[jira] [Commented] (WAGON-449) CLIENT not changed after setting PoolingHttpClientConnectionManager

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/WAGON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114226#comment-15114226
 ] 

Hudson commented on WAGON-449:
--

UNSTABLE: Integrated in maven-wagon #1302 (See 
[https://builds.apache.org/job/maven-wagon/1302/])
[WAGON-449] Use new connection manager when set (jeannikl: rev 
4f42503a9aa6d6c03bfdf2562cb86eec194b70dd)
* 
wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
* pom.xml


> CLIENT not changed after setting PoolingHttpClientConnectionManager
> ---
>
> Key: WAGON-449
> URL: https://issues.apache.org/jira/browse/WAGON-449
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-http
>Affects Versions: 2.8, 2.9, 2.10
>Reporter: Jean Niklas L'orange
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.11
>
>
> The AbstractHttpClientWagon class statically creates both a 
> PoolingHttpClientConnectionManager and a client that uses said connection 
> manager. This is fine, had it not been the case that the client itself is a 
> final field and is never updated.
> Thus, using {{setPoolingHttpClientConnectionManager}} has no effect as the 
> client is based on the PoolingHttpClientConnectionManager created at startup. 
> This affects users that e.g. may want to change the SSLContext to support 
> self-signed certificates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (WAGON-449) CLIENT not changed after setting PoolingHttpClientConnectionManager

2016-01-23 Thread *$^¨%`£

 [ 
https://issues.apache.org/jira/browse/WAGON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy (*$^¨%`£) closed WAGON-449.

Resolution: Fixed

pr merged
Thanks!

> CLIENT not changed after setting PoolingHttpClientConnectionManager
> ---
>
> Key: WAGON-449
> URL: https://issues.apache.org/jira/browse/WAGON-449
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-http
>Affects Versions: 2.8, 2.9, 2.10
>Reporter: Jean Niklas L'orange
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.11
>
>
> The AbstractHttpClientWagon class statically creates both a 
> PoolingHttpClientConnectionManager and a client that uses said connection 
> manager. This is fine, had it not been the case that the client itself is a 
> final field and is never updated.
> Thus, using {{setPoolingHttpClientConnectionManager}} has no effect as the 
> client is based on the PoolingHttpClientConnectionManager created at startup. 
> This affects users that e.g. may want to change the SSLContext to support 
> self-signed certificates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WAGON-449) CLIENT not changed after setting PoolingHttpClientConnectionManager

2016-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WAGON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114221#comment-15114221
 ] 

ASF GitHub Bot commented on WAGON-449:
--

Github user asfgit closed the pull request at:

https://github.com/apache/maven-wagon/pull/21


> CLIENT not changed after setting PoolingHttpClientConnectionManager
> ---
>
> Key: WAGON-449
> URL: https://issues.apache.org/jira/browse/WAGON-449
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-http
>Affects Versions: 2.8, 2.9, 2.10
>Reporter: Jean Niklas L'orange
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.11
>
>
> The AbstractHttpClientWagon class statically creates both a 
> PoolingHttpClientConnectionManager and a client that uses said connection 
> manager. This is fine, had it not been the case that the client itself is a 
> final field and is never updated.
> Thus, using {{setPoolingHttpClientConnectionManager}} has no effect as the 
> client is based on the PoolingHttpClientConnectionManager created at startup. 
> This affects users that e.g. may want to change the SSLContext to support 
> self-signed certificates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (WAGON-449) CLIENT not changed after setting PoolingHttpClientConnectionManager

2016-01-23 Thread *$^¨%`£

 [ 
https://issues.apache.org/jira/browse/WAGON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy (*$^¨%`£) updated WAGON-449:
-
Fix Version/s: 2.11

> CLIENT not changed after setting PoolingHttpClientConnectionManager
> ---
>
> Key: WAGON-449
> URL: https://issues.apache.org/jira/browse/WAGON-449
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-http
>Affects Versions: 2.8, 2.9, 2.10
>Reporter: Jean Niklas L'orange
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 2.11
>
>
> The AbstractHttpClientWagon class statically creates both a 
> PoolingHttpClientConnectionManager and a client that uses said connection 
> manager. This is fine, had it not been the case that the client itself is a 
> final field and is never updated.
> Thus, using {{setPoolingHttpClientConnectionManager}} has no effect as the 
> client is based on the PoolingHttpClientConnectionManager created at startup. 
> This affects users that e.g. may want to change the SSLContext to support 
> self-signed certificates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (WAGON-449) CLIENT not changed after setting PoolingHttpClientConnectionManager

2016-01-23 Thread *$^¨%`£

 [ 
https://issues.apache.org/jira/browse/WAGON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy (*$^¨%`£) reassigned WAGON-449:


Assignee: Olivier Lamy (*$^¨%`£)

> CLIENT not changed after setting PoolingHttpClientConnectionManager
> ---
>
> Key: WAGON-449
> URL: https://issues.apache.org/jira/browse/WAGON-449
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-http
>Affects Versions: 2.8, 2.9, 2.10
>Reporter: Jean Niklas L'orange
>Assignee: Olivier Lamy (*$^¨%`£)
>
> The AbstractHttpClientWagon class statically creates both a 
> PoolingHttpClientConnectionManager and a client that uses said connection 
> manager. This is fine, had it not been the case that the client itself is a 
> final field and is never updated.
> Thus, using {{setPoolingHttpClientConnectionManager}} has no effect as the 
> client is based on the PoolingHttpClientConnectionManager created at startup. 
> This affects users that e.g. may want to change the SSLContext to support 
> self-signed certificates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MCOMPILER-203) Allow compiler-plugin to specify annotation processor dependencies

2016-01-23 Thread Thomas Broyer (JIRA)

[ 
https://issues.apache.org/jira/browse/MCOMPILER-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114055#comment-15114055
 ] 

Thomas Broyer commented on MCOMPILER-203:
-

FWIW, one big issue with this (but which is not imputable to the plugin, but to 
Maven's design), is that dependencies declared in the 
`annotationProcessorPaths` don't participate in the Maven execution graph 
analysis, such that Maven cannot guarantee that within a reactor build 
annotation processors will actually be built before the modules that use them.

> Allow compiler-plugin to specify annotation processor dependencies
> --
>
> Key: MCOMPILER-203
> URL: https://issues.apache.org/jira/browse/MCOMPILER-203
> Project: Maven Compiler Plugin
>  Issue Type: New Feature
>Affects Versions: 2.3.2, 3.1
> Environment: Java 6+
>Reporter: David M. Lloyd
>Assignee: Andreas Gudian
> Fix For: 3.5
>
>
> Right now the status quo for annotation processor artifacts requires one of 
> two actions:
> # Use an external plugin for annotation processing
> # Put the annotation processor in as a dependency with {{provided}} scope
> The former is suboptimal because the external plugins are clunky and 
> ill-supported, and inflexible/hard to use.  The latter is suboptimal because 
> it is often the case that you do not want to leak annotation processor 
> classes on to the application class path.
> It should be possible to add annotation processor dependency artifacts to the 
> compiler plugin configuration such that they are recognized by the annotation 
> processing search algorithm of the compiler, but they do not actually appear 
> on the compilation class path.  Ideally they would also be isolated from one 
> another (dependency graphs and all), but that's more of a "nice to have".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-761) Enable deployed site folder to be configurable, eg $project.version not just "staging"

2016-01-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MSITE-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114006#comment-15114006
 ] 

Hervé Boutemy commented on MSITE-761:
-

did you have a look at stagingSiteURL parameter:
http://maven.apache.org/plugins/maven-site-plugin/stage-deploy-mojo.html#stagingSiteURL
?
why doesn't it fit your needs?

> Enable deployed site folder to be configurable, eg $project.version not just 
> "staging"
> --
>
> Key: MSITE-761
> URL: https://issues.apache.org/jira/browse/MSITE-761
> Project: Maven Site Plugin
>  Issue Type: Improvement
>  Components: site:stage(-deploy)
>Affects Versions: 3.4
>Reporter: Andy Brook
>
> The site deploy, when configured with a pom distributionManagement url zips 
> up the local "staging" (hard-coded within the site plugin?) folder and 
> unpacks it at the given URL.  As the folder I nominated above is the 
> _project_ folder, I want the target folder to be the current 
> $\{project.version} but there doesn't seem a way to make it do that.  As a 
> result, every time I build, I clobber the current version.  I track many 
> branches, and versions, and want to have access to them all.
> I'd like to add site configuration param like:
> {noformat}
> ${project.version}
> {noformat}
> So that a version 1.2.3 site-deploy ends up as:
> {noformat}
> scp://webserver/var/www/html/product/1.2.3
> {noformat}
> MSITE-617 could possibly do this, however, this is a very specific slice of 
> that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-537) NullPointerException parsing table cell with single space

2016-01-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114003#comment-15114003
 ] 

Hervé Boutemy commented on DOXIA-537:
-

thank you Robert

> NullPointerException parsing table cell with single space
> -
>
> Key: DOXIA-537
> URL: https://issues.apache.org/jira/browse/DOXIA-537
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Confluence
>Affects Versions: 1.6
>Reporter: Robin Roos
>Assignee: Robert Scholte
> Fix For: 1.7
>
>
> I have chosen to use Confluence format to generate my maven site, primarily 
> because of good table support.
> I have found that doxia-module-confluence falls over with a 
> NullPointerException if an empty cell is represented as a single space.
> Confluence tables usually require this empty space, or they collapse the cell 
> to be non-existant.
> Information pertaining to this failure is below.
> Let me know what more I can usefully provide.
> Kind regards, Robin.
> File: src/site/confluence/tables.confluence
> Here is a 3 column table with headers, one row, and data in every column:
> {noformat}||One||Two||Three||
> |1|2|3|{noformat}
> Now there is no data in column Two
> {noformat}||One||Two||Three||
> |1||3|{noformat}
> Now there is a space in column Two 
> {noformat}||One||Two||Three||
> |1| |3|{noformat}
> pom.xml excerpt
> {code:xml}
> ...
> 
> ...
> 
> org.apache.maven.plugins
> maven-site-plugin
> 3.4
> 
> 
> org.apache.maven.doxia
> doxia-module-confluence
> 1.6
> 
> 
> org.apache.maven.doxia
> doxia-module-markdown
> 1.6
> 
> 
> 
> 
> {code}
> {noformat}mvn -X clean site
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
> fitnesse-calypso: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null: ParseException: NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on 
> project fitnesse-calypso: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null
> at 
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:146)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at 
> org

[jira] [Commented] (DOXIASITETOOLS-93) request-scoped default Velocity Tools are not accessible

2016-01-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114004#comment-15114004
 ] 

Hervé Boutemy commented on DOXIASITETOOLS-93:
-

one week, no problem: no strong hurry
just a lot of work that I want to release now to move on :)

> request-scoped default Velocity Tools are not accessible
> 
>
> Key: DOXIASITETOOLS-93
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.6
>Reporter: Hervé Boutemy
> Fix For: 1.7
>
>
> only application scoped are available: $esc, ...
> nut not $context, for example
> see 
> http://svn.apache.org/viewvc/velocity/tools/tags/2.0/src/main/java/org/apache/velocity/tools/generic/tools.xml?view=markup



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-508) Format characters are interpreted in monospaced text

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113951#comment-15113951
 ] 

Hudson commented on DOXIA-508:
--

SUCCESS: Integrated in doxia-all #227 (See 
[https://builds.apache.org/job/doxia-all/227/])
[DOXIA-508] Format characters are interpreted in monospaced text
Patch provided by Mark Schenk, review and adjusted by Robert Scholte 
(rfscholte: [http://svn.apache.org/viewvc/?view=rev&rev=1726451])
* 
./doxia/doxia-modules/doxia-module-confluence/src/main/java/org/apache/maven/doxia/module/confluence/parser/ChildBlocksBuilder.java
* 
./doxia/doxia-modules/doxia-module-confluence/src/test/java/org/apache/maven/doxia/module/confluence/ConfluenceParserTest.java
* 
./doxia/doxia-modules/doxia-module-confluence/src/test/resources/nested-format.confluence


> Format characters are interpreted in monospaced text
> 
>
> Key: DOXIA-508
> URL: https://issues.apache.org/jira/browse/DOXIA-508
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Confluence
>Affects Versions: 1.5
> Environment: Maven site generation
>Reporter: Mark Schenk
>Assignee: Robert Scholte
>Priority: Critical
> Fix For: 1.7
>
> Attachments: Patch_DOXIA-508_2_trunk.patch, 
> Patch_DOXIA-508_trunk.patch
>
>
> When I have the following text within my site documentation 
> monospaced-text-with-hyphens it is formatted as follows 
> -text-{{monospacedwithhyphens}}
> What is expected is {{monospaced-text-with-hyphens}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (DOXIA-508) Format characters are interpreted in monospaced text

2016-01-23 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed DOXIA-508.

   Resolution: Fixed
 Assignee: Robert Scholte
Fix Version/s: 1.7

Fixed in [r1726451|http://svn.apache.org/r1726451]
Thanks for the patch. Tests were very helpful. I've decided not to go for the 
if-monospace-else-switch-case construction, I've kept it all inside the cases, 
combining it with the insideLink flag when possible.

> Format characters are interpreted in monospaced text
> 
>
> Key: DOXIA-508
> URL: https://issues.apache.org/jira/browse/DOXIA-508
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Confluence
>Affects Versions: 1.5
> Environment: Maven site generation
>Reporter: Mark Schenk
>Assignee: Robert Scholte
>Priority: Critical
> Fix For: 1.7
>
> Attachments: Patch_DOXIA-508_2_trunk.patch, 
> Patch_DOXIA-508_trunk.patch
>
>
> When I have the following text within my site documentation 
> monospaced-text-with-hyphens it is formatted as follows 
> -text-{{monospacedwithhyphens}}
> What is expected is {{monospaced-text-with-hyphens}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-537) NullPointerException parsing table cell with single space

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113940#comment-15113940
 ] 

Hudson commented on DOXIA-537:
--

SUCCESS: Integrated in doxia-all #226 (See 
[https://builds.apache.org/job/doxia-all/226/])
[DOXIA-537] NullPointerException parsing table cell with single space 
(rfscholte: [http://svn.apache.org/viewvc/?view=rev&rev=1726441])
* 
./doxia/doxia-modules/doxia-module-confluence/src/main/java/org/apache/maven/doxia/module/confluence/parser/table/TableBlockParser.java
* 
./doxia/doxia-modules/doxia-module-confluence/src/test/java/org/apache/maven/doxia/module/confluence/ConfluenceParserTest.java
* 
./doxia/doxia-modules/doxia-module-confluence/src/test/resources/table.confluence


> NullPointerException parsing table cell with single space
> -
>
> Key: DOXIA-537
> URL: https://issues.apache.org/jira/browse/DOXIA-537
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Confluence
>Affects Versions: 1.6
>Reporter: Robin Roos
>Assignee: Robert Scholte
> Fix For: 1.7
>
>
> I have chosen to use Confluence format to generate my maven site, primarily 
> because of good table support.
> I have found that doxia-module-confluence falls over with a 
> NullPointerException if an empty cell is represented as a single space.
> Confluence tables usually require this empty space, or they collapse the cell 
> to be non-existant.
> Information pertaining to this failure is below.
> Let me know what more I can usefully provide.
> Kind regards, Robin.
> File: src/site/confluence/tables.confluence
> Here is a 3 column table with headers, one row, and data in every column:
> {noformat}||One||Two||Three||
> |1|2|3|{noformat}
> Now there is no data in column Two
> {noformat}||One||Two||Three||
> |1||3|{noformat}
> Now there is a space in column Two 
> {noformat}||One||Two||Three||
> |1| |3|{noformat}
> pom.xml excerpt
> {code:xml}
> ...
> 
> ...
> 
> org.apache.maven.plugins
> maven-site-plugin
> 3.4
> 
> 
> org.apache.maven.doxia
> doxia-module-confluence
> 1.6
> 
> 
> org.apache.maven.doxia
> doxia-module-markdown
> 1.6
> 
> 
> 
> 
> {code}
> {noformat}mvn -X clean site
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
> fitnesse-calypso: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null: ParseException: NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on 
> project fitnesse-calypso: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at 
> org.codehaus.plex

[jira] [Closed] (DOXIA-537) NullPointerException parsing table cell with single space

2016-01-23 Thread Robert Scholte (JIRA)

 [ 
https://issues.apache.org/jira/browse/DOXIA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed DOXIA-537.

   Resolution: Fixed
 Assignee: Robert Scholte
Fix Version/s: 1.7

Fixed in [r1726441|http://svn.apache.org/r1726441]

> NullPointerException parsing table cell with single space
> -
>
> Key: DOXIA-537
> URL: https://issues.apache.org/jira/browse/DOXIA-537
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Confluence
>Affects Versions: 1.6
>Reporter: Robin Roos
>Assignee: Robert Scholte
> Fix For: 1.7
>
>
> I have chosen to use Confluence format to generate my maven site, primarily 
> because of good table support.
> I have found that doxia-module-confluence falls over with a 
> NullPointerException if an empty cell is represented as a single space.
> Confluence tables usually require this empty space, or they collapse the cell 
> to be non-existant.
> Information pertaining to this failure is below.
> Let me know what more I can usefully provide.
> Kind regards, Robin.
> File: src/site/confluence/tables.confluence
> Here is a 3 column table with headers, one row, and data in every column:
> {noformat}||One||Two||Three||
> |1|2|3|{noformat}
> Now there is no data in column Two
> {noformat}||One||Two||Three||
> |1||3|{noformat}
> Now there is a space in column Two 
> {noformat}||One||Two||Three||
> |1| |3|{noformat}
> pom.xml excerpt
> {code:xml}
> ...
> 
> ...
> 
> org.apache.maven.plugins
> maven-site-plugin
> 3.4
> 
> 
> org.apache.maven.doxia
> doxia-module-confluence
> 1.6
> 
> 
> org.apache.maven.doxia
> doxia-module-markdown
> 1.6
> 
> 
> 
> 
> {code}
> {noformat}mvn -X clean site
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
> fitnesse-calypso: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null: ParseException: NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on 
> project fitnesse-calypso: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null
> at 
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:146)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeM

[jira] [Commented] (DOXIASITETOOLS-93) request-scoped default Velocity Tools are not accessible

2016-01-23 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113889#comment-15113889
 ] 

Michael Osipov commented on DOXIASITETOOLS-93:
--

Are you in a hurry to release 1.7? I won't have a look before next week.

> request-scoped default Velocity Tools are not accessible
> 
>
> Key: DOXIASITETOOLS-93
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.6
>Reporter: Hervé Boutemy
> Fix For: 1.7
>
>
> only application scoped are available: $esc, ...
> nut not $context, for example
> see 
> http://svn.apache.org/viewvc/velocity/tools/tags/2.0/src/main/java/org/apache/velocity/tools/generic/tools.xml?view=markup



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIASITETOOLS-93) request-scoped default Velocity Tools are not accessible

2016-01-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113871#comment-15113871
 ] 

Hervé Boutemy commented on DOXIASITETOOLS-93:
-

is there any chance to fix this issue before 1.7 release?

> request-scoped default Velocity Tools are not accessible
> 
>
> Key: DOXIASITETOOLS-93
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Project: Maven Doxia Sitetools
>  Issue Type: Bug
>  Components: Site renderer
>Affects Versions: 1.6
>Reporter: Hervé Boutemy
> Fix For: 1.7
>
>
> only application scoped are available: $esc, ...
> nut not $context, for example
> see 
> http://svn.apache.org/viewvc/velocity/tools/tags/2.0/src/main/java/org/apache/velocity/tools/generic/tools.xml?view=markup



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-532) Update handling of comments for Server Side Includes (ie comments starting with #)

2016-01-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113868#comment-15113868
 ] 

Hervé Boutemy commented on DOXIA-532:
-

Christian,

there is a conflict with DOXIASITETOOLS-146/DOXIA-482

what about creating a macro for SSI?
since macros are now supported in most Doxia markups

> Update handling of comments for Server Side Includes (ie comments starting 
> with #)
> --
>
> Key: DOXIA-532
> URL: https://issues.apache.org/jira/browse/DOXIA-532
> Project: Maven Doxia
>  Issue Type: New Feature
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Minor
> Fix For: 1.7
>
>
> Support for server side includes.
> comments starting with a '#' character represent SSI expressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (DOXIA-506) move classes from doxia-core in sink package (same as doxia-sink-api) to dedicated sink.impl package

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy closed DOXIA-506.
---
Resolution: Fixed
  Assignee: Hervé Boutemy

> move classes from doxia-core in sink package (same as doxia-sink-api) to 
> dedicated sink.impl package
> 
>
> Key: DOXIA-506
> URL: https://issues.apache.org/jira/browse/DOXIA-506
> Project: Maven Doxia
>  Issue Type: Wish
>  Components: Core
>Affects Versions: 1.5
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
> Fix For: 1.7
>
>
> doxia-sink-api "owns" o.a.m.doxia.sink package: 
> http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-sink-api/apidocs/index.html
> there shouldn't be classes from doxia-core in the same package: 
> http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-core/apidocs/org/apache/maven/doxia/sink/package-summary.html
> moving these classes to an "impl" subpackage will make things clearer, while 
> being only internal between doxia-core and modules



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-537) NullPointerException parsing table cell with single space

2016-01-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113861#comment-15113861
 ] 

Hervé Boutemy commented on DOXIA-537:
-

I had a look: yes, the issue is easy to reproduce

then I had a look at parsing code: sorry, I can't do anything

> NullPointerException parsing table cell with single space
> -
>
> Key: DOXIA-537
> URL: https://issues.apache.org/jira/browse/DOXIA-537
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Confluence
>Affects Versions: 1.6
>Reporter: Robin Roos
>
> I have chosen to use Confluence format to generate my maven site, primarily 
> because of good table support.
> I have found that doxia-module-confluence falls over with a 
> NullPointerException if an empty cell is represented as a single space.
> Confluence tables usually require this empty space, or they collapse the cell 
> to be non-existant.
> Information pertaining to this failure is below.
> Let me know what more I can usefully provide.
> Kind regards, Robin.
> File: src/site/confluence/tables.confluence
> Here is a 3 column table with headers, one row, and data in every column:
> {noformat}||One||Two||Three||
> |1|2|3|{noformat}
> Now there is no data in column Two
> {noformat}||One||Two||Three||
> |1||3|{noformat}
> Now there is a space in column Two 
> {noformat}||One||Two||Three||
> |1| |3|{noformat}
> pom.xml excerpt
> {code:xml}
> ...
> 
> ...
> 
> org.apache.maven.plugins
> maven-site-plugin
> 3.4
> 
> 
> org.apache.maven.doxia
> doxia-module-confluence
> 1.6
> 
> 
> org.apache.maven.doxia
> doxia-module-markdown
> 1.6
> 
> 
> 
> 
> {code}
> {noformat}mvn -X clean site
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
> fitnesse-calypso: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null: ParseException: NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on 
> project fitnesse-calypso: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error parsing 
> '/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
> line [15] null
> at 
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:146)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.

[jira] [Commented] (DOXIA-506) move classes from doxia-core in sink package (same as doxia-sink-api) to dedicated sink.impl package

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113854#comment-15113854
 ] 

Hudson commented on DOXIA-506:
--

SUCCESS: Integrated in doxia-all #225 (See 
[https://builds.apache.org/job/doxia-all/225/])
[DOXIA-506] fixed test after change (hboutemy: 
[http://svn.apache.org/viewvc/?view=rev&rev=1726413])
* 
./doxia-sitetools/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/SkinResourceLoaderTest.java


> move classes from doxia-core in sink package (same as doxia-sink-api) to 
> dedicated sink.impl package
> 
>
> Key: DOXIA-506
> URL: https://issues.apache.org/jira/browse/DOXIA-506
> Project: Maven Doxia
>  Issue Type: Wish
>  Components: Core
>Affects Versions: 1.5
>Reporter: Hervé Boutemy
> Fix For: 1.7
>
>
> doxia-sink-api "owns" o.a.m.doxia.sink package: 
> http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-sink-api/apidocs/index.html
> there shouldn't be classes from doxia-core in the same package: 
> http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-core/apidocs/org/apache/maven/doxia/sink/package-summary.html
> moving these classes to an "impl" subpackage will make things clearer, while 
> being only internal between doxia-core and modules



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIA-537) NullPointerException parsing table cell with single space

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated DOXIA-537:

Description: 
I have chosen to use Confluence format to generate my maven site, primarily 
because of good table support.

I have found that doxia-module-confluence falls over with a 
NullPointerException if an empty cell is represented as a single space.

Confluence tables usually require this empty space, or they collapse the cell 
to be non-existant.

Information pertaining to this failure is below.

Let me know what more I can usefully provide.

Kind regards, Robin.



File: src/site/confluence/tables.confluence

Here is a 3 column table with headers, one row, and data in every column:

{noformat}||One||Two||Three||
|1|2|3|{noformat}

Now there is no data in column Two

{noformat}||One||Two||Three||
|1||3|{noformat}

Now there is a space in column Two 

{noformat}||One||Two||Three||
|1| |3|{noformat}


pom.xml excerpt

{code:xml}
...

...

org.apache.maven.plugins
maven-site-plugin
3.4


org.apache.maven.doxia
doxia-module-confluence
1.6


org.apache.maven.doxia
doxia-module-markdown
1.6




{code}


{noformat}mvn -X clean site


[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
fitnesse-calypso: Error parsing 
'/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
line [15] null: ParseException: NullPointerException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
fitnesse-calypso: Error parsing 
'/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
line [15] null
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error parsing 
'/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
line [15] null
at 
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:146)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
... 20 more
Caused by: org.apache.maven.doxia.siterenderer.RendererException: Error parsing 
'/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
line [15] null
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:406)
at 
org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer.renderDocument(DoxiaDocumentRenderer.java:51)
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(Default

[jira] [Updated] (DOXIA-537) NullPointerException parsing table cell with single space

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated DOXIA-537:

Description: 
I have chosen to use Confluence format to generate my maven site, primarily 
because of good table support.

I have found that doxia-module-confluence falls over with a 
NullPointerException if an empty cell is represented as a single space.

Confluence tables usually require this empty space, or they collapse the cell 
to be non-existant.

Information pertaining to this failure is below.

Let me know what more I can usefully provide.

Kind regards, Robin.



File: src/site/confluence/tables.confluence

Here is a 3 column table with headers, one row, and data in every column:

||One||Two||Three||
|1|2|3|

Now there is no data in column Two

||One||Two||Three||
|1||3|

Now there is a space in column Two 

||One||Two||Three||
|1| |3|


pom.xml excerpt

{code:xml}
...

...

org.apache.maven.plugins
maven-site-plugin
3.4


org.apache.maven.doxia
doxia-module-confluence
1.6


org.apache.maven.doxia
doxia-module-markdown
1.6




{code}


{noformat}mvn -X clean site


[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
fitnesse-calypso: Error parsing 
'/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
line [15] null: ParseException: NullPointerException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
fitnesse-calypso: Error parsing 
'/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
line [15] null
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error parsing 
'/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
line [15] null
at 
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:146)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
... 20 more
Caused by: org.apache.maven.doxia.siterenderer.RendererException: Error parsing 
'/Users/robin/tmp3/fitnesse-calypso/src/site/confluence/tables.confluence': 
line [15] null
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:406)
at 
org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer.renderDocument(DoxiaDocumentRenderer.java:51)
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129)
at 
org.apache.maven.plugins.

[jira] [Commented] (DOXIA-539) language element of code block is ignored

2016-01-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113843#comment-15113843
 ] 

Hervé Boutemy commented on DOXIA-539:
-

Honestly, I fear this issue will never be worked on: syntax highlighting is not 
done at Doxia level at all, but at skin level, with Doxia not passing any info

if you expect to work yourself on code, don't hesitate
but if you expect someone else to do the code, it won't be me :)

> language element of code block is ignored
> -
>
> Key: DOXIA-539
> URL: https://issues.apache.org/jira/browse/DOXIA-539
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Confluence
>Reporter: Robin Roos
>
> In Confluence markup, the "code" block takes an attribute "language".  The 
> default language is java.
> It appears that doxia-module-confluence ignores attempts to set the language 
> on a code block (e.g. code:language=none) and always uses Java colour 
> highlighting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-535) Support .markdown file extension (in addition to current .md)

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113839#comment-15113839
 ] 

Hudson commented on DOXIA-535:
--

FAILURE: Integrated in doxia-all #224 (See 
[https://builds.apache.org/job/doxia-all/224/])
[DOXIA-535] added support for .markdown file extension (in addition to current 
.md) (hboutemy: [http://svn.apache.org/viewvc/?view=rev&rev=1726412])
* 
./doxia/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownParserModule.java


> Support .markdown file extension (in addition to current .md)
> -
>
> Key: DOXIA-535
> URL: https://issues.apache.org/jira/browse/DOXIA-535
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - Markdown
>Reporter: Vratko Polak
> Fix For: 1.7
>
>
> Currently, "md" is the only extension identifying markdown files for Doxia. 
> There are many [0] extensions identifying markdown. GitHub uses "md", but it 
> is also interpreting markdown somewhat differently [1]. Wikipedia article [2] 
> offers "markdown" as an alternative extension, citing [3] the author of 
> markdown, who agrees [4] with proponents of this extension.
> Please, add a support for "markdown" extension;
> possibly keeping it for standard markdown and leaving "md" for the GitHub 
> style.
> [0] https://gist.github.com/schwa/8311179
> [1] https://help.github.com/articles/github-flavored-markdown
> [2] https://en.wikipedia.org/wiki/Markdown
> [3] http://daringfireball.net/linked/2014/01/08/markdown-extension
> [4] http://hiltmon.com/blog/2012/03/07/the-markdown-file-extension/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-506) move classes from doxia-core in sink package (same as doxia-sink-api) to dedicated sink.impl package

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113838#comment-15113838
 ] 

Hudson commented on DOXIA-506:
--

FAILURE: Integrated in doxia-all #224 (See 
[https://builds.apache.org/job/doxia-all/224/])
[DOXIA-506] moved classes from doxia-core in sink package (same as 
doxia-sink-api) to dedicated sink.impl package (hboutemy: 
[http://svn.apache.org/viewvc/?view=rev&rev=1726411])
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/index/IndexingSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/macro/AbstractMacro.java
* ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/macro/EchoMacro.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/macro/snippet/SnippetMacro.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/parser/XhtmlBaseParser.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractBinarySinkFactory.java
* ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractTextSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractTextSinkFactory.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractXmlSinkFactory.java
* ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/PipelineSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/RandomAccessSink.java
* ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/SinkAdapter.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/SinkEventAttributeSet.java
* ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/SinkUtils.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/XhtmlBaseSink.java
* ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractBinarySinkFactory.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractTextSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractTextSinkFactory.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractXmlSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/AbstractXmlSinkFactory.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/PipelineSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/RandomAccessSink.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/SinkAdapter.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/SinkEventAttributeSet.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/SinkUtils.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/XhtmlBaseSink.java
* ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/util/DoxiaUtils.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/macro/EchoMacroTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/macro/SwfMacroTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/macro/snippet/SnippetMacroTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/macro/toc/TocMacroTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/module/AbstractIdentityTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/parser/AbstractParserTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/parser/AbstractParserTestCase.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/parser/XhtmlBaseParserTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/AbstractSinkTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/AbstractSinkTestCase.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/AbstractXmlSinkTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/RandomAccessSinkTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/SinkAdapterTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/SinkEventAttributeSetTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/SinkEventElement.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/SinkEventTestingSink.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/SinkTestDocument.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/SinkUtilsTest.java
* 
./doxia/doxia-core/src/test/java/org/apache/maven/doxia/sink/TestAbstractSink.java
* ./doxia/doxia-core/

[jira] [Updated] (DOXIA-535) Support .markdown file extension (in addition to current .md)

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated DOXIA-535:

Fix Version/s: 1.7

> Support .markdown file extension (in addition to current .md)
> -
>
> Key: DOXIA-535
> URL: https://issues.apache.org/jira/browse/DOXIA-535
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - Markdown
>Reporter: Vratko Polak
> Fix For: 1.7
>
>
> Currently, "md" is the only extension identifying markdown files for Doxia. 
> There are many [0] extensions identifying markdown. GitHub uses "md", but it 
> is also interpreting markdown somewhat differently [1]. Wikipedia article [2] 
> offers "markdown" as an alternative extension, citing [3] the author of 
> markdown, who agrees [4] with proponents of this extension.
> Please, add a support for "markdown" extension;
> possibly keeping it for standard markdown and leaving "md" for the GitHub 
> style.
> [0] https://gist.github.com/schwa/8311179
> [1] https://help.github.com/articles/github-flavored-markdown
> [2] https://en.wikipedia.org/wiki/Markdown
> [3] http://daringfireball.net/linked/2014/01/08/markdown-extension
> [4] http://hiltmon.com/blog/2012/03/07/the-markdown-file-extension/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIA-535) Support .markdown file extension (in addition to current .md)

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated DOXIA-535:

Summary: Support .markdown file extension (in addition to current .md)  
(was: Support .markdown extension)

> Support .markdown file extension (in addition to current .md)
> -
>
> Key: DOXIA-535
> URL: https://issues.apache.org/jira/browse/DOXIA-535
> Project: Maven Doxia
>  Issue Type: New Feature
>  Components: Module - Markdown
>Reporter: Vratko Polak
>
> Currently, "md" is the only extension identifying markdown files for Doxia. 
> There are many [0] extensions identifying markdown. GitHub uses "md", but it 
> is also interpreting markdown somewhat differently [1]. Wikipedia article [2] 
> offers "markdown" as an alternative extension, citing [3] the author of 
> markdown, who agrees [4] with proponents of this extension.
> Please, add a support for "markdown" extension;
> possibly keeping it for standard markdown and leaving "md" for the GitHub 
> style.
> [0] https://gist.github.com/schwa/8311179
> [1] https://help.github.com/articles/github-flavored-markdown
> [2] https://en.wikipedia.org/wiki/Markdown
> [3] http://daringfireball.net/linked/2014/01/08/markdown-extension
> [4] http://hiltmon.com/blog/2012/03/07/the-markdown-file-extension/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIA-506) move classes from doxia-core in sink package (same as doxia-sink-api) to dedicated sink.impl package

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated DOXIA-506:

Fix Version/s: (was: 2.0)
   1.7

> move classes from doxia-core in sink package (same as doxia-sink-api) to 
> dedicated sink.impl package
> 
>
> Key: DOXIA-506
> URL: https://issues.apache.org/jira/browse/DOXIA-506
> Project: Maven Doxia
>  Issue Type: Wish
>  Components: Core
>Affects Versions: 1.5
>Reporter: Hervé Boutemy
> Fix For: 1.7
>
>
> doxia-sink-api "owns" o.a.m.doxia.sink package: 
> http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-sink-api/apidocs/index.html
> there shouldn't be classes from doxia-core in the same package: 
> http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-core/apidocs/org/apache/maven/doxia/sink/package-summary.html
> moving these classes to an "impl" subpackage will make things clearer, while 
> being only internal between doxia-core and modules



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIA-525) Rendering links in xdocs breaks them

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated DOXIA-525:

Component/s: Module - Xdoc

> Rendering links in xdocs breaks them
> 
>
> Key: DOXIA-525
> URL: https://issues.apache.org/jira/browse/DOXIA-525
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Xdoc
>Affects Versions: 1.6
>Reporter: Aleksey  Nesterenko
>
> Generating linkcheck report on our project has encountered some problems.
> In final report lots of links are marked as "invalid"
> Report generated on test project:
> http://alexkravin.github.io/testproject/writingchecks.html
> For example try to follow link  processFiltered(java.io.File, java.util.List)
> Look to the URL:
> link looks like 
> AbstractFileSetCheck.html#processFilteredjava.io.File_java.util.List
> Rendering link in this velocity template breaks it:
> https://github.com/alexkravin/linkstest/blob/master/src/xdocs/writingchecks.xml.vm#L13
> brackets and space in the link are broken, the similar problem was specified 
> here
> https://jira.codehaus.org/browse/DOXIA-397
> but in velocity template developer can't put '##' - it would fail the 
> rendering with an error:
> [ERROR] Error parsing /home/asus/sources/links/src/xdocs/writingchecks.xml.vm 
> as a velocity template, using as text.
> Steps of reproducing my problem (for simplifying I'm pointing on my test 
> project):
> 1) git clone g...@github.com:alexkravin/linkstest.git && cd linkstest/
> 2) mvn clean site
> 3) Open target/site/writingchecks.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIA-482) add an API to avoid translating APT source comments into output comments

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated DOXIA-482:

Summary: add an API to avoid translating APT source comments into output 
comments  (was: don't translate APT source comments into output comments)

> add an API to avoid translating APT source comments into output comments
> 
>
> Key: DOXIA-482
> URL: https://issues.apache.org/jira/browse/DOXIA-482
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Apt
>Affects Versions: 1.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 1.7
>
> Attachments: DOXIA-482.patch
>
>
> I have defined this as the very first lines in my apt file:
> {code}
> ~~ Copyright 2012 Michael Osipov
> ~~
> ~~ Licensed under the Apache License, Version 2.0 (the "License");
> ~~ you may not use this file except in compliance with the License.
> ~~ You may obtain a copy of the License at
> ~~
> ~~ http://www.apache.org/licenses/LICENSE-2.0
> ~~
> ~~ Unless required by applicable law or agreed to in writing, software
> ~~ distributed under the License is distributed on an "AS IS" BASIS,
> ~~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> ~~ See the License for the specific language governing permissions and
> ~~ limitations under the License.
> ~~ $Id$
> {code}
> This is unfortunately translated in
> {{/html/body/div/div/div#bodyColumn}} to a line-by-line comment
> {noformat}
> 
> {noformat}
> This, of course, is somewhat useless. I'd rather would have split comments 
> like in JSP or Velocity. Template comments are left out and HTML comments 
> remain untouched.
> I obviously do not need the ASL somewhere in the middle of by page as comment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIASITETOOLS-146) don't translate APT source comments into output comments

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113808#comment-15113808
 ] 

Hudson commented on DOXIASITETOOLS-146:
---

SUCCESS: Integrated in doxia-all #223 (See 
[https://builds.apache.org/job/doxia-all/223/])
[DOXIASITETOOLS-146] don't render source markup comments in site's output HTML 
(hboutemy: [http://svn.apache.org/viewvc/?view=rev&rev=1726408])
* 
./doxia-sitetools/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
* 
./doxia-sitetools/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/CommentsVerifier.java
* 
./doxia-sitetools/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
* ./doxia-sitetools/doxia-site-renderer/src/test/resources/site/apt/apt.apt
* ./doxia-sitetools/doxia-site-renderer/src/test/resources/site/xdoc/misc.xml


> don't translate APT source comments into output comments
> 
>
> Key: DOXIASITETOOLS-146
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-146
> Project: Maven Doxia Sitetools
>  Issue Type: Wish
>  Components: Site renderer
>Affects Versions: 1.6
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
> Fix For: 1.7
>
>
> see DOXIA-482: when Doxia is used in a site, parsing markup and translating 
> it to HTML, comments in source markup are not really meant for output site



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-482) don't translate APT source comments into output comments

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113809#comment-15113809
 ] 

Hudson commented on DOXIA-482:
--

SUCCESS: Integrated in doxia-all #223 (See 
[https://builds.apache.org/job/doxia-all/223/])
[DOXIA-482] added an API to define if comments from source markup are emitted 
as Doxia comment events (hboutemy: 
[http://svn.apache.org/viewvc/?view=rev&rev=1726407])
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java
* ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/parser/Parser.java
* 
./doxia/doxia-core/src/main/java/org/apache/maven/doxia/parser/XhtmlBaseParser.java
* 
./doxia/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptParser.java
* 
./doxia/doxia-modules/doxia-module-docbook-simple/src/main/java/org/apache/maven/doxia/module/docbook/DocBookParser.java
* 
./doxia/doxia-modules/doxia-module-fml/src/main/java/org/apache/maven/doxia/module/fml/FmlParser.java
* ./doxia/pom.xml


> don't translate APT source comments into output comments
> 
>
> Key: DOXIA-482
> URL: https://issues.apache.org/jira/browse/DOXIA-482
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Apt
>Affects Versions: 1.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 1.7
>
> Attachments: DOXIA-482.patch
>
>
> I have defined this as the very first lines in my apt file:
> {code}
> ~~ Copyright 2012 Michael Osipov
> ~~
> ~~ Licensed under the Apache License, Version 2.0 (the "License");
> ~~ you may not use this file except in compliance with the License.
> ~~ You may obtain a copy of the License at
> ~~
> ~~ http://www.apache.org/licenses/LICENSE-2.0
> ~~
> ~~ Unless required by applicable law or agreed to in writing, software
> ~~ distributed under the License is distributed on an "AS IS" BASIS,
> ~~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> ~~ See the License for the specific language governing permissions and
> ~~ limitations under the License.
> ~~ $Id$
> {code}
> This is unfortunately translated in
> {{/html/body/div/div/div#bodyColumn}} to a line-by-line comment
> {noformat}
> 
> {noformat}
> This, of course, is somewhat useless. I'd rather would have split comments 
> like in JSP or Velocity. Template comments are left out and HTML comments 
> remain untouched.
> I obviously do not need the ASL somewhere in the middle of by page as comment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-482) don't translate APT source comments into output comments

2016-01-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIA-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113807#comment-15113807
 ] 

Hervé Boutemy commented on DOXIA-482:
-

API added, but I fear this is contrary to DOXIA-532 = use of comments for SSI

I'm not really sure we should remove comments...

> don't translate APT source comments into output comments
> 
>
> Key: DOXIA-482
> URL: https://issues.apache.org/jira/browse/DOXIA-482
> Project: Maven Doxia
>  Issue Type: Bug
>  Components: Module - Apt
>Affects Versions: 1.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 1.7
>
> Attachments: DOXIA-482.patch
>
>
> I have defined this as the very first lines in my apt file:
> {code}
> ~~ Copyright 2012 Michael Osipov
> ~~
> ~~ Licensed under the Apache License, Version 2.0 (the "License");
> ~~ you may not use this file except in compliance with the License.
> ~~ You may obtain a copy of the License at
> ~~
> ~~ http://www.apache.org/licenses/LICENSE-2.0
> ~~
> ~~ Unless required by applicable law or agreed to in writing, software
> ~~ distributed under the License is distributed on an "AS IS" BASIS,
> ~~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> ~~ See the License for the specific language governing permissions and
> ~~ limitations under the License.
> ~~ $Id$
> {code}
> This is unfortunately translated in
> {{/html/body/div/div/div#bodyColumn}} to a line-by-line comment
> {noformat}
> 
> {noformat}
> This, of course, is somewhat useless. I'd rather would have split comments 
> like in JSP or Velocity. Template comments are left out and HTML comments 
> remain untouched.
> I obviously do not need the ASL somewhere in the middle of by page as comment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIA-532) Update handling of comments for Server Side Includes (ie comments starting with #)

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated DOXIA-532:

Summary: Update handling of comments for Server Side Includes (ie comments 
starting with #)  (was: Updated handling of comments.)

> Update handling of comments for Server Side Includes (ie comments starting 
> with #)
> --
>
> Key: DOXIA-532
> URL: https://issues.apache.org/jira/browse/DOXIA-532
> Project: Maven Doxia
>  Issue Type: New Feature
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Minor
> Fix For: 1.7
>
>
> Support for server side includes.
> comments starting with a '#' character represent SSI expressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DOXIA-532) Updated handling of comments.

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated DOXIA-532:

Description: 
Support for server side includes.
comments starting with a '#' character represent SSI expressions.


> Updated handling of comments.
> -
>
> Key: DOXIA-532
> URL: https://issues.apache.org/jira/browse/DOXIA-532
> Project: Maven Doxia
>  Issue Type: New Feature
>Reporter: Christian Schulte
>Assignee: Christian Schulte
>Priority: Minor
> Fix For: 1.7
>
>
> Support for server side includes.
> comments starting with a '#' character represent SSI expressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIASITETOOLS-146) don't translate APT source comments into output comments

2016-01-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113804#comment-15113804
 ] 

Hervé Boutemy commented on DOXIASITETOOLS-146:
--

notice that removing comments will cause issue for some users: see DOXIA-532

really not sure we should remove comments...

API in Doxia is ready to use, it's now easy do as we want: need to rethink 
about it

> don't translate APT source comments into output comments
> 
>
> Key: DOXIASITETOOLS-146
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-146
> Project: Maven Doxia Sitetools
>  Issue Type: Wish
>  Components: Site renderer
>Affects Versions: 1.6
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
> Fix For: 1.7
>
>
> see DOXIA-482: when Doxia is used in a site, parsing markup and translating 
> it to HTML, comments in source markup are not really meant for output site



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (DOXIA-511) remove deprecated o.a.m.doxia.module.site package

2016-01-23 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/DOXIA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy closed DOXIA-511.
---
Resolution: Fixed
  Assignee: Hervé Boutemy

> remove deprecated o.a.m.doxia.module.site package
> -
>
> Key: DOXIA-511
> URL: https://issues.apache.org/jira/browse/DOXIA-511
> Project: Maven Doxia
>  Issue Type: Task
>  Components: Core, Modules
>Affects Versions: 1.6
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
> Fix For: 1.7
>
>
> to finish work started in DOXIA-510



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-527) Allow multiple extensions for given format

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113777#comment-15113777
 ] 

Hudson commented on DOXIA-527:
--

SUCCESS: Integrated in doxia-all #222 (See 
[https://builds.apache.org/job/doxia-all/222/])
[DOXIA-511] migrated to o.a.m.doxia.parser.module (DOXIA-510) and added 
multiple extensions support (DOXIA-527) (hboutemy: 
[http://svn.apache.org/viewvc/?view=rev&rev=1726406])
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/AbstractDocumentRenderer.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/itext/AbstractITextRender.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/AbstractPdfRenderer.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/fo/FoPdfRenderer.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/itext/ITextPdfRenderer.java
* ./doxia-sitetools/pom.xml


> Allow multiple extensions for given format
> --
>
> Key: DOXIA-527
> URL: https://issues.apache.org/jira/browse/DOXIA-527
> Project: Maven Doxia
>  Issue Type: Improvement
>Reporter: Petar Tahchiev
>Assignee: Hervé Boutemy
> Fix For: 1.7
>
>
> Hello,
> according to this thread here:
> https://github.com/asciidoctor/asciidoctor-maven-plugin/issues/125
> people are requesting to allow multiple extensions (*.adoc and *.asciidoc) 
> for the doxia renderer.
> I've done also a pull request to address this issue:
> https://github.com/apache/maven-doxia/pull/1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-511) remove deprecated o.a.m.doxia.module.site package

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113778#comment-15113778
 ] 

Hudson commented on DOXIA-511:
--

SUCCESS: Integrated in doxia-all #222 (See 
[https://builds.apache.org/job/doxia-all/222/])
[DOXIA-511] migrated to o.a.m.doxia.parser.module (DOXIA-510) and added 
multiple extensions support (DOXIA-527) (hboutemy: 
[http://svn.apache.org/viewvc/?view=rev&rev=1726406])
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/AbstractDocumentRenderer.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/itext/AbstractITextRender.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/AbstractPdfRenderer.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/fo/FoPdfRenderer.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/itext/ITextPdfRenderer.java
* ./doxia-sitetools/pom.xml


> remove deprecated o.a.m.doxia.module.site package
> -
>
> Key: DOXIA-511
> URL: https://issues.apache.org/jira/browse/DOXIA-511
> Project: Maven Doxia
>  Issue Type: Task
>  Components: Core, Modules
>Affects Versions: 1.6
>Reporter: Hervé Boutemy
> Fix For: 1.7
>
>
> to finish work started in DOXIA-510



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-510) create parser.module equivalent to module.site

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113779#comment-15113779
 ] 

Hudson commented on DOXIA-510:
--

SUCCESS: Integrated in doxia-all #222 (See 
[https://builds.apache.org/job/doxia-all/222/])
[DOXIA-511] migrated to o.a.m.doxia.parser.module (DOXIA-510) and added 
multiple extensions support (DOXIA-527) (hboutemy: 
[http://svn.apache.org/viewvc/?view=rev&rev=1726406])
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/AbstractDocumentRenderer.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/itext/AbstractITextRender.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/AbstractPdfRenderer.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/fo/FoPdfRenderer.java
* 
./doxia-sitetools/doxia-doc-renderer/src/main/java/org/apache/maven/doxia/docrenderer/pdf/itext/ITextPdfRenderer.java
* ./doxia-sitetools/pom.xml


> create parser.module equivalent to module.site
> --
>
> Key: DOXIA-510
> URL: https://issues.apache.org/jira/browse/DOXIA-510
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Core, Modules
>Affects Versions: 1.5
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
> Fix For: 1.6
>
>
> actually, there are SiteModules in o.a.m.doxia.module.site
> But this API isn't intuitive:
> - its package is like a "site" module, but it's not a Doxia module (like apt 
> or markdown)
> - a "site module" is in fact a *parser* module, because the site plugin use 
> module to parse source, only for Doxia modules that support parsing
> so creating an equivalent ParserModule API in o.a.m.doxia.parser.module will 
> help people understand better the intent
> in this first step, old API can stay in place as deprecated ton maintain 
> compatibility: this does not represent much code, and can be clean up in 
> Doxia 2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (DOXIASITETOOLS-146) don't translate APT source comments into output comments

2016-01-23 Thread JIRA
Hervé Boutemy created DOXIASITETOOLS-146:


 Summary: don't translate APT source comments into output comments
 Key: DOXIASITETOOLS-146
 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-146
 Project: Maven Doxia Sitetools
  Issue Type: Wish
  Components: Site renderer
Affects Versions: 1.6
Reporter: Hervé Boutemy
Assignee: Hervé Boutemy
 Fix For: 1.7


see DOXIA-482: when Doxia is used in a site, parsing markup and translating it 
to HTML, comments in source markup are not really meant for output site




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DOXIA-511) remove deprecated o.a.m.doxia.module.site package

2016-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DOXIA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113741#comment-15113741
 ] 

Hudson commented on DOXIA-511:
--

FAILURE: Integrated in doxia-all #221 (See 
[https://builds.apache.org/job/doxia-all/221/])
[DOXIA-511] removed deprecated o.a.m.doxia.module.site package (hboutemy: 
[http://svn.apache.org/viewvc/?view=rev&rev=1726395])
* ./doxia/doxia-core/src/main/java/org/apache/maven/doxia/module
* 
./doxia/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSiteModule.java
* 
./doxia/doxia-modules/doxia-module-confluence/src/main/java/org/apache/maven/doxia/module/confluence/ConfluenceSiteModule.java
* 
./doxia/doxia-modules/doxia-module-docbook-simple/src/main/java/org/apache/maven/doxia/module/docbook/DocBookSiteModule.java
* 
./doxia/doxia-modules/doxia-module-fml/src/main/java/org/apache/maven/doxia/module/fml/FmlSiteModule.java
* 
./doxia/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSiteModule.java
* 
./doxia/doxia-modules/doxia-module-markdown/src/test/java/org/apache/maven/doxia/module/markdown/MarkdownParserTest.java
* 
./doxia/doxia-modules/doxia-module-twiki/src/main/java/org/apache/maven/doxia/module/twiki/TWikiSiteModule.java
* 
./doxia/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocSiteModule.java
* 
./doxia/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSiteModule.java
* ./doxia/pom.xml


> remove deprecated o.a.m.doxia.module.site package
> -
>
> Key: DOXIA-511
> URL: https://issues.apache.org/jira/browse/DOXIA-511
> Project: Maven Doxia
>  Issue Type: Task
>  Components: Core, Modules
>Affects Versions: 1.6
>Reporter: Hervé Boutemy
> Fix For: 1.7
>
>
> to finish work started in DOXIA-510



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SUREFIRE-1219) skipAfterFailureCount should not count flaky tests as failures when using rerunFailingTestsCount

2016-01-23 Thread Tibor Digana (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113676#comment-15113676
 ] 

Tibor Digana commented on SUREFIRE-1219:


[~sflanigan]
[~seanf]
As a short answer, the feature works with skipAfterFailureCount but simply 
ignores rerunFailingTestsCount.
This means the failed test immediately incremented skipAfterFailureCount 
counter but it is not incremented when rerun phase is taken into account. This 
is very important because that's the only way how to make both JUnit providers 
surefire-junit4 and surefire-junit47 working the same way and skipping the test 
phase eagerly.
I know what you want to achieve, that the test is passed in next re-run but 
does not increment the counter but that's not possible for surefire-junit47 and 
not for forkCount=0 or 1 and forkCount=2C. Forking the tests is changing the 
behavior but we want to keep it the same for all scenarios. The point of 
skipAfterFailureCount is to skip the test-set eagerly and fail the build asap 
without waiting for whole run of whole test-set. The users do not want to wait 
for long running tests only due to they fail. Maybe they have common root 
cause, due to last commit in SVN, thus no reason to wait for next 100 test 
until they fail. If we placed the function of skipAfterFailureCount at the end 
of test phase then this feature would not make much sense because it just did 
not stop the build eagerly. Yes it is a kind of limit in rerun feature on how 
far the rerun may go. That's the reason why you can see both failures/errors 
and skipped tests.

> skipAfterFailureCount should not count flaky tests as failures when using 
> rerunFailingTestsCount
> 
>
> Key: SUREFIRE-1219
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1219
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.19.1
>Reporter: Sean Flanigan
> Attachments: SUREFIRE-1219-tests.zip
>
>
> According to 
> https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html
>  "failed tests within re-run phase are not included in 
> skipAfterFailureCount". For instance, if skipAfterFailureCount is 1, but 
> every test passes on the second attempt, the tests are "flaky" but not 
> "failures".  This should be reflected in summaries, in XML result files and 
> in fail fast (skipAfterFailureCount), but this is not the case.
> If I have 10 flaky-but-not-failing tests, set rerunFailingTestsCount=1 and 
> skipAfterFailureCount=5:
> 1. I would expect something like this to be printed on the console:
>   Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Flakes: 10
> 2. The XML report should list s but no .
> 3. All tests should be run, not just 5 of them, in other words 
> skipAfterFailureCount should not count the flaky tests as part of the failure 
> count.
> I have some tests demonstrating the problem, which I will attach to this 
> issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)