[jira] [Commented] (SUREFIRE-1228) rerunFailingTestsCount + TestNG + @DataProvider = failed tests pass
[
https://issues.apache.org/jira/browse/SUREFIRE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207909#comment-15207909
]
Tibor Digana commented on SUREFIRE-1228:
Simply do not use rerun with TestNG. It was not designed for TestNG, but faster
you can just set it to false in your POM.
> rerunFailingTestsCount + TestNG + @DataProvider = failed tests pass
> ---
>
> Key: SUREFIRE-1228
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1228
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
>Affects Versions: 2.19.1
>Reporter: Cam Morris
>Assignee: Tibor Digana
> Attachments: TestRandomFail.java, pom.xml
>
>
> Surefire confuses tests run with a data-provider with rerun tests so only one
> of the data-provided tests need to pass.
> Steps to reproduce:
> # Create a testNG test with a data provider that passes with some of the data
> and fails with others
> {code:title=TestNG example|language=java}
> @Test(dataProvider = "succeed")
> public void fail(boolean succeed) {
> if (!succeed) {
> Assert.fail("nope");
> }
> }
> @DataProvider(name="succeed")
> public Object[][] arrayIndex() {
> return new Object[][]{ {true}, {false}};
> }
> {code}
> # Configure surefire to rerun failed tests
> {code:title=pom.xml example|language=xml}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> cam.test
> testng-retry
> 1.0-SNAPSHOT
>
>
> org.testng
> testng
> 6.9.10
> test
>
>
>
>
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.19.1
>
> 1
>
>
>
>
>
> {code}
> - *Expected results*: "Tests run: 2, Failures: 1..." The tests should not
> pass.
> - *Actual results*: "Tests run: 1, Failures: 0, Errors: 0, Skipped: 0,
> Flakes: 1" The rerun confuses test runs with different data for retry
> attempts. Just one of the data provider tests needs to succeed for the test
> to be deemed a success.
> {code}mvn test
> ...
> ---
> T E S T S
> ---
> Running TestRandomFail
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.267 sec <<<
> FAILURE! - in TestRandomFail
> fail(TestRandomFail) Time elapsed: 0.007 sec <<< FAILURE!
> java.lang.AssertionError: nope
> at TestRandomFail.fail(TestRandomFail.java:14)
> Results :
> Flaked tests:
> TestRandomFail.fail(TestRandomFail)
> Run 1: PASS
> Run 2: TestRandomFail.fail:14 nope
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Flakes: 1
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 2.251 s
> [INFO] Finished at: 2016-02-10T07:39:21-07:00
> [INFO] Final Memory: 9M/244M
> [INFO]
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1238) Surefire: Test using @dataprovider are skipped by surefire
[ https://issues.apache.org/jira/browse/SUREFIRE-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207903#comment-15207903 ] Tibor Digana commented on SUREFIRE-1238: [~rbernard] Pls atach the file C:\Users\rbernard\workspace\Learning\testng.xml and files in src/main/java and src/test/java. Please use Version 2.19.1 instead of 2.19. > Surefire: Test using @dataprovider are skipped by surefire > -- > > Key: SUREFIRE-1238 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1238 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: RegisRozario >Assignee: Tibor Digana >Priority: Blocker > Attachments: pom.xml > > > Tests using @dataprovider are skipped by surefire > ex: > @Test(dataProvider="test") --> this test will be skipped by the surefire > plugin > I have my data stored in a excel file and am using a testng dataprovider to > pass the value to this test. > Note: Excel file is available under src/test/java > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SUREFIRE-1238) Surefire: Test using @dataprovider are skipped by surefire
[ https://issues.apache.org/jira/browse/SUREFIRE-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1238: -- Assignee: Tibor Digana > Surefire: Test using @dataprovider are skipped by surefire > -- > > Key: SUREFIRE-1238 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1238 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: RegisRozario >Assignee: Tibor Digana >Priority: Blocker > Attachments: pom.xml > > > Tests using @dataprovider are skipped by surefire > ex: > @Test(dataProvider="test") --> this test will be skipped by the surefire > plugin > I have my data stored in a excel file and am using a testng dataprovider to > pass the value to this test. > Note: Excel file is available under src/test/java > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DOXIASITETOOLS-158) Support ${this.*} as expression in site.xml interpolation
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207591#comment-15207591
]
Hudson commented on DOXIASITETOOLS-158:
---
FAILURE: Integrated in doxia-all #271 (See
[https://builds.apache.org/job/doxia-all/271/])
[DOXIASITETOOLS-158] added support for ${this.*} as expression in site.xml
interpolation (hboutemy: [http://svn.apache.org/viewvc/?view=rev=1736261])
*
./doxia-sitetools/doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java
*
./doxia-sitetools/doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/SiteToolTest.java
*
./doxia-sitetools/doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/stubs/SiteToolMavenProjectStub.java
*
./doxia-sitetools/doxia-integration-tools/src/test/resources/unit/interpolation-child-test/pom.xml
*
./doxia-sitetools/doxia-integration-tools/src/test/resources/unit/interpolation-parent-test/pom.xml
*
./doxia-sitetools/doxia-integration-tools/src/test/resources/unit/interpolation-parent-test/src/site/site.xml
> Support ${this.*} as expression in site.xml interpolation
> -
>
> Key: DOXIASITETOOLS-158
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-158
> Project: Maven Doxia Sitetools
> Issue Type: New Feature
> Components: Decoration model
>Affects Versions: 1.7
>Reporter: Hervé Boutemy
> Fix For: 1.8
>
>
> with MSITE-135/DOXIASITETOOLS-118 fixed for consistency with general Maven
> interpolation principles, we see that interpolating immediately with current
> pom content is something quite natural in {{site.xml}}
> adding support for {{$\{this.\*}}} to interpolate with current pom (instead
> of classical {{$\{project.*}}}) would give back the feature expected in
> {{site.xml}}
> and would be consistent with MNG-5900 (not yet available in any Maven version)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
