[jira] [Created] (MJLINK-7) Code incorrectly assumes that two modules won't have the same name
Gili created MJLINK-7: - Summary: Code incorrectly assumes that two modules won't have the same name Key: MJLINK-7 URL: https://issues.apache.org/jira/browse/MJLINK-7 Project: Maven JLink Plugin Issue Type: Bug Affects Versions: 3.0.0-alpha-2 Reporter: Gili https://github.com/apache/maven-plugins/blob/bfa65c310d7f16671db672773f73fd64f05edfd0/maven-jlink-plugin/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java#L327 wrongfully assumes that two modules won't share the same name (this is legal as discussed at https://stackoverflow.com/a/46573805/14731). Please review this code to make sure it correctly handles multiple modules having the same name. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1451) Surefire Booter compatibility with NetBSD ps(1) output
[ https://issues.apache.org/jira/browse/SUREFIRE-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1451: --- Summary: Surefire Booter compatibility with NetBSD ps(1) output (was: sureFire Booter compatibility with NetBSD ps(1) output) > Surefire Booter compatibility with NetBSD ps(1) output > -- > > Key: SUREFIRE-1451 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1451 > Project: Maven Surefire > Issue Type: Bug > Components: process forking >Affects Versions: 2.20.1 > Environment: NetBSD >Reporter: Tobias Nygren >Assignee: Tibor Digana >Priority: Minor > > On NetBSD The /bin/ps command reports time as 0:01 rather than 00:01 for > intervals shorter than 10 minutes. > The pattern as used [here in SureFire > Booter|https://github.com/apache/maven-surefire/commit/c343cc412b986fd9da839696c709542d03679d68#diff-33826e7c2cc48fb008e88914fd841d10R71] > to parse ps(1) output does not take this into account. > printf(3) logic for ps(1) can be found in the [ps > source|https://github.com/NetBSD/src/blob/9160f3e067c6f959b9ecb4296771d8a6ae9b3ee6/bin/ps/print.c#L832]. > The following patterns are possible and need to be accounted for: > * m:ss > * mm:ss > * h:mm:ss > * hh:mm:ss > * d-hh:mm:ss > * dd-hh:mm:ss -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1451) sureFire Booter compatibility with NetBSD ps(1) output
[ https://issues.apache.org/jira/browse/SUREFIRE-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279470#comment-16279470 ] Tibor Digana commented on SUREFIRE-1451: [~tnn] Feel free to push a PR fix on GitHub and extend unit tests. Thx. > sureFire Booter compatibility with NetBSD ps(1) output > -- > > Key: SUREFIRE-1451 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1451 > Project: Maven Surefire > Issue Type: Bug > Components: process forking >Affects Versions: 2.20.1 > Environment: NetBSD >Reporter: Tobias Nygren >Assignee: Tibor Digana >Priority: Minor > > On NetBSD The /bin/ps command reports time as 0:01 rather than 00:01 for > intervals shorter than 10 minutes. > The pattern as used [here in SureFire > Booter|https://github.com/apache/maven-surefire/commit/c343cc412b986fd9da839696c709542d03679d68#diff-33826e7c2cc48fb008e88914fd841d10R71] > to parse ps(1) output does not take this into account. > printf(3) logic for ps(1) can be found in the [ps > source|https://github.com/NetBSD/src/blob/9160f3e067c6f959b9ecb4296771d8a6ae9b3ee6/bin/ps/print.c#L832]. > The following patterns are possible and need to be accounted for: > * m:ss > * mm:ss > * h:mm:ss > * hh:mm:ss > * d-hh:mm:ss > * dd-hh:mm:ss -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SUREFIRE-1451) sureFire Booter compatibility with NetBSD ps(1) output
[ https://issues.apache.org/jira/browse/SUREFIRE-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1451: -- Assignee: Tibor Digana > sureFire Booter compatibility with NetBSD ps(1) output > -- > > Key: SUREFIRE-1451 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1451 > Project: Maven Surefire > Issue Type: Bug > Components: process forking >Affects Versions: 2.20.1 > Environment: NetBSD >Reporter: Tobias Nygren >Assignee: Tibor Digana >Priority: Minor > > On NetBSD The /bin/ps command reports time as 0:01 rather than 00:01 for > intervals shorter than 10 minutes. > The pattern as used [here in SureFire > Booter|https://github.com/apache/maven-surefire/commit/c343cc412b986fd9da839696c709542d03679d68#diff-33826e7c2cc48fb008e88914fd841d10R71] > to parse ps(1) output does not take this into account. > printf(3) logic for ps(1) can be found in the [ps > source|https://github.com/NetBSD/src/blob/9160f3e067c6f959b9ecb4296771d8a6ae9b3ee6/bin/ps/print.c#L832]. > The following patterns are possible and need to be accounted for: > * m:ss > * mm:ss > * h:mm:ss > * hh:mm:ss > * d-hh:mm:ss > * dd-hh:mm:ss -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1450) TestNG Listener aren't working from Property Tag in POM.xml With JDK9
[ https://issues.apache.org/jira/browse/SUREFIRE-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279467#comment-16279467 ] Tibor Digana commented on SUREFIRE-1450: [~hammadhost] It can be also TestNG issue. What it means "not working". You should investigate and prove it is Surefire and not TestNG issue. Debug the code. > TestNG Listener aren't working from Property Tag in POM.xml With JDK9 > - > > Key: SUREFIRE-1450 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1450 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin, TestNG > support >Affects Versions: 2.20.1 > Environment: macOS + Ubuntu, JDK9 >Reporter: Hammad >Assignee: Tibor Digana > Labels: newbie > > TestNG Listener are not working when using: > Maven = Apache Maven 3.5.2 > JDK9 on either platform (sierra+ubuntu) > Here is relevant repo: https://github.com/HammadHost/poc_testng_surefire > I executed it with jdk8 in same environment listener did work, but they > aren't working with JDK9 > FYI: > https://stackoverflow.com/questions/47560412/maven-surefire-is-not-respecting-testng-listeners-in-property-tag -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SUREFIRE-1450) TestNG Listener aren't working from Property Tag in POM.xml With JDK9
[ https://issues.apache.org/jira/browse/SUREFIRE-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1450: -- Assignee: Tibor Digana > TestNG Listener aren't working from Property Tag in POM.xml With JDK9 > - > > Key: SUREFIRE-1450 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1450 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin, TestNG > support >Affects Versions: 2.20.1 > Environment: macOS + Ubuntu, JDK9 >Reporter: Hammad >Assignee: Tibor Digana > Labels: newbie > > TestNG Listener are not working when using: > Maven = Apache Maven 3.5.2 > JDK9 on either platform (sierra+ubuntu) > Here is relevant repo: https://github.com/HammadHost/poc_testng_surefire > I executed it with jdk8 in same environment listener did work, but they > aren't working with JDK9 > FYI: > https://stackoverflow.com/questions/47560412/maven-surefire-is-not-respecting-testng-listeners-in-property-tag -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DOXIA-566) Update dependences to latest version
[ https://issues.apache.org/jira/browse/DOXIA-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279427#comment-16279427 ] ASF GitHub Bot commented on DOXIA-566: -- hboutemy commented on issue #6: [DOXIA-566] Upgrade dependences and plugin versions URL: https://github.com/apache/maven-doxia/pull/6#issuecomment-349487617 PR merged thank you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update dependences to latest version > > > Key: DOXIA-566 > URL: https://issues.apache.org/jira/browse/DOXIA-566 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Hervé Boutemy >Priority: Minor > Fix For: 1.8 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DOXIA-566) Update dependences to latest version
[
https://issues.apache.org/jira/browse/DOXIA-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279428#comment-16279428
]
ASF GitHub Bot commented on DOXIA-566:
--
hboutemy closed pull request #6: [DOXIA-566] Upgrade dependences and plugin
versions
URL: https://github.com/apache/maven-doxia/pull/6
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/doxia-core/pom.xml b/doxia-core/pom.xml
index 7b3ce1fc..371e56af 100644
--- a/doxia-core/pom.xml
+++ b/doxia-core/pom.xml
@@ -72,9 +72,14 @@ under the License.
- xmlunit
- xmlunit
- 1.5
+ org.xmlunit
+ xmlunit-core
+ test
+
+
+ org.xmlunit
+ xmlunit-matchers
+ test
diff --git
a/doxia-core/src/test/java/org/apache/maven/doxia/AbstractModuleTest.java
b/doxia-core/src/test/java/org/apache/maven/doxia/AbstractModuleTest.java
index 997d3b42..b583a630 100644
--- a/doxia-core/src/test/java/org/apache/maven/doxia/AbstractModuleTest.java
+++ b/doxia-core/src/test/java/org/apache/maven/doxia/AbstractModuleTest.java
@@ -102,6 +102,14 @@ protected Writer getXmlTestWriter( String baseName )
return getXmlTestWriter( baseName, outputExtension() );
}
+protected static String normalizeLineEnds(String s) {
+if ( s != null) {
+return s.replaceAll("\r\n", "\n" )
+.replaceAll("\r", "\n");
+} else {
+return null;
+}
+}
/**
* Returns an XML FileWriter to write to a file with the given name
* in the test target output directory.
diff --git
a/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java
b/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java
index 4a5baca3..4fb1d7fd 100644
---
a/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java
+++
b/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java
@@ -27,11 +27,11 @@
import org.apache.maven.doxia.logging.PlexusLoggerWrapper;
import org.apache.maven.doxia.sink.Sink;
import org.apache.maven.doxia.sink.SinkEventAttributes;
-import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet;
import org.codehaus.plexus.DefaultPlexusContainer;
import org.codehaus.plexus.util.IOUtil;
-import org.custommonkey.xmlunit.Diff;
-import org.custommonkey.xmlunit.XMLUnit;
+import org.xmlunit.matchers.CompareMatcher;
+
+import static org.junit.Assert.assertThat;
/**
* Abstract base class to test sinks.
@@ -207,8 +207,8 @@ public void testHead()
sink.flush();
sink.close();
-String actual = testWriter.toString();
-String expected = getHeadBlock();
+String actual = normalizeLineEnds( testWriter.toString() );
+String expected = normalizeLineEnds( getHeadBlock() );
assertEquals( "Wrong head!", expected, actual );
}
@@ -470,12 +470,11 @@ public void testFigure() throws Exception
if ( isXmlSink() )
{
-Diff diff = XMLUnit.compareXML( wrapXml( expected ), wrapXml(
actual ) );
-assertTrue( "Wrong figure!", diff.identical() );
+assertThat ( wrapXml( actual ), CompareMatcher.isIdenticalTo(
wrapXml( expected ) ));
}
else
{
-assertEquals( "Wrong figure!", expected, actual );
+assertEquals( actual, expected );
}
}
@@ -494,12 +493,11 @@ public void testFigureWithoutCaption() throws Exception
if ( isXmlSink() )
{
-Diff diff = XMLUnit.compareXML( wrapXml( expected ), wrapXml(
actual ) );
-assertTrue( "Wrong figure!", diff.identical() );
+assertThat ( wrapXml( actual ), CompareMatcher.isIdenticalTo(
wrapXml( expected ) ));
}
else
{
-assertEquals( "Wrong figure!", expected, actual );
+assertEquals( actual, expected );
}
}
@@ -536,12 +534,11 @@ public void testTable() throws Exception
if ( isXmlSink() )
{
-Diff diff = XMLUnit.compareXML( wrapXml( expected ), wrapXml(
actual ) );
-assertTrue( "Wrong table!", diff.identical() );
+assertThat ( wrapXml( actual ), CompareMatcher.isIdenticalTo(
wrapXml( expected ) ));
}
else
{
-assertEquals( "Wrong table!", expected, actual );
+assertEquals( actual, expected );
}
}
diff --git a/doxia-modules/doxia-module-apt/pom.xml
b/doxia-modules/doxia-module-apt/pom.xml
index c3e5a049..4e9308df 100644
--- a/doxia-modules/doxia-module-apt/pom.xml
+++ b/doxia-modules/doxia-module-apt/pom.xml
@@ -46,5
[jira] [Closed] (DOXIA-566) Update dependences to latest version
[ https://issues.apache.org/jira/browse/DOXIA-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy closed DOXIA-566. --- Resolution: Fixed Fix Version/s: 1.8 > Update dependences to latest version > > > Key: DOXIA-566 > URL: https://issues.apache.org/jira/browse/DOXIA-566 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Hervé Boutemy >Priority: Minor > Fix For: 1.8 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DOXIA-566) Update dependences to latest version
[ https://issues.apache.org/jira/browse/DOXIA-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279362#comment-16279362 ] Hudson commented on DOXIA-566: -- SUCCESS: Integrated in Jenkins build doxia #7 (See [https://builds.apache.org/job/doxia/7/]) [DOXIA-566] Upgrade dependences (hboutemy: [http://gitbox.apache.org/repos/asf/?p=maven-doxia.git=commit=304c6f49e8ead22a7e3f77f4e6dbe3547c92b2e4]) * (edit) doxia-modules/doxia-module-apt/pom.xml * (edit) pom.xml * (edit) doxia-modules/doxia-module-latex/pom.xml * (edit) doxia-core/src/test/java/org/apache/maven/doxia/AbstractModuleTest.java * (edit) doxia-modules/doxia-module-xdoc/pom.xml * (edit) doxia-modules/doxia-module-xhtml/pom.xml * (edit) doxia-modules/doxia-module-docbook-simple/pom.xml * (edit) doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java * (edit) doxia-core/pom.xml * (edit) doxia-modules/doxia-module-fo/pom.xml * (edit) doxia-modules/doxia-module-fo/src/test/java/org/apache/maven/doxia/module/fo/FoAggregateSinkTest.java > Update dependences to latest version > > > Key: DOXIA-566 > URL: https://issues.apache.org/jira/browse/DOXIA-566 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Hervé Boutemy >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (DOXIA-566) Update dependences to latest version
[ https://issues.apache.org/jira/browse/DOXIA-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279357#comment-16279357 ] Hudson commented on DOXIA-566: -- Build succeeded in Jenkins: Maven TLP » maven-doxia » master #4 See https://builds.apache.org/job/maven-box/job/maven-doxia/job/master/4/ > Update dependences to latest version > > > Key: DOXIA-566 > URL: https://issues.apache.org/jira/browse/DOXIA-566 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Hervé Boutemy >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (DOXIA-566) Update dependences to latest version
[ https://issues.apache.org/jira/browse/DOXIA-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy updated DOXIA-566: Summary: Update dependences to latest version (was: Update dependences and default plugins to latest version) > Update dependences to latest version > > > Key: DOXIA-566 > URL: https://issues.apache.org/jira/browse/DOXIA-566 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (DOXIA-566) Update dependences to latest version
[ https://issues.apache.org/jira/browse/DOXIA-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy reassigned DOXIA-566: --- Assignee: Hervé Boutemy > Update dependences to latest version > > > Key: DOXIA-566 > URL: https://issues.apache.org/jira/browse/DOXIA-566 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Hervé Boutemy >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MJAR-242) When building an empty project with mvn clean install deploy it will fail because it executes maven-jar-plugin twice with "have to use classifier" error.
[ https://issues.apache.org/jira/browse/MJAR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279124#comment-16279124 ] Karl Heinz Marbaise commented on MJAR-242: -- In the end this is an issue of the Maven Core MNG-6318 > When building an empty project with mvn clean install deploy it will fail > because it executes maven-jar-plugin twice with "have to use classifier" > error. > - > > Key: MJAR-242 > URL: https://issues.apache.org/jira/browse/MJAR-242 > Project: Maven JAR Plugin > Issue Type: Bug >Affects Versions: 3.0.0 > Environment: Windows 10 x64 > Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c; > 2015-03-13T16:10:27-04:00) > Java version: 1.8.0_131, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.8.0_131\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos" >Reporter: Daniel Cruver >Priority: Minor > Attachments: empty-project-build.log, pom.xml > > > This issues should never happen because who has empty projects, well our > project had a few, so I ran across this issue when running mvn clean install. > "You have to use a classifier to attach supplemental artifacts to the project > instead of replacing" > I have attached the build log and an example pom that can reproduce the > error, assuming you updated the distributionManagement section with an actual > Maven Repository. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MNG-6318) Prevent calling "mvn install deploy"
Karl Heinz Marbaise created MNG-6318:
Summary: Prevent calling "mvn install deploy"
Key: MNG-6318
URL: https://issues.apache.org/jira/browse/MNG-6318
Project: Maven
Issue Type: Improvement
Components: Command Line, core
Affects Versions: 3.5.2, 3.5.0, 3.3.9, 3.2.5
Reporter: Karl Heinz Marbaise
Priority: Minor
Currently you can call Maven like this: {{mvn install deploy}} or {{mvn test
install}} which in the end is not useful nor correct and can cause sometimes
strange issues like MJAR-242. I think we should prevent things like this. It
should be possible to do things like this: {{mvn site deploy}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MJAR-242) When building an empty project with mvn clean install deploy it will fail because it executes maven-jar-plugin twice with "have to use classifier" error.
[
https://issues.apache.org/jira/browse/MJAR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279110#comment-16279110
]
Karl Heinz Marbaise commented on MJAR-242:
--
If you really call {{mvn clean install deploy}} the usage of {{install}} is
superfluous cause the life cycle includes the {{install}} parts which means
{{mvn clean deploy}} is sufficient. The problem here is located based on the
repeating of the {{install}} phase which will call the {{maven-jar-plugin}} a
second time which will cause the resulting error message.
> When building an empty project with mvn clean install deploy it will fail
> because it executes maven-jar-plugin twice with "have to use classifier"
> error.
> -
>
> Key: MJAR-242
> URL: https://issues.apache.org/jira/browse/MJAR-242
> Project: Maven JAR Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Windows 10 x64
> Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
> 2015-03-13T16:10:27-04:00)
> Java version: 1.8.0_131, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_131\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"
>Reporter: Daniel Cruver
>Priority: Minor
> Attachments: empty-project-build.log, pom.xml
>
>
> This issues should never happen because who has empty projects, well our
> project had a few, so I ran across this issue when running mvn clean install.
> "You have to use a classifier to attach supplemental artifacts to the project
> instead of replacing"
> I have attached the build log and an example pom that can reproduce the
> error, assuming you updated the distributionManagement section with an actual
> Maven Repository.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MRESOURCES-240) Add some binnary types to nonFilteredFileExtension by default
[ https://issues.apache.org/jira/browse/MRESOURCES-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279103#comment-16279103 ] Manfred Moser commented on MRESOURCES-240: -- I think this should NOT be implemented. Users can set that themselves as needed already and whatever defaults we come up with might be wrong for some users and incomplete for others. This does not really solve a problem but instead creates more complexity. > Add some binnary types to nonFilteredFileExtension by default > --- > > Key: MRESOURCES-240 > URL: https://issues.apache.org/jira/browse/MRESOURCES-240 > Project: Maven Resources Plugin > Issue Type: Improvement > Components: filtering >Reporter: Flávio Casas de Arcega >Priority: Minor > Labels: easyfix, patch > > Hi! > I had problems with filtering binnary resources, fonts and icons from my > application where corrupted during the build process. > To solve, I added this configuration to the maven-resources-plugin: > > > > maven-resources-plugin > > > > svg > > woff > > woff2 > > ttf > > eot > > otf > > > > > > And I was wondering if this binnary types coudn't be excluded from filters by > default. > I think It would be possible, changing the > org.apache.maven.shared.maven-filtering plugin by applying this patch to the > org.apache.maven.shared.filtering.DefaultMavenResourcesFiltering class: > 79a80,85 > > this.defaultNonFilteredFileExtensions.add( "svg" ); > > this.defaultNonFilteredFileExtensions.add( "woff" ); > > this.defaultNonFilteredFileExtensions.add( "woff2" ); > > this.defaultNonFilteredFileExtensions.add( "ttf" ); > > this.defaultNonFilteredFileExtensions.add( "eot" ); > > this.defaultNonFilteredFileExtensions.add( "otf" ); > Only a suggestion, thanks 4 all... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MRESOURCES-240) Add some binnary types to nonFilteredFileExtension by default
Flávio Casas de Arcega created MRESOURCES-240: - Summary: Add some binnary types to nonFilteredFileExtension by default Key: MRESOURCES-240 URL: https://issues.apache.org/jira/browse/MRESOURCES-240 Project: Maven Resources Plugin Issue Type: Improvement Components: filtering Reporter: Flávio Casas de Arcega Priority: Minor Hi! I had problems with filtering binnary resources, fonts and icons from my application where corrupted during the build process. To solve, I added this configuration to the maven-resources-plugin: maven-resources-plugin svg woff woff2 ttf eot otf And I was wondering if this binnary types coudn't be excluded from filters by default. I think It would be possible, changing the org.apache.maven.shared.maven-filtering plugin by applying this patch to the org.apache.maven.shared.filtering.DefaultMavenResourcesFiltering class: 79a80,85 > this.defaultNonFilteredFileExtensions.add( "svg" ); > this.defaultNonFilteredFileExtensions.add( "woff" ); > this.defaultNonFilteredFileExtensions.add( "woff2" ); > this.defaultNonFilteredFileExtensions.add( "ttf" ); > this.defaultNonFilteredFileExtensions.add( "eot" ); > this.defaultNonFilteredFileExtensions.add( "otf" ); Only a suggestion, thanks 4 all... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MJAR-241) Jar package does not have a size in ZipEntry
[
https://issues.apache.org/jira/browse/MJAR-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278976#comment-16278976
]
Plamen Totev commented on MJAR-241:
---
I do believe that the root cause is a bug fixed in Apache Commons Compress
1.15. If you override the dependency it should fix the issue:
{code:xml}
org.apache.maven.plugins
maven-jar-plugin
3.0.2
org.apache.commons
commons-compress
1.15
{code}
The next release of Plexus Archiver is going to depend on Apache Commons
Compress 1.15 so once it is released this issue could be fixed by just updating
the Plexus Archiver dependency.
> Jar package does not have a size in ZipEntry
>
>
> Key: MJAR-241
> URL: https://issues.apache.org/jira/browse/MJAR-241
> Project: Maven JAR Plugin
> Issue Type: Bug
>Affects Versions: 2.5, 2.6, 3.0.2
> Environment: Windows 7
> Maven 3.3.9
>Reporter: Kaitlyn Lemmons
>
> Since version 2.5, jars output by the maven-jar-plugin do not have a size
> that Java's standard ZipEntry class can read. Version 2.4, however, outputs a
> jar with sizes that works just fine.
> Testing included versions 2.4, 2.5, 2.6, and 3.0.2 - only version 2.4 outputs
> a jar with sizes according to ZipEntry. All configuration was kept constant;
> only the version was altered between each test.
> Sample code is below:
> {code:java}
> ZipInputStream zis = new ZipInputStream(new FileInputStream(jarFile));
> ZipEntry entry = zis.getNextEntry();
> System.out.println(entry.getSize());
> {code}
> Output is -1 for versions 2.5+ and a correct >0 size for version 2.4.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (MJAR-242) When building an empty project with mvn clean install deploy it will fail because it executes maven-jar-plugin twice with "have to use classifier" error.
Daniel Cruver created MJAR-242: -- Summary: When building an empty project with mvn clean install deploy it will fail because it executes maven-jar-plugin twice with "have to use classifier" error. Key: MJAR-242 URL: https://issues.apache.org/jira/browse/MJAR-242 Project: Maven JAR Plugin Issue Type: Bug Affects Versions: 3.0.0 Environment: Windows 10 x64 Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c; 2015-03-13T16:10:27-04:00) Java version: 1.8.0_131, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.8.0_131\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos" Reporter: Daniel Cruver Priority: Minor Attachments: empty-project-build.log, pom.xml This issues should never happen because who has empty projects, well our project had a few, so I ran across this issue when running mvn clean install. "You have to use a classifier to attach supplemental artifacts to the project instead of replacing" I have attached the build log and an example pom that can reproduce the error, assuming you updated the distributionManagement section with an actual Maven Repository. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MCHECKSTYLE-332) maven plugin not using cache property
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278846#comment-16278846
]
richard commented on MCHECKSTYLE-332:
-
Is there a timetable when 2.18 will come out or are releases now abandoned for
this project? We have been waiting a year for this change.
Checkstyle cannot make backward breaking changes until the new version is
released. The old version will abend with the method in TreeWalker is removed
so we cannot remove it until the new version comes out.
See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> maven plugin not using cache property
> -
>
> Key: MCHECKSTYLE-332
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-332
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 2.17
> Environment: Windows 7, 64 bit, JDK 8
>Reporter: richard
>Assignee: Guillaume Boué
> Fix For: 3.0.0
>
>
> When enabling cache in the pom for checkstyle via `cacheFile`, no cache file
> is ever created after the run and multiple runs are not using any cache as
> there is no speed up.
> POM:
> https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
> I am specifying the cache after line 472 with the following:
> bq. ${project.build.directory}/cachefile-sevntu
> When I specify the cache directly into the configuration file, the cache file
> is created, so this looks like an issue directly related to the maven plugin.
> I shouldn't need to specify it into the configuration since a property is
> available in the POM.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SUREFIRE-1451) sureFire Booter compatibility with NetBSD ps(1) output
[
https://issues.apache.org/jira/browse/SUREFIRE-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278420#comment-16278420
]
Tobias Nygren edited comment on SUREFIRE-1451 at 12/5/17 11:29 AM:
---
The following change solves the problem for me:
{code:none}
diff --git
a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
index 7c275845..2fc9f090 100644
---
a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
+++
b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
@@ -55,7 +55,7 @@
/**
* The etime is in the form of [[dd-]hh:]mm:ss on Unix like systems.
*/
-static final Pattern UNIX_CMD_OUT_PATTERN = compile(
"^(((\\d+)-)?(\\d{2}):)?(\\d{2}):(\\d{2})$" );
+static final Pattern UNIX_CMD_OUT_PATTERN = compile(
"^(((\\d+)-)?(\\d{1,2}):)?(\\d{1,2}):(\\d{2})$" );
private final long pluginPid;
{code}
was (Author: tnn):
The following change solves the problem for me:
{code:diff}
diff --git
a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
index 7c275845..2fc9f090 100644
---
a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
+++
b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
@@ -55,7 +55,7 @@
/**
* The etime is in the form of [[dd-]hh:]mm:ss on Unix like systems.
*/
-static final Pattern UNIX_CMD_OUT_PATTERN = compile(
"^(((\\d+)-)?(\\d{2}):)?(\\d{2}):(\\d{2})$" );
+static final Pattern UNIX_CMD_OUT_PATTERN = compile(
"^(((\\d+)-)?(\\d{1,2}):)?(\\d{1,2}):(\\d{2})$" );
private final long pluginPid;
{code}
> sureFire Booter compatibility with NetBSD ps(1) output
> --
>
> Key: SUREFIRE-1451
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1451
> Project: Maven Surefire
> Issue Type: Bug
> Components: process forking
>Affects Versions: 2.20.1
> Environment: NetBSD
>Reporter: Tobias Nygren
>Priority: Minor
>
> On NetBSD The /bin/ps command reports time as 0:01 rather than 00:01 for
> intervals shorter than 10 minutes.
> The pattern as used [here in SureFire
> Booter|https://github.com/apache/maven-surefire/commit/c343cc412b986fd9da839696c709542d03679d68#diff-33826e7c2cc48fb008e88914fd841d10R71]
> to parse ps(1) output does not take this into account.
> printf(3) logic for ps(1) can be found in the [ps
> source|https://github.com/NetBSD/src/blob/9160f3e067c6f959b9ecb4296771d8a6ae9b3ee6/bin/ps/print.c#L832].
> The following patterns are possible and need to be accounted for:
> * m:ss
> * mm:ss
> * h:mm:ss
> * hh:mm:ss
> * d-hh:mm:ss
> * dd-hh:mm:ss
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1451) sureFire Booter compatibility with NetBSD ps(1) output
[
https://issues.apache.org/jira/browse/SUREFIRE-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278420#comment-16278420
]
Tobias Nygren commented on SUREFIRE-1451:
-
The following change solves the problem for me:
{code:diff}
diff --git
a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
index 7c275845..2fc9f090 100644
---
a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
+++
b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
@@ -55,7 +55,7 @@
/**
* The etime is in the form of [[dd-]hh:]mm:ss on Unix like systems.
*/
-static final Pattern UNIX_CMD_OUT_PATTERN = compile(
"^(((\\d+)-)?(\\d{2}):)?(\\d{2}):(\\d{2})$" );
+static final Pattern UNIX_CMD_OUT_PATTERN = compile(
"^(((\\d+)-)?(\\d{1,2}):)?(\\d{1,2}):(\\d{2})$" );
private final long pluginPid;
{code}
> sureFire Booter compatibility with NetBSD ps(1) output
> --
>
> Key: SUREFIRE-1451
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1451
> Project: Maven Surefire
> Issue Type: Bug
> Components: process forking
>Affects Versions: 2.20.1
> Environment: NetBSD
>Reporter: Tobias Nygren
>Priority: Minor
>
> On NetBSD The /bin/ps command reports time as 0:01 rather than 00:01 for
> intervals shorter than 10 minutes.
> The pattern as used [here in SureFire
> Booter|https://github.com/apache/maven-surefire/commit/c343cc412b986fd9da839696c709542d03679d68#diff-33826e7c2cc48fb008e88914fd841d10R71]
> to parse ps(1) output does not take this into account.
> printf(3) logic for ps(1) can be found in the [ps
> source|https://github.com/NetBSD/src/blob/9160f3e067c6f959b9ecb4296771d8a6ae9b3ee6/bin/ps/print.c#L832].
> The following patterns are possible and need to be accounted for:
> * m:ss
> * mm:ss
> * h:mm:ss
> * hh:mm:ss
> * d-hh:mm:ss
> * dd-hh:mm:ss
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (SUREFIRE-1451) sureFire Booter compatibility with NetBSD ps(1) output
Tobias Nygren created SUREFIRE-1451: --- Summary: sureFire Booter compatibility with NetBSD ps(1) output Key: SUREFIRE-1451 URL: https://issues.apache.org/jira/browse/SUREFIRE-1451 Project: Maven Surefire Issue Type: Bug Components: process forking Affects Versions: 2.20.1 Environment: NetBSD Reporter: Tobias Nygren Priority: Minor On NetBSD The /bin/ps command reports time as 0:01 rather than 00:01 for intervals shorter than 10 minutes. The pattern as used [here in SureFire Booter|https://github.com/apache/maven-surefire/commit/c343cc412b986fd9da839696c709542d03679d68#diff-33826e7c2cc48fb008e88914fd841d10R71] to parse ps(1) output does not take this into account. printf(3) logic for ps(1) can be found in the [ps source|https://github.com/NetBSD/src/blob/9160f3e067c6f959b9ecb4296771d8a6ae9b3ee6/bin/ps/print.c#L832]. The following patterns are possible and need to be accounted for: * m:ss * mm:ss * h:mm:ss * hh:mm:ss * d-hh:mm:ss * dd-hh:mm:ss -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1450) TestNG Listener aren't working from Property Tag in POM With JDK9
[ https://issues.apache.org/jira/browse/SUREFIRE-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hammad updated SUREFIRE-1450: - Summary: TestNG Listener aren't working from Property Tag in POM With JDK9 (was: TestNG Listener aren't working With JDK9) > TestNG Listener aren't working from Property Tag in POM With JDK9 > - > > Key: SUREFIRE-1450 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1450 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin, TestNG > support >Affects Versions: 2.20.1 > Environment: macOS + Ubuntu, JDK9 >Reporter: Hammad > Labels: newbie > > TestNG Listener are not working when using: > Maven = Apache Maven 3.5.2 > JDK9 on either platform (sierra+ubuntu) > Here is relevant repo: https://github.com/HammadHost/poc_testng_surefire > I executed it with jdk8 in same environment listener did work, but they > aren't working with JDK9 > FYI: > https://stackoverflow.com/questions/47560412/maven-surefire-is-not-respecting-testng-listeners-in-property-tag -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SUREFIRE-1450) TestNG Listener aren't working from Property Tag in POM.xml With JDK9
[ https://issues.apache.org/jira/browse/SUREFIRE-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hammad updated SUREFIRE-1450: - Summary: TestNG Listener aren't working from Property Tag in POM.xml With JDK9 (was: TestNG Listener aren't working from Property Tag in POM With JDK9) > TestNG Listener aren't working from Property Tag in POM.xml With JDK9 > - > > Key: SUREFIRE-1450 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1450 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin, TestNG > support >Affects Versions: 2.20.1 > Environment: macOS + Ubuntu, JDK9 >Reporter: Hammad > Labels: newbie > > TestNG Listener are not working when using: > Maven = Apache Maven 3.5.2 > JDK9 on either platform (sierra+ubuntu) > Here is relevant repo: https://github.com/HammadHost/poc_testng_surefire > I executed it with jdk8 in same environment listener did work, but they > aren't working with JDK9 > FYI: > https://stackoverflow.com/questions/47560412/maven-surefire-is-not-respecting-testng-listeners-in-property-tag -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SUREFIRE-1450) TestNG Listener aren't working With JDK9
Hammad created SUREFIRE-1450: Summary: TestNG Listener aren't working With JDK9 Key: SUREFIRE-1450 URL: https://issues.apache.org/jira/browse/SUREFIRE-1450 Project: Maven Surefire Issue Type: Bug Components: Maven Failsafe Plugin, Maven Surefire Plugin, TestNG support Affects Versions: 2.20.1 Environment: macOS + Ubuntu, JDK9 Reporter: Hammad TestNG Listener are not working when using: Maven = Apache Maven 3.5.2 JDK9 on either platform (sierra+ubuntu) Here is relevant repo: https://github.com/HammadHost/poc_testng_surefire I executed it with jdk8 in same environment listener did work, but they aren't working with JDK9 FYI: https://stackoverflow.com/questions/47560412/maven-surefire-is-not-respecting-testng-listeners-in-property-tag -- This message was sent by Atlassian JIRA (v6.4.14#64029)
