[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Roman Ivanov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304642#comment-16304642
 ] 

Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 4:42 PM:


It might be off topic here, 
but it would be awesome to upgrade checkstyleVersion to 7.X release but this 
will require upgrade of plugin to jdk8 , as it was major update for Checkstyle 
http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 .
can you help us to upgrade to jdk8 parent poms and . , we will contribute 
all other checkstyle related update, I could create separate issue on this if 
you agree to help. I will be definitely for 2.19 release 


was (Author: romani):
It might be off topic here, 
but it would be awesome to upgrade checkstyleVersion to 7.X release but this 
will require upgrade of plugin to jdk8 , as it was major update for Checkstyle 
http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 .
can you help us to upgrade to jdk8 parent poms and . , we will contribute 
all other checkstyle related update, I could create separate issue on this if 
you agree to help.

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Roman Ivanov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304641#comment-16304641
 ] 

Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 4:41 PM:


{quote} If there are other issues which should be part of this release, let me 
know. {quote}

please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
 1.${javaVersion}
 1.${javaVersion}
 3.0
-6.18
+6.19
 1.4
 3.4
   
{code}

this is the last checkstyle release for jdk7. 
it is good to do 2.18 plugin release in such state.


was (Author: romani):
{quote} If there are other issues which should be part of this release, let me 
know. {quote}

please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
 1.${javaVersion}
 1.${javaVersion}
 3.0
-6.18
+6.19
 1.4
 3.4
   
{code}

this is the last checkstyle release for jdk7. 
it is good to release plugin.

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Roman Ivanov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304642#comment-16304642
 ] 

Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 4:39 PM:


It might be off topic here, 
but it would be awesome to upgrade checkstyleVersion to 7.X release but this 
will require upgrade of plugin to jdk8 , as it was major update for Checkstyle 
http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 .
can you help us to upgrade to jdk8 parent poms and . , we will contribute 
all other checkstyle related update, I could create separate issue on this if 
you agree to help.


was (Author: romani):
It might be off topic here, 
but it would be awesome to upgrade checkstyleVersion to 7.X release but this 
will require upgrade of plugin to jdk8 , as it major update for Checkstyle 
http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 .
can you help us to upgrade to jdk8 parent poms and . , we will contribute 
all other checkstyle related update, I could create separate issue on this if 
you agree to help.

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Roman Ivanov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304641#comment-16304641
 ] 

Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 4:37 PM:


{quote} If there are other issues which should be part of this release, let me 
know. {quote}

please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
 1.${javaVersion}
 1.${javaVersion}
 3.0
-6.18
+6.19
 1.4
 3.4
   
{code}

this is the last checkstyle release for jdk7. 
it is good to release plugin.


was (Author: romani):
{quote} If there are other issues which should be part of this release, let me 
know. {quote}

please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
 1.${javaVersion}
 1.${javaVersion}
 3.0
-6.18
+6.19
 1.4
 3.4
   
{code}

this is the last checkstyle release for jdk7. 

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Roman Ivanov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304642#comment-16304642
 ] 

Roman Ivanov commented on MCHECKSTYLE-346:
--

It might be off topic here, 
but it would be awesome to upgrade checkstyleVersion to 7.X release but this 
will require upgrade of plugin to jdk8 , as it major update for Checkstyle 
http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 .
can you help us to upgrade to jdk8 parent poms and . , we will contribute 
all other checkstyle related update, I could create separate issue on this if 
you agree to help.

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Roman Ivanov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304641#comment-16304641
 ] 

Roman Ivanov commented on MCHECKSTYLE-346:
--

{quote} If there are other issues which should be part of this release, let me 
know. {quote}

please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
 1.${javaVersion}
 1.${javaVersion}
 3.0
-6.18
+6.19
 1.4
 3.4
   
{code}

this is the last checkstyle release for jdk7. 

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Roman Ivanov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304625#comment-16304625
 ] 

Roman Ivanov commented on MCHECKSTYLE-346:
--

> we're probably even in worse shape.

I do understand you. Just try to find compromise to avoid blocks.

> I can think of several other solutions, but in the end it all depends how 
> much control you want over this plugin and if the current situation is 
> acceptable. 

Please share your thoughts  , we can provide fixes (migration for new 
versions of checkstyle, as we are in full context of how to make it), but it 
would be awesome for us to know when we can expect release of such fixes.
We are completely understand that release will not be immediate, but at least 
ones in few month, or any other trigger. I know that release process is not big 
fun for engineers, and is postponed as much as possible, and  . But 
contributors will unlikely send you code if they know that release will take a 
while, so fork is better for them or do any other workaround. 
Please share your thought and thanks lot for cooperation.

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Roman Ivanov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304625#comment-16304625
 ] 

Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 3:57 PM:


{quote} we're probably even in worse shape. {quote}

I do understand you. Just try to find compromise to avoid blocks.

{quote} I can think of several other solutions, but in the end it all depends 
how much control you want over this plugin and if the current situation is 
acceptable. {quote}

Please share your thoughts  , we can provide fixes (migration for new 
versions of checkstyle, as we are in full context of how to make it), but it 
would be awesome for us to know when we can expect release of such fixes.
We are completely understand that release will not be immediate, but at least 
ones in few month, or any other trigger. I know that release process is not big 
fun for engineers, and is postponed as much as possible, and  . But 
contributors will unlikely send you code if they know that release will take a 
while, so fork is better for them or do any other workaround. 
Please share your thought and thanks lot for cooperation.


was (Author: romani):
> we're probably even in worse shape.

I do understand you. Just try to find compromise to avoid blocks.

> I can think of several other solutions, but in the end it all depends how 
> much control you want over this plugin and if the current situation is 
> acceptable. 

Please share your thoughts  , we can provide fixes (migration for new 
versions of checkstyle, as we are in full context of how to make it), but it 
would be awesome for us to know when we can expect release of such fixes.
We are completely understand that release will not be immediate, but at least 
ones in few month, or any other trigger. I know that release process is not big 
fun for engineers, and is postponed as much as possible, and  . But 
contributors will unlikely send you code if they know that release will take a 
while, so fork is better for them or do any other workaround. 
Please share your thought and thanks lot for cooperation.

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SUREFIRE-1416) maven-surefire-parser: add new method isError in ReportTestCase

2017-12-27 Thread Tibor Digana (JIRA)

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1416:
---
Fix Version/s: 2.21.0.Jigsaw

> maven-surefire-parser: add new method isError in ReportTestCase
> ---
>
> Key: SUREFIRE-1416
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1416
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Reporter: Simon Urli
>Assignee: Tibor Digana
>Priority: Minor
> Fix For: 2.21.0.Jigsaw
>
>
> There is currently no way after parsing test suite to know if a test case is 
> a failure or an error. I need a boolean isError in ReportTestCase and 
> associated getter and setter, to be able to use properly the 
> maven-surefire-parser API to know if a test is considered as an error or as a 
> failure, without consulting the logs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription

2017-12-27 Thread Tibor Digana (JIRA)

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1372:
---
Fix Version/s: (was: 2.21.1)
   2.21.0.Jigsaw

> Rerunning failing tests fails in combination with 
> Description#createSuiteDescription
> 
>
> Key: SUREFIRE-1372
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1372
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: M.P. Korstanje
>Assignee: Tibor Digana
> Fix For: 2.21.0.Jigsaw
>
>
> When using surefire to rerun failing tests created by a Runner that uses 
> {noformat}Description#createSuiteDescription{noformat} with a human readable 
> name rather then a class name the following stack trace occurs:
> {code}
> org.apache.maven.surefire.testset.TestSetFailedException: Unable to create 
> test class 'Scenario: Fail when running'
> at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:385)
> at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
> at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> Caused by: java.lang.ClassNotFoundException: Scenario: Fail when running
> at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:379)
> at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
> at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SUREFIRE-1416) maven-surefire-parser: add new method isError in ReportTestCase

2017-12-27 Thread Tibor Digana (JIRA)

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana reassigned SUREFIRE-1416:
--

Assignee: Tibor Digana

> maven-surefire-parser: add new method isError in ReportTestCase
> ---
>
> Key: SUREFIRE-1416
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1416
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Reporter: Simon Urli
>Assignee: Tibor Digana
>Priority: Minor
>
> There is currently no way after parsing test suite to know if a test case is 
> a failure or an error. I need a boolean isError in ReportTestCase and 
> associated getter and setter, to be able to use properly the 
> maven-surefire-parser API to know if a test is considered as an error or as a 
> failure, without consulting the logs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SUREFIRE-1455) JaCoCo on integration tests

2017-12-27 Thread Tibor Digana (JIRA)
Tibor Digana created SUREFIRE-1455:
--

 Summary: JaCoCo on integration tests
 Key: SUREFIRE-1455
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1455
 Project: Maven Surefire
  Issue Type: Task
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 2.21.0.Jigsaw






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SUREFIRE-1416) maven-surefire-parser: add new method isError in ReportTestCase

2017-12-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304595#comment-16304595
 ] 

ASF GitHub Bot commented on SUREFIRE-1416:
--

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/143
  
@surli 
I had to change you code in new branch

https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1416
Can you build the version `2.21.0-SNAPSHOT` using `mvn install -DskipTests` 
and let me know if the report site works for you? I want to include this fix in 
release in several days.


> maven-surefire-parser: add new method isError in ReportTestCase
> ---
>
> Key: SUREFIRE-1416
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1416
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Reporter: Simon Urli
>Priority: Minor
>
> There is currently no way after parsing test suite to know if a test case is 
> a failure or an error. I need a boolean isError in ReportTestCase and 
> associated getter and setter, to be able to use properly the 
> maven-surefire-parser API to know if a test is considered as an error or as a 
> failure, without consulting the logs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] maven-surefire issue #143: [SUREFIRE-1416] maven-surefire-parser: add new me...

2017-12-27 Thread Tibor17
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/143
  
@surli 
I had to change you code in new branch

https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1416
Can you build the version `2.21.0-SNAPSHOT` using `mvn install -DskipTests` 
and let me know if the report site works for you? I want to include this fix in 
release in several days.


---


[jira] [Commented] (MJAVADOC-504) NullPointerException in JavadocUtil.getJavaHome() when JAVA_HOME isn't set

2017-12-27 Thread Robert Scholte (JIRA)

[ 
https://issues.apache.org/jira/browse/MJAVADOC-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304566#comment-16304566
 ] 

Robert Scholte commented on MJAVADOC-504:
-

I agree, we should improve {{JavadocUtil.getJavaHome}} to check for 
{{java.home}} in case {{JAVA_HOME}} was not set. IDEs probably suffer with the 
same problem.
But can't be fixed yet due to an svn2git migration issue

> NullPointerException in JavadocUtil.getJavaHome() when JAVA_HOME isn't set
> --
>
> Key: MJAVADOC-504
> URL: https://issues.apache.org/jira/browse/MJAVADOC-504
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Debian, OpenJDK 8
>Reporter: Emmanuel Bourg
>
> Hi,
> After upgrading to maven-javadoc-plugin I noticed a NullPointerException in 
> {{JavadocUtil.getJavaHome()}} when the JAVA_HOME environment variable isn't 
> set:
> {noformat}
> java.lang.NullPointerException
> at java.io.File. (File.java:277)
> at org.apache.maven.plugins.javadoc.JavadocUtil.getJavaHome 
> (JavadocUtil.java:1302)
> at org.apache.maven.plugins.javadoc.JavadocUtil.invokeMaven 
> (JavadocUtil.java:941)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getModulesLinks 
> (AbstractJavadocMojo.java:5640)
> at 
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addLinkofflineArguments 
> (AbstractJavadocMojo.java:4046)
> at 
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addStandardDocletOptions 
> (AbstractJavadocMojo.java:4936)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport 
> (AbstractJavadocMojo.java:2074)
> at org.apache.maven.plugins.javadoc.JavadocReport.generate 
> (JavadocReport.java:134)
> at org.apache.maven.plugins.javadoc.JavadocReport.doExecute 
> (JavadocReport.java:329)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.execute 
> (AbstractJavadocMojo.java:1909)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:993)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:345)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:191)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:180)
> {noformat}
> This error doesn't occur with the version 3.0.0-M1 or when JAVA_HOME is set. 
> It can be reproduced on the byte-buddy project:
> {code}
> git clone https://github.com/raphw/byte-buddy
> cd byte-buddy
> git checkout byte-buddy-1.7.9
> mvn org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:javadoc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MJAVADOC-504) NullPointerException in JavadocUtil.getJavaHome() when JAVA_HOME isn't set

2017-12-27 Thread Emmanuel Bourg (JIRA)

[ 
https://issues.apache.org/jira/browse/MJAVADOC-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304543#comment-16304543
 ] 

Emmanuel Bourg commented on MJAVADOC-504:
-

A BuildException wouldn't really help, that would still be a regression 
compared to the previous versions.

> NullPointerException in JavadocUtil.getJavaHome() when JAVA_HOME isn't set
> --
>
> Key: MJAVADOC-504
> URL: https://issues.apache.org/jira/browse/MJAVADOC-504
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Debian, OpenJDK 8
>Reporter: Emmanuel Bourg
>
> Hi,
> After upgrading to maven-javadoc-plugin I noticed a NullPointerException in 
> {{JavadocUtil.getJavaHome()}} when the JAVA_HOME environment variable isn't 
> set:
> {noformat}
> java.lang.NullPointerException
> at java.io.File. (File.java:277)
> at org.apache.maven.plugins.javadoc.JavadocUtil.getJavaHome 
> (JavadocUtil.java:1302)
> at org.apache.maven.plugins.javadoc.JavadocUtil.invokeMaven 
> (JavadocUtil.java:941)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getModulesLinks 
> (AbstractJavadocMojo.java:5640)
> at 
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addLinkofflineArguments 
> (AbstractJavadocMojo.java:4046)
> at 
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addStandardDocletOptions 
> (AbstractJavadocMojo.java:4936)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport 
> (AbstractJavadocMojo.java:2074)
> at org.apache.maven.plugins.javadoc.JavadocReport.generate 
> (JavadocReport.java:134)
> at org.apache.maven.plugins.javadoc.JavadocReport.doExecute 
> (JavadocReport.java:329)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.execute 
> (AbstractJavadocMojo.java:1909)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:993)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:345)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:191)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:180)
> {noformat}
> This error doesn't occur with the version 3.0.0-M1 or when JAVA_HOME is set. 
> It can be reproduced on the byte-buddy project:
> {code}
> git clone https://github.com/raphw/byte-buddy
> cd byte-buddy
> git checkout byte-buddy-1.7.9
> mvn org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:javadoc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Robert Scholte (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304524#comment-16304524
 ] 

Robert Scholte commented on MCHECKSTYLE-346:


https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/master/ 
plugin is stable now.
If there are other issues which should be part of this release, let me know.

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MCHECKSTYLE-346) Release a new version

2017-12-27 Thread Robert Scholte (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304493#comment-16304493
 ] 

Robert Scholte commented on MCHECKSTYLE-346:


bq. Checkstyle team is small ...

We have the same issue with regard to active committers and comparing this with 
the code to maintain we're probably even in worse shape.

We cannot isolate access to just one plugin, so letting one of you join the 
team just to maintain this plugin is unlikely to happen. 
I can think of several other solutions, but in the end it all depends how much 
control you want over this plugin and if the current situation is acceptable. 
This might require to ping the team when necessary. 

> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed 
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this 
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for 
> fixes and functionality needed. As it is now, we cannot remove old deprecated 
> code from our utility as the plugin relies on them too much and breaks if 
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to 
> update the code base. Why is this? Is there something that prevents you from 
> creating a new release? Do you lack personnel of some kind? Is it possible to 
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking 
> compatibility with the plugin in newer versions as this project seems to have 
> run stagnant and is lacking support. If compatibility is broken, the current 
> plugin released will then only work with old and outdated versions. I, and I 
> am sure the community, don't wish to see this happen but the checkstyle 
> utility needs to keep evolving and remove outdated code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MJAVADOC-504) NullPointerException in JavadocUtil.getJavaHome() when JAVA_HOME isn't set

2017-12-27 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MJAVADOC-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304478#comment-16304478
 ] 

Michael Osipov commented on MJAVADOC-504:
-

That's correct,  I completely forgot it. Some components won't run. Do you 
expect to see a {{BuildException}}?

> NullPointerException in JavadocUtil.getJavaHome() when JAVA_HOME isn't set
> --
>
> Key: MJAVADOC-504
> URL: https://issues.apache.org/jira/browse/MJAVADOC-504
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
> Environment: Debian, OpenJDK 8
>Reporter: Emmanuel Bourg
>
> Hi,
> After upgrading to maven-javadoc-plugin I noticed a NullPointerException in 
> {{JavadocUtil.getJavaHome()}} when the JAVA_HOME environment variable isn't 
> set:
> {noformat}
> java.lang.NullPointerException
> at java.io.File. (File.java:277)
> at org.apache.maven.plugins.javadoc.JavadocUtil.getJavaHome 
> (JavadocUtil.java:1302)
> at org.apache.maven.plugins.javadoc.JavadocUtil.invokeMaven 
> (JavadocUtil.java:941)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getModulesLinks 
> (AbstractJavadocMojo.java:5640)
> at 
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addLinkofflineArguments 
> (AbstractJavadocMojo.java:4046)
> at 
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addStandardDocletOptions 
> (AbstractJavadocMojo.java:4936)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport 
> (AbstractJavadocMojo.java:2074)
> at org.apache.maven.plugins.javadoc.JavadocReport.generate 
> (JavadocReport.java:134)
> at org.apache.maven.plugins.javadoc.JavadocReport.doExecute 
> (JavadocReport.java:329)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.execute 
> (AbstractJavadocMojo.java:1909)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:993)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:345)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:191)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:180)
> {noformat}
> This error doesn't occur with the version 3.0.0-M1 or when JAVA_HOME is set. 
> It can be reproduced on the byte-buddy project:
> {code}
> git clone https://github.com/raphw/byte-buddy
> cd byte-buddy
> git checkout byte-buddy-1.7.9
> mvn org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:javadoc
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)