[jira] [Commented] (MNG-6428) IT for MNG-5958 fails on Java 9+
[
https://issues.apache.org/jira/browse/MNG-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514565#comment-16514565
]
Hudson commented on MNG-6428:
-
Build succeeded in Jenkins: Maven TLP » maven » master #26
See https://builds.apache.org/job/maven-box/job/maven/job/master/26/
> IT for MNG-5958 fails on Java 9+
>
>
> Key: MNG-6428
> URL: https://issues.apache.org/jira/browse/MNG-6428
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> The failure lies in the parsing of the error log. It expects:
> {noformat}
> verifier.verifyTextInLog( "[ERROR] Internal error:
> java.lang.ClassCastException: "
> + "org.apache.maven.lifecycle.mapping.LifecyclePhase cannot
> be cast to java.lang.String -> [Help 1]" );
> {noformat}
> while Java 9+ includes the module name:
> {noformat}
> [ERROR] Internal error: java.lang.ClassCastException:
> org.apache.maven.lifecycle.mapping.LifecyclePhase cannot be cast to
> java.base/java.lang.String -> [Help 1]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-5958) java.lang.String cannot be cast to org.apache.maven.lifecycle.mapping.LifecyclePhase
[
https://issues.apache.org/jira/browse/MNG-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514566#comment-16514566
]
Hudson commented on MNG-5958:
-
Build succeeded in Jenkins: Maven TLP » maven » master #26
See https://builds.apache.org/job/maven-box/job/maven/job/master/26/
> java.lang.String cannot be cast to
> org.apache.maven.lifecycle.mapping.LifecyclePhase
>
>
> Key: MNG-5958
> URL: https://issues.apache.org/jira/browse/MNG-5958
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle
>Affects Versions: 3.3.9
> Environment: win 8.1
>Reporter: Meytal Genah
>Assignee: Christian Schulte
>Priority: Minor
> Fix For: 3.5.0-alpha-1, 3.5.0
>
>
> Our app uses flex mojo.
> We upgraded from Maven 3.3.3 to Maven 3.3.9 and when building we get:
> {noformat}[ERROR] Internal error: java.lang.ClassCastException:
> java.lang.String cannot be cast to
> org.apache.maven.lifecycle.mapping.LifecyclePhase -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.lang.ClassCastException: java.lang.String cannot be cast to
> org.apache.maven.lifecycle.mapping.LifecyclePhas
> e
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:121)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to
> org.apache.maven.lifecycle.mapping.LifecyclePhase
> at
> org.apache.maven.lifecycle.internal.DefaultLifecyclePluginAnalyzer.getPluginsBoundByDefaultToAllLifecycles(DefaultLifecyclePluginAnalyzer.java:119)
> at
> org.apache.maven.model.plugin.DefaultLifecycleBindingsInjector.injectLifecycleBindings(DefaultLifecycleBindingsInjector.java:64)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:451)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:421)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:620)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:626)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:411)
> at
> org.apache.maven.graph.DefaultGraphBuilder.collectProjects(DefaultGraphBuilder.java:419)
> at
> org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor(DefaultGraphBuilder.java:410)
> at
> org.apache.maven.graph.DefaultGraphBuilder.build(DefaultGraphBuilder.java:83)
> at org.apache.maven.DefaultMaven.buildGraph(DefaultMaven.java:491)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:219)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> ... 11 more{noformat}
> I didn’t see anyone encountering the same problem. Maybe it is related to the
> fix of https://issues.apache.org/jira/browse/MNG-5805.
> Also, according to the stack trace, the invalid casting is in this line:
> {code:java}LifecyclePhase goals =
> goalsForLifecyclePhase.getValue();{code}
> this is the content of the pom.xml:
> {code:xml}http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd";>
> 4.0.0
>
>com.myapp.plugin
> GUI
> tru
[jira] [Commented] (MNG-1957) clause in the activation section has to provide more complex expressions.
[ https://issues.apache.org/jira/browse/MNG-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514564#comment-16514564 ] Hudson commented on MNG-1957: - Build succeeded in Jenkins: Maven TLP » maven » master #26 See https://builds.apache.org/job/maven-box/job/maven/job/master/26/ > clause in the activation section has to provide more complex > expressions. > - > > Key: MNG-1957 > URL: https://issues.apache.org/jira/browse/MNG-1957 > Project: Maven > Issue Type: Improvement > Components: POM >Affects Versions: 2.0, 2.0.1 >Reporter: Trustin Lee >Assignee: Brett Porter >Priority: Major > Fix For: 2.1.0 > > Attachments: MNG-1957-maven-project.patch > > > For now, provides only one operator '!' which means negation, but > it would be great if i can use '+' and ~ operator: > 1.5+ > 1.1 ~ 1.4 > ~ 1.3 > 1.4 ~ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6427) IT for MNG-1957 fails on Java 9+
[
https://issues.apache.org/jira/browse/MNG-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514563#comment-16514563
]
Hudson commented on MNG-6427:
-
Build succeeded in Jenkins: Maven TLP » maven » master #26
See https://builds.apache.org/job/maven-box/job/maven/job/master/26/
> IT for MNG-1957 fails on Java 9+
>
>
> Key: MNG-6427
> URL: https://issues.apache.org/jira/browse/MNG-6427
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> The execution fails with:
> {noformat}
> junit.framework.ComparisonFailure: expected: but was:
> at
> org.apache.maven.it.MavenITmng1957JdkActivationWithVersionRangeTest.testitMNG1957(MavenITmng1957JdkActivationWithVersionRangeTest.java:64)
> {noformat}
> This is caused by incorrect JDK ranges in the {{pom.xml}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6426) IT for MNG-6127 fails on Java 9+
[
https://issues.apache.org/jira/browse/MNG-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514561#comment-16514561
]
Hudson commented on MNG-6426:
-
Build succeeded in Jenkins: Maven TLP » maven » master #26
See https://builds.apache.org/job/maven-box/job/maven/job/master/26/
> IT for MNG-6127 fails on Java 9+
>
>
> Key: MNG-6426
> URL: https://issues.apache.org/jira/browse/MNG-6426
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> Failure on Java 10 in Windows:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile)
> on project mng-6127-plugin: Compilation failure
> [ERROR]
> /D:/Entwicklung/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-6127-plugin-execution-configuration-interference/plugin/src/main/java/org/apache/maven/its/mng6127/plugin/TestMojo.java:[67,13]
> try-with-resources is not supported in -source 6
> [ERROR] (use -source 7 or higher to enable try-with-resources)
> [ERROR] -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
> (default-compile) on project mng-6127-plugin: Compilation failure
> {noformat}
> The compiled plugin uses Java 7, but the code introduced in
> ee3cae93ce70f9ff1898b5c10f3cce59898923af autoresets everything to 1.6.
> Drop all occurencies of {{maven.compiler.*}} and remove the
> try-with-resources statement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6127) Fix plugin execution configuration interference
[ https://issues.apache.org/jira/browse/MNG-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514562#comment-16514562 ] Hudson commented on MNG-6127: - Build succeeded in Jenkins: Maven TLP » maven » master #26 See https://builds.apache.org/job/maven-box/job/maven/job/master/26/ > Fix plugin execution configuration interference > --- > > Key: MNG-6127 > URL: https://issues.apache.org/jira/browse/MNG-6127 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.3.9 >Reporter: Mario Krizmanic >Assignee: Robert Scholte >Priority: Major > Fix For: 3.5.2 > > > The plugin execution configuration may interfere across maven modules > included in a build in case a plugin extension provides a default > configuration. > Because the custom plugin configuration defined in the maven modules is > merged to the plugin execution configuration and the merged configuration is > re-used during building the other included maven modules, so the other maven > modules may be build using the invalid configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPOM-185) jdk10 needs maven-surefire-plugin version 2.21.0
[
https://issues.apache.org/jira/browse/MPOM-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514528#comment-16514528
]
Michael Osipov commented on MPOM-185:
-
Can confirm this for Maven Integration Testing.
> jdk10 needs maven-surefire-plugin version 2.21.0
>
>
> Key: MPOM-185
> URL: https://issues.apache.org/jira/browse/MPOM-185
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven-plugins
>Affects Versions: ASF-19
> Environment: w7, mvn 3.5.3, jdk-10.0.1
>Reporter: Tilman Hausherr
>Priority: Major
> Labels: jdk10
>
> The apache parent pom has this line
> {code}
> 2.20.1
> {code}
> however in jdk10 maven-surefire-plugin goes NPE. 2.21.0 works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-6428) IT for MNG-5958 fails on Java 9+
[
https://issues.apache.org/jira/browse/MNG-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6428.
---
Resolution: Fixed
Fixed with
[b7f0bca65ce458d70daa16d00f249cb49ba688c6|https://gitbox.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=b7f0bca65ce458d70daa16d00f249cb49ba688c6].
> IT for MNG-5958 fails on Java 9+
>
>
> Key: MNG-6428
> URL: https://issues.apache.org/jira/browse/MNG-6428
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> The failure lies in the parsing of the error log. It expects:
> {noformat}
> verifier.verifyTextInLog( "[ERROR] Internal error:
> java.lang.ClassCastException: "
> + "org.apache.maven.lifecycle.mapping.LifecyclePhase cannot
> be cast to java.lang.String -> [Help 1]" );
> {noformat}
> while Java 9+ includes the module name:
> {noformat}
> [ERROR] Internal error: java.lang.ClassCastException:
> org.apache.maven.lifecycle.mapping.LifecyclePhase cannot be cast to
> java.base/java.lang.String -> [Help 1]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MNG-6428) IT for MNG-5958 fails on Java 9+
Michael Osipov created MNG-6428:
---
Summary: IT for MNG-5958 fails on Java 9+
Key: MNG-6428
URL: https://issues.apache.org/jira/browse/MNG-6428
Project: Maven
Issue Type: Bug
Components: Integration Tests
Reporter: Michael Osipov
Assignee: Michael Osipov
The failure lies in the parsing of the error log. It expects:
{noformat}
verifier.verifyTextInLog( "[ERROR] Internal error:
java.lang.ClassCastException: "
+ "org.apache.maven.lifecycle.mapping.LifecyclePhase cannot be
cast to java.lang.String -> [Help 1]" );
{noformat}
while Java 9+ includes the module name:
{noformat}
[ERROR] Internal error: java.lang.ClassCastException:
org.apache.maven.lifecycle.mapping.LifecyclePhase cannot be cast to
java.base/java.lang.String -> [Help 1]
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-6427) IT for MNG-1957 fails on Java 9+
[
https://issues.apache.org/jira/browse/MNG-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6427.
---
Resolution: Fixed
Fixed with
[4e9454d7121132537b016eee0392b80bf2a9ebb2|https://gitbox.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=4e9454d7121132537b016eee0392b80bf2a9ebb2].
> IT for MNG-1957 fails on Java 9+
>
>
> Key: MNG-6427
> URL: https://issues.apache.org/jira/browse/MNG-6427
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> The execution fails with:
> {noformat}
> junit.framework.ComparisonFailure: expected: but was:
> at
> org.apache.maven.it.MavenITmng1957JdkActivationWithVersionRangeTest.testitMNG1957(MavenITmng1957JdkActivationWithVersionRangeTest.java:64)
> {noformat}
> This is caused by incorrect JDK ranges in the {{pom.xml}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MNG-6427) IT for MNG-1957 fails on Java 9+
Michael Osipov created MNG-6427:
---
Summary: IT for MNG-1957 fails on Java 9+
Key: MNG-6427
URL: https://issues.apache.org/jira/browse/MNG-6427
Project: Maven
Issue Type: Bug
Components: Integration Tests
Reporter: Michael Osipov
Assignee: Michael Osipov
The execution fails with:
{noformat}
junit.framework.ComparisonFailure: expected: but was:
at
org.apache.maven.it.MavenITmng1957JdkActivationWithVersionRangeTest.testitMNG1957(MavenITmng1957JdkActivationWithVersionRangeTest.java:64)
{noformat}
This is caused by incorrect JDK ranges in the {{pom.xml}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-6426) IT for MNG-6127 fails on Java 9+
[
https://issues.apache.org/jira/browse/MNG-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6426.
---
Resolution: Fixed
Fixed with
[a022c8501bc39273737a565f9c194b99dddaadf4|https://gitbox.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=a022c8501bc39273737a565f9c194b99dddaadf4].
> IT for MNG-6127 fails on Java 9+
>
>
> Key: MNG-6426
> URL: https://issues.apache.org/jira/browse/MNG-6426
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> Failure on Java 10 in Windows:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile)
> on project mng-6127-plugin: Compilation failure
> [ERROR]
> /D:/Entwicklung/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-6127-plugin-execution-configuration-interference/plugin/src/main/java/org/apache/maven/its/mng6127/plugin/TestMojo.java:[67,13]
> try-with-resources is not supported in -source 6
> [ERROR] (use -source 7 or higher to enable try-with-resources)
> [ERROR] -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
> (default-compile) on project mng-6127-plugin: Compilation failure
> {noformat}
> The compiled plugin uses Java 7, but the code introduced in
> ee3cae93ce70f9ff1898b5c10f3cce59898923af autoresets everything to 1.6.
> Drop all occurencies of {{maven.compiler.*}} and remove the
> try-with-resources statement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MNG-6426) IT for MNG-6127 fails on Java 9+
Michael Osipov created MNG-6426:
---
Summary: IT for MNG-6127 fails on Java 9+
Key: MNG-6426
URL: https://issues.apache.org/jira/browse/MNG-6426
Project: Maven
Issue Type: Bug
Components: Integration Tests
Reporter: Michael Osipov
Assignee: Michael Osipov
Failure on Java 10 in Windows:
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on
project mng-6127-plugin: Compilation failure
[ERROR]
/D:/Entwicklung/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-6127-plugin-execution-configuration-interference/plugin/src/main/java/org/apache/maven/its/mng6127/plugin/TestMojo.java:[67,13]
try-with-resources is not supported in -source 6
[ERROR] (use -source 7 or higher to enable try-with-resources)
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on
project mng-6127-plugin: Compilation failure
{noformat}
The compiled plugin uses Java 7, but the code introduced in
ee3cae93ce70f9ff1898b5c10f3cce59898923af autoresets everything to 1.6.
Drop all occurencies of {{maven.compiler.*}} and remove the try-with-resources
statement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-3525) Settings.xml allowing mirror definitions inside profiles
[
https://issues.apache.org/jira/browse/MNG-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514179#comment-16514179
]
Robert Scholte commented on MNG-3525:
-
Changing the settings.xml will have a huge impact. One of the known issues is:
should still be called settings.xml, or should it contain the version? The
reason is that developers might have multiple versions of Maven ( I have all
3.0+ released version on my machine) which should share the same settings.xml.
Including the version implies duplication of configuration.
For now: better to have multiple settings.xml and use {{\-s/\-\-settings
}} or {{\-gs/\-\-global-settings }} to separate them per environment
> Settings.xml allowing mirror definitions inside profiles
>
>
> Key: MNG-3525
> URL: https://issues.apache.org/jira/browse/MNG-3525
> Project: Maven
> Issue Type: Improvement
> Components: Profiles, Settings
>Affects Versions: 2.0.9
> Environment: N/A
>Reporter: Paul Gribben
>Priority: Major
> Fix For: Issues to be reviewed for 4.x
>
>
> I currently use Maven in 2 places
> 1. At work
> 2. Not at work
> At work we have a repository manager thus we have mirror properties in the
> settings.xml for the whole teams global settings. We also have a defined a
> number of repositories in our work profile so we can mirror these to
> different repo's managed by Archiva. Now when I work from home I have to
> comment out the mirror definitions and activate a home profile which does not
> define any repos so Maven just goes out to the WWW as normal. So the pain is
> having to comment out and un-comment the mirror settings every time I go from
> work to home and visa-versa.
> Can we not have the option to add mirrors inside profiles?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-3525) Settings.xml allowing mirror definitions inside profiles
[ https://issues.apache.org/jira/browse/MNG-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MNG-3525: Component/s: Settings > Settings.xml allowing mirror definitions inside profiles > > > Key: MNG-3525 > URL: https://issues.apache.org/jira/browse/MNG-3525 > Project: Maven > Issue Type: Improvement > Components: Profiles, Settings >Affects Versions: 2.0.9 > Environment: N/A >Reporter: Paul Gribben >Priority: Major > Fix For: Issues to be reviewed for 4.x > > > I currently use Maven in 2 places > 1. At work > 2. Not at work > At work we have a repository manager thus we have mirror properties in the > settings.xml for the whole teams global settings. We also have a defined a > number of repositories in our work profile so we can mirror these to > different repo's managed by Archiva. Now when I work from home I have to > comment out the mirror definitions and activate a home profile which does not > define any repos so Maven just goes out to the WWW as normal. So the pain is > having to comment out and un-comment the mirror settings every time I go from > work to home and visa-versa. > Can we not have the option to add mirrors inside profiles? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-3525) Settings.xml allowing mirror definitions inside profiles
[ https://issues.apache.org/jira/browse/MNG-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MNG-3525: Fix Version/s: (was: Issues to be reviewed for 3.x) Issues to be reviewed for 4.x > Settings.xml allowing mirror definitions inside profiles > > > Key: MNG-3525 > URL: https://issues.apache.org/jira/browse/MNG-3525 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 2.0.9 > Environment: N/A >Reporter: Paul Gribben >Priority: Major > Fix For: Issues to be reviewed for 4.x > > > I currently use Maven in 2 places > 1. At work > 2. Not at work > At work we have a repository manager thus we have mirror properties in the > settings.xml for the whole teams global settings. We also have a defined a > number of repositories in our work profile so we can mirror these to > different repo's managed by Archiva. Now when I work from home I have to > comment out the mirror definitions and activate a home profile which does not > define any repos so Maven just goes out to the WWW as normal. So the pain is > having to comment out and un-comment the mirror settings every time I go from > work to home and visa-versa. > Can we not have the option to add mirrors inside profiles? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPLUGIN-341) Make the plugin tool modular or at least module-ready
[
https://issues.apache.org/jira/browse/MPLUGIN-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514158#comment-16514158
]
Robert Scholte commented on MPLUGIN-341:
The usage of {{Automatic-Module-Name}} should only be used if the project is
Java 9 ready, but its dependencies don't have a module name yet. Both are not
in place for Maven and I don't expect it to happen. The only possibility to
solve the split packages issues is to make a monolith of it again, which is
exactly the opposite of modularization. And the most interesting Maven module
is maven-compat, which will always cause split packages, and we don't want them
to return in the base code.
If Maven wants to use Java modularization, it has to be rewritten with new
packages. That would imply that *all* current plugins become useless and must
be rewritten as well.
Java modules don't add much regarding reliable configuration compared to Maven.
Strong encapsulation would be cool, but that only works in combination with the
module-descriptor.
> Make the plugin tool modular or at least module-ready
> -
>
> Key: MPLUGIN-341
> URL: https://issues.apache.org/jira/browse/MPLUGIN-341
> Project: Maven Plugin Tools
> Issue Type: Improvement
>Affects Versions: 3.5.2
>Reporter: Lukas Eder
>Priority: Critical
>
> When implementing custom maven modules, it is currently not possible to make
> those plugins modular on JDK 9+. The reason for this is that there are a lot
> of split packages among the various libraries, such as the
> org.apache.maven.plugin package between:
> * org.apache.maven:maven-core:3.5.3
> * org.apache.maven:maven-plugin-api:3.5.3
> This, and the fact that there are not Automatic-Module-Name entries in the
> manifests (see
> [http://branchandbound.net/blog/java/2017/12/automatic-module-name/),] means
> that no one can currently reasonably create modular maven plugins.
> It would be cool if these two things could be fixed in the next minor or
> major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MPLUGIN-341) Make the plugin tool modular or at least module-ready
[ https://issues.apache.org/jira/browse/MPLUGIN-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MPLUGIN-341: --- Priority: Minor (was: Critical) > Make the plugin tool modular or at least module-ready > - > > Key: MPLUGIN-341 > URL: https://issues.apache.org/jira/browse/MPLUGIN-341 > Project: Maven Plugin Tools > Issue Type: Improvement >Affects Versions: 3.5.2 >Reporter: Lukas Eder >Priority: Minor > > When implementing custom maven modules, it is currently not possible to make > those plugins modular on JDK 9+. The reason for this is that there are a lot > of split packages among the various libraries, such as the > org.apache.maven.plugin package between: > * org.apache.maven:maven-core:3.5.3 > * org.apache.maven:maven-plugin-api:3.5.3 > This, and the fact that there are not Automatic-Module-Name entries in the > manifests (see > [http://branchandbound.net/blog/java/2017/12/automatic-module-name/),] means > that no one can currently reasonably create modular maven plugins. > It would be cool if these two things could be fixed in the next minor or > major release -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-223500764 :palm_tree: anyone there? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MPLUGIN-341) Make the plugin tool modular or at least module-ready
Lukas Eder created MPLUGIN-341: -- Summary: Make the plugin tool modular or at least module-ready Key: MPLUGIN-341 URL: https://issues.apache.org/jira/browse/MPLUGIN-341 Project: Maven Plugin Tools Issue Type: Improvement Affects Versions: 3.5.2 Reporter: Lukas Eder When implementing custom maven modules, it is currently not possible to make those plugins modular on JDK 9+. The reason for this is that there are a lot of split packages among the various libraries, such as the org.apache.maven.plugin package between: * org.apache.maven:maven-core:3.5.3 * org.apache.maven:maven-plugin-api:3.5.3 This, and the fact that there are not Automatic-Module-Name entries in the manifests (see [http://branchandbound.net/blog/java/2017/12/automatic-module-name/),] means that no one can currently reasonably create modular maven plugins. It would be cool if these two things could be fixed in the next minor or major release -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] sormuras opened a new pull request #27: [WIP] Add module descriptor information to ArtifactInfo
sormuras opened a new pull request #27: [WIP] Add module descriptor information to ArtifactInfo URL: https://github.com/apache/maven-indexer/pull/27 State: **proof-of-concept** Caveat: needs at least JDK 9 due to `ModuleFinder` usage This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MPOM-185) jdk10 needs maven-surefire-plugin version 2.21.0
Tilman Hausherr created MPOM-185:
Summary: jdk10 needs maven-surefire-plugin version 2.21.0
Key: MPOM-185
URL: https://issues.apache.org/jira/browse/MPOM-185
Project: Maven POMs
Issue Type: Dependency upgrade
Components: maven-plugins
Affects Versions: ASF-19
Environment: w7, mvn 3.5.3, jdk-10.0.1
Reporter: Tilman Hausherr
The apache parent pom has this line
{code}
2.20.1
{code}
however in jdk10 maven-surefire-plugin goes NPE. 2.21.0 works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MPOM-185) jdk10 needs maven-surefire-plugin version 2.21.0
[
https://issues.apache.org/jira/browse/MPOM-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilman Hausherr updated MPOM-185:
-
Labels: jdk10 (was: )
> jdk10 needs maven-surefire-plugin version 2.21.0
>
>
> Key: MPOM-185
> URL: https://issues.apache.org/jira/browse/MPOM-185
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven-plugins
>Affects Versions: ASF-19
> Environment: w7, mvn 3.5.3, jdk-10.0.1
>Reporter: Tilman Hausherr
>Priority: Major
> Labels: jdk10
>
> The apache parent pom has this line
> {code}
> 2.20.1
> {code}
> however in jdk10 maven-surefire-plugin goes NPE. 2.21.0 works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-5940) Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
[
https://issues.apache.org/jira/browse/MNG-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513560#comment-16513560
]
Hudson commented on MNG-5940:
-
Build unstable in Jenkins: Maven TLP » maven » master #24
See https://builds.apache.org/job/maven-box/job/maven/job/master/24/
> Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
> ---
>
> Key: MNG-5940
> URL: https://issues.apache.org/jira/browse/MNG-5940
> Project: Maven
> Issue Type: Improvement
> Components: core
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> At the moment the {{maven-source-plugin:jar}} goal is defined in the Maven
> super pom:
> {code:xml}
>
> true
> maven-source-plugin
>
>
> attach-sources
>
> jar
>
>
>
>
> {code}
> where the goal of {{maven-source-plugin}} should be changed from {{jar}} into
> {{jar-no-fork}}, cause most of the time you need to override this behaviour.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] cardil commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on a change in pull request #112: Adding support for
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r195661271
##
File path:
surefire-its/src/test/resources/testng-parallel-suites/src/test/java/testng/suiteXml/TestNGSuiteTest.java
##
@@ -28,16 +28,23 @@
* @author mailto:tibordig...@apache.org";>Tibor Digana (tibor17)
* @since 2.19
*/
-public class TestNGSuiteTest {
- private static final AtomicInteger counter = new AtomicInteger();
+public class TestNGSuiteTest
+{
+private static final AtomicInteger counter = new AtomicInteger();
- @Test
- public void shouldRunAndPrintItself()
- throws Exception
- {
- System.out.println( getClass().getSimpleName() +
"#shouldRunAndPrintItself() "
- +
counter.incrementAndGet() + ".");
+@Test
+public void shouldRunAndPrintItself() throws Exception
+{
+String message = String.format(
+"%s#shouldRunAndPrintItself() %d.",
+getClass().getSimpleName(),
+counter.incrementAndGet()
+);
+TimeUnit.SECONDS.sleep( 1 );
- TimeUnit.SECONDS.sleep( 2 );
- }
+synchronized ( System.out )
Review comment:
I've explained it in commit message:
https://github.com/apache/maven-surefire/commit/2beb507001867dc61f2be55d206c5825e9f0c2ca
> Fixing flaky test Surefire1177TestngParallelSuitesIT
>
> This test rely on displaying messages on System.out, but invocations
wasn't synchronized so messeges tend to interweave and test wasn't able to
assert for them properly. I added synchronization and move code a litle bit.
Test asserts that messages should be either:
```
TestNGSuiteTest#shouldRunAndPrintItself() 1.
TestNGSuiteTest#shouldRunAndPrintItself() 2.
```
or
```
TestNGSuiteTest#shouldRunAndPrintItself() 2.
TestNGSuiteTest#shouldRunAndPrintItself() 1.
```
And without synchronization it often was something like this:
```
TestNGSuitTestNGSuiteTeTest#shouldRunAndPrintItself() 1.
est#shouldRunAndPrintItself() 2.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cardil commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on a change in pull request #112: Adding support for
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r195661271
##
File path:
surefire-its/src/test/resources/testng-parallel-suites/src/test/java/testng/suiteXml/TestNGSuiteTest.java
##
@@ -28,16 +28,23 @@
* @author mailto:tibordig...@apache.org";>Tibor Digana (tibor17)
* @since 2.19
*/
-public class TestNGSuiteTest {
- private static final AtomicInteger counter = new AtomicInteger();
+public class TestNGSuiteTest
+{
+private static final AtomicInteger counter = new AtomicInteger();
- @Test
- public void shouldRunAndPrintItself()
- throws Exception
- {
- System.out.println( getClass().getSimpleName() +
"#shouldRunAndPrintItself() "
- +
counter.incrementAndGet() + ".");
+@Test
+public void shouldRunAndPrintItself() throws Exception
+{
+String message = String.format(
+"%s#shouldRunAndPrintItself() %d.",
+getClass().getSimpleName(),
+counter.incrementAndGet()
+);
+TimeUnit.SECONDS.sleep( 1 );
- TimeUnit.SECONDS.sleep( 2 );
- }
+synchronized ( System.out )
Review comment:
I've explained it in commit message:
https://github.com/apache/maven-surefire/commit/2beb507001867dc61f2be55d206c5825e9f0c2ca
> Fixing flaky test Surefire1177TestngParallelSuitesIT
>
> This test rely on displaying messages on System.out, but invocations
wasn't synchronized so messeges tend to interweave and test wasn't able to
assert for them properly. I added synchronization and move code a litle bit.
Test asserts that messages should be either:
```
TestNGSuiteTest#shouldRunAndPrintItself() 1.
TestNGSuiteTest#shouldRunAndPrintItself() 2.
```
or
```
TestNGSuiteTest#shouldRunAndPrintItself() 1.
TestNGSuiteTest#shouldRunAndPrintItself() 2.
```
And without synchronization it often was something like this:
```
TestNGSuitTestNGSuiteTeTest#shouldRunAndPrintItself() 1.
est#shouldRunAndPrintItself() 2.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cardil commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on a change in pull request #112: Adding support for
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r195661271
##
File path:
surefire-its/src/test/resources/testng-parallel-suites/src/test/java/testng/suiteXml/TestNGSuiteTest.java
##
@@ -28,16 +28,23 @@
* @author mailto:tibordig...@apache.org";>Tibor Digana (tibor17)
* @since 2.19
*/
-public class TestNGSuiteTest {
- private static final AtomicInteger counter = new AtomicInteger();
+public class TestNGSuiteTest
+{
+private static final AtomicInteger counter = new AtomicInteger();
- @Test
- public void shouldRunAndPrintItself()
- throws Exception
- {
- System.out.println( getClass().getSimpleName() +
"#shouldRunAndPrintItself() "
- +
counter.incrementAndGet() + ".");
+@Test
+public void shouldRunAndPrintItself() throws Exception
+{
+String message = String.format(
+"%s#shouldRunAndPrintItself() %d.",
+getClass().getSimpleName(),
+counter.incrementAndGet()
+);
+TimeUnit.SECONDS.sleep( 1 );
- TimeUnit.SECONDS.sleep( 2 );
- }
+synchronized ( System.out )
Review comment:
I've explained it in commit message:
https://github.com/apache/maven-surefire/commit/2beb507001867dc61f2be55d206c5825e9f0c2ca
> Fixing flaky test Surefire1177TestngParallelSuitesIT
>
> This test rely on displaying messages on System.out, but invocations
wasn't synchronized so messeges tend to interweave and test wasn't able to
assert for them properly. I added synchronization and move code a litle bit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cardil commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on a change in pull request #112: Adding support for
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r195660396
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/util/RunOrders.java
##
@@ -0,0 +1,103 @@
+package org.apache.maven.surefire.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.annotation.ParametersAreNonnullByDefault;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * Represents a complete set of run orders with arguments
+ *
+ * @author Krzysztof
Suszyński
+ */
+@ParametersAreNonnullByDefault
+public final class RunOrders
+{
+private final List withArguments;
+
+public RunOrders( RunOrder... runOrders )
+{
+this( withEmptyArguments( runOrders ) );
+}
+
+RunOrders( List runOrders )
+{
+this.withArguments = Collections.unmodifiableList( runOrders );
+}
+
+public Iterable getIterable()
+{
+return withArguments;
+}
+
+public boolean any()
+{
+return !withArguments.isEmpty();
+}
+
+public boolean contains( RunOrder runOrder )
+{
+for ( RunOrderWithArguments order : withArguments )
+{
+if ( order.getRunOrder().equals( runOrder ) )
+{
+return true;
+}
+}
+return false;
+}
+
+public RunOrderArguments getArguments( RunOrder runOrder )
+{
+for ( RunOrderWithArguments order : withArguments )
+{
+if ( order.getRunOrder().equals( runOrder ) )
+{
+return order.getRunOrderArguments();
+}
+}
+throw new IllegalStateException( "20180524:221004 - check if contains
specific run "
++ "order before using getArguments" );
+}
+
+RunOrder firstAsType()
+{
+if ( !any() )
+{
+throw new IllegalStateException(
+"20180524:222348 - use #any() method before invoking
#firstAsType() method."
Review comment:
Oh. It is exception id. A randomly unique generated id that can be easily
traced to the place of it's origin. Its only intended for developer bugs, not
end user error communication. Its here:
https://github.com/wavesoftware/java-eid-exceptions
I use this convention so this slipped. I can remove it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
