[jira] [Created] (MNGSITE-344) Failed to collect dependencies at com.google.appengine.tools:appengine-gcs-client:jar:0.7
Villonava created MNGSITE-344: - Summary: Failed to collect dependencies at com.google.appengine.tools:appengine-gcs-client:jar:0.7 Key: MNGSITE-344 URL: https://issues.apache.org/jira/browse/MNGSITE-344 Project: Maven Project Web Site Issue Type: Bug Environment: Maven Reporter: Villonava Hello, We are using the following Maven dependency for long days com.google.appengine.tools appengine-gcs-client 0.7 com.google.guava guava com.google.appengine appengine-api-1.0-sdk javax.servlet servlet-api Till date we didn't get any problem but by today it is throwing the following issue Failed to execute goal on project myproj: Could not resolve dependencies for project com.sample:myproj:war:1.5.8.RELEASE: Failed to collect dependencies at com.google.appengine.tools:appengine-gcs-client:jar:0.7 -> com.google.api-client:google-api-client-appengine:jar:1.24.1 -> com.google.oauth-client:google-oauth-client-appengine:jar:1.24.1 -> com.google.http-client:google-http-client-appengine:jar:1.24.1: Failed to read artifact descriptor for com.google.http-client:google-http-client-appengine:jar:1.24.1: Failure to find com.google.http-client:google-http-client-parent:pom:1.24.1 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project numr: Could not resolve dependencies for project com.skyvin:numr:war:1.5.8.RELEASE: Failed to collect dependencies at com.google.appengine.tools:appengine-gcs-client:jar:0.7 -> com.google.api-client:google-api-client-appengine:jar:1.24.1 -> com.google.oauth-client:google-oauth-client-appengine:jar:1.24.1 -> com.google.http-client:google-http-client-appengine:jar:1.24.1 and I browsed and I found you have updated something in the following page : https://repo.maven.apache.org/maven2/com/google/http-client/google-http-client-appengine/1.24.1/ Please fix this issue and let me know as soon as possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (MCOMPILER-355) NPE in CompilerMojo.preparePaths on exception
[ https://issues.apache.org/jira/browse/MCOMPILER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Sutton updated MCOMPILER-355: --- Comment: was deleted (was: mvn -X deploy Apache Maven 3.5.2 Maven home: /usr/share/maven Java version: 10.0.1, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-11-openjdk-amd64 Default locale: en_AU, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-29-generic", arch: "amd64", family: "unix" WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release [DEBUG] Created new class realm maven.api [DEBUG] Importing foreign packages into class realm maven.api [DEBUG] Imported: javax.annotation.* < plexus.core [DEBUG] Imported: javax.enterprise.inject.* < plexus.core [DEBUG] Imported: javax.enterprise.util.* < plexus.core [DEBUG] Imported: javax.inject.* < plexus.core [DEBUG] Imported: org.apache.maven.* < plexus.core [DEBUG] Imported: org.apache.maven.artifact < plexus.core [DEBUG] Imported: org.apache.maven.classrealm < plexus.core [DEBUG] Imported: org.apache.maven.cli < plexus.core [DEBUG] Imported: org.apache.maven.configuration < plexus.core [DEBUG] Imported: org.apache.maven.exception < plexus.core [DEBUG] Imported: org.apache.maven.execution < plexus.core [DEBUG] Imported: org.apache.maven.execution.scope < plexus.core [DEBUG] Imported: org.apache.maven.lifecycle < plexus.core [DEBUG] Imported: org.apache.maven.model < plexus.core [DEBUG] Imported: org.apache.maven.monitor < plexus.core [DEBUG] Imported: org.apache.maven.plugin < plexus.core [DEBUG] Imported: org.apache.maven.profiles < plexus.core [DEBUG] Imported: org.apache.maven.project < plexus.core [DEBUG] Imported: org.apache.maven.reporting < plexus.core [DEBUG] Imported: org.apache.maven.repository < plexus.core [DEBUG] Imported: org.apache.maven.rtinfo < plexus.core [DEBUG] Imported: org.apache.maven.settings < plexus.core [DEBUG] Imported: org.apache.maven.toolchain < plexus.core [DEBUG] Imported: org.apache.maven.usability < plexus.core [DEBUG] Imported: org.apache.maven.wagon.* < plexus.core [DEBUG] Imported: org.apache.maven.wagon.authentication < plexus.core [DEBUG] Imported: org.apache.maven.wagon.authorization < plexus.core [DEBUG] Imported: org.apache.maven.wagon.events < plexus.core [DEBUG] Imported: org.apache.maven.wagon.observers < plexus.core [DEBUG] Imported: org.apache.maven.wagon.proxy < plexus.core [DEBUG] Imported: org.apache.maven.wagon.repository < plexus.core [DEBUG] Imported: org.apache.maven.wagon.resource < plexus.core [DEBUG] Imported: org.codehaus.classworlds < plexus.core [DEBUG] Imported: org.codehaus.plexus.* < plexus.core [DEBUG] Imported: org.codehaus.plexus.classworlds < plexus.core [DEBUG] Imported: org.codehaus.plexus.component < plexus.core [DEBUG] Imported: org.codehaus.plexus.configuration < plexus.core [DEBUG] Imported: org.codehaus.plexus.container < plexus.core [DEBUG] Imported: org.codehaus.plexus.context < plexus.core [DEBUG] Imported: org.codehaus.plexus.lifecycle < plexus.core [DEBUG] Imported: org.codehaus.plexus.logging < plexus.core [DEBUG] Imported: org.codehaus.plexus.personality < plexus.core [DEBUG] Imported: org.codehaus.plexus.util.xml.Xpp3Dom < plexus.core [DEBUG] Imported: org.codehaus.plexus.util.xml.pull.XmlPullParser < plexus.core [DEBUG] Imported: org.codehaus.plexus.util.xml.pull.XmlPullParserException < plexus.core [DEBUG] Imported: org.codehaus.plexus.util.xml.pull.XmlSerializer < plexus.core [DEBUG] Imported: org.eclipse.aether.* < plexus.core [DEBUG] Imported: org.eclipse.aether.artifact < plexus.core [DEBUG] Imported: org.eclipse.aether.collection < plexus.core [DEBUG] Imported: org.eclipse.aether.deployment < plexus.core [DEBUG] Imported: org.eclipse.aether.graph < plexus.core [DEBUG] Imported: org.eclipse.aether.impl < plexus.core [DEBUG] Imported: org.eclipse.aether.installation < plexus.core [DEBUG] Imported: org.eclipse.aether.internal.impl < plexus.core [DEBUG] Imported: org.eclipse.aether.metadata < plexus.core [DEBUG] Imported: org.eclipse.aether.repository < plexus.core [DEBUG] Imported: org.eclipse.aether.resolution < plexus.core [DEBUG] Imported: org.eclipse.aether.spi < plexus.core [DEBUG] Imported: org.eclipse.aether.transfer < plexus.core [DEBUG] Imported: org.eclipse.aether.version < plexus.core [D
[jira] [Commented] (MCOMPILER-355) NPE in CompilerMojo.preparePaths on exception
[ https://issues.apache.org/jira/browse/MCOMPILER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564718#comment-16564718 ] Brett Sutton commented on MCOMPILER-355: which mvn /usr/bin/mvn $ ls -l /usr/bin/mvn lrwxrwxrwx 1 root root 21 Oct 25 2015 /usr/bin/mvn -> /etc/alternatives/mvn $ ls -l /etc/alternatives/mvn lrwxrwxrwx 1 root root 24 Oct 25 2015 /etc/alternatives/mvn -> /usr/share/maven/bin/mvn > NPE in CompilerMojo.preparePaths on exception > - > > Key: MCOMPILER-355 > URL: https://issues.apache.org/jira/browse/MCOMPILER-355 > Project: Maven Compiler Plugin > Issue Type: Bug > Environment: ubunutu 18.04. >Reporter: Brett Sutton >Priority: Major > Attachments: testpom.zip > > > I'm getting: > > {code:java} > > Caused by: java.lang.NullPointerException > at org.apache.maven.plugin.compiler.CompilerMojo.preparePaths > (CompilerMojo.java:244) > at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute > (AbstractCompilerMojo.java:787) > at org.apache.maven.plugin.compiler.CompilerMojo.execute > (CompilerMojo.java:188) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:134) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:208) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:154) > {code} > > Appears to be caused by the exception handling assuming the 'cause' will be > non-null: > line 244 is: > {code:java} > 243 Throwable cause = pathException.getValue().getCause(); > 244 while ( cause.getCause() != null ) > 245 { > 246 cause = cause.getCause(); > 247 }{code} > > Clearly in some cases pathException.getValue().getCause() is returning null. > This occurs when I try to build a java 10 project using: > {code:java} > mvn deploy{code} > > I've narrowed the problem down to this dependancy: > {code:java} > > org.javamoney > moneta > 1.3 > pom > {code} > If you remove the above dependency then the problem goes away. > So there is likely to be two problems here. The initial NPE which should be > easy to fix and then possibly the root cause of the exception. > Full pom is: > {code:java} > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > au.com.noojee > noojeebilling.api > 1.4-SNAPSHOT > > > > src/main/java > > > maven-compiler-plugin > 3.8.0 > > 10 > > > > > > io.packagecloud.maven.wagon > maven-packagecloud-wagon > 0.0.6 > > > > > > noojee-internal > packagecloud+https://packagecloud.io/noojee/internal > > > noojee-internal > packagecloud+https://packagecloud.io/noojee/internal > > > > > > > com.google.code.gson > gson > 2.8.5 > > > > org.apache.logging.log4j > log4j-core > 2.9.1 > > > > org.javamoney > moneta > 1.3 > pom > > > > org.bouncycastle > bcprov-jdk15on > 1.59 > > > junit > junit > 4.11 > test > > > > > {code} > > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCOMPILER-355) NPE in CompilerMojo.preparePaths on exception
[ https://issues.apache.org/jira/browse/MCOMPILER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564717#comment-16564717 ] Brett Sutton commented on MCOMPILER-355: ls -la /usr/share/maven/lib total 16 drwxr-xr-x 2 root root 12288 Apr 27 18:06 . drwxr-xr-x 6 root root 4096 Oct 25 2015 .. lrwxrwxrwx 1 root root 26 Feb 24 03:38 aopalliance.jar -> ../../java/aopalliance.jar lrwxrwxrwx 1 root root 22 Feb 24 03:38 cdi-api.jar -> ../../java/cdi-api.jar lrwxrwxrwx 1 root root 26 Feb 24 03:38 commons-cli.jar -> ../../java/commons-cli.jar lrwxrwxrwx 1 root root 25 Feb 24 03:38 commons-io.jar -> ../../java/commons-io.jar lrwxrwxrwx 1 root root 28 Feb 24 03:38 commons-lang3.jar -> ../../java/commons-lang3.jar lrwxrwxrwx 1 root root 20 Feb 24 03:38 guava.jar -> ../../java/guava.jar lrwxrwxrwx 1 root root 20 Feb 24 03:38 guice.jar -> ../../java/guice.jar lrwxrwxrwx 1 root root 20 Feb 24 03:38 jansi.jar -> ../../java/jansi.jar lrwxrwxrwx 1 root root 38 Feb 24 03:38 javax.inject.jar -> ../../java/atinject-jsr330-api-1.0.jar lrwxrwxrwx 1 root root 29 Feb 24 03:38 jcl-over-slf4j.jar -> ../../java/jcl-over-slf4j.jar lrwxrwxrwx 1 root root 43 Feb 24 03:38 jsr250-api.jar -> ../../java/geronimo-annotation-1.3-spec.jar lrwxrwxrwx 1 root root 30 Feb 24 03:38 maven-artifact-3.x.jar -> ../../java/maven3-artifact.jar lrwxrwxrwx 1 root root 37 Feb 24 03:38 maven-builder-support-3.x.jar -> ../../java/maven3-builder-support.jar lrwxrwxrwx 1 root root 28 Feb 24 03:38 maven-compat-3.x.jar -> ../../java/maven3-compat.jar lrwxrwxrwx 1 root root 26 Feb 24 03:38 maven-core-3.x.jar -> ../../java/maven3-core.jar lrwxrwxrwx 1 root root 30 Feb 24 03:38 maven-embedder-3.x.jar -> ../../java/maven3-embedder.jar lrwxrwxrwx 1 root root 27 Feb 24 03:38 maven-model-3.x.jar -> ../../java/maven3-model.jar lrwxrwxrwx 1 root root 35 Feb 24 03:38 maven-model-builder-3.x.jar -> ../../java/maven3-model-builder.jar lrwxrwxrwx 1 root root 32 Feb 24 03:38 maven-plugin-api-3.x.jar -> ../../java/maven3-plugin-api.jar lrwxrwxrwx 1 root root 41 Feb 24 03:38 maven-repository-metadata-3.x.jar -> ../../java/maven3-repository-metadata.jar lrwxrwxrwx 1 root root 33 Feb 24 03:38 maven-resolver-api.jar -> ../../java/maven-resolver-api.jar lrwxrwxrwx 1 root root 45 Feb 24 03:38 maven-resolver-connector-basic.jar -> ../../java/maven-resolver-connector-basic.jar lrwxrwxrwx 1 root root 34 Feb 24 03:38 maven-resolver-impl.jar -> ../../java/maven-resolver-impl.jar lrwxrwxrwx 1 root root 39 Feb 24 03:38 maven-resolver-provider-3.x.jar -> ../../java/maven3-resolver-provider.jar lrwxrwxrwx 1 root root 33 Feb 24 03:38 maven-resolver-spi.jar -> ../../java/maven-resolver-spi.jar lrwxrwxrwx 1 root root 45 Feb 24 03:38 maven-resolver-transport-wagon.jar -> ../../java/maven-resolver-transport-wagon.jar lrwxrwxrwx 1 root root 34 Feb 24 03:38 maven-resolver-util.jar -> ../../java/maven-resolver-util.jar lrwxrwxrwx 1 root root 30 Feb 24 03:38 maven-settings-3.x.jar -> ../../java/maven3-settings.jar lrwxrwxrwx 1 root root 38 Feb 24 03:38 maven-settings-builder-3.x.jar -> ../../java/maven3-settings-builder.jar lrwxrwxrwx 1 root root 33 Feb 24 03:38 maven-shared-utils.jar -> ../../java/maven-shared-utils.jar lrwxrwxrwx 1 root root 36 Feb 24 03:38 maven-slf4j-provider-3.x.jar -> ../../java/maven3-slf4j-provider.jar lrwxrwxrwx 1 root root 28 Feb 24 03:38 plexus-cipher.jar -> ../../java/plexus-cipher.jar lrwxrwxrwx 1 root root 43 Feb 24 03:38 plexus-component-annotations.jar -> ../../java/plexus-component-annotations.jar lrwxrwxrwx 1 root root 35 Feb 24 03:38 plexus-interpolation.jar -> ../../java/plexus-interpolation.jar lrwxrwxrwx 1 root root 36 Feb 24 03:38 plexus-sec-dispatcher.jar -> ../../java/plexus-sec-dispatcher.jar lrwxrwxrwx 1 root root 28 Feb 24 03:38 plexus-utils.jar -> ../../java/plexus-utils2.jar lrwxrwxrwx 1 root root 26 Feb 24 03:38 sisu-inject.jar -> ../../java/sisu-inject.jar lrwxrwxrwx 1 root root 26 Feb 24 03:38 sisu-plexus.jar -> ../../java/sisu-plexus.jar lrwxrwxrwx 1 root root 24 Feb 24 03:38 slf4j-api.jar -> ../../java/slf4j-api.jar lrwxrwxrwx 1 root root 25 Feb 24 03:38 wagon-file.jar -> ../../java/wagon-file.jar lrwxrwxrwx 1 root root 32 Feb 24 03:38 wagon-http-shaded.jar -> ../../java/wagon-http-shaded.jar lrwxrwxrwx 1 root root 33 Feb 24 03:38 wagon-provider-api.jar -> ../../java/wagon-provider-api.jar > NPE in CompilerMojo.preparePaths on exception > - > > Key: MCOMPILER-355 > URL: https://issues.apache.org/jira/browse/MCOMPILER-355 > Project: Maven Compiler Plugin > Issue Type: Bug > Environment: ubunutu 18.04. >Reporter: Brett Sutton >Priority: Major > Attachments: testpom.zip > > > I'm getting: > > {code:java} > > Caused by: java.lang.NullPointerException > at org.apache.maven.plugin.compile
[jira] [Commented] (MCOMPILER-355) NPE in CompilerMojo.preparePaths on exception
[ https://issues.apache.org/jira/browse/MCOMPILER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564715#comment-16564715 ] Brett Sutton commented on MCOMPILER-355: mvn -X deploy Apache Maven 3.5.2 Maven home: /usr/share/maven Java version: 10.0.1, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-11-openjdk-amd64 Default locale: en_AU, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-29-generic", arch: "amd64", family: "unix" WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release [DEBUG] Created new class realm maven.api [DEBUG] Importing foreign packages into class realm maven.api [DEBUG] Imported: javax.annotation.* < plexus.core [DEBUG] Imported: javax.enterprise.inject.* < plexus.core [DEBUG] Imported: javax.enterprise.util.* < plexus.core [DEBUG] Imported: javax.inject.* < plexus.core [DEBUG] Imported: org.apache.maven.* < plexus.core [DEBUG] Imported: org.apache.maven.artifact < plexus.core [DEBUG] Imported: org.apache.maven.classrealm < plexus.core [DEBUG] Imported: org.apache.maven.cli < plexus.core [DEBUG] Imported: org.apache.maven.configuration < plexus.core [DEBUG] Imported: org.apache.maven.exception < plexus.core [DEBUG] Imported: org.apache.maven.execution < plexus.core [DEBUG] Imported: org.apache.maven.execution.scope < plexus.core [DEBUG] Imported: org.apache.maven.lifecycle < plexus.core [DEBUG] Imported: org.apache.maven.model < plexus.core [DEBUG] Imported: org.apache.maven.monitor < plexus.core [DEBUG] Imported: org.apache.maven.plugin < plexus.core [DEBUG] Imported: org.apache.maven.profiles < plexus.core [DEBUG] Imported: org.apache.maven.project < plexus.core [DEBUG] Imported: org.apache.maven.reporting < plexus.core [DEBUG] Imported: org.apache.maven.repository < plexus.core [DEBUG] Imported: org.apache.maven.rtinfo < plexus.core [DEBUG] Imported: org.apache.maven.settings < plexus.core [DEBUG] Imported: org.apache.maven.toolchain < plexus.core [DEBUG] Imported: org.apache.maven.usability < plexus.core [DEBUG] Imported: org.apache.maven.wagon.* < plexus.core [DEBUG] Imported: org.apache.maven.wagon.authentication < plexus.core [DEBUG] Imported: org.apache.maven.wagon.authorization < plexus.core [DEBUG] Imported: org.apache.maven.wagon.events < plexus.core [DEBUG] Imported: org.apache.maven.wagon.observers < plexus.core [DEBUG] Imported: org.apache.maven.wagon.proxy < plexus.core [DEBUG] Imported: org.apache.maven.wagon.repository < plexus.core [DEBUG] Imported: org.apache.maven.wagon.resource < plexus.core [DEBUG] Imported: org.codehaus.classworlds < plexus.core [DEBUG] Imported: org.codehaus.plexus.* < plexus.core [DEBUG] Imported: org.codehaus.plexus.classworlds < plexus.core [DEBUG] Imported: org.codehaus.plexus.component < plexus.core [DEBUG] Imported: org.codehaus.plexus.configuration < plexus.core [DEBUG] Imported: org.codehaus.plexus.container < plexus.core [DEBUG] Imported: org.codehaus.plexus.context < plexus.core [DEBUG] Imported: org.codehaus.plexus.lifecycle < plexus.core [DEBUG] Imported: org.codehaus.plexus.logging < plexus.core [DEBUG] Imported: org.codehaus.plexus.personality < plexus.core [DEBUG] Imported: org.codehaus.plexus.util.xml.Xpp3Dom < plexus.core [DEBUG] Imported: org.codehaus.plexus.util.xml.pull.XmlPullParser < plexus.core [DEBUG] Imported: org.codehaus.plexus.util.xml.pull.XmlPullParserException < plexus.core [DEBUG] Imported: org.codehaus.plexus.util.xml.pull.XmlSerializer < plexus.core [DEBUG] Imported: org.eclipse.aether.* < plexus.core [DEBUG] Imported: org.eclipse.aether.artifact < plexus.core [DEBUG] Imported: org.eclipse.aether.collection < plexus.core [DEBUG] Imported: org.eclipse.aether.deployment < plexus.core [DEBUG] Imported: org.eclipse.aether.graph < plexus.core [DEBUG] Imported: org.eclipse.aether.impl < plexus.core [DEBUG] Imported: org.eclipse.aether.installation < plexus.core [DEBUG] Imported: org.eclipse.aether.internal.impl < plexus.core [DEBUG] Imported: org.eclipse.aether.metadata < plexus.core [DEBUG] Imported: org.eclipse.aether.repository < plexus.core [DEBUG] Imported: org.eclipse.aether.resolution < plexus.core [DEBUG] Imported: org.eclipse.aether.spi < plexus.core [DEBUG] Imported: org.eclipse.aether.transfer < plexus.core [DEBUG] Imported: org.eclipse.aethe
[jira] [Commented] (MCOMPILER-355) NPE in CompilerMojo.preparePaths on exception
[ https://issues.apache.org/jira/browse/MCOMPILER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564714#comment-16564714 ] Brett Sutton commented on MCOMPILER-355: So I've managed to get a minimal config that will reproduce the error: Essentially you need a module-info.java and a dependency on javax.money. a mvn compile will then demonstrate the issue. zip attached.[^testpom.zip] > NPE in CompilerMojo.preparePaths on exception > - > > Key: MCOMPILER-355 > URL: https://issues.apache.org/jira/browse/MCOMPILER-355 > Project: Maven Compiler Plugin > Issue Type: Bug > Environment: ubunutu 18.04. >Reporter: Brett Sutton >Priority: Major > Attachments: testpom.zip > > > I'm getting: > > {code:java} > > Caused by: java.lang.NullPointerException > at org.apache.maven.plugin.compiler.CompilerMojo.preparePaths > (CompilerMojo.java:244) > at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute > (AbstractCompilerMojo.java:787) > at org.apache.maven.plugin.compiler.CompilerMojo.execute > (CompilerMojo.java:188) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:134) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:208) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:154) > {code} > > Appears to be caused by the exception handling assuming the 'cause' will be > non-null: > line 244 is: > {code:java} > 243 Throwable cause = pathException.getValue().getCause(); > 244 while ( cause.getCause() != null ) > 245 { > 246 cause = cause.getCause(); > 247 }{code} > > Clearly in some cases pathException.getValue().getCause() is returning null. > This occurs when I try to build a java 10 project using: > {code:java} > mvn deploy{code} > > I've narrowed the problem down to this dependancy: > {code:java} > > org.javamoney > moneta > 1.3 > pom > {code} > If you remove the above dependency then the problem goes away. > So there is likely to be two problems here. The initial NPE which should be > easy to fix and then possibly the root cause of the exception. > Full pom is: > {code:java} > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > au.com.noojee > noojeebilling.api > 1.4-SNAPSHOT > > > > src/main/java > > > maven-compiler-plugin > 3.8.0 > > 10 > > > > > > io.packagecloud.maven.wagon > maven-packagecloud-wagon > 0.0.6 > > > > > > noojee-internal > packagecloud+https://packagecloud.io/noojee/internal > > > noojee-internal > packagecloud+https://packagecloud.io/noojee/internal > > > > > > > com.google.code.gson > gson > 2.8.5 > > > > org.apache.logging.log4j > log4j-core > 2.9.1 > > > > org.javamoney > moneta > 1.3 > pom > > > > org.bouncycastle > bcprov-jdk15on > 1.59 > > > junit > junit > 4.11 > test > > > > > {code} > > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MCOMPILER-355) NPE in CompilerMojo.preparePaths on exception
[ https://issues.apache.org/jira/browse/MCOMPILER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Sutton updated MCOMPILER-355: --- Attachment: testpom.zip > NPE in CompilerMojo.preparePaths on exception > - > > Key: MCOMPILER-355 > URL: https://issues.apache.org/jira/browse/MCOMPILER-355 > Project: Maven Compiler Plugin > Issue Type: Bug > Environment: ubunutu 18.04. >Reporter: Brett Sutton >Priority: Major > Attachments: testpom.zip > > > I'm getting: > > {code:java} > > Caused by: java.lang.NullPointerException > at org.apache.maven.plugin.compiler.CompilerMojo.preparePaths > (CompilerMojo.java:244) > at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute > (AbstractCompilerMojo.java:787) > at org.apache.maven.plugin.compiler.CompilerMojo.execute > (CompilerMojo.java:188) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:134) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:208) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:154) > {code} > > Appears to be caused by the exception handling assuming the 'cause' will be > non-null: > line 244 is: > {code:java} > 243 Throwable cause = pathException.getValue().getCause(); > 244 while ( cause.getCause() != null ) > 245 { > 246 cause = cause.getCause(); > 247 }{code} > > Clearly in some cases pathException.getValue().getCause() is returning null. > This occurs when I try to build a java 10 project using: > {code:java} > mvn deploy{code} > > I've narrowed the problem down to this dependancy: > {code:java} > > org.javamoney > moneta > 1.3 > pom > {code} > If you remove the above dependency then the problem goes away. > So there is likely to be two problems here. The initial NPE which should be > easy to fix and then possibly the root cause of the exception. > Full pom is: > {code:java} > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > au.com.noojee > noojeebilling.api > 1.4-SNAPSHOT > > > > src/main/java > > > maven-compiler-plugin > 3.8.0 > > 10 > > > > > > io.packagecloud.maven.wagon > maven-packagecloud-wagon > 0.0.6 > > > > > > noojee-internal > packagecloud+https://packagecloud.io/noojee/internal > > > noojee-internal > packagecloud+https://packagecloud.io/noojee/internal > > > > > > > com.google.code.gson > gson > 2.8.5 > > > > org.apache.logging.log4j > log4j-core > 2.9.1 > > > > org.javamoney > moneta > 1.3 > pom > > > > org.bouncycastle > bcprov-jdk15on > 1.59 > > > junit > junit > 4.11 > test > > > > > {code} > > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRRESOURCES-103) Upgrade parent to 32
[ https://issues.apache.org/jira/browse/MRRESOURCES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564401#comment-16564401 ] Hudson commented on MRRESOURCES-103: Build failed in Jenkins: Maven TLP » maven-remote-resources-plugin » MRRESOURCES-103 #15 See https://builds.apache.org/job/maven-box/job/maven-remote-resources-plugin/job/MRRESOURCES-103/15/ > Upgrade parent to 32 > > > Key: MRRESOURCES-103 > URL: https://issues.apache.org/jira/browse/MRRESOURCES-103 > Project: Maven Remote Resources Plugin > Issue Type: Dependency upgrade >Affects Versions: 1.6 >Reporter: Karl Heinz Marbaise >Assignee: Robert Scholte >Priority: Minor > Fix For: 1.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] rfscholte closed pull request #37: fixed typo in dependencyConvergence.html
rfscholte closed pull request #37: fixed typo in dependencyConvergence.html URL: https://github.com/apache/maven-enforcer/pull/37 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/enforcer-rules/src/site/apt/dependencyConvergence.apt.vm b/enforcer-rules/src/site/apt/dependencyConvergence.apt.vm index bc7dcf9..55a9b02 100644 --- a/enforcer-rules/src/site/apt/dependencyConvergence.apt.vm +++ b/enforcer-rules/src/site/apt/dependencyConvergence.apt.vm @@ -24,7 +24,7 @@ Dependency Convergence - This rule requires that dependency version numbers converge. If a project has two dependencies, A and B, both depending on the same artifact, C, this rule will fail the build if A depends on a different version of C then the version of C depended on by B. + This rule requires that dependency version numbers converge. If a project has two dependencies, A and B, both depending on the same artifact, C, this rule will fail the build if A depends on a different version of C than the version of C depended on by B. Here is a concrete example. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6412) Exceeding project discovery time when using CI friendly versions
[ https://issues.apache.org/jira/browse/MNG-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564323#comment-16564323 ] Karl Heinz Marbaise commented on MNG-6412: -- Hi [~chamshoff] do you have a chance to test a SNAPSHOT build of Maven 3.6.0 ? > Exceeding project discovery time when using CI friendly versions > > > Key: MNG-6412 > URL: https://issues.apache.org/jira/browse/MNG-6412 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.3 >Reporter: Christoph Amshoff >Priority: Critical > Attachments: ci-version-validate.log, fix-version-validate.log, > test-ci-project-scanning.zip > > > We are switching a larger project to CI friendly versions > ([https://maven.apache.org/maven-ci-friendly.html]), using properties > _${revision}_ (fix) and _${changelist}_ (maps to the CI build number) to > create the actual version. However, doing so, the project discovery time > (right after Maven says “Scanning for projects...”) increases dramatically > from few seconds to more than 3 minutes, and we had to double the maximum > heap in order to avoid “GC overhead limit exceeded” exception. > The project root POM looks like this: > {noformat} > test > parent > ${revision}-${changelist} > pom > ... > > 1.0.0 > UNDEFINED > {noformat} > and is built by passing “-Dchangelist=123” to the Maven process for CI build > 123, for instance. > In debug output, we can see that for each POM of the reactor there are > messages like these, repeatedly for every single parent POM up the complete > hierarchy: > {noformat} > [DEBUG] Extension realms for project test:grandchild1-1:jar:1.0.0-123: (none) > [DEBUG] Looking up lifecycle mappings for packaging jar from > ClassRealm[plexus.core, parent: null] > [DEBUG] Extension realms for project test:child1:pom:1.0.0-123: (none) > [DEBUG] Looking up lifecycle mappings for packaging pom from > ClassRealm[plexus.core, parent: null] > [DEBUG] Extension realms for project test:parent:pom:1.0.0-123: (none) > [DEBUG] Looking up lifecycle mappings for packaging pom from > ClassRealm[plexus.core, parent: null] > {noformat} > When using fix version string (release or SNAPSHOT), these messages are only > present for the reactor POMs, but not their parents, grand-parents, etc. up > to the root POM. > Looking up the lifecycle mapping for the same parent POMs over and over again > seems wrong to me, and is probably the cause of high memory consumption. > Altogether, there are more than 2,800 messages "Looking up lifecycle > mappings..." in the logs for about 350 subprojects built in the reactor! > See attached test projects and logs for fix version vs. CI friendly versions. > The test project structure is like this: > {noformat} > parent > child1 > grandchild1-1 > grandchild1-2 > child2 > grandchild2-1 > grandchild2-2{noformat} > If you compare both log files, you'll see the difference in project resolving. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MNG-6383) ProjectBuilder unnecessarily rebuilds modules with ci-friendly versions
[ https://issues.apache.org/jira/browse/MNG-6383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-6383. Resolution: Fixed Done in [396f49d75e42900efab87e94c12d0ae1fe9ee622|https://gitbox.apache.org/repos/asf?p=maven.git;a=commitdiff;h=396f49d75e42900efab87e94c12d0ae1fe9ee622] > ProjectBuilder unnecessarily rebuilds modules with ci-friendly versions > --- > > Key: MNG-6383 > URL: https://issues.apache.org/jira/browse/MNG-6383 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.3 >Reporter: Christoph Kunze >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.6.0 > > Attachments: sample-project.tar.gz > > > Consider a multi-module project that uses ci-friendly versions (i.e. the root > pom declares ${revision}). > While "scanning for projects", the DefaultProjectBuilder (build:347) uses a > two-phase approach. > 1) build:390 populates a set of interimResults and a projectIndex. The keys > of the projectIndex take the form groupId:artifactId:packaging:version and > the version always is the interpolated version (i.e. 1.0-SNAPSHOT rather than > ${revision}). > 2) build:573 calls initProject which in line 638 attempts to retrieve the > previously constructed parent project from the projectIndex. However, the key > used here still contains the uninterpolated version (i.e. ${revision}) so > *the* *parent project is never found*. In line 652, the parent project is > therefore constructed anew: > {code:java} > parent = build( parentPomFile, projectBuildingRequest ).getProject(); > {code} > This is not only ineffective but also causes problems, e.g. if the parent > imports a bom module from the same reactor, this leads to a warning "Failed > to build parent project" and potential follow-up problems. Also, the maven > assembly plugin seems to fail on such projects. > *Details* > - The ModelBuildingResult created in the first phase contains a list of > modelIds. They key used to add an entry to the project index always > corresponds to the *first* item in this list: > {code:java} > // DefaultProjectBuilder:436 > projectIndex.put( result.getModelIds().get( 0 ), project ) > {code} > However, the key used to retrieve the entry during the processing of its > child is the *second* element from the modelIds list: > {code:java} > // DefaultProjectBuilder:636 > String parentModelId = result.getModelIds().get( 1 ); > MavenProject parent = projects.get( parentModelId ); > {code} > The list items are created by DefaultModelBuilder.build:244. First a > "lineage" of the current module is built. Then the first element of the > lineage, corresponding to the current module, gets interpolated. The other > lineage items *do not get interpolated*, i.e. they still contain the > placeholder version. > The list of modelIds is then constructed from the lineage, leading to the > first element having an interpolated version whereas all other elements have > a placeholder version. > {code:java} > // DefaultModelBuilder:411 > for ( ModelData currentData : lineage ) > { > String modelId = ( currentData != superData ) ? currentData.getId() : ""; > result.addModelId( modelId ); > {code} > *Fix* > One way to fix the issue might be to interpolate all elements of the lineage > in DefaultModelBuilder.build:244, or to at least replace their versions. > The following modification (hacky and probably faulty, for demonstration > purpose only) fixed the issue for my project: > {code:java} > // model interpolation > resultModel = interpolateModel( resultModel, request, problems ); > resultData.setModel( resultModel ); > /* new code starts here */ > if ( resultModel.getParent() != null ) > { > final ModelData parentData = lineage.get( 1 ); > final Model interpolatedParent = interpolateModel( parentData.getModel(), > request, problems ); > // parentData.setModel( interpolatedParent ); > parentData.setVersion( interpolatedParent.getVersion() ); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6383) ProjectBuilder unnecessarily rebuilds modules with ci-friendly versions
[ https://issues.apache.org/jira/browse/MNG-6383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564319#comment-16564319 ] Karl Heinz Marbaise commented on MNG-6383: -- After doing some testing with a multi module build which contains 2000 (generated) modules (tests; [generator|https://github.com/khmarbaise/maven-test-project-generator]) the result is clear a very good. This has been tested by using {{mvn -Drevision=1.0-SNAPSHOT clean}} Maven 3.5.4 * {{[INFO] Project discovery time: 12357 ms}} * overall {{[INFO] Total time: 19.037 s}} Maven 3.6.0-SNAPSHOT (on the branch): * {{[INFO] Project discovery time: 2449 ms}} * overall {{[INFO] Total time: 7.897 s}} Thanks to [~ckunze] for his code suggestions which helped a lot... > ProjectBuilder unnecessarily rebuilds modules with ci-friendly versions > --- > > Key: MNG-6383 > URL: https://issues.apache.org/jira/browse/MNG-6383 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.3 >Reporter: Christoph Kunze >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.6.0 > > Attachments: sample-project.tar.gz > > > Consider a multi-module project that uses ci-friendly versions (i.e. the root > pom declares ${revision}). > While "scanning for projects", the DefaultProjectBuilder (build:347) uses a > two-phase approach. > 1) build:390 populates a set of interimResults and a projectIndex. The keys > of the projectIndex take the form groupId:artifactId:packaging:version and > the version always is the interpolated version (i.e. 1.0-SNAPSHOT rather than > ${revision}). > 2) build:573 calls initProject which in line 638 attempts to retrieve the > previously constructed parent project from the projectIndex. However, the key > used here still contains the uninterpolated version (i.e. ${revision}) so > *the* *parent project is never found*. In line 652, the parent project is > therefore constructed anew: > {code:java} > parent = build( parentPomFile, projectBuildingRequest ).getProject(); > {code} > This is not only ineffective but also causes problems, e.g. if the parent > imports a bom module from the same reactor, this leads to a warning "Failed > to build parent project" and potential follow-up problems. Also, the maven > assembly plugin seems to fail on such projects. > *Details* > - The ModelBuildingResult created in the first phase contains a list of > modelIds. They key used to add an entry to the project index always > corresponds to the *first* item in this list: > {code:java} > // DefaultProjectBuilder:436 > projectIndex.put( result.getModelIds().get( 0 ), project ) > {code} > However, the key used to retrieve the entry during the processing of its > child is the *second* element from the modelIds list: > {code:java} > // DefaultProjectBuilder:636 > String parentModelId = result.getModelIds().get( 1 ); > MavenProject parent = projects.get( parentModelId ); > {code} > The list items are created by DefaultModelBuilder.build:244. First a > "lineage" of the current module is built. Then the first element of the > lineage, corresponding to the current module, gets interpolated. The other > lineage items *do not get interpolated*, i.e. they still contain the > placeholder version. > The list of modelIds is then constructed from the lineage, leading to the > first element having an interpolated version whereas all other elements have > a placeholder version. > {code:java} > // DefaultModelBuilder:411 > for ( ModelData currentData : lineage ) > { > String modelId = ( currentData != superData ) ? currentData.getId() : ""; > result.addModelId( modelId ); > {code} > *Fix* > One way to fix the issue might be to interpolate all elements of the lineage > in DefaultModelBuilder.build:244, or to at least replace their versions. > The following modification (hacky and probably faulty, for demonstration > purpose only) fixed the issue for my project: > {code:java} > // model interpolation > resultModel = interpolateModel( resultModel, request, problems ); > resultData.setModel( resultModel ); > /* new code starts here */ > if ( resultModel.getParent() != null ) > { > final ModelData parentData = lineage.get( 1 ); > final Model interpolatedParent = interpolateModel( parentData.getModel(), > request, problems ); > // parentData.setModel( interpolatedParent ); > parentData.setVersion( interpolatedParent.getVersion() ); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MRRESOURCES-103) Upgrade parent to 32
[ https://issues.apache.org/jira/browse/MRRESOURCES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte reassigned MRRESOURCES-103: -- Assignee: Robert Scholte (was: Karl Heinz Marbaise) > Upgrade parent to 32 > > > Key: MRRESOURCES-103 > URL: https://issues.apache.org/jira/browse/MRRESOURCES-103 > Project: Maven Remote Resources Plugin > Issue Type: Dependency upgrade >Affects Versions: 1.6 >Reporter: Karl Heinz Marbaise >Assignee: Robert Scholte >Priority: Minor > Fix For: 1.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MRRESOURCES-103) Upgrade parent to 32
[ https://issues.apache.org/jira/browse/MRRESOURCES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MRRESOURCES-103: --- Summary: Upgrade parent to 32 (was: Upgrade parent to 31) > Upgrade parent to 32 > > > Key: MRRESOURCES-103 > URL: https://issues.apache.org/jira/browse/MRRESOURCES-103 > Project: Maven Remote Resources Plugin > Issue Type: Dependency upgrade >Affects Versions: 1.6 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 1.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNGSITE-343) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNGSITE-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564290#comment-16564290 ] ASF GitHub Bot commented on MNGSITE-343: khmarbaise commented on issue #25: [MNGSITE-343] doc updated to be more clear about the plugin management URL: https://github.com/apache/maven-site/pull/25#issuecomment-409346661 Thanks for you contribution. * Merged into master https://gitbox.apache.org/repos/asf?p=maven-site.git;a=commitdiff;h=114afddb4d4a9bd7a1de3c3c60c9f5a34c73fd8e * https://issues.apache.org/jira/browse/MNGSITE-343 (closed). will be online with a few minutes...Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct the documentation for the plugin management > --- > > Key: MNGSITE-343 > URL: https://issues.apache.org/jira/browse/MNGSITE-343 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Martin Prochazka >Assignee: Karl Heinz Marbaise >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNGSITE-343) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNGSITE-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564291#comment-16564291 ] ASF GitHub Bot commented on MNGSITE-343: khmarbaise closed pull request #25: [MNGSITE-343] doc updated to be more clear about the plugin management URL: https://github.com/apache/maven-site/pull/25 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/content/apt/pom.apt b/content/apt/pom.apt index fb2224a6..cea326b1 100644 --- a/content/apt/pom.apt +++ b/content/apt/pom.apt @@ -1218,8 +1218,8 @@ Display parameters as parsed by Maven (in canonical form) and comparison result: is an element that is seen along side plugins. Plugin Management contains plugin elements in much the same way, except that rather than configuring plugin information for this particular project build, it is intended to configure project builds that inherit from this one. However, this only configures - plugins that are actually referenced within the plugins element in the children. The children have every - right to override <<>> definitions. + plugins that are actually referenced within the plugins element in the children or in the current POM. + The children have every right to override <<>> definitions. [] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct the documentation for the plugin management > --- > > Key: MNGSITE-343 > URL: https://issues.apache.org/jira/browse/MNGSITE-343 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Martin Prochazka >Assignee: Karl Heinz Marbaise >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MNGSITE-343) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNGSITE-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNGSITE-343. --- Resolution: Done Done by contribution of Martin Prochazka with [114afddb4d4a9bd7a1de3c3c60c9f5a34c73fd8e|https://gitbox.apache.org/repos/asf?p=maven-site.git;a=commitdiff;h=114afddb4d4a9bd7a1de3c3c60c9f5a34c73fd8e] > Correct the documentation for the plugin management > --- > > Key: MNGSITE-343 > URL: https://issues.apache.org/jira/browse/MNGSITE-343 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Martin Prochazka >Assignee: Karl Heinz Marbaise >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MNGSITE-343) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNGSITE-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MNGSITE-343: --- Assignee: Karl Heinz Marbaise > Correct the documentation for the plugin management > --- > > Key: MNGSITE-343 > URL: https://issues.apache.org/jira/browse/MNGSITE-343 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Martin Prochazka >Assignee: Karl Heinz Marbaise >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNGSITE-343) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNGSITE-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564278#comment-16564278 ] ASF GitHub Bot commented on MNGSITE-343: eramol commented on issue #25: [MNGSITE-343] doc updated to be more clear about the plugin management URL: https://github.com/apache/maven-site/pull/25#issuecomment-409344997 changed the commit message This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct the documentation for the plugin management > --- > > Key: MNGSITE-343 > URL: https://issues.apache.org/jira/browse/MNGSITE-343 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Martin Prochazka >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
[ https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564276#comment-16564276 ] Laird Nelson commented on MNG-6435: --- Compatibility is tricky here. Thanks to the design, I _think_ if you had some stuff in your {{settings.xml}} like this: {code:java} <${project.artifactId}>hello {code} …it should work (which is a little crazy). The serialization, in other words, dumps the whole {{settings.xml}} (XML tokens and all) into a {{String}} and then performs interpolation on the resulting {{String}}. I'm not sure there's any other solution than my approach above if that behavior has to be maintained. > DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML > --- > > Key: MNG-6435 > URL: https://issues.apache.org/jira/browse/MNG-6435 > Project: Maven > Issue Type: Improvement > Components: Settings >Affects Versions: 3.5.3 >Reporter: Laird Nelson >Priority: Minor > > On or around line 234, interpolation of settings assumes XML: > {code} > interpolator.addPostProcessor( new InterpolationPostProcessor() > { > @Override > public Object execute( String expression, Object value ) > { > if ( value != null ) > { > // we're going to parse this back in as XML so we need to escape XML > markup > value = value.toString().replace( "&", "&" ).replace( "<", "<" > ).replace( ">", ">" ); > return value; > } > return null; > } > } ); > {code} > The value being interpolated here is the result of a {{SettingsWriter}}'s > output. Obviously this kind of escaping doesn't make any sense if the > {{SettingsWriter}} in question is not XML-based. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNGSITE-343) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNGSITE-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564249#comment-16564249 ] ASF GitHub Bot commented on MNGSITE-343: khmarbaise commented on issue #25: [MNG-6451] doc updated to be more clear about the plugin management URL: https://github.com/apache/maven-site/pull/25#issuecomment-409338825 First I have moved the issue to the correct location https://issues.apache.org/jira/browse/MNGSITE-343 and it would be great if you could change your commit message accordingly ...and I would appreciate to merge you fix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct the documentation for the plugin management > --- > > Key: MNGSITE-343 > URL: https://issues.apache.org/jira/browse/MNGSITE-343 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Martin Prochazka >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6451) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNG-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-6451: - Issue Type: Improvement (was: Bug) > Correct the documentation for the plugin management > --- > > Key: MNG-6451 > URL: https://issues.apache.org/jira/browse/MNG-6451 > Project: Maven > Issue Type: Improvement >Reporter: Martin Prochazka >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Moved] (MNGSITE-343) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNGSITE-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise moved MNG-6451 to MNGSITE-343: -- Affects Version/s: (was: 3.5.3) Component/s: (was: Documentation: General) Key: MNGSITE-343 (was: MNG-6451) Project: Maven Project Web Site (was: Maven) > Correct the documentation for the plugin management > --- > > Key: MNGSITE-343 > URL: https://issues.apache.org/jira/browse/MNGSITE-343 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Martin Prochazka >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6451) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNG-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564239#comment-16564239 ] ASF GitHub Bot commented on MNG-6451: - eramol opened a new pull request #25: [MNG-6451] doc updated to be more clear about the plugin management URL: https://github.com/apache/maven-site/pull/25 doc updated to be more clear about the plugin management usage This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct the documentation for the plugin management > --- > > Key: MNG-6451 > URL: https://issues.apache.org/jira/browse/MNG-6451 > Project: Maven > Issue Type: Bug > Components: Documentation: General >Affects Versions: 3.5.3 >Reporter: Martin Prochazka >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MNG-6451) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNG-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564212#comment-16564212 ] Martin Prochazka edited comment on MNG-6451 at 7/31/18 7:12 PM: no problem, but I don't know in which repo the site code is EDIT: nevermind, I found it was (Author: mprochaz): no problem, but I don't know in which repo the site code is > Correct the documentation for the plugin management > --- > > Key: MNG-6451 > URL: https://issues.apache.org/jira/browse/MNG-6451 > Project: Maven > Issue Type: Bug > Components: Documentation: General >Affects Versions: 3.5.3 >Reporter: Martin Prochazka >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6451) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNG-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564212#comment-16564212 ] Martin Prochazka commented on MNG-6451: --- no problem, but I don't know in which repo the site code is > Correct the documentation for the plugin management > --- > > Key: MNG-6451 > URL: https://issues.apache.org/jira/browse/MNG-6451 > Project: Maven > Issue Type: Bug > Components: Documentation: General >Affects Versions: 3.5.3 >Reporter: Martin Prochazka >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
[ https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564211#comment-16564211 ] Karl Heinz Marbaise edited comment on MNG-6435 at 7/31/18 7:01 PM: --- Ok you have given an example which can cause problems which means the design is simply not goodso the question is can we fix/improve that in a way without breaking compatibility and maybe making your life (implementing) easier ? Do you have suggestions or a patch ? was (Author: khmarbaise): Ok you have given an example where can cause problems which means the design is simply not goodso the question is can we fix/improve that in a way without breaking compatibility and maybe making your life (implementing) easier ? Do you have suggestions or a patch ? > DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML > --- > > Key: MNG-6435 > URL: https://issues.apache.org/jira/browse/MNG-6435 > Project: Maven > Issue Type: Improvement > Components: Settings >Affects Versions: 3.5.3 >Reporter: Laird Nelson >Priority: Minor > > On or around line 234, interpolation of settings assumes XML: > {code} > interpolator.addPostProcessor( new InterpolationPostProcessor() > { > @Override > public Object execute( String expression, Object value ) > { > if ( value != null ) > { > // we're going to parse this back in as XML so we need to escape XML > markup > value = value.toString().replace( "&", "&" ).replace( "<", "<" > ).replace( ">", ">" ); > return value; > } > return null; > } > } ); > {code} > The value being interpolated here is the result of a {{SettingsWriter}}'s > output. Obviously this kind of escaping doesn't make any sense if the > {{SettingsWriter}} in question is not XML-based. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
[ https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564211#comment-16564211 ] Karl Heinz Marbaise commented on MNG-6435: -- Ok you have given an example where can cause problems which means the design is simply not goodso the question is can we fix/improve that in a way without breaking compatibility and maybe making your life (implementing) easier ? Do you have suggestions or a patch ? > DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML > --- > > Key: MNG-6435 > URL: https://issues.apache.org/jira/browse/MNG-6435 > Project: Maven > Issue Type: Improvement > Components: Settings >Affects Versions: 3.5.3 >Reporter: Laird Nelson >Priority: Minor > > On or around line 234, interpolation of settings assumes XML: > {code} > interpolator.addPostProcessor( new InterpolationPostProcessor() > { > @Override > public Object execute( String expression, Object value ) > { > if ( value != null ) > { > // we're going to parse this back in as XML so we need to escape XML > markup > value = value.toString().replace( "&", "&" ).replace( "<", "<" > ).replace( ">", ">" ); > return value; > } > return null; > } > } ); > {code} > The value being interpolated here is the result of a {{SettingsWriter}}'s > output. Obviously this kind of escaping doesn't make any sense if the > {{SettingsWriter}} in question is not XML-based. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
[ https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564197#comment-16564197 ] Laird Nelson commented on MNG-6435: --- That's a bit of a strange request; I'm not sure what constitutes "harm". I can give an example of someone (me) trying to write a settings reader and realizing that I had to also write a settings writer even though there is no case where I or any other part of the tool needs to write settings. To do this, I had to jump through a lot of hoops. Please see: https://github.com/microbean/microbean-maven-cdi/blob/master/src/main/java/org/microbean/maven/cdi/YamlSettingsBuilder.java Note that I shouldn't have to implement a {{SettingsBuilder}} but only a {{SettingsReader}}. But I can't simply implement a {{SettingsReader}} because the {{DefaultSettingsBuilder}} forces me needlessly to also implement a {{SettingsWriter}}. In my case, I simply reimplemented the {{SettingsBuilder}} to bypass this limitation. > DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML > --- > > Key: MNG-6435 > URL: https://issues.apache.org/jira/browse/MNG-6435 > Project: Maven > Issue Type: Improvement > Components: Settings >Affects Versions: 3.5.3 >Reporter: Laird Nelson >Priority: Minor > > On or around line 234, interpolation of settings assumes XML: > {code} > interpolator.addPostProcessor( new InterpolationPostProcessor() > { > @Override > public Object execute( String expression, Object value ) > { > if ( value != null ) > { > // we're going to parse this back in as XML so we need to escape XML > markup > value = value.toString().replace( "&", "&" ).replace( "<", "<" > ).replace( ">", ">" ); > return value; > } > return null; > } > } ); > {code} > The value being interpolated here is the result of a {{SettingsWriter}}'s > output. Obviously this kind of escaping doesn't make any sense if the > {{SettingsWriter}} in question is not XML-based. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6420) ComparableVersion incorrectly parses certain version strings
[ https://issues.apache.org/jira/browse/MNG-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564194#comment-16564194 ] Karl Heinz Marbaise commented on MNG-6420: -- The first thing which comes to my mind: What is correct: The docs or the code ? I currently would always tend to say the code is correct. To be honest I don't see any chance currently to replace that code with something different cause the implications are to impossible to guess also if we assume the code has errors (Which I also tend to say; But related to what?) > ComparableVersion incorrectly parses certain version strings > > > Key: MNG-6420 > URL: https://issues.apache.org/jira/browse/MNG-6420 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.3 >Reporter: Ross Goldberg >Priority: Major > Fix For: wontfix-candidate > > > For certain version strings, ComparableVersion doesn't follow the Maven > version order spec > (https://maven.apache.org/pom.html#Version_Order_Specification). > To improve the code & fix the following bugs, I completely rewrote the > version parser (using Java 10 & Google Guava 25.1). It is attached & passes > all of the tests from ComparableVersionTest. > Bug 1: > > java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.5.3.jar > 1-0.3 1 > > Outputs: > > 1. 1-0.3 == 1-0.3 > 1-0.3 == 1 > 2. 1 == 1 > > This probleem stems from: > > [https://github.com/apache/maven/blob/b8c06e61ab73cd9e25a5b2c93d9e5077b2196751/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java#L295-L296] > > > > Bug 2: > > java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.5.3.jar > 1-0-2 1-0.1 > > 1. 1-0-2 == 1-2 > 1-0-2 < 1-0.1 > 2. 1-0.1 == 1-0.1 > > This problem stems from retaining ListItems that, after normalization, have > no children other than the subsequent ListItem. Removing the unnecessary > ListItem should fix this (i.e. remove the extraneous ListItem (named > extraneous) from its parent ListItem (named parent), then add the only child > of extraneous to parent). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MNG-6420) ComparableVersion incorrectly parses certain version strings
[ https://issues.apache.org/jira/browse/MNG-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564194#comment-16564194 ] Karl Heinz Marbaise edited comment on MNG-6420 at 7/31/18 6:52 PM: --- The first thing which comes to my mind: What is correct: The docs or the code ? I currently would always tend to say the code is correct (which means we need to fix the docs accordingly). To be honest I don't see any chance currently to replace that code with something different cause the implications are to impossible to guess also if we assume the code has errors (Which I also tend to say; But related to what?) was (Author: khmarbaise): The first thing which comes to my mind: What is correct: The docs or the code ? I currently would always tend to say the code is correct. To be honest I don't see any chance currently to replace that code with something different cause the implications are to impossible to guess also if we assume the code has errors (Which I also tend to say; But related to what?) > ComparableVersion incorrectly parses certain version strings > > > Key: MNG-6420 > URL: https://issues.apache.org/jira/browse/MNG-6420 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.3 >Reporter: Ross Goldberg >Priority: Major > Fix For: wontfix-candidate > > > For certain version strings, ComparableVersion doesn't follow the Maven > version order spec > (https://maven.apache.org/pom.html#Version_Order_Specification). > To improve the code & fix the following bugs, I completely rewrote the > version parser (using Java 10 & Google Guava 25.1). It is attached & passes > all of the tests from ComparableVersionTest. > Bug 1: > > java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.5.3.jar > 1-0.3 1 > > Outputs: > > 1. 1-0.3 == 1-0.3 > 1-0.3 == 1 > 2. 1 == 1 > > This probleem stems from: > > [https://github.com/apache/maven/blob/b8c06e61ab73cd9e25a5b2c93d9e5077b2196751/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java#L295-L296] > > > > Bug 2: > > java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.5.3.jar > 1-0-2 1-0.1 > > 1. 1-0-2 == 1-2 > 1-0-2 < 1-0.1 > 2. 1-0.1 == 1-0.1 > > This problem stems from retaining ListItems that, after normalization, have > no children other than the subsequent ListItem. Removing the unnecessary > ListItem should fix this (i.e. remove the extraneous ListItem (named > extraneous) from its parent ListItem (named parent), then add the only child > of extraneous to parent). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6420) ComparableVersion incorrectly parses certain version strings
[ https://issues.apache.org/jira/browse/MNG-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-6420: - Fix Version/s: wontfix-candidate > ComparableVersion incorrectly parses certain version strings > > > Key: MNG-6420 > URL: https://issues.apache.org/jira/browse/MNG-6420 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.3 >Reporter: Ross Goldberg >Priority: Major > Fix For: wontfix-candidate > > > For certain version strings, ComparableVersion doesn't follow the Maven > version order spec > (https://maven.apache.org/pom.html#Version_Order_Specification). > To improve the code & fix the following bugs, I completely rewrote the > version parser (using Java 10 & Google Guava 25.1). It is attached & passes > all of the tests from ComparableVersionTest. > Bug 1: > > java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.5.3.jar > 1-0.3 1 > > Outputs: > > 1. 1-0.3 == 1-0.3 > 1-0.3 == 1 > 2. 1 == 1 > > This probleem stems from: > > [https://github.com/apache/maven/blob/b8c06e61ab73cd9e25a5b2c93d9e5077b2196751/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java#L295-L296] > > > > Bug 2: > > java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.5.3.jar > 1-0-2 1-0.1 > > 1. 1-0-2 == 1-2 > 1-0-2 < 1-0.1 > 2. 1-0.1 == 1-0.1 > > This problem stems from retaining ListItems that, after normalization, have > no children other than the subsequent ListItem. Removing the unnecessary > ListItem should fix this (i.e. remove the extraneous ListItem (named > extraneous) from its parent ListItem (named parent), then add the only child > of extraneous to parent). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6416) Parallel Build with option "-T 1C" fails on Maven 3.5.3 + Linux Centos + Jenkins
[ https://issues.apache.org/jira/browse/MNG-6416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-6416: - Fix Version/s: waiting-for-feedback > Parallel Build with option "-T 1C" fails on Maven 3.5.3 + Linux Centos + > Jenkins > > > Key: MNG-6416 > URL: https://issues.apache.org/jira/browse/MNG-6416 > Project: Maven > Issue Type: Bug > Components: Bootstrap & Build, Performance >Affects Versions: 3.5.3 > Environment: Linux Centos >Reporter: Samir Shaik >Priority: Major > Fix For: waiting-for-feedback > > > +*Environment*+ > *OS:* Linux Centos > *CI/CD Tool:* Jenkins > *Maven:* 3.5.3 > *Model:* multi module project > With Maven version 3.5.0 we were having issues with metadata.xml being > wrongly updated by Maven on Nexus3. So we upgraded to 3.5.3 to resolve the > issue around metadata.xml issue. With 3.5.3 we are unable to run parallel > builds with "-T 1C" option. > Note that the same setup works smooth on my local machine which has Windows 7 > OS. This has to do something with Maven3.5.3 + Linux + Jenkins. Would > appreciate if you can take a look and get to the root cause of this issue. We > are ready to provide more details if that helps. > > *Expected behavior:* Build would run successfully. > *Actual Behavior:* Build fails every time with different reasons. Ran build 4 > times and the results are attached to this ticket -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6424) Upgrade plexus-interpolation to 1.25
[ https://issues.apache.org/jira/browse/MNG-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-6424: - Fix Version/s: (was: 3.6.x-candidate) 3.6.0 > Upgrade plexus-interpolation to 1.25 > > > Key: MNG-6424 > URL: https://issues.apache.org/jira/browse/MNG-6424 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.5.4 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MNG-6424) Upgrade plexus-interpolation to 1.25
[ https://issues.apache.org/jira/browse/MNG-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-6424. Resolution: Done > Upgrade plexus-interpolation to 1.25 > > > Key: MNG-6424 > URL: https://issues.apache.org/jira/browse/MNG-6424 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.5.4 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6433) Maven does not authenticate
[ https://issues.apache.org/jira/browse/MNG-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-6433: - Fix Version/s: waiting-for-feedback > Maven does not authenticate > > > Key: MNG-6433 > URL: https://issues.apache.org/jira/browse/MNG-6433 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.4 > Environment: Windows 10, JFrog artifactory >Reporter: Martin Formanko >Priority: Major > Fix For: waiting-for-feedback > > > I have set the username and password in settings.xml (encrypted and also > plain-text the same behaviour). In debug logs I also see the following: > > {code:java} > [DEBUG] Using connector BasicRepositoryConnector with priority 0.0 for > http://[censored]/artifactory/repo with username=[censored], password=*** > Downloading from repo: > http://[censored]/artifactory/repo/com/[censored].pom{code} > > > but maven itself does not authenticate, from what I see in network dump: > > {code:java} > GET /artifactory/[censored].pom HTTP/1.1 > Cache-control: no-cache > Cache-store: no-store > Pragma: no-cache > Expires: 0 > Accept-Encoding: gzip > User-Agent: Apache-Maven/3.5.4 (Java 1.8.0_161; Windows 10 10.0) > Host: [censored] > Connection: Keep-Alive > HTTP/1.1 404 Not Found > Server: Artifactory/5.11.1 > X-Artifactory-Id: [censored]c:-8000 > Content-Type: application/json;charset=ISO-8859-1 > Content-Length: 74 > Date: Mon, 25 Jun 2018 14:28:17 GMT > {code} > > So... then I am getting > {code:java} > [FATAL] Non-resolvable parent POM for [censored]: Could not find > artifact{code} > Because Maven is awaiting maybe 407 authentication required or some similar > status code. Is this correct behaviour? Should our artifactory request the > username/password? Because what it does, is that it replies with 404 when > authentication is not done. > My settings.xml are not important I think, because as you can see in the log, > there is BasicConnector which is using already the username/password, so the > settings are correct, but maven simply does not use any credentials at all > and tries to grab artifact directly which fails with FATAL error. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
[ https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-6435: - Priority: Minor (was: Major) > DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML > --- > > Key: MNG-6435 > URL: https://issues.apache.org/jira/browse/MNG-6435 > Project: Maven > Issue Type: Improvement > Components: Settings >Affects Versions: 3.5.3 >Reporter: Laird Nelson >Priority: Minor > > On or around line 234, interpolation of settings assumes XML: > {code} > interpolator.addPostProcessor( new InterpolationPostProcessor() > { > @Override > public Object execute( String expression, Object value ) > { > if ( value != null ) > { > // we're going to parse this back in as XML so we need to escape XML > markup > value = value.toString().replace( "&", "&" ).replace( "<", "<" > ).replace( ">", ">" ); > return value; > } > return null; > } > } ); > {code} > The value being interpolated here is the result of a {{SettingsWriter}}'s > output. Obviously this kind of escaping doesn't make any sense if the > {{SettingsWriter}} in question is not XML-based. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
[ https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-6435: - Issue Type: Improvement (was: Bug) > DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML > --- > > Key: MNG-6435 > URL: https://issues.apache.org/jira/browse/MNG-6435 > Project: Maven > Issue Type: Improvement > Components: Settings >Affects Versions: 3.5.3 >Reporter: Laird Nelson >Priority: Major > > On or around line 234, interpolation of settings assumes XML: > {code} > interpolator.addPostProcessor( new InterpolationPostProcessor() > { > @Override > public Object execute( String expression, Object value ) > { > if ( value != null ) > { > // we're going to parse this back in as XML so we need to escape XML > markup > value = value.toString().replace( "&", "&" ).replace( "<", "<" > ).replace( ">", ">" ); > return value; > } > return null; > } > } ); > {code} > The value being interpolated here is the result of a {{SettingsWriter}}'s > output. Obviously this kind of escaping doesn't make any sense if the > {{SettingsWriter}} in question is not XML-based. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
[ https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564130#comment-16564130 ] Karl Heinz Marbaise commented on MNG-6435: -- Can you please give an example where this could harm someone? > DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML > --- > > Key: MNG-6435 > URL: https://issues.apache.org/jira/browse/MNG-6435 > Project: Maven > Issue Type: Bug > Components: Settings >Affects Versions: 3.5.3 >Reporter: Laird Nelson >Priority: Major > > On or around line 234, interpolation of settings assumes XML: > {code} > interpolator.addPostProcessor( new InterpolationPostProcessor() > { > @Override > public Object execute( String expression, Object value ) > { > if ( value != null ) > { > // we're going to parse this back in as XML so we need to escape XML > markup > value = value.toString().replace( "&", "&" ).replace( "<", "<" > ).replace( ">", ">" ); > return value; > } > return null; > } > } ); > {code} > The value being interpolated here is the result of a {{SettingsWriter}}'s > output. Obviously this kind of escaping doesn't make any sense if the > {{SettingsWriter}} in question is not XML-based. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6438) Continuous Delivery friendly versions do not work on root pom's parent
[ https://issues.apache.org/jira/browse/MNG-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564123#comment-16564123 ] Karl Heinz Marbaise commented on MNG-6438: -- The point is the ci friendly setup is intended to make it easier to define a version via command line etc. for the project artifacts (which could a multi module build)..but not for parents..cause I don't see there a good use case for itYou have mentioned the iterator-maven-plugin..can you please make an full example why you are using it and what kind of problem you have solved with it? > Continuous Delivery friendly versions do not work on root pom's parent > -- > > Key: MNG-6438 > URL: https://issues.apache.org/jira/browse/MNG-6438 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.3 > Environment: Apache Maven 3.5.3 > (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T20:49:05+01:00) > Maven home: /usr/local/Cellar/maven/3.5.3/libexec > Java version: 1.8.0_162, vendor: Oracle Corporation > Java home: > /Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre > Default locale: en_DE, platform encoding: UTF-8 > OS name: "mac os x", version: "10.13.5", arch: "x86_64", family: "mac" >Reporter: Konrad Windszus >Priority: Major > > If I use either {{${revision}}},{{${sha1}}}, or {{${changelist}}} in the root > pom's parent version it simply does not work, even when the project is > invoked via > {{mvn package -Drevision=1.0}} and the according parent is available in > version {{1.0}} in my Maven repo. > Instead I get the following error > {code} > mvn package -Dsha1=1.0 > [INFO] Scanning for projects... > Downloading from central: > https://repo.maven.apache.org/maven2/some/test/myparent/$%7Bsha1%7D/myparent-$%7Bsha1%7D.pom > [ERROR] [ERROR] Some problems were encountered while processing the POMs: > [FATAL] Non-resolvable parent POM for some.test:root:[unknown-version]: Could > not find artifact some.test:myparent:pom:${sha1} in central > (https://repo.maven.apache.org/maven2) and 'parent.relativePath' points at > wrong local POM @ line 11, column 13 > @ > [ERROR] The build could not read 1 project -> [Help 1] > [ERROR] > [ERROR] The project some.test:root:[unknown-version] > (/Users/konradwindszus/Downloads/pom.xml) has 1 error > [ERROR] Non-resolvable parent POM for some.test:root:[unknown-version]: > Could not find artifact some.test:myparent:pom:${sha1} in central > (https://repo.maven.apache.org/maven2) and 'parent.relativePath' points at > wrong local POM @ line 11, column 13 -> [Help 2] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException > [ERROR] [Help 2] > http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException > {code} > The following minimum pom can be used for testing > {code} > > xmlns="http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd";> > 4.0.0 > > some.test > myparent > > ${sha1} > > root > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6441) Update to maven-resolver 1.1.2
[ https://issues.apache.org/jira/browse/MNG-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564118#comment-16564118 ] ASF GitHub Bot commented on MNG-6441: - khmarbaise commented on issue #173: [MNG-6441] Upgrade maven-resolver to 1.1.2 URL: https://github.com/apache/maven/pull/173#issuecomment-409319920 Unfortunately Maven Resolver 1.1.2 does not exist yet ;-) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update to maven-resolver 1.1.2 > -- > > Key: MNG-6441 > URL: https://issues.apache.org/jira/browse/MNG-6441 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] khmarbaise commented on issue #173: [MNG-6441] Upgrade maven-resolver to 1.1.2
khmarbaise commented on issue #173: [MNG-6441] Upgrade maven-resolver to 1.1.2 URL: https://github.com/apache/maven/pull/173#issuecomment-409319920 Unfortunately Maven Resolver 1.1.2 does not exist yet ;-) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6451) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNG-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564108#comment-16564108 ] Karl Heinz Marbaise commented on MNG-6451: -- What about making a pull request for the documentation ? > Correct the documentation for the plugin management > --- > > Key: MNG-6451 > URL: https://issues.apache.org/jira/browse/MNG-6451 > Project: Maven > Issue Type: Bug > Components: Documentation: General >Affects Versions: 3.5.3 >Reporter: Martin Prochazka >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6451) Correct the documentation for the plugin management
[ https://issues.apache.org/jira/browse/MNG-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-6451: - Labels: easyfix (was: ) > Correct the documentation for the plugin management > --- > > Key: MNG-6451 > URL: https://issues.apache.org/jira/browse/MNG-6451 > Project: Maven > Issue Type: Bug > Components: Documentation: General >Affects Versions: 3.5.3 >Reporter: Martin Prochazka >Priority: Minor > Labels: easyfix > > In the documentation of the plugin management element it says that the plugin > management relates *only* to children, however maven behaves differently. The > following pom creates also a jar with dependencies, even by documentation it > should not be configured to do so. > The solution is to change a few words in the documentation. > {code:java} > > http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > 4.0.0 > someproject > someartifact > 1.0-SNAPSHOT > > > > > maven-assembly-plugin > 3.1.0 > > > > jar-with-dependencies > > > > > make-assembly > package > > single > > > > > > > > > maven-assembly-plugin > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6383) ProjectBuilder unnecessarily rebuilds modules with ci-friendly versions
[ https://issues.apache.org/jira/browse/MNG-6383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-6383: - Fix Version/s: (was: 3.6.x-candidate) 3.6.0 > ProjectBuilder unnecessarily rebuilds modules with ci-friendly versions > --- > > Key: MNG-6383 > URL: https://issues.apache.org/jira/browse/MNG-6383 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.3 >Reporter: Christoph Kunze >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.6.0 > > Attachments: sample-project.tar.gz > > > Consider a multi-module project that uses ci-friendly versions (i.e. the root > pom declares ${revision}). > While "scanning for projects", the DefaultProjectBuilder (build:347) uses a > two-phase approach. > 1) build:390 populates a set of interimResults and a projectIndex. The keys > of the projectIndex take the form groupId:artifactId:packaging:version and > the version always is the interpolated version (i.e. 1.0-SNAPSHOT rather than > ${revision}). > 2) build:573 calls initProject which in line 638 attempts to retrieve the > previously constructed parent project from the projectIndex. However, the key > used here still contains the uninterpolated version (i.e. ${revision}) so > *the* *parent project is never found*. In line 652, the parent project is > therefore constructed anew: > {code:java} > parent = build( parentPomFile, projectBuildingRequest ).getProject(); > {code} > This is not only ineffective but also causes problems, e.g. if the parent > imports a bom module from the same reactor, this leads to a warning "Failed > to build parent project" and potential follow-up problems. Also, the maven > assembly plugin seems to fail on such projects. > *Details* > - The ModelBuildingResult created in the first phase contains a list of > modelIds. They key used to add an entry to the project index always > corresponds to the *first* item in this list: > {code:java} > // DefaultProjectBuilder:436 > projectIndex.put( result.getModelIds().get( 0 ), project ) > {code} > However, the key used to retrieve the entry during the processing of its > child is the *second* element from the modelIds list: > {code:java} > // DefaultProjectBuilder:636 > String parentModelId = result.getModelIds().get( 1 ); > MavenProject parent = projects.get( parentModelId ); > {code} > The list items are created by DefaultModelBuilder.build:244. First a > "lineage" of the current module is built. Then the first element of the > lineage, corresponding to the current module, gets interpolated. The other > lineage items *do not get interpolated*, i.e. they still contain the > placeholder version. > The list of modelIds is then constructed from the lineage, leading to the > first element having an interpolated version whereas all other elements have > a placeholder version. > {code:java} > // DefaultModelBuilder:411 > for ( ModelData currentData : lineage ) > { > String modelId = ( currentData != superData ) ? currentData.getId() : ""; > result.addModelId( modelId ); > {code} > *Fix* > One way to fix the issue might be to interpolate all elements of the lineage > in DefaultModelBuilder.build:244, or to at least replace their versions. > The following modification (hacky and probably faulty, for demonstration > purpose only) fixed the issue for my project: > {code:java} > // model interpolation > resultModel = interpolateModel( resultModel, request, problems ); > resultData.setModel( resultModel ); > /* new code starts here */ > if ( resultModel.getParent() != null ) > { > final ModelData parentData = lineage.get( 1 ); > final Model interpolatedParent = interpolateModel( parentData.getModel(), > request, problems ); > // parentData.setModel( interpolatedParent ); > parentData.setVersion( interpolatedParent.getVersion() ); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRESOLVER-51) Upgrade maven-parent to version 32
[ https://issues.apache.org/jira/browse/MRESOLVER-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564076#comment-16564076 ] Hudson commented on MRESOLVER-51: - Build succeeded in Jenkins: Maven TLP » maven-resolver » master #14 See https://builds.apache.org/job/maven-box/job/maven-resolver/job/master/14/ > Upgrade maven-parent to version 32 > -- > > Key: MRESOLVER-51 > URL: https://issues.apache.org/jira/browse/MRESOLVER-51 > Project: Maven Resolver > Issue Type: Dependency upgrade >Affects Versions: 1.1.2 >Reporter: Karl Heinz Marbaise >Priority: Minor > Fix For: 1.1.2 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MRESOLVER-51) Upgrade maven-parent to version 32
[ https://issues.apache.org/jira/browse/MRESOLVER-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MRESOLVER-51. Resolution: Done > Upgrade maven-parent to version 32 > -- > > Key: MRESOLVER-51 > URL: https://issues.apache.org/jira/browse/MRESOLVER-51 > Project: Maven Resolver > Issue Type: Dependency upgrade >Affects Versions: 1.1.2 >Reporter: Karl Heinz Marbaise >Priority: Minor > Fix For: 1.1.2 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRESOLVER-51) Upgrade maven-parent to version 32
[ https://issues.apache.org/jira/browse/MRESOLVER-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564069#comment-16564069 ] Karl Heinz Marbaise commented on MRESOLVER-51: -- Done in [cf1a6a8de334f906c72b4344f7e39409f6085bae|https://gitbox.apache.org/repos/asf?p=maven-resolver.git;a=commitdiff;h=cf1a6a8de334f906c72b4344f7e39409f6085bae] > Upgrade maven-parent to version 32 > -- > > Key: MRESOLVER-51 > URL: https://issues.apache.org/jira/browse/MRESOLVER-51 > Project: Maven Resolver > Issue Type: Dependency upgrade >Affects Versions: 1.1.2 >Reporter: Karl Heinz Marbaise >Priority: Minor > Fix For: 1.1.2 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRESOLVER-40) Migrate examples to use java annotations
[ https://issues.apache.org/jira/browse/MRESOLVER-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564029#comment-16564029 ] ASF GitHub Bot commented on MRESOLVER-40: - khmarbaise closed pull request #20: [MRESOLVER-40] Convert legacy Plexus components into JSR-330 annotations URL: https://github.com/apache/maven-resolver/pull/20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml b/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml index 4496679a..cf88db24 100644 --- a/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml +++ b/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml @@ -73,6 +73,22 @@ org.apache.maven.resolver maven-resolver-util + + org.apache.maven.plugin-tools + maven-plugin-annotations + provided + true + + + org.slf4j + slf4j-api + provided + + + javax.inject + javax.inject + provided + diff --git a/maven-resolver-demos/maven-resolver-demo-maven-plugin/src/main/java/org/apache/maven/resolver/examples/maven/ResolveArtifactMojo.java b/maven-resolver-demos/maven-resolver-demo-maven-plugin/src/main/java/org/apache/maven/resolver/examples/maven/ResolveArtifactMojo.java index 38b9f2d6..57e09792 100644 --- a/maven-resolver-demos/maven-resolver-demo-maven-plugin/src/main/java/org/apache/maven/resolver/examples/maven/ResolveArtifactMojo.java +++ b/maven-resolver-demos/maven-resolver-demo-maven-plugin/src/main/java/org/apache/maven/resolver/examples/maven/ResolveArtifactMojo.java @@ -24,6 +24,9 @@ import org.apache.maven.plugin.AbstractMojo; import org.apache.maven.plugin.MojoExecutionException; import org.apache.maven.plugin.MojoFailureException; +import org.apache.maven.plugins.annotations.Component; +import org.apache.maven.plugins.annotations.Mojo; +import org.apache.maven.plugins.annotations.Parameter; import org.eclipse.aether.RepositorySystem; import org.eclipse.aether.RepositorySystemSession; import org.eclipse.aether.artifact.Artifact; @@ -32,44 +35,39 @@ import org.eclipse.aether.resolution.ArtifactRequest; import org.eclipse.aether.resolution.ArtifactResolutionException; import org.eclipse.aether.resolution.ArtifactResult; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Resolves a single artifact (not including its transitive dependencies). - * - * @goal resolve-artifact */ +@Mojo( name = "resolve-artifact", threadSafe = true ) public class ResolveArtifactMojo extends AbstractMojo { - +private static final Logger LOGGER = LoggerFactory.getLogger( ResolveArtifactMojo.class ); /** * The entry point to Maven Artifact Resolver, i.e. the component doing all the work. - * - * @component */ +@Component private RepositorySystem repoSystem; /** * The current repository/network configuration of Maven. - * - * @parameter default-value="${repositorySystemSession}" - * @readonly */ +@Parameter( defaultValue = "${repositorySystemSession}", readonly = true ) private RepositorySystemSession repoSession; /** * The project's remote repositories to use for the resolution. - * - * @parameter default-value="${project.remoteProjectRepositories}" - * @readonly */ +@Parameter( defaultValue = "${project.remotePluginRepositories}", readonly = true ) private List remoteRepos; /** * The {@code :[:[:]]:} of the artifact to resolve. - * - * @parameter property="resolver.artifactCoords" */ +@Parameter ( property = "resolver.artifactCoords", readonly = true ) private String artifactCoords; /** @@ -92,7 +90,7 @@ public void execute() request.setArtifact( artifact ); request.setRepositories( remoteRepos ); -getLog().info( "Resolving artifact " + artifact + " from " + remoteRepos ); +LOGGER.info( "Resolving artifact {} from {}", artifact, remoteRepos ); ArtifactResult result; try @@ -104,8 +102,8 @@ public void execute() throw new MojoExecutionException( e.getMessage(), e ); } -getLog().info( "Resolved artifact " + artifact + " to " + result.getArtifact().getFile() + " from " - + result.getRepository() ); +LOGGER.info( "Resolved artifact {} to {} from {}", artifact, result.getArtifact().getFile(), +result.getRepository() ); } } diff --git a/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/guice
[jira] [Commented] (MRESOLVER-40) Migrate examples to use java annotations
[ https://issues.apache.org/jira/browse/MRESOLVER-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564028#comment-16564028 ] ASF GitHub Bot commented on MRESOLVER-40: - khmarbaise commented on issue #20: [MRESOLVER-40] Convert legacy Plexus components into JSR-330 annotations URL: https://github.com/apache/maven-resolver/pull/20#issuecomment-409300400 So CI was happy: * https://builds.apache.org/job/maven-box/job/maven-resolver/job/MRESOLVER-40/ * Merged into master https://gitbox.apache.org/repos/asf?p=maven-resolver.git;a=commitdiff;h=3040b15c06047dab2eb09d0a24501f556dc339aa Thanks for your contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Migrate examples to use java annotations > > > Key: MRESOLVER-40 > URL: https://issues.apache.org/jira/browse/MRESOLVER-40 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Trivial > > Migrate examples from javadoc to java 5 annotations in > _maven-resolver-demo-maven-plugin_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] khmarbaise commented on issue #20: [MRESOLVER-40] Convert legacy Plexus components into JSR-330 annotations
khmarbaise commented on issue #20: [MRESOLVER-40] Convert legacy Plexus components into JSR-330 annotations URL: https://github.com/apache/maven-resolver/pull/20#issuecomment-409300400 So CI was happy: * https://builds.apache.org/job/maven-box/job/maven-resolver/job/MRESOLVER-40/ * Merged into master https://gitbox.apache.org/repos/asf?p=maven-resolver.git;a=commitdiff;h=3040b15c06047dab2eb09d0a24501f556dc339aa Thanks for your contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise closed pull request #20: [MRESOLVER-40] Convert legacy Plexus components into JSR-330 annotations
khmarbaise closed pull request #20: [MRESOLVER-40] Convert legacy Plexus components into JSR-330 annotations URL: https://github.com/apache/maven-resolver/pull/20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml b/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml index 4496679a..cf88db24 100644 --- a/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml +++ b/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml @@ -73,6 +73,22 @@ org.apache.maven.resolver maven-resolver-util + + org.apache.maven.plugin-tools + maven-plugin-annotations + provided + true + + + org.slf4j + slf4j-api + provided + + + javax.inject + javax.inject + provided + diff --git a/maven-resolver-demos/maven-resolver-demo-maven-plugin/src/main/java/org/apache/maven/resolver/examples/maven/ResolveArtifactMojo.java b/maven-resolver-demos/maven-resolver-demo-maven-plugin/src/main/java/org/apache/maven/resolver/examples/maven/ResolveArtifactMojo.java index 38b9f2d6..57e09792 100644 --- a/maven-resolver-demos/maven-resolver-demo-maven-plugin/src/main/java/org/apache/maven/resolver/examples/maven/ResolveArtifactMojo.java +++ b/maven-resolver-demos/maven-resolver-demo-maven-plugin/src/main/java/org/apache/maven/resolver/examples/maven/ResolveArtifactMojo.java @@ -24,6 +24,9 @@ import org.apache.maven.plugin.AbstractMojo; import org.apache.maven.plugin.MojoExecutionException; import org.apache.maven.plugin.MojoFailureException; +import org.apache.maven.plugins.annotations.Component; +import org.apache.maven.plugins.annotations.Mojo; +import org.apache.maven.plugins.annotations.Parameter; import org.eclipse.aether.RepositorySystem; import org.eclipse.aether.RepositorySystemSession; import org.eclipse.aether.artifact.Artifact; @@ -32,44 +35,39 @@ import org.eclipse.aether.resolution.ArtifactRequest; import org.eclipse.aether.resolution.ArtifactResolutionException; import org.eclipse.aether.resolution.ArtifactResult; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Resolves a single artifact (not including its transitive dependencies). - * - * @goal resolve-artifact */ +@Mojo( name = "resolve-artifact", threadSafe = true ) public class ResolveArtifactMojo extends AbstractMojo { - +private static final Logger LOGGER = LoggerFactory.getLogger( ResolveArtifactMojo.class ); /** * The entry point to Maven Artifact Resolver, i.e. the component doing all the work. - * - * @component */ +@Component private RepositorySystem repoSystem; /** * The current repository/network configuration of Maven. - * - * @parameter default-value="${repositorySystemSession}" - * @readonly */ +@Parameter( defaultValue = "${repositorySystemSession}", readonly = true ) private RepositorySystemSession repoSession; /** * The project's remote repositories to use for the resolution. - * - * @parameter default-value="${project.remoteProjectRepositories}" - * @readonly */ +@Parameter( defaultValue = "${project.remotePluginRepositories}", readonly = true ) private List remoteRepos; /** * The {@code :[:[:]]:} of the artifact to resolve. - * - * @parameter property="resolver.artifactCoords" */ +@Parameter ( property = "resolver.artifactCoords", readonly = true ) private String artifactCoords; /** @@ -92,7 +90,7 @@ public void execute() request.setArtifact( artifact ); request.setRepositories( remoteRepos ); -getLog().info( "Resolving artifact " + artifact + " from " + remoteRepos ); +LOGGER.info( "Resolving artifact {} from {}", artifact, remoteRepos ); ArtifactResult result; try @@ -104,8 +102,8 @@ public void execute() throw new MojoExecutionException( e.getMessage(), e ); } -getLog().info( "Resolved artifact " + artifact + " to " + result.getArtifact().getFile() + " from " - + result.getRepository() ); +LOGGER.info( "Resolved artifact {} to {} from {}", artifact, result.getArtifact().getFile(), +result.getRepository() ); } } diff --git a/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/guice/DemoResolverModule.java b/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/guice/DemoResolverModule.java index fcec471e..6b1691af 100644 --- a/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/or
[jira] [Commented] (MRESOLVER-40) Migrate examples to use java annotations
[ https://issues.apache.org/jira/browse/MRESOLVER-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564026#comment-16564026 ] Hudson commented on MRESOLVER-40: - Build succeeded in Jenkins: Maven TLP » maven-resolver » master #13 See https://builds.apache.org/job/maven-box/job/maven-resolver/job/master/13/ > Migrate examples to use java annotations > > > Key: MRESOLVER-40 > URL: https://issues.apache.org/jira/browse/MRESOLVER-40 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Trivial > > Migrate examples from javadoc to java 5 annotations in > _maven-resolver-demo-maven-plugin_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MRESOLVER-40) Migrate examples to use java annotations
[ https://issues.apache.org/jira/browse/MRESOLVER-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MRESOLVER-40. Resolution: Done > Migrate examples to use java annotations > > > Key: MRESOLVER-40 > URL: https://issues.apache.org/jira/browse/MRESOLVER-40 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Trivial > > Migrate examples from javadoc to java 5 annotations in > _maven-resolver-demo-maven-plugin_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRESOLVER-40) Migrate examples to use java annotations
[ https://issues.apache.org/jira/browse/MRESOLVER-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564012#comment-16564012 ] Karl Heinz Marbaise commented on MRESOLVER-40: -- Done in [3040b15c06047dab2eb09d0a24501f556dc339aa|https://gitbox.apache.org/repos/asf?p=maven-resolver.git;a=commitdiff;h=3040b15c06047dab2eb09d0a24501f556dc339aa] > Migrate examples to use java annotations > > > Key: MRESOLVER-40 > URL: https://issues.apache.org/jira/browse/MRESOLVER-40 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Trivial > > Migrate examples from javadoc to java 5 annotations in > _maven-resolver-demo-maven-plugin_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRESOLVER-50) Repo missing
[ https://issues.apache.org/jira/browse/MRESOLVER-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564009#comment-16564009 ] Karl Heinz Marbaise commented on MRESOLVER-50: -- The repository has been moved to this location: https://gitbox.apache.org/repos/asf/maven-resolver.git and the web site will be fixed by the next release...Thanks for reporting this... > Repo missing > > > Key: MRESOLVER-50 > URL: https://issues.apache.org/jira/browse/MRESOLVER-50 > Project: Maven Resolver > Issue Type: Bug > Components: resolver >Reporter: Elliotte Rusty Harold >Priority: Minor > > The instructions on this page are incorrect: > [https://maven.apache.org/resolver/source-repository.html] > $ git clone --branch maven-resolver-1.1.1 > [https://git-wip-us.apache.org/repos/asf/maven-resolver.git] > Cloning into 'maven-resolver'... > fatal: repository > 'https://git-wip-us.apache.org/repos/asf/maven-resolver.git/' not found > Please update this page to point to the new repo on github > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MRESOLVER-51) Upgrade maven-parent to version 32
Karl Heinz Marbaise created MRESOLVER-51: Summary: Upgrade maven-parent to version 32 Key: MRESOLVER-51 URL: https://issues.apache.org/jira/browse/MRESOLVER-51 Project: Maven Resolver Issue Type: Dependency upgrade Affects Versions: 1.1.2 Reporter: Karl Heinz Marbaise Fix For: 1.1.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MRESOLVER-50) Repo missing
[ https://issues.apache.org/jira/browse/MRESOLVER-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MRESOLVER-50: - Priority: Minor (was: Major) > Repo missing > > > Key: MRESOLVER-50 > URL: https://issues.apache.org/jira/browse/MRESOLVER-50 > Project: Maven Resolver > Issue Type: Bug > Components: resolver >Reporter: Elliotte Rusty Harold >Priority: Minor > > The instructions on this page are incorrect: > [https://maven.apache.org/resolver/source-repository.html] > $ git clone --branch maven-resolver-1.1.1 > [https://git-wip-us.apache.org/repos/asf/maven-resolver.git] > Cloning into 'maven-resolver'... > fatal: repository > 'https://git-wip-us.apache.org/repos/asf/maven-resolver.git/' not found > Please update this page to point to the new repo on github > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRESOLVER-40) Migrate examples to use java annotations
[ https://issues.apache.org/jira/browse/MRESOLVER-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563994#comment-16563994 ] ASF GitHub Bot commented on MRESOLVER-40: - khmarbaise commented on issue #20: [MRESOLVER-40] Convert legacy Plexus components into JSR-330 annotations URL: https://github.com/apache/maven-resolver/pull/20#issuecomment-409292579 So lets see what the CI server has to tell us... https://builds.apache.org/job/maven-box/job/maven-resolver/job/MRESOLVER-40/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Migrate examples to use java annotations > > > Key: MRESOLVER-40 > URL: https://issues.apache.org/jira/browse/MRESOLVER-40 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Trivial > > Migrate examples from javadoc to java 5 annotations in > _maven-resolver-demo-maven-plugin_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] khmarbaise commented on issue #20: [MRESOLVER-40] Convert legacy Plexus components into JSR-330 annotations
khmarbaise commented on issue #20: [MRESOLVER-40] Convert legacy Plexus components into JSR-330 annotations URL: https://github.com/apache/maven-resolver/pull/20#issuecomment-409292579 So lets see what the CI server has to tell us... https://builds.apache.org/job/maven-box/job/maven-resolver/job/MRESOLVER-40/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MPIR-374) Unknown packaging: bundle when creating report
[ https://issues.apache.org/jira/browse/MPIR-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563891#comment-16563891 ] Mikaël Geljić commented on MPIR-374: Hi there, may I relate this issue to MPIR-373? Both are similar in that the reports produce hefty stack traces for remote POM issues, which are otherwise not reported in the default lifecycle. As this involves few established 3rd-party deps (on central) there is little option to do anything about them, in this case maybe for the lack of MNG-5600. ;) We therefore "inherit" a mix of _unknown packaging_, deprecated expressions or missing plugin versions, as illustrated below (omitting 175 lines of stack traces): {noformat} [INFO] Generating "Dependencies" report --- maven-project-info-reports-plugin:3.0.0:dependencies [WARNING] Unable to create Maven project from repository. org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs: [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-surefire-plugin is missing. @ line 153, column 15 [WARNING] The expression ${pom.build.sourceDirectory} is deprecated. Please use ${project.build.sourceDirectory} instead. @ [ERROR] 'distributionManagement.status' must not be specified. @ line 237, column 13 {noformat} Cheers, > Unknown packaging: bundle when creating report > -- > > Key: MPIR-374 > URL: https://issues.apache.org/jira/browse/MPIR-374 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependency-management >Affects Versions: 3.0.0 > Environment: Java 10 >Reporter: Peter Lamby >Priority: Minor > > After I upgraded the plugin to 3.0.0 I get the following errors: > {noformat} > [INFO] Generating "Dependency Management" report --- > maven-project-info-reports-plugin:3.0.0:dependency-management > [WARNING] Unable to create Maven project for > com.fasterxml.jackson.module:jackson-module-scala_2.10:jar:2.9.5 from > repository. > org.apache.maven.project.ProjectBuildingException: Some problems were > encountered while processing the POMs: > [ERROR] Unknown packaging: bundle @ line 6, column 16 > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:192) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:327) > at > org.apache.maven.report.projectinfo.dependencies.RepositoryUtils.getMavenProjectFromRepository(RepositoryUtils.java:125) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.getDependencyRow(DependencyManagementRenderer.java:253) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderDependenciesForScope(DependencyManagementRenderer.java:202) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderDependenciesForAllScopes(DependencyManagementRenderer.java:151) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderSectionProjectDependencies(DependencyManagementRenderer.java:144) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderBody(DependencyManagementRenderer.java:130) > at > org.apache.maven.reporting.AbstractMavenReportRenderer.render(AbstractMavenReportRenderer.java:80) > at > org.apache.maven.report.projectinfo.DependencyManagementReport.executeReport(DependencyManagementReport.java:107) > at > org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:251) > at > org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:230) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:349) > at > org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:198) > at > org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:147) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.bu
[jira] [Commented] (MPH-154) The output of the plugin should contain a line-ending
[ https://issues.apache.org/jira/browse/MPH-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563428#comment-16563428 ] Karl Heinz Marbaise commented on MPH-154: - As I already asked where you have got that output from ? > The output of the plugin should contain a line-ending > - > > Key: MPH-154 > URL: https://issues.apache.org/jira/browse/MPH-154 > Project: Maven Help Plugin > Issue Type: Improvement >Reporter: Patrick van Rhijn >Priority: Major > > When you use the plugin the output doesn't contain a line-ending making the > output hard to use in scripting when you have JAVA_OPTIONS defined. > In the current situation the plugin gives me the following output: > $ mvn -N -q org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate > -Dexpression='project.groupId' -DforceStdout=true > *nl.foo.barPicked up _JAVA_OPTIONS: -XX:+ForceTimeHighResolution > -Dsun.java2d.noddraw=true -Duser.timezone='Europe/Amsterdam'* > It would be better if the output would be divided over two lines and look > like the output of the exec-maven-plugin: > $ mvn -N -q -Dexec.executable='echo' -Dexec.args='${project.groupId}' > org.codehaus.mojo:exec-maven-plugin:1.4.0:exec > *nl.foo.bar* > *Picked up _JAVA_OPTIONS: -XX:+ForceTimeHighResolution > -Dsun.java2d.noddraw=true -Duser.timezone='Europe/Amsterdam'* > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPH-154) The output of the plugin should contain a line-ending
[ https://issues.apache.org/jira/browse/MPH-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563378#comment-16563378 ] Patrick van Rhijn commented on MPH-154: --- I'm looking into the fact that the line "Picked up..." is generated by the jvm and is specific to the jvm. The result differs when you use a zulu, openjdk or a oracle jre. So I'm looking into a way to suppress this message on the OS. > The output of the plugin should contain a line-ending > - > > Key: MPH-154 > URL: https://issues.apache.org/jira/browse/MPH-154 > Project: Maven Help Plugin > Issue Type: Improvement >Reporter: Patrick van Rhijn >Priority: Major > > When you use the plugin the output doesn't contain a line-ending making the > output hard to use in scripting when you have JAVA_OPTIONS defined. > In the current situation the plugin gives me the following output: > $ mvn -N -q org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate > -Dexpression='project.groupId' -DforceStdout=true > *nl.foo.barPicked up _JAVA_OPTIONS: -XX:+ForceTimeHighResolution > -Dsun.java2d.noddraw=true -Duser.timezone='Europe/Amsterdam'* > It would be better if the output would be divided over two lines and look > like the output of the exec-maven-plugin: > $ mvn -N -q -Dexec.executable='echo' -Dexec.args='${project.groupId}' > org.codehaus.mojo:exec-maven-plugin:1.4.0:exec > *nl.foo.bar* > *Picked up _JAVA_OPTIONS: -XX:+ForceTimeHighResolution > -Dsun.java2d.noddraw=true -Duser.timezone='Europe/Amsterdam'* > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MCOMPILER-355) NPE in CompilerMojo.preparePaths on exception
[ https://issues.apache.org/jira/browse/MCOMPILER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563276#comment-16563276 ] Karl Heinz Marbaise edited comment on MCOMPILER-355 at 7/31/18 8:15 AM: I see that the output of {{mvn -version}} does not show the information about the commit which it has been created off which should look like this: {noformat} Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T09:58:13+02:00) Maven home: /usr/local/maven Java version: 10.0.1, vendor: Oracle Corporation Java home: /home/khm/tools/jdk-10.0.1 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.10.0-862.6.3.el7.x86_64", arch: "amd64", family: "unix" {noformat} Furthermore to fix an issue the first step is to reproduce it which is used as a foundation for an integration test which currently does not work cause if I use your examples: {noformat} [khm@oc4030881648 test]$ mvn -V clean Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T09:58:13+02:00) Maven home: /usr/local/maven Java version: 10.0.1, vendor: Oracle Corporation Java home: /home/khm/tools/jdk-10.0.1 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.10.0-862.6.3.el7.x86_64", arch: "amd64", family: "unix" [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building noojeebilling.api 1.4-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ noojeebilling.api --- [INFO] Deleting /home/khm/ws-git/test/target [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 0.459 s [INFO] Finished at: 2018-07-31T09:59:59+02:00 [INFO] Final Memory: 7M/30M [INFO] {noformat} Furthermore doing the following: {noformat} Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T09:58:13+02:00) Maven home: /usr/local/maven Java version: 10.0.1, vendor: Oracle Corporation Java home: /home/khm/tools/jdk-10.0.1 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.10.0-862.6.3.el7.x86_64", arch: "amd64", family: "unix" [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building noojeebilling.api 1.4-SNAPSHOT [INFO] [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ noojeebilling.api --- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent! [INFO] skip non existing resourceDirectory /home/khm/ws-git/test/src/main/resources [INFO] [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ noojeebilling.api --- [INFO] No sources to compile [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ noojeebilling.api --- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent! [INFO] skip non existing resourceDirectory /home/khm/ws-git/test/src/test/resources [INFO] [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ noojeebilling.api --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ noojeebilling.api --- [INFO] No tests to run. [INFO] [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ noojeebilling.api --- [WARNING] JAR will be empty - no content was marked for inclusion! [INFO] Building jar: /home/khm/ws-git/test/target/noojeebilling.api-1.4-SNAPSHOT.jar [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1.435 s [INFO] Finished at: 2018-07-31T10:01:19+02:00 [INFO] Final Memory: 12M/47M [INFO] {noformat} Apart from that what looks strange to me is the output at the beginning: {noformat} WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNIN
[jira] [Commented] (MCOMPILER-355) NPE in CompilerMojo.preparePaths on exception
[ https://issues.apache.org/jira/browse/MCOMPILER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563276#comment-16563276 ] Karl Heinz Marbaise commented on MCOMPILER-355: --- I see that the output of {{mvn -version}} does not show the information about the commit which it has been created off which should look like this: {noformat} Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T09:58:13+02:00) Maven home: /usr/local/maven Java version: 10.0.1, vendor: Oracle Corporation Java home: /home/khm/tools/jdk-10.0.1 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.10.0-862.6.3.el7.x86_64", arch: "amd64", family: "unix" {noformat} Furthermore to fix an issue the first step is to reproduce it which is used as a foundation for an integration test which currently does not work cause if I use your examples: {noformat} [khm@oc4030881648 test]$ mvn -V clean Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T09:58:13+02:00) Maven home: /usr/local/maven Java version: 10.0.1, vendor: Oracle Corporation Java home: /home/khm/tools/jdk-10.0.1 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.10.0-862.6.3.el7.x86_64", arch: "amd64", family: "unix" [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building noojeebilling.api 1.4-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ noojeebilling.api --- [INFO] Deleting /home/khm/ws-git/test/target [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 0.459 s [INFO] Finished at: 2018-07-31T09:59:59+02:00 [INFO] Final Memory: 7M/30M [INFO] {noformat} Furthermore doing the following: {noformat} Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T09:58:13+02:00) Maven home: /usr/local/maven Java version: 10.0.1, vendor: Oracle Corporation Java home: /home/khm/tools/jdk-10.0.1 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.10.0-862.6.3.el7.x86_64", arch: "amd64", family: "unix" [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building noojeebilling.api 1.4-SNAPSHOT [INFO] [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ noojeebilling.api --- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent! [INFO] skip non existing resourceDirectory /home/khm/ws-git/test/src/main/resources [INFO] [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ noojeebilling.api --- [INFO] No sources to compile [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ noojeebilling.api --- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent! [INFO] skip non existing resourceDirectory /home/khm/ws-git/test/src/test/resources [INFO] [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ noojeebilling.api --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ noojeebilling.api --- [INFO] No tests to run. [INFO] [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ noojeebilling.api --- [WARNING] JAR will be empty - no content was marked for inclusion! [INFO] Building jar: /home/khm/ws-git/test/target/noojeebilling.api-1.4-SNAPSHOT.jar [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1.435 s [INFO] Finished at: 2018-07-31T10:01:19+02:00 [INFO] Final Memory: 12M/47M [INFO] {noformat} Apart from that what looks strange to me is the output at the beginning: {noformat} WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied i
[jira] [Commented] (SCM-318) Allow tags to be removed
[ https://issues.apache.org/jira/browse/SCM-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563224#comment-16563224 ] ASF GitHub Bot commented on SCM-318: Pr0methean opened a new pull request #79: [SCM-318] Untag command, with Git implementations URL: https://github.com/apache/maven-scm/pull/79 Still needs testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow tags to be removed > > > Key: SCM-318 > URL: https://issues.apache.org/jira/browse/SCM-318 > Project: Maven SCM > Issue Type: New Feature > Components: maven-scm-api >Affects Versions: 1.0-rc1 >Reporter: Mark Hobson >Priority: Major > Fix For: 1.x > > > Need to add an untag or removeTag method to ScmProvider to reverse the tag > operation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Pr0methean opened a new pull request #79: [SCM-318] Untag command, with Git implementations
Pr0methean opened a new pull request #79: [SCM-318] Untag command, with Git implementations URL: https://github.com/apache/maven-scm/pull/79 Still needs testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services