[jira] [Commented] (MSHARED-766) Build on JDK 11
[ https://issues.apache.org/jira/browse/MSHARED-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681014#comment-16681014 ] Karl Heinz Marbaise commented on MSHARED-766: - Done in [ee084ddfe152590e8a11d85337febc7018657b04|https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commitdiff;h=ee084ddfe152590e8a11d85337febc7018657b04] > Build on JDK 11 > --- > > Key: MSHARED-766 > URL: https://issues.apache.org/jira/browse/MSHARED-766 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-artifact-transfer-0.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSHARED-766) Build on JDK 11
[ https://issues.apache.org/jira/browse/MSHARED-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHARED-766. --- Resolution: Done > Build on JDK 11 > --- > > Key: MSHARED-766 > URL: https://issues.apache.org/jira/browse/MSHARED-766 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-artifact-transfer-0.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-759) Upgrade parent to version 33
[ https://issues.apache.org/jira/browse/MSHARED-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680996#comment-16680996 ] Hudson commented on MSHARED-759: Build succeeded in Jenkins: Maven TLP » maven-artifact-transfer » master #47 See https://builds.apache.org/job/maven-box/job/maven-artifact-transfer/job/master/47/ > Upgrade parent to version 33 > > > Key: MSHARED-759 > URL: https://issues.apache.org/jira/browse/MSHARED-759 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-artifact-transfer-0.11.0 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MSHARED-766) Build on JDK 11
[ https://issues.apache.org/jira/browse/MSHARED-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MSHARED-766: --- Assignee: Karl Heinz Marbaise > Build on JDK 11 > --- > > Key: MSHARED-766 > URL: https://issues.apache.org/jira/browse/MSHARED-766 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-artifact-transfer-0.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MSHARED-766) Build on JDK 11
Karl Heinz Marbaise created MSHARED-766: --- Summary: Build on JDK 11 Key: MSHARED-766 URL: https://issues.apache.org/jira/browse/MSHARED-766 Project: Maven Shared Components Issue Type: Improvement Components: maven-artifact-transfer Affects Versions: maven-artifact-transfer-0.11.0 Reporter: Karl Heinz Marbaise Fix For: maven-artifact-transfer-0.11.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-759) Upgrade parent to version 33
[ https://issues.apache.org/jira/browse/MSHARED-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680982#comment-16680982 ] Karl Heinz Marbaise commented on MSHARED-759: - Done in [46028b639909d93100f46c7884060f7367294294|https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commitdiff;h=46028b639909d93100f46c7884060f7367294294] > Upgrade parent to version 33 > > > Key: MSHARED-759 > URL: https://issues.apache.org/jira/browse/MSHARED-759 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-artifact-transfer-0.11.0 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSHARED-759) Upgrade parent to version 33
[ https://issues.apache.org/jira/browse/MSHARED-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHARED-759. --- Resolution: Done > Upgrade parent to version 33 > > > Key: MSHARED-759 > URL: https://issues.apache.org/jira/browse/MSHARED-759 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-artifact-transfer-0.11.0 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MSHARED-759) Upgrade parent to version 33
[ https://issues.apache.org/jira/browse/MSHARED-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MSHARED-759: --- Assignee: Karl Heinz Marbaise > Upgrade parent to version 33 > > > Key: MSHARED-759 > URL: https://issues.apache.org/jira/browse/MSHARED-759 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-artifact-transfer-0.11.0 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] olamy closed pull request #29: Removing shading for maven model packages
olamy closed pull request #29: Removing shading for maven model packages URL: https://github.com/apache/maven-indexer/pull/29 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/indexer-core/pom.xml b/indexer-core/pom.xml index 6c3dc96..1f7cd6c 100644 --- a/indexer-core/pom.xml +++ b/indexer-core/pom.xml @@ -237,10 +237,6 @@ under the License. org.apache.commons.compress org.apache.maven.index_shaded.lucene - - org.apache.maven.model - org.apache.maven.index_shaded.maven - This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MSITE-828) Jdk 1.8 required / Upgrade Jetty Version 9.4.12
[ https://issues.apache.org/jira/browse/MSITE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680911#comment-16680911 ] ASF GitHub Bot commented on MSITE-828: -- oflebbe commented on issue #3: [MSITE-828] Upgrade jetty to recent version. Update to java 1.8 (required for jetty) URL: https://github.com/apache/maven-site-plugin/pull/3#issuecomment-437258056 Hi Michael, nice to meet again :-) the change was done on purpose: You know I am hunting down insecure maven configurations in Big Data and IoT projects, though it is the first time I found a maven plugin to be the trigger. The old, deprecated jetty version included an insecure pluginRepository in transitive dependencies to 3rd parties (Fortunately I could arrange the codehaus.org domain to be hosted by apache, but it is still accessed over http). All maintained jetty versions need java 1.8 http://www.eclipse.org/jetty/documentation/current/what-jetty-version.html Seriously, my concern was more that we break compatibility through transitive dependecies. Fortunately you don't see this as a problem. Best Regards, Olaf Von meinem iPad gesendet > Am 08.11.2018 um 22:08 schrieb Michael Osipov : > > Seriously, because of the tests we need to force Java 8 with zero benefit? I Have the latest 1.7 Jetty in Wagon which does the job for testing. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or mute the thread. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Jdk 1.8 required / Upgrade Jetty Version 9.4.12 > --- > > Key: MSITE-828 > URL: https://issues.apache.org/jira/browse/MSITE-828 > Project: Maven Site Plugin > Issue Type: Task >Reporter: Olivier Lamy (*$^¨%`£) >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSITE-828) Jdk 1.8 required / Upgrade Jetty Version 9.4.12
[ https://issues.apache.org/jira/browse/MSITE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680795#comment-16680795 ] ASF GitHub Bot commented on MSITE-828: -- olamy edited a comment on issue #3: [MSITE-828] Upgrade jetty to recent version. Update to java 1.8 (required for jetty) URL: https://github.com/apache/maven-site-plugin/pull/3#issuecomment-437158167 @michael-o I would say seriously in November 2018 with 1.8 already EOL and even 9 or 10 what is the point having 1.7. https://www.oracle.com/technetwork/java/javase/eol-135779.html After this we can then change the code to use 1.8 features. But come on we should try being an attractive project and get new committers!! And saying "we must be 1.7" is definitely not the way to do it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Jdk 1.8 required / Upgrade Jetty Version 9.4.12 > --- > > Key: MSITE-828 > URL: https://issues.apache.org/jira/browse/MSITE-828 > Project: Maven Site Plugin > Issue Type: Task >Reporter: Olivier Lamy (*$^¨%`£) >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679164#comment-16679164 ] Hudson commented on MNG-6481: - Build unstable in Jenkins: Maven TLP » maven » slach-pre-merge-master #7 See https://builds.apache.org/job/maven-box/job/maven/job/slach-pre-merge-master/7/ > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.x-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-1957) clause in the activation section has to provide more complex expressions.
[ https://issues.apache.org/jira/browse/MNG-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679163#comment-16679163 ] Hudson commented on MNG-1957: - Build unstable in Jenkins: Maven TLP » maven » slach-pre-merge-master #7 See https://builds.apache.org/job/maven-box/job/maven/job/slach-pre-merge-master/7/ > clause in the activation section has to provide more complex > expressions. > - > > Key: MNG-1957 > URL: https://issues.apache.org/jira/browse/MNG-1957 > Project: Maven > Issue Type: Improvement > Components: POM >Affects Versions: 2.0, 2.0.1 >Reporter: Trustin Lee >Assignee: Brett Porter >Priority: Major > Fix For: 2.1.0 > > Attachments: MNG-1957-maven-project.patch > > > For now, provides only one operator '!' which means negation, but > it would be great if i can use '+' and ~ operator: > 1.5+ > 1.1 ~ 1.4 > ~ 1.3 > 1.4 ~ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MNG-6509) Upgrade maven-dependency-plugin to 3.1.1
[ https://issues.apache.org/jira/browse/MNG-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-6509. - Resolution: Fixed > Upgrade maven-dependency-plugin to 3.1.1 > > > Key: MNG-6509 > URL: https://issues.apache.org/jira/browse/MNG-6509 > Project: Maven > Issue Type: Dependency upgrade > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > > Upgrade plugin to version compatible with Java 9+ for dependency:resolve goal > in Bootstrap ITs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6509) Upgrade maven-dependency-plugin to 3.1.1
[ https://issues.apache.org/jira/browse/MNG-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680480#comment-16680480 ] Hudson commented on MNG-6509: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5995 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5995/2/ > Upgrade maven-dependency-plugin to 3.1.1 > > > Key: MNG-6509 > URL: https://issues.apache.org/jira/browse/MNG-6509 > Project: Maven > Issue Type: Dependency upgrade > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > > Upgrade plugin to version compatible with Java 9+ for dependency:resolve goal > in Bootstrap ITs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPATCH-20) support exclude pattern
[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679422#comment-16679422
]
ASF GitHub Bot commented on MPATCH-20:
--
matthiasbalke commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r231796857
##
File path: src/main/java/org/apache/maven/plugin/patch/ApplyMojo.java
##
@@ -237,6 +238,16 @@
@Parameter( defaultValue = "false" )
private boolean binary;
+/**
+ * List of ANT-style exclude patterns. These patterns are used to exclude
patch files found
+ * in the {@link ApplyMojo#patchDirectory}. These exclude patterns does
not apply to a static defined list of
+ * {@link ApplyMojo#patches}.
+ *
+ * @since 1.3
+ */
+@Parameter
+private List excludes;
Review comment:
Currently no generics are getting used within the code of the plugin. Thats
why I kept this style. Do you want to change it anyways?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> ---
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
>Affects Versions: 1.2, 1.3
>Reporter: Matthias Balke
>Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1588) Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8
[
https://issues.apache.org/jira/browse/SUREFIRE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679350#comment-16679350
]
ASF GitHub Bot commented on SUREFIRE-1588:
--
Tibor17 commented on a change in pull request #198: [SUREFIRE-1588] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r231778368
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##
@@ -150,8 +150,10 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
-return new URI( null, parent.relativize( classPathElement.toPath()
).toString(), null )
-.toASCIIString();
+return new URI( null,
+parent.relativize( classPathElement.toPath()
).toString().
Review comment:
You could use a separate variable since this is getting long line. It would
be at least easy to debug.
```
Path absolutePath = classPathElement.toPath();
String relativeUriPath = parent.relativize( absolutePath )
.toString()
.replace( File.separatorChar, '/' );
return new URI( null, relativeUriPath, null ).toASCIIString();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8
> ---
>
> Key: SUREFIRE-1588
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1588
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.22.1
>Reporter: Cservenak, Tamas
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M1
>
>
> See issue [1], but in short: latest Java8 on Ubuntu/Debian/Mint family of
> Linuxes (am on Mint, Ubuntu derivative) contains this patch [3], and eforces
> Manifest class path entries to be relative, as defined in [2].
> Hence, surefire booter and rest of Maven classpath, that uses absolute URLs
> are simply discarded.
> Example error:
> {noformat}
> # Created at 2018-10-30T21:34:43.339
> Error: Could not find or load main class
> org.apache.maven.surefire.booter.ForkedBooter{noformat}
> using the new property
> {{-Djdk.net.URLClassPath.disableClassPathURLCheck=debug}} clearly shows that
> all the entries from the surefire JAR are simply ignored.
>
> [1] [https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911925]
> [2]
> https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#classpath
> [3] [https://hg.openjdk.java.net/jdk/jdk/rev/27135de165ac]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MNG-6509) Upgrade maven-dependency-plugin to 3.1.1
Sylwester Lachiewicz created MNG-6509: - Summary: Upgrade maven-dependency-plugin to 3.1.1 Key: MNG-6509 URL: https://issues.apache.org/jira/browse/MNG-6509 Project: Maven Issue Type: Dependency upgrade Components: Integration Tests Reporter: Sylwester Lachiewicz Assignee: Sylwester Lachiewicz Upgrade plugin to version compatible with Java 9+ for dependency:resolve goal in Bootstrap ITs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-1957) clause in the activation section has to provide more complex expressions.
[ https://issues.apache.org/jira/browse/MNG-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679086#comment-16679086 ] Hudson commented on MNG-1957: - Build unstable in Jenkins: Maven TLP » maven » slach-build8 #3 See https://builds.apache.org/job/maven-box/job/maven/job/slach-build8/3/ > clause in the activation section has to provide more complex > expressions. > - > > Key: MNG-1957 > URL: https://issues.apache.org/jira/browse/MNG-1957 > Project: Maven > Issue Type: Improvement > Components: POM >Affects Versions: 2.0, 2.0.1 >Reporter: Trustin Lee >Assignee: Brett Porter >Priority: Major > Fix For: 2.1.0 > > Attachments: MNG-1957-maven-project.patch > > > For now, provides only one operator '!' which means negation, but > it would be great if i can use '+' and ~ operator: > 1.5+ > 1.1 ~ 1.4 > ~ 1.3 > 1.4 ~ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSITE-828) Jdk 1.8 required / Upgrade Jetty Version 9.4.12
[ https://issues.apache.org/jira/browse/MSITE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680393#comment-16680393 ] ASF GitHub Bot commented on MSITE-828: -- olamy commented on issue #3: [MSITE-828] Upgrade jetty to recent version. Update to java 1.8 (required for jetty) URL: https://github.com/apache/maven-site-plugin/pull/3#issuecomment-437158167 @michael-o I would say seriously!! in November 2018 with 1.8 already EOL and even 9 or 10 what is the point having 1.7. https://www.oracle.com/technetwork/java/javase/eol-135779.html After this we can then change the code to use 1.8 features. But come on we should try being an attractive project and get new committers!! And saying "we must be 1.7" is definitely not the way to do it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Jdk 1.8 required / Upgrade Jetty Version 9.4.12 > --- > > Key: MSITE-828 > URL: https://issues.apache.org/jira/browse/MSITE-828 > Project: Maven Site Plugin > Issue Type: Task >Reporter: Olivier Lamy (*$^¨%`£) >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680013#comment-16680013
]
ASF GitHub Bot commented on SUREFIRE-1593:
--
Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r231979549
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
-return new URI( null,
-parent.relativize( classPathElement.toPath()
).toString().
-replace( File.separatorChar, '/' ),
-null ).toASCIIString();
+Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
This won't tested by ITs because we cannot occupy any disk on Jenkins, but
this algorithm could be tested by unit test and Mockito. At least Line 153 in
mock and next two lines are real and tested. If the Line went to private static
method, we could mock it via PowerMock, and then the next two lines together in
another method calling the first static method. We would assert the returned
value has Unix slashes and white spaces are escaped, paths are relative, etc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 3.0.0-M1 produces invalid code sources on Windows
> -
>
> Key: SUREFIRE-1593
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, process forking
>Affects Versions: 3.0.0-M1
>Reporter: Jesse Glick
>Priority: Major
>
> The fix for SUREFIRE-1588 did not work correctly on Windows. (When
> active—i.e., when the drive letters of the system temporary directory, per
> SUREFIRE-1400, and the project basedir were the same.) It would produce
> relative URIs containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-267) Upgrade to make Maven 3+
[ https://issues.apache.org/jira/browse/MENFORCER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680009#comment-16680009 ] Mikolaj Izdebski commented on MENFORCER-267: Karl, are you still working on this issue? Fedora has a patch porting Enforcer to Maven 3 API and I may be able to rebase/improve it and submit as a pull request. https://src.fedoraproject.org/rpms/maven-enforcer/blob/4ceb05a/f/0001-Port-to-Maven-3-API.patch > Upgrade to make Maven 3+ > > > Key: MENFORCER-267 > URL: https://issues.apache.org/jira/browse/MENFORCER-267 > Project: Maven Enforcer Plugin > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Blocker > Fix For: 3.0.0 > > > * maven-dependency-tree needs to be updated to 3.0.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679849#comment-16679849
]
ASF GitHub Bot commented on SUREFIRE-1593:
--
jglick commented on issue #198: [SUREFIRE-1593] Correcting relativization logic
to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437017168
> Create a new Jira ticket.
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 3.0.0-M1 produces invalid code sources on Windows
> -
>
> Key: SUREFIRE-1593
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, process forking
>Affects Versions: 3.0.0-M1
>Reporter: Jesse Glick
>Priority: Major
>
> The fix for SUREFIRE-1588 did not work correctly on Windows. (When
> active—i.e., when the drive letters of the system temporary directory, per
> SUREFIRE-1400, and the project basedir were the same.) It would produce
> relative URIs containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MEAR-272) SNAPSHOT dependencies are copied with timestamp
Benjamin Cartereau created MEAR-272: --- Summary: SNAPSHOT dependencies are copied with timestamp Key: MEAR-272 URL: https://issues.apache.org/jira/browse/MEAR-272 Project: Maven Ear Plugin Issue Type: Bug Affects Versions: 3.0.1 Environment: JDK 8 Maven 3.3 and 3.5 Reporter: Benjamin Cartereau We have an EAR project that have a dependency towards a SNAPSHOT (version in dependency within the pom set as "1.0-SNASPHOT") version of a jar stored in our Nexus repository. When we build the project, the ear:ear plugin is executed and we can see that the timestamp version of the dependency is copied as is: [INFO] Copying artifact[jar:xxx:yyy:1.0-20181106.150409-27] to[yyy-*1.0-20181106.150409-27*.jar] We also tried with the 3.0.0 version of the ear plugin and we get the same result. Then we have tried the 2.10.1 version of the plugin (with the useBaseVersion set to true in ear plugin configuration) and it is now working: [INFO] Copying artifact[jar:xxx:yyy:1.0-20181106.150409-27] to[yyy-*1.0-SNAPSHOT*.jar] The "useBaseVersion" parameter has no effect with 3.0.1 version of the plugin except displaying the warn message "Using _useBaseVersion_ not _yet_ fixed". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679238#comment-16679238 ] Hudson commented on MNG-6481: - Build succeeded in Jenkins: Maven TLP » maven » slach-pre-merge-master #8 See https://builds.apache.org/job/maven-box/job/maven/job/slach-pre-merge-master/8/ > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.x-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6427) IT for MNG-1957 fails on Java 9+
[
https://issues.apache.org/jira/browse/MNG-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679162#comment-16679162
]
Hudson commented on MNG-6427:
-
Build unstable in Jenkins: Maven TLP » maven » slach-pre-merge-master #7
See
https://builds.apache.org/job/maven-box/job/maven/job/slach-pre-merge-master/7/
> IT for MNG-1957 fails on Java 9+
>
>
> Key: MNG-6427
> URL: https://issues.apache.org/jira/browse/MNG-6427
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> The execution fails with:
> {noformat}
> junit.framework.ComparisonFailure: expected: but was:
> at
> org.apache.maven.it.MavenITmng1957JdkActivationWithVersionRangeTest.testitMNG1957(MavenITmng1957JdkActivationWithVersionRangeTest.java:64)
> {noformat}
> This is caused by incorrect JDK ranges in the {{pom.xml}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
Jesse Glick created SUREFIRE-1593:
-
Summary: 3.0.0-M1 produces invalid code sources on Windows
Key: SUREFIRE-1593
URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
Project: Maven Surefire
Issue Type: Bug
Components: classloading, process forking
Affects Versions: 3.0.0-M1
Reporter: Jesse Glick
The fix for SUREFIRE-1588 did not work correctly on Windows. (When active—i.e.,
when the drive letters of the system temporary directory, per SUREFIRE-1400,
and the project basedir were the same.) It would produce relative URIs
containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSITE-828) Jdk 1.8 required / Upgrade Jetty Version 9.4.12
[ https://issues.apache.org/jira/browse/MSITE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680385#comment-16680385 ] ASF GitHub Bot commented on MSITE-828: -- michael-o commented on issue #3: [MSITE-828] Upgrade jetty to recent version. Update to java 1.8 (required for jetty) URL: https://github.com/apache/maven-site-plugin/pull/3#issuecomment-437156499 Seriously, because of the tests we need to force Java 8 with zero benefit? I Have the latest 1.7 Jetty in Wagon which does the job for testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Jdk 1.8 required / Upgrade Jetty Version 9.4.12 > --- > > Key: MSITE-828 > URL: https://issues.apache.org/jira/browse/MSITE-828 > Project: Maven Site Plugin > Issue Type: Task >Reporter: Olivier Lamy (*$^¨%`£) >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680352#comment-16680352 ] Hudson commented on MNG-6481: - Build succeeded in Jenkins: Maven TLP » maven » master #109 See https://builds.apache.org/job/maven-box/job/maven/job/master/109/ > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.x-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6427) IT for MNG-1957 fails on Java 9+
[
https://issues.apache.org/jira/browse/MNG-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680350#comment-16680350
]
Hudson commented on MNG-6427:
-
Build succeeded in Jenkins: Maven TLP » maven » master #109
See https://builds.apache.org/job/maven-box/job/maven/job/master/109/
> IT for MNG-1957 fails on Java 9+
>
>
> Key: MNG-6427
> URL: https://issues.apache.org/jira/browse/MNG-6427
> Project: Maven
> Issue Type: Bug
> Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> The execution fails with:
> {noformat}
> junit.framework.ComparisonFailure: expected: but was:
> at
> org.apache.maven.it.MavenITmng1957JdkActivationWithVersionRangeTest.testitMNG1957(MavenITmng1957JdkActivationWithVersionRangeTest.java:64)
> {noformat}
> This is caused by incorrect JDK ranges in the {{pom.xml}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-1957) clause in the activation section has to provide more complex expressions.
[ https://issues.apache.org/jira/browse/MNG-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680351#comment-16680351 ] Hudson commented on MNG-1957: - Build succeeded in Jenkins: Maven TLP » maven » master #109 See https://builds.apache.org/job/maven-box/job/maven/job/master/109/ > clause in the activation section has to provide more complex > expressions. > - > > Key: MNG-1957 > URL: https://issues.apache.org/jira/browse/MNG-1957 > Project: Maven > Issue Type: Improvement > Components: POM >Affects Versions: 2.0, 2.0.1 >Reporter: Trustin Lee >Assignee: Brett Porter >Priority: Major > Fix For: 2.1.0 > > Attachments: MNG-1957-maven-project.patch > > > For now, provides only one operator '!' which means negation, but > it would be great if i can use '+' and ~ operator: > 1.5+ > 1.1 ~ 1.4 > ~ 1.3 > 1.4 ~ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679945#comment-16679945 ] Karl Heinz Marbaise commented on MNG-6481: -- [~slachiewicz] Could you please name your branches based on the issue ...instead of something different... > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.x-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1384) Add ProviderInfo for JUnit Plattform to enable automatic provider lookup
[ https://issues.apache.org/jira/browse/SUREFIRE-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679521#comment-16679521 ] Christian Stein commented on SUREFIRE-1384: --- Superseded/fixed by https://issues.apache.org/jira/browse/SUREFIRE-1330 – if nobody objects, I'll close this issue soon. > Add ProviderInfo for JUnit Plattform to enable automatic provider lookup > > > Key: SUREFIRE-1384 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1384 > Project: Maven Surefire > Issue Type: Improvement > Components: JUnit 5.x support >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.0.0-M3 > > > In order to enable automatic provider lookup for JUnit Plattform/JUnit 5, we > need to add the corresponding ProviderInfo implementation to > AbstractSurefireMojo. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAR-252) Upgrade plexus-archiver to 3.6.0
[ https://issues.apache.org/jira/browse/MJAR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679932#comment-16679932 ] Karl Heinz Marbaise commented on MJAR-252: -- Apart from that you shouldn't use a closed issue better create a new one... > Upgrade plexus-archiver to 3.6.0 > > > Key: MJAR-252 > URL: https://issues.apache.org/jira/browse/MJAR-252 > Project: Maven JAR Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.1.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680265#comment-16680265
]
Hudson commented on MNG-6391:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.0
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6497) Upgrade guice to 4.2.1
[ https://issues.apache.org/jira/browse/MNG-6497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680268#comment-16680268 ] Hudson commented on MNG-6497: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade guice to 4.2.1 > -- > > Key: MNG-6497 > URL: https://issues.apache.org/jira/browse/MNG-6497 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.6.0 > > > Upgrade would be a good idea based on > https://app.snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-32236 > Based on the upgrade of guice to 4.2.1 we get an upgrade of Guava to version > 25.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MNG-5896) Download dependency POMs in parallel
[ https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-5896: - Assignee: (was: Sylwester Lachiewicz) > Download dependency POMs in parallel > > > Key: MNG-5896 > URL: https://issues.apache.org/jira/browse/MNG-5896 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.3.3 >Reporter: Harald Wellmann >Priority: Major > Fix For: 3.6.x-candidate, needing-scrub-3.4.0-fallout > > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.3 first downloads the dependency POMs > _sequentially_ and then proceeds downloading the dependency JARs with up to 5 > threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-6481: - Assignee: (was: Sylwester Lachiewicz) > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.x-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680287#comment-16680287 ] Sylwester Lachiewicz commented on MNG-6481: --- Sorry, yes, my branches deleted - that was multiple patches combined for testing with Java 8/11 only code before planned merge to master. Next time I'll submit patches one by one :) > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.x-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6164) Collections inconsistently immutable
[
https://issues.apache.org/jira/browse/MNG-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680261#comment-16680261
]
Hudson commented on MNG-6164:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Collections inconsistently immutable
>
>
> Key: MNG-6164
> URL: https://issues.apache.org/jira/browse/MNG-6164
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Christian Schulte
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.6.0
>
>
> There are plenty of places where empty collections are returned from public
> API in methods written like:
> {code}
> public List getExceptions()
> {
> return exceptions == null ? Collections.emptyList() :
> exceptions;
> }
> {code}
> The issue with this is that the empty list is immutable but the collection
> returned for the nun-null case is not immutable.
> All those methods should return a collection with consistent "mutability":
> either mutable, either immutable.
> Given empty immutable collections do not cause harm until now, switching
> consistently to immutable collections is more conservative and should not be
> risky
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6012) Missing profile is only notified at the end of a run
[ https://issues.apache.org/jira/browse/MNG-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680269#comment-16680269 ] Hudson commented on MNG-6012: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Missing profile is only notified at the end of a run > > > Key: MNG-6012 > URL: https://issues.apache.org/jira/browse/MNG-6012 > Project: Maven > Issue Type: New Feature >Affects Versions: 3.3.9 >Reporter: Sebb >Priority: Major > Fix For: needing-scrub-3.4.0-fallout > > > A missing profile is only notified at the end of a run. > Since this may mean that the run is useless, it would be helpful if: > 1) It was also noted near the start, so the user could cancel the run. > It's still helpful at the end, as it saves scrolling back to see if there was > a problem. > 2) There were an option to fail a run if a profile is not found. This option > should be settable in a POM and in settings.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6490) Maven shall not fail reporting circular dependency when the dependency is a classified secondary artifact
[
https://issues.apache.org/jira/browse/MNG-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680266#comment-16680266
]
Hudson commented on MNG-6490:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Maven shall not fail reporting circular dependency when the dependency is a
> classified secondary artifact
> -
>
> Key: MNG-6490
> URL: https://issues.apache.org/jira/browse/MNG-6490
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 3.5.2, 3.5.3, 3.5.4
> Environment: Ubuntu 16.0.4 LTS, Ubuntu 18.0.4 LTS, Mac OS High
> Sierra, Oracle and OpenJDK 8, Oracle Java 11,
>Reporter: John Canny
>Assignee: Sylwester Lachiewicz
>Priority: Blocker
> Fix For: 3.6.0
>
>
> As of maven 3.5.2, 3.5.3, 3.5.4, the following pom fails with the error
> "dependencies.dependency. Main:MainJar:1' for Main:MainJar:1 is referencing
> itself"
> But the dependency is not circular, it references a classified jar (in our
> use cases its an architecture-dependent native code container jar). The pom
> below allows the main jar to be built without building the dependency every
> time (other lines conditionally build the dependency), and ensures the
> appropriate pre-built dependency is loaded. Behavior in maven 3.5.0 and
> earlier was correct (i.e. no error). This breaks several of the usage
> scenarios for classified artifacts...
>
> {code:xml}http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> Main
> MainJar
> jar
> 1
>
>
> ${project.groupId}
> ${project.artifactId}
> ${project.version}
> linux
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6492) Minor improvement on Array construction, converson
[ https://issues.apache.org/jira/browse/MNG-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680267#comment-16680267 ] Hudson commented on MNG-6492: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Minor improvement on Array construction, converson > -- > > Key: MNG-6492 > URL: https://issues.apache.org/jira/browse/MNG-6492 > Project: Maven > Issue Type: Improvement >Reporter: Hoa Phan >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.0 > > > See [https://shipilev.net/blog/2016/arrays-wisdom-ancients/] for benchmark. > These more performant code style are also built-in check in IntelliJ. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6496) Upgrade Maven Resolver to 1.3.1
[ https://issues.apache.org/jira/browse/MNG-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680264#comment-16680264 ] Hudson commented on MNG-6496: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade Maven Resolver to 1.3.1 > --- > > Key: MNG-6496 > URL: https://issues.apache.org/jira/browse/MNG-6496 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.6.0 > > > * MRESOLVER-60 – Possible NPE when calling > RepositorySystemSession.getFileTransformerManager > * Remove dependency to old maven-resolver Logger -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6489) Upgrade Maven Resolver to 1.3.0
[ https://issues.apache.org/jira/browse/MNG-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680262#comment-16680262 ] Hudson commented on MNG-6489: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade Maven Resolver to 1.3.0 > --- > > Key: MNG-6489 > URL: https://issues.apache.org/jira/browse/MNG-6489 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories, Dependencies >Affects Versions: 3.5.4 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > > Release Notes - Maven Resolver - Version 1.3.0 > Bug > * MRESOLVER-45 - Git repo is gone/moved > * MRESOLVER-50 - Source repository coordinates incorrect > New Feature > * MRESOLVER-46 - Add support InputStream/OutputStream transformers > Improvement > * MRESOLVER-31 - Use the Felix Bundle Plugin to generate OSGi metadata > * MRESOLVER-35 - Move dependency collector and friends to subpackage in > maven-resolver-impl > * MRESOLVER-36 - SLFJ - remove LoggerFactory from dependency injection > * MRESOLVER-42 - Use pre-compiled pattern in DefaultArtifact constructor > * MRESOLVER-47 - Link to older Aether Wiki in Eclipse on front page > * MRESOLVER-48 - Add default Travis CI configuration for Java 7, 8, 10 > Task > * MRESOLVER-44 - switch from Git-WIP to Gitbox -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6491) Upgrade commons-lang3 to 3.8.1
[ https://issues.apache.org/jira/browse/MNG-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680263#comment-16680263 ] Hudson commented on MNG-6491: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade commons-lang3 to 3.8.1 > -- > > Key: MNG-6491 > URL: https://issues.apache.org/jira/browse/MNG-6491 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Hervé Boutemy >Priority: Trivial > Fix For: 3.6.0 > > > Upgrade to latest version compatible with Java 11 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6386) ${project.baseUri} is not a valid URI (according to RFC 3986)
[
https://issues.apache.org/jira/browse/MNG-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680235#comment-16680235
]
Hudson commented on MNG-6386:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> ${project.baseUri} is not a valid URI (according to RFC 3986)
> -
>
> Key: MNG-6386
> URL: https://issues.apache.org/jira/browse/MNG-6386
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.5.4
>
>
> {{File#toURI}} produces an invalid URI on Windows:
> {noformat}
> file:/C:/path/to/basedir{noformat}
> A valid URI has to be:
> {noformat}
> file:///C:/path/to/basedir{noformat}
> Same issue for Unix-like OSes:
> {noformat}
> file:/path/to/basedir{noformat}
> A valid URI has to be:
> {noformat}
> file:///path/to/basedir{noformat}
> Using {{Path#toUri}} we can easily solve that problem because it creates
> compliant URIs. The failure occurs when interacting with local Git and
> Subversion repos:
> {noformat}
> PS D:\Entwicklung\Projekte\maven-scm> svn ls
> file:/D:/Entwicklung/svn-repos/scm-svn-test-at-sign
> svn: E020024: Error resolving case of
> 'file:\D:\Entwicklung\svn-repos\scm-svn-test-at-sign'
> while the proper (new) havior will produce a valid URI:
> PS D:\Entwicklung\Projekte\maven-scm> svn ls
> file:///D:/Entwicklung/svn-repos/scm-svn-test-at-sign
> branches/
> tags/
> trunk/
> {noformat}
> {noformat}
> PS D:\Entwicklung\Projekte> git clone file:///D:/Entwicklung/git-repos/toll
> tlll2
> Cloning into 'tlll2'...
> warning: You appear to have cloned an empty repository.
> PS D:\Entwicklung\Projekte> git clone file:/D:/Entwicklung/git-repos/toll
> tlll2
> Cloning into 'tlll2'...
> ssh: Could not resolve hostname file: Name or service not known
> fatal: Could not read from remote repository.
> {noformat}
> or Subversion repo at: {{D:\Entwicklung\svn-repos\это по-русский}}:
> {noformat}
> PS D:\Entwicklung\Projekte> svn ls
> file:/D:/Entwicklung/svn-repos/это%20по-русский/
> svn: E020024: Error resolving case of
> 'file:\D:\Entwicklung\svn-repos\???%20??-???\'
> {noformat}
> proper URI gives:
> {noformat}
> PS D:\Entwicklung\Projekte> svn ls
> file:///D:/Entwicklung/svn-repos/%D1%8D%D1%82%D0%BE%20%D0%BF%D0%BE-%D1%80%D1%83%D1%81%D1%81%D0%BA%D0%B8%D0%B9/
> branches/
> tags/
> trunk/
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6478) Upgrade parent to 33 for sha512 checksum on release
[ https://issues.apache.org/jira/browse/MNG-6478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680253#comment-16680253 ] Hudson commented on MNG-6478: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade parent to 33 for sha512 checksum on release > --- > > Key: MNG-6478 > URL: https://issues.apache.org/jira/browse/MNG-6478 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Major > Fix For: 3.6.0 > > > benefit from MPOM-205 and customize for Maven core (which does not have > classical release files) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6363) Remove secret thread configuration property from code
[
https://issues.apache.org/jira/browse/MNG-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680234#comment-16680234
]
Hudson commented on MNG-6363:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Remove secret thread configuration property from code
> -
>
> Key: MNG-6363
> URL: https://issues.apache.org/jira/browse/MNG-6363
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.4
>
>
> Currently the code of Maven core {{MavenCli}} contains something like this:
> {code:java}
> final String threadConfiguration = commandLine.hasOption(
> CLIManager.THREADS )
> ? commandLine.getOptionValue( CLIManager.THREADS )
> : request.getSystemProperties().getProperty(
> MavenCli.THREADS_DEPRECATED ); // TODO Remove this setting.
> Note that the int-tests use it
> {code}
> We should remove the {{THREADS_DEPRECATED}} part here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6403) Artifact#VERSION_FILE_PATTERN does not escape period between date and time
[
https://issues.apache.org/jira/browse/MNG-6403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680237#comment-16680237
]
Hudson commented on MNG-6403:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Artifact#VERSION_FILE_PATTERN does not escape period between date and time
> --
>
> Key: MNG-6403
> URL: https://issues.apache.org/jira/browse/MNG-6403
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.5.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.5.4
>
>
> The pattern {{^(.*)\-([0-9]\{8\}.[0-9]\{6\})\-([0-9]+)$}} accepts everything
> between date and time. This is wrong. It shall be a period only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6475) Remove guava dependencies
[ https://issues.apache.org/jira/browse/MNG-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680251#comment-16680251 ] Hudson commented on MNG-6475: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Remove guava dependencies > - > > Key: MNG-6475 > URL: https://issues.apache.org/jira/browse/MNG-6475 > Project: Maven > Issue Type: Task >Affects Versions: 3.6.0 >Reporter: Phillip Webb >Assignee: Karl Heinz Marbaise >Priority: Trivial > Fix For: 3.6.0 > > > It looks like [this > commit|https://github.com/apache/maven/commit/b8c06e61ab73cd9e25a5b2c93d9e5077b2196751] > removed Guava imports from the codebase, however, several dependencies are > still declared in the POMs. This can be problematic for projects that embed > Maven jars (see MNG-6306 for an example). > I tried a local Maven build with guava dependencies removed and it appears to > compile without issue. I'll submit a pull request with the relevant changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6424) Upgrade plexus-interpolation to 1.25
[ https://issues.apache.org/jira/browse/MNG-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680246#comment-16680246 ] Hudson commented on MNG-6424: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade plexus-interpolation to 1.25 > > > Key: MNG-6424 > URL: https://issues.apache.org/jira/browse/MNG-6424 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.5.4 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6467) Remove plugin definition from pom file which is inherited
[ https://issues.apache.org/jira/browse/MNG-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680249#comment-16680249 ] Hudson commented on MNG-6467: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Remove plugin definition from pom file which is inherited > - > > Key: MNG-6467 > URL: https://issues.apache.org/jira/browse/MNG-6467 > Project: Maven > Issue Type: Improvement > Components: Errors, General >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Trivial > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6344) Upgrade Guice to 4.2.0
[
https://issues.apache.org/jira/browse/MNG-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680244#comment-16680244
]
Hudson commented on MNG-6344:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Upgrade Guice to 4.2.0
> --
>
> Key: MNG-6344
> URL: https://issues.apache.org/jira/browse/MNG-6344
> Project: Maven
> Issue Type: Dependency upgrade
>Affects Versions: 3.5.2
>Reporter: Sylwester Lachiewicz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> A new version is available from
> [https://github.com/google/guice/wiki/Guice41] (released in 2016) - we should
> consider update.
> While updating - Maven depends on Guice, but with removed AOP code.
> {code:java}
> org.apache.maven:maven-core:jar:3.5.3-SNAPSHOT
> \- com.google.inject:guice:jar:no_aop:4.0:compile
> \- aopalliance:aopalliance:jar:1.0:compile{code}
> This has impact on performance
> [https://github.com/google/guice/wiki/OptionalAOP]
> If we decide to keep no_aop version, probably dependency to aopalliance can
> be removed (4kb).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6480) Eclipse.org site is down, and you are unable to build Maven?
[
https://issues.apache.org/jira/browse/MNG-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680258#comment-16680258
]
Hudson commented on MNG-6480:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Eclipse.org site is down, and you are unable to build Maven?
>
>
> Key: MNG-6480
> URL: https://issues.apache.org/jira/browse/MNG-6480
> Project: Maven
> Issue Type: Improvement
>Reporter: Cservenak, Tamas
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.0
>
>
> Was trying to build Maven locally, just to see it is failing (actually, too
> way long was stuck in console). Had no idea what is happening until I did
> {{-X}}, to see it is {{maven-remote-resources-plugin}} (see below).
> I am quite surprised to see, that if {{eclipse.org}} site is down (as in this
> moment), one cannot build Apache Maven, and I find it quite ironic.
> {noformat}
> [DEBUG] URLResourceLoader: Exception when looking for
> 'http://www.eclipse.org/legal/epl-v10.html' at ''
> java.net.SocketException: Unexpected end of file from server
> at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:792)
> at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
> at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:789)
> at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
> at
> sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1536)
> at
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)
> at java.net.URL.openStream(URL.java:1045)
> at
> org.codehaus.plexus.resource.loader.URLResourceLoader.getResource(URLResourceLoader.java:73)
> at
> org.codehaus.plexus.resource.DefaultResourceManager.getResource(DefaultResourceManager.java:159)
> at
> org.codehaus.plexus.resource.DefaultResourceManager.getResourceAsFile(DefaultResourceManager.java:91)
> at sun.reflect.GeneratedMethodAccessor69.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
> at
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
> at
> org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
> at
> org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
> at
> org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:567)
> at
> org.apache.velocity.runtime.parser.node.ASTExpression.value(ASTExpression.java:71)
> at
> org.apache.velocity.runtime.parser.node.ASTSetDirective.render(ASTSetDirective.java:142)
> at
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
> at
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
> at
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
> at
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
> at
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
> at
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
> at
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
> at
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
> at
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
> at
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
> at
> org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
> at
> org.apache.velocity.runtime.RuntimeInstance.render(RuntimeInstance.java:1378)
> at
> org.apache.velocity.runtime.RuntimeInstance.evaluate(RuntimeInstance.java:1314)
> at org.apache.velocity.app.Velocity.evaluate(Velocity.java:254)
> at
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1218)
> at
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.execute(ProcessRemoteResourcesMojo.java:520)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apach
[jira] [Commented] (MNG-6410) Add groupId to --resume-from suggestion if artifactId is not unique in reactor
[
https://issues.apache.org/jira/browse/MNG-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680241#comment-16680241
]
Hudson commented on MNG-6410:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Add groupId to --resume-from suggestion if artifactId is not unique in reactor
> --
>
> Key: MNG-6410
> URL: https://issues.apache.org/jira/browse/MNG-6410
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> In multi module builds same artifact id can be repeated with different group
> id. For example if project strategy is to use nesting of modules, instead of
> using long artifact names, {{ap}} or {{model}} module can occur multiple
> times with different group id.
> By default maven, upon failed build, prints out only {{-rf :artifactId}}.
> When developer will copy given suggestion and run build again then his build
> will be started from first module which have given artifact id.
> While severity of this bug is quite low, it affects productivity in bigger
> projects big time. To improve usability of returned message a Maven should
> return {{-rf groupId:artifactId}} once artifact id is not unique.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6423) Upgrade to Wagon 3.1.0
[ https://issues.apache.org/jira/browse/MNG-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680242#comment-16680242 ] Hudson commented on MNG-6423: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade to Wagon 3.1.0 > -- > > Key: MNG-6423 > URL: https://issues.apache.org/jira/browse/MNG-6423 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Affects Versions: 3.5.3 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.5.4 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-5940) Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
[
https://issues.apache.org/jira/browse/MNG-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680245#comment-16680245
]
Hudson commented on MNG-5940:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
> ---
>
> Key: MNG-5940
> URL: https://issues.apache.org/jira/browse/MNG-5940
> Project: Maven
> Issue Type: Improvement
> Components: core
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> At the moment the {{maven-source-plugin:jar}} goal is defined in the Maven
> super pom:
> {code:xml}
>
> true
> maven-source-plugin
>
>
> attach-sources
>
> jar
>
>
>
>
> {code}
> where the goal of {{maven-source-plugin}} should be changed from {{jar}} into
> {{jar-no-fork}}, cause most of the time you need to override this behaviour.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNGSITE-339) Broken link: Mailing lists
[ https://issues.apache.org/jira/browse/MNGSITE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680247#comment-16680247 ] Hudson commented on MNGSITE-339: Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Broken link: Mailing lists > -- > > Key: MNGSITE-339 > URL: https://issues.apache.org/jira/browse/MNGSITE-339 > Project: Maven Project Web Site > Issue Type: Bug >Reporter: Henning Hoefer >Assignee: Michael Osipov >Priority: Major > Labels: broken-link > > The mailing lists page seems to have vanished: > [https://maven.apache.org/mail-lists.html] > This page is referenced quite a lot on the net, e.g.: > * Google: [https://www.google.de/search?q=maven+mailing+list] > * Apache project list: [https://projects.apache.org/project.html?maven] > * Maven home page (sidebar): [https://maven.apache.org/index.html] > It should therefore probably be reinstated/replaced. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6449) Upgrade parent to 32
[ https://issues.apache.org/jira/browse/MNG-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680248#comment-16680248 ] Hudson commented on MNG-6449: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade parent to 32 > > > Key: MNG-6449 > URL: https://issues.apache.org/jira/browse/MNG-6449 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6411) Improve readability of project list returned when --resume-from option value is invalid
[
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680240#comment-16680240
]
Hudson commented on MNG-6411:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Improve readability of project list returned when --resume-from option value
> is invalid
> ---
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of
> all projects in build is returned.
> This list contains too much information. For every project it includes
> groupId, artifactId, version and pom location. While it is useful for
> debugging purposes many, if not most, developers are interested in specific
> coordinate (groupId:artifactId) which should be passed to next execution, and
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> MavenProject: com.example:foobar:1.0.0-SNAPSHOT @
> ~/sources/foobar/pom.xml,
> MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @
> ~/sources/foobar/parent/pom.xml,
> MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/api/pom.xml,
> MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/model/pom.xml,
> MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/pom.xml,
> MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/model/pom.xml,
> MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/api/pom.xml,
> MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/pom.xml,
> MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/model/pom.xml,
> MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/api/pom.xml,
> MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/core/pom.xml,
> MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/pom.xml,
> MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/api/pom.xml,
> MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/model/pom.xml,
> MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/pom.xml,
> MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/api/pom.xml,
> MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> com.example:foobar,
> com.example.foobar:parent,
> com.example.foobar:api,
> com.example.foobar:model,
> com.example.foobar:csv,
> com.example.foobar.csv:model,
> com.example.foobar.csv:api,
> com.example.foobar:json,
> com.example.foobar.json:model,
> com.example.foobar.json:api,
> com.example.foobar.json:core,
> com.example.foobar:fax,
> com.example.foobar.fax:api,
> com.example.foobar.fax:model,
> com.example.foobar.fax:web,
> com.example.foobar.fax.web:api,
> com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6382) JANSI fails frequently with NumberFormatException when building in parallel
[
https://issues.apache.org/jira/browse/MNG-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680238#comment-16680238
]
Hudson commented on MNG-6382:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> JANSI fails frequently with NumberFormatException when building in parallel
> ---
>
> Key: MNG-6382
> URL: https://issues.apache.org/jira/browse/MNG-6382
> Project: Maven
> Issue Type: Bug
> Components: Logging
>Affects Versions: 3.5.3
> Environment: Apache Maven 3.5.3
> (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T20:49:05+01:00)
> Maven home: C:\Develop\_tools\apache-maven-3.5.3\bin\..
> Java version: 10, vendor: Oracle Corporation
> Java home: C:\Develop\_tools\jdk-10.0.0
> Default locale: de_DE, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Falko Modler
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.4
>
>
> After upgrading from 3.3.9 to 3.5.4 my parallel Maven build fail frequently
> with:
> {noformat}
> java.lang.NumberFormatException: For input string: "34m"
> at
> java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
> at java.base/java.lang.Integer.parseInt(Integer.java:652)
> at java.base/java.lang.Integer.(Integer.java:1096)
> at
> org.fusesource.jansi.AnsiPrintStream.filter(AnsiPrintStream.java:129)
> at
> org.fusesource.jansi.FilterPrintStream.write(FilterPrintStream.java:97)
> at
> org.fusesource.jansi.FilterPrintStream.write(FilterPrintStream.java:107)
> at
> org.fusesource.jansi.FilterPrintStream.print(FilterPrintStream.java:161)
> at
> org.slf4j.impl.MavenSimpleLogger.writeThrowable(MavenSimpleLogger.java:81)
> at org.slf4j.impl.SimpleLogger.write(SimpleLogger.java:319)
> at org.slf4j.impl.SimpleLogger.log(SimpleLogger.java:295)
> at org.slf4j.impl.SimpleLogger.error(SimpleLogger.java:593)
> at
> org.apache.maven.cli.CLIReportingUtils.showError(CLIReportingUtils.java:138)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:309)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:194)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:564)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> {noformat}
> This seems to have been [fixed in JANSI master
> branch|https://github.com/fusesource/jansi/commit/e45e4665538ba9234f5ee5d7b06d78d6a03deda3]
> but it has not yet been released. There is already a request for a bugfix
> release, see [issue 114 ("Need 1.17.1
> release")|https://github.com/fusesource/jansi/issues/114].
> Maven 3.5.4 should therefore upgrade to JANSI 1.17.1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6473) Update Mockito to 2.21.0
[ https://issues.apache.org/jira/browse/MNG-6473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680250#comment-16680250 ] Hudson commented on MNG-6473: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Update Mockito to 2.21.0 > > > Key: MNG-6473 > URL: https://issues.apache.org/jira/browse/MNG-6473 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-5756) Java home output in mvn -v is misleading
[
https://issues.apache.org/jira/browse/MNG-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680236#comment-16680236
]
Hudson commented on MNG-5756:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Java home output in mvn -v is misleading
>
>
> Key: MNG-5756
> URL: https://issues.apache.org/jira/browse/MNG-5756
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.2.5, 3.3.3
> Environment: any
>Reporter: Jarkko Rantavuori
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> For example on my windows box, mvn -v prints the following:
> {code}
> Java home: C:\Program Files (x86)\Java\jdk1.7.0_51\jre
> {code}
> But my JAVA_HOME is actually
> {code}
> > echo %JAVA_HOME%
> C:\Program Files (x86)\Java\jdk1.7.0_51
> {code}
> In the source code, the line comes from:
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java#l63
> {code}
> version.append( "Java home: " ).append( System.getProperty( "java.home",
> "" ) ).append( ls );
> {code}
> which is using property "java.home" to fetch java home. However, "java.home"
> property is not JAVA_HOME! This is explained in detail in here:
> http://javahowto.blogspot.fi/2006/05/javahome-vs-javahome.html
> To quote:
> {quote}
> What's the difference between JAVA_HOME and java.home?
> JAVA_HOME is the JDK install directory, e.g., C:\jdk5. It's meant to be
> set as an environment variable and referenced in Windows batch files or Unix
> scripts. I always have it in my Windows Control Panel and .tcsh files,along
> with other common environment variables. Some Java applications use the name
> jdk.home for this purpose, which I think is a better name. But JAVA_HOME has
> been used since the beginning and is now a convention.
> java.home is the JRE install directory, e.g., C:\jdk5\jre, or C:\Program
> Files\Java\jre1.5.0_06. Unlike JAVA_HOME, I never seen java.home as an
> environment variable. java.home is a build-in Java system property, whose
> value is the JRE install directory. Since all Java system properties are also
> exposed as Ant build properties, you can also use ${java.home} in
> build files.
> Would jre.home be a better name? Maybe, but I don't think Sun will change
> it.
> {quote}
> This is a source of constant confusion. Some stackoverflow threads to
> illustrate:
> http://stackoverflow.com/questions/15279586/java-home-in-maven
> http://stackoverflow.com/questions/17620531/maven-pointing-to-jre-instead-of-jdk
> The correct way to print JAVA_HOME would be to use
> System.getenv("JAVA_HOME"). Either that should be used or current output
> should be changed so it wouldn't be so misleading.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6372) On Windows Maven can output spurious ANSI escapes such as [0m [0m
[ https://issues.apache.org/jira/browse/MNG-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680239#comment-16680239 ] Hudson commented on MNG-6372: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > On Windows Maven can output spurious ANSI escapes such as [0m [0m > - > > Key: MNG-6372 > URL: https://issues.apache.org/jira/browse/MNG-6372 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.3 >Reporter: Stephen Connolly >Assignee: Hervé Boutemy >Priority: Major > Fix For: 3.5.4 > > > Found during the release vote of Maven 3.5.3 on Windows spurious ANSI partial > escape codes such as [0m > A regression introduced by the upgrade of JAnsi to 1.17. Tracked in Jansi as > issue #107 https://github.com/fusesource/jansi/issues/107, will be fixed in > 1.17.1 > notice: another issue from Jansi 1.17 exists, which is failure when run in > parallel build with NumberFormatException = see MNG-6382 for details -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6364) Enhanced Jenkinsfile to test Core with JDK 9
[ https://issues.apache.org/jira/browse/MNG-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680243#comment-16680243 ] Hudson commented on MNG-6364: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Enhanced Jenkinsfile to test Core with JDK 9 > > > Key: MNG-6364 > URL: https://issues.apache.org/jira/browse/MNG-6364 > Project: Maven > Issue Type: Improvement > Components: Bootstrap & Build >Affects Versions: 3.5.3 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.5.4 > > > currently, Maven core is build with one configuration OS+JDK+Maven > then it is tested (ie [Maven Core ITs|https://maven.apache.org/core-its/] > are built and executed) in misc configurations: > - Java 7 and Java 8 > - Linux and Windows > Now that Java 9 and even Java 10 are out, it would be useful to add Java 9 > and even Java 10 to the tests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6479) Upgrade XMLUnit to 2.2.1
[ https://issues.apache.org/jira/browse/MNG-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680257#comment-16680257 ] Hudson commented on MNG-6479: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade XMLUnit to 2.2.1 > > > Key: MNG-6479 > URL: https://issues.apache.org/jira/browse/MNG-6479 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.0 > > > Upgrade XMLUnit test dependency from 1.x line to 2.2.1 and correct test cases > _XMLUnit 2.x will never try to compare unmatched nodes with arbitrary other > nodes_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6311) Maven intolerably slow when import scope used heavily in large project
[ https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680252#comment-16680252 ] Hudson commented on MNG-6311: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Maven intolerably slow when import scope used heavily in large project > -- > > Key: MNG-6311 > URL: https://issues.apache.org/jira/browse/MNG-6311 > Project: Maven > Issue Type: Bug > Components: core, Performance >Affects Versions: 3.5.0, 3.5.2 >Reporter: David Churcher >Assignee: Sylwester Lachiewicz >Priority: Major > Labels: performance > Fix For: 3.6.0 > > Attachments: Call-tree-–-All-threads-together.html, > anon-hierarchy-maven-output.zip, modelcachefix.diff > > > I have a build performance problem that is identical to MNG-5312, and has > appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, > removing the ModelCache from some of the overloads for > DefaultProjectBuilder.build. > As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 > levels of parent POMs, many of which use the import scope and have large > dependency-management sections, and has hundreds of dependencies that also > use the same parent POM hierarchy. Adding some logging shows that Maven does > over 800,000 uncached reads of parent POM files, which takes about half an > hour. With model caching this goes down to a few seconds. > I've attached a patch that fixes this by using a class-level ModelCache in > DefaultProjectBuilder. This does not suffer from the memory usage problems > reported in MNG-6030. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-5951) add an option to avoid path addition to inherited URLs
[
https://issues.apache.org/jira/browse/MNG-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680255#comment-16680255
]
Hudson commented on MNG-5951:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> add an option to avoid path addition to inherited URLs
> --
>
> Key: MNG-5951
> URL: https://issues.apache.org/jira/browse/MNG-5951
> Project: Maven
> Issue Type: Improvement
> Components: Inheritance and Interpolation
>Affects Versions: 3.0.5, 3.1.1, 3.2.5, 3.3.9
>Reporter: Jörg Sesterhenn
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: MNG-5951.zip
>
>
> What I am trying to achieve is
> the definition of a project.url in a parent pom
> in a way that all children inherit a url ending with
> {code:java}
> ${project.groupId}/${project.artifactId}/${project.version}/
> {code}
> in order to be able to publish sites of all artifacts in all versions in
> parallel
> without having to redefine the url in every child pom.
> This is currently not working as expected in maven due to the default child
> urls calculation which leads to urls that add up parent urls like
>
> [http://my.domain.de/sites/de.enterprise.calculatorsGroupId/calculator-artifactID/1.0.0-SNAPSHOT/internetAppParentPOM/calculatorParentPom/calculator-artifactID/]
> The part *"internetAppParentPOM/calculatorParentPom/"* is added by automatic
> child url calculation (those are the artifactIds of all parent poms beneath
> our enterprise parent pom where the url is defined) and *is expexted to not
> be there at all*. The repeated artifactID at the end of the url is
> superfluous as well but tollerable.
> I expect maven-core to be changed so that I can turn on/off the automatic
> calculation of child URLs as an option which is by default on (current
> behaviour so nothing will change unless configured explicitly).
> See the discussion in MSITE-672.
> As this can not be done in the maven-site-plugin there needs to be a change
> in Maven itself (core), in Maven Model Builder, ie the way effective model is
> calculated, and more precisely in the inheritance step:
> [http://maven.apache.org/ref/current/maven-model-builder/].
> h1. Implemented solution:
> {code:xml}
> ...
>
> ...
> ...
> ...
>
>
>
> ...
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6486) Upgrade to Wagon 3.2.0
[ https://issues.apache.org/jira/browse/MNG-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680260#comment-16680260 ] Hudson commented on MNG-6486: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Upgrade to Wagon 3.2.0 > -- > > Key: MNG-6486 > URL: https://issues.apache.org/jira/browse/MNG-6486 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Affects Versions: 3.5.4 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6415) Project Artifacts Cache does not retain the order of classpath entries.
[ https://issues.apache.org/jira/browse/MNG-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680259#comment-16680259 ] Hudson commented on MNG-6415: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Project Artifacts Cache does not retain the order of classpath entries. > --- > > Key: MNG-6415 > URL: https://issues.apache.org/jira/browse/MNG-6415 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.2 > Environment: Windows 7, JDK8u144 >Reporter: Seckin Onur SELAMET >Assignee: Robert Scholte >Priority: Major > Labels: CLASSPATH > Fix For: 3.6.0 > > Attachments: > [MNG-6415]_Fixes_Project_Artifact_Cache_classpath_order_retaining_issue_.patch > > > Project artifacts cache does not retain the order of classpath entries. > Wrong Object type used in implementation. HashSet can not guarantee the order > of elements. > In runtime ProjectArtifacts passed as LinkedHashSet already which is safe. > > Possible fix is provided in comments section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6358) Maven build should not require access to apache.org
[
https://issues.apache.org/jira/browse/MNG-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680256#comment-16680256
]
Hudson commented on MNG-6358:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Maven build should not require access to apache.org
> ---
>
> Key: MNG-6358
> URL: https://issues.apache.org/jira/browse/MNG-6358
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 3.2.1, 3.5.2
> Environment: RHEL 7.4
> JDK 1.8.0_141
>Reporter: Adam John Burley
>Assignee: Hervé Boutemy
>Priority: Minor
> Fix For: 3.6.0
>
>
> I am trying to build Maven 3.5.2 from source using Maven 3.0.5. The machine I
> am building on has access to an internal Maven repository, but doesn't have
> access to the Internet.
> The build fails, seemingly because it cannot access {{apache.org}} to
> download the license. But I don't understand why it needs to do this, as the
> license is already contained in file {{apache-jar-resource-bundle}} which is
> retrieved as a Maven dependency.
> Here is the log I get:
> {code}
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ apache-maven ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/test/resources*/**
> [INFO] Exclude: src/test/projects/**
> [INFO] Exclude: src/test/remote-repo/**
> [INFO] Exclude: **/*.odg
> [INFO] Exclude: src/bin/m2.conf
> [INFO] Exclude: bootstrap/**
> [INFO] Exclude: README.bootstrap.txt
> [INFO] Exclude: .repository/**
> [INFO] Exclude: .maven/spy.log
> [INFO] Exclude: .java-version
> [INFO] Exclude: README.md
> [INFO] Exclude: DEPENDENCIES
> [INFO] 19 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0
> approved: 16 licence.
> [INFO]
> [INFO] --- maven-dependency-plugin:2.8:unpack-dependencies
> (unpack-jansi-native) @ apache-maven ---
> [INFO] Unpacking
> /root/.m2/repository/org/fusesource/jansi/jansi/1.16/jansi-1.16.jar to
> /tmp/maven-build/apache-maven/target/dependency with includes
> "META-INF/native/**" and excludes ""
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ apache-maven
> ---
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Maven .. SUCCESS [25.091s]
> [INFO] Maven Model ... SUCCESS [18.000s]
> [INFO] Maven Artifact SUCCESS [4.418s]
> [INFO] Maven Plugin API .. SUCCESS [4.677s]
> [INFO] Maven Builder Support . SUCCESS [1.900s]
> [INFO] Maven Model Builder ... SUCCESS [5.690s]
> [INFO] Maven Settings SUCCESS [1.905s]
> [INFO] Maven Settings Builder SUCCESS [2.010s]
> [INFO] Maven Repository Metadata Model ... SUCCESS [1.511s]
> [INFO] Maven Artifact Resolver Provider .. SUCCESS [5.110s]
> [INFO] Maven Core SUCCESS [13.168s]
> [INFO] Maven SLF4J Simple Provider ... SUCCESS [5.013s]
> [INFO] Maven Embedder SUCCESS [3.617s]
> [INFO] Maven Compat .. SUCCESS [4.462s]
> [INFO] Apache Maven Distribution . FAILURE [4:18.467s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 5:58.134s
> [INFO] Finished at: Mon Feb 12 21:03:11 GMT 2018
> [INFO] Final Memory: 83M/190M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default)
> on project apache-maven: Error rendering velocity resource. Invocation of
> method 'getResourceAsFile' in class
> org.codehaus.plexus.resource.DefaultResourceManager threw exception
> org.codehaus.plexus.resource.loader.ResourceNotFoundException: Could not find
> resource 'https://www.apache.org/licenses/LICENSE-2.0.txt'. at
> remote-resources[line 38, column 26] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, pleas
[jira] [Commented] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license
[
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680254#comment-16680254
]
Hudson commented on MNG-6414:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16
See
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/
> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin uses
> {{appended-resources/META-INF/LICENSE.vm}} to add content to {{LICENSE}} and
> try to download licenses for all dependencies that are not Apache licensed
> (see end of {{LICENSE}} and resulting {{lib/*.license}} in Maven binary
> distribution, since Maven 3.2.1 MNG-5494).
> License file is not downloaded only when project/license/name is strictly
> equal to "The Apache Software License, Version 2.0": this is too restrictive,
> as we see Apache license downloaded many times from https://www.apache.org/
> (causing some issues with https: MNG-6358).
> After debugging these cases, additional patterns for Apache license exist and
> need to be added to exception list in
> {{appended-resources/META-INF/LICENSE.vm}}:
> - "Apache License, Version 2.0"
> - "The Apache Software License, Version 2.0"
> - "ASLv2"
> - "Apache Public License 2.0"
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6362) Add documentation information for GitHub
[ https://issues.apache.org/jira/browse/MNG-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680233#comment-16680233 ] Hudson commented on MNG-6362: - Build failed in Jenkins: Maven TLP » maven » MNG-6012-Missing-Profile-At-End #16 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6012-Missing-Profile-At-End/16/ > Add documentation information for GitHub > > > Key: MNG-6362 > URL: https://issues.apache.org/jira/browse/MNG-6362 > Project: Maven > Issue Type: Improvement >Affects Versions: 3.5.3 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.5.4 > > > Create an information page for GitHub users about contribution etc. > Things like: README.md, CONTRIBUTION.md, pull_request_template.md -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-267) Upgrade to make Maven 3+
[ https://issues.apache.org/jira/browse/MENFORCER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680229#comment-16680229 ] Jesse Glick commented on MENFORCER-267: --- Doing this might fix MENFORCER-298 by the way. (I no longer personally care to pursue it since the Jenkins project has largely [moved away from using timestamped snapshots|https://github.com/jenkinsci/jep/blob/master/jep/305/README.adoc#timestamped-snapshot-issues].) > Upgrade to make Maven 3+ > > > Key: MENFORCER-267 > URL: https://issues.apache.org/jira/browse/MENFORCER-267 > Project: Maven Enforcer Plugin > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Blocker > Fix For: 3.0.0 > > > * maven-dependency-tree needs to be updated to 3.0.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-267) Upgrade to make Maven 3+
[ https://issues.apache.org/jira/browse/MENFORCER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680224#comment-16680224 ] Karl Heinz Marbaise commented on MENFORCER-267: --- Hi, Ok...at moment I'm working on other issues..so this would help ...to improve maven-enforcer...so go for it... > Upgrade to make Maven 3+ > > > Key: MENFORCER-267 > URL: https://issues.apache.org/jira/browse/MENFORCER-267 > Project: Maven Enforcer Plugin > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Blocker > Fix For: 3.0.0 > > > * maven-dependency-tree needs to be updated to 3.0.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-267) Upgrade to make Maven 3+
[ https://issues.apache.org/jira/browse/MENFORCER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680214#comment-16680214 ] Mikolaj Izdebski commented on MENFORCER-267: Thanks for review. I realize that the patch needs improving before it can be submitted as a pull request, but I didn't want to duplicate the work, hence my question - are you still working on the port to Maven 3? If not I will try to rebase and improve the old patch and submit it as a pull request. (Originally I didn't submit it as back in 2015 Enforcer was still targeting Maven 2, so the patch wouldn't be accepted anyway.) > Upgrade to make Maven 3+ > > > Key: MENFORCER-267 > URL: https://issues.apache.org/jira/browse/MENFORCER-267 > Project: Maven Enforcer Plugin > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Blocker > Fix For: 3.0.0 > > > * maven-dependency-tree needs to be updated to 3.0.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MSHARED-759) Upgrade parent to version 33
[ https://issues.apache.org/jira/browse/MSHARED-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MSHARED-759: Summary: Upgrade parent to version 33 (was: Upgrade parent to version 32) > Upgrade parent to version 33 > > > Key: MSHARED-759 > URL: https://issues.apache.org/jira/browse/MSHARED-759 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-artifact-transfer-0.11.0 > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-267) Upgrade to make Maven 3+
[ https://issues.apache.org/jira/browse/MENFORCER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680144#comment-16680144 ] Karl Heinz Marbaise commented on MENFORCER-267: --- The best approach would be to make a PR via Github..but I have taken a look into patch...there are things which can't be done that way. First a dependency to maven-compat has to be removed cause compat is only for compatibility to Maven 2 so enforcer should work completely without it (sometimes it's needed in test which means scope test)...furthermore the base line for compatibility is maven 3.0 and not 3.3.3 etc...which means also to have max. version 2.1 of maven-plugin-testing-harness. > Upgrade to make Maven 3+ > > > Key: MENFORCER-267 > URL: https://issues.apache.org/jira/browse/MENFORCER-267 > Project: Maven Enforcer Plugin > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Blocker > Fix For: 3.0.0 > > > * maven-dependency-tree needs to be updated to 3.0.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPATCH-20) support exclude pattern
[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679423#comment-16679423
]
ASF GitHub Bot commented on MPATCH-20:
--
matthiasbalke commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r231797372
##
File path: src/it/exclude-patches-from-patchDirectory/pom.xml
##
@@ -0,0 +1,65 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ 4.0.0
+
+ test
+ exclude-patches-from-patchDirectory
+ exclude-patches-from-patchDirectory
+ 1.0-SNAPSHOT
+
+
+UTF-8
+
+
+
+
+
+org.apache.maven.plugins
+maven-patch-plugin
+@pom.version@
Review comment:
Whats the difference here? Is it a more modern syntax? I used the same as
the integration tests used before (see remove-emtpy-files/pom.xml).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> ---
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
>Affects Versions: 1.2, 1.3
>Reporter: Matthias Balke
>Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679243#comment-16679243 ] Sylwester Lachiewicz commented on MNG-6481: --- Only one left mng4877DeployUsingPrivateKey(it)FAILURE (0.7 s) > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.x-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680060#comment-16680060
]
ASF GitHub Bot commented on SUREFIRE-1593:
--
Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r231991410
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
-return new URI( null,
-parent.relativize( classPathElement.toPath()
).toString().
-replace( File.separatorChar, '/' ),
-null ).toASCIIString();
+Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
@jglick
There is one IT test `Surefire855AllowFailsafeUseArtifactFileIT` which
asserts Class-Path in manifest and surefire.properties, but it's hard to
develope such test runing on any platform and any number of dists. Even in our
case, using ASF Jenkins CI, we have workspace on `F:\` but the TEMP is on `C:\`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 3.0.0-M1 produces invalid code sources on Windows
> -
>
> Key: SUREFIRE-1593
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, process forking
>Affects Versions: 3.0.0-M1
>Reporter: Jesse Glick
>Priority: Major
>
> The fix for SUREFIRE-1588 did not work correctly on Windows. (When
> active—i.e., when the drive letters of the system temporary directory, per
> SUREFIRE-1400, and the project basedir were the same.) It would produce
> relative URIs containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1588) Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8
[
https://issues.apache.org/jira/browse/SUREFIRE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679844#comment-16679844
]
ASF GitHub Bot commented on SUREFIRE-1588:
--
jglick commented on issue #198: [SUREFIRE-1588] Correcting relativization logic
to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437015281
> write a unit test for edge cases
This would only be meaningful when run on Windows, so I am not sure how
valuable that is. I would put more trust into integration tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8
> ---
>
> Key: SUREFIRE-1588
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1588
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.22.1
>Reporter: Cservenak, Tamas
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M1
>
>
> See issue [1], but in short: latest Java8 on Ubuntu/Debian/Mint family of
> Linuxes (am on Mint, Ubuntu derivative) contains this patch [3], and eforces
> Manifest class path entries to be relative, as defined in [2].
> Hence, surefire booter and rest of Maven classpath, that uses absolute URLs
> are simply discarded.
> Example error:
> {noformat}
> # Created at 2018-10-30T21:34:43.339
> Error: Could not find or load main class
> org.apache.maven.surefire.booter.ForkedBooter{noformat}
> using the new property
> {{-Djdk.net.URLClassPath.disableClassPathURLCheck=debug}} clearly shows that
> all the entries from the surefire JAR are simply ignored.
>
> [1] [https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911925]
> [2]
> https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#classpath
> [3] [https://hg.openjdk.java.net/jdk/jdk/rev/27135de165ac]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows
[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680062#comment-16680062
]
ASF GitHub Bot commented on SUREFIRE-1593:
--
Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r231991410
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
-return new URI( null,
-parent.relativize( classPathElement.toPath()
).toString().
-replace( File.separatorChar, '/' ),
-null ).toASCIIString();
+Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
@jglick
There is one IT test `Surefire855AllowFailsafeUseArtifactFileIT` which
asserts Class-Path in manifest and surefire.properties, but it's hard to
develop such test running on any platform and with any number of disks. Even in
our case, using ASF Jenkins CI, we have workspace on `F:\` but the TEMP is on
`C:\`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 3.0.0-M1 produces invalid code sources on Windows
> -
>
> Key: SUREFIRE-1593
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, process forking
>Affects Versions: 3.0.0-M1
>Reporter: Jesse Glick
>Priority: Major
>
> The fix for SUREFIRE-1588 did not work correctly on Windows. (When
> active—i.e., when the drive letters of the system temporary directory, per
> SUREFIRE-1400, and the project basedir were the same.) It would produce
> relative URIs containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCOMPILER-205) maven-compiler-plugin: incremental compilation broken
[
https://issues.apache.org/jira/browse/MCOMPILER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680027#comment-16680027
]
Jens Bannmann commented on MCOMPILER-205:
-
Okay, so how about the following summary to clear up any ambiguity?
{quote}If any source file has been changed or removed, all files are deleted
and recompiled. The reason for this is that simply recompiling everything with
the default java compiler is quite fast, likely much faster than the
alternative, which would look similar to this:
# detect all changed files
# analyze all source files to map all relations between classes
# calculate all affected files
# recompile affected files{quote}
Please explicitly confirm this, [~rfscholte], or rewrite it as you like. Then
I'll put it into my SO answer, and then we will have fixed at least some
confusion :)
> maven-compiler-plugin: incremental compilation broken
> -
>
> Key: MCOMPILER-205
> URL: https://issues.apache.org/jira/browse/MCOMPILER-205
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Lukas Fryc
>Priority: Major
> Attachments: hello.tgz, ignore-package-info.patch,
> no-class-in-java-file.zip, only-recompile-changed.patch
>
>
> When we do {{clean}} -> {{compile}} -> {{compile}}, all Java sources are
> re-compiled for second compilation steps:
> {code}
> [framework]$ mvn clean
> ...
> [framework]$ mvn compile
> ...
> [INFO] --- maven-compiler-plugin:3.1:compile (precompile-sources-for-cdk) @
> richfaces-framework ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 915 source files to
> /mnt/workspace/workspaces/richfaces/richfaces5/framework/target/classes
> ...
> [framework]$ mvn compile
> ...
> [INFO] --- maven-compiler-plugin:3.1:compile (precompile-sources-for-cdk) @
> richfaces-framework ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 915 source files to
> /mnt/workspace/workspaces/richfaces/richfaces5/framework/target/classes
> ...
> {code}
> The source code of the affected project:
> https://github.com/richfaces/richfaces5/tree/077dcfc0a46d03d7ba9a7ac3e701a4adfb834c71
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r231991410
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
-return new URI( null,
-parent.relativize( classPathElement.toPath()
).toString().
-replace( File.separatorChar, '/' ),
-null ).toASCIIString();
+Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
@jglick
There is one IT test `Surefire855AllowFailsafeUseArtifactFileIT` which
asserts Class-Path in manifest and surefire.properties, but it's hard to
develop such test running on any platform and with any number of disks. Even in
our case, using ASF Jenkins CI, we have workspace on `F:\` but the TEMP is on
`C:\`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r231991410
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
-return new URI( null,
-parent.relativize( classPathElement.toPath()
).toString().
-replace( File.separatorChar, '/' ),
-null ).toASCIIString();
+Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
@jglick
There is one IT test `Surefire855AllowFailsafeUseArtifactFileIT` which
asserts Class-Path in manifest and surefire.properties, but it's hard to
develope such test runing on any platform and any number of dists. Even in our
case, using ASF Jenkins CI, we have workspace on `F:\` but the TEMP is on `C:\`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r231979549
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
-return new URI( null,
-parent.relativize( classPathElement.toPath()
).toString().
-replace( File.separatorChar, '/' ),
-null ).toASCIIString();
+Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
This won't tested by ITs because we cannot occupy any disk on Jenkins, but
this algorithm could be tested by unit test and Mockito. At least Line 153 in
mock and next two lines are real and tested. If the Line went to private static
method, we could mock it via PowerMock, and then the next two lines together in
another method calling the first static method. We would assert the returned
value has Unix slashes and white spaces are escaped, paths are relative, etc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] effrafax opened a new pull request #29: Removing shading for maven model packages
effrafax opened a new pull request #29: Removing shading for maven model packages URL: https://github.com/apache/maven-indexer/pull/29 Found an issue with referenced objects in maven model packages in the shaded library (references to classes in a shaded package that does not exist). I think this update should fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jglick commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
jglick commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437017168 > Create a new Jira ticket. done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jglick commented on issue #198: [SUREFIRE-1588] Correcting relativization logic to produce valid URIs on Windows
jglick commented on issue #198: [SUREFIRE-1588] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437015281 > write a unit test for edge cases This would only be meaningful when run on Windows, so I am not sure how valuable that is. I would put more trust into integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)
matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20) URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r231797372 ## File path: src/it/exclude-patches-from-patchDirectory/pom.xml ## @@ -0,0 +1,65 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + 4.0.0 + + test + exclude-patches-from-patchDirectory + exclude-patches-from-patchDirectory + 1.0-SNAPSHOT + + +UTF-8 + + + + + +org.apache.maven.plugins +maven-patch-plugin +@pom.version@ Review comment: Whats the difference here? Is it a more modern syntax? I used the same as the integration tests used before (see remove-emtpy-files/pom.xml). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)
matthiasbalke commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r231796857
##
File path: src/main/java/org/apache/maven/plugin/patch/ApplyMojo.java
##
@@ -237,6 +238,16 @@
@Parameter( defaultValue = "false" )
private boolean binary;
+/**
+ * List of ANT-style exclude patterns. These patterns are used to exclude
patch files found
+ * in the {@link ApplyMojo#patchDirectory}. These exclude patterns does
not apply to a static defined list of
+ * {@link ApplyMojo#patches}.
+ *
+ * @since 1.3
+ */
+@Parameter
+private List excludes;
Review comment:
Currently no generics are getting used within the code of the plugin. Thats
why I kept this style. Do you want to change it anyways?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
