[jira] [Comment Edited] (SUREFIRE-1541) SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[
https://issues.apache.org/jira/browse/SUREFIRE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686059#comment-16686059
]
Radoslav Ivanov edited comment on SUREFIRE-1541 at 11/16/18 12:40 AM:
--
Should we change the default memory settings - note the
attached.[^hs_err_pid3584.log]
(EDIT) Increasing paging file size seems to resolve my problem
was (Author: rivanov):
Should we change the default memory settings - note the
attached.[^hs_err_pid3584.log]
> SurefireBooterForkException: The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> --
>
> Key: SUREFIRE-1541
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1541
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Anghel Botos
>Assignee: Tibor Digana
>Priority: Major
> Attachments: hs_err_pid3584.log
>
>
> Attempting to run integration tests using maven-failsafe-plugin with
> {{-Dmaven.failsafe.debug=false}} yields the following stacktrace:
>
> {noformat}
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was cmd.exe /X /C ""C:\Program
> Files\Java\jdk1.8.0_121\jre\bin\java" false -jar
> C:\Users\ANGHEL~1.BOT\AppData\Local\Temp\surefire8539836821793811485\surefirebooter6734575521909210279.jar
> C:\Users\anghel.botos\AppData\Local\Temp\surefire8539836821793811485
> 2018-07-24T11-18-12_704-jvmRun1 surefire7184511894589995478tmp
> surefire_411836142070426630764tmp"
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:293)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> {noformat}
>
> The issue is the "free-floating" {{false}} that appears in the command line
> used to start a new JVM. I've traced down the issue to
> {{org.apache.maven.plugin.surefire.AbstractSurefireMojo#getEffectiveDebugForkedProcess}}
> where the following code can be found:
> {code:java}
> String debugForkedProcess = getDebugForkedProcess();
> if ( "true".equals( debugForkedProcess ) )
> {
> return "-Xdebug -Xnoagent -Djava.compiler=NONE"
> + "
> -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005";
> }
> return debugForkedProcess;
> {code}
> ...which is quite..."unexpected" to see that one can pass in a value of
> {{true}}, but not a value of {{false}}.
> Please fix with a proper parsing of true/false values for the
> {{maven.failsafe.debug}} property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MRESOLVER-63) FileTransformer#transformData(File) should also throw TransformException
[ https://issues.apache.org/jira/browse/MRESOLVER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688734#comment-16688734 ] ASF GitHub Bot commented on MRESOLVER-63: - mcimbora commented on issue #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException URL: https://github.com/apache/maven-resolver/pull/23#issuecomment-439214140 @rfscholte PR updated, added contributor section to pom.xml. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > FileTransformer#transformData(File) should also throw TransformException > > > Key: MRESOLVER-63 > URL: https://issues.apache.org/jira/browse/MRESOLVER-63 > Project: Maven Resolver > Issue Type: Improvement > Components: resolver >Affects Versions: 1.3.1 >Reporter: Robert Scholte >Priority: Major > Labels: up-for-grabs > Fix For: 1.3.2 > > > 1.3.1 introduced the FileTransformer to allow on-the-fly transforming of data. > For XML files it makes sense to use XMLFilters and create an XMLReader. This > can throw a SAXException, which is a checked exception, which shouldn't be > rethrown as an IOException. > Better to introduce a new Exception to handle this case properly. > Assuming this class isn't used anywhere yet, it should be good to introduce > it asap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] mcimbora commented on issue #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException
mcimbora commented on issue #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException URL: https://github.com/apache/maven-resolver/pull/23#issuecomment-439214140 @rfscholte PR updated, added contributor section to pom.xml. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNGSITE-357) README.md: Maven user list link not working
[ https://issues.apache.org/jira/browse/MNGSITE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688614#comment-16688614 ] Hudson commented on MNGSITE-357: Build succeeded in Jenkins: Maven TLP » maven » master #113 See https://builds.apache.org/job/maven-box/job/maven/job/master/113/ > README.md: Maven user list link not working > --- > > Key: MNGSITE-357 > URL: https://issues.apache.org/jira/browse/MNGSITE-357 > Project: Maven Project Web Site > Issue Type: Bug > Environment: github, homepage >Reporter: Matthias Fuchs >Assignee: Michael Osipov >Priority: Trivial > Labels: docs, github, homepage, mailing-list, readme > > The link from the github README doesn't work: > [https://maven.apache.org/mail-lists.html.] > You guys shoudl definitely enable github issues! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Tibor17 commented on issue #199: Surefire 1593
Tibor17 commented on issue #199: Surefire 1593 URL: https://github.com/apache/maven-surefire/pull/199#issuecomment-439178024 @jglick Can we finalize this? Should I proceed or you want to take it to your PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MNGSITE-357) README.md: Maven user list link not working
[ https://issues.apache.org/jira/browse/MNGSITE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNGSITE-357: --- Summary: README.md: Maven user list link not working (was: Homepage - maven user list link not working) > README.md: Maven user list link not working > --- > > Key: MNGSITE-357 > URL: https://issues.apache.org/jira/browse/MNGSITE-357 > Project: Maven Project Web Site > Issue Type: Bug > Environment: github, homepage >Reporter: Matthias Fuchs >Assignee: Michael Osipov >Priority: Trivial > Labels: docs, github, homepage, mailing-list, readme > > The link from the github README doesn't work: > [https://maven.apache.org/mail-lists.html.] > You guys shoudl definitely enable github issues! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MNGSITE-357) README.md: Maven user list link not working
[ https://issues.apache.org/jira/browse/MNGSITE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNGSITE-357. -- Resolution: Fixed Fixed with [86d4a91d20bca2c8c4c3e5b87eb1f9e704902a4e|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=86d4a91d20bca2c8c4c3e5b87eb1f9e704902a4e]. > README.md: Maven user list link not working > --- > > Key: MNGSITE-357 > URL: https://issues.apache.org/jira/browse/MNGSITE-357 > Project: Maven Project Web Site > Issue Type: Bug > Environment: github, homepage >Reporter: Matthias Fuchs >Assignee: Michael Osipov >Priority: Trivial > Labels: docs, github, homepage, mailing-list, readme > > The link from the github README doesn't work: > [https://maven.apache.org/mail-lists.html.] > You guys shoudl definitely enable github issues! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MNG-6517) Homepage - maven user list link not working
[ https://issues.apache.org/jira/browse/MNG-6517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-6517: --- Assignee: Michael Osipov > Homepage - maven user list link not working > --- > > Key: MNG-6517 > URL: https://issues.apache.org/jira/browse/MNG-6517 > Project: Maven > Issue Type: Bug > Environment: github, homepage >Reporter: Matthias Fuchs >Assignee: Michael Osipov >Priority: Trivial > Labels: docs, github, homepage, mailing-list, readme > > The link from the github README doesn't work: > [https://maven.apache.org/mail-lists.html.] > You guys shoudl definitely enable github issues! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Moved] (MNGSITE-357) Homepage - maven user list link not working
[ https://issues.apache.org/jira/browse/MNGSITE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MNG-6517 to MNGSITE-357: - Key: MNGSITE-357 (was: MNG-6517) Project: Maven Project Web Site (was: Maven) > Homepage - maven user list link not working > --- > > Key: MNGSITE-357 > URL: https://issues.apache.org/jira/browse/MNGSITE-357 > Project: Maven Project Web Site > Issue Type: Bug > Environment: github, homepage >Reporter: Matthias Fuchs >Assignee: Michael Osipov >Priority: Trivial > Labels: docs, github, homepage, mailing-list, readme > > The link from the github README doesn't work: > [https://maven.apache.org/mail-lists.html.] > You guys shoudl definitely enable github issues! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Tibor17 commented on a change in pull request #199: Surefire 1593
Tibor17 commented on a change in pull request #199: Surefire 1593
URL: https://github.com/apache/maven-surefire/pull/199#discussion_r233983855
##
File path:
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfigurationTest.java
##
@@ -0,0 +1,216 @@
+package org.apache.maven.plugin.surefire.booterclient;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Path;
+
+import
org.apache.maven.plugin.surefire.booterclient.output.InPluginProcessDumpSingleton;
+
+import static
org.apache.maven.plugin.surefire.booterclient.JarManifestForkConfiguration.relativize;
+import static
org.apache.maven.plugin.surefire.booterclient.JarManifestForkConfiguration.toAbsoluteUri;
+import static
org.apache.maven.plugin.surefire.booterclient.JarManifestForkConfiguration.toClasspathElementUri;
+import static org.fest.assertions.Assertions.assertThat;
+
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import static org.mockito.ArgumentMatchers.same;
+import static org.powermock.api.mockito.PowerMockito.mock;
+import static org.powermock.api.mockito.PowerMockito.mockStatic;
+import static org.powermock.api.mockito.PowerMockito.when;
+
+import org.mockito.invocation.InvocationOnMock;
+import org.mockito.stubbing.Answer;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+/**
+ * Unit tests for {@link JarManifestForkConfiguration}.
+ */
+@RunWith( PowerMockRunner.class )
+@PrepareForTest( { JarManifestForkConfiguration.class,
InPluginProcessDumpSingleton.class } )
+public class JarManifestForkConfigurationTest
+{
+@ClassRule
+public static final TemporaryFolder TMP = new TemporaryFolder();
+
+private static File dumpDirectory;
+
+@BeforeClass
+public static void createSystemTemporaryDir()
+throws IOException
+{
+TMP.create();
Review comment:
@jglick
done.
Avoided `@Rule` in PowerMock test. Used assertion f/w `fest-assert` utility
class `org.fest.util.Files`.
I checked the temp folders are properly created and deleted with content in
it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (MNG-6517) Homepage - maven user list link not working
Matthias Fuchs created MNG-6517: --- Summary: Homepage - maven user list link not working Key: MNG-6517 URL: https://issues.apache.org/jira/browse/MNG-6517 Project: Maven Issue Type: Bug Environment: github, homepage Reporter: Matthias Fuchs The link from the github README doesn't work: [https://maven.apache.org/mail-lists.html.] You guys shoudl definitely enable github issues! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MNG-6516) Build maven-mojo using Java9 fails
Matthias Fuchs created MNG-6516: --- Summary: Build maven-mojo using Java9 fails Key: MNG-6516 URL: https://issues.apache.org/jira/browse/MNG-6516 Project: Maven Issue Type: Bug Components: Plugin API Environment: java 9 Reporter: Matthias Fuchs I'm upgrading my Java8 framework to Java9, but I have major problems upgrading my mojos (https://github.com/spot-next/spot-framework/tree/develop/spot-maven-plugin). The problem is that my dependecies maven-artifact a maven-core contain the same classes. This causes the java9 compiler to fail. It also seems that those libraries haven't been upgraded to use module-info.java or at least automatic module name in META-INF. Expected solution: restructure the libraries to conform to the java module system. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MARCHETYPES-56) finish maven-archetype-profiles
[ https://issues.apache.org/jira/browse/MARCHETYPES-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688212#comment-16688212 ] Kimberly commented on MARCHETYPES-56: - So someone back in april already started a prject build on my devices?? > finish maven-archetype-profiles > --- > > Key: MARCHETYPES-56 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-56 > Project: Maven Archetype Bundles > Issue Type: Task >Reporter: Hervé Boutemy >Priority: Major > > this is a WIP that was never finished: there is still no profile in generated > pom.xml... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MARCHETYPES-61) Update quickstart to use JUnit 5
[
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688213#comment-16688213
]
Kimberly commented on MARCHETYPES-61:
-
I dont want my devices changed from factory settings. My son has interfaced and
rooted my phone and hacked my laptop. Im trying too reverse it.
> Update quickstart to use JUnit 5
>
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
> Issue Type: Improvement
> Components: Maven Quickstart Archetype
>Affects Versions: 1.3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> Update quickstart archetype to generate a project using JUnit 5, the next
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
>
>
>
> org.junit
> junit-bom
> 5.3.1
> pom
> import
>
>
>
>
>
> org.junit.jupiter
> junit-jupiter-api
> test
>
>
> org.junit.jupiter
> junit-jupiter-engine
> test
>
>
>
> org.junit.jupiter
> junit-jupiter-params
> test
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSITE-828) Jdk 1.8 required
[ https://issues.apache.org/jira/browse/MSITE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687851#comment-16687851 ] Hudson commented on MSITE-828: -- Build failed in Jenkins: Maven TLP » maven-site-plugin » master #60 See https://builds.apache.org/job/maven-box/job/maven-site-plugin/job/master/60/ > Jdk 1.8 required > > > Key: MSITE-828 > URL: https://issues.apache.org/jira/browse/MSITE-828 > Project: Maven Site Plugin > Issue Type: Task >Reporter: Olivier Lamy (*$^¨%`£) >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > Fix For: 3.8 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSITE-829) Upgrade Jetty to 9.4.12
[ https://issues.apache.org/jira/browse/MSITE-829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687852#comment-16687852 ] Hudson commented on MSITE-829: -- Build failed in Jenkins: Maven TLP » maven-site-plugin » master #60 See https://builds.apache.org/job/maven-box/job/maven-site-plugin/job/master/60/ > Upgrade Jetty to 9.4.12 > --- > > Key: MSITE-829 > URL: https://issues.apache.org/jira/browse/MSITE-829 > Project: Maven Site Plugin > Issue Type: Task >Reporter: Olivier Lamy (*$^¨%`£) >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > Fix For: 3.8 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSITE-829) Upgrade Jetty to 9.4.12
[ https://issues.apache.org/jira/browse/MSITE-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MSITE-829. Resolution: Fixed > Upgrade Jetty to 9.4.12 > --- > > Key: MSITE-829 > URL: https://issues.apache.org/jira/browse/MSITE-829 > Project: Maven Site Plugin > Issue Type: Task >Reporter: Olivier Lamy (*$^¨%`£) >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > Fix For: 3.8 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSITE-828) Jdk 1.8 required
[ https://issues.apache.org/jira/browse/MSITE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MSITE-828. Resolution: Fixed > Jdk 1.8 required > > > Key: MSITE-828 > URL: https://issues.apache.org/jira/browse/MSITE-828 > Project: Maven Site Plugin > Issue Type: Task >Reporter: Olivier Lamy (*$^¨%`£) >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > Fix For: 3.8 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSITE-828) Jdk 1.8 required
[
https://issues.apache.org/jira/browse/MSITE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687823#comment-16687823
]
ASF GitHub Bot commented on MSITE-828:
--
olamy closed pull request #3: [MSITE-828] Upgrade jetty to recent version.
Update to java 1.8 (required for jetty)
URL: https://github.com/apache/maven-site-plugin/pull/3
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pom.xml b/pom.xml
index 52df601..be75a1d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -207,9 +207,25 @@ under the License.
2.7
2.9.1
3.0.1
+1.8
+1.8
+9.4.12.v20180830
+
+
+ commons-logging
+ commons-logging
+ 1.1
+
+
+ javax.servlet
+ servlet-api
+
+
+
+
org.apache.maven.reporting
maven-reporting-api
@@ -348,23 +364,19 @@ under the License.
runtime
-
- javax.servlet
- servlet-api
- 2.5
-
-
org.apache.maven.doxia
doxia-decoration-model
${doxiaSitetoolsVersion}
+
org.apache.maven.doxia
doxia-site-renderer
${doxiaSitetoolsVersion}
+
org.apache.maven.doxia
doxia-integration-tools
@@ -392,20 +404,40 @@ under the License.
- org.mortbay.jetty
- jetty
- 6.1.25
+ org.eclipse.jetty
+ jetty-server
+ ${jettyVersion}
+
+
+
+ org.eclipse.jetty
+ jetty-servlet
+ ${jettyVersion}
+
+
+
+ org.eclipse.jetty
+ jetty-webapp
+ ${jettyVersion}
+
- org.mortbay.jetty
+ org.eclipse.jetty
jetty-util
- 6.1.25
+ ${jettyVersion}
- org.mortbay.jetty
+ org.eclipse.jetty
jetty-client
- 6.1.25
+ ${jettyVersion}
+ test
+
+
+
+ org.eclipse.jetty
+ jetty-proxy
+ ${jettyVersion}
test
@@ -533,10 +565,6 @@ under the License.
${maven.compiler.target}
-
-
org.apache.maven.doxia:doxia-module-markdown
-org.nibor.autolink:autolink
-
true
diff --git
a/src/main/java/org/apache/maven/plugins/site/deploy/AbstractDeployMojo.java
b/src/main/java/org/apache/maven/plugins/site/deploy/AbstractDeployMojo.java
index addbf96..7c0101c 100644
--- a/src/main/java/org/apache/maven/plugins/site/deploy/AbstractDeployMojo.java
+++ b/src/main/java/org/apache/maven/plugins/site/deploy/AbstractDeployMojo.java
@@ -323,7 +323,11 @@ private void deploy( final File directory, final
Repository repository )
{
try
{
-SettingsDecrypter settingsDecrypter = container.lookup(
SettingsDecrypter.class );
+// The cast does not make sense, however I get when
compiled with maven 3.5.4:
+// error: incompatible types: Object cannot be converted
to SettingsDecrypter
+// The cast is not necessary with maven 3.3.9
+SettingsDecrypter settingsDecrypter =
+(SettingsDecrypter) container.lookup(
SettingsDecrypter.class );
proxyInfo = getProxy( repository, settingsDecrypter );
}
diff --git a/src/main/java/org/apache/maven/plugins/site/run/SiteRunMojo.java
b/src/main/java/org/apache/maven/plugins/site/run/SiteRunMojo.java
index 32fc8a6..d000964 100644
--- a/src/main/java/org/apache/maven/plugins/site/run/SiteRunMojo.java
+++ b/src/main/java/org/apache/maven/plugins/site/run/SiteRunMojo.java
@@ -38,12 +38,8 @@
import org.apache.maven.plugins.site.render.AbstractSiteRenderingMojo;
import org.apache.maven.reporting.exec.MavenReportExecution;
import org.codehaus.plexus.util.IOUtil;
-import org.mortbay.jetty.Connector;
-import org.mortbay.jetty.Handler;
-import org.mortbay.jetty.Server;
-import org.mortbay.jetty.handler.DefaultHandler;
-import org.mortbay.jetty.nio.SelectChannelConnector;
-import org.mortbay.jetty.webapp.WebAppContext;
+import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.webapp.WebAppContext;
/**
* Starts the site up, rendering documents as requested for faster editing.
@@ -78,22 +74,13 @@ public void execute()
{
checkInputEncoding();
-Server server = new Server();
+Server server = new Server( port );
server.setStopAtShutdown( true );
-Connector defaultConnector = getDefaultConnector();
-server.setConnectors( new Connector[] { defaultConnector } );
-
[jira] [Commented] (MRESOLVER-63) FileTransformer#transformData(File) should also throw TransformException
[ https://issues.apache.org/jira/browse/MRESOLVER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687808#comment-16687808 ] ASF GitHub Bot commented on MRESOLVER-63: - rfscholte commented on issue #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException URL: https://github.com/apache/maven-resolver/pull/23#issuecomment-438998122 If you want you can add yourself as a contributor in the pomfile as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > FileTransformer#transformData(File) should also throw TransformException > > > Key: MRESOLVER-63 > URL: https://issues.apache.org/jira/browse/MRESOLVER-63 > Project: Maven Resolver > Issue Type: Improvement > Components: resolver >Affects Versions: 1.3.1 >Reporter: Robert Scholte >Priority: Major > Labels: up-for-grabs > Fix For: 1.3.2 > > > 1.3.1 introduced the FileTransformer to allow on-the-fly transforming of data. > For XML files it makes sense to use XMLFilters and create an XMLReader. This > can throw a SAXException, which is a checked exception, which shouldn't be > rethrown as an IOException. > Better to introduce a new Exception to handle this case properly. > Assuming this class isn't used anywhere yet, it should be good to introduce > it asap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] rfscholte commented on issue #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException
rfscholte commented on issue #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException URL: https://github.com/apache/maven-resolver/pull/23#issuecomment-438998122 If you want you can add yourself as a contributor in the pomfile as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MASFRES-22) pom.xml in any Maven project showing org.apache.maven.plugin.jar.JarMojo error.
Kausheek created MASFRES-22: --- Summary: pom.xml in any Maven project showing org.apache.maven.plugin.jar.JarMojo error. Key: MASFRES-22 URL: https://issues.apache.org/jira/browse/MASFRES-22 Project: Apache Maven Resource Bundles Issue Type: Bug Components: apache-jar-resource-bundle Environment: Windows 10 Home 64 bit English. Eclipse Version: 2018-09 (4.9.0) / Oxygen Release (4.7.0) Apache Maven 3.6.0 / 3.0.5 Reporter: Kausheek Attachments: Eclipse Maven error.png I have installed Apache Maven 3.6.0. My Eclipse version is eclipse-jee-2018-09-win32-x86_64.I have set the Maven Installation appropriately. (Refer Attachment) Now for my old Maven Projects as well any new Maven project I am creating, pom.xml shows an error. The error is "org.apache.maven.plugin.jar.JarMojo". I am unable to resolve this after multiple project Clean and running Update project from Maven menu. I have tried many things after consulting different websites. But none worked. I even down graded Maven to 3.0.5 and tried to use it with Eclipse Oxygen Release 4.7.0. But there I observed the same result. I am not getting any solution in this regard. Please help. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WAGON-538) Basic authentication fails if the password contains non-ASCII characters
[
https://issues.apache.org/jira/browse/WAGON-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687621#comment-16687621
]
ASF GitHub Bot commented on WAGON-538:
--
aleksgj closed pull request #52: [MNG-6514] Adding support for encoding basic
auth credentials with UT…
URL: https://github.com/apache/maven-wagon/pull/52
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
index 9f294f7e..2ccc4793 100755
---
a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
+++
b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
@@ -19,12 +19,14 @@
* under the License.
*/
+import org.apache.http.Consts;
import org.apache.http.Header;
import org.apache.http.HttpEntity;
import org.apache.http.HttpException;
import org.apache.http.HttpHost;
import org.apache.http.HttpResponse;
import org.apache.http.HttpStatus;
+import org.apache.http.auth.AuthSchemeProvider;
import org.apache.http.auth.AuthScope;
import org.apache.http.auth.ChallengeState;
import org.apache.http.auth.Credentials;
@@ -33,6 +35,7 @@
import org.apache.http.client.AuthCache;
import org.apache.http.client.CredentialsProvider;
import org.apache.http.client.HttpRequestRetryHandler;
+import org.apache.http.client.config.AuthSchemes;
import org.apache.http.client.config.CookieSpecs;
import org.apache.http.client.config.RequestConfig;
import org.apache.http.client.methods.CloseableHttpResponse;
@@ -52,6 +55,7 @@
import org.apache.http.conn.ssl.SSLInitializationException;
import org.apache.http.entity.AbstractHttpEntity;
import org.apache.http.impl.auth.BasicScheme;
+import org.apache.http.impl.auth.BasicSchemeFactory;
import org.apache.http.impl.client.BasicAuthCache;
import org.apache.http.impl.client.BasicCredentialsProvider;
import org.apache.http.impl.client.CloseableHttpClient;
@@ -439,6 +443,13 @@ private static HttpRequestRetryHandler createRetryHandler()
}
}
+private static Registry createAuthSchemeRegistry()
+{
+return RegistryBuilder.create()
+.register( AuthSchemes.BASIC, new BasicSchemeFactory(
Consts.UTF_8 ) )
+.build();
+}
+
private static Collection>
getNonRetryableExceptions()
{
final List> exceptions = new
ArrayList<>();
@@ -466,6 +477,7 @@ private static CloseableHttpClient createClient()
.disableConnectionState() //
.setConnectionManager( httpClientConnectionManager ) //
.setRetryHandler( createRetryHandler() )
+.setDefaultAuthSchemeRegistry( createAuthSchemeRegistry() )
.build();
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Basic authentication fails if the password contains non-ASCII characters
>
>
> Key: WAGON-538
> URL: https://issues.apache.org/jira/browse/WAGON-538
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-http
>Affects Versions: 3.2.0
>Reporter: Aleksander Gjermundsen
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.3.0
>
>
> If the username and/or password used to authenticate to Nexus contains
> non-ascii characters, the authentication fails with an access denied error.
> After using Wireshark to investigate the headers being sent (in my case "Ø",
> any non-ascii characters are replaced with "?".
> To test, I have used the following configuration:
> {code:java}
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> ...
>
>
> artifactory
> userØ
> userØ
>
>
> ...
>
>
> nexus
> *
> Local Nexus
> http://localhost:8081/repository/maven-public
>
>
> ...
> {code}
> The settings.xml file is saved using UTF-8 encoding and it
[jira] [Commented] (WAGON-538) Basic authentication fails if the password contains non-ASCII characters
[
https://issues.apache.org/jira/browse/WAGON-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687620#comment-16687620
]
ASF GitHub Bot commented on WAGON-538:
--
aleksgj commented on issue #52: [MNG-6514] Adding support for encoding basic
auth credentials with UT…
URL: https://github.com/apache/maven-wagon/pull/52#issuecomment-438951774
Closing this PR because of fix in WAGON-540
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Basic authentication fails if the password contains non-ASCII characters
>
>
> Key: WAGON-538
> URL: https://issues.apache.org/jira/browse/WAGON-538
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-http
>Affects Versions: 3.2.0
>Reporter: Aleksander Gjermundsen
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.3.0
>
>
> If the username and/or password used to authenticate to Nexus contains
> non-ascii characters, the authentication fails with an access denied error.
> After using Wireshark to investigate the headers being sent (in my case "Ø",
> any non-ascii characters are replaced with "?".
> To test, I have used the following configuration:
> {code:java}
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> ...
>
>
> artifactory
> userØ
> userØ
>
>
> ...
>
>
> nexus
> *
> Local Nexus
> http://localhost:8081/repository/maven-public
>
>
> ...
> {code}
> The settings.xml file is saved using UTF-8 encoding and it appears that Maven
> reads the username and passwords correctly into strings, but Apache
> HttpClient do not encode the UTF-8 characters when encoding them into base64.
> I did a quick patch of Wagon to make it work for my use case, where
> HttpClient is configured to encode as UTF-8. As is mentioned in MNG-5917, it
> is not completely clear from the standards how these characters are supposed
> to be handled, but on my system both wget and the Chrome web browser encode
> the characters the same way as after my patch and are able to download files
> from Nexus.
> Since Artifactory was used in MNG-5917, I also tested against that, but in
> contrast to Maven it was not able to decode the username and password
> correctly, however it would be broken without the patch anyway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] aleksgj closed pull request #52: [MNG-6514] Adding support for encoding basic auth credentials with UT…
aleksgj closed pull request #52: [MNG-6514] Adding support for encoding basic
auth credentials with UT…
URL: https://github.com/apache/maven-wagon/pull/52
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
index 9f294f7e..2ccc4793 100755
---
a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
+++
b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
@@ -19,12 +19,14 @@
* under the License.
*/
+import org.apache.http.Consts;
import org.apache.http.Header;
import org.apache.http.HttpEntity;
import org.apache.http.HttpException;
import org.apache.http.HttpHost;
import org.apache.http.HttpResponse;
import org.apache.http.HttpStatus;
+import org.apache.http.auth.AuthSchemeProvider;
import org.apache.http.auth.AuthScope;
import org.apache.http.auth.ChallengeState;
import org.apache.http.auth.Credentials;
@@ -33,6 +35,7 @@
import org.apache.http.client.AuthCache;
import org.apache.http.client.CredentialsProvider;
import org.apache.http.client.HttpRequestRetryHandler;
+import org.apache.http.client.config.AuthSchemes;
import org.apache.http.client.config.CookieSpecs;
import org.apache.http.client.config.RequestConfig;
import org.apache.http.client.methods.CloseableHttpResponse;
@@ -52,6 +55,7 @@
import org.apache.http.conn.ssl.SSLInitializationException;
import org.apache.http.entity.AbstractHttpEntity;
import org.apache.http.impl.auth.BasicScheme;
+import org.apache.http.impl.auth.BasicSchemeFactory;
import org.apache.http.impl.client.BasicAuthCache;
import org.apache.http.impl.client.BasicCredentialsProvider;
import org.apache.http.impl.client.CloseableHttpClient;
@@ -439,6 +443,13 @@ private static HttpRequestRetryHandler createRetryHandler()
}
}
+private static Registry createAuthSchemeRegistry()
+{
+return RegistryBuilder.create()
+.register( AuthSchemes.BASIC, new BasicSchemeFactory(
Consts.UTF_8 ) )
+.build();
+}
+
private static Collection>
getNonRetryableExceptions()
{
final List> exceptions = new
ArrayList<>();
@@ -466,6 +477,7 @@ private static CloseableHttpClient createClient()
.disableConnectionState() //
.setConnectionManager( httpClientConnectionManager ) //
.setRetryHandler( createRetryHandler() )
+.setDefaultAuthSchemeRegistry( createAuthSchemeRegistry() )
.build();
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] aleksgj commented on issue #52: [MNG-6514] Adding support for encoding basic auth credentials with UT…
aleksgj commented on issue #52: [MNG-6514] Adding support for encoding basic auth credentials with UT… URL: https://github.com/apache/maven-wagon/pull/52#issuecomment-438951774 Closing this PR because of fix in WAGON-540 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WAGON-538) Basic authentication fails if the password contains non-ASCII characters
[
https://issues.apache.org/jira/browse/WAGON-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687617#comment-16687617
]
Aleksander Gjermundsen commented on WAGON-538:
--
[~michael-o]: The WAGON-540 branch works for me. It downloads files from Nexus
and the log now says:
{code}
8441 [main] [DEBUG] org.apache.maven.wagon.providers.http.httpclient.headers -
http-outgoing-0 >> HEAD
/repository/maven-public/org/codehaus/plexus/plexus/1.0.11/plexus-1.0.11.pom
HTTP/1.1
8441 [main] [DEBUG] org.apache.maven.wagon.providers.http.httpclient.headers -
http-outgoing-0 >> Cache-control: no-cache
8441 [main] [DEBUG] org.apache.maven.wagon.providers.http.httpclient.headers -
http-outgoing-0 >> Cache-store: no-store
8442 [main] [DEBUG] org.apache.maven.wagon.providers.http.httpclient.headers -
http-outgoing-0 >> Pragma: no-cache
8442 [main] [DEBUG] org.apache.maven.wagon.providers.http.httpclient.headers -
http-outgoing-0 >> User-Agent: Apache-Maven/3.6.1-SNAPSHOT (Java 1.8.0_192;
Linux 4.19.1-1-MANJARO)
8442 [main] [DEBUG] org.apache.maven.wagon.providers.http.httpclient.headers -
http-outgoing-0 >> Host: localhost:8081
8442 [main] [DEBUG] org.apache.maven.wagon.providers.http.httpclient.headers -
http-outgoing-0 >> Connection: Keep-Alive
8443 [main] [DEBUG] org.apache.maven.wagon.providers.http.httpclient.headers -
http-outgoing-0 >> Accept-Encoding: gzip,deflate
8443 [main] [DEBUG] org.apache.maven.wagon.providers.http.httpclient.headers -
http-outgoing-0 >> Authorization: Basic dXNlcsOYOnVzZXLDmA==
{code}
This was without http.auth.credential-charset defined in settings.xml, so
simply:
{code}
nexus
userØ
userØ
{code}
> Basic authentication fails if the password contains non-ASCII characters
>
>
> Key: WAGON-538
> URL: https://issues.apache.org/jira/browse/WAGON-538
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-http
>Affects Versions: 3.2.0
>Reporter: Aleksander Gjermundsen
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.3.0
>
>
> If the username and/or password used to authenticate to Nexus contains
> non-ascii characters, the authentication fails with an access denied error.
> After using Wireshark to investigate the headers being sent (in my case "Ø",
> any non-ascii characters are replaced with "?".
> To test, I have used the following configuration:
> {code:java}
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> ...
>
>
> artifactory
> userØ
> userØ
>
>
> ...
>
>
> nexus
> *
> Local Nexus
> http://localhost:8081/repository/maven-public
>
>
> ...
> {code}
> The settings.xml file is saved using UTF-8 encoding and it appears that Maven
> reads the username and passwords correctly into strings, but Apache
> HttpClient do not encode the UTF-8 characters when encoding them into base64.
> I did a quick patch of Wagon to make it work for my use case, where
> HttpClient is configured to encode as UTF-8. As is mentioned in MNG-5917, it
> is not completely clear from the standards how these characters are supposed
> to be handled, but on my system both wget and the Chrome web browser encode
> the characters the same way as after my patch and are able to download files
> from Nexus.
> Since Artifactory was used in MNG-5917, I also tested against that, but in
> contrast to Maven it was not able to decode the username and password
> correctly, however it would be broken without the patch anyway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
