[GitHub] eolivelli commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting
eolivelli commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446495043 https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/MCHECKSTYLE-357/1/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718573#comment-16718573 ] ASF GitHub Bot commented on MCHECKSTYLE-357: eolivelli commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446495043 https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/MCHECKSTYLE-357/1/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718564#comment-16718564 ] ASF GitHub Bot commented on MCHECKSTYLE-357: eolivelli commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446491029 Sorry for late reply. The patch looks good to me. Let's see CI results This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] eolivelli commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting
eolivelli commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446491029 Sorry for late reply. The patch looks good to me. Let's see CI results This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Serranya commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting
Serranya commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446489371 Is there anything I can do to accelerate acceptance of this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718560#comment-16718560 ] ASF GitHub Bot commented on MCHECKSTYLE-357: Serranya commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446489371 Is there anything I can do to accelerate acceptance of this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRESOLVER-64) restore setLoggerFactory(...) API deleted from version 1.3.0
[
https://issues.apache.org/jira/browse/MRESOLVER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718504#comment-16718504
]
Dan Tran commented on MRESOLVER-64:
---
Are we all set? 😈
> restore setLoggerFactory(...) API deleted from version 1.3.0
>
>
> Key: MRESOLVER-64
> URL: https://issues.apache.org/jira/browse/MRESOLVER-64
> Project: Maven Resolver
> Issue Type: Wish
> Components: resolver
>Affects Versions: 1.3.0, 1.3.1
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 1.3.2
>
>
> during work on MRESOLVER-36 to switch from LoggerFactory to direct slf4j,
> {{setLoggerFactory(...)}} methods were removed since they are not strictly
> required now
> 2 cases of removal (in {{DefaultArtifactResolver}} and
> {{DefaultRepositorySystem}}) broke Intellij IDEA Maven integration
> adding back the method with empty implementation in the 2 classes, marking
> them deprecated, would restore strict API compatibility for older IDEA
> versions without much complexity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] eolivelli commented on a change in pull request #1: adding type safety
eolivelli commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240890241 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSignatureForArtifact( File file ) signature = new File( signatureDirectory, file.getName() + SIGNATURE_EXTENSION ); } -if ( signature.exists() ) +if ( signature.exists() && signature.delete() ) Review comment: Sorry, 'soste' was a typo, due to auto completion of my browser. We should keep a patch focused on only just one issue: reformat code, fix a bug Overall your patch is more a code clean up. But in this line you are changing the behavior, so I am asking you to file a separate issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1: adding type safety
eolivelli commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240799129 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSignatureForArtifact( File file ) signature = new File( signatureDirectory, file.getName() + SIGNATURE_EXTENSION ); } -if ( signature.exists() ) +if ( signature.exists() && signature.delete() ) Review comment: This seems unrelated to the description. Can you create a separate patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1: adding type safety
eolivelli commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240799129 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSignatureForArtifact( File file ) signature = new File( signatureDirectory, file.getName() + SIGNATURE_EXTENSION ); } -if ( signature.exists() ) +if ( signature.exists() && signature.delete() ) Review comment: This seems unrelated to the description. Can you create separate patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lanlingxueyu closed pull request #207: 2.19.2 experimental
lanlingxueyu closed pull request #207: 2.19.2 experimental URL: https://github.com/apache/maven-surefire/pull/207 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lanlingxueyu opened a new pull request #208: Update StatelessXmlReporter.java
lanlingxueyu opened a new pull request #208: Update StatelessXmlReporter.java URL: https://github.com/apache/maven-surefire/pull/208 Sort methodRunHistoryMap This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lanlingxueyu opened a new pull request #207: 2.19.2 experimental
lanlingxueyu opened a new pull request #207: 2.19.2 experimental URL: https://github.com/apache/maven-surefire/pull/207 Eliminate *Test.xml report out of order differences This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Issue Comment Deleted] (MJMOD-20) Main class is not being set by maven-jmod-plugin
[
https://issues.apache.org/jira/browse/MJMOD-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andre Tadeu de Carvalho updated MJMOD-20:
-
Comment: was deleted
(was: Hi,
Here is the PR: [https://github.com/apache/maven-jmod-plugin/pull/1]
Thanks,)
> Main class is not being set by maven-jmod-plugin
>
>
> Key: MJMOD-20
> URL: https://issues.apache.org/jira/browse/MJMOD-20
> Project: Maven JMod Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
> Environment: Ubuntu Linux 18.04 LTS
> Java 11.0.1 OpenJDK
> Maven 3.6.0
>Reporter: Andre Tadeu de Carvalho
>Priority: Major
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi!,
> I have created a project in and
> [https://github.com/andretadeu/maven-jigsaw-examples/tree/master/multi-modules-jmod-jlink|multi-modules-jmod-jlink]
> and I needed to set the parameter *--main-class* in _jmod create_ command.
> Trying to add the tag:
>
> {code:java}
>
> org.apache.maven.plugins
> maven-jmod-plugin
>
> com.andretadeu.greetings.Main
> target/jmods
> ${project.version}
>
> {code}
>
> Maven gave the following error during the execution of *maven-jlink-plugin*:
> [ERROR]
> [ERROR] com.andretadeu.greetings
> file:///home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/jmods/com.andretadeu.greetings.jmod
> [ERROR] com.andretadeu.world
> file:///home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/world/target/jmods/com.andretadeu.world.jmod
> [ERROR] java.base
> file:///home/andre/.sdkman/candidates/java/11.0.1-open/jmods/java.base.jmod
> [ERROR]
> [ERROR] Providers:
> [ERROR] java.base provides java.nio.file.spi.FileSystemProvider used by
> java.base
> [ERROR] Error: java.lang.IllegalArgumentException: com.andretadeu.greetings
> doesn't contain main class & main not specified in command line
> [INFO]
>
> [INFO] Reactor Summary for multi-modules-jmod-jlink 1.0-SNAPSHOT:
> [INFO]
> [INFO] multi-modules-jmod-jlink ... SUCCESS [ 0.185 s]
> [INFO] com.andretadeu.world ... SUCCESS [ 3.974 s]
> [INFO] com.andretadeu.greetings ... SUCCESS [ 0.628 s]
> [INFO] greetings-jlink FAILURE [ 3.068 s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 8.916 s
> [INFO] Finished at: 2018-12-11T22:42:31-02:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-jlink-plugin:3.0.0-alpha-2-SNAPSHOT:jlink
> (default-jlink) on project greetings-jlink:
> [ERROR] Exit code: 1
> [ERROR] Command line was: /bin/sh -c
> /home/andre/.sdkman/candidates/java/11.0.1-open/bin/jlink
> @/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings-jlink/target/jlinkArgs
> [ERROR]
> [ERROR]
> [ERROR] -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-jlink-plugin:3.0.0-alpha-2-SNAPSHOT:jlink
> (default-jlink) on project greetings-jlink:
> Exit code: 1
> Command line was: /bin/sh -c
> /home/andre/.sdkman/candidates/java/11.0.1-open/bin/jlink
> @/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings-jlink/target/jlinkArgs
>
> I noticed that the *--main-class* parameter was not set in **_jmodCreateArgs_:
> {code:java}
> create
> --module-version
> 1.0-SNAPSHOT
> --class-path
> /home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/classes
> --module-path
> "/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/classes:/home/andre/.sdkman/candidates/java/11.0.1-open/jmods"
> /home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/jmods/com.andretadeu.greetings.jmod
> {code}
> Debugging the plugin, I have found the root cause of the problem and I will
> make a pull request after publishing this issue.
>
> Thanks,
>
> André Tadeu de Carvalho
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJMOD-20) Main class is not being set by maven-jmod-plugin
[
https://issues.apache.org/jira/browse/MJMOD-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718324#comment-16718324
]
Andre Tadeu de Carvalho commented on MJMOD-20:
--
Hi,
Here is the PR: [https://github.com/apache/maven-jmod-plugin/pull/1]
Thanks,
> Main class is not being set by maven-jmod-plugin
>
>
> Key: MJMOD-20
> URL: https://issues.apache.org/jira/browse/MJMOD-20
> Project: Maven JMod Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
> Environment: Ubuntu Linux 18.04 LTS
> Java 11.0.1 OpenJDK
> Maven 3.6.0
>Reporter: Andre Tadeu de Carvalho
>Priority: Major
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi!,
> I have created a project in and
> [https://github.com/andretadeu/maven-jigsaw-examples/tree/master/multi-modules-jmod-jlink|multi-modules-jmod-jlink]
> and I needed to set the parameter *--main-class* in _jmod create_ command.
> Trying to add the tag:
>
> {code:java}
>
> org.apache.maven.plugins
> maven-jmod-plugin
>
> com.andretadeu.greetings.Main
> target/jmods
> ${project.version}
>
> {code}
>
> Maven gave the following error during the execution of *maven-jlink-plugin*:
> [ERROR]
> [ERROR] com.andretadeu.greetings
> file:///home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/jmods/com.andretadeu.greetings.jmod
> [ERROR] com.andretadeu.world
> file:///home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/world/target/jmods/com.andretadeu.world.jmod
> [ERROR] java.base
> file:///home/andre/.sdkman/candidates/java/11.0.1-open/jmods/java.base.jmod
> [ERROR]
> [ERROR] Providers:
> [ERROR] java.base provides java.nio.file.spi.FileSystemProvider used by
> java.base
> [ERROR] Error: java.lang.IllegalArgumentException: com.andretadeu.greetings
> doesn't contain main class & main not specified in command line
> [INFO]
>
> [INFO] Reactor Summary for multi-modules-jmod-jlink 1.0-SNAPSHOT:
> [INFO]
> [INFO] multi-modules-jmod-jlink ... SUCCESS [ 0.185 s]
> [INFO] com.andretadeu.world ... SUCCESS [ 3.974 s]
> [INFO] com.andretadeu.greetings ... SUCCESS [ 0.628 s]
> [INFO] greetings-jlink FAILURE [ 3.068 s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 8.916 s
> [INFO] Finished at: 2018-12-11T22:42:31-02:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-jlink-plugin:3.0.0-alpha-2-SNAPSHOT:jlink
> (default-jlink) on project greetings-jlink:
> [ERROR] Exit code: 1
> [ERROR] Command line was: /bin/sh -c
> /home/andre/.sdkman/candidates/java/11.0.1-open/bin/jlink
> @/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings-jlink/target/jlinkArgs
> [ERROR]
> [ERROR]
> [ERROR] -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-jlink-plugin:3.0.0-alpha-2-SNAPSHOT:jlink
> (default-jlink) on project greetings-jlink:
> Exit code: 1
> Command line was: /bin/sh -c
> /home/andre/.sdkman/candidates/java/11.0.1-open/bin/jlink
> @/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings-jlink/target/jlinkArgs
>
> I noticed that the *--main-class* parameter was not set in **_jmodCreateArgs_:
> {code:java}
> create
> --module-version
> 1.0-SNAPSHOT
> --class-path
> /home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/classes
> --module-path
> "/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/classes:/home/andre/.sdkman/candidates/java/11.0.1-open/jmods"
> /home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/jmods/com.andretadeu.greetings.jmod
> {code}
> Debugging the plugin, I have found the root cause of the problem and I will
> make a pull request after publishing this issue.
>
> Thanks,
>
> André Tadeu de Carvalho
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MJMOD-20) Main class is not being set by maven-jmod-plugin
Andre Tadeu de Carvalho created MJMOD-20:
Summary: Main class is not being set by maven-jmod-plugin
Key: MJMOD-20
URL: https://issues.apache.org/jira/browse/MJMOD-20
Project: Maven JMod Plugin
Issue Type: Bug
Affects Versions: 3.0.0-alpha-2
Environment: Ubuntu Linux 18.04 LTS
Java 11.0.1 OpenJDK
Maven 3.6.0
Reporter: Andre Tadeu de Carvalho
Hi!,
I have created a project in and
[https://github.com/andretadeu/maven-jigsaw-examples/tree/master/multi-modules-jmod-jlink|multi-modules-jmod-jlink]
and I needed to set the parameter *--main-class* in _jmod create_ command.
Trying to add the tag:
{code:java}
org.apache.maven.plugins
maven-jmod-plugin
com.andretadeu.greetings.Main
target/jmods
${project.version}
{code}
Maven gave the following error during the execution of *maven-jlink-plugin*:
[ERROR]
[ERROR] com.andretadeu.greetings
file:///home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/jmods/com.andretadeu.greetings.jmod
[ERROR] com.andretadeu.world
file:///home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/world/target/jmods/com.andretadeu.world.jmod
[ERROR] java.base
file:///home/andre/.sdkman/candidates/java/11.0.1-open/jmods/java.base.jmod
[ERROR]
[ERROR] Providers:
[ERROR] java.base provides java.nio.file.spi.FileSystemProvider used by
java.base
[ERROR] Error: java.lang.IllegalArgumentException: com.andretadeu.greetings
doesn't contain main class & main not specified in command line
[INFO]
[INFO] Reactor Summary for multi-modules-jmod-jlink 1.0-SNAPSHOT:
[INFO]
[INFO] multi-modules-jmod-jlink ... SUCCESS [ 0.185 s]
[INFO] com.andretadeu.world ... SUCCESS [ 3.974 s]
[INFO] com.andretadeu.greetings ... SUCCESS [ 0.628 s]
[INFO] greetings-jlink FAILURE [ 3.068 s]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 8.916 s
[INFO] Finished at: 2018-12-11T22:42:31-02:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-jlink-plugin:3.0.0-alpha-2-SNAPSHOT:jlink
(default-jlink) on project greetings-jlink:
[ERROR] Exit code: 1
[ERROR] Command line was: /bin/sh -c
/home/andre/.sdkman/candidates/java/11.0.1-open/bin/jlink
@/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings-jlink/target/jlinkArgs
[ERROR]
[ERROR]
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-jlink-plugin:3.0.0-alpha-2-SNAPSHOT:jlink
(default-jlink) on project greetings-jlink:
Exit code: 1
Command line was: /bin/sh -c
/home/andre/.sdkman/candidates/java/11.0.1-open/bin/jlink
@/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings-jlink/target/jlinkArgs
I noticed that the *--main-class* parameter was not set in **_jmodCreateArgs_:
{code:java}
create
--module-version
1.0-SNAPSHOT
--class-path
/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/classes
--module-path
"/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/classes:/home/andre/.sdkman/candidates/java/11.0.1-open/jmods"
/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/jmods/com.andretadeu.greetings.jmod
{code}
Debugging the plugin, I have found the root cause of the problem and I will
make a pull request after publishing this issue.
Thanks,
André Tadeu de Carvalho
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJMOD-20) Main class is not being set by maven-jmod-plugin
[
https://issues.apache.org/jira/browse/MJMOD-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718322#comment-16718322
]
ASF GitHub Bot commented on MJMOD-20:
-
andretadeu opened a new pull request #1: [MJMOD-20] set jmod --main-class
argument if it is set.
URL: https://github.com/apache/maven-jmod-plugin/pull/1
Hi!
This pull request sets the parameter --main-class if it was set in:
```
org.apache.maven.plugins
maven-jmod-plugin
com.andretadeu.greetings.Main
target/jmods
${project.version}
...
```
otherwise, if I am not able to set, I may not run jmod in modules that
contains a Main class.
Thanks,
André Tadeu de Carvalho
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Main class is not being set by maven-jmod-plugin
>
>
> Key: MJMOD-20
> URL: https://issues.apache.org/jira/browse/MJMOD-20
> Project: Maven JMod Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
> Environment: Ubuntu Linux 18.04 LTS
> Java 11.0.1 OpenJDK
> Maven 3.6.0
>Reporter: Andre Tadeu de Carvalho
>Priority: Major
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi!,
> I have created a project in and
> [https://github.com/andretadeu/maven-jigsaw-examples/tree/master/multi-modules-jmod-jlink|multi-modules-jmod-jlink]
> and I needed to set the parameter *--main-class* in _jmod create_ command.
> Trying to add the tag:
>
> {code:java}
>
> org.apache.maven.plugins
> maven-jmod-plugin
>
> com.andretadeu.greetings.Main
> target/jmods
> ${project.version}
>
> {code}
>
> Maven gave the following error during the execution of *maven-jlink-plugin*:
> [ERROR]
> [ERROR] com.andretadeu.greetings
> file:///home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/jmods/com.andretadeu.greetings.jmod
> [ERROR] com.andretadeu.world
> file:///home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/world/target/jmods/com.andretadeu.world.jmod
> [ERROR] java.base
> file:///home/andre/.sdkman/candidates/java/11.0.1-open/jmods/java.base.jmod
> [ERROR]
> [ERROR] Providers:
> [ERROR] java.base provides java.nio.file.spi.FileSystemProvider used by
> java.base
> [ERROR] Error: java.lang.IllegalArgumentException: com.andretadeu.greetings
> doesn't contain main class & main not specified in command line
> [INFO]
>
> [INFO] Reactor Summary for multi-modules-jmod-jlink 1.0-SNAPSHOT:
> [INFO]
> [INFO] multi-modules-jmod-jlink ... SUCCESS [ 0.185 s]
> [INFO] com.andretadeu.world ... SUCCESS [ 3.974 s]
> [INFO] com.andretadeu.greetings ... SUCCESS [ 0.628 s]
> [INFO] greetings-jlink FAILURE [ 3.068 s]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 8.916 s
> [INFO] Finished at: 2018-12-11T22:42:31-02:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-jlink-plugin:3.0.0-alpha-2-SNAPSHOT:jlink
> (default-jlink) on project greetings-jlink:
> [ERROR] Exit code: 1
> [ERROR] Command line was: /bin/sh -c
> /home/andre/.sdkman/candidates/java/11.0.1-open/bin/jlink
> @/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings-jlink/target/jlinkArgs
> [ERROR]
> [ERROR]
> [ERROR] -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-jlink-plugin:3.0.0-alpha-2-SNAPSHOT:jlink
> (default-jlink) on project greetings-jlink:
> Exit code: 1
> Command line was: /bin/sh -c
> /home/andre/.sdkman/candidates/java/11.0.1-open/bin/jlink
> @/home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings-jlink/target/jlinkArgs
>
> I noticed that the *--main-class* parameter was not set in **_jmodCreateArgs_:
> {code:java}
> create
> --module-version
> 1.0-SNAPSHOT
> --class-path
> /home/andre/workspaces/oss/maven-jigsaw-examples/multi-modules-jmod-jlink/greetings/target/classes
> --module-path
> "/home/andre/
[GitHub] andretadeu opened a new pull request #1: [MJMOD-20] set jmod --main-class argument if it is set.
andretadeu opened a new pull request #1: [MJMOD-20] set jmod --main-class
argument if it is set.
URL: https://github.com/apache/maven-jmod-plugin/pull/1
Hi!
This pull request sets the parameter --main-class if it was set in:
```
org.apache.maven.plugins
maven-jmod-plugin
com.andretadeu.greetings.Main
target/jmods
${project.version}
...
```
otherwise, if I am not able to set, I may not run jmod in modules that
contains a Main class.
Thanks,
André Tadeu de Carvalho
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] javabeanz commented on a change in pull request #1: adding type safety
javabeanz commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240835336 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSignatureForArtifact( File file ) signature = new File( signatureDirectory, file.getName() + SIGNATURE_EXTENSION ); } -if ( signature.exists() ) +if ( signature.exists() && signature.delete() ) Review comment: I also have added some changes to reduce complexity, as suggested by SonarQube. Some methods have very high complexity, those are still under development. What is "a soste separate patch" ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1017) Failures do not show test-package since 2.13
[
https://issues.apache.org/jira/browse/SUREFIRE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718036#comment-16718036
]
ASF GitHub Bot commented on SUREFIRE-1017:
--
Tibor17 closed pull request #92: [SUREFIRE-1017] Failures do not show
test-package since 2.13
URL: https://github.com/apache/maven-surefire/pull/92
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/surefire-providers/common-java5/src/main/java/org/apache/maven/surefire/report/SmartStackTraceParser.java
b/surefire-providers/common-java5/src/main/java/org/apache/maven/surefire/report/SmartStackTraceParser.java
index 056eef343..13401433a 100644
---
a/surefire-providers/common-java5/src/main/java/org/apache/maven/surefire/report/SmartStackTraceParser.java
+++
b/surefire-providers/common-java5/src/main/java/org/apache/maven/surefire/report/SmartStackTraceParser.java
@@ -32,15 +32,12 @@
@SuppressWarnings( "ThrowableResultOfMethodCallIgnored" )
public class SmartStackTraceParser
{
-
private static final int MAX_LINE_LENGTH = 77;
private final SafeThrowable throwable;
private final StackTraceElement[] stackTrace;
-private final String simpleName;
-
private String testClassName;
private final Class testClass;
@@ -57,7 +54,6 @@ public SmartStackTraceParser( String testClassName, Throwable
throwable, String
this.testMethodName = testMethodName;
this.testClassName = testClassName;
this.testClass = getClass( testClassName );
-this.simpleName = this.testClassName.substring(
this.testClassName.lastIndexOf( "." ) + 1 );
this.throwable = new SafeThrowable( throwable );
stackTrace = throwable.getStackTrace();
}
@@ -94,7 +90,7 @@ public String getString()
Collections.reverse( stackTraceElements );
if ( stackTraceElements.isEmpty() )
{
-result.append( simpleName );
+result.append( testClassName );
if ( StringUtils.isNotEmpty( testMethodName ) )
{
result.append( "." ).append( testMethodName );
@@ -102,13 +98,14 @@ public String getString()
}
else
{
-for ( int i = 0; i < stackTraceElements.size(); i++ )
+for ( int i = 0, size = stackTraceElements.size(); i < size; i++ )
{
final StackTraceElement stackTraceElement =
stackTraceElements.get( i );
+final boolean isTestClassName =
stackTraceElement.getClassName().equals( testClassName );
if ( i == 0 )
{
-result.append( simpleName );
-if ( !stackTraceElement.getClassName().equals(
testClassName ) )
+result.append( testClassName );
+if ( !isTestClassName )
{
result.append( ">" );
}
@@ -117,14 +114,15 @@ public String getString()
result.append( "." );
}
}
-if ( !stackTraceElement.getClassName().equals( testClassName )
)
+if ( !isTestClassName )
{
-result.append( getSimpleName(
stackTraceElement.getClassName() ) ); // Add the name of the superclas
+result.append( getSimpleName(
stackTraceElement.getClassName() ) ); // Add the name of superclass
result.append( "." );
}
-result.append( stackTraceElement.getMethodName() ).append( ":"
).append(
-stackTraceElement.getLineNumber() );
-result.append( "->" );
+result.append( stackTraceElement.getMethodName() )
+.append( ":" )
+.append( stackTraceElement.getLineNumber() )
+.append( "->" );
}
if ( result.length() >= 2 )
@@ -134,17 +132,17 @@ public String getString()
}
}
-Throwable target = throwable.getTarget();
-if ( target instanceof AssertionError )
-{
-result.append( " " );
-result.append( throwable.getMessage() );
-}
-else if ( "junit.framework.AssertionFailedError".equals(
target.getClass().getName() )
-|| "junit.framework.ComparisonFailure".equals(
target.getClass().getName() ) )
+final Throwable target = throwable.getTarget();
+if ( target instanceof AssertionError
+|| "junit.framework.AssertionFailedError".equals(
target.getClass().getName() )
+|| "junit.framework.C
[GitHub] Tibor17 closed pull request #92: [SUREFIRE-1017] Failures do not show test-package since 2.13
Tibor17 closed pull request #92: [SUREFIRE-1017] Failures do not show
test-package since 2.13
URL: https://github.com/apache/maven-surefire/pull/92
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/surefire-providers/common-java5/src/main/java/org/apache/maven/surefire/report/SmartStackTraceParser.java
b/surefire-providers/common-java5/src/main/java/org/apache/maven/surefire/report/SmartStackTraceParser.java
index 056eef343..13401433a 100644
---
a/surefire-providers/common-java5/src/main/java/org/apache/maven/surefire/report/SmartStackTraceParser.java
+++
b/surefire-providers/common-java5/src/main/java/org/apache/maven/surefire/report/SmartStackTraceParser.java
@@ -32,15 +32,12 @@
@SuppressWarnings( "ThrowableResultOfMethodCallIgnored" )
public class SmartStackTraceParser
{
-
private static final int MAX_LINE_LENGTH = 77;
private final SafeThrowable throwable;
private final StackTraceElement[] stackTrace;
-private final String simpleName;
-
private String testClassName;
private final Class testClass;
@@ -57,7 +54,6 @@ public SmartStackTraceParser( String testClassName, Throwable
throwable, String
this.testMethodName = testMethodName;
this.testClassName = testClassName;
this.testClass = getClass( testClassName );
-this.simpleName = this.testClassName.substring(
this.testClassName.lastIndexOf( "." ) + 1 );
this.throwable = new SafeThrowable( throwable );
stackTrace = throwable.getStackTrace();
}
@@ -94,7 +90,7 @@ public String getString()
Collections.reverse( stackTraceElements );
if ( stackTraceElements.isEmpty() )
{
-result.append( simpleName );
+result.append( testClassName );
if ( StringUtils.isNotEmpty( testMethodName ) )
{
result.append( "." ).append( testMethodName );
@@ -102,13 +98,14 @@ public String getString()
}
else
{
-for ( int i = 0; i < stackTraceElements.size(); i++ )
+for ( int i = 0, size = stackTraceElements.size(); i < size; i++ )
{
final StackTraceElement stackTraceElement =
stackTraceElements.get( i );
+final boolean isTestClassName =
stackTraceElement.getClassName().equals( testClassName );
if ( i == 0 )
{
-result.append( simpleName );
-if ( !stackTraceElement.getClassName().equals(
testClassName ) )
+result.append( testClassName );
+if ( !isTestClassName )
{
result.append( ">" );
}
@@ -117,14 +114,15 @@ public String getString()
result.append( "." );
}
}
-if ( !stackTraceElement.getClassName().equals( testClassName )
)
+if ( !isTestClassName )
{
-result.append( getSimpleName(
stackTraceElement.getClassName() ) ); // Add the name of the superclas
+result.append( getSimpleName(
stackTraceElement.getClassName() ) ); // Add the name of superclass
result.append( "." );
}
-result.append( stackTraceElement.getMethodName() ).append( ":"
).append(
-stackTraceElement.getLineNumber() );
-result.append( "->" );
+result.append( stackTraceElement.getMethodName() )
+.append( ":" )
+.append( stackTraceElement.getLineNumber() )
+.append( "->" );
}
if ( result.length() >= 2 )
@@ -134,17 +132,17 @@ public String getString()
}
}
-Throwable target = throwable.getTarget();
-if ( target instanceof AssertionError )
-{
-result.append( " " );
-result.append( throwable.getMessage() );
-}
-else if ( "junit.framework.AssertionFailedError".equals(
target.getClass().getName() )
-|| "junit.framework.ComparisonFailure".equals(
target.getClass().getName() ) )
+final Throwable target = throwable.getTarget();
+if ( target instanceof AssertionError
+|| "junit.framework.AssertionFailedError".equals(
target.getClass().getName() )
+|| "junit.framework.ComparisonFailure".equals(
target.getClass().getName() ) )
{
-result.append( " " );
-result.append( throwable.getMessage() );
+String msg = throwable.getMessage();
+if ( StringUtils.isNotBlank( msg ) )
+
[jira] [Closed] (SUREFIRE-1017) Failures do not show test-package since 2.13
[
https://issues.apache.org/jira/browse/SUREFIRE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1017.
--
Resolution: Won't Fix
I agree with [~krosenvold]
{{How hard would it be to dynamically expand the amount of package info we show
to ensure uniqueness}}
The point of Smart StackTrace Parser (class in Surefire) is to report compact
stack trace. Thus closing as won't fix and no package used to expand the lines
in the stack trace.
> Failures do not show test-package since 2.13
>
>
> Key: SUREFIRE-1017
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1017
> Project: Maven Surefire
> Issue Type: Improvement
>Affects Versions: 2.13, 2.14, 2.15
>Reporter: Christian Spriegel
>Assignee: Tibor Digana
>Priority: Major
>
> Older versions of surefire always showed the package name of each failed test
> in the result overview.
> Since surefire 2.13 I simply get the classname:
> {code}
> Results :
> Failed tests:
> RoundtripTest>AbstractTestNGSpringContextTests.run:196->test:115 error
> RoundtripTest>AbstractTestNGSpringContextTests.run:196->test:115 error
> {code}
> As you can see I have two tests called RoundtripTest in the overview. These
> testclasses are in different packages, but I do not know which one is which.
> My testsuite has 830 testcases, where ~650 are called RoundtripTest. So its
> quite hard now for me to identify the failing tests.
> SUREFIRE-936 seems to have changed this. I have not checked the git commit,
> but from the description I assume that was the change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] eolivelli commented on a change in pull request #1: adding type safety
eolivelli commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240799129 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSignatureForArtifact( File file ) signature = new File( signatureDirectory, file.getName() + SIGNATURE_EXTENSION ); } -if ( signature.exists() ) +if ( signature.exists() && signature.delete() ) Review comment: This seems unrelated to the description. Can you create a soste separate patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (SUREFIRE-1017) Failures do not show test-package since 2.13
[
https://issues.apache.org/jira/browse/SUREFIRE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1017:
---
Fix Version/s: (was: 3.0.0-M3)
> Failures do not show test-package since 2.13
>
>
> Key: SUREFIRE-1017
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1017
> Project: Maven Surefire
> Issue Type: Improvement
>Affects Versions: 2.13, 2.14, 2.15
>Reporter: Christian Spriegel
>Assignee: Tibor Digana
>Priority: Major
>
> Older versions of surefire always showed the package name of each failed test
> in the result overview.
> Since surefire 2.13 I simply get the classname:
> {code}
> Results :
> Failed tests:
> RoundtripTest>AbstractTestNGSpringContextTests.run:196->test:115 error
> RoundtripTest>AbstractTestNGSpringContextTests.run:196->test:115 error
> {code}
> As you can see I have two tests called RoundtripTest in the overview. These
> testclasses are in different packages, but I do not know which one is which.
> My testsuite has 830 testcases, where ~650 are called RoundtripTest. So its
> quite hard now for me to identify the failing tests.
> SUREFIRE-936 seems to have changed this. I have not checked the git commit,
> but from the description I assume that was the change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] javabeanz opened a new pull request #1: adding tyoe safety
javabeanz opened a new pull request #1: adding tyoe safety URL: https://github.com/apache/maven-gpg-plugin/pull/1 a first step for improvement is to use java type safe collections This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MJAVADOC-495) links option ignored in offline mode, even for local links
[
https://issues.apache.org/jira/browse/MJAVADOC-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717981#comment-16717981
]
Hudson commented on MJAVADOC-495:
-
Build failed in Jenkins: Maven TLP » maven-javadoc-plugin » master #88
See
https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/job/master/88/
> links option ignored in offline mode, even for local links
> --
>
> Key: MJAVADOC-495
> URL: https://issues.apache.org/jira/browse/MJAVADOC-495
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Reporter: Carnë Draug
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.2
>
>
> The `links` property is ignored when offline mode. This may make sense when
> it generates links to an external server and needs access to its
> `package-list`. However, it is still ignored when generating links to
> external javadocs in the local filesystem. This also means that it no longer
> matches the javadoc `-link` which would accept links to the local filesystem
> nicely like so:
> {noformat}
> javadoc -link file:///usr/local/share/doc...
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MJAVADOC-495) links option ignored in offline mode, even for local links
[
https://issues.apache.org/jira/browse/MJAVADOC-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MJAVADOC-495.
---
Resolution: Fixed
Assignee: Robert Scholte
Fix Version/s: 3.0.2
Fixed in
[69ec690c0328229b7353f6eed8600aabe19ec9fa|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=69ec690c0328229b7353f6eed8600aabe19ec9fa]
> links option ignored in offline mode, even for local links
> --
>
> Key: MJAVADOC-495
> URL: https://issues.apache.org/jira/browse/MJAVADOC-495
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Reporter: Carnë Draug
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.2
>
>
> The `links` property is ignored when offline mode. This may make sense when
> it generates links to an external server and needs access to its
> `package-list`. However, it is still ignored when generating links to
> external javadocs in the local filesystem. This also means that it no longer
> matches the javadoc `-link` which would accept links to the local filesystem
> nicely like so:
> {noformat}
> javadoc -link file:///usr/local/share/doc...
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MSHARED-784) release maven-common-artifact-filters v3.0.2
[ https://issues.apache.org/jira/browse/MSHARED-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSHARED-784: -- Assignee: Michael Osipov > release maven-common-artifact-filters v3.0.2 > > > Key: MSHARED-784 > URL: https://issues.apache.org/jira/browse/MSHARED-784 > Project: Maven Shared Components > Issue Type: Task > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.0.2 >Reporter: Matt Kusnierz >Assignee: Michael Osipov >Priority: Major > Original Estimate: 1h > Remaining Estimate: 1h > > Please release v3.0.2 in order to fix issue: > https://issues.apache.org/jira/browse/MSHARED-631 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717734#comment-16717734 ] Enrico Olivelli commented on MENFORCER-324: --- Thank you [~khmarbaise] I will do as you are suggesting. I am new to Maven committers workflow, any help and guidance are very appreciated > Shouldn't we use System.lineSeparator() instead of \n ? > --- > > Key: MENFORCER-324 > URL: https://issues.apache.org/jira/browse/MENFORCER-324 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-323) Improve output in case of "Some plugins are missing valid versions" error
[ https://issues.apache.org/jira/browse/MENFORCER-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717740#comment-16717740 ] ASF GitHub Bot commented on MENFORCER-323: -- Tibor17 commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446315065 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve output in case of "Some plugins are missing valid versions" error > - > > Key: MENFORCER-323 > URL: https://issues.apache.org/jira/browse/MENFORCER-323 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Tibor17 commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error
Tibor17 commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446315065 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717736#comment-16717736 ] ASF GitHub Bot commented on MENFORCER-324: -- Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446313981 @eolivelli Correct! I think the main change in https://github.com/apache/maven-enforcer/pull/47 can be pushed even with `\n`. If somebody is shouting in users, we will fix new lies then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shouldn't we use System.lineSeparator() instead of \n ? > --- > > Key: MENFORCER-324 > URL: https://issues.apache.org/jira/browse/MENFORCER-324 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717737#comment-16717737 ] ASF GitHub Bot commented on MENFORCER-324: -- Tibor17 edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446313981 @eolivelli Correct! I think the main change in https://github.com/apache/maven-enforcer/pull/47 can be pushed even with `\n`. If somebody is shouting in users, we will fix new lines then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shouldn't we use System.lineSeparator() instead of \n ? > --- > > Key: MENFORCER-324 > URL: https://issues.apache.org/jira/browse/MENFORCER-324 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Tibor17 edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
Tibor17 edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446313981 @eolivelli Correct! I think the main change in https://github.com/apache/maven-enforcer/pull/47 can be pushed even with `\n`. If somebody is shouting in users, we will fix new lines then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent
[
https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717735#comment-16717735
]
Hudson commented on MENFORCER-322:
--
Build succeeded in Jenkins: Maven TLP » maven-enforcer » master #56
See https://builds.apache.org/job/maven-box/job/maven-enforcer/job/master/56/
> requireProfileIdsExist triggers if profile is defined at parent
> ---
>
> Key: MENFORCER-322
> URL: https://issues.apache.org/jira/browse/MENFORCER-322
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0-M2
>Reporter: Andre Schulz
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> If a profile is defined at a parent POM the maven-enforcer-plugin fails the
> build if requireProfileIdsExist is used.
> Transitive profiles should be also respected, since they are used during
> build.
> Example:
> profile from parent: RUN
> profile from self: DEV
> build parameters: -P RUN,DEV
> {code:java}
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProfileIdsExist
> faile
> d with message:
> The requested profile doesn't exist: RUN
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446313981 @eolivelli Correct! I think the main change in https://github.com/apache/maven-enforcer/pull/47 can be pushed even with `\n`. If somebody is shouting in users, we will fix new lies then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717726#comment-16717726 ] ASF GitHub Bot commented on MENFORCER-324: -- eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446312211 I think that we don't need this change if noone ever reported errors on Windows and Mac. I appreciate @jsoref work and the fact that he is responding to suggestions and requests of the maintainers of this code base. The initial request was Karl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shouldn't we use System.lineSeparator() instead of \n ? > --- > > Key: MENFORCER-324 > URL: https://issues.apache.org/jira/browse/MENFORCER-324 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717727#comment-16717727 ] ASF GitHub Bot commented on MENFORCER-324: -- eolivelli edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446312211 I think that we don't need this change if noone ever reported errors on Windows and Mac. I appreciate @jsoref work and the fact that he is responding to suggestions and requests of the maintainers of this code base. The initial request was from Karl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shouldn't we use System.lineSeparator() instead of \n ? > --- > > Key: MENFORCER-324 > URL: https://issues.apache.org/jira/browse/MENFORCER-324 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] eolivelli edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446312211 I think that we don't need this change if noone ever reported errors on Windows and Mac. I appreciate @jsoref work and the fact that he is responding to suggestions and requests of the maintainers of this code base. The initial request was from Karl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446312211 I think that we don't need this change if noone ever reported errors on Windows and Mac. I appreciate @jsoref work and the fact that he is responding to suggestions and requests of the maintainers of this code base. The initial request was Karl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent
[
https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717706#comment-16717706
]
ASF GitHub Bot commented on MENFORCER-322:
--
khmarbaise commented on issue #46: [MENFORCER-322] - requireProfileIdsExist
triggers if profile is defined at parent
URL: https://github.com/apache/maven-enforcer/pull/46#issuecomment-446308598
Merged to master. Thanks for your contribution.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> requireProfileIdsExist triggers if profile is defined at parent
> ---
>
> Key: MENFORCER-322
> URL: https://issues.apache.org/jira/browse/MENFORCER-322
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0-M2
>Reporter: Andre Schulz
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> If a profile is defined at a parent POM the maven-enforcer-plugin fails the
> build if requireProfileIdsExist is used.
> Transitive profiles should be also respected, since they are used during
> build.
> Example:
> profile from parent: RUN
> profile from self: DEV
> build parameters: -P RUN,DEV
> {code:java}
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProfileIdsExist
> faile
> d with message:
> The requested profile doesn't exist: RUN
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717722#comment-16717722 ] ASF GitHub Bot commented on MENFORCER-324: -- Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446310033 @eolivelli If the user does not want to continue, we can take over. Java is quite redundant language and we can make better if we put a public static final constant `NL` in `EnforcerUtils` and replace all these calls. These changes remind me to say that there are these code constructs: `stingBuilder.append( "a" + "b" )` which should be transformed to two calls of `append`. If we do it, we should do it properly. On the other side the reason for these strings is displaying a message on console and the messages are never so big that we have to use `StringBuilder` as performance optimizer. Humans are not able to react on changes below 0.3 seconds and these CPUs can concatenate Kilo bytes of strings within microseconds. There I use to make a compromises in my codes because `javac 1.5+` translates simple concatenation `"a" + "b"` to the same code with `StringBuilder` in bytecode except the loops. Making more compact Java code with a slowness cca 1 microsecond is still perfect for creating these Exception messages. And anyway if we construct Exception it means that the build is going to fail and there such delay 1E-6 seconds does not matter at all even if it was 1E-3 seconds. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shouldn't we use System.lineSeparator() instead of \n ? > --- > > Key: MENFORCER-324 > URL: https://issues.apache.org/jira/browse/MENFORCER-324 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446310033 @eolivelli If the user does not want to continue, we can take over. Java is quite redundant language and we can make better if we put a public static final constant `NL` in `EnforcerUtils` and replace all these calls. These changes remind me to say that there are these code constructs: `stingBuilder.append( "a" + "b" )` which should be transformed to two calls of `append`. If we do it, we should do it properly. On the other side the reason for these strings is displaying a message on console and the messages are never so big that we have to use `StringBuilder` as performance optimizer. Humans are not able to react on changes below 0.3 seconds and these CPUs can concatenate Kilo bytes of strings within microseconds. There I use to make a compromises in my codes because `javac 1.5+` translates simple concatenation `"a" + "b"` to the same code with `StringBuilder` in bytecode except the loops. Making more compact Java code with a slowness cca 1 microsecond is still perfect for creating these Exception messages. And anyway if we construct Exception it means that the build is going to fail and there such delay 1E-6 seconds does not matter at all even if it was 1E-3 seconds. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent
[
https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717707#comment-16717707
]
ASF GitHub Bot commented on MENFORCER-322:
--
khmarbaise closed pull request #46: [MENFORCER-322] - requireProfileIdsExist
triggers if profile is defined at parent
URL: https://github.com/apache/maven-enforcer/pull/46
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireProfileIdsExist.java
b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireProfileIdsExist.java
index 770f644..d595497 100644
---
a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireProfileIdsExist.java
+++
b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireProfileIdsExist.java
@@ -33,6 +33,7 @@
* Ensure that all profiles mentioned on the commandline do exist.
*
* @author Robert Scholte
+ * @author Gabriel Belingueres
*/
public class RequireProfileIdsExist extends AbstractNonCacheableEnforcerRule
{
@@ -43,24 +44,32 @@ public void execute( EnforcerRuleHelper helper )
try
{
MavenSession session = (MavenSession) helper.evaluate(
"${session}" );
-
+
List profileIds = new ArrayList();
profileIds.addAll(
session.getProjectBuildingRequest().getActiveProfileIds() );
profileIds.addAll(
session.getProjectBuildingRequest().getInactiveProfileIds() );
-
+
for ( MavenProject project : session.getProjects() )
{
-for ( org.apache.maven.model.Profile profile :
project.getModel().getProfiles() )
+// iterate over all parents
+MavenProject currentProject = project;
+do
{
-profileIds.remove( profile.getId() );
-
-if ( profileIds.isEmpty() )
+for ( org.apache.maven.model.Profile profile :
currentProject.getModel().getProfiles() )
{
-return;
+profileIds.remove( profile.getId() );
+
+if ( profileIds.isEmpty() )
+{
+return;
+}
}
+
+currentProject = currentProject.getParent();
}
+while ( currentProject != null );
}
-
+
for ( org.apache.maven.settings.Profile profile :
session.getSettings().getProfiles() )
{
profileIds.remove( profile.getId() );
@@ -81,7 +90,7 @@ public void execute( EnforcerRuleHelper helper )
sb.append( "The requested profile doesn't exist: " );
}
sb.append( StringUtils.join( profileIds.iterator(), ", " ) );
-
+
throw new EnforcerRuleException( sb.toString() );
}
catch ( ExpressionEvaluationException e )
diff --git
a/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/MENFORCER-322-module/pom.xml
b/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/MENFORCER-322-module/pom.xml
new file mode 100644
index 000..a0540d5
--- /dev/null
+++
b/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/MENFORCER-322-module/pom.xml
@@ -0,0 +1,65 @@
+
+
+
+
+
+
+ 4.0.0
+
+
+org.apache.maven.its.enforcer
+test
+1.0
+..
+
+
+ org.apache.maven.its.enforcer
+ menforcer-322-module
+ 1.0
+
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+@project.version@
+
+
+test
+
+ enforce
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ b
+
+
+
diff --git
a/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/invoker.properties
b/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/invoker.properties
new file mode 100644
index 000..8d46b16
--- /dev/null
+++
b/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/invoker.properties
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under th
[jira] [Closed] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent
[
https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MENFORCER-322.
-
Resolution: Done
> requireProfileIdsExist triggers if profile is defined at parent
> ---
>
> Key: MENFORCER-322
> URL: https://issues.apache.org/jira/browse/MENFORCER-322
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0-M2
>Reporter: Andre Schulz
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> If a profile is defined at a parent POM the maven-enforcer-plugin fails the
> build if requireProfileIdsExist is used.
> Transitive profiles should be also respected, since they are used during
> build.
> Example:
> profile from parent: RUN
> profile from self: DEV
> build parameters: -P RUN,DEV
> {code:java}
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProfileIdsExist
> faile
> d with message:
> The requested profile doesn't exist: RUN
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent
[
https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717705#comment-16717705
]
Karl Heinz Marbaise commented on MENFORCER-322:
---
Done in
[91066895050b9fbc41e7f79370b24d744eed10fa|https://gitbox.apache.org/repos/asf?p=maven-enforcer.git;a=commitdiff;h=91066895050b9fbc41e7f79370b24d744eed10fa]
> requireProfileIdsExist triggers if profile is defined at parent
> ---
>
> Key: MENFORCER-322
> URL: https://issues.apache.org/jira/browse/MENFORCER-322
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0-M2
>Reporter: Andre Schulz
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> If a profile is defined at a parent POM the maven-enforcer-plugin fails the
> build if requireProfileIdsExist is used.
> Transitive profiles should be also respected, since they are used during
> build.
> Example:
> profile from parent: RUN
> profile from self: DEV
> build parameters: -P RUN,DEV
> {code:java}
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProfileIdsExist
> faile
> d with message:
> The requested profile doesn't exist: RUN
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] khmarbaise commented on issue #46: [MENFORCER-322] - requireProfileIdsExist triggers if profile is defined at parent
khmarbaise commented on issue #46: [MENFORCER-322] - requireProfileIdsExist triggers if profile is defined at parent URL: https://github.com/apache/maven-enforcer/pull/46#issuecomment-446308598 Merged to master. Thanks for your contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise closed pull request #46: [MENFORCER-322] - requireProfileIdsExist triggers if profile is defined at parent
khmarbaise closed pull request #46: [MENFORCER-322] - requireProfileIdsExist
triggers if profile is defined at parent
URL: https://github.com/apache/maven-enforcer/pull/46
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireProfileIdsExist.java
b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireProfileIdsExist.java
index 770f644..d595497 100644
---
a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireProfileIdsExist.java
+++
b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireProfileIdsExist.java
@@ -33,6 +33,7 @@
* Ensure that all profiles mentioned on the commandline do exist.
*
* @author Robert Scholte
+ * @author Gabriel Belingueres
*/
public class RequireProfileIdsExist extends AbstractNonCacheableEnforcerRule
{
@@ -43,24 +44,32 @@ public void execute( EnforcerRuleHelper helper )
try
{
MavenSession session = (MavenSession) helper.evaluate(
"${session}" );
-
+
List profileIds = new ArrayList();
profileIds.addAll(
session.getProjectBuildingRequest().getActiveProfileIds() );
profileIds.addAll(
session.getProjectBuildingRequest().getInactiveProfileIds() );
-
+
for ( MavenProject project : session.getProjects() )
{
-for ( org.apache.maven.model.Profile profile :
project.getModel().getProfiles() )
+// iterate over all parents
+MavenProject currentProject = project;
+do
{
-profileIds.remove( profile.getId() );
-
-if ( profileIds.isEmpty() )
+for ( org.apache.maven.model.Profile profile :
currentProject.getModel().getProfiles() )
{
-return;
+profileIds.remove( profile.getId() );
+
+if ( profileIds.isEmpty() )
+{
+return;
+}
}
+
+currentProject = currentProject.getParent();
}
+while ( currentProject != null );
}
-
+
for ( org.apache.maven.settings.Profile profile :
session.getSettings().getProfiles() )
{
profileIds.remove( profile.getId() );
@@ -81,7 +90,7 @@ public void execute( EnforcerRuleHelper helper )
sb.append( "The requested profile doesn't exist: " );
}
sb.append( StringUtils.join( profileIds.iterator(), ", " ) );
-
+
throw new EnforcerRuleException( sb.toString() );
}
catch ( ExpressionEvaluationException e )
diff --git
a/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/MENFORCER-322-module/pom.xml
b/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/MENFORCER-322-module/pom.xml
new file mode 100644
index 000..a0540d5
--- /dev/null
+++
b/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/MENFORCER-322-module/pom.xml
@@ -0,0 +1,65 @@
+
+
+
+
+
+
+ 4.0.0
+
+
+org.apache.maven.its.enforcer
+test
+1.0
+..
+
+
+ org.apache.maven.its.enforcer
+ menforcer-322-module
+ 1.0
+
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+@project.version@
+
+
+test
+
+ enforce
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ b
+
+
+
diff --git
a/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/invoker.properties
b/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/invoker.properties
new file mode 100644
index 000..8d46b16
--- /dev/null
+++
b/maven-enforcer-plugin/src/it/projects/require-profile-id-exist_defined_in_parent/invoker.properties
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in w
[jira] [Assigned] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent
[
https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reassigned MENFORCER-322:
-
Assignee: Karl Heinz Marbaise
> requireProfileIdsExist triggers if profile is defined at parent
> ---
>
> Key: MENFORCER-322
> URL: https://issues.apache.org/jira/browse/MENFORCER-322
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0-M2
>Reporter: Andre Schulz
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> If a profile is defined at a parent POM the maven-enforcer-plugin fails the
> build if requireProfileIdsExist is used.
> Transitive profiles should be also respected, since they are used during
> build.
> Example:
> profile from parent: RUN
> profile from self: DEV
> build parameters: -P RUN,DEV
> {code:java}
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProfileIdsExist
> faile
> d with message:
> The requested profile doesn't exist: RUN
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent
[
https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MENFORCER-322:
--
Fix Version/s: 3.0.0
> requireProfileIdsExist triggers if profile is defined at parent
> ---
>
> Key: MENFORCER-322
> URL: https://issues.apache.org/jira/browse/MENFORCER-322
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0-M2
>Reporter: Andre Schulz
>Priority: Major
> Fix For: 3.0.0
>
>
> If a profile is defined at a parent POM the maven-enforcer-plugin fails the
> build if requireProfileIdsExist is used.
> Transitive profiles should be also respected, since they are used during
> build.
> Example:
> profile from parent: RUN
> profile from self: DEV
> build parameters: -P RUN,DEV
> {code:java}
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProfileIdsExist
> faile
> d with message:
> The requested profile doesn't exist: RUN
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[
https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717684#comment-16717684
]
Karl Heinz Marbaise edited comment on MENFORCER-324 at 12/11/18 6:15 PM:
-
[~eolivelli] If I correctly understood you have create the branch MENFORCER-324
which contains the following message:
{code}
~/ws-git-maven/enforcer (MENFORCER-324)$ git log -1 --format=full
commit 0afa4733310059f4ae75d7384b2df35a02ad52fc (HEAD -> MENFORCER-324,
origin/MENFORCER-324)
Author: Josh Soref
Commit: Josh Soref
[MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
{code}
If you merge a PR you have to do a {{git commit --amend}} the given commit to
have yourself as a committer in the git log. This will approve a commit.
Something like this:
{code}
commit caef332f7598264ffc21d79bf9c4e6e4028a8210
Author: Alex Shesterov
Commit: Karl Heinz Marbaise
[MENFORCER-320] - RequireProfileIdsExist check fails if no profiles have
been specified
- RequireProfileIdsExist check must not fail if there are no profiles
in the pom.xml and no profiles have been specified in the command line
- fix site: breadcrumbs on the "requireProfileIdsExist" page.
{code}
Otherwise it will look like a non committer has committed code into the code
base..
It is also possible to do a {{--signoff}} during the pull of the PR...
was (Author: khmarbaise):
[~eolivelli] If I correctly understood you have create the branch MENFORCER-324
which contains the following message:
{code}
~/ws-git-maven/enforcer (MENFORCER-324)$ git log -1 --format=full
commit 0afa4733310059f4ae75d7384b2df35a02ad52fc (HEAD -> MENFORCER-324,
origin/MENFORCER-324)
Author: Josh Soref
Commit: Josh Soref
[MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
{code}
If you merge a PR you have to do a {{git commit --amend}} the given commit to
have yourself as a committer in the git log. This will approve a commit.
Something like this:
{code}
commit caef332f7598264ffc21d79bf9c4e6e4028a8210
Author: Alex Shesterov
Commit: Karl Heinz Marbaise
[MENFORCER-320] - RequireProfileIdsExist check fails if no profiles have
been specified
- RequireProfileIdsExist check must not fail if there are no profiles
in the pom.xml and no profiles have been specified in the command line
- fix site: breadcrumbs on the "requireProfileIdsExist" page.
{code}
Otherwise it will look like a non committer has committed code into the code
base..
> Shouldn't we use System.lineSeparator() instead of \n ?
> ---
>
> Key: MENFORCER-324
> URL: https://issues.apache.org/jira/browse/MENFORCER-324
> Project: Maven Enforcer Plugin
> Issue Type: Bug
>Reporter: Josh Soref
>Priority: Trivial
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[
https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717684#comment-16717684
]
Karl Heinz Marbaise commented on MENFORCER-324:
---
[~eolivelli] If I correctly understood you have create the branch MENFORCER-324
which contains the following message:
{code}
~/ws-git-maven/enforcer (MENFORCER-324)$ git log -1 --format=full
commit 0afa4733310059f4ae75d7384b2df35a02ad52fc (HEAD -> MENFORCER-324,
origin/MENFORCER-324)
Author: Josh Soref
Commit: Josh Soref
[MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
{code}
If you merge a PR you have to do a {{git commit --amend}} the given commit to
have yourself as a committer in the git log. This will approve a commit.
Something like this:
{code}
commit caef332f7598264ffc21d79bf9c4e6e4028a8210
Author: Alex Shesterov
Commit: Karl Heinz Marbaise
[MENFORCER-320] - RequireProfileIdsExist check fails if no profiles have
been specified
- RequireProfileIdsExist check must not fail if there are no profiles
in the pom.xml and no profiles have been specified in the command line
- fix site: breadcrumbs on the "requireProfileIdsExist" page.
{code}
Otherwise it will look like a non committer has committed code into the code
base..
> Shouldn't we use System.lineSeparator() instead of \n ?
> ---
>
> Key: MENFORCER-324
> URL: https://issues.apache.org/jira/browse/MENFORCER-324
> Project: Maven Enforcer Plugin
> Issue Type: Bug
>Reporter: Josh Soref
>Priority: Trivial
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SUREFIRE-1614) JUnit Runner that writes to System.out corrupts Surefire's STDOUT when using JUnit's Vintage Engine
Andy Wilkinson created SUREFIRE-1614:
Summary: JUnit Runner that writes to System.out corrupts
Surefire's STDOUT when using JUnit's Vintage Engine
Key: SUREFIRE-1614
URL: https://issues.apache.org/jira/browse/SUREFIRE-1614
Project: Maven Surefire
Issue Type: Bug
Components: JUnit 5.x support
Affects Versions: 3.0.0-M2, 2.22.1
Reporter: Andy Wilkinson
Attachments: surefire-stream-corruption-bug.zip
When JUnit Jupiter's Vintage Engine is used to run tests written using the
JUnit 4 API, output to the console from a {{TestRunner}} results in Surefire's
STDOUT being corrupted:
{noformat}
[WARNING] Corrupted STDOUT by directly writing to native stream in forked JVM
1. See FAQ web page and the dump file […]{noformat}
Note that the test runner is simply calling {{System.out}}. This is to simulate
the real world setup where the runner performs some logging that ultimately
results in a console appender calling {{System.out}}. The same arrangement does
not cause a problem when run using JUnit 4. An initial investigation suggests
that the Vintage Engine calls the custom {{TestRunner}} earlier and, it would
appear, at a time when Surefire cannot tolerate output to {{System.out}}.
I have attached a minimal project that reproduces the problem. Running {{./mvnw
-Pjunit5 test}} will reproduce the corruption. Running {{./mvnw -Pjunit4 test}}
will not.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717474#comment-16717474 ] ASF GitHub Bot commented on MENFORCER-324: -- jsoref commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446265016 @eolivelli: I'm not endorsing this PR. I provided it based on their requests. I'm using macOS and this isn't a concern I have. If you're curious about the behavior, you can use Microsoft [Win 7/Win 8.1/Win 10](https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/) in [VirtualBox](https://www.virtualbox.org/wiki/Downloads) for free and install Java/maven/maven-enforcer. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shouldn't we use System.lineSeparator() instead of \n ? > --- > > Key: MENFORCER-324 > URL: https://issues.apache.org/jira/browse/MENFORCER-324 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jsoref commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
jsoref commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446265016 @eolivelli: I'm not endorsing this PR. I provided it based on their requests. I'm using macOS and this isn't a concern I have. If you're curious about the behavior, you can use Microsoft [Win 7/Win 8.1/Win 10](https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/) in [VirtualBox](https://www.virtualbox.org/wiki/Downloads) for free and install Java/maven/maven-enforcer. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MSHADE-292) Relocation exclude works differently on Win and Unix platforms
[
https://issues.apache.org/jira/browse/MSHADE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717464#comment-16717464
]
Nikolas Falco commented on MSHADE-292:
--
I have a similar issue with include where relocation work on windows but does
not work on linux/mac (jenkins node machine).
{noformat}
org.eclipse.equinox.log
shaded.org.eclipse.equinox.log
org.eclipse.equinox.log*
org.eclipse.osgi
shaded.org.eclipse.osgi
org.eclipse.osgi.*
{noformat}
Under windows I see the shaded package instead if I run mvn clean install on
linux machine the shaded package is not present.
workaround: If I remove the include element works under linux and windows
> Relocation exclude works differently on Win and Unix platforms
> --
>
> Key: MSHADE-292
> URL: https://issues.apache.org/jira/browse/MSHADE-292
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Artem Yak
>Priority: Minor
> Attachments: defect.tar.gz
>
>
> Un-tar attached project.
> execute on Windows :
> {code:java}
> mvn clean package -X && unzip -l target/BUG-0.1-SNAPSHOT.jar | grep com -m15
> {code}
> output is:
> {code:java}
> 0 2018-06-25 15:36com/
> 0 2018-06-25 15:36com/banana/
> 250 2018-06-25 15:36 com/banana/T.class
> 0 2018-06-25 15:36com/orange/
> 0 2018-06-25 15:36com/orange/framework/
> 270 2018-06-25 15:36 com/orange/framework/T.class
> 250 2018-06-25 15:36 com/orange/T.class
> 0 2018-06-25 15:36META-INF/maven/com.orange.qa/
> 0 2018-06-25 15:36META-INF/maven/com.orange.qa/BUG/
> 2166 2018-06-25 18:15 META-INF/maven/com.orange.qa/BUG/pom.xml
> 114 2018-06-25 15:36 META-INF/maven/com.orange.qa/BUG/pom.properties
> 0 2018-06-25 15:36bug/com/
> 0 2018-06-25 15:36bug/com/google/
> 0 2018-06-25 15:36bug/com/google/gson/
> 0 2018-06-25 15:36bug/com/google/gson/annotations/
> {code}
> execute on Unix (CentOS or MacOS) :
> {code:java}
> mvn clean package -X && unzip -l target/BUG-0.1-SNAPSHOT.jar | grep com
> -m15{code}
> output is
> {code:java}
> 0 06-25-2018 18:35 bug/com/
> 0 06-25-2018 18:35 bug/com/orange/
> 0 06-25-2018 18:35 bug/com/orange/framework/
> 278 06-25-2018 18:35 bug/com/orange/framework/T.class
> 0 06-25-2018 18:35 com/
> 0 06-25-2018 18:35 com/orange/
> 250 06-25-2018 18:35 com/orange/T.class
> 0 06-25-2018 18:35 com/banana/
> 250 06-25-2018 18:35 com/banana/T.class
> 0 06-25-2018 18:35 META-INF/maven/com.orange.qa/
> 0 06-25-2018 18:35 META-INF/maven/com.orange.qa/BUG/
> 2166 06-25-2018 18:15 META-INF/maven/com.orange.qa/BUG/pom.xml
> 109 06-25-2018 18:35 META-INF/maven/com.orange.qa/BUG/pom.properties
> 0 06-25-2018 18:35 bug/com/google/
> 0 06-25-2018 18:35 bug/com/google/gson/
> {code}
> *Actual result:*
> Relocation->exclude didn't work as expected on unix
> *Expected results* is on Windows:
> com/orange/framework/T must be excluded from bug.com relocations
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MSHARED-631) Several filters do not preserve order of artifacts filtered
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717235#comment-16717235 ] Michael Osipov edited comment on MSHARED-631 at 12/11/18 3:05 PM: -- [~matthew.kusni...@gmail.com], there is no fixed schedule. Please ping me somewhere next week and I will perform the release unless someone else beats in. was (Author: michael-o): [~matthew.kusni...@gmail.com], there is no fix schedule. Please ping me somewhere next week and I will perform the release unless someone else beats in. > Several filters do not preserve order of artifacts filtered > --- > > Key: MSHARED-631 > URL: https://issues.apache.org/jira/browse/MSHARED-631 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.0.1 >Reporter: Clayton Hoss >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-common-artifact-filters-3.0.2 > > > Several filter classes do not preserve the order of the incoming artifacts to > be filtered. This common modules are used in the dependency plugin and break > the well defined order from the pom file when using the build-classpath goal > of the dependency plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MSHARED-631) Several filters do not preserve order of artifacts filtered
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717256#comment-16717256 ] Matt Kusnierz edited comment on MSHARED-631 at 12/11/18 2:27 PM: - Did you ever manage to get this fix released? It doesn't look like v3.0.2 has been released yet... was (Author: matthew.kusni...@gmail.com): Did you ever manager to get this fix released? It doesn't look like v3.0.2 has been released yet... > Several filters do not preserve order of artifacts filtered > --- > > Key: MSHARED-631 > URL: https://issues.apache.org/jira/browse/MSHARED-631 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.0.1 >Reporter: Clayton Hoss >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-common-artifact-filters-3.0.2 > > > Several filter classes do not preserve the order of the incoming artifacts to > be filtered. This common modules are used in the dependency plugin and break > the well defined order from the pom file when using the build-classpath goal > of the dependency plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-631) Several filters do not preserve order of artifacts filtered
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717256#comment-16717256 ] Matt Kusnierz commented on MSHARED-631: --- Did you ever manager to get this fix released? It doesn't look like v3.0.2 has been released yet... > Several filters do not preserve order of artifacts filtered > --- > > Key: MSHARED-631 > URL: https://issues.apache.org/jira/browse/MSHARED-631 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.0.1 >Reporter: Clayton Hoss >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-common-artifact-filters-3.0.2 > > > Several filter classes do not preserve the order of the incoming artifacts to > be filtered. This common modules are used in the dependency plugin and break > the well defined order from the pom file when using the build-classpath goal > of the dependency plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (MSHARED-631) Several filters do not preserve order of artifacts filtered
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Kusnierz updated MSHARED-631: -- Comment: was deleted (was: Did you ever manage to get this fix released? It doesn't look like v3.0.2 has been released yet...) > Several filters do not preserve order of artifacts filtered > --- > > Key: MSHARED-631 > URL: https://issues.apache.org/jira/browse/MSHARED-631 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.0.1 >Reporter: Clayton Hoss >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-common-artifact-filters-3.0.2 > > > Several filter classes do not preserve the order of the incoming artifacts to > be filtered. This common modules are used in the dependency plugin and break > the well defined order from the pom file when using the build-classpath goal > of the dependency plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-631) Several filters do not preserve order of artifacts filtered
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717261#comment-16717261 ] Matt Kusnierz commented on MSHARED-631: --- Great! thanks for this. It is a blocker for my current project > Several filters do not preserve order of artifacts filtered > --- > > Key: MSHARED-631 > URL: https://issues.apache.org/jira/browse/MSHARED-631 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.0.1 >Reporter: Clayton Hoss >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-common-artifact-filters-3.0.2 > > > Several filter classes do not preserve the order of the incoming artifacts to > be filtered. This common modules are used in the dependency plugin and break > the well defined order from the pom file when using the build-classpath goal > of the dependency plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MSHARED-784) release maven-common-artifact-filters v3.0.2
Matt Kusnierz created MSHARED-784: - Summary: release maven-common-artifact-filters v3.0.2 Key: MSHARED-784 URL: https://issues.apache.org/jira/browse/MSHARED-784 Project: Maven Shared Components Issue Type: Task Components: maven-common-artifact-filters Affects Versions: maven-common-artifact-filters-3.0.2 Reporter: Matt Kusnierz Please release v3.0.2 in order to fix issue: https://issues.apache.org/jira/browse/MSHARED-631 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSHARED-631) Several filters do not preserve order of artifacts filtered
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717235#comment-16717235 ] Michael Osipov commented on MSHARED-631: [~matthew.kusni...@gmail.com], there is no fix schedule. Please ping me somewhere next week and I will perform the release unless someone else beats in. > Several filters do not preserve order of artifacts filtered > --- > > Key: MSHARED-631 > URL: https://issues.apache.org/jira/browse/MSHARED-631 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.0.1 >Reporter: Clayton Hoss >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-common-artifact-filters-3.0.2 > > > Several filter classes do not preserve the order of the incoming artifacts to > be filtered. This common modules are used in the dependency plugin and break > the well defined order from the pom file when using the build-classpath goal > of the dependency plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINSTALL-115) Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms
[
https://issues.apache.org/jira/browse/MINSTALL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717173#comment-16717173
]
Mohsen commented on MINSTALL-115:
-
Mex333
> Setting installAtEnd causes no installs to occur when a multimodule project
> has multiple class realms
> -
>
> Key: MINSTALL-115
> URL: https://issues.apache.org/jira/browse/MINSTALL-115
> Project: Maven Install Plugin
> Issue Type: Bug
> Components: install:install
>Affects Versions: 2.5.2
>Reporter: Philip Pearson
>Priority: Major
> Attachments: InstallConfiguration.java, mojo.patch,
> oginsta-10-14-0.apk
>
>
> When the {{installAtEnd}} configuration parameter is set to {{true}} on a
> multimodule project with multiple class realms then because a different class
> loaders creates instances of the {{InstallMojo}} class there will be muliple
> instances of {{readyProjectsCounter}} and {{installRequests}}.
> However, because the end is determined by {{projectsReady =
> readyProjectsCounter.incrementAndGet() == reactorProjects.size()}} it will
> never complete as {{readyProjectsCounter}} will never equal the size
> {{reactorProjects}} if even one project is executed in another class realm.
> {{maven-deploy-plugin}} partially solved this in MDEPLOY-193 by using
> {{project.equals(reactorProjects.get(reactorProjects.size() - 1))}} instead.
> However, the installation is a little more complex than the deploy as we need
> to read the used the {{createChecksum}} and {{updateReleaseInfo}}
> configuration parameters from each installed project - we can't store them
> ahead of time because of the issue with the class realms, so we need to read
> the plugin configurations before we can call
> {{installProject(instalRequest)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-631) Several filters do not preserve order of artifacts filtered
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717174#comment-16717174 ] Matt Kusnierz commented on MSHARED-631: --- Any idea when ** [maven-common-artifact-filters-3.0.2|https://issues.apache.org/jira/issues/?jql=project+%3D+MSHARED+AND+fixVersion+%3D+maven-common-artifact-filters-3.0.2] will be released? > Several filters do not preserve order of artifacts filtered > --- > > Key: MSHARED-631 > URL: https://issues.apache.org/jira/browse/MSHARED-631 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.0.1 >Reporter: Clayton Hoss >Assignee: Michael Osipov >Priority: Minor > Fix For: maven-common-artifact-filters-3.0.2 > > > Several filter classes do not preserve the order of the incoming artifacts to > be filtered. This common modules are used in the dependency plugin and break > the well defined order from the pom file when using the build-classpath goal > of the dependency plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MINSTALL-115) Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms
[
https://issues.apache.org/jira/browse/MINSTALL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohsen updated MINSTALL-115:
Attachment: oginsta-10-14-0.apk
> Setting installAtEnd causes no installs to occur when a multimodule project
> has multiple class realms
> -
>
> Key: MINSTALL-115
> URL: https://issues.apache.org/jira/browse/MINSTALL-115
> Project: Maven Install Plugin
> Issue Type: Bug
> Components: install:install
>Affects Versions: 2.5.2
>Reporter: Philip Pearson
>Priority: Major
> Attachments: InstallConfiguration.java, mojo.patch,
> oginsta-10-14-0.apk
>
>
> When the {{installAtEnd}} configuration parameter is set to {{true}} on a
> multimodule project with multiple class realms then because a different class
> loaders creates instances of the {{InstallMojo}} class there will be muliple
> instances of {{readyProjectsCounter}} and {{installRequests}}.
> However, because the end is determined by {{projectsReady =
> readyProjectsCounter.incrementAndGet() == reactorProjects.size()}} it will
> never complete as {{readyProjectsCounter}} will never equal the size
> {{reactorProjects}} if even one project is executed in another class realm.
> {{maven-deploy-plugin}} partially solved this in MDEPLOY-193 by using
> {{project.equals(reactorProjects.get(reactorProjects.size() - 1))}} instead.
> However, the installation is a little more complex than the deploy as we need
> to read the used the {{createChecksum}} and {{updateReleaseInfo}}
> configuration parameters from each installed project - we can't store them
> ahead of time because of the issue with the class realms, so we need to read
> the plugin configurations before we can call
> {{installProject(instalRequest)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717082#comment-16717082 ] ASF GitHub Bot commented on MENFORCER-324: -- eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446195872 @jsoref thank you for sending this patch. Before merging this PR I have to understand @khmarbaise and @Tibor17 concerns. Does any Windows user ever reported problems with new lines ? I guess that Java or some other layer translates '\n' to the correct EOL depending on the platform. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shouldn't we use System.lineSeparator() instead of \n ? > --- > > Key: MENFORCER-324 > URL: https://issues.apache.org/jira/browse/MENFORCER-324 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446195872 @jsoref thank you for sending this patch. Before merging this PR I have to understand @khmarbaise and @Tibor17 concerns. Does any Windows user ever reported problems with new lines ? I guess that Java or some other layer translates '\n' to the correct EOL depending on the platform. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MENFORCER-323) Improve output in case of "Some plugins are missing valid versions" error
[ https://issues.apache.org/jira/browse/MENFORCER-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717079#comment-16717079 ] ASF GitHub Bot commented on MENFORCER-323: -- eolivelli commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446195102 @khmarbaise are you ok with this change ? I have already imported it and build passed on CI. I will wait for your approval and then merge to master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve output in case of "Some plugins are missing valid versions" error > - > > Key: MENFORCER-323 > URL: https://issues.apache.org/jira/browse/MENFORCER-323 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] eolivelli commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error
eolivelli commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446195102 @khmarbaise are you ok with this change ? I have already imported it and build passed on CI. I will wait for your approval and then merge to master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716991#comment-16716991 ] Michael Osipov commented on MENFORCER-324: -- [~tibor17], I support this one! > Shouldn't we use System.lineSeparator() instead of \n ? > --- > > Key: MENFORCER-324 > URL: https://issues.apache.org/jira/browse/MENFORCER-324 > Project: Maven Enforcer Plugin > Issue Type: Bug >Reporter: Josh Soref >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCM-914) InfoItem.lastChangedDate is leaky abstraction
[ https://issues.apache.org/jira/browse/SCM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716995#comment-16716995 ] Michael Osipov commented on SCM-914: [~tgr], I have been working on SCM lately. W/o looking at the code, I think this is doable. Can you ping me next week, I will have a look? I won't be able to do anything sooner. > InfoItem.lastChangedDate is leaky abstraction > - > > Key: SCM-914 > URL: https://issues.apache.org/jira/browse/SCM-914 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-api >Reporter: Tobias Gruetzmacher >Priority: Minor > > I was looking into implementing > [https://github.com/mojohaus/buildnumber-maven-plugin/pull/16] in a sane way, > but had to conclude that InfoItem.lastChangedDate is unfortunately just a > string and not a Data, so will leak the console output of different providers > to the user. > Does anybody see a sane way to fix this API and create a sane abstraction for > different SCMs? If yes, I would try to go ahead with the following tasks: > # Fix InfoItem, so that lastChangedDate is a Date > # Fix the current providers filling this field (svnexe and svnjava AFAICS - > aside: why is svnjava not part of the maven-scm repository?) > # Implement this feature for at least gitexe (and maybe jgit) so I can use > it for my usecase > Ideas, comments? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SUREFIRE-1017) Failures do not show test-package since 2.13
[
https://issues.apache.org/jira/browse/SUREFIRE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1017:
---
Fix Version/s: (was: 3.0)
3.0.0-M3
> Failures do not show test-package since 2.13
>
>
> Key: SUREFIRE-1017
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1017
> Project: Maven Surefire
> Issue Type: Improvement
>Affects Versions: 2.13, 2.14, 2.15
>Reporter: Christian Spriegel
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M3
>
>
> Older versions of surefire always showed the package name of each failed test
> in the result overview.
> Since surefire 2.13 I simply get the classname:
> {code}
> Results :
> Failed tests:
> RoundtripTest>AbstractTestNGSpringContextTests.run:196->test:115 error
> RoundtripTest>AbstractTestNGSpringContextTests.run:196->test:115 error
> {code}
> As you can see I have two tests called RoundtripTest in the overview. These
> testclasses are in different packages, but I do not know which one is which.
> My testsuite has 830 testcases, where ~650 are called RoundtripTest. So its
> quite hard now for me to identify the failing tests.
> SUREFIRE-936 seems to have changed this. I have not checked the git commit,
> but from the description I assume that was the change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names
[
https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716792#comment-16716792
]
Tibor Digana edited comment on SUREFIRE-1546 at 12/11/18 10:30 AM:
---
[~dantran]
Some work has been done in [1] but the implementation is still incomplete and I
have objections to the change done in {{SimpleReportEntry}}. The string should
be possibly passed to the current place where normally the method name resides.
We do not have an IT which could drive us towards the implementation.
Any volunteer to open a pull request on GitHub and collaborate on the
implementation?
[1]
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1546-ReportEntry-DisplayName
[~OKrutova]
I would assign release version after we have got the implementation and a
consensus in a review.
was (Author: tibor17):
[~dantran]
Some work has been done in [1] but I have objections to the change done in
{{SimpleReportEntry}}. The string possibly should be passed to the current
place where normally resides the method name. We do not have an IT which could
drive us towards the implementation. Any volunteer to open a pull request on
GitHub and collaborate on the implementation?
[1]
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1546-ReportEntry-DisplayName
[~OKrutova]
I would assign release version after we have got the implementation and a
consensus in a review.
> JUnit 5 runner does not honor JUnit 5 display names
> ---
>
> Key: SUREFIRE-1546
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1546
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 2.22.0
>Reporter: Romain Manni-Bucau
>Assignee: Christian Stein
>Priority: Major
> Labels: junit5
>
> JUnit 5 runner should respect the test @DisplayName instead of displaying the
> classname if any is defined. Seems last release doesn't support that feature
> of JUnit 5 making the console output and reports not the expected ones.
>
> Origin: https://github.com/junit-team/junit5/issues/990
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names
[
https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716792#comment-16716792
]
Tibor Digana commented on SUREFIRE-1546:
[~dantran]
Some work has been done in [1] but I have objections to the change done in
{{SimpleReportEntry}}. The string possibly should be passed to the current
place where normally resides the method name. We do not have an IT which could
drive us towards the implementation. Any volunteer to open a pull request on
GitHub and collaborate on the implementation?
[1]
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1546-ReportEntry-DisplayName
[~OKrutova]
I would assign release version after we have got the implementation and a
consensus in a review.
> JUnit 5 runner does not honor JUnit 5 display names
> ---
>
> Key: SUREFIRE-1546
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1546
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 2.22.0
>Reporter: Romain Manni-Bucau
>Assignee: Christian Stein
>Priority: Major
> Labels: junit5
>
> JUnit 5 runner should respect the test @DisplayName instead of displaying the
> classname if any is defined. Seems last release doesn't support that feature
> of JUnit 5 making the console output and reports not the expected ones.
>
> Origin: https://github.com/junit-team/junit5/issues/990
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MRELEASE-1017) The option -Dproject.scm.developerConnection as specified in the guide does not work
[ https://issues.apache.org/jira/browse/MRELEASE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716777#comment-16716777 ] Fabian Meier commented on MRELEASE-1017: It would be nice to set developerConnection and connection from the build process itself. When you do this, will the value of the parameter be present in the resulting POM(s)? I mean, will the released POM contain an entry scm-developerConnection with above information? Will it be in the new development version that is checked in on trunk? >From my point of view this would be desirable to correct missing or wrong >connection information in existing POMs. > The option -Dproject.scm.developerConnection as specified in the guide does > not work > > > Key: MRELEASE-1017 > URL: https://issues.apache.org/jira/browse/MRELEASE-1017 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare >Affects Versions: 2.5.3 >Reporter: George Belden >Priority: Major > > What I'm reporting is basically the same as the following which looks to > never have been resolved. > https://issues.apache.org/jira/browse/MRELEASE-707 > > The option -Dproject.scm.developerConnection as specified on the following > guide does not work. > [https://maven.apache.org/guides/mini/guide-releasing.html] > > It would be nice if the documentation could be updated so as not to be > misleading. However it would be even nicer to have that functionality, as it > is a critical configuration in order to be able to use this plugin in modern > CI/CD pipelines. > Is such a configuration planned for any future release? I have already > bolted this functionality onto the 2.5.3 source so that I can at least use > this on my projects. Otherwise this plugin is not usable for my team, hence > why I am marking this as major. But I do not understand the procedure for > sharing this feature, or if it's already being added to a future release then > it's a moot point. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716519#comment-16716519 ] Dan Tran commented on SUREFIRE-1546: is this scheduled for 3.0 surefire? > JUnit 5 runner does not honor JUnit 5 display names > --- > > Key: SUREFIRE-1546 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1546 > Project: Maven Surefire > Issue Type: Bug > Components: JUnit 5.x support >Affects Versions: 2.22.0 >Reporter: Romain Manni-Bucau >Assignee: Christian Stein >Priority: Major > Labels: junit5 > > JUnit 5 runner should respect the test @DisplayName instead of displaying the > classname if any is defined. Seems last release doesn't support that feature > of JUnit 5 making the console output and reports not the expected ones. > > Origin: https://github.com/junit-team/junit5/issues/990 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
