[jira] [Commented] (MCOMPILER-359) plexus-java 0.9.10 causes a NullPointer in compiler-plugin 3.8.0

2019-04-25 Thread Taylor Born (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826679#comment-16826679
 ] 

Taylor Born commented on MCOMPILER-359:
---

I have the same issue with dependency type zip.
This zip was built in dependency by maven-assembly-plugin, format zip.
Contains no class files.

Waiting for release 3.8.1.

> plexus-java 0.9.10 causes a NullPointer in compiler-plugin 3.8.0
> 
>
> Key: MCOMPILER-359
> URL: https://issues.apache.org/jira/browse/MCOMPILER-359
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
> Environment: Windows 7
> JDK 10.0.2
> Maven 3.5.4
>Reporter: Marvin
>Priority: Major
> Attachments: plugintest.zip
>
>
> If {{}} contains a {{pom}} or {{war}} 
> this call:
>  {{moduleDescriptor = binaryParser.getModuleDescriptor( path );}}
>  throws an {{IOException}}:
>  {{zip END header not found}}
>  because the file is being treated as a jar file.
>  When the call returns to {{CompilerMojo.preparePaths()}} this call returns 
> {{null}}:
>  {{Throwable cause = pathException.getValue().getCause();}}
>  and the next line throws a {{NullPointerException}}:
>  {{while ( cause.getCause() != null )}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6647) NPE in DefaultReportingConverter

2019-04-25 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826662#comment-16826662
 ] 

Hervé Boutemy commented on MNG-6647:


ok, I did that late in the night, with 2 commits that I split in MNG-6636 and 
MNG-6644 but that I didn't test separately, and without unit tests = what will 
really be required, since there are useful corner cases
>From a user point of view, your case looks interesting since it's just empty 
>reporting sections in the whole inheritance

I'll take time to finish my fixes during the WE and will ping you

bq. I wonder if it's not also an issue in our tiles plugin and how we 
copy/merge models around maybe...
your plugin is not expected to be an extension, that tweaks Maven model 
internals during inheritance, isn't it?
I'll have a deep look, but I don't expect you can do anything at your level: I 
really did not see how the reportSet/reports construct is quite unique in the 
whole POM inheritance and input location tracking and the corner cases this 
involves

> NPE in DefaultReportingConverter
> 
>
> Key: MNG-6647
> URL: https://issues.apache.org/jira/browse/MNG-6647
> Project: Maven
>  Issue Type: Bug
>Reporter: Mark Derricutt
>Priority: Minor
>
> I discovered this NPE whilst running some integration tests for our 
> tiles-maven-plugin:
>  
> {noformat}[INFO] Scanning for projects...
> [INFO] --- tiles-maven-plugin: Injecting 1 tiles as intermediary parent 
> artifacts for com.test:reporting-tiletest...
> [INFO] Mixed 'com.test:reporting-tiletest:0.1.0' with tile 
> 'com.test:reporting-tiletest-tile:0.1.0' as its new parent.
> [INFO] Mixed 'com.test:reporting-tiletest-tile:0.1.0' with original parent 
> '(no parent)' as its new top level parent.
> [INFO] 
> [ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:498)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> Caused by: java.lang.NullPointerException
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)
>  at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)
>  at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)
>  at org.apache.maven.model.building.ModelBuilder$build$0.call (Unknown Source)
>  at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall 
> (CallSiteArray.java:47)
>  at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:116)
>  at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:136)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.thunkModelBuilder 
> (TilesMavenLifecycleParticipant.groovy:460)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.orchestrateMerge 
> (TilesMavenLifecycleParticipant.groovy:362)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.afterProjectsRead 
> (TilesMavenLifecycleParticipant.groovy:306)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at jav

[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI

2019-04-25 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826588#comment-16826588
 ] 

Hudson commented on MNG-6573:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6636 #3

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6636/3/

> Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
> --
>
> Key: MNG-6573
> URL: https://issues.apache.org/jira/browse/MNG-6573
> Project: Maven
>  Issue Type: Task
>  Components: Integration Tests
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, 
> 11, 12-ea, 13-ea.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6647) NPE in DefaultReportingConverter

2019-04-25 Thread Mark Derricutt (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826584#comment-16826584
 ] 

Mark Derricutt commented on MNG-6647:
-

[~hboutemy] - checking out that branch and rebuilding, I still seem to get the 
same failure in that one IT test - which can be seen via:

{{git clone g...@github.com:repaint-io/maven-tiles.git}}
{{cd maven-tiles}}
{{mvn clean install -Prun-its}}

On ModelMerger.java:1479 - sourceLocation is still null, and this seems to be 
tripping up on the "default" reportSet which includes dependencies, 
project-team, mailing-list etc. etc.

I wonder if it's not also an issue in our tiles plugin and how we copy/merge 
models around maybe...

 

> NPE in DefaultReportingConverter
> 
>
> Key: MNG-6647
> URL: https://issues.apache.org/jira/browse/MNG-6647
> Project: Maven
>  Issue Type: Bug
>Reporter: Mark Derricutt
>Priority: Minor
>
> I discovered this NPE whilst running some integration tests for our 
> tiles-maven-plugin:
>  
> {noformat}[INFO] Scanning for projects...
> [INFO] --- tiles-maven-plugin: Injecting 1 tiles as intermediary parent 
> artifacts for com.test:reporting-tiletest...
> [INFO] Mixed 'com.test:reporting-tiletest:0.1.0' with tile 
> 'com.test:reporting-tiletest-tile:0.1.0' as its new parent.
> [INFO] Mixed 'com.test:reporting-tiletest-tile:0.1.0' with original parent 
> '(no parent)' as its new top level parent.
> [INFO] 
> [ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:498)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> Caused by: java.lang.NullPointerException
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)
>  at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)
>  at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)
>  at org.apache.maven.model.building.ModelBuilder$build$0.call (Unknown Source)
>  at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall 
> (CallSiteArray.java:47)
>  at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:116)
>  at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:136)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.thunkModelBuilder 
> (TilesMavenLifecycleParticipant.groovy:460)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.orchestrateMerge 
> (TilesMavenLifecycleParticipant.groovy:362)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.afterProjectsRead 
> (TilesMavenLifecycleParticipant.groovy:306)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:498)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at o

[jira] [Commented] (MNG-6647) NPE in DefaultReportingConverter

2019-04-25 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826568#comment-16826568
 ] 

Hervé Boutemy commented on MNG-6647:


I really fixed the issue in MNG-6636 branch: can you check, please?

> NPE in DefaultReportingConverter
> 
>
> Key: MNG-6647
> URL: https://issues.apache.org/jira/browse/MNG-6647
> Project: Maven
>  Issue Type: Bug
>Reporter: Mark Derricutt
>Priority: Minor
>
> I discovered this NPE whilst running some integration tests for our 
> tiles-maven-plugin:
>  
> {noformat}[INFO] Scanning for projects...
> [INFO] --- tiles-maven-plugin: Injecting 1 tiles as intermediary parent 
> artifacts for com.test:reporting-tiletest...
> [INFO] Mixed 'com.test:reporting-tiletest:0.1.0' with tile 
> 'com.test:reporting-tiletest-tile:0.1.0' as its new parent.
> [INFO] Mixed 'com.test:reporting-tiletest-tile:0.1.0' with original parent 
> '(no parent)' as its new top level parent.
> [INFO] 
> [ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:498)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> Caused by: java.lang.NullPointerException
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)
>  at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)
>  at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)
>  at org.apache.maven.model.building.ModelBuilder$build$0.call (Unknown Source)
>  at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall 
> (CallSiteArray.java:47)
>  at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:116)
>  at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:136)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.thunkModelBuilder 
> (TilesMavenLifecycleParticipant.groovy:460)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.orchestrateMerge 
> (TilesMavenLifecycleParticipant.groovy:362)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.afterProjectsRead 
> (TilesMavenLifecycleParticipant.groovy:306)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:498)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347){noformat}
>  
> This was triggered when running our sitereporting test ( 
> [https://github.com/repaint-io/maven-tiles/tree/master/src/it/sitereporting-tiletest]
>  ) and doesn't trigger an NPE using Apache Maven 3.5.3, but does with the 
> current SNAPSHOT of 3.6.2.
> The problem lies when Maven is building the model from 
> [https://github.com/repaint-io/maven-tiles/blob/master/src/it/siter

[jira] [Commented] (MNG-6644) NPE in DefaultReportingConverter when reports has no InputLocation

2019-04-25 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826565#comment-16826565
 ] 

Hervé Boutemy commented on MNG-6644:


I just created MNG-6644 branch for your use case, which is not the same as 
MNG-6636
can you check it works for you, please?

> NPE in DefaultReportingConverter when reports has no InputLocation
> --
>
> Key: MNG-6644
> URL: https://issues.apache.org/jira/browse/MNG-6644
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Robert Thornton
>Priority: Major
> Attachments: maven-3.6.1-reporting-bug.zip
>
>
> After upgrading from Maven 3.6.0 to Maven 3.6.1, the attached project fails 
> with a NullPointerException.
> *This project uses the extension `io.takari.polyglot:polyglot-kotlin` in 
> order to build the Maven project model using a Kotlin script.*
> {code:java}
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.apache.maven.wrapper.BootstrapMainStarter.start 
> (BootstrapMainStarter.java:39)
> at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
> at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
> Caused by: java.lang.NullPointerException
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:616)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:385)
> at org.apache.maven.graph.DefaultGraphBuilder.collectProjects 
> (DefaultGraphBuilder.java:414)
> at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor 
> (DefaultGraphBuilder.java:405)
> at org.apache.maven.graph.DefaultGraphBuilder.build 
> (DefaultGraphBuilder.java:82)
> at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflec

[jira] [Updated] (MNG-6644) NPE in DefaultReportingConverter when reports has no InputLocation

2019-04-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6644:
---
Description: 
After upgrading from Maven 3.6.0 to Maven 3.6.1, the attached project fails 
with a NullPointerException.
*This project uses the extension `io.takari.polyglot:polyglot-kotlin` in order 
to build the Maven project model using a Kotlin script.*
{code:java}
org.apache.maven.InternalErrorException: Internal error: 
java.lang.NullPointerException
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.apache.maven.wrapper.BootstrapMainStarter.start 
(BootstrapMainStarter.java:39)
at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
Caused by: java.lang.NullPointerException
at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
(DefaultReportingConverter.java:243)
at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
(DefaultReportingConverter.java:213)
at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
(DefaultReportingConverter.java:140)
at org.apache.maven.model.building.DefaultModelBuilder.build 
(DefaultModelBuilder.java:479)
at org.apache.maven.model.building.DefaultModelBuilder.build 
(DefaultModelBuilder.java:432)
at org.apache.maven.project.DefaultProjectBuilder.build 
(DefaultProjectBuilder.java:616)
at org.apache.maven.project.DefaultProjectBuilder.build 
(DefaultProjectBuilder.java:385)
at org.apache.maven.graph.DefaultGraphBuilder.collectProjects 
(DefaultGraphBuilder.java:414)
at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor 
(DefaultGraphBuilder.java:405)
at org.apache.maven.graph.DefaultGraphBuilder.build 
(DefaultGraphBuilder.java:82)
at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.apache.maven.wrapper.BootstrapMainStarter.start 
(BootstrapMainStarter.java:39)
at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
{code}

  was:
After upgrading from Maven 3.6.0 to Maven 3.6.1, the attached project fails 
with a NullPointerException. This project uses the extension 
`io.takari.polyglot:polyglot-kotlin` in order to build the Maven project model 
using a Kotlin script.
{code:java}
org.apache.maven.InternalErrorException

[jira] [Reopened] (MNG-6644) NPE in DefaultReportingConverter when reports has no InputLocation

2019-04-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy reopened MNG-6644:


reopening: I'll need to check the final fix for MNG-6636 against your project, 
given its quite specific case

> NPE in DefaultReportingConverter when reports has no InputLocation
> --
>
> Key: MNG-6644
> URL: https://issues.apache.org/jira/browse/MNG-6644
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Robert Thornton
>Priority: Major
> Attachments: maven-3.6.1-reporting-bug.zip
>
>
> After upgrading from Maven 3.6.0 to Maven 3.6.1, the attached project fails 
> with a NullPointerException. This project uses the extension 
> `io.takari.polyglot:polyglot-kotlin` in order to build the Maven project 
> model using a Kotlin script.
> {code:java}
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.apache.maven.wrapper.BootstrapMainStarter.start 
> (BootstrapMainStarter.java:39)
> at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
> at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
> Caused by: java.lang.NullPointerException
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:616)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:385)
> at org.apache.maven.graph.DefaultGraphBuilder.collectProjects 
> (DefaultGraphBuilder.java:414)
> at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor 
> (DefaultGraphBuilder.java:405)
> at org.apache.maven.graph.DefaultGraphBuilder.build 
> (DefaultGraphBuilder.java:82)
> at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)

[jira] [Commented] (MNG-6644) NPE in DefaultReportingConverter when reports has no InputLocation

2019-04-25 Thread Robert Thornton (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826394#comment-16826394
 ] 

Robert Thornton commented on MNG-6644:
--

I tested against branch [https://github.com/apache/maven/tree/MNG-6636] and it 
fixes the issue.

> NPE in DefaultReportingConverter when reports has no InputLocation
> --
>
> Key: MNG-6644
> URL: https://issues.apache.org/jira/browse/MNG-6644
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Robert Thornton
>Priority: Major
> Attachments: maven-3.6.1-reporting-bug.zip
>
>
> After upgrading from Maven 3.6.0 to Maven 3.6.1, the attached project fails 
> with a NullPointerException. This project uses the extension 
> `io.takari.polyglot:polyglot-kotlin` in order to build the Maven project 
> model using a Kotlin script.
> {code:java}
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.apache.maven.wrapper.BootstrapMainStarter.start 
> (BootstrapMainStarter.java:39)
> at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
> at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
> Caused by: java.lang.NullPointerException
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:616)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:385)
> at org.apache.maven.graph.DefaultGraphBuilder.collectProjects 
> (DefaultGraphBuilder.java:414)
> at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor 
> (DefaultGraphBuilder.java:405)
> at org.apache.maven.graph.DefaultGraphBuilder.build 
> (DefaultGraphBuilder.java:82)
> at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImp

[jira] [Comment Edited] (MNG-6644) NPE in DefaultReportingConverter when reports has no InputLocation

2019-04-25 Thread Robert Thornton (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826359#comment-16826359
 ] 

Robert Thornton edited comment on MNG-6644 at 4/25/19 6:52 PM:
---

Although the fix for this issue might be the same as for MNG-6636, I don't 
believe this issue is necessarily a duplicate because the Maven model, in my 
case, is not being parsed from xml. Rather it is being created programmatically 
using the polykot-maven extension for kotlin, so InputLocation will always be 
null regardless of whether the list of reports is empty or not. For this 
reason, the workaround does not work for me, so I have to stay on Maven 3.6.0. 
But as long as the fix for MNG-6636 performs a null check of InputLocation, it 
should solve this issue.


was (Author: rptmaestro):
Although the fix for this issue might be the same as for MNG-6636, I don't 
believe this issue is necessarily a duplicate because the Maven model, in my 
case, is not being parsed from xml. Rather it is being created programmatically 
using the maven-polykot extension, so InputLocation will always be null 
regardless of whether the list of reports is empty or not. For this reason, the 
workaround does not work for me, so I have to stay on Maven 3.6.0. But as long 
as the fix for MNG-6636 performs a null check of InputLocation, it should solve 
this issue.

> NPE in DefaultReportingConverter when reports has no InputLocation
> --
>
> Key: MNG-6644
> URL: https://issues.apache.org/jira/browse/MNG-6644
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Robert Thornton
>Priority: Major
> Attachments: maven-3.6.1-reporting-bug.zip
>
>
> After upgrading from Maven 3.6.0 to Maven 3.6.1, the attached project fails 
> with a NullPointerException. This project uses the extension 
> `io.takari.polyglot:polyglot-kotlin` in order to build the Maven project 
> model using a Kotlin script.
> {code:java}
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.apache.maven.wrapper.BootstrapMainStarter.start 
> (BootstrapMainStarter.java:39)
> at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
> at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
> Caused by: java.lang.NullPointerException
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:616)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:385)
> at org.apache.maven.graph.DefaultGraphBuilder.collectProjects 
> (DefaultGraphBuilder.java:414)
> at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor 
> (DefaultGraphBuilder.java:405)
> at org.apache.maven.graph.DefaultGraphBuilder.build 
> (DefaultGraphBuilder.java:82)
> at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
> at org.apac

[jira] [Commented] (MNG-6644) NPE in DefaultReportingConverter when reports has no InputLocation

2019-04-25 Thread Robert Thornton (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826359#comment-16826359
 ] 

Robert Thornton commented on MNG-6644:
--

Although the fix for this issue might be the same as for MNG-6636, I don't 
believe this issue is necessarily a duplicate because the Maven model, in my 
case, is not being parsed from xml. Rather it is being created programmatically 
using the maven-polykot extension, so InputLocation will always be null 
regardless of whether the list of reports is empty or not. For this reason, the 
workaround does not work for me, so I have to stay on Maven 3.6.0. But as long 
as the fix for MNG-6636 performs a null check of InputLocation, it should solve 
this issue.

> NPE in DefaultReportingConverter when reports has no InputLocation
> --
>
> Key: MNG-6644
> URL: https://issues.apache.org/jira/browse/MNG-6644
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Robert Thornton
>Priority: Major
> Attachments: maven-3.6.1-reporting-bug.zip
>
>
> After upgrading from Maven 3.6.0 to Maven 3.6.1, the attached project fails 
> with a NullPointerException. This project uses the extension 
> `io.takari.polyglot:polyglot-kotlin` in order to build the Maven project 
> model using a Kotlin script.
> {code:java}
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.apache.maven.wrapper.BootstrapMainStarter.start 
> (BootstrapMainStarter.java:39)
> at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
> at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
> Caused by: java.lang.NullPointerException
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)
> at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)
> at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:616)
> at org.apache.maven.project.DefaultProjectBuilder.build 
> (DefaultProjectBuilder.java:385)
> at org.apache.maven.graph.DefaultGraphBuilder.collectProjects 
> (DefaultGraphBuilder.java:414)
> at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor 
> (DefaultGraphBuilder.java:405)
> at org.apache.maven.graph.DefaultGraphBuilder.build 
> (DefaultGraphBuilder.java:82)
> at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.cod

[jira] [Commented] (MNG-6647) NPE in DefaultReportingConverter

2019-04-25 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826272#comment-16826272
 ] 

Hervé Boutemy commented on MNG-6647:


probably like MNG-6644, it's a duplicate: written in the release notes 
https://maven.apache.org/docs/3.6.1/release-notes.html#Known_Issues, this is a 
known issue tracked as MNG-6636 and there is a workaround that should be easy 
to use

can you try the workaround and confirm this avoid the NPE?

and for sure, I need to work on MNG-6636 on 3.6.2-SNAPSHOT to not rely on the 
workaround...

> NPE in DefaultReportingConverter
> 
>
> Key: MNG-6647
> URL: https://issues.apache.org/jira/browse/MNG-6647
> Project: Maven
>  Issue Type: Bug
>Reporter: Mark Derricutt
>Priority: Minor
>
> I discovered this NPE whilst running some integration tests for our 
> tiles-maven-plugin:
>  
> {noformat}[INFO] Scanning for projects...
> [INFO] --- tiles-maven-plugin: Injecting 1 tiles as intermediary parent 
> artifacts for com.test:reporting-tiletest...
> [INFO] Mixed 'com.test:reporting-tiletest:0.1.0' with tile 
> 'com.test:reporting-tiletest-tile:0.1.0' as its new parent.
> [INFO] Mixed 'com.test:reporting-tiletest-tile:0.1.0' with original parent 
> '(no parent)' as its new top level parent.
> [INFO] 
> [ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:498)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> Caused by: java.lang.NullPointerException
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)
>  at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)
>  at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)
>  at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)
>  at org.apache.maven.model.building.ModelBuilder$build$0.call (Unknown Source)
>  at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall 
> (CallSiteArray.java:47)
>  at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:116)
>  at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:136)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.thunkModelBuilder 
> (TilesMavenLifecycleParticipant.groovy:460)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.orchestrateMerge 
> (TilesMavenLifecycleParticipant.groovy:362)
>  at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.afterProjectsRead 
> (TilesMavenLifecycleParticipant.groovy:306)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
>  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
>  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
>  at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>  at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke (Method.java:498)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>  at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347){noformat}
>  
> This was triggered when running our sitereporting test 

[jira] [Updated] (MNG-6647) NPE in DefaultReportingConverter

2019-04-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6647:
---
Description: 
I discovered this NPE whilst running some integration tests for our 
tiles-maven-plugin:

 

{noformat}[INFO] Scanning for projects...
[INFO] --- tiles-maven-plugin: Injecting 1 tiles as intermediary parent 
artifacts for com.test:reporting-tiletest...
[INFO] Mixed 'com.test:reporting-tiletest:0.1.0' with tile 
'com.test:reporting-tiletest-tile:0.1.0' as its new parent.
[INFO] Mixed 'com.test:reporting-tiletest-tile:0.1.0' with original parent '(no 
parent)' as its new top level parent.
[INFO] 
[ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: 
java.lang.NullPointerException
 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
 at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
 at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
 at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
 at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke (Method.java:498)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
 at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)
 at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: java.lang.NullPointerException
 at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
(DefaultReportingConverter.java:243)
 at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
(DefaultReportingConverter.java:213)
 at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
(DefaultReportingConverter.java:140)
 at org.apache.maven.model.building.DefaultModelBuilder.build 
(DefaultModelBuilder.java:479)
 at org.apache.maven.model.building.DefaultModelBuilder.build 
(DefaultModelBuilder.java:432)
 at org.apache.maven.model.building.ModelBuilder$build$0.call (Unknown Source)
 at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall 
(CallSiteArray.java:47)
 at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
(AbstractCallSite.java:116)
 at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
(AbstractCallSite.java:136)
 at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.thunkModelBuilder 
(TilesMavenLifecycleParticipant.groovy:460)
 at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.orchestrateMerge 
(TilesMavenLifecycleParticipant.groovy:362)
 at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.afterProjectsRead 
(TilesMavenLifecycleParticipant.groovy:306)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
 at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
 at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
 at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
 at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke (Method.java:498)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)
 at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
 at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)
 at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:347){noformat}

 

This was triggered when running our sitereporting test ( 
[https://github.com/repaint-io/maven-tiles/tree/master/src/it/sitereporting-tiletest]
 ) and doesn't trigger an NPE using Apache Maven 3.5.3, but does with the 
current SNAPSHOT of 3.6.2.

The problem lies when Maven is building the model from 
[https://github.com/repaint-io/maven-tiles/blob/master/src/it/sitereporting-tiletest/tile-tile/tile.xml#L35]
 and can be fixed by applying the patch found at 
[https://www.dropbox.com/s/9gficrmlgxl2jd0/0001-Fix-NPE-thrown-from-DefaultReportingConverter.patch?dl=0]
 (for some reason I could not attach the patch to the ticket).

 

  was:
I discovered this NPE whilst running some integration tests for our 
tiles-maven-plugin:

 

{{ O] Scanning for projects...}}
{{[INFO] --- tiles-maven-plugin: Injecting 1 tiles as intermediary parent 
artifacts for com.test:reporting-tiletest...}}
{{[INFO] Mixed 'com.test:reporting-tiletest:0.1.0

[jira] [Commented] (MJAVADOC-595) javadoc not found using java.home

2019-04-25 Thread Gordon Pettey (JIRA)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826259#comment-16826259
 ] 

Gordon Pettey commented on MJAVADOC-595:


I think the problem stems from commons-lang3 {{SystemUtils.getJavaHome()}} 
usage of {{getProperty("java.home")}} instead of {{getEnv("JAVA_HOME")}}, which 
are different (by "/jre") for pre-9 JDKs. The code quoted in the issue 
description appears to be a workaround for that.

> javadoc not found using java.home 
> --
>
> Key: MJAVADOC-595
> URL: https://issues.apache.org/jira/browse/MJAVADOC-595
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Oliver Lüttin
>Priority: Major
>
> When searching for the javadoc executable the plugin looks in 
> java.home/../bin.
> This doesn't work with ubuntu 18.10 and java-11-openjdk.
> Instead it should look at java.hom/bin where the javadoc executable is 
> located.
> Here's the code snippet from AbstactJavadocMojo:
> {code:java}
> 3720 private String getJavadocExecutable()
> 3721  throws IOException
> 3722  {
> ...
> 3768 else
> 3769  {
> 3770  javadocExe =
> 3771  new File( SystemUtils.getJavaHome() + File.separator + ".." +  
> File.separator + "bin", javadocCommand );
> 3772  }
> {code}
>  
> As workaround one could configure the executable in the pom.xml:
>  
> {code:java}
> 
> ${java.home}/bin/javadoc
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MNG-6648) Add command line parameters in 'mavenrc_pre' script

2019-04-25 Thread Alix Lourme (JIRA)
Alix Lourme created MNG-6648:


 Summary: Add command line parameters in 'mavenrc_pre' script
 Key: MNG-6648
 URL: https://issues.apache.org/jira/browse/MNG-6648
 Project: Maven
  Issue Type: Improvement
  Components: Command Line
Affects Versions: 3.6.1, 3.6.0
Reporter: Alix Lourme


Hello,

In some corner-case, you could have to run Maven with a custom {{JAVA_HOME}} 
(JDK v8, v11, ... even if it is evil some plugin can be impacted by JDK at 
runtime).

If it is per-project, [JVM and Command Line 
Options|https://maven.apache.org/docs/3.3.1/release-notes.html#JVM_and_Command_Line_Options]
 is not relevant and update {{JAVA_HOME}} each time in your environment could 
be boring.

A command line user-custom-parameter (ex : {{-Dmy.jdk=11}}) could be simple to 
achieve that.

A Maven script wrapper could be implemented for that, but it's like update the 
Maven distribution => evil.
The *mavenrc_pre* (MNGSITE-246) could be perfect for that feature !
But currently command line parameters are not used in script :(.

If parameters are used dor script call, sample for {{mvn.cmd}} (windows):
{code}
if exist "%USERPROFILE%\mavenrc_pre.cmd" call "%USERPROFILE%\mavenrc_pre.cmd %*"
{code}

It's allow any user customization, using Maven standards.

If relevant, I can provide PR.
Best regards



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MDEP-650) dependency:unpack doesn't seem to handle version ranges

2019-04-25 Thread Andy Lehane (JIRA)


[ 
https://issues.apache.org/jira/browse/MDEP-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826144#comment-16826144
 ] 

Andy Lehane commented on MDEP-650:
--

I've figured out how to create the unit tests now, so will create the pull 
request tomorrow.

> dependency:unpack doesn't seem to handle version ranges
> ---
>
> Key: MDEP-650
> URL: https://issues.apache.org/jira/browse/MDEP-650
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: unpack
>Affects Versions: 3.1.1
>Reporter: Andy Lehane
>Priority: Minor
>
> This call is a reopened version of MDEP-50.
>  
> I have a maven-dependency-plugin configuration of:
> {code:java}
> 
>   org.apache.maven.plugins
>   maven-dependency-plugin
>   
> 
>   unpack commons-lang example
>   process-resources
>   
> unpack
>   
>   
> 
>   
> commons-lang
> commons-lang
> [0,)
> jar
> true
> ${project.build.directory}/test
>   
> 
>   
> 
>   
> 
> {code}
> When this is run using maven 3.6.0 and the maven-dependency-plugin version 
> 3.1.1, the following error is produced:
>  
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:unpack (unpack commons-lang example) 
> @ MavenDependencyPluginTestBed ---
> [INFO] Configured Artifact: common-lang:commons-lang:[0,):jar
> Downloading from central-proxy: 
> http://internal-repo/repository/central/commons-lang/commons-lang/%5B0,)/commons-lang-%5B0,).pom
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] ---
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (MJAVADOC-595) javadoc not found using java.home

2019-04-25 Thread Dmitry Volodin (JIRA)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826083#comment-16826083
 ] 

Dmitry Volodin edited comment on MJAVADOC-595 at 4/25/19 1:58 PM:
--

[~rfscholte], looks like the reason, why it works fine since JDK 9 for most of 
the ITs, the explicit JAVA_HOME env variable definition. It it not defined, it 
unable to autodetect 'javadoc' path, and can't using 'javadoc' from the 
environment.

It must be 
{code:java}
SystemUtils.getJavaHome() + File.separator + "bin", javadocCommand
{code}


was (Author: dmvolod):
[~rfscholte], looks like the reason, why it works fine since JDK 9 for most of 
teh ITs, the explicit JAVA_HOME env variable definition. It it not defined, it 
unable to autodetect 'javadoc' path, and can't using 'javadoc' from the 
environment.

It must be 
{code:java}
SystemUtils.getJavaHome() + File.separator + "bin", javadocCommand
{code}

> javadoc not found using java.home 
> --
>
> Key: MJAVADOC-595
> URL: https://issues.apache.org/jira/browse/MJAVADOC-595
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Oliver Lüttin
>Priority: Major
>
> When searching for the javadoc executable the plugin looks in 
> java.home/../bin.
> This doesn't work with ubuntu 18.10 and java-11-openjdk.
> Instead it should look at java.hom/bin where the javadoc executable is 
> located.
> Here's the code snippet from AbstactJavadocMojo:
> {code:java}
> 3720 private String getJavadocExecutable()
> 3721  throws IOException
> 3722  {
> ...
> 3768 else
> 3769  {
> 3770  javadocExe =
> 3771  new File( SystemUtils.getJavaHome() + File.separator + ".." +  
> File.separator + "bin", javadocCommand );
> 3772  }
> {code}
>  
> As workaround one could configure the executable in the pom.xml:
>  
> {code:java}
> 
> ${java.home}/bin/javadoc
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (MJAVADOC-595) javadoc not found using java.home

2019-04-25 Thread Dmitry Volodin (JIRA)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826083#comment-16826083
 ] 

Dmitry Volodin edited comment on MJAVADOC-595 at 4/25/19 1:50 PM:
--

[~rfscholte], looks like the reason, why it works fine since JDK 9 for most of 
teh ITs, the explicit JAVA_HOME env variable definition. It it not defined, it 
unable to autodetect 'javadoc' path, and can't using 'javadoc' from the 
environment.

It must be 
{code:java}
SystemUtils.getJavaHome() + File.separator + "bin", javadocCommand
{code}


was (Author: dmvolod):
[~rfscholte], looks like the reason, why it works fine since JDK 9 for most of 
teh ITs, the explicit JAVA_HOME definition. It it not defined, it unable to 
autodetect 'javadoc' path, and can't using 'javadoc' from the environment.

It must be 
{code:java}
SystemUtils.getJavaHome() + File.separator + "bin", javadocCommand
{code}

> javadoc not found using java.home 
> --
>
> Key: MJAVADOC-595
> URL: https://issues.apache.org/jira/browse/MJAVADOC-595
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Oliver Lüttin
>Priority: Major
>
> When searching for the javadoc executable the plugin looks in 
> java.home/../bin.
> This doesn't work with ubuntu 18.10 and java-11-openjdk.
> Instead it should look at java.hom/bin where the javadoc executable is 
> located.
> Here's the code snippet from AbstactJavadocMojo:
> {code:java}
> 3720 private String getJavadocExecutable()
> 3721  throws IOException
> 3722  {
> ...
> 3768 else
> 3769  {
> 3770  javadocExe =
> 3771  new File( SystemUtils.getJavaHome() + File.separator + ".." +  
> File.separator + "bin", javadocCommand );
> 3772  }
> {code}
>  
> As workaround one could configure the executable in the pom.xml:
>  
> {code:java}
> 
> ${java.home}/bin/javadoc
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MJAVADOC-595) javadoc not found using java.home

2019-04-25 Thread Dmitry Volodin (JIRA)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826083#comment-16826083
 ] 

Dmitry Volodin commented on MJAVADOC-595:
-

[~rfscholte], looks like the reason, why it works fine since JDK 9 for most of 
teh ITs, the explicit JAVA_HOME definition. It it not defined, it unable to 
autodetect 'javadoc' path, and can't using 'javadoc' from the environment.

It must be 
{code:java}
SystemUtils.getJavaHome() + File.separator + "bin", javadocCommand
{code}

> javadoc not found using java.home 
> --
>
> Key: MJAVADOC-595
> URL: https://issues.apache.org/jira/browse/MJAVADOC-595
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Oliver Lüttin
>Priority: Major
>
> When searching for the javadoc executable the plugin looks in 
> java.home/../bin.
> This doesn't work with ubuntu 18.10 and java-11-openjdk.
> Instead it should look at java.hom/bin where the javadoc executable is 
> located.
> Here's the code snippet from AbstactJavadocMojo:
> {code:java}
> 3720 private String getJavadocExecutable()
> 3721  throws IOException
> 3722  {
> ...
> 3768 else
> 3769  {
> 3770  javadocExe =
> 3771  new File( SystemUtils.getJavaHome() + File.separator + ".." +  
> File.separator + "bin", javadocCommand );
> 3772  }
> {code}
>  
> As workaround one could configure the executable in the pom.xml:
>  
> {code:java}
> 
> ${java.home}/bin/javadoc
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6260) Inconsistency for dynamic property replacement while using Maven's Plugin Prefix Resolution

2019-04-25 Thread S L (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826030#comment-16826030
 ] 

S L commented on MNG-6260:
--

As far as I understand the comment, the {{deployMoyo}} with it's configuration 
is fully initialized before it knows the 'right' {{sample.generated}} property 
(which somewhat makes sense).

I'm wondering if there would be a way to make the {{deployMoyo}} aware of the 
changed value for {{sample.generated}}.

For a user perspective it is weird that running {{mvn 
com.test.plugins:testPlugin:deployMojo}} somewhat generates the 
{{sample.generated}} property, but it's certainly not making it's way into the 
{{deployMoyo}} since the configuration picked up the unchanged value.

 

A use-case where such feature could be needed is a plugin that extracts the 
git-commit-hash from the repository and then should be used as a version 
configuration for sonar which actually suggests using Maven's Plugin Prefix 
Resolution ([as per 
suggestion|https://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Maven#AnalyzingwithSonarQubeScannerforMaven-AnalyzingaMavenProject]
 use {{mvn clean verify sonar:sonar}} which breaks 
{{${project.version}-${git.commit}}}).

Not sure if this would then be something that can only be fixed within maven.

> Inconsistency for dynamic property replacement while using Maven's Plugin 
> Prefix Resolution
> ---
>
> Key: MNG-6260
> URL: https://issues.apache.org/jira/browse/MNG-6260
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.3.9, 3.5.0
>Reporter: S L
>Priority: Major
> Attachments: SampleProject.zip
>
>
> Hi,
> I recently discovered a strange behaviour dynamic property replacement while 
> using Maven's Plugin Prefix Resolution.
> The original cause was reported to a project that I currently maintain and 
> basically extract's repository information from git and inject them back as 
> properties into the maven project.
> The original report was that one if generated properties does not get 
> resolved when it is getting used as a configuration parameter while executing 
> ??mvn appengine:deploy??.
> To be able to reproduce the issue I crafted a sample project that contain's 
> of two Mojo's to simulate this behaviour.
> * The first Mojo {{BuildInjectPropertyMojo}} will inject a Property 
> {{sample.generated}} to the Maven project
> * The second Mojo {{DeployMojo}} basically takes an arbitrary argument and 
> prints it to the console. To reproduce the issue the Parameter needs to 
> defined as followed 
> {noformat}
> ${sample.generated}
> {noformat}
> Observations:
> * When building with {noformat}mvn clean package{noformat} the injected 
> Property {{sample.generated}} will be printed by the Mojo as well as from 
> antrun correctly.
> * When building with {noformat}mvn 
> com.test.plugins:testPlugin:deployMojo{noformat} the injected Property 
> {{sample.generated}} will be printed by antrun correctly but will show up as 
> null for the mojo execution.
> * When building with {noformat}mvn 
> com.test.plugins:testPlugin:buildInjectPropertyMojo antrun:run 
> com.test.plugins:testPlugin:deployMojo{noformat} he injected Property 
> {{sample.generated}} will be printed by the Mojo as well as from antrun 
> correctly.
> To use the attached example one need to install it first {noformat}mvn clean 
> install{noformat} and remove the comments inside the pom.xml that are 
> annotated with {{COMMENT THIS IN TO REPRODUCE}}
> Please note that the execution of {{mvn appengine:deploy}} is per offical 
> guideline of this tool:
> https://cloud.google.com/appengine/docs/standard/java/tools/using-maven#deploying_your_application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MDEP-650) dependency:unpack doesn't seem to handle version ranges

2019-04-25 Thread Andy Lehane (JIRA)


 [ 
https://issues.apache.org/jira/browse/MDEP-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Lehane updated MDEP-650:
-
Description: 
This call is a reopened version of MDEP-50.

 

I have a maven-dependency-plugin configuration of:
{code:java}

  org.apache.maven.plugins
  maven-dependency-plugin
  

  unpack commons-lang example
  process-resources
  
unpack
  
  

  
commons-lang
commons-lang
[0,)
jar
true
${project.build.directory}/test
  

  

  


{code}
When this is run using maven 3.6.0 and the maven-dependency-plugin version 
3.1.1, the following error is produced:

 
{code:java}
[INFO] --- maven-dependency-plugin:3.1.1:unpack (unpack commons-lang example) @ 
MavenDependencyPluginTestBed ---
[INFO] Configured Artifact: common-lang:commons-lang:[0,):jar
Downloading from central-proxy: 
http://internal-repo/repository/central/commons-lang/commons-lang/%5B0,)/commons-lang-%5B0,).pom
[INFO] 
[INFO] BUILD FAILURE
[INFO] ---
{code}

  was:
This call is a reopened version of MDEP-50.

 

I have a maven-dependency-plugin configuration of:
{code:java}

  org.apache.maven.plugins
  maven-dependency-plugin
  

  unpack common-lang example
  process-resources
  
unpack
  
  

  
common-lang
common-lang
[0,)
jar
true
${project.build.directory}/test
  

  

  


{code}
When this is run using maven 3.6.0 and the maven-dependency-plugin version 
3.1.1, the following error is produced:

 
{code:java}
[INFO] --- maven-dependency-plugin:3.1.1:unpack (unpack common-lang example) @ 
MavenDependencyPluginTestBed ---
[INFO] Configured Artifact: common-lang:common-lang:[0,):jar
Downloading from central-proxy: 
http://internal-repo/repository/central/common-lang/common-lang/%5B0,)/common-lang-%5B0,).pom
[INFO] 
[INFO] BUILD FAILURE
[INFO] ---
{code}


> dependency:unpack doesn't seem to handle version ranges
> ---
>
> Key: MDEP-650
> URL: https://issues.apache.org/jira/browse/MDEP-650
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: unpack
>Affects Versions: 3.1.1
>Reporter: Andy Lehane
>Priority: Minor
>
> This call is a reopened version of MDEP-50.
>  
> I have a maven-dependency-plugin configuration of:
> {code:java}
> 
>   org.apache.maven.plugins
>   maven-dependency-plugin
>   
> 
>   unpack commons-lang example
>   process-resources
>   
> unpack
>   
>   
> 
>   
> commons-lang
> commons-lang
> [0,)
> jar
> true
> ${project.build.directory}/test
>   
> 
>   
> 
>   
> 
> {code}
> When this is run using maven 3.6.0 and the maven-dependency-plugin version 
> 3.1.1, the following error is produced:
>  
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:unpack (unpack commons-lang example) 
> @ MavenDependencyPluginTestBed ---
> [INFO] Configured Artifact: common-lang:commons-lang:[0,):jar
> Downloading from central-proxy: 
> http://internal-repo/repository/central/commons-lang/commons-lang/%5B0,)/commons-lang-%5B0,).pom
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] ---
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MDEP-650) dependency:unpack doesn't seem to handle version ranges

2019-04-25 Thread Andy Lehane (JIRA)


[ 
https://issues.apache.org/jira/browse/MDEP-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826015#comment-16826015
 ] 

Andy Lehane commented on MDEP-650:
--

When I get the unit tests created and working, I'll look to submit a pull 
request from my github fork.

> dependency:unpack doesn't seem to handle version ranges
> ---
>
> Key: MDEP-650
> URL: https://issues.apache.org/jira/browse/MDEP-650
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: unpack
>Affects Versions: 3.1.1
>Reporter: Andy Lehane
>Priority: Minor
>
> This call is a reopened version of MDEP-50.
>  
> I have a maven-dependency-plugin configuration of:
> {code:java}
> 
>   org.apache.maven.plugins
>   maven-dependency-plugin
>   
> 
>   unpack common-lang example
>   process-resources
>   
> unpack
>   
>   
> 
>   
> common-lang
> common-lang
> [0,)
> jar
> true
> ${project.build.directory}/test
>   
> 
>   
> 
>   
> 
> {code}
> When this is run using maven 3.6.0 and the maven-dependency-plugin version 
> 3.1.1, the following error is produced:
>  
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:unpack (unpack common-lang example) 
> @ MavenDependencyPluginTestBed ---
> [INFO] Configured Artifact: common-lang:common-lang:[0,):jar
> Downloading from central-proxy: 
> http://internal-repo/repository/central/common-lang/common-lang/%5B0,)/common-lang-%5B0,).pom
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] ---
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MDEP-650) dependency:unpack doesn't seem to handle version ranges

2019-04-25 Thread Andy Lehane (JIRA)


[ 
https://issues.apache.org/jira/browse/MDEP-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826013#comment-16826013
 ] 

Andy Lehane commented on MDEP-650:
--

 I've tested this locally, which works. All of the unit tests pass. I've 
attempted to write unit tests for the new functionality but keep getting errors 
when the getArtifact(artifactItem) method attempts to use the artifact resolver 
to look up the artifact. I assume that I'm not setting up the test correctly 
but cannot figure out how to do this correctly.

> dependency:unpack doesn't seem to handle version ranges
> ---
>
> Key: MDEP-650
> URL: https://issues.apache.org/jira/browse/MDEP-650
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: unpack
>Affects Versions: 3.1.1
>Reporter: Andy Lehane
>Priority: Minor
>
> This call is a reopened version of MDEP-50.
>  
> I have a maven-dependency-plugin configuration of:
> {code:java}
> 
>   org.apache.maven.plugins
>   maven-dependency-plugin
>   
> 
>   unpack common-lang example
>   process-resources
>   
> unpack
>   
>   
> 
>   
> common-lang
> common-lang
> [0,)
> jar
> true
> ${project.build.directory}/test
>   
> 
>   
> 
>   
> 
> {code}
> When this is run using maven 3.6.0 and the maven-dependency-plugin version 
> 3.1.1, the following error is produced:
>  
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:unpack (unpack common-lang example) 
> @ MavenDependencyPluginTestBed ---
> [INFO] Configured Artifact: common-lang:common-lang:[0,):jar
> Downloading from central-proxy: 
> http://internal-repo/repository/central/common-lang/common-lang/%5B0,)/common-lang-%5B0,).pom
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] ---
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MDEP-650) dependency:unpack doesn't seem to handle version ranges

2019-04-25 Thread Andy Lehane (JIRA)


[ 
https://issues.apache.org/jira/browse/MDEP-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826012#comment-16826012
 ] 

Andy Lehane commented on MDEP-650:
--

I've been working on a fix for this, which is based on the following ideas:

 

AbstractFromConfigurationMojo:
 *  - Add a new method called, resolveArtifactRanges
 *  - Call resolveArtifactRanges in the getProcessedArtifactItems method as the 
first call after the log statement when looping around each artifact item.
 *  - The resolveArtifactRanges method performs the following logic:

 # Constructs a version range from the artifactItem's version property, if the 
range has no restrictions, no processing is required.
 # If the version range has restrictions, then try and find a match in the 
projects list of already resolved dependencies (i.e. 
project.getDependencyArtifacts()).
 # If the artifact is not found in the project.getDepencencyArtifacts list, 
then use the Maven DependencyResolver (injected into the Mojo using the 
@Component annotation). 
 # If an artifact has been resolved to a specific version, then update the 
artifactItem's version property with the resolved version.
 # If the artifact cannot be resolved, then leave the version alone 
(maintaining backwards compatibility)

 

> dependency:unpack doesn't seem to handle version ranges
> ---
>
> Key: MDEP-650
> URL: https://issues.apache.org/jira/browse/MDEP-650
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: unpack
>Affects Versions: 3.1.1
>Reporter: Andy Lehane
>Priority: Minor
>
> This call is a reopened version of MDEP-50.
>  
> I have a maven-dependency-plugin configuration of:
> {code:java}
> 
>   org.apache.maven.plugins
>   maven-dependency-plugin
>   
> 
>   unpack common-lang example
>   process-resources
>   
> unpack
>   
>   
> 
>   
> common-lang
> common-lang
> [0,)
> jar
> true
> ${project.build.directory}/test
>   
> 
>   
> 
>   
> 
> {code}
> When this is run using maven 3.6.0 and the maven-dependency-plugin version 
> 3.1.1, the following error is produced:
>  
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:unpack (unpack common-lang example) 
> @ MavenDependencyPluginTestBed ---
> [INFO] Configured Artifact: common-lang:common-lang:[0,):jar
> Downloading from central-proxy: 
> http://internal-repo/repository/central/common-lang/common-lang/%5B0,)/common-lang-%5B0,).pom
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] ---
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MDEP-650) dependency:unpack doesn't seem to handle version ranges

2019-04-25 Thread Andy Lehane (JIRA)
Andy Lehane created MDEP-650:


 Summary: dependency:unpack doesn't seem to handle version ranges
 Key: MDEP-650
 URL: https://issues.apache.org/jira/browse/MDEP-650
 Project: Maven Dependency Plugin
  Issue Type: Bug
  Components: unpack
Affects Versions: 3.1.1
Reporter: Andy Lehane


This call is a reopened version of MDEP-50.

 

I have a maven-dependency-plugin configuration of:
{code:java}

  org.apache.maven.plugins
  maven-dependency-plugin
  

  unpack common-lang example
  process-resources
  
unpack
  
  

  
common-lang
common-lang
[0,)
jar
true
${project.build.directory}/test
  

  

  


{code}
When this is run using maven 3.6.0 and the maven-dependency-plugin version 
3.1.1, the following error is produced:

 
{code:java}
[INFO] --- maven-dependency-plugin:3.1.1:unpack (unpack common-lang example) @ 
MavenDependencyPluginTestBed ---
[INFO] Configured Artifact: common-lang:common-lang:[0,):jar
Downloading from central-proxy: 
http://internal-repo/repository/central/common-lang/common-lang/%5B0,)/common-lang-%5B0,).pom
[INFO] 
[INFO] BUILD FAILURE
[INFO] ---
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [maven-resolver] slachiewicz commented on issue #34: [MRESOLVER-88] Use Java 7 features and style fixes

2019-04-25 Thread GitBox
slachiewicz commented on issue #34: [MRESOLVER-88] Use Java 7 features and 
style fixes
URL: https://github.com/apache/maven-resolver/pull/34#issuecomment-486633306
 
 
   ok, now it's ready for review. That's all that I found to be improved - then 
we have a better base to implement other improvements like migrating to NIO.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (MJAVADOC-601) 3.1.1-SNAPSHOT fails with Java 12

2019-04-25 Thread Benedikt Ritter (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benedikt Ritter updated MJAVADOC-601:
-
Description: 
The latest 3.1.1-SNAPSHOT version fails with Java 12 with

{{javadoc: error - The code being documented uses packages in the unnamed 
module, but the packages defined in 
[https://docs.oracle.com/en/java/javase/12/docs/api/] are in named modules.}}

Even if the fix from [https://bugs.openjdk.java.net/browse/JDK-8212233] 
(explicitly setting source to 8) is applied.

See the attached sample project to reproduce:

 
||Java Version||Command||Result||
|Java 8|mvn clean javadoc:javadoc|success|
|Java 8|mvn clean javadoc:javadoc -Psnapshot|success|
|Java 9|mvn clean javadoc:javadoc|success|
|Java 9|mvn clean javadoc:javadoc -Psnapshot|success|
|Java 10|mvn clean javadoc:javadoc|success|
|Java 10|mvn clean javadoc:javadoc -Psnapshot|success|
|Java 11|mvn clean javadoc:javadoc|failure (source fix does not work for Java 
11)|
|Java 11|mvn clean javadoc:javadoc -Psnapshot|failure (source fix does not work 
for Java 11)|
|Java 12|mvn clean javadoc:javadoc|*success*|
|Java 12|mvn clean javadoc:javadoc -Psnapshot|*failure*|

 

  was:
The latest 3.1.1-SNAPSHOT version fails with Java 12 with

{{javadoc: error - The code being documented uses packages in the unnamed 
module, but the packages defined in 
https://docs.oracle.com/en/java/javase/12/docs/api/ are in named modules.}}

Even if the fix from 

[https://bugs.openjdk.java.net/browse/JDK-8212233] (explicitly setting source 
to 8) is applied.


> 3.1.1-SNAPSHOT fails with Java 12
> -
>
> Key: MJAVADOC-601
> URL: https://issues.apache.org/jira/browse/MJAVADOC-601
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: jar, javadoc
>Affects Versions: 3.1.1
>Reporter: Benedikt Ritter
>Priority: Major
> Attachments: mjavadoc-601.tar.gz
>
>
> The latest 3.1.1-SNAPSHOT version fails with Java 12 with
> {{javadoc: error - The code being documented uses packages in the unnamed 
> module, but the packages defined in 
> [https://docs.oracle.com/en/java/javase/12/docs/api/] are in named modules.}}
> Even if the fix from [https://bugs.openjdk.java.net/browse/JDK-8212233] 
> (explicitly setting source to 8) is applied.
> See the attached sample project to reproduce:
>  
> ||Java Version||Command||Result||
> |Java 8|mvn clean javadoc:javadoc|success|
> |Java 8|mvn clean javadoc:javadoc -Psnapshot|success|
> |Java 9|mvn clean javadoc:javadoc|success|
> |Java 9|mvn clean javadoc:javadoc -Psnapshot|success|
> |Java 10|mvn clean javadoc:javadoc|success|
> |Java 10|mvn clean javadoc:javadoc -Psnapshot|success|
> |Java 11|mvn clean javadoc:javadoc|failure (source fix does not work for Java 
> 11)|
> |Java 11|mvn clean javadoc:javadoc -Psnapshot|failure (source fix does not 
> work for Java 11)|
> |Java 12|mvn clean javadoc:javadoc|*success*|
> |Java 12|mvn clean javadoc:javadoc -Psnapshot|*failure*|
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRELEASE-1023) minor cleanups

2019-04-25 Thread Davide Angelocola (JIRA)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825964#comment-16825964
 ] 

Davide Angelocola commented on MRELEASE-1023:
-

https://github.com/apache/maven-release/pull/22

> minor cleanups
> --
>
> Key: MRELEASE-1023
> URL: https://issues.apache.org/jira/browse/MRELEASE-1023
> Project: Maven Release Plugin
>  Issue Type: Improvement
>Reporter: Davide Angelocola
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MJAVADOC-601) 3.1.1-SNAPSHOT fails with Java 12

2019-04-25 Thread Benedikt Ritter (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benedikt Ritter updated MJAVADOC-601:
-
Attachment: mjavadoc-601.tar.gz

> 3.1.1-SNAPSHOT fails with Java 12
> -
>
> Key: MJAVADOC-601
> URL: https://issues.apache.org/jira/browse/MJAVADOC-601
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: jar, javadoc
>Affects Versions: 3.1.1
>Reporter: Benedikt Ritter
>Priority: Major
> Attachments: mjavadoc-601.tar.gz
>
>
> The latest 3.1.1-SNAPSHOT version fails with Java 12 with
> {{javadoc: error - The code being documented uses packages in the unnamed 
> module, but the packages defined in 
> https://docs.oracle.com/en/java/javase/12/docs/api/ are in named modules.}}
> Even if the fix from 
> [https://bugs.openjdk.java.net/browse/JDK-8212233] (explicitly setting source 
> to 8) is applied.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MJAVADOC-601) 3.1.1-SNAPSHOT fails with Java 12

2019-04-25 Thread Benedikt Ritter (JIRA)
Benedikt Ritter created MJAVADOC-601:


 Summary: 3.1.1-SNAPSHOT fails with Java 12
 Key: MJAVADOC-601
 URL: https://issues.apache.org/jira/browse/MJAVADOC-601
 Project: Maven Javadoc Plugin
  Issue Type: Bug
  Components: jar, javadoc
Affects Versions: 3.1.1
Reporter: Benedikt Ritter


The latest 3.1.1-SNAPSHOT version fails with Java 12 with

{{javadoc: error - The code being documented uses packages in the unnamed 
module, but the packages defined in 
https://docs.oracle.com/en/java/javase/12/docs/api/ are in named modules.}}

Even if the fix from 

[https://bugs.openjdk.java.net/browse/JDK-8212233] (explicitly setting source 
to 8) is applied.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRELEASE-1023) minor cleanups

2019-04-25 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825963#comment-16825963
 ] 

Michael Osipov commented on MRELEASE-1023:
--

Where are the cleanups?

> minor cleanups
> --
>
> Key: MRELEASE-1023
> URL: https://issues.apache.org/jira/browse/MRELEASE-1023
> Project: Maven Release Plugin
>  Issue Type: Improvement
>Reporter: Davide Angelocola
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6647) NPE in DefaultReportingConverter

2019-04-25 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825959#comment-16825959
 ] 

Michael Osipov commented on MNG-6647:
-

[~hboutemy], can you have a look?

> NPE in DefaultReportingConverter
> 
>
> Key: MNG-6647
> URL: https://issues.apache.org/jira/browse/MNG-6647
> Project: Maven
>  Issue Type: Bug
>Reporter: Mark Derricutt
>Priority: Minor
>
> I discovered this NPE whilst running some integration tests for our 
> tiles-maven-plugin:
>  
> {{ O] Scanning for projects...}}
> {{[INFO] --- tiles-maven-plugin: Injecting 1 tiles as intermediary parent 
> artifacts for com.test:reporting-tiletest...}}
> {{[INFO] Mixed 'com.test:reporting-tiletest:0.1.0' with tile 
> 'com.test:reporting-tiletest-tile:0.1.0' as its new parent.}}
> {{[INFO] Mixed 'com.test:reporting-tiletest-tile:0.1.0' with original parent 
> '(no parent)' as its new top level parent.}}
> {{[INFO] }}
> {{[ERROR] Internal error: java.lang.NullPointerException -> [Help 1]}}
> {{org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException}}
> {{ at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)}}
> {{ at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)}}
> {{ at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)}}
> {{ at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)}}
> {{ at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)}}
> {{ at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)}}
> {{ at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)}}
> {{ at java.lang.reflect.Method.invoke (Method.java:498)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)}}
> {{Caused by: java.lang.NullPointerException}}
> {{ at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:243)}}
> {{ at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
> (DefaultReportingConverter.java:213)}}
> {{ at 
> org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
> (DefaultReportingConverter.java:140)}}
> {{ at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:479)}}
> {{ at org.apache.maven.model.building.DefaultModelBuilder.build 
> (DefaultModelBuilder.java:432)}}
> {{ at org.apache.maven.model.building.ModelBuilder$build$0.call (Unknown 
> Source)}}
> {{ at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall 
> (CallSiteArray.java:47)}}
> {{ at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:116)}}
> {{ at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
> (AbstractCallSite.java:136)}}
> {{ at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.thunkModelBuilder 
> (TilesMavenLifecycleParticipant.groovy:460)}}
> {{ at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.orchestrateMerge 
> (TilesMavenLifecycleParticipant.groovy:362)}}
> {{ at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.afterProjectsRead 
> (TilesMavenLifecycleParticipant.groovy:306)}}
> {{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)}}
> {{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)}}
> {{ at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)}}
> {{ at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)}}
> {{ at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)}}
> {{ at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)}}
> {{ at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)}}
> {{ at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)}}
> {{ at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)}}
> {{ at java.lang.reflect.Method.invoke (Method.java:498)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)}}
>  
> This was triggered when running our sitereporting test ( 
> [https://github.com/repaint-io/maven-tiles/tree/master/src/it/sitereporting-tiletest]
>  ) and doesn't trigger an NPE using Apache Maven 3.5.3, but does with the 
> current SNAPSHOT

[jira] [Commented] (MNG-4559) MAVEN_OPTS are incorrectly resolved in Unix

2019-04-25 Thread Markus Schuh (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825940#comment-16825940
 ] 

Markus Schuh commented on MNG-4559:
---

The support of path names containing spaces within maven is meanwhile quite 
complete due to meanwhile proper quoting. Just this special case issue is open.

As already mentioned by [~dwijnand] in a comment above in 2012, the 
[POSIX|[http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html]]
 solution - within a POSIX shell -  for addition of the needed quoting in final 
call is just to prefix the exec by an "eval ".

The introduction of arrays (not yet part of POSIX) were cleaner - but requires 
bash (or another shell). This may have compatibility concerns for a tool of 
such wide spread usage as maven.

"eval" has some security implication (code injection) - but when used as prefix 
for "exec" this isn't relevant, since the "exec" terminates the shell execution 
anyway.

> MAVEN_OPTS are incorrectly resolved in Unix
> ---
>
> Key: MNG-4559
> URL: https://issues.apache.org/jira/browse/MNG-4559
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 2.2.1, 3.0.5
> Environment: OS: Linux, 2.6.32-11-generic, amd64.
> Java: 1.6.0_17
> Also Operating System = Mac OS X version 10.9.2 running on x86_64
> Java; VM; Vendor = 1.7.0_51
>Reporter: Maxim Podkolzine
>Priority: Major
>
> I'm trying to pass a quoted parameter through MAVEN_OPTS, e.g.
> MAVEN_OPTS="-Dfoo='bar baz'"
> As a result the quotes are not resolved, causing Java failure:
> Exception in thread "main" java.lang.NoClassDefFoundError: baz'
> ...
> I couldn't figure out a way to make it work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MENFORCER-195) Dependency convergence does not support wildcard exclusions

2019-04-25 Thread Henning Hoefer (JIRA)


[ 
https://issues.apache.org/jira/browse/MENFORCER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825887#comment-16825887
 ] 

Henning Hoefer commented on MENFORCER-195:
--

{quote}This is a PR merged from a forked repository.
{quote}
Contrary to the bot's message, this PR has *not* been merged! (but the PR has 
been closed)

The problem persists, still affects 3.0.0.M2

> Dependency convergence does not support wildcard exclusions
> ---
>
> Key: MENFORCER-195
> URL: https://issues.apache.org/jira/browse/MENFORCER-195
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 1.3.1
> Environment: Maven 3.2.1
>Reporter: Tomaz Cerar
>Priority: Major
>
> Maven 3.2 introduced wildcard exclusions for dependencies.
> But if you use them dependencyConvergence wrongly complains about conflicting 
> transitive dependencies.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MNG-6647) NPE in DefaultReportingConverter

2019-04-25 Thread Mark Derricutt (JIRA)
Mark Derricutt created MNG-6647:
---

 Summary: NPE in DefaultReportingConverter
 Key: MNG-6647
 URL: https://issues.apache.org/jira/browse/MNG-6647
 Project: Maven
  Issue Type: Bug
Reporter: Mark Derricutt


I discovered this NPE whilst running some integration tests for our 
tiles-maven-plugin:

 

{{ O] Scanning for projects...}}
{{[INFO] --- tiles-maven-plugin: Injecting 1 tiles as intermediary parent 
artifacts for com.test:reporting-tiletest...}}
{{[INFO] Mixed 'com.test:reporting-tiletest:0.1.0' with tile 
'com.test:reporting-tiletest-tile:0.1.0' as its new parent.}}
{{[INFO] Mixed 'com.test:reporting-tiletest-tile:0.1.0' with original parent 
'(no parent)' as its new top level parent.}}
{{[INFO] }}
{{[ERROR] Internal error: java.lang.NullPointerException -> [Help 1]}}
{{org.apache.maven.InternalErrorException: Internal error: 
java.lang.NullPointerException}}
{{ at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)}}
{{ at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)}}
{{ at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)}}
{{ at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)}}
{{ at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)}}
{{ at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)}}
{{ at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)}}
{{ at java.lang.reflect.Method.invoke (Method.java:498)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:225)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:347)}}
{{Caused by: java.lang.NullPointerException}}
{{ at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
(DefaultReportingConverter.java:243)}}
{{ at org.apache.maven.model.plugin.DefaultReportingConverter.convert 
(DefaultReportingConverter.java:213)}}
{{ at org.apache.maven.model.plugin.DefaultReportingConverter.convertReporting 
(DefaultReportingConverter.java:140)}}
{{ at org.apache.maven.model.building.DefaultModelBuilder.build 
(DefaultModelBuilder.java:479)}}
{{ at org.apache.maven.model.building.DefaultModelBuilder.build 
(DefaultModelBuilder.java:432)}}
{{ at org.apache.maven.model.building.ModelBuilder$build$0.call (Unknown 
Source)}}
{{ at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall 
(CallSiteArray.java:47)}}
{{ at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
(AbstractCallSite.java:116)}}
{{ at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call 
(AbstractCallSite.java:136)}}
{{ at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.thunkModelBuilder 
(TilesMavenLifecycleParticipant.groovy:460)}}
{{ at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.orchestrateMerge 
(TilesMavenLifecycleParticipant.groovy:362)}}
{{ at io.repaint.maven.tiles.TilesMavenLifecycleParticipant.afterProjectsRead 
(TilesMavenLifecycleParticipant.groovy:306)}}
{{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)}}
{{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)}}
{{ at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)}}
{{ at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)}}
{{ at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)}}
{{ at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)}}
{{ at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)}}
{{ at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)}}
{{ at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)}}
{{ at java.lang.reflect.Method.invoke (Method.java:498)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:225)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:347)}}

 

This was triggered when running our sitereporting test ( 
[https://github.com/repaint-io/maven-tiles/tree/master/src/it/sitereporting-tiletest]
 ) and doesn't trigger an NPE using Apache Maven 3.5.3, but does with the 
current SNAPSHOT of 3.6.2.

The problem lies when Maven is building the model from 
[https://github.com/repaint-io/maven-tiles/blob/master/src/it/sitereporting-tiletest/tile-tile/tile.xml#L35]
 and can be fixed by applying the patch found at 
[https://www.dropbox.com/s/9gficrmlgxl2jd0/0001-Fix-NPE-thrown-from-DefaultReportingConverter.patch?dl=0]
 (for some reason I could not attach the patch to the ticket).

 



--
This message was sent by