[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI

2019-05-23 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847121#comment-16847121
 ] 

Hudson commented on MNG-6573:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6169/MNG-6552 #10

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6552/10/

> Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
> --
>
> Key: MNG-6573
> URL: https://issues.apache.org/jira/browse/MNG-6573
> Project: Maven
>  Issue Type: Task
>  Components: Integration Tests
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, 
> 11, 12-ea, 13-ea.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI

2019-05-23 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847112#comment-16847112
 ] 

Hudson commented on MNG-6573:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6169/MNG-6553 #10

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6553/10/

> Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
> --
>
> Key: MNG-6573
> URL: https://issues.apache.org/jira/browse/MNG-6573
> Project: Maven
>  Issue Type: Task
>  Components: Integration Tests
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, 
> 11, 12-ea, 13-ea.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MCOMPILER-320) Allow additional class path items to be given during compilation

2019-05-23 Thread David M. Lloyd (JIRA)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847095#comment-16847095
 ] 

David M. Lloyd commented on MCOMPILER-320:
--

So... how was Kiev? :)

> Allow additional class path items to be given during compilation
> 
>
> Key: MCOMPILER-320
> URL: https://issues.apache.org/jira/browse/MCOMPILER-320
> Project: Maven Compiler Plugin
>  Issue Type: New Feature
>Reporter: David M. Lloyd
>Assignee: Robert Scholte
>Priority: Major
>
> At present it is very difficult to include additional class path items during 
> compilation that are not dependencies.  But this is a very useful capability, 
> especially when doing partial builds, MR JARs, JDK API stubbing, including 
> dependency items that cannot be included in any other build phase or 
> execution, etc.
> This enhancement and pull request are to request the addition of a 
> {{additionalCompilePathItems}} property in CompilerMojo or 
> AbstractCompilerMojo which includes additional filesystem paths in the 
> compilation class path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6553) Packaging 'war' binding plugin upgrades

2019-05-23 Thread Michael Osipov (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6553:

Description: 
This affects:
||groupId||artifactId||[previous 
version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_war_packaging]||target
 version||
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.1|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-war-plugin|2.4|3.2.2|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|

  was:
This affects:
||groupId||artifactId||[previous 
version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_war_packaging]||target
 version||
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-war-plugin|2.4|3.2.2|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|



> Packaging 'war' binding plugin upgrades
> ---
>
> Key: MNG-6553
> URL: https://issues.apache.org/jira/browse/MNG-6553
> Project: Maven
>  Issue Type: Sub-task
>  Components: core, Dependencies
>Affects Versions: 3.5.0, 3.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0-candidate
>
>
> This affects:
> ||groupId||artifactId||[previous 
> version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_war_packaging]||target
>  version||
> |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
> |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.1|
> |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
> |org.apache.maven.plugins|maven-war-plugin|2.4|3.2.2|
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6552) Packaging 'ejb' binding plugin upgrades

2019-05-23 Thread Michael Osipov (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6552:

Description: 
This affects:
||groupId||artifactId||[previous 
version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target
 version||
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.1|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-ejb-plugin|2.4|3.0.1|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|

  was:
This affects:
||groupId||artifactId||[previous 
version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target
 version||
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-ejb-plugin|2.4|3.0.1|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|



> Packaging 'ejb' binding plugin upgrades
> ---
>
> Key: MNG-6552
> URL: https://issues.apache.org/jira/browse/MNG-6552
> Project: Maven
>  Issue Type: Sub-task
>  Components: core, Dependencies
>Affects Versions: 3.5.0, 3.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0-candidate
>
>
> This affects:
> ||groupId||artifactId||[previous 
> version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target
>  version||
> |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
> |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.1|
> |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
> |org.apache.maven.plugins|maven-ejb-plugin|2.4|3.0.1|
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI

2019-05-23 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847049#comment-16847049
 ] 

Hudson commented on MNG-6573:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6551 #16

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6551/16/

> Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
> --
>
> Key: MNG-6573
> URL: https://issues.apache.org/jira/browse/MNG-6573
> Project: Maven
>  Issue Type: Task
>  Components: Integration Tests
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, 
> 11, 12-ea, 13-ea.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SUREFIRE-1664) "plugin's wiki page" points to non-existing web page

2019-05-23 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1664:
---
Fix Version/s: 3.0.0-M4

> "plugin's wiki page" points to non-existing web page
> 
>
> Key: SUREFIRE-1664
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1664
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: documentation
>Reporter: Bruce Wen
>Priority: Minor
> Fix For: 3.0.0-M4
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In [http://maven.apache.org/surefire/maven-surefire-plugin/index.html], 
> *Usage* section,  [plugin's wiki 
> page|http://docs.codehaus.org/display/MAVENUSER/Surefire+Plugin] points to 
> [http://docs.codehaus.org/display/MAVENUSER/Surefire+Plugin] which doesn't 
> exist anymore. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [maven-surefire] Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-23 Thread GitBox
Tibor17 commented on issue #112: Adding support for externally passed random 
seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-495381979
 
 
   @cardil 
   Yes please resolve these conflicts. I saw your changes on GitHub already but 
I have to see them better again in IDE. The runorder is calculated in the 
forked jvm, so it means the extension won't be possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (MNG-6551) Packaging 'jar' binding plugin upgrades

2019-05-23 Thread Michael Osipov (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6551:

Description: 
This affects:
||groupId||artifactId||[previous 
version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target
 version||
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.1|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-jar-plugin|2.4|3.1.2|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|

  was:
This affects:
||groupId||artifactId||[previous 
version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target
 version||
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-jar-plugin|2.4|3.1.1|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|



> Packaging 'jar' binding plugin upgrades
> ---
>
> Key: MNG-6551
> URL: https://issues.apache.org/jira/browse/MNG-6551
> Project: Maven
>  Issue Type: Sub-task
>  Components: core, Dependencies
>Affects Versions: 3.5.0, 3.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0-candidate
>
>
> This affects:
> ||groupId||artifactId||[previous 
> version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging]||target
>  version||
> |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
> |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.1|
> |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
> |org.apache.maven.plugins|maven-jar-plugin|2.4|3.1.2|
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [maven-surefire] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-23 Thread GitBox
cardil commented on issue #112: Adding support for externally passed random 
seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-495378702
 
 
   @Tibor17 Should I implement the new extenstion API introduced in 
https://github.com/apache/maven-surefire/pull/232 or just fix the conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2019-05-23 Thread Christian Stein (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847017#comment-16847017
 ] 

Christian Stein commented on SUREFIRE-1546:
---

Great seeing this feature being implemented. Good job, Tibor.

> JUnit 5 runner does not honor JUnit 5 display names
> ---
>
> Key: SUREFIRE-1546
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1546
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support
>Affects Versions: 2.22.0
>Reporter: Romain Manni-Bucau
>Assignee: Tibor Digana
>Priority: Major
>  Labels: junit5
> Fix For: 3.0.0-M4
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> JUnit 5 runner should respect the test @DisplayName instead of displaying the 
> classname if any is defined. Seems last release doesn't support that feature 
> of JUnit 5 making the console output and reports not the expected ones.
>  
> Origin: https://github.com/junit-team/junit5/issues/990



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SUREFIRE-1222) ForkClient attempts to consume unrelated lines

2019-05-23 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847014#comment-16847014
 ] 

Tibor Digana commented on SUREFIRE-1222:


https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=deae79575b6846dddee53ccd3d4e28fc8133dc6f

> ForkClient attempts to consume unrelated lines
> --
>
> Key: SUREFIRE-1222
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1222
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.17
> Environment: Oracle JDK7 (build 1.7.0_79-b15)
> Linux 3.13 x86_64 with default locale cs_CZ
>Reporter: Martin Kouba
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M4
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This month the [Weld 
> SE|https://github.com/weld/core/tree/2.3/environments/se/tests] test suite 
> suddenly started to fail on a Linux machine with Oracle JDK7 and the default 
> locale {{cs_CZ}}:
> {code}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of 
> range: -1
>   at java.lang.String.substring(String.java:1911)
>   at 
> org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:128)
>   at 
> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:67)
>   at java.lang.Thread.run(Thread.java:745)
> {code}
> A {{java.util.logging.Logger}} is used in the forked process. The exception 
> occurs when the following log message is written to the standard output:
> {code}
> I 29, 2016 2:01:43 ODP. org.jboss.arquillian.container.se.server.Main main
> {code}
> We have found out that the timestamp *I 29, 2016 2:01:43* (i.e. 2016-01-29 
> 14:01:43) is incorrectly parsed as {{ForkingRunListener.BOOTERCODE_SYSPROPS}} 
> operation.
> I think the protocol should be robust enough to avoid similar collisions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2019-05-23 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed SUREFIRE-1546.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=d624dadcaaac18e8a26517400e16143fa6cc2f11

> JUnit 5 runner does not honor JUnit 5 display names
> ---
>
> Key: SUREFIRE-1546
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1546
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support
>Affects Versions: 2.22.0
>Reporter: Romain Manni-Bucau
>Assignee: Tibor Digana
>Priority: Major
>  Labels: junit5
> Fix For: 3.0.0-M4
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> JUnit 5 runner should respect the test @DisplayName instead of displaying the 
> classname if any is defined. Seems last release doesn't support that feature 
> of JUnit 5 making the console output and reports not the expected ones.
>  
> Origin: https://github.com/junit-team/junit5/issues/990



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [maven-surefire] asfgit merged pull request #232: [SUREFIRE-1546] JUnit 5 runner does not honor JUnit 5 display names

2019-05-23 Thread GitBox
asfgit merged pull request #232: [SUREFIRE-1546] JUnit 5 runner does not honor 
JUnit 5 display names
URL: https://github.com/apache/maven-surefire/pull/232
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI

2019-05-23 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847004#comment-16847004
 ] 

Hudson commented on MNG-6573:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6169/MNG-6555 #17

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6555/17/

> Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
> --
>
> Key: MNG-6573
> URL: https://issues.apache.org/jira/browse/MNG-6573
> Project: Maven
>  Issue Type: Task
>  Components: Integration Tests
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, 
> 11, 12-ea, 13-ea.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MWAR-420) build failure in lifecycle deploy: 'Could not copy webapp sources'

2019-05-23 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MWAR-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846995#comment-16846995
 ] 

Karl Heinz Marbaise commented on MWAR-420:
--

I checked also on MacOS unpacked the ZIP file first I can not reproduce the 
issue cause I don't see any {{Caused by: java.nio.file.AccessDeniedException: 
C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT\images\ajaxloading.gif}}
 apart from that the unpacked content of the archive looks a bit strange cause 
it contains several special information about permissions

> build failure in lifecycle deploy: 'Could not copy webapp sources'
> --
>
> Key: MWAR-420
> URL: https://issues.apache.org/jira/browse/MWAR-420
> Project: Maven WAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.0, 3.2.1, 3.2.2
>Reporter: Bruno Marti
>Priority: Major
> Attachments: build-error.log, testWarPlugin.zip
>
>
> Since version 3.2.x there is a build failure in maven-war-plugin on lifecycle 
> 'deploy'.
> {code:java}
> mvn package package -e{code}
> If you build sample webapp (see attachement: [^testWarPlugin.zip]) with 
> version 3.2.2 following error occurs:
> {code:java}
> [INFO] --- maven-war-plugin:3.2.2:war (default-war) @ testWarPlugin ---
> [INFO] Packaging webapp
> [INFO] Assembling webapp [testWarPlugin] in 
> [C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT]
> [INFO] Processing war project
> [INFO] Copying webapp resources [C:\TEMP\testWarPlugin\src\main\webapp]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5.106 s
> [INFO] Finished at: 2018-11-07T10:11:58+01:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-war-plugin:3.2.2:war (default-war) on project 
> testWarPlugin: Could not copy webapp sources 
> [C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT]: 
> C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT\images\ajaxloading.gif
>  -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-war-plugin:3.2.2:war (default-war) on 
> project testWarPlugin: Could not copy webapp sources 
> [C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT]
> ...
> Caused by: java.nio.file.AccessDeniedException: 
> C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT\images\ajaxloading.gif
>     at sun.nio.fs.WindowsException.translateToIOException 
> (WindowsException.java:83)
>     at sun.nio.fs.WindowsException.rethrowAsIOException 
> (WindowsException.java:97)
>     at sun.nio.fs.WindowsException.rethrowAsIOException 
> (WindowsException.java:102)
>     at sun.nio.fs.WindowsFileCopy.copy (WindowsFileCopy.java:165)
>     at sun.nio.fs.WindowsFileSystemProvider.copy 
> (WindowsFileSystemProvider.java:278)
>     at java.nio.file.Files.copy (Files.java:1274)
> {code}
> It only occurs on {color:#ff}windows{color} and with 
> maven-war-plugin{color:#ff} 3.2.x{color}. Fullstacktrace here: 
> [^build-error.log]
> Version {color:#14892c}3.1.0 and older{color} works fine



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6555) Packaging 'rar' binding plugin upgrades

2019-05-23 Thread Michael Osipov (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6555:

Description: 
This affects:
||groupId||artifactId||[previous 
version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_rar_packaging]||target
 version||
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.1|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-rar-plugin|2.2|2.4|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|

  was:
This affects:
||groupId||artifactId||[previous 
version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_rar_packaging]||target
 version||
|org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
|org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.0|
|org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
|org.apache.maven.plugins|maven-rar-plugin|2.2|2.4|
|org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
|org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|



> Packaging 'rar' binding plugin upgrades
> ---
>
> Key: MNG-6555
> URL: https://issues.apache.org/jira/browse/MNG-6555
> Project: Maven
>  Issue Type: Sub-task
>  Components: core, Dependencies
>Affects Versions: 3.5.0, 3.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.0-candidate
>
>
> This affects:
> ||groupId||artifactId||[previous 
> version|https://maven.apache.org/ref/3.5.0/maven-core/default-bindings.html#Plugin_bindings_for_rar_packaging]||target
>  version||
> |org.apache.maven.plugins|maven-resources-plugin|2.6|3.1.0|
> |org.apache.maven.plugins|maven-compiler-plugin|3.1|3.8.1|
> |org.apache.maven.plugins|maven-surefire-plugin|2.12.4|3.0.0-M3|
> |org.apache.maven.plugins|maven-rar-plugin|2.2|2.4|
> |org.apache.maven.plugins|maven-install-plugin|2.4|3.0.0-M1|
> |org.apache.maven.plugins|maven-deploy-plugin|2.7|3.0.0-M1|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (MNG-5896) Download dependency POMs in parallel

2019-05-23 Thread Michael Osipov (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MNG-5896:
---

Assignee: (was: Michael Osipov)

> Download dependency POMs in parallel
> 
>
> Key: MNG-5896
> URL: https://issues.apache.org/jira/browse/MNG-5896
> Project: Maven
>  Issue Type: Improvement
>  Components: Dependencies
>Affects Versions: 3.3.3
>Reporter: Harald Wellmann
>Priority: Major
>
> h3. Background
> When building a project with dependencies not yet available in the local 
> repository, I noticed that Maven 3.3.3 first downloads the dependency POMs 
> _sequentially_ and then proceeds downloading the dependency JARs with up to 5 
> threads _in parallel_.
> Due to this, when first building a project with a large number of 
> dependencies, downloading a large number of small POMs may take a lot longer 
> than downloading the much larger JARs, or even longer than building the 
> project itself, especially when a repository manager is used which increases 
> the download latency.
> h3. Enhancement
> Download POMs of (transitive) dependencies in parallel to significantly speed 
> up initial builds of large projects.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MJAR-265) Resources not copied

2019-05-23 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJAR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MJAR-265:
-
Affects Version/s: (was: 2.6)
   (was: 2.5)
   (was: 2.4)

> Resources not copied
> 
>
> Key: MJAR-265
> URL: https://issues.apache.org/jira/browse/MJAR-265
> Project: Maven JAR Plugin
>  Issue Type: New Feature
>Affects Versions: 3.1.2
> Environment: windows 7, Maven 3.3.9 Java version: 1.7.0_80
>Reporter: vincent c
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Attachments: example.7z
>
>
> I have a folder named *.metadata* that is in the target/classes folder.
> But it is not copied to the jar archive. It looks like a default exclusion 
> filter is used.
> It is working with version maven-jar-plugin:2.3 but version 2.4 and upper it 
> is not.
>  
> The issue seams to be also discussed on 
> [stackoverflow|https://stackoverflow.com/questions/55514758/maven-jar-plugin-does-not-include-gitignore-file/55522970#55522970].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (MJAR-265) Resources not copied

2019-05-23 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJAR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MJAR-265:


Assignee: Karl Heinz Marbaise

> Resources not copied
> 
>
> Key: MJAR-265
> URL: https://issues.apache.org/jira/browse/MJAR-265
> Project: Maven JAR Plugin
>  Issue Type: New Feature
>Affects Versions: 2.4, 2.5, 2.6, 3.1.2
> Environment: windows 7, Maven 3.3.9 Java version: 1.7.0_80
>Reporter: vincent c
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Attachments: example.7z
>
>
> I have a folder named *.metadata* that is in the target/classes folder.
> But it is not copied to the jar archive. It looks like a default exclusion 
> filter is used.
> It is working with version maven-jar-plugin:2.3 but version 2.4 and upper it 
> is not.
>  
> The issue seams to be also discussed on 
> [stackoverflow|https://stackoverflow.com/questions/55514758/maven-jar-plugin-does-not-include-gitignore-file/55522970#55522970].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MJAR-265) Resources not copied

2019-05-23 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJAR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MJAR-265:
-
Issue Type: New Feature  (was: Bug)

> Resources not copied
> 
>
> Key: MJAR-265
> URL: https://issues.apache.org/jira/browse/MJAR-265
> Project: Maven JAR Plugin
>  Issue Type: New Feature
>Affects Versions: 2.4, 2.5, 2.6, 3.1.2
> Environment: windows 7, Maven 3.3.9 Java version: 1.7.0_80
>Reporter: vincent c
>Priority: Minor
> Attachments: example.7z
>
>
> I have a folder named *.metadata* that is in the target/classes folder.
> But it is not copied to the jar archive. It looks like a default exclusion 
> filter is used.
> It is working with version maven-jar-plugin:2.3 but version 2.4 and upper it 
> is not.
>  
> The issue seams to be also discussed on 
> [stackoverflow|https://stackoverflow.com/questions/55514758/maven-jar-plugin-does-not-include-gitignore-file/55522970#55522970].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MJAR-265) Resources not copied

2019-05-23 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJAR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MJAR-265:
-
Priority: Minor  (was: Major)

> Resources not copied
> 
>
> Key: MJAR-265
> URL: https://issues.apache.org/jira/browse/MJAR-265
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Affects Versions: 2.4, 2.5, 2.6, 3.1.2
> Environment: windows 7, Maven 3.3.9 Java version: 1.7.0_80
>Reporter: vincent c
>Priority: Minor
> Attachments: example.7z
>
>
> I have a folder named *.metadata* that is in the target/classes folder.
> But it is not copied to the jar archive. It looks like a default exclusion 
> filter is used.
> It is working with version maven-jar-plugin:2.3 but version 2.4 and upper it 
> is not.
>  
> The issue seams to be also discussed on 
> [stackoverflow|https://stackoverflow.com/questions/55514758/maven-jar-plugin-does-not-include-gitignore-file/55522970#55522970].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [maven-surefire] Tibor17 commented on issue #232: [SUREFIRE-1546] JUnit 5 runner does not honor JUnit 5 display names

2019-05-23 Thread GitBox
Tibor17 commented on issue #232: [SUREFIRE-1546] JUnit 5 runner does not honor 
JUnit 5 display names
URL: https://github.com/apache/maven-surefire/pull/232#issuecomment-495310911
 
 
   Because it was easier for me to have two branches and pickup only related 
files from one branch to multiple commits in second branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] eolivelli commented on issue #232: [SUREFIRE-1546] JUnit 5 runner does not honor JUnit 5 display names

2019-05-23 Thread GitBox
eolivelli commented on issue #232: [SUREFIRE-1546] JUnit 5 runner does not 
honor JUnit 5 display names
URL: https://github.com/apache/maven-surefire/pull/232#issuecomment-495310032
 
 
   @Tibor17 why are you opening this new PR ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 commented on issue #226: Extended SimpleReportEntry with sourceText and nameText

2019-05-23 Thread GitBox
Tibor17 commented on issue #226: Extended SimpleReportEntry with sourceText and 
nameText
URL: https://github.com/apache/maven-surefire/pull/226#issuecomment-495307709
 
 
   @eolivelli I am closing this PR and continuing in #232 .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 closed pull request #226: Extended SimpleReportEntry with sourceText and nameText

2019-05-23 Thread GitBox
Tibor17 closed pull request #226: Extended SimpleReportEntry with sourceText 
and nameText
URL: https://github.com/apache/maven-surefire/pull/226
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] Tibor17 opened a new pull request #232: [SUREFIRE-1546] JUnit 5 runner does not honor JUnit 5 display names

2019-05-23 Thread GitBox
Tibor17 opened a new pull request #232: [SUREFIRE-1546] JUnit 5 runner does not 
honor JUnit 5 display names
URL: https://github.com/apache/maven-surefire/pull/232
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-23 Thread GitBox
cardil commented on issue #112: Adding support for externally passed random 
seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-495190869
 
 
   @Tibor17 Should I do something with this PR? Rewrite it somehow? I do not 
understand.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MJAR-265) Resources not copied

2019-05-23 Thread vincent c (JIRA)


[ 
https://issues.apache.org/jira/browse/MJAR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846667#comment-16846667
 ] 

vincent c commented on MJAR-265:


Thank you [~khmarbaise] to have reviewed my problem.

I have attached a simple project. To reproduce the behaviour, just run : {{mvn 
install}}

The {{.metadata}} folder comes from {{src/main/resources}}, it is well copied 
to {{target/classes}} folder but not into the jar.

> Resources not copied
> 
>
> Key: MJAR-265
> URL: https://issues.apache.org/jira/browse/MJAR-265
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Affects Versions: 2.4, 2.5, 2.6, 3.1.2
> Environment: windows 7, Maven 3.3.9 Java version: 1.7.0_80
>Reporter: vincent c
>Priority: Major
> Attachments: example.7z
>
>
> I have a folder named *.metadata* that is in the target/classes folder.
> But it is not copied to the jar archive. It looks like a default exclusion 
> filter is used.
> It is working with version maven-jar-plugin:2.3 but version 2.4 and upper it 
> is not.
>  
> The issue seams to be also discussed on 
> [stackoverflow|https://stackoverflow.com/questions/55514758/maven-jar-plugin-does-not-include-gitignore-file/55522970#55522970].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MJAR-265) Resources not copied

2019-05-23 Thread vincent c (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJAR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

vincent c updated MJAR-265:
---
Attachment: example.7z

> Resources not copied
> 
>
> Key: MJAR-265
> URL: https://issues.apache.org/jira/browse/MJAR-265
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Affects Versions: 2.4, 2.5, 2.6, 3.1.2
> Environment: windows 7, Maven 3.3.9 Java version: 1.7.0_80
>Reporter: vincent c
>Priority: Major
> Attachments: example.7z
>
>
> I have a folder named *.metadata* that is in the target/classes folder.
> But it is not copied to the jar archive. It looks like a default exclusion 
> filter is used.
> It is working with version maven-jar-plugin:2.3 but version 2.4 and upper it 
> is not.
>  
> The issue seams to be also discussed on 
> [stackoverflow|https://stackoverflow.com/questions/55514758/maven-jar-plugin-does-not-include-gitignore-file/55522970#55522970].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [maven-surefire] Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-23 Thread GitBox
Tibor17 commented on issue #112: Adding support for externally passed random 
seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-495186396
 
 
   @cardil 
   Thx for the progress. In #226 we have a tendency not to push users to write 
a code for surefire nothing but exposing Extensions API which can be 
implemented by the same user in his POM without asking us in ASF. Nevertheless 
we should adopt your patch but as an extension which prevents from long waiting 
periods of our acceptance.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (MCHECKSTYLE-377) Violations or exceptions when using "external" FQCNs in @throws after upgrade to 3.1.0

2019-05-23 Thread Falko Modler (JIRA)


 [ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Falko Modler updated MCHECKSTYLE-377:
-
Description: 
I started to see strange violations and even exceptions after upgrading 
checkstyle-plugin from 3.0.0 and 3.1.0. Please note that I pinned Checkstyle to 
8.7, so the Checkstyle version itself did _not_ change in my setup.

The problem boils down to Checkstyle not being able anymore to load classes 
that reside in dependencies (= not im the same project as the checked class) 
when using fully qualified class names in {{@throws}} tags, e.g.:
{code:java}
/**
 * Foo.
 * @throws some.other.project.SomeException some exception.
 */
public void foo() throws SomeException {
// ...
}
{code}
Please note that the actual throws declaration does _not_ use the fully 
qualified class name.
While this might be an inconsistent/non DRY approach, it is not forbidden by 
JavaDoc or the compiler.

In one case (where the exception resides in an external dependency), this 
resulted in a violation:
{noformat}
JavadocMethod: Expected @throws tag for 'SomeException'.
{noformat}

In another case (where the exception resides in the same module but implements 
an interface that resides in another module of the project being built), this 
resulted in an exception:
{noformat}
[...]
Caused by: java.lang.NoClassDefFoundError: 
some/project/othermodule/SomeInterface
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:348)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.safeLoad(ClassResolver.java:216)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.resolve(ClassResolver.java:95)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.resolveClass(AbstractTypeAwareCheck.java:241)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.tryLoadClass(AbstractTypeAwareCheck.java:258)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck$RegularClass.getClazz(AbstractTypeAwareCheck.java:467)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkThrowsTags(JavadocMethodCheck.java:909)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkComment(JavadocMethodCheck.java:503)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.processAST(JavadocMethodCheck.java:357)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.visitToken(AbstractTypeAwareCheck.java:157)
at 
com.puppycrawl.tools.checkstyle.TreeWalker.notifyVisit(TreeWalker.java:423)
at 
com.puppycrawl.tools.checkstyle.TreeWalker.processIter(TreeWalker.java:579)
at com.puppycrawl.tools.checkstyle.TreeWalker.walk(TreeWalker.java:363)
at 
com.puppycrawl.tools.checkstyle.TreeWalker.processFiltered(TreeWalker.java:208)
at 
com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:83)
at com.puppycrawl.tools.checkstyle.Checker.processFile(Checker.java:319)
at 
com.puppycrawl.tools.checkstyle.Checker.processFiles(Checker.java:289)
... 25 more
Caused by: java.lang.ClassNotFoundException: 
com.t_systems_mms.ccs.common.base.service.exception.ExceptionAttributeInterface
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 54 more
{noformat}

I guess this is caused by MCHECKSTYLE-353 (which does improve runtime a lot 
when {{checkstyle:check}} is invoked explicitly).

*Workaround*: Don't use fully qualified exception class names in {{@throws}}.

PS: This might actually be a shortcomming in Checkstyle itself and it also 
might affect more than just {{@throws}}.

  was:
I started to see strange violations and even exceptions after upgrading 
checkstyle-plugin from 3.0.0 and 3.1.0. Please note that I pinned Checkstyle to 
8.7, so the Checkstyle version itself did _not_ change 

[GitHub] [maven-checkstyle-plugin] famod commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2019-05-23 Thread GitBox
famod commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-495165010
 
 
   I'd like to raise your attention to 
[MCHECKSTYLE-377](https://issues.apache.org/jira/browse/MCHECKSTYLE-377), which 
I strongly think is caused by this change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (MCHECKSTYLE-377) Violations or exceptions when using "external" FQCNs in @throws after upgrade to 3.1.0

2019-05-23 Thread Falko Modler (JIRA)


 [ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Falko Modler updated MCHECKSTYLE-377:
-
Summary: Violations or exceptions when using "external" FQCNs in @throws 
after upgrade to 3.1.0  (was: Violations or exceptions when using FQCNs in 
@throws after upgrade to 3.1.0)

> Violations or exceptions when using "external" FQCNs in @throws after upgrade 
> to 3.1.0
> --
>
> Key: MCHECKSTYLE-377
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-377
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.1 
> (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00)
> Java version: 1.8.0_202, vendor: Oracle Corporation
> Default locale: de_DE, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Falko Modler
>Priority: Major
>
> I started to see strange violations and even exceptions after upgrading 
> checkstyle-plugin from 3.0.0 and 3.1.0. Please note that I pinned Checkstyle 
> to 8.7, so the Checkstyle version itself did _not_ change in my setup.
> The problem boils down to Checkstyle not being able anymore to load classes 
> that reside in dependencies (= not im the same project as the checked class) 
> when using fully qualified class names in {{@throws}} tags, e.g.:
> {code:java}
> /**
>  * Foo.
>  * @throws some.other.project.SomeException some exception.
>  */
> public void foo() throws SomeException {
> // ...
> }
> {code}
> Please note that the actual throws declaration does _not_ use the fully 
> qualified class name.
> While this might be an inconsistent/non DRY approach, it is not forbidden by 
> JavaDoc or the compiler.
> In one case (where the exception resides in an external dependency), this 
> resulted in a violation:
> {noformat}
> JavadocMethod: Expected @throws tag for 'SomeException'.
> {noformat}
> In another case (where the exception resides in the same module but 
> implements an interface that resides in another module of the project being 
> built), this resulted in an exception:
> {noformat}
> [...]
> Caused by: java.lang.NoClassDefFoundError: 
> some/project/othermodule/SomeInterface
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> at 
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:348)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.safeLoad(ClassResolver.java:216)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.resolve(ClassResolver.java:95)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.resolveClass(AbstractTypeAwareCheck.java:241)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.tryLoadClass(AbstractTypeAwareCheck.java:258)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck$RegularClass.getClazz(AbstractTypeAwareCheck.java:467)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkThrowsTags(JavadocMethodCheck.java:909)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkComment(JavadocMethodCheck.java:503)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.processAST(JavadocMethodCheck.java:357)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.visitToken(AbstractTypeAwareCheck.java:157)
> at 
> com.puppycrawl.tools.checkstyle.TreeWalker.notifyVisit(TreeWalker.java:423)
> at 
> com.puppycrawl.tools.checkstyle.TreeWalker.processIter(TreeWalker.java:579)
> at 
> com.puppycrawl.tools.checkstyle.TreeWalker.walk(TreeWalker.java:363)
> at 
> com.puppycrawl.tools.checkstyle.TreeWalker.processFiltered(TreeWalker.java:208)
> at 
> com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:83)
> 

[jira] [Commented] (MCHECKSTYLE-353) Don't resolve any dependencies

2019-05-23 Thread Falko Modler (JIRA)


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846609#comment-16846609
 ] 

Falko Modler commented on MCHECKSTYLE-353:
--

Note: I am almost sure this change is causing MCHECKSTYLE-377.

> Don't resolve any dependencies
> --
>
> Key: MCHECKSTYLE-353
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-353
> Project: Maven Checkstyle Plugin
>  Issue Type: Improvement
>  Components: checkstyle:check
>Affects Versions: 3.0.0
>Reporter: Zoran Regvart
>Assignee: Enrico Olivelli
>Priority: Major
> Fix For: 3.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Not sure why resolving dependencies is needed for running Checkstyle, it does 
> slow down the build considerably. For Apache Camel this makes a ten fold 
> difference from ~20mins to ~2mins for running mvn checkstyle:check.
> Seems this was introduced with MCHECKSTYLE-163 but subsequently integration 
> test was removed in MCHECKSTYLE-272.
> I've created a GitHub pull request to address this:
> https://github.com/apache/maven-checkstyle-plugin/pull/5



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MCHECKSTYLE-377) Violations or exception when using FQCNs in @throws after upgrade to 3.1.0

2019-05-23 Thread Falko Modler (JIRA)
Falko Modler created MCHECKSTYLE-377:


 Summary: Violations or exception when using FQCNs in @throws after 
upgrade to 3.1.0
 Key: MCHECKSTYLE-377
 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-377
 Project: Maven Checkstyle Plugin
  Issue Type: Bug
Affects Versions: 3.1.0
 Environment: Apache Maven 3.6.1 
(d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00)
Java version: 1.8.0_202, vendor: Oracle Corporation
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Reporter: Falko Modler


I started to see strange violations and even exceptions after upgrading 
checkstyle-plugin from 3.0.0 and 3.1.0. Please note that I pinned Checkstyle to 
8.7, so the Checkstyle version itself did _not_ change in my setup.

The problem boils down to Checkstyle not being able anymore to load classes 
that reside in dependencies (= not im the same project as the checked class) 
when using fully qualified class names in {{@throws}} tags, e.g.:
{code:java}
/**
 * Foo.
 * @throws some.other.project.SomeException some exception.
 */
public void foo() throws SomeException {
// ...
}
{code}
Please note that the actual throws declaration does _not_ use the fully 
qualified class name.
While this might be an inconsistent/non DRY approach, it is not forbidden by 
JavaDoc or the compiler.

In one case (where the exception resides in an external dependency), this 
resulted in a violation:
{noformat}
JavadocMethod: Expected @throws tag for 'SomeException'.
{noformat}

In another case (where the exception resides in the same module but implements 
an interface that resides in another module of the project being built), this 
resulted in an exception:
{noformat}
[...]
Caused by: java.lang.NoClassDefFoundError: 
some/project/othermodule/SomeInterface
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:348)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.safeLoad(ClassResolver.java:216)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.resolve(ClassResolver.java:95)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.resolveClass(AbstractTypeAwareCheck.java:241)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.tryLoadClass(AbstractTypeAwareCheck.java:258)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck$RegularClass.getClazz(AbstractTypeAwareCheck.java:467)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkThrowsTags(JavadocMethodCheck.java:909)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkComment(JavadocMethodCheck.java:503)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.processAST(JavadocMethodCheck.java:357)
at 
com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.visitToken(AbstractTypeAwareCheck.java:157)
at 
com.puppycrawl.tools.checkstyle.TreeWalker.notifyVisit(TreeWalker.java:423)
at 
com.puppycrawl.tools.checkstyle.TreeWalker.processIter(TreeWalker.java:579)
at com.puppycrawl.tools.checkstyle.TreeWalker.walk(TreeWalker.java:363)
at 
com.puppycrawl.tools.checkstyle.TreeWalker.processFiltered(TreeWalker.java:208)
at 
com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:83)
at com.puppycrawl.tools.checkstyle.Checker.processFile(Checker.java:319)
at 
com.puppycrawl.tools.checkstyle.Checker.processFiles(Checker.java:289)
... 25 more
Caused by: java.lang.ClassNotFoundException: 
com.t_systems_mms.ccs.common.base.service.exception.ExceptionAttributeInterface
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 54 more
{noformat}

I guess this is caused by MCHECKSTYLE-353 (which does 

[jira] [Updated] (MCHECKSTYLE-377) Violations or exceptions when using FQCNs in @throws after upgrade to 3.1.0

2019-05-23 Thread Falko Modler (JIRA)


 [ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Falko Modler updated MCHECKSTYLE-377:
-
Summary: Violations or exceptions when using FQCNs in @throws after upgrade 
to 3.1.0  (was: Violations or exception when using FQCNs in @throws after 
upgrade to 3.1.0)

> Violations or exceptions when using FQCNs in @throws after upgrade to 3.1.0
> ---
>
> Key: MCHECKSTYLE-377
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-377
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.1 
> (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00)
> Java version: 1.8.0_202, vendor: Oracle Corporation
> Default locale: de_DE, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Falko Modler
>Priority: Major
>
> I started to see strange violations and even exceptions after upgrading 
> checkstyle-plugin from 3.0.0 and 3.1.0. Please note that I pinned Checkstyle 
> to 8.7, so the Checkstyle version itself did _not_ change in my setup.
> The problem boils down to Checkstyle not being able anymore to load classes 
> that reside in dependencies (= not im the same project as the checked class) 
> when using fully qualified class names in {{@throws}} tags, e.g.:
> {code:java}
> /**
>  * Foo.
>  * @throws some.other.project.SomeException some exception.
>  */
> public void foo() throws SomeException {
> // ...
> }
> {code}
> Please note that the actual throws declaration does _not_ use the fully 
> qualified class name.
> While this might be an inconsistent/non DRY approach, it is not forbidden by 
> JavaDoc or the compiler.
> In one case (where the exception resides in an external dependency), this 
> resulted in a violation:
> {noformat}
> JavadocMethod: Expected @throws tag for 'SomeException'.
> {noformat}
> In another case (where the exception resides in the same module but 
> implements an interface that resides in another module of the project being 
> built), this resulted in an exception:
> {noformat}
> [...]
> Caused by: java.lang.NoClassDefFoundError: 
> some/project/othermodule/SomeInterface
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> at 
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:348)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.safeLoad(ClassResolver.java:216)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.resolve(ClassResolver.java:95)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.resolveClass(AbstractTypeAwareCheck.java:241)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.tryLoadClass(AbstractTypeAwareCheck.java:258)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck$RegularClass.getClazz(AbstractTypeAwareCheck.java:467)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkThrowsTags(JavadocMethodCheck.java:909)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkComment(JavadocMethodCheck.java:503)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.processAST(JavadocMethodCheck.java:357)
> at 
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.visitToken(AbstractTypeAwareCheck.java:157)
> at 
> com.puppycrawl.tools.checkstyle.TreeWalker.notifyVisit(TreeWalker.java:423)
> at 
> com.puppycrawl.tools.checkstyle.TreeWalker.processIter(TreeWalker.java:579)
> at 
> com.puppycrawl.tools.checkstyle.TreeWalker.walk(TreeWalker.java:363)
> at 
> com.puppycrawl.tools.checkstyle.TreeWalker.processFiltered(TreeWalker.java:208)
> at 
> com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:83)
> at 
> 

[GitHub] [maven-surefire] cardil commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console

2019-05-23 Thread GitBox
cardil commented on a change in pull request #112: Adding support for 
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r286847301
 
 

 ##
 File path: pom.xml
 ##
 @@ -514,7 +514,7 @@
 
 
   maven-invoker-plugin
-  3.2.0
+  3.1.0
 
 Review comment:
   Update. Today, at work, I've run a same build with invoker `3.2.0` and it 
installed the file just fine. The error is when you restore build at a point. 
Like this: `mvn clean install -Prun-its -e -V -nsu -rf maven-failsafe-plugin`
   
   Full error:
   
   ```
   [INFO] --- maven-shade-plugin:3.1.1:shade (default) @ maven-failsafe-plugin 
---
   [INFO] Excluding 
org.apache.maven.surefire:maven-surefire-common:jar:3.0.0-SNAPSHOT from the 
shaded jar.
   [INFO] Excluding org.apache.maven.surefire:surefire-api:jar:3.0.0-SNAPSHOT 
from the shaded jar.
   [INFO] Excluding 
org.apache.maven.surefire:surefire-logger-api:jar:3.0.0-SNAPSHOT from the 
shaded jar.
   [INFO] Excluding 
org.apache.maven.surefire:surefire-booter:jar:3.0.0-SNAPSHOT from the shaded 
jar.
   [INFO] Excluding org.apache.maven:maven-toolchain:jar:3.0-alpha-2 from the 
shaded jar.
   [INFO] Excluding org.apache.maven.shared:maven-artifact-transfer:jar:0.11.0 
from the shaded jar.
   [INFO] Excluding 
org.apache.maven.shared:maven-common-artifact-filters:jar:3.1.0 from the shaded 
jar.
   [INFO] Excluding commons-codec:commons-codec:jar:1.11 from the shaded jar.
   [INFO] Excluding org.slf4j:slf4j-api:jar:1.7.5 from the shaded jar.
   [INFO] Excluding org.codehaus.plexus:plexus-java:jar:1.0.3 from the shaded 
jar.
   [INFO] Excluding org.ow2.asm:asm:jar:7.0 from the shaded jar.
   [INFO] Excluding com.thoughtworks.qdox:qdox:jar:2.0-M9 from the shaded jar.
   [INFO] Excluding org.apache.maven:maven-model:jar:3.0 from the shaded jar.
   [INFO] Excluding org.apache.maven:maven-artifact:jar:3.0 from the shaded jar.
   [INFO] Excluding org.apache.maven:maven-plugin-api:jar:3.0 from the shaded 
jar.
   [INFO] Excluding org.sonatype.sisu:sisu-inject-plexus:jar:1.4.2 from the 
shaded jar.
   [INFO] Excluding org.sonatype.sisu:sisu-inject-bean:jar:1.4.2 from the 
shaded jar.
   [INFO] Excluding org.sonatype.sisu:sisu-guice:jar:noaop:2.1.7 from the 
shaded jar.
   [INFO] Excluding org.codehaus.plexus:plexus-utils:jar:2.0.4 from the shaded 
jar.
   [INFO] Excluding org.codehaus.plexus:plexus-classworlds:jar:2.2.3 from the 
shaded jar.
   [INFO] Excluding org.codehaus.plexus:plexus-component-annotations:jar:1.7.1 
from the shaded jar.
   [INFO] Including org.apache.maven.shared:maven-shared-utils:jar:3.1.0 in the 
shaded jar.
   [INFO] Including org.apache.commons:commons-lang3:jar:3.8.1 in the shaded 
jar.
   [INFO] Including commons-io:commons-io:jar:2.6 in the shaded jar.
   [INFO] Minimizing jar 
org.apache.maven.plugins:maven-failsafe-plugin:maven-plugin:3.0.0-SNAPSHOT
   [INFO] Minimized 510 -> 105 (20%)
   [INFO] Replacing original artifact with shaded artifact.
   [INFO] Replacing 
C:\Users\ksuszynski\git\maven-surefire\maven-failsafe-plugin\target\maven-failsafe-plugin-3.0.0-SNAPSHOT.jar
 with 
C:\Users\ksuszynski\git\maven-surefire\maven-failsafe-plugin\target\maven-failsafe-plugin-3.0.0-SNAPSHOT-shaded.jar
   [INFO] Dependency-reduced POM written at: 
C:\Users\ksuszynski\git\maven-surefire\maven-failsafe-plugin\dependency-reduced-pom.xml
   [INFO]
   [INFO] --- maven-invoker-plugin:3.2.0:install (pre-its) @ 
maven-failsafe-plugin ---
   [INFO] 

   [INFO] Reactor Summary for Maven Failsafe Plugin 3.0.0-SNAPSHOT:
   [INFO]
   [INFO] Maven Failsafe Plugin .. FAILURE [ 20.944 
s]
   [INFO] Maven Surefire Report Plugin ... SKIPPED
   [INFO] Maven Surefire Integration Tests ... SKIPPED
   [INFO] 

   [INFO] BUILD FAILURE
   [INFO] 

   [INFO] Total time:  21.382 s
   [INFO] Finished at: 2019-05-23T11:05:28+02:00
   [INFO] 

   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-invoker-plugin:3.2.0:install (pre-its) on 
project maven-failsafe-plugin: Failed to install project dependencies: 
MavenProject: org.apache.maven.plugins:maven-failsafe-plugin:3.0.0-SNAPSHOT @ 
C:\Users\ksuszynski\git\maven-surefire\maven-failsafe-plugin\dependency-reduced-pom.xml:
 Failed to install project artifacts: null: Failed to install POM: null: 
NullPointerException -> [Help 1]
   org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
goal org.apache.maven.plugins:maven-invoker-plugin:3.2.0:install (pre-its) on 
project maven-failsafe-plugin: Failed to install project dependencies: 
MavenProject: 

[GitHub] [maven-surefire] cardil commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console

2019-05-23 Thread GitBox
cardil commented on a change in pull request #112: Adding support for 
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r286841579
 
 

 ##
 File path: 
surefire-its/src/test/resources/testng-parallel-suites/src/test/java/testng/suiteXml/TestNGSuiteTest.java
 ##
 @@ -28,16 +28,23 @@
  * @author mailto:tibordig...@apache.org;>Tibor Digana (tibor17)
  * @since 2.19
  */
-public class TestNGSuiteTest {
-   private static final AtomicInteger counter = new AtomicInteger();
+public class TestNGSuiteTest
+{
+private static final AtomicInteger counter = new AtomicInteger();
 
-   @Test
-   public void shouldRunAndPrintItself()
-   throws Exception
-   {
-   System.out.println( getClass().getSimpleName() + 
"#shouldRunAndPrintItself() "
-   + 
counter.incrementAndGet() + ".");
+@Test
+public void shouldRunAndPrintItself() throws Exception
+{
+String message = String.format(
+"%s#shouldRunAndPrintItself() %d.",
+getClass().getSimpleName(),
+counter.incrementAndGet()
+);
+TimeUnit.SECONDS.sleep( 1 );
 
-   TimeUnit.SECONDS.sleep( 2 );
-   }
+synchronized ( System.out )
 
 Review comment:
   It depends on how you write to `OutputStream`. Usually you got a single 
writer, like with using a logging framework. Every thread gets the same 
instance of writer. Such writer will usually buffer writing to a stream and in 
that way, each mesage is treated as separate. 
   
   In this test, there are seperate threads that write bytes directly to 
`OutputStream`, without buffering or synchronization. This is the reason that 
here synchronization helps. But it might or might not be needed in production 
code. It depends.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] cardil commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console

2019-05-23 Thread GitBox
cardil commented on a change in pull request #112: Adding support for 
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r286838689
 
 

 ##
 File path: pom.xml
 ##
 @@ -514,7 +514,7 @@
 
 
   maven-invoker-plugin
-  3.2.0
+  3.1.0
 
 Review comment:
   Yes. I should have written about it.
   
   I was getting errors when running the `mvn clean install -Prun-its -e -V 
-nsu` command while building the `maven-failsafe-plugin` subproject. These were 
NPE errors in the `InstallerTask` class for the `maven-invoker-plugin`. The 
errors were related to processing the `dependency-reduced-pom.xml` file.
   
   After downgrade to previous version, project build fine.
   
   I was building on OpenJDK 8u202 with Maven 3.6.0 on Ubuntu 18.04


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-indexer] sormuras commented on issue #27: [WIP] Add module descriptor information to ArtifactInfo

2019-05-23 Thread GitBox
sormuras commented on issue #27: [WIP] Add module descriptor information to 
ArtifactInfo
URL: https://github.com/apache/maven-indexer/pull/27#issuecomment-495117750
 
 
   Granted, that seems a legit use-case.
   
   But I need to clean up / re-do some edge cases before re-submitting this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-indexer] olamy commented on issue #27: [WIP] Add module descriptor information to ArtifactInfo

2019-05-23 Thread GitBox
olamy commented on issue #27: [WIP] Add module descriptor information to 
ArtifactInfo
URL: https://github.com/apache/maven-indexer/pull/27#issuecomment-495116468
 
 
   well Archiva can use it... and maybe others using maven indexer 
   so it worths having it merged..


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-surefire] seregamorph commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console

2019-05-23 Thread GitBox
seregamorph commented on a change in pull request #112: Adding support for 
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r286814972
 
 

 ##
 File path: pom.xml
 ##
 @@ -514,7 +514,7 @@
 
 
   maven-invoker-plugin
-  3.2.0
+  3.1.0
 
 Review comment:
   are you sure you intended this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-indexer] sormuras commented on issue #27: [WIP] Add module descriptor information to ArtifactInfo

2019-05-23 Thread GitBox
sormuras commented on issue #27: [WIP] Add module descriptor information to 
ArtifactInfo
URL: https://github.com/apache/maven-indexer/pull/27#issuecomment-495092796
 
 
   @jorlina explained it yesterday in a meetup.
   
   iirc, `maven-indexer` is *not* running directly on Sonatype's 
infrastructure. So changes made by this PR won't result in updates of their 
internal model used to populate their search web site.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-indexer] olamy commented on issue #27: [WIP] Add module descriptor information to ArtifactInfo

2019-05-23 Thread GitBox
olamy commented on issue #27: [WIP] Add module descriptor information to 
ArtifactInfo
URL: https://github.com/apache/maven-indexer/pull/27#issuecomment-495087159
 
 
   not sure to understand why you closed this pr?
   It could be very useful!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services