[GitHub] [maven-doxia-sitetools] smaarn edited a comment on issue #8: MSKINS-107: Added the meta generator entry.
smaarn edited a comment on issue #8: MSKINS-107: Added the meta generator entry. URL: https://github.com/apache/maven-doxia-sitetools/pull/8#issuecomment-502419906 Force pushed the alignment on the fluido-skin project, more specifically with apache/maven-fluido-skin@8fbba67529ef48792f531b74ffa9e4009c2cceeb This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-doxia-sitetools] smaarn edited a comment on issue #8: MSKINS-107: Added the meta generator entry.
smaarn edited a comment on issue #8: MSKINS-107: Added the meta generator entry. URL: https://github.com/apache/maven-doxia-sitetools/pull/8#issuecomment-502419906 Force pushed the alignment on the fluido-skin project, more specifically with apache/fluido-skin@8fbba67529ef48792f531b74ffa9e4009c2cceeb This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-doxia-sitetools] smaarn edited a comment on issue #8: MSKINS-107: Added the meta generator entry.
smaarn edited a comment on issue #8: MSKINS-107: Added the meta generator entry. URL: https://github.com/apache/maven-doxia-sitetools/pull/8#issuecomment-502419906 Force pushed the alignment on the fluido-skin project, more specifically with apache/fluido-skin#8fbba67529ef48792f531b74ffa9e4009c2cceeb This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-doxia-sitetools] smaarn commented on issue #8: MSKINS-107: Added the meta generator entry.
smaarn commented on issue #8: MSKINS-107: Added the meta generator entry. URL: https://github.com/apache/maven-doxia-sitetools/pull/8#issuecomment-502419906 Force pushed the alignment on the fluido-skin project. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-doxia-sitetools] smaarn commented on a change in pull request #8: MSKINS-107: Added the meta generator entry.
smaarn commented on a change in pull request #8: MSKINS-107: Added the meta generator entry. URL: https://github.com/apache/maven-doxia-sitetools/pull/8#discussion_r294067268 ## File path: doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm ## @@ -17,7 +17,7 @@ ## under the License. ## #parse( "default-site-macros.vm" ) -
[jira] [Commented] (MSKINS-107) Add "generator" meta tag in HTML head
[
https://issues.apache.org/jira/browse/MSKINS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864881#comment-16864881
]
Hudson commented on MSKINS-107:
---
Build succeeded in Jenkins: Maven TLP » maven-fluido-skin » master #12
See https://builds.apache.org/job/maven-box/job/maven-fluido-skin/job/master/12/
> Add "generator" meta tag in HTML head
> -
>
> Key: MSKINS-107
> URL: https://issues.apache.org/jira/browse/MSKINS-107
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Labels: up-for-grabs
> Fix For: fluido-1.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It shall be the same as the comment before the {{}} tag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MSKINS-107) Add "generator" meta tag in HTML head
[
https://issues.apache.org/jira/browse/MSKINS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MSKINS-107.
-
Resolution: Fixed
Fixed with
[8fbba67529ef48792f531b74ffa9e4009c2cceeb|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=8fbba67529ef48792f531b74ffa9e4009c2cceeb].
> Add "generator" meta tag in HTML head
> -
>
> Key: MSKINS-107
> URL: https://issues.apache.org/jira/browse/MSKINS-107
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Labels: up-for-grabs
> Fix For: fluido-1.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It shall be the same as the comment before the {{}} tag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-fluido-skin] asfgit closed pull request #9: MSKINS-107: Added the generator meta information to the generated HTML resources
asfgit closed pull request #9: MSKINS-107: Added the generator meta information to the generated HTML resources URL: https://github.com/apache/maven-fluido-skin/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-scm] michael-o commented on a change in pull request #90: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
michael-o commented on a change in pull request #90: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit URL: https://github.com/apache/maven-scm/pull/90#discussion_r294060679 ## File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remove/JGitRemoveCommand.java ## @@ -0,0 +1,79 @@ +package org.apache.maven.scm.provider.git.jgit.command.remove; +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ + +import java.util.List; + +import org.apache.maven.scm.ScmException; +import org.apache.maven.scm.ScmFile; +import org.apache.maven.scm.ScmFileSet; +import org.apache.maven.scm.ScmResult; +import org.apache.maven.scm.command.remove.AbstractRemoveCommand; +import org.apache.maven.scm.command.remove.RemoveScmResult; +import org.apache.maven.scm.provider.ScmProviderRepository; +import org.apache.maven.scm.provider.git.command.GitCommand; +import org.apache.maven.scm.provider.git.jgit.command.JGitUtils; +import org.eclipse.jgit.api.Git; + +/** + * @author mailto:tsakuma...@gmail.com";>Georg Tsakumagos + * @author Georg Tsakumagos + * @since 1.11.2.1 Review comment: This is obviously wrong. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-scm] michael-o commented on a change in pull request #90: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
michael-o commented on a change in pull request #90: [SCM-925] Implement
RemoveCommand in maven-scm-provider-jgit
URL: https://github.com/apache/maven-scm/pull/90#discussion_r294060757
##
File path:
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/remove/JGitRemoveCommand.java
##
@@ -0,0 +1,79 @@
+package org.apache.maven.scm.provider.git.jgit.command.remove;
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+import java.util.List;
+
+import org.apache.maven.scm.ScmException;
+import org.apache.maven.scm.ScmFile;
+import org.apache.maven.scm.ScmFileSet;
+import org.apache.maven.scm.ScmResult;
+import org.apache.maven.scm.command.remove.AbstractRemoveCommand;
+import org.apache.maven.scm.command.remove.RemoveScmResult;
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.git.command.GitCommand;
+import org.apache.maven.scm.provider.git.jgit.command.JGitUtils;
+import org.eclipse.jgit.api.Git;
+
+/**
+ * @author mailto:tsakuma...@gmail.com";>Georg Tsakumagos
+ * @author Georg Tsakumagos
+ * @since 1.11.2.1
+ */
+public class JGitRemoveCommand extends AbstractRemoveCommand implements
GitCommand {
+
+
+ @Override
+ protected ScmResult executeRemoveCommand(ScmProviderRepository
repository, ScmFileSet fileSet, String message)
+ throws ScmException {
+
+if ( fileSet.getFileList().isEmpty() )
+{
+throw new ScmException( "You must provide at least one
file/directory to remove (e.g. -Dincludes=...)" );
Review comment:
Make the message consistent with the `GitExeProvider`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-scm] michael-o commented on issue #90: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
michael-o commented on issue #90: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit URL: https://github.com/apache/maven-scm/pull/90#issuecomment-502402921 Can you also please come up with a test case? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-doxia-sitetools] michael-o commented on a change in pull request #8: MSKINS-107: Added the meta generator entry.
michael-o commented on a change in pull request #8: MSKINS-107: Added the meta generator entry. URL: https://github.com/apache/maven-doxia-sitetools/pull/8#discussion_r294060189 ## File path: doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm ## @@ -17,7 +17,7 @@ ## under the License. ## #parse( "default-site-macros.vm" ) -
[jira] [Commented] (MSKINS-107) Add "generator" meta tag in HTML head
[
https://issues.apache.org/jira/browse/MSKINS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864873#comment-16864873
]
Michael Osipov commented on MSKINS-107:
---
[~smaarn], please create an appropriate ticket for DOXIASITETOOLS too.
> Add "generator" meta tag in HTML head
> -
>
> Key: MSKINS-107
> URL: https://issues.apache.org/jira/browse/MSKINS-107
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Labels: up-for-grabs
> Fix For: fluido-1.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It shall be the same as the comment before the {{}} tag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MSKINS-107) Add "generator" meta tag in HTML head
[
https://issues.apache.org/jira/browse/MSKINS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MSKINS-107:
-
Assignee: Michael Osipov
> Add "generator" meta tag in HTML head
> -
>
> Key: MSKINS-107
> URL: https://issues.apache.org/jira/browse/MSKINS-107
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Labels: up-for-grabs
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It shall be the same as the comment before the {{}} tag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MSKINS-107) Add "generator" meta tag in HTML head
[
https://issues.apache.org/jira/browse/MSKINS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSKINS-107:
--
Fix Version/s: fluido-1.8
> Add "generator" meta tag in HTML head
> -
>
> Key: MSKINS-107
> URL: https://issues.apache.org/jira/browse/MSKINS-107
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Labels: up-for-grabs
> Fix For: fluido-1.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It shall be the same as the comment before the {{}} tag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MSKINS-106) Replace unregistered meta tags with standard ones
[ https://issues.apache.org/jira/browse/MSKINS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-106: -- Labels: up-for-grabs (was: ) > Replace unregistered meta tags with standard ones > - > > Key: MSKINS-106 > URL: https://issues.apache.org/jira/browse/MSKINS-106 > Project: Maven Skins > Issue Type: Sub-task > Components: Fluido Skin >Affects Versions: fluido-1.3.1 >Reporter: Michael Osipov >Priority: Major > Labels: up-for-grabs > > Issued errors: > bq. Bad value Date-Creation-mmdd for attribute name on element meta: > Keyword date-creation-mmdd is not registered. > and > bq. Bad value Date-Revision-mmdd for attribute name on element meta: > Keyword date-revision-mmdd is not registered. > Best approach would be to use well-accepted tags from Dublic Core, see: > http://stackoverflow.com/a/14893974/696632 > Reference: > https://html.spec.whatwg.org/multipage/semantics.html#the-meta-element and > https://wiki.whatwg.org/wiki/MetaExtensions -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MSKINS-103) Escape ampersands properly
[ https://issues.apache.org/jira/browse/MSKINS-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-103: -- Labels: up-for-grabs (was: ) > Escape ampersands properly > -- > > Key: MSKINS-103 > URL: https://issues.apache.org/jira/browse/MSKINS-103 > Project: Maven Skins > Issue Type: Sub-task > Components: Fluido Skin >Affects Versions: fluido-1.3.1 >Reporter: Michael Osipov >Priority: Major > Labels: up-for-grabs > > Issued error: > bq. & did not start a character reference. (& probably should have been > escaped as &.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MSKINS-105) Provide alt for all images
[ https://issues.apache.org/jira/browse/MSKINS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-105: -- Labels: up-for-grabs (was: ) > Provide alt for all images > -- > > Key: MSKINS-105 > URL: https://issues.apache.org/jira/browse/MSKINS-105 > Project: Maven Skins > Issue Type: Sub-task > Components: Fluido Skin >Affects Versions: fluido-1.3.1 >Reporter: Michael Osipov >Priority: Major > Labels: up-for-grabs > > Issued error: > bq. An img element must have an alt attribute, except under certain > conditions. For details, consult guidance on providing text alternatives for > images. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRELEASE-1023) Minor code cleanups
[ https://issues.apache.org/jira/browse/MRELEASE-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864872#comment-16864872 ] Hudson commented on MRELEASE-1023: -- Build failed in Jenkins: Maven TLP » maven-release » master #12 See https://builds.apache.org/job/maven-box/job/maven-release/job/master/12/ > Minor code cleanups > --- > > Key: MRELEASE-1023 > URL: https://issues.apache.org/jira/browse/MRELEASE-1023 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Davide Angelocola >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-doxia-sitetools] michael-o commented on a change in pull request #8: MSKINS-107: Added the meta generator entry.
michael-o commented on a change in pull request #8: MSKINS-107: Added the meta generator entry. URL: https://github.com/apache/maven-doxia-sitetools/pull/8#discussion_r294059590 ## File path: doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm ## @@ -17,7 +17,7 @@ ## under the License. ## #parse( "default-site-macros.vm" ) -
[jira] [Created] (MSITE-840) Create a post-site goal
QualiteSys QualiteSys created MSITE-840:
---
Summary: Create a post-site goal
Key: MSITE-840
URL: https://issues.apache.org/jira/browse/MSITE-840
Project: Maven Site Plugin
Issue Type: Wish
Reporter: QualiteSys QualiteSys
How to create a java post-site phase ?
I tried a AbstractMojo without success, for example :
/**
* Generation of post site phase to generate base64 binary files
*
* @goal qcrgoalreportingpost
*
* @phase post-site
*/
public class QcrReportingPostMojo
extends AbstractMojo
{
...
}
Thanks for your help
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-release] michael-o commented on issue #29: [MRELEASE-229] Implementation of RemoveScmTagPhase; updated maven-scm
michael-o commented on issue #29: [MRELEASE-229] Implementation of RemoveScmTagPhase; updated maven-scm URL: https://github.com/apache/maven-release/pull/29#issuecomment-502398593 I will look at this after the next SCM release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (MRELEASE-1023) Minor code cleanups
[ https://issues.apache.org/jira/browse/MRELEASE-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1023. Resolution: Fixed Fixed with [a94c76f77ef8df1b82e9eef370412ce9b23083a0|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=a94c76f77ef8df1b82e9eef370412ce9b23083a0 ]. > Minor code cleanups > --- > > Key: MRELEASE-1023 > URL: https://issues.apache.org/jira/browse/MRELEASE-1023 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Davide Angelocola >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-release] asfgit closed pull request #22: Cleanups
asfgit closed pull request #22: Cleanups URL: https://github.com/apache/maven-release/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (MNG-6680) Convert Maven Settings Builder to JSR 330
[ https://issues.apache.org/jira/browse/MNG-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6680. --- Resolution: Fixed Fixed with [c5ede2fef8b63cd5c75f8bc2f53aeaa75c629adc|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=c5ede2fef8b63cd5c75f8bc2f53aeaa75c629adc]. > Convert Maven Settings Builder to JSR 330 > - > > Key: MNG-6680 > URL: https://issues.apache.org/jira/browse/MNG-6680 > Project: Maven > Issue Type: Sub-task > Components: Settings >Affects Versions: 3.6.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven] asfgit closed pull request #246: [MNG-5577] Convert maven-settings-builder to JSR 330.
asfgit closed pull request #246: [MNG-5577] Convert maven-settings-builder to JSR 330. URL: https://github.com/apache/maven/pull/246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MRELEASE-1023) Minor code cleanups
[ https://issues.apache.org/jira/browse/MRELEASE-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1023: - Summary: Minor code cleanups (was: Minor cleanups) > Minor code cleanups > --- > > Key: MRELEASE-1023 > URL: https://issues.apache.org/jira/browse/MRELEASE-1023 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Davide Angelocola >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MRELEASE-1023) Minor cleanups
[ https://issues.apache.org/jira/browse/MRELEASE-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1023: - Summary: Minor cleanups (was: minor cleanups) > Minor cleanups > -- > > Key: MRELEASE-1023 > URL: https://issues.apache.org/jira/browse/MRELEASE-1023 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Davide Angelocola >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MRELEASE-1023) minor cleanups
[ https://issues.apache.org/jira/browse/MRELEASE-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1023: - Fix Version/s: 3.0.0 > minor cleanups > -- > > Key: MRELEASE-1023 > URL: https://issues.apache.org/jira/browse/MRELEASE-1023 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Davide Angelocola >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MRELEASE-1023) minor cleanups
[ https://issues.apache.org/jira/browse/MRELEASE-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRELEASE-1023: Assignee: Michael Osipov > minor cleanups > -- > > Key: MRELEASE-1023 > URL: https://issues.apache.org/jira/browse/MRELEASE-1023 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Davide Angelocola >Assignee: Michael Osipov >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-resolver-ant-tasks] michael-o commented on issue #1: Use a FileResource instead of PathElement for easier copy of path created by Resolve
michael-o commented on issue #1: Use a FileResource instead of PathElement for easier copy of path created by Resolve URL: https://github.com/apache/maven-resolver-ant-tasks/pull/1#issuecomment-502396684 JIRA issue and a suitable case for this please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-source-plugin] michael-o commented on issue #1: [MSOURCES-95] Fix source Jar is re-created even when sources are not changed
michael-o commented on issue #1: [MSOURCES-95] Fix source Jar is re-created even when sources are not changed URL: https://github.com/apache/maven-source-plugin/pull/1#issuecomment-502396594 Does this one still apply? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-filtering] michael-o closed pull request #2: [MSHARED-809] Upgrade plexus-utils 3.2.0
michael-o closed pull request #2: [MSHARED-809] Upgrade plexus-utils 3.2.0 URL: https://github.com/apache/maven-filtering/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MNG-6680) Convert Maven Settings Builder to JSR 330
Michael Osipov created MNG-6680: --- Summary: Convert Maven Settings Builder to JSR 330 Key: MNG-6680 URL: https://issues.apache.org/jira/browse/MNG-6680 Project: Maven Issue Type: Sub-task Components: Settings Affects Versions: 3.6.1 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.6.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven] michael-o commented on issue #233: [MNG-6562] added WARNING on default bindings plugins unlocked versions
michael-o commented on issue #233: [MNG-6562] added WARNING on default bindings plugins unlocked versions URL: https://github.com/apache/maven/pull/233#issuecomment-502388512 @hboutemy Do we want this for 3.6.2? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on issue #165: [MNG-6028] Include current goals in resume suggestion
michael-o commented on issue #165: [MNG-6028] Include current goals in resume suggestion URL: https://github.com/apache/maven/pull/165#issuecomment-502388387 @hboutemy if we cannot agree on something let's make it general with `` otherwise we have goals, phases, options and properties. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (MNG-6675) Make Resolver debug log messages for projects and plugins consistent
[ https://issues.apache.org/jira/browse/MNG-6675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6675. --- Resolution: Fixed Fixed with [c2f13f7e87acc95e7df4b2205303e2668c4a5445|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=c2f13f7e87acc95e7df4b2205303e2668c4a5445]. > Make Resolver debug log messages for projects and plugins consistent > > > Key: MNG-6675 > URL: https://issues.apache.org/jira/browse/MNG-6675 > Project: Maven > Issue Type: Improvement > Components: Logging >Affects Versions: 3.6.1 >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Copied from the PR: > The graph returned by the resolver after resolution is logged at debug level. > This pull request only updates those debug log messages to be consistent > across project and plugin resolution and to provide as much information as > possible to make users aware of what is going on. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven] asfgit closed pull request #253: [MNG-6675] Make Resolver debug log messages for projects and plugins …
asfgit closed pull request #253: [MNG-6675] Make Resolver debug log messages for projects and plugins … URL: https://github.com/apache/maven/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] asfgit closed pull request #124: Make resolver debug log messages for projects and plugins consistent.
asfgit closed pull request #124: Make resolver debug log messages for projects and plugins consistent. URL: https://github.com/apache/maven/pull/124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MPIR-381) Improve russian localization
[ https://issues.apache.org/jira/browse/MPIR-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864816#comment-16864816 ] Hudson commented on MPIR-381: - Build failed in Jenkins: Maven TLP » maven-project-info-reports-plugin » master #56 See https://builds.apache.org/job/maven-box/job/maven-project-info-reports-plugin/job/master/56/ > Improve russian localization > > > Key: MPIR-381 > URL: https://issues.apache.org/jira/browse/MPIR-381 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: plugins >Affects Versions: 3.0.0 >Reporter: Dmitry Samoshin >Assignee: Michael Osipov >Priority: Minor > Labels: pull-request-available > Fix For: 3.0.1 > > Time Spent: 40m > Remaining Estimate: 0h > > Add missing string constants, correct some stylistic, spelling and > punctuation errors. > > Github pull request: > [https://github.com/apache/maven-project-info-reports-plugin/pull/10] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MPIR-381) Improve russian localization
[ https://issues.apache.org/jira/browse/MPIR-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPIR-381. --- Resolution: Fixed Fixed with [bc1360cd76365e23435b567f5c1f14033bd2ca34|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=bc1360cd76365e23435b567f5c1f14033bd2ca34]. > Improve russian localization > > > Key: MPIR-381 > URL: https://issues.apache.org/jira/browse/MPIR-381 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: plugins >Affects Versions: 3.0.0 >Reporter: Dmitry Samoshin >Assignee: Michael Osipov >Priority: Minor > Labels: pull-request-available > Fix For: 3.0.1 > > Time Spent: 40m > Remaining Estimate: 0h > > Add missing string constants, correct some stylistic, spelling and > punctuation errors. > > Github pull request: > [https://github.com/apache/maven-project-info-reports-plugin/pull/10] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-project-info-reports-plugin] asfgit closed pull request #10: [MPIR-381] Improve russian localization
asfgit closed pull request #10: [MPIR-381] Improve russian localization URL: https://github.com/apache/maven-project-info-reports-plugin/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MPIR-381) Improve russian localization
[ https://issues.apache.org/jira/browse/MPIR-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-381: Fix Version/s: 3.0.1 > Improve russian localization > > > Key: MPIR-381 > URL: https://issues.apache.org/jira/browse/MPIR-381 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: plugins >Affects Versions: 3.0.0 >Reporter: Dmitry Samoshin >Assignee: Michael Osipov >Priority: Minor > Labels: pull-request-available > Fix For: 3.0.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Add missing string constants, correct some stylistic, spelling and > punctuation errors. > > Github pull request: > [https://github.com/apache/maven-project-info-reports-plugin/pull/10] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPIR-351) Adding functionality to dependencies goal in order to integrate with maven license plugin and source missing licenses from specified properties file.
[ https://issues.apache.org/jira/browse/MPIR-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864785#comment-16864785 ] Michael Osipov commented on MPIR-351: - I don't understand the benefit here. > Adding functionality to dependencies goal in order to integrate with maven > license plugin and source missing licenses from specified properties file. > - > > Key: MPIR-351 > URL: https://issues.apache.org/jira/browse/MPIR-351 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Affects Versions: 2.9 >Reporter: Aneesh Natarajan >Priority: Major > Labels: beginner, patch > > The maven license plugin produces a THIRD-PARTY.properties file with each of > the third party libraries with missing licensing information. The patch that > I am proposing uses those properties file to source licensing information > when developing the dependencies.html reports. It would include the following: > - Add configurable property dependency.license.resource that specifies > the path of the properties file > - Have MavenProject object source licensing information from properties > file, when license block is not available in pom.xml file of dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MPIR-351) Adding functionality to dependencies goal in order to integrate with maven license plugin and source missing licenses from specified properties file.
[ https://issues.apache.org/jira/browse/MPIR-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-351: Fix Version/s: waiting-for-feedback > Adding functionality to dependencies goal in order to integrate with maven > license plugin and source missing licenses from specified properties file. > - > > Key: MPIR-351 > URL: https://issues.apache.org/jira/browse/MPIR-351 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Affects Versions: 2.9 >Reporter: Aneesh Natarajan >Priority: Major > Labels: beginner, patch > Fix For: waiting-for-feedback > > > The maven license plugin produces a THIRD-PARTY.properties file with each of > the third party libraries with missing licensing information. The patch that > I am proposing uses those properties file to source licensing information > when developing the dependencies.html reports. It would include the following: > - Add configurable property dependency.license.resource that specifies > the path of the properties file > - Have MavenProject object source licensing information from properties > file, when license block is not available in pom.xml file of dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPIR-382) Group different license spellings together
[ https://issues.apache.org/jira/browse/MPIR-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864784#comment-16864784 ] Michael Osipov commented on MPIR-382: - Refusing to implement this because this fix the symptom not the cause. Request upsteam to fix their POMs. > Group different license spellings together > -- > > Key: MPIR-382 > URL: https://issues.apache.org/jira/browse/MPIR-382 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Affects Versions: 3.0.0 >Reporter: Vincent Privat >Priority: Major > Fix For: wontfix-candidate > > > The licenses report is not aware of the different possible spellings we can > find in all Maven dependencies published on Maven Central. This results in > any given license (for example, Apache 2.0) being listed several times. For > example, take a look to the seven variants listed in [maven-site-plugin > dependencies|http://maven.apache.org/plugins/maven-site-plugin/dependencies.html#Licenses]: > * Apache Public License 2.0 > * Apache License Version 2 > * Apache License, Version 2.0 > * Apache Software License - Version 2.0 > * Apache License 2.0 > * Apache License Version 2.0 > * The Apache Software License, Version 2.0 > On a large project, this makes the license report unreadable. The plugin > should detect all these variants denote the same license and group them > together. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MPIR-382) Group different license spellings together
[ https://issues.apache.org/jira/browse/MPIR-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-382: Fix Version/s: wontfix-candidate > Group different license spellings together > -- > > Key: MPIR-382 > URL: https://issues.apache.org/jira/browse/MPIR-382 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Affects Versions: 3.0.0 >Reporter: Vincent Privat >Priority: Major > Fix For: wontfix-candidate > > > The licenses report is not aware of the different possible spellings we can > find in all Maven dependencies published on Maven Central. This results in > any given license (for example, Apache 2.0) being listed several times. For > example, take a look to the seven variants listed in [maven-site-plugin > dependencies|http://maven.apache.org/plugins/maven-site-plugin/dependencies.html#Licenses]: > * Apache Public License 2.0 > * Apache License Version 2 > * Apache License, Version 2.0 > * Apache Software License - Version 2.0 > * Apache License 2.0 > * Apache License Version 2.0 > * The Apache Software License, Version 2.0 > On a large project, this makes the license report unreadable. The plugin > should detect all these variants denote the same license and group them > together. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6678) locked version range to a timestamped snapshot does not work
[
https://issues.apache.org/jira/browse/MNG-6678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864762#comment-16864762
]
Michael Osipov commented on MNG-6678:
-
You are abusing SNAPSHOTs as versions. Snapshots are moving targets. If you
want it fixed, tag and release it.
> locked version range to a timestamped snapshot does not work
>
>
> Key: MNG-6678
> URL: https://issues.apache.org/jira/browse/MNG-6678
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.6.0
>Reporter: James Nord
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> I had built and deployed a snapshot to our internal repo mananger (nexus) and
> then attempted to force the use of that artifact in a downstream project by
> using an explicit version range for that artifact.
> However when I tried to do this maven complained the version range could not
> be satisfied.
> for example the snapshot deployed with timestamp
> {{2.176.1.3-20190613.140544-1}} and the range I tried to use was
> {{[2.176.1.3-20190613.140544-1]}}
> in the {{maven-metadata.xml}} from the artifact root in the repo I see
> 2.176.1.3-SNAPSHOT is mentioned, and looking in the {{maven-metadata.xml}}
> for the 2.176.1.3-SNAPSHOT I do see it contains that in the list of
> {{snapshotVersions}}
> This appears to be to be a bug that the versionRange does not correctly
> identify a timestamped version as a SNAPSHOT and thus resolve the metadata
> for the snapshot correctly to see what versions of that SNAPSHOT are
> available.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-doxia-sitetools] michael-o commented on issue #8: MSKINS-107: Added the meta generator entry.
michael-o commented on issue #8: MSKINS-107: Added the meta generator entry. URL: https://github.com/apache/maven-doxia-sitetools/pull/8#issuecomment-502380631 LGTM, I will triage and merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (MJMOD-17) JDK10: IllegalArgument Exception
[
https://issues.apache.org/jira/browse/MJMOD-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864738#comment-16864738
]
Andrey edited comment on MJMOD-17 at 6/15/19 3:29 PM:
--
I was able to reproduce. Caused by:
{code:java}
Caused by: java.lang.IllegalArgumentException: Unsupported class file major
version 55
at org.objectweb.asm.ClassReader.(ClassReader.java:166)
at org.objectweb.asm.ClassReader.(ClassReader.java:148)
at org.objectweb.asm.ClassReader.(ClassReader.java:136)
at org.objectweb.asm.ClassReader.(ClassReader.java:237)
at
org.codehaus.plexus.languages.java.jpms.AsmModuleInfoParser.parse(AsmModuleInfoParser.java:89){code}
Upgraded asm to 7.1 fixed the issue.
was (Author: dernasherbrezon):
I was able to reproduced. Caused by:
{code:java}
Caused by: java.lang.IllegalArgumentException: Unsupported class file major
version 55
at org.objectweb.asm.ClassReader.(ClassReader.java:166)
at org.objectweb.asm.ClassReader.(ClassReader.java:148)
at org.objectweb.asm.ClassReader.(ClassReader.java:136)
at org.objectweb.asm.ClassReader.(ClassReader.java:237)
at
org.codehaus.plexus.languages.java.jpms.AsmModuleInfoParser.parse(AsmModuleInfoParser.java:89){code}
Upgraded asm to 7.1 fixed the issue.
> JDK10: IllegalArgument Exception
>
>
> Key: MJMOD-17
> URL: https://issues.apache.org/jira/browse/MJMOD-17
> Project: Maven JMod Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
> Fix For: 3.0.0-alpha-2
>
>
> Building a single module with JDK 10 fails with illegalArgumentException.
> Reference https://github.com/khmarbaise/simple-jdk9-maven
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJMOD-17) JDK10: IllegalArgument Exception
[
https://issues.apache.org/jira/browse/MJMOD-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864738#comment-16864738
]
Andrey commented on MJMOD-17:
-
I was able to reproduced. Caused by:
{code:java}
Caused by: java.lang.IllegalArgumentException: Unsupported class file major
version 55
at org.objectweb.asm.ClassReader.(ClassReader.java:166)
at org.objectweb.asm.ClassReader.(ClassReader.java:148)
at org.objectweb.asm.ClassReader.(ClassReader.java:136)
at org.objectweb.asm.ClassReader.(ClassReader.java:237)
at
org.codehaus.plexus.languages.java.jpms.AsmModuleInfoParser.parse(AsmModuleInfoParser.java:89){code}
Upgraded asm to 7.1 fixed the issue.
> JDK10: IllegalArgument Exception
>
>
> Key: MJMOD-17
> URL: https://issues.apache.org/jira/browse/MJMOD-17
> Project: Maven JMod Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
> Fix For: 3.0.0-alpha-2
>
>
> Building a single module with JDK 10 fails with illegalArgumentException.
> Reference https://github.com/khmarbaise/simple-jdk9-maven
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSKINS-107) Add "generator" meta tag in HTML head
[
https://issues.apache.org/jira/browse/MSKINS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864716#comment-16864716
]
Antoine Malliarakis commented on MSKINS-107:
To be fair, another alternative would be to customize the default skin's
velocity template this way the change would only impact default and fluido
skins.
> Add "generator" meta tag in HTML head
> -
>
> Key: MSKINS-107
> URL: https://issues.apache.org/jira/browse/MSKINS-107
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Reporter: Michael Osipov
>Priority: Major
> Labels: up-for-grabs
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It shall be the same as the comment before the {{}} tag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSKINS-107) Add "generator" meta tag in HTML head
[
https://issues.apache.org/jira/browse/MSKINS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864703#comment-16864703
]
Antoine Malliarakis commented on MSKINS-107:
Hello,
I took the liberty to implement this feature in attached PRs.
I'm not too sure about the process to follow and so on, so don't hesitate to
tell me if there's anything I missed (I think I added corresponding unit tests
/ integration tests wherever relavant).
One thing, though: there was no change involved for the default skin, but I had
to modify the default velocity template used by the doxia site renderer.
> Add "generator" meta tag in HTML head
> -
>
> Key: MSKINS-107
> URL: https://issues.apache.org/jira/browse/MSKINS-107
> Project: Maven Skins
> Issue Type: Task
> Components: Default Skin, Fluido Skin
>Reporter: Michael Osipov
>Priority: Major
> Labels: up-for-grabs
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It shall be the same as the comment before the {{}} tag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-doxia-sitetools] smaarn opened a new pull request #8: MSKINS-107: Added the meta generator entry.
smaarn opened a new pull request #8: MSKINS-107: Added the meta generator entry. URL: https://github.com/apache/maven-doxia-sitetools/pull/8 Added the generation of the meta entry of name "generator" mentioning the doxia site renderer being used. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (DOXIATOOLS-59) Link checker not handling anchors of fluido skin topbar very well
[
https://issues.apache.org/jira/browse/DOXIATOOLS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864699#comment-16864699
]
Chris Neve commented on DOXIATOOLS-59:
--
Cannot reproduce. See in bugfix.zip the project I generated. I followed these
steps:
* Create a project and add maven-site-plugin,
maven-project-info-reports-plugin and maven-linkcheck-plugin plugins to pom
* Create site.xml under src/site and populated it as documented above
* Run mvn clean install, then mvn site. Site is then generated under
target/site
* Run mvn linkcheck:linkcheck, which succeeds instead of failing as I
understood it would.
Did I reproduce the error wrong? Or does this issue no longer seem to exist?
Versions used:
* Fluido skin: 1.7 as documented above
* Site plugin: 3.7.1
* maven-project-info-reports-plugin: 3.0.0
* maven-linkcheck-plugin: 1.2 as documented above
> Link checker not handling anchors of fluido skin topbar very well
> -
>
> Key: DOXIATOOLS-59
> URL: https://issues.apache.org/jira/browse/DOXIATOOLS-59
> Project: Maven Doxia Tools
> Issue Type: Improvement
> Components: Doxia Linkcheck
>Affects Versions: doxia-linkcheck-1.2
>Reporter: Alix Lourme
>Priority: Minor
> Labels: up-for-grabs
> Attachments: bugfix.zip
>
>
> When you are using
> [maven-fluido-skin|https://maven.apache.org/skins/maven-fluido-skin/] with
> [topbar|https://maven.apache.org/skins/maven-fluido-skin/topbar/index.html],
> category menus are produced with a *single anchor* (*#*) like that:
> {code}
> Overview class="caret">
> {code}
> In this case, _maven-linkcheck-plugin_ fails. You can simply reproduce the
> problem with this _site.xml_:
> {code}
>
>
> org.apache.maven.skins
> maven-fluido-skin
> 1.7
>
>
>
> true
> false
>
>
>
>
> http://www.apache.org"; />
> https://maven.apache.org"; />
>
>
>
> {code}
>
> You can use *excludedLink* property, but the pattern to use in
> [LinkValidatorManager.matchPattern|https://github.com/apache/maven-doxia-linkcheck/blob/1afc9f52cecea900b0c21926973afc5460c7a12e/src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidatorManager.java#L337]
> is a little tricky to found :
> * # : All links page are excluded
> * ^#$ : Not found ... Java pattern seems not really used
> * *# : Do the trick finally
> Snippet for proof:
> {code}
> String pattern = "#";
> System.out.println(matchPattern("#", pattern)); // --> true
> System.out.println(matchPattern("#localLink", pattern)); // --> true
> System.out.println(matchPattern("http://fake.url.org/index.html#";,
> pattern)); // --> true
>
> System.out.println(matchPattern("http://fake.url.org/index.html#link";,
> pattern)); // --> true
> pattern = "^#$";
> System.out.println(matchPattern("#", pattern)); // --> false
> System.out.println(matchPattern("#localLink", pattern)); // --> false
> System.out.println(matchPattern("http://fake.url.org/index.html#";,
> pattern)); // --> false
>
> System.out.println(matchPattern("http://fake.url.org/index.html#link";,
> pattern)); // --> false
> pattern = "*#";
> System.out.println(matchPattern("#", pattern)); // --> true
> System.out.println(matchPattern("#localLink", pattern)); // --> false
> System.out.println(matchPattern("http://fake.url.org/index.html#";,
> pattern)); // --> false ... corner case ?
>
> System.out.println(matchPattern("http://fake.url.org/index.html#link";,
> pattern)); // --> false
> {code}
>
> Perhaps consider a single anchor (#) as valid link by default could be useful
> and avoiding some headlock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-fluido-skin] smaarn opened a new pull request #9: MSKINS-107: Added the generator meta information to the generated HTML resources
smaarn opened a new pull request #9: MSKINS-107: Added the generator meta information to the generated HTML resources URL: https://github.com/apache/maven-fluido-skin/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (DOXIATOOLS-59) Link checker not handling anchors of fluido skin topbar very well
[
https://issues.apache.org/jira/browse/DOXIATOOLS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Neve updated DOXIATOOLS-59:
-
Attachment: bugfix.zip
> Link checker not handling anchors of fluido skin topbar very well
> -
>
> Key: DOXIATOOLS-59
> URL: https://issues.apache.org/jira/browse/DOXIATOOLS-59
> Project: Maven Doxia Tools
> Issue Type: Improvement
> Components: Doxia Linkcheck
>Affects Versions: doxia-linkcheck-1.2
>Reporter: Alix Lourme
>Priority: Minor
> Labels: up-for-grabs
> Attachments: bugfix.zip
>
>
> When you are using
> [maven-fluido-skin|https://maven.apache.org/skins/maven-fluido-skin/] with
> [topbar|https://maven.apache.org/skins/maven-fluido-skin/topbar/index.html],
> category menus are produced with a *single anchor* (*#*) like that:
> {code}
> Overview class="caret">
> {code}
> In this case, _maven-linkcheck-plugin_ fails. You can simply reproduce the
> problem with this _site.xml_:
> {code}
>
>
> org.apache.maven.skins
> maven-fluido-skin
> 1.7
>
>
>
> true
> false
>
>
>
>
> http://www.apache.org"; />
> https://maven.apache.org"; />
>
>
>
> {code}
>
> You can use *excludedLink* property, but the pattern to use in
> [LinkValidatorManager.matchPattern|https://github.com/apache/maven-doxia-linkcheck/blob/1afc9f52cecea900b0c21926973afc5460c7a12e/src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidatorManager.java#L337]
> is a little tricky to found :
> * # : All links page are excluded
> * ^#$ : Not found ... Java pattern seems not really used
> * *# : Do the trick finally
> Snippet for proof:
> {code}
> String pattern = "#";
> System.out.println(matchPattern("#", pattern)); // --> true
> System.out.println(matchPattern("#localLink", pattern)); // --> true
> System.out.println(matchPattern("http://fake.url.org/index.html#";,
> pattern)); // --> true
>
> System.out.println(matchPattern("http://fake.url.org/index.html#link";,
> pattern)); // --> true
> pattern = "^#$";
> System.out.println(matchPattern("#", pattern)); // --> false
> System.out.println(matchPattern("#localLink", pattern)); // --> false
> System.out.println(matchPattern("http://fake.url.org/index.html#";,
> pattern)); // --> false
>
> System.out.println(matchPattern("http://fake.url.org/index.html#link";,
> pattern)); // --> false
> pattern = "*#";
> System.out.println(matchPattern("#", pattern)); // --> true
> System.out.println(matchPattern("#localLink", pattern)); // --> false
> System.out.println(matchPattern("http://fake.url.org/index.html#";,
> pattern)); // --> false ... corner case ?
>
> System.out.println(matchPattern("http://fake.url.org/index.html#link";,
> pattern)); // --> false
> {code}
>
> Perhaps consider a single anchor (#) as valid link by default could be useful
> and avoiding some headlock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MNG-6678) locked version range to a timestamped snapshot does not work
[
https://issues.apache.org/jira/browse/MNG-6678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864691#comment-16864691
]
James Nord edited comment on MNG-6678 at 6/15/19 1:55 PM:
--
> You cannot supply a snapshot with a timestamp
Huh a SNAPSHOT is a version that ends with "\-SNAPSHOT" or a timestamp
"-MMDD.HHMMSS\-#"
You can grab [https://github.com/jtnord/maven-test-project] and run "mvn
deploy" and then you should see it in the logs as being deployed as something
like "1.0.0-20190615.160423-1" (you may want to change the deployment URL to
a repo that will be consulted for resolution)
Take the version unique snapshot version (timestamp) and then use that in a
range in another project
{noformat}
org.jenkins-ci.test
module-5
[0.0.1-20190615.160423-1]
{noformat}
try and build that - and observe the failure
remove the range specifier so you are just using a version hint.
{noformat}
org.jenkins-ci.test
module-5
0.0.1-20190615.160423-1
{noformat}
try and build that and observe that it works as expected.
was (Author: jnord_cbs):
> You cannot supply a snapshot with a timestamp
Huh a SNAPSHOT is a version that ends with "-SNAPSHOT" or a timestamp
"MMDD.HHMMSS-#"
You can grab [https://github.com/jtnord/maven-test-project] and run "mvn
deploy" and then you should see it in the logs as being deployed as something
like "1.0.0-20190615.160423-1" (you may want to change the deployment URL to
a repo that will be consulted for resolution)
Take the version unique snapshot version (timestamp) and then use that in a
range in another project
{noformat}
org.jenkins-ci.test
module-5
[0.0.1-20190615.160423-1]
{noformat}
try and build that - and observe the failure
remove the range specifier so you are just using a version hint.
{noformat}
org.jenkins-ci.test
module-5
0.0.1-20190615.160423-1
{noformat}
try and build that and observe that it works as expected.
> locked version range to a timestamped snapshot does not work
>
>
> Key: MNG-6678
> URL: https://issues.apache.org/jira/browse/MNG-6678
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.6.0
>Reporter: James Nord
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> I had built and deployed a snapshot to our internal repo mananger (nexus) and
> then attempted to force the use of that artifact in a downstream project by
> using an explicit version range for that artifact.
> However when I tried to do this maven complained the version range could not
> be satisfied.
> for example the snapshot deployed with timestamp
> {{2.176.1.3-20190613.140544-1}} and the range I tried to use was
> {{[2.176.1.3-20190613.140544-1]}}
> in the {{maven-metadata.xml}} from the artifact root in the repo I see
> 2.176.1.3-SNAPSHOT is mentioned, and looking in the {{maven-metadata.xml}}
> for the 2.176.1.3-SNAPSHOT I do see it contains that in the list of
> {{snapshotVersions}}
> This appears to be to be a bug that the versionRange does not correctly
> identify a timestamped version as a SNAPSHOT and thus resolve the metadata
> for the snapshot correctly to see what versions of that SNAPSHOT are
> available.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MNG-6678) locked version range to a timestamped snapshot does not work
[
https://issues.apache.org/jira/browse/MNG-6678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864691#comment-16864691
]
James Nord edited comment on MNG-6678 at 6/15/19 1:54 PM:
--
> You cannot supply a snapshot with a timestamp
Huh a SNAPSHOT is a version that ends with "-SNAPSHOT" or a timestamp
"MMDD.HHMMSS-#"
You can grab [https://github.com/jtnord/maven-test-project] and run "mvn
deploy" and then you should see it in the logs as being deployed as something
like "1.0.0-20190615.160423-1" (you may want to change the deployment URL to
a repo that will be consulted for resolution)
Take the version unique snapshot version (timestamp) and then use that in a
range in another project
{noformat}
org.jenkins-ci.test
module-5
[0.0.1-20190615.160423-1]
{noformat}
try and build that - and observe the failure
remove the range specifier so you are just using a version hint.
{noformat}
org.jenkins-ci.test
module-5
0.0.1-20190615.160423-1
{noformat}
try and build that and observe that it works as expected.
was (Author: jnord_cbs):
> You cannot supply a snapshot with a timestamp
Huh a SNAPSHOT is a version that ends with "-SNAPSHOT" or a timestamp
"MMDD.HHMMSS-#"
You can grab [https://github.com/jtnord/maven-test-project] and run "mvn
deploy" and then you should see it in the logs as being deployed as something
like "1.0.0-20190615.160423-1" (you may want to change the deployment URL to
a repo that will be consulted for resolution)
Take the version unique snapshot version (timestamp) and then use that in a
range in another project
{noformat}
org.jenkins-ci.test
module-5
[0.0.1-20190615.160423-1]
{noformat}
try and build that - and observe the failure
remove the range specifier so you are just using a version hint.
{noformat}
org.jenkins-ci.test
module-5
0.0.1-20190615.160423-1
{noformat}
try and build that and observe that it works as expected.
> locked version range to a timestamped snapshot does not work
>
>
> Key: MNG-6678
> URL: https://issues.apache.org/jira/browse/MNG-6678
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.6.0
>Reporter: James Nord
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> I had built and deployed a snapshot to our internal repo mananger (nexus) and
> then attempted to force the use of that artifact in a downstream project by
> using an explicit version range for that artifact.
> However when I tried to do this maven complained the version range could not
> be satisfied.
> for example the snapshot deployed with timestamp
> {{2.176.1.3-20190613.140544-1}} and the range I tried to use was
> {{[2.176.1.3-20190613.140544-1]}}
> in the {{maven-metadata.xml}} from the artifact root in the repo I see
> 2.176.1.3-SNAPSHOT is mentioned, and looking in the {{maven-metadata.xml}}
> for the 2.176.1.3-SNAPSHOT I do see it contains that in the list of
> {{snapshotVersions}}
> This appears to be to be a bug that the versionRange does not correctly
> identify a timestamped version as a SNAPSHOT and thus resolve the metadata
> for the snapshot correctly to see what versions of that SNAPSHOT are
> available.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6678) locked version range to a timestamped snapshot does not work
[
https://issues.apache.org/jira/browse/MNG-6678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864691#comment-16864691
]
James Nord commented on MNG-6678:
-
> You cannot supply a snapshot with a timestamp
Huh a SNAPSHOT is a version that ends with "-SNAPSHOT" or a timestamp
"MMDD.HHMMSS-#"
You can grab [https://github.com/jtnord/maven-test-project] and run "mvn
deploy" and then you should see it in the logs as being deployed as something
like "1.0.0-20190615.160423-1" (you may want to change the deployment URL to
a repo that will be consulted for resolution)
Take the version unique snapshot version (timestamp) and then use that in a
range in another project
{noformat}
org.jenkins-ci.test
module-5
[0.0.1-20190615.160423-1]
{noformat}
try and build that - and observe the failure
remove the range specifier so you are just using a version hint.
{noformat}
org.jenkins-ci.test
module-5
0.0.1-20190615.160423-1
{noformat}
try and build that and observe that it works as expected.
> locked version range to a timestamped snapshot does not work
>
>
> Key: MNG-6678
> URL: https://issues.apache.org/jira/browse/MNG-6678
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.6.0
>Reporter: James Nord
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> I had built and deployed a snapshot to our internal repo mananger (nexus) and
> then attempted to force the use of that artifact in a downstream project by
> using an explicit version range for that artifact.
> However when I tried to do this maven complained the version range could not
> be satisfied.
> for example the snapshot deployed with timestamp
> {{2.176.1.3-20190613.140544-1}} and the range I tried to use was
> {{[2.176.1.3-20190613.140544-1]}}
> in the {{maven-metadata.xml}} from the artifact root in the repo I see
> 2.176.1.3-SNAPSHOT is mentioned, and looking in the {{maven-metadata.xml}}
> for the 2.176.1.3-SNAPSHOT I do see it contains that in the list of
> {{snapshotVersions}}
> This appears to be to be a bug that the versionRange does not correctly
> identify a timestamped version as a SNAPSHOT and thus resolve the metadata
> for the snapshot correctly to see what versions of that SNAPSHOT are
> available.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-archetypes] behrangsa opened a new pull request #3: Enabled generating Java 9+ projects as well as using JUnit 5.x
behrangsa opened a new pull request #3: Enabled generating Java 9+ projects as well as using JUnit 5.x URL: https://github.com/apache/maven-archetypes/pull/3 ## Enabled generating Java 9+ projects as well as using JUnit 5.x I have kept the plugin backwards compatible -- if `javaCompilerVersion` and `junitVersion` properties are not passed to the plugin it will work as before and generate a Java 1.8 project with JUnit 4.11. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1659) Log4j logger in TestExecutionListener corrupts Surefire's STDOUT.
[
https://issues.apache.org/jira/browse/SUREFIRE-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864660#comment-16864660
]
Tibor Digana commented on SUREFIRE-1659:
[~Srdo]
[~rkraneis]
I think this is caused by eager initialization of {{Launcher}} in Surefire
class {{JUnitPlatformProvider}}.
You can contribute in Surefire project at GitHub and fix it in a new pulrequest.
Try to encapsulate {{launcher}}, {{filters}} and {{configurationParameters}}
and initialize lazily in a new private method. The method {{invoke( Object
forkTestSet )}} should call {{startCapture( ( ConsoleOutputReceiver )
runListener )}} first and then lazy initialization.
> Log4j logger in TestExecutionListener corrupts Surefire's STDOUT.
> -
>
> Key: SUREFIRE-1659
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1659
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M3
>Reporter: Stig Rohde Døssing
>Priority: Major
> Attachments: surefire-stdout-corrupt.zip
>
>
> I have a project that registers a JUnit 5 TestExecutionListener. The
> TestExecutionListener contains an SLF4j Logger, using Log4j2 as the
> underlying library. There is a log4j2.xml on the classpath, logging to
> console, and Surefire is set up to redirect output.
> Running the tests gives the following result.
> {quote}
> [WARNING] Corrupted STDOUT by directly writing to native stream in forked JVM
> 1. See FAQ web page and the dump file ...
> {quote}
> I've attached a minimal reproduction.
> Doing either of the following eliminates the error:
> * Not having the log4j2.xml on the classpath
> * Not having the Logger in the TestExecutionListener
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
