[jira] [Updated] (MDEP-679) mvn dependency:analyze detected wrong transitive dependency

2020-03-09 Thread John Lin (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Lin updated MDEP-679:
--
Description: 
To illustrate this issue, I created a sample project here: 
[https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava]

The dependency tree is like this:
{code:java}
My app ---> ApacheJMeter_http ---> dnsjava
{code}
I didn't use any code directly from the artifact {{dnsjava}} in my app. I only 
used {{ApacheJMeter_http}}. However, the command {{mvn dependency:analyze}} 
will report a used undeclared dependency: {{dnsjava}}.
{code:java}
[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ 
maven-dependency-analyze-dnsjava ---
[WARNING] Used undeclared dependencies found:
[WARNING]dnsjava:dnsjava:jar:2.1.9:runtime {code}
It seems that the problem came from the line:
{code:java}
map.put("update", null);
{code}
If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE", 
null);}}, the problem will disappear. Therefore, I think there might be 
something to do with the string "update".

Note that this issue is not reproducible in maven-dependency-plugin:2.8.

  was:
To illustrate this issue, I created a sample project here: 
https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava

The dependency tree is like this:

{code}
My app ---> ApacheJMeter_http ---> dnsjava
{code}

I didn't use any code directly from the artifact {{dnsjava}} in my app. I only 
used {{ApacheJMeter_http}}. However, the command {{mvn dependency:analyze}} 
will report a used undeclared dependency: {{dnsjava}}.

It seems that the problem came from the line:

{code}
map.put("update", null);
{code}

If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE", 
null);}}, the problem will disappear. Therefore, I think there might be 
something to do with the string "update".

Note that this issue is not reproducible in maven-dependency-plugin:2.8.


> mvn dependency:analyze detected wrong transitive dependency
> ---
>
> Key: MDEP-679
> URL: https://issues.apache.org/jira/browse/MDEP-679
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: analyze
>Affects Versions: 3.1.1
>Reporter: John Lin
>Priority: Major
>
> To illustrate this issue, I created a sample project here: 
> [https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava]
> The dependency tree is like this:
> {code:java}
> My app ---> ApacheJMeter_http ---> dnsjava
> {code}
> I didn't use any code directly from the artifact {{dnsjava}} in my app. I 
> only used {{ApacheJMeter_http}}. However, the command {{mvn 
> dependency:analyze}} will report a used undeclared dependency: {{dnsjava}}.
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ 
> maven-dependency-analyze-dnsjava ---
> [WARNING] Used undeclared dependencies found:
> [WARNING]dnsjava:dnsjava:jar:2.1.9:runtime {code}
> It seems that the problem came from the line:
> {code:java}
> map.put("update", null);
> {code}
> If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE", 
> null);}}, the problem will disappear. Therefore, I think there might be 
> something to do with the string "update".
> Note that this issue is not reproducible in maven-dependency-plugin:2.8.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (WAGON-582) HttpMethodConfiguration#copy() performs a shallow copy only

2020-03-09 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/WAGON-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed WAGON-582.

Resolution: Fixed

Fixed with 
[c766255c469bd4560d447613a2ff66dc9c5be29c|https://gitbox.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=c766255c469bd4560d447613a2ff66dc9c5be29c].

> HttpMethodConfiguration#copy() performs a shallow copy only
> ---
>
> Key: WAGON-582
> URL: https://issues.apache.org/jira/browse/WAGON-582
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-http
>Affects Versions: 3.3.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.4.0
>
>
> The {{copy()}} method does the following: {{copy.setHeaders( getHeaders() 
> );}} same for parameters. It passes the reference of the {{Properties}} 
> object w/o creating a new instance and copying the content. All subsequent 
> instances share those and may modify those.
> To make things worse {{HttpConfiguration.DEFAULT_PUT}} is passed for {{PUT}}. 
> If a previous configuration modified {{http.protocol.expect-continue}} to 
> {{false}} this singleton is modified too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven] oopexpert commented on issue #328: [MNG-6866] extract methods, apply SLA in PluginDescriptorBuilder

2020-03-09 Thread GitBox
oopexpert commented on issue #328: [MNG-6866] extract methods, apply SLA in 
PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328#issuecomment-596801475
 
 
   looks green to me...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (WAGON-582) HttpMethodConfiguration#copy() performs a shallow copy only

2020-03-09 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/WAGON-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated WAGON-582:
-
Summary: HttpMethodConfiguration#copy() performs a shallow copy only  (was: 
HttpMethodConfiguration#copy() does a shallow copy only)

> HttpMethodConfiguration#copy() performs a shallow copy only
> ---
>
> Key: WAGON-582
> URL: https://issues.apache.org/jira/browse/WAGON-582
> Project: Maven Wagon
>  Issue Type: Bug
>  Components: wagon-http
>Affects Versions: 3.3.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.4.0
>
>
> The {{copy()}} method does the following: {{copy.setHeaders( getHeaders() 
> );}} same for parameters. It passes the reference of the {{Properties}} 
> object w/o creating a new instance and copying the content. All subsequent 
> instances share those and may modify those.
> To make things worse {{HttpConfiguration.DEFAULT_PUT}} is passed for {{PUT}}. 
> If a previous configuration modified {{http.protocol.expect-continue}} to 
> {{false}} this singleton is modified too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (WAGON-582) HttpMethodConfiguration#copy() does a shallow copy only

2020-03-09 Thread Michael Osipov (Jira)
Michael Osipov created WAGON-582:


 Summary: HttpMethodConfiguration#copy() does a shallow copy only
 Key: WAGON-582
 URL: https://issues.apache.org/jira/browse/WAGON-582
 Project: Maven Wagon
  Issue Type: Bug
  Components: wagon-http
Affects Versions: 3.3.4
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 3.4.0


The {{copy()}} method does the following: {{copy.setHeaders( getHeaders() );}} 
same for parameters. It passes the reference of the {{Properties}} object w/o 
creating a new instance and copying the content. All subsequent instances share 
those and may modify those.

To make things worse {{HttpConfiguration.DEFAULT_PUT}} is passed for {{PUT}}. 
If a previous configuration modified {{http.protocol.expect-continue}} to 
{{false}} this singleton is modified too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DOXIASITETOOLS-224) Update Plexus

2020-03-09 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055394#comment-17055394
 ] 

Michael Osipov commented on DOXIASITETOOLS-224:
---

This may also conflict with the underlying Maven container...

> Update Plexus
> -
>
> Key: DOXIASITETOOLS-224
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-224
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> We have multiple versions of different plexus artifacts, all very old. E.g. 
> we pull in both
>  
> 
>  org.codehaus.plexus
>  plexus-container-default
>  1.0-alpha-9
>  
>  
> and
>  
> 
>  org.codehaus.plexus
>  plexus-container-default
>  1.0-alpha-30
>  
>  
> The current version is 2.1.0. Get these upgraded. Some code changes are 
> probably required.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (WAGON-581) Upgrade HttpClient to 4.5.12

2020-03-09 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/WAGON-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed WAGON-581.

Resolution: Fixed

Fixed with 
[19e59b8d857263312b4d2430c865a2340acc5e1b|https://gitbox.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=19e59b8d857263312b4d2430c865a2340acc5e1b].

> Upgrade HttpClient to 4.5.12
> 
>
> Key: WAGON-581
> URL: https://issues.apache.org/jira/browse/WAGON-581
> Project: Maven Wagon
>  Issue Type: Dependency upgrade
>  Components: wagon-http
>Affects Versions: 3.3.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect

2020-03-09 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055362#comment-17055362
 ] 

Michael Osipov commented on MJAVADOC-642:
-

I can't find this property. Can you show me?

> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are 
> having, and I'd like to set isOffline to true.     I tried to do this my 
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't 
> seem to take effect.    Setting isOffline to true within the  
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect

2020-03-09 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MJAVADOC-642:

Fix Version/s: waiting-for-feedback

> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are 
> having, and I'd like to set isOffline to true.     I tried to do this my 
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't 
> seem to take effect.    Setting isOffline to true within the  
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MJAVADOC-600) -bottom parameter breaks some doclets

2020-03-09 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055358#comment-17055358
 ] 

Michael Osipov commented on MJAVADOC-600:
-

Can we have a sample project please?

> -bottom parameter breaks some doclets
> -
>
> Key: MJAVADOC-600
> URL: https://issues.apache.org/jira/browse/MJAVADOC-600
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Reporter: Stephen Parry
>Priority: Major
>
> When using with some custom doclets e.g. pdfdoclet 1.0.2, you cannot suppress 
> the -bottom parameter - :which causes the doclet to fail :
> {code:java}
> Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:javadoc (default-cli) on 
> project WordNetTestApp: An error has occurred in PDF Doclet Output report 
> generation:
> Exit code: 1 - javadoc: error - invalid flag: -bottom
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MJAVADOC-600) -bottom parameter breaks some doclets

2020-03-09 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MJAVADOC-600:

Fix Version/s: waiting-for-feedback

> -bottom parameter breaks some doclets
> -
>
> Key: MJAVADOC-600
> URL: https://issues.apache.org/jira/browse/MJAVADOC-600
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Reporter: Stephen Parry
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> When using with some custom doclets e.g. pdfdoclet 1.0.2, you cannot suppress 
> the -bottom parameter - :which causes the doclet to fail :
> {code:java}
> Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:javadoc (default-cli) on 
> project WordNetTestApp: An error has occurred in PDF Doclet Output report 
> generation:
> Exit code: 1 - javadoc: error - invalid flag: -bottom
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MJAVADOC-604) javadoc:fix on JDK8: NullPointerException

2020-03-09 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MJAVADOC-604:

Fix Version/s: waiting-for-feedback

> javadoc:fix on JDK8: NullPointerException
> -
>
> Key: MJAVADOC-604
> URL: https://issues.apache.org/jira/browse/MJAVADOC-604
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: fix
>Affects Versions: 3.1.0
> Environment: openjdk version "1.8.0_212"
> OpenJDK Runtime Environment (build 1.8.0_212-b04)
> OpenJDK 64-Bit Server VM (build 25.212-b04, mixed mode)
>Reporter: Graham Leggett
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> While attempting to run javadoc:fix on JDK8, we get the following 
> NullPointerException:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix (default-cli) on 
> project x-db: Execution default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix failed. 
> NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix (default-cli) on 
> project x-db: Execution default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix failed.
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-cli of goal org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix 
> failed.
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
>   ... 19 more
> Caused by: java.lang.NullPointerException
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.writeParamTag(AbstractFixJavadocMojo.java:2119)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateJavadocTags(AbstractFixJavadocMojo.java:2011)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateJavadocTags(AbstractFixJavadocMojo.java:1923)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateJavadocComment(AbstractFixJavadocMojo.java:1755)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateEntityComment(AbstractFixJavadocMojo.java:1621)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.fixMethodComment(AbstractFixJavadocMojo.java:1475)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.processFix(AbstractFixJavadocMojo.java:1089)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.execute(AbstractFixJavadocMojo.java:472)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
>   ... 20 more
> [ERROR] 
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/PluginEx

[jira] [Closed] (MJAVADOC-603) javadoc:fix failure on JDK10: java.lang.ClassNotFoundException: java.sql.Connection

2020-03-09 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MJAVADOC-603.
---
Resolution: Incomplete

No sample project provided within 9 months. If you have one, we can reopen.

> javadoc:fix failure on JDK10: java.lang.ClassNotFoundException: 
> java.sql.Connection
> ---
>
> Key: MJAVADOC-603
> URL: https://issues.apache.org/jira/browse/MJAVADOC-603
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: fix
>Affects Versions: 3.1.0
> Environment: java version "10.0.2" 2018-07-17
> Java(TM) SE Runtime Environment 18.3 (build 10.0.2+13)
> Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode)
>Reporter: Graham Leggett
>Priority: Major
>
> When trying to run javadoc:fix on the jdk as follows:
> {noformat}
> java version "10.0.2" 2018-07-17
> Java(TM) SE Runtime Environment 18.3 (build 10.0.2+13)
> Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode)
> {noformat}
> The javadoc plugin fails as follows:
> {noformat}
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-cli of goal org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix 
> failed: A required class was missing while executing 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix: java/sql/Connection
> {noformat}
> Last exception is as follows:
> {noformat}
> Caused by: java.lang.ClassNotFoundException: java.sql.Connection
> at java.net.URLClassLoader.findClass (URLClassLoader.java:466)
> at java.lang.ClassLoader.loadClass (ClassLoader.java:566)
> at java.lang.ClassLoader.loadClass (ClassLoader.java:499)
> at java.lang.Class.getDeclaredMethods0 (Native Method)
> at java.lang.Class.privateGetDeclaredMethods (Class.java:3119)
> at java.lang.Class.getDeclaredMethods (Class.java:2268)
> at org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.isInherited 
> (AbstractFixJavadocMojo.java:2802)
> at org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.isInherited 
> (AbstractFixJavadocMojo.java:2775)
> at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateJavadocComment 
> (AbstractFixJavadocMojo.java:1661)
> at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateEntityComment 
> (AbstractFixJavadocMojo.java:1621)
> at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.fixMethodComment 
> (AbstractFixJavadocMojo.java:1475)
> at org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.processFix 
> (AbstractFixJavadocMojo.java:1066)
> at org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.execute 
> (AbstractFixJavadocMojo.java:472)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:564)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> [ERROR] 
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, ple

[jira] [Commented] (MJAVADOC-604) javadoc:fix on JDK8: NullPointerException

2020-03-09 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055356#comment-17055356
 ] 

Michael Osipov commented on MJAVADOC-604:
-

Can we have a sample project please?

> javadoc:fix on JDK8: NullPointerException
> -
>
> Key: MJAVADOC-604
> URL: https://issues.apache.org/jira/browse/MJAVADOC-604
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: fix
>Affects Versions: 3.1.0
> Environment: openjdk version "1.8.0_212"
> OpenJDK Runtime Environment (build 1.8.0_212-b04)
> OpenJDK 64-Bit Server VM (build 25.212-b04, mixed mode)
>Reporter: Graham Leggett
>Priority: Major
>
> While attempting to run javadoc:fix on JDK8, we get the following 
> NullPointerException:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix (default-cli) on 
> project x-db: Execution default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix failed. 
> NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix (default-cli) on 
> project x-db: Execution default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix failed.
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-cli of goal org.apache.maven.plugins:maven-javadoc-plugin:3.1.0:fix 
> failed.
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
>   ... 19 more
> Caused by: java.lang.NullPointerException
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.writeParamTag(AbstractFixJavadocMojo.java:2119)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateJavadocTags(AbstractFixJavadocMojo.java:2011)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateJavadocTags(AbstractFixJavadocMojo.java:1923)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateJavadocComment(AbstractFixJavadocMojo.java:1755)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.updateEntityComment(AbstractFixJavadocMojo.java:1621)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.fixMethodComment(AbstractFixJavadocMojo.java:1475)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.processFix(AbstractFixJavadocMojo.java:1089)
>   at 
> org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.execute(AbstractFixJavadocMojo.java:472)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
>   ... 20 more
> [ERROR] 
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN

[jira] [Comment Edited] (MJAVADOC-615) Workaround for bug JDK-8212233 does no longer work in 3.1.1 when using Java 12

2020-03-09 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055351#comment-17055351
 ] 

Michael Osipov edited comment on MJAVADOC-615 at 3/9/20, 8:44 PM:
--

The JDK issue has been resolved. No need to take action.

See:
{noformat}
[INFO] --- maven-javadoc-plugin:3.1.0:javadoc (default-cli) @ mjavadoc-615 ---
[ERROR] Error fetching link: 
D:\Entwicklung\Projekte\mjavadoc-615\target\javadoc-bundle-options. Ignored it.
[INFO]
Loading source files for package com.example.mjavadoc615...
Constructing Javadoc information...
Standard Doclet version 13.0.2
Building tree for all the packages and classes...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\com\example\mjavadoc615\Foo.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\com\example\mjavadoc615\package-summary.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\com\example\mjavadoc615\package-tree.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\constant-values.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\com\example\mjavadoc615\class-use\Foo.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\com\example\mjavadoc615\package-use.html...
Building index for all the packages and classes...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\overview-tree.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\deprecated-list.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\index-all.html...
Building index for all classes...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\allclasses-index.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\allpackages-index.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\index.html...
Generating 
D:\Entwicklung\Projekte\mjavadoc-615\target\site\apidocs\help-doc.html...
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 5.946 s
[INFO] Finished at: 2020-03-09T21:43:31+01:00
[INFO] 
PS D:\Entwicklung\Projekte\mjavadoc-615>
{noformat}


was (Author: michael-o):
The JDK issue has been resolved. No need to take action.

> Workaround for bug JDK-8212233 does no longer work in 3.1.1 when using Java 12
> --
>
> Key: MJAVADOC-615
> URL: https://issues.apache.org/jira/browse/MJAVADOC-615
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: jar, javadoc
>Affects Versions: 3.1.1
>Reporter: Benedikt Ritter
>Assignee: Olivier Lamy
>Priority: Major
> Attachments: mjavadoc-615.tar.gz
>
>
> The workaround for 
> [JDK-8212233|https://bugs.openjdk.java.net/browse/JDK-8212233] does not 
> longer work in 3.1.1 when building on Java 12. The error being reported is:
> {{Exit code: 1 - javadoc: error - The code being documented uses packages in 
> the unnamed module, but the packages defined in 
> [https://docs.oracle.com/en/java/javase/12/docs/api/] are in named modules.}}
> The workaround for this was to add 8 to the 
> maven-javadoc-plugin configuration. This would fix the issue on Java 9,10 and 
> 12 in 3.1.0. On 11 it was still broken. When I updated to the 3.1.1 release, 
> my build started to fail on Java 12, although it worked before.
> I've attached a demo project and here is what I can observe when I run mvn 
> javadoc:javadoc:
>  
> ||Plugin version||Java Version||Result||
> |3.1.0|9|Success|
> |3.1.0|10|Success|
> |3.1.0|11|Failure|
> |3.1.0|12|*Success*|
> |3.1.1|9|Success|
> |3.1.1|10|Success|
> |3.1.1|11|Failure|
> |3.1.1|12|*Failure*|
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (MJAVADOC-615) Workaround for bug JDK-8212233 does no longer work in 3.1.1 when using Java 12

2020-03-09 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MJAVADOC-615.
---
Fix Version/s: (was: waiting-for-feedback)
   Resolution: Not A Problem

The JDK issue has been resolved. No need to take action.

> Workaround for bug JDK-8212233 does no longer work in 3.1.1 when using Java 12
> --
>
> Key: MJAVADOC-615
> URL: https://issues.apache.org/jira/browse/MJAVADOC-615
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: jar, javadoc
>Affects Versions: 3.1.1
>Reporter: Benedikt Ritter
>Assignee: Olivier Lamy
>Priority: Major
> Attachments: mjavadoc-615.tar.gz
>
>
> The workaround for 
> [JDK-8212233|https://bugs.openjdk.java.net/browse/JDK-8212233] does not 
> longer work in 3.1.1 when building on Java 12. The error being reported is:
> {{Exit code: 1 - javadoc: error - The code being documented uses packages in 
> the unnamed module, but the packages defined in 
> [https://docs.oracle.com/en/java/javase/12/docs/api/] are in named modules.}}
> The workaround for this was to add 8 to the 
> maven-javadoc-plugin configuration. This would fix the issue on Java 9,10 and 
> 12 in 3.1.0. On 11 it was still broken. When I updated to the 3.1.1 release, 
> my build started to fail on Java 12, although it worked before.
> I've attached a demo project and here is what I can observe when I run mvn 
> javadoc:javadoc:
>  
> ||Plugin version||Java Version||Result||
> |3.1.0|9|Success|
> |3.1.0|10|Success|
> |3.1.0|11|Failure|
> |3.1.0|12|*Success*|
> |3.1.1|9|Success|
> |3.1.1|10|Success|
> |3.1.1|11|Failure|
> |3.1.1|12|*Failure*|
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MJAVADOC-641) 3.1.1 does not handle proxy username or proxy password

2020-03-09 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055349#comment-17055349
 ] 

Michael Osipov commented on MJAVADOC-641:
-

You can set it in {{HttpURLConnection}} via code only, not via properties.

I can't help myself, see:

{noformat}
[mosipov@mika-ion 
/usr/ports/java/openjdk11/work/openjdk-jdk11u-jdk-11.0.6-10-1]$ grep -r  
'\.proxy' --include='**/*.java' src --color
src/java.base/share/classes/java/lang/reflect/Proxy.java:
GetPropertyAction.privilegedGetProperty("jdk.proxy.debug", "");
src/java.base/share/classes/java/lang/reflect/Proxy.java: * a 
non-exported package named com.sun.proxy.$MODULE.
src/java.base/share/classes/java/lang/reflect/Proxy.java:String 
mn = "jdk.proxy" + counter.incrementAndGet();
src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java:  
  "jdk.proxy.ProxyGenerator.saveGeneratedFiles")).booleanValue();
src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java: * Supports 
http/https/ftp.proxyHost, http/https/ftp.proxyPort,
src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java: * 
{"ftp", "ftp.proxy", "ftpProxy", "proxy", "socksProxy"},
src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java: *
  + ftp.proxyHost & ftp.proxyPort
src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java:
{"http", "http.proxy", "proxy", "socksProxy"},
src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java:
{"https", "https.proxy", "proxy", "socksProxy"},
src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java:
{"ftp", "ftp.proxy", "ftpProxy", "proxy", "socksProxy"},
src/java.base/share/classes/sun/net/www/http/HttpClient.java:
boolean compatible = Objects.equals(ret.proxy, p)
src/java.base/share/classes/sun/net/www/http/HttpClient.java:if 
(ret.proxy == Proxy.NO_PROXY || ret.proxy == null) {
src/java.base/share/classes/sun/net/www/protocol/http/Handler.java:
this.proxy = proxy;
src/java.base/share/classes/sun/net/www/protocol/http/Handler.java:
this.proxyPort = port;
src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:   
 p = getNetProperty("jdk.http.auth.proxying.disabledSchemes");
src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:   
 ret = NTLMAuthenticationProxy.proxy.create(true, host,
src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:   
 ret = NTLMAuthenticationProxy.proxy.create(false,
src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:   
  * _should_ denote a URL - let's hope for "http://my.proxy.org";
src/java.base/share/classes/sun/net/www/protocol/https/Handler.java:
this.proxy = proxy;
src/java.base/share/classes/sun/net/www/protocol/https/Handler.java:
this.proxyPort = port;
src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java: *  
https.proxyHost ... the host supporting SSL
src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java: *  
https.proxyPort ... port to use on proxyHost
src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java:// 
HttpClient.proxyDisabled will always be false, because we don't
src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java:
this.proxy = proxy;
src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java:
this.proxyDisabled = true;
src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java:
boolean compatible = ((ret.proxy != null && ret.proxy.equals(p)) ||
src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java:
(ret.proxy == null && p == Proxy.NO_PROXY))
src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java:
if (ret.proxy == Proxy.NO_PROXY || ret.proxy == null) {
src/java.base/share/classes/sun/reflect/misc/ReflectUtil.java:public static 
final String PROXY_PACKAGE = "com.sun.proxy";
src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java:
this.proxyActionName = proxyActionName;
src/java.desktop/share/classes/java/awt/Component.java:
parent.proxyEnableEvents(AWTEvent.FOCUS_EVENT_MASK);
src/java.desktop/share/classes/java/awt/Component.java:
parent.proxyEnableEvents(AWTEvent.KEY_EVENT_MASK);
src/java.desktop/share/classes/java/awt/Component.java:
parent.proxyEnableEvents(AWTEvent.MOUSE_EVENT_MASK);
src/java.desktop/share/classes/java/awt/Component.java:
parent.proxyEnableEvents(AWTEvent.MOUSE_MOTION_EVENT_MASK);
src/java.desktop/share/classes/java/awt/Component.java:
parent.proxyEnableEvents(AWTEvent.MOUSE_WHEEL_EVENT_MASK);
src/java.desktop/shar

[jira] [Commented] (MNG-6875) mvn test keeps failing after changes removed

2020-03-09 Thread Grigoriy Mikhalkin (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055325#comment-17055325
 ] 

Grigoriy Mikhalkin commented on MNG-6875:
-

[~khmarbaise] unfortunately, project is closed source. I will try to create 
reproducible example this weekend.

I ran plain command in terminal and use OpenJDK v1.8.0_242

> mvn test keeps failing after changes removed
> 
>
> Key: MNG-6875
> URL: https://issues.apache.org/jira/browse/MNG-6875
> Project: Maven
>  Issue Type: Bug
>Reporter: Grigoriy Mikhalkin
>Priority: Major
>
> Maven version: 3.6.0
> Problem: 
> After i created new branch and did few changes to code, i ran `mvn test` and 
> got formatting error:
>  
> {code:java}
> somefile has not been previously formatted. Please format file and commit 
> before running validation!{code}
>  
>  
> I stashed changes, so `git status` didn't displayed any changes between 
> master and branch, and ran `mvn test` again - still got same error.
>  
> Then i switched to master and ran `mvn test` - no errors. Switched to new 
> branch again - still having errors. Just in case, i tried to close my IDE and 
> log out/in - nothing helps.
>  
> From what i understand, even if there some changes in files, that git is not 
> tracking, `mvn test` should return identical results in both cases(as code in 
> master and branch are same). But in reality it's not the case. Probably, 
> maven stores some metadata about git branches, that can cause such behavior?
>  
> Btw, not sure if this is really problem with maven. Maybe someone can point 
> to right places to look at.
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-help-plugin] croister commented on a change in pull request #5: [MPH-164] - Effective-pom ignores artifact argument

2020-03-09 Thread GitBox
croister commented on a change in pull request #5: [MPH-164] - Effective-pom 
ignores artifact argument
URL: https://github.com/apache/maven-help-plugin/pull/5#discussion_r389907375
 
 

 ##
 File path: src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java
 ##
 @@ -111,6 +112,7 @@ public void execute()
 if ( StringUtils.isNotEmpty( artifact ) )
 {
 project = getMavenProject( artifact );
+projects = Collections.emptyList();
 
 Review comment:
   Those executions do not contain the new test included in my pull request.
   Please run that test without my fix to see why it is needed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] oopexpert commented on issue #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager

2020-03-09 Thread GitBox
oopexpert commented on issue #326: [MNG-6867] extract methods, apply SLA 
DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326#issuecomment-596722904
 
 
   I squashed and rebased...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] oopexpert commented on issue #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager

2020-03-09 Thread GitBox
oopexpert commented on issue #326: [MNG-6867] extract methods, apply SLA 
DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326#issuecomment-596713338
 
 
   > 
   > 
   > Can you please rebase to most recent master and squash your commits to a 
single one...you can force push on that branch ...
   
   ... which is?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] oopexpert opened a new pull request #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager

2020-03-09 Thread GitBox
oopexpert opened a new pull request #326: [MNG-6867] extract methods, apply SLA 
DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326
 
 
   Apply "extract method" refactoring to make methods smaller. Considering 
principle "single level of abstraction".


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] oopexpert closed pull request #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager

2020-03-09 Thread GitBox
oopexpert closed pull request #326: [MNG-6867] extract methods, apply SLA 
DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] oopexpert commented on issue #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager

2020-03-09 Thread GitBox
oopexpert commented on issue #326: [MNG-6867] extract methods, apply SLA 
DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326#issuecomment-596712246
 
 
   > 
   > 
   > Can you please rebase to most recent master and squash your commits to a 
single one...you can force push on that branch ...
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MJAVADOC-641) 3.1.1 does not handle proxy username or proxy password

2020-03-09 Thread Thomas Cunningham (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055297#comment-17055297
 ] 

Thomas Cunningham commented on MJAVADOC-641:


[[~michael-o]] maven-javadoc-plugin 3.0.1 seems to work fine though - it seems 
to somehow set the user and the password.     Is there a way to set the proxy 
user and password from the settings for HttpURLConnection?

> 3.1.1 does not handle proxy username or proxy password
> --
>
> Key: MJAVADOC-641
> URL: https://issues.apache.org/jira/browse/MJAVADOC-641
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: wontfix-candidate
>
>
> I'm seeing the following trying to build camel behind a firewall : 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.1:jar (attach-javadocs) on 
> project camel-util: MavenReportException: Error while generating Javadoc: 
> [ERROR] Exit code: 1 - javadoc: error - Error fetching URL: 
> https://download.oracle.com/javase/7/docs/api/
> [ERROR] javadoc: error - Error fetching URL: 
> [https://download.oracle.com/javaee/7/api/]
>  
> This is a new issue for us, and maven-javadoc-plugin 3.0.1 seems to work fine 
> while 3.1.1 gives this error.
>  
> I dug in a little and I think the issue is that in 3.0.1 handles proxy 
> username and password :
> [https://github.com/apache/maven-javadoc-plugin/blob/maven-javadoc-plugin-3.0.1/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L3606-L3614]
>  
> As far as I can see (and I might be missing something here), 3.1.1 does not : 
> [https://github.com/apache/maven-javadoc-plugin/blob/maven-javadoc-plugin-3.1.1/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L3674-L3690]
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven] khmarbaise edited a comment on issue #328: [MNG-6866] extract methods, apply SLA in PluginDescriptorBuilder

2020-03-09 Thread GitBox
khmarbaise edited a comment on issue #328: [MNG-6866] extract methods, apply 
SLA in PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328#issuecomment-596692334
 
 
   Lets see what CI 
says...https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6866/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] khmarbaise commented on issue #328: [MNG-6866] extract methods, apply SLA in PluginDescriptorBuilder

2020-03-09 Thread GitBox
khmarbaise commented on issue #328: [MNG-6866] extract methods, apply SLA in 
PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328#issuecomment-596692334
 
 
   Lets see what CI says...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven] khmarbaise commented on issue #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager

2020-03-09 Thread GitBox
khmarbaise commented on issue #326: [MNG-6867] extract methods, apply SLA 
DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326#issuecomment-596691192
 
 
   Can you please rebase to most recent master and squash your commits to a 
single one...you can force push on that branch ...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6872) Found CVEs in your dependencies - plexus-utils (tests)

2020-03-09 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055275#comment-17055275
 ] 

Hudson commented on MNG-6872:
-

Build succeeded in Jenkins: Maven TLP » maven » master #378

See https://builds.apache.org/job/maven-box/job/maven/job/master/378/

> Found CVEs in your dependencies - plexus-utils (tests)
> --
>
> Key: MNG-6872
> URL: https://issues.apache.org/jira/browse/MNG-6872
> Project: Maven
>  Issue Type: Dependency upgrade
>Affects Versions: 3.6.3
>Reporter: XuCongying
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.7.0
>
>
> I noticed some of your libraries contained CVEs. I suggest a library update 
> to avoid potential risks. See below for more details:
>  
> Vulnerable Library Version: org.codehaus.plexus : plexus-utils : 1.5.5
>   CVE ID: 
> [CVE-2017-1000487](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-1000487)
>   Import Path: 
> maven-core/src/test/resources-project-builder/micromailer/pom.xml
>   Suggested Safe Versions: 3.0.16, 3.0.17, 3.0.18, 3.0.19, 3.0.20, 3.0.21, 
> 3.0.22, 3.0.23, 3.0.24, 3.1.0, 3.1.1, 3.2.0, 3.2.1, 3.3.0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6865) copy in object scope rather in class scope

2020-03-09 Thread Arne Lewinski (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055273#comment-17055273
 ] 

Arne Lewinski commented on MNG-6865:


I did so far as I could. DefaultMavenExecutionRequest is the only implementing 
class I found.

> copy in object scope rather in class scope
> --
>
> Key: MNG-6865
> URL: https://issues.apache.org/jira/browse/MNG-6865
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Reporter: Arne Lewinski
>Priority: Minor
>
> This refactoring refers to a more intuitive API approach.
> The interface "MavenExecutionRequest" should provide an object scope method 
> to copy itself. This has to be implemented by each sub type of 
> "MavenExecutionRequest". Neverteless: I only found the class 
> "DefaultMavenExecutionRequest" implementing the interface.
>  # Providing an object scope copy method makes the usage less verbose.
>  # As the copy method is defined abstract: the MavenCli class got rid of the 
> concrete class "DefaultMavenExecutionRequest" dependency
> The static copy method should be declared deprecated and can be made private 
> in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6865) copy in object scope rather in class scope

2020-03-09 Thread Arne Lewinski (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055271#comment-17055271
 ] 

Arne Lewinski commented on MNG-6865:


https://github.com/apache/maven/pull/327

> copy in object scope rather in class scope
> --
>
> Key: MNG-6865
> URL: https://issues.apache.org/jira/browse/MNG-6865
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Reporter: Arne Lewinski
>Priority: Minor
>
> This refactoring refers to a more intuitive API approach.
> The interface "MavenExecutionRequest" should provide an object scope method 
> to copy itself. This has to be implemented by each sub type of 
> "MavenExecutionRequest". Neverteless: I only found the class 
> "DefaultMavenExecutionRequest" implementing the interface.
>  # Providing an object scope copy method makes the usage less verbose.
>  # As the copy method is defined abstract: the MavenCli class got rid of the 
> concrete class "DefaultMavenExecutionRequest" dependency
> The static copy method should be declared deprecated and can be made private 
> in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (MNG-6736) Parallel builds, module build order

2020-03-09 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MNG-6736.

Resolution: Cannot Reproduce

no further feedback.

> Parallel builds, module build order
> ---
>
> Key: MNG-6736
> URL: https://issues.apache.org/jira/browse/MNG-6736
> Project: Maven
>  Issue Type: New Feature
>  Components: Bootstrap & Build
>Affects Versions: 3.6.1
>Reporter: Wang Haiqi
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: image-2019-08-16-14-46-27-734.png
>
>
> !image-2019-08-16-14-46-27-734.png!
>  
> As above
> Maven-assembly-plugin is used in assembly module.
> assembly module should be the last build,but parallel builds cannot specify 
> the order of modules.
>  
> Most of the multi-module will eventually have an aggregation module, and how 
> can you specify that one of the modules built in parallel runs at the end



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6867) extract methods, apply SLA DefaultMavenPluginManager

2020-03-09 Thread Arne Lewinski (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055269#comment-17055269
 ] 

Arne Lewinski commented on MNG-6867:


https://github.com/apache/maven/pull/326

> extract methods, apply SLA DefaultMavenPluginManager
> 
>
> Key: MNG-6867
> URL: https://issues.apache.org/jira/browse/MNG-6867
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Reporter: Arne Lewinski
>Priority: Minor
>
> Apply "extract method" refactoring to make methods smaller. Considering 
> principle "single level of abstraction".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6865) copy in object scope rather in class scope

2020-03-09 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055251#comment-17055251
 ] 

Karl Heinz Marbaise commented on MNG-6865:
--

Have you taken a look where the interface {{MavenExecutionRequest}} is being 
used? That would be breaking change if we would change that interface isn't 
that the case? 

> copy in object scope rather in class scope
> --
>
> Key: MNG-6865
> URL: https://issues.apache.org/jira/browse/MNG-6865
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Reporter: Arne Lewinski
>Priority: Minor
>
> This refactoring refers to a more intuitive API approach.
> The interface "MavenExecutionRequest" should provide an object scope method 
> to copy itself. This has to be implemented by each sub type of 
> "MavenExecutionRequest". Neverteless: I only found the class 
> "DefaultMavenExecutionRequest" implementing the interface.
>  # Providing an object scope copy method makes the usage less verbose.
>  # As the copy method is defined abstract: the MavenCli class got rid of the 
> concrete class "DefaultMavenExecutionRequest" dependency
> The static copy method should be declared deprecated and can be made private 
> in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6866) PluginDescriptorBuilder build method very long

2020-03-09 Thread Arne Lewinski (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055250#comment-17055250
 ] 

Arne Lewinski commented on MNG-6866:


https://github.com/apache/maven/pull/328

> PluginDescriptorBuilder build method very long
> --
>
> Key: MNG-6866
> URL: https://issues.apache.org/jira/browse/MNG-6866
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Reporter: Arne Lewinski
>Priority: Minor
>
> The build method of the class ""PluginDescriptorBuilder" is very long.
> I suggest to extract several methods and harmonize the methodolgy to set all 
> values. It can follows the strict concept: extracting the necessary element 
> from the PlexusConfiguration and setting it on the PluginDescriptor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6866) PluginDescriptorBuilder build method very long

2020-03-09 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055245#comment-17055245
 ] 

Karl Heinz Marbaise commented on MNG-6866:
--

Feel free to make a pull request...

> PluginDescriptorBuilder build method very long
> --
>
> Key: MNG-6866
> URL: https://issues.apache.org/jira/browse/MNG-6866
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Reporter: Arne Lewinski
>Priority: Minor
>
> The build method of the class ""PluginDescriptorBuilder" is very long.
> I suggest to extract several methods and harmonize the methodolgy to set all 
> values. It can follows the strict concept: extracting the necessary element 
> from the PlexusConfiguration and setting it on the PluginDescriptor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6867) extract methods, apply SLA DefaultMavenPluginManager

2020-03-09 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055243#comment-17055243
 ] 

Karl Heinz Marbaise commented on MNG-6867:
--

What about offering a patch for your refactoring suggestions?

> extract methods, apply SLA DefaultMavenPluginManager
> 
>
> Key: MNG-6867
> URL: https://issues.apache.org/jira/browse/MNG-6867
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Reporter: Arne Lewinski
>Priority: Minor
>
> Apply "extract method" refactoring to make methods smaller. Considering 
> principle "single level of abstraction".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (MNG-6872) Found CVEs in your dependencies - plexus-utils (tests)

2020-03-09 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MNG-6872.

Resolution: Done

> Found CVEs in your dependencies - plexus-utils (tests)
> --
>
> Key: MNG-6872
> URL: https://issues.apache.org/jira/browse/MNG-6872
> Project: Maven
>  Issue Type: Dependency upgrade
>Affects Versions: 3.6.3
>Reporter: XuCongying
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.7.0
>
>
> I noticed some of your libraries contained CVEs. I suggest a library update 
> to avoid potential risks. See below for more details:
>  
> Vulnerable Library Version: org.codehaus.plexus : plexus-utils : 1.5.5
>   CVE ID: 
> [CVE-2017-1000487](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-1000487)
>   Import Path: 
> maven-core/src/test/resources-project-builder/micromailer/pom.xml
>   Suggested Safe Versions: 3.0.16, 3.0.17, 3.0.18, 3.0.19, 3.0.20, 3.0.21, 
> 3.0.22, 3.0.23, 3.0.24, 3.1.0, 3.1.1, 3.2.0, 3.2.1, 3.3.0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MNG-6872) Found CVEs in your dependencies - plexus-utils (tests)

2020-03-09 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MNG-6872:
-
Fix Version/s: 3.7.0

> Found CVEs in your dependencies - plexus-utils (tests)
> --
>
> Key: MNG-6872
> URL: https://issues.apache.org/jira/browse/MNG-6872
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: XuCongying
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.7.0
>
>
> I noticed some of your libraries contained CVEs. I suggest a library update 
> to avoid potential risks. See below for more details:
>  
> Vulnerable Library Version: org.codehaus.plexus : plexus-utils : 1.5.5
>   CVE ID: 
> [CVE-2017-1000487](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-1000487)
>   Import Path: 
> maven-core/src/test/resources-project-builder/micromailer/pom.xml
>   Suggested Safe Versions: 3.0.16, 3.0.17, 3.0.18, 3.0.19, 3.0.20, 3.0.21, 
> 3.0.22, 3.0.23, 3.0.24, 3.1.0, 3.1.1, 3.2.0, 3.2.1, 3.3.0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6872) Found CVEs in your dependencies - plexus-utils (tests)

2020-03-09 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055232#comment-17055232
 ] 

Karl Heinz Marbaise commented on MNG-6872:
--

Done in 
[9e92a93ab83e4fc8bc2fd9544198b735ed92d678|https://gitbox.apache.org/repos/asf?p=maven.git;a=commitdiff;h=9e92a93ab83e4fc8bc2fd9544198b735ed92d678]

> Found CVEs in your dependencies - plexus-utils (tests)
> --
>
> Key: MNG-6872
> URL: https://issues.apache.org/jira/browse/MNG-6872
> Project: Maven
>  Issue Type: Dependency upgrade
>Affects Versions: 3.6.3
>Reporter: XuCongying
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.7.0
>
>
> I noticed some of your libraries contained CVEs. I suggest a library update 
> to avoid potential risks. See below for more details:
>  
> Vulnerable Library Version: org.codehaus.plexus : plexus-utils : 1.5.5
>   CVE ID: 
> [CVE-2017-1000487](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-1000487)
>   Import Path: 
> maven-core/src/test/resources-project-builder/micromailer/pom.xml
>   Suggested Safe Versions: 3.0.16, 3.0.17, 3.0.18, 3.0.19, 3.0.20, 3.0.21, 
> 3.0.22, 3.0.23, 3.0.24, 3.1.0, 3.1.1, 3.2.0, 3.2.1, 3.3.0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MNG-6872) Found CVEs in your dependencies - plexus-utils (tests)

2020-03-09 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MNG-6872:
-
Affects Version/s: 3.6.3

> Found CVEs in your dependencies - plexus-utils (tests)
> --
>
> Key: MNG-6872
> URL: https://issues.apache.org/jira/browse/MNG-6872
> Project: Maven
>  Issue Type: Dependency upgrade
>Affects Versions: 3.6.3
>Reporter: XuCongying
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.7.0
>
>
> I noticed some of your libraries contained CVEs. I suggest a library update 
> to avoid potential risks. See below for more details:
>  
> Vulnerable Library Version: org.codehaus.plexus : plexus-utils : 1.5.5
>   CVE ID: 
> [CVE-2017-1000487](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-1000487)
>   Import Path: 
> maven-core/src/test/resources-project-builder/micromailer/pom.xml
>   Suggested Safe Versions: 3.0.16, 3.0.17, 3.0.18, 3.0.19, 3.0.20, 3.0.21, 
> 3.0.22, 3.0.23, 3.0.24, 3.1.0, 3.1.1, 3.2.0, 3.2.1, 3.3.0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (MASSEMBLY-917) Maven Assembly plugin produces strange warnings

2020-03-09 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MASSEMBLY-917.
-
Resolution: Invalid

> Maven Assembly plugin produces strange warnings
> ---
>
> Key: MASSEMBLY-917
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-917
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Seweryn Habdank-Wojewodzki
>Priority: Major
>
> I am not sure why and what is happening, but in my maven build, which uses 
> assembly plugin, I got strange warnings.
> They are really unexpected to me, as I am completely not sure what assembly 
> plugin is doing or trying to do behind the scene.
> Why it is trying to download anything from any fixed maven repo?
> Why it is even expecting my libraries are located in: sonatype, apache or 
> twitter repo?
> Why those and not others?
> What means transfer *from/to*? Is assembly plugin trying to send some 
> metadata to some repo?
> I would expect assembly plugin is going to *the* repository (configured one) 
> and there shall be done all libraries resolution. 
> Assembly plugin shall not got on its own to any not explicitly configured 
> repositories.
> {code}
> 10:14:08 [INFO] Downloading: 
> http://maven.twttr.com/com/mycompany/my/my-commons/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [INFO] Downloading: 
> http://repository.apache.org/snapshots/com/mycompany/my/my-commons/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [INFO] Downloading: 
> https://oss.sonatype.org/content/repositories/snapshots/com/mycompany/my/my-commons/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to Twitter 
> (http://maven.twttr.com/): maven.twttr.com: Name or service not known
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> apache.snapshots (http://repository.apache.org/snapshots): 
> repository.apache.org: Name or service not known
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> sonatype-nexus-snapshots 
> (https://oss.sonatype.org/content/repositories/snapshots): oss.sonatype.org: 
> Name or service not known
> 10:14:08 [INFO] Downloading: 
> http://repository.apache.org/snapshots/com/mycompany/my/my-parent/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [INFO] Downloading: 
> https://oss.sonatype.org/content/repositories/snapshots/com/mycompany/my/my-parent/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [INFO] Downloading: 
> http://maven.twttr.com/com/mycompany/my/my-parent/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-parent:3.2.3-SNAPSHOT/maven-metadata.xml from/to Twitter 
> (http://maven.twttr.com/): maven.twttr.com
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-parent:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> apache.snapshots (http://repository.apache.org/snapshots): 
> repository.apache.org
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-parent:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> sonatype-nexus-snapshots 
> (https://oss.sonatype.org/content/repositories/snapshots): oss.sonatype.org
> 10:14:08 [WARNING] Failure to transfer 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from 
> http://maven.twttr.com/ was cached in the local repository, resolution will 
> not be reattempted until the update interval of Twitter has elapsed or 
> updates are forced. Original error: Could not transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to Twitter 
> (http://maven.twttr.com/): maven.twttr.com: Name or service not known
> 10:14:08 [WARNING] Failure to transfer 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from 
> http://repository.apache.org/snapshots was cached in the local repository, 
> resolution will not be reattempted until the update interval of 
> apache.snapshots has elapsed or updates are forced. Original error: Could not 
> transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> apache.snapshots (http://repository.apache.org/snapshots): 
> repository.apache.org: Name or service not known
> 10:14:08 [WARNING] Failure to transfer 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from 
> https://oss.sonatype.org/content/repositories/snapshots was cached in the 
> local repository, resolution will not be reattempted until the update 
> interval of sonatype-nexus-snapshots has elapsed or updates are forced. 
> Original error: Could not transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metada

[jira] [Commented] (MASSEMBLY-917) Maven Assembly plugin produces strange warnings

2020-03-09 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MASSEMBLY-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055229#comment-17055229
 ] 

Karl Heinz Marbaise commented on MASSEMBLY-917:
---

The log files shows me that your configuration simple broken cause you are 
using codehaus and maven.twttr.com as repositories which I don't know if even 
existing...the first one codehaus has been closed a very long time ago ...the 
second one I simply don't know but I have my doubts ...this means it is a 
configuration issue not a bug. So I will close this. If you have further 
details don't hesitate to reopen the issue.

> Maven Assembly plugin produces strange warnings
> ---
>
> Key: MASSEMBLY-917
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-917
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Seweryn Habdank-Wojewodzki
>Priority: Major
>
> I am not sure why and what is happening, but in my maven build, which uses 
> assembly plugin, I got strange warnings.
> They are really unexpected to me, as I am completely not sure what assembly 
> plugin is doing or trying to do behind the scene.
> Why it is trying to download anything from any fixed maven repo?
> Why it is even expecting my libraries are located in: sonatype, apache or 
> twitter repo?
> Why those and not others?
> What means transfer *from/to*? Is assembly plugin trying to send some 
> metadata to some repo?
> I would expect assembly plugin is going to *the* repository (configured one) 
> and there shall be done all libraries resolution. 
> Assembly plugin shall not got on its own to any not explicitly configured 
> repositories.
> {code}
> 10:14:08 [INFO] Downloading: 
> http://maven.twttr.com/com/mycompany/my/my-commons/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [INFO] Downloading: 
> http://repository.apache.org/snapshots/com/mycompany/my/my-commons/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [INFO] Downloading: 
> https://oss.sonatype.org/content/repositories/snapshots/com/mycompany/my/my-commons/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to Twitter 
> (http://maven.twttr.com/): maven.twttr.com: Name or service not known
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> apache.snapshots (http://repository.apache.org/snapshots): 
> repository.apache.org: Name or service not known
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> sonatype-nexus-snapshots 
> (https://oss.sonatype.org/content/repositories/snapshots): oss.sonatype.org: 
> Name or service not known
> 10:14:08 [INFO] Downloading: 
> http://repository.apache.org/snapshots/com/mycompany/my/my-parent/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [INFO] Downloading: 
> https://oss.sonatype.org/content/repositories/snapshots/com/mycompany/my/my-parent/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [INFO] Downloading: 
> http://maven.twttr.com/com/mycompany/my/my-parent/3.2.3-SNAPSHOT/maven-metadata.xml
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-parent:3.2.3-SNAPSHOT/maven-metadata.xml from/to Twitter 
> (http://maven.twttr.com/): maven.twttr.com
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-parent:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> apache.snapshots (http://repository.apache.org/snapshots): 
> repository.apache.org
> 10:14:08 [WARNING] Could not transfer metadata 
> com.mycompany.my:my-parent:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> sonatype-nexus-snapshots 
> (https://oss.sonatype.org/content/repositories/snapshots): oss.sonatype.org
> 10:14:08 [WARNING] Failure to transfer 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from 
> http://maven.twttr.com/ was cached in the local repository, resolution will 
> not be reattempted until the update interval of Twitter has elapsed or 
> updates are forced. Original error: Could not transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to Twitter 
> (http://maven.twttr.com/): maven.twttr.com: Name or service not known
> 10:14:08 [WARNING] Failure to transfer 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from 
> http://repository.apache.org/snapshots was cached in the local repository, 
> resolution will not be reattempted until the update interval of 
> apache.snapshots has elapsed or updates are forced. Original error: Could not 
> transfer metadata 
> com.mycompany.my:my-commons:3.2.3-SNAPSHOT/maven-metadata.xml from/to 
> apache.snapshots (http://repository.apache.org/snapshots): 
> repository.apache.org: Name

[GitHub] [maven-help-plugin] khmarbaise commented on a change in pull request #5: [MPH-164] - Effective-pom ignores artifact argument

2020-03-09 Thread GitBox
khmarbaise commented on a change in pull request #5: [MPH-164] - Effective-pom 
ignores artifact argument
URL: https://github.com/apache/maven-help-plugin/pull/5#discussion_r389840014
 
 

 ##
 File path: src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java
 ##
 @@ -111,6 +112,7 @@ public void execute()
 if ( StringUtils.isNotEmpty( artifact ) )
 {
 project = getMavenProject( artifact );
+projects = Collections.emptyList();
 
 Review comment:
   I'm confused as well... cause all integration tests are running fine 
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-help-plugin/job/master/
 ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6875) mvn test keeps failing after changes removed

2020-03-09 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055222#comment-17055222
 ] 

Karl Heinz Marbaise commented on MNG-6875:
--

First it would be helpful to describe on which project you are working or even 
better if you have project which can be used to reproduce the behaviour. 
Furthermore are you running on plain command line or within an IDE ? Which Java 
version do you use?. Apart from that Maven does not store any kind of metadata 
about Git branches ...

If you have switched from one branch to another it could be the case that older 
plugin version might not identifying to rebuild parts (depends on the plugin 
versions you are using) but I can't tell you for sure cause I don't have the 
information .

> mvn test keeps failing after changes removed
> 
>
> Key: MNG-6875
> URL: https://issues.apache.org/jira/browse/MNG-6875
> Project: Maven
>  Issue Type: Bug
>Reporter: Grigoriy Mikhalkin
>Priority: Major
>
> Maven version: 3.6.0
> Problem: 
> After i created new branch and did few changes to code, i ran `mvn test` and 
> got formatting error:
>  
> {code:java}
> somefile has not been previously formatted. Please format file and commit 
> before running validation!{code}
>  
>  
> I stashed changes, so `git status` didn't displayed any changes between 
> master and branch, and ran `mvn test` again - still got same error.
>  
> Then i switched to master and ran `mvn test` - no errors. Switched to new 
> branch again - still having errors. Just in case, i tried to close my IDE and 
> log out/in - nothing helps.
>  
> From what i understand, even if there some changes in files, that git is not 
> tracking, `mvn test` should return identical results in both cases(as code in 
> master and branch are same). But in reality it's not the case. Probably, 
> maven stores some metadata about git branches, that can cause such behavior?
>  
> Btw, not sure if this is really problem with maven. Maybe someone can point 
> to right places to look at.
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (MNG-6875) mvn test keeps failing after changes removed

2020-03-09 Thread Grigoriy Mikhalkin (Jira)
Grigoriy Mikhalkin created MNG-6875:
---

 Summary: mvn test keeps failing after changes removed
 Key: MNG-6875
 URL: https://issues.apache.org/jira/browse/MNG-6875
 Project: Maven
  Issue Type: Bug
Reporter: Grigoriy Mikhalkin


Maven version: 3.6.0

Problem: 

After i created new branch and did few changes to code, i ran `mvn test` and 
got formatting error:

 
{code:java}
somefile has not been previously formatted. Please format file and commit 
before running validation!{code}
 

 

I stashed changes, so `git status` didn't displayed any changes between master 
and branch, and ran `mvn test` again - still got same error.

 

Then i switched to master and ran `mvn test` - no errors. Switched to new 
branch again - still having errors. Just in case, i tried to close my IDE and 
log out/in - nothing helps.

 

>From what i understand, even if there some changes in files, that git is not 
>tracking, `mvn test` should return identical results in both cases(as code in 
>master and branch are same). But in reality it's not the case. Probably, maven 
>stores some metadata about git branches, that can cause such behavior?

 

Btw, not sure if this is really problem with maven. Maybe someone can point to 
right places to look at.

  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-help-plugin] croister commented on a change in pull request #5: [MPH-164] - Effective-pom ignores artifact argument

2020-03-09 Thread GitBox
croister commented on a change in pull request #5: [MPH-164] - Effective-pom 
ignores artifact argument
URL: https://github.com/apache/maven-help-plugin/pull/5#discussion_r389759023
 
 

 ##
 File path: src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java
 ##
 @@ -111,6 +112,7 @@ public void execute()
 if ( StringUtils.isNotEmpty( artifact ) )
 {
 project = getMavenProject( artifact );
+projects = Collections.emptyList();
 
 Review comment:
   The shouldWriteAllEffectivePOMsInReactor() method checks if there is more 
than 1 item in projects and returns true even though the artifact argument has 
been provided which should override this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-help-plugin] croister commented on a change in pull request #5: [MPH-164] - Effective-pom ignores artifact argument

2020-03-09 Thread GitBox
croister commented on a change in pull request #5: [MPH-164] - Effective-pom 
ignores artifact argument
URL: https://github.com/apache/maven-help-plugin/pull/5#discussion_r389756444
 
 

 ##
 File path: src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java
 ##
 @@ -111,6 +112,7 @@ public void execute()
 if ( StringUtils.isNotEmpty( artifact ) )
 {
 project = getMavenProject( artifact );
+projects = Collections.emptyList();
 
 Review comment:
   Maven injects the list of poms (local and sub modules).
   Run the included integration test without my change to see what happens.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-help-plugin] michael-o commented on a change in pull request #5: [MPH-164] - Effective-pom ignores artifact argument

2020-03-09 Thread GitBox
michael-o commented on a change in pull request #5: [MPH-164] - Effective-pom 
ignores artifact argument
URL: https://github.com/apache/maven-help-plugin/pull/5#discussion_r389749340
 
 

 ##
 File path: src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java
 ##
 @@ -111,6 +112,7 @@ public void execute()
 if ( StringUtils.isNotEmpty( artifact ) )
 {
 project = getMavenProject( artifact );
+projects = Collections.emptyList();
 
 Review comment:
   I am confused why you do this? What else is injected?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MPH-164) Effective-pom ignores artifact argument

2020-03-09 Thread Christian Lindblom (Jira)


[ 
https://issues.apache.org/jira/browse/MPH-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055045#comment-17055045
 ] 

Christian Lindblom commented on MPH-164:


Pull request added: https://github.com/apache/maven-help-plugin/pull/5

> Effective-pom ignores artifact argument
> ---
>
> Key: MPH-164
> URL: https://issues.apache.org/jira/browse/MPH-164
> Project: Maven Help Plugin
>  Issue Type: Bug
>  Components: effective-pom
>Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.2.0
>Reporter: Christian Lindblom
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If the effective-pom command is executed with the artifact argument in a 
> module which has sub modules it ignores the artifact argument and outputs all 
> poms from the current module instead.
> The issue seems to have been introduced by MPH-105.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-help-plugin] croister opened a new pull request #5: [MPH-164] - Effective-pom ignores artifact argument

2020-03-09 Thread GitBox
croister opened a new pull request #5: [MPH-164] - Effective-pom ignores 
artifact argument
URL: https://github.com/apache/maven-help-plugin/pull/5
 
 
   Set the projects argument to an empty list to avoid processing
   the local pom when the artifact argument has been provided.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MPH) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line 
and body.
- [X] Format the pull request title like `[MPH-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MPH-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MPH-164) Effective-pom ignores artifact argument

2020-03-09 Thread Christian Lindblom (Jira)
Christian Lindblom created MPH-164:
--

 Summary: Effective-pom ignores artifact argument
 Key: MPH-164
 URL: https://issues.apache.org/jira/browse/MPH-164
 Project: Maven Help Plugin
  Issue Type: Bug
  Components: effective-pom
Affects Versions: 3.2.0, 3.1.1, 3.1.0, 3.0.1, 3.0.0
Reporter: Christian Lindblom


If the effective-pom command is executed with the artifact argument in a module 
which has sub modules it ignores the artifact argument and outputs all poms 
from the current module instead.

The issue seems to have been introduced by MPH-105.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect

2020-03-09 Thread Thomas Cunningham (Jira)
Thomas Cunningham created MJAVADOC-642:
--

 Summary: Setting maven.javadoc.isoffline seems to have no effect
 Key: MJAVADOC-642
 URL: https://issues.apache.org/jira/browse/MJAVADOC-642
 Project: Maven Javadoc Plugin
  Issue Type: Bug
  Components: jar
Affects Versions: 3.1.1
Reporter: Thomas Cunningham


I'm trying to work around MJAVADOC-641 and the proxy issues that we are having, 
and I'd like to set isOffline to true.     I tried to do this my setting 
-Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't seem to 
take effect.    Setting isOffline to true within the  allows my 
build to succeed.

Am I using the wrong command line property for isOffline?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MNGSITE-393) Remove references to Maven 2.x

2020-03-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold updated MNGSITE-393:
--
Description: 
Maven 3.x is over a decade old now and we're talking about Maven 4. It's time 
to clean out all the random discussion here and there about how Maven 2.x did 
things, differences between Maven 2 and 3, what works in Maven 3 but not 2, 
etc. 

Assume Maven 3.0 as the minimum, probably Maven 3.1.


  was:
Maven 3.x is over a decade old now and we're talking about Maven 4. It;s time 
to clean out all the random discussion here and there about how Maven 2.x did 
things, differences between Maven 2 and 3, what works in Maven 3 but not 2, 
etc. 

Assume Maven 3.0 as the minimum, probably Maven 3.1.



> Remove references to Maven 2.x
> --
>
> Key: MNGSITE-393
> URL: https://issues.apache.org/jira/browse/MNGSITE-393
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> Maven 3.x is over a decade old now and we're talking about Maven 4. It's time 
> to clean out all the random discussion here and there about how Maven 2.x did 
> things, differences between Maven 2 and 3, what works in Maven 3 but not 2, 
> etc. 
> Assume Maven 3.0 as the minimum, probably Maven 3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNGSITE-393) Remove references to Maven 2.x

2020-03-09 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054944#comment-17054944
 ] 

Michael Osipov commented on MNGSITE-393:


I fully agree with this.

> Remove references to Maven 2.x
> --
>
> Key: MNGSITE-393
> URL: https://issues.apache.org/jira/browse/MNGSITE-393
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> Maven 3.x is over a decade old now and we're talking about Maven 4. It;s time 
> to clean out all the random discussion here and there about how Maven 2.x did 
> things, differences between Maven 2 and 3, what works in Maven 3 but not 2, 
> etc. 
> Assume Maven 3.0 as the minimum, probably Maven 3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MJAVADOC-453) Using Alternate Doclet documentation example snippet is out of date and does not work

2020-03-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold updated MJAVADOC-453:
---
Component/s: (was: javadoc)

> Using Alternate Doclet documentation example snippet is out of date and does 
> not work
> -
>
> Key: MJAVADOC-453
> URL: https://issues.apache.org/jira/browse/MJAVADOC-453
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Reporter: Ljuba
>Priority: Minor
>  Labels: documentation
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Please, update documentation example on page [Using Alternate 
> Doclet|http://maven.apache.org/plugins/maven-javadoc-plugin/examples/alternate-doclet.html]
>  with following snippet  that works: 
> {code:xml}
>   
>   
>   
>   org.apache.maven.plugins
>   maven-javadoc-plugin
>   2.10.3
>   
>   
> org.umlgraph.doclet.UmlGraphDoc
>   
>   
>   org.umlgraph
>   
> umlgraph
>   5.6.6
>   
>   
> -views
>   
> true
>   
> -Xdoclint:none 
>   
>   
>   
>   
> {code}
> This is current documentation example snippet:
> {code:xml}
> 
>   ...
>(or )
> 
>   
> org.apache.maven.plugins
> maven-javadoc-plugin
> 2.10.3
> 
>   org.umlgraph.doclet.UmlGraphDoc
>   
>   
> org.umlgraph
> doclet
> 5.1
>   
>   -views
>   true
> 
>   
> ...
> 
>(or )
>   ...
> 
> {code}
> Current documentation example snippet yields this error:
> {noformat}
> UmlGraphDoc version 5.1, altering javadocs
> Building Package view for package ...
> Warning, could not find a line that matches the pattern ''.
>  Class diagram reference not inserted
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MJAVADOC-453) Using Alternate Doclet documentation example snippet is out of date and does not work

2020-03-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold updated MJAVADOC-453:
---
Priority: Minor  (was: Trivial)

> Using Alternate Doclet documentation example snippet is out of date and does 
> not work
> -
>
> Key: MJAVADOC-453
> URL: https://issues.apache.org/jira/browse/MJAVADOC-453
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Reporter: Ljuba
>Priority: Minor
>  Labels: documentation
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Please, update documentation example on page [Using Alternate 
> Doclet|http://maven.apache.org/plugins/maven-javadoc-plugin/examples/alternate-doclet.html]
>  with following snippet  that works: 
> {code:xml}
>   
>   
>   
>   org.apache.maven.plugins
>   maven-javadoc-plugin
>   2.10.3
>   
>   
> org.umlgraph.doclet.UmlGraphDoc
>   
>   
>   org.umlgraph
>   
> umlgraph
>   5.6.6
>   
>   
> -views
>   
> true
>   
> -Xdoclint:none 
>   
>   
>   
>   
> {code}
> This is current documentation example snippet:
> {code:xml}
> 
>   ...
>(or )
> 
>   
> org.apache.maven.plugins
> maven-javadoc-plugin
> 2.10.3
> 
>   org.umlgraph.doclet.UmlGraphDoc
>   
>   
> org.umlgraph
> doclet
> 5.1
>   
>   -views
>   true
> 
>   
> ...
> 
>(or )
>   ...
> 
> {code}
> Current documentation example snippet yields this error:
> {noformat}
> UmlGraphDoc version 5.1, altering javadocs
> Building Package view for package ...
> Warning, could not find a line that matches the pattern ''.
>  Class diagram reference not inserted
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #27: MJAVADOC-617 Normalize module path so that '..' in the path are resolved

2020-03-09 Thread GitBox
elharo commented on a change in pull request #27: MJAVADOC-617 Normalize module 
path so that '..' in the path are resolved
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/27#discussion_r389616079
 
 

 ##
 File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##
 @@ -2393,7 +2393,7 @@ protected void executeReport( Locale unusedLocale )
 List modulePaths = new LinkedList<>();
 for ( String module :  aggregatedProject.getModules() )
 {
-modulePaths.add( new File( aggregatedProject.getBasedir(), module 
).toPath() );
+modulePaths.add( new File( aggregatedProject.getBasedir(), module 
).toPath().normalize() );
 
 Review comment:
   You can probably use Paths.get here and avoid the File class completely.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MNGSITE-393) Remove references to Maven 2.x

2020-03-09 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MNGSITE-393:
-

 Summary: Remove references to Maven 2.x
 Key: MNGSITE-393
 URL: https://issues.apache.org/jira/browse/MNGSITE-393
 Project: Maven Project Web Site
  Issue Type: Improvement
Reporter: Elliotte Rusty Harold


Maven 3.x is over a decade old now and we're talking about Maven 4. It;s time 
to clean out all the random discussion here and there about how Maven 2.x did 
things, differences between Maven 2 and 3, what works in Maven 3 but not 2, 
etc. 

Assume Maven 3.0 as the minimum, probably Maven 3.1.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #32: [MJAVADOC-625] Support for multiple stylesheets

2020-03-09 Thread GitBox
elharo commented on a change in pull request #32: [MJAVADOC-625] Support for 
multiple stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#discussion_r389613504
 
 

 ##
 File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##
 @@ -1422,8 +1422,28 @@
  * stylesheetfile.
  */
 @Parameter( property = "stylesheetfile" )
-   private String stylesheetfile;
-
+private String stylesheetfile;
+
+/**
+ * Specifies the path of an additional HTML stylesheet file.
+ * @since 3.1.2
+ */
+@Parameter
+private String addStylesheet;
+
+/**
+ * Specifies the path of an additional HTML stylesheet file.
+ * Example:
+ * 
+ * 
 
 Review comment:
   are tag names like this typically nouns or verbs?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #32: [MJAVADOC-625] Support for multiple stylesheets

2020-03-09 Thread GitBox
elharo commented on a change in pull request #32: [MJAVADOC-625] Support for 
multiple stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#discussion_r389613876
 
 

 ##
 File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##
 @@ -2981,6 +3001,35 @@ private String getStylesheetFile( final File 
javadocOutputDirectory )
 
 return getResource( new File( javadocOutputDirectory, DEFAULT_CSS_NAME 
), stylesheetfile );
 }
+
+private String getAddStylesheet( final File javadocOutputDirectory, final 
String stylesheet )
+throws MavenReportException
+{
+if ( StringUtils.isEmpty( stylesheet ) )
+{
+return null;
+}
+
+File addstylesheetfile = new File( stylesheet );
 
 Review comment:
   additionalStyleheetFile


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #32: [MJAVADOC-625] Support for multiple stylesheets

2020-03-09 Thread GitBox
elharo commented on a change in pull request #32: [MJAVADOC-625] Support for 
multiple stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#discussion_r389613010
 
 

 ##
 File path: src/it/projects/MJAVADOC-625/pom.xml
 ##
 @@ -0,0 +1,46 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0";
+   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+   4.0.0
+   org.apache.maven.plugins.javadoc.it
+   mjavadoc-625
+   1.0.0-SNAPSHOT
+
+   https://issues.apache.org/jira/browse/MJAVADOC-625
+
+   
 
 Review comment:
   Maven project code style is 2 space indents in XML: 
https://maven.apache.org/developers/conventions/code.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #32: [MJAVADOC-625] Support for multiple stylesheets

2020-03-09 Thread GitBox
elharo commented on a change in pull request #32: [MJAVADOC-625] Support for 
multiple stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#discussion_r389613291
 
 

 ##
 File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##
 @@ -1422,8 +1422,28 @@
  * stylesheetfile.
  */
 @Parameter( property = "stylesheetfile" )
-   private String stylesheetfile;
-
+private String stylesheetfile;
+
+/**
+ * Specifies the path of an additional HTML stylesheet file.
+ * @since 3.1.2
+ */
+@Parameter
+private String addStylesheet;
 
 Review comment:
   additionalStylesheet


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #32: [MJAVADOC-625] Support for multiple stylesheets

2020-03-09 Thread GitBox
elharo commented on a change in pull request #32: [MJAVADOC-625] Support for 
multiple stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#discussion_r389614224
 
 

 ##
 File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##
 @@ -5432,6 +5481,17 @@ private void addStandardDocletOptions( File 
javadocOutputDirectory,
 
 addArgIfNotEmpty( arguments, "-stylesheetfile",
   JavadocUtil.quotedPathArgument( getStylesheetFile( 
javadocOutputDirectory ) ) );
+
+addArgIfNotEmpty( arguments, "--add-stylesheet",
+  JavadocUtil.quotedPathArgument( getAddStylesheet( 
javadocOutputDirectory, addStylesheet ) ) );
+if ( addStylesheets != null && addStylesheets.length != 0 )
+{
+for ( String as : addStylesheets )
 
 Review comment:
   as --> stylesheet


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #32: [MJAVADOC-625] Support for multiple stylesheets

2020-03-09 Thread GitBox
elharo commented on a change in pull request #32: [MJAVADOC-625] Support for 
multiple stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#discussion_r389613670
 
 

 ##
 File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##
 @@ -2981,6 +3001,35 @@ private String getStylesheetFile( final File 
javadocOutputDirectory )
 
 return getResource( new File( javadocOutputDirectory, DEFAULT_CSS_NAME 
), stylesheetfile );
 }
+
+private String getAddStylesheet( final File javadocOutputDirectory, final 
String stylesheet )
 
 Review comment:
   getAdditionalStylesheet


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #32: [MJAVADOC-625] Support for multiple stylesheets

2020-03-09 Thread GitBox
elharo commented on a change in pull request #32: [MJAVADOC-625] Support for 
multiple stylesheets
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/32#discussion_r389614020
 
 

 ##
 File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##
 @@ -2981,6 +3001,35 @@ private String getStylesheetFile( final File 
javadocOutputDirectory )
 
 return getResource( new File( javadocOutputDirectory, DEFAULT_CSS_NAME 
), stylesheetfile );
 }
+
+private String getAddStylesheet( final File javadocOutputDirectory, final 
String stylesheet )
+throws MavenReportException
+{
+if ( StringUtils.isEmpty( stylesheet ) )
+{
+return null;
+}
+
+File addstylesheetfile = new File( stylesheet );
+if ( addstylesheetfile.exists() )
+{
+String stylesheetfilename = getStylesheetFile( 
javadocOutputDirectory );
 
 Review comment:
   stylesheetFilename


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #31: [MJAVADOC-624] tagletArtifacts throws exception in case artifact is a Java 9+ module

2020-03-09 Thread GitBox
elharo commented on a change in pull request #31: [MJAVADOC-624] 
tagletArtifacts throws exception in case artifact is a Java 9+ module
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/31#discussion_r389611518
 
 

 ##
 File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
 ##
 @@ -735,6 +735,12 @@ protected static boolean validateEncoding( String 
charsetName )
 
 for ( String s : classes )
 
 Review comment:
   optional: s --> clazz


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Closed] (MJAVADOC-628) add javadoc.io link pattern when option is set to true

2020-03-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold closed MJAVADOC-628.
--

> add javadoc.io link pattern when  option is set to true
> ---
>
> Key: MJAVADOC-628
> URL: https://issues.apache.org/jira/browse/MJAVADOC-628
> Project: Maven Javadoc Plugin
>  Issue Type: New Feature
>  Components: javadoc
>Affects Versions: next-release
>Reporter: Max
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> For example, google gson ([https://github.com/google/gson]) has pointed their 
> javadoc to [https://www.javadoc.io/doc/com.google.code.gson/gson] on their 
> README.md. But currently, maven-javadoc-plugin will only try to fetch 
> [https://github.com/google/gson/apidoc/package-list] , which apparently is an 
> invalid address. It doesn't make sense to have github, a source control 
> system to keep track of generated files as well.
>   
>  Many popular libraries are hosting javadoc with 
> [javadoc.io|http://javadoc.io/] already (eg, mockito / spark), and the 
> pattern is very simple as well: 
> https://www.javadoc.io/doc/[group_id]/[artifact_id]/[version_id]/package-list
>  This will work with  tag, but that's quite tedious as everytime we 
> have to manually keep things in sync when we add / remove dependencies or 
> update dependency versions.
> Thus, it will be quite helpful if maven-javadoc-plugin can just automatically 
> try this url pattern from the dependency list as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (MJAVADOC-628) add javadoc.io link pattern when option is set to true

2020-03-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold resolved MJAVADOC-628.

Resolution: Not A Problem

closing per discussion on 
https://github.com/apache/maven-javadoc-plugin/pull/34 to use providers

> add javadoc.io link pattern when  option is set to true
> ---
>
> Key: MJAVADOC-628
> URL: https://issues.apache.org/jira/browse/MJAVADOC-628
> Project: Maven Javadoc Plugin
>  Issue Type: New Feature
>  Components: javadoc
>Affects Versions: next-release
>Reporter: Max
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> For example, google gson ([https://github.com/google/gson]) has pointed their 
> javadoc to [https://www.javadoc.io/doc/com.google.code.gson/gson] on their 
> README.md. But currently, maven-javadoc-plugin will only try to fetch 
> [https://github.com/google/gson/apidoc/package-list] , which apparently is an 
> invalid address. It doesn't make sense to have github, a source control 
> system to keep track of generated files as well.
>   
>  Many popular libraries are hosting javadoc with 
> [javadoc.io|http://javadoc.io/] already (eg, mockito / spark), and the 
> pattern is very simple as well: 
> https://www.javadoc.io/doc/[group_id]/[artifact_id]/[version_id]/package-list
>  This will work with  tag, but that's quite tedious as everytime we 
> have to manually keep things in sync when we add / remove dependencies or 
> update dependency versions.
> Thus, it will be quite helpful if maven-javadoc-plugin can just automatically 
> try this url pattern from the dependency list as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-javadoc-plugin] elharo commented on issue #34: [MJAVADOC-628] - add javadoc.io link pattern when option is …

2020-03-09 Thread GitBox
elharo commented on issue #34: [MJAVADOC-628] - add javadoc.io link pattern 
when  option is …
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/34#issuecomment-596479739
 
 
   Can we close this PR then?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (MJAVADOC-529) File is not accepted in sourcespath

2020-03-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold updated MJAVADOC-529:
---
Priority: Major  (was: Critical)

> File is not accepted in sourcespath
> ---
>
> Key: MJAVADOC-529
> URL: https://issues.apache.org/jira/browse/MJAVADOC-529
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.1
>Reporter: Michal Safr
>Priority: Major
>
> Hello guys
> As per official Javadoc spec, sourcepath can accept both directory and a file.
> [https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#documentingboth]
> {noformat}
> javadoc -d C:\home\html -sourcepath C:\home\src java.awt 
> C:\home\src\java\applet\Applet.java
> {noformat}
> However sourcepath in the maven javadoc plugin accepts only directory. From 
> AbstractJavadocMojo:
> {code:java}
> sourcePaths = JavadocUtil.pruneDirs( project, sourcePaths );
> {code}
> I'd need to be able to specify a combination of a package in sourcepath and a 
> specific java as in the example above.
> Thank you,
> Michal



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (MJAVADOC-621) Flaky "Error fetching URL" on https links

2020-03-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold closed MJAVADOC-621.
--

> Flaky "Error fetching URL" on https links
> -
>
> Key: MJAVADOC-621
> URL: https://issues.apache.org/jira/browse/MJAVADOC-621
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.1
> Environment: OS: Ubuntu Linux 18.04 | macOS Mohave 10.14.6
> Java: 1.8.0_222 | 1.8.0_181
> Maven: 3.6.1
> Javadoc Maven Plugin: 2.10.4, 3.1.1
>Reporter: Peter Ivanov
>Priority: Critical
> Fix For: waiting-for-feedback
>
>
> https://github.com/apache/ignite/blob/2d871005fdc5228479c0aa700e94b7c757e6deae/parent/pom.xml#L342
> When changed http to https, build started triggering Javadoc Warnings from 
> time to time with no visible pattern.
> It is reproduced on latest (3.1.1) version of Maven Javadoc Plugin
> {code}
> [WARNING] Javadoc Warnings
> [WARNING] javadoc: warning - Error fetching URL: 
> https://hadoop.apache.org/docs/current/api/
> {code}
> h3. Reproducer
> {code}
> git clone g...@github.com:apache/ignite.git
> cd ignite
> git checkout 2d871005fdc5228479c0aa700e94b7c757e6deae
> mvn clean package -pl :ignite-tools -am -DskipTests
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (MJAVADOC-621) Flaky "Error fetching URL" on https links

2020-03-09 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold resolved MJAVADOC-621.

Resolution: Invalid

not a bug in the javadoc plugin

> Flaky "Error fetching URL" on https links
> -
>
> Key: MJAVADOC-621
> URL: https://issues.apache.org/jira/browse/MJAVADOC-621
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.1
> Environment: OS: Ubuntu Linux 18.04 | macOS Mohave 10.14.6
> Java: 1.8.0_222 | 1.8.0_181
> Maven: 3.6.1
> Javadoc Maven Plugin: 2.10.4, 3.1.1
>Reporter: Peter Ivanov
>Priority: Critical
> Fix For: waiting-for-feedback
>
>
> https://github.com/apache/ignite/blob/2d871005fdc5228479c0aa700e94b7c757e6deae/parent/pom.xml#L342
> When changed http to https, build started triggering Javadoc Warnings from 
> time to time with no visible pattern.
> It is reproduced on latest (3.1.1) version of Maven Javadoc Plugin
> {code}
> [WARNING] Javadoc Warnings
> [WARNING] javadoc: warning - Error fetching URL: 
> https://hadoop.apache.org/docs/current/api/
> {code}
> h3. Reproducer
> {code}
> git clone g...@github.com:apache/ignite.git
> cd ignite
> git checkout 2d871005fdc5228479c0aa700e94b7c757e6deae
> mvn clean package -pl :ignite-tools -am -DskipTests
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-changes-plugin] elharo commented on issue #9: revert http updates

2020-03-09 Thread GitBox
elharo commented on issue #9: revert http updates
URL: 
https://github.com/apache/maven-changes-plugin/pull/9#issuecomment-596476873
 
 
   Just maybe this was caused by HTTPCLIENT-2047. Try 4.5.12 and see what 
happens.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-doxia-sitetools] elharo merged pull request #15: revert very old plexus to even older one

2020-03-09 Thread GitBox
elharo merged pull request #15: revert very old plexus to even older one
URL: https://github.com/apache/maven-doxia-sitetools/pull/15
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MDEP-679) mvn dependency:analyze detected wrong transitive dependency

2020-03-09 Thread John Lin (Jira)
John Lin created MDEP-679:
-

 Summary: mvn dependency:analyze detected wrong transitive 
dependency
 Key: MDEP-679
 URL: https://issues.apache.org/jira/browse/MDEP-679
 Project: Maven Dependency Plugin
  Issue Type: Bug
  Components: analyze
Affects Versions: 3.1.1
Reporter: John Lin


To illustrate this issue, I created a sample project here: 
https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava

The dependency tree is like this:

{code}
My app ---> ApacheJMeter_http ---> dnsjava
{code}

I didn't use any code directly from the artifact {{dnsjava}} in my app. I only 
used {{ApacheJMeter_http}}. However, the command {{mvn dependency:analyze}} 
will report a used undeclared dependency: {{dnsjava}}.

It seems that the problem came from the line:

{code}
map.put("update", null);
{code}

If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE", 
null);}}, the problem will disappear. Therefore, I think there might be 
something to do with the string "update".

Note that this issue is not reproducible in maven-dependency-plugin:2.8.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-invoker-plugin] pzygielo opened a new pull request #15: [MINVOKER-254] Bump groovy to the latest in 2.4

2020-03-09 Thread GitBox
pzygielo opened a new pull request #15: [MINVOKER-254] Bump groovy to the 
latest in 2.4
URL: https://github.com/apache/maven-invoker-plugin/pull/15
 
 
   As 
[3.2.2](https://issues.apache.org/jira/projects/MINVOKER/versions/12346157) is 
still unreleased, I think this change can be covered by 
[MINVOKER-254](https://issues.apache.org/jira/browse/MINVOKER-254).
   
   [Changes in Groovy 
2.4.19](http://groovy-lang.org/changelogs/changelog-2.4.19.html)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #54: [MNG-4660] Add integration test to show that --resume-from works

2020-03-09 Thread GitBox
MartinKanters commented on a change in pull request #54: [MNG-4660] Add 
integration test to show that --resume-from works
URL: 
https://github.com/apache/maven-integration-testing/pull/54#discussion_r389519663
 
 

 ##
 File path: 
core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
 ##
 @@ -231,6 +231,7 @@ public static Test suite()
 suite.addTestSuite( MavenITmng4679SnapshotUpdateInPluginTest.class );
 suite.addTestSuite( 
MavenITmng4677DisabledPluginConfigInheritanceTest.class );
 suite.addTestSuite( MavenITmng4666CoreRealmImportTest.class );
+suite.addTestSuite( MavenITmng4660ResumeFromTest.class );
 
 Review comment:
   I've put the test at the top of the list. Do you want us to change the 
javadoc (pointed out by Maarten above) or do you want to do that separately?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MJAVADOC-610) Support multirelease jar

2020-03-09 Thread Robert Scholte (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054717#comment-17054717
 ] 

Robert Scholte commented on MJAVADOC-610:
-

I've pushed a branch with an example. Not sure if it is complete.

> Support multirelease jar
> 
>
> Key: MJAVADOC-610
> URL: https://issues.apache.org/jira/browse/MJAVADOC-610
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>Affects Versions: 3.1.0
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.2.0
>
>
> When having a multirelease jar, all sourcefolders need to be added. Now only 
> the main sourcefolder is added.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Issue Comment Deleted] (MJAVADOC-610) Support multirelease jar

2020-03-09 Thread Robert Scholte (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MJAVADOC-610:

Comment: was deleted

(was: I've pushed a branch with an integration test)

> Support multirelease jar
> 
>
> Key: MJAVADOC-610
> URL: https://issues.apache.org/jira/browse/MJAVADOC-610
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>Affects Versions: 3.1.0
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.2.0
>
>
> When having a multirelease jar, all sourcefolders need to be added. Now only 
> the main sourcefolder is added.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MJAVADOC-610) Support multirelease jar

2020-03-09 Thread Robert Scholte (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054715#comment-17054715
 ] 

Robert Scholte commented on MJAVADOC-610:
-

I've pushed a branch with an integration test

> Support multirelease jar
> 
>
> Key: MJAVADOC-610
> URL: https://issues.apache.org/jira/browse/MJAVADOC-610
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>Affects Versions: 3.1.0
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.2.0
>
>
> When having a multirelease jar, all sourcefolders need to be added. Now only 
> the main sourcefolder is added.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)