[jira] [Commented] (MNG-5001) @readonly Mojo parameter annotation doesn't work
[
https://issues.apache.org/jira/browse/MNG-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061350#comment-17061350
]
Herve Boutemy commented on MNG-5001:
core IT created in
https://github.com/apache/maven-integration-testing/tree/MNG-5001
> @readonly Mojo parameter annotation doesn't work
>
>
> Key: MNG-5001
> URL: https://issues.apache.org/jira/browse/MNG-5001
> Project: Maven
> Issue Type: Bug
> Components: Plugin API
>Affects Versions: 3.0.2
>Reporter: Jochen Ehret
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.7.0-candidate
>
> Attachments: log-maven-2.2.1.txt, log-maven-3.0.2.txt,
> readonlytest.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In Maven 2.2.1, the @readonly annotation works as described: You can't
> configure a Mojo parameter in the pom section. If you do, the
> build will fail:
> {noformat}[INFO] Error configuring: test:test-plugin. Reason: ERROR: Cannot
> override read-only parameter: testParameter in goal:
> test:dumpParameter{noformat}
> In Maven 3.0.2, the @readonly seems to have no effect:
> {noformat}[INFO] --- test-plugin:0.0.1-SNAPSHOT:dumpParameter (test-exec) @
> test-project ---
> testParameter: readonly parameter configured in pom{noformat}
> You can reproduce the behaviour with the attached example project. Log
> outputs for Maven 2.2.1 and 3.0.2 are also attached.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] hboutemy commented on issue #240: [MNG-5001] Block the option to set Mojo parameters marked as @readonly
hboutemy commented on issue #240: [MNG-5001] Block the option to set Mojo parameters marked as @readonly URL: https://github.com/apache/maven/pull/240#issuecomment-600399322 core IT prepared in MNG-5001 branch https://github.com/apache/maven-integration-testing/tree/MNG-5001 @slachiewicz can you create a branch on Maven core to test and finish this feature, please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MDEP-679) mvn dependency:analyze detected wrong transitive dependency
[
https://issues.apache.org/jira/browse/MDEP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061283#comment-17061283
]
John Lin commented on MDEP-679:
---
I've submitted a PR:
[https://github.com/apache/maven-dependency-analyzer/pull/7]
The root cause is that the component that parses references in classes treat
string literals as class/method names. It happens that there is a class called
"update.class" in dnsjava-2.1.9.jar, without any package prefix. Therefore,
maven-dependency-analyzer would think my app uses dnsjava as a direct
dependency.
My fix to this issue is to exclude string literals when parsing the references.
> mvn dependency:analyze detected wrong transitive dependency
> ---
>
> Key: MDEP-679
> URL: https://issues.apache.org/jira/browse/MDEP-679
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze
>Affects Versions: 3.1.1
>Reporter: John Lin
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> To illustrate this issue, I created a sample project here:
> [https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava]
> The dependency tree is like this:
> {code:java}
> My app ---> ApacheJMeter_http ---> dnsjava
> {code}
> I didn't use any code directly from the artifact {{dnsjava}} in my app. I
> only used {{ApacheJMeter_http}}. However, the command {{mvn
> dependency:analyze}} will report a used undeclared dependency: {{dnsjava}}.
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @
> maven-dependency-analyze-dnsjava ---
> [WARNING] Used undeclared dependencies found:
> [WARNING]dnsjava:dnsjava:jar:2.1.9:runtime {code}
> It seems that the problem came from the line:
> {code:java}
> map.put("update", null);
> {code}
> If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE",
> null);}}, the problem will disappear. Therefore, I think there might be
> something to do with the string "update".
> Note that this issue is not reproducible in maven-dependency-plugin:2.8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6872) Found CVEs in your dependencies - plexus-utils (tests)
[ https://issues.apache.org/jira/browse/MNG-6872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061281#comment-17061281 ] Hudson commented on MNG-6872: - Build failed in Jenkins: Maven TLP » maven » testFor363 #10 See https://builds.apache.org/job/maven-box/job/maven/job/testFor363/10/ > Found CVEs in your dependencies - plexus-utils (tests) > -- > > Key: MNG-6872 > URL: https://issues.apache.org/jira/browse/MNG-6872 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.6.3 >Reporter: XuCongying >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.7.0 > > > I noticed some of your libraries contained CVEs. I suggest a library update > to avoid potential risks. See below for more details: > > Vulnerable Library Version: org.codehaus.plexus : plexus-utils : 1.5.5 > CVE ID: > [CVE-2017-1000487](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-1000487) > Import Path: > maven-core/src/test/resources-project-builder/micromailer/pom.xml > Suggested Safe Versions: 3.0.16, 3.0.17, 3.0.18, 3.0.19, 3.0.20, 3.0.21, > 3.0.22, 3.0.23, 3.0.24, 3.1.0, 3.1.1, 3.2.0, 3.2.1, 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6874) Upgrade Maven Parent to 34
[ https://issues.apache.org/jira/browse/MNG-6874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061280#comment-17061280 ] Hudson commented on MNG-6874: - Build failed in Jenkins: Maven TLP » maven » testFor363 #10 See https://builds.apache.org/job/maven-box/job/maven/job/testFor363/10/ > Upgrade Maven Parent to 34 > -- > > Key: MNG-6874 > URL: https://issues.apache.org/jira/browse/MNG-6874 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.7.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNGSITE-398) Fix typos and make improvements in `Configuring Apache Maven`
[
https://issues.apache.org/jira/browse/MNGSITE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edinson E. Padrón Urdaneta updated MNGSITE-398:
---
Labels: documentation (was: document)
> Fix typos and make improvements in `Configuring Apache Maven`
> -
>
> Key: MNGSITE-398
> URL: https://issues.apache.org/jira/browse/MNGSITE-398
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Edinson E. Padrón Urdaneta
>Priority: Trivial
> Labels: documentation
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current text for `MAVEN_OPTS` is
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to supply additional options to globally to Maven.
> {quote}
> There's an odd `to` before `globally`. An a rewording like this could be
> improve how it is read
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to globally supply additional options to it.
> {quote}
>
> Another typo in
> {quote}Located with in the projects top level folder, the files
> {{maven.config}}, {{jvm.config}}, and {{extensions.xml}} contain project
> specific configuration for running Maven.
> {quote}
> It should be `within` instead of `with in`.
>
> And another one in
> {quote}You don’t need to remember of using this options in {{MAVEN_OPTS}} or
> switching between different configurations. in the end, add the following:
> {quote}
> How about?
> {quote}You don’t need to use these options in \{{MAVEN_OPTS,}}nor switching
> between different configurations.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MNGSITE-398) Fix typos and make improvements in `Configuring Apache Maven`
[
https://issues.apache.org/jira/browse/MNGSITE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MNGSITE-398.
---
Resolution: Fixed
> Fix typos and make improvements in `Configuring Apache Maven`
> -
>
> Key: MNGSITE-398
> URL: https://issues.apache.org/jira/browse/MNGSITE-398
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Edinson E. Padrón Urdaneta
>Priority: Trivial
> Labels: document
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current text for `MAVEN_OPTS` is
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to supply additional options to globally to Maven.
> {quote}
> There's an odd `to` before `globally`. An a rewording like this could be
> improve how it is read
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to globally supply additional options to it.
> {quote}
>
> Another typo in
> {quote}Located with in the projects top level folder, the files
> {{maven.config}}, {{jvm.config}}, and {{extensions.xml}} contain project
> specific configuration for running Maven.
> {quote}
> It should be `within` instead of `with in`.
>
> And another one in
> {quote}You don’t need to remember of using this options in {{MAVEN_OPTS}} or
> switching between different configurations. in the end, add the following:
> {quote}
> How about?
> {quote}You don’t need to use these options in \{{MAVEN_OPTS,}}nor switching
> between different configurations.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNGSITE-398) Fix typos and make improvements in `Configuring Apache Maven`
[
https://issues.apache.org/jira/browse/MNGSITE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold closed MNGSITE-398.
-
> Fix typos and make improvements in `Configuring Apache Maven`
> -
>
> Key: MNGSITE-398
> URL: https://issues.apache.org/jira/browse/MNGSITE-398
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Edinson E. Padrón Urdaneta
>Priority: Trivial
> Labels: document
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current text for `MAVEN_OPTS` is
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to supply additional options to globally to Maven.
> {quote}
> There's an odd `to` before `globally`. An a rewording like this could be
> improve how it is read
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to globally supply additional options to it.
> {quote}
>
> Another typo in
> {quote}Located with in the projects top level folder, the files
> {{maven.config}}, {{jvm.config}}, and {{extensions.xml}} contain project
> specific configuration for running Maven.
> {quote}
> It should be `within` instead of `with in`.
>
> And another one in
> {quote}You don’t need to remember of using this options in {{MAVEN_OPTS}} or
> switching between different configurations. in the end, add the following:
> {quote}
> How about?
> {quote}You don’t need to use these options in \{{MAVEN_OPTS,}}nor switching
> between different configurations.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNGSITE-398) Fix typos and make improvements in `Configuring Apache Maven`
[
https://issues.apache.org/jira/browse/MNGSITE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MNGSITE-398:
--
Issue Type: Bug (was: Improvement)
> Fix typos and make improvements in `Configuring Apache Maven`
> -
>
> Key: MNGSITE-398
> URL: https://issues.apache.org/jira/browse/MNGSITE-398
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Edinson E. Padrón Urdaneta
>Priority: Trivial
> Labels: document
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current text for `MAVEN_OPTS` is
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to supply additional options to globally to Maven.
> {quote}
> There's an odd `to` before `globally`. An a rewording like this could be
> improve how it is read
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to globally supply additional options to it.
> {quote}
>
> Another typo in
> {quote}Located with in the projects top level folder, the files
> {{maven.config}}, {{jvm.config}}, and {{extensions.xml}} contain project
> specific configuration for running Maven.
> {quote}
> It should be `within` instead of `with in`.
>
> And another one in
> {quote}You don’t need to remember of using this options in {{MAVEN_OPTS}} or
> switching between different configurations. in the end, add the following:
> {quote}
> How about?
> {quote}You don’t need to use these options in \{{MAVEN_OPTS,}}nor switching
> between different configurations.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNGSITE-398) Fix typos and make improvements in `Configuring Apache Maven`
[
https://issues.apache.org/jira/browse/MNGSITE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061256#comment-17061256
]
Hudson commented on MNGSITE-398:
Build succeeded in Jenkins: Maven TLP » maven-site » master #221
See https://builds.apache.org/job/maven-box/job/maven-site/job/master/221/
> Fix typos and make improvements in `Configuring Apache Maven`
> -
>
> Key: MNGSITE-398
> URL: https://issues.apache.org/jira/browse/MNGSITE-398
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Edinson E. Padrón Urdaneta
>Priority: Trivial
> Labels: document
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current text for `MAVEN_OPTS` is
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to supply additional options to globally to Maven.
> {quote}
> There's an odd `to` before `globally`. An a rewording like this could be
> improve how it is read
> {quote}This variable contains parameters used to start up the JVM running
> Maven and can be used to globally supply additional options to it.
> {quote}
>
> Another typo in
> {quote}Located with in the projects top level folder, the files
> {{maven.config}}, {{jvm.config}}, and {{extensions.xml}} contain project
> specific configuration for running Maven.
> {quote}
> It should be `within` instead of `with in`.
>
> And another one in
> {quote}You don’t need to remember of using this options in {{MAVEN_OPTS}} or
> switching between different configurations. in the end, add the following:
> {quote}
> How about?
> {quote}You don’t need to use these options in \{{MAVEN_OPTS,}}nor switching
> between different configurations.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MNGSITE-393) Remove references to Maven 2.x
[ https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MNGSITE-393: - Assignee: Elliotte Rusty Harold > Remove references to Maven 2.x > -- > > Key: MNGSITE-393 > URL: https://issues.apache.org/jira/browse/MNGSITE-393 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > > Maven 3.x is over a decade old now and we're talking about Maven 4. It's time > to clean out all the random discussion here and there about how Maven 2.x did > things, differences between Maven 2 and 3, what works in Maven 3 but not 2, > etc. > Assume Maven 3.0 as the minimum, probably Maven 3.1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNGSITE-397) Improve wording on `Providing a uniform build system` in `Introduction`
[
https://issues.apache.org/jira/browse/MNGSITE-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061123#comment-17061123
]
Hudson commented on MNGSITE-397:
Build succeeded in Jenkins: Maven TLP » maven-site » master #219
See https://builds.apache.org/job/maven-box/job/maven-site/job/master/219/
> Improve wording on `Providing a uniform build system` in `Introduction`
> ---
>
> Key: MNGSITE-397
> URL: https://issues.apache.org/jira/browse/MNGSITE-397
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Edinson E. Padrón Urdaneta
>Priority: Trivial
> Labels: docuentation
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current text is
> {quote}Maven allows a project to build using its project object model (POM)
> and a set of plugins that are shared by all projects using Maven, providing a
> uniform build system. Once you familiarize yourself with how one Maven
> project builds you automatically know how all Maven projects build saving you
> immense amounts of time when trying to navigate many projects.
> {quote}
> I think this way reads better:
> {quote}Maven allows a project to be built using its project object model
> (POM) and a set of plugins that are shared by all projects using Maven,
> providing a uniform build system. Once you familiarize yourself with how one
> Maven project builds, you automatically know how all Maven projects build,
> saving you immense amounts of time when trying to navigate many projects.
> {quote}
> Changing "to build" with "to be built" and adding a couple of commas.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNGSITE-399) Fix the `banned dependencies rule` link at `Optional Dependencies and Dependency Exclusions`
[
https://issues.apache.org/jira/browse/MNGSITE-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061121#comment-17061121
]
Hudson commented on MNGSITE-399:
Build succeeded in Jenkins: Maven TLP » maven-site » master #218
See https://builds.apache.org/job/maven-box/job/maven-site/job/master/218/
> Fix the `banned dependencies rule` link at `Optional Dependencies and
> Dependency Exclusions`
>
>
> Key: MNGSITE-399
> URL: https://issues.apache.org/jira/browse/MNGSITE-399
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Edinson E. Padrón Urdaneta
>Priority: Trivial
> Labels: documentation
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the link is constructed this way
> {code:java}
> [banned dependencies
> rule](https://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html)
> {code}
> {{But even though that's valid Markdown syntax, the file is an APT (Almost
> Plain Text) instead of MD.}}
>
> {{The correct syntax should be}}
> {code:java}
> {{{https://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html}banned
> dependencies rule}}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-changes-plugin] elharo opened a new pull request #12: deps: update xmlrpc-client
elharo opened a new pull request #12: deps: update xmlrpc-client URL: https://github.com/apache/maven-changes-plugin/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-dependency-analyzer] johnlinp opened a new pull request #7: [MDEP-679] mvn dependency:analyze detected wrong transitive dependency
johnlinp opened a new pull request #7: [MDEP-679] mvn dependency:analyze detected wrong transitive dependency URL: https://github.com/apache/maven-dependency-analyzer/pull/7 [MDEP-679] Should not include string literals when parsing references Following this checklist to help us incorporate your contribution quickly and easily: - [ x ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. Also be sure having selected the correct component. - [ x ] Each commit in the pull request should have a meaningful subject line and body. - [ x ] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ x ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ x ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ x ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ x ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-changes-plugin] elharo merged pull request #4: sample jira report has a license
elharo merged pull request #4: sample jira report has a license URL: https://github.com/apache/maven-changes-plugin/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-changes-plugin] elharo merged pull request #5: we require Java 7 now
elharo merged pull request #5: we require Java 7 now URL: https://github.com/apache/maven-changes-plugin/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-changes-plugin] elharo closed pull request #10: new http
elharo closed pull request #10: new http URL: https://github.com/apache/maven-changes-plugin/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1556) Test XML file is not valid when rerun "fails" with an assumption
[
https://issues.apache.org/jira/browse/SUREFIRE-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060867#comment-17060867
]
Tibor Digana commented on SUREFIRE-1556:
[~Micky002]
Can you attach a project where we can reproduce this issue and debug our code?
Thx
> Test XML file is not valid when rerun "fails" with an assumption
>
>
> Key: SUREFIRE-1556
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1556
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.21.0, 2.22.0
>Reporter: Michael Weisgrab
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 3.0.0-M5
>
> Attachments: TEST-asdf.SearchTest_assumption_valid.xml,
> TEST-asdf.SearchTest_rerun_assumption_invalid.xml,
> TEST-asdf.SearchTest_rerun_fail_valid.xml
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We are running UI tests and are doing one retry if there is a bug.
> When a test fails with an Exception on the first try and the second try is
> skipped by an assumption violation the resulting test report xml file is not
> valid (not well formatted xml file).
> When the test is skipped on the first try or both runs fail with an exception
> everything is ok.
> This is a testcase which is retried and a valid xml is generated.
>
> {code:java}
>
>
> ...
>
>
> ...
>
>
> ...
>
>
> ...
>
> ...
>
>
> ...
>
>
> {code}
>
>
> Here is a generated invalid xml. The rerunError tag is missing. The retry
> "error" is an assumption violation so the test should be marked as skipped
> with message of the assumptionviolation.
> {code:java}
>
>
>
>
> ...
>
>
> ...
>
> < message="There should be a list of ads!">
>
> ...
>
>
> ...
>
>
>
> {code}
> I have attached the following files:
> * TEST-asdf.SearchTest_assumption_valid.xml (assumption violation in the
> first test run)
> * TEST-asdf.SearchTest_rerun_fail_valid.xml (both runs throw exception)
> * TEST-asdf.SearchTest_rerun_assumption_invalid.xml (first run exception -
> second run assumption violation)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MSHARED-866) loadOptionalProperties throws AssertionError
[ https://issues.apache.org/jira/browse/MSHARED-866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MSHARED-866: - Assignee: Elliotte Rusty Harold > loadOptionalProperties throws AssertionError > > > Key: MSHARED-866 > URL: https://issues.apache.org/jira/browse/MSHARED-866 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > > API docs claim PropertyUtils.loadOptionalProperties returns an empty > Properties object on IOException. It does not. Instead it converts the > IOException to a process killing AssertionError. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MSHARED-866) loadOptionalProperties throws AssertionError
Elliotte Rusty Harold created MSHARED-866: - Summary: loadOptionalProperties throws AssertionError Key: MSHARED-866 URL: https://issues.apache.org/jira/browse/MSHARED-866 Project: Maven Shared Components Issue Type: Bug Components: maven-shared-utils Reporter: Elliotte Rusty Harold API docs claim PropertyUtils.loadOptionalProperties returns an empty Properties object on IOException. It does not. Instead it converts the IOException to a process killing AssertionError. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-803) CommandLineUtils should set names for Threads
[
https://issues.apache.org/jira/browse/MSHARED-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060845#comment-17060845
]
Hudson commented on MSHARED-803:
Build succeeded in Jenkins: Maven TLP » maven-shared-utils » xml2 #6
See https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/xml2/6/
> CommandLineUtils should set names for Threads
> -
>
> Key: MSHARED-803
> URL: https://issues.apache.org/jira/browse/MSHARED-803
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-shared-utils
>Reporter: Andrey Turbanov
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> CommandLineUtils now creates Threads with default names, like Thread-1
> I noticed it in one of thread-dump for hang maven build
> {noformat}
> Thread-109" #309 daemon prio=5 os_prio=0 tid=0x7f1ce0005000 nid=0x13b3c
> runnable [0x7f1d3a3f6000]
>java.lang.Thread.State: RUNNABLE
> at java.io.FileInputStream.readBytes(Native Method)
> at java.io.FileInputStream.read(FileInputStream.java:255)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0xebdca730> (a
> java.lang.UNIXProcess$ProcessPipeInputStream)
> at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
> at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
> at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
> - locked <0xebdca718> (a java.io.InputStreamReader)
> at java.io.InputStreamReader.read(InputStreamReader.java:184)
> at java.io.BufferedReader.fill(BufferedReader.java:161)
> at java.io.BufferedReader.readLine(BufferedReader.java:324)
> - locked <0xebdca718> (a java.io.InputStreamReader)
> at java.io.BufferedReader.readLine(BufferedReader.java:389)
> at
> org.apache.maven.surefire.shade.org.apache.maven.shared.utils.cli.StreamPumper.run(StreamPumper.java:76)
> {noformat}
> It would be nice to set names for threads created by CommandLineUtils
> {code}
> final StreamFeeder inputFeeder = systemIn != null ? new StreamFeeder(
> systemIn, p.getOutputStream() ) : null;
> inputFeeder.setName("StreamFeeder-systemIn-" + p);
> final StreamPumper outputPumper = new StreamPumper(
> p.getInputStream(), systemOut );
> inputFeeder.setName("StreamPumper-systemOut-" + p);
> final StreamPumper errorPumper = new StreamPumper(
> p.getErrorStream(), systemErr );
> errorPumper.setName("StreamPumper-systemErr-" + p);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSHARED-860) Deprecate obsolete functionality
[ https://issues.apache.org/jira/browse/MSHARED-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060847#comment-17060847 ] Hudson commented on MSHARED-860: Build succeeded in Jenkins: Maven TLP » maven-shared-utils » xml2 #6 See https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/xml2/6/ > Deprecate obsolete functionality > > > Key: MSHARED-860 > URL: https://issues.apache.org/jira/browse/MSHARED-860 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Large chunks of org.apache.maven.shared.utils are out of date and duplicate > better maintained code in the Java class libraries, Apache Commons Lang, > Apache Commons I/O, or even all three. > > Add deprecation comments and annotations to such methods, classes, and fields > with pointers to the modern replacements for this functionality. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-685) DirectoryScanner#checkSymlinkBehaviour() does not use assert*
[ https://issues.apache.org/jira/browse/MSHARED-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060846#comment-17060846 ] Hudson commented on MSHARED-685: Build succeeded in Jenkins: Maven TLP » maven-shared-utils » xml2 #6 See https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/xml2/6/ > DirectoryScanner#checkSymlinkBehaviour() does not use assert* > -- > > Key: MSHARED-685 > URL: https://issues.apache.org/jira/browse/MSHARED-685 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-utils >Affects Versions: maven-shared-utils-3.3.0 >Reporter: Karl Heinz Marbaise >Assignee: Elliotte Rusty Harold >Priority: Minor > Labels: up-for-grabs > Attachments: MSHARED-685-maven-shared-utils.patch > > Time Spent: 20m > Remaining Estimate: 0h > > Add assertions to > org.apache.maven.shared.utils.io.DirectoryScannerTest#checkSymlinkBehaviour > test -- This message was sent by Atlassian Jira (v8.3.4#803005)
