[jira] [Commented] (MSHARED-511) Using structures to keep insertion order for MANIFEST.MF
[ https://issues.apache.org/jira/browse/MSHARED-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085419#comment-17085419 ] md_5 commented on MSHARED-511: -- This isn't really fixed as in JDK 8 the underlying java.util.jar.Attributes class is not ordered, and in all current versions the underlying java.util.jar.Manifest 'Name:' entries are unordered. The plexus archiver component needs to do some post serialization sorting, or serialize the manifest itself without relying on the JDK. > Using structures to keep insertion order for MANIFEST.MF > > > Key: MSHARED-511 > URL: https://issues.apache.org/jira/browse/MSHARED-511 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-archiver >Affects Versions: maven-archiver-3.0.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-archiver-3.0.1 > > > Currently in maven-archiver things like HashMap and ArrayList are used which > are not insertion order aware. Replaced with LinkedHashMap and LinkedList to > keep insertion order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] ripper2hl commented on a change in pull request #36: Add feature to create base dir
ripper2hl commented on a change in pull request #36: Add feature to create base
dir
URL: https://github.com/apache/maven-archetype/pull/36#discussion_r409962351
##
File path:
archetype-common/src/main/java/org/apache/maven/archetype/ArchetypeGenerationRequest.java
##
@@ -390,4 +392,16 @@ public ArchetypeGenerationRequest setFilter( String
filter )
return this;
}
+
+public boolean isCreateBaseDir()
+{
+return createBaseDir;
+}
+
+public ArchetypeGenerationRequest setCreteBaseDir( boolean createBaseDir )
Review comment:
@michael-o you can review now, please
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-archetype] ripper2hl commented on issue #36: Add feature to create base dir
ripper2hl commented on issue #36: Add feature to create base dir URL: https://github.com/apache/maven-archetype/pull/36#issuecomment-614946934 This a related jira issue , i don't know if what is you need @elharo . https://issues.apache.org/jira/browse/ARCHETYPE-311 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] ripper2hl commented on a change in pull request #36: Add feature to create base dir
ripper2hl commented on a change in pull request #36: Add feature to create base
dir
URL: https://github.com/apache/maven-archetype/pull/36#discussion_r409904662
##
File path:
archetype-common/src/main/java/org/apache/maven/archetype/ArchetypeGenerationRequest.java
##
@@ -390,4 +392,16 @@ public ArchetypeGenerationRequest setFilter( String
filter )
return this;
}
+
+public boolean isCreateBaseDir()
+{
+return createBaseDir;
+}
+
+public ArchetypeGenerationRequest setCreteBaseDir( boolean createBaseDir )
Review comment:
:o yes, i need fix it ,
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #248: SUREFIRE-1695 Support multiple inheritance of @Categories
Tibor17 commented on issue #248: SUREFIRE-1695 Support multiple inheritance of @Categories URL: https://github.com/apache/maven-surefire/pull/248#issuecomment-614942298 @YiannisDermitzakis Here is a new branch https://github.com/apache/maven-surefire/tree/pull/248 where the test are automated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1776) DefaultReportFactory doesn't report errors when engine fails
[
https://issues.apache.org/jira/browse/SUREFIRE-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085295#comment-17085295
]
Tibor Digana commented on SUREFIRE-1776:
It could simply happen tht the JUnit description of a test failed.
Check it out with the development version 3.0.0-SNAPSHOT and use the plugin
repo in your POM:
{code:xml}
surefire-snapshot
surefire-snapshot
https://repository.apache.org/content/repositories/snapshots/
true
DefaultReportFactory doesn't report errors when engine fails
>
>
> Key: SUREFIRE-1776
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1776
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.22.0
>Reporter: Mickael Istria
>Priority: Major
>
> We face an issue with tycho-surefire-plugin reporting "No tests found" when a
> test is actually found but the engine fails (for a tycho-specific reason)
> when preparing the test.
> tycho-surefire-plugin basically builds an OSGi container as defined in the
> usual Tycho way and uses Surefire API to run the tests inside that container
> and report it as a plain surefire does regularly.
> To do so, it does mainly uses `RunResult result =
> ProviderFactory.invokeProvider(...)`. However, it can happen that an error
> happen in the engine, before any test method starts (although the test method
> is scanned and detected and an executionRequest is emitted for it). The cases
> for it are relatively probable with Tycho/OSGi.
> In such case, even if the engine faced an error, we get a RunResult
> mentioning no error, actually reporting no test execution, but no error,
> usually making the test report say everything is fine or telling "No tests
> found" (which is also incorrect because test is found, it could not just be
> started).
> I could dig a bit more and I think the
> DefaultTestReporter.mergeTestHistoryResult() method just fails at handling
> the cases of errors when the error do not happen on the test method, because
> it wrongly assumes that `listener.getTestMethodStats()` is exhaustive.
> More specifically, when debugging this method, I do see in debugger that
> `this.listeners[0].detailsForThis` has `completedCount==1` and `errors==1`
> but the return value says completedCount==0 and errors=0; its reportEntries
> show one error entry, which has for source `` so they're not
> returned by `listener.getTestMethodStats()`.
> I believe the DefaultReportFactory should handle the case to verify before
> returning whether such unrooted error wasn't missed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-6892) Design Multi-Release jar support
[ https://issues.apache.org/jira/browse/MNG-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MNG-6892: --- Description: Figure out what multi-release jar builds in maven look like: changes to pom.xml, plugin configurations, source layout, etc. [JEP 238: Multi-Release JAR Files|http://openjdk.java.net/jeps/238] Using pure javac + jar: [https://blog.codefx.org/tools/multi-release-jars-multiple-java-versions/] [https://www.baeldung.com/java-multi-release-jar] Prior art: https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html [http://word-bits.flurg.com/multrelease-jars/] [https://github.com/metlos/multi-release-jar-maven-plugin] [https://planet.jboss.org/post/building_multi_release_jars_with_maven] [https://in.relation.to/2017/02/13/building-multi-release-jars-with-maven/] was: Figure out what multi-release jar builds in maven look like: changes to pom.xml, plugin configurations, source layout, etc. [JEP 238: Multi-Release JAR Files|http://openjdk.java.net/jeps/238] Using pure javac + jar: [https://blog.codefx.org/tools/multi-release-jars-multiple-java-versions/] [https://www.baeldung.com/java-multi-release-jar] Prior art: [http://word-bits.flurg.com/multrelease-jars/] [https://github.com/metlos/multi-release-jar-maven-plugin] [https://planet.jboss.org/post/building_multi_release_jars_with_maven] [https://in.relation.to/2017/02/13/building-multi-release-jars-with-maven/] > Design Multi-Release jar support > > > Key: MNG-6892 > URL: https://issues.apache.org/jira/browse/MNG-6892 > Project: Maven > Issue Type: Task >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > > Figure out what multi-release jar builds in maven look like: changes to > pom.xml, plugin configurations, source layout, etc. > > [JEP 238: Multi-Release JAR Files|http://openjdk.java.net/jeps/238] > > Using pure javac + jar: > [https://blog.codefx.org/tools/multi-release-jars-multiple-java-versions/] > [https://www.baeldung.com/java-multi-release-jar] > > Prior art: > https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html > [http://word-bits.flurg.com/multrelease-jars/] > [https://github.com/metlos/multi-release-jar-maven-plugin] > [https://planet.jboss.org/post/building_multi_release_jars_with_maven] > [https://in.relation.to/2017/02/13/building-multi-release-jars-with-maven/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARCHETYPE-594) Update easymock
[ https://issues.apache.org/jira/browse/ARCHETYPE-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085292#comment-17085292 ] Elliotte Rusty Harold commented on ARCHETYPE-594: - I prefer Mockito too, but I'd prefer not to rewrite all the existing tests. It was painful enough upgrading them from EasyMock 1. I think I've also seen some PowerMock in one plugin or another. > Update easymock > --- > > Key: ARCHETYPE-594 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-594 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MNG-6751) Warning on empty version of reporting plugins
[
https://issues.apache.org/jira/browse/MNG-6751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6751.
---
Fix Version/s: (was: waiting-for-feedback)
Resolution: Incomplete
No sample project provided.
> Warning on empty version of reporting plugins
> -
>
> Key: MNG-6751
> URL: https://issues.apache.org/jira/browse/MNG-6751
> Project: Maven
> Issue Type: Task
> Components: Documentation: General
>Affects Versions: 3.6.1
>Reporter: Radek Antoniuk
>Priority: Minor
>
> Per [https://maven.apache.org/plugins/maven-site-plugin/maven-3.html]
> _When used with Maven 3, a report plugin version can be empty (like build
> plugins)__._
> but I'm still getting a warning on _mvn site_
> {noformat}
> [WARNING] Report plugin
> org.apache.maven.plugins:maven-project-info-reports-plugin has an empty
> version.
> [WARNING] Report plugin org.owasp:dependency-check-maven has an empty
> version. {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MINVOKER-263) integration test support for .kts pre/post hook scripts
[
https://issues.apache.org/jira/browse/MINVOKER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dariusz Kuc updated MINVOKER-263:
-
Description: It would be great if {{maven-invoker-plugin}} could support
Kotlin script files (.kts). This would allow to write maven-plugin completely
in Kotlin without the need to fallback to Groovy/Java for integration tests.
(was: It would be great if `maven-invoker-plugin` could support Kotlin script
files (.kts). This would allow Kotlin maven-plugin projects to use same
language for both sources and tests.)
> integration test support for .kts pre/post hook scripts
>
>
> Key: MINVOKER-263
> URL: https://issues.apache.org/jira/browse/MINVOKER-263
> Project: Maven Invoker Plugin
> Issue Type: New Feature
>Affects Versions: 3.2.1
>Reporter: Dariusz Kuc
>Priority: Minor
>
> It would be great if {{maven-invoker-plugin}} could support Kotlin script
> files (.kts). This would allow to write maven-plugin completely in Kotlin
> without the need to fallback to Groovy/Java for integration tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNG-5872) Maven results are wrong after rerun test cases by RetryListeners
[
https://issues.apache.org/jira/browse/MNG-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-5872.
---
Fix Version/s: (was: wontfix-candidate)
(was: waiting-for-feedback)
Resolution: Incomplete
No further information provided.
> Maven results are wrong after rerun test cases by RetryListeners
>
>
> Key: MNG-5872
> URL: https://issues.apache.org/jira/browse/MNG-5872
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Reporter: Vishnu
>Priority: Major
>
> I am getting wrong result count after re-run the failed test case using
> RetryListener.
> Environment details:
> Java,
> Selenium with TestNG
> Chrome browser
> Maven mode execution
> Total Running Test case : 1
> Simulation:
> 1. Have added Listener class in TestNG and running test case using maven
>
>
>
> 2. Made test case failed and it invoked failed test case and 2nd time, it got
> passed. The results would be as follows;
> Expected Results ==> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> (Correct)
> Actual Results ==> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 (Wrong)
> I've used below classes for Listeners and calling RetryListener class from
> TestNG.xml and executing them from Maven mode.
> IRetryAnalyzer class:
> public class RetryAnalyzer implements IRetryAnalyzer {
> private int retryCount = 0;
> private int retryMaxCount = 1;
>
> public RetryAnalyzer() {
> setCount(retryMaxCount);
> }
>@Override
> public boolean retry(ITestResult result) {
> if (!result.isSuccess()) {
> if (retryCount < retryMaxCount) {
> retryCount++;
> result.setStatus(ITestResult.SUCCESS);
> String message = Thread.currentThread().getName() + ": Error in
> " + result.getName() + " Retrying "
> + (retryMaxCount + 1 - retryCount) + " more time(s)";
> System.out.println(message);
> Reporter.log(message);
> return true;
> } else {
> result.setStatus(ITestResult.FAILURE);
> }
> }
> return false;
> }
>
> public void setCount(int count) {
> retryMaxCount = count;
> }
> RetryLister Class:
> public class RetryListener implements IAnnotationTransformer {
> @SuppressWarnings("rawtypes")
> @Override
> public void transform(ITestAnnotation arg0, Class arg1, Constructor
> arg2,
> Method arg3) {
> IRetryAnalyzer retry = arg0.getRetryAnalyzer();
> if (retry == null) {
> arg0.setRetryAnalyzer(RetryAnalyzer.class);
> }
> }
>
> public void onFinish(ITestContext context) {
>Iterator failedTestCases
> =context.getFailedTests().getAllResults().iterator();
> while (failedTestCases.hasNext()) {
> System.out.println("failedTestCases");
> ITestResult failedTestCase = failedTestCases.next();
> ITestNGMethod method = failedTestCase.getMethod();
> if (context.getFailedTests().getResults(method).size() > 1) {
> System.out.println("failed test case remove as dup:" +
> failedTestCase.getTestClass().toString());
> failedTestCases.remove();
> } else {
> if (context.getPassedTests().getResults(method).size() > 0)
> {
> System.out.println("failed test case remove as pass
> retry:" + failedTestCase.getTestClass().toString());
> failedTestCases.remove();
> }
> }
> }
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MINVOKER-263) integration test support for .kts pre/post hook scripts
Dariusz Kuc created MINVOKER-263: Summary: integration test support for .kts pre/post hook scripts Key: MINVOKER-263 URL: https://issues.apache.org/jira/browse/MINVOKER-263 Project: Maven Invoker Plugin Issue Type: New Feature Affects Versions: 3.2.1 Reporter: Dariusz Kuc It would be great if `maven-invoker-plugin` could support Kotlin script files (.kts). This would allow Kotlin maven-plugin projects to use same language for both sources and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6356) property from list element in pom model
[
https://issues.apache.org/jira/browse/MNG-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085276#comment-17085276
]
Michael Osipov commented on MNG-6356:
-
The problem could be simply Plexus Interpolation.
> property from list element in pom model
> ---
>
> Key: MNG-6356
> URL: https://issues.apache.org/jira/browse/MNG-6356
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.2
> Environment: linux
>Reporter: Ernst Reissner
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
> Attachments: project.tar
>
>
> I tried to filter $\{project.developers[0].email}
> Although mvn help:evaluate finds the correct answer, filtering does not work
> else.
> Even if i havein the properties section of the pom one of the three
> ernst.reiss...@simuline.eu
> ${project.organization.name}
> $\{project.developers[0].email}
> the latter is not replaced and just comes litterally.
>
> Update: I added a minimal project
> comprising a pom and some resource to be filtered.
> What we see is, that ${project.organization.name} is filtered,
> whereas $\{project.developers[0].email} is not: remains literal.
>
> Also I think, better than developers[0] would be a way to use a label,
> e.g. a key, like an identifier. (but this is a feature request. )
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNG-6857) When a repository we are referring to , in pom.xml has been made down or shut down . The maven is not handling it appropriately
[ https://issues.apache.org/jira/browse/MNG-6857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6857. --- Fix Version/s: (was: wontfix-candidate) (was: waiting-for-feedback) Resolution: Invalid No logs received after two months. > When a repository we are referring to , in pom.xml has been made down or shut > down . The maven is not handling it appropriately > --- > > Key: MNG-6857 > URL: https://issues.apache.org/jira/browse/MNG-6857 > Project: Maven > Issue Type: Bug > Components: Artifacts and Repositories >Affects Versions: 3.6.3 >Reporter: Devendra Tummala >Priority: Major > Labels: patch > Original Estimate: 48h > Remaining Estimate: 48h > > I am working in Maven-Spring Boot Projects . > I have a list of repositories listed down in my pom.xml and among those one > is down/moved permanently(302 /301 status), then Maven is unable to handle it > and downloading some corrupted jars from no where and when we try to "mvn > install" ,it states error like "error in opening zip file" for that jar . > > Steps How we resolved that issue-- > 1.Commented out that repository in pom.xml > 2.Removed that corrupted jar from local repository. > 3.mvn -U clean install > > How we are expecting it to be resolved :: > # If the repository throws 301/302 , the maven should go to the next > available repository listed in pom.xml and should check for this jar . > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MNG-6368) Maven 3.5.2 breaks the Maven Invoker Plugin on Windows
[
https://issues.apache.org/jira/browse/MNG-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6368.
---
Fix Version/s: (was: wontfix-candidate)
(was: waiting-for-feedback)
Resolution: Incomplete
No response for a long time.
> Maven 3.5.2 breaks the Maven Invoker Plugin on Windows
> --
>
> Key: MNG-6368
> URL: https://issues.apache.org/jira/browse/MNG-6368
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.2
> Environment: Windows 7
> run from cygwin with January 2017 updates
>Reporter: Gene Smith
>Priority: Minor
> Attachments: test-maven-invoker-plugin.zip
>
>
> *I found a work around (credit Robert Scholte's quetion for the clue)..*
> * *make sure all files in $MAVEN_HOME/bin are executable***
> Maven 3.5.2 will not tell you why maven-invoker-fails if it can't find an
> executable.
> ...
> With Maven 3.5.2 on Windows 7,. the Maven Invoker Plugin breaks:
> * reporting
> _The Maven invocation failed. Error while executing process._
> * leaving empty log files, and streaming nothing from the invoked process
> I have multiple uses in a large project, which have has been working for us
> through many version of Maven. They all break, *on Windows with:*
> * a simple clean attempt to upgrade to Maven 3.5.2.
> (without changing any plugin versions)
> * a complex upgrade attempt, advancing forward as many plugin versions as
> can be pushed.
> The complex upgrade attempt works with Maven 3.5.0.
> And on testing to isolate it, Maven 3.5.2 + Maven Invoker Plugin 2+ breaks
> even in simplest form invoking:
> * an empty jar project with no inheritance
> * an empty pom project with no inheritance
> * an empty jar project with direct inheritance from the invoker
> * an empty pom project with direct inheritance from the invoker
> The attached zip very simple test project, which
> * works with:
> ** Maven 3.0.5, 3.1.1, 3.2.1, 3.3.3, 3.3.9
> *** maven-invoker-plugin 1.6, 1.7, 1.8, 1.9, 2.0.0, 3.0.0, 3.0.1
> ** Maven 3.5.0
> *** maven-invoker-plugin 2.0.0, 3.0.0, 3.0.1
> * *breaks with:*
> ** Maven 3.5.2
> *** maven-invoker-plugin 1.6, 1.7, 1.8, 1.9, 2.0.0, 3.0.0, 3.0.1
> I looked through sources and was able to test with this built locally (but my
> task is timeboxed and I have not been able to get Maven built from sources in
> the time I have):
> *
> [http://svn.apache.org/repos/asf/maven/plugins/tags/maven-invoker-plugin-3.0.1]
> and traced it as far as the call to:
> * org.apache.maven.shared.invoker.Invoker
> try
>
> { result = invoker.execute( request ); }
> catch ( final MavenInvocationException e )
>
> { getLog().debug( "Error invoking Maven: " +
> e.getMessage(), e ); throw new RunFailureException(
> "Maven invocation failed. " + e.getMessage(),
> BuildJob.Result.FAILURE_BUILD ); }
> but it invoker hides all trace, and I do not have time (I am time boxed this
> week) to get Maven built from sources to trace it into the Invoker.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-archetype] elharo opened a new pull request #45: [ARCHETYPE-594] Update EasyMock
elharo opened a new pull request #45: [ARCHETYPE-594] Update EasyMock URL: https://github.com/apache/maven-archetype/pull/45 @michael-o This is the latest version that works with Java 7. The EasyMock API changed since the tests were written so there's a lot of test rewrites here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ARCHETYPE-594) Update easymock
[ https://issues.apache.org/jira/browse/ARCHETYPE-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085252#comment-17085252 ] Robert Scholte commented on ARCHETYPE-594: -- nowadays we prefer mockito over easymock > Update easymock > --- > > Key: ARCHETYPE-594 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-594 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARCHETYPE-593) Update artifact-transfer
[ https://issues.apache.org/jira/browse/ARCHETYPE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved ARCHETYPE-593. - Resolution: Fixed > Update artifact-transfer > > > Key: ARCHETYPE-593 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-593 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (ARCHETYPE-593) Update artifact-transfer
[ https://issues.apache.org/jira/browse/ARCHETYPE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed ARCHETYPE-593. --- > Update artifact-transfer > > > Key: ARCHETYPE-593 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-593 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ARCHETYPE-593) Update artifact-transfer
[ https://issues.apache.org/jira/browse/ARCHETYPE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned ARCHETYPE-593: --- Assignee: Elliotte Rusty Harold > Update artifact-transfer > > > Key: ARCHETYPE-593 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-593 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ARCHETYPE-594) Update easymock
[ https://issues.apache.org/jira/browse/ARCHETYPE-594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned ARCHETYPE-594: --- Assignee: Elliotte Rusty Harold > Update easymock > --- > > Key: ARCHETYPE-594 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-594 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ARCHETYPE-598) Update JUnit
[ https://issues.apache.org/jira/browse/ARCHETYPE-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned ARCHETYPE-598: --- Assignee: Elliotte Rusty Harold > Update JUnit > > > Key: ARCHETYPE-598 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-598 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (ARCHETYPE-598) Update JUnit
[ https://issues.apache.org/jira/browse/ARCHETYPE-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed ARCHETYPE-598. --- > Update JUnit > > > Key: ARCHETYPE-598 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-598 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARCHETYPE-598) Update JUnit
[ https://issues.apache.org/jira/browse/ARCHETYPE-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved ARCHETYPE-598. - Resolution: Fixed > Update JUnit > > > Key: ARCHETYPE-598 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-598 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARCHETYPE-596) Update xmlunit
[ https://issues.apache.org/jira/browse/ARCHETYPE-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved ARCHETYPE-596. - Resolution: Fixed > Update xmlunit > -- > > Key: ARCHETYPE-596 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-596 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo merged pull request #42: [MARCHETYPE-596] update xmlunit
elharo merged pull request #42: [MARCHETYPE-596] update xmlunit URL: https://github.com/apache/maven-archetype/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (ARCHETYPE-596) Update xmlunit
[ https://issues.apache.org/jira/browse/ARCHETYPE-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed ARCHETYPE-596. --- > Update xmlunit > -- > > Key: ARCHETYPE-596 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-596 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo commented on issue #42: [MARCHETYPE-596] update xmlunit
elharo commented on issue #42: [MARCHETYPE-596] update xmlunit URL: https://github.com/apache/maven-archetype/pull/42#issuecomment-614888422 Updating enforcer rules worked. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MANTRUN-224) Require Java 8
[ https://issues.apache.org/jira/browse/MANTRUN-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085240#comment-17085240 ] Hudson commented on MANTRUN-224: Build succeeded in Jenkins: Maven TLP » maven-antrun-plugin » MANTRUN-224 #4 See https://builds.apache.org/job/maven-box/job/maven-antrun-plugin/job/MANTRUN-224/4/ > Require Java 8 > -- > > Key: MANTRUN-224 > URL: https://issues.apache.org/jira/browse/MANTRUN-224 > Project: Maven Antrun Plugin > Issue Type: Task >Reporter: Sylwester Lachiewicz >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] newur commented on a change in pull request #35: ARCHETYPE-584 fix indention in root pom.xml
newur commented on a change in pull request #35: ARCHETYPE-584 fix indention in
root pom.xml
URL: https://github.com/apache/maven-archetype/pull/35#discussion_r409828497
##
File path:
archetype-common/src/test/java/org/apache/maven/archetype/old/ArchetypeTest.java
##
@@ -61,6 +61,17 @@
public class ArchetypeTest
extends PlexusTestCase
{
+private static final String XML_VERSION_1_0 =
Review comment:
Funny how different people read code. I could barley make any sense out of
the initial version. Is revert in the new commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-archetype] newur commented on a change in pull request #35: ARCHETYPE-584 fix indention in root pom.xml
newur commented on a change in pull request #35: ARCHETYPE-584 fix indention in
root pom.xml
URL: https://github.com/apache/maven-archetype/pull/35#discussion_r409828626
##
File path:
archetype-common/src/test/java/org/apache/maven/archetype/old/ArchetypeTest.java
##
@@ -239,93 +250,118 @@ private ClassLoader getContextClassloader( Artifact
archetypeArtifact, ArtifactR
return archetypeJarLoader;
}
-public void testAddModuleToParentPOM()
-throws Exception
+public void testAddModuleToParentBasic()
+throws Exception
{
-String pom = "\n"
-+ " pom\n"
-+ "";
+String pom = PROJECT_ELEMENT
++ PACKAGING
++ PROJECT_ELEMENT_END;
StringWriter out = new StringWriter();
assertTrue( DefaultOldArchetype.addModuleToParentPom( "myArtifactId1",
new StringReader( pom ), out ) );
-assertThat( out.toString(), isIdenticalTo( "\n"
-+ "\n"
-+ " pom\n"
+assertThat( out.toString(), isIdenticalTo( XML_VERSION_1_0
++ PROJECT_ELEMENT
++ PACKAGING
+ " \n"
+ "myArtifactId1\n"
+ " \n"
-+ "" ).normalizeWhitespace() );
++ PROJECT_ELEMENT_END ) );
+}
-pom = "\n"
-+ " 4.0.0\n"
-+ " pom\n"
-+ "";
+public void testAddModuleToParentWithModelVersion()
+throws Exception
+{
+String pom = PROJECT_ELEMENT
++ MODEL_VERSION
++ PACKAGING
++ PROJECT_ELEMENT_END;
-out = new StringWriter();
+StringWriter out = new StringWriter();
Review comment:
Moved to setup method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (MANTRUN-226) Bump minimum required Maven for Plugin to 3.1.0
[ https://issues.apache.org/jira/browse/MANTRUN-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MANTRUN-226: - Summary: Bump minimum required Maven for Plugin to 3.1.0 (was: Bump minimum required Maven for Plugin to 3.1.1) > Bump minimum required Maven for Plugin to 3.1.0 > --- > > Key: MANTRUN-226 > URL: https://issues.apache.org/jira/browse/MANTRUN-226 > Project: Maven Antrun Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MANTRUN-226) Bump minimum required Maven for Plugin to 3.1.1
Sylwester Lachiewicz created MANTRUN-226: Summary: Bump minimum required Maven for Plugin to 3.1.1 Key: MANTRUN-226 URL: https://issues.apache.org/jira/browse/MANTRUN-226 Project: Maven Antrun Plugin Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] Tibor17 commented on a change in pull request #27: ARCHETYPE-531
Tibor17 commented on a change in pull request #27: ARCHETYPE-531
URL: https://github.com/apache/maven-archetype/pull/27#discussion_r409799554
##
File path:
archetype-common/src/main/java/org/apache/maven/archetype/creator/FilesetArchetypeCreator.java
##
@@ -702,7 +702,9 @@ private void rewriteEARPluginReferences( Plugin plugin,
String rootArtifactId, S
Xpp3Dom configuration = (Xpp3Dom) plugin.getConfiguration();
if ( configuration != null )
{
-Xpp3Dom[] modules = configuration.getChild( "modules"
).getChildren();
+Xpp3Dom[] modules = configuration.getChild( "modules" ) != null
Review comment:
use a local variable for `configuration.getChild( "modules" )`.
That's better than this and better for debugging as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MNG-6454) Introduce option to allow non-pom packaging types to also support the modules-tag
[
https://issues.apache.org/jira/browse/MNG-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085197#comment-17085197
]
Robert Scholte commented on MNG-6454:
-
No, this fits in the current pom model 4.0.0. Still a challenge, but easier to
solve then some think of the MRJARs requirements.
The support for mutlirelease jar (which actually needs to be generalized
because it is too Java specific) will likely require changes in the pom. e.g
you cannot talk about THE source directory anymore, every source directory
needs its own context (source/target/release, output folder).
With MNG-6454 in place, you'll have
https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html Maven
MultiModule 2.0 (no need for the assembly-plugin to assemble the jar)
> Introduce option to allow non-pom packaging types to also support the
> modules-tag
> -
>
> Key: MNG-6454
> URL: https://issues.apache.org/jira/browse/MNG-6454
> Project: Maven
> Issue Type: New Feature
>Reporter: Robert Scholte
>Priority: Major
> Labels: intern, multirelease
>
> While working on the multirelease jars I noticed we're missing a feature in
> Maven. At JCrete after talking with [~sanne] he had a similar request for a
> different reason. In his case it is about having a jar where all Drivers are
> optional, so developers only have to add this jar. However, it would be great
> it code could be isolated per Driver.
> The idea is to allow packaging:jar to specify modules in the pom. These
> submodules follow the normal lifecycle, but are never installed or deployed.
> Instead the root-project will embed these files in the main jar.
> To support this, Maven first of all recognize if modules are allowed for a
> specific packaging type. The
> {{org.apache.maven.artifact.handler.ArtifactHandler}} looks close, but that
> should be about artifacts (dependencies). So most likely we need a new
> ProjectHandler here.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (ARCHETYPE-591) Update JDOM
[ https://issues.apache.org/jira/browse/ARCHETYPE-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved ARCHETYPE-591. - Resolution: Fixed > Update JDOM > --- > > Key: ARCHETYPE-591 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-591 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (ARCHETYPE-591) Update JDOM
[ https://issues.apache.org/jira/browse/ARCHETYPE-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed ARCHETYPE-591. --- > Update JDOM > --- > > Key: ARCHETYPE-591 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-591 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARCHETYPE-592) Update commons-io
[ https://issues.apache.org/jira/browse/ARCHETYPE-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved ARCHETYPE-592. - Resolution: Fixed > Update commons-io > - > > Key: ARCHETYPE-592 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-592 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (ARCHETYPE-592) Update commons-io
[ https://issues.apache.org/jira/browse/ARCHETYPE-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed ARCHETYPE-592. --- > Update commons-io > - > > Key: ARCHETYPE-592 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-592 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo commented on a change in pull request #35: ARCHETYPE-584 fix indention in root pom.xml
elharo commented on a change in pull request #35: ARCHETYPE-584 fix indention
in root pom.xml
URL: https://github.com/apache/maven-archetype/pull/35#discussion_r409776830
##
File path:
archetype-common/src/test/java/org/apache/maven/archetype/old/ArchetypeTest.java
##
@@ -239,93 +250,118 @@ private ClassLoader getContextClassloader( Artifact
archetypeArtifact, ArtifactR
return archetypeJarLoader;
}
-public void testAddModuleToParentPOM()
-throws Exception
+public void testAddModuleToParentBasic()
+throws Exception
{
-String pom = "\n"
-+ " pom\n"
-+ "";
+String pom = PROJECT_ELEMENT
++ PACKAGING
++ PROJECT_ELEMENT_END;
StringWriter out = new StringWriter();
assertTrue( DefaultOldArchetype.addModuleToParentPom( "myArtifactId1",
new StringReader( pom ), out ) );
-assertThat( out.toString(), isIdenticalTo( "\n"
-+ "\n"
-+ " pom\n"
+assertThat( out.toString(), isIdenticalTo( XML_VERSION_1_0
++ PROJECT_ELEMENT
++ PACKAGING
+ " \n"
+ "myArtifactId1\n"
+ " \n"
-+ "" ).normalizeWhitespace() );
++ PROJECT_ELEMENT_END ) );
+}
-pom = "\n"
-+ " 4.0.0\n"
-+ " pom\n"
-+ "";
+public void testAddModuleToParentWithModelVersion()
+throws Exception
+{
+String pom = PROJECT_ELEMENT
++ MODEL_VERSION
++ PACKAGING
++ PROJECT_ELEMENT_END;
-out = new StringWriter();
+StringWriter out = new StringWriter();
Review comment:
Looks like this could be a field that doesn't need to be initialized in each
method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-archetype] elharo commented on a change in pull request #35: ARCHETYPE-584 fix indention in root pom.xml
elharo commented on a change in pull request #35: ARCHETYPE-584 fix indention
in root pom.xml
URL: https://github.com/apache/maven-archetype/pull/35#discussion_r409778208
##
File path:
archetype-common/src/test/java/org/apache/maven/archetype/old/ArchetypeTest.java
##
@@ -61,6 +61,17 @@
public class ArchetypeTest
extends PlexusTestCase
{
+private static final String XML_VERSION_1_0 =
Review comment:
splitting out these constants makes the tests harder for me to read. I
prefer having all the expected content directly in each method, even at the
expense of some duplication.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-archetype] michael-o commented on a change in pull request #36: Add feature to create base dir
michael-o commented on a change in pull request #36: Add feature to create base
dir
URL: https://github.com/apache/maven-archetype/pull/36#discussion_r409777230
##
File path:
archetype-common/src/main/java/org/apache/maven/archetype/ArchetypeGenerationRequest.java
##
@@ -390,4 +392,16 @@ public ArchetypeGenerationRequest setFilter( String
filter )
return this;
}
+
+public boolean isCreateBaseDir()
+{
+return createBaseDir;
+}
+
+public ArchetypeGenerationRequest setCreteBaseDir( boolean createBaseDir )
Review comment:
HEre is a typo
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-archetype] rfscholte commented on issue #42: [MARCHETYPE-596] update xmlunit
rfscholte commented on issue #42: [MARCHETYPE-596] update xmlunit URL: https://github.com/apache/maven-archetype/pull/42#issuecomment-614831898 my guess: the rule is set to failOnWarning. AFAIK most recent version of this rule understands multirelease jar. On 16-4-2020 20:44:45, Elliotte Rusty Harold wrote: Hmm, shouldn't that be an ERROR, not a WARNING then? In either case, is our test here to strict? The problematic byte code is hidden in inside a multi-release jar so it should be OK for any VM that sees it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub [https://github.com/apache/maven-archetype/pull/42#issuecomment-614830007], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AABE3UBN5D332G6ATUQJ4BLRM5GZPANCNFSM4MJWENXA]. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (ARCHETYPE-595) Update Plexus
[ https://issues.apache.org/jira/browse/ARCHETYPE-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed ARCHETYPE-595. --- Assignee: Elliotte Rusty Harold > Update Plexus > - > > Key: ARCHETYPE-595 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-595 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARCHETYPE-595) Update Plexus
[ https://issues.apache.org/jira/browse/ARCHETYPE-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved ARCHETYPE-595. - Resolution: Fixed > Update Plexus > - > > Key: ARCHETYPE-595 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-595 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo merged pull request #43: [MARCHETYPE-595] update plexus
elharo merged pull request #43: [MARCHETYPE-595] update plexus URL: https://github.com/apache/maven-archetype/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] elharo commented on issue #42: [MARCHETYPE-596] update xmlunit
elharo commented on issue #42: [MARCHETYPE-596] update xmlunit URL: https://github.com/apache/maven-archetype/pull/42#issuecomment-614830007 Hmm, shouldn't that be an ERROR, not a WARNING then? In either case, is our test here to strict? The problematic byte code is hidden in inside a multi-release jar so it should be OK for any VM that sees it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] rfscholte commented on issue #42: [MARCHETYPE-596] update xmlunit
rfscholte commented on issue #42: [MARCHETYPE-596] update xmlunit URL: https://github.com/apache/maven-archetype/pull/42#issuecomment-614826701 It was not a test that failed. [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-bytecode-version) @ archetype-common --- [INFO] Restricted to JDK 1.7 yet javax.xml.bind:jaxb-api:jar:2.3.0:test contains META-INF/versions/9/javax/xml/bind/ModuleUtil.class targeted to JDK 1.9 [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message: Found Banned Dependency: javax.xml.bind:jaxb-api:jar:2.3.0 Use 'mvn dependency:tree' to locate the source of the banned dependencies. On 16-4-2020 20:24:47, Elliotte Rusty Harold wrote: Curious how this gives a red build AND "Test Result (no failures)" — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub [https://github.com/apache/maven-archetype/pull/42#issuecomment-614819854], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AABE3UCW2IG3Q5A2GKWLOYLRM5EOXANCNFSM4MJWENXA]. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] elharo commented on issue #42: [MARCHETYPE-596] update xmlunit
elharo commented on issue #42: [MARCHETYPE-596] update xmlunit URL: https://github.com/apache/maven-archetype/pull/42#issuecomment-614819854 Curious how this gives a red build AND "Test Result (no failures)" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MLINKCHECK-28) javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
[
https://issues.apache.org/jira/browse/MLINKCHECK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085169#comment-17085169
]
Elliotte Rusty Harold commented on MLINKCHECK-28:
-
perhaps relvant:
[https://dzone.com/articles/troubleshooting-javaxnetsslsslhandshakeexception-r]
> javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
> -
>
> Key: MLINKCHECK-28
> URL: https://issues.apache.org/jira/browse/MLINKCHECK-28
> Project: Maven Linkcheck Plugin
> Issue Type: Bug
>Affects Versions: 1.2
> Environment: Linux pc 4.4.0-59-generic #80-Ubuntu x86_64
>Reporter: Roman Ivanov
>Priority: Major
>
> reproducible on CI and on ubuntu 16.04.
> Link to repo: https://github.com/checkstyle/checkstyle
> CI logs: https://codeship.com/projects/124310/builds/22118854
> config: https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L1151
> It worked fine at 14:55 2017-01-26 on this CI, and failed at 17:51
> 2017-01-26. No config changes on checkstyle side, probably smth is changed on
> sourceforge side.
> Command in CI:
> {code}
> uname -a && mvn --version && curl -I http://checkstyle.sourceforge.net/ &&
> mvn clean site -Dcheckstyle.ant.skip=true -DskipTests -DskipITs
> -Dpmd.skip=true -Dfindbugs.skip=true -Dcobertura.skip=true
> -Dcheckstyle.skip=true && echo " grep of linkcheck.html--BEGIN"
> && grep externalLink target/site/linkcheck.html | cat && echo "
> grep of linkcheck.html--END" && RESULT=$(grep externalLink
> target/site/linkcheck.html | grep -v 'Read timed out' | wc -l) && echo 'Exit
> code:'$RESULT && if [[ $RESULT != 0 ]]; then false; fi
> {code}
> Problems with following links:
> https://sourceforge.net/p/checkstyle/news/feed
> https://sourceforge.net/projects/checkstyle/
> https://sourceforge.net/projects/checkstyle/files/checkstyle/
> Curl output right after maven execution, the same in CI:
> {code}
> $ curl -I https://sourceforge.net/projects/checkstyle/
> HTTP/1.1 200 OK
> Server: nginx
> Date: Sat, 28 Jan 2017 14:05:47 GMT
> Content-Type: text/html; charset=utf-8
>
> {code}
> HTML Report chunk:
> {code}
> href="https://sourceforge.net/p/checkstyle/news/feed;>https://sourceforge.net/p/checkstyle/news/feed:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> href="https://sourceforge.net/projects/checkstyle/;>https://sourceforge.net/projects/checkstyle/:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MLINKCHECK-36) upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts
[ https://issues.apache.org/jira/browse/MLINKCHECK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MLINKCHECK-36. --- > upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts > --- > > Key: MLINKCHECK-36 > URL: https://issues.apache.org/jira/browse/MLINKCHECK-36 > Project: Maven Linkcheck Plugin > Issue Type: Dependency upgrade >Affects Versions: 1.2 >Reporter: Herve Boutemy >Assignee: Elliotte Rusty Harold >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > to benefit from dependencies removal in DOXIASITETOOLS-215 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MLINKCHECK-36) upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts
[ https://issues.apache.org/jira/browse/MLINKCHECK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MLINKCHECK-36. - Resolution: Fixed > upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts > --- > > Key: MLINKCHECK-36 > URL: https://issues.apache.org/jira/browse/MLINKCHECK-36 > Project: Maven Linkcheck Plugin > Issue Type: Dependency upgrade >Affects Versions: 1.2 >Reporter: Herve Boutemy >Assignee: Elliotte Rusty Harold >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > to benefit from dependencies removal in DOXIASITETOOLS-215 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo merged pull request #44: [MARCHETYPE-598] update JUnit
elharo merged pull request #44: [MARCHETYPE-598] update JUnit URL: https://github.com/apache/maven-archetype/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SUREFIRE-1776) DefaultReportFactory doesn't report errors when engine fails
Mickael Istria created SUREFIRE-1776: Summary: DefaultReportFactory doesn't report errors when engine fails Key: SUREFIRE-1776 URL: https://issues.apache.org/jira/browse/SUREFIRE-1776 Project: Maven Surefire Issue Type: Bug Components: Maven Surefire Plugin Affects Versions: 2.22.0 Reporter: Mickael Istria We face an issue with tycho-surefire-plugin reporting "No tests found" when a test is actually found but the engine fails (for a tycho-specific reason) when preparing the test. tycho-surefire-plugin basically builds an OSGi container as defined in the usual Tycho way and uses Surefire API to run the tests inside that container and report it as a plain surefire does regularly. To do so, it does mainly uses `RunResult result = ProviderFactory.invokeProvider(...)`. However, it can happen that an error happen in the engine, before any test method starts (although the test method is scanned and detected and an executionRequest is emitted for it). The cases for it are relatively probable with Tycho/OSGi. In such case, even if the engine faced an error, we get a RunResult mentioning no error, actually reporting no test execution, but no error, usually making the test report say everything is fine or telling "No tests found" (which is also incorrect because test is found, it could not just be started). I could dig a bit more and I think the DefaultTestReporter.mergeTestHistoryResult() method just fails at handling the cases of errors when the error do not happen on the test method, because it wrongly assumes that `listener.getTestMethodStats()` is exhaustive. More specifically, when debugging this method, I do see in debugger that `this.listeners[0].detailsForThis` has `completedCount==1` and `errors==1` but the return value says completedCount==0 and errors=0; its reportEntries show one error entry, which has for source `` so they're not returned by `listener.getTestMethodStats()`. I believe the DefaultReportFactory should handle the case to verify before returning whether such unrooted error wasn't missed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MLINKCHECK-36) upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts
[ https://issues.apache.org/jira/browse/MLINKCHECK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085013#comment-17085013 ] Hudson commented on MLINKCHECK-36: -- Build succeeded in Jenkins: Maven TLP » maven-linkcheck-plugin » master #34 See https://builds.apache.org/job/maven-box/job/maven-linkcheck-plugin/job/master/34/ > upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts > --- > > Key: MLINKCHECK-36 > URL: https://issues.apache.org/jira/browse/MLINKCHECK-36 > Project: Maven Linkcheck Plugin > Issue Type: Dependency upgrade >Affects Versions: 1.2 >Reporter: Herve Boutemy >Assignee: Elliotte Rusty Harold >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > to benefit from dependencies removal in DOXIASITETOOLS-215 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo merged pull request #40: {MARCHETYPE-593] update artifact transfer
elharo merged pull request #40: {MARCHETYPE-593] update artifact transfer
URL: https://github.com/apache/maven-archetype/pull/40
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-archetype] elharo merged pull request #39: [MARCHETYPE-592] update commons-io
elharo merged pull request #39: [MARCHETYPE-592] update commons-io URL: https://github.com/apache/maven-archetype/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] elharo merged pull request #38: [MARCHETYPE-591] update jdom
elharo merged pull request #38: [MARCHETYPE-591] update jdom URL: https://github.com/apache/maven-archetype/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-linkcheck-plugin] elharo merged pull request #1: [MLINKCHECK-36] update doxia and parent POM
elharo merged pull request #1: [MLINKCHECK-36] update doxia and parent POM URL: https://github.com/apache/maven-linkcheck-plugin/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-jxr] elharo merged pull request #16: remove reference to deprecated class
elharo merged pull request #16: remove reference to deprecated class URL: https://github.com/apache/maven-jxr/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MLINKCHECK-28) javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
[
https://issues.apache.org/jira/browse/MLINKCHECK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084904#comment-17084904
]
Roman Ivanov commented on MLINKCHECK-28:
checkstyle project is on jdk8 from May 29, 2016 , so this issue was created
when we were on jdk8 (we still use jdk8).
You can reproduce issue by execution of ".ci/run-link-check-plugin.sh" in our
repo.
Here is logs of execution of this command -
https://app.codeship.com/projects/124310
> javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
> -
>
> Key: MLINKCHECK-28
> URL: https://issues.apache.org/jira/browse/MLINKCHECK-28
> Project: Maven Linkcheck Plugin
> Issue Type: Bug
>Affects Versions: 1.2
> Environment: Linux pc 4.4.0-59-generic #80-Ubuntu x86_64
>Reporter: Roman Ivanov
>Priority: Major
>
> reproducible on CI and on ubuntu 16.04.
> Link to repo: https://github.com/checkstyle/checkstyle
> CI logs: https://codeship.com/projects/124310/builds/22118854
> config: https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L1151
> It worked fine at 14:55 2017-01-26 on this CI, and failed at 17:51
> 2017-01-26. No config changes on checkstyle side, probably smth is changed on
> sourceforge side.
> Command in CI:
> {code}
> uname -a && mvn --version && curl -I http://checkstyle.sourceforge.net/ &&
> mvn clean site -Dcheckstyle.ant.skip=true -DskipTests -DskipITs
> -Dpmd.skip=true -Dfindbugs.skip=true -Dcobertura.skip=true
> -Dcheckstyle.skip=true && echo " grep of linkcheck.html--BEGIN"
> && grep externalLink target/site/linkcheck.html | cat && echo "
> grep of linkcheck.html--END" && RESULT=$(grep externalLink
> target/site/linkcheck.html | grep -v 'Read timed out' | wc -l) && echo 'Exit
> code:'$RESULT && if [[ $RESULT != 0 ]]; then false; fi
> {code}
> Problems with following links:
> https://sourceforge.net/p/checkstyle/news/feed
> https://sourceforge.net/projects/checkstyle/
> https://sourceforge.net/projects/checkstyle/files/checkstyle/
> Curl output right after maven execution, the same in CI:
> {code}
> $ curl -I https://sourceforge.net/projects/checkstyle/
> HTTP/1.1 200 OK
> Server: nginx
> Date: Sat, 28 Jan 2017 14:05:47 GMT
> Content-Type: text/html; charset=utf-8
>
> {code}
> HTML Report chunk:
> {code}
> href="https://sourceforge.net/p/checkstyle/news/feed;>https://sourceforge.net/p/checkstyle/news/feed:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> href="https://sourceforge.net/projects/checkstyle/;>https://sourceforge.net/projects/checkstyle/:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-archetype] elharo opened a new pull request #44: [MARCHETYPE-598] update JUnit
elharo opened a new pull request #44: [MARCHETYPE-598] update JUnit URL: https://github.com/apache/maven-archetype/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ARCHETYPE-599) Update maven-antrun-plugn
Elliotte Rusty Harold created ARCHETYPE-599: --- Summary: Update maven-antrun-plugn Key: ARCHETYPE-599 URL: https://issues.apache.org/jira/browse/ARCHETYPE-599 Project: Maven Archetype Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARCHETYPE-598) Update JUnit
Elliotte Rusty Harold created ARCHETYPE-598: --- Summary: Update JUnit Key: ARCHETYPE-598 URL: https://issues.apache.org/jira/browse/ARCHETYPE-598 Project: Maven Archetype Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo closed pull request #41: update xmlunit
elharo closed pull request #41: update xmlunit URL: https://github.com/apache/maven-archetype/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] elharo opened a new pull request #43: [MARCHETYPE-595] update plexus
elharo opened a new pull request #43: [MARCHETYPE-595] update plexus URL: https://github.com/apache/maven-archetype/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] elharo opened a new pull request #42: [MARCHETYPE-595] update xmlunit
elharo opened a new pull request #42: [MARCHETYPE-595] update xmlunit URL: https://github.com/apache/maven-archetype/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (ARCHETYPE-596) Update xmlunit
[ https://issues.apache.org/jira/browse/ARCHETYPE-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned ARCHETYPE-596: --- Assignee: Elliotte Rusty Harold > Update xmlunit > -- > > Key: ARCHETYPE-596 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-596 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo opened a new pull request #41: update xmlunit
elharo opened a new pull request #41: update xmlunit URL: https://github.com/apache/maven-archetype/pull/41 @Tibor17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ARCHETYPE-597) update aether
Elliotte Rusty Harold created ARCHETYPE-597: --- Summary: update aether Key: ARCHETYPE-597 URL: https://issues.apache.org/jira/browse/ARCHETYPE-597 Project: Maven Archetype Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold use resolver instead of org.sonatype.aether -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARCHETYPE-596) Update xmlunit
Elliotte Rusty Harold created ARCHETYPE-596: --- Summary: Update xmlunit Key: ARCHETYPE-596 URL: https://issues.apache.org/jira/browse/ARCHETYPE-596 Project: Maven Archetype Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARCHETYPE-595) Update Plexus
Elliotte Rusty Harold created ARCHETYPE-595: --- Summary: Update Plexus Key: ARCHETYPE-595 URL: https://issues.apache.org/jira/browse/ARCHETYPE-595 Project: Maven Archetype Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARCHETYPE-594) Update easymock
Elliotte Rusty Harold created ARCHETYPE-594: --- Summary: Update easymock Key: ARCHETYPE-594 URL: https://issues.apache.org/jira/browse/ARCHETYPE-594 Project: Maven Archetype Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo opened a new pull request #40: {MARCHETYPE-593] update artifact transfer
elharo opened a new pull request #40: {MARCHETYPE-593] update artifact transfer
URL: https://github.com/apache/maven-archetype/pull/40
@Tibor17
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-archetype] elharo opened a new pull request #39: update commons-io
elharo opened a new pull request #39: update commons-io URL: https://github.com/apache/maven-archetype/pull/39 @Tibor17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ARCHETYPE-592) Update commons-io
Elliotte Rusty Harold created ARCHETYPE-592: --- Summary: Update commons-io Key: ARCHETYPE-592 URL: https://issues.apache.org/jira/browse/ARCHETYPE-592 Project: Maven Archetype Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold Assignee: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARCHETYPE-593) Update artifact-transfer
Elliotte Rusty Harold created ARCHETYPE-593: --- Summary: Update artifact-transfer Key: ARCHETYPE-593 URL: https://issues.apache.org/jira/browse/ARCHETYPE-593 Project: Maven Archetype Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5 URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-614652858 @mosabua yes, I would doo it too, even 3.3.x as well. We have updated all plugins to 3.0 and it was not easy job. IMO doing it with 3.1 would be as simple as updating the dependencies only and much easier than before. If we would do it systemematically, we would deprecate also 3.2, I am sure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (ARCHETYPE-591) Update JDOM
[ https://issues.apache.org/jira/browse/ARCHETYPE-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned ARCHETYPE-591: --- Assignee: Elliotte Rusty Harold > Update JDOM > --- > > Key: ARCHETYPE-591 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-591 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-archetype] elharo opened a new pull request #38: [MARCHETYPE-591] update jdom
elharo opened a new pull request #38: [MARCHETYPE-591] update jdom URL: https://github.com/apache/maven-archetype/pull/38 @Tibor17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ARCHETYPE-591) Update JDOM
Elliotte Rusty Harold created ARCHETYPE-591: --- Summary: Update JDOM Key: ARCHETYPE-591 URL: https://issues.apache.org/jira/browse/ARCHETYPE-591 Project: Maven Archetype Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MLINKCHECK-28) javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
[
https://issues.apache.org/jira/browse/MLINKCHECK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084861#comment-17084861
]
Elliotte Rusty Harold commented on MLINKCHECK-28:
-
What JDK are you using? These issues are sometimes caused when an old JDK 7 or
earlier hits a newer website.
> javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
> -
>
> Key: MLINKCHECK-28
> URL: https://issues.apache.org/jira/browse/MLINKCHECK-28
> Project: Maven Linkcheck Plugin
> Issue Type: Bug
>Affects Versions: 1.2
> Environment: Linux pc 4.4.0-59-generic #80-Ubuntu x86_64
>Reporter: Roman Ivanov
>Priority: Major
>
> reproducible on CI and on ubuntu 16.04.
> Link to repo: https://github.com/checkstyle/checkstyle
> CI logs: https://codeship.com/projects/124310/builds/22118854
> config: https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L1151
> It worked fine at 14:55 2017-01-26 on this CI, and failed at 17:51
> 2017-01-26. No config changes on checkstyle side, probably smth is changed on
> sourceforge side.
> Command in CI:
> {code}
> uname -a && mvn --version && curl -I http://checkstyle.sourceforge.net/ &&
> mvn clean site -Dcheckstyle.ant.skip=true -DskipTests -DskipITs
> -Dpmd.skip=true -Dfindbugs.skip=true -Dcobertura.skip=true
> -Dcheckstyle.skip=true && echo " grep of linkcheck.html--BEGIN"
> && grep externalLink target/site/linkcheck.html | cat && echo "
> grep of linkcheck.html--END" && RESULT=$(grep externalLink
> target/site/linkcheck.html | grep -v 'Read timed out' | wc -l) && echo 'Exit
> code:'$RESULT && if [[ $RESULT != 0 ]]; then false; fi
> {code}
> Problems with following links:
> https://sourceforge.net/p/checkstyle/news/feed
> https://sourceforge.net/projects/checkstyle/
> https://sourceforge.net/projects/checkstyle/files/checkstyle/
> Curl output right after maven execution, the same in CI:
> {code}
> $ curl -I https://sourceforge.net/projects/checkstyle/
> HTTP/1.1 200 OK
> Server: nginx
> Date: Sat, 28 Jan 2017 14:05:47 GMT
> Content-Type: text/html; charset=utf-8
>
> {code}
> HTML Report chunk:
> {code}
> href="https://sourceforge.net/p/checkstyle/news/feed;>https://sourceforge.net/p/checkstyle/news/feed:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> href="https://sourceforge.net/projects/checkstyle/;>https://sourceforge.net/projects/checkstyle/:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-linkcheck-plugin] elharo commented on a change in pull request #1: [MLINKCHECK-36] update doxia and parent POM
elharo commented on a change in pull request #1: [MLINKCHECK-36] update doxia and parent POM URL: https://github.com/apache/maven-linkcheck-plugin/pull/1#discussion_r409542510 ## File path: pom.xml ## @@ -62,11 +62,11 @@ under the License. -1.4 -1.4 +1.9.1 +1.9.2 2.2.1 7 - 2020-04-07T21:04:00Z +2020-04-04T16:07:00Z Review comment: fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MGPG-79) plugin hangs on first run on Windows Git Bash with Kleopatra
Herve Boutemy created MGPG-79:
-
Summary: plugin hangs on first run on Windows Git Bash with
Kleopatra
Key: MGPG-79
URL: https://issues.apache.org/jira/browse/MGPG-79
Project: Maven GPG Plugin
Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Herve Boutemy
Fix For: 3.0.2
found during release 3.0.0 vote:
[https://lists.apache.org/thread.html/r855a3f8d4b161da297191e5a7ce0e7e5be81895e60fe5b7be16cc604%40%3Cdev.maven.apache.org%3E]
{quote}the plugin simply hangs and does not continue if I use 3.0.0 after
starting Kleopatra (https://docs.kde.org/stable5/en/pim/kleopatra/).
When I first use 1.6 of the plugin after starting Kleopatra, the
password dialog pops up (as ususal), the files are signed *and after
this I am able to use 3.0.0 just fine!*
So with 3.0.0 the initial communication with the agent seems to be broken...
$ mvn -version
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\_dev\Maven\latest
Java version: 11.0.6, vendor: AdoptOpenJDK, runtime: C:\_dev\Java\latest
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
$ gpg --version
gpg (GnuPG) 2.2.19-unknown
libgcrypt 1.8.5
Git Bash.{quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MGPG-78) gpg version parsing failure on Windows
[
https://issues.apache.org/jira/browse/MGPG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MGPG-78:
--
Issue Type: Bug (was: Improvement)
> gpg version parsing failure on Windows
> --
>
> Key: MGPG-78
> URL: https://issues.apache.org/jira/browse/MGPG-78
> Project: Maven GPG Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.0.2
>
>
> found during 3.0.0 release vote:
> https://lists.apache.org/thread.html/rcab83b862f15ca276aab3fc61cd4192e1a67a35a2a6ce7ad4c7994b1%40%3Cdev.maven.apache.org%3E
> {noformat}Caused by: java.lang.IllegalArgumentException: Can't parse version
> of
> gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)
> at org.apache.maven.plugins.gpg.GpgVersion.compareTo(GpgVersion.java:60)
> at org.apache.maven.plugins.gpg.GpgVersion.isBefore(GpgVersion.java:101)
> at
> org.apache.maven.plugins.gpg.GpgSigner.generateSignatureForFile(GpgSigner.java:89)
> at
> org.apache.maven.plugins.gpg.AbstractGpgSigner.generateSignatureForArtifact(AbstractGpgSigner.java:203)
> at
> org.apache.maven.plugins.gpg.GpgSignAttachedMojo.execute(GpgSignAttachedMojo.java:178)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134){noformat}
> The version on the command line:
> {noformat}$ gpg --version
> gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)
> libgcrypt 1.6.2
> Copyright (C) 2013 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> [show/hide original text] {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MGPG-78) gpg version parsing failure on Windows
[
https://issues.apache.org/jira/browse/MGPG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MGPG-78:
--
Fix Version/s: 3.0.2
> gpg version parsing failure on Windows
> --
>
> Key: MGPG-78
> URL: https://issues.apache.org/jira/browse/MGPG-78
> Project: Maven GPG Plugin
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.0.2
>
>
> found during 3.0.0 release vote:
> https://lists.apache.org/thread.html/rcab83b862f15ca276aab3fc61cd4192e1a67a35a2a6ce7ad4c7994b1%40%3Cdev.maven.apache.org%3E
> {noformat}Caused by: java.lang.IllegalArgumentException: Can't parse version
> of
> gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)
> at org.apache.maven.plugins.gpg.GpgVersion.compareTo(GpgVersion.java:60)
> at org.apache.maven.plugins.gpg.GpgVersion.isBefore(GpgVersion.java:101)
> at
> org.apache.maven.plugins.gpg.GpgSigner.generateSignatureForFile(GpgSigner.java:89)
> at
> org.apache.maven.plugins.gpg.AbstractGpgSigner.generateSignatureForArtifact(AbstractGpgSigner.java:203)
> at
> org.apache.maven.plugins.gpg.GpgSignAttachedMojo.execute(GpgSignAttachedMojo.java:178)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134){noformat}
> The version on the command line:
> {noformat}$ gpg --version
> gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)
> libgcrypt 1.6.2
> Copyright (C) 2013 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> [show/hide original text] {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MGPG-78) gpg version parsing failure on Windows
Herve Boutemy created MGPG-78:
-
Summary: gpg version parsing failure on Windows
Key: MGPG-78
URL: https://issues.apache.org/jira/browse/MGPG-78
Project: Maven GPG Plugin
Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Herve Boutemy
found during 3.0.0 release vote:
https://lists.apache.org/thread.html/rcab83b862f15ca276aab3fc61cd4192e1a67a35a2a6ce7ad4c7994b1%40%3Cdev.maven.apache.org%3E
{noformat}Caused by: java.lang.IllegalArgumentException: Can't parse version of
gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)
at org.apache.maven.plugins.gpg.GpgVersion.compareTo(GpgVersion.java:60)
at org.apache.maven.plugins.gpg.GpgVersion.isBefore(GpgVersion.java:101)
at
org.apache.maven.plugins.gpg.GpgSigner.generateSignatureForFile(GpgSigner.java:89)
at
org.apache.maven.plugins.gpg.AbstractGpgSigner.generateSignatureForArtifact(AbstractGpgSigner.java:203)
at
org.apache.maven.plugins.gpg.GpgSignAttachedMojo.execute(GpgSignAttachedMojo.java:178)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134){noformat}
The version on the command line:
{noformat}$ gpg --version
gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)
libgcrypt 1.6.2
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
[show/hide original text] {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
