date:20200518

[jira] [Updated] (MJMOD-27) Implement unpack goal

2020-05-18 Thread Alexander Kriegisch (Jira)



 [ 
https://issues.apache.org/jira/browse/MJMOD-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Kriegisch updated MJMOD-27:
-
Description: 
There has not been another alpha release for 2.5 years (2017/09 to 2020/05), so 
I am not sure if this project is dead or alive. But in case development is 
still active, I would like to have an option to not only to create a JMOD but 
also to *unpack* one. Maybe this could also be implemented in Maven Assembly. I 
am not sure where it would fit best, but I think here.

Background:
 * Sometimes I want to instrument JRE/JDK classes using ASM, ByteBuddy, 
Javassist or similar byte code engineering tools during build time in order to 
then either prepend the resulting JAR file to the boot classpath (Java <= 8) or 
to use `--patch-module` (Java >= 9).
 * In order to do that in Java 9+ environments, I have to use JDK command line 
tools like _jmod.exe_ (unpack single JMOD from _jmods_ directory) or 
_jimage.exe_ (unpack _lib/modules_).
 * The result is a partly scripted build, using a Beanshell script via Build 
Helper or something like Antrun.

The benefit of having an unpack feature accessible via a Maven plugin is 
obvious, I think. Who likes scripted builds?

  was:
There has not been another alpha release for 2.5 years (2017/09 to 2020/05), so 
I am not sure if this project is dead or alive. But in case development is 
still active, I would like to have an option to not only to create a JMOD but 
also to *unpack* one. Maybe this could also be implemented in Maven Assembly. I 
am not sure where it would fit best, but I think here.

Background:
 * Sometimes I want to instrument JRE/JDK classes using ASM, ByteBuddy, 
Javassist or similar byte code engineering tools during build time in order to 
then either prepend the resulting JAR file to the boot classpath (Java <= 8) or 
to use `--patch-module` (Java >= 9).
 * In order to do that in Java 9+ environments, I have to use JDK command line 
tools like _jmod.exe_ (unpack single JMOD from _jmods_ directory) or 
_jimage.exe_ (unpack _lib/modules_).
 * The result is a partly scripted build, using a Beanshell script via Build 
Helper or something like Antrun.
 * The benefit of having an unpack feature accessible via a Maven plugin is 
obvious, I think. Who likes scripted builds?


> Implement unpack goal
> -
>
> Key: MJMOD-27
> URL: https://issues.apache.org/jira/browse/MJMOD-27
> Project: Maven JMod Plugin
>  Issue Type: New Feature
>Affects Versions: 3.0.0-alpha-1
>Reporter: Alexander Kriegisch
>Priority: Major
>
> There has not been another alpha release for 2.5 years (2017/09 to 2020/05), 
> so I am not sure if this project is dead or alive. But in case development is 
> still active, I would like to have an option to not only to create a JMOD but 
> also to *unpack* one. Maybe this could also be implemented in Maven Assembly. 
> I am not sure where it would fit best, but I think here.
> Background:
>  * Sometimes I want to instrument JRE/JDK classes using ASM, ByteBuddy, 
> Javassist or similar byte code engineering tools during build time in order 
> to then either prepend the resulting JAR file to the boot classpath (Java <= 
> 8) or to use `--patch-module` (Java >= 9).
>  * In order to do that in Java 9+ environments, I have to use JDK command 
> line tools like _jmod.exe_ (unpack single JMOD from _jmods_ directory) or 
> _jimage.exe_ (unpack _lib/modules_).
>  * The result is a partly scripted build, using a Beanshell script via Build 
> Helper or something like Antrun.
> The benefit of having an unpack feature accessible via a Maven plugin is 
> obvious, I think. Who likes scripted builds?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (MJMOD-27) Implement unpack goal

2020-05-18 Thread Alexander Kriegisch (Jira)



 [ 
https://issues.apache.org/jira/browse/MJMOD-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Kriegisch updated MJMOD-27:
-
Description: 
There has not been another alpha release for 2.5 years (2017/09 to 2020/05), so 
I am not sure if this project is dead or alive. But in case development is 
still active, I would like to have an option to not only to create a JMOD but 
also to *unpack* one. Maybe this could also be implemented in Maven Assembly. I 
am not sure where it would fit best, but I think here.

Background:
 * Sometimes I want to instrument JRE/JDK classes using ASM, ByteBuddy, 
Javassist or similar byte code engineering tools during build time in order to 
then either prepend the resulting JAR file to the boot classpath (Java <= 8) or 
to use `--patch-module` (Java >= 9).
 * In order to do that in Java 9+ environments, I have to use JDK command line 
tools like _jmod.exe_ (unpack single JMOD from _jmods_ directory) or 
_jimage.exe_ (unpack _lib/modules_).
 * The result is a partly scripted build, using a Beanshell script via Build 
Helper or something like Antrun.
 * The benefit of having an unpack feature accessible via a Maven plugin is 
obvious, I think. Who likes scripted builds?

  was:
There has not been another alpha release for 2.5 years (2017/09 to 2020/05), so 
I am not sure if this project is dead or alive. But in case development is 
still active, I would like to have an option not only to create a JMOD but also 
to unpack one. Maybe this could also be implemented in Maven Assembly. I am not 
sure where it would fit best, but I think here.

Background:
 * Sometimes I want to instrument JRE/JDK classes using ASM, ByteBuddy, 
Javassist or similar byte code engineering tools during build time in order to 
then either prepend the resulting JAR file to the boot classpath (Java <= 8) or 
to use `--patch-module` (Java >= 9).
 * In order to do that in Java 9+ environments, I have to use JDK command line 
tools like _jmod.exe_ (unpack single JMOD from _jmods_ directory) or 
_jimage.exe_ (unpack _lib/modules_).
 * The result is a partly scripted build, using a Beanshell script via Build 
Helper or something like Antrun.
 * The benefit of having an unpack feature accessible via a Maven plugin is 
obvious, I think. Who likes scripted builds?


> Implement unpack goal
> -
>
> Key: MJMOD-27
> URL: https://issues.apache.org/jira/browse/MJMOD-27
> Project: Maven JMod Plugin
>  Issue Type: New Feature
>Affects Versions: 3.0.0-alpha-1
>Reporter: Alexander Kriegisch
>Priority: Major
>
> There has not been another alpha release for 2.5 years (2017/09 to 2020/05), 
> so I am not sure if this project is dead or alive. But in case development is 
> still active, I would like to have an option to not only to create a JMOD but 
> also to *unpack* one. Maybe this could also be implemented in Maven Assembly. 
> I am not sure where it would fit best, but I think here.
> Background:
>  * Sometimes I want to instrument JRE/JDK classes using ASM, ByteBuddy, 
> Javassist or similar byte code engineering tools during build time in order 
> to then either prepend the resulting JAR file to the boot classpath (Java <= 
> 8) or to use `--patch-module` (Java >= 9).
>  * In order to do that in Java 9+ environments, I have to use JDK command 
> line tools like _jmod.exe_ (unpack single JMOD from _jmods_ directory) or 
> _jimage.exe_ (unpack _lib/modules_).
>  * The result is a partly scripted build, using a Beanshell script via Build 
> Helper or something like Antrun.
>  * The benefit of having an unpack feature accessible via a Maven plugin is 
> obvious, I think. Who likes scripted builds?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (MJMOD-27) Implement unpack goal

2020-05-18 Thread Alexander Kriegisch (Jira)

Alexander Kriegisch created MJMOD-27:


 Summary: Implement unpack goal
 Key: MJMOD-27
 URL: https://issues.apache.org/jira/browse/MJMOD-27
 Project: Maven JMod Plugin
  Issue Type: New Feature
Affects Versions: 3.0.0-alpha-1
Reporter: Alexander Kriegisch


There has not been another alpha release for 2.5 years (2017/09 to 2020/05), so 
I am not sure if this project is dead or alive. But in case development is 
still active, I would like to have an option not only to create a JMOD but also 
to unpack one. Maybe this could also be implemented in Maven Assembly. I am not 
sure where it would fit best, but I think here.

Background:
 * Sometimes I want to instrument JRE/JDK classes using ASM, ByteBuddy, 
Javassist or similar byte code engineering tools during build time in order to 
then either prepend the resulting JAR file to the boot classpath (Java <= 8) or 
to use `--patch-module` (Java >= 9).
 * In order to do that in Java 9+ environments, I have to use JDK command line 
tools like _jmod.exe_ (unpack single JMOD from _jmods_ directory) or 
_jimage.exe_ (unpack _lib/modules_).
 * The result is a partly scripted build, using a Beanshell script via Build 
Helper or something like Antrun.
 * The benefit of having an unpack feature accessible via a Maven plugin is 
obvious, I think. Who likes scripted builds?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6598) Maven 3.6.0 and Surefire problem

2020-05-18 Thread Claus Nielsen (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110827#comment-17110827
 ] 

Claus Nielsen commented on MNG-6598:


I guess I need some instructions on how to build Maven from source and use it 
locally to confirm. Is it just as simple as running a mvn clean package on the 
branch?

> Maven 3.6.0 and Surefire problem
> 
>
> Key: MNG-6598
> URL: https://issues.apache.org/jira/browse/MNG-6598
> Project: Maven
>  Issue Type: Task
>  Components: General
>Affects Versions: 3.6.0
> Environment: windows 7, 64bit Oracle jdk 1.8 (see stacktrace)
>Reporter: Lars Borup Jensen
>Priority: Critical
> Fix For: 3.7.0-candidate
>
>
> We've been using 3.5.2 for a longer period of time and just recently upgraded 
> to 3.6.0 and then the problems started.
> First we experienced way longer build times when running the absolutely same 
> build in 3.6.0 than 3.5.2. Using -B when running locally does seem to improve 
> build time but still not quite the same.
> The main issue and one that is really causing us headaches is that Surefire 
> 2.22.0 suddently started failing to create forks when running tests - setting 
> forkCount does help on this, but then we come back to the above mentioned 
> problem: build time, which then becomes painfully slow. 
> So our discovery is: same source, same POM (same versions of plugins etc) 
> fails to build on 3.6.0 but works on 3.5.2 (and even faster) - do you have 
> any pointers for us, what to look for?
> Stacktrace from Maven
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on 
> project myproj: There are test failures.
> [ERROR]
> [ERROR] Please refer to C:\projects\myproj\proj\target\surefire-reports for 
> the individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] The forked VM terminated without properly saying goodbye. VM crash or 
> System.exit called?
> [ERROR] Command was cmd.exe /X /C "C:\tools\oracle\jdk\1.8.0_192\jre\bin\java 
> -javaagent:C:\\tools\\apache\\maven\\m2repository\\org\\jacoco\\org.jacoco.agent\\0.8.2\\org.jacoco.agent-0.8.2-runtime.jar=destfile=C:\\projects\\myproj\\proj\\target\\jacoco.exec,append=true,excludes=*_javassist_*:**/com/**/*:**/dk/company/schemas/**/*:**/dk/oio/**/*:**/net/companynet/**/*:**/dk/othercompany/**/*:**/dk/othercompany/integration/**/*:**/dk/company/stub/**/*
>  -jar 
> C:\Users\someuser\AppData\Local\Temp\surefire1255787583870225582\surefirebooter6297886391209366508.jar
>  C:\Users\someuser\AppData\Local\Temp\surefire1255787583870225582 
> 2019-02-22T09-01-49_197-jvmRun1 surefire7364437855153295156tmp 
> surefire_13521419335267356208tmp"
> [ERROR] Process Exit Code: 0
> [ERROR] Crashed tests:
> [ERROR] dk.company.proj.persistence.RepositoryTest
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: The 
> forked VM terminated without properly saying goodbye. VM crash or System.exit 
> called?
> [ERROR] Command was cmd.exe /X /C "C:\tools\oracle\jdk\1.8.0_192\jre\bin\java 
> -javaagent:C:\\tools\\apache\\maven\\m2repository\\org\\jacoco\\org.jacoco.agent\\0.8.2\\org.jacoco.agent-0.8.2-runtime.jar=destfile=C:\\projects\\myproj\\proj\\target\\jacoco.exec,append=true,excludes=*_javassist_*:**/com/**/*:**/dk/company/schemas/**/*:**/dk/oio/**/*:**/net/companynet/**/*:**/dk/othercompany/**/*:**/dk/othercompany/integration/**/*:**/dk/company/stub/**/*
>  -jar 
> C:\Users\someuser\AppData\Local\Temp\surefire1255787583870225582\surefirebooter6297886391209366508.jar
>  C:\Users\someuser\AppData\Local\Temp\surefire1255787583870225582 
> 2019-02-22T09-01-49_197-jvmRun1 surefire7364437855153295156tmp 
> surefire_13521419335267356208tmp"
> [ERROR] Process Exit Code: 0
> [ERROR] Crashed tests:
> [ERROR] dk.company.proj.persistence.RepositoryTest
> [ERROR] at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
> [ERROR] at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
> [ERROR] at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
> [ERROR] at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:244)
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (MNG-6049) Add behavior to filter resolved version ranges of an artifact

2020-05-18 Thread Xiang Li (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110645#comment-17110645
 ] 

Xiang Li edited comment on MNG-6049 at 5/19/20, 1:34 AM:
-

Hi, since aether got merged after maven 3.5, I can not find the same method 
anymore, wonder if the interface got removed or still presist in another name?


was (Author: xiang li):
Hi, I wonder if it is still on the road map?

> Add behavior to filter resolved version ranges of an artifact
> -
>
> Key: MNG-6049
> URL: https://issues.apache.org/jira/browse/MNG-6049
> Project: Maven
>  Issue Type: Improvement
>  Components: core, Dependencies
>Reporter: Uwe Barthel
>Priority: Critical
> Fix For: 3.7.x-candidate
>
>
> The discussion on issue MNG-3092 shows the seriously needs of different kinds 
> of version range resolving in Maven.
> This solution provides a hook for Maven extensions/plugins to change the list 
> of resolved version range results as required.
> The {{DefaultVersionRangeResolver}} will be extended with a filter for 
> version range results. A new interface {{VersionRangeResultFilter}} is added 
> and a non-filtering {{DefaultVersionRangeResultFilter}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SUREFIRE-1228) rerunFailingTestsCount + TestNG + @DataProvider = failed tests pass

2020-05-18 Thread Tibor Digana (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110749#comment-17110749
 ] 

Tibor Digana commented on SUREFIRE-1228:


[~cmorris_partnet]
Regardless of the "rerun", check it out with the project version 
3.0.0-SNAPSHOT. We implemented another fix which identifies distinct runs of 
each test. There should be total=2 and failure=1.

> rerunFailingTestsCount + TestNG + @DataProvider = failed tests pass
> ---
>
> Key: SUREFIRE-1228
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1228
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: TestNG support
>Affects Versions: 2.19.1
>Reporter: Cam Morris
>Assignee: Tibor Digana
>Priority: Major
> Attachments: TestRandomFail.java, pom.xml
>
>
> Surefire confuses tests run with a data-provider with rerun tests so only one 
> of the data-provided tests need to pass.
> Steps to reproduce:
> # Create a testNG test with a data provider that passes with some of the data 
> and fails with others
> {code:title=TestNG example|language=java}
>   @Test(dataProvider = "succeed")
>   public void fail(boolean succeed) {
> if (!succeed) {
>   Assert.fail("nope");
> }
>   }
>   @DataProvider(name="succeed")
>   public Object[][] arrayIndex() {
> return new Object[][]{ {true}, {false}};
>   }
> {code}
> # Configure surefire to rerun failed tests
> {code:title=pom.xml example|language=xml}
> 
> http://maven.apache.org/POM/4.0.0;
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> cam.test
> testng-retry
> 1.0-SNAPSHOT
> 
> 
> org.testng
> testng
> 6.9.10
> test
> 
> 
> 
> 
> 
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.19.1
> 
>   1
> 
> 
> 
> 
> 
> {code}
> - *Expected results*:  "Tests run: 2, Failures: 1..."  The tests should not 
> pass.
> - *Actual results*: "Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, 
> Flakes: 1"  The rerun confuses test runs with different data for retry 
> attempts.  Just one of the data provider tests needs to succeed for the test 
> to be deemed a success.
> {code}mvn test
> ...
> ---
>  T E S T S
> ---
> Running TestRandomFail
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.267 sec <<< 
> FAILURE! - in TestRandomFail
> fail(TestRandomFail)  Time elapsed: 0.007 sec  <<< FAILURE!
> java.lang.AssertionError: nope
> at TestRandomFail.fail(TestRandomFail.java:14)
> Results :
> Flaked tests: 
> TestRandomFail.fail(TestRandomFail)
>   Run 1: PASS
>   Run 2: TestRandomFail.fail:14 nope
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Flakes: 1
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2.251 s
> [INFO] Finished at: 2016-02-10T07:39:21-07:00
> [INFO] Final Memory: 9M/244M
> [INFO] 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SUREFIRE-1228) rerunFailingTestsCount + TestNG + @DataProvider = failed tests pass

2020-05-18 Thread Cam Morris (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110720#comment-17110720
 ] 

Cam Morris commented on SUREFIRE-1228:
--

I'm pulling down the code to attempt to implement this in the testng provider.  
A few pointers of where to start would be nice.

> rerunFailingTestsCount + TestNG + @DataProvider = failed tests pass
> ---
>
> Key: SUREFIRE-1228
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1228
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: TestNG support
>Affects Versions: 2.19.1
>Reporter: Cam Morris
>Assignee: Tibor Digana
>Priority: Major
> Attachments: TestRandomFail.java, pom.xml
>
>
> Surefire confuses tests run with a data-provider with rerun tests so only one 
> of the data-provided tests need to pass.
> Steps to reproduce:
> # Create a testNG test with a data provider that passes with some of the data 
> and fails with others
> {code:title=TestNG example|language=java}
>   @Test(dataProvider = "succeed")
>   public void fail(boolean succeed) {
> if (!succeed) {
>   Assert.fail("nope");
> }
>   }
>   @DataProvider(name="succeed")
>   public Object[][] arrayIndex() {
> return new Object[][]{ {true}, {false}};
>   }
> {code}
> # Configure surefire to rerun failed tests
> {code:title=pom.xml example|language=xml}
> 
> http://maven.apache.org/POM/4.0.0;
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> cam.test
> testng-retry
> 1.0-SNAPSHOT
> 
> 
> org.testng
> testng
> 6.9.10
> test
> 
> 
> 
> 
> 
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.19.1
> 
>   1
> 
> 
> 
> 
> 
> {code}
> - *Expected results*:  "Tests run: 2, Failures: 1..."  The tests should not 
> pass.
> - *Actual results*: "Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, 
> Flakes: 1"  The rerun confuses test runs with different data for retry 
> attempts.  Just one of the data provider tests needs to succeed for the test 
> to be deemed a success.
> {code}mvn test
> ...
> ---
>  T E S T S
> ---
> Running TestRandomFail
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.267 sec <<< 
> FAILURE! - in TestRandomFail
> fail(TestRandomFail)  Time elapsed: 0.007 sec  <<< FAILURE!
> java.lang.AssertionError: nope
> at TestRandomFail.fail(TestRandomFail.java:14)
> Results :
> Flaked tests: 
> TestRandomFail.fail(TestRandomFail)
>   Run 1: PASS
>   Run 2: TestRandomFail.fail:14 nope
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Flakes: 1
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2.251 s
> [INFO] Finished at: 2016-02-10T07:39:21-07:00
> [INFO] Final Memory: 9M/244M
> [INFO] 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-wagon] spyhunter99 removed a comment on pull request #67: Feature/MNG-5583 per endpoint support for PKI authentication

2020-05-18 Thread GitBox



spyhunter99 removed a comment on pull request #67:
URL: https://github.com/apache/maven-wagon/pull/67#issuecomment-630471431


   hang on,forgot i had disabled checkstyle.  sorry stand by



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1228) rerunFailingTestsCount + TestNG + @DataProvider = failed tests pass

2020-05-18 Thread Cam Morris (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110718#comment-17110718
 ] 

Cam Morris commented on SUREFIRE-1228:
--

Revisiting this 4 years later...  I think this should be reopened.  It is a 
bug.  If the testng provider doesn't support rerun, then it shouldn't say 
everything passed.  It gives a false positive when a bug in the code should 
have been found.  If rerun isn't supported than the build should fail with an 
error telling me it isn't supported.

> rerunFailingTestsCount + TestNG + @DataProvider = failed tests pass
> ---
>
> Key: SUREFIRE-1228
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1228
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: TestNG support
>Affects Versions: 2.19.1
>Reporter: Cam Morris
>Assignee: Tibor Digana
>Priority: Major
> Attachments: TestRandomFail.java, pom.xml
>
>
> Surefire confuses tests run with a data-provider with rerun tests so only one 
> of the data-provided tests need to pass.
> Steps to reproduce:
> # Create a testNG test with a data provider that passes with some of the data 
> and fails with others
> {code:title=TestNG example|language=java}
>   @Test(dataProvider = "succeed")
>   public void fail(boolean succeed) {
> if (!succeed) {
>   Assert.fail("nope");
> }
>   }
>   @DataProvider(name="succeed")
>   public Object[][] arrayIndex() {
> return new Object[][]{ {true}, {false}};
>   }
> {code}
> # Configure surefire to rerun failed tests
> {code:title=pom.xml example|language=xml}
> 
> http://maven.apache.org/POM/4.0.0;
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> cam.test
> testng-retry
> 1.0-SNAPSHOT
> 
> 
> org.testng
> testng
> 6.9.10
> test
> 
> 
> 
> 
> 
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.19.1
> 
>   1
> 
> 
> 
> 
> 
> {code}
> - *Expected results*:  "Tests run: 2, Failures: 1..."  The tests should not 
> pass.
> - *Actual results*: "Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, 
> Flakes: 1"  The rerun confuses test runs with different data for retry 
> attempts.  Just one of the data provider tests needs to succeed for the test 
> to be deemed a success.
> {code}mvn test
> ...
> ---
>  T E S T S
> ---
> Running TestRandomFail
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.267 sec <<< 
> FAILURE! - in TestRandomFail
> fail(TestRandomFail)  Time elapsed: 0.007 sec  <<< FAILURE!
> java.lang.AssertionError: nope
> at TestRandomFail.fail(TestRandomFail.java:14)
> Results :
> Flaked tests: 
> TestRandomFail.fail(TestRandomFail)
>   Run 1: PASS
>   Run 2: TestRandomFail.fail:14 nope
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Flakes: 1
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2.251 s
> [INFO] Finished at: 2016-02-10T07:39:21-07:00
> [INFO] Final Memory: 9M/244M
> [INFO] 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-wagon] spyhunter99 commented on pull request #67: Feature/MNG-5583 per endpoint support for PKI authentication

2020-05-18 Thread GitBox



spyhunter99 commented on pull request #67:
URL: https://github.com/apache/maven-wagon/pull/67#issuecomment-630471431


   hang on,forgot i had disabled checkstyle.  sorry stand by



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] spyhunter99 opened a new pull request #67: Feature/MNG-5583 per endpoint support for PKI authentication

2020-05-18 Thread GitBox



spyhunter99 opened a new pull request #67:
URL: https://github.com/apache/maven-wagon/pull/67


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-resolver] spyhunter99 opened a new pull request #51: MNG-5583 initial commit for supporting PKI authentication to nexus re…

2020-05-18 Thread GitBox



spyhunter99 opened a new pull request #51:
URL: https://github.com/apache/maven-resolver/pull/51


   …positories.  also requires changes to maven-wagon



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] jonvolfson opened a new pull request #53: Moved GetMojo logic to an abstract class. This allows new mojos to im…

2020-05-18 Thread GitBox



jonvolfson opened a new pull request #53:
URL: https://github.com/apache/maven-dependency-plugin/pull/53


   …plement functionality on top of checking if an artifact can be retrieved 
remotely.
   
   This will allow the logic in the old GetMojo to be used for [MDEP-645].
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-6049) Add behavior to filter resolved version ranges of an artifact

2020-05-18 Thread Xiang Li (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110645#comment-17110645
 ] 

Xiang Li commented on MNG-6049:
---

Hi, I wonder if it is still on the road map?

> Add behavior to filter resolved version ranges of an artifact
> -
>
> Key: MNG-6049
> URL: https://issues.apache.org/jira/browse/MNG-6049
> Project: Maven
>  Issue Type: Improvement
>  Components: core, Dependencies
>Reporter: Uwe Barthel
>Priority: Critical
> Fix For: 3.7.x-candidate
>
>
> The discussion on issue MNG-3092 shows the seriously needs of different kinds 
> of version range resolving in Maven.
> This solution provides a hook for Maven extensions/plugins to change the list 
> of resolved version range results as required.
> The {{DefaultVersionRangeResolver}} will be extended with a filter for 
> version range results. A new interface {{VersionRangeResultFilter}} is added 
> and a non-filtering {{DefaultVersionRangeResultFilter}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-release] bguerin opened a new pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles

2020-05-18 Thread GitBox



bguerin opened a new pull request #56:
URL: https://github.com/apache/maven-release/pull/56


   Fix UnsupportedOperationException when altering 
releaseDescriptor.activateProfiles



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles

2020-05-18 Thread Benoit GUERIN (Jira)



[ 
https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110640#comment-17110640
 ] 

Benoit GUERIN commented on MRELEASE-1042:
-

New PR sent to fix

> releaseProfiles get overriden by activeProfiles
> ---
>
> Key: MRELEASE-1042
> URL: https://issues.apache.org/jira/browse/MRELEASE-1042
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: perform
>Affects Versions: 3.0.0-M2
>Reporter: Arnaud Heritier
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.0-M3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I tried to release a project with 3.0.0-M2 and potentially it is another 
> problem related to MRELEASE-1038 [~rfscholte] [~olamy]
>  
> In our corporate POM we have a pluginManagement entry:
> {code:java}
> 
>   maven-release-plugin
>   2.5.3
>   
> forked-path
> false
> cloudbees-internal-release
>   
> 
> {code}
> My project extends it and has no settings related to the release plugin
> In my user settings I have
> {code:java}
>   
> cloudbees-internal-deploy
> cloudbees-snapshots
> apache-staging
>   
> {code}
> Then I release my project using 3.0.0-M2 with
> {code:java}
>  mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare 
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform
> {code}
> The perform step is taking my user profiles but not the ones from 
> "releaseProfiles"
> {noformat}
> [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout && 
> /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s 
> /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml
>  -f pom.xml deploy -P 
> cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f 
> pom.xml{noformat}
> Not sure if it could be because I call the release plugin with the full GAV 
> but it is strange ...
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles

2020-05-18 Thread Benoit GUERIN (Jira)



[ 
https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110622#comment-17110622
 ] 

Benoit GUERIN commented on MRELEASE-1042:
-

[~rfscholte] I am sorry but I disagree ... Lookin at the stack, it IS in the 
code modified by my PR, so this issue is not fixed :(

> releaseProfiles get overriden by activeProfiles
> ---
>
> Key: MRELEASE-1042
> URL: https://issues.apache.org/jira/browse/MRELEASE-1042
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: perform
>Affects Versions: 3.0.0-M2
>Reporter: Arnaud Heritier
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.0-M3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I tried to release a project with 3.0.0-M2 and potentially it is another 
> problem related to MRELEASE-1038 [~rfscholte] [~olamy]
>  
> In our corporate POM we have a pluginManagement entry:
> {code:java}
> 
>   maven-release-plugin
>   2.5.3
>   
> forked-path
> false
> cloudbees-internal-release
>   
> 
> {code}
> My project extends it and has no settings related to the release plugin
> In my user settings I have
> {code:java}
>   
> cloudbees-internal-deploy
> cloudbees-snapshots
> apache-staging
>   
> {code}
> Then I release my project using 3.0.0-M2 with
> {code:java}
>  mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare 
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform
> {code}
> The perform step is taking my user profiles but not the ones from 
> "releaseProfiles"
> {noformat}
> [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout && 
> /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s 
> /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml
>  -f pom.xml deploy -P 
> cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f 
> pom.xml{noformat}
> Not sure if it could be because I call the release plugin with the full GAV 
> but it is strange ...
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNGSITE-393) Remove references to Maven 2.x

2020-05-18 Thread Hudson (Jira)



[ 
https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110617#comment-17110617
 ] 

Hudson commented on MNGSITE-393:


Build succeeded in Jenkins: Maven TLP » maven-site » master #285

See https://builds.apache.org/job/maven-box/job/maven-site/job/master/285/

> Remove references to Maven 2.x
> --
>
> Key: MNGSITE-393
> URL: https://issues.apache.org/jira/browse/MNGSITE-393
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> Maven 3.x is over a decade old now and we're talking about Maven 4. It's time 
> to clean out all the random discussion here and there about how Maven 2.x did 
> things, differences between Maven 2 and 3, what works in Maven 3 but not 2, 
> etc. 
> Assume Maven 3.0 as the minimum, probably Maven 3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (MSHADE-367) ServicesResourceTransformer & relocation together cause issues with "reshading"

2020-05-18 Thread Chris Dennis (Jira)

Chris Dennis created MSHADE-367:
---

 Summary: ServicesResourceTransformer & relocation together cause 
issues with "reshading"
 Key: MSHADE-367
 URL: https://issues.apache.org/jira/browse/MSHADE-367
 Project: Maven Shade Plugin
  Issue Type: Bug
Affects Versions: 3.2.3
Reporter: Chris Dennis
 Attachments: maven-shade-bug.zip

The attached sample project shades {{org.terracotta:a}} in to 
{{org.terracotta:b}}. Both a and b declare an implementation of a shared 
service interface {{org.terracotta.Service}}. When you {{mvn package}} this 
project everything works as it should. If you run {{mvn package}} again without 
cleaning first plugin appears to attempt to shade on top of itself and 
complains that the service file colliides in the JAR file. This issue is 
hitting us during our build process. We have worked around it by having a task 
delete the shade output during the pre-package phase but would appreciate a 
better solution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-dependency-plugin] elharo merged pull request #52: [MNGSITE-393] don't care about old versions

2020-05-18 Thread GitBox



elharo merged pull request #52:
URL: https://github.com/apache/maven-dependency-plugin/pull/52


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SUREFIRE-1793) Change the Java packge of surefire-api to the distinct package org.apache.maven.surefire.api

2020-05-18 Thread Tibor Digana (Jira)

Tibor Digana created SUREFIRE-1793:
--

 Summary: Change the Java packge of surefire-api to the distinct 
package org.apache.maven.surefire.api
 Key: SUREFIRE-1793
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1793
 Project: Maven Surefire
  Issue Type: Improvement
  Components: Maven Failsafe Plugin, Maven Surefire Plugin
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 3.0.0-M5






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-dependency-plugin] elharo opened a new pull request #52: [MNGSITE-393] don't care about old versions

2020-05-18 Thread GitBox



elharo opened a new pull request #52:
URL: https://github.com/apache/maven-dependency-plugin/pull/52


   @khmarbaise 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles

2020-05-18 Thread Robert Scholte (Jira)



[ 
https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110524#comment-17110524
 ] 

Robert Scholte commented on MRELEASE-1042:
--

I'd suggest to create a new issue. For the reporter this issue is fixed, so you 
must hit another edge case.

> releaseProfiles get overriden by activeProfiles
> ---
>
> Key: MRELEASE-1042
> URL: https://issues.apache.org/jira/browse/MRELEASE-1042
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: perform
>Affects Versions: 3.0.0-M2
>Reporter: Arnaud Heritier
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.0-M3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I tried to release a project with 3.0.0-M2 and potentially it is another 
> problem related to MRELEASE-1038 [~rfscholte] [~olamy]
>  
> In our corporate POM we have a pluginManagement entry:
> {code:java}
> 
>   maven-release-plugin
>   2.5.3
>   
> forked-path
> false
> cloudbees-internal-release
>   
> 
> {code}
> My project extends it and has no settings related to the release plugin
> In my user settings I have
> {code:java}
>   
> cloudbees-internal-deploy
> cloudbees-snapshots
> apache-staging
>   
> {code}
> Then I release my project using 3.0.0-M2 with
> {code:java}
>  mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare 
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform
> {code}
> The perform step is taking my user profiles but not the ones from 
> "releaseProfiles"
> {noformat}
> [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout && 
> /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s 
> /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml
>  -f pom.xml deploy -P 
> cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f 
> pom.xml{noformat}
> Not sure if it could be because I call the release plugin with the full GAV 
> but it is strange ...
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNGSITE-411) on website, Maven Issue Management page, markdown is showing in plaintext

2020-05-18 Thread Hudson (Jira)



[ 
https://issues.apache.org/jira/browse/MNGSITE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110511#comment-17110511
 ] 

Hudson commented on MNGSITE-411:


Build succeeded in Jenkins: Maven TLP » maven-site » elharo-patch-6 #3

See https://builds.apache.org/job/maven-box/job/maven-site/job/elharo-patch-6/3/

> on website, Maven Issue Management page, markdown is showing in plaintext
> -
>
> Key: MNGSITE-411
> URL: https://issues.apache.org/jira/browse/MNGSITE-411
> Project: Maven Project Web Site
>  Issue Type: Bug
> Environment: website
>Reporter: Tim Stewart
>Assignee: Herve Boutemy
>Priority: Minor
>  Labels: typo, website
> Attachments: markdownbroken.png
>
>
> on page [https://maven.apache.org/issue-management.html], in the first 
> Overview section, there is markdown code showing in plain text. See attached 
> screenshot. Don't know what's causing it, but surely it should render as a 
> clickable hyperlink



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNGSITE-386) markdown not always resolved

2020-05-18 Thread Hudson (Jira)



[ 
https://issues.apache.org/jira/browse/MNGSITE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110512#comment-17110512
 ] 

Hudson commented on MNGSITE-386:


Build succeeded in Jenkins: Maven TLP » maven-site » elharo-patch-6 #3

See https://builds.apache.org/job/maven-box/job/maven-site/job/elharo-patch-6/3/

> markdown not always resolved
> 
>
> Key: MNGSITE-386
> URL: https://issues.apache.org/jira/browse/MNGSITE-386
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Herve Boutemy
>Priority: Minor
>
> On several pages including https://maven.apache.org/what-is-maven.html I 
> notice that markdown is slipping through into the site instead of being 
> rendered into HTML. I don't know why. 
> E.g. it says
> Maven, a [Yiddish word](https://en.wikipedia.org/wiki/Maven) meaning 
> *accumulator of knowledge*,
> instead of 
> Maven, a Yiddish word 
> meaning accumulator of knowledge
> This usually seems to happen only in the first paragraph. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNGSITE-393) Remove references to Maven 2.x

2020-05-18 Thread Hudson (Jira)



[ 
https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110513#comment-17110513
 ] 

Hudson commented on MNGSITE-393:


Build succeeded in Jenkins: Maven TLP » maven-site » elharo-patch-6 #3

See https://builds.apache.org/job/maven-box/job/maven-site/job/elharo-patch-6/3/

> Remove references to Maven 2.x
> --
>
> Key: MNGSITE-393
> URL: https://issues.apache.org/jira/browse/MNGSITE-393
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> Maven 3.x is over a decade old now and we're talking about Maven 4. It's time 
> to clean out all the random discussion here and there about how Maven 2.x did 
> things, differences between Maven 2 and 3, what works in Maven 3 but not 2, 
> etc. 
> Assume Maven 3.0 as the minimum, probably Maven 3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-scm] michael-o commented on a change in pull request #103: [SCM-940] remove getModule method

2020-05-18 Thread GitBox



michael-o commented on a change in pull request #103:
URL: https://github.com/apache/maven-scm/pull/103#discussion_r426810897



##
File path: maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java
##
@@ -369,7 +362,7 @@ public void assertCommandLine( String expectedCommand, File 
expectedWorkingDirec
 
 /**
  * @param cmd the executable to run, not null.
- * @return true
+ * @return true iff the command is on the path

Review comment:
   Don't expect people to know that





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-scm] elharo commented on a change in pull request #103: [SCM-940] remove getModule method

2020-05-18 Thread GitBox



elharo commented on a change in pull request #103:
URL: https://github.com/apache/maven-scm/pull/103#discussion_r426763512



##
File path: maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java
##
@@ -369,7 +362,7 @@ public void assertCommandLine( String expectedCommand, File 
expectedWorkingDirec
 
 /**
  * @param cmd the executable to run, not null.
- * @return true
+ * @return true iff the command is on the path

Review comment:
   iff is math notation for "if and only if"





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-scm] michael-o commented on a change in pull request #103: [SCM-940] remove getModule method

2020-05-18 Thread GitBox



michael-o commented on a change in pull request #103:
URL: https://github.com/apache/maven-scm/pull/103#discussion_r426722832



##
File path: maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java
##
@@ -369,7 +362,7 @@ public void assertCommandLine( String expectedCommand, File 
expectedWorkingDirec
 
 /**
  * @param cmd the executable to run, not null.
- * @return true
+ * @return true iff the command is on the path

Review comment:
   Typo





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles

2020-05-18 Thread Nikolas Falco (Jira)



[ 
https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110302#comment-17110302
 ] 

Nikolas Falco edited comment on MRELEASE-1042 at 5/18/20, 1:59 PM:
---

Hi [~rfscholte] we compile 
[master|https://github.com/apache/maven-release/tree/57d6b591cabfc1b1b417db28f723fbb9a94dc989]
 to get this fix but we got other exception during release phase.
 Our scenario, we have:
 * active profiles defined in settings.xml to use internal maven repository
 * releaseProfile to publish generated documentation defined by system property
 * integration test profile by command line

This is the exception we got
{noformat}
[INFO] Release preparation complete.
[INFO]
[INFO] --- maven-release-plugin:3.0.0-alpha3:perform (default-cli) @ 
com.acme.core ---
[DEBUG] Configuring mojo 
org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform from plugin 
realm 
ClassRealm[plugin>org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3, 
parent: sun.misc.Launcher$AppClassLoader@4e25154f]
[DEBUG] Configuring mojo 
'org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform' with basic 
configurator -->
[DEBUG]   (f) arguments = 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
 -Dskip-javadoc=false -Dskip-sources=false -Dmaven.test.failure.ignore=false -f 
pom.xml --batch-mode -t "C:/Users/User1/.m2/toolchains.xml" 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
 -Denforcer.fail=true -Denforcer.skip=false -Dmaven.test.skip=true 
-Dbnd.baseline.skip=true
[DEBUG]   (s) basedir = C:\git\fx.cmn.fna-java
[DEBUG]   (f) dryRun = false
[DEBUG]   (f) javaHome = C:\Program Files\java\jdk1.8.0_191\jre
[DEBUG]   (f) localCheckout = true
[DEBUG]   (f) mavenExecutorId = invoker
[DEBUG]   (f) mavenHome = C:\Program Files\apache-maven-3.6.0
[DEBUG]   (s) pomFileName = pom.xml
[DEBUG]   (f) project = MavenProject: com.acme:com.acme.core:0.41.4-SNAPSHOT @ 
C:\git\fx.cmn.fna-java\pom.xml
[DEBUG]   (f) reactorProjects = [MavenProject: 
com.finantix.common:com.finantix.mdl.fna.core:0.41.4-SNAPSHOT @ 
C:\git\repo\pom.xml]
[DEBUG]   (f) releaseProfiles = release
[DEBUG]   (f) releaseStrategyId = default
[DEBUG]   (f) session = org.apache.maven.execution.MavenSession@c1fca2a
[DEBUG]   (f) settings = org.apache.maven.execution.SettingsAdapter@7c447c76
[DEBUG]   (f) useReleaseProfile = false
[DEBUG]   (f) workingDirectory = C:\git\repo\target\checkout
[DEBUG] -- end configuration --
[INFO] phase verify-release-configuration
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  01:15 min
[INFO] Finished at: 2020-05-15T15:24:27+02:00
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform 
(default-cli) on project com.finantix.mdl.fna.core: Execution default-cli of 
goal org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform failed. 
UnsupportedOperationException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform 
(default-cli) on project com.finantix.mdl.fna.core: Execution default-cli of 
goal org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform failed.
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at

[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles

2020-05-18 Thread Nikolas Falco (Jira)



[ 
https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110303#comment-17110303
 ] 

Nikolas Falco commented on MRELEASE-1042:
-

[~rfscholte] Please reopen this issue

> releaseProfiles get overriden by activeProfiles
> ---
>
> Key: MRELEASE-1042
> URL: https://issues.apache.org/jira/browse/MRELEASE-1042
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: perform
>Affects Versions: 3.0.0-M2
>Reporter: Arnaud Heritier
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.0-M3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I tried to release a project with 3.0.0-M2 and potentially it is another 
> problem related to MRELEASE-1038 [~rfscholte] [~olamy]
>  
> In our corporate POM we have a pluginManagement entry:
> {code:java}
> 
>   maven-release-plugin
>   2.5.3
>   
> forked-path
> false
> cloudbees-internal-release
>   
> 
> {code}
> My project extends it and has no settings related to the release plugin
> In my user settings I have
> {code:java}
>   
> cloudbees-internal-deploy
> cloudbees-snapshots
> apache-staging
>   
> {code}
> Then I release my project using 3.0.0-M2 with
> {code:java}
>  mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare 
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform
> {code}
> The perform step is taking my user profiles but not the ones from 
> "releaseProfiles"
> {noformat}
> [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout && 
> /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s 
> /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml
>  -f pom.xml deploy -P 
> cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f 
> pom.xml{noformat}
> Not sure if it could be because I call the release plugin with the full GAV 
> but it is strange ...
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles

2020-05-18 Thread Nikolas Falco (Jira)



[ 
https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110302#comment-17110302
 ] 

Nikolas Falco commented on MRELEASE-1042:
-

Hi [~rfscholte] we compile 
[master|https://github.com/apache/maven-release/tree/57d6b591cabfc1b1b417db28f723fbb9a94dc989]
 to get this fix but we got other exception during release phase.
 Our scenario, we have:
 * active profiles defined in settings.xml to use internal maven repository
 * releaseProfile to publish generated documentation defined by system property
 * integration test profile by command line

This is the exception we got
{noformat}
[INFO] Release preparation complete.
[INFO]
[INFO] --- maven-release-plugin:3.0.0-alpha3:perform (default-cli) @ 
com.finantix.mdl.fna.core ---
[DEBUG] Configuring mojo 
org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform from plugin 
realm 
ClassRealm[plugin>org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3, 
parent: sun.misc.Launcher$AppClassLoader@4e25154f]
[DEBUG] Configuring mojo 
'org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform' with basic 
configurator -->
[DEBUG]   (f) arguments = 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
 -Dskip-javadoc=false -Dskip-sources=false -Dmaven.test.failure.ignore=false -f 
pom.xml --batch-mode -t "C:/Users/Alessandro Ballarin/.m2/toolchains.xml" 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
 -Denforcer.fail=true -Denforcer.skip=false -Dmaven.test.skip=true 
-Dbnd.baseline.skip=true
[DEBUG]   (s) basedir = C:\git\fx.cmn.fna-java
[DEBUG]   (f) dryRun = false
[DEBUG]   (f) javaHome = C:\Program Files\java\jdk1.8.0_191\jre
[DEBUG]   (f) localCheckout = true
[DEBUG]   (f) mavenExecutorId = invoker
[DEBUG]   (f) mavenHome = C:\Program Files\apache-maven-3.6.0
[DEBUG]   (s) pomFileName = pom.xml
[DEBUG]   (f) project = MavenProject: 
com.finantix.common:com.finantix.mdl.fna.core:0.41.4-SNAPSHOT @ 
C:\git\fx.cmn.fna-java\pom.xml
[DEBUG]   (f) reactorProjects = [MavenProject: 
com.finantix.common:com.finantix.mdl.fna.core:0.41.4-SNAPSHOT @ 
C:\git\fx.cmn.fna-java\pom.xml]
[DEBUG]   (f) releaseProfiles = release
[DEBUG]   (f) releaseStrategyId = default
[DEBUG]   (f) session = org.apache.maven.execution.MavenSession@c1fca2a
[DEBUG]   (f) settings = org.apache.maven.execution.SettingsAdapter@7c447c76
[DEBUG]   (f) useReleaseProfile = false
[DEBUG]   (f) workingDirectory = C:\git\fx.cmn.fna-java\target\checkout
[DEBUG] -- end configuration --
[INFO] phase verify-release-configuration
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  01:15 min
[INFO] Finished at: 2020-05-15T15:24:27+02:00
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform 
(default-cli) on project com.finantix.mdl.fna.core: Execution default-cli of 
goal org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform failed. 
UnsupportedOperationException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform 
(default-cli) on project com.finantix.mdl.fna.core: Execution default-cli of 
goal org.apache.maven.plugins:maven-release-plugin:3.0.0-alpha3:perform failed.
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)

[GitHub] [maven-scm] elharo commented on pull request #103: [SCM-940] remove getModule method

2020-05-18 Thread GitBox



elharo commented on pull request #103:
URL: https://github.com/apache/maven-scm/pull/103#issuecomment-630174668


   Ping. Jenkins passes for this one. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Pavel_K (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110158#comment-17110158
 ] 

Pavel_K commented on SUREFIRE-1570:
---

[~tibordigana] Yes, my package visibility problem is described here 
https://issues.apache.org/jira/browse/SUREFIRE-1733 . Thank you very much for 
your help and the link.

> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module javafx.media
> module java.rmi
> module java.prefs
> module jdk.security.jgss
> module javafx.fxml
> module java.smartcardio
> module jdk.xml.dom
> module java.xml.crypto
> module jdk.jsobject
> module jdk.jdi
> module jdk.compiler
> module java.management
> module jdk.management.cmm
> module jdk.packager.services
> module jdk.jartool
> module jdk.scripting.nashorn
> module java.security.jgss
> module jdk.localedata
> module java.desktop
> module jdk.zipfs
> module jdk.jshell
> module oracle.desktop
> module jdk.internal.ed
>

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Pavel_K (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110141#comment-17110141
 ] 

Pavel_K commented on SUREFIRE-1570:
---

[~tibordigana] I had two questions: 1) about package visibility 2) about Junit4 
runner. I asked these two questions one by one. 

> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module javafx.media
> module java.rmi
> module java.prefs
> module jdk.security.jgss
> module javafx.fxml
> module java.smartcardio
> module jdk.xml.dom
> module java.xml.crypto
> module jdk.jsobject
> module jdk.jdi
> module jdk.compiler
> module java.management
> module jdk.management.cmm
> module jdk.packager.services
> module jdk.jartool
> module jdk.scripting.nashorn
> module java.security.jgss
> module jdk.localedata
> module java.desktop
> module jdk.zipfs
> module jdk.jshell
> module oracle.desktop
> module jdk.internal.ed
> module java.security.sasl
> module

[jira] [Comment Edited] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Tibor Digana (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110125#comment-17110125
 ] 

Tibor Digana edited comment on SUREFIRE-1570 at 5/18/20, 10:45 AM:
---

In this 
[commit|https://github.com/apache/maven-surefire/commit/d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041#diff-4a6be0bdcb206076a5b7b8ab87b41234R45]
 you can see what you are talking about. It is the IT for such a runner.
But I really do not understand your problem. Onece you are talking about JPMS, 
then JUnit4 Runner. Notice that this issue is not about JPMS. It is about 
accessing module-info within the jar for the purposes of Failsafe plugin.
If you don't like "{{opens com.foo.impl;}}" then it is another story but i 
think we were talking about it before. Pls confirm that the issue with "{{opens 
com.foo.impl;}}" is what you expect to solve in SUREFIRE-1733 (full modularity 
main + test).


was (Author: tibor17):
In this 
[commit|https://github.com/apache/maven-surefire/commit/d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041#diff-4a6be0bdcb206076a5b7b8ab87b41234R45]
 you can see what you are talking about. It is the IT for such a runner.
But I really do not understand your problem. Onece you are talking about JPMS, 
then JUnit4 Runner. Notice that this issue is not about JPMS. It is about 
accessing module-info within the jar for the purposes of Failsafe plugin.
If you don't like this directive {{opens com.foo.impl;}} then it is another 
story but i think we were talking about it.
Pls confirm if the issue with {{opens com.foo.impl;}} is what you expect in 
SUREFIRE-1733 (full modularity main + test).

> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
>

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Tibor Digana (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110125#comment-17110125
 ] 

Tibor Digana commented on SUREFIRE-1570:


In this 
[commit|https://github.com/apache/maven-surefire/commit/d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041#diff-4a6be0bdcb206076a5b7b8ab87b41234R45]
 you can see what you are talking about. It is the IT for such a runner.
But I really do not understand your problem. Onece you are talking about JPMS, 
then JUnit4 Runner. Notice that this issue is not about JPMS. It is about 
accessing module-info within the jar for the purposes of Failsafe plugin.
If you don't like this directive {{opens com.foo.impl;}} then it is another 
story but i think we were talking about it.
Pls confirm if the issue with {{opens com.foo.impl;}} is what you expect in 
SUREFIRE-1733 (full modularity main + test).

> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Pavel_K (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110090#comment-17110090
 ] 

Pavel_K commented on SUREFIRE-1570:
---

[~tibordigana] Could you then explain what I should do if I want 

import org.junit.platform.runner.JUnitPlatform;
import org.junit.platform.suite.api.SelectPackages;
import org.junit.platform.suite.api.SuiteDisplayName;
import org.junit.runner.RunWith;

@RunWith(JUnitPlatform.class)
@SuiteDisplayName("JUnit Platform Suite Demo")
@SelectPackages("example")
public class JUnitPlatformSuiteDemo {
}

as it it explained [here 
|https://junit.org/junit5/docs/current/user-guide/#running-tests-junit-platform-runner-test-suite].
 Without that dependency I can't compile project.


> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module javafx.media
> module java.rmi
> module java.prefs
> module jdk.security.jgss
> module javafx.fxml
> module java.smartcardio
>

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Tibor Digana (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110086#comment-17110086
 ] 

Tibor Digana commented on SUREFIRE-1570:


that's intended because this dependency is JUnit4 runner

> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module javafx.media
> module java.rmi
> module java.prefs
> module jdk.security.jgss
> module javafx.fxml
> module java.smartcardio
> module jdk.xml.dom
> module java.xml.crypto
> module jdk.jsobject
> module jdk.jdi
> module jdk.compiler
> module java.management
> module jdk.management.cmm
> module jdk.packager.services
> module jdk.jartool
> module jdk.scripting.nashorn
> module java.security.jgss
> module jdk.localedata
> module java.desktop
> module jdk.zipfs
> module jdk.jshell
> module oracle.desktop
> module jdk.internal.ed
> module java.security.sasl
> module jdk.jdwp.agent
> module java.compiler
> module jdk.plugin.dom
> module

[jira] [Comment Edited] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Tibor Digana (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110078#comment-17110078
 ] 

Tibor Digana edited comment on SUREFIRE-1570 at 5/18/20, 9:33 AM:
--

[~Pavel_K]
I think you are talking about another problem. I guess you mean this issue in 
progress https://github.com/apache/maven-surefire/pull/293
but then also your project must be correct and the tests must contain 
{{src/test/java/module-info.java}}. I guess you do not have it in your project 
and even if you do then it would not work because the PR is not completed.


was (Author: tibor17):
[~Pavel_K]
I think you are talking about another problem. I guess you mean this issue in 
progress https://github.com/apache/maven-surefire/pull/293

> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module javafx.media
> module java.rmi
> module java.prefs
> module jdk.security.jgss
> module javafx.fxml

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Tibor Digana (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110078#comment-17110078
 ] 

Tibor Digana commented on SUREFIRE-1570:


[~Pavel_K]
I think you are talking about another problem. I guess you mean this issue in 
progress https://github.com/apache/maven-surefire/pull/293

> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module javafx.media
> module java.rmi
> module java.prefs
> module jdk.security.jgss
> module javafx.fxml
> module java.smartcardio
> module jdk.xml.dom
> module java.xml.crypto
> module jdk.jsobject
> module jdk.jdi
> module jdk.compiler
> module java.management
> module jdk.management.cmm
> module jdk.packager.services
> module jdk.jartool
> module jdk.scripting.nashorn
> module java.security.jgss
> module jdk.localedata
> module java.desktop
> module jdk.zipfs
> module jdk.jshell
> module oracle.desktop
> module jdk.internal.ed
> module

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Pavel_K (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110080#comment-17110080
 ] 

Pavel_K commented on SUREFIRE-1570:
---

[~tibordigana] Besides, I noted if you add to 
[https://github.com/apache/maven-surefire/blob/13ff5483f591662143f40014bb5f2e7556c9557f/surefire-its/src/test/resources/surefire-1570/com.foo.impl/pom.xml]
 the following dependency:
{code:java}

    org.junit.platform
    junit-platform-runner
    1.6.2
    test
 {code}

Then test won't be run anymore. But if I need this dependency, for example for 
running suites?


> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module javafx.media
> module java.rmi
> module java.prefs
> module jdk.security.jgss
> module javafx.fxml
> module java.smartcardio
> module jdk.xml.dom
> module java.xml.crypto
> module jdk.jsobject
> module jdk.jdi
> module jdk.compiler
> module java.management
> module jdk.management.cmm
>

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Tibor Digana (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110076#comment-17110076
 ] 

Tibor Digana commented on SUREFIRE-1570:


[~Pavel_K]
All the purpose of this fix is not JPMS modularity and visibility of packages, 
nothing but fixing the method {{getModuleDescriptor()}} to have the access to 
the {{module-info}}, see this comment:
https://issues.apache.org/jira/browse/SUREFIRE-1570?focusedCommentId=16806761=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16806761
We cannot do more and do more magic.

> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module javafx.media
> module java.rmi
> module java.prefs
> module jdk.security.jgss
> module javafx.fxml
> module java.smartcardio
> module jdk.xml.dom
> module java.xml.crypto
> module jdk.jsobject
> module jdk.jdi
> module jdk.compiler
> module java.management
> module jdk.management.cmm
> module

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-18 Thread GitBox



Tibor17 edited a comment on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-630040366


   I have got the prototype working but the real surefire forked jvm failed due 
to we have same Java packages (e.g. `org.apache.maven.surefire.booter`) in 
`surefire-api`, `forked-booter` and `commons-java5`.
   So there should be a new Jira ticket which would create a new package 
`org.apache.maven.surefire.api` in the module `surefire-api`. The package 
`org.apache.maven.surefire.api` would be distinct in whole project. The old 
packages would be renamed.
   My local implementation (not committed yet) fails on the conflict with 
packages:
   
   ```
   [ERROR] java.lang.NoClassDefFoundError: 
org/apache/maven/surefire/booter/Shutdown
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.BooterDeserializer.deserialize(BooterDeserializer.java:126)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.setupBooter(ForkedBooter.java:105)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:554)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:541)
   [ERROR] Caused by: java.lang.ClassNotFoundException: 
org.apache.maven.surefire.booter.Shutdown
   [ERROR] at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
   [ERROR] at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
   [ERROR] at 
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
   [ERROR] ... 4 more
   [ERROR] Exception in thread "main" java.lang.NoClassDefFoundError: 
org/apache/maven/surefire/booter/DumpErrorSingleton
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:560)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:541)
   [ERROR] Caused by: java.lang.ClassNotFoundException: 
org.apache.maven.surefire.booter.DumpErrorSingleton
   [ERROR] at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
   [ERROR] at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
   [ERROR] at 
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
   [ERROR] ... 2 more
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-18 Thread GitBox



Tibor17 edited a comment on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-630040366


   I have got the prototype working but the real surefire forked jvm failed due 
to we have same Java packages (e.g. org.apache.maven.surefire.booter) in 
`surefire-api`, `forked-booter` and `commons-java5`.
   So there should be a new Jira ticket which would create a new package 
`org.apache.maven.surefire.api` in the module `surefire-api`. The package 
`org.apache.maven.surefire.api` would be distinct in whole project. The old 
packages would be renamed.
   My local implementation (not committed yet) fails on the conflict with 
packages:
   
   ```
   [ERROR] java.lang.NoClassDefFoundError: 
org/apache/maven/surefire/booter/Shutdown
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.BooterDeserializer.deserialize(BooterDeserializer.java:126)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.setupBooter(ForkedBooter.java:105)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:554)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:541)
   [ERROR] Caused by: java.lang.ClassNotFoundException: 
org.apache.maven.surefire.booter.Shutdown
   [ERROR] at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
   [ERROR] at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
   [ERROR] at 
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
   [ERROR] ... 4 more
   [ERROR] Exception in thread "main" java.lang.NoClassDefFoundError: 
org/apache/maven/surefire/booter/DumpErrorSingleton
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:560)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:541)
   [ERROR] Caused by: java.lang.ClassNotFoundException: 
org.apache.maven.surefire.booter.DumpErrorSingleton
   [ERROR] at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
   [ERROR] at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
   [ERROR] at 
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
   [ERROR] ... 2 more
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-18 Thread GitBox



Tibor17 commented on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-630040366


   I have got the prototype working but the real surefire forked jvm failed due 
to we have same Java packages in `surefire-api`, `forked-booter` and 
`commons-java5`.
   So there should be a new Jira ticket which would create a new package 
`org.apache.maven.surefire.api` in the module `surefire-api`. The package 
`org.apache.maven.surefire.api` would be distinct in whole project. The old 
packages would be renamed.
   My local implementation (not committed yet) fails on the conflict with 
packages:
   
   ```
   [ERROR] java.lang.NoClassDefFoundError: 
org/apache/maven/surefire/booter/Shutdown
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.BooterDeserializer.deserialize(BooterDeserializer.java:126)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.setupBooter(ForkedBooter.java:105)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:554)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:541)
   [ERROR] Caused by: java.lang.ClassNotFoundException: 
org.apache.maven.surefire.booter.Shutdown
   [ERROR] at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
   [ERROR] at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
   [ERROR] at 
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
   [ERROR] ... 4 more
   [ERROR] Exception in thread "main" java.lang.NoClassDefFoundError: 
org/apache/maven/surefire/booter/DumpErrorSingleton
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:560)
   [ERROR] at 
org.apache.maven.surefire.booter@3.0.0-SNAPSHOT/org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:541)
   [ERROR] Caused by: java.lang.ClassNotFoundException: 
org.apache.maven.surefire.booter.DumpErrorSingleton
   [ERROR] at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
   [ERROR] at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
   [ERROR] at 
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
   [ERROR] ... 2 more
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-05-18 Thread Pavel_K (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109986#comment-17109986
 ] 

Pavel_K commented on SUREFIRE-1570:
---

[~tibordigana]Thank you very much for solving this issue and your answer. Now I 
am testing how it works and have the following queston - if you comment this 
line 
[https://github.com/apache/maven-surefire/blob/13ff5483f591662143f40014bb5f2e7556c9557f/surefire-its/src/test/resources/surefire-1570/com.foo.impl/src/main/java/module-info.java#L24]
 , you will get:
{code:java}
java.lang.reflect.InaccessibleObjectException: Unable to make void 
com.foo.impl.BarTest.shouldPrintModulePath() accessible: module com.foo.impl 
does not "opens com.foo.impl" to unnamed module @68567e20{code}
So, if we want to run it tests we must open the package where it is located. 
And as the module has no name we need to open package to all modules? As a 
workaround it is possible to place it tests in separate packages and open them, 
but it is not good. Or I don't understand something?

 

> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the 
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ 
> mavenproject20 ---
> [WARNING] 
> 
> [WARNING] * Required filename-based automodules detected. Please don't 
> publish this project to a public artifact repository! *
> [WARNING] 
> 
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to 
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING] 
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
>  module name component Mavenproject20 should avoid terminal digits
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ 
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to 
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20 
> ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar: 
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests) 
> @ mavenproject20 ---
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
>

[jira] [Commented] (MDEPLOY-267) add parameters to deploy or not non snapshots or release (-DskipRelease or -DskipSnapshot)

2020-05-18 Thread Hudson (Jira)



[ 
https://issues.apache.org/jira/browse/MDEPLOY-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109929#comment-17109929
 ] 

Hudson commented on MDEPLOY-267:


Build succeeded in Jenkins: Maven TLP » maven-deploy-plugin » master #48

See 
https://builds.apache.org/job/maven-box/job/maven-deploy-plugin/job/master/48/

> add parameters to deploy or not non snapshots or release (-DskipRelease or 
> -DskipSnapshot)
> --
>
> Key: MDEPLOY-267
> URL: https://issues.apache.org/jira/browse/MDEPLOY-267
> Project: Maven Deploy Plugin
>  Issue Type: New Feature
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.0.0
>
>
> maven-release-plugin creates a commit where the pom is not a SNAPSHOT 
> version:  if CI system is configured to build on every commit and to deploy 
> the artifacts on every build (with the intent in general to deploy updated 
> SNAPSHOTs on every commit), the CI will deploy the non-SNAPSHOT that has 
> already been deployed by the user who launched {{mvn release:perform}}, then 
> it will generate an error (trying to override existing release artifact) 
> and/or create new staging repository and/or override artifacts partially (if 
> repository not configured to block overrides)
> we can add a new parameter {{-DdeployOnlySnaphots=true/false}}: it will be 
> false per default for normal use, but can be configured to true in users' CI 
> system.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (MDEPLOY-267) add parameters to deploy or not non snapshots or release (-DskipRelease or -DskipSnapshot)

2020-05-18 Thread Olivier Lamy (Jira)



 [ 
https://issues.apache.org/jira/browse/MDEPLOY-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy closed MDEPLOY-267.

Resolution: Fixed

pr merged

> add parameters to deploy or not non snapshots or release (-DskipRelease or 
> -DskipSnapshot)
> --
>
> Key: MDEPLOY-267
> URL: https://issues.apache.org/jira/browse/MDEPLOY-267
> Project: Maven Deploy Plugin
>  Issue Type: New Feature
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.0.0
>
>
> maven-release-plugin creates a commit where the pom is not a SNAPSHOT 
> version:  if CI system is configured to build on every commit and to deploy 
> the artifacts on every build (with the intent in general to deploy updated 
> SNAPSHOTs on every commit), the CI will deploy the non-SNAPSHOT that has 
> already been deployed by the user who launched {{mvn release:perform}}, then 
> it will generate an error (trying to override existing release artifact) 
> and/or create new staging repository and/or override artifacts partially (if 
> repository not configured to block overrides)
> we can add a new parameter {{-DdeployOnlySnaphots=true/false}}: it will be 
> false per default for normal use, but can be configured to true in users' CI 
> system.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-deploy-plugin] olamy merged pull request #10: [MDEPLOY-267] add parameters to deploy or not non snapshots or release (-DskipRelease or -DskipSnapshot)

2020-05-18 Thread GitBox



olamy merged pull request #10:
URL: https://github.com/apache/maven-deploy-plugin/pull/10


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

50 matches

Mail list logo