[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request #22: Bump maven-site-plugin from 3.9.0 to 3.9.1
dependabot[bot] opened a new pull request #22: URL: https://github.com/apache/maven-apache-parent/pull/22 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.9.0 to 3.9.1. Commits https://github.com/apache/maven-site-plugin/commit/854e6a0c4b660f48e313c0a6b2391ded14704aab";>854e6a0 [maven-release-plugin] prepare release maven-site-plugin-3.9.1 https://github.com/apache/maven-site-plugin/commit/ec954c8d280dd996e05b773b09c8249dd3a5ec75";>ec954c8 [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.rel... https://github.com/apache/maven-site-plugin/commit/d4160ab5b1cbeafd465b3eccc5f9f622e1f31e83";>d4160ab fix javadoc issues with JDK 8 https://github.com/apache/maven-site-plugin/commit/963cbcb734959227349a8b274479c0f7c268ed4c";>963cbcb remove unused plugins https://github.com/apache/maven-site-plugin/commit/da109170788cccf3efdccb5a12a14b85a3d7c5f2";>da10917 remove enforce bytecode now inherited from maven-parent https://github.com/apache/maven-site-plugin/commit/e03332897bef17d144aef48abf15efe78f126a9a";>e033328 [MSITE-757] remove shading not used any more https://github.com/apache/maven-site-plugin/commit/5179a4d5b708f5ab5546edfb0fb2d6313b018ba4";>5179a4d [MSITE-863] fix Maven < 3.6.1 compatibility issue https://github.com/apache/maven-site-plugin/commit/028119f2bbb2b00031070a3e1eaedf594ba8cae7";>028119f Github Actions https://github.com/apache/maven-site-plugin/commit/77c7cff6e5dbf1ed848383a933187a5f578b9435";>77c7cff [MSITE-863] upgrade m-reporting-exec to show that MSHARED-921 is fixed https://github.com/apache/maven-site-plugin/commit/36b11f4455076840df0af3dc51d825358f899198";>36b11f4 [MSITE-863] revert ae9c132, not caused by Java 7 but Maven 3.6.0- Additional commits viewable in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.9.0...maven-site-plugin-3.9.1";>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6947) StringSearchModelInterpolatorTest fails to interpolate ${project.basedir} across Java versions
[
https://issues.apache.org/jira/browse/MNG-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1710#comment-1710
]
Robert Scholte commented on MNG-6947:
-
It has been a while, but IIRC ideally something like this needs to be changed:
[https://github.com/frohoff/jdk8u-jdk/blob/master/src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java#L53]
You must be able to set to root of the filesystem, From that moment on we can
use Path (not File) to get the correct full path.
> StringSearchModelInterpolatorTest fails to interpolate ${project.basedir}
> across Java versions
> --
>
> Key: MNG-6947
> URL: https://issues.apache.org/jira/browse/MNG-6947
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> This has been discovered while using {{MAVENCODEBASE}} with relative paths
> and symlinks.
> This is a very subtile bug and I yet don't understand. Here is how to
> reproduce:
> Have Maven cloned repo on a symlinked dir:
> {noformat}
> osipovmi@deblndw011x:~/var/Projekte/maven (master *=)
> $ pwd -P
> /var/osipovmi/Projekte/maven
> {noformat}
> and invoke Maven with {{-f}} and a non-normalized path:
> {noformat}
> mvn -f $PWD/../maven -V -pl maven-model-builder test
> {noformat}
> With Java 8 all tests pass, with Java 11+ the mentioned test fails:
> {noformat}
> [ERROR] Tests run: 34, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.086 s <<< FAILURE! - in
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
> [ERROR]
> testInterpolateObjectWithPomFile(org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest)
> Time elapsed: 0.012 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: is (is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/target" or is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target")
> but: was "/var/osipovmi/Projekte/maven/maven-model-builder/./target"
> at
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest.testInterpolateObjectWithPomFile(StringSearchModelInterpolatorTest.java:366)
> {noformat}
> I have applied the following patch:
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBuildingRequest( p );
> SimpleProblemCollector collector = new SimpleProblemCollector();
> assertProblemFree( collector );
> -
> +System.out.println( baseDir.getAbsolutePath() );
> +System.out.println( System.getProperty( "user.dir" ) );
> +System.out.println( obj.values.get( "key" ) );
> assertThat( baseDir.getAbsolutePath(), is( System.getProperty(
> "user.dir" ) ) );
> assertThat( obj.values.size(), is( 1 ) );
> assertThat( (String) obj.values.get( "key" ), is( anyOf(
> {noformat}
> and receive:
> {noformat}
> Java 8:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target
> Java 11:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> Java 14:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> {noformat}
> When I apply
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBu
[jira] [Updated] (MWRAPPER-4) Error "}" was unexpected at this time (Windows 10)
[
https://issues.apache.org/jira/browse/MWRAPPER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentin Despa updated MWRAPPER-4:
--
Description:
I have generated a simple project using the Spring Initializr. If I try to run
the Maven wrapper from a workspace folder within Jenkins, the following error
occurs:
{{"}" was unexpected at this time}}
If I copy the project folder and run it from a different location, it works
with no issues.
A similar issue has been reported on Stackoverflow as well:
[https://stackoverflow.com/q/62028432/766177]
was:
I have generate a simple project using the Spring Initializr. If I try to run
the Maven wrapper from a workspace folder within Jenkins (), the following
error occurs:
{{"}" was unexpected at this time}}
If I copy the project folder and run it from a different location, it works
with no issues.
A similar issue has been reported on Stackoverflow as well:
[https://stackoverflow.com/q/62028432/766177|https://stackoverflow.com/q/62028432/766177]
> Error "}" was unexpected at this time (Windows 10)
> --
>
> Key: MWRAPPER-4
> URL: https://issues.apache.org/jira/browse/MWRAPPER-4
> Project: Maven Wrapper
> Issue Type: Bug
>Reporter: Valentin Despa
>Priority: Major
> Attachments: demo.zip, not-working.png, working.png
>
>
> I have generated a simple project using the Spring Initializr. If I try to
> run the Maven wrapper from a workspace folder within Jenkins, the following
> error occurs:
> {{"}" was unexpected at this time}}
> If I copy the project folder and run it from a different location, it works
> with no issues.
> A similar issue has been reported on Stackoverflow as well:
> [https://stackoverflow.com/q/62028432/766177]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MWRAPPER-4) Error "}" was unexpected at this time (Windows 10)
[
https://issues.apache.org/jira/browse/MWRAPPER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentin Despa updated MWRAPPER-4:
--
Attachment: demo.zip
> Error "}" was unexpected at this time (Windows 10)
> --
>
> Key: MWRAPPER-4
> URL: https://issues.apache.org/jira/browse/MWRAPPER-4
> Project: Maven Wrapper
> Issue Type: Bug
>Reporter: Valentin Despa
>Priority: Major
> Attachments: demo.zip, not-working.png, working.png
>
>
> I have generate a simple project using the Spring Initializr. If I try to run
> the Maven wrapper from a workspace folder within Jenkins (), the following
> error occurs:
> {{"}" was unexpected at this time}}
> If I copy the project folder and run it from a different location, it works
> with no issues.
> A similar issue has been reported on Stackoverflow as well:
> [https://stackoverflow.com/q/62028432/766177|https://stackoverflow.com/q/62028432/766177]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MWRAPPER-4) Error "}" was unexpected at this time (Windows 10)
[
https://issues.apache.org/jira/browse/MWRAPPER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentin Despa updated MWRAPPER-4:
--
Description:
I have generate a simple project using the Spring Initializr. If I try to run
the Maven wrapper from a workspace folder within Jenkins (), the following
error occurs:
{{"}" was unexpected at this time}}
If I copy the project folder and run it from a different location, it works
with no issues.
A similar issue has been reported on Stackoverflow as well:
[https://stackoverflow.com/q/62028432/766177|https://stackoverflow.com/q/62028432/766177]
was:
I have generate a simple project using the Spring Initializr. If I try to run
the Maven wrapper from a workspace folder within Jenkins (), the following
error occurs:
{{"}" was unexpected at this time}}
If I copy the project folder and run it from a different location, it works
with no issues.
> Error "}" was unexpected at this time (Windows 10)
> --
>
> Key: MWRAPPER-4
> URL: https://issues.apache.org/jira/browse/MWRAPPER-4
> Project: Maven Wrapper
> Issue Type: Bug
>Reporter: Valentin Despa
>Priority: Major
> Attachments: demo.zip, not-working.png, working.png
>
>
> I have generate a simple project using the Spring Initializr. If I try to run
> the Maven wrapper from a workspace folder within Jenkins (), the following
> error occurs:
> {{"}" was unexpected at this time}}
> If I copy the project folder and run it from a different location, it works
> with no issues.
> A similar issue has been reported on Stackoverflow as well:
> [https://stackoverflow.com/q/62028432/766177|https://stackoverflow.com/q/62028432/766177]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MWRAPPER-4) Error "}" was unexpected at this time (Windows 10)
[
https://issues.apache.org/jira/browse/MWRAPPER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentin Despa updated MWRAPPER-4:
--
Attachment: working.png
not-working.png
> Error "}" was unexpected at this time (Windows 10)
> --
>
> Key: MWRAPPER-4
> URL: https://issues.apache.org/jira/browse/MWRAPPER-4
> Project: Maven Wrapper
> Issue Type: Bug
>Reporter: Valentin Despa
>Priority: Major
> Attachments: not-working.png, working.png
>
>
> I have generate a simple project using the Spring Initializr. If I try to run
> the Maven wrapper from a workspace folder within Jenkins (), the following
> error occurs:
> {{"}" was unexpected at this time}}
> If I copy the project folder and run it from a different location, it works
> with no issues.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6947) StringSearchModelInterpolatorTest fails to interpolate ${project.basedir} across Java versions
[
https://issues.apache.org/jira/browse/MNG-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144426#comment-17144426
]
Michael Osipov commented on MNG-6947:
-
Can you explain brief what needs to be done to the JDK to have this fixed w/o
us writing (much) client code?
> StringSearchModelInterpolatorTest fails to interpolate ${project.basedir}
> across Java versions
> --
>
> Key: MNG-6947
> URL: https://issues.apache.org/jira/browse/MNG-6947
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> This has been discovered while using {{MAVENCODEBASE}} with relative paths
> and symlinks.
> This is a very subtile bug and I yet don't understand. Here is how to
> reproduce:
> Have Maven cloned repo on a symlinked dir:
> {noformat}
> osipovmi@deblndw011x:~/var/Projekte/maven (master *=)
> $ pwd -P
> /var/osipovmi/Projekte/maven
> {noformat}
> and invoke Maven with {{-f}} and a non-normalized path:
> {noformat}
> mvn -f $PWD/../maven -V -pl maven-model-builder test
> {noformat}
> With Java 8 all tests pass, with Java 11+ the mentioned test fails:
> {noformat}
> [ERROR] Tests run: 34, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.086 s <<< FAILURE! - in
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
> [ERROR]
> testInterpolateObjectWithPomFile(org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest)
> Time elapsed: 0.012 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: is (is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/target" or is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target")
> but: was "/var/osipovmi/Projekte/maven/maven-model-builder/./target"
> at
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest.testInterpolateObjectWithPomFile(StringSearchModelInterpolatorTest.java:366)
> {noformat}
> I have applied the following patch:
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBuildingRequest( p );
> SimpleProblemCollector collector = new SimpleProblemCollector();
> assertProblemFree( collector );
> -
> +System.out.println( baseDir.getAbsolutePath() );
> +System.out.println( System.getProperty( "user.dir" ) );
> +System.out.println( obj.values.get( "key" ) );
> assertThat( baseDir.getAbsolutePath(), is( System.getProperty(
> "user.dir" ) ) );
> assertThat( obj.values.size(), is( 1 ) );
> assertThat( (String) obj.values.get( "key" ), is( anyOf(
> {noformat}
> and receive:
> {noformat}
> Java 8:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target
> Java 11:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> Java 14:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> {noformat}
> When I apply
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBuildingRequest( p );
> SimpleProblemCollector collector = new SimpleProblemCollector();
> -interpolator.interpolateObject( obj, model, new File( "." ), config,
> collector );
> +interpolator.i
[jira] [Commented] (MNG-6947) StringSearchModelInterpolatorTest fails to interpolate ${project.basedir} across Java versions
[
https://issues.apache.org/jira/browse/MNG-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144416#comment-17144416
]
Robert Scholte commented on MNG-6947:
-
I'm actually kind of surprised we haven't seen so much issues.
Some reason I can think of:
* Not enough projects moved to Java 11
* Most resources are picked up from the classpath, not from the file system
(which is often a good thing!).
I need a lot of "sponsors" to extend the FileSystem. A lot of broken builds
would have helped.
Rampdown has started for Java 15, and such improvement should land in Java 16
or 17 because most still wait for LTS releases, so do your calculations...
> StringSearchModelInterpolatorTest fails to interpolate ${project.basedir}
> across Java versions
> --
>
> Key: MNG-6947
> URL: https://issues.apache.org/jira/browse/MNG-6947
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> This has been discovered while using {{MAVENCODEBASE}} with relative paths
> and symlinks.
> This is a very subtile bug and I yet don't understand. Here is how to
> reproduce:
> Have Maven cloned repo on a symlinked dir:
> {noformat}
> osipovmi@deblndw011x:~/var/Projekte/maven (master *=)
> $ pwd -P
> /var/osipovmi/Projekte/maven
> {noformat}
> and invoke Maven with {{-f}} and a non-normalized path:
> {noformat}
> mvn -f $PWD/../maven -V -pl maven-model-builder test
> {noformat}
> With Java 8 all tests pass, with Java 11+ the mentioned test fails:
> {noformat}
> [ERROR] Tests run: 34, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.086 s <<< FAILURE! - in
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
> [ERROR]
> testInterpolateObjectWithPomFile(org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest)
> Time elapsed: 0.012 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: is (is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/target" or is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target")
> but: was "/var/osipovmi/Projekte/maven/maven-model-builder/./target"
> at
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest.testInterpolateObjectWithPomFile(StringSearchModelInterpolatorTest.java:366)
> {noformat}
> I have applied the following patch:
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBuildingRequest( p );
> SimpleProblemCollector collector = new SimpleProblemCollector();
> assertProblemFree( collector );
> -
> +System.out.println( baseDir.getAbsolutePath() );
> +System.out.println( System.getProperty( "user.dir" ) );
> +System.out.println( obj.values.get( "key" ) );
> assertThat( baseDir.getAbsolutePath(), is( System.getProperty(
> "user.dir" ) ) );
> assertThat( obj.values.size(), is( 1 ) );
> assertThat( (String) obj.values.get( "key" ), is( anyOf(
> {noformat}
> and receive:
> {noformat}
> Java 8:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target
> Java 11:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> Java 14:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> {noformat}
> When I apply
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/inte
[jira] [Created] (MWRAPPER-4) Error "}" was unexpected at this time (Windows 10)
Valentin Despa created MWRAPPER-4:
-
Summary: Error "}" was unexpected at this time (Windows 10)
Key: MWRAPPER-4
URL: https://issues.apache.org/jira/browse/MWRAPPER-4
Project: Maven Wrapper
Issue Type: Bug
Reporter: Valentin Despa
I have generate a simple project using the Spring Initializr. If I try to run
the Maven wrapper from a workspace folder within Jenkins (), the following
error occurs:
{{"}" was unexpected at this time}}
If I copy the project folder and run it from a different location, it works
with no issues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6947) StringSearchModelInterpolatorTest fails to interpolate ${project.basedir} across Java versions
[
https://issues.apache.org/jira/browse/MNG-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144396#comment-17144396
]
Michael Osipov commented on MNG-6947:
-
Depressing! Sounds like a lot of work :-( I guess there is no short term fix
for that? I will have a look at your basefir fs.
> StringSearchModelInterpolatorTest fails to interpolate ${project.basedir}
> across Java versions
> --
>
> Key: MNG-6947
> URL: https://issues.apache.org/jira/browse/MNG-6947
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> This has been discovered while using {{MAVENCODEBASE}} with relative paths
> and symlinks.
> This is a very subtile bug and I yet don't understand. Here is how to
> reproduce:
> Have Maven cloned repo on a symlinked dir:
> {noformat}
> osipovmi@deblndw011x:~/var/Projekte/maven (master *=)
> $ pwd -P
> /var/osipovmi/Projekte/maven
> {noformat}
> and invoke Maven with {{-f}} and a non-normalized path:
> {noformat}
> mvn -f $PWD/../maven -V -pl maven-model-builder test
> {noformat}
> With Java 8 all tests pass, with Java 11+ the mentioned test fails:
> {noformat}
> [ERROR] Tests run: 34, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.086 s <<< FAILURE! - in
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
> [ERROR]
> testInterpolateObjectWithPomFile(org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest)
> Time elapsed: 0.012 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: is (is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/target" or is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target")
> but: was "/var/osipovmi/Projekte/maven/maven-model-builder/./target"
> at
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest.testInterpolateObjectWithPomFile(StringSearchModelInterpolatorTest.java:366)
> {noformat}
> I have applied the following patch:
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBuildingRequest( p );
> SimpleProblemCollector collector = new SimpleProblemCollector();
> assertProblemFree( collector );
> -
> +System.out.println( baseDir.getAbsolutePath() );
> +System.out.println( System.getProperty( "user.dir" ) );
> +System.out.println( obj.values.get( "key" ) );
> assertThat( baseDir.getAbsolutePath(), is( System.getProperty(
> "user.dir" ) ) );
> assertThat( obj.values.size(), is( 1 ) );
> assertThat( (String) obj.values.get( "key" ), is( anyOf(
> {noformat}
> and receive:
> {noformat}
> Java 8:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target
> Java 11:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> Java 14:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> {noformat}
> When I apply
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBuildingRequest( p );
> SimpleProblemCollector collector = new SimpleProblemCollector();
> -interpolator.interpolateObject( obj, model, new File( "." ), config,
> collector );
> +
[GitHub] [maven] kwin commented on a change in pull request #345: MNG-5583 new feature PKI authentication to nexus repositories
kwin commented on a change in pull request #345:
URL: https://github.com/apache/maven/pull/345#discussion_r445169403
##
File path:
maven-artifact/src/main/java/org/apache/maven/artifact/repository/Authentication.java
##
@@ -125,5 +126,301 @@ public void setPrivateKey( final String privateKey )
{
this.privateKey = privateKey;
}
+
+
+ /**
+ *
+ *
+ * The path to the trust store. If not defined, the JRE's cacert store is
+ * used.
+ *
+ *
+ */
+private String trustStore;
+
+/**
+ *
+ *
+ * The password to the trust store.
+ *
+ *
+ */
+private String trustStorePassword;
+
+/**
+ *
+ *
+ * The type of trust store, default is JKS
Review comment:
Since Java 9 it is no longer JKS by default:
http://openjdk.java.net/jeps/229
##
File path: maven-settings/src/main/mdo/settings.mdo
##
@@ -580,6 +580,92 @@
]]>
+
+
+
+ trustStore
+ 1.0.0+
+
+
+
+ String
+
+
+ trustStorePassword
+ 1.0.0+
+
+
+
+ String
+
+
+ trustStoreType
+ 1.0.0+
+
+
+
+
+
+ trustStore
+ 1.0.0+
+
+
+
+ String
+
+
+ trustStorePassword
+ 1.0.0+
+
+
+
+ String
+
+
+ trustStoreType
+ 1.0.0+
+
+
+
+ String
+
+
+ keyStore
+ 1.0.0+
+
+
+
+ String
+
+
+
+ keyStorePassword
+ 1.0.0+
+
+
+
+ String
+
+
+ keyAlias
+ 1.0.0+
+
+
+
+ String
+
+
+ keyPassword
+ 1.0.0+
+
+
+
+ String
+
+
+ keyStoreType
+ 1.0.0+
+
+
[jira] [Commented] (MRELEASE-1048) Unrecognized option: --no-transfer-progress
[
https://issues.apache.org/jira/browse/MRELEASE-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144260#comment-17144260
]
Robert Scholte commented on MRELEASE-1048:
--
How about settings [mavenExecutorId
|maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#mavenExecutorId]
to {{"forked-path"}}, so you switch to the implementation of
https://github.com/apache/maven-release/blob/master/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java
?
This will fork Maven and won't validate the arguments.
> Unrecognized option: --no-transfer-progress
> ---
>
> Key: MRELEASE-1048
> URL: https://issues.apache.org/jira/browse/MRELEASE-1048
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 2.5.3
>Reporter: Olivier Vernin
>Priority: Major
>
> ```
> usr/share/maven/bin/mvn B -s settings-release.xml
> -Darguments='-no-transfer-progress' release:prepare
>
> Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on
> project remoting: Failed to re-parse additional arguments for Maven
> invocation. Unrecognized option: --no-transfer-progress -> [Help 1]
> ```
>
> maven version
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Oracle Corporation, runtime:
> /usr/local/openjdk-8/jre
> Default locale: en, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-1082-azure", arch: "amd64", family: "unix"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6947) StringSearchModelInterpolatorTest fails to interpolate ${project.basedir} across Java versions
[
https://issues.apache.org/jira/browse/MNG-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144252#comment-17144252
]
Robert Scholte commented on MNG-6947:
-
Reminds me of the conversation I had with [~hboutemy] and [~khmarbaise] during
FOSDEM with 2 lead OpenJDK developers. This was about the change that was done
regarding the user.dir. It will be immutable once the runtime has started. This
implies that the trick done by surefire to adjust this value won't work
anymore. I think it is https://bugs.openjdk.java.net/browse/JDK-8194154
They gave several solutions: start up a new runtime. Reasoning: startup time
has improved a lot. However our argument was that it might result in a huge
number of runtimes.
They gave me a hint how to solve this with the FileSystem. I gave it a try, see
https://github.com/apache/maven-studies/tree/maven-basedir-filesystem.
This works, but once you're in the wrapper class, you've lost your context.
Ideal solution is to make it possible to set the root of the FileSystem.
> StringSearchModelInterpolatorTest fails to interpolate ${project.basedir}
> across Java versions
> --
>
> Key: MNG-6947
> URL: https://issues.apache.org/jira/browse/MNG-6947
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> This has been discovered while using {{MAVENCODEBASE}} with relative paths
> and symlinks.
> This is a very subtile bug and I yet don't understand. Here is how to
> reproduce:
> Have Maven cloned repo on a symlinked dir:
> {noformat}
> osipovmi@deblndw011x:~/var/Projekte/maven (master *=)
> $ pwd -P
> /var/osipovmi/Projekte/maven
> {noformat}
> and invoke Maven with {{-f}} and a non-normalized path:
> {noformat}
> mvn -f $PWD/../maven -V -pl maven-model-builder test
> {noformat}
> With Java 8 all tests pass, with Java 11+ the mentioned test fails:
> {noformat}
> [ERROR] Tests run: 34, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.086 s <<< FAILURE! - in
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
> [ERROR]
> testInterpolateObjectWithPomFile(org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest)
> Time elapsed: 0.012 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: is (is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/target" or is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target")
> but: was "/var/osipovmi/Projekte/maven/maven-model-builder/./target"
> at
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest.testInterpolateObjectWithPomFile(StringSearchModelInterpolatorTest.java:366)
> {noformat}
> I have applied the following patch:
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBuildingRequest( p );
> SimpleProblemCollector collector = new SimpleProblemCollector();
> assertProblemFree( collector );
> -
> +System.out.println( baseDir.getAbsolutePath() );
> +System.out.println( System.getProperty( "user.dir" ) );
> +System.out.println( obj.values.get( "key" ) );
> assertThat( baseDir.getAbsolutePath(), is( System.getProperty(
> "user.dir" ) ) );
> assertThat( obj.values.size(), is( 1 ) );
> assertThat( (String) obj.values.get( "key" ), is( anyOf(
> {noformat}
> and receive:
> {noformat}
> Java 8:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target
> Java 11:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> Java 14:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> {noformat}
> When I apply
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInter
[GitHub] [maven] dehasi commented on pull request #347: [MNG-6802] Fix bug in FileProfileActivator
dehasi commented on pull request #347: URL: https://github.com/apache/maven/pull/347#issuecomment-649020277 @rfscholte I resolved conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-5760) Add `-r/--resume` to automatically resume from the last failure point
[
https://issues.apache.org/jira/browse/MNG-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144102#comment-17144102
]
Guy Brand commented on MNG-5760:
[~mthmulders] Great to hear! Thanks a lot!
> Add `-r/--resume` to automatically resume from the last failure point
> -
>
> Key: MNG-5760
> URL: https://issues.apache.org/jira/browse/MNG-5760
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.2.5
>Reporter: Phillip Webb
>Assignee: Robert Scholte
>Priority: Trivial
> Fix For: 3.7.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently when a multi-module build fails the {{mvn}} command line prints the
> following error:
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :some-module-name
> {noformat}
> Since I almost always want to use this flag with the next build it would be
> very useful if you could type {{mvn -rf}} and have the project name
> inferred from the last failure rather than needing to copy/paste from the
> terminal.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-5760) Add `-r/--resume` to automatically resume from the last failure point
[
https://issues.apache.org/jira/browse/MNG-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144101#comment-17144101
]
Maarten Mulders commented on MNG-5760:
--
Good catch, [~Brand], thanks for bringing it up.
I have some other improvements for this feature as well, and I'll include the
fix for this scenario. I'll also update the integration test to make sure it
doesn't happen again.
> Add `-r/--resume` to automatically resume from the last failure point
> -
>
> Key: MNG-5760
> URL: https://issues.apache.org/jira/browse/MNG-5760
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.2.5
>Reporter: Phillip Webb
>Assignee: Robert Scholte
>Priority: Trivial
> Fix For: 3.7.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently when a multi-module build fails the {{mvn}} command line prints the
> following error:
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :some-module-name
> {noformat}
> Since I almost always want to use this flag with the next build it would be
> very useful if you could type {{mvn -rf}} and have the project name
> inferred from the last failure rather than needing to copy/paste from the
> terminal.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SUREFIRE-1808) OutOfMemoryError running with TestNG
[
https://issues.apache.org/jira/browse/SUREFIRE-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143896#comment-17143896
]
Tibor Digana edited comment on SUREFIRE-1808 at 6/24/20, 2:58 PM:
--
In case of OOME you must not rely on stack trace that the particular line has
reached the OOM.
The JVM is used to throw it several times and finaly it is thrown from anywhere
asnd the process exits abnormally. The root cause does not have to be related
to the line in stack trace.
You are using very old version. Plse switch the version to {{3.0.0-M5}} and let
us know what you have observed.
was (Author: tibor17):
In case of OOME you must not rely on stack trace that the particular line has
OOM.
The JVM is used to throw it several times and finaly the it thrown from
anywhere.
It does not have to be related to the line.
You are using very old version. Plse switch the version to {{3.0.0-M5}} and let
us know what you have observed.
> OutOfMemoryError running with TestNG
>
>
> Key: SUREFIRE-1808
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1808
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin, TestNG support
>Affects Versions: 3.0.0-M3
> Environment: OS: Linux
>Reporter: Jingfei Hu
>Priority: Major
> Labels: OOM, TestNG, surefire
> Attachments: image-2020-06-24-14-37-45-038.png
>
>
> Hi team,
> We've been suffering OutOfMemory intermittently in our test labs recently.
> The call stack is below
>
> [ERROR] Java heap space -> [Help 1][ERROR] Java heap space -> [Help
> 1]java.lang.OutOfMemoryError: Java heap space at
> java.util.Arrays.copyOf(Arrays.java:3332) at
> java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)
> at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448) at
> java.lang.StringBuilder.append(StringBuilder.java:136) at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$CloseableCloser.run(ForkStarter.java:204)
> at
> org.apache.maven.surefire.shade.common.org.apache.maven.shared.utils.cli.CommandLineUtils$1.call(CommandLineUtils.java:301)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:615)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:283)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:246)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1161)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1002)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:848)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309) at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194) at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107) at
> org.apache.maven.cli.MavenCli.execute(MavenCli.java:993) at
> org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345) at
> org.apache.maven.cli.MavenCli.main(MavenCli.java:191) at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)[ERROR]
> [ERROR] [ERROR] For more information about the errors and possible
> solutions, please read the following articles:[ERROR] [Help 1]
> [http://cwiki.apache.org/confluence/display/MAVEN/OutOfMemoryError]
>
> Our test count is +4k, and pass rate is around 95% for each execution. The
> OOM error is not al
[jira] [Commented] (SUREFIRE-1808) OutOfMemoryError running with TestNG
[
https://issues.apache.org/jira/browse/SUREFIRE-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143896#comment-17143896
]
Tibor Digana commented on SUREFIRE-1808:
In case of OOME you must not rely on stack trace that the particular line has
OOM.
The JVM is used to throw it several times and finaly the it thrown from
anywhere.
It does not have to be related to the line.
You are using very old version. Plse switch the version to {{3.0.0-M5}} and let
us know what you have observed.
> OutOfMemoryError running with TestNG
>
>
> Key: SUREFIRE-1808
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1808
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin, TestNG support
>Affects Versions: 3.0.0-M3
> Environment: OS: Linux
>Reporter: Jingfei Hu
>Priority: Major
> Labels: OOM, TestNG, surefire
> Attachments: image-2020-06-24-14-37-45-038.png
>
>
> Hi team,
> We've been suffering OutOfMemory intermittently in our test labs recently.
> The call stack is below
>
> [ERROR] Java heap space -> [Help 1][ERROR] Java heap space -> [Help
> 1]java.lang.OutOfMemoryError: Java heap space at
> java.util.Arrays.copyOf(Arrays.java:3332) at
> java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)
> at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448) at
> java.lang.StringBuilder.append(StringBuilder.java:136) at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$CloseableCloser.run(ForkStarter.java:204)
> at
> org.apache.maven.surefire.shade.common.org.apache.maven.shared.utils.cli.CommandLineUtils$1.call(CommandLineUtils.java:301)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:615)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:283)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:246)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1161)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1002)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:848)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309) at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194) at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107) at
> org.apache.maven.cli.MavenCli.execute(MavenCli.java:993) at
> org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345) at
> org.apache.maven.cli.MavenCli.main(MavenCli.java:191) at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)[ERROR]
> [ERROR] [ERROR] For more information about the errors and possible
> solutions, please read the following articles:[ERROR] [Help 1]
> [http://cwiki.apache.org/confluence/display/MAVEN/OutOfMemoryError]
>
> Our test count is +4k, and pass rate is around 95% for each execution. The
> OOM error is not always reproducible. And we set memory dump parameters, but
> there is no dump file generated when it occurs.
>
> More information:
> maven-surefire-plugin: 3.0.0-M3
> testng: 6.4
> maven: 3.2.5
>
> The line of code throwing the exception is below.
>
> !image-2020-06-24-14-37-45-038.png!
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-5760) Add `-r/--resume` to automatically resume from the last failure point
[
https://issues.apache.org/jira/browse/MNG-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143795#comment-17143795
]
Guy Brand commented on MNG-5760:
This change introduces a [possible
{{NullPointerException}}|https://github.com/apache/maven/pull/342/files#diff-27608ebc026789b242c47348ac37dabfR65]
as the {{project}} retrieved
[here|https://github.com/apache/maven/pull/342/files#diff-27608ebc026789b242c47348ac37dabfR84]
(coming from
[{{LifecycleExecutionException#getProject()}}|https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/lifecycle/LifecycleExecutionException.java#L74])
can return {{null}}.
We face this error when executing our integration tests which execute {{mvn
resources:resources}} without an existing project. With Maven {{3.6.3}} the
following error is thrown:
{code:java}
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 1.995 s
[INFO] Finished at: 2020-06-24T09:38:21+02:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-resources-plugin:3.1.0:resources (default-cli):
Goal requires a project to execute but there is no POM in this directory
(/foo). Please verify you invoked Maven from the correct directory. -> [Help
1]{code}
Can this be fixed as part of that issue ? Shall I create another pull request
or will you have a look at this [~mthmulders] ?
> Add `-r/--resume` to automatically resume from the last failure point
> -
>
> Key: MNG-5760
> URL: https://issues.apache.org/jira/browse/MNG-5760
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.2.5
>Reporter: Phillip Webb
>Assignee: Robert Scholte
>Priority: Trivial
> Fix For: 3.7.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently when a multi-module build fails the {{mvn}} command line prints the
> following error:
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :some-module-name
> {noformat}
> Since I almost always want to use this flag with the next build it would be
> very useful if you could type {{mvn -rf}} and have the project name
> inferred from the last failure rather than needing to copy/paste from the
> terminal.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] santik commented on pull request #9: [MEAR-194] Use ear archiver instead of jar archiver
santik commented on pull request #9: URL: https://github.com/apache/maven-ear-plugin/pull/9#issuecomment-648743428 > On [fb2a47c](https://github.com/apache/maven-ear-plugin/commit/fb2a47cf8cdbc23639b49d6f892a9a0e2fc766d2) I got > > ``` > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0-SNAPSHOT:ear (default-ear) on project maven-ear-plugin-test-project-054: Error assembling EAR: Deployment descriptor: .../maven-ear-plugin/target/test-classes/projects/project-054/target/maven-ear-plugin-test-project-054-99.0/META-INF/application.xml does not exist. -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0-SNAPSHOT:ear (default-ear) on project maven-ear-plugin-test-project-054: Error assembling EAR > ... > [ERROR] Errors: > [ERROR] EarMojoIT.testProject054:652->AbstractEarPluginIT.doTestProject:184->AbstractEarPluginIT.doTestProject:169->AbstractEarPluginIT.doTestProject:144->AbstractEarPluginIT.executeMojo:128->AbstractEarPluginIT.executeMojo:97 » Verification > ``` You are right. Sometimes we still need to use JAR archiver. Updated the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] pzygielo commented on pull request #9: [MEAR-194] Use ear archiver instead of jar archiver
pzygielo commented on pull request #9: URL: https://github.com/apache/maven-ear-plugin/pull/9#issuecomment-648726740 On fb2a47cf8cdbc23639b49d6f892a9a0e2fc766d2 I got ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0-SNAPSHOT:ear (default-ear) on project maven-ear-plugin-test-project-054: Error assembling EAR: Deployment descriptor: .../maven-ear-plugin/target/test-classes/projects/project-054/target/maven-ear-plugin-test-project-054-99.0/META-INF/application.xml does not exist. -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0-SNAPSHOT:ear (default-ear) on project maven-ear-plugin-test-project-054: Error assembling EAR ... [ERROR] Errors: [ERROR] EarMojoIT.testProject054:652->AbstractEarPluginIT.doTestProject:184->AbstractEarPluginIT.doTestProject:169->AbstractEarPluginIT.doTestProject:144->AbstractEarPluginIT.executeMojo:128->AbstractEarPluginIT.executeMojo:97 » Verification ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] santik opened a new pull request #364: [MCHECKSTYLE-393] Upgrade Doxia Version to 1.9.2
santik opened a new pull request #364: URL: https://github.com/apache/maven/pull/364 [MCHECKSTYLE-393] Upgrade Doxia Version to 1.9.2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] santik commented on a change in pull request #9: [MEAR-194] Use ear archiver instead of jar archiver
santik commented on a change in pull request #9: URL: https://github.com/apache/maven-ear-plugin/pull/9#discussion_r444767125 ## File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java ## @@ -692,9 +693,9 @@ public String getMappedFileName( String pName ) * * @return the archiver */ -protected JarArchiver getJarArchiver() +protected EarArchiver getEarArchiver() Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] pzygielo commented on a change in pull request #9: [MEAR-194] Use ear archiver instead of jar archiver
pzygielo commented on a change in pull request #9: URL: https://github.com/apache/maven-ear-plugin/pull/9#discussion_r444763785 ## File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java ## @@ -692,9 +693,9 @@ public String getMappedFileName( String pName ) * * @return the archiver */ -protected JarArchiver getJarArchiver() +protected EarArchiver getEarArchiver() Review comment: Perhaps `link` in doc could be updated and import of `JarAchiver` removed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] santik opened a new pull request #9: [MEAR-194] Use ear archiver instead of jar archiver
santik opened a new pull request #9: URL: https://github.com/apache/maven-ear-plugin/pull/9 In plugin instead of correct EAR archiver JAR archiver was used. In this PR application will use correct archiver. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWAR-433) Maven WAR plugin is deleting files generated by other plugins after upgrading to 3.3.0
[
https://issues.apache.org/jira/browse/MWAR-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143687#comment-17143687
]
Marco Rothe commented on MWAR-433:
--
Same here. Our builds break, as generated content will be deleted. Please fix :)
> Maven WAR plugin is deleting files generated by other plugins after upgrading
> to 3.3.0
> --
>
> Key: MWAR-433
> URL: https://issues.apache.org/jira/browse/MWAR-433
> Project: Maven WAR Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Kyle Lieber
>Priority: Critical
> Fix For: 3.3.1
>
>
> My project generates wsdls using the {{jaxws-maven-plugin}} which puts the
> generated wsdls in
> {{${project.build.directory}/${project.build.finalName}/WEB-INF/wsdls}} so
> that they are packaged up in the war file. Then I have a client jar that
> copies those wsdls out of the war file using the {{maven-dependency-plugin}}
> and generates a client from the wsdls using the {{jaxws-maven-plugin}}.
> This all works fine using {{3.2.3}} of the {{maven-war-plugin}}. However,
> after upgrading to {{3.3.0}} my project fails to build because the wsdls are
> no longer preserved. It seems that they are being deleted by the
> {{maven-war-plugin}}.
> I created an example project on Github which recreates the problem. The
> {{master}} branch is using {{3.2.3}} and the {{maven-war-plugin-3.3.0}}
> branch is using {{3.3.0}}. You can find more details in the readme file of
> the example project:
> https://github.com/klieber/maven-war-plugin-bug
> I also suspect that MWAR-427 is the change that introduced this bug.
> Please let me know if there is anymore information I can provide. Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-6947) StringSearchModelInterpolatorTest fails to interpolate ${project.basedir} across Java versions
[
https://issues.apache.org/jira/browse/MNG-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6947:
Description:
This has been discovered while using {{MAVENCODEBASE}} with relative paths and
symlinks.
This is a very subtile bug and I yet don't understand. Here is how to reproduce:
Have Maven cloned repo on a symlinked dir:
{noformat}
osipovmi@deblndw011x:~/var/Projekte/maven (master *=)
$ pwd -P
/var/osipovmi/Projekte/maven
{noformat}
and invoke Maven with {{-f}} and a non-normalized path:
{noformat}
mvn -f $PWD/../maven -V -pl maven-model-builder test
{noformat}
With Java 8 all tests pass, with Java 11+ the mentioned test fails:
{noformat}
[ERROR] Tests run: 34, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.086
s <<< FAILURE! - in
org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
[ERROR]
testInterpolateObjectWithPomFile(org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest)
Time elapsed: 0.012 s <<< FAILURE!
java.lang.AssertionError:
Expected: is (is
"/net/home/osipovmi/var/Projekte/maven/maven-model-builder/target" or is
"/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target")
but: was "/var/osipovmi/Projekte/maven/maven-model-builder/./target"
at
org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest.testInterpolateObjectWithPomFile(StringSearchModelInterpolatorTest.java:366)
{noformat}
I have applied the following patch:
{noformat}
$ git diff
diff --git
a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
index dbb72c4f7..b2d4b0965 100644
---
a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
+++
b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
@@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
ModelBuildingRequest config = createModelBuildingRequest( p );
SimpleProblemCollector collector = new SimpleProblemCollector();
assertProblemFree( collector );
-
+System.out.println( baseDir.getAbsolutePath() );
+System.out.println( System.getProperty( "user.dir" ) );
+System.out.println( obj.values.get( "key" ) );
assertThat( baseDir.getAbsolutePath(), is( System.getProperty(
"user.dir" ) ) );
assertThat( obj.values.size(), is( 1 ) );
assertThat( (String) obj.values.get( "key" ), is( anyOf(
{noformat}
and receive:
{noformat}
Java 8:
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target
Java 11:
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/var/osipovmi/Projekte/maven/maven-model-builder/./target
Java 14:
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/var/osipovmi/Projekte/maven/maven-model-builder/./target
{noformat}
When I apply
{noformat}
$ git diff
diff --git
a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
index dbb72c4f7..b2d4b0965 100644
---
a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
+++
b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
@@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
ModelBuildingRequest config = createModelBuildingRequest( p );
SimpleProblemCollector collector = new SimpleProblemCollector();
-interpolator.interpolateObject( obj, model, new File( "." ), config,
collector );
+interpolator.interpolateObject( obj, model, new File(
System.getProperty( "user.dir" ) ), config, collector );
assertProblemFree( collector );
{noformat}
The code works. Unfortunately, I do not know whether this fixes the cause
because the test is faulty or just the symptom and the issue is in Core. Is has
to be noted that {{user.dir}} is backed by {{getcwd()}} which always returns an
absolute, canonical path.
All tests perfomed on:
{noformat}
$ mvn -v
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T20:33:14+02:00)
Maven home: /usr/local/apache-maven-3.5.4
Java version: 11.0.7, vendor: Oracle Corporation, runtime: /usr/local/openjdk11
Default locale: de_DE, platform encoding: UTF-8
OS name: "freebsd", version: "12.1-stable", arch: "amd64", family: "unix"
{nofor
[jira] [Commented] (MNG-6947) StringSearchModelInterpolatorTest fails to interpolate ${project.basedir} across Java versions
[
https://issues.apache.org/jira/browse/MNG-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143657#comment-17143657
]
Michael Osipov commented on MNG-6947:
-
[~rfscholte], yet another symlink/canonical path issue. WDYT?
> StringSearchModelInterpolatorTest fails to interpolate ${project.basedir}
> across Java versions
> --
>
> Key: MNG-6947
> URL: https://issues.apache.org/jira/browse/MNG-6947
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
>
> This has been discovered while using {{MAVENCODEBASE}} with relative paths
> and symlinks.
> This is a very subtile bug and I yet don't understand. Here is how to
> reproduce:
> Have Maven cloned repo on a symlinked dir:
> {noformat}
> osipovmi@deblndw011x:~/var/Projekte/maven (master *=)
> $ pwd -P
> /var/osipovmi/Projekte/maven
> {noformat}
> and invoke Maven with {{-f}} and a non-normalized path:
> {noformat}
> mvn -f $PWD/../maven -V -pl maven-model-builder test
> {noformat}
> With Java 8 all tests pass, with Java 11+ the mentioned test fails:
> {noformat}
> [ERROR] Tests run: 34, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.086 s <<< FAILURE! - in
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
> [ERROR]
> testInterpolateObjectWithPomFile(org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest)
> Time elapsed: 0.012 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: is (is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/target" or is
> "/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target")
> but: was "/var/osipovmi/Projekte/maven/maven-model-builder/./target"
> at
> org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest.testInterpolateObjectWithPomFile(StringSearchModelInterpolatorTest.java:366)
> {noformat}
> I have applied the following patch:
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBuildingRequest( p );
> SimpleProblemCollector collector = new SimpleProblemCollector();
> assertProblemFree( collector );
> -
> +System.out.println( baseDir.getAbsolutePath() );
> +System.out.println( System.getProperty( "user.dir" ) );
> +System.out.println( obj.values.get( "key" ) );
> assertThat( baseDir.getAbsolutePath(), is( System.getProperty(
> "user.dir" ) ) );
> assertThat( obj.values.size(), is( 1 ) );
> assertThat( (String) obj.values.get( "key" ), is( anyOf(
> {noformat}
> and receive:
> {noformat}
> Java 8:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target
> Java 11:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> Java 14:
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /net/home/osipovmi/var/Projekte/maven/maven-model-builder
> /var/osipovmi/Projekte/maven/maven-model-builder/./target
> {noformat}
> When I apply
> {noformat}
> $ git diff
> diff --git
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
>
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> index dbb72c4f7..b2d4b0965 100644
> ---
> a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> +++
> b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
> @@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
> ModelBuildingRequest config = createModelBuildingRequest( p );
> SimpleProblemCollector collector = new SimpleProblemCollector();
> -interpolator.interpolateObject( obj, model, new File( "." ), config,
> collector );
> +interpolator.interpolateObject( obj, model, new File(
> Syste
[jira] [Created] (MNG-6947) StringSearchModelInterpolatorTest fails to interpolate ${project.basedir} across Java versions
Michael Osipov created MNG-6947:
---
Summary: StringSearchModelInterpolatorTest fails to interpolate
${project.basedir} across Java versions
Key: MNG-6947
URL: https://issues.apache.org/jira/browse/MNG-6947
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.6.3
Reporter: Michael Osipov
This has been discovered while using {{MAVENCODEBASE}} with relative paths and
symlinks.
This is a very subtile bug and I yet don't understand. Here is how to reproduce:
Have Maven cloned repo on a symlinked dir:
{noformat}
osipovmi@deblndw011x:~/var/Projekte/maven (master *=)
$ pwd -P
/var/osipovmi/Projekte/maven
{noformat}
and invoke Maven with {{-f}} and a non-normalized path:
{noformat}
mvn -f $PWD/../maven -V -pl maven-model-builder test
{noformat}
With Java 8 all tests pass, with Java 11+ the mentioned test fails:
{noformat}
[ERROR] Tests run: 34, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.086
s <<< FAILURE! - in
org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
[ERROR]
testInterpolateObjectWithPomFile(org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest)
Time elapsed: 0.012 s <<< FAILURE!
java.lang.AssertionError:
Expected: is (is
"/net/home/osipovmi/var/Projekte/maven/maven-model-builder/target" or is
"/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target")
but: was "/var/osipovmi/Projekte/maven/maven-model-builder/./target"
at
org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest.testInterpolateObjectWithPomFile(StringSearchModelInterpolatorTest.java:366)
{noformat}
I have applied the following patch:
{noformat}
$ git diff
diff --git
a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
index dbb72c4f7..b2d4b0965 100644
---
a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
+++
b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
@@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
ModelBuildingRequest config = createModelBuildingRequest( p );
SimpleProblemCollector collector = new SimpleProblemCollector();
assertProblemFree( collector );
-
+System.out.println( baseDir.getAbsolutePath() );
+System.out.println( System.getProperty( "user.dir" ) );
+System.out.println( obj.values.get( "key" ) );
assertThat( baseDir.getAbsolutePath(), is( System.getProperty(
"user.dir" ) ) );
assertThat( obj.values.size(), is( 1 ) );
assertThat( (String) obj.values.get( "key" ), is( anyOf(
{noformat}
and receive:
{noformat}
Java 8:
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/net/home/osipovmi/var/Projekte/maven/maven-model-builder/./target
Java 11:
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/var/osipovmi/Projekte/maven/maven-model-builder/./target
Java 14:
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/net/home/osipovmi/var/Projekte/maven/maven-model-builder
/var/osipovmi/Projekte/maven/maven-model-builder/./target
{noformat}
When I apply
{noformat}
$ git diff
diff --git
a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
index dbb72c4f7..b2d4b0965 100644
---
a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
+++
b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
@@ -356,9 +356,11 @@ public void testInterpolateObjectWithPomFile()
ModelBuildingRequest config = createModelBuildingRequest( p );
SimpleProblemCollector collector = new SimpleProblemCollector();
-interpolator.interpolateObject( obj, model, new File( "." ), config,
collector );
+interpolator.interpolateObject( obj, model, new File(
System.getProperty( "user.dir" ) ), config, collector );
assertProblemFree( collector );
{noformat}
The code works. Unfortunately, I do not know whether this fixes the cause
because the test is faulty or just the symptom and the issue is in Core.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRELEASE-1048) Unrecognized option: --no-transfer-progress
[ https://issues.apache.org/jira/browse/MRELEASE-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143634#comment-17143634 ] Arnaud Heritier commented on MRELEASE-1048: --- I had a quick look at it. This option is effectively not declared in [https://github.com/apache/maven-release/blob/master/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java] but the real problem is that we cannot pass to the InvocationRequest a TransfertListerner like we do in a MavenExecutionRequest [https://github.com/apache/maven/blob/658ad90b3850131e4a73fd6cca2ead30f6e5f213/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L1469-L1484] We could probably have a workaround by just defining the system property -[Dorg.slf4j.simpleLogger.log.org|http://dorg.slf4j.simplelogger.log.org/].apache.maven.cli.transfer.Slf4jMavenTransferListener=warn like in pre 3.6.1 but it's not really clean ... WDYT [~rfscholte] ? > Unrecognized option: --no-transfer-progress > --- > > Key: MRELEASE-1048 > URL: https://issues.apache.org/jira/browse/MRELEASE-1048 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare >Affects Versions: 2.5.3 >Reporter: Olivier Vernin >Priority: Major > > ``` > usr/share/maven/bin/mvn B -s settings-release.xml > -Darguments='-no-transfer-progress' release:prepare > > Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on > project remoting: Failed to re-parse additional arguments for Maven > invocation. Unrecognized option: --no-transfer-progress -> [Help 1] > ``` > > maven version > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /usr/share/maven > Java version: 1.8.0_252, vendor: Oracle Corporation, runtime: > /usr/local/openjdk-8/jre > Default locale: en, platform encoding: UTF-8 > OS name: "linux", version: "4.15.0-1082-azure", arch: "amd64", family: "unix" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1048) Unrecognized option: --no-transfer-progress
[ https://issues.apache.org/jira/browse/MRELEASE-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143632#comment-17143632 ] Olivier Vernin commented on MRELEASE-1048: -- A suggested workaround was to replace ''-Darguments='-no-transfer-progress'" by "-Darguments=-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn" release:clean > Unrecognized option: --no-transfer-progress > --- > > Key: MRELEASE-1048 > URL: https://issues.apache.org/jira/browse/MRELEASE-1048 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare >Affects Versions: 2.5.3 >Reporter: Olivier Vernin >Priority: Major > > ``` > usr/share/maven/bin/mvn B -s settings-release.xml > -Darguments='-no-transfer-progress' release:prepare > > Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on > project remoting: Failed to re-parse additional arguments for Maven > invocation. Unrecognized option: --no-transfer-progress -> [Help 1] > ``` > > maven version > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /usr/share/maven > Java version: 1.8.0_252, vendor: Oracle Corporation, runtime: > /usr/local/openjdk-8/jre > Default locale: en, platform encoding: UTF-8 > OS name: "linux", version: "4.15.0-1082-azure", arch: "amd64", family: "unix" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MRELEASE-1048) Unrecognized option: --no-transfer-progress
[ https://issues.apache.org/jira/browse/MRELEASE-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Vernin updated MRELEASE-1048: - Description: ``` usr/share/maven/bin/mvn B -s settings-release.xml -Darguments='-no-transfer-progress' release:prepare Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on project remoting: Failed to re-parse additional arguments for Maven invocation. Unrecognized option: --no-transfer-progress -> [Help 1] ``` maven version Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/share/maven Java version: 1.8.0_252, vendor: Oracle Corporation, runtime: /usr/local/openjdk-8/jre Default locale: en, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-1082-azure", arch: "amd64", family: "unix" was: ``` usr/share/maven/bin/mvn -B -s settings-release.xml -Darguments='--no-transfer-progress' release:prepare Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on project remoting: Failed to re-parse additional arguments for Maven invocation. Unrecognized option: --no-transfer-progress -> [Help 1] ``` maven version Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/share/maven Java version: 1.8.0_252, vendor: Oracle Corporation, runtime: /usr/local/openjdk-8/jre Default locale: en, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-1082-azure", arch: "amd64", family: "unix" > Unrecognized option: --no-transfer-progress > --- > > Key: MRELEASE-1048 > URL: https://issues.apache.org/jira/browse/MRELEASE-1048 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare >Affects Versions: 2.5.3 >Reporter: Olivier Vernin >Priority: Major > > ``` > usr/share/maven/bin/mvn B -s settings-release.xml > -Darguments='-no-transfer-progress' release:prepare > > Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on > project remoting: Failed to re-parse additional arguments for Maven > invocation. Unrecognized option: --no-transfer-progress -> [Help 1] > ``` > > maven version > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /usr/share/maven > Java version: 1.8.0_252, vendor: Oracle Corporation, runtime: > /usr/local/openjdk-8/jre > Default locale: en, platform encoding: UTF-8 > OS name: "linux", version: "4.15.0-1082-azure", arch: "amd64", family: "unix" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MRELEASE-1048) Unrecognized option: --no-transfer-progress
Olivier Vernin created MRELEASE-1048: Summary: Unrecognized option: --no-transfer-progress Key: MRELEASE-1048 URL: https://issues.apache.org/jira/browse/MRELEASE-1048 Project: Maven Release Plugin Issue Type: Bug Components: prepare Affects Versions: 2.5.3 Reporter: Olivier Vernin ``` usr/share/maven/bin/mvn -B -s settings-release.xml -Darguments='--no-transfer-progress' release:prepare Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on project remoting: Failed to re-parse additional arguments for Maven invocation. Unrecognized option: --no-transfer-progress -> [Help 1] ``` maven version Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/share/maven Java version: 1.8.0_252, vendor: Oracle Corporation, runtime: /usr/local/openjdk-8/jre Default locale: en, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-1082-azure", arch: "amd64", family: "unix" -- This message was sent by Atlassian Jira (v8.3.4#803005)
