[jira] [Created] (MRELEASE-1051) maven-release-plugin should honnor the -N command line option
zosrothko created MRELEASE-1051: --- Summary: maven-release-plugin should honnor the -N command line option Key: MRELEASE-1051 URL: https://issues.apache.org/jira/browse/MRELEASE-1051 Project: Maven Release Plugin Issue Type: Bug Affects Versions: 3.0.0-M1 Environment: C:\Users\fandre\Documents\git\javacc\javacc-8.0>mvn -version Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00) Maven home: C:\ASF\apache-maven-3.6.1\bin\.. Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_181\jre Default locale: fr_FR, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Reporter: zosrothko Hello the maven-release-plugin does not seem to honnor the maven command line option '-N' as it releases all modules of a root pom module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-shade-plugin] dependabot[bot] opened a new pull request #60: Bump mockito-core from 2.28.2 to 3.4.0
dependabot[bot] opened a new pull request #60: URL: https://github.com/apache/maven-shade-plugin/pull/60 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 3.4.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v3.4.0 Release notes were automatically generated by http://shipkit.org/";>Shipkit 3.4.0 2020-07-10 - https://github.com/mockito/mockito/compare/v3.3.12...v3.4.0";>19 commits by 9 authors - published to https://bintray.com/mockito/maven/mockito/3.4.0";>https://img.shields.io/badge/Bintray-3.4.0-green.svg"; alt="Bintray" /> Commits: https://github.com/TimvdLippe";>Tim van der Lippe (5), https://github.com/epeee";>Erhard Pointl (4), https://github.com/raphw";>Rafael Winterhalter (3), https://github.com/grimreaper";>Eitan Adler (2), adrianriley (1), akluball (1), https://github.com/arteam";>Artem Prigoda (1), https://github.com/jamietanna";>Jamie Tanna (1), https://github.com/takezoe";>Naoki Takezoe (1) [Android support] Enable mocking static methods in Mockito [(https://github-redirect.dependabot.com/mockito/mockito/issues/1013";>#1013)](https://github-redirect.dependabot.com/mockito/mockito/issues/1013";>mockito/mockito#1013) Document using @Mock with method parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/1961";>#1961)](https://github-redirect.dependabot.com/mockito/mockito/pull/1961";>mockito/mockito#1961) Documentation: @Mock on method parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/1960";>#1960)](https://github-redirect.dependabot.com/mockito/mockito/issues/1960";>mockito/mockito#1960) Update errorprone gradle plugin to v1.2.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1958";>#1958)](https://github-redirect.dependabot.com/mockito/mockito/pull/1958";>mockito/mockito#1958) Update spotless Travis job name to be more descriptive [(https://github-redirect.dependabot.com/mockito/mockito/issues/1957";>#1957)](https://github-redirect.dependabot.com/mockito/mockito/pull/1957";>mockito/mockito#1957) Fix a confusing typo in subclassing error message [(https://github-redirect.dependabot.com/mockito/mockito/issues/1953";>#1953)](https://github-redirect.dependabot.com/mockito/mockito/pull/1953";>mockito/mockito#1953) Update bnd gradle plugin to v5.1.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1952";>#1952)](https://github-redirect.dependabot.com/mockito/mockito/pull/1952";>mockito/mockito#1952) Use errorprone 2.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1951";>#1951)](https://github-redirect.dependabot.com/mockito/mockito/pull/1951";>mockito/mockito#1951) Use jacoco v0.8.5 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1950";>#1950)](https://github-redirect.dependabot.com/mockito/mockito/pull/1950";>mockito/mockito#1950) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/1712";>#1712 : prepend description to AssertionError thrown in verification [(https://github-redirect.dependabot.com/mockito/mockito/issues/1949";>#1949)](https://github-redirect.dependabot.com/mockito/mockito/pull/1949";>mockito/mockito#1949) Update gradle 6 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1948";>#1948)](https://github-redirect.dependabot.com/mockito/mockito/pull/1948";>mockito/mockito#1948) Move spotless check to separate build task [(https://github-redirect.dependabot.com/mockito/mockito/issues/1946";>#1946)](https://github-redirect.dependabot.com/mockito/mockito/pull/1946";>mockito/mockito#1946) [Travis] Replace JDK 9/10 with 14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1945";>#1945)](https://github-redirect.dependabot.com/mockito/mockito/pull/1945";>mockito/mockito#1945) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/1898";>#1898 : Return mock name from toString method for deep stub mocks [(https://github-redirect.dependabot.com/mockito/mockito/issues/1942";>#1942)](https://github-redirect.dependabot.com/mockito/mockito/pull/1942";>mockito/mockito#1942) [checkstyle] switch to new DTD [(https://github-redirect.dependabot.com/mockito/mockito/issues/1940";>#1940)](https://github-redirect.dependabot.com/mockito/mockito/pull/1940";>mockito/mockito#1940) Use google-java-format in spotless [(https://github-redirect.dependabot.com/mockito/mockito/issues/1934";>#1934)](https://github-redirect.dependabot.com/mockito/mockito/pull/1934";>mockito/mockito#1934) Update report message to use any() instead of anyObject() [(https://github-redirect.dependabot.com/mockito/mockito/issues/1931";>#1931)](https://github-redirect.dependabot.com/mockito/mockito/pull/1931";>mockito/mockito#1931) [build] bump gradle to latest 5.x release [(https://github-redirect.dependabot.com/mockito/mockito/issues/1923";>#1923)](https://github-redirect.dependabot.com/mockito/mockito/
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request #81: Bump mockito-core from 2.28.2 to 3.4.0
dependabot[bot] opened a new pull request #81: URL: https://github.com/apache/maven-dependency-plugin/pull/81 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 3.4.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v3.4.0 Release notes were automatically generated by http://shipkit.org/";>Shipkit 3.4.0 2020-07-10 - https://github.com/mockito/mockito/compare/v3.3.12...v3.4.0";>19 commits by 9 authors - published to https://bintray.com/mockito/maven/mockito/3.4.0";>https://img.shields.io/badge/Bintray-3.4.0-green.svg"; alt="Bintray" /> Commits: https://github.com/TimvdLippe";>Tim van der Lippe (5), https://github.com/epeee";>Erhard Pointl (4), https://github.com/raphw";>Rafael Winterhalter (3), https://github.com/grimreaper";>Eitan Adler (2), adrianriley (1), akluball (1), https://github.com/arteam";>Artem Prigoda (1), https://github.com/jamietanna";>Jamie Tanna (1), https://github.com/takezoe";>Naoki Takezoe (1) [Android support] Enable mocking static methods in Mockito [(https://github-redirect.dependabot.com/mockito/mockito/issues/1013";>#1013)](https://github-redirect.dependabot.com/mockito/mockito/issues/1013";>mockito/mockito#1013) Document using @Mock with method parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/1961";>#1961)](https://github-redirect.dependabot.com/mockito/mockito/pull/1961";>mockito/mockito#1961) Documentation: @Mock on method parameters [(https://github-redirect.dependabot.com/mockito/mockito/issues/1960";>#1960)](https://github-redirect.dependabot.com/mockito/mockito/issues/1960";>mockito/mockito#1960) Update errorprone gradle plugin to v1.2.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1958";>#1958)](https://github-redirect.dependabot.com/mockito/mockito/pull/1958";>mockito/mockito#1958) Update spotless Travis job name to be more descriptive [(https://github-redirect.dependabot.com/mockito/mockito/issues/1957";>#1957)](https://github-redirect.dependabot.com/mockito/mockito/pull/1957";>mockito/mockito#1957) Fix a confusing typo in subclassing error message [(https://github-redirect.dependabot.com/mockito/mockito/issues/1953";>#1953)](https://github-redirect.dependabot.com/mockito/mockito/pull/1953";>mockito/mockito#1953) Update bnd gradle plugin to v5.1.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1952";>#1952)](https://github-redirect.dependabot.com/mockito/mockito/pull/1952";>mockito/mockito#1952) Use errorprone 2.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1951";>#1951)](https://github-redirect.dependabot.com/mockito/mockito/pull/1951";>mockito/mockito#1951) Use jacoco v0.8.5 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1950";>#1950)](https://github-redirect.dependabot.com/mockito/mockito/pull/1950";>mockito/mockito#1950) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/1712";>#1712 : prepend description to AssertionError thrown in verification [(https://github-redirect.dependabot.com/mockito/mockito/issues/1949";>#1949)](https://github-redirect.dependabot.com/mockito/mockito/pull/1949";>mockito/mockito#1949) Update gradle 6 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1948";>#1948)](https://github-redirect.dependabot.com/mockito/mockito/pull/1948";>mockito/mockito#1948) Move spotless check to separate build task [(https://github-redirect.dependabot.com/mockito/mockito/issues/1946";>#1946)](https://github-redirect.dependabot.com/mockito/mockito/pull/1946";>mockito/mockito#1946) [Travis] Replace JDK 9/10 with 14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/1945";>#1945)](https://github-redirect.dependabot.com/mockito/mockito/pull/1945";>mockito/mockito#1945) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/1898";>#1898 : Return mock name from toString method for deep stub mocks [(https://github-redirect.dependabot.com/mockito/mockito/issues/1942";>#1942)](https://github-redirect.dependabot.com/mockito/mockito/pull/1942";>mockito/mockito#1942) [checkstyle] switch to new DTD [(https://github-redirect.dependabot.com/mockito/mockito/issues/1940";>#1940)](https://github-redirect.dependabot.com/mockito/mockito/pull/1940";>mockito/mockito#1940) Use google-java-format in spotless [(https://github-redirect.dependabot.com/mockito/mockito/issues/1934";>#1934)](https://github-redirect.dependabot.com/mockito/mockito/pull/1934";>mockito/mockito#1934) Update report message to use any() instead of anyObject() [(https://github-redirect.dependabot.com/mockito/mockito/issues/1931";>#1931)](https://github-redirect.dependabot.com/mockito/mockito/pull/1931";>mockito/mockito#1931) [build] bump gradle to latest 5.x release [(https://github-redirect.dependabot.com/mockito/mockito/issues/1923";>#1923)](https://github-redirect.dependabot.com/mockito/moc
[jira] [Commented] (MNG-6932) NullPointerException if no Package is defined for the current class
[
https://issues.apache.org/jira/browse/MNG-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156386#comment-17156386
]
Michael Osipov commented on MNG-6932:
-
Yes, but not using {{RuntimeInformation}} because this one isn't static. How am
I supposed to use the injected instance in a static block?
> NullPointerException if no Package is defined for the current class
> ---
>
> Key: MNG-6932
> URL: https://issues.apache.org/jira/browse/MNG-6932
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.6.3
> Environment: Windows 10, Java 8, custom classloading
>Reporter: Bence Sipka
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.7.x-candidate
>
>
> When the maven-resolver and related classes are used with a {{ClassLoader}}
> that doesn't define a java.lang.Package object for the loaded classes, the
> library throws a {{NullPointerException}}.
> Scenario: I'm using the maven-resolver classes to resolver artifacts from
> various repositories. I package the app, and deploy it to a custom
> environment where the {{ClassLoader}} for the app doesn't define a
> {{Package}} for the loaded classes. In these cases, when the maven-resolver
> library calls {{this.getClass().getPackage().getImplementationVersion()}}
> then a {{NullPointerException}} will occurr.
> The following classes are affected:
> {{DefaultSuperPomProvider.getSuperModel():81}}
> {{DefaultReportingConverter.:56}}
> Code around the locations:
> {code:java}
> String modelId = "org.apache.maven:maven-model-builder:"
> + this.getClass().getPackage().getImplementationVersion() + ":super-pom";
> InputSource inputSource = new InputSource();
> inputSource.setModelId( modelId );
> {code}
> This exception makes the library unportable to different environments.
> Workaround:
> Implement a custom variant of the above classes that circumvent these parts
> of the code.
> Possible solution:
> Null checks, and hard coding the version number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6932) NullPointerException if no Package is defined for the current class
[
https://issues.apache.org/jira/browse/MNG-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156383#comment-17156383
]
Herve Boutemy commented on MNG-6932:
standard Java coding question: do what Java permits (static final can be
initialized in static code, isn't it?)
> NullPointerException if no Package is defined for the current class
> ---
>
> Key: MNG-6932
> URL: https://issues.apache.org/jira/browse/MNG-6932
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.6.3
> Environment: Windows 10, Java 8, custom classloading
>Reporter: Bence Sipka
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.7.x-candidate
>
>
> When the maven-resolver and related classes are used with a {{ClassLoader}}
> that doesn't define a java.lang.Package object for the loaded classes, the
> library throws a {{NullPointerException}}.
> Scenario: I'm using the maven-resolver classes to resolver artifacts from
> various repositories. I package the app, and deploy it to a custom
> environment where the {{ClassLoader}} for the app doesn't define a
> {{Package}} for the loaded classes. In these cases, when the maven-resolver
> library calls {{this.getClass().getPackage().getImplementationVersion()}}
> then a {{NullPointerException}} will occurr.
> The following classes are affected:
> {{DefaultSuperPomProvider.getSuperModel():81}}
> {{DefaultReportingConverter.:56}}
> Code around the locations:
> {code:java}
> String modelId = "org.apache.maven:maven-model-builder:"
> + this.getClass().getPackage().getImplementationVersion() + ":super-pom";
> InputSource inputSource = new InputSource();
> inputSource.setModelId( modelId );
> {code}
> This exception makes the library unportable to different environments.
> Workaround:
> Implement a custom variant of the above classes that circumvent these parts
> of the code.
> Possible solution:
> Null checks, and hard coding the version number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MCHECKSTYLE-99) should use default test sources xref output dir: ${project.reporting.outputDirectory}/xref-test
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156367#comment-17156367
]
Stefan Paal commented on MCHECKSTYLE-99:
i am aware this ticket was closed. still i also have the issue xref links in
the checkstyle report to test source files are broken. i prepared a pull
request that introduces the parameter {{xrefTestLocation}} to specify a custom
location of the test source files. the default is
{{${project.reporting.outputDirectory}/xref-test}} and thus it will work
out-of-the-box for current checkstyle configurations and add the correct xref
links in the checkstyle report.
[https://github.com/apache/maven-checkstyle-plugin/pull/34
|https://github.com/apache/maven-checkstyle-plugin/pull/34]
> should use default test sources xref output dir:
> ${project.reporting.outputDirectory}/xref-test
>
>
> Key: MCHECKSTYLE-99
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-99
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 2.2
> Environment: Linux (but I assume it happens in all environs)
>Reporter: Dan Rollo
>Priority: Major
> Attachments: pom.xml
>
>
> The xref link to the Source pages in the checkstyle report page is
> broken. The source xref link for Unit Test Source files is not using the
> default value of the destDir for jxr test sources. From the jxr plugin docs
> for jxr:test-jxr:
> destDir
> Folder where the Xref files will be copied to.
> * Type: java.lang.String
> * Required: No
> * Expression: ${project.reporting.outputDirectory}/xref-test
> I think the checkstyle plugin should:
> - assume the default dir for jxr:test-jxr
> - provide it's own additional override setting (similar to xrefLocation,
> but for test sources). like: testXrefLocation.
> A pom file exhibiting this problem is attached.
> Dan Rollo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-checkstyle-plugin] stefan-paal-innoq opened a new pull request #34: MCHECKSTYLE-99: should use default test
stefan-paal-innoq opened a new pull request #34:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/34
MCHECKSTYLE-99: should use default test sources
xref output dir: ${project.reporting.outputDirectory}/xref-test
- add parameter xrefTestLocation
- use xrefTestLocation to create jxr report links for test source file
- add integration tests
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MNGSITE-416) Exercising "Getting Started" gives BUILD FAILURE plus example output issues
[
https://issues.apache.org/jira/browse/MNGSITE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Mulders closed MNGSITE-416.
---
Assignee: Maarten Mulders
Resolution: Fixed
Fixed in
[bfdc0b27|https://gitbox.apache.org/repos/asf?p=maven-site.git;a=commit;h=bfdc0b27a8d5e6d2d12c2862d93afeda26abc28c].
> Exercising "Getting Started" gives BUILD FAILURE plus example output issues
> ---
>
> Key: MNGSITE-416
> URL: https://issues.apache.org/jira/browse/MNGSITE-416
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: David Pead
>Assignee: Maarten Mulders
>Priority: Minor
> Attachments: mvnTest.png
>
>
> When following the steps in the Getting Started section, if one uses the
> example archetype as suggested, then tries to compile, in the subsequent step
> you'll be faced with:
> {code:java}
> $ mvn compile
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< com.company.app:my-app
> >---
> [INFO] Building my-app 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ my-app
> ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> /Users/davidpead/dev/mavenGettingStarted/my-app/src/main/resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ my-app ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to
> /Users/davidpead/dev/mavenGettingStarted/my-app/target/classes
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] Source option 5 is no longer supported. Use 6 or later.
> [ERROR] Target option 1.5 is no longer supported. Use 1.6 or later.
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.686 s
> [INFO] Finished at: 2020-07-11T17:32:22+01:00
> [INFO]
>
> {code}
> As the version of the archetype is not set it defaults to 1.0. The resulting
> pom doesn't set the source or target properties so I assume maven defaults to
> 5 / 1.5. The above will happen for any quickstart archetype < 1.3
> Suggest the example is changed to match that of the Maven in 5 mins guide:
> [https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project
>
> |https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project]and
> the pom example too:
> [https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#the-pom]
> Additionally the subsequent steps for test & install show output examples
> that are escaping from the code blocks:
> !mvnTest.png|width=416,height=367!
> This is due the the TEST section output having the closing block hyphens.
> This could be overcome by using more up-to-date output. What's currently
> there reflects an old version.
> PR cometh...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSHARED-916) Require Maven 3+
[ https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156319#comment-17156319 ] Elliotte Rusty Harold commented on MSHARED-916: --- Issue might be in the resting harness. Specifically ProjectTool.readProjectWithDependencies in tetsing-harness 2.1 creates a DefaultProjectBuildingRequest but does not call setResolveDependencies(true) on that object. > Require Maven 3+ > > > Key: MSHARED-916 > URL: https://issues.apache.org/jira/browse/MSHARED-916 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Reporter: Sylwester Lachiewicz >Assignee: Elliotte Rusty Harold >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MSHARED-916) Require Maven 3+
[ https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156319#comment-17156319 ] Elliotte Rusty Harold edited comment on MSHARED-916 at 7/12/20, 2:05 PM: - Issue might be in the testing harness. Specifically ProjectTool.readProjectWithDependencies in tetsing-harness 2.1 creates a DefaultProjectBuildingRequest but does not call setResolveDependencies(true) on that object. was (Author: elharo): Issue might be in the resting harness. Specifically ProjectTool.readProjectWithDependencies in tetsing-harness 2.1 creates a DefaultProjectBuildingRequest but does not call setResolveDependencies(true) on that object. > Require Maven 3+ > > > Key: MSHARED-916 > URL: https://issues.apache.org/jira/browse/MSHARED-916 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Reporter: Sylwester Lachiewicz >Assignee: Elliotte Rusty Harold >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNGSITE-416) Exercising "Getting Started" gives BUILD FAILURE plus example output issues
[
https://issues.apache.org/jira/browse/MNGSITE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156318#comment-17156318
]
David Pead commented on MNGSITE-416:
Linked https://issues.apache.org/jira/browse/MNGSITE-410 as it's fixed by
current PR
> Exercising "Getting Started" gives BUILD FAILURE plus example output issues
> ---
>
> Key: MNGSITE-416
> URL: https://issues.apache.org/jira/browse/MNGSITE-416
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: David Pead
>Priority: Minor
> Attachments: mvnTest.png
>
>
> When following the steps in the Getting Started section, if one uses the
> example archetype as suggested, then tries to compile, in the subsequent step
> you'll be faced with:
> {code:java}
> $ mvn compile
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< com.company.app:my-app
> >---
> [INFO] Building my-app 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ my-app
> ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> /Users/davidpead/dev/mavenGettingStarted/my-app/src/main/resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ my-app ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to
> /Users/davidpead/dev/mavenGettingStarted/my-app/target/classes
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] Source option 5 is no longer supported. Use 6 or later.
> [ERROR] Target option 1.5 is no longer supported. Use 1.6 or later.
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.686 s
> [INFO] Finished at: 2020-07-11T17:32:22+01:00
> [INFO]
>
> {code}
> As the version of the archetype is not set it defaults to 1.0. The resulting
> pom doesn't set the source or target properties so I assume maven defaults to
> 5 / 1.5. The above will happen for any quickstart archetype < 1.3
> Suggest the example is changed to match that of the Maven in 5 mins guide:
> [https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project
>
> |https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project]and
> the pom example too:
> [https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#the-pom]
> Additionally the subsequent steps for test & install show output examples
> that are escaping from the code blocks:
> !mvnTest.png|width=416,height=367!
> This is due the the TEST section output having the closing block hyphens.
> This could be overcome by using more up-to-date output. What's currently
> there reflects an old version.
> PR cometh...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MNGSITE-410) on website, Maven Getting Started page, sample pom.xml has no description element, but subsequent explanation of the sample pom.xml thinks it does
[ https://issues.apache.org/jira/browse/MNGSITE-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156317#comment-17156317 ] David Pead edited comment on MNGSITE-410 at 7/12/20, 1:46 PM: -- covered by this PR: [https://github.com/apache/maven-site/pull/177] & https://issues.apache.org/jira/browse/MNGSITE-416 was (Author: davepead): covered by this PR: https://github.com/apache/maven-site/pull/177 > on website, Maven Getting Started page, sample pom.xml has no description > element, but subsequent explanation of the sample pom.xml thinks it does > -- > > Key: MNGSITE-410 > URL: https://issues.apache.org/jira/browse/MNGSITE-410 > Project: Maven Project Web Site > Issue Type: Bug > Environment: website >Reporter: Tim Stewart >Priority: Minor > > On web page [https://maven.apache.org/guides/getting-started/] the sample > pom.xml does not contain a element, but below the sample > pom.xml it says: "This is a very simple POM but still displays the key > elements every POM contains, so let's walk through each of them to > familiarize you with the POM essentials: ... • _description This element > provides a basic description of your project. This is often used in Maven's > generated documentation._" > So the explanation of the "description" element assumes the pom.xml contains > one, but it does not. > Recommended fix: include a "description" element in the sample pom.xml. Or, > alternatively, remove references to the description "element" from the > bulleted explanation of elements below the sample pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNGSITE-410) on website, Maven Getting Started page, sample pom.xml has no description element, but subsequent explanation of the sample pom.xml thinks it does
[ https://issues.apache.org/jira/browse/MNGSITE-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156317#comment-17156317 ] David Pead commented on MNGSITE-410: covered by this PR: https://github.com/apache/maven-site/pull/177 > on website, Maven Getting Started page, sample pom.xml has no description > element, but subsequent explanation of the sample pom.xml thinks it does > -- > > Key: MNGSITE-410 > URL: https://issues.apache.org/jira/browse/MNGSITE-410 > Project: Maven Project Web Site > Issue Type: Bug > Environment: website >Reporter: Tim Stewart >Priority: Minor > > On web page [https://maven.apache.org/guides/getting-started/] the sample > pom.xml does not contain a element, but below the sample > pom.xml it says: "This is a very simple POM but still displays the key > elements every POM contains, so let's walk through each of them to > familiarize you with the POM essentials: ... • _description This element > provides a basic description of your project. This is often used in Maven's > generated documentation._" > So the explanation of the "description" element assumes the pom.xml contains > one, but it does not. > Recommended fix: include a "description" element in the sample pom.xml. Or, > alternatively, remove references to the description "element" from the > bulleted explanation of elements below the sample pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MSHARED-916) Require Maven 3+
[
https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156314#comment-17156314
]
Elliotte Rusty Harold edited comment on MSHARED-916 at 7/12/20, 1:39 PM:
-
In 3.0 MavenProject.getArtifacts is sometimes returning an empty list. That is,
it's not reporting the project's dependencies. That is, this is failing in
DefaultProjectDependencyAnalyzerTest:
{{compileProject( "jarWithCompileDependency/pom.xml" );
MavenProject project2 = getProject( "jarWithCompileDependency/project2/pom.xml"
);
assertFalse(project2.getArtifacts().isEmpty());}}
was (Author: elharo):
In 3.0 MavenProject.getArtifacts is sometimes returning an empty list. That is,
it's not reporting the project's dependencies. That is, this is failing in
DefaultProjectDependencyAnalyzerTest:
{{compileProject( "jarWithCompileDependency/pom.xml" );}}
{{ MavenProject project2 = getProject(
"jarWithCompileDependency/project2/pom.xml" );}}
{{ assertFalse(project2.getArtifacts().isEmpty());}}
> Require Maven 3+
>
>
> Key: MSHARED-916
> URL: https://issues.apache.org/jira/browse/MSHARED-916
> Project: Maven Shared Components
> Issue Type: Dependency upgrade
> Components: maven-dependency-analyzer
>Reporter: Sylwester Lachiewicz
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MSHARED-916) Require Maven 3+
[
https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156314#comment-17156314
]
Elliotte Rusty Harold edited comment on MSHARED-916 at 7/12/20, 1:38 PM:
-
In 3.0 MavenProject.getArtifacts is sometimes returning an empty list. That is,
it's not reporting the project's dependencies. That is, this is failing in
DefaultProjectDependencyAnalyzerTest:
{{compileProject( "jarWithCompileDependency/pom.xml" );}}
{{ MavenProject project2 = getProject(
"jarWithCompileDependency/project2/pom.xml" );}}
{{ assertFalse(project2.getArtifacts().isEmpty());}}
was (Author: elharo):
In 3.0 MavenProject.getArtifacts is sometimes returning an empty list. That is,
it's not reporting the project's dependencies. That is, this is failing in
DefaultProjectDependencyAnalyzerTest:
compileProject( "jarWithCompileDependency/pom.xml" );
{{ MavenProject project2 = getProject(
"jarWithCompileDependency/project2/pom.xml" );}}
{{ assertFalse(project2.getArtifacts().isEmpty());}}
> Require Maven 3+
>
>
> Key: MSHARED-916
> URL: https://issues.apache.org/jira/browse/MSHARED-916
> Project: Maven Shared Components
> Issue Type: Dependency upgrade
> Components: maven-dependency-analyzer
>Reporter: Sylwester Lachiewicz
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MSHARED-916) Require Maven 3+
[
https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156314#comment-17156314
]
Elliotte Rusty Harold edited comment on MSHARED-916 at 7/12/20, 1:38 PM:
-
In 3.0 MavenProject.getArtifacts is sometimes returning an empty list. That is,
it's not reporting the project's dependencies. That is, this is failing in
DefaultProjectDependencyAnalyzerTest:
compileProject( "jarWithCompileDependency/pom.xml" );
{{ MavenProject project2 = getProject(
"jarWithCompileDependency/project2/pom.xml" );}}
{{ assertFalse(project2.getArtifacts().isEmpty());}}
was (Author: elharo):
In 3.0 MavenProject.getArtifacts is sometimes returning an empty list. That is,
it's not reporting the project's dependencies. That is, this is failing in
DefaultProjectDependencyAnalyzerTest:
{{compileProject( "jarWithCompileDependency/pom.xml" );}}
{{ MavenProject project2 = getProject(
"jarWithCompileDependency/project2/pom.xml" );}}
{{ assertFalse(project2.getArtifacts().isEmpty());}}
> Require Maven 3+
>
>
> Key: MSHARED-916
> URL: https://issues.apache.org/jira/browse/MSHARED-916
> Project: Maven Shared Components
> Issue Type: Dependency upgrade
> Components: maven-dependency-analyzer
>Reporter: Sylwester Lachiewicz
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MSHARED-916) Require Maven 3+
[
https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156314#comment-17156314
]
Elliotte Rusty Harold edited comment on MSHARED-916 at 7/12/20, 1:38 PM:
-
In 3.0 MavenProject.getArtifacts is sometimes returning an empty list. That is,
it's not reporting the project's dependencies. That is, this is failing in
DefaultProjectDependencyAnalyzerTest:
{{compileProject( "jarWithCompileDependency/pom.xml" );}}
{{ MavenProject project2 = getProject(
"jarWithCompileDependency/project2/pom.xml" );}}
{{ assertFalse(project2.getArtifacts().isEmpty());}}
was (Author: elharo):
In 3.0 MavenProject.getArtifacts is sometimes returning an empty list. That is,
it's not reporting the project's dependencies. That is, this is failing in
DefaultProjectDependencyAnalyzerTest:
{{compileProject( "jarWithCompileDependency/pom.xml" );
MavenProject project2 = getProject(
"jarWithCompileDependency/project2/pom.xml" );
assertFalse(project2.getArtifacts().isEmpty());}}
> Require Maven 3+
>
>
> Key: MSHARED-916
> URL: https://issues.apache.org/jira/browse/MSHARED-916
> Project: Maven Shared Components
> Issue Type: Dependency upgrade
> Components: maven-dependency-analyzer
>Reporter: Sylwester Lachiewicz
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSHARED-916) Require Maven 3+
[ https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156316#comment-17156316 ] Elliotte Rusty Harold commented on MSHARED-916: --- JavaDoc warns me that getArtifacts returns "All dependencies that this project has, including transitive ones. Contents are lazily populated, so depending on what phases have run dependencies in some scopes won't be included. eg. if only compile phase has run, dependencies with scope test won't be included." so maybe the right phase hasn't run when we need it for some of the tests? > Require Maven 3+ > > > Key: MSHARED-916 > URL: https://issues.apache.org/jira/browse/MSHARED-916 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Reporter: Sylwester Lachiewicz >Assignee: Elliotte Rusty Harold >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-916) Require Maven 3+
[
https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156314#comment-17156314
]
Elliotte Rusty Harold commented on MSHARED-916:
---
In 3.0 MavenProject.getArtifacts is sometimes returning an empty list. That is,
it's not reporting the project's dependencies. That is, this is failing in
DefaultProjectDependencyAnalyzerTest:
{{compileProject( "jarWithCompileDependency/pom.xml" );
MavenProject project2 = getProject(
"jarWithCompileDependency/project2/pom.xml" );
assertFalse(project2.getArtifacts().isEmpty());}}
> Require Maven 3+
>
>
> Key: MSHARED-916
> URL: https://issues.apache.org/jira/browse/MSHARED-916
> Project: Maven Shared Components
> Issue Type: Dependency upgrade
> Components: maven-dependency-analyzer
>Reporter: Sylwester Lachiewicz
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MDEP-289) Incorrect warning with javax.xml
[ https://issues.apache.org/jira/browse/MDEP-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-289: --- Labels: intern (was: ) > Incorrect warning with javax.xml > > > Key: MDEP-289 > URL: https://issues.apache.org/jira/browse/MDEP-289 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: analyze >Affects Versions: 2.1 > Environment: OS : Windows XP > Maven 2.2.1 > Java 1.5 >Reporter: zaccret >Priority: Major > Labels: intern > Attachments: sandbox.zip > > > When you use some javax.xml classes in a project and that you have transitive > dependencies containing these classes, you will get a warning if you analyze > your dependencies (Used undeclared dependencies found), even if the classes > you use are contained in your JDK. > I attach a project using javax.xml.parsers.DocumentBuilder which is included > in Java Class Library (rt.jar) but also in a transitive dependency (xml-apis). > I think we should not get a warning because the Java Class Library should be > the first library found in the classpath, doesn't it ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MDEP-289) Incorrect warning with javax.xml
[ https://issues.apache.org/jira/browse/MDEP-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-289: --- Priority: Major (was: Minor) > Incorrect warning with javax.xml > > > Key: MDEP-289 > URL: https://issues.apache.org/jira/browse/MDEP-289 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: analyze >Affects Versions: 2.1 > Environment: OS : Windows XP > Maven 2.2.1 > Java 1.5 >Reporter: zaccret >Priority: Major > Attachments: sandbox.zip > > > When you use some javax.xml classes in a project and that you have transitive > dependencies containing these classes, you will get a warning if you analyze > your dependencies (Used undeclared dependencies found), even if the classes > you use are contained in your JDK. > I attach a project using javax.xml.parsers.DocumentBuilder which is included > in Java Class Library (rt.jar) but also in a transitive dependency (xml-apis). > I think we should not get a warning because the Java Class Library should be > the first library found in the classpath, doesn't it ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MDEP-665) Recognize "starters" during analyze
[
https://issues.apache.org/jira/browse/MDEP-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MDEP-665.
Resolution: Duplicate
> Recognize "starters" during analyze
> ---
>
> Key: MDEP-665
> URL: https://issues.apache.org/jira/browse/MDEP-665
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: analyze
>Reporter: Robert Scholte
>Priority: Major
>
> Springboot introduces the concept of starters, which are a predefined set of
> dependencies.
> It is an empty jar, which acts as just a container for multiple dependencies.
> (it should have been a pom, but that means people suddenly need to add
> {{pom to their dependency)
> Due to its popularity we should solve this during analyze: a starter should
> be a delegate for its dependencies. (in the code I would use the word
> {{delegate}}, not starter as it is too Spring specific)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MDEP-665) Recognize "starters" during analyze
[
https://issues.apache.org/jira/browse/MDEP-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MDEP-665:
---
Issue Type: New Feature (was: Improvement)
> Recognize "starters" during analyze
> ---
>
> Key: MDEP-665
> URL: https://issues.apache.org/jira/browse/MDEP-665
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: analyze
>Reporter: Robert Scholte
>Priority: Major
>
> Springboot introduces the concept of starters, which are a predefined set of
> dependencies.
> It is an empty jar, which acts as just a container for multiple dependencies.
> (it should have been a pom, but that means people suddenly need to add
> {{pom to their dependency)
> Due to its popularity we should solve this during analyze: a starter should
> be a delegate for its dependencies. (in the code I would use the word
> {{delegate}}, not starter as it is too Spring specific)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MDEP-712) Merge two JIRA components for dependency-analyzer
Elliotte Rusty Harold created MDEP-712: -- Summary: Merge two JIRA components for dependency-analyzer Key: MDEP-712 URL: https://issues.apache.org/jira/browse/MDEP-712 Project: Maven Dependency Plugin Issue Type: Task Components: analyze Reporter: Elliotte Rusty Harold Issues for the analyzer have been filed both in MDEP with component analyze and in MSHARED with component maven-dependency-analyzer. Figure out which we want to use, update pom.xml, and move everything there. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-707) Upgrade maven-dependency-analyzer to 1.11.2
[ https://issues.apache.org/jira/browse/MDEP-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156310#comment-17156310 ] Elliotte Rusty Harold commented on MDEP-707: 1.11.2 (or 1.12.0) will need to be released first. > Upgrade maven-dependency-analyzer to 1.11.2 > --- > > Key: MDEP-707 > URL: https://issues.apache.org/jira/browse/MDEP-707 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade > Components: analyze >Affects Versions: 3.1.2 >Reporter: Andreas Dangel >Priority: Major > Fix For: 3.1.3 > > > In order to analyze projects with newer java versions, MSHARED-870 needs to > be completed. > Just updating asm version (as in MDEP-682) is not enough. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MDEP-707) Upgrade maven-dependency-analyzer to 1.11.2
[ https://issues.apache.org/jira/browse/MDEP-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-707: --- Summary: Upgrade maven-dependency-analyzer to 1.11.2 (was: Upgrade maven-dependency-analyzer to 1.1.2) > Upgrade maven-dependency-analyzer to 1.11.2 > --- > > Key: MDEP-707 > URL: https://issues.apache.org/jira/browse/MDEP-707 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade > Components: analyze >Affects Versions: 3.1.2 >Reporter: Andreas Dangel >Priority: Minor > Fix For: 3.1.3 > > > In order to analyze projects with newer java versions, MSHARED-870 needs to > be completed. > Just updating asm version (as in MDEP-682) is not enough. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MDEP-707) Upgrade maven-dependency-analyzer to 1.11.2
[ https://issues.apache.org/jira/browse/MDEP-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-707: --- Priority: Major (was: Minor) > Upgrade maven-dependency-analyzer to 1.11.2 > --- > > Key: MDEP-707 > URL: https://issues.apache.org/jira/browse/MDEP-707 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade > Components: analyze >Affects Versions: 3.1.2 >Reporter: Andreas Dangel >Priority: Major > Fix For: 3.1.3 > > > In order to analyze projects with newer java versions, MSHARED-870 needs to > be completed. > Just updating asm version (as in MDEP-682) is not enough. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MSHARED-916) Require Maven 3+
[ https://issues.apache.org/jira/browse/MSHARED-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MSHARED-916: - Assignee: Elliotte Rusty Harold > Require Maven 3+ > > > Key: MSHARED-916 > URL: https://issues.apache.org/jira/browse/MSHARED-916 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Reporter: Sylwester Lachiewicz >Assignee: Elliotte Rusty Harold >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNGSITE-416) Exercising "Getting Started" gives BUILD FAILURE plus example output issues
[
https://issues.apache.org/jira/browse/MNGSITE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156294#comment-17156294
]
David Pead commented on MNGSITE-416:
I forked from here: [https://github.com/apache/maven-site] and ran locally
today, still seeing the issue.
PR: https://github.com/apache/maven-site/pull/177
> Exercising "Getting Started" gives BUILD FAILURE plus example output issues
> ---
>
> Key: MNGSITE-416
> URL: https://issues.apache.org/jira/browse/MNGSITE-416
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: David Pead
>Priority: Minor
> Attachments: mvnTest.png
>
>
> When following the steps in the Getting Started section, if one uses the
> example archetype as suggested, then tries to compile, in the subsequent step
> you'll be faced with:
> {code:java}
> $ mvn compile
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< com.company.app:my-app
> >---
> [INFO] Building my-app 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ my-app
> ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> /Users/davidpead/dev/mavenGettingStarted/my-app/src/main/resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ my-app ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to
> /Users/davidpead/dev/mavenGettingStarted/my-app/target/classes
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] Source option 5 is no longer supported. Use 6 or later.
> [ERROR] Target option 1.5 is no longer supported. Use 1.6 or later.
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.686 s
> [INFO] Finished at: 2020-07-11T17:32:22+01:00
> [INFO]
>
> {code}
> As the version of the archetype is not set it defaults to 1.0. The resulting
> pom doesn't set the source or target properties so I assume maven defaults to
> 5 / 1.5. The above will happen for any quickstart archetype < 1.3
> Suggest the example is changed to match that of the Maven in 5 mins guide:
> [https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project
>
> |https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project]and
> the pom example too:
> [https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#the-pom]
> Additionally the subsequent steps for test & install show output examples
> that are escaping from the code blocks:
> !mvnTest.png|width=416,height=367!
> This is due the the TEST section output having the closing block hyphens.
> This could be overcome by using more up-to-date output. What's currently
> there reflects an old version.
> PR cometh...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNGSITE-416) Exercising "Getting Started" gives BUILD FAILURE plus example output issues
[
https://issues.apache.org/jira/browse/MNGSITE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156280#comment-17156280
]
Michael Osipov commented on MNGSITE-416:
Can you retry with Maven master? I have several open issues which should
address this, but am not sure.
> Exercising "Getting Started" gives BUILD FAILURE plus example output issues
> ---
>
> Key: MNGSITE-416
> URL: https://issues.apache.org/jira/browse/MNGSITE-416
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: David Pead
>Priority: Minor
> Attachments: mvnTest.png
>
>
> When following the steps in the Getting Started section, if one uses the
> example archetype as suggested, then tries to compile, in the subsequent step
> you'll be faced with:
> {code:java}
> $ mvn compile
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< com.company.app:my-app
> >---
> [INFO] Building my-app 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ my-app
> ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> /Users/davidpead/dev/mavenGettingStarted/my-app/src/main/resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ my-app ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to
> /Users/davidpead/dev/mavenGettingStarted/my-app/target/classes
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] Source option 5 is no longer supported. Use 6 or later.
> [ERROR] Target option 1.5 is no longer supported. Use 1.6 or later.
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.686 s
> [INFO] Finished at: 2020-07-11T17:32:22+01:00
> [INFO]
>
> {code}
> As the version of the archetype is not set it defaults to 1.0. The resulting
> pom doesn't set the source or target properties so I assume maven defaults to
> 5 / 1.5. The above will happen for any quickstart archetype < 1.3
> Suggest the example is changed to match that of the Maven in 5 mins guide:
> [https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project
>
> |https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project]and
> the pom example too:
> [https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#the-pom]
> Additionally the subsequent steps for test & install show output examples
> that are escaping from the code blocks:
> !mvnTest.png|width=416,height=367!
> This is due the the TEST section output having the closing block hyphens.
> This could be overcome by using more up-to-date output. What's currently
> there reflects an old version.
> PR cometh...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6932) NullPointerException if no Package is defined for the current class
[
https://issues.apache.org/jira/browse/MNG-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156277#comment-17156277
]
Michael Osipov commented on MNG-6932:
-
OK, granted. So instead of using the manifest data, using
{{RuntimeInformation}} seems right for me. But for this, we need to remove the
static final variable and move it to a method on the interface. WDYT?
> NullPointerException if no Package is defined for the current class
> ---
>
> Key: MNG-6932
> URL: https://issues.apache.org/jira/browse/MNG-6932
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.6.3
> Environment: Windows 10, Java 8, custom classloading
>Reporter: Bence Sipka
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.7.x-candidate
>
>
> When the maven-resolver and related classes are used with a {{ClassLoader}}
> that doesn't define a java.lang.Package object for the loaded classes, the
> library throws a {{NullPointerException}}.
> Scenario: I'm using the maven-resolver classes to resolver artifacts from
> various repositories. I package the app, and deploy it to a custom
> environment where the {{ClassLoader}} for the app doesn't define a
> {{Package}} for the loaded classes. In these cases, when the maven-resolver
> library calls {{this.getClass().getPackage().getImplementationVersion()}}
> then a {{NullPointerException}} will occurr.
> The following classes are affected:
> {{DefaultSuperPomProvider.getSuperModel():81}}
> {{DefaultReportingConverter.:56}}
> Code around the locations:
> {code:java}
> String modelId = "org.apache.maven:maven-model-builder:"
> + this.getClass().getPackage().getImplementationVersion() + ":super-pom";
> InputSource inputSource = new InputSource();
> inputSource.setModelId( modelId );
> {code}
> This exception makes the library unportable to different environments.
> Workaround:
> Implement a custom variant of the above classes that circumvent these parts
> of the code.
> Possible solution:
> Null checks, and hard coding the version number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MNGSITE-416) Exercising "Getting Started" gives BUILD FAILURE plus example output issues
David Pead created MNGSITE-416:
--
Summary: Exercising "Getting Started" gives BUILD FAILURE plus
example output issues
Key: MNGSITE-416
URL: https://issues.apache.org/jira/browse/MNGSITE-416
Project: Maven Project Web Site
Issue Type: Bug
Reporter: David Pead
Attachments: mvnTest.png
When following the steps in the Getting Started section, if one uses the
example archetype as suggested, then tries to compile, in the subsequent step
you'll be faced with:
{code:java}
$ mvn compile
[INFO] Scanning for projects...
[INFO]
[INFO] ---< com.company.app:my-app >---
[INFO] Building my-app 1.0-SNAPSHOT
[INFO] [ jar ]-
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ my-app ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/Users/davidpead/dev/mavenGettingStarted/my-app/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ my-app ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 1 source file to
/Users/davidpead/dev/mavenGettingStarted/my-app/target/classes
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR] Source option 5 is no longer supported. Use 6 or later.
[ERROR] Target option 1.5 is no longer supported. Use 1.6 or later.
[INFO] 2 errors
[INFO] -
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 0.686 s
[INFO] Finished at: 2020-07-11T17:32:22+01:00
[INFO]
{code}
As the version of the archetype is not set it defaults to 1.0. The resulting
pom doesn't set the source or target properties so I assume maven defaults to 5
/ 1.5. The above will happen for any quickstart archetype < 1.3
Suggest the example is changed to match that of the Maven in 5 mins guide:
[https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project
|https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#creating-a-project]and
the pom example too:
[https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html#the-pom]
Additionally the subsequent steps for test & install show output examples that
are escaping from the code blocks:
!mvnTest.png|width=416,height=367!
This is due the the TEST section output having the closing block hyphens. This
could be overcome by using more up-to-date output. What's currently there
reflects an old version.
PR cometh...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6932) NullPointerException if no Package is defined for the current class
[
https://issues.apache.org/jira/browse/MNG-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156245#comment-17156245
]
Herve Boutemy commented on MNG-6932:
bq. Do you see any benefit in having the Maven version in the identifier?
yes, there is a benefit: given version of the plugin depends on Maven core
version (in the future, even more than in the past), yes, showing which version
of Maven core injected the plugin version is useful
> NullPointerException if no Package is defined for the current class
> ---
>
> Key: MNG-6932
> URL: https://issues.apache.org/jira/browse/MNG-6932
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.6.3
> Environment: Windows 10, Java 8, custom classloading
>Reporter: Bence Sipka
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.7.x-candidate
>
>
> When the maven-resolver and related classes are used with a {{ClassLoader}}
> that doesn't define a java.lang.Package object for the loaded classes, the
> library throws a {{NullPointerException}}.
> Scenario: I'm using the maven-resolver classes to resolver artifacts from
> various repositories. I package the app, and deploy it to a custom
> environment where the {{ClassLoader}} for the app doesn't define a
> {{Package}} for the loaded classes. In these cases, when the maven-resolver
> library calls {{this.getClass().getPackage().getImplementationVersion()}}
> then a {{NullPointerException}} will occurr.
> The following classes are affected:
> {{DefaultSuperPomProvider.getSuperModel():81}}
> {{DefaultReportingConverter.:56}}
> Code around the locations:
> {code:java}
> String modelId = "org.apache.maven:maven-model-builder:"
> + this.getClass().getPackage().getImplementationVersion() + ":super-pom";
> InputSource inputSource = new InputSource();
> inputSource.setModelId( modelId );
> {code}
> This exception makes the library unportable to different environments.
> Workaround:
> Implement a custom variant of the above classes that circumvent these parts
> of the code.
> Possible solution:
> Null checks, and hard coding the version number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6562) WARN if plugins injected by default lifecycle bindings don't have their version locked in pom.xml or parent
[
https://issues.apache.org/jira/browse/MNG-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156244#comment-17156244
]
Herve Boutemy commented on MNG-6562:
going to MNG-6932, since this is where the issue is open
> WARN if plugins injected by default lifecycle bindings don't have their
> version locked in pom.xml or parent
> ---
>
> Key: MNG-6562
> URL: https://issues.apache.org/jira/browse/MNG-6562
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
>Affects Versions: 3.6.0
>Reporter: Herve Boutemy
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.7.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, when building from a basic pom.xml:
> {code:xml}
> 4.0.0
> com.mycompany.app
> my-app
> 1.0-SNAPSHOT
> {code}
> many plugins are used, but their version is not locked by the user: the
> default plugins versions depend on Maven version used, which is not stable
> over different Maven versions.
> Adding a warning for this stability issue will help users know that they need
> to lock down plugins versions in their pom (or parent), something like:
> {noformat}[WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for com.mycompany.app:my-app:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins
> [maven-install-plugin, maven-resources-plugin, maven-surefire-plugin,
> maven-compiler-plugin, maven-jar-plugin, maven-deploy-plugin,
> maven-site-plugin], you should define versions in pluginManagement section of
> your pom.xml or parent
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6562) WARN if plugins injected by default lifecycle bindings don't have their version locked in pom.xml or parent
[
https://issues.apache.org/jira/browse/MNG-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156232#comment-17156232
]
Michael Osipov commented on MNG-6562:
-
[~hboutemy], right. Should I move the discussion to MNG-6600? Do you see any
benefti in having the Maven version in the identifier?
> WARN if plugins injected by default lifecycle bindings don't have their
> version locked in pom.xml or parent
> ---
>
> Key: MNG-6562
> URL: https://issues.apache.org/jira/browse/MNG-6562
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
>Affects Versions: 3.6.0
>Reporter: Herve Boutemy
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.7.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, when building from a basic pom.xml:
> {code:xml}
> 4.0.0
> com.mycompany.app
> my-app
> 1.0-SNAPSHOT
> {code}
> many plugins are used, but their version is not locked by the user: the
> default plugins versions depend on Maven version used, which is not stable
> over different Maven versions.
> Adding a warning for this stability issue will help users know that they need
> to lock down plugins versions in their pom (or parent), something like:
> {noformat}[WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for com.mycompany.app:my-app:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins
> [maven-install-plugin, maven-resources-plugin, maven-surefire-plugin,
> maven-compiler-plugin, maven-jar-plugin, maven-deploy-plugin,
> maven-site-plugin], you should define versions in pluginManagement section of
> your pom.xml or parent
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
