[jira] [Commented] (MANTRUN-224) Require Java 8

2020-09-15 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MANTRUN-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196709#comment-17196709
 ] 

Hudson commented on MANTRUN-224:


Build succeeded in Jenkins: Maven » Maven TLP » maven-antrun-plugin » master #22

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-antrun-plugin/job/master/22/

> Require Java 8
> --
>
> Key: MANTRUN-224
> URL: https://issues.apache.org/jira/browse/MANTRUN-224
> Project: Maven Antrun Plugin
>  Issue Type: Task
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-shade-plugin] asfgit closed pull request #71: (doc) Dead link for source repo

2020-09-15 Thread GitBox


asfgit closed pull request #71:
URL: https://github.com/apache/maven-shade-plugin/pull/71


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-doxia-converter] dependabot[bot] opened a new pull request #4: Bump jacoco-maven-plugin from 0.8.5 to 0.8.6

2020-09-15 Thread GitBox


dependabot[bot] opened a new pull request #4:
URL: https://github.com/apache/maven-doxia-converter/pull/4


   Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.5 to 
0.8.6.
   
   Release notes
   Sourced from https://github.com/jacoco/jacoco/releases";>jacoco-maven-plugin's 
releases.
   
   0.8.6
   New Features
   
   JaCoCo now officially supports Java 14.
   Experimental support for Java 15 class files (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/992";>#992).
   Experimental support for Java 16 class files (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1059";>#1059).
   Methods toString, hashCode and 
equals generated by compiler for records are filtered out during 
generation of report (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/990";>#990).
   Bridge methods are filtered out during generation of report (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1010";>#1010).
   Methods generated by Kotlin compiler for non-overridden non-abstract 
methods of interfaces are filtered out during generation of report (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1012";>#1012).
   Branches added by the Kotlin compiler version 1.3.60 for suspending 
functions with tail call optimization are filtered out during generation of 
report (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1016";>#1016).
   
   Fixed bugs
   
   Compression method of zip entries is now preserved when instrumenting 
archives. This allows to use JaCoCo with frameworks that expect uncompressed 
entries (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1018";>#1018).
   
   Non-functional Changes
   
   Support for Pack200 was removed in JDK 14. JaCoCo will now throw a 
detailed exception when Pack200 archives are processed with the latest JDKs 
(GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/984";>#984).
   JaCoCo now depends on ASM 8.0.1 (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1032";>#1032,
 https://github-redirect.dependabot.com/jacoco/jacoco/issues/1043";>#1043).
   
   API Changes
   
   URLStreamHandlerRuntime removed (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/471";>#471).
   
   
   
   
   Commits
   
   https://github.com/jacoco/jacoco/commit/492f4213aaee85915b835047b8808eb16f3994fa";>492f421
 Prepare release 0.8.6
   https://github.com/jacoco/jacoco/commit/b404a6b3eca7f39156d4ad3a98576a2d7bfa06af";>b404a6b
 improve english grammer (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1068";>#1068)
   https://github.com/jacoco/jacoco/commit/6ceb0193d6bfc06a684f0063627bf3f047b15ad5";>6ceb019
 Visual cleanup of JDK/compilation target table (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1034";>#1034)
   https://github.com/jacoco/jacoco/commit/2a75e0d6777269eb031d0549ff85feb75684a926";>2a75e0d
 Remove URLStreamHandlerRuntime (https://github-redirect.dependabot.com/jacoco/jacoco/issues/471";>#471)
   https://github.com/jacoco/jacoco/commit/1485a4192d6afee7dd5449d4a0e28ca184efd887";>1485a41
 Add experimental support for Java 16 (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1059";>#1059)
   https://github.com/jacoco/jacoco/commit/d60a5b23ba6816c134218550c1d27cf4b304";>d60a5b2
 Fix validation test for Java 15 (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1052";>#1052)
   https://github.com/jacoco/jacoco/commit/c53d987087a1a1fa8d9b609f9c21abdcb5ddfd56";>c53d987
 Upgrade ASM to 8.0.1 (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1043";>#1043)
   https://github.com/jacoco/jacoco/commit/1c5601bba5bf195a5f9b09a87cb5d2152857bbb7";>1c5601b
 Happy birthday JDK 14! (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1033";>#1033)
   https://github.com/jacoco/jacoco/commit/ed4653ee8b814c744aeb6d8aba9545fd9321daa8";>ed4653e
 Upgrade ASM to 8.0 (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1032";>#1032)
   https://github.com/jacoco/jacoco/commit/bbff1f5bd1ea54582e81c94947a34468e0f73d0d";>bbff1f5
 Add link about integration of JaCoCo into Codacy (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1028";>#1028)
   Additional commits viewable in https://github.com/jacoco/jacoco/compare/v0.8.5...v0.8.6";>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.jacoco:jacoco-maven-plugin&package-manager=maven&previous-version=0.8.5&new-version=0.8.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   

[GitHub] [maven-indexer] dependabot[bot] closed pull request #66: Bump version.spring from 4.0.6.RELEASE to 5.2.8.RELEASE

2020-09-15 Thread GitBox


dependabot[bot] closed pull request #66:
URL: https://github.com/apache/maven-indexer/pull/66


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-indexer] dependabot[bot] commented on pull request #66: Bump version.spring from 4.0.6.RELEASE to 5.2.8.RELEASE

2020-09-15 Thread GitBox


dependabot[bot] commented on pull request #66:
URL: https://github.com/apache/maven-indexer/pull/66#issuecomment-693155543


   Superseded by #69.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-indexer] dependabot[bot] opened a new pull request #69: Bump version.spring from 4.0.6.RELEASE to 5.2.9.RELEASE

2020-09-15 Thread GitBox


dependabot[bot] opened a new pull request #69:
URL: https://github.com/apache/maven-indexer/pull/69


   Bumps `version.spring` from 4.0.6.RELEASE to 5.2.9.RELEASE.
   Updates `spring-beans` from 4.0.6.RELEASE to 5.2.9.RELEASE
   
   Release notes
   Sourced from https://github.com/spring-projects/spring-framework/releases";>spring-beans's
 releases.
   
   v5.2.9.RELEASE
   :star: New Features
   
   HttpHeaders.setContentDispositionFormData should ignore empty filename 
https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25769";>#25769
   StringDecoder does not provide a way to configure the default charset https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25762";>#25762
   MimeMessageHelper.addAttachment: configurable encoding of attachment 
filename https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25755";>#25755
   Current log level not checked by LogAccessor supplier-enabled logging 
methods https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25741";>#25741
   PropertiesLoaderSupport should ignore socket/connect exceptions as well 
https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25717";>#25717
   Avoid repeated calls to getPathWithinApplication from 
UrlPathHelper.getLookupPathForRequest https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25669";>#25669
   Avoid full singleton lock for 
DefaultSingletonBeanRegistry.getSingleton(beanName, false) https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25667";>#25667
   XStreamMarshaller should avoid direct use of CompositeClassLoader which 
is not exported by XStream in OSGi https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25662";>#25662
   Avoid LinkedList performance issues through use of ArrayDeque https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25652";>#25652
   Introduce createContext() factory method in AbstractGenericContextLoader 
https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/25600";>#25600
   Declare MessagePostProcessor as a @FunctionalInterface https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/25571";>#25571
   Assert preconditions for MergedAnnotations.from() factory methods https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25568";>#25568
   Provide access to AbstractRoutingDataSource's resolved target 
DataSources https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25544";>#25544
   Possible optimization in UrlResource https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25531";>#25531
   Refine use of substring operations https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/25445";>#25445
   Cache abstraction does not log hit / miss for synchronized access https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25248";>#25248
   
   :beetle: Bug Fixes
   
   Issue with Forwarded Header and Multiple Values https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25737";>#25737
   CallMetaDataContext.reconcileParameters overwrites cursor name https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25707";>#25707
   VerifyErrors when using SpEL compilation with Thymeleaf when invoking a 
default method defined in an interface https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25706";>#25706
   SQLErrorCodesFactory.getErrorCodes(DataSource) returns empty error codes 
if access to transactional connection fails https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25681";>#25681
   Make "org.springframework.util.unit.DataSize" class 
Serializable https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25675";>#25675
   Joda-Time presence check fails to detect Joda-Time 2.x specifically https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25655";>#25655
   Regression in SimpleThreadScope introduced in 5.2.7 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25618";>#25618
   Potential integer overflow in 
ExecutorConfigurationSupport.setAwaitTerminationSeconds(int) and 
AbstractResourceBasedMessageSource.setCacheSeconds(int) https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25613";>#25613
   Remove session on 4xx response from WebSocket handshake https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/25608";>#25608
   spring-jdbc don't set out parameter name from metadata for Postgresql 
function after issue#25399 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/25588";>#25588
   FileUrlResource isWritable method returns true if URL protocol is not 
indicatin

[jira] [Commented] (SUREFIRE-1841) no longer finds tests starting with 3.0.0-M4

2020-09-15 Thread BJ Cardon (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196512#comment-17196512
 ] 

BJ Cardon commented on SUREFIRE-1841:
-

Hello, if I find some time in the near future I can try to look into it further 
from a code perspective. However, I did create a small application example that 
exhibits the same behavior.

[https://github.com/cardonator/demo]

In this project, if you run 
{code:java}
mvn test -Pintegration -pl demo-integration
{code}

You will see that the TestSuite is discovered and the tests are run. This is on 
Surefire 3.0.0-M3. If you change to 3.0.0-M4 or higher and run the same 
command, it will not find the TestSuite at all or run any tests.

>  no longer finds tests starting with 3.0.0-M4
> 
>
> Key: SUREFIRE-1841
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1841
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: TestNG support
>Affects Versions: 3.0.0-M4
>Reporter: BJ Cardon
>Priority: Major
>
> Hello. I have a fairly simple multi-module project where I'm using the 
> surefire plugin to execute a series of integration tests in one of the 
> modules. I am doing this by defining a profile in the module that runs one of 
> my suite XML files.
> Here is my profile definition in the POM.
> {noformat}
> 
> acceptance
> 
> 
> 
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.0.0-M4
> 
> false
> 
> 
> src/test/resources/jenkins/acceptance-testng.xml
> 
> 
> 
> 
> 
> {noformat}
> In previous versions of the plugin, including in 3.0.0-M3, this works and the 
> suite is found and executed. In 3.0.0-M4, the test suite is not found and the 
> tests don't run at all. The same behavior is observed in 3.0.0-M5.
> Here is my `acceptance-testng.xml` file
> {noformat}
> https://testng.org/testng-1.0.dtd"; >
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>  name="com.company.app.integration.suite.rest.AppRestErrorTest"/>
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>  name="com.company.app.integration.suite.vendor.VendorRestTest"/>
>  name="com.company.app.integration.suite.vendor.VendorRestErrorTest"/>
>  name="com.company.app.integration.suite.vendor.VendorAuthTest"/>
>  name="com.company.app.integration.suite.vendor.VendorLoadTest"/>
> 
> 
> {noformat}
> As stated above, this broke sometime between 3.0.0-M3 and 3.0.0-M4. I tried 
> looking through the changelog (on a tangent, the changelogs linked from the 
> ASF page require creating an account in Jira which seems odd) but it seems 
> like a number of fairly large changes were made in 3.0.0-M4 that could have 
> been to blame for this change in behavior.
> Let me know if I can provide any additional context.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-shade-plugin] rfscholte commented on a change in pull request #71: (doc) Dead link for source repo

2020-09-15 Thread GitBox


rfscholte commented on a change in pull request #71:
URL: https://github.com/apache/maven-shade-plugin/pull/71#discussion_r488861984



##
File path: src/site/apt/index.apt.vm
##
@@ -50,7 +50,7 @@ ${project.name}
   concern. Especially for fixing bugs it is crucial that the developers can 
reproduce your problem. For this reason,
   entire debug logs, POMs or most preferably little demo projects attached to 
the issue are very much appreciated.
   Of course, patches are welcome, too. Contributors can check out the project 
from our
-  {{{./source-repository.html}source repository}} and will find supplementary 
information in the
+  {{{https://github.com/apache/maven-shade-plugin}source repository}} and will 
find supplementary information in the

Review comment:
   It should be `scm.html`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-shade-plugin] rfscholte commented on a change in pull request #71: (doc) Dead link for source repo

2020-09-15 Thread GitBox


rfscholte commented on a change in pull request #71:
URL: https://github.com/apache/maven-shade-plugin/pull/71#discussion_r488861984



##
File path: src/site/apt/index.apt.vm
##
@@ -50,7 +50,7 @@ ${project.name}
   concern. Especially for fixing bugs it is crucial that the developers can 
reproduce your problem. For this reason,
   entire debug logs, POMs or most preferably little demo projects attached to 
the issue are very much appreciated.
   Of course, patches are welcome, too. Contributors can check out the project 
from our
-  {{{./source-repository.html}source repository}} and will find supplementary 
information in the
+  {{{https://github.com/apache/maven-shade-plugin}source repository}} and will 
find supplementary information in the

Review comment:
   It should be {{scm.html}}





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (MNG-6983) Plugin not executed when using pluginManagement and variable in groupId

2020-09-15 Thread Paul Pazderski (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196179#comment-17196179
 ] 

Paul Pazderski commented on MNG-6983:
-

No comments? Whatever you think of the possible fix I would appreciate a 
comment on the failing example I attached.

After I noticed it worked in 3.6.2 I bisect the issue and came to 
[3a80ae08aac785deb61e417f82560cb06209d5bc|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=3a80ae08aac785deb61e417f82560cb06209d5bc]
 as causing commit. Apparently there is a difference between 
{{StringSearchModelInterpolator}} and {{StringVisitorModelInterpolator}} which 
make this example fail.

> Plugin not executed when using pluginManagement and variable in groupId
> ---
>
> Key: MNG-6983
> URL: https://issues.apache.org/jira/browse/MNG-6983
> Project: Maven
>  Issue Type: Bug
>  Components: core, Plugins and Lifecycle
>Affects Versions: 3.6.3
>Reporter: Paul Pazderski
>Priority: Major
> Attachments: pluginNotExecuted.zip
>
>
> I have a project build with maven where some maven plugins are not executed 
> without any warning or error shown in output.
> I was could reproduce the issue with a minimal example. (see attachment)
> The expected result of this example is to get the one source file compiled if 
> you invoke {{mvn compile}}.
> If I run this example using Maven 3.6.3 the following output appears:
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO] -< org.example:child 
> >--
> [INFO] Building child 0.0.1-SNAPSHOT
> [INFO] [ jar 
> ]-
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ child 
> ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> [...]\pluginNotExecuted\src\main\resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ child ---
> [INFO] No sources to compile
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time:  0.644 s
> [INFO] Finished at: [...]
> [INFO] 
> 
> {noformat}
> Notice that there is no execution of the build-helper-maven-plugin (and as 
> consequence no source compiled) and no indication why it is missing.
> From what I've found the problem seem to be the usage of variable in the 
> plugins groupId. If you replace either the variable in parent- or child-pom 
> with the actual value the build shows a warning
> {noformat}
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model 
> for org.example:child:jar:0.0.1-SNAPSHOT
> [WARNING] 'build.plugins.plugin.version' for 
> org.codehaus.mojo:build-helper-maven-plugin is missing. @ line 16, column 21
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
> {noformat}
> If you replace both variables with the actual value everything works as 
> expected.
>  
> I investigated the problem further and will provide more details with a pull 
> request for a possible fix.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6978) Setting inherited to false on execution has no effect

2020-09-15 Thread Michael Boyles (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196173#comment-17196173
 ] 

Michael Boyles commented on MNG-6978:
-

Should be filed under Enforcer Plugin 
https://issues.apache.org/jira/projects/MENFORCER/issues/

> Setting inherited to false on execution has no effect
> -
>
> Key: MNG-6978
> URL: https://issues.apache.org/jira/browse/MNG-6978
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.3
>Reporter: László Stahorszki
>Priority: Major
>
> Minimal reproducible example
> [https://github.com/rolaca11/maven-inherited-min/tree/master]
> When the execution configuration comes from a  tag, 
> disabling inheritance doesn't work on subsequent child projects.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNGSITE-425) Deadlink showed on page

2020-09-15 Thread Michael Boyles (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196166#comment-17196166
 ] 

Michael Boyles commented on MNGSITE-425:


This is filed under the wrong project.

In any case, raised a PR here. 
https://github.com/apache/maven-shade-plugin/pull/71/commits 

> Deadlink showed on page
> ---
>
> Key: MNGSITE-425
> URL: https://issues.apache.org/jira/browse/MNGSITE-425
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: Zhenbo Li
>Priority: Major
>
> I was reading the document 
> [https://maven.apache.org/plugins/maven-shade-plugin/]
> Content Contributors can check out the project from our [source 
> repository|https://maven.apache.org/plugins/maven-shade-plugin/source-repository.html]
>   pointing to an invalid link 
> https://maven.apache.org/plugins/maven-shade-plugin/source-repository.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-shade-plugin] michaelboyles opened a new pull request #71: (doc) Dead link for source repo

2020-09-15 Thread GitBox


michaelboyles opened a new pull request #71:
URL: https://github.com/apache/maven-shade-plugin/pull/71


   The link for source repo was dead
   
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MSHADE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MSHADE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (MCOMPILER-428) Documentation regarding useIncrementalCompilation not very useful

2020-09-15 Thread Michael Boyles (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196126#comment-17196126
 ] 

Michael Boyles commented on MCOMPILER-428:
--

I suspect your description may be inaccurate. As per the comments on that 
ticket by Robert:
"if 1 file has been changed or removed, all files are deleted and recompiled"

As per your description: "any source file was **added**, removed or changed".

I don't know whether this optimization actually exists, but it seems plausible: 
If the only change is purely adding a class or classes, and no other existing 
classes changed, we can infer that the whole module does not need recompiling.

Suppose we add a new Spring @Component. It would be sufficient to just compile 
this new class, and Spring's DI will pick it up at runtime. Recompiling 
everything else when we know they haven't changed would be a waste of time.

> Documentation regarding useIncrementalCompilation not very useful
> -
>
> Key: MCOMPILER-428
> URL: https://issues.apache.org/jira/browse/MCOMPILER-428
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Thomas Bracher
>Priority: Minor
>  Labels: documentation
>
> As of today, maven-compiler-plugin documentation for 
> useIncrementalCompilation says: "to enable/disable incrementation compilation 
> feature". Since there is no documentation of said feature, users will have to 
> either:
> 1) take a guess at how the feature behaves
> 2) painfully read the plugin code to understand what it does
> This is less than optimal and lead to misunderstanding, like this comment 
> https://issues.apache.org/jira/browse/MCOMPILER-205?focusedCommentId=14428972&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14428972
>  
> So far the most explicit documentation I have found is in answer of a 
> stackoverflow issue: https://stackoverflow.com/a/49700942
> I think it would benefit a lot of users to understand the implication of both 
> options of this flag. I am trying to submit a PR providing an example of text.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DOXIA-606) fix javadoc issues with JDK 8 when generating documentation

2020-09-15 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196053#comment-17196053
 ] 

ASF GitHub Bot commented on DOXIA-606:
--

asfgit closed pull request #38:
URL: https://github.com/apache/maven-doxia/pull/38


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> fix javadoc issues with JDK 8 when generating documentation
> ---
>
> Key: DOXIA-606
> URL: https://issues.apache.org/jira/browse/DOXIA-606
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: 1.9.1
>Reporter: Herve Boutemy
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 1.9.2
>
>
> when building Doxia documentation with JDK 8:
> {noformat}mvn -Preporting site site:stage{noformat}
> some javadoc issues make site generation failure
> I had to build Doxia 1.9.1 release documentation with JDK 7, even if I built 
> the artifacts with JDK 8...
> for next release, it would be nice to not hit this issue any more



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-6989) The page "Introduction to the Dependency Mechanism" shows deprecated practices

2020-09-15 Thread Michael Boyles (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196034#comment-17196034
 ] 

Michael Boyles commented on MNG-6989:
-

It's here: 
https://github.com/apache/maven-site/blob/master/content/apt/guides/introduction/introduction-to-dependency-mechanism.apt

> The page "Introduction to the Dependency Mechanism" shows deprecated practices
> --
>
> Key: MNG-6989
> URL: https://issues.apache.org/jira/browse/MNG-6989
> Project: Maven
>  Issue Type: Bug
>  Components: Documentation: Introductions
>Affects Versions: 3.6.3
>Reporter: Mikaël Barbero
>Priority: Major
>
> Page URL: 
> https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html
> The section "[Bill of 
> Materials|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#bill-of-materials-bom-poms]";
>  explains that one should use some properties to define submodules versions 
> (e.g., project1Version). Defining versions this way lead to publish pom files 
> with $variable in in their . This a bad practice that Maven warns 
> about during builds. I think this should not be advocated in an introduction 
> guide. AFAICT, the "standard" way for handling a bom setup is to have all 
> modules inheriting their versions from the parent pom.
> If one committer is willing to point me where the code of this guide is 
> stored, I may be able to submit a patch. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MANTRUN-227) Upgrade Ant to 1.10.8

2020-09-15 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MANTRUN-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196028#comment-17196028
 ] 

Hudson commented on MANTRUN-227:


Build failed in Jenkins: Maven » Maven TLP » maven-antrun-plugin » master #21

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-antrun-plugin/job/master/21/

> Upgrade Ant to 1.10.8
> -
>
> Key: MANTRUN-227
> URL: https://issues.apache.org/jira/browse/MANTRUN-227
> Project: Maven Antrun Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7, 1.8, 3.0.0
>Reporter: Sylwester Lachiewicz
>Priority: Major
>  Labels: Security
> Fix For: 3.1.0
>
>
> Versions Affected: Apache Ant 1.1 to 1.9.14 and 1.10.0 to 1.10.7
>  
> *Medium: insecure temporary file vulnerability* 
> [CVE-2020-1945|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-1945]
> Apache Ant uses the default temporary directory identified by the Java system 
> property {{java.io.tmpdir}} for several tasks and may thus leak sensitive 
> information. The fixcrlf and replaceregexp tasks also copy files from the 
> temporary directory back into the build tree allowing an attacker to inject 
> modified source files into the build process.
> *Mitigation:* Ant users of versions 1.1 to 1.9.14 and 1.10.0 to 1.10.7 should 
> set the java.io.tmpdir system property to point to a directory only readable 
> and writable by the current user prior to running Ant.
> Users of versions 1.9.15 and 1.10.8 can use the Ant property {{ant.tmpfile}} 
> instead. Users of Ant 1.10.8 can rely on Ant protecting the temporary files 
> if the underlying filesystem allows it, but we still recommend using a 
> private temporary directory instead.
> This was fixed in revisions 
> [9c1f4d905da59bf446570ac28df5b68a37281f35|https://gitbox.apache.org/repos/asf?p=ant.git;a=commit;h=9c1f4d905da59bf446570ac28df5b68a37281f35],
>  
> [041b058c7bf10a94d56db3ca9dba38cf90ab9943|https://gitbox.apache.org/repos/asf?p=ant.git;a=commit;h=041b058c7bf10a94d56db3ca9dba38cf90ab9943]
>  and 
> [a8645a151bc706259fb1789ef587d05482d98612|https://gitbox.apache.org/repos/asf?p=ant.git;a=commit;h=a8645a151bc706259fb1789ef587d05482d98612].
> This was first reported to the Security Team on 29 January 2020 and made 
> public on 13 May 2020
> Affects: until 1.10.7



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-antrun-plugin] dependabot[bot] commented on pull request #8: Bump modello-maven-plugin from 1.10.0 to 1.11

2020-09-15 Thread GitBox


dependabot[bot] commented on pull request #8:
URL: https://github.com/apache/maven-antrun-plugin/pull/8#issuecomment-692610324


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-antrun-plugin] asfgit closed pull request #8: Bump modello-maven-plugin from 1.10.0 to 1.11

2020-09-15 Thread GitBox


asfgit closed pull request #8:
URL: https://github.com/apache/maven-antrun-plugin/pull/8


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-antrun-plugin] dependabot[bot] commented on pull request #9: Bump junit-jupiter-engine from 5.6.2 to 5.7.0

2020-09-15 Thread GitBox


dependabot[bot] commented on pull request #9:
URL: https://github.com/apache/maven-antrun-plugin/pull/9#issuecomment-692609725


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-antrun-plugin] asfgit closed pull request #9: Bump junit-jupiter-engine from 5.6.2 to 5.7.0

2020-09-15 Thread GitBox


asfgit closed pull request #9:
URL: https://github.com/apache/maven-antrun-plugin/pull/9


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (MEAR-284) Tests fail at HEAD on Linux

2020-09-15 Thread Marat Abrarov (Jira)


[ 
https://issues.apache.org/jira/browse/MEAR-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195993#comment-17195993
 ] 

Marat Abrarov commented on MEAR-284:


This issue looks like the only blocker for release of 3.1.0 version. Is 
somebody working on that workaround?

> Tests fail at HEAD on Linux
> ---
>
> Key: MEAR-284
> URL: https://issues.apache.org/jira/browse/MEAR-284
> Project: Maven Ear Plugin
>  Issue Type: Test
>Affects Versions: 3.1.0
>Reporter: Elliotte Rusty Harold
>Priority: Blocker
> Fix For: 3.1.0
>
>
> Possibly on other systems:
> {noformat}[INFO] Building: packaging-includes/pom.xml
> [INFO] run post-build script verify.bsh
> [INFO]   The post-build script did not succeed. Missing archive entry: 
> META-INF/application.xml
> [INFO]   packaging-includes/pom.xml  FAILED (1.4 s)
> ...
> [ERROR] The following builds failed:
> [ERROR] *  packaging-includes/pom.xml
> [ERROR] *  basic/pom.xml{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (MEAR-284) Tests fail at HEAD on Linux

2020-09-15 Thread Marat Abrarov (Jira)


[ 
https://issues.apache.org/jira/browse/MEAR-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195993#comment-17195993
 ] 

Marat Abrarov edited comment on MEAR-284 at 9/15/20, 9:00 AM:
--

This issue looks like the only blocker for release of 3.1.0 version. Is 
somebody working on [that 
workaround|https://issues.apache.org/jira/browse/MEAR-284?focusedCommentId=17194817&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17194817]?


was (Author: abrarovm):
This issue looks like the only blocker for release of 3.1.0 version. Is 
somebody working on that workaround?

> Tests fail at HEAD on Linux
> ---
>
> Key: MEAR-284
> URL: https://issues.apache.org/jira/browse/MEAR-284
> Project: Maven Ear Plugin
>  Issue Type: Test
>Affects Versions: 3.1.0
>Reporter: Elliotte Rusty Harold
>Priority: Blocker
> Fix For: 3.1.0
>
>
> Possibly on other systems:
> {noformat}[INFO] Building: packaging-includes/pom.xml
> [INFO] run post-build script verify.bsh
> [INFO]   The post-build script did not succeed. Missing archive entry: 
> META-INF/application.xml
> [INFO]   packaging-includes/pom.xml  FAILED (1.4 s)
> ...
> [ERROR] The following builds failed:
> [ERROR] *  packaging-includes/pom.xml
> [ERROR] *  basic/pom.xml{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (MNG-6989) The page "Introduction to the Dependency Mechanism" shows deprecated practices

2020-09-15 Thread Jira
Mikaël Barbero created MNG-6989:
---

 Summary: The page "Introduction to the Dependency Mechanism" shows 
deprecated practices
 Key: MNG-6989
 URL: https://issues.apache.org/jira/browse/MNG-6989
 Project: Maven
  Issue Type: Bug
  Components: Documentation: Introductions
Affects Versions: 3.6.3
Reporter: Mikaël Barbero


Page URL: 
https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html

The section "[Bill of 
Materials|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#bill-of-materials-bom-poms]";
 explains that one should use some properties to define submodules versions 
(e.g., project1Version). Defining versions this way lead to publish pom files 
with $variable in in their . This a bad practice that Maven warns 
about during builds. I think this should not be advocated in an introduction 
guide. AFAICT, the "standard" way for handling a bom setup is to have all 
modules inheriting their versions from the parent pom.

If one committer is willing to point me where the code of this guide is stored, 
I may be able to submit a patch. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)