[jira] [Commented] (MNG-7008) skip reactor logging
[
https://issues.apache.org/jira/browse/MNG-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238583#comment-17238583
]
Delany commented on MNG-7008:
-
{{mvn install -T1 -Dorg.slf4j.simpleLogger.showThreadName=true | grep -v
--color=always '\[main\]' | sed 's:[^]]*] ::'}}
> skip reactor logging
>
>
> Key: MNG-7008
> URL: https://issues.apache.org/jira/browse/MNG-7008
> Project: Maven
> Issue Type: Improvement
> Components: Logging
>Affects Versions: 3.6.3
>Reporter: Delany
>Priority: Minor
>
> Can we have a way to skip reactor logging, i.e. the reactor build order
> and/or reactor summary.
> I have hundreds of modules in my reactor build and I always have to scroll
> back pages to see the error message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238569#comment-17238569
]
Martin Kanters commented on MNG-6268:
-
Alright, so we can do that indeed. The only drawback of that is that the line
could become very long when a lot of goals/properties etc are passed to the CLI
(and then the -r flag will not stand out a lot).
I'm wondering whether we should include all the cli args in the
resume.properties file. Then the user could resume the build with invoking `mvn
-r`. (without having to put in the goals etc).
> When a reactor build fails Maven should include -f (if used) in command line
> suggestion
> ---
>
> Key: MNG-6268
> URL: https://issues.apache.org/jira/browse/MNG-6268
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Andreas Sewe
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.7.x-candidate
>
>
> When a reactor build fails, Maven prints out a helpful suggestion on how to
> resume.
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :example
> {noformat}
> Unfortunately, when running {{mvn}} with {{-f}}, this suggestion is wrong;
> Maven will either pick the wrong {{pom.xml}} or simply won’t find any; in
> either case, the {{pom.xml}} specified with {{-f}} is *crucial* information
> that was left out of the suggestion.
> FYI, this is related to MNG-6028, but covers a different bit of info that
> IMHO should be part of the suggestion. Hence this separate issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOURCES-270) mandatory resources
[ https://issues.apache.org/jira/browse/MRESOURCES-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238541#comment-17238541 ] Delany commented on MRESOURCES-270: --- I use the verifier plugin. It requires an extra location tag for every file, but it stores it in a separate file, so I don't have to include it in the pom. Enforcer adds a lot of lines to every project, but you can see at a glance which files could/must be included. Both imperfect hacks to something this plugin should do > mandatory resources > --- > > Key: MRESOURCES-270 > URL: https://issues.apache.org/jira/browse/MRESOURCES-270 > Project: Maven Resources Plugin > Issue Type: Improvement >Affects Versions: 3.2.0 >Reporter: Delany >Priority: Major > Fix For: waiting-for-feedback > > > If a resource is missing there should be an option to fail the > execution/build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-parent] dependabot[bot] opened a new pull request #21: Bump maven-pmd-plugin from 3.13.0 to 3.14.0
dependabot[bot] opened a new pull request #21: URL: https://github.com/apache/maven-parent/pull/21 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.13.0 to 3.14.0. Commits https://github.com/apache/maven-pmd-plugin/commit/56924f33687bfbc6fb051241dc51a0fc5bdf7ef6";>56924f3 [maven-release-plugin] prepare release maven-pmd-plugin-3.14.0 https://github.com/apache/maven-pmd-plugin/commit/bd5b0173532a23caa12ae3751ac87a9cf870e7df";>bd5b017 Fix integration test MPMD-165 https://github.com/apache/maven-pmd-plugin/commit/5048ab82bd92fa6526eba922d059f1a646b30cc6";>5048ab8 [MPMD-302] - Upgrade to PMD 6.29.0 https://github.com/apache/maven-pmd-plugin/commit/563654b474e031d7639429128b4d30eab5da3c02";>563654b [MPMD-307] - NPE when using custom rule https://github.com/apache/maven-pmd-plugin/commit/aff4499e154e34d050d0b099ed1b7fae85cddcef";>aff4499 [MPMD-290] - Skip integration test for maven < 3.3 https://github.com/apache/maven-pmd-plugin/commit/f39c0018e622e6c12a3a3df3a2a92bfb0ceeab44";>f39c001 [MPMD-304] - maven-pmd-plugin should be toolchains-aware https://github.com/apache/maven-pmd-plugin/commit/597d4cb712cf63a17daf67e6f0c0516fe1643e69";>597d4cb [MPMD-290] - Add integration test for CPD for C# https://github.com/apache/maven-pmd-plugin/commit/d766fdb0c93a6630ad7a788f260746b05c804a71";>d766fdb [MPMD-302] - Upgrade to PMD 6.28.0 https://github.com/apache/maven-pmd-plugin/commit/50765584772cd063e71d0922bfc8b74b82c113c5";>5076558 Fix typo in CpdReport.java https://github.com/apache/maven-pmd-plugin/commit/de2ff17c612faba5db5412fe45255e5e8f6e370c";>de2ff17 [MPMD-305] Add back support for txt format for CPD Additional commits viewable in https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.13.0...maven-pmd-plugin-3.14.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MARCHETYPES-70) Quickstart support for junit 5 and java 9+
[
https://issues.apache.org/jira/browse/MARCHETYPES-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238491#comment-17238491
]
Hudson commented on MARCHETYPES-70:
---
Build failed in Jenkins: Maven » Maven TLP » maven-archetypes » master #20
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-archetypes/job/master/20/
> Quickstart support for junit 5 and java 9+
> --
>
> Key: MARCHETYPES-70
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-70
> Project: Maven Archetype Bundles
> Issue Type: Improvement
> Components: Maven Quickstart Archetype
>Affects Versions: 1.3, 1.4
>Reporter: Jurrian Fahner
>Priority: Minor
>
> Quickstart archetype is outdated due to the support for java versions below 9
> and junit 4.
> The changes needs to be made backwards compatible in order to avoid breaking
> changes for legacy projects.
> For the support of java 9+ the java version tag must change from:
> {code:xml}
>
> 1.8
> 1.8
> {code}
> to:
> {code:xml}
>
> 11
> {code}
> For junit 5 support it is needed to add junit-jupiter-api and the vintage
> plugin, to add support for large older projects (with old junit tests in it).
> Example for dependencies for junit 5 it will look like:
> {code:xml}
>
> org.junit.jupiter
> junit-jupiter-api
> 5.2.2
> test
>
>
> org.junit.jupiter
> junit-jupiter-engine
> 5.2.2
> test
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MCOMPILER-442) Add "showLint" option
[
https://issues.apache.org/jira/browse/MCOMPILER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mike duigou updated MCOMPILER-442:
--
Description:
Add a showLint configuration option to eliminate the need to use
{code:java}
true
-Xlint:all
...
{code}
to configure the display of compiler lint messages. The advantage to a showLint
configuration would be that it is more ammenable to inclusion in a parent or
reactor project for inheritance in to sub-modules.
The element, if present would add the "-Xlint" option to the
compiler command line and the contents of the element as the parameter. ie.
{code:java}
all,-options,-path
{code}
would add:
{code:java}
-Xlint:all,-options,-path
{code}
to the compiler command line.
was:
Add a showLint configuration option to eliminate the need to use
{code:java}
true
-Xlint:all
...
{code}
to configure the display of compiler lint messages. The advantage to a showLint
configuration would be that it is more ammenable to inclusion in a parent or
reactor project for inheritance in to sub-modules.
The element, if present would add the "-Xlint" option to the
compiler command line and the contents of the element as the parameter. ie.
{code:java}
all,-options,-path
{code}
would add:
{code:java}
-Xlint:all,-options,-path
{code}
to the compiler command line.
> Add "showLint" option
> -
>
> Key: MCOMPILER-442
> URL: https://issues.apache.org/jira/browse/MCOMPILER-442
> Project: Maven Compiler Plugin
> Issue Type: New Feature
>Affects Versions: 3.8.1
>Reporter: mike duigou
>Priority: Minor
>
> Add a showLint configuration option to eliminate the need to use
>
> {code:java}
>
> true
>
> -Xlint:all
>
> ...
> {code}
> to configure the display of compiler lint messages. The advantage to a
> showLint configuration would be that it is more ammenable to inclusion in a
> parent or reactor project for inheritance in to sub-modules.
> The element, if present would add the "-Xlint" option to the
> compiler command line and the contents of the element as the parameter. ie.
> {code:java}
> all,-options,-path
> {code}
> would add:
> {code:java}
> -Xlint:all,-options,-path
> {code}
> to the compiler command line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MCOMPILER-442) Add "showLint" option
mike duigou created MCOMPILER-442:
-
Summary: Add "showLint" option
Key: MCOMPILER-442
URL: https://issues.apache.org/jira/browse/MCOMPILER-442
Project: Maven Compiler Plugin
Issue Type: New Feature
Affects Versions: 3.8.1
Reporter: mike duigou
Add a showLint configuration option to eliminate the need to use
{code:java}
true
-Xlint:all
...
{code}
to configure the display of compiler lint messages. The advantage to a showLint
configuration would be that it is more ammenable to inclusion in a parent or
reactor project for inheritance in to sub-modules.
The element, if present would add the "-Xlint" option to the
compiler command line and the contents of the element as the parameter. ie.
{code:java}
all,-options,-path
{code}
would add:
{code:java}
-Xlint:all,-options,-path
{code}
to the compiler command line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MVERIFIER-41) case-sensitive
[ https://issues.apache.org/jira/browse/MVERIFIER-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MVERIFIER-41: Fix Version/s: waiting-for-feedback > case-sensitive > -- > > Key: MVERIFIER-41 > URL: https://issues.apache.org/jira/browse/MVERIFIER-41 > Project: Maven Verifier Plugin > Issue Type: Improvement >Affects Versions: 1.1 >Reporter: Delany >Priority: Minor > Fix For: waiting-for-feedback > > > I use the verifier plugin to ensure resources are available for the resources > plugin. The resources plugin is case-sensitive, so I need the verifier plugin > to be case-sensitive. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MVERIFIER-41) case-sensitive
[ https://issues.apache.org/jira/browse/MVERIFIER-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238381#comment-17238381 ] Michael Osipov commented on MVERIFIER-41: - What is exactly case-insensitive? > case-sensitive > -- > > Key: MVERIFIER-41 > URL: https://issues.apache.org/jira/browse/MVERIFIER-41 > Project: Maven Verifier Plugin > Issue Type: Improvement >Affects Versions: 1.1 >Reporter: Delany >Priority: Minor > > I use the verifier plugin to ensure resources are available for the resources > plugin. The resources plugin is case-sensitive, so I need the verifier plugin > to be case-sensitive. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MRESOURCES-270) mandatory resources
[ https://issues.apache.org/jira/browse/MRESOURCES-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOURCES-270: -- Fix Version/s: waiting-for-feedback > mandatory resources > --- > > Key: MRESOURCES-270 > URL: https://issues.apache.org/jira/browse/MRESOURCES-270 > Project: Maven Resources Plugin > Issue Type: Improvement >Affects Versions: 3.2.0 >Reporter: Delany >Priority: Major > Fix For: waiting-for-feedback > > > If a resource is missing there should be an option to fail the > execution/build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRESOURCES-270) mandatory resources
[ https://issues.apache.org/jira/browse/MRESOURCES-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238380#comment-17238380 ] Michael Osipov commented on MRESOURCES-270: --- Have you considered https://maven.apache.org/enforcer/enforcer-rules/requireFilesExist.html? > mandatory resources > --- > > Key: MRESOURCES-270 > URL: https://issues.apache.org/jira/browse/MRESOURCES-270 > Project: Maven Resources Plugin > Issue Type: Improvement >Affects Versions: 3.2.0 >Reporter: Delany >Priority: Major > > If a resource is missing there should be an option to fail the > execution/build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238369#comment-17238369
]
Michael Osipov edited comment on MNG-6268 at 11/24/20, 9:13 PM:
I think we can. {{CliRequest}} contains the original args passed to Maven. It
is worth a try. The only problem I see are spaces in args which need to be
quoted.
was (Author: michael-o):
I think we can. {{CliRequest}} contains the original args passed to Maven. It
is worth a try.
> When a reactor build fails Maven should include -f (if used) in command line
> suggestion
> ---
>
> Key: MNG-6268
> URL: https://issues.apache.org/jira/browse/MNG-6268
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Andreas Sewe
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.7.x-candidate
>
>
> When a reactor build fails, Maven prints out a helpful suggestion on how to
> resume.
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :example
> {noformat}
> Unfortunately, when running {{mvn}} with {{-f}}, this suggestion is wrong;
> Maven will either pick the wrong {{pom.xml}} or simply won’t find any; in
> either case, the {{pom.xml}} specified with {{-f}} is *crucial* information
> that was left out of the suggestion.
> FYI, this is related to MNG-6028, but covers a different bit of info that
> IMHO should be part of the suggestion. Hence this separate issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (WAGON-597) AbstractHttpClientWagon.setPersistentPool has no effect due to parameter assigned to itself
[ https://issues.apache.org/jira/browse/WAGON-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated WAGON-597: - Component/s: wagon-http > AbstractHttpClientWagon.setPersistentPool has no effect due to parameter > assigned to itself > --- > > Key: WAGON-597 > URL: https://issues.apache.org/jira/browse/WAGON-597 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Affects Versions: 3.4.1 >Reporter: Piotr Zygielo >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.4.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-wagon] asfgit closed pull request #74: fix encode URL to preserve trailing slash
asfgit closed pull request #74: URL: https://github.com/apache/maven-wagon/pull/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (WAGON-602) [Regression] Preserve trailing slash in encoded URL
[ https://issues.apache.org/jira/browse/WAGON-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed WAGON-602. Resolution: Fixed Fixed with [370c89fd76be6297d7539181708582ae235a362e|https://gitbox.apache.org/repos/asf?p=maven-wagon.git&a=commit&h=370c89fd76be6297d7539181708582ae235a362e]. > [Regression] Preserve trailing slash in encoded URL > --- > > Key: WAGON-602 > URL: https://issues.apache.org/jira/browse/WAGON-602 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Reporter: Anatolii >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > Make `EncodingUtil.encodeURLToString` API preserves trailing slash in encoded > URL. > > PR: https://github.com/apache/maven-wagon/pull/74 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (WAGON-602) [Regression] Preserve trailing slash in encoded URL
[ https://issues.apache.org/jira/browse/WAGON-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated WAGON-602: - Summary: [Regression] Preserve trailing slash in encoded URL (was: Preserve trailing slash in encoded URL) > [Regression] Preserve trailing slash in encoded URL > --- > > Key: WAGON-602 > URL: https://issues.apache.org/jira/browse/WAGON-602 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Reporter: Anatolii >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > Make `EncodingUtil.encodeURLToString` API preserves trailing slash in encoded > URL. > > PR: https://github.com/apache/maven-wagon/pull/74 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238373#comment-17238373
]
Michael Osipov edited comment on MNG-7032 at 11/24/20, 9:04 PM:
I can confirm that. Both batch mode and {{style.color}} are evaluated after
cli args are processed and right here {{-v}} and {{-h}} is evaluated. So none
of the former has an effect. Yes, it is a bug.
Same applie for {{mvn -v -l file}}. It does not work. We'd need to move them
out of {{cli()}} and run them after {{logging()}} in {{MavenCli}}.
was (Author: michael-o):
I can confirm that. Both batch mode and {{style.color}} are evaluated after
cli args are processed and right here {{-v}} and {{-h}} is evaluated. So none
of the former has an effect. Yes, it is a bug.
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Priority: Major
> Labels: easyfix
> Fix For: 3.7.0-candidate
>
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7032:
Fix Version/s: (was: 3.7.0-candidate)
3.7.x-candidate
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Priority: Major
> Labels: easyfix
> Fix For: 3.7.x-candidate
>
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238373#comment-17238373
]
Michael Osipov edited comment on MNG-7032 at 11/24/20, 9:01 PM:
I can confirm that. Both batch mode and {{style.color}} are evaluated after
cli args are processed and right here {{-v}} and {{-h}} is evaluated. So none
of the former has an effect. Yes, it is a bug.
was (Author: michael-o):
I can confirm that. Both batch mode and {{style.color}} are evaluated after
cli args are processed and right here {{-v}} and {{-h}} is evaluated. So none
of the former has an effect.
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Priority: Major
> Labels: easyfix
> Fix For: 3.7.0-candidate
>
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238373#comment-17238373
]
Michael Osipov commented on MNG-7032:
-
I can confirm that. Both batch mode and {{style.color}} are evaluated after
cli args are processed and right here {{-v}} and {{-h}} is evaluated. So none
of the former has an effect.
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Priority: Major
> Labels: easyfix
> Fix For: 3.7.0-candidate
>
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MPLUGIN-294) 'report' mojo should use 'extractors' configuration parameter
[ https://issues.apache.org/jira/browse/MPLUGIN-294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MPLUGIN-294. Resolution: Won't Fix > 'report' mojo should use 'extractors' configuration parameter > - > > Key: MPLUGIN-294 > URL: https://issues.apache.org/jira/browse/MPLUGIN-294 > Project: Maven Plugin Tools > Issue Type: Improvement > Components: Plugin Plugin >Affects Versions: 3.4 >Reporter: Grzegorz Slowikowski >Priority: Trivial > > "extractors" configuration parameter should be used by "report" mojo the same > way it's used by "descriptor" and "helpmojo" mojos. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MPLUGIN-340) upgrade Ant version to 1.9.13
[ https://issues.apache.org/jira/browse/MPLUGIN-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MPLUGIN-340: Assignee: Sylwester Lachiewicz > upgrade Ant version to 1.9.13 > - > > Key: MPLUGIN-340 > URL: https://issues.apache.org/jira/browse/MPLUGIN-340 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade > Components: maven-plugin-tools-ant >Affects Versions: 3.5.2 >Reporter: Herve Boutemy >Assignee: Sylwester Lachiewicz >Priority: Major > > to benefit from > https://github.com/apache/ant/commit/857095da5153fd18504b46f276d84f1e76a66970 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MPLUGIN-369) Descriptor generation fails if a Mojo uses Java Records ("UnsupportedOperationException: Record requires ASM8")
[
https://issues.apache.org/jira/browse/MPLUGIN-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed MPLUGIN-369.
Resolution: Fixed
> Descriptor generation fails if a Mojo uses Java Records
> ("UnsupportedOperationException: Record requires ASM8")
> ---
>
> Key: MPLUGIN-369
> URL: https://issues.apache.org/jira/browse/MPLUGIN-369
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.0
>Reporter: Alex Shesterov
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>
> If a Mojo uses Java Records, then plugin's descriptor generation fails with
> the following error: *"descriptor failed: Record requires ASM8"*
> The fix requires upgdating ASM, which is already done in 3.6.1, *and*
> creating ASM Class Visitors with an updated API flag, e.g.:
> {code:java}
> public MojoClassVisitor( Logger logger )
> {
> super( Opcodes.ASM9 ); // <-- This is currently set to Opcodes.ASM7
> this.logger = logger;
> }{code}
>
> Error log:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor
> (default-descriptor) on project ***: Execution default-descriptor of goal
> org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor failed: Record
> requires ASM8 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor
> (default-descriptor) on project re-app-classifier-generator-plugin: Execution
> default-descriptor of goal
> org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor failed: Record
> requires ASM8
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:64)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:564)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
> default-descriptor of goal
> org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor failed: Record
> requires ASM8
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.ja
[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238369#comment-17238369
]
Michael Osipov commented on MNG-6268:
-
I think we can. {{CliRequest}} contains the original args passed to Maven. It
is worth a try.
> When a reactor build fails Maven should include -f (if used) in command line
> suggestion
> ---
>
> Key: MNG-6268
> URL: https://issues.apache.org/jira/browse/MNG-6268
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Andreas Sewe
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.7.x-candidate
>
>
> When a reactor build fails, Maven prints out a helpful suggestion on how to
> resume.
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :example
> {noformat}
> Unfortunately, when running {{mvn}} with {{-f}}, this suggestion is wrong;
> Maven will either pick the wrong {{pom.xml}} or simply won’t find any; in
> either case, the {{pom.xml}} specified with {{-f}} is *crucial* information
> that was left out of the suggestion.
> FYI, this is related to MNG-6028, but covers a different bit of info that
> IMHO should be part of the suggestion. Hence this separate issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238362#comment-17238362
]
Michael Osipov commented on MNG-6268:
-
That was my concern too. Even if we add {{-f ...}} it is still incomplete and
the original args have to be copied over. I ask myself wether we can reproduce
all args to make it copy and paste with {{-r}}/{{-rf}}.
> When a reactor build fails Maven should include -f (if used) in command line
> suggestion
> ---
>
> Key: MNG-6268
> URL: https://issues.apache.org/jira/browse/MNG-6268
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Andreas Sewe
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.7.x-candidate
>
>
> When a reactor build fails, Maven prints out a helpful suggestion on how to
> resume.
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :example
> {noformat}
> Unfortunately, when running {{mvn}} with {{-f}}, this suggestion is wrong;
> Maven will either pick the wrong {{pom.xml}} or simply won’t find any; in
> either case, the {{pom.xml}} specified with {{-f}} is *crucial* information
> that was left out of the suggestion.
> FYI, this is related to MNG-6028, but covers a different bit of info that
> IMHO should be part of the suggestion. Hence this separate issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (WAGON-597) AbstractHttpClientWagon.setPersistentPool has no effect due to parameter assigned to itself
[ https://issues.apache.org/jira/browse/WAGON-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed WAGON-597. > AbstractHttpClientWagon.setPersistentPool has no effect due to parameter > assigned to itself > --- > > Key: WAGON-597 > URL: https://issues.apache.org/jira/browse/WAGON-597 > Project: Maven Wagon > Issue Type: Bug >Affects Versions: 3.4.1 >Reporter: Piotr Zygielo >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.4.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (WAGON-601) Use latest JUnit version 4.13.1
[
https://issues.apache.org/jira/browse/WAGON-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed WAGON-601.
Resolution: Fixed
Fixed with 9b4f2fee4b0460aa16dee90d37a49440f09ed0db.
> Use latest JUnit version 4.13.1
> ---
>
> Key: WAGON-601
> URL: https://issues.apache.org/jira/browse/WAGON-601
> Project: Maven Wagon
> Issue Type: Dependency upgrade
>Reporter: Georgios Makris
>Assignee: Sylwester Lachiewicz
>Priority: Trivial
> Fix For: 3.4.2
>
>
> Update JUnit dependency to current latest version.
>
> h3. Security fix: {{TemporaryFolder}} now limits access to temporary folders
> on Java 1.7 or later
> A local information disclosure vulnerability in {{TemporaryFolder}} has been
> fixed. See the published [security
> advisory|https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp]
> for details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733208695 @ok2c Thank you. This is what I have assumed! @volkodava I have pushed branch WAGON-602 which another test, but removed one test because it was logically wrong. As soon as you add a non-ASCII character your test will fail. I will run the entire test set and them merge into master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6566) @Execute should not re-execute goals
[ https://issues.apache.org/jira/browse/MNG-6566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238346#comment-17238346 ] Martin Kanters commented on MNG-6566: - Luckl507 on StackOverflow has reported that his issue has been solved with the build of this pull request: https://stackoverflow.com/questions/64220555/what-is-the-reason-that-the-spring-boot-maven-plugin-reruns-a-full-build-cycle-a/64232561#64232561. > @Execute should not re-execute goals > > > Key: MNG-6566 > URL: https://issues.apache.org/jira/browse/MNG-6566 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Robert Scholte >Priority: Major > > We're getting quite a lot of requests for -no-fork goals, because now > often plugins are executed twice because of retriggering plugins due to the > @Execute -annotation. > Maven should be able to discover if there's a need to re-execute those > goals/lifecycles. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-wagon] ok2c edited a comment on pull request #74: fix encode URL to preserve trailing slash
ok2c edited a comment on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733195865 > So does the serialization happens. I need to check a few things and ask another expert. @ok2c What is your opinion on? > So you PR is partially correct and the trailing slash should logically be retained, but not unconditionally appended. I will get back to you when my checks are complete. @michael-o Yes, this sounds correct. The parser should be able to differentiate `/blah/blah/` and `/blah/blah` as distinct paths and do not turn one into another. The former should be treated as `['blah', 'blah', '']` sequence and the latter as `['blah', 'blah']`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] ok2c commented on pull request #74: fix encode URL to preserve trailing slash
ok2c commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733195865 > So does the serialization happens. I need to check a few things and ask another expert. @ok2c What is your opinion on? > So you PR is partially correct and the trailing slash should logically be retained, but not unconditionally appended. I will get back to you when my checks are complete. @michael-o Yes, this sounds correct. The parser should be able to differentiate `/blah/blah/` and `/blah/blah` as distinct paths and do not turn one into another. The former should be treated as ['blah', 'blah', ''] sequence and the latter as ['blah', 'blah'] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238339#comment-17238339
]
Martin Kanters commented on MNG-6268:
-
I'm not against this change too much, but it feels a bit inconsistent that we
do include the -f flag, but we do not fill in the other cli args (like goals
etc). What do you think?
> When a reactor build fails Maven should include -f (if used) in command line
> suggestion
> ---
>
> Key: MNG-6268
> URL: https://issues.apache.org/jira/browse/MNG-6268
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Andreas Sewe
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.7.x-candidate
>
>
> When a reactor build fails, Maven prints out a helpful suggestion on how to
> resume.
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :example
> {noformat}
> Unfortunately, when running {{mvn}} with {{-f}}, this suggestion is wrong;
> Maven will either pick the wrong {{pom.xml}} or simply won’t find any; in
> either case, the {{pom.xml}} specified with {{-f}} is *crucial* information
> that was left out of the suggestion.
> FYI, this is related to MNG-6028, but covers a different bit of info that
> IMHO should be part of the suggestion. Hence this separate issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-7026) Ability to only build direct dependants
[ https://issues.apache.org/jira/browse/MNG-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238337#comment-17238337 ] Martin Kanters commented on MNG-7026: - Right, then I guess it would make sense for you indeed. I'm a bit hesitant in building this in, because it (still) seems like a niche feature. It could definitely work out for you, but it will introduce extra complexity in the codebase and also in the usage/understandability of the flags. I'm wondering whether something like this can be built into an extension, but I do not have sufficient experience in that area. I hope some other experienced Maven users/contributors can weigh in. > Ability to only build direct dependants > --- > > Key: MNG-7026 > URL: https://issues.apache.org/jira/browse/MNG-7026 > Project: Maven > Issue Type: New Feature > Components: Command Line, core >Affects Versions: 3.6.3 >Reporter: Chadi >Priority: Minor > Labels: easyfix, features > > We are an organization with a large reactor. When we update a project X, we > would like to have the possibility to compile the artifacts that directly > depend on X, without having to recompile everything. > The fix itself is trivial and consists of traversing in non-recursive mode. I > can prepare a PR if you are OK with the request. > Its activation could be done using a flag such as --amdd, > --also-make-direct-dependents, or maybe --also-make-dependents=direct > What do you think? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7024) Directory instead of file in an artifact
[
https://issues.apache.org/jira/browse/MNG-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238333#comment-17238333
]
Martin Kanters commented on MNG-7024:
-
When they invoke mvn inside of the {{apache-camel}} module (I understand that's
their use-case), then apache-camel is definitely part of the reactor.
I'm pretty sure that the original behavior is intact when they would run mvn
from the root level without the profile activated.
> Directory instead of file in an artifact
>
>
> Key: MNG-7024
> URL: https://issues.apache.org/jira/browse/MNG-7024
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.7.0-candidate
>Reporter: Guillaume Nodet
>Priority: Blocker
> Fix For: 3.7.0-candidate
>
>
> When trying to build camel assembly with maven 3.7.0-SNAPSHOT, I hit the
> following exception
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:3.0.0:single (bin) on project
> apache-camel: Failed to create assembly: Error adding file
> 'org.apache.camel:camel-spring:jar:3.7.0-SNAPSHOT' to archive:
> /Users/gnodet/work/git/camel/components/camel-spring/target/classes isn't a
> file. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-assembly-plugin:3.0.0:single (bin) on
> project apache-camel: Failed to create assembly: Error adding file
> 'org.apache.camel:camel-spring:jar:3.7.0-SNAPSHOT' to archive:
> /Users/gnodet/work/git/camel/components/camel-spring/target/classes isn't a
> file.
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:218)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:115)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:79)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:64)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:131)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:319)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to create
> assembly: Error adding file
> 'org.apache.camel:camel-spring:jar:3.7.0-SNAPSHOT' to archive:
> /Users/gnodet/work/git/camel/components/camel-spring/target/classes isn't a
> file.
> at org.apache.maven.plugins.assembly.mojos.AbstractAssemblyMojo.execute
> (AbstractAssemblyMojo.java:530)
> at org.apache.maven.plugins.assembly.mojos.SingleAssemblyMojo.execute
> (SingleAssemblyMojo.java:58)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:136)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:115)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:79)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:64)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:131)
>
[jira] [Commented] (SUREFIRE-1863) Tests run in surefire can clear the thread interrupted flag silently when any message is logged to the console.
[
https://issues.apache.org/jira/browse/SUREFIRE-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238328#comment-17238328
]
Tibor Digana commented on SUREFIRE-1863:
[~peter..lawrey]
Is this issue the same with https://issues.apache.org/jira/browse/SUREFIRE-1815
?
> Tests run in surefire can clear the thread interrupted flag silently when any
> message is logged to the console.
> ---
>
> Key: SUREFIRE-1863
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1863
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Peter Lawrey
>Assignee: Tibor Digana
>Priority: Major
>
> Surefire-api clears the interrupted flag sometimes but not consistently in
> any code which writes to the console.
> It is not expected that writing to the console would result in clearing the
> interrupted flag nor is it easy to trace this is the cause when it does.
> The line of code causing this has a warning that it's result is ignored and
> probably shouldn't be.
> {{
> //noinspection ResultOfMethodCallIgnored
> Thread.interrupted();
> }}
> The stack trace
> {{
> Thread.interrupted() called
> at
> org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.encodeAndPrintEvent(LegacyMasterProcessChannelEncoder.java:310)
> at
> org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.setOutErr(LegacyMasterProcessChannelEncoder.java:204)
> at
> org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.stdOut(LegacyMasterProcessChannelEncoder.java:190)
> at
> org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:133)
> at
> org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:131)
> at
> net.openhft.chronicle.threads.DiskSpaceMonitor.pollDiskSpace(DiskSpaceMonitor.java:113)
> }}
> The last line of code calls System.out.println(abc);
>
> Instead of discarding the interrupted flag, I suggest setting it again in a
> finally block when exiting the sensitive code or it's not cleared
> unexpectedly.
> If this is expected behaviour, I suggest producing a warning that it was
> cleared so you work out why certain tests to detect the behaviour of an
> interrupted thread, fail when run in surefire.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SUREFIRE-1863) Tests run in surefire can clear the thread interrupted flag silently when any message is logged to the console.
[
https://issues.apache.org/jira/browse/SUREFIRE-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1863:
--
Assignee: Tibor Digana
> Tests run in surefire can clear the thread interrupted flag silently when any
> message is logged to the console.
> ---
>
> Key: SUREFIRE-1863
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1863
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Peter Lawrey
>Assignee: Tibor Digana
>Priority: Major
>
> Surefire-api clears the interrupted flag sometimes but not consistently in
> any code which writes to the console.
> It is not expected that writing to the console would result in clearing the
> interrupted flag nor is it easy to trace this is the cause when it does.
> The line of code causing this has a warning that it's result is ignored and
> probably shouldn't be.
> {{
> //noinspection ResultOfMethodCallIgnored
> Thread.interrupted();
> }}
> The stack trace
> {{
> Thread.interrupted() called
> at
> org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.encodeAndPrintEvent(LegacyMasterProcessChannelEncoder.java:310)
> at
> org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.setOutErr(LegacyMasterProcessChannelEncoder.java:204)
> at
> org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.stdOut(LegacyMasterProcessChannelEncoder.java:190)
> at
> org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:133)
> at
> org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:131)
> at
> net.openhft.chronicle.threads.DiskSpaceMonitor.pollDiskSpace(DiskSpaceMonitor.java:113)
> }}
> The last line of code calls System.out.println(abc);
>
> Instead of discarding the interrupted flag, I suggest setting it again in a
> finally block when exiting the sensitive code or it's not cleared
> unexpectedly.
> If this is expected behaviour, I suggest producing a warning that it was
> cleared so you work out why certain tests to detect the behaviour of an
> interrupted thread, fail when run in surefire.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238310#comment-17238310
]
Michael Osipov commented on MNG-7032:
-
Will look at it.
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Priority: Major
> Labels: easyfix
> Fix For: 3.7.0-candidate
>
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-jlink-plugin] rfscholte commented on pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.
rfscholte commented on pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#issuecomment-733141016 Fixed in https://github.com/apache/maven-jlink-plugin/commit/f8bdf5050c266854524aaa51eb36109c00ca692a Thanks for the patch! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] rfscholte closed pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.
rfscholte closed pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MJLINK-36) Use JLink via ToolProvider
[ https://issues.apache.org/jira/browse/MJLINK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MJLINK-36. Assignee: Robert Scholte Resolution: Fixed Fixed in [f8bdf5050c266854524aaa51eb36109c00ca692a|https://gitbox.apache.org/repos/asf?p=maven-jlink-plugin.git;a=commit;h=f8bdf5050c266854524aaa51eb36109c00ca692a] > Use JLink via ToolProvider > -- > > Key: MJLINK-36 > URL: https://issues.apache.org/jira/browse/MJLINK-36 > Project: Maven JLink Plugin > Issue Type: Improvement >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Major > Fix For: 3.0.1 > > > Especially Windows is having issues with long paths. Providing this option > wll pick up the jlink tool via the ToolProvider, so you don't have to start a > new jvm to use jlink. > See https://docs.oracle.com/javase/9/docs/api/jdk.jlink-summary.html > I would suggest that if toolchains isn't used, the ToolProvider should be > used instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte updated MNG-7032:
Fix Version/s: 3.7.0-candidate
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Priority: Major
> Labels: easyfix
> Fix For: 3.7.0-candidate
>
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-wagon] volkodava edited a comment on pull request #74: fix encode URL to preserve trailing slash
volkodava edited a comment on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733124272 > You have to undo the last commit because `URLEncodedUtils` expects encoded paths which we don't have. done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] volkodava commented on pull request #74: fix encode URL to preserve trailing slash
volkodava commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733124272 > You have to undo the last commit because `URLEncodedUtils` expects encoded paths which we don't have. done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] michael-o edited a comment on pull request #74: fix encode URL to preserve trailing slash
michael-o edited a comment on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733120004 You have to undo the last commit because `URLEncodedUtils` expects encoded paths which we don't have. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (WAGON-602) Preserve trailing slash in encoded URL
[ https://issues.apache.org/jira/browse/WAGON-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated WAGON-602: - Component/s: (was: wagon-provider-api) wagon-http > Preserve trailing slash in encoded URL > -- > > Key: WAGON-602 > URL: https://issues.apache.org/jira/browse/WAGON-602 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Reporter: Anatolii >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.1 > > > Make `EncodingUtil.encodeURLToString` API preserves trailing slash in encoded > URL. > > PR: https://github.com/apache/maven-wagon/pull/74 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (WAGON-602) Preserve trailing slash in encoded URL
[ https://issues.apache.org/jira/browse/WAGON-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated WAGON-602: - Fix Version/s: (was: 3.4.1) 3.4.2 > Preserve trailing slash in encoded URL > -- > > Key: WAGON-602 > URL: https://issues.apache.org/jira/browse/WAGON-602 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Reporter: Anatolii >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > Make `EncodingUtil.encodeURLToString` API preserves trailing slash in encoded > URL. > > PR: https://github.com/apache/maven-wagon/pull/74 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (WAGON-602) Preserve trailing slash in encoded URL
[ https://issues.apache.org/jira/browse/WAGON-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned WAGON-602: Assignee: Michael Osipov > Preserve trailing slash in encoded URL > -- > > Key: WAGON-602 > URL: https://issues.apache.org/jira/browse/WAGON-602 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-provider-api >Reporter: Anatolii >Assignee: Michael Osipov >Priority: Major > > Make `EncodingUtil.encodeURLToString` API preserves trailing slash in encoded > URL. > > PR: https://github.com/apache/maven-wagon/pull/74 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (WAGON-602) Preserve trailing slash in encoded URL
[ https://issues.apache.org/jira/browse/WAGON-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated WAGON-602: - Fix Version/s: 3.4.1 > Preserve trailing slash in encoded URL > -- > > Key: WAGON-602 > URL: https://issues.apache.org/jira/browse/WAGON-602 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-provider-api >Reporter: Anatolii >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.1 > > > Make `EncodingUtil.encodeURLToString` API preserves trailing slash in encoded > URL. > > PR: https://github.com/apache/maven-wagon/pull/74 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733120004 You have to undo the last commit because `URLEncodedUtils` expects encoded paths. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] volkodava commented on pull request #74: fix encode URL to preserve trailing slash
volkodava commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733118113 @michael-o respective JIRA created: https://issues.apache.org/jira/browse/WAGON-602, `encodeURLToString` updated to use `parsePathSegments` from `URLEncodedUtils`. Please find more details at: https://github.com/apache/maven-wagon/pull/74/commits/1b8361402d5613fe9ee8045703e128776761cbee This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (WAGON-602) Preserve trailing slash in encoded URL
Anatolii created WAGON-602: -- Summary: Preserve trailing slash in encoded URL Key: WAGON-602 URL: https://issues.apache.org/jira/browse/WAGON-602 Project: Maven Wagon Issue Type: Bug Components: wagon-provider-api Reporter: Anatolii Make `EncodingUtil.encodeURLToString` API preserves trailing slash in encoded URL. PR: https://github.com/apache/maven-wagon/pull/74 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-wagon] michael-o edited a comment on pull request #74: fix encode URL to preserve trailing slash
michael-o edited a comment on pull request #74:
URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733089123
I can confirm that HttpClient's
`URLEncodedUtils.parsePathSegments("/wow/"))` does what I have expected: `[wow,
]`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash
michael-o commented on pull request #74:
URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733089123
I can confirm that HttpClient's
`URLEncodedUtils.parsePathSegments("/wow/"))` does what I have expected: `[wow,
]`.
We need now a split which retains the last empty element.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.
bmarwell commented on pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#issuecomment-733079333 @rfscholte would you merge this one please? I do not have the karma to do so. Another review is also ok :) Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733056193 Please create a JIRA issue for this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733056024 So I have checked RFC 3986, it does not say anything about path ending normalization. Therefore I have checked WHATWG's URL spec: https://url.spec.whatwg.org/#url-serializing. Especially 4.2, append `/` and segment. We need to split the path because it could come from an FS unencoded. Now what about parsing? If I understand [this](https://url.spec.whatwg.org/#path-state) correctly, the parser remains in path state until a termination or a state change happens. I think 4.2 applies here in the parsing, after the last slash the buffer is empty, but still appended. So `/test/demo.zip/` splits up into: 0: `"test"` 1: `"demo.zip"` 3: `""` So does the serialization happens. I need to check a few things and ask another expert. @ok2c What is your opinion on? So you PR is partially correct and the trailing slash should logically be retained, but not unconditionally appended. I will get back to you when my checks are complete. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-1863) Tests run in surefire can clear the thread interrupted flag silently when any message is logged to the console.
Peter Lawrey created SUREFIRE-1863:
--
Summary: Tests run in surefire can clear the thread interrupted
flag silently when any message is logged to the console.
Key: SUREFIRE-1863
URL: https://issues.apache.org/jira/browse/SUREFIRE-1863
Project: Maven Surefire
Issue Type: Bug
Components: Maven Surefire Plugin
Affects Versions: 3.0.0-M5
Reporter: Peter Lawrey
Surefire-api clears the interrupted flag sometimes but not consistently in any
code which writes to the console.
It is not expected that writing to the console would result in clearing the
interrupted flag nor is it easy to trace this is the cause when it does.
The line of code causing this has a warning that it's result is ignored and
probably shouldn't be.
{{
//noinspection ResultOfMethodCallIgnored
Thread.interrupted();
}}
The stack trace
{{
Thread.interrupted() called
at
org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.encodeAndPrintEvent(LegacyMasterProcessChannelEncoder.java:310)
at
org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.setOutErr(LegacyMasterProcessChannelEncoder.java:204)
at
org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.stdOut(LegacyMasterProcessChannelEncoder.java:190)
at
org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:133)
at
org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:131)
at
net.openhft.chronicle.threads.DiskSpaceMonitor.pollDiskSpace(DiskSpaceMonitor.java:113)
}}
The last line of code calls System.out.println(abc);
Instead of discarding the interrupted flag, I suggest setting it again in a
finally block when exiting the sensitive code or it's not cleared unexpectedly.
If this is expected behaviour, I suggest producing a warning that it was
cleared so you work out why certain tests to detect the behaviour of an
interrupted thread, fail when run in surefire.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-wagon] michael-o edited a comment on pull request #74: fix encode URL to preserve trailing slash
michael-o edited a comment on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-732994229 OK, let me get to the breaking change first: The entire old code has been thrown out because it was defective and did not really comply with RFC 3986. HttpClient offers better solutions for this. Both `EncodingUtil.encodeURLToString( String )` and `EncodingUtil.encodeURL( String url )` are deprecated and rely on URI. This class is broken and does not comply with RFC 3986. Don't expect correct behavior here. Now going through your change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-732994229 OK, let me get to the breaking change first: The entire old code has been thrown out because it was defective and did not really comply with RFC 3986. HttpClient offers better solutions for this. Now going through your change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-732975081 I need to take a closer look before merging this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7032) Option -B still showing formatting when used with --version
Christian Koop created MNG-7032:
---
Summary: Option -B still showing formatting when used with
--version
Key: MNG-7032
URL: https://issues.apache.org/jira/browse/MNG-7032
Project: Maven
Issue Type: Bug
Components: Command Line, Logging
Affects Versions: 3.6.3
Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
Apache Maven 3.6.3
Maven home: /usr/share/maven
Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
Reporter: Christian Koop
When running {{mvn -B --version}} the first line ('Apache Maven 3.6.3') is
written in bold although the option {{-B}} should have stripped that as it does
with color in combination with other options.
This causes an issue when logging to a file as the ASCII escape sequence is
written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Koop updated MNG-7032:
Description:
When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}}) is
written in bold although the option {{-B}} should have stripped that as it does
with color in combination with other options.
This causes an issue when logging to a file as the ASCII escape sequence is
written to it in plain text (causing confusion).
was:
When running {{mvn -B --version}} the first line ('Apache Maven 3.6.3') is
written in bold although the option {{-B}} should have stripped that as it does
with color in combination with other options.
This causes an issue when logging to a file as the ASCII escape sequence is
written to it in plain text (causing confusion).
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Priority: Major
> Labels: easyfix
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-wagon] volkodava opened a new pull request #74: fix encode URL to preserve trailing slash
volkodava opened a new pull request #74: URL: https://github.com/apache/maven-wagon/pull/74 In this pull request we have a fix for breaking change introduced by `EncodingUtil.encodeURLToString( String baseUrl, String path )` for URLs with trailing slash in the following commit: https://github.com/apache/maven-wagon/commit/7d1315e47df948d8b17f5c759b20a5b3437cbff7#diff-a0742c473bc4d821caf820463c87956b67da4d07c059d5b6a631e98dd3f7f7b4R93, which has two issues: - inconsistency between `EncodingUtil.encodeURLToString( String url )` and `EncodingUtil.encodeURLToString( String baseUrl, String path )` in regards to URLs with trailing slash - affects `org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.resourceExists(...)` API, as URL `https://host:1234/test/demo.zip/` gets normalized to `https://host:1234/test/demo.zip` (with no trailing slash) by `EncodingUtil.encodeURLToString( String baseUrl, String path )` before verify if resource exists This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7031) Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS
[
https://issues.apache.org/jira/browse/MNG-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238063#comment-17238063
]
Michael Osipov commented on MNG-7031:
-
I just checked the code. MAVEN_OPTS is solely for the JVM (system properties),
it is not passed down to user properties since {{style.color}} is read from
{{cliRequest.getUserProperties()}}.
> Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS
> ---
>
> Key: MNG-7031
> URL: https://issues.apache.org/jira/browse/MNG-7031
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
> Environment: Apache Maven 3.6.3
> (cecedd343002696d0abb50b32b541b8a6ba2883f)
>Reporter: Andrei Osipov
>Priority: Major
> Attachments: mvn1.png, mvn2.png, mvn3.png, mvn4.png
>
>
> Options -Dstyle.color=never and -Dmaven.color=false have no effect when set
> in MAVEN_OPTS or JAVA_TOOL_OPTIONS
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-7031) Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS
[ https://issues.apache.org/jira/browse/MNG-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238053#comment-17238053 ] Andrei Osipov commented on MNG-7031: [~michael-o] The terminal was kitty, checked also with xterm (same result). `JAVA_TOOL_OPTIONS` seems to work fine for slf4j properties. Yes, it does work when passed directly. !mvn4.png! [~pzygielo] I guess `style.color` is not queried from System.properties than. Could it be the issue here? > Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS > --- > > Key: MNG-7031 > URL: https://issues.apache.org/jira/browse/MNG-7031 > Project: Maven > Issue Type: Bug >Affects Versions: 3.6.3 > Environment: Apache Maven 3.6.3 > (cecedd343002696d0abb50b32b541b8a6ba2883f) >Reporter: Andrei Osipov >Priority: Major > Attachments: mvn1.png, mvn2.png, mvn3.png, mvn4.png > > > Options -Dstyle.color=never and -Dmaven.color=false have no effect when set > in MAVEN_OPTS or JAVA_TOOL_OPTIONS > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-7031) Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS
[ https://issues.apache.org/jira/browse/MNG-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Osipov updated MNG-7031: --- Attachment: mvn4.png > Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS > --- > > Key: MNG-7031 > URL: https://issues.apache.org/jira/browse/MNG-7031 > Project: Maven > Issue Type: Bug >Affects Versions: 3.6.3 > Environment: Apache Maven 3.6.3 > (cecedd343002696d0abb50b32b541b8a6ba2883f) >Reporter: Andrei Osipov >Priority: Major > Attachments: mvn1.png, mvn2.png, mvn3.png, mvn4.png > > > Options -Dstyle.color=never and -Dmaven.color=false have no effect when set > in MAVEN_OPTS or JAVA_TOOL_OPTIONS > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7031) Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS
[
https://issues.apache.org/jira/browse/MNG-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238044#comment-17238044
]
Piotr Zygielo commented on MNG-7031:
Do not be mislead by MAVEN_OPTS name. It holds options for java used to execute
maven.
{quote}MAVEN_OPTS (Optional) Java runtime options used when Maven is executed
{quote}
As Michael asked "Does it work when you pass to Maven directly?" - it does work
this way.
{{-D}} for java is not the same as {{-D}} for maven.
> Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS
> ---
>
> Key: MNG-7031
> URL: https://issues.apache.org/jira/browse/MNG-7031
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
> Environment: Apache Maven 3.6.3
> (cecedd343002696d0abb50b32b541b8a6ba2883f)
>Reporter: Andrei Osipov
>Priority: Major
> Attachments: mvn1.png, mvn2.png, mvn3.png
>
>
> Options -Dstyle.color=never and -Dmaven.color=false have no effect when set
> in MAVEN_OPTS or JAVA_TOOL_OPTIONS
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-7030) Allow to use project.scm properties in a maven release
[ https://issues.apache.org/jira/browse/MNG-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7030: Fix Version/s: waiting-for-feedback > Allow to use project.scm properties in a maven release > -- > > Key: MNG-7030 > URL: https://issues.apache.org/jira/browse/MNG-7030 > Project: Maven > Issue Type: Bug > Components: POM >Affects Versions: 3.6.2, 3.6.3 >Reporter: Armand BERGES >Priority: Major > Fix For: waiting-for-feedback > > > I try to create a custom parent pom for my company. > Everything works great except for the release step. Actually, I would allow > my team mate to only declare a property (say *util.scm.url*) to enable all > the scm release block in maven-release-plugin. > For this, I have two problems : > > * When I declare *scm* section only in parent pom I fall into a SCM issue > that blocks my sons projects during my release steps (since the scm is badly > interpolated my build can't push release modifications) > * When I try to use *project.scm.** properties in my parent pom instead of > *scm* section, the release plugin blocks me with "Unable to find scm > section". I think he tries to find out the *scm* section only and not the > properties created by it > Please tell me if I'm missing something or if you need other informations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7030) Allow to use project.scm properties in a maven release
[ https://issues.apache.org/jira/browse/MNG-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238041#comment-17238041 ] Michael Osipov commented on MNG-7030: - You are supposed to provide/override SCM information in all POMs where the information changes. In the POM itself parts can be interpolated. I don't understand what you are trying to save here. > Allow to use project.scm properties in a maven release > -- > > Key: MNG-7030 > URL: https://issues.apache.org/jira/browse/MNG-7030 > Project: Maven > Issue Type: Bug > Components: POM >Affects Versions: 3.6.2, 3.6.3 >Reporter: Armand BERGES >Priority: Major > > I try to create a custom parent pom for my company. > Everything works great except for the release step. Actually, I would allow > my team mate to only declare a property (say *util.scm.url*) to enable all > the scm release block in maven-release-plugin. > For this, I have two problems : > > * When I declare *scm* section only in parent pom I fall into a SCM issue > that blocks my sons projects during my release steps (since the scm is badly > interpolated my build can't push release modifications) > * When I try to use *project.scm.** properties in my parent pom instead of > *scm* section, the release plugin blocks me with "Unable to find scm > section". I think he tries to find out the *scm* section only and not the > properties created by it > Please tell me if I'm missing something or if you need other informations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-7030) Allow to use project.scm properties in a maven release
[ https://issues.apache.org/jira/browse/MNG-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7030: Description: I try to create a custom parent pom for my company. Everything works great except for the release step. Actually, I would allow my team mate to only declare a property (say *util.scm.url*) to enable all the scm release block in maven-release-plugin. For this, I have two problems : * When I declare *scm* section only in parent pom I fall into a SCM issue that blocks my sons projects during my release steps (since the scm is badly interpolated my build can't push release modifications) * When I try to use *project.scm.** properties in my parent pom instead of *scm* section, the release plugin blocks me with "Unable to find scm section". I think he tries to find out the *scm* section only and not the properties created by it Please tell me if I'm missing something or if you need other informations was: I try to create a custom super pom for my company. Everything works great except for the release step. Actually, I would allow my teamate to only declare a property (say *util.scm.url*) to enable all the scm release bloc in maven-release-plugin. For this, I have two problems : * When I declare *scm* section only in parent pom I fall into a SCM issue that blocks my sons projects during my release steps (since the scm is badly interpolated my build can't push release modifications) * When I try to use *project.scm.** properties in my parent pom instead of *scm* section, the release plugin blocks me with "Unable to find scm section". I think he tries to find out the *scm* section only and not the properties created by it PLease tell me if I'm missing something or if you need other informations > Allow to use project.scm properties in a maven release > -- > > Key: MNG-7030 > URL: https://issues.apache.org/jira/browse/MNG-7030 > Project: Maven > Issue Type: Bug > Components: POM >Affects Versions: 3.6.2, 3.6.3 >Reporter: Armand BERGES >Priority: Major > > I try to create a custom parent pom for my company. > Everything works great except for the release step. Actually, I would allow > my team mate to only declare a property (say *util.scm.url*) to enable all > the scm release block in maven-release-plugin. > For this, I have two problems : > > * When I declare *scm* section only in parent pom I fall into a SCM issue > that blocks my sons projects during my release steps (since the scm is badly > interpolated my build can't push release modifications) > * When I try to use *project.scm.** properties in my parent pom instead of > *scm* section, the release plugin blocks me with "Unable to find scm > section". I think he tries to find out the *scm* section only and not the > properties created by it > Please tell me if I'm missing something or if you need other informations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7031) Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS
[ https://issues.apache.org/jira/browse/MNG-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238027#comment-17238027 ] Michael Osipov commented on MNG-7031: - What terminal do you use?. WE don't use `JAVA_TOOL_OPTIONS`. Does it work when you pass to Maven directly? > Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS > --- > > Key: MNG-7031 > URL: https://issues.apache.org/jira/browse/MNG-7031 > Project: Maven > Issue Type: Bug >Affects Versions: 3.6.3 > Environment: Apache Maven 3.6.3 > (cecedd343002696d0abb50b32b541b8a6ba2883f) >Reporter: Andrei Osipov >Priority: Major > Attachments: mvn1.png, mvn2.png, mvn3.png > > > Options -Dstyle.color=never and -Dmaven.color=false have no effect when set > in MAVEN_OPTS or JAVA_TOOL_OPTIONS > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MNG-7031) Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS
Andrei Osipov created MNG-7031: -- Summary: Unable to use -Dstyle.color with MAVEN_OPTS & JAVA_TOOL_OPTIONS Key: MNG-7031 URL: https://issues.apache.org/jira/browse/MNG-7031 Project: Maven Issue Type: Bug Affects Versions: 3.6.3 Environment: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Reporter: Andrei Osipov Attachments: mvn1.png, mvn2.png, mvn3.png Options -Dstyle.color=never and -Dmaven.color=false have no effect when set in MAVEN_OPTS or JAVA_TOOL_OPTIONS -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MRESOURCES-270) mandatory resources
Delany created MRESOURCES-270: - Summary: mandatory resources Key: MRESOURCES-270 URL: https://issues.apache.org/jira/browse/MRESOURCES-270 Project: Maven Resources Plugin Issue Type: Improvement Affects Versions: 3.2.0 Reporter: Delany If a resource is missing there should be an option to fail the execution/build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MVERIFIER-41) case-sensitive
Delany created MVERIFIER-41: --- Summary: case-sensitive Key: MVERIFIER-41 URL: https://issues.apache.org/jira/browse/MVERIFIER-41 Project: Maven Verifier Plugin Issue Type: Improvement Affects Versions: 1.1 Reporter: Delany I use the verifier plugin to ensure resources are available for the resources plugin. The resources plugin is case-sensitive, so I need the verifier plugin to be case-sensitive. -- This message was sent by Atlassian Jira (v8.3.4#803005)
