[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …
bmarwell commented on a change in pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19#discussion_r537287176 ## File path: pom.xml ## @@ -109,6 +109,11 @@ commons-lang3 3.6 + Review comment: Plugins are isolated. Dependency convergence does not matter here. We can drop commons altogether in a new PR imho. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] sparsick commented on a change in pull request #23: [MJLINK-57] Migrate to slf4j
sparsick commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537283535
##
File path:
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##
@@ -35,11 +36,11 @@
abstract class AbstractJLinkToolchainExecutor extends AbstractJLinkExecutor
{
+private static final Logger LOGGER = LoggerFactory.getLogger(
AbstractJLinkToolchainExecutor.class );
Review comment:
@elharo I looked in [other Maven code
](https://github.com/apache/maven-artifact-transfer/blob/dfb1e61c4f5db6fe167b3d879a37ab5e25c8475c/src/main/java/org/apache/maven/shared/transfer/project/deploy/internal/DefaultProjectDeployer.java#L52)
that use slf4j logger and there "LOGGER" is used. So I would prefer LOGGER
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #28: [MEAR-182] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov edited a comment on pull request #28: URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-739541265 @hboutemy, it would be nice to include this PR and PR #22 into 3.2.0 release of Maven EAR Plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] gianm commented on pull request #327: [SUREFIRE-1865] ChecksumCalculator getSha1 does not compute checksums correctly.
gianm commented on pull request #327: URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-739715279 The "GitHub CI for *Nix / build (macOS-latest)" check is still failing, but I'm not sure why. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] gianm closed pull request #327: [SUREFIRE-1865] ChecksumCalculator getSha1 does not compute checksums correctly.
gianm closed pull request #327: URL: https://github.com/apache/maven-surefire/pull/327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] gianm commented on pull request #327: [SUREFIRE-1865] ChecksumCalculator getSha1 does not compute checksums correctly.
gianm commented on pull request #327: URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-739639633 @Tibor17 OK, I've made those changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (WAGON-575) Retry for connection issues
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244923#comment-17244923
]
Igor Dvorzhak edited comment on WAGON-575 at 12/7/20, 3:22 AM:
---
I have sent a [PR|https://github.com/apache/maven-wagon/pull/75] that fixes
this issue by adding high-level retries for failed downloads in Maven Wagon.
It's less efficient retry mechanism than what was discussed in the comments
above but much simpler to implement and solves stability issue with my
multi-hour build.
Please, let me know if this is something that you are willing to consider/merge
with some additional work (configuration, tests, etc).
was (Author: medb):
I have sent a [PR|https://github.com/apache/maven-wagon/pull/75] that fixes
this issue by adding high-level retries for failed downloads in Maven Wagon.
It's less efficient retry mechanism than what was discussed in the comments
above but much simpler to implement and solves the issue for my build.
Please, let me know if this is something that you are willing to consider/merge
with some additional work (configuration, tests, etc).
> Retry for connection issues
> ---
>
> Key: WAGON-575
> URL: https://issues.apache.org/jira/browse/WAGON-575
> Project: Maven Wagon
> Issue Type: New Feature
> Components: wagon-http
>Affects Versions: 3.3.4
> Environment: windows and linux
>Reporter: Michael Medin
>Priority: Minor
>
> There are a RetryHandler and now also a ServiceRetryHandler but both seem to
> focus only the handshake and no the data stream.
> In our case we download large artifacts (1+Gb) over a sometimes shaky
> connection which causes frequent "Connection reset" issues.
> To mitigate this we started to implement retry logic based on this
> [https://maven.apache.org/wagon/wagon-providers/wagon-http/] document. But
> seems our retry handler is never invoked when the connection is reset.
> So after some digging into the source code it seems the retryhandler are only
> used when connecting to the server and once the connection has been
> established and the HTTP headers have been read there is no retry handling
> for the reminder stream copy.
> Looking at the code it seems non trivial to add retry for this at is split up
> so I wanted to know if I am missing something before looking at implementing
> a PR for this.
>
> A simple way to simulate this behavior is to start a maven build with some
> large dependencies and during the download phase just kill the internet
> connection.
> If you have a RetryHandler enabled it will never be called instead you will
> get a stack trace along the following:
> {{[ERROR] Failed to execute goal on project test: Could not resolve
> dependencies for project test:test:jar:1.0.0: Could not transfer artifact
> REDACTED from/to REDACTED from REDACTED failed: Connection reset -> [Help 1]}}
> {{org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal on project test: Could not resolve dependencies for project
> test:test:jar:1.0.0: Could not transfer artifact REDACTED from/to REDACTED
> (REDACTED): GET request of: REDACTED from REDACTED failed}}
> {{ at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies
> (LifecycleDependencyResolver.java:269)}}
> {{ at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies
> (LifecycleDependencyResolver.java:147)}}
> {{ at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved
> (MojoExecutor.java:248)}}
> {{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:202)}}
> {{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)}}
> {{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)}}
> {{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)}}
> {{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)}}
> {{ at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)}}
> {{ at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)}}
> {{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)}}
> {{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)}}
> {{ at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)}}
> {{ at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)}}
> {{ at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)}}
> {{ at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)}}
> {{ at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native
[jira] [Comment Edited] (WAGON-575) Retry for connection issues
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244923#comment-17244923
]
Igor Dvorzhak edited comment on WAGON-575 at 12/7/20, 3:21 AM:
---
I have sent a [PR|https://github.com/apache/maven-wagon/pull/75] that fixes
this issue by adding high-level retries for failed downloads in Maven Wagon.
It's less efficient retry mechanism than what was discussed in the comments
above but much simpler to implement and solves the issue for my build.
Please, let me know if this is something that you are willing to consider/merge
with some additional work (configuration, tests, etc).
was (Author: medb):
I have sent a [PR|https://github.com/apache/maven-wagon/pull/75] that fixes
this issue by adding high-level retries for failed downloads. It's less
efficient retry mechanism than what was discussed in the comments above but
much simpler to implement and solves the issue for my build.
Please, let me know if this is something that you are willing to consider/merge
with some additional work (configuration, tests, etc).
> Retry for connection issues
> ---
>
> Key: WAGON-575
> URL: https://issues.apache.org/jira/browse/WAGON-575
> Project: Maven Wagon
> Issue Type: New Feature
> Components: wagon-http
>Affects Versions: 3.3.4
> Environment: windows and linux
>Reporter: Michael Medin
>Priority: Minor
>
> There are a RetryHandler and now also a ServiceRetryHandler but both seem to
> focus only the handshake and no the data stream.
> In our case we download large artifacts (1+Gb) over a sometimes shaky
> connection which causes frequent "Connection reset" issues.
> To mitigate this we started to implement retry logic based on this
> [https://maven.apache.org/wagon/wagon-providers/wagon-http/] document. But
> seems our retry handler is never invoked when the connection is reset.
> So after some digging into the source code it seems the retryhandler are only
> used when connecting to the server and once the connection has been
> established and the HTTP headers have been read there is no retry handling
> for the reminder stream copy.
> Looking at the code it seems non trivial to add retry for this at is split up
> so I wanted to know if I am missing something before looking at implementing
> a PR for this.
>
> A simple way to simulate this behavior is to start a maven build with some
> large dependencies and during the download phase just kill the internet
> connection.
> If you have a RetryHandler enabled it will never be called instead you will
> get a stack trace along the following:
> {{[ERROR] Failed to execute goal on project test: Could not resolve
> dependencies for project test:test:jar:1.0.0: Could not transfer artifact
> REDACTED from/to REDACTED from REDACTED failed: Connection reset -> [Help 1]}}
> {{org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal on project test: Could not resolve dependencies for project
> test:test:jar:1.0.0: Could not transfer artifact REDACTED from/to REDACTED
> (REDACTED): GET request of: REDACTED from REDACTED failed}}
> {{ at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies
> (LifecycleDependencyResolver.java:269)}}
> {{ at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies
> (LifecycleDependencyResolver.java:147)}}
> {{ at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved
> (MojoExecutor.java:248)}}
> {{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:202)}}
> {{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)}}
> {{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)}}
> {{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)}}
> {{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)}}
> {{ at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)}}
> {{ at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)}}
> {{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)}}
> {{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)}}
> {{ at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)}}
> {{ at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)}}
> {{ at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)}}
> {{ at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)}}
> {{ at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)}}
> {{ at
[jira] [Commented] (WAGON-575) Retry for connection issues
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244923#comment-17244923
]
Igor Dvorzhak commented on WAGON-575:
-
I have sent a [PR|https://github.com/apache/maven-wagon/pull/75] that fixes
this issue by adding high-level retries for failed downloads. It's less
efficient retry mechanism than what was discussed in the comments above but
much simpler to implement and solves the issue for my build.
Please, let me know if this is something that you are willing to consider/merge
with some additional work (configuration, tests, etc).
> Retry for connection issues
> ---
>
> Key: WAGON-575
> URL: https://issues.apache.org/jira/browse/WAGON-575
> Project: Maven Wagon
> Issue Type: New Feature
> Components: wagon-http
>Affects Versions: 3.3.4
> Environment: windows and linux
>Reporter: Michael Medin
>Priority: Minor
>
> There are a RetryHandler and now also a ServiceRetryHandler but both seem to
> focus only the handshake and no the data stream.
> In our case we download large artifacts (1+Gb) over a sometimes shaky
> connection which causes frequent "Connection reset" issues.
> To mitigate this we started to implement retry logic based on this
> [https://maven.apache.org/wagon/wagon-providers/wagon-http/] document. But
> seems our retry handler is never invoked when the connection is reset.
> So after some digging into the source code it seems the retryhandler are only
> used when connecting to the server and once the connection has been
> established and the HTTP headers have been read there is no retry handling
> for the reminder stream copy.
> Looking at the code it seems non trivial to add retry for this at is split up
> so I wanted to know if I am missing something before looking at implementing
> a PR for this.
>
> A simple way to simulate this behavior is to start a maven build with some
> large dependencies and during the download phase just kill the internet
> connection.
> If you have a RetryHandler enabled it will never be called instead you will
> get a stack trace along the following:
> {{[ERROR] Failed to execute goal on project test: Could not resolve
> dependencies for project test:test:jar:1.0.0: Could not transfer artifact
> REDACTED from/to REDACTED from REDACTED failed: Connection reset -> [Help 1]}}
> {{org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal on project test: Could not resolve dependencies for project
> test:test:jar:1.0.0: Could not transfer artifact REDACTED from/to REDACTED
> (REDACTED): GET request of: REDACTED from REDACTED failed}}
> {{ at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies
> (LifecycleDependencyResolver.java:269)}}
> {{ at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies
> (LifecycleDependencyResolver.java:147)}}
> {{ at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved
> (MojoExecutor.java:248)}}
> {{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:202)}}
> {{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)}}
> {{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)}}
> {{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)}}
> {{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)}}
> {{ at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)}}
> {{ at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)}}
> {{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)}}
> {{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)}}
> {{ at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)}}
> {{ at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)}}
> {{ at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)}}
> {{ at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)}}
> {{ at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)}}
> {{ at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)}}
> {{ at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)}}
> {{ at java.lang.reflect.Method.invoke (Method.java:566)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)}}
> {{ at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
>
[GitHub] [maven-wagon] medb opened a new pull request #75: [WAGON-575] Add high-level download retries
medb opened a new pull request #75: URL: https://github.com/apache/maven-wagon/pull/75 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1862) IntegrationTestMojo should not silently swallow exceptions thrown by providers
[
https://issues.apache.org/jira/browse/SUREFIRE-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244874#comment-17244874
]
Tibor Digana commented on SUREFIRE-1862:
This method parameter _firstForkException_ is not needed and should be deleted
because it is already processed in _AbstractSurefireMojo_
{code:java}
current = failure( current, firstForkException );
handleSummary( current, firstForkException );
{code}
> IntegrationTestMojo should not silently swallow exceptions thrown by providers
> --
>
> Key: SUREFIRE-1862
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1862
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Reporter: Marc Philipp
>Priority: Major
>
> The {{IntegrationTestMojo}}'s {{handleSummary}} method currently does not
> handle the passed {{firstForkException}}:
> [https://github.com/apache/maven-surefire/blob/52ec2773d168d35dcc681b184f72c1053a1b9f16/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java#L485-L508]
> That leads to provider failures being silently ignored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SUREFIRE-1863) Tests run in surefire can clear the thread interrupted flag silently when any message is logged to the console.
[
https://issues.apache.org/jira/browse/SUREFIRE-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1863.
--
Fix Version/s: SUREFIRE-1815
Resolution: Duplicate
> Tests run in surefire can clear the thread interrupted flag silently when any
> message is logged to the console.
> ---
>
> Key: SUREFIRE-1863
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1863
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Peter Lawrey
>Assignee: Tibor Digana
>Priority: Major
> Fix For: SUREFIRE-1815
>
>
> Surefire-api clears the interrupted flag sometimes but not consistently in
> any code which writes to the console.
> It is not expected that writing to the console would result in clearing the
> interrupted flag nor is it easy to trace this is the cause when it does.
> The line of code causing this has a warning that it's result is ignored and
> probably shouldn't be.
> {{
> //noinspection ResultOfMethodCallIgnored
> Thread.interrupted();
> }}
> The stack trace
> {{
> Thread.interrupted() called
> at
> org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.encodeAndPrintEvent(LegacyMasterProcessChannelEncoder.java:310)
> at
> org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.setOutErr(LegacyMasterProcessChannelEncoder.java:204)
> at
> org.apache.maven.surefire.booter.spi.LegacyMasterProcessChannelEncoder.stdOut(LegacyMasterProcessChannelEncoder.java:190)
> at
> org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:133)
> at
> org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:131)
> at
> net.openhft.chronicle.threads.DiskSpaceMonitor.pollDiskSpace(DiskSpaceMonitor.java:113)
> }}
> The last line of code calls System.out.println(abc);
>
> Instead of discarding the interrupted flag, I suggest setting it again in a
> finally block when exiting the sensitive code or it's not cleared
> unexpectedly.
> If this is expected behaviour, I suggest producing a warning that it was
> cleared so you work out why certain tests to detect the behaviour of an
> interrupted thread, fail when run in surefire.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-jlink-plugin] elharo commented on pull request #22: older commons IO for dependency convergence
elharo commented on pull request #22: URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739584400 It's not just about this plugin. It's about its own dependencies like maven-archiver that are expecting an older version of commons-io. They'll probably work with the new version, but in the rare cases when they don't it's a really nasty problem to locate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] elharo commented on a change in pull request #23: [MJLINK-57] Migrate to slf4j
elharo commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537148975
##
File path:
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##
@@ -35,11 +36,11 @@
abstract class AbstractJLinkToolchainExecutor extends AbstractJLinkExecutor
{
+private static final Logger LOGGER = LoggerFactory.getLogger(
AbstractJLinkToolchainExecutor.class );
Review comment:
Section 5.2.4 of the Google Java Style Guide explains the thinking here:
https://google.github.io/styleguide/javaguide.html#s5.2-specific-identifier-names
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #22: older commons IO for dependency convergence
bmarwell commented on pull request #22: URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739583748 Assuming this plugin needs at least java 9 to work (either by toolchain or by the executing Java), I do not see the purpose of this change. No one would be affected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #23: [MJLINK-57] Migrate to slf4j
bmarwell commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537148500
##
File path:
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##
@@ -35,11 +36,11 @@
abstract class AbstractJLinkToolchainExecutor extends AbstractJLinkExecutor
{
+private static final Logger LOGGER = LoggerFactory.getLogger(
AbstractJLinkToolchainExecutor.class );
Review comment:
This is the first time I heard this. Do you have a reference? I haven't
seen any static code analysis tool which can differentiate between `static
final mutable` and `static final immutable`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-jlink-plugin] elharo commented on pull request #22: older commons IO for dependency convergence
elharo commented on pull request #22: URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739583228 Upgrading other dependencies would be a major breaking change that shoould be discussed on the mailing list and follow some analysis of how many projects and people we'd be likely to break. Most folks are on Java 8 now, but not all, and Maven is very widely used. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] elharo commented on a change in pull request #22: older commons IO for dependency convergence
elharo commented on a change in pull request #22: URL: https://github.com/apache/maven-jlink-plugin/pull/22#discussion_r537147922 ## File path: pom.xml ## @@ -112,7 +112,7 @@ commons-io commons-io - 2.8.0 Review comment: check the dependency convergence report. It's not just the plugins but shared libraries such as maven-archiver. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] elharo commented on a change in pull request #23: [MJLINK-57] Migrate to slf4j
elharo commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537147596
##
File path:
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##
@@ -35,11 +36,11 @@
abstract class AbstractJLinkToolchainExecutor extends AbstractJLinkExecutor
{
+private static final Logger LOGGER = LoggerFactory.getLogger(
AbstractJLinkToolchainExecutor.class );
Review comment:
usually "logger" because the object isn't truly a constant even if the
variable is
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #21: [MJLINK-53] Add classifier support
bmarwell commented on a change in pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21#discussion_r537139144
##
File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
##
@@ -428,11 +437,13 @@ private JLinkExecutor getExecutor()
return getJlinkExecutor();
}
-private boolean projectHasAlreadySetAnArtifact()
+private boolean projectHasAlreadySetAnArtifact( File
createZipArchiveFromImage )
{
-if ( getProject().getArtifact().getFile() != null )
+Optional file = Optional.ofNullable(
getProject().getArtifact().getFile() );
Review comment:
Actually we're missing an `isFile` check here. Thanks for catching this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell edited a comment on pull request #14: [MJLINK-41] add support for --add-options argument (JDK14+).
bmarwell edited a comment on pull request #14: URL: https://github.com/apache/maven-jlink-plugin/pull/14#issuecomment-739574405 > What happens if someone builds the project with JDK 8 or 11? We can't require JDK 14+ for building. Then the integration test is not being executed. You need at least a toolchain to execute the ITs, but that has been in this project since ever. Jlink is part of Java 9+. This is why all ITs are java 1.9+. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #14: [MJLINK-41] add support for --add-options argument (JDK14+).
bmarwell commented on pull request #14: URL: https://github.com/apache/maven-jlink-plugin/pull/14#issuecomment-739574405 > What happens if someone builds the project with JDK 8 or 11? We can't require JDK 14+ for building. Then the integration test is not being executed. You need at least a toolchain to execute the ITs, but that has been in this project since ever. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #21: [MJLINK-53] Add classifier support
bmarwell commented on a change in pull request #21: URL: https://github.com/apache/maven-jlink-plugin/pull/21#discussion_r537135356 ## File path: src/it/projects/MJLINK-52_classifiers/invoker.properties ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +invoker.java.version = 1.9+ Review comment: That would require a toolchain for the test to be executed. This is why all the ITs are 1.9+. ## File path: src/it/projects/MJLINK-52_classifiers/pom.xml ## @@ -0,0 +1,59 @@ + + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd; +> + 4.0.0 + org.apache.maven.plugins + maven-jlink-plugin-mjlink-26 + 96.0 + jlink + Maven + https://maven.apache.org + Test JLink creates archives with classifiers. + +1.9 +1.9 +UTF-8 + + + + +org.apache.maven.plugins +maven-compiler-plugin +3.8.0 + + 1.9 Review comment: That would require a toolchain for the test to be executed. This is why all the ITs are 1.9+. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #22: older commons IO for dependency convergence
bmarwell commented on a change in pull request #22: URL: https://github.com/apache/maven-jlink-plugin/pull/22#discussion_r537134930 ## File path: pom.xml ## @@ -112,7 +112,7 @@ commons-io commons-io - 2.8.0 Review comment: Please give a short reason. Either inherit it from somewhere or add a comment. Plugins are seperated by classloaders as far as I remember, so a dependency convergence should not hurt (aside from a few KiB of jars). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] sparsick edited a comment on pull request #22: older commons IO for dependency convergence
sparsick edited a comment on pull request #22: URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739563155 Maybe we should upgrade the other dependencies that requires Java 8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] sparsick commented on pull request #22: older commons IO for dependency convergence
sparsick commented on pull request #22: URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739563155 Maybe we should upgrade the other dependencies to require Java 8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #28: [MEAR-182] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov edited a comment on pull request #28: URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-739541265 @hboutemy, it would be nice to include this PR and PR #22 into 3.2.0 release of Maven EAR Plugin. My Skype account is marat.abrarov, feel free to IM if immediate action / answer is needed. I'll be online for the next 6 hrs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #28: [MEAR-182] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on pull request #28: URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-739541265 @hboutemy, it would be nice to include this PR and PR #22 into 3.2.0 release of Maven EAR Plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] hboutemy commented on pull request #24: [MEAR-153] skinnyModules option
hboutemy commented on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739540158 It has been merged, even if GitHub can't really get it because of the last commit I amended... let's close and more importantly enjoy and say a big thank you for this nice new feature This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] hboutemy closed pull request #24: [MEAR-153] skinnyModules option
hboutemy closed pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739538879 Hi @hboutemy, > Did I miss something? No you didn't. It looks like you merged all changed I proposed in this PR. I'm just confused what to do with this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] hboutemy edited a comment on pull request #24: [MEAR-153] skinnyModules option
hboutemy edited a comment on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739538449 Hi Marat, yes, I merged this PR but amended the last commit message in 30395beebffb0232d8ad7ffb03af57d919c1e89e because it was written against MEAR-216 instead of MEAR-153: I was waiting for Apache Jenkins job to finish before closing PR, Jira, and thanking you much for your hard work. Did I miss something? Regards, Hervé This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] hboutemy commented on pull request #24: [MEAR-153] skinnyModules option
hboutemy commented on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739538449 Hi Marat, yes, I merged this PR but amended the last commit message because it was written against MEAR-216 instead of MEAR-153: I was waiting for Apache Jenkins job to finish before closing PR, Jira, and thanking you much for your hard work. Did I miss something? Regards, Hervé This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs
mabrarov commented on pull request #22: URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-739536070 This PR was successfully built by Jenkins. Is it possible to get this PR merged? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #24: [MEAR-153] skinnyModules option
mabrarov edited a comment on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739535717 I fixed [that issue](https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739500692) with not empty diff by merging the master branch into the source branch of this pull request. Now this pull request has empty diff. @hboutemy, it looks like you merged source branch of this pull request into the master branch in 954b7363f7d522c0477207ca16b13b64272650fd, so I request you to take decision on this pull request - whether to merge this PR for correct history, or to decline this PR (because all changes were merged somehow without this PR). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #24: [MEAR-153] skinnyModules option
mabrarov edited a comment on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739535717 I fixed [that issue](https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739500692) with not empty diff by merging the master branch into the source branch of this pull request. Now this pull request has empty diff. @hboutemy, it looks like you merged source branch of this pull request into the master branch in 954b7363f7d522c0477207ca16b13b64272650fd, so I request you to take decision on this pull request - whether to merge it for correct history, or decline it (because all changes were merged somehow without this PR). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #412: Upgrade github actions cache and use m2 cache for integration testing…
michael-o commented on a change in pull request #412: URL: https://github.com/apache/maven/pull/412#discussion_r537086472 ## File path: .github/workflows/maven.yml ## @@ -137,4 +137,4 @@ jobs: - name: Running integration tests shell: bash -run: mvn install -e -B -V -Prun-its,embedded -DmavenDistro="$GITHUB_WORKSPACE/built-maven/apache-maven-bin.zip" -DwrapperDistroDir="$GITHUB_WORKSPACE/built-maven/" -DmavenWrapper="$GITHUB_WORKSPACE/built-maven-wrapper/maven-wrapper.jar" -f maven-integration-testing/pom.xml +run: mvn install -e -B -V -Prun-its,embedded -Dmaven.repo.local=~/.m2/repository -DmavenDistro="$GITHUB_WORKSPACE/built-maven/apache-maven-bin.zip" -DwrapperDistroDir="$GITHUB_WORKSPACE/built-maven/" -DmavenWrapper="$GITHUB_WORKSPACE/built-maven-wrapper/maven-wrapper.jar" -f maven-integration-testing/pom.xml Review comment: Isn't this redundant then because it is the default value? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739535717 I fixed [that issue](https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739500692) with not empty diff by merge master branch into the source branch of this pull request. No this pull request has empty diff. @hboutemy, it looks like you merged source branch of this pull request into the master branch in 954b7363f7d522c0477207ca16b13b64272650fd, so I request you to take decision on this pull request - whether to merge it for correct history, or decline it (because all changes were merged somehow without this PR). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MEAR-289) skinnyWars issue with finalName for Jar module
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244742#comment-17244742
]
Marat Abrarov edited comment on MEAR-289 at 12/6/20, 5:28 PM:
--
There is a chance that this issue is fixed within MEAR-288. Please retest your
case with Maven EAR Plugin built from the master branch. I tried to do that and
found no issue (comparing to the results produced by Maven EAR Plugin 3.1.0).
Here is my test of the given repro-project ([^maven-ear-example.zip]) which
uses Maven EAR Plugin 3.1.0:
{noformat}
$ mvn clean package
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
212 Defl:N 139 34% 2020-12-06 17:04 d29cf45c META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:04 META-INF/
0 Stored0 0% 2020-12-06 17:04 lib/
0 Stored0 0% 2020-12-06 17:04 META-INF/maven/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:03 697502a0
META-INF/application.xml
4214 Defl:N 3063 27% 2020-12-06 17:04 987f5ff5
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1052 46% 2020-12-06 17:04 fbd50bcf
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:04 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
8600 5052 41%11 files
$ unzip -vl
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Archive:
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
267 Defl:N 170 36% 2020-12-06 17:03 df2d2884 META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:03 META-INF/
0 Stored0 0% 2020-12-06 17:03 META-INF/maven/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/module-war/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/classes/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/lib/
64 Defl:N 65 -2% 2020-12-06 17:03 1310927b
META-INF/maven/com.example/module-war/pom.properties
1057 Defl:N 334 68% 2020-11-12 16:54 fef6778d
META-INF/maven/com.example/module-war/pom.xml
1946 Defl:N 1052 46% 2020-12-06 17:03 fbd50bcf
WEB-INF/lib/module-jar-0-SNAPSHOT.jar
1927 Defl:N 1025 47% 2020-12-06 17:03 935e5609
WEB-INF/lib/module-jar2-0-SNAPSHOT.jar
--- ------
5261 2646 50%12 files
{noformat}
And here is the same test with Maven EAR Plugin 3.2.0-SNAPSHOT built from the
master branch:
{noformat}
$ mvn clean package -Dmaven-ear-plugin.version=3.2.0-SNAPSHOT
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
221 Defl:N 143 35% 2020-12-06 17:05 8528f16f META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:05 META-INF/
0 Stored0 0% 2020-12-06 17:05 lib/
0 Stored0 0% 2020-12-06 17:05 META-INF/maven/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:05 697502a0
META-INF/application.xml
3012 Defl:N 2055 32% 2020-12-06 17:05 f3062fe2
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1062 45% 2020-12-06 17:05 6e22962d
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:05 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
7407 4058 45%11 files
$ unzip
[jira] [Commented] (MEAR-182) Skinny WAR's - Skip Class-Path Modification in Manifest
[
https://issues.apache.org/jira/browse/MEAR-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244796#comment-17244796
]
Marat Abrarov commented on MEAR-182:
It looks like there is a bug in implementation of {{skipClassPathModification}}
option introduced in MEAR-182. If {{skipClassPathModification}} is {{true}} and
original MANIFEST.mf of EAR module artifact has no {{Class-Path}} entry, then
empty {{Class-Path}} entry is added into EAR module. I tried to fix this bug in
[pull request #28|https://github.com/apache/maven-ear-plugin/pull/28]. Please
review and merge if agree.
> Skinny WAR's - Skip Class-Path Modification in Manifest
> ---
>
> Key: MEAR-182
> URL: https://issues.apache.org/jira/browse/MEAR-182
> Project: Maven EAR Plugin
> Issue Type: Improvement
>Affects Versions: 2.9
>Reporter: Mario Däpp
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 2.10
>
> Attachments: MEAR-182-patch.txt
>
>
> From Java EE 5, a library directory may be specified in the application.xml
> (element library-directory). The Maven EAR Plugin already supports this for
> generating the application.xml (value of property defaultLibBundleDir).
> The Java EE 5 specification mandates that all JAR files contained in the
> library directory be made available to all modules within the EAR file (cf.
> chapter EE.8.2.1 Bundled Libraries, section 2).
> If one specifies both the skinnyWars (value = true) and defaultLibBundleDir
> parameters, the libraries will be removed from the WAR and copied to the
> defaultLibBundleDir. They will also be added to the Class-Path in the WAR
> files manifest. This is unnecessary as per the Java EE 5 specification. Even
> worse, it breaks my EAR on WebLogic (classloading issues).
> I therefore propose the following improvement to the skinny WAR's
> functionality: If the Java EE version is 5 or greater and the
> defaultLibBundleDir has been specified, the Class-Path in the WAR's manifest
> should remain unchanged.
> I've created a corresponding patch and integration test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] mabrarov opened a new pull request #28: [MEAR-182] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov opened a new pull request #28: URL: https://github.com/apache/maven-ear-plugin/pull/28 [MEAR-182] - Don't add MANFIEST.mf Class-Path entry for EAR modules if skipClassPathModification is configured, generated Class-Path is empty and original MANFIEST.mf doesn't contain Class-Path entry. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244754#comment-17244754
]
Andreas Sewe commented on MNG-6268:
---
Closing as Won't Fix is fair enough.
That being said, I was pleasantly surprised to see so much in-depth discussion
on this issue, which turned to be much harder to address than I naively thought
when filing it. So, thank you very much, Martin, Michael and Piotr. Your effort
is appreciated, even if the resolution is Won't Fix.
> When a reactor build fails Maven should include -f (if used) in command line
> suggestion
> ---
>
> Key: MNG-6268
> URL: https://issues.apache.org/jira/browse/MNG-6268
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Andreas Sewe
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 4.0.x-candidate, wontfix-candidate
>
>
> When a reactor build fails, Maven prints out a helpful suggestion on how to
> resume.
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :example
> {noformat}
> Unfortunately, when running {{mvn}} with {{-f}}, this suggestion is wrong;
> Maven will either pick the wrong {{pom.xml}} or simply won’t find any; in
> either case, the {{pom.xml}} specified with {{-f}} is *crucial* information
> that was left out of the suggestion.
> FYI, this is related to MNG-6028, but covers a different bit of info that
> IMHO should be part of the suggestion. Hence this separate issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MJLINK-61) Provide .editorconfig based on checkstyle configuration
Sandra Parsick created MJLINK-61: Summary: Provide .editorconfig based on checkstyle configuration Key: MJLINK-61 URL: https://issues.apache.org/jira/browse/MJLINK-61 Project: Maven JLink Plugin Issue Type: Improvement Affects Versions: 3.0.0 Reporter: Sandra Parsick This file is generated using IntelliJ, following these steps: * Open Preferences > Editor > Code Style * Select (config wheel) > Import Schema > CheckStyle Configuration * Select hbase-checkstyle/src/main/resources/hbase/checkstyle.xml * Select (config wheel) > Export > EditorConfig File -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPOM-244) Upload SHA-512 to Staging Repository
[ https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244751#comment-17244751 ] Michael Osipov commented on MPOM-244: - This has to be configured in the release plugin to pass properties to the forked Maven instance for Resolver to pick up. > Upload SHA-512 to Staging Repository > > > Key: MPOM-244 > URL: https://issues.apache.org/jira/browse/MPOM-244 > Project: Maven POMs > Issue Type: Improvement >Affects Versions: ASF-23 >Reporter: Konrad Windszus >Priority: Major > > As now the ASF staging repository supports SHA2 hashes > (https://issues.apache.org/jira/browse/INFRA-14923) they should be generated > for > - all attached artifacts and > - deployed to the Staging repository (i.e. attached to build as well) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-jlink-plugin] sparsick opened a new pull request #23: [MJLINK-57] Migrate to slf4j
sparsick opened a new pull request #23: URL: https://github.com/apache/maven-jlink-plugin/pull/23 - add slf4j dependencies Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJLINK) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MJLINK-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] elharo opened a new pull request #22: older commons IO for dependency convergence
elharo opened a new pull request #22: URL: https://github.com/apache/maven-jlink-plugin/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MEAR-288) SNAPSHOT dependency JAR having timestamp name in WAR is not removed from WAR when skinnyWars option is turned on
[
https://issues.apache.org/jira/browse/MEAR-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244746#comment-17244746
]
Hudson commented on MEAR-288:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-ear-plugin » mear-216 #4
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/mear-216/4/
> SNAPSHOT dependency JAR having timestamp name in WAR is not removed from WAR
> when skinnyWars option is turned on
>
>
> Key: MEAR-288
> URL: https://issues.apache.org/jira/browse/MEAR-288
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Marat Abrarov
>Priority: Major
> Fix For: 3.2.0
>
>
> SNAPSHOT dependency JAR having *timestamp* name in WAR is not removed from
> WAR when skinnyWars option is turned on.
> Refer to
> [skinny-wars-timestamp|https://github.com/apache/maven-ear-plugin/tree/maven-ear-plugin-3.1.0/src/it/skinny-wars-timestamp]
> integration test. When this test is executed it generates this WAR archive:
> {noformat}
> target/it/skinny-wars-timestamp/war-module/target/war-module-1.0.war
> ├───META-INF/
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───war-module/
> │ ├───pom.properties
> │ └───pom.xml
> └───WEB-INF/
> ├───web.xml
> ├───classes/
> └───lib/
> ├───commons-lang-2.5.jar
> └───jar-sample-one-1.0-20150825.210557-91.jar
> {noformat}
> and this EAR archive:
> {noformat}
> target/it/skinny-wars-timestamp/ear-module/target/ear-module-1.0.ear
> ├───commons-lang-commons-lang-2.5.jar
> ├───eartest-jar-sample-one-1.0-20150825.210557-91.jar
> │
> ├───META-INF/
> │ ├───application.xml
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───ear-module/
> │ ├───pom.properties
> │ └───pom.xml
> │
> └───org.apache.maven.its.ear.skinnywars-war-module-1.0.war
> ├───META-INF/
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───war-module/
> │ ├───pom.properties
> │ └───pom.xml
> │
> └───WEB-INF/
> ├───web.xml
> ├───classes/
> └───lib/
> └───jar-sample-one-1.0-20150825.210557-91.jar
> {noformat}
> while expected EAR archive is:
> {noformat}
> target/it/skinny-wars-timestamp/ear-module/target/ear-module-1.0.ear
> ├───commons-lang-commons-lang-2.5.jar
> ├───eartest-jar-sample-one-1.0-20150825.210557-91.jar
> │
> ├───META-INF/
> │ ├───application.xml
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───ear-module/
> │ ├───pom.properties
> │ └───pom.xml
> │
> └───org.apache.maven.its.ear.skinnywars-war-module-1.0.war
> ├───META-INF/
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───war-module/
> │ ├───pom.properties
> │ └───pom.xml
> │
> └───WEB-INF/
> ├───web.xml
> ├───classes/
> └───lib/
> {noformat}
> i.e.
> target/it/skinny-wars-timestamp/ear-module/target/ear-module-1.0.ear/org.apache.maven.its.ear.skinnywars-war-module-1.0.war/WEB-INF/lib/jar-sample-one-1.0-20150825.210557-91.jar
> file should not exist (because of skinnyWars option turned on).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MEAR-216) Unable to include dependencies of type test-jar
[
https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244747#comment-17244747
]
Hudson commented on MEAR-216:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-ear-plugin » mear-216 #4
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/mear-216/4/
> Unable to include dependencies of type test-jar
> ---
>
> Key: MEAR-216
> URL: https://issues.apache.org/jira/browse/MEAR-216
> Project: Maven EAR Plugin
> Issue Type: Improvement
>Affects Versions: 2.10
>Reporter: Maxim Frolov
>Priority: Major
> Fix For: waiting-for-feedback, 3.2.0
>
> Attachments: test-jar-in-ear-2.zip, test-jar-in-ear.zip
>
>
> Please implement support for artifacts of type *test-jar*.
> One of the use cases would be to build a test EAR as a mix of production and
> test JARs where the test JARs are used to set up the test data used to test
> the production code.
> Currently including one or more dependencies of type test-jar causes
> *LifecycleExecutionException*:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml
> (default-generate-application-xml) on project suite-systemtests-common-ear:
> Failed to initialize ear modules: Unknown artifact type[test-jar] for
> artifact_id -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml
> (default-generate-application-xml) on project suite-systemtests-common-ear:
> Failed to initialize ear modules
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to
> initialize ear modules
> at
> org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:260)
> at
> org.apache.maven.plugin.ear.GenerateApplicationXmlMojo.execute(GenerateApplicationXmlMojo.java:162)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: org.apache.maven.plugin.ear.UnknownArtifactTypeException: Unknown
> artifact type[test-jar] for common-domain-impl
> at
> org.apache.maven.plugin.ear.EarModuleFactory.newEarModule(EarModuleFactory.java:88)
> at
> org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:250)
> ... 22 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-jlink-plugin] elharo commented on a change in pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …
elharo commented on a change in pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19#discussion_r537049767 ## File path: pom.xml ## @@ -109,6 +109,11 @@ commons-lang3 3.6 + Review comment: Even if this plugin requires Java 1.8, other dependencies require Java 7 which means 2.6.0 for commons-io. For dependency convergence this should be pushed back. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] elharo commented on a change in pull request #21: [MJLINK-53] Add classifier support
elharo commented on a change in pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21#discussion_r537048702
##
File path: src/it/projects/MJLINK-52_classifiers/invoker.properties
##
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+invoker.java.version = 1.9+
Review comment:
1.8 at max, preferably 1.7
##
File path: src/it/projects/MJLINK-52_classifiers/pom.xml
##
@@ -0,0 +1,59 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
+>
+ 4.0.0
+ org.apache.maven.plugins
+ maven-jlink-plugin-mjlink-26
+ 96.0
+ jlink
+ Maven
+ https://maven.apache.org
+ Test JLink creates archives with classifiers.
+
+1.9
+1.9
+UTF-8
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.8.0
+
+ 1.9
Review comment:
1.8
##
File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
##
@@ -428,11 +437,13 @@ private JLinkExecutor getExecutor()
return getJlinkExecutor();
}
-private boolean projectHasAlreadySetAnArtifact()
+private boolean projectHasAlreadySetAnArtifact( File
createZipArchiveFromImage )
{
-if ( getProject().getArtifact().getFile() != null )
+Optional file = Optional.ofNullable(
getProject().getArtifact().getFile() );
Review comment:
optional here reads even more opaquely than simply checking for null
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (MEAR-289) skinnyWars issue with finalName for Jar module
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244742#comment-17244742
]
Marat Abrarov edited comment on MEAR-289 at 12/6/20, 2:19 PM:
--
There is a chance that this issue is fixed within MEAR-288. Please retest your
case with Maven EAR Plugin built from the master branch. I tried to do that and
found no issue (comparing to the results produced by Maven EAR Plugin 3.1.0).
Here is my test of the given repro-project ([^maven-ear-example.zip]) which
uses Maven EAR Plugin 3.1.0:
{noformat}
$ mvn clean package
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
212 Defl:N 139 34% 2020-12-06 17:04 d29cf45c META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:04 META-INF/
0 Stored0 0% 2020-12-06 17:04 lib/
0 Stored0 0% 2020-12-06 17:04 META-INF/maven/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:03 697502a0
META-INF/application.xml
4214 Defl:N 3063 27% 2020-12-06 17:04 987f5ff5
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1052 46% 2020-12-06 17:04 fbd50bcf
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:04 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
8600 5052 41%11 files
$ unzip -vl
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Archive:
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
267 Defl:N 170 36% 2020-12-06 17:03 df2d2884 META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:03 META-INF/
0 Stored0 0% 2020-12-06 17:03 META-INF/maven/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/module-war/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/classes/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/lib/
64 Defl:N 65 -2% 2020-12-06 17:03 1310927b
META-INF/maven/com.example/module-war/pom.properties
1057 Defl:N 334 68% 2020-11-12 16:54 fef6778d
META-INF/maven/com.example/module-war/pom.xml
1946 Defl:N 1052 46% 2020-12-06 17:03 fbd50bcf
WEB-INF/lib/module-jar-0-SNAPSHOT.jar
1927 Defl:N 1025 47% 2020-12-06 17:03 935e5609
WEB-INF/lib/module-jar2-0-SNAPSHOT.jar
--- ------
5261 2646 50%12 files
{noformat}
And here is the same test with Maven EAR Plugin 3.2.0-SNAPSHOT built from the
master branch:
{noformat}
$ mvn clean package -Dmaven-ear-plugin.version=3.2.0-SNAPSHOT
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
221 Defl:N 143 35% 2020-12-06 17:05 8528f16f META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:05 META-INF/
0 Stored0 0% 2020-12-06 17:05 lib/
0 Stored0 0% 2020-12-06 17:05 META-INF/maven/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:05 697502a0
META-INF/application.xml
3012 Defl:N 2055 32% 2020-12-06 17:05 f3062fe2
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1062 45% 2020-12-06 17:05 6e22962d
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:05 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
7407 4058 45%11 files
$ unzip
[jira] [Comment Edited] (MEAR-289) skinnyWars issue with finalName for Jar module
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244742#comment-17244742
]
Marat Abrarov edited comment on MEAR-289 at 12/6/20, 2:18 PM:
--
There is a chance that this issue is fixed within MEAR-288. Please retest your
case with Maven EAR Plugin built from the master branch. I tried to do that and
found no issue (comparing to the results produced by Maven EAR Plugin 3.1.0).
Here is my test of the given repro-project ([^maven-ear-example.zip]) which
uses Maven EAR Plugin 3.1.0:
{noformat}
$ mvn clean package
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
212 Defl:N 139 34% 2020-12-06 17:04 d29cf45c META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:04 META-INF/
0 Stored0 0% 2020-12-06 17:04 lib/
0 Stored0 0% 2020-12-06 17:04 META-INF/maven/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:03 697502a0
META-INF/application.xml
4214 Defl:N 3063 27% 2020-12-06 17:04 987f5ff5
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1052 46% 2020-12-06 17:04 fbd50bcf
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:04 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
8600 5052 41%11 files
$ unzip -vl
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Archive:
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
267 Defl:N 170 36% 2020-12-06 17:03 df2d2884 META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:03 META-INF/
0 Stored0 0% 2020-12-06 17:03 META-INF/maven/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/module-war/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/classes/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/lib/
64 Defl:N 65 -2% 2020-12-06 17:03 1310927b
META-INF/maven/com.example/module-war/pom.properties
1057 Defl:N 334 68% 2020-11-12 16:54 fef6778d
META-INF/maven/com.example/module-war/pom.xml
1946 Defl:N 1052 46% 2020-12-06 17:03 fbd50bcf
WEB-INF/lib/module-jar-0-SNAPSHOT.jar
1927 Defl:N 1025 47% 2020-12-06 17:03 935e5609
WEB-INF/lib/module-jar2-0-SNAPSHOT.jar
--- ------
5261 2646 50%12 files
{noformat}
And here is the same test with Maven EAR Plugin 3.2.0-SNAPSHOT built from the
master branch:
{noformat}
$ mvn clean package -Dmaven-ear-plugin.version=3.2.0-SNAPSHOT
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
221 Defl:N 143 35% 2020-12-06 17:05 8528f16f META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:05 META-INF/
0 Stored0 0% 2020-12-06 17:05 lib/
0 Stored0 0% 2020-12-06 17:05 META-INF/maven/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:05 697502a0
META-INF/application.xml
3012 Defl:N 2055 32% 2020-12-06 17:05 f3062fe2
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1062 45% 2020-12-06 17:05 6e22962d
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:05 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
7407 4058 45%11 files
$ unzip
[jira] [Comment Edited] (MEAR-289) skinnyWars issue with finalName for Jar module
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244742#comment-17244742
]
Marat Abrarov edited comment on MEAR-289 at 12/6/20, 2:12 PM:
--
There is a chance that this issue is fixed within MEAR-288. Please retest your
case with Maven EAR Plugin built from the master branch. I tried to do that and
found no issue (comparing to the results produced by Maven EAR Plugin 3.1.0).
Here is my test of the given repro-project ([^maven-ear-example.zip]) which
uses Maven EAR Plugin 3.1.0:
{noformat}
$ mvn clean package
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
212 Defl:N 139 34% 2020-12-06 17:04 d29cf45c META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:04 META-INF/
0 Stored0 0% 2020-12-06 17:04 lib/
0 Stored0 0% 2020-12-06 17:04 META-INF/maven/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:03 697502a0
META-INF/application.xml
4214 Defl:N 3063 27% 2020-12-06 17:04 987f5ff5
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1052 46% 2020-12-06 17:04 fbd50bcf
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:04 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
8600 5052 41%11 files
$ unzip -vl
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Archive:
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
267 Defl:N 170 36% 2020-12-06 17:03 df2d2884 META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:03 META-INF/
0 Stored0 0% 2020-12-06 17:03 META-INF/maven/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/module-war/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/classes/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/lib/
64 Defl:N 65 -2% 2020-12-06 17:03 1310927b
META-INF/maven/com.example/module-war/pom.properties
1057 Defl:N 334 68% 2020-11-12 16:54 fef6778d
META-INF/maven/com.example/module-war/pom.xml
1946 Defl:N 1052 46% 2020-12-06 17:03 fbd50bcf
WEB-INF/lib/module-jar-0-SNAPSHOT.jar
1927 Defl:N 1025 47% 2020-12-06 17:03 935e5609
WEB-INF/lib/module-jar2-0-SNAPSHOT.jar
--- ------
5261 2646 50%12 files
{noformat}
And here is the same test with Maven EAR Plugin 3.2.0-SNAPSHOT built from the
master branch:
{noformat}
$ mvn clean package -Dmaven-ear-plugin.version=3.2.0-SNAPSHOT
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
221 Defl:N 143 35% 2020-12-06 17:05 8528f16f META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:05 META-INF/
0 Stored0 0% 2020-12-06 17:05 lib/
0 Stored0 0% 2020-12-06 17:05 META-INF/maven/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:05 697502a0
META-INF/application.xml
3012 Defl:N 2055 32% 2020-12-06 17:05 f3062fe2
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1062 45% 2020-12-06 17:05 6e22962d
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:05 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
7407 4058 45%11 files
$ unzip
[jira] [Commented] (MEAR-289) skinnyWars issue with finalName for Jar module
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244742#comment-17244742
]
Marat Abrarov commented on MEAR-289:
There is a chance that this issue is fixed within MEAR-288. Please retest your
case with Maven EAR Plugin built from the master branch. I tried to do that and
found no issue (comparing to the results produced by Maven EAR Plugin 3.1.0).
Here is my test of the given repro-project ( [^maven-ear-example.zip]) which
uses Maven EAR Plugin 3.1.0:
{noformat}
$ mvn clean package
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
212 Defl:N 139 34% 2020-12-06 17:04 d29cf45c META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:04 META-INF/
0 Stored0 0% 2020-12-06 17:04 lib/
0 Stored0 0% 2020-12-06 17:04 META-INF/maven/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:04
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:03 697502a0
META-INF/application.xml
4214 Defl:N 3063 27% 2020-12-06 17:04 987f5ff5
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1052 46% 2020-12-06 17:04 fbd50bcf
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:04 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
8600 5052 41%11 files
$ unzip -vl
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Archive:
module-ear/target/module-ear-0-SNAPSHOT/com.example-module-war-0-SNAPSHOT.war
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
267 Defl:N 170 36% 2020-12-06 17:03 df2d2884 META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:03 META-INF/
0 Stored0 0% 2020-12-06 17:03 META-INF/maven/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:03
META-INF/maven/com.example/module-war/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/classes/
0 Stored0 0% 2020-12-06 17:03 WEB-INF/lib/
64 Defl:N 65 -2% 2020-12-06 17:03 1310927b
META-INF/maven/com.example/module-war/pom.properties
1057 Defl:N 334 68% 2020-11-12 16:54 fef6778d
META-INF/maven/com.example/module-war/pom.xml
1946 Defl:N 1052 46% 2020-12-06 17:03 fbd50bcf
WEB-INF/lib/module-jar-0-SNAPSHOT.jar
1927 Defl:N 1025 47% 2020-12-06 17:03 935e5609
WEB-INF/lib/module-jar2-0-SNAPSHOT.jar
--- ------
5261 2646 50%12 files
{noformat}
And here is the same test with Maven EAR Plugin 3.2.0-SNAPSHOT built from the
master branch:
{noformat}
$ mvn clean package -Dmaven-ear-plugin.version=3.2.0-SNAPSHOT
...
$ unzip -vl module-ear/target/module-ear-0-SNAPSHOT.ear
Archive: module-ear/target/module-ear-0-SNAPSHOT.ear
Length MethodSize CmprDateTime CRC-32 Name
-- --- -- -
221 Defl:N 143 35% 2020-12-06 17:05 8528f16f META-INF/MANIFEST.MF
0 Stored0 0% 2020-12-06 17:05 META-INF/
0 Stored0 0% 2020-12-06 17:05 lib/
0 Stored0 0% 2020-12-06 17:05 META-INF/maven/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/
0 Stored0 0% 2020-12-06 17:05
META-INF/maven/com.example/module-ear/
477 Defl:N 258 46% 2020-12-06 17:05 697502a0
META-INF/application.xml
3012 Defl:N 2055 32% 2020-12-06 17:05 f3062fe2
com.example-module-war-0-SNAPSHOT.war
1946 Defl:N 1062 45% 2020-12-06 17:05 6e22962d
lib/com.example-module-jar-0-SNAPSHOT.jar
1687 Defl:N 475 72% 2020-11-12 16:54 9e8c42bb
META-INF/maven/com.example/module-ear/pom.xml
64 Defl:N 65 -2% 2020-12-06 17:05 7dde0569
META-INF/maven/com.example/module-ear/pom.properties
--- ------
7407 4058 45%11 files
$ unzip -vl
[jira] [Created] (MRESOURCES-272) Error message is not clear
Maxim Solodovnik created MRESOURCES-272:
---
Summary: Error message is not clear
Key: MRESOURCES-272
URL: https://issues.apache.org/jira/browse/MRESOURCES-272
Project: Maven Resources Plugin
Issue Type: Bug
Components: filtering
Affects Versions: 3.2.0
Reporter: Maxim Solodovnik
If maven-resources-plugin get some binary file it reports following error:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-resources-plugin:3.2.0:copy-resources
(prepare-test-resources) on project openmeetings-web: Input length = 1 -> [Help
1]
{code}
which is not very helpful
if {{mvn -e}} is used the error is
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-resources-plugin:3.2.0:copy-resources
(prepare-test-resources) on project openmeetings-web: Input length = 1 -> [Help
1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-resources-plugin:3.2.0:copy-resources
(prepare-test-resources) on project openmeetings-web: Input length = 1
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:347)
Caused by: org.apache.maven.plugin.MojoExecutionException: Input length = 1
at org.apache.maven.plugins.resources.ResourcesMojo.execute
(ResourcesMojo.java:362)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)
at
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs
mabrarov commented on pull request #22: URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-739505049 Merged conflicts were resolved. Please trigger a new Jenkins build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project
[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7038:
Fix Version/s: Issues to be reviewed for 4.x
> Introduce public property to point to a root directory of (multi-module)
> project
>
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
> Issue Type: Improvement
>Reporter: Envious Guest
>Priority: Major
> Fix For: Issues to be reviewed for 4.x
>
>
> This is a request to expose a property *maven.multiModuleProjectDirectory*
> which is currently internal (or introduce a brand new one with analogous
> functionality).
> * For a single-module project, its value should be same as *project.basedir*
> * For multi-module project, its value should point to a project.basedir of a
> root module
> Example:
> multi-module // located at /home/me/sources
> +- module-a
> +- module B
> Sample multi-module/pom.xml:
> {{}}
> {{ }}
> {{ com.acme}}
> {{ corp-parent}}
> {{ 1.0.0-RELEASE}}
> {{ }}
> {{ com.acme}}
> {{ multi-module}}
> {{ 0.5.2-SNAPSHOT}}
> {{ }}
> {{ module-a}}
> {{ module-b}}
> {{ }}
> {{}}
> The property requested should return /home/me/sources/multi-module,
> regardless of whether it's referenced in any of the child modules (module-a,
> module-b) or in multi-module.
> Note that multi-module itself has parent (e.g. installed in a local
> repository), so the new property should be smart enough to detect it and
> still point to /home/me/sources/multi-module instead of the local repository
> where the corp-parent is installed.
> The use-case for such a property could be to have a directory for combined
> report of static analysis tools. Typical example - jacoco combined coverage
> reports.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739500692 It looks like this pull request was partially merged, because the diff has reduced but is still not empty: https://github.com/apache/maven-ear-plugin/compare/master...mabrarov:MEAR-153  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project
[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244729#comment-17244729
]
Konrad Windszus commented on MNG-7038:
--
Just FTR: There is a plugin which is able to set project property values to
directory paths (https://github.com/jdcasey/directory-maven-plugin). This can
also calculate the toplevel base dir (which is equivalent to the internal
property {{maven.multiModuleProjectDirectory}}).
> Introduce public property to point to a root directory of (multi-module)
> project
>
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
> Issue Type: Improvement
>Reporter: Envious Guest
>Priority: Major
>
> This is a request to expose a property *maven.multiModuleProjectDirectory*
> which is currently internal (or introduce a brand new one with analogous
> functionality).
> * For a single-module project, its value should be same as *project.basedir*
> * For multi-module project, its value should point to a project.basedir of a
> root module
> Example:
> multi-module // located at /home/me/sources
> +- module-a
> +- module B
> Sample multi-module/pom.xml:
> {{}}
> {{ }}
> {{ com.acme}}
> {{ corp-parent}}
> {{ 1.0.0-RELEASE}}
> {{ }}
> {{ com.acme}}
> {{ multi-module}}
> {{ 0.5.2-SNAPSHOT}}
> {{ }}
> {{ module-a}}
> {{ module-b}}
> {{ }}
> {{}}
> The property requested should return /home/me/sources/multi-module,
> regardless of whether it's referenced in any of the child modules (module-a,
> module-b) or in multi-module.
> Note that multi-module itself has parent (e.g. installed in a local
> repository), so the new property should be smart enough to detect it and
> still point to /home/me/sources/multi-module instead of the local repository
> where the corp-parent is installed.
> The use-case for such a property could be to have a directory for combined
> report of static analysis tools. Typical example - jacoco combined coverage
> reports.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SUREFIRE-1584) Rerun Failing Tests with JUnit 5
[ https://issues.apache.org/jira/browse/SUREFIRE-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244728#comment-17244728 ] Tibor Digana edited comment on SUREFIRE-1584 at 12/6/20, 12:13 PM: --- [~ctubbsii] I have to talkout it with [~hboutemy] because i followed the instructions how to deploy the site but obviously something was not done right way. was (Author: tibor17): [~ctubbsii] I ahve to talkout it with [~hboutemy] because i followed the instructions where the site is deployed but obviously something was not done right way. > Rerun Failing Tests with JUnit 5 > > > Key: SUREFIRE-1584 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1584 > Project: Maven Surefire > Issue Type: New Feature > Components: JUnit 5.x support, Maven Surefire Report Plugin >Affects Versions: 2.22.0 >Reporter: Tic Tac >Assignee: Tibor Digana >Priority: Major > Labels: junit5 > Fix For: 3.0.0-M4 > > Attachments: FlakyReruns.png > > > The very useful feature for integration tests ¨[Rerun Failing > Tests|https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html]¨ > is currently only supported for the very outdated JUnit 4. > The documentation says: ¨This feature is supported only for JUnit 4.x.¨ > Can you please support this feature for JUnit 5.3 or later? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1584) Rerun Failing Tests with JUnit 5
[ https://issues.apache.org/jira/browse/SUREFIRE-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244728#comment-17244728 ] Tibor Digana commented on SUREFIRE-1584: [~ctubbsii] I ahve to talkout it with [~hboutemy] because i followed the instructions where the site is deployed but obviously something was not done right way. > Rerun Failing Tests with JUnit 5 > > > Key: SUREFIRE-1584 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1584 > Project: Maven Surefire > Issue Type: New Feature > Components: JUnit 5.x support, Maven Surefire Report Plugin >Affects Versions: 2.22.0 >Reporter: Tic Tac >Assignee: Tibor Digana >Priority: Major > Labels: junit5 > Fix For: 3.0.0-M4 > > Attachments: FlakyReruns.png > > > The very useful feature for integration tests ¨[Rerun Failing > Tests|https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html]¨ > is currently only supported for the very outdated JUnit 4. > The documentation says: ¨This feature is supported only for JUnit 4.x.¨ > Can you please support this feature for JUnit 5.3 or later? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MJLINK-41) Add support for launcher script
[ https://issues.apache.org/jira/browse/MJLINK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MJLINK-41: -- Assignee: Benjamin Marwell > Add support for launcher script > --- > > Key: MJLINK-41 > URL: https://issues.apache.org/jira/browse/MJLINK-41 > Project: Maven JLink Plugin > Issue Type: New Feature >Reporter: Frank Ulbricht >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.0.1 > > > The jlink tool can generate a launcher script (a *.bat file on Windows) so > the user can start the application just with a double-click. > These features should be considered: > * Choose the main module (the one with the main class that should be startet) > * Provide additional parameters (e.g. --enable-preview) > * Optionally, choose between java and javaw (for GUI applications) > Example: jlink --launcher MyApp=com.sample.mymodule leads to a launcher > called MyApp.bat -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MJLINK-41) Add support for launcher script
[ https://issues.apache.org/jira/browse/MJLINK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJLINK-41: --- Fix Version/s: 3.0.1 > Add support for launcher script > --- > > Key: MJLINK-41 > URL: https://issues.apache.org/jira/browse/MJLINK-41 > Project: Maven JLink Plugin > Issue Type: New Feature >Reporter: Frank Ulbricht >Priority: Major > Fix For: 3.0.1 > > > The jlink tool can generate a launcher script (a *.bat file on Windows) so > the user can start the application just with a double-click. > These features should be considered: > * Choose the main module (the one with the main class that should be startet) > * Provide additional parameters (e.g. --enable-preview) > * Optionally, choose between java and javaw (for GUI applications) > Example: jlink --launcher MyApp=com.sample.mymodule leads to a launcher > called MyApp.bat -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MJLINK-53) ITs should fail if no jlink binary is available
[
https://issues.apache.org/jira/browse/MJLINK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MJLINK-53:
---
Fix Version/s: 3.0.1
> ITs should fail if no jlink binary is available
> ---
>
> Key: MJLINK-53
> URL: https://issues.apache.org/jira/browse/MJLINK-53
> Project: Maven JLink Plugin
> Issue Type: Improvement
>Reporter: Benjamin Marwell
>Priority: Major
> Fix For: 3.0.1
>
>
> Currently the ITs will just be skipped if no jlink binary is available:
> {code:java}
> [INFO] --- maven-invoker-plugin:3.2.1:integration-test (integration-test) @
> maven-jlink-plugin ---
> 107[INFO] Running 2 setup jobs:
> 108[INFO] Building: setup-jar-module-info/pom.xml
> 109[INFO] setup-jar-module-info/pom.xml
> SKIPPED due to JRE version
> 110[INFO] Building: setup-jar/pom.xml
> 111[INFO] setup-jar/pom.xml
> SKIPPED due to JRE version
> 112[INFO] Setup done.
> 113[INFO] Building: MJLINK-3_improveVerboseOutput/pom.xml
> 114[INFO] MJLINK-3_improveVerboseOutput/pom.xml
> SKIPPED due to JRE version
> 115[INFO] Building: MJLINK-4_dependencyResolution/pom.xml
> 116[INFO] MJLINK-4_dependencyResolution/pom.xml
> SKIPPED due to JRE version
> 117[INFO] Building: MJLINK-26/pom.xml
> 118[INFO] MJLINK-26/pom.xml
> SKIPPED due to JRE version
> 119
> {code}
> Source:
> [https://github.com/bmarwell/maven-jlink-plugin/runs/1343140417?check_suite_focus=true#step:11:1]
>
> However, building this project (maven-mjlink-plugin) with JDK8 should be
> supported using jlink via toolchains.
>
> To add a little bit more detail:
> https://issues.apache.org/jira/browse/MJLINK-36 is to be implemented via
> multi-module jars (e.g. add a folder {{src/main/java9}}). This means that
> without a Java8+Toolchain execution, the Java 8 code is never executed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MJLINK-53) ITs should fail if no jlink binary is available
[
https://issues.apache.org/jira/browse/MJLINK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MJLINK-53:
--
Assignee: Benjamin Marwell
> ITs should fail if no jlink binary is available
> ---
>
> Key: MJLINK-53
> URL: https://issues.apache.org/jira/browse/MJLINK-53
> Project: Maven JLink Plugin
> Issue Type: Improvement
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Fix For: 3.0.1
>
>
> Currently the ITs will just be skipped if no jlink binary is available:
> {code:java}
> [INFO] --- maven-invoker-plugin:3.2.1:integration-test (integration-test) @
> maven-jlink-plugin ---
> 107[INFO] Running 2 setup jobs:
> 108[INFO] Building: setup-jar-module-info/pom.xml
> 109[INFO] setup-jar-module-info/pom.xml
> SKIPPED due to JRE version
> 110[INFO] Building: setup-jar/pom.xml
> 111[INFO] setup-jar/pom.xml
> SKIPPED due to JRE version
> 112[INFO] Setup done.
> 113[INFO] Building: MJLINK-3_improveVerboseOutput/pom.xml
> 114[INFO] MJLINK-3_improveVerboseOutput/pom.xml
> SKIPPED due to JRE version
> 115[INFO] Building: MJLINK-4_dependencyResolution/pom.xml
> 116[INFO] MJLINK-4_dependencyResolution/pom.xml
> SKIPPED due to JRE version
> 117[INFO] Building: MJLINK-26/pom.xml
> 118[INFO] MJLINK-26/pom.xml
> SKIPPED due to JRE version
> 119
> {code}
> Source:
> [https://github.com/bmarwell/maven-jlink-plugin/runs/1343140417?check_suite_focus=true#step:11:1]
>
> However, building this project (maven-mjlink-plugin) with JDK8 should be
> supported using jlink via toolchains.
>
> To add a little bit more detail:
> https://issues.apache.org/jira/browse/MJLINK-36 is to be implemented via
> multi-module jars (e.g. add a folder {{src/main/java9}}). This means that
> without a Java8+Toolchain execution, the Java 8 code is never executed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on pull request #327: [SUREFIRE-1865] ChecksumCalculator getSha1 does not compute checksums correctly.
Tibor17 commented on pull request #327: URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-739488042 @gianm Pls check the logs from the [build](https://github.com/apache/maven-surefire/pull/327/checks?check_run_id=1505231524). There are 5 checkstyle violations. Pls fix them, squash the commits and rebase. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] MartinKanters merged pull request #328: Fix message about forkCount parameter = 0 - part 2
MartinKanters merged pull request #328: URL: https://github.com/apache/maven-surefire/pull/328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244703#comment-17244703
]
Michael Osipov commented on MNG-6268:
-
I will leave this ticket open for at least another week for [~sewe] and others
to have their say.
> When a reactor build fails Maven should include -f (if used) in command line
> suggestion
> ---
>
> Key: MNG-6268
> URL: https://issues.apache.org/jira/browse/MNG-6268
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Andreas Sewe
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 4.0.x-candidate, wontfix-candidate
>
>
> When a reactor build fails, Maven prints out a helpful suggestion on how to
> resume.
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :example
> {noformat}
> Unfortunately, when running {{mvn}} with {{-f}}, this suggestion is wrong;
> Maven will either pick the wrong {{pom.xml}} or simply won’t find any; in
> either case, the {{pom.xml}} specified with {{-f}} is *crucial* information
> that was left out of the suggestion.
> FYI, this is related to MNG-6028, but covers a different bit of info that
> IMHO should be part of the suggestion. Hence this separate issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MJLINK-58) Remove usage of plexus utils, use commons lang or native java instead.
[
https://issues.apache.org/jira/browse/MJLINK-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244699#comment-17244699
]
Hudson commented on MJLINK-58:
--
Build failed in Jenkins: Maven » Maven TLP » maven-jlink-plugin » master #40
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-jlink-plugin/job/master/40/
> Remove usage of plexus utils, use commons lang or native java instead.
> --
>
> Key: MJLINK-58
> URL: https://issues.apache.org/jira/browse/MJLINK-58
> Project: Maven JLink Plugin
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Fix For: 3.0.1
>
>
> Remove usage of plexus utils, use commons lang or native java instead.
> Most {{nullOrEmtpy}} calls can easily be avoided by returning an optional
> from a getter method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MJLINK-58) Remove usage of plexus utils, use commons lang or native java instead.
[
https://issues.apache.org/jira/browse/MJLINK-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MJLINK-58.
Assignee: Benjamin Marwell
Resolution: Fixed
> Remove usage of plexus utils, use commons lang or native java instead.
> --
>
> Key: MJLINK-58
> URL: https://issues.apache.org/jira/browse/MJLINK-58
> Project: Maven JLink Plugin
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Fix For: 3.0.1
>
>
> Remove usage of plexus utils, use commons lang or native java instead.
> Most {{nullOrEmtpy}} calls can easily be avoided by returning an optional
> from a getter method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-jlink-plugin] bmarwell edited a comment on pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …
bmarwell edited a comment on pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-739480883 Fixed in https://github.com/apache/maven-jlink-plugin/commit/24f2bf8d10df37696f5901f4353e2ef1bd3fdd0b This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell closed pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …
bmarwell closed pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …
bmarwell commented on pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-739480883 Fixed in #24f2bf8d10df37696f5901f4353e2ef1bd3fdd0b This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] MartinKanters opened a new pull request #328: Fix message about forkCount parameter = 0 - part 2
MartinKanters opened a new pull request #328: URL: https://github.com/apache/maven-surefire/pull/328 Continuing https://github.com/apache/maven-surefire/pull/326/... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
