[jira] [Commented] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256761#comment-17256761
]
ASF GitHub Bot commented on DOXIA-616:
--
bertysentry commented on a change in pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#discussion_r550358090
##
File path:
doxia-modules/doxia-module-markdown/src/test/resources/fenced-code-block.md
##
@@ -0,0 +1,5 @@
+Below code is Java:
+
+```java
+System.out.println(helloWorld);
Review comment:
Nah, it's on purpose. This is just a test resource that is translated as
Sink events. But the presence of quotes around `helloWorld` breaks the *text*
Sink event in several fragment, which is annoying for my test.
But we can consider *helloWorld* is a *String* variable defined somewhere
else.
Again, this is just an example for the unit tests. We don't need valid Java
code here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Markdown: Properly expose the language specified in fenced code blocks
> --
>
> Key: DOXIA-616
> URL: https://issues.apache.org/jira/browse/DOXIA-616
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Markdown
>Affects Versions: 1.8, 1.9, 1.9.1
>Reporter: Bertrand Martin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.2
>
>
> h1. Use Case
> Writers can specify the language used in a fenced code block (typically for
> syntax highlighting), as in the example below:
> {code}
> ```java
> System.out.println("Beautiful\n");
> ```
> {code}
> Currently, the Doxia module for Markdown does not expose this information
> ("java") in the produced HTML, so a Maven skin (or frontend renderer) cannot
> leverage it.
> Produced HTML:
> {code:html}
>
>
> System.out.println("Beautiful\n");
>
>
> {code}
> Wanted result:
> {code:html}
>
>
> System.out.println("Beautiful\n");
>
>
> {code}
> h1. Specification
> Un-comment this block:
> https://github.com/apache/maven-doxia/blob/c439714e8f4a9e86f9962ac6be9a0077ae9b4d30/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer.java#L103
> This should do the trick.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-doxia] bertysentry commented on a change in pull request #49: [DOXIA-616]
bertysentry commented on a change in pull request #49: URL: https://github.com/apache/maven-doxia/pull/49#discussion_r550358090 ## File path: doxia-modules/doxia-module-markdown/src/test/resources/fenced-code-block.md ## @@ -0,0 +1,5 @@ +Below code is Java: + +```java +System.out.println(helloWorld); Review comment: Nah, it's on purpose. This is just a test resource that is translated as Sink events. But the presence of quotes around `helloWorld` breaks the *text* Sink event in several fragment, which is annoying for my test. But we can consider *helloWorld* is a *String* variable defined somewhere else. Again, this is just an example for the unit tests. We don't need valid Java code here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256760#comment-17256760
]
ASF GitHub Bot commented on DOXIA-616:
--
bertysentry commented on a change in pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#discussion_r550357704
##
File path:
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownParser.java
##
@@ -130,133 +184,98 @@ public void parse( Reader source, Sink sink )
* @return HTML content generated by flexmark-java
* @throws IOException passed through
*/
-String toHtml( Reader source )
+CharSequence toHtml( Reader source )
throws IOException
{
+// Read the source
String text = IOUtil.toString( source );
-MutableDataHolder flexmarkOptions =
PegdownOptionsAdapter.flexmarkOptions(
-Extensions.ALL & ~( Extensions.HARDWRAPS |
Extensions.ANCHORLINKS ) ).toMutable();
-ArrayList extensions = new ArrayList<>();
-for ( Extension extension : flexmarkOptions.get(
com.vladsch.flexmark.parser.Parser.EXTENSIONS ) )
-{
-extensions.add( extension );
-}
-
-extensions.add( FlexmarkDoxiaExtension.create() );
-flexmarkOptions.set( com.vladsch.flexmark.parser.Parser.EXTENSIONS,
extensions );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_OPEN_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_CLOSE_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.MAX_TRAILING_BLANK_LINES, -1 );
-
-com.vladsch.flexmark.parser.Parser parser =
com.vladsch.flexmark.parser.Parser.builder( flexmarkOptions )
-.build();
-HtmlRenderer renderer = HtmlRenderer.builder( flexmarkOptions )
-.linkResolverFactory( new
FlexmarkDoxiaLinkResolver.Factory() )
-.build();
-
+// Now, build the HTML document
StringBuilder html = new StringBuilder( 1000 );
html.append( "" );
html.append( "" );
-Pattern metadataPattern = Pattern.compile(
MULTI_MARKDOWN_METADATA_SECTION, Pattern.MULTILINE );
-Matcher metadataMatcher = metadataPattern.matcher( text );
+
+// First, we interpret the "metadata" section of the document and add
the corresponding HTML headers
+Matcher metadataMatcher = METADATA_SECTION_PATTERN.matcher( text );
boolean haveTitle = false;
if ( metadataMatcher.find() )
{
-metadataPattern = Pattern.compile( MULTI_MARKDOWN_METADATA_ENTRY,
Pattern.MULTILINE );
-Matcher lineMatcher = metadataPattern.matcher(
metadataMatcher.group( 1 ) );
-boolean first = true;
-while ( lineMatcher.find() )
+Matcher entryMatcher = METADATA_ENTRY_PATTERN.matcher(
metadataMatcher.group( 0 ) );
+while ( entryMatcher.find() )
{
-String key = StringUtils.trimToEmpty( lineMatcher.group( 1 ) );
-if ( first )
-{
-boolean found = false;
-for ( String k : STANDARD_METADATA_KEYS )
-{
-if ( k.equalsIgnoreCase( key ) )
-{
-found = true;
-break;
-}
-}
-if ( !found )
-{
-break;
-}
-first = false;
-}
-String value = StringUtils.trimToEmpty( lineMatcher.group( 2 )
);
+String key = entryMatcher.group( 1 );
+String value = entryMatcher.group( 2 );
if ( "title".equalsIgnoreCase( key ) )
{
haveTitle = true;
html.append( "" );
-html.append( StringEscapeUtils.escapeXml( value ) );
+html.append( HtmlTools.escapeHTML( value, false ) );
html.append( "" );
}
-else if ( "author".equalsIgnoreCase( key ) )
-{
-html.append( "" );
-}
-else if ( "date".equalsIgnoreCase( key ) )
-{
-html.append( "" );
-}
else
{
-html.append( "" );
+html.append( "" );
}
}
-if ( !first )
-{
-text = text.substring( metadataMatcher.end() );
-}
+
+// Trim the metadata from the source
+text = text.substring( metadataMatcher.end( 0 ) );
+
}
-Node rootNode
[jira] [Commented] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256759#comment-17256759
]
ASF GitHub Bot commented on DOXIA-616:
--
bertysentry commented on a change in pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#discussion_r550357588
##
File path:
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownParser.java
##
@@ -130,133 +184,98 @@ public void parse( Reader source, Sink sink )
* @return HTML content generated by flexmark-java
* @throws IOException passed through
*/
-String toHtml( Reader source )
+CharSequence toHtml( Reader source )
throws IOException
{
+// Read the source
String text = IOUtil.toString( source );
-MutableDataHolder flexmarkOptions =
PegdownOptionsAdapter.flexmarkOptions(
-Extensions.ALL & ~( Extensions.HARDWRAPS |
Extensions.ANCHORLINKS ) ).toMutable();
-ArrayList extensions = new ArrayList<>();
-for ( Extension extension : flexmarkOptions.get(
com.vladsch.flexmark.parser.Parser.EXTENSIONS ) )
-{
-extensions.add( extension );
-}
-
-extensions.add( FlexmarkDoxiaExtension.create() );
-flexmarkOptions.set( com.vladsch.flexmark.parser.Parser.EXTENSIONS,
extensions );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_OPEN_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_CLOSE_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.MAX_TRAILING_BLANK_LINES, -1 );
-
-com.vladsch.flexmark.parser.Parser parser =
com.vladsch.flexmark.parser.Parser.builder( flexmarkOptions )
-.build();
-HtmlRenderer renderer = HtmlRenderer.builder( flexmarkOptions )
-.linkResolverFactory( new
FlexmarkDoxiaLinkResolver.Factory() )
-.build();
-
+// Now, build the HTML document
StringBuilder html = new StringBuilder( 1000 );
html.append( "" );
html.append( "" );
-Pattern metadataPattern = Pattern.compile(
MULTI_MARKDOWN_METADATA_SECTION, Pattern.MULTILINE );
-Matcher metadataMatcher = metadataPattern.matcher( text );
+
+// First, we interpret the "metadata" section of the document and add
the corresponding HTML headers
+Matcher metadataMatcher = METADATA_SECTION_PATTERN.matcher( text );
boolean haveTitle = false;
if ( metadataMatcher.find() )
{
-metadataPattern = Pattern.compile( MULTI_MARKDOWN_METADATA_ENTRY,
Pattern.MULTILINE );
-Matcher lineMatcher = metadataPattern.matcher(
metadataMatcher.group( 1 ) );
-boolean first = true;
-while ( lineMatcher.find() )
+Matcher entryMatcher = METADATA_ENTRY_PATTERN.matcher(
metadataMatcher.group( 0 ) );
+while ( entryMatcher.find() )
{
-String key = StringUtils.trimToEmpty( lineMatcher.group( 1 ) );
-if ( first )
-{
-boolean found = false;
-for ( String k : STANDARD_METADATA_KEYS )
-{
-if ( k.equalsIgnoreCase( key ) )
-{
-found = true;
-break;
-}
-}
-if ( !found )
-{
-break;
-}
-first = false;
-}
-String value = StringUtils.trimToEmpty( lineMatcher.group( 2 )
);
+String key = entryMatcher.group( 1 );
+String value = entryMatcher.group( 2 );
if ( "title".equalsIgnoreCase( key ) )
{
haveTitle = true;
html.append( "" );
-html.append( StringEscapeUtils.escapeXml( value ) );
+html.append( HtmlTools.escapeHTML( value, false ) );
Review comment:
The only difference between *false* and *true* in
*HtmlTools.escapeHTML()* is the handling of the apostrophe (should it be
replaced with `'` or not). As we're inside a `` element, there is
no need to replace the apostrophe.
However, on line 218 and 221, we're inside the attribute of an element, i.e.
inside quotes, and that's why we need to escape the apostrophe here.
Note that the presence (and absence) of apostrophe in the title and
metadatas is covered with unit tests (see *testMetadataSinkEvent()* in
**MarkdownParserTest.java**)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[GitHub] [maven-doxia] bertysentry commented on a change in pull request #49: [DOXIA-616]
bertysentry commented on a change in pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#discussion_r550357704
##
File path:
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownParser.java
##
@@ -130,133 +184,98 @@ public void parse( Reader source, Sink sink )
* @return HTML content generated by flexmark-java
* @throws IOException passed through
*/
-String toHtml( Reader source )
+CharSequence toHtml( Reader source )
throws IOException
{
+// Read the source
String text = IOUtil.toString( source );
-MutableDataHolder flexmarkOptions =
PegdownOptionsAdapter.flexmarkOptions(
-Extensions.ALL & ~( Extensions.HARDWRAPS |
Extensions.ANCHORLINKS ) ).toMutable();
-ArrayList extensions = new ArrayList<>();
-for ( Extension extension : flexmarkOptions.get(
com.vladsch.flexmark.parser.Parser.EXTENSIONS ) )
-{
-extensions.add( extension );
-}
-
-extensions.add( FlexmarkDoxiaExtension.create() );
-flexmarkOptions.set( com.vladsch.flexmark.parser.Parser.EXTENSIONS,
extensions );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_OPEN_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_CLOSE_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.MAX_TRAILING_BLANK_LINES, -1 );
-
-com.vladsch.flexmark.parser.Parser parser =
com.vladsch.flexmark.parser.Parser.builder( flexmarkOptions )
-.build();
-HtmlRenderer renderer = HtmlRenderer.builder( flexmarkOptions )
-.linkResolverFactory( new
FlexmarkDoxiaLinkResolver.Factory() )
-.build();
-
+// Now, build the HTML document
StringBuilder html = new StringBuilder( 1000 );
html.append( "" );
html.append( "" );
-Pattern metadataPattern = Pattern.compile(
MULTI_MARKDOWN_METADATA_SECTION, Pattern.MULTILINE );
-Matcher metadataMatcher = metadataPattern.matcher( text );
+
+// First, we interpret the "metadata" section of the document and add
the corresponding HTML headers
+Matcher metadataMatcher = METADATA_SECTION_PATTERN.matcher( text );
boolean haveTitle = false;
if ( metadataMatcher.find() )
{
-metadataPattern = Pattern.compile( MULTI_MARKDOWN_METADATA_ENTRY,
Pattern.MULTILINE );
-Matcher lineMatcher = metadataPattern.matcher(
metadataMatcher.group( 1 ) );
-boolean first = true;
-while ( lineMatcher.find() )
+Matcher entryMatcher = METADATA_ENTRY_PATTERN.matcher(
metadataMatcher.group( 0 ) );
+while ( entryMatcher.find() )
{
-String key = StringUtils.trimToEmpty( lineMatcher.group( 1 ) );
-if ( first )
-{
-boolean found = false;
-for ( String k : STANDARD_METADATA_KEYS )
-{
-if ( k.equalsIgnoreCase( key ) )
-{
-found = true;
-break;
-}
-}
-if ( !found )
-{
-break;
-}
-first = false;
-}
-String value = StringUtils.trimToEmpty( lineMatcher.group( 2 )
);
+String key = entryMatcher.group( 1 );
+String value = entryMatcher.group( 2 );
if ( "title".equalsIgnoreCase( key ) )
{
haveTitle = true;
html.append( "" );
-html.append( StringEscapeUtils.escapeXml( value ) );
+html.append( HtmlTools.escapeHTML( value, false ) );
html.append( "" );
}
-else if ( "author".equalsIgnoreCase( key ) )
-{
-html.append( "" );
-}
-else if ( "date".equalsIgnoreCase( key ) )
-{
-html.append( "" );
-}
else
{
-html.append( "" );
+html.append( "" );
}
}
-if ( !first )
-{
-text = text.substring( metadataMatcher.end() );
-}
+
+// Trim the metadata from the source
+text = text.substring( metadataMatcher.end( 0 ) );
+
}
-Node rootNode = parser.parse( text );
-String markdownHtml = renderer.render( rootNode );
+// Now is the time to parse the Markdown document
+// (after we've trimmed out the metadatas, and before we check for its
headings)
+Node doc
[GitHub] [maven-doxia] bertysentry commented on a change in pull request #49: [DOXIA-616]
bertysentry commented on a change in pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#discussion_r550357588
##
File path:
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownParser.java
##
@@ -130,133 +184,98 @@ public void parse( Reader source, Sink sink )
* @return HTML content generated by flexmark-java
* @throws IOException passed through
*/
-String toHtml( Reader source )
+CharSequence toHtml( Reader source )
throws IOException
{
+// Read the source
String text = IOUtil.toString( source );
-MutableDataHolder flexmarkOptions =
PegdownOptionsAdapter.flexmarkOptions(
-Extensions.ALL & ~( Extensions.HARDWRAPS |
Extensions.ANCHORLINKS ) ).toMutable();
-ArrayList extensions = new ArrayList<>();
-for ( Extension extension : flexmarkOptions.get(
com.vladsch.flexmark.parser.Parser.EXTENSIONS ) )
-{
-extensions.add( extension );
-}
-
-extensions.add( FlexmarkDoxiaExtension.create() );
-flexmarkOptions.set( com.vladsch.flexmark.parser.Parser.EXTENSIONS,
extensions );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_OPEN_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_CLOSE_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.MAX_TRAILING_BLANK_LINES, -1 );
-
-com.vladsch.flexmark.parser.Parser parser =
com.vladsch.flexmark.parser.Parser.builder( flexmarkOptions )
-.build();
-HtmlRenderer renderer = HtmlRenderer.builder( flexmarkOptions )
-.linkResolverFactory( new
FlexmarkDoxiaLinkResolver.Factory() )
-.build();
-
+// Now, build the HTML document
StringBuilder html = new StringBuilder( 1000 );
html.append( "" );
html.append( "" );
-Pattern metadataPattern = Pattern.compile(
MULTI_MARKDOWN_METADATA_SECTION, Pattern.MULTILINE );
-Matcher metadataMatcher = metadataPattern.matcher( text );
+
+// First, we interpret the "metadata" section of the document and add
the corresponding HTML headers
+Matcher metadataMatcher = METADATA_SECTION_PATTERN.matcher( text );
boolean haveTitle = false;
if ( metadataMatcher.find() )
{
-metadataPattern = Pattern.compile( MULTI_MARKDOWN_METADATA_ENTRY,
Pattern.MULTILINE );
-Matcher lineMatcher = metadataPattern.matcher(
metadataMatcher.group( 1 ) );
-boolean first = true;
-while ( lineMatcher.find() )
+Matcher entryMatcher = METADATA_ENTRY_PATTERN.matcher(
metadataMatcher.group( 0 ) );
+while ( entryMatcher.find() )
{
-String key = StringUtils.trimToEmpty( lineMatcher.group( 1 ) );
-if ( first )
-{
-boolean found = false;
-for ( String k : STANDARD_METADATA_KEYS )
-{
-if ( k.equalsIgnoreCase( key ) )
-{
-found = true;
-break;
-}
-}
-if ( !found )
-{
-break;
-}
-first = false;
-}
-String value = StringUtils.trimToEmpty( lineMatcher.group( 2 )
);
+String key = entryMatcher.group( 1 );
+String value = entryMatcher.group( 2 );
if ( "title".equalsIgnoreCase( key ) )
{
haveTitle = true;
html.append( "" );
-html.append( StringEscapeUtils.escapeXml( value ) );
+html.append( HtmlTools.escapeHTML( value, false ) );
Review comment:
The only difference between *false* and *true* in
*HtmlTools.escapeHTML()* is the handling of the apostrophe (should it be
replaced with `'` or not). As we're inside a `` element, there is
no need to replace the apostrophe.
However, on line 218 and 221, we're inside the attribute of an element, i.e.
inside quotes, and that's why we need to escape the apostrophe here.
Note that the presence (and absence) of apostrophe in the title and
metadatas is covered with unit tests (see *testMetadataSinkEvent()* in
**MarkdownParserTest.java**)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o opened a new pull request #424: Use system line separator wherever possible
michael-o opened a new pull request #424: URL: https://github.com/apache/maven/pull/424 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
michael-o commented on a change in pull request #423:
URL: https://github.com/apache/maven/pull/423#discussion_r550349032
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -108,15 +109,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
// With Maven 4's build/consumer the POM will always rewrite during
distribution.
// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
// Fail as long as there's no solution available yet
-Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
-.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() )
- && "org.apache.maven.plugins".equals(
m.getGroupId() ) )
-.findAny();
-
-if ( gpgMojo.isPresent() )
+if ( Features.buildConsumer().isActive() )
{
-throw new LifecycleExecutionException( "The maven-gpg-plugin is
not supported by Maven 4."
-+ " Verify if there is a compatible signing solution or use
Maven 3" );
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "maven-gpg-plugin".equals(
m.getArtifactId() )
+ && "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
+throw new LifecycleExecutionException( "The maven-gpg-plugin
is not supported by Maven 4."
++ " Verify if there is a compatible signing solution"
++ " or add -D" + Features.buildConsumer().propertyName() +
"=false"
++ " or use Maven 3" );
Review comment:
Sentence ends here. Add a full stop.
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -108,15 +109,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
// With Maven 4's build/consumer the POM will always rewrite during
distribution.
// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
// Fail as long as there's no solution available yet
-Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
-.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() )
- && "org.apache.maven.plugins".equals(
m.getGroupId() ) )
-.findAny();
-
-if ( gpgMojo.isPresent() )
+if ( Features.buildConsumer().isActive() )
{
-throw new LifecycleExecutionException( "The maven-gpg-plugin is
not supported by Maven 4."
-+ " Verify if there is a compatible signing solution or use
Maven 3" );
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "maven-gpg-plugin".equals(
m.getArtifactId() )
+ && "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
+throw new LifecycleExecutionException( "The maven-gpg-plugin
is not supported by Maven 4."
++ " Verify if there is a compatible signing solution"
++ " or add -D" + Features.buildConsumer().propertyName() +
"=false"
Review comment:
the first "or" should be replaced with a comma.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MARCHETYPES-71) update plugin versions used in archetypes
[ https://issues.apache.org/jira/browse/MARCHETYPES-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256754#comment-17256754 ] Hudson commented on MARCHETYPES-71: --- Build failed in Jenkins: Maven » Maven TLP » maven-archetypes » master #24 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-archetypes/job/master/24/ > update plugin versions used in archetypes > - > > Key: MARCHETYPES-71 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-71 > Project: Maven Archetype Bundles > Issue Type: Dependency upgrade >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] michael-o commented on pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
michael-o commented on pull request #423: URL: https://github.com/apache/maven/pull/423#issuecomment-752776107 > > > Good question. You will be fine if build/consumer is disabled. Do you expect this to be added to the message? But I don't expect to fail if this feature is disabled because the POM is never transformed. If the feature is enabled, the exception should say that this plugin can only be used when this feature is *disabled*. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rfscholte commented on pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
rfscholte commented on pull request #423: URL: https://github.com/apache/maven/pull/423#issuecomment-752775667 Good question. You will be fine if build/consumer is disabled. Do you expect this to be added to the message? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7062) Add first class support for deployment repositories to settings.xml
[
https://issues.apache.org/jira/browse/MNG-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256746#comment-17256746
]
Michael Osipov commented on MNG-7062:
-
OK, I see this makes sense of course. This piece of information needs to be
retained.
> Add first class support for deployment repositories to settings.xml
> ---
>
> Key: MNG-7062
> URL: https://issues.apache.org/jira/browse/MNG-7062
> Project: Maven
> Issue Type: Improvement
> Components: Settings
>Affects Versions: 3.6.3
>Reporter: Phil Clay
>Priority: Minor
>
> The maven settings.xml file currently has first-class support for controlling
> artifact _downloads_ via the [mirrors
> section|https://maven.apache.org/settings.html#Mirrors]. It would be
> intuitive and logical if the the settings.xml file also had first-class
> support for controlling artifact _uploads_.
> Being able to control _both_ artifact uploads and downloads from the
> settings.xml file allows for easier centralized management in organizations
> using a repository manager, in which all downloads and uploads should go
> through the repository manager.
> The current approach of being able to point artifact downloads to a
> repository manager in settings.xml, but not being able to point uploads to
> the same repository manager in settings.xml is clunky and not intuitive.
> Here are several alternatives that can be used today, but none are as
> easy/intuitive as first class support in the settings.xml would be.
> # Define downloads in settings.xml file, but define uploads via
> {{distributionManagement}} in poms.
> # Define {{alt*DeploymentRepository}} properties in settings.xml (as
> mentioned in [PR #23|https://github.com/apache/maven-site/pull/223]). Do not
> use {{distributionManagement}} in poms at all.
> # Define custom release/snapshot repo properties in settings.xml, and define
> a {{distributionManagement}} section in poms that references those properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] michael-o commented on pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
michael-o commented on pull request #423: URL: https://github.com/apache/maven/pull/423#issuecomment-752774281 Should this fail to when build consumer/producer feature is disabled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MWRAPPER-11) Could not find artifact org.apache.maven:apache-maven-wrapper:zip:script
[
https://issues.apache.org/jira/browse/MWRAPPER-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Cushing updated MWRAPPER-11:
--
Description:
trying to upgrade from the original? non apache plugin. I get this stacktrace
{code}
ERROR] Failed to execute goal
org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on
project dex: Could not find artifact org.apache.maven:apache-maven-wrapper:z
ip:script:3.6.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on
project dex: Could not find
artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central
(https://repo.maven.apache.org/maven2)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:356)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.apache.maven.wrapper.BootstrapMainStarter.start
(BootstrapMainStarter.java:39)
at org.apache.maven.wrapper.WrapperExecutor.execute
(WrapperExecutor.java:122)
at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
Caused by: org.apache.maven.plugin.MojoExecutionException: Could not find
artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central
(https://repo.maven.apache.org/mave
n2)
at org.apache.maven.plugins.wrapper.WrapperMojo.execute
(WrapperMojo.java:127)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Metho
[jira] [Updated] (MWRAPPER-11) Could not find artifact org.apache.maven:apache-maven-wrapper:zip:script
[
https://issues.apache.org/jira/browse/MWRAPPER-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Cushing updated MWRAPPER-11:
--
Description:
trying to upgrade from the original? non apache plugin. I get this stacktrace
[
{code:java}
ERROR] Failed to execute goal
org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on
project dex: Could not find artifact org.apache.maven:apache-maven-wrapper:z
ip:script:3.6.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on
project dex: Could not find
artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central
(https://repo.maven.apache.org/maven2)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:356)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.apache.maven.wrapper.BootstrapMainStarter.start
(BootstrapMainStarter.java:39)
at org.apache.maven.wrapper.WrapperExecutor.execute
(WrapperExecutor.java:122)
at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
Caused by: org.apache.maven.plugin.MojoExecutionException: Could not find
artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central
(https://repo.maven.apache.org/mave
n2)
at org.apache.maven.plugins.wrapper.WrapperMojo.execute
(WrapperMojo.java:127)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflec
[jira] [Updated] (MWRAPPER-11) Could not find artifact org.apache.maven:apache-maven-wrapper:zip:script
[
https://issues.apache.org/jira/browse/MWRAPPER-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Cushing updated MWRAPPER-11:
--
Description:
trying to upgrade from the original? non apache plugin. I get this stacktrace
{{code}}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on
project dex: Could not find artifact org.apache.maven:apache-maven-wrapper:z
ip:script:3.6.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on
project dex: Could not find
artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central
(https://repo.maven.apache.org/maven2)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:356)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.apache.maven.wrapper.BootstrapMainStarter.start
(BootstrapMainStarter.java:39)
at org.apache.maven.wrapper.WrapperExecutor.execute
(WrapperExecutor.java:122)
at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
Caused by: org.apache.maven.plugin.MojoExecutionException: Could not find
artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central
(https://repo.maven.apache.org/mave
n2)
at org.apache.maven.plugins.wrapper.WrapperMojo.execute
(WrapperMojo.java:127)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Me
[jira] [Updated] (MWRAPPER-11) Could not find artifact org.apache.maven:apache-maven-wrapper:zip:script
[
https://issues.apache.org/jira/browse/MWRAPPER-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Cushing updated MWRAPPER-11:
--
Description:
trying to upgrade from the original? non apache plugin. I get this stacktrace
```
{{code}}[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on
project dex: Could not find artifact org.apache.maven:apache-maven-wrapper:z
ip:script:3.6.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on
project dex: Could not find
artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central
(https://repo.maven.apache.org/maven2)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:356)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.apache.maven.wrapper.BootstrapMainStarter.start
(BootstrapMainStarter.java:39)
at org.apache.maven.wrapper.WrapperExecutor.execute
(WrapperExecutor.java:122)
at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55)
Caused by: org.apache.maven.plugin.MojoExecutionException: Could not find
artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central
(https://repo.maven.apache.org/mave
n2)
at org.apache.maven.plugins.wrapper.WrapperMojo.execute
(WrapperMojo.java:127)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect
[jira] [Updated] (MWRAPPER-11) Could not find artifact org.apache.maven:apache-maven-wrapper:zip:script
[ https://issues.apache.org/jira/browse/MWRAPPER-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Cushing updated MWRAPPER-11: -- Description: trying to upgrade from the original? non apache plugin. I get this stacktrace ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on project dex: Could not find artifact org.apache.maven:apache-maven-wrapper:z ip:script:3.6.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-wrapper-plugin:3.0.1:wrapper (default-cli) on project dex: Could not find artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central (https://repo.maven.apache.org/maven2) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:498) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:498) at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:39) at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122) at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:55) Caused by: org.apache.maven.plugin.MojoExecutionException: Could not find artifact org.apache.maven:apache-maven-wrapper:zip:script:3.6.0 in central (https://repo.maven.apache.org/mave n2) at org.apache.maven.plugins.wrapper.WrapperMojo.execute (WrapperMojo.java:127) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.
[jira] [Commented] (MNG-7062) Add first class support for deployment repositories to settings.xml
[
https://issues.apache.org/jira/browse/MNG-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256739#comment-17256739
]
Robert Scholte commented on MNG-7062:
-
Nobody can publish directly to central. If you have issues with some unfamiliar
artifact, this could help you trace down its origin. That kind of information
can be very valuable, even though it is not used dependency resolution.
> Add first class support for deployment repositories to settings.xml
> ---
>
> Key: MNG-7062
> URL: https://issues.apache.org/jira/browse/MNG-7062
> Project: Maven
> Issue Type: Improvement
> Components: Settings
>Affects Versions: 3.6.3
>Reporter: Phil Clay
>Priority: Minor
>
> The maven settings.xml file currently has first-class support for controlling
> artifact _downloads_ via the [mirrors
> section|https://maven.apache.org/settings.html#Mirrors]. It would be
> intuitive and logical if the the settings.xml file also had first-class
> support for controlling artifact _uploads_.
> Being able to control _both_ artifact uploads and downloads from the
> settings.xml file allows for easier centralized management in organizations
> using a repository manager, in which all downloads and uploads should go
> through the repository manager.
> The current approach of being able to point artifact downloads to a
> repository manager in settings.xml, but not being able to point uploads to
> the same repository manager in settings.xml is clunky and not intuitive.
> Here are several alternatives that can be used today, but none are as
> easy/intuitive as first class support in the settings.xml would be.
> # Define downloads in settings.xml file, but define uploads via
> {{distributionManagement}} in poms.
> # Define {{alt*DeploymentRepository}} properties in settings.xml (as
> mentioned in [PR #23|https://github.com/apache/maven-site/pull/223]). Do not
> use {{distributionManagement}} in poms at all.
> # Define custom release/snapshot repo properties in settings.xml, and define
> a {{distributionManagement}} section in poms that references those properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MWRAPPER-11) Could not find artifact org.apache.maven:apache-maven-wrapper:zip:script
Caleb Cushing created MWRAPPER-11: - Summary: Could not find artifact org.apache.maven:apache-maven-wrapper:zip:script Key: MWRAPPER-11 URL: https://issues.apache.org/jira/browse/MWRAPPER-11 Project: Maven Wrapper Issue Type: Bug Affects Versions: 3.0.1 Reporter: Caleb Cushing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] slachiewicz commented on pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
slachiewicz commented on pull request #423: URL: https://github.com/apache/maven/pull/423#issuecomment-752768758 Cool, let me try to test it again, releasing something ;-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
rfscholte commented on a change in pull request #423:
URL: https://github.com/apache/maven/pull/423#discussion_r550335853
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
lifecycleDebugLogger.debugProjectPlan( project, executionPlan );
+// With Maven 4's build/consumer the POM will always rewrite during
distribution.
+// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
+// Fail as long as there's no solution available yet
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
Review comment:
To me the stream is not complex enough to justify this propsed
extraction.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MARCHETYPES-71) update plugin versions used in archetypes
Herve Boutemy created MARCHETYPES-71: Summary: update plugin versions used in archetypes Key: MARCHETYPES-71 URL: https://issues.apache.org/jira/browse/MARCHETYPES-71 Project: Maven Archetype Bundles Issue Type: Dependency upgrade Affects Versions: 1.4 Reporter: Herve Boutemy Fix For: 1.5 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MEJB-130) Plugin does not accept ejbVersion 4.0
[ https://issues.apache.org/jira/browse/MEJB-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256737#comment-17256737 ] Hudson commented on MEJB-130: - Build failed in Jenkins: Maven » Maven TLP » maven-ejb-plugin » master #21 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ejb-plugin/job/master/21/ > Plugin does not accept ejbVersion 4.0 > - > > Key: MEJB-130 > URL: https://issues.apache.org/jira/browse/MEJB-130 > Project: Maven EJB Plugin > Issue Type: Bug >Reporter: Piotr Zygielo >Priority: Major > > EJB being now with Jakarta is released with new spec under the version 4.0 > ([https://repo.maven.apache.org/maven2/jakarta/ejb/jakarta.ejb-api/4.0.0/], > [https://projects.eclipse.org/projects/ee4j.ejb/releases/4.0]) > However plugin is not prepared to deal with that. > Failing IT presented as first commit in > https://github.com/apache/maven-ejb-plugin/pull/11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MEJB-130) Plugin does not accept ejbVersion 4.0
[ https://issues.apache.org/jira/browse/MEJB-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MEJB-130. -- > Plugin does not accept ejbVersion 4.0 > - > > Key: MEJB-130 > URL: https://issues.apache.org/jira/browse/MEJB-130 > Project: Maven EJB Plugin > Issue Type: Bug >Reporter: Piotr Zygielo >Priority: Major > > EJB being now with Jakarta is released with new spec under the version 4.0 > ([https://repo.maven.apache.org/maven2/jakarta/ejb/jakarta.ejb-api/4.0.0/], > [https://projects.eclipse.org/projects/ee4j.ejb/releases/4.0]) > However plugin is not prepared to deal with that. > Failing IT presented as first commit in > https://github.com/apache/maven-ejb-plugin/pull/11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MEJB-130) Plugin does not accept ejbVersion 4.0
[ https://issues.apache.org/jira/browse/MEJB-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MEJB-130. Resolution: Fixed > Plugin does not accept ejbVersion 4.0 > - > > Key: MEJB-130 > URL: https://issues.apache.org/jira/browse/MEJB-130 > Project: Maven EJB Plugin > Issue Type: Bug >Reporter: Piotr Zygielo >Priority: Major > > EJB being now with Jakarta is released with new spec under the version 4.0 > ([https://repo.maven.apache.org/maven2/jakarta/ejb/jakarta.ejb-api/4.0.0/], > [https://projects.eclipse.org/projects/ee4j.ejb/releases/4.0]) > However plugin is not prepared to deal with that. > Failing IT presented as first commit in > https://github.com/apache/maven-ejb-plugin/pull/11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MARCHETYPES-70) Quickstart support for junit 5 and java 9+
[
https://issues.apache.org/jira/browse/MARCHETYPES-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy closed MARCHETYPES-70.
Fix Version/s: 1.5
Assignee: Enrico Olivelli
Resolution: Fixed
PR merged in
https://github.com/apache/maven-archetypes/commit/f7627910d41722ee56be2e3b96d57958e84a0750
> Quickstart support for junit 5 and java 9+
> --
>
> Key: MARCHETYPES-70
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-70
> Project: Maven Archetype Bundles
> Issue Type: Improvement
> Components: Maven Quickstart Archetype
>Affects Versions: 1.3, 1.4
>Reporter: Jurrian Fahner
>Assignee: Enrico Olivelli
>Priority: Minor
> Fix For: 1.5
>
>
> Quickstart archetype is outdated due to the support for java versions below 9
> and junit 4.
> The changes needs to be made backwards compatible in order to avoid breaking
> changes for legacy projects.
> For the support of java 9+ the java version tag must change from:
> {code:xml}
>
> 1.8
> 1.8
> {code}
> to:
> {code:xml}
>
> 11
> {code}
> For junit 5 support it is needed to add junit-jupiter-api and the vintage
> plugin, to add support for large older projects (with old junit tests in it).
> Example for dependencies for junit 5 it will look like:
> {code:xml}
>
> org.junit.jupiter
> junit-jupiter-api
> 5.2.2
> test
>
>
> org.junit.jupiter
> junit-jupiter-engine
> 5.2.2
> test
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ejb-plugin] elharo merged pull request #11: [MEJB-130] Accept ejbVersion 4.x
elharo merged pull request #11: URL: https://github.com/apache/maven-ejb-plugin/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJLINK-62) Replace ByteArrayOutputStream with StringWriter
[ https://issues.apache.org/jira/browse/MJLINK-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256732#comment-17256732 ] Hudson commented on MJLINK-62: -- Build failed in Jenkins: Maven » Maven TLP » maven-jlink-plugin » master #60 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-jlink-plugin/job/master/60/ > Replace ByteArrayOutputStream with StringWriter > --- > > Key: MJLINK-62 > URL: https://issues.apache.org/jira/browse/MJLINK-62 > Project: Maven JLink Plugin > Issue Type: Bug >Affects Versions: 3.1.0 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: encoding > Fix For: 3.2.0 > > > Currently a BAOS exists to capture JLinks output. > Replacing it with StringWriter would preserve the platform’s encoding. > Reference: > https://github.com/apache/maven-jlink-plugin/blob/f8bdf5050c266854524aaa51eb36109c00ca692a/src/main/java9/org/apache/maven/plugins/jlink/JLinkExecutor.java#L72-L75 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-ejb-plugin] hboutemy commented on pull request #15: update plexus-archiver
hboutemy commented on pull request #15: URL: https://github.com/apache/maven-ejb-plugin/pull/15#issuecomment-752761280 yes, what's the problem? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-250) remove the JavaDoc taglets from maven-parent (both to extract Mojo javadoc annotations and link in javadoc)
[ https://issues.apache.org/jira/browse/MPOM-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256730#comment-17256730 ] Hudson commented on MPOM-250: - Build succeeded in Jenkins: Maven » Maven TLP » maven-parent » master #38 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/38/ > remove the JavaDoc taglets from maven-parent (both to extract Mojo javadoc > annotations and link in javadoc) > --- > > Key: MPOM-250 > URL: https://issues.apache.org/jira/browse/MPOM-250 > Project: Maven POMs > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: MAVEN-35 > > > we should remove the taglets from maven-parent, it has been replaced with > annotations, taglets have been dropped. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] khmarbaise commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
khmarbaise commented on a change in pull request #423:
URL: https://github.com/apache/maven/pull/423#discussion_r550328822
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
lifecycleDebugLogger.debugProjectPlan( project, executionPlan );
+// With Maven 4's build/consumer the POM will always rewrite during
distribution.
+// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
+// Fail as long as there's no solution available yet
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
Review comment:
A separate predicate expresses better what you really mean because it
gives it a readable name.
I prefer this one:
```java
boolean gpgMojo =
executionPlan.getMojoExecutions().stream().anyMatch(MavenGpgPlugin);
```
Can't be clearer from my POV... If you like more details jump to the
predicate via IDE.
Complexity? If you use stream API predicates are more less everywhere.
Usually if a method is to long (too complex) you refactor out a part of it with
a readable name. Here it's the same.
Furthermore combined filters don't give you the chance to use
`anyMatch(..)`, `.allMatch(..)` or `noneMatch(..)` which is often a good choice
and often not used based on the usage of chaining several filter(..)...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256728#comment-17256728
]
ASF GitHub Bot commented on DOXIA-616:
--
michael-o commented on a change in pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#discussion_r550327590
##
File path:
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownParser.java
##
@@ -130,133 +184,98 @@ public void parse( Reader source, Sink sink )
* @return HTML content generated by flexmark-java
* @throws IOException passed through
*/
-String toHtml( Reader source )
+CharSequence toHtml( Reader source )
throws IOException
{
+// Read the source
String text = IOUtil.toString( source );
-MutableDataHolder flexmarkOptions =
PegdownOptionsAdapter.flexmarkOptions(
-Extensions.ALL & ~( Extensions.HARDWRAPS |
Extensions.ANCHORLINKS ) ).toMutable();
-ArrayList extensions = new ArrayList<>();
-for ( Extension extension : flexmarkOptions.get(
com.vladsch.flexmark.parser.Parser.EXTENSIONS ) )
-{
-extensions.add( extension );
-}
-
-extensions.add( FlexmarkDoxiaExtension.create() );
-flexmarkOptions.set( com.vladsch.flexmark.parser.Parser.EXTENSIONS,
extensions );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_OPEN_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_CLOSE_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.MAX_TRAILING_BLANK_LINES, -1 );
-
-com.vladsch.flexmark.parser.Parser parser =
com.vladsch.flexmark.parser.Parser.builder( flexmarkOptions )
-.build();
-HtmlRenderer renderer = HtmlRenderer.builder( flexmarkOptions )
-.linkResolverFactory( new
FlexmarkDoxiaLinkResolver.Factory() )
-.build();
-
+// Now, build the HTML document
StringBuilder html = new StringBuilder( 1000 );
html.append( "" );
html.append( "" );
-Pattern metadataPattern = Pattern.compile(
MULTI_MARKDOWN_METADATA_SECTION, Pattern.MULTILINE );
-Matcher metadataMatcher = metadataPattern.matcher( text );
+
+// First, we interpret the "metadata" section of the document and add
the corresponding HTML headers
+Matcher metadataMatcher = METADATA_SECTION_PATTERN.matcher( text );
boolean haveTitle = false;
if ( metadataMatcher.find() )
{
-metadataPattern = Pattern.compile( MULTI_MARKDOWN_METADATA_ENTRY,
Pattern.MULTILINE );
-Matcher lineMatcher = metadataPattern.matcher(
metadataMatcher.group( 1 ) );
-boolean first = true;
-while ( lineMatcher.find() )
+Matcher entryMatcher = METADATA_ENTRY_PATTERN.matcher(
metadataMatcher.group( 0 ) );
+while ( entryMatcher.find() )
{
-String key = StringUtils.trimToEmpty( lineMatcher.group( 1 ) );
-if ( first )
-{
-boolean found = false;
-for ( String k : STANDARD_METADATA_KEYS )
-{
-if ( k.equalsIgnoreCase( key ) )
-{
-found = true;
-break;
-}
-}
-if ( !found )
-{
-break;
-}
-first = false;
-}
-String value = StringUtils.trimToEmpty( lineMatcher.group( 2 )
);
+String key = entryMatcher.group( 1 );
+String value = entryMatcher.group( 2 );
if ( "title".equalsIgnoreCase( key ) )
{
haveTitle = true;
html.append( "" );
-html.append( StringEscapeUtils.escapeXml( value ) );
+html.append( HtmlTools.escapeHTML( value, false ) );
html.append( "" );
}
-else if ( "author".equalsIgnoreCase( key ) )
-{
-html.append( "" );
-}
-else if ( "date".equalsIgnoreCase( key ) )
-{
-html.append( "" );
-}
else
{
-html.append( "" );
+html.append( "" );
}
}
-if ( !first )
-{
-text = text.substring( metadataMatcher.end() );
-}
+
+// Trim the metadata from the source
+text = text.substring( metadataMatcher.end( 0 ) );
+
}
-Node rootNode =
[GitHub] [maven-doxia] michael-o commented on a change in pull request #49: [DOXIA-616]
michael-o commented on a change in pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#discussion_r550327590
##
File path:
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownParser.java
##
@@ -130,133 +184,98 @@ public void parse( Reader source, Sink sink )
* @return HTML content generated by flexmark-java
* @throws IOException passed through
*/
-String toHtml( Reader source )
+CharSequence toHtml( Reader source )
throws IOException
{
+// Read the source
String text = IOUtil.toString( source );
-MutableDataHolder flexmarkOptions =
PegdownOptionsAdapter.flexmarkOptions(
-Extensions.ALL & ~( Extensions.HARDWRAPS |
Extensions.ANCHORLINKS ) ).toMutable();
-ArrayList extensions = new ArrayList<>();
-for ( Extension extension : flexmarkOptions.get(
com.vladsch.flexmark.parser.Parser.EXTENSIONS ) )
-{
-extensions.add( extension );
-}
-
-extensions.add( FlexmarkDoxiaExtension.create() );
-flexmarkOptions.set( com.vladsch.flexmark.parser.Parser.EXTENSIONS,
extensions );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_OPEN_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.HTML_BLOCK_CLOSE_TAG_EOL, false );
-flexmarkOptions.set( HtmlRenderer.MAX_TRAILING_BLANK_LINES, -1 );
-
-com.vladsch.flexmark.parser.Parser parser =
com.vladsch.flexmark.parser.Parser.builder( flexmarkOptions )
-.build();
-HtmlRenderer renderer = HtmlRenderer.builder( flexmarkOptions )
-.linkResolverFactory( new
FlexmarkDoxiaLinkResolver.Factory() )
-.build();
-
+// Now, build the HTML document
StringBuilder html = new StringBuilder( 1000 );
html.append( "" );
html.append( "" );
-Pattern metadataPattern = Pattern.compile(
MULTI_MARKDOWN_METADATA_SECTION, Pattern.MULTILINE );
-Matcher metadataMatcher = metadataPattern.matcher( text );
+
+// First, we interpret the "metadata" section of the document and add
the corresponding HTML headers
+Matcher metadataMatcher = METADATA_SECTION_PATTERN.matcher( text );
boolean haveTitle = false;
if ( metadataMatcher.find() )
{
-metadataPattern = Pattern.compile( MULTI_MARKDOWN_METADATA_ENTRY,
Pattern.MULTILINE );
-Matcher lineMatcher = metadataPattern.matcher(
metadataMatcher.group( 1 ) );
-boolean first = true;
-while ( lineMatcher.find() )
+Matcher entryMatcher = METADATA_ENTRY_PATTERN.matcher(
metadataMatcher.group( 0 ) );
+while ( entryMatcher.find() )
{
-String key = StringUtils.trimToEmpty( lineMatcher.group( 1 ) );
-if ( first )
-{
-boolean found = false;
-for ( String k : STANDARD_METADATA_KEYS )
-{
-if ( k.equalsIgnoreCase( key ) )
-{
-found = true;
-break;
-}
-}
-if ( !found )
-{
-break;
-}
-first = false;
-}
-String value = StringUtils.trimToEmpty( lineMatcher.group( 2 )
);
+String key = entryMatcher.group( 1 );
+String value = entryMatcher.group( 2 );
if ( "title".equalsIgnoreCase( key ) )
{
haveTitle = true;
html.append( "" );
-html.append( StringEscapeUtils.escapeXml( value ) );
+html.append( HtmlTools.escapeHTML( value, false ) );
html.append( "" );
}
-else if ( "author".equalsIgnoreCase( key ) )
-{
-html.append( "" );
-}
-else if ( "date".equalsIgnoreCase( key ) )
-{
-html.append( "" );
-}
else
{
-html.append( "" );
+html.append( "" );
}
}
-if ( !first )
-{
-text = text.substring( metadataMatcher.end() );
-}
+
+// Trim the metadata from the source
+text = text.substring( metadataMatcher.end( 0 ) );
+
}
-Node rootNode = parser.parse( text );
-String markdownHtml = renderer.render( rootNode );
+// Now is the time to parse the Markdown document
+// (after we've trimmed out the metadatas, and before we check for its
headings)
+Node docum
[jira] [Commented] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256725#comment-17256725
]
ASF GitHub Bot commented on DOXIA-616:
--
michael-o commented on pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#issuecomment-752758230
OK, let me go through again and test it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Markdown: Properly expose the language specified in fenced code blocks
> --
>
> Key: DOXIA-616
> URL: https://issues.apache.org/jira/browse/DOXIA-616
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Markdown
>Affects Versions: 1.8, 1.9, 1.9.1
>Reporter: Bertrand Martin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.2
>
>
> h1. Use Case
> Writers can specify the language used in a fenced code block (typically for
> syntax highlighting), as in the example below:
> {code}
> ```java
> System.out.println("Beautiful\n");
> ```
> {code}
> Currently, the Doxia module for Markdown does not expose this information
> ("java") in the produced HTML, so a Maven skin (or frontend renderer) cannot
> leverage it.
> Produced HTML:
> {code:html}
>
>
> System.out.println("Beautiful\n");
>
>
> {code}
> Wanted result:
> {code:html}
>
>
> System.out.println("Beautiful\n");
>
>
> {code}
> h1. Specification
> Un-comment this block:
> https://github.com/apache/maven-doxia/blob/c439714e8f4a9e86f9962ac6be9a0077ae9b4d30/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer.java#L103
> This should do the trick.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-doxia] michael-o commented on pull request #49: [DOXIA-616]
michael-o commented on pull request #49: URL: https://github.com/apache/maven-doxia/pull/49#issuecomment-752758230 OK, let me go through again and test it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
michael-o commented on a change in pull request #423:
URL: https://github.com/apache/maven/pull/423#discussion_r550326838
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
lifecycleDebugLogger.debugProjectPlan( project, executionPlan );
+// With Maven 4's build/consumer the POM will always rewrite during
distribution.
+// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
+// Fail as long as there's no solution available yet
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
Review comment:
Let's keep it as simple as possible. Either one or two filters.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7062) Add first class support for deployment repositories to settings.xml
[
https://issues.apache.org/jira/browse/MNG-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256721#comment-17256721
]
Michael Osipov commented on MNG-7062:
-
[~rfscholte], but why does this matter for the consumer then? The distro
management is relevant during release only. Consumers don't need this kind of
information.
> Add first class support for deployment repositories to settings.xml
> ---
>
> Key: MNG-7062
> URL: https://issues.apache.org/jira/browse/MNG-7062
> Project: Maven
> Issue Type: Improvement
> Components: Settings
>Affects Versions: 3.6.3
>Reporter: Phil Clay
>Priority: Minor
>
> The maven settings.xml file currently has first-class support for controlling
> artifact _downloads_ via the [mirrors
> section|https://maven.apache.org/settings.html#Mirrors]. It would be
> intuitive and logical if the the settings.xml file also had first-class
> support for controlling artifact _uploads_.
> Being able to control _both_ artifact uploads and downloads from the
> settings.xml file allows for easier centralized management in organizations
> using a repository manager, in which all downloads and uploads should go
> through the repository manager.
> The current approach of being able to point artifact downloads to a
> repository manager in settings.xml, but not being able to point uploads to
> the same repository manager in settings.xml is clunky and not intuitive.
> Here are several alternatives that can be used today, but none are as
> easy/intuitive as first class support in the settings.xml would be.
> # Define downloads in settings.xml file, but define uploads via
> {{distributionManagement}} in poms.
> # Define {{alt*DeploymentRepository}} properties in settings.xml (as
> mentioned in [PR #23|https://github.com/apache/maven-site/pull/223]). Do not
> use {{distributionManagement}} in poms at all.
> # Define custom release/snapshot repo properties in settings.xml, and define
> a {{distributionManagement}} section in poms that references those properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] rfscholte commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
rfscholte commented on a change in pull request #423:
URL: https://github.com/apache/maven/pull/423#discussion_r550325388
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
lifecycleDebugLogger.debugProjectPlan( project, executionPlan );
+// With Maven 4's build/consumer the POM will always rewrite during
distribution.
+// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
+// Fail as long as there's no solution available yet
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
Review comment:
So yes, there are many options to write this. My style would be: 1
simple statement per filter as it would reduce complexity (TT, TF, FT, FF vs
T->T, T->F, F) and no externalized predicates if the statement is short and
clear.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7062) Add first class support for deployment repositories to settings.xml
[
https://issues.apache.org/jira/browse/MNG-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256718#comment-17256718
]
Robert Scholte commented on MNG-7062:
-
I consider the distributionManagement as a part of the trace where artifacts
are coming from, so it must be there, either in the POM or via inheritence.
So my first response would be no.
But with the build/consumer we can rewrite the POM, so we should be to inject
this information while distributing the artifacts.
> Add first class support for deployment repositories to settings.xml
> ---
>
> Key: MNG-7062
> URL: https://issues.apache.org/jira/browse/MNG-7062
> Project: Maven
> Issue Type: Improvement
> Components: Settings
>Affects Versions: 3.6.3
>Reporter: Phil Clay
>Priority: Minor
>
> The maven settings.xml file currently has first-class support for controlling
> artifact _downloads_ via the [mirrors
> section|https://maven.apache.org/settings.html#Mirrors]. It would be
> intuitive and logical if the the settings.xml file also had first-class
> support for controlling artifact _uploads_.
> Being able to control _both_ artifact uploads and downloads from the
> settings.xml file allows for easier centralized management in organizations
> using a repository manager, in which all downloads and uploads should go
> through the repository manager.
> The current approach of being able to point artifact downloads to a
> repository manager in settings.xml, but not being able to point uploads to
> the same repository manager in settings.xml is clunky and not intuitive.
> Here are several alternatives that can be used today, but none are as
> easy/intuitive as first class support in the settings.xml would be.
> # Define downloads in settings.xml file, but define uploads via
> {{distributionManagement}} in poms.
> # Define {{alt*DeploymentRepository}} properties in settings.xml (as
> mentioned in [PR #23|https://github.com/apache/maven-site/pull/223]). Do not
> use {{distributionManagement}} in poms at all.
> # Define custom release/snapshot repo properties in settings.xml, and define
> a {{distributionManagement}} section in poms that references those properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] khmarbaise commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
khmarbaise commented on a change in pull request #423:
URL: https://github.com/apache/maven/pull/423#discussion_r550322416
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
lifecycleDebugLogger.debugProjectPlan( project, executionPlan );
+// With Maven 4's build/consumer the POM will always rewrite during
distribution.
+// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
+// Fail as long as there's no solution available yet
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
Review comment:
To make more clear the combining of G+A: you could go the path:
Defining two predicates like:
```java
private Predicate isMavenGpgGroupId = m ->
m.getGroupId().equals( "org.apache.maven.plugins" );
private Predicate isMavenGpgArtifactId = m ->
m.getArtifactId().equals( "maven-gpg-plugin" );
```
and later use it like this:
```java
boolean gpgMojo =
executionPlan.getMojoExecutions().stream().anyMatch(isMavenGpgGroupId.and(isMavenGpgArtifactId
));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] khmarbaise commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
khmarbaise commented on a change in pull request #423:
URL: https://github.com/apache/maven/pull/423#discussion_r550321627
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
lifecycleDebugLogger.debugProjectPlan( project, executionPlan );
+// With Maven 4's build/consumer the POM will always rewrite during
distribution.
+// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
+// Fail as long as there's no solution available yet
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
Review comment:
You might also inline the `gpgMojo` into the if-Statement.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] khmarbaise commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
khmarbaise commented on a change in pull request #423:
URL: https://github.com/apache/maven/pull/423#discussion_r550321423
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
lifecycleDebugLogger.debugProjectPlan( project, executionPlan );
+// With Maven 4's build/consumer the POM will always rewrite during
distribution.
+// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
+// Fail as long as there's no solution available yet
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
Review comment:
What about adding a predicate:
```java
private Predicate isMavenGpgPlugin = m ->
m.getArtifactId().equals(
"maven-gpg-plugin" ) && m.getGroupId().equals(
"org.apache.maven.plugins" );
```
Then you can change the whole filter via the following:
```java
boolean gpgMojo =
executionPlan.getMojoExecutions().stream().anyMatch(isMavenGpgPlugin);
if ( gpgMojo )
{
throw new LifecycleExecutionException( "The maven-gpg-plugin is
not supported by Maven 4."
+ " Verify if there is a compatible signing solution or use
Maven 3" );
}
```
because the optional is only used as boolean.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] khmarbaise commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
khmarbaise commented on a change in pull request #423:
URL: https://github.com/apache/maven/pull/423#discussion_r550321423
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java
##
@@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession
session, MavenProject p
lifecycleDebugLogger.debugProjectPlan( project, executionPlan );
+// With Maven 4's build/consumer the POM will always rewrite during
distribution.
+// The maven-gpg-plugin uses the original POM, causing an invalid
signature.
+// Fail as long as there's no solution available yet
+Optional gpgMojo =
executionPlan.getMojoExecutions().stream()
+.filter( m -> "org.apache.maven.plugins".equals(
m.getGroupId() ) )
+.filter( m -> "maven-gpg-plugin".equals( m.getArtifactId() ) )
+.findAny();
+
+if ( gpgMojo.isPresent() )
+{
Review comment:
What about adding a predicate:
```java
private Predicate isMavenGpgPlugin = m ->
m.getArtifactId().equals(
"maven-gpg-plugin" ) && m.getGroupId().equals(
"org.apache.maven.plugins" );
```
Then you can change the whole filter via the following:
```
boolean gpgMojo =
executionPlan.getMojoExecutions().stream().anyMatch(isMavenGpgPlugin);
if ( gpgMojo )
{
throw new LifecycleExecutionException( "The maven-gpg-plugin is
not supported by Maven 4."
+ " Verify if there is a compatible signing solution or use
Maven 3" );
}
```
because the optional is only used as boolean.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
michael-o commented on a change in pull request #423: URL: https://github.com/apache/maven/pull/423#discussion_r550321326 ## File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java ## @@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession session, MavenProject p lifecycleDebugLogger.debugProjectPlan( project, executionPlan ); +// With Maven 4's build/consumer the POM will always rewrite during distribution. +// The maven-gpg-plugin uses the original POM, causing an invalid signature. +// Fail as long as there's no solution available yet +Optional gpgMojo = executionPlan.getMojoExecutions().stream() +.filter( m -> "org.apache.maven.plugins".equals( m.getGroupId() ) ) Review comment: Think of it like `if (.. && ..)`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
rfscholte commented on a change in pull request #423: URL: https://github.com/apache/maven/pull/423#discussion_r550319373 ## File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java ## @@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession session, MavenProject p lifecycleDebugLogger.debugProjectPlan( project, executionPlan ); +// With Maven 4's build/consumer the POM will always rewrite during distribution. +// The maven-gpg-plugin uses the original POM, causing an invalid signature. +// Fail as long as there's no solution available yet +Optional gpgMojo = executionPlan.getMojoExecutions().stream() +.filter( m -> "org.apache.maven.plugins".equals( m.getGroupId() ) ) Review comment: Sure it can, but IMO this is more readable. The effect is the same. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
michael-o commented on a change in pull request #423: URL: https://github.com/apache/maven/pull/423#discussion_r550315149 ## File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java ## @@ -105,6 +106,20 @@ public MavenExecutionPlan resolveBuildPlan( MavenSession session, MavenProject p lifecycleDebugLogger.debugProjectPlan( project, executionPlan ); +// With Maven 4's build/consumer the POM will always rewrite during distribution. +// The maven-gpg-plugin uses the original POM, causing an invalid signature. +// Fail as long as there's no solution available yet +Optional gpgMojo = executionPlan.getMojoExecutions().stream() +.filter( m -> "org.apache.maven.plugins".equals( m.getGroupId() ) ) Review comment: Can't the filter be ANDed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rfscholte opened a new pull request #423: [MNG-7060] Let build fail fast in case any maven-gpg-plugin goal is c…
rfscholte opened a new pull request #423: URL: https://github.com/apache/maven/pull/423 …alled Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-7062) Add first class support for deployment repositories to settings.xml
[
https://issues.apache.org/jira/browse/MNG-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256695#comment-17256695
]
Michael Osipov edited comment on MNG-7062 at 12/30/20, 7:59 PM:
[~rfscholte], [~khmarbaise], what is your opinion on this? This generally makes
sense, but distribution management is not necesarily the opposite of repos...I
am a bit split here.
was (Author: michael-o):
[~rfscholte], what is your opinion on this? This generally makes sense, but
distribution management is not necesarily the opposite of repos...I am a bit
split here.
> Add first class support for deployment repositories to settings.xml
> ---
>
> Key: MNG-7062
> URL: https://issues.apache.org/jira/browse/MNG-7062
> Project: Maven
> Issue Type: Improvement
> Components: Settings
>Affects Versions: 3.6.3
>Reporter: Phil Clay
>Priority: Minor
>
> The maven settings.xml file currently has first-class support for controlling
> artifact _downloads_ via the [mirrors
> section|https://maven.apache.org/settings.html#Mirrors]. It would be
> intuitive and logical if the the settings.xml file also had first-class
> support for controlling artifact _uploads_.
> Being able to control _both_ artifact uploads and downloads from the
> settings.xml file allows for easier centralized management in organizations
> using a repository manager, in which all downloads and uploads should go
> through the repository manager.
> The current approach of being able to point artifact downloads to a
> repository manager in settings.xml, but not being able to point uploads to
> the same repository manager in settings.xml is clunky and not intuitive.
> Here are several alternatives that can be used today, but none are as
> easy/intuitive as first class support in the settings.xml would be.
> # Define downloads in settings.xml file, but define uploads via
> {{distributionManagement}} in poms.
> # Define {{alt*DeploymentRepository}} properties in settings.xml (as
> mentioned in [PR #23|https://github.com/apache/maven-site/pull/223]). Do not
> use {{distributionManagement}} in poms at all.
> # Define custom release/snapshot repo properties in settings.xml, and define
> a {{distributionManagement}} section in poms that references those properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-7062) Add first class support for deployment repositories to settings.xml
[
https://issues.apache.org/jira/browse/MNG-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256695#comment-17256695
]
Michael Osipov commented on MNG-7062:
-
[~rfscholte], what is your opinion on this? This generally makes sense, but
distribution management is not necesarily the opposite of repos...I am a bit
split here.
> Add first class support for deployment repositories to settings.xml
> ---
>
> Key: MNG-7062
> URL: https://issues.apache.org/jira/browse/MNG-7062
> Project: Maven
> Issue Type: Improvement
> Components: Settings
>Affects Versions: 3.6.3
>Reporter: Phil Clay
>Priority: Minor
>
> The maven settings.xml file currently has first-class support for controlling
> artifact _downloads_ via the [mirrors
> section|https://maven.apache.org/settings.html#Mirrors]. It would be
> intuitive and logical if the the settings.xml file also had first-class
> support for controlling artifact _uploads_.
> Being able to control _both_ artifact uploads and downloads from the
> settings.xml file allows for easier centralized management in organizations
> using a repository manager, in which all downloads and uploads should go
> through the repository manager.
> The current approach of being able to point artifact downloads to a
> repository manager in settings.xml, but not being able to point uploads to
> the same repository manager in settings.xml is clunky and not intuitive.
> Here are several alternatives that can be used today, but none are as
> easy/intuitive as first class support in the settings.xml would be.
> # Define downloads in settings.xml file, but define uploads via
> {{distributionManagement}} in poms.
> # Define {{alt*DeploymentRepository}} properties in settings.xml (as
> mentioned in [PR #23|https://github.com/apache/maven-site/pull/223]). Do not
> use {{distributionManagement}} in poms at all.
> # Define custom release/snapshot repo properties in settings.xml, and define
> a {{distributionManagement}} section in poms that references those properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-7062) Add first class support for deployment repositories to settings.xml
[
https://issues.apache.org/jira/browse/MNG-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Clay updated MNG-7062:
---
Description:
The maven settings.xml file currently has first-class support for controlling
artifact _downloads_ via the [mirrors
section|https://maven.apache.org/settings.html#Mirrors]. It would be intuitive
and logical if the the settings.xml file also had first-class support for
controlling artifact _uploads_.
Being able to control _both_ artifact uploads and downloads from the
settings.xml file allows for easier centralized management in organizations
using a repository manager, in which all downloads and uploads should go
through the repository manager.
The current approach of being able to point artifact downloads to a repository
manager in settings.xml, but not being able to point uploads to the same
repository manager in settings.xml is clunky and not intuitive.
Here are several alternatives that can be used today, but none are as
easy/intuitive as first class support in the settings.xml would be.
# Define downloads in settings.xml file, but define uploads via
{{distributionManagement}} in poms.
# Define {{alt*DeploymentRepository}} properties in settings.xml (as mentioned
in [PR #23|https://github.com/apache/maven-site/pull/223]). Do not use
{{distributionManagement}} in poms at all.
# Define custom release/snapshot repo properties in settings.xml, and define a
{{distributionManagement}} section in poms that references those properties
was:
The maven settings.xml file currently has first-class support for controlling
artifact _downloads_ via the [mirrors
section|https://maven.apache.org/settings.html#Mirrors]. It would be intuitive
and logical if the the settings.xml file also had first-class support for
controlling artifact _uploads_.
Being able to control _both_ artifact uploads and downloads from the
settings.xml file allows for easier centralized management in organizations
using a repository manager, in which all downloads and uploads should go
through the repository manager.
The current approach of being able to point artifact downloads to a repository
manager in settings.xml, but not being able to point uploads to the same
repository manager in settings.xml is clunky and not intuitive.
Here are several alternatives that can be used today, but none are as
easy/intuitive as first class support in the settings.xml would be.
# Define downloads in settings.xml file, but define uploads via
{{distributionManagement}} in poms.
# Define {{alt*DeploymentRepository}} properties in settings.xml (as mentioned
in [PR #23|https://github.com/apache/maven-site/pull/223]. Do not use
{{distributionManagement}} in poms at all.
# Define custom release/snapshot repo properties in settings.xml, and define a
{{distributionManagement}} section in poms that references those properties
> Add first class support for deployment repositories to settings.xml
> ---
>
> Key: MNG-7062
> URL: https://issues.apache.org/jira/browse/MNG-7062
> Project: Maven
> Issue Type: Improvement
> Components: Settings
>Affects Versions: 3.6.3
>Reporter: Phil Clay
>Priority: Minor
>
> The maven settings.xml file currently has first-class support for controlling
> artifact _downloads_ via the [mirrors
> section|https://maven.apache.org/settings.html#Mirrors]. It would be
> intuitive and logical if the the settings.xml file also had first-class
> support for controlling artifact _uploads_.
> Being able to control _both_ artifact uploads and downloads from the
> settings.xml file allows for easier centralized management in organizations
> using a repository manager, in which all downloads and uploads should go
> through the repository manager.
> The current approach of being able to point artifact downloads to a
> repository manager in settings.xml, but not being able to point uploads to
> the same repository manager in settings.xml is clunky and not intuitive.
> Here are several alternatives that can be used today, but none are as
> easy/intuitive as first class support in the settings.xml would be.
> # Define downloads in settings.xml file, but define uploads via
> {{distributionManagement}} in poms.
> # Define {{alt*DeploymentRepository}} properties in settings.xml (as
> mentioned in [PR #23|https://github.com/apache/maven-site/pull/223]). Do not
> use {{distributionManagement}} in poms at all.
> # Define custom release/snapshot repo properties in settings.xml, and define
> a {{distributionManagement}} section in poms that references those properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MNG-7062) Add first class support for deployment repositories to settings.xml
Phil Clay created MNG-7062:
--
Summary: Add first class support for deployment repositories to
settings.xml
Key: MNG-7062
URL: https://issues.apache.org/jira/browse/MNG-7062
Project: Maven
Issue Type: Improvement
Components: Settings
Affects Versions: 3.6.3
Reporter: Phil Clay
The maven settings.xml file currently has first-class support for controlling
artifact _downloads_ via the [mirrors
section|https://maven.apache.org/settings.html#Mirrors]. It would be intuitive
and logical if the the settings.xml file also had first-class support for
controlling artifact _uploads_.
Being able to control _both_ artifact uploads and downloads from the
settings.xml file allows for easier centralized management in organizations
using a repository manager, in which all downloads and uploads should go
through the repository manager.
The current approach of being able to point artifact downloads to a repository
manager in settings.xml, but not being able to point uploads to the same
repository manager in settings.xml is clunky and not intuitive.
Here are several alternatives that can be used today, but none are as
easy/intuitive as first class support in the settings.xml would be.
# Define downloads in settings.xml file, but define uploads via
{{distributionManagement}} in poms.
# Define {{alt*DeploymentRepository}} properties in settings.xml (as mentioned
in [PR #23|https://github.com/apache/maven-site/pull/223]. Do not use
{{distributionManagement}} in poms at all.
# Define custom release/snapshot repo properties in settings.xml, and define a
{{distributionManagement}} section in poms that references those properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r550303951 ## File path: maven-resolver-named-redisson/src/site/site.xml ## @@ -22,7 +22,7 @@ under the License. http://maven.apache.org/DECORATION/1.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/DECORATION/1.0.0 http://maven.apache.org/xsd/decoration-1.0.0.xsd"; - name="RedissonSyncContext"> + name="NamedSyncContext"> Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r550303909
##
File path:
maven-resolver-named/src/main/java/org/eclipse/aether/named/providers/GlobalReadWriteLockProvider.java
##
@@ -0,0 +1,129 @@
+package org.eclipse.aether.named.providers;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.named.NamedLock;
+import org.eclipse.aether.named.NamedLockFactory;
+
+import javax.inject.Named;
+import javax.inject.Provider;
+import javax.inject.Singleton;
+import java.util.ArrayDeque;
+import java.util.NoSuchElementException;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReentrantReadWriteLock;
+
+/**
+ * Provider of {@link GlobalNamedLockFactory}. This uses one "global" {@link
ReentrantReadWriteLock}, is really not a
+ * "named" lock.
+ */
+@Singleton
+@Named( GlobalReadWriteLockProvider.NAME )
+public final class GlobalReadWriteLockProvider
+implements Provider
+{
+public static final String NAME = "global";
+
+@Override
+public NamedLockFactory get()
+{
+return new GlobalNamedLockFactory();
+}
+
+/**
+ * A global named lock factory that actually uses one singleton named lock
instance for all names.
+ */
+public static final class GlobalNamedLockFactory implements
NamedLockFactory
+{
+private final GlobalNamedLock globalNamedLock = new GlobalNamedLock();
+
+@Override
+public NamedLock getLock( String name )
+{
+return globalNamedLock;
+}
+
+@Override
+public void shutdown()
+{
+// nop
+}
+}
+
+/**
+ * A global named lock that uses one single reentrant read-write lock.
+ */
+public static final class GlobalNamedLock implements NamedLock
+{
+private final ReentrantReadWriteLock global = new
ReentrantReadWriteLock();
+
+private final ArrayDeque steps = new ArrayDeque<>();
Review comment:
This class is removed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r550303703
##
File path: maven-resolver-named/src/site/markdown/index.md.vm
##
@@ -0,0 +1,69 @@
+${esc.hash} Named Sync Context for Maven Resolver
+
+
+
+The Named Sync Context Factory is a distributed lock factory for Maven Resolver
+on top of JVM and Hazelcast to provide a fast, concurrent-safe access from one
or multiple Maven instances to the
+same local Maven repository.
+
+For further details about the factory read the
[Javadoc](./apidocs/org/eclipse/aether/synccontext/NamedSyncContextFactory.html).
+
+${esc.hash}${esc.hash} Open Issues/Notes
+
+- It only works when dependency injection is used and not the bundled
`AetherModule` or
+ `ServiceLocator` (Maven uses dependency injection).
+- It includes a lot of trace logging which partially will go way as soon as it
has been stabilized.
+- Usage from plugins has not been tested yet.
+- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
+ of dependency injection.
+
+${esc.hash}${esc.hash} Installation/Testing
+
+- Create the directory `${maven.home}/lib/ext/hazelcast/`.
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r550303553
##
File path: maven-resolver-named-hazelcast/src/site/site.xml
##
@@ -22,7 +22,7 @@ under the License.
http://maven.apache.org/DECORATION/1.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/DECORATION/1.0.0
http://maven.apache.org/xsd/decoration-1.0.0.xsd";
- name="GlobalSyncContext">
+ name="NamedSyncContext">
Review comment:
Fixed
##
File path: maven-resolver-named-redisson/pom.xml
##
@@ -28,51 +28,57 @@
1.7.0-SNAPSHOT
- maven-resolver-synccontext-redisson
+ maven-resolver-named-redisson
Review comment:
Renamed
##
File path: maven-resolver-named-redisson/src/site/markdown/index.md.vm
##
@@ -0,0 +1,69 @@
+${esc.hash} Named Sync Context for Maven Resolver
+
+
+
+The Named Sync Context Factory is a distributed lock factory for Maven Resolver
+on top of JVM and Hazelcast to provide a fast, concurrent-safe access from one
or multiple Maven instances to the
+same local Maven repository.
+
+For further details about the factory read the
[Javadoc](./apidocs/org/eclipse/aether/synccontext/NamedSyncContextFactory.html).
+
+${esc.hash}${esc.hash} Open Issues/Notes
+
+- It only works when dependency injection is used and not the bundled
`AetherModule` or
+ `ServiceLocator` (Maven uses dependency injection).
+- It includes a lot of trace logging which partially will go way as soon as it
has been stabilized.
+- Usage from plugins has not been tested yet.
+- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
+ of dependency injection.
+
+${esc.hash}${esc.hash} Installation/Testing
+
+- Create the directory `${maven.home}/lib/ext/hazelcast/`.
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r550303466 ## File path: maven-resolver-impl/pom.xml ## @@ -49,6 +49,10 @@ org.apache.maven.resolver maven-resolver-spi + + org.apache.maven.resolver + maven-resolver-named Review comment: renamed "named"->"named-locks" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo opened a new pull request #122: [MDEP-729] fix NullPointerException
elharo opened a new pull request #122: URL: https://github.com/apache/maven-dependency-plugin/pull/122 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-250) remove the JavaDoc taglets from maven-parent (both to extract Mojo javadoc annotations and link in javadoc)
[ https://issues.apache.org/jira/browse/MPOM-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256646#comment-17256646 ] Herve Boutemy commented on MPOM-250: done in https://github.com/apache/maven-parent/commit/0280e9293d6973df5ba48e7f8d90bf5d743b009c > remove the JavaDoc taglets from maven-parent (both to extract Mojo javadoc > annotations and link in javadoc) > --- > > Key: MPOM-250 > URL: https://issues.apache.org/jira/browse/MPOM-250 > Project: Maven POMs > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: MAVEN-35 > > > we should remove the taglets from maven-parent, it has been replaced with > annotations, taglets have been dropped. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MPOM-250) remove the JavaDoc taglets from maven-parent (both to extract Mojo javadoc annotations and link in javadoc)
[ https://issues.apache.org/jira/browse/MPOM-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MPOM-250: --- Summary: remove the JavaDoc taglets from maven-parent (both to extract Mojo javadoc annotations and link in javadoc) (was: remove the JavaDoc taglets from maven-parent) > remove the JavaDoc taglets from maven-parent (both to extract Mojo javadoc > annotations and link in javadoc) > --- > > Key: MPOM-250 > URL: https://issues.apache.org/jira/browse/MPOM-250 > Project: Maven POMs > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: MAVEN-35 > > > we should remove the taglets from maven-parent, it has been replaced with > annotations, taglets have been dropped. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MEAR-297) failure when building javadoc: maven-plugin-tools-javadoc:jar:3.6.0 is missing
[
https://issues.apache.org/jira/browse/MEAR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256642#comment-17256642
]
Herve Boutemy commented on MEAR-297:
caused by upgrade of mavenPluginToolsVersion to 3.6.0 in
https://github.com/apache/maven-ear-plugin/commit/278cd720fd867ca42bec1e3931485376b1392a04
: this release of Maven Plugin Tools does not provide javadoc annotation
documentation
need to update Maven Plugins parent POM
> failure when building javadoc: maven-plugin-tools-javadoc:jar:3.6.0 is missing
> --
>
> Key: MEAR-297
> URL: https://issues.apache.org/jira/browse/MEAR-297
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Herve Boutemy
>Priority: Major
>
> found during "mvn release:perform":
> {noformat}
> 11:47 $ mvn release:perform
> [INFO] Scanning for projects...
> [INFO]
> [INFO] -< org.apache.maven.plugins:maven-ear-plugin
> >--
> [INFO] Building Apache Maven EAR Plugin 3.2.1-SNAPSHOT
> [INFO] [ maven-plugin
> ]
> [INFO]
> [INFO] --- maven-release-plugin:3.0.0-M1:perform (default-cli) @
> maven-ear-plugin ---
> [INFO] phase verify-release-configuration
> [INFO] starting perform goal, composed of 3 phases:
> verify-completed-prepare-phases, checkout-project-from-scm, run-perform-goals
> [INFO] [perform] 1/3 verify-completed-prepare-phases
> [INFO] [perform] 2/3 checkout-project-from-scm
> [INFO] Checking out the project to perform the release ...
> ...
> [INFO] [perform] 3/3 run-perform-goals
> [INFO] Invoking perform goals in directory
> /tmp/maven-ear-plugin/target/checkout
> [INFO] Executing goals 'deploy'...
> [INFO] pomFileName is already set, ignoring the -f argument
> [WARNING] Maven will be executed in interactive mode, but no input stream has
> been configured for this MavenInvoker instance.
> [INFO] [INFO] Scanning for projects...
> [INFO] [INFO]
> [INFO] [INFO] -< org.apache.maven.plugins:maven-ear-plugin
> >--
> [INFO] [INFO] Building Apache Maven EAR Plugin 3.2.0
> [INFO] [INFO] [ maven-plugin
> ]
> [INFO] [INFO]
> [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce
> (enforce-maven-version) @ maven-ear-plugin ---
> [INFO] [INFO]
> ...
> [INFO] [INFO] --- maven-javadoc-plugin:3.2.0:jar (attach-javadocs) @
> maven-ear-plugin ---
> [INFO] [WARNING] Error fetching link: http://www.xmlunit.org/apidocs. Ignored
> it.
> [INFO] [WARNING] Error fetching link: http://junit.org/apidocs. Ignored it.
> [INFO] [WARNING] The POM for
> org.apache.maven.plugin-tools:maven-plugin-tools-javadoc:jar:3.6.0 is
> missing, no dependency information available
> [INFO] [INFO]
>
> [INFO] [INFO] BUILD FAILURE
> [INFO] [INFO]
>
> [INFO] [INFO] Total time: 11.187 s
> [INFO] [INFO] Finished at: 2020-12-30T11:49:28+01:00
> [INFO] [INFO]
>
> [INFO] [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs) on
> project maven-ear-plugin: MavenReportException: Error while generating
> Javadoc: Unable to resolve artifact:groupId = 'org.apache.maven.plugin-tools'
> [INFO] [ERROR] artifactId = 'maven-plugin-tools-javadoc'
> [INFO] [ERROR] version = '3.6.0': Failure to find
> org.apache.maven.plugin-tools:maven-plugin-tools-javadoc:jar:3.6.0 in
> http://localhost:8081/nexus/content/groups/public was cached in the local
> repository, resolution will not be reattempted until the update interval of
> central has elapsed or updates are forced
> [INFO] [ERROR] -> [Help 1]
> [INFO] [ERROR]
> [INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with
> the -e switch.
> [INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [INFO] [ERROR]
> [INFO] [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
> [INFO] [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256634#comment-17256634
]
ASF GitHub Bot commented on DOXIA-616:
--
bertysentry commented on pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#issuecomment-752708690
Guys, I updated the PR with all suggested changes. Is there anything else I
can do? I would like to have this merged so I can submit my PR on DOXIA-542
(apostrophes vs quotes). Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Markdown: Properly expose the language specified in fenced code blocks
> --
>
> Key: DOXIA-616
> URL: https://issues.apache.org/jira/browse/DOXIA-616
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Markdown
>Affects Versions: 1.8, 1.9, 1.9.1
>Reporter: Bertrand Martin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.2
>
>
> h1. Use Case
> Writers can specify the language used in a fenced code block (typically for
> syntax highlighting), as in the example below:
> {code}
> ```java
> System.out.println("Beautiful\n");
> ```
> {code}
> Currently, the Doxia module for Markdown does not expose this information
> ("java") in the produced HTML, so a Maven skin (or frontend renderer) cannot
> leverage it.
> Produced HTML:
> {code:html}
>
>
> System.out.println("Beautiful\n");
>
>
> {code}
> Wanted result:
> {code:html}
>
>
> System.out.println("Beautiful\n");
>
>
> {code}
> h1. Specification
> Un-comment this block:
> https://github.com/apache/maven-doxia/blob/c439714e8f4a9e86f9962ac6be9a0077ae9b4d30/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer.java#L103
> This should do the trick.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-doxia] bertysentry commented on pull request #49: [DOXIA-616]
bertysentry commented on pull request #49: URL: https://github.com/apache/maven-doxia/pull/49#issuecomment-752708690 Guys, I updated the PR with all suggested changes. Is there anything else I can do? I would like to have this merged so I can submit my PR on DOXIA-542 (apostrophes vs quotes). Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256589#comment-17256589
]
Michael Osipov commented on MRESOLVER-153:
--
You can automate that. Clone from
https://github.com/cstamas/maven-resolver/tree/named. Install locally, clone
from Maven master. Update root POM with the resolver 1.7.0-SNAPSHOT. Build
Maven, use that tarball to test your own builds.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed on the {{TrackingFileManager}}
> ([https://github.com/apache/maven-resolver/pull/67]). This now leads to
> concurrent writes on the {{resolver-status.properties}} file in o
[jira] [Comment Edited] (MENFORCER-367) Null Pointer Exception Analyzing org.bouncycastle:bcprov-jdk15on:1.66
[ https://issues.apache.org/jira/browse/MENFORCER-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256572#comment-17256572 ] Dave Wichers edited comment on MENFORCER-367 at 12/30/20, 3:55 PM: --- Upgrading to 1.3 of extra-enforcer-rules fixed it. Thanks for researching! was (Author: davewichers): Upgrading to 1.3 fixed it! Thanks for researching. > Null Pointer Exception Analyzing org.bouncycastle:bcprov-jdk15on:1.66 > - > > Key: MENFORCER-367 > URL: https://issues.apache.org/jira/browse/MENFORCER-367 > Project: Maven Enforcer Plugin > Issue Type: Bug > Components: Plugin >Affects Versions: 3.0.0-M3 >Reporter: Dave Wichers >Priority: Major > > When I try to upgrade from 1.65.01 to 1.66 of this library: > > org.bouncycastle > bcprov-jdk15on > > 1.66 > > I get the following NullPointerException: > [*ERROR*] Failed to execute goal > org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce > *(enforce-bytecode-version)* on project benchmark: *Execution > enforce-bytecode-version of goal > org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce failed.*: > NullPointerException -> *[Help 1]* > *org.apache.maven.lifecycle.LifecycleExecutionException*: *Failed to execute > goal* *org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce* > *(enforce-bytecode-version)* on project benchmark: *Execution > enforce-bytecode-version of goal > org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce failed.* > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:213*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:154*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:146*) > *at* > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (*LifecycleModuleBuilder.java:117*) > *at* > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (*LifecycleModuleBuilder.java:81*) > *at* > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (*SingleThreadedBuilder.java:56*) > *at* org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (*LifecycleStarter.java:128*) > *at* org.apache.maven.DefaultMaven.doExecute (*DefaultMaven.java:305*) > *at* org.apache.maven.DefaultMaven.doExecute (*DefaultMaven.java:192*) > *at* org.apache.maven.DefaultMaven.execute (*DefaultMaven.java:105*) > *at* org.apache.maven.cli.MavenCli.execute (*MavenCli.java:956*) > *at* org.apache.maven.cli.MavenCli.doMain (*MavenCli.java:290*) > *at* org.apache.maven.cli.MavenCli.main (*MavenCli.java:194*) > *at* sun.reflect.NativeMethodAccessorImpl.invoke0 (*Native Method*) > *at* sun.reflect.NativeMethodAccessorImpl.invoke > (*NativeMethodAccessorImpl.java:62*) > *at* sun.reflect.DelegatingMethodAccessorImpl.invoke > (*DelegatingMethodAccessorImpl.java:43*) > *at* java.lang.reflect.Method.invoke (*Method.java:498*) > *at* org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (*Launcher.java:289*) > *at* org.codehaus.plexus.classworlds.launcher.Launcher.launch > (*Launcher.java:229*) > *at* org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (*Launcher.java:415*) > *at* org.codehaus.plexus.classworlds.launcher.Launcher.main > (*Launcher.java:356*) > *Caused by*: org.apache.maven.plugin.PluginExecutionException: *Execution > enforce-bytecode-version of goal > org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce failed.* > *at* org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (*DefaultBuildPluginManager.java:148*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:208*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:154*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:146*) > *at* > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (*LifecycleModuleBuilder.java:117*) > *at* > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (*LifecycleModuleBuilder.java:81*) > *at* > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (*SingleThreadedBuilder.java:56*) > *at* org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (*LifecycleStarter.java:128*) > *at* org.apache.maven.DefaultMaven.doExecute (*DefaultMaven.java:305*) > *at* org.apache
[jira] [Commented] (MENFORCER-367) Null Pointer Exception Analyzing org.bouncycastle:bcprov-jdk15on:1.66
[ https://issues.apache.org/jira/browse/MENFORCER-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256572#comment-17256572 ] Dave Wichers commented on MENFORCER-367: Upgrading to 1.3 fixed it! Thanks for researching. > Null Pointer Exception Analyzing org.bouncycastle:bcprov-jdk15on:1.66 > - > > Key: MENFORCER-367 > URL: https://issues.apache.org/jira/browse/MENFORCER-367 > Project: Maven Enforcer Plugin > Issue Type: Bug > Components: Plugin >Affects Versions: 3.0.0-M3 >Reporter: Dave Wichers >Priority: Major > > When I try to upgrade from 1.65.01 to 1.66 of this library: > > org.bouncycastle > bcprov-jdk15on > > 1.66 > > I get the following NullPointerException: > [*ERROR*] Failed to execute goal > org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce > *(enforce-bytecode-version)* on project benchmark: *Execution > enforce-bytecode-version of goal > org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce failed.*: > NullPointerException -> *[Help 1]* > *org.apache.maven.lifecycle.LifecycleExecutionException*: *Failed to execute > goal* *org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce* > *(enforce-bytecode-version)* on project benchmark: *Execution > enforce-bytecode-version of goal > org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce failed.* > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:213*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:154*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:146*) > *at* > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (*LifecycleModuleBuilder.java:117*) > *at* > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (*LifecycleModuleBuilder.java:81*) > *at* > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (*SingleThreadedBuilder.java:56*) > *at* org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (*LifecycleStarter.java:128*) > *at* org.apache.maven.DefaultMaven.doExecute (*DefaultMaven.java:305*) > *at* org.apache.maven.DefaultMaven.doExecute (*DefaultMaven.java:192*) > *at* org.apache.maven.DefaultMaven.execute (*DefaultMaven.java:105*) > *at* org.apache.maven.cli.MavenCli.execute (*MavenCli.java:956*) > *at* org.apache.maven.cli.MavenCli.doMain (*MavenCli.java:290*) > *at* org.apache.maven.cli.MavenCli.main (*MavenCli.java:194*) > *at* sun.reflect.NativeMethodAccessorImpl.invoke0 (*Native Method*) > *at* sun.reflect.NativeMethodAccessorImpl.invoke > (*NativeMethodAccessorImpl.java:62*) > *at* sun.reflect.DelegatingMethodAccessorImpl.invoke > (*DelegatingMethodAccessorImpl.java:43*) > *at* java.lang.reflect.Method.invoke (*Method.java:498*) > *at* org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (*Launcher.java:289*) > *at* org.codehaus.plexus.classworlds.launcher.Launcher.launch > (*Launcher.java:229*) > *at* org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (*Launcher.java:415*) > *at* org.codehaus.plexus.classworlds.launcher.Launcher.main > (*Launcher.java:356*) > *Caused by*: org.apache.maven.plugin.PluginExecutionException: *Execution > enforce-bytecode-version of goal > org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce failed.* > *at* org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (*DefaultBuildPluginManager.java:148*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:208*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:154*) > *at* org.apache.maven.lifecycle.internal.MojoExecutor.execute > (*MojoExecutor.java:146*) > *at* > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (*LifecycleModuleBuilder.java:117*) > *at* > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (*LifecycleModuleBuilder.java:81*) > *at* > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (*SingleThreadedBuilder.java:56*) > *at* org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (*LifecycleStarter.java:128*) > *at* org.apache.maven.DefaultMaven.doExecute (*DefaultMaven.java:305*) > *at* org.apache.maven.DefaultMaven.doExecute (*DefaultMaven.java:192*) > *at* org.apache.maven.DefaultMaven.execute (*DefaultMaven.java:105*) > *at* org.apache.mave
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256553#comment-17256553
]
Guy Brand commented on MRESOLVER-153:
-
[~michael-o] Not sure how to do this as the referenced PR is from the Maven
Resolver project and not from [https://github.com/apache/maven] from which we
create our nightly snapshots via CI. If you can provide a custom branch on that
repo with these changes I can trigger our suite based on these changes.
Manually building it is not an option for us, as we have everything automated
in CI and only rely on artifacts published by CI.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
[jira] [Closed] (MNG-7061) maven 3 does not follow 308 Permanent Redirect
[ https://issues.apache.org/jira/browse/MNG-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7061. --- Resolution: Not A Problem Upgrade the bundled Wagon to 3.4.2: https://github.com/apache/maven-wagon/blob/c956aac9007303ce9e1746c834d58dff097ce3d6/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/WagonRedirectStrategy.java#L69-L88 or wait for Maven 4.0.0-alpha-1. This issue has already been addressed in WAGON-570/Wagon 3.4.0. > maven 3 does not follow 308 Permanent Redirect > -- > > Key: MNG-7061 > URL: https://issues.apache.org/jira/browse/MNG-7061 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.6.3 >Reporter: James Z.M. Gao >Priority: Major > > some old http repository, e.g. > http://repository.cloudera.com/artifactory/libs-release uses 308 redirect to > https url, but maven 3.6.3 can not deal with this response. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-ejb-plugin] elharo commented on pull request #11: [MEJB-130] Accept ejbVersion 4.x
elharo commented on pull request #11: URL: https://github.com/apache/maven-ejb-plugin/pull/11#issuecomment-752639839 Running through Jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ejb-plugin/job/mejb-130/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ejb-plugin] elharo opened a new pull request #15: update plexus-archiver
elharo opened a new pull request #15: URL: https://github.com/apache/maven-ejb-plugin/pull/15 @hboutemy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256550#comment-17256550
]
Michael Osipov commented on MRESOLVER-153:
--
[~Brand], if you you can start out by building from MRESOLVER-145 which is a
custom Maven build. This is ongoing work, but should give the enough to make
decisions.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed on the {{TrackingFileManager}}
> ([https://github.com/apache/maven-resolver/pull/67]). This now leads to
> concurrent writes on the {{resolver-status.properties}} file in our tests and
> causes the error during the {{Properties#load()}} metho
[GitHub] [maven-dependency-plugin] elharo merged pull request #121: unused import
elharo merged pull request #121: URL: https://github.com/apache/maven-dependency-plugin/pull/121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDEP-734) Drop maven-artifact-transfer
Elliotte Rusty Harold created MDEP-734: -- Summary: Drop maven-artifact-transfer Key: MDEP-734 URL: https://issues.apache.org/jira/browse/MDEP-734 Project: Maven Dependency Plugin Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold see [https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=155749857] Per discussion on [https://github.com/apache/maven-artifact-transfer/pull/20] we should be able to remove the dependency on maven-artifact-transfer now that 3.1.1 or later is required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MSHARED-963) Require Maven 3.1.1 (drop dependency to Mave 3.0 Sonatype Aether)
[ https://issues.apache.org/jira/browse/MSHARED-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MSHARED-963. -- Assignee: Robert Scholte Resolution: Won't Fix This shouldn't be implemented. The only purpose of this library is to support Sonatype Aether and Eclipse Aether (rebranded to Maven Artifact Resolver) at the same time. If you only want to use the latter (in other words support M3.1+), there's no need to use Maven artifact Transfer, just use Maven Artifact Resolver directly. > Require Maven 3.1.1 (drop dependency to Mave 3.0 Sonatype Aether) > - > > Key: MSHARED-963 > URL: https://issues.apache.org/jira/browse/MSHARED-963 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-artifact-transfer >Reporter: Sylwester Lachiewicz >Assignee: Robert Scholte >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (MSHARED-801) Add functionality to collect raw dependencies in Maven 3+
[ https://issues.apache.org/jira/browse/MSHARED-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MSHARED-801: --- Comment: was deleted (was: Please don't do this. The intention of maven-artifact-transfer is a bridge to any Aether implementation.) > Add functionality to collect raw dependencies in Maven 3+ > - > > Key: MSHARED-801 > URL: https://issues.apache.org/jira/browse/MSHARED-801 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Gabriel Belingueres >Priority: Major > Labels: intern > Time Spent: 10m > Remaining Estimate: 0h > > Add funcionality allowing to collect raw project dependencies. > This can be used to implement dependencyConvergence and requireUpperBoundDeps > enforcer rules. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-801) Add functionality to collect raw dependencies in Maven 3+
[ https://issues.apache.org/jira/browse/MSHARED-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256471#comment-17256471 ] Robert Scholte commented on MSHARED-801: Please don't do this. The intention of maven-artifact-transfer is a bridge to any Aether implementation. > Add functionality to collect raw dependencies in Maven 3+ > - > > Key: MSHARED-801 > URL: https://issues.apache.org/jira/browse/MSHARED-801 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Gabriel Belingueres >Priority: Major > Labels: intern > Time Spent: 10m > Remaining Estimate: 0h > > Add funcionality allowing to collect raw project dependencies. > This can be used to implement dependencyConvergence and requireUpperBoundDeps > enforcer rules. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MEAR-297) failure when building javadoc: maven-plugin-tools-javadoc:jar:3.6.0 is missing
Herve Boutemy created MEAR-297:
--
Summary: failure when building javadoc:
maven-plugin-tools-javadoc:jar:3.6.0 is missing
Key: MEAR-297
URL: https://issues.apache.org/jira/browse/MEAR-297
Project: Maven EAR Plugin
Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Herve Boutemy
found during "mvn release:perform":
{noformat}
11:47 $ mvn release:perform
[INFO] Scanning for projects...
[INFO]
[INFO] -< org.apache.maven.plugins:maven-ear-plugin >--
[INFO] Building Apache Maven EAR Plugin 3.2.1-SNAPSHOT
[INFO] [ maven-plugin ]
[INFO]
[INFO] --- maven-release-plugin:3.0.0-M1:perform (default-cli) @
maven-ear-plugin ---
[INFO] phase verify-release-configuration
[INFO] starting perform goal, composed of 3 phases:
verify-completed-prepare-phases, checkout-project-from-scm, run-perform-goals
[INFO] [perform] 1/3 verify-completed-prepare-phases
[INFO] [perform] 2/3 checkout-project-from-scm
[INFO] Checking out the project to perform the release ...
...
[INFO] [perform] 3/3 run-perform-goals
[INFO] Invoking perform goals in directory /tmp/maven-ear-plugin/target/checkout
[INFO] Executing goals 'deploy'...
[INFO] pomFileName is already set, ignoring the -f argument
[WARNING] Maven will be executed in interactive mode, but no input stream has
been configured for this MavenInvoker instance.
[INFO] [INFO] Scanning for projects...
[INFO] [INFO]
[INFO] [INFO] -< org.apache.maven.plugins:maven-ear-plugin
>--
[INFO] [INFO] Building Apache Maven EAR Plugin 3.2.0
[INFO] [INFO] [ maven-plugin
]
[INFO] [INFO]
[INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce
(enforce-maven-version) @ maven-ear-plugin ---
[INFO] [INFO]
...
[INFO] [INFO] --- maven-javadoc-plugin:3.2.0:jar (attach-javadocs) @
maven-ear-plugin ---
[INFO] [WARNING] Error fetching link: http://www.xmlunit.org/apidocs. Ignored
it.
[INFO] [WARNING] Error fetching link: http://junit.org/apidocs. Ignored it.
[INFO] [WARNING] The POM for
org.apache.maven.plugin-tools:maven-plugin-tools-javadoc:jar:3.6.0 is missing,
no dependency information available
[INFO] [INFO]
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO]
[INFO] [INFO] Total time: 11.187 s
[INFO] [INFO] Finished at: 2020-12-30T11:49:28+01:00
[INFO] [INFO]
[INFO] [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs) on
project maven-ear-plugin: MavenReportException: Error while generating Javadoc:
Unable to resolve artifact:groupId = 'org.apache.maven.plugin-tools'
[INFO] [ERROR] artifactId = 'maven-plugin-tools-javadoc'
[INFO] [ERROR] version = '3.6.0': Failure to find
org.apache.maven.plugin-tools:maven-plugin-tools-javadoc:jar:3.6.0 in
http://localhost:8081/nexus/content/groups/public was cached in the local
repository, resolution will not be reattempted until the update interval of
central has elapsed or updates are forced
[INFO] [ERROR] -> [Help 1]
[INFO] [ERROR]
[INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[INFO] [ERROR]
[INFO] [ERROR] For more information about the errors and possible solutions,
please read the following articles:
[INFO] [ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-doxia] dependabot[bot] commented on pull request #47: Bump xmlunit-matchers from 2.7.0 to 2.8.2
dependabot[bot] commented on pull request #47: URL: https://github.com/apache/maven-doxia/pull/47#issuecomment-752381076 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia] dependabot[bot] commented on pull request #48: Bump xmlunit-core from 2.7.0 to 2.8.2
dependabot[bot] commented on pull request #48: URL: https://github.com/apache/maven-doxia/pull/48#issuecomment-752381041 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] dependabot[bot] commented on pull request #3: Bump commons-io from 2.6 to 2.8.0
dependabot[bot] commented on pull request #3: URL: https://github.com/apache/maven-doxia-converter/pull/3#issuecomment-752374110 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] asfgit closed pull request #3: Bump commons-io from 2.6 to 2.8.0
asfgit closed pull request #3: URL: https://github.com/apache/maven-doxia-converter/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] asfgit closed pull request #8: Bump icu4j from 67.1 to 68.2
asfgit closed pull request #8: URL: https://github.com/apache/maven-doxia-converter/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] dependabot[bot] commented on pull request #8: Bump icu4j from 67.1 to 68.2
dependabot[bot] commented on pull request #8: URL: https://github.com/apache/maven-doxia-converter/pull/8#issuecomment-752374002 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256383#comment-17256383
]
Guy Brand commented on MRESOLVER-153:
-
I'm happy to help out. We can run our set of tests with changes on master. We
publish our own Maven nightlies based on the {{master}} branch to our own
infrastructure. We may be able to do a custom snapshot from a branch where the
new Maven resolver version is included. If you can provide such a branch we can
use it for the tests.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed on the {{TrackingFileManager}}
> ([https://github.com/apache/maven-resolver/pull/67]
