[jira] [Created] (MJDEPS-25) jdeps commandline parameters are not correctly constructed

2021-01-29 Thread Kai Hofmann (Jira)
Kai Hofmann created MJDEPS-25:
-

 Summary: jdeps commandline parameters are not correctly constructed
 Key: MJDEPS-25
 URL: https://issues.apache.org/jira/browse/MJDEPS-25
 Project: Maven JDeps Plugin
  Issue Type: Bug
Affects Versions: 3.1.2
 Environment: MacOS 10.13, maven 3.6.3
Reporter: Kai Hofmann


In my pom.xml I used the following plugin configuration:

 


  org.apache.maven.plugins
  maven-jdeps-plugin
  3.1.2
  
    de.powerstat.phplib.templateengine
    11
    true
   
 

 

and calling it with mvn jdeps:jdkinternals

 

Because I am using jdk9 modules, I always got an error message - because of 
MJDEPS-19/20. During this error message the jdeps commandline will be written 
as:

 

[ERROR] Command line was: /bin/sh -c 
'/Library/Java/JavaVirtualMachines/jdk-12.0.1.jdk/Contents/Home/bin/jdeps' 
'-cp' 
'/Users/powerstat/.m2/repository/org/apache/logging/log4j/log4j-api/2.14.0/log4j-api-2.14.0.jar:/Users/powerstat/.m2/repository/org/apache/logging/log4j/log4j-core/2.14.0/log4j-core-2.14.0.jar'
 '/Users/powerstat/Documents/dev/TemplateEngine/target/classes'

 

What I am missing here are two things:

 

1) --jdk-internals, because I called the plugin with jdeps:jdkinternals!

2) --multi-release 11, as given by my plugin configuration!

 

So it would be nice to fix these 3 things (MJDEPS-19/20 included).

 

For testing you could use my project on github: 
https://github.com/PowerStat/TemplateEngine



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MJDEPS-20) jdeps for modularized code should use --module-path

2021-01-29 Thread Kai Hofmann (Jira)


[ 
https://issues.apache.org/jira/browse/MJDEPS-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275499#comment-17275499
 ] 

Kai Hofmann commented on MJDEPS-20:
---

Same problem

> jdeps for modularized code should use --module-path
> ---
>
> Key: MJDEPS-20
> URL: https://issues.apache.org/jira/browse/MJDEPS-20
> Project: Maven JDeps Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.2
>Reporter: Andre Tadeu de Carvalho
>Priority: Major
>
> In the attempt to solve https://issues.apache.org/jira/browse/MJDEPS-16, I 
> discover that the plugin is not settings *--module-path* when the code is 
> modularized. It also need to set the target to 
> _target/classes/module-info.class_ instead _target/classes_.
> As an example in [https://github.com/andretadeu/maven-jdeps-plugin.git,] 
> branch MJDEPS-16, running the test *MJDEPS-16_jdkinternals*:
> {code}
> jdeps --module-path  repo>/com/google/inject/guice/4.2.0/guice-4.2.0.jar: repo>/javax/inject/javax.inject/1/javax.inject-1.jar: repo>/aopalliance/aopalliance/1.0/aopalliance-1.0.jar: repo>/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar: repo>/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar: repo>/org/checkerframework/checker-qual/2.0.0/checker-qual-2.0.0.jar: repo>/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.jar:  
> repo>/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar:  
> repo>/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar
>  -jdkinternals  root>/target/it/MJDEPS-16_jdkinternals/target/classes/module-info.class
> {code}
> should return:
> {code:java}
> com.google.common automatic
> [file:///home/andre/workspaces/oss/maven-jdeps-plugin/target/local-repo/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar]
> requires mandated java.base
> com.google.common -> jdk.unsupported
> com.google.common.cache.Striped64 -> sun.misc.Unsafe JDK internal API 
> (jdk.unsupported)
> com.google.common.cache.Striped64$1 -> sun.misc.Unsafe JDK internal API 
> (jdk.unsupported)
> com.google.common.cache.Striped64$Cell -> sun.misc.Unsafe JDK internal API 
> (jdk.unsupported)
> com.google.common.hash.LittleEndianByteArray$UnsafeByteArray -> 
> sun.misc.Unsafe JDK internal API (jdk.unsupported)
> com.google.common.hash.LittleEndianByteArray$UnsafeByteArray$1 -> 
> sun.misc.Unsafe JDK internal API (jdk.unsupported)
> com.google.common.hash.LittleEndianByteArray$UnsafeByteArray$2 -> 
> sun.misc.Unsafe JDK internal API (jdk.unsupported)
> com.google.common.hash.LittleEndianByteArray$UnsafeByteArray$3 -> 
> sun.misc.Unsafe JDK internal API (jdk.unsupported)
> com.google.common.hash.Striped64 -> sun.misc.Unsafe JDK internal API 
> (jdk.unsupported)
> com.google.common.hash.Striped64$1 -> sun.misc.Unsafe JDK internal API 
> (jdk.unsupported)
> com.google.common.hash.Striped64$Cell -> sun.misc.Unsafe JDK internal API 
> (jdk.unsupported)
> com.google.common.primitives.UnsignedBytes$LexicographicalComparatorHolder$UnsafeComparator
>  -> sun.misc.Unsafe JDK internal API (jdk.unsupported)
> com.google.common.primitives.UnsignedBytes$LexicographicalComparatorHolder$UnsafeComparator$1
>  -> sun.misc.Unsafe JDK internal API (jdk.unsupported)
> com.google.common.util.concurrent.AbstractFuture$UnsafeAtomicHelper -> 
> sun.misc.Unsafe JDK internal API (jdk.unsupported)
> com.google.common.util.concurrent.AbstractFuture$UnsafeAtomicHelper$1 -> 
> sun.misc.Unsafe JDK internal API (jdk.unsupported)
> Warning: JDK internal APIs are unsupported and private to JDK implementation 
> that are
> subject to be removed or changed incompatibly and could break your 
> application.
> Please modify your code to eliminate dependence on any JDK internal APIs.
> For the most recent update on JDK internal API replacements, please check:
> https://wiki.openjdk.java.net/display/JDK8/Java+Dependency+Analysis+Tool
> JDK Internal API Suggested Replacement
>  -
> sun.misc.Unsafe See http://openjdk.java.net/jeps/260
> {code}
> If the code is not modularized, it should keep using *-cp* instead of 
> *--module-path* and it will point to _target/classes**_. If jdeps command is 
> using *--module-path*, it should point to *module-info.class*, or the command 
> won't return a single line.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275467#comment-17275467
 ] 

Anjiang Wei edited comment on SUREFIRE-1884 at 1/30/21, 2:36 AM:
-

Another plausible explanation for this bug is that when running the whole test 
suite, all test methods are running inside one JVM, so some prior tests running 
before TransformedMultiValuedMapTest may help Surefire setup and be in a good 
state for forking the JVM.

However, when running TransformedMultiValuedMapTest alone in one JVM, 
Surefire's setup may be problematic, thus throwing exception.


was (Author: david1998):
Another plausible explanation for this bug is that when running the whole test 
suite, all test methods are running inside one JVM, so some prior tests running 
before TransformedMultiValuedMapTest may help setting up Surefire to be in a 
good state.

However, when running TransformedMultiValuedMapTest alone in one JVM, 
Surefire's setup may be incorrect, thus throwing exception.

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275467#comment-17275467
 ] 

Anjiang Wei commented on SUREFIRE-1884:
---

Another plausible explanation for this bug is that when running the whole test 
suite, all test methods are running inside one JVM, so some prior tests running 
before TransformedMultiValuedMapTest may help setting up Surefire to be in a 
good state.

However, when running TransformedMultiValuedMapTest alone in one JVM, 
Surefire's setup may be incorrect, thus throwing exception.

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox


Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r567079918



##
File path: 
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefireHelperTest.java
##
@@ -156,4 +156,59 @@ public void shouldHandleTestFailure() throws Exception
 + "for the individual test results.\nPlease refer to dump 
files (if any exist) "
 + "[date].dump, [date]-jvmRun[N].dump and [date].dumpstream.'" 
);
 }
+
+@Test
+public void failsIfThereAreTooManyFlakes() throws Exception
+{
+RunResult summary = new RunResult( 1, 0, 0, 0, 1 );
+Mojo reportParameters = new Mojo();
+reportParameters.setFailOnFlakeCount( 1 );
+try
+{
+reportExecution( reportParameters, summary, null, null );
+}
+catch ( MojoFailureException e )
+{
+assertThat( e.getLocalizedMessage() )
+.isEqualTo( "There are too many flakes.\n\nPlease refer to 
null "
++ "for the individual test results.\nPlease refer to dump 
files (if any exist) "
++ "[date].dump, [date]-jvmRun[N].dump and 
[date].dumpstream." );
+return;
+}
+fail( "Expected MojoFailureException with message "

Review comment:
   @oehme 
   Pls move this line right after the line 168, and remove the `return`. It 
would behave the same, We normally do it this way.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox


Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r567075080



##
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##
@@ -142,7 +142,10 @@ public static void reportExecution( 
SurefireReportParameters reportParameters, R
 PluginConsoleLogger log, Exception 
firstForkException )
 throws MojoFailureException, MojoExecutionException
 {
-if ( firstForkException == null && !result.isTimeout() && 
result.isErrorFree() )
+boolean isError = firstForkException != null || result.isTimeout() || 
!result.isErrorFree();
+boolean isFlaky = reportParameters.getFailOnFlakeCount() > 0
+&& result.getFlakes() >= reportParameters.getFailOnFlakeCount();

Review comment:
   @paplorinc 
   What you mean?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox


Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r567073880



##
File path: 
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
##
@@ -139,6 +139,13 @@
 @Parameter( property = "failIfNoTests" )
 private Boolean failIfNoTests;
 
+/**
+ * Set this to a value greater than 0 to fail the whole test set if the 
cumulative number of flakes reaches
+ * this threshold. Set to 0 to allow an unlimited number of flakes.

Review comment:
   @oehme
   Actually yes, we should and there is something like "verifyParameters" 
method.
   Have you used the flag to serialize the content in the method 
`getConfigChecksum`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox


Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r567069271



##
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##
@@ -286,7 +289,15 @@ private static String createErrorMessage( 
SurefireReportParameters reportParamet
 }
 else
 {
-msg.append( "There are test failures.\n\nPlease refer to " )
+if ( result.getFailures() > 0 )

Review comment:
   @oehme 
   ok just fine!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (MPOM-244) Upload SHA-512 to Staging Repository

2021-01-29 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275300#comment-17275300
 ] 

Michael Osipov commented on MPOM-244:
-

So you copy everything from Nexus to dist?

> Upload SHA-512 to Staging Repository
> 
>
> Key: MPOM-244
> URL: https://issues.apache.org/jira/browse/MPOM-244
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Affects Versions: ASF-23
>Reporter: Konrad Windszus
>Priority: Major
>
> As now the ASF staging repository supports SHA2 hashes 
> (https://issues.apache.org/jira/browse/INFRA-14923) they should be generated 
> for 
> - all attached artifacts and
> - deployed to the Staging repository (i.e. attached to build as well)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MPOM-244) Upload SHA-512 to Staging Repository

2021-01-29 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275283#comment-17275283
 ] 

Konrad Windszus commented on MPOM-244:
--

I want everything which is pushed to dist in the staging repo. This was like 
that in the past when only SHA1 was required. The ASF parent pom currently 
creates SHA512 but does not deploy those to the staging repo forcing the one 
finalizing the release regenerating it.

> Upload SHA-512 to Staging Repository
> 
>
> Key: MPOM-244
> URL: https://issues.apache.org/jira/browse/MPOM-244
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Affects Versions: ASF-23
>Reporter: Konrad Windszus
>Priority: Major
>
> As now the ASF staging repository supports SHA2 hashes 
> (https://issues.apache.org/jira/browse/INFRA-14923) they should be generated 
> for 
> - all attached artifacts and
> - deployed to the Staging repository (i.e. attached to build as well)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MPOM-244) Upload SHA-512 to Staging Repository

2021-01-29 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275277#comment-17275277
 ] 

Michael Osipov commented on MPOM-244:
-

You are confusing dist with Central. These are two completely different things. 
We do also create source release with checksums for dist. Look at our parent 
POM.

> Upload SHA-512 to Staging Repository
> 
>
> Key: MPOM-244
> URL: https://issues.apache.org/jira/browse/MPOM-244
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Affects Versions: ASF-23
>Reporter: Konrad Windszus
>Priority: Major
>
> As now the ASF staging repository supports SHA2 hashes 
> (https://issues.apache.org/jira/browse/INFRA-14923) they should be generated 
> for 
> - all attached artifacts and
> - deployed to the Staging repository (i.e. attached to build as well)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MPOM-244) Upload SHA-512 to Staging Repository

2021-01-29 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275264#comment-17275264
 ] 

Konrad Windszus commented on MPOM-244:
--

In the past the Maven generated SHA1 checksum have been used by a lot of ASF 
projects as checksum which was pushed to dist once finalizing a release. Now 
that ASF has the requirement for SHA512 in dist this is on longer possible, but 
as I said, generating the SHA512 checksums with checksum-maven-plugin, attach 
them as 2nd artifacts and deploy them to the staging repo allows to use the 
same approach.

That allows also to easily verify a release from just the contents of the stage 
repository

> Upload SHA-512 to Staging Repository
> 
>
> Key: MPOM-244
> URL: https://issues.apache.org/jira/browse/MPOM-244
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Affects Versions: ASF-23
>Reporter: Konrad Windszus
>Priority: Major
>
> As now the ASF staging repository supports SHA2 hashes 
> (https://issues.apache.org/jira/browse/INFRA-14923) they should be generated 
> for 
> - all attached artifacts and
> - deployed to the Staging repository (i.e. attached to build as well)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (MPOM-244) Upload SHA-512 to Staging Repository

2021-01-29 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275264#comment-17275264
 ] 

Konrad Windszus edited comment on MPOM-244 at 1/29/21, 6:58 PM:


In the past the Maven generated SHA1 checksum has been used by a lot of ASF 
projects as checksum which was pushed to dist once finalizing a release. Now 
that ASF has the requirement for SHA512 in dist this is on longer possible, but 
as I said, generating the SHA512 checksums with checksum-maven-plugin, attach 
them as 2nd artifacts and deploy them to the staging repo allows to use the 
same approach.

That allows also to easily verify a release from just the contents of the stage 
repository


was (Author: kwin):
In the past the Maven generated SHA1 checksum have been used by a lot of ASF 
projects as checksum which was pushed to dist once finalizing a release. Now 
that ASF has the requirement for SHA512 in dist this is on longer possible, but 
as I said, generating the SHA512 checksums with checksum-maven-plugin, attach 
them as 2nd artifacts and deploy them to the staging repo allows to use the 
same approach.

That allows also to easily verify a release from just the contents of the stage 
repository

> Upload SHA-512 to Staging Repository
> 
>
> Key: MPOM-244
> URL: https://issues.apache.org/jira/browse/MPOM-244
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Affects Versions: ASF-23
>Reporter: Konrad Windszus
>Priority: Major
>
> As now the ASF staging repository supports SHA2 hashes 
> (https://issues.apache.org/jira/browse/INFRA-14923) they should be generated 
> for 
> - all attached artifacts and
> - deployed to the Staging repository (i.e. attached to build as well)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MPOM-244) Upload SHA-512 to Staging Repository

2021-01-29 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275241#comment-17275241
 ] 

Michael Osipov commented on MPOM-244:
-

It is important to understand that the checksums generated by Resolver are 
private to Revolver transport only and are not artifacts. They are out of your 
reach. The checksum plugin is not related to that.

> Upload SHA-512 to Staging Repository
> 
>
> Key: MPOM-244
> URL: https://issues.apache.org/jira/browse/MPOM-244
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Affects Versions: ASF-23
>Reporter: Konrad Windszus
>Priority: Major
>
> As now the ASF staging repository supports SHA2 hashes 
> (https://issues.apache.org/jira/browse/INFRA-14923) they should be generated 
> for 
> - all attached artifacts and
> - deployed to the Staging repository (i.e. attached to build as well)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-7088) A property which always points to pom.xml own directory

2021-01-29 Thread Monkey (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274991#comment-17274991
 ] 

Monkey commented on MNG-7088:
-

Excuse me, Michael. Of course, it points to a directory. I wanted to ask, does 
it point to the directory of the project:

- which is configured by the file pom.xml, in which the property instance 
occurs, i.e. where the property is evaluated.
- or which is configured by the first pom.xml open by Maven.

If the latter is true in the case of ${project.basedir}, do Maven has another 
property, which does the former. If not, then is there a clean way of accessing 
whatever resources (repositories, etc) which are located in the same directory 
as a given pom.xml. A way which does not rely on e.g. the relative placement of 
projects directories, which can eventually change.


> A property which always points to pom.xml own directory
> ---
>
> Key: MNG-7088
> URL: https://issues.apache.org/jira/browse/MNG-7088
> Project: Maven
>  Issue Type: New Feature
>Affects Versions: 3.6.3
>Reporter: Monkey
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Maven docs say that ${project.basedir} points to the directory containing the 
> pom.xml file, but does not say, which pom.xml file. As it turns out in the 
> example below, it can be the file in the directory where mvn is called, and 
> not really the file where the property is used.
> If the problems as the one below cannot be resolved cleanly,  would adding a 
> property, which always points to pom.xml own directory, help?
> I am sorry for the formatting, it is the system which puts new paragraphs and 
> brackets for whatever reason.
> I have a Maven child project in a directory "child". I have also a parent 
> project "local-lib" in the directory "child/local-lib" which contains a 
> repository with jars. The repository is declared in "child/local-lib/pom.xml" 
> as
> {code:xml}
> 
>   
> repo
> [file:///$]}}{{{project.basedir}/repo
>   
> 
> {code}
>  
>  The child project has "child/pom.xml" where it refers to its parent as 
> follows:
>  
> {code:xml}
> 
>   someGroup
>   local-lib
>   0.0.1
>   ./local-lib
> 
> {code}
>  
>  When I type "mvn clean install" in the child project, that is, in the 
> directory "child", the child project attempts to search for a non-existing 
> repository "child/repo", instead of "child/local-lib/repo". However, 
> replacing "${project.basedir}" in "child/local-lib/pom.xml" with the full 
> path to "child/local-lib" on my disk makes the child project use the correct 
> repository child/local-lib/repo. This in turn, placed in 
> child/local-lib/pom.xml as before, but with additional "local-lib":
>  
> {code:xml}
> 
>   
> repo
> [file:///$]{project.basedir}/local-lib/repo
>   
> 
> {code}
> works this time correctly if I use maven from the directory "child", but not 
> if I use directly "child/local-lib/pom.xml" from "child/local-lib". The 
> latter creates a path with local-lib included twice.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (MPOM-244) Upload SHA-512 to Staging Repository

2021-01-29 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255937#comment-17255937
 ] 

Konrad Windszus edited comment on MPOM-244 at 1/29/21, 5:03 PM:


Instead of configuring this in the Maven Resolver, we should generate the 
SHA512 checksums as additional artifacts with 
[http://checksum-maven-plugin.nicoulaj.net/artifacts-mojo.html.]  That way the 
Staging Repository contains all necessary artifacts for an ASF release in dist. 
The only thing which currently blocks is a release containing 
https://github.com/nicoulaj/checksum-maven-plugin/pull/87 and 
https://github.com/nicoulaj/checksum-maven-plugin/pull/101.


was (Author: kwin):
Instead of configuring this in the Maven Resolver, we should generate the 
SHA512 checksums as additional artifacts with 
[http://checksum-maven-plugin.nicoulaj.net/artifacts-mojo.html.]  That way the 
Staging Repository contains all necessary artifacts for an ASF release in dist. 
The only thing which currently blocks is a release containing 
https://github.com/nicoulaj/checksum-maven-plugin/pull/87.

> Upload SHA-512 to Staging Repository
> 
>
> Key: MPOM-244
> URL: https://issues.apache.org/jira/browse/MPOM-244
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Affects Versions: ASF-23
>Reporter: Konrad Windszus
>Priority: Major
>
> As now the ASF staging repository supports SHA2 hashes 
> (https://issues.apache.org/jira/browse/INFRA-14923) they should be generated 
> for 
> - all attached artifacts and
> - deployed to the Staging repository (i.e. attached to build as well)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-7088) A property which always points to pom.xml own directory

2021-01-29 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274569#comment-17274569
 ] 

Michael Osipov commented on MNG-7088:
-

This property never points to a file, but to the project directory only. I am 
confused why you are always talking about the POM here.

> A property which always points to pom.xml own directory
> ---
>
> Key: MNG-7088
> URL: https://issues.apache.org/jira/browse/MNG-7088
> Project: Maven
>  Issue Type: New Feature
>Affects Versions: 3.6.3
>Reporter: Monkey
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Maven docs say that ${project.basedir} points to the directory containing the 
> pom.xml file, but does not say, which pom.xml file. As it turns out in the 
> example below, it can be the file in the directory where mvn is called, and 
> not really the file where the property is used.
> If the problems as the one below cannot be resolved cleanly,  would adding a 
> property, which always points to pom.xml own directory, help?
> I am sorry for the formatting, it is the system which puts new paragraphs and 
> brackets for whatever reason.
> I have a Maven child project in a directory "child". I have also a parent 
> project "local-lib" in the directory "child/local-lib" which contains a 
> repository with jars. The repository is declared in "child/local-lib/pom.xml" 
> as
> {code:xml}
> 
>   
> repo
> [file:///$]}}{{{project.basedir}/repo
>   
> 
> {code}
>  
>  The child project has "child/pom.xml" where it refers to its parent as 
> follows:
>  
> {code:xml}
> 
>   someGroup
>   local-lib
>   0.0.1
>   ./local-lib
> 
> {code}
>  
>  When I type "mvn clean install" in the child project, that is, in the 
> directory "child", the child project attempts to search for a non-existing 
> repository "child/repo", instead of "child/local-lib/repo". However, 
> replacing "${project.basedir}" in "child/local-lib/pom.xml" with the full 
> path to "child/local-lib" on my disk makes the child project use the correct 
> repository child/local-lib/repo. This in turn, placed in 
> child/local-lib/pom.xml as before, but with additional "local-lib":
>  
> {code:xml}
> 
>   
> repo
> [file:///$]{project.basedir}/local-lib/repo
>   
> 
> {code}
> works this time correctly if I use maven from the directory "child", but not 
> if I use directly "child/local-lib/pom.xml" from "child/local-lib". The 
> latter creates a path with local-lib included twice.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MCOMPILER-452) release cannot be emptied to activate profiles compiling with previous Java version

2021-01-29 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274567#comment-17274567
 ] 

Michael Osipov commented on MCOMPILER-452:
--

That's not related to this plugin, but you generally cannot remove properies, 
but only overwrite.

> release cannot be emptied to activate profiles compiling with previous Java 
> version
> ---
>
> Key: MCOMPILER-452
> URL: https://issues.apache.org/jira/browse/MCOMPILER-452
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.1
>Reporter: Lugan
>Priority: Minor
>
> I am working on a project where some sub modules maven are in compiled in 
> Java 8, some other in Java 11.
> For modules where sources must be compiled in Java 8, we still want to write 
> our tests in Java 11. 
> I have defined 2 profiles :
>  * Java 11 by default with the maven.compiler.release property set 
>  * Java 8 where the maven.compiler.release property is empty :
>  {code:xml}
> 
> 1.8
> 1.8
> 
> 
> {code}
> I have a IllegalArugmentException :
> {code:java}
> Caused by: java.lang.NumberFormatException: For input string: ""
> at java.lang.NumberFormatException.forInputString 
> (NumberFormatException.java:65)
> at java.lang.Integer.parseInt (Integer.java:662)
> at java.lang.Integer.valueOf (Integer.java:983)
> at org.apache.maven.plugin.compiler.TestCompilerMojo.preparePaths 
> (TestCompilerMojo.java:306)
>  {code}
> After inspecting the plugin source code on github, I have found that release 
> variable is tested to be null or not : 
> {code:java}
> if ( release != null )
> {
> if ( Integer.valueOf( release ) < 9 )
> {
> {code}
> https://github.com/apache/maven-compiler-plugin/blob/master/src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java
> It would be more robust by checking if release is neither null nor empty. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (WAGON-606) Support HTTP/2

2021-01-29 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/WAGON-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274566#comment-17274566
 ] 

Michael Osipov commented on WAGON-606:
--

The benefit is already there. We have used a connection pool ever since. Please 
read: 
https://lists.apache.org/thread.html/r1694ec68c10ac5619a0d0ab932d6678dd42a4d310e92d71fc287d383%40%3Cusers.maven.apache.org%3E

Yes, your understanding ist correct, but one would also need to clean up 
deprecated stuff. So this is a lot of work.

> Support HTTP/2
> --
>
> Key: WAGON-606
> URL: https://issues.apache.org/jira/browse/WAGON-606
> Project: Maven Wagon
>  Issue Type: New Feature
>  Components: wagon-http
>Affects Versions: 3.4.2
>Reporter: Ingo Siebert
>Priority: Major
>
> Maven could get a performance boost when downloading and uploading artifacts 
> by using HTTP/2.
> The benefit out of the box would be, that the TCP connection is reused for 
> all HTTP/2 requests.
>  
> As far as I understood, the only thing that must be done is that the Apache 
> httpclient dependency must be updated from 4.5 to 5.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MWRAPPER-8) Status note on web page

2021-01-29 Thread Dominic Anello (Jira)


[ 
https://issues.apache.org/jira/browse/MWRAPPER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274542#comment-17274542
 ] 

Dominic Anello commented on MWRAPPER-8:
---

For what it's worth, I did read that line, but I did not take "introduced in 
Apache Maven 3.7.0" to mean "incompatible with maven 3.6" or "not released for 
public consumption".  I interpreted that to mean that while earlier versions 
might not be aware of the plugin out of the box, I could still add it using the 
standard plugin mechanism, especially given that the page at 
[https://maven.apache.org/plugins/maven-wrapper-plugin/plugin-info.html] 
indicates the minimum maven version is {{3.1.0}}

When that failed, I spent a bit of time futzing with the source distribution to 
see if I could build the {{apache-maven-wrapper:zip:script:3.6.2}} artifact and 
install it locally before I found this Jira ticket.  An explicit message saying 
not to bother with this plugin until Maven 3.7.0 is released would be helpful 
since for all intents and purposes it looks like a fully released and usable 
plugin.

> Status note on web page
> ---
>
> Key: MWRAPPER-8
> URL: https://issues.apache.org/jira/browse/MWRAPPER-8
> Project: Maven Wrapper
>  Issue Type: Task
>Affects Versions: 3.0.1
>Reporter: Markus Karg
>Priority: Trivial
>  Labels: documentation
>
> 3.0.1 was just released for development purposes, but not for public use. In 
> fact, this plugin does not work for the broad public, as it doesn't find its 
> needed downloads from Maven Central. Unfortunately there is no note on the 
> public web page of this plugin telling people so, hence more and more people 
> run into the problem that they try out the plugin and fail.
>  
> *I offer to put a clear warning there, that nobody needs to try out this 
> plugin, as it will definitively fail unless Maven 3.7.0 is published.*
>  
> On the other hand this only makes sense, if Maven 3.7.0 is several weeks away.
>  
> *So please tell me if it is worth sending a PR, or if you think 3.7.0 will be 
> here in the next few weeks.*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274533#comment-17274533
 ] 

Anjiang Wei edited comment on SUREFIRE-1884 at 1/29/21, 3:57 PM:
-

The content of my dumpstream file is:

Created at 2021-01-29T09:40:43.003
 null


was (Author: david1998):
The content of my dumpstream file is:

# Created at 2021-01-29T09:40:43.003
null

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274533#comment-17274533
 ] 

Anjiang Wei commented on SUREFIRE-1884:
---

The content of my dumpstream file is:

# Created at 2021-01-29T09:40:43.003
null

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274519#comment-17274519
 ] 

Tibor Digana commented on SUREFIRE-1884:


Obviously some system property influenced the build. None of them except 
{{-Dtest=}} are related to Surefire. So I am wondering.

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274518#comment-17274518
 ] 

Tibor Digana commented on SUREFIRE-1884:


Pls try to isolate bunch of system properties and identify which one did it.
For instance I have found out NPE where the JUnit5 failed. Not sure if we are 
passing NULL test class or the framework failed. See the dump file, mine is 
located in 

{noformat}
commons-collections/target/surefire-reports/2021-01-29T16-10-06_641-jvmRun1.dumpstream
{noformat}


> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274515#comment-17274515
 ] 

Anjiang Wei commented on SUREFIRE-1884:
---

Thanks for confirming this! Yes, the inconsistency between the two results 
shows that one of them is problematic. If you need any further help from me, 
please let me know:)

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274506#comment-17274506
 ] 

Tibor Digana commented on SUREFIRE-1884:


I've got successful build including many tests run with this command

{noformat}
mvn test
{noformat}

then I cleaned the build


{noformat}
mvn clean
{noformat}


The build failed after i run your command:

{noformat}
mvn test -Dtest=TransformedMultiValuedMapTest -Dlicense.skip -Dcheckstyle.skip 
-Drat.skip -Denforcer.skip -Danimal.sniffer.skip -Dmaven.javadoc.skip 
-Dfindbugs.skip -Dwarbucks.skip -Dmodernizer.skip -Dimpsort.skip 
-Dmdep.analyze.skip -Dpgpverify.skip -Dxml.skip -Ddependency-check.skip=true 
-Dgpg.skip -fn
{noformat}

You have to investigate the system properties. Obviously one of them is 
problematic.

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-surefire] oehme commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox


oehme commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r566875005



##
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##
@@ -286,7 +289,15 @@ private static String createErrorMessage( 
SurefireReportParameters reportParamet
 }
 else
 {
-msg.append( "There are test failures.\n\nPlease refer to " )
+if ( result.getFailures() > 0 )

Review comment:
   The IntegrationTestMojo does not report this text. The VerifyMojo does 
and uses the same logic as the SurefirePlugin





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274488#comment-17274488
 ] 

Anjiang Wei commented on SUREFIRE-1884:
---

Yeah, you are right. I have upgraded to 3.0.0-M5 and the results are the same 
as 2.22.2.

The commit is 
[https://github.com/Anjiang-Wei/commons-collections/commit/dcb404159f0d09de8d03317805b92ececbd1d30c]

The build log is 
[https://travis-ci.com/github/Anjiang-Wei/commons-collections/jobs/478283514]

 

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274474#comment-17274474
 ] 

Tibor Digana commented on SUREFIRE-1884:


Version 2.22.2 is pretty old. Pls check it out with 3.0.0-M5. Thx

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1812) Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) are not reported

2021-01-29 Thread Jiri Ondrusek (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1727#comment-1727
 ] 

Jiri Ondrusek commented on SUREFIRE-1812:
-

[~tibordigana] I rebased my test branch - 
[https://github.com/apache/camel-quarkus/pull/1383] - and once there will be 
some results, I'll compare it to some other results (using older surefire 
plugin). From my notes, there should be a difference in the following test: 
`org.apache.camel.quarkus.component.braintree.it.BraintreeTest`

> Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) 
> are not reported
> --
>
> Key: SUREFIRE-1812
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1812
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4, 3.0.0-M5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> I'm upgrading surefire plugin from 2.22.2 and there is a different behavior 
> started from 3.0.0-M4.
> When the test class is ignored by using @EnabledIfEnvironmentVariable(...), 
> final report shows bad information: (3.0.0.-M4, M5, master)
> {quote}[INFO] Results:
> [INFO] 
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {quote}
> The same test executed with 3.0.0-M3 shows:
> {quote}[INFO] Results:
> [INFO] 
> [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274440#comment-17274440
 ] 

Anjiang Wei commented on SUREFIRE-1884:
---

[~tibordigana]

That's a good idea. I hope the following steps can make results more objective.

I forked 
[apache/commons-collections|https://travis-ci.com/github/apache/commons-collections/jobs/472448798]
 and added one more line to the CI config file:

[https://github.com/Anjiang-Wei/commons-collections/commit/33d0f2e8f635]

The following is the build log.

[https://travis-ci.com/github/Anjiang-Wei/commons-collections/jobs/478257402]

By searching for the word TransformedMultiValuedMapTest, you can see that mvn 
test -Dtest=TransformedMultiValuedMapTest failed due to 
SurefireBooterForkException.

_[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There 
was an error in the forked process_ 

_[ERROR] null_ 

_[ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
 [ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
 [ERROR] at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)_

 

But when running the whole test suite, tests all passed:

_[INFO] Running TransformedMultiValuedMapTest_

_[INFO] Tests run: 342, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.065 
s - in TransformedMultiValuedMapTest_

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274421#comment-17274421
 ] 

Tibor Digana commented on SUREFIRE-1884:


[~david1998]
Can you show me the log from GitHub CI for the particular commit?
We have to start with something objective.

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox


Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r566806966



##
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##
@@ -286,7 +289,15 @@ private static String createErrorMessage( 
SurefireReportParameters reportParamet
 }
 else
 {
-msg.append( "There are test failures.\n\nPlease refer to " )
+if ( result.getFailures() > 0 )

Review comment:
   @oehme 
   Pls see the class `IntegrationTestPlugin`. It reports this text other way. 
The same messages should be there as well but the solution is different from 
this one.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] paplorinc commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox


paplorinc commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r566785137



##
File path: 
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
##
@@ -139,6 +139,13 @@
 @Parameter( property = "failIfNoTests" )
 private Boolean failIfNoTests;
 
+/**
+ * Set this to a value greater than 0 to fail the whole test set if the 
cumulative number of flakes reaches
+ * this threshold. Set to 0 to allow an unlimited number of flakes.

Review comment:
   based on the code a negative number would do the same, right?
   Should we maybe rather fail in that case?

##
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##
@@ -142,7 +142,10 @@ public static void reportExecution( 
SurefireReportParameters reportParameters, R
 PluginConsoleLogger log, Exception 
firstForkException )
 throws MojoFailureException, MojoExecutionException
 {
-if ( firstForkException == null && !result.isTimeout() && 
result.isErrorFree() )
+boolean isError = firstForkException != null || result.isTimeout() || 
!result.isErrorFree();
+boolean isFlaky = reportParameters.getFailOnFlakeCount() > 0
+&& result.getFlakes() >= reportParameters.getFailOnFlakeCount();

Review comment:
   minor: could we have `getFailOnFlakeCount` on the same side on both 
cases to simplify comparison?

##
File path: 
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefireHelperTest.java
##
@@ -156,4 +156,59 @@ public void shouldHandleTestFailure() throws Exception
 + "for the individual test results.\nPlease refer to dump 
files (if any exist) "
 + "[date].dump, [date]-jvmRun[N].dump and [date].dumpstream.'" 
);
 }
+
+@Test
+public void failsIfThereAreTooManyFlakes() throws Exception
+{
+RunResult summary = new RunResult( 1, 0, 0, 0, 1 );
+Mojo reportParameters = new Mojo();
+reportParameters.setFailOnFlakeCount( 1 );
+try
+{
+reportExecution( reportParameters, summary, null, null );
+}
+catch ( MojoFailureException e )
+{
+assertThat( e.getLocalizedMessage() )
+.isEqualTo( "There are too many flakes.\n\nPlease refer to 
null "
++ "for the individual test results.\nPlease refer to dump 
files (if any exist) "
++ "[date].dump, [date]-jvmRun[N].dump and 
[date].dumpstream." );
+return;
+}
+fail( "Expected MojoFailureException with message "

Review comment:
   minor: you could add this inside the try in which case we wouldn't need 
a return in the catch

##
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##
@@ -142,7 +142,10 @@ public static void reportExecution( 
SurefireReportParameters reportParameters, R
 PluginConsoleLogger log, Exception 
firstForkException )
 throws MojoFailureException, MojoExecutionException
 {
-if ( firstForkException == null && !result.isTimeout() && 
result.isErrorFree() )
+boolean isError = firstForkException != null || result.isTimeout() || 
!result.isErrorFree();
+boolean isFlaky = reportParameters.getFailOnFlakeCount() > 0

Review comment:
   this stores more than whether we're flaky, rather something like: 
`isFlakyError`, right?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] paplorinc commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox


paplorinc commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r566784637



##
File path: 
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
##
@@ -139,6 +139,12 @@
 @Parameter( property = "failIfNoTests" )
 private Boolean failIfNoTests;
 
+/**
+ * The number of flakes after which the overall test suite will be 
considered a failure.
+ */
+@Parameter( property = "surefire.failOnFlakeCount", defaultValue = "0" )
+private int failOnFlakeCount;

Review comment:
   It's very clear now, thanks!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox


oehme commented on pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-769772297


   I've clarified the documentation and added unit tests. I've removed the 
integration test, since this feature is not junit-platform specific, but fully 
contained in SurefireHelper.
   
   Are there any other things I should add or modify?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #39: Bump plexusCompilerVersion to 2.8.8

2021-01-29 Thread GitBox


pzygielo commented on pull request #39:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/39#issuecomment-769767049


   May I ask for review, please?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274350#comment-17274350
 ] 

Anjiang Wei edited comment on SUREFIRE-1884 at 1/29/21, 11:28 AM:
--

[~tibordigana] Thanks for your comments! What seems to be the bug is that 
running the whole test suite doesn't throw any exception, while running the 
specific test class does. So I believe there is a bug. I have confirmed this is 
reproducible on two different machines. Maybe minimization of the input should 
be done first in order to localize the bug.


was (Author: david1998):
[~tibordigana] Thanks for your comments! What seems to be the bug is that 
running the whole test suite doesn't throw any exception, while running the 
specific test class does. So I believe there is a bug. Maybe minimization of 
the input should be done first in order to localize the bug.

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274349#comment-17274349
 ] 

Tibor Digana edited comment on SUREFIRE-1884 at 1/29/21, 11:24 AM:
---

Sorry but i do not see the error in your build log for the particular commit
https://travis-ci.com/github/apache/commons-collections/jobs/472448798


was (Author: tibor17):
Sorry but i do not see the error in your build log for the particular commit

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274350#comment-17274350
 ] 

Anjiang Wei commented on SUREFIRE-1884:
---

[~tibordigana] Thanks for your comments! What seems to be the bug is that 
running the whole test suite doesn't throw any exception, while running the 
specific test class does. So I believe there is a bug. Maybe minimization of 
the input should be done first in order to localize the bug.

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274349#comment-17274349
 ] 

Tibor Digana commented on SUREFIRE-1884:


Sorry but i do not see the error in your build log for the particular commit

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-compiler-plugin] pzygielo opened a new pull request #39: Bump plexusCompilerVersion to 2.8.8

2021-01-29 Thread GitBox


pzygielo opened a new pull request #39:
URL: https://github.com/apache/maven-compiler-plugin/pull/39


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274344#comment-17274344
 ] 

Tibor Digana commented on SUREFIRE-1884:


[~david1998]
Pls proove it that it is a bug. You provided some instructions but no evidence 
of the bug. Stacktrace is not a bug. It is a normal end of build failure. It is 
not a failure within the plugin.

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Tibor Digana (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1884:
---
Issue Type: Wish  (was: Bug)

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Wish
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MTOOLCHAINS-34) Toolchains breaks annotation processing

2021-01-29 Thread James (Jira)


 [ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James updated MTOOLCHAINS-34:
-
Attachment: mvn-debug-working.txt
mvn-debug-not-working.txt

> Toolchains breaks annotation processing
> ---
>
> Key: MTOOLCHAINS-34
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-34
> Project: Maven Toolchains Plugin
>  Issue Type: Bug
>Reporter: James
>Priority: Major
> Attachments: mvn-debug-not-working.txt, mvn-debug-working.txt, 
> toolchains.xml
>
>
> The following will work...
> Clone: [https://github.com/cloudogu/annotation-processors]
> Then:
> 1: cd part-1-maven
> 2: mvn clean install.
> You will see:
> [*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello
> In the output to indicate that it works.
> Now, if you clone my forked repo:
> [https://github.com/jimhooker2002/annotation-processors]
> You'll see the following diff: 
> [https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]
> And note that it will no longer work (the log message no longer appears).  In 
> my forked repo, if you comment out the maven-toolchains-plugin, it will start 
> to work again.
> So, it looks as though toolchains plugin is preventing the annotation 
> processing from running somehow.
>  
> My setup:
> mvn -v
> *Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T20:00:29+01:00)*
> Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1
> Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>  
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/java 
> --version
> openjdk 11.0.4 2019-07-16
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)
> OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)
> Following files attached: 
> 1: My toolchains.xml is attached 
> 2: mvn -X output when it works.
> 3: mvn -X output whet it doesn't work.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MTOOLCHAINS-34) Toolchains breaks annotation processing

2021-01-29 Thread James (Jira)


 [ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James updated MTOOLCHAINS-34:
-
Description: 
The following will work...

Clone: [https://github.com/cloudogu/annotation-processors]

Then:

1: cd part-1-maven

2: mvn clean install.

You will see:

[*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello

In the output to indicate that it works.

Now, if you clone my forked repo:

[https://github.com/jimhooker2002/annotation-processors]

You'll see the following diff: 
[https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]

And note that it will no longer work (the log message no longer appears).  In 
my forked repo, if you comment out the maven-toolchains-plugin, it will start 
to work again.

So, it looks as though toolchains plugin is preventing the annotation 
processing from running somehow.

 

My setup:

mvn -v

*Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
2019-04-04T20:00:29+01:00)*

Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1

Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

Default locale: en_GB, platform encoding: UTF-8

OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"

 

/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/java 
--version

openjdk 11.0.4 2019-07-16

OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)

OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)




Following files attached:

1: My toolchains.xml is attached 
 2: mvn -X output when it works.

3: mvn -X output whet it doesn't work.

 

  was:
The following will work...

Clone: [https://github.com/cloudogu/annotation-processors]

Then:

1: cd part-1-maven

2: mvn clean install.

You will see:

[*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello

In the output to indicate that it works.

Now, if you clone my forked repo:

[https://github.com/jimhooker2002/annotation-processors]

You'll see the following diff: 
[https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]

And note that it will no longer work (the log message no longer appears).  In 
my forked repo, if you comment out the maven-toolchains-plugin, it will start 
to work again.

So, it looks as though toolchains plugin is preventing the annotation 
processing from running somehow.

 

My setup:

mvn -v

*Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
2019-04-04T20:00:29+01:00)*

Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1

Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

Default locale: en_GB, platform encoding: UTF-8

OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"

 

/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/java 
--version

openjdk 11.0.4 2019-07-16

OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)

OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)

Following files attached: 

1: My toolchains.xml is attached 
2: mvn -X output when it works.

3: mvn -X output whet it doesn't work.

 


> Toolchains breaks annotation processing
> ---
>
> Key: MTOOLCHAINS-34
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-34
> Project: Maven Toolchains Plugin
>  Issue Type: Bug
>Reporter: James
>Priority: Major
> Attachments: mvn-debug-not-working.txt, mvn-debug-working.txt, 
> toolchains.xml
>
>
> The following will work...
> Clone: [https://github.com/cloudogu/annotation-processors]
> Then:
> 1: cd part-1-maven
> 2: mvn clean install.
> You will see:
> [*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello
> In the output to indicate that it works.
> Now, if you clone my forked repo:
> [https://github.com/jimhooker2002/annotation-processors]
> You'll see the following diff: 
> [https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]
> And note that it will no longer work (the log message no longer appears).  In 
> my forked repo, if you comment out the maven-toolchains-plugin, it will start 
> to work again.
> So, it looks as though toolchains plugin is preventing the annotation 
> processing from running somehow.
>  
> My setup:
> mvn -v
> *Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T20:00:29+01:00)*
> Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1
> Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x

[jira] [Updated] (MTOOLCHAINS-34) Toolchains breaks annotation processing

2021-01-29 Thread James (Jira)


 [ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James updated MTOOLCHAINS-34:
-
Description: 
The following will work...

Clone: [https://github.com/cloudogu/annotation-processors]

Then:

1: cd part-1-maven

2: mvn clean install.

You will see:

[*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello

In the output to indicate that it works.

Now, if you clone my forked repo:

[https://github.com/jimhooker2002/annotation-processors]

You'll see the following diff: 
[https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]

And note that it will no longer work (the log message no longer appears).  In 
my forked repo, if you comment out the maven-toolchains-plugin, it will start 
to work again.

So, it looks as though toolchains plugin is preventing the annotation 
processing from running somehow.

 

My setup:

mvn -v

*Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
2019-04-04T20:00:29+01:00)*

Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1

Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

Default locale: en_GB, platform encoding: UTF-8

OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"

 

/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/java 
--version

openjdk 11.0.4 2019-07-16

OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)

OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)

Following files attached: 

1: My toolchains.xml is attached 
2: mvn -X output when it works.

3: mvn -X output whet it doesn't work.

 

  was:
The following will work...

Clone: [https://github.com/cloudogu/annotation-processors]

Then:

1: cd part-1-maven

2: mvn clean install.

You will see:

[*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello

In the output to indicate that it works.

Now, if you clone my forked repo:

[https://github.com/jimhooker2002/annotation-processors]

You'll see the following diff: 
[https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]

And note that it will no longer work (the log message no longer appears).  In 
my forked repo, if you comment out the maven-toolchains-plugin, it will start 
to work again.

So, it looks as though toolchains plugin is preventing the annotation 
processing from running somehow.

 

My setup:

mvn -v

*Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
2019-04-04T20:00:29+01:00)*

Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1

Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

Default locale: en_GB, platform encoding: UTF-8

OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"

 

/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/java 
--version

openjdk 11.0.4 2019-07-16

OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)

OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)



My toolchains.xml is attached 




 


> Toolchains breaks annotation processing
> ---
>
> Key: MTOOLCHAINS-34
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-34
> Project: Maven Toolchains Plugin
>  Issue Type: Bug
>Reporter: James
>Priority: Major
> Attachments: mvn-debug-not-working.txt, mvn-debug-working.txt, 
> toolchains.xml
>
>
> The following will work...
> Clone: [https://github.com/cloudogu/annotation-processors]
> Then:
> 1: cd part-1-maven
> 2: mvn clean install.
> You will see:
> [*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello
> In the output to indicate that it works.
> Now, if you clone my forked repo:
> [https://github.com/jimhooker2002/annotation-processors]
> You'll see the following diff: 
> [https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]
> And note that it will no longer work (the log message no longer appears).  In 
> my forked repo, if you comment out the maven-toolchains-plugin, it will start 
> to work again.
> So, it looks as though toolchains plugin is preventing the annotation 
> processing from running somehow.
>  
> My setup:
> mvn -v
> *Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T20:00:29+01:00)*
> Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1
> Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>  
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/j

[jira] [Updated] (MTOOLCHAINS-34) Toolchains breaks annotation processing

2021-01-29 Thread James (Jira)


 [ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James updated MTOOLCHAINS-34:
-
Description: 
The following will work...

Clone: [https://github.com/cloudogu/annotation-processors]

Then:

1: cd part-1-maven

2: mvn clean install.

You will see:

[*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello

In the output to indicate that it works.

Now, if you clone my forked repo:

[https://github.com/jimhooker2002/annotation-processors]

You'll see the following diff: 
[https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]

And note that it will no longer work (the log message no longer appears).  In 
my forked repo, if you comment out the maven-toolchains-plugin, it will start 
to work again.

So, it looks as though toolchains plugin is preventing the annotation 
processing from running somehow.

 

My setup:

mvn -v

*Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
2019-04-04T20:00:29+01:00)*

Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1

Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

Default locale: en_GB, platform encoding: UTF-8

OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"

 

/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/java 
--version

openjdk 11.0.4 2019-07-16

OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)

OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)



My toolchains.xml is attached 




 

  was:
The following will work...

Clone: [https://github.com/cloudogu/annotation-processors]

Then:

1: cd part-1-maven

2: mvn clean install.

You will see:

[*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello

In the output to indicate that it works.

Now, if you clone my forked repo:

[https://github.com/jimhooker2002/annotation-processors]

You'll see the following diff: 
[https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]

And note that it will no longer work (the log message no longer appears).  In 
my forked repo, if you comment out the maven-toolchains-plugin, it will start 
to work again.

So, it looks as though toolchains plugin is preventing the annotation 
processing from running somehow.

 

My setup:



mvn -v

*Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
2019-04-04T20:00:29+01:00)*

Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1

Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

Default locale: en_GB, platform encoding: UTF-8

OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"

My toolchains.xml is attached 



 


> Toolchains breaks annotation processing
> ---
>
> Key: MTOOLCHAINS-34
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-34
> Project: Maven Toolchains Plugin
>  Issue Type: Bug
>Reporter: James
>Priority: Major
> Attachments: toolchains.xml
>
>
> The following will work...
> Clone: [https://github.com/cloudogu/annotation-processors]
> Then:
> 1: cd part-1-maven
> 2: mvn clean install.
> You will see:
> [*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello
> In the output to indicate that it works.
> Now, if you clone my forked repo:
> [https://github.com/jimhooker2002/annotation-processors]
> You'll see the following diff: 
> [https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]
> And note that it will no longer work (the log message no longer appears).  In 
> my forked repo, if you comment out the maven-toolchains-plugin, it will start 
> to work again.
> So, it looks as though toolchains plugin is preventing the annotation 
> processing from running somehow.
>  
> My setup:
> mvn -v
> *Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T20:00:29+01:00)*
> Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1
> Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>  
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/java 
> --version
> openjdk 11.0.4 2019-07-16
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)
> OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)
> My toolchains.xml is attached 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (MTOOLCHAINS-34) Toolchains breaks annotation processing

2021-01-29 Thread James (Jira)
James created MTOOLCHAINS-34:


 Summary: Toolchains breaks annotation processing
 Key: MTOOLCHAINS-34
 URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-34
 Project: Maven Toolchains Plugin
  Issue Type: Bug
Reporter: James
 Attachments: toolchains.xml

The following will work...

Clone: [https://github.com/cloudogu/annotation-processors]

Then:

1: cd part-1-maven

2: mvn clean install.

You will see:

[*INFO*] found @Log at com.cloudogu.blog.annotationprocessor.sample.Hello

In the output to indicate that it works.

Now, if you clone my forked repo:

[https://github.com/jimhooker2002/annotation-processors]

You'll see the following diff: 
[https://github.com/cloudogu/annotation-processors/compare/master...jimhooker2002:master]

And note that it will no longer work (the log message no longer appears).  In 
my forked repo, if you comment out the maven-toolchains-plugin, it will start 
to work again.

So, it looks as though toolchains plugin is preventing the annotation 
processing from running somehow.

 

My setup:



mvn -v

*Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
2019-04-04T20:00:29+01:00)*

Maven home: /Users/james.hooker/Applications/apache-maven-3.6.1

Java version: 11.0.4, vendor: AdoptOpenJDK, runtime: 
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

Default locale: en_GB, platform encoding: UTF-8

OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"

My toolchains.xml is attached 



 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (WAGON-606) Support HTTP/2

2021-01-29 Thread Ingo Siebert (Jira)
Ingo Siebert created WAGON-606:
--

 Summary: Support HTTP/2
 Key: WAGON-606
 URL: https://issues.apache.org/jira/browse/WAGON-606
 Project: Maven Wagon
  Issue Type: New Feature
  Components: wagon-http
Affects Versions: 3.4.2
Reporter: Ingo Siebert


Maven could get a performance boost when downloading and uploading artifacts by 
using HTTP/2.
The benefit out of the box would be, that the TCP connection is reused for all 
HTTP/2 requests.

 

As far as I understood, the only thing that must be done is that the Apache 
httpclient dependency must be updated from 4.5 to 5.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anjiang Wei updated SUREFIRE-1884:
--
Priority: Major  (was: Critical)

> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Major
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel

2021-01-29 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274268#comment-17274268
 ] 

Michael Osipov commented on MRESOLVER-7:


[~ppanda-beta], if you really need this feature then hire a contractor, pay him 
€€€ and we will review his PR. You obviously don't understand that we are 
volunteers don't have to do nothing for you!

> Download dependency POMs in parallel
> 
>
> Key: MRESOLVER-7
> URL: https://issues.apache.org/jira/browse/MRESOLVER-7
> Project: Maven Resolver
>  Issue Type: Improvement
>Affects Versions: Aether 1.0.2
>Reporter: Harald Wellmann
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> h3. Background
> When building a project with dependencies not yet available in the local 
> repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the 
> dependency POMs _sequentially_ and then proceeds downloading the dependency 
> JARs with up to 5 threads _in parallel_.
> Due to this, when first building a project with a large number of 
> dependencies, downloading a large number of small POMs may take a lot longer 
> than downloading the much larger JARs, or even longer than building the 
> project itself, especially when a repository manager is used which increases 
> the download latency.
> h3. Enhancement
> Download POMs of (transitive) dependencies in parallel to significantly speed 
> up initial builds of large projects.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anjiang Wei updated SUREFIRE-1884:
--
Description: 
Steps to reproduce:

git clone [https://github.com/apache/commons-collections;]

cd commons-collections

git checkout dc01c2583a6d77242862f92b38908d1fc28e90de

mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
-Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
-Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
-Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'

mvn test-compile $mvnops

mvn test $mvnops # Running whole test suite works fine

mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
exception # [ERROR] 
org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
error in the forked process

 

The full stack trace has been uploaded in the attachment.

  was:
Steps to reproduce:

git clone [https://github.com/apache/commons-collections;]

cd commons-collections

# git checkout dc01c2583a6d77242862f92b38908d1fc28e90de

mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
-Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
-Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
-Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'

mvn test-compile $mvnops

mvn test $mvnops # Running whole test suite works fine

mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
exception # [ERROR] 
org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
error in the forked process

 

The full stack trace has been uploaded in the attachment.


> Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest 
> from apache/commons-collections
> -
>
> Key: SUREFIRE-1884
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.22.2
> Environment: The following is the Java / Maven version info:
> openjdk version "1.8.0_252"
> OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
> OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
> --
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_252, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
>Reporter: Anjiang Wei
>Priority: Critical
> Attachments: Full Stack Trace.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Steps to reproduce:
> git clone [https://github.com/apache/commons-collections;]
> cd commons-collections
> git checkout dc01c2583a6d77242862f92b38908d1fc28e90de
> mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
> -Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
> -Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
> -Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'
> mvn test-compile $mvnops
> mvn test $mvnops # Running whole test suite works fine
> mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
> exception # [ERROR] 
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
>  
> The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SUREFIRE-1884) Forked JVM Throws an Exception When Running TransformedMultiValuedMapTest from apache/commons-collections

2021-01-29 Thread Anjiang Wei (Jira)
Anjiang Wei created SUREFIRE-1884:
-

 Summary: Forked JVM Throws an Exception When Running 
TransformedMultiValuedMapTest from apache/commons-collections
 Key: SUREFIRE-1884
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1884
 Project: Maven Surefire
  Issue Type: Bug
  Components: Maven Surefire Plugin, process forking
Affects Versions: 2.22.2
 Environment: The following is the Java / Maven version info:
openjdk version "1.8.0_252"
OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
--
Apache Maven 3.6.0
Maven home: /usr/share/maven
Java version: 1.8.0_252, vendor: Private Build, runtime: 
/usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family: "unix
Reporter: Anjiang Wei
 Attachments: Full Stack Trace.txt

Steps to reproduce:

git clone [https://github.com/apache/commons-collections;]

cd commons-collections

# git checkout dc01c2583a6d77242862f92b38908d1fc28e90de

mvnops='-Dlicense.skip -Dcheckstyle.skip -Drat.skip -Denforcer.skip 
-Danimal.sniffer.skip -Dmaven.javadoc.skip -Dfindbugs.skip -Dwarbucks.skip 
-Dmodernizer.skip -Dimpsort.skip -Dmdep.analyze.skip -Dpgpverify.skip 
-Dxml.skip -Ddependency-check.skip=true -Dgpg.skip -fn'

mvn test-compile $mvnops

mvn test $mvnops # Running whole test suite works fine

mvn test -Dtest=TransformedMultiValuedMapTest $mvnops # forked JVM throws an 
exception # [ERROR] 
org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
error in the forked process

 

The full stack trace has been uploaded in the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-shade-plugin] JanMosigItemis commented on pull request #83: [MSHADE-366] - "Access denied" during 'minimizeJar'

2021-01-29 Thread GitBox


JanMosigItemis commented on pull request #83:
URL: https://github.com/apache/maven-shade-plugin/pull/83#issuecomment-769668875


   @rmannibucau yes I checked. It is bc 
org.apache.maven.plugins.shade.filter.MinijarFilter.removeServices(MavenProject,
 Clazzpath) calls `project.getRuntimeClasspathElements` which puts the output 
directory on the resulting list. See 
https://github.com/apache/maven/blob/bb916d0784c7631866167928e4d0615df3317567/maven-core/src/main/java/org/apache/maven/project/MavenProject.java#L412
   
   I could provide the test you wrote about, but I am not sure it leaves the 
scope of this PR, bc such a test was already missing before I started working 
on the issue. Please let me know if such a test is required here.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (MARTIFACT-2) First version release

2021-01-29 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274238#comment-17274238
 ] 

Herve Boutemy commented on MARTIFACT-2:
---

please vote on the dev mailing list

> First version release
> -
>
> Key: MARTIFACT-2
> URL: https://issues.apache.org/jira/browse/MARTIFACT-2
> Project: Maven Artifact Plugin
>  Issue Type: Wish
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: 1.0
>
>
> When do you want to release first version of plugin?
> Released version will be easier to testing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1876) Possibility to skip unit but not integration tests

2021-01-29 Thread Tobias Stadler (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274230#comment-17274230
 ] 

Tobias Stadler commented on SUREFIRE-1876:
--

I am using a similar workaround at the moment.

> Possibility to skip unit but not integration tests
> --
>
> Key: SUREFIRE-1876
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1876
> Project: Maven Surefire
>  Issue Type: New Feature
>  Components: Maven Failsafe Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Tobias Stadler
>Priority: Major
>
> Currently one can skip execution of integration test while still executing 
> unit tests by using the skipIT property. I would would like to be able to 
> skip execution of unit tests but not the integration tests.
> My integration tests are located in a module of a multi module project. When 
> running mvn verify -pl :my-it-project -am both unit and integration tests for 
> all projects are run. Skipping unit test execution would speed things up a 
> little bit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-surefire] tobiasstadler commented on pull request #331: [SUREFIRE-1876] Added support for skipping unit test execution not affecting integration test execution

2021-01-29 Thread GitBox


tobiasstadler commented on pull request #331:
URL: https://github.com/apache/maven-surefire/pull/331#issuecomment-769650598


   Yes, I am using the following surefire configuration at the moment:
   ```
   
   ${skipUTs}
   
   ```
   
   But I think it is more convenient if it was built into the plugin.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org