[jira] [Updated] (MNG-7049) Version range resolution downloads all poms, not just the highest version

2021-02-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7049:

Issue Type: Improvement  (was: Bug)

> Version range resolution downloads all poms, not just the highest version
> -
>
> Key: MNG-7049
> URL: https://issues.apache.org/jira/browse/MNG-7049
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Reporter: Moti Nisenson-Ken
>Priority: Major
>
> When specifying a version range for a dependency, maven will download and try 
> to resolve all poms in that range which satisfy the range. The usage however 
> is only to use the highestVersion. This causes two issues:
>  # Performance - it's downloading numerous poms that aren't needed.
>  # Fragility - if the version range covers any "bad" poms, then the build 
> will fail. For example, consider that for a specific version, the parent of a 
> pom is not present in the repository. This is enough to fail any build with a 
> version range covering that specific version, as the range resolution stage 
> will not complete. This is particularly harmful when that version would not 
> be selected as the highest, anyway.
> Recommend to have a system property to control the desired behavior - it 
> should be possible to short-circuit loading all the versions and to just to 
> load the highest version.
> For another user report of this see: 
> [https://stackoverflow.com/questions/25047859/restrict-maven-to-not-download-all-poms]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MNG-7049) Version range resolution downloads all poms, not just the highest version

2021-02-03 Thread Xiang Li (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278423#comment-17278423
 ] 

Xiang Li commented on MNG-7049:
---

I hit the same issue, I wonder if it is necessary for 
DefaultVersionRangeResolver to download all previous poms instead of directly 
getting the highest version from metadata, seem maven version plugin did able 
to fetch metadata only. 

> Version range resolution downloads all poms, not just the highest version
> -
>
> Key: MNG-7049
> URL: https://issues.apache.org/jira/browse/MNG-7049
> Project: Maven
>  Issue Type: Bug
>  Components: core
>Reporter: Moti Nisenson-Ken
>Priority: Major
>
> When specifying a version range for a dependency, maven will download and try 
> to resolve all poms in that range which satisfy the range. The usage however 
> is only to use the highestVersion. This causes two issues:
>  # Performance - it's downloading numerous poms that aren't needed.
>  # Fragility - if the version range covers any "bad" poms, then the build 
> will fail. For example, consider that for a specific version, the parent of a 
> pom is not present in the repository. This is enough to fail any build with a 
> version range covering that specific version, as the range resolution stage 
> will not complete. This is particularly harmful when that version would not 
> be selected as the highest, anyway.
> Recommend to have a system property to control the desired behavior - it 
> should be possible to short-circuit loading all the versions and to just to 
> load the highest version.
> For another user report of this see: 
> [https://stackoverflow.com/questions/25047859/restrict-maven-to-not-download-all-poms]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven] rmannibucau commented on pull request #177: [MNG-6471] during parallel build, ensure to set the thread name to the artifactId

2021-02-03 Thread GitBox


rmannibucau commented on pull request #177:
URL: https://github.com/apache/maven/pull/177#issuecomment-772772663


   @michael-o +1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven] michael-o commented on pull request #177: [MNG-6471] during parallel build, ensure to set the thread name to the artifactId

2021-02-03 Thread GitBox


michael-o commented on pull request #177:
URL: https://github.com/apache/maven/pull/177#issuecomment-772720044


   What about a hybrid: `mvn-builder-`?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven] rmannibucau commented on pull request #177: [MNG-6471] during parallel build, ensure to set the thread name to the artifactId

2021-02-03 Thread GitBox


rmannibucau commented on pull request #177:
URL: https://github.com/apache/maven/pull/177#issuecomment-772698291


   @michael-o I would strip "Builder-" or at least make it "mvn-" (builder is 
too common and we don't know if it is a plugin or maven itself so it just takes 
space IMHO). Otherwise +1 for your version.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (MSHARED-867) Timed out processes can stay alive in background

2021-02-03 Thread Sylwester Lachiewicz (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278103#comment-17278103
 ] 

Sylwester Lachiewicz commented on MSHARED-867:
--

invoker -> mvn clean validate -> surefire fork running infinite test in 
project. 

Quick workaround for our CI implemented with 
[b9ea3371ce880db561aff3c30fc9f870b40c8d28|https://gitbox.apache.org/repos/asf?p=maven-invoker.git;a=commit;h=b9ea3371ce880db561aff3c30fc9f870b40c8d28]
  - to reproduce, remove timeout from test and use jcmd /ProcessTools to check 
bacgroundd processes

> Timed out processes can stay alive in background
> 
>
> Key: MSHARED-867
> URL: https://issues.apache.org/jira/browse/MSHARED-867
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-invoker
>Affects Versions: maven-invoker-3.0.1
> Environment: Windows, Java 8
>Reporter: Robert Scholte
>Priority: Major
>
> MSHARED-795 introduced a timeout for processes, but on Windows I can see Java 
> processes staying alive, Maven Invoker just continues without forcing them to 
> stop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Issue Comment Deleted] (MSHARED-926) Maven invoker build stuck at compiling a module

2021-02-03 Thread Sylwester Lachiewicz (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz updated MSHARED-926:
-
Comment: was deleted

(was: It may be related to MSHARED-867)

> Maven invoker build stuck at compiling a module
> ---
>
> Key: MSHARED-926
> URL: https://issues.apache.org/jira/browse/MSHARED-926
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-invoker
>Affects Versions: maven-invoker-3.0.1
> Environment: windows 10 64bit, intel i7-4770, 16gb ram,
>Reporter: gaurav
>Priority: Major
> Attachments: app_dump.txt, mvn_dump.txt
>
>
> Hi all,
> I am creating a tool to schedule two maven builds one after another using 
> maven-invoker APIs.
> Both maven projects are multi-module huge projects.
> The first projects build without issues and the next project build stucks 
> after sometime.
> I suspect there is some kind of thread related issue which causes it.
>  
>  
> {code:java}
> private void invokerAPI(Path pomRootPath, Properties props) {
>  InvocationRequest request = new DefaultInvocationRequest();
>  request.setPomFile(Paths.get(pomRootPath.toAbsolutePath().toString(), 
> "pom.xml").toFile());
>  request.setGoals(Arrays.asList("clean", "install"));
>  request.setProfiles(Collections.singletonList("qa"));
>  request.setProperties(getInvokerProps(props));
>  request.setUserSettingsFile(new 
> File("C:\\Users\\gauravd\\.m2\\settings.xml"));
> invoker.setMavenHome(new File("C:\\Program Files\\Apache Software 
> Foundation\\apache-maven-3.6.1"));
>  try {
>  InvocationResult result = invoker.execute(request);
>  if (result.getExitCode() != 0) {
>  if (result.getExecutionException() != null) {
>  logger.error("Failed to run the maven command. Exited with status {}", 
> result.getExitCode(), result.getExecutionException());
>  throw new RuntimeException("Failed to run the maven command. Exited with 
> status " + result.getExitCode(),
>  result.getExecutionException());
>  } else {
>  logger.error("Failed to run the maven command. Exited with status {}", 
> result.getExitCode());
>  throw new RuntimeException("Failed to run the maven command. Exited with 
> status " + result.getExitCode());
>  }
>  }
>  } catch (MavenInvocationException e) {
>  logger.error("Failed to run the maven command.", e);
>  throw new RuntimeException("Failed to run the maven command.", e);
>  }
> }
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SUREFIRE-1812) Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) are not reported

2021-02-03 Thread Jiri Ondrusek (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278097#comment-17278097
 ] 

Jiri Ondrusek commented on SUREFIRE-1812:
-

[~tibordigana] 

I've created a simple reproducer: 
[https://github.com/JiriOndrusek/SUREFIRE-1812-reproducer]
 Run test via 'mvn test' and get
{quote}[INFO] ---
 [INFO] T E S T S
 [INFO] ---
 [INFO] 
 [INFO] Results:
 [INFO] 
 [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
{quote}
Switch maven-surefire-plugin to 3.0.0-M5 in 
[https://github.com/JiriOndrusek/SUREFIRE-1812-reproducer/blob/master/pom.xml#L36]
 Run again. Result is:
{quote}INFO] ---
 [INFO] T E S T S
 [INFO] ---
 [INFO] Running reproducer.eproducerTest
 [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
0.004 s - in reproducer.eproducerTest
 [INFO] 
 [INFO] Results:
 [INFO] 
 [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
 [INFO] 
 [INFO] 
 [INFO] BUILD SUCCESS
{quote}
(you can not have environmental variable with name *TEST_ENV* - see 
[https://github.com/JiriOndrusek/SUREFIRE-1812-reproducer/blob/master/src/test/java/reproducer/ReproducerTest.java#L8])

> Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) 
> are not reported
> --
>
> Key: SUREFIRE-1812
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1812
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4, 3.0.0-M5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> I'm upgrading surefire plugin from 2.22.2 and there is a different behavior 
> started from 3.0.0-M4.
> When the test class is ignored by using @EnabledIfEnvironmentVariable(...), 
> final report shows bad information: (3.0.0.-M4, M5, master)
> {quote}[INFO] Results:
> [INFO] 
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {quote}
> The same test executed with 3.0.0-M3 shows:
> {quote}[INFO] Results:
> [INFO] 
> [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MSHARED-832) Cannot invoke maven from path with parentheses on Windows

2021-02-03 Thread Sylwester Lachiewicz (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278095#comment-17278095
 ] 

Sylwester Lachiewicz commented on MSHARED-832:
--

First, it requires change in shared-utils

> Cannot invoke maven from path with parentheses on Windows
> -
>
> Key: MSHARED-832
> URL: https://issues.apache.org/jira/browse/MSHARED-832
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-invoker, maven-shared-utils
>Affects Versions: maven-invoker-2.2
> Environment: Windows 10
>Reporter: Anton Krylov
>Priority: Major
>
> When {{M2_HOME}} is set to a path with parentheses (in this case 
> {{C:\work\lol(1)\maven)}}, the following command is generated on windows:
> {noformat}
> cmd.exe /X /C "C:\work\lol(1)\maven\bin\mvn.cmd -B -e -V compile"
> {noformat}
> This command fails, saying that C:\work\lol is not a known command
> When a space is added to the path, the path gets escaped, and the command 
> runs successfully.
> It looks like more characters need to be escaped on some platforms



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-shared-utils] slachiewicz edited a comment on pull request #74: Windows 9X is long dead

2021-02-03 Thread GitBox


slachiewicz edited a comment on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-772603566


   `CommandShell` / Windows 95 was marked as Deprecated with MSHARED-860 in 
https://github.com/apache/maven-shared-utils/commit/cb448b90918a5e894c38b86d00d402638f195502
 and released with 3.3.3 version.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-shared-utils] slachiewicz commented on pull request #74: Windows 9X is long dead

2021-02-03 Thread GitBox


slachiewicz commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-772603566


   `CmdShell` was marked as Deprecated with MSHARED-860 in 
https://github.com/apache/maven-shared-utils/commit/cb448b90918a5e894c38b86d00d402638f195502
 and released with 3.3.3 version.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (MSHARED-431) # (Hash-Sign) should trigger quoting in BourneShell.java

2021-02-03 Thread Sylwester Lachiewicz (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278055#comment-17278055
 ] 

Sylwester Lachiewicz commented on MSHARED-431:
--

Done in 
[76605ac236ee5fb64062581209e8ee941efcea77|https://gitbox.apache.org/repos/asf?p=maven-shared-utils.git;a=commit;h=76605ac236ee5fb64062581209e8ee941efcea77]
 

> # (Hash-Sign) should trigger quoting in BourneShell.java
> 
>
> Key: MSHARED-431
> URL: https://issues.apache.org/jira/browse/MSHARED-431
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-shared-utils
>Affects Versions: maven-shared-utils-0.8
> Environment: Unix (Linux)
>Reporter: Fritz Elfert
>Priority: Major
> Fix For: maven-shared-utils-3.3.3
>
>
> When trying to use the latest maven-jarsign-plugin using a keystore-password 
> which started with a hash (#), signing failed. After enabling debug output 
> with -X, I got a strange debug message:
> [DEBUG] Option lacks argument
> Since signtool is invoked using /bin/sh -c ..., of course, any # must be 
> quoted, because otherwise it acts as a comment-start and thus effectively 
> cuts-off the rest of the cmdline.
> After single-quoting the password in the pom.xml, the jar signing was ok.
> =>
> Adding '#' to BASH_QUOTING_TRIGGER_CHARS in 
> org.apache.maven.shared.utils.cli.shell.BourneShell.java should fix the 
> problem.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (MSHARED-431) # (Hash-Sign) should trigger quoting in BourneShell.java

2021-02-03 Thread Sylwester Lachiewicz (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz reassigned MSHARED-431:


Assignee: Sylwester Lachiewicz

> # (Hash-Sign) should trigger quoting in BourneShell.java
> 
>
> Key: MSHARED-431
> URL: https://issues.apache.org/jira/browse/MSHARED-431
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-shared-utils
>Affects Versions: maven-shared-utils-0.8
> Environment: Unix (Linux)
>Reporter: Fritz Elfert
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: maven-shared-utils-3.3.3
>
>
> When trying to use the latest maven-jarsign-plugin using a keystore-password 
> which started with a hash (#), signing failed. After enabling debug output 
> with -X, I got a strange debug message:
> [DEBUG] Option lacks argument
> Since signtool is invoked using /bin/sh -c ..., of course, any # must be 
> quoted, because otherwise it acts as a comment-start and thus effectively 
> cuts-off the rest of the cmdline.
> After single-quoting the password in the pom.xml, the jar signing was ok.
> =>
> Adding '#' to BASH_QUOTING_TRIGGER_CHARS in 
> org.apache.maven.shared.utils.cli.shell.BourneShell.java should fix the 
> problem.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (MSHARED-832) Cannot invoke maven from path with parentheses on Windows

2021-02-03 Thread Sylwester Lachiewicz (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz updated MSHARED-832:
-
Component/s: maven-shared-utils

> Cannot invoke maven from path with parentheses on Windows
> -
>
> Key: MSHARED-832
> URL: https://issues.apache.org/jira/browse/MSHARED-832
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-invoker, maven-shared-utils
>Affects Versions: maven-invoker-2.2
> Environment: Windows 10
>Reporter: Anton Krylov
>Priority: Major
>
> When {{M2_HOME}} is set to a path with parentheses (in this case 
> {{C:\work\lol(1)\maven)}}, the following command is generated on windows:
> {noformat}
> cmd.exe /X /C "C:\work\lol(1)\maven\bin\mvn.cmd -B -e -V compile"
> {noformat}
> This command fails, saying that C:\work\lol is not a known command
> When a space is added to the path, the path gets escaped, and the command 
> runs successfully.
> It looks like more characters need to be escaped on some platforms



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MSHARED-867) Timed out processes can stay alive in background

2021-02-03 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277993#comment-17277993
 ] 

Hudson commented on MSHARED-867:


Build unstable in Jenkins: Maven » Maven TLP » maven-invoker » master #21

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-invoker/job/master/21/

> Timed out processes can stay alive in background
> 
>
> Key: MSHARED-867
> URL: https://issues.apache.org/jira/browse/MSHARED-867
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-invoker
>Affects Versions: maven-invoker-3.0.1
> Environment: Windows, Java 8
>Reporter: Robert Scholte
>Priority: Major
>
> MSHARED-795 introduced a timeout for processes, but on Windows I can see Java 
> processes staying alive, Maven Invoker just continues without forcing them to 
> stop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-02-03 Thread GitBox


oehme commented on pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-772492203


   Added the IT back



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (MJAVADOC-617) aggregate-jar does nothing if aggregator modules are referenced using relative pathes and are not in sub folders (

2021-02-03 Thread Alexander Suter (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277981#comment-17277981
 ] 

Alexander Suter commented on MJAVADOC-617:
--

can please anybody say in which version this has been fixed?

> aggregate-jar does nothing if aggregator modules are referenced using 
> relative pathes and are not in sub folders (
> --
>
> Key: MJAVADOC-617
> URL: https://issues.apache.org/jira/browse/MJAVADOC-617
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0, 3.1.1
>Reporter: Reto Weiss
>Priority: Major
> Attachments: fix.zip
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If an aggregator project has modules that are not located in sub folders and 
> are referenced using relative pathes (e.g. "../project1") then the javadoc 
> aggregate-jar does nothing.
> It does not fail but no javadoc is generated at all.
> This works with 3.0.1.
> See attached Zip File with three projects all, project1 and project2. Project 
> all is the aggregator project. It references project 1 and project 2 with 
> ../project1 and ../project2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARCHETYPE-505) archetype:create-from-project,the .gitignore file not copy to archetype-resources

2021-02-03 Thread Jan Mosig (Jira)


[ 
https://issues.apache.org/jira/browse/ARCHETYPE-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277974#comment-17277974
 ] 

Jan Mosig commented on ARCHETYPE-505:
-

Hi there,

just to let you know: Although you can't "restore" the {{.gitignore}} file, you 
can of course include a file called {{gitignore}} and then rename it via the 
post processing script.

 

Example: 
https://github.com/JanMosigItemis/fluffy-archetype-java/blob/main/src/main/resources/META-INF/archetype-post-generate.groovy

> archetype:create-from-project,the .gitignore file not copy to 
> archetype-resources
> -
>
> Key: ARCHETYPE-505
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-505
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Archetypes
>Affects Versions: 2.4
> Environment: maven 3.3 ,maven-archetype-plugin 2.4
>Reporter: feilong
>Priority: Major
> Attachments: webapp-springmvc32.zip
>
>
> I have a very simple maven test project for {{archetype:create-from-project}}
> such as :(you can download from the Attachment)
> {noformat}
> |   .gitignore
> |   pom.xml
> |
> \---src
> +---main
> |   \---java
> |   overview.html
> |
> \---test
> {noformat}
> only {{.gitignore}} and {{pom.xml}}, and {{overview.html}} files
> and I excute the command line in the root folder:
> {code:xml}
> mvn -X  archetype:create-from-project
> {code}
> I see ,in the 
> {{target\generated-sources\archetype\src\main\resources\archetype-resources}} 
> folder, only 
> {noformat}
> |   pom.xml
> |
> \---src
> \---main
> \---java
> overview.html
> {noformat}
> no {{.gitignore}} file
> 
> first , I search the same issue in jira, there is #ARCHETYPE-474 , but not as 
> my scene
> 
> I search some solution in stackoverflow
> http://stackoverflow.com/questions/7981060/maven-archetype-plugin-doesnt-let-resources-in-archetype-resources-through#answer-37322323
> In pom.xml,I have also configed that  
> {code:xml}
> 
> maven-resources-plugin
> 3.0.1
> 
> utf-8
> true
> false
> 
> 
> 
> default-resources
> process-resources
> 
> resources
> 
> 
> true
> 
> 
> 
> default-testResources
> process-test-resources
> 
> testResources
> 
> 
> 
> 
> {code}
> {{maven-resources-plugin}} set {{addDefaultExcludes}} attribute to {{false}}
> but does't work
> 
> so, I look for the maven-archetype source code in github  
> https://github.com/apache/maven-archetype
> the 
> org.apache.maven.archetype.creator.FilesetArchetypeCreator.*createArchetypeFiles*(Properties,
>  List, String, File, File, String) method 
> line 796  show that:
> {code:title=FilesetArchetypeCreator.java|borderStyle=solid}
> private void createArchetypeFiles( Properties reverseProperties, 
> List fileSets, String packageName,
>File basedir, File 
> archetypeFilesDirectory, String defaultEncoding )
> throws IOException
> {
> getLogger().debug( "Creating Archetype/Module files from " + basedir 
> + " to " + archetypeFilesDirectory );
> for ( FileSet fileSet : fileSets )
> {
> DirectoryScanner scanner = new DirectoryScanner();
> scanner.setBasedir( basedir );
> scanner.setIncludes( (String[]) concatenateToList( 
> fileSet.getIncludes(), fileSet.getDirectory() ).toArray(
> new String[fileSet.getIncludes().size()] ) );
> scanner.setExcludes( (String[]) fileSet.getExcludes().toArray( 
> new String[fileSet.getExcludes().size()] ) );
> scanner.addDefaultExcludes();
> getLogger().debug( "Using fileset " + fileSet );
> scanner.scan();
> List fileSetResources = Arrays.asList( 
> scanner.getIncludedFiles() );
> getLogger().debug( "Scanned " + fileSetResources.size() + " 
> resources" );
> 
> .
> {code}
> here is  {{scanner.addDefaultExcludes();}} 
> So , the result log show that :
> {noformat}
> [DEBUG] Creating Archetype/Module files from 
> C:\Users\feilong\feilong\feilong-archetypes\0726-232539 to 
> C:\Users\feilong\feilong\feilong-archetypes\0726-232539\
> target\generated-sources\archetype\src\main\resources\archetype-resources
> [DEBUG] Using fileset src/main/java (Copied-Flat) [**/*.html -- ]
> [DEBUG] Scanned 1 resources
> [DEBUG] Package as Directory: Package:com.baozun.store->com\baozun\store
> [DEBUG] InputFileName:src\main\java\overview.html
> [DEBUG] OutputFileName:src\main\java\overview.html
> [DEBUG] 

[GitHub] [maven-surefire] marcphilipp commented on pull request #334: Fix build error with latest Maven 4.0 snapshot

2021-02-03 Thread GitBox


marcphilipp commented on pull request #334:
URL: https://github.com/apache/maven-surefire/pull/334#issuecomment-772450994


   @Tibor17 What name would you prefer?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] pzygielo commented on pull request #334: Fix build error with latest Maven 4.0 snapshot

2021-02-03 Thread GitBox


pzygielo commented on pull request #334:
URL: https://github.com/apache/maven-surefire/pull/334#issuecomment-772418612


   > Removing the `+` from the profile name solves the issue.
   
   But now the profile id does not cover the open range of JDKs. If `+` is 
disallowed indeed - perhaps change to `jdk9plus`?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] marcphilipp opened a new pull request #334: Fix build error with latest Maven 4.0 snapshot

2021-02-03 Thread GitBox


marcphilipp opened a new pull request #334:
URL: https://github.com/apache/maven-surefire/pull/334


   With the latest Maven snapshot version based on 
https://github.com/apache/maven/commit/eae3074c63dbba24680d7049dc36217323c7d00b,
 the build fails with the following exception:
   
   $ mvn validate
   [INFO] Scanning for projects...
   [ERROR] [ERROR] Some problems were encountered while processing the POMs:
   [ERROR] 'profiles.profile[jdk9+].id' with value 'jdk9+' does not match a 
valid id pattern. @ line 20, column 205
   
   [ERROR] The build could not read 1 project -> [Help 1]
   [ERROR]
   [ERROR]   The project 
org.apache.maven.surefire:surefire:3.0.0-M6-SNAPSHOT 
(/Users/marc/Repositories/maven/plugins/core/surefire/pom.xml) has 1 error
   [ERROR] 'profiles.profile[jdk9+].id' with value 'jdk9+' does not 
match a valid id pattern. @ line 20, column 205
   [ERROR]
   [ERROR] To see the full stack trace of the errors, re-run Maven with the 
'-e' switch.
   [ERROR] Re-run Maven using the '-X' switch to enable full debug logging.
   [ERROR]
   [ERROR] For more information about the errors and possible solutions, 
please read the following articles:
   [ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
   
   Removing the `+` from the profile name solves the issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] Tibor17 commented on pull request #333: Add failOnFlakeCount option

2021-02-03 Thread GitBox


Tibor17 commented on pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-772358615


   I also believe that it would be fine without IT but we should cover every 
config param by IT. It would be the highest guarantee that the client would not 
fire a bug against us that a fresh feature is dead ;-)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] eolivelli commented on pull request #333: Add failOnFlakeCount option

2021-02-03 Thread GitBox


eolivelli commented on pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-772346866


   @oehme I think there is not need to add the IT
   
   @Tibor17  ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-02-03 Thread GitBox


oehme commented on pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-772337965


   @Tibor17 I don't, but I can easily add one back if you want. I removed it 
because this feature isn't specific to a particular provider and all the logic 
could be unit tested, so I didn't feel like an extra integ test was necessary 
anymore.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org