[jira] [Commented] (MDEP-649) dependency:resolve-plugins lacks includeParents user property
[
https://issues.apache.org/jira/browse/MDEP-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292193#comment-17292193
]
Dennis Schridde commented on MDEP-649:
--
[~rfscholte],[~nick.stolwijk]: Indeed changing the default is not a good idea.
But that is not necessary: `dependency:get` has `transitive=true`, but
`dependency:resolve` has `excludeTransitive=false` by default. So the two use
inverse names for the same functionality with the same default behaviour (with
the inverse default value, though).
> dependency:resolve-plugins lacks includeParents user property
> -
>
> Key: MDEP-649
> URL: https://issues.apache.org/jira/browse/MDEP-649
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: resolve-plugins
>Affects Versions: 3.1.1
>Reporter: Dennis Schridde
>Priority: Major
>
> `dependency:resolve` has an `includeParents` user property [1] which
> `dependency:resolve-plugins` is lacking [2]. This makes it difficult to
> generate a complete list of all (JARs and) POMs required to build a project
> (with dependencies and plugins and their dependencies).
> P.S. `dependency:get` appears to have a similar shortcoming: It can resolve
> dependencies recursively (`{{transitive}}=true`, enabled by default [3]), but
> it lacks a `{{includeParents}}` user property.
> [1]:
> [https://maven.apache.org/plugins/maven-dependency-plugin/resolve-mojo.html#includeParents]
> [2]:
> [https://maven.apache.org/plugins/maven-dependency-plugin/resolve-plugins-mojo.html]
> [3]: Which BTW is inverse to the disabled-by-default `{{excludeTransitive}}`
> user property of `dependency:resolve`
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MRELEASE-1060) release:prepare fails to pass system properties to build
Robert Patrick created MRELEASE-1060:
Summary: release:prepare fails to pass system properties to build
Key: MRELEASE-1060
URL: https://issues.apache.org/jira/browse/MRELEASE-1060
Project: Maven Release Plugin
Issue Type: Bug
Components: perform, prepare
Affects Versions: 3.0.0-M1
Environment: MacOS 10.15.7
Maven 3.6.3
MacBook Pro (16-inch, 2019) w/ 8-core i9 and 32 GB RAM
Reporter: Robert Patrick
Attachments: release-prepare.log, release.properties, verify.log
I have a project with plugin that runs python tests and it requires
configuration to tell it a directory path. The POM is set up to supply the
value based on a Maven property defined in the POM. When I run the following
command, everything works fine:
{{mvn -Dfoo=/path/to/directory verify}}
However, when I try to use the release plugin (after creating the
release.properties file) using the following command:
{{mvn -B -Dfoo=/path/to/directory release:prepare}}
The process fails because the foo property is not defined.
I have created a simple
[release-test|https://github.com/robertpatrick/release-test] reproducer to
demonstrate the issue I am having. When I try to run the release:prepare (as
shown above), I get:
{{...
[INFO] [INFO] — maven-surefire-plugin:2.20.1:test (default-test) @ release-test
—}}
{{ [INFO] [INFO] }}
{{ [INFO] [INFO] ---}}
{{ [INFO] [INFO] T E S T S}}
{{ [INFO] [INFO] ---}}
{{ [INFO] [INFO] Running io.rhpatrick.test.ReleaseTesterTest}}
{{ [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
elapsed: 0.075 s <<< FAILURE! - in io.rhpatrick.test.ReleaseTesterTest}}
{{ [INFO] [ERROR]
TestAdd_WithPositiveNumbers_ReturnsExpectedNumber(io.rhpatrick.test.ReleaseTesterTest)
Time elapsed: 0.01 s <<< ERROR!}}
{{ [INFO] java.lang.IllegalArgumentException: Java system property foo was
empty}}
{{ [INFO] at
io.rhpatrick.test.ReleaseTesterTest.ensurePropertySet(ReleaseTesterTest.java:15)}}
{{ [INFO] }}
{{ [INFO] [INFO] }}
{{ [INFO] [INFO] Results:}}
{{ [INFO] [INFO] }}
{{ [INFO] [ERROR] Errors: }}
{{ [INFO] [ERROR] ReleaseTesterTest.ensurePropertySet:15 IllegalArgument Java
system property fo...}}
{{ [INFO] [INFO] }}
{{ [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0}}
{{ [INFO] [INFO] }}
{{ [INFO] [INFO]
}}
{{ [INFO] [INFO] BUILD FAILURE}}
{{ [INFO] [INFO]
}}
{{ [INFO] [INFO] Total time: 2.536 s}}
{{ [INFO] [INFO] Finished at: 2021-02-27T09:59:26-06:00}}
{{ [INFO] [INFO]
}}
{{ [INFO] [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on
project release-test: There are test failures.}}
{{ [INFO] [ERROR] }}
{{ [INFO] [ERROR] Please refer to
/Users/rpatrick/tmp/release-test/target/surefire-reports for the individual
test results.}}
{{ [INFO] [ERROR] Please refer to dump files (if any exist)
[date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.}}
{{ [INFO] [ERROR] -> [Help 1]}}
{{ [INFO] [ERROR] }}
{{ [INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with
the -e switch.}}
{{ [INFO] [ERROR] Re-run Maven using the -X switch to enable full debug
logging.}}
{{ [INFO] [ERROR] }}
{{ [INFO] [ERROR] For more information about the errors and possible solutions,
please read the following articles:}}
{{ [INFO] [ERROR] [Help 1]
[http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException]}}
{{ [INFO]
}}
{{ [INFO] BUILD FAILURE}}
{{ [INFO]
}}
{{ [INFO] Total time: 4.588 s}}
{{ [INFO] Finished at: 2021-02-27T09:59:26-06:00}}
{{ [INFO]
}}
{{ [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:3.0.0-M1:prepare (default-cli) on
project release-test: Maven execution failed, exit code: '1' -> [Help 1]}}
{{ [ERROR] }}
{{ [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.}}
{{ [ERROR] Re-run Maven using the -X switch to enable full debug logging.}}
{{ [ERROR] }}
{{ [ERROR] For more information about the errors and possible solutions, please
read the following articles:}}
{{ [ERROR] [Help 1]
[http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException]}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MJAR-275) outputTimestamp not applied to module-info; breaks reproducible builds
[
https://issues.apache.org/jira/browse/MJAR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292126#comment-17292126
]
Jorge Solórzano commented on MJAR-275:
--
Yes, the two issues are annoying, it doesn't make sense to include the JDK
patch version here.
But I have just checked some strange behavior, it looks like if you compile
with a Java version superior to the --release version (for instance, if you are
using Java 11 to compile a module-info.java with --release 9), the versions are
not recorded in the module descriptor, which in some cases could allow
reproducible builds.
A workaround for the timestamp could still be needed on a post post-process.
> outputTimestamp not applied to module-info; breaks reproducible builds
> --
>
> Key: MJAR-275
> URL: https://issues.apache.org/jira/browse/MJAR-275
> Project: Maven JAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
> Environment: Mac OS X 10.14.6
> JDK 15 (build 15+36)
> JDK 11 (build 11.0.8+10)
>Reporter: Anand Beh
>Priority: Minor
> Attachments: MCOMPILER-439.zip, Screenshot 2020-10-25 at 2.35.59
> PM.png
>
>
> Setting {{project.build.outputTimestamp}} to a fixed value allows creating
> reproducible builds per this guide:
> [https://maven.apache.org/guides/mini/guide-reproducible-builds.html
> |https://maven.apache.org/guides/mini/guide-reproducible-builds.html]However,
> if one adds a module-info file to the project, reproducible builds break.
> This is caused by module-info.class using the latest timestamp and not
> {{project.build.outputTimestamp}}. I was able to identify the problem using
> diffoscope: [https://diffoscope.org/.|https://diffoscope.org/] With it I
> determined the timestamp across 2 builds was constant for all but the
> module-info.class:
>
> {code:java}
> -rw 2.0 fat 862 bl defN 20-Oct-17 00:40
> space/arim/libertybans/api/select/SelectionOrder.class
> │ -rw 2.0 fat 1113 bl defN 20-Oct-17 00:40
> space/arim/libertybans/api/select/SelectionOrderBuilder.class
> │ -rw 2.0 fat 2285 bl defN 20-Oct-17 00:40
> META-INF/maven/space.arim.libertybans/bans-api/pom.xml
> │ -rw 2.0 fat 74 bl defN 20-Oct-17 00:40
> META-INF/maven/space.arim.libertybans/bans-api/pom.properties
> │ --rw 2.0 fat 557 bl defN 20-Oct-25 12:39 module-info.class
> │ +-rw 2.0 fat 557 bl defN 20-Oct-25 12:41 module-info.class
> {code}
>
> Note the + and - which are diffoscope's way of indicating the difference
> between the .jar files. Here the {{project.build.outputTimestamp}} is on 17
> October. As shown, module-info has a "rebellious" timestamp.
>
> *EDIT:*
> Example project to reproduce the bug:
> [https://github.com/A248/MJAR-275|https://github.com/A248/MCOMPILER-439]
> (Renamed from [https://github.com/A248/MCOMPILER-439])
> Source code is also provided as an attachment below
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MPMD-312) Upgrade to PMD 6.32.0
[ https://issues.apache.org/jira/browse/MPMD-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292114#comment-17292114 ] Hudson commented on MPMD-312: - Build succeeded in Jenkins: Maven » Maven TLP » maven-pmd-plugin » master #45 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-pmd-plugin/job/master/45/ > Upgrade to PMD 6.32.0 > - > > Key: MPMD-312 > URL: https://issues.apache.org/jira/browse/MPMD-312 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MPMD-312) Upgrade to PMD 6.32.0
[ https://issues.apache.org/jira/browse/MPMD-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-312: Summary: Upgrade to PMD 6.32.0 (was: Upgrade to PMD 6.31.0) > Upgrade to PMD 6.32.0 > - > > Key: MPMD-312 > URL: https://issues.apache.org/jira/browse/MPMD-312 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAVADOC-664) Detection of stale files not working on Windows
[
https://issues.apache.org/jira/browse/MJAVADOC-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292068#comment-17292068
]
Hudson commented on MJAVADOC-664:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-javadoc-plugin » master
#36
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-javadoc-plugin/job/master/36/
> Detection of stale files not working on Windows
> ---
>
> Key: MJAVADOC-664
> URL: https://issues.apache.org/jira/browse/MJAVADOC-664
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Frederik Boster
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.2.1
>
>
> h1. Description
> The detection of stale files introduced by MJAVADOC-626 does not work on
> Windows.
> The root cause is that file-arguments on the commandline, i.e. {{@options}}
> and {{@packages}}, are not recognized as such, because of double-quoting, and
> are therefore not resolved to individual arguments.
> h1. Solution Proposal
> The generated stale data detection key should contain only the arguments
> passed to the javadoc binary but not the whole commandline.
> This can be achieved by replacing the usage of
> {{Commandline#getCommandline()}} by {{Commandline#getArguments()}} in
> {{org.apache.maven.plugins.javadoc.StaleHelper#getStaleData(Commandline)}}
> h1. Examples
> Example for the generated stale data detection key on Windows before applying
> the proposed fix:
> {noformat}
> cmd.exe
> /X
> /C
> ""C:\Program Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot\bin\javadoc.exe"
> @options @packages"
> C:\Programming\project\target\apidocs\allclasses-index.html = 1601644656408
> C:\Programming\project\target\apidocs\allclasses.html = 1601644656424
> C:\Programming\project\target\apidocs\allpackages-index.html = 1601644656412
> C:\Programming\project\target\apidocs\constant-values.html = 1601644656341
> C:\Programming\project\target\apidocs\deprecated-list.html = 1601644656421
> C:\Programming\project\target\apidocs\element-list = 1601644656318
> C:\Programming\project\target\apidocs\help-doc.html = 1601644656432
> C:\Programming\project\target\apidocs\index-all.html = 1601644656400
> C:\Programming\project\target\apidocs\index.html = 1601644656427
> C:\Programming\project\target\apidocs\member-search-index.js = 1601644656395
> C:\Programming\project\target\apidocs\member-search-index.zip = 1601644656397
> C:\Programming\project\target\apidocs\options = 1601644688290
> C:\Programming\project\target\apidocs\overview-tree.html = 1601644656373
> C:\Programming\project\target\apidocs\package-search-index.js = 1601644656385
> C:\Programming\project\target\apidocs\package-search-index.zip = 1601644656389
> C:\Programming\project\target\apidocs\packages = 1601644688291
> C:\Programming\project\target\apidocs\script.js = 1601644656441
> C:\Programming\project\target\apidocs\search.js = 1601644656449
> C:\Programming\project\target\apidocs\stylesheet.css = 1601644656437
> C:\Programming\project\target\apidocs\type-search-index.js = 1601644656391
> C:\Programming\project\target\apidocs\type-search-index.zip = 1601644656393
> {noformat}
> Example for the generated stale data detection key on Linux:
> {noformat}
> /usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc
> @options
> @packages
> -classpath
>
[jira] [Closed] (MJAVADOC-664) Detection of stale files not working on Windows
[
https://issues.apache.org/jira/browse/MJAVADOC-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed MJAVADOC-664.
-
Resolution: Fixed
> Detection of stale files not working on Windows
> ---
>
> Key: MJAVADOC-664
> URL: https://issues.apache.org/jira/browse/MJAVADOC-664
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Frederik Boster
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.2.1
>
>
> h1. Description
> The detection of stale files introduced by MJAVADOC-626 does not work on
> Windows.
> The root cause is that file-arguments on the commandline, i.e. {{@options}}
> and {{@packages}}, are not recognized as such, because of double-quoting, and
> are therefore not resolved to individual arguments.
> h1. Solution Proposal
> The generated stale data detection key should contain only the arguments
> passed to the javadoc binary but not the whole commandline.
> This can be achieved by replacing the usage of
> {{Commandline#getCommandline()}} by {{Commandline#getArguments()}} in
> {{org.apache.maven.plugins.javadoc.StaleHelper#getStaleData(Commandline)}}
> h1. Examples
> Example for the generated stale data detection key on Windows before applying
> the proposed fix:
> {noformat}
> cmd.exe
> /X
> /C
> ""C:\Program Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot\bin\javadoc.exe"
> @options @packages"
> C:\Programming\project\target\apidocs\allclasses-index.html = 1601644656408
> C:\Programming\project\target\apidocs\allclasses.html = 1601644656424
> C:\Programming\project\target\apidocs\allpackages-index.html = 1601644656412
> C:\Programming\project\target\apidocs\constant-values.html = 1601644656341
> C:\Programming\project\target\apidocs\deprecated-list.html = 1601644656421
> C:\Programming\project\target\apidocs\element-list = 1601644656318
> C:\Programming\project\target\apidocs\help-doc.html = 1601644656432
> C:\Programming\project\target\apidocs\index-all.html = 1601644656400
> C:\Programming\project\target\apidocs\index.html = 1601644656427
> C:\Programming\project\target\apidocs\member-search-index.js = 1601644656395
> C:\Programming\project\target\apidocs\member-search-index.zip = 1601644656397
> C:\Programming\project\target\apidocs\options = 1601644688290
> C:\Programming\project\target\apidocs\overview-tree.html = 1601644656373
> C:\Programming\project\target\apidocs\package-search-index.js = 1601644656385
> C:\Programming\project\target\apidocs\package-search-index.zip = 1601644656389
> C:\Programming\project\target\apidocs\packages = 1601644688291
> C:\Programming\project\target\apidocs\script.js = 1601644656441
> C:\Programming\project\target\apidocs\search.js = 1601644656449
> C:\Programming\project\target\apidocs\stylesheet.css = 1601644656437
> C:\Programming\project\target\apidocs\type-search-index.js = 1601644656391
> C:\Programming\project\target\apidocs\type-search-index.zip = 1601644656393
> {noformat}
> Example for the generated stale data detection key on Linux:
> {noformat}
> /usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc
> @options
> @packages
> -classpath
>
[GitHub] [maven-javadoc-plugin] slachiewicz merged pull request #63: [MJAVADOC-664] - Fix stale javadoc data detection on Windows.
slachiewicz merged pull request #63: URL: https://github.com/apache/maven-javadoc-plugin/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
