[GitHub] [maven-surefire] rmannibucau commented on a change in pull request #340: [SUREFIRE-1892] ensure systemPropertyVariables values are stringified
rmannibucau commented on a change in pull request #340:
URL: https://github.com/apache/maven-surefire/pull/340#discussion_r590002068
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -3623,9 +3623,20 @@ public void setSystemProperties( Properties
systemProperties )
}
@SuppressWarnings( "UnusedDeclaration" )
-public void setSystemPropertyVariables( Map
systemPropertyVariables )
+public void setSystemPropertyVariables( Map
systemPropertyVariables )
{
-this.systemPropertyVariables = systemPropertyVariables;
+if (systemPropertyVariables != null)
+{
+this.systemPropertyVariables = new HashMap<>();
+for ( final Map.Entry entry :
systemPropertyVariables.entrySet() )
+{
+this.systemPropertyVariables.put( entry.getKey(),
String.valueOf( entry.getValue() ) );
Review comment:
Yep got it but have to admit I'm mixed about it, I like your setter
proposal because it makes the abstract data consistent for any consumer whereas
copyProperties can let subclasses/consumers see wrong data which is worse IMHO.
About the utility I'm tempted to say the gain is very light and mainly
envisionned because we can't use lambda yet. Since maven master is on java 8
and plugins already started to move I suspect this will drop as soon as we move
to java 8 so let's keep it simple maybe?
Wdyt?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (SUREFIRE-1893) New maven-surefire JUnit5 extension API by Fabricio Yamamoto
[ https://issues.apache.org/jira/browse/SUREFIRE-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1893: --- Description: https://github.com/fabriciorby/maven-surefire/tree/feature/junit5-tree-view https://github.com/fabriciorby/maven-surefire-junit5-tree-reporter was: https://github.com/fabriciorby/maven-surefire/tree/feature/junit5-tree-view > New maven-surefire JUnit5 extension API by Fabricio Yamamoto > > > Key: SUREFIRE-1893 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1893 > Project: Maven Surefire > Issue Type: New Feature > Components: documentation, JUnit 5.x support, Maven Failsafe Plugin, > Maven Surefire Plugin >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > Attachments: junit5extension.png > > > https://github.com/fabriciorby/maven-surefire/tree/feature/junit5-tree-view > https://github.com/fabriciorby/maven-surefire-junit5-tree-reporter -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SUREFIRE-1893) New maven-surefire JUnit5 extension API by Fabricio Yamamoto
[ https://issues.apache.org/jira/browse/SUREFIRE-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1893: --- Description: https://github.com/fabriciorby/maven-surefire/tree/feature/junit5-tree-view > New maven-surefire JUnit5 extension API by Fabricio Yamamoto > > > Key: SUREFIRE-1893 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1893 > Project: Maven Surefire > Issue Type: New Feature > Components: documentation, JUnit 5.x support, Maven Failsafe Plugin, > Maven Surefire Plugin >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > Attachments: junit5extension.png > > > https://github.com/fabriciorby/maven-surefire/tree/feature/junit5-tree-view -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SUREFIRE-1893) New maven-surefire JUnit5 extension API by Fabricio Yamamoto
Tibor Digana created SUREFIRE-1893: -- Summary: New maven-surefire JUnit5 extension API by Fabricio Yamamoto Key: SUREFIRE-1893 URL: https://issues.apache.org/jira/browse/SUREFIRE-1893 Project: Maven Surefire Issue Type: New Feature Components: documentation, JUnit 5.x support, Maven Failsafe Plugin, Maven Surefire Plugin Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 3.0.0-M6 Attachments: junit5extension.png -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #340: [SUREFIRE-1892] ensure systemPropertyVariables values are stringified
Tibor17 commented on a change in pull request #340:
URL: https://github.com/apache/maven-surefire/pull/340#discussion_r589778798
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -3623,9 +3623,20 @@ public void setSystemProperties( Properties
systemProperties )
}
@SuppressWarnings( "UnusedDeclaration" )
-public void setSystemPropertyVariables( Map
systemPropertyVariables )
+public void setSystemPropertyVariables( Map
systemPropertyVariables )
{
-this.systemPropertyVariables = systemPropertyVariables;
+if (systemPropertyVariables != null)
+{
+this.systemPropertyVariables = new HashMap<>();
+for ( final Map.Entry entry :
systemPropertyVariables.entrySet() )
+{
+this.systemPropertyVariables.put( entry.getKey(),
String.valueOf( entry.getValue() ) );
Review comment:
@rmannibucau
I was talking
[about](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L175).
Due to the method
[copyProperties](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L168)
is called only in
[calculateEffectiveProperties](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L148)
which is called in ASM, then the solution is to move both methods to ASM
because they are used only there, and then your method can call
[copyProperties](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L168).
You have to only change `Properties` to `Map` without generics. The method
`copyProperties` takes your `systemPropertyVariables` to the second parameter.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #340: [SUREFIRE-1892] ensure systemPropertyVariables values are stringified
Tibor17 commented on a change in pull request #340:
URL: https://github.com/apache/maven-surefire/pull/340#discussion_r589778798
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -3623,9 +3623,20 @@ public void setSystemProperties( Properties
systemProperties )
}
@SuppressWarnings( "UnusedDeclaration" )
-public void setSystemPropertyVariables( Map
systemPropertyVariables )
+public void setSystemPropertyVariables( Map
systemPropertyVariables )
{
-this.systemPropertyVariables = systemPropertyVariables;
+if (systemPropertyVariables != null)
+{
+this.systemPropertyVariables = new HashMap<>();
+for ( final Map.Entry entry :
systemPropertyVariables.entrySet() )
+{
+this.systemPropertyVariables.put( entry.getKey(),
String.valueOf( entry.getValue() ) );
Review comment:
@rmannibucau
I was talking
[about](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L175).
Due to the method
[copyProperties](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L168)
is called only in
[calculateEffectiveProperties](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L148)
which is called in ASM, then the solution is to move both methods to ASM
because they are used only there, and then your method can call
[copyProperties](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L168).
You have to only change `Properties` to `Map` withou generics. The method
`copyProperties` takes your `systemPropertyVariables` to the second parameter.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MCHANGELOG-128) Remove the unused commentFormat parameter from changelog mojo
[ https://issues.apache.org/jira/browse/MCHANGELOG-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297694#comment-17297694 ] Lutz Horn commented on MCHANGELOG-128: -- I've turned the attached patch into a pull request: https://github.com/apache/maven-changelog-plugin/pull/2 > Remove the unused commentFormat parameter from changelog mojo > - > > Key: MCHANGELOG-128 > URL: https://issues.apache.org/jira/browse/MCHANGELOG-128 > Project: Maven Changelog Plugin > Issue Type: Improvement >Affects Versions: 2.2, 2.3 >Reporter: Martín D'Aloia >Priority: Trivial > Attachments: remove-commentFormat-parameter.patch > > > The parameter commentFormat on the changelog mojo is unused and the javadoc > says that it is used by ClearcaseChangeLogGenerator which not exists on the > project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-changelog-plugin] lutzhorn opened a new pull request #2: MCHANGELOG-128: remove unused parameter commentFormat
lutzhorn opened a new pull request #2: URL: https://github.com/apache/maven-changelog-plugin/pull/2 The parameter `commentFormat` on the changelog mojo is unused and the javadoc says that it is used by `ClearcaseChangeLogGenerator` which not exists on the project. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] lutzhorn commented on a change in pull request #454: Update README.md
lutzhorn commented on a change in pull request #454: URL: https://github.com/apache/maven/pull/454#discussion_r589717088 ## File path: README.md ## @@ -63,10 +63,10 @@ Do you like Apache Maven? Then [donate back to the ASF](https://www.apache.org/f Quick Build --- -If you want to bootstrap Maven, you'll need: +If you want to bootstrap Maven from source, you'll need: - Java 1.8+ - Maven 3.0.5 or later -- Run Maven, specifying a location into which the completed Maven distro should be installed: +- Run Maven already installed, specifying a location into which the completed Maven distro should be installed: Review comment: Since an already installed Maven is required in the line above, this change adds not new information. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] lutzhorn commented on a change in pull request #454: Update README.md
lutzhorn commented on a change in pull request #454: URL: https://github.com/apache/maven/pull/454#discussion_r589716609 ## File path: README.md ## @@ -63,10 +63,10 @@ Do you like Apache Maven? Then [donate back to the ASF](https://www.apache.org/f Quick Build --- -If you want to bootstrap Maven, you'll need: +If you want to bootstrap Maven from source, you'll need: Review comment: 'Bootstrap' implies 'from source' so this change is redundant. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rfscholte commented on pull request #448: [MNG-7102] The child modules of excluded projects are now excluded
rfscholte commented on pull request #448: URL: https://github.com/apache/maven/pull/448#issuecomment-793019213 `mvn -pl !mod_c2,mod_c_2_2` is the same as `mvn -pl !mod_c2,!mod_c_2_1,!mod_c_2_2,!mod_c_2_2_1,!mod_c_2_2_2,!mod_c_2_3,mod_c_2_2` Order doesn't matter. Because `mod_c_2_2` is both selected and deselected, it is effectively not selected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #448: [MNG-7102] The child modules of excluded projects are now excluded
michael-o commented on pull request #448: URL: https://github.com/apache/maven/pull/448#issuecomment-792998441 > > I wonder what would happen if I have this: > > root: mod_a, mod_b, mod_c > > mod_c: mod_c_1, mod_c_2, mod_c_3 > > mod_c_2: mod_c_2_1, mod_c_2_2, mod_c_2_3 > > mod_c_2_2: mod_c_2_2_1, mod_c_2_2_2 > > `mvn -pl !mod_c2,mod_c_2_2` > > I think this should be the equivalent of `mvn -pl mod_c_2_2`. > > AFAIK Maven should first pick all selected modules (`mod_c_2_2`) and remove all excluded modules (`mod_c2` recursive). In that case no project would be selected. I am trying to understand why this should be the case This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rdp opened a new pull request #454: Update README.md
rdp opened a new pull request #454: URL: https://github.com/apache/maven/pull/454 Attempt to make it clearer how to bootstrap. `Run Maven` wasn't clear which to me. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rfscholte commented on pull request #448: [MNG-7102] The child modules of excluded projects are now excluded
rfscholte commented on pull request #448: URL: https://github.com/apache/maven/pull/448#issuecomment-792978269 > I wonder what would happen if I have this: > > root: mod_a, mod_b, mod_c > mod_c: mod_c_1, mod_c_2, mod_c_3 > mod_c_2: mod_c_2_1, mod_c_2_2, mod_c_2_3 > mod_c_2_2: mod_c_2_2_1, mod_c_2_2_2 > > `mvn -pl !mod_c2,mod_c_2_2` > > I think this should be the equivalent of `mvn -pl mod_c_2_2`. AFAIK Maven should first pick all selected modules (`mod_c_2_2`) and remove all excluded modules (`mod_c2` recursive). In that case no project would be selected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7051) Optionally skip non-existing profiles
[
https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297515#comment-17297515
]
Hudson commented on MNG-7051:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #115
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/master/115/
> Optionally skip non-existing profiles
> -
>
> Key: MNG-7051
> URL: https://issues.apache.org/jira/browse/MNG-7051
> Project: Maven
> Issue Type: Sub-task
> Components: Profiles
>Reporter: Maarten Mulders
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> For Maven 4, the behaviour of the {{-P}} command line option will change:
> * {{-P apache-release}} will activate the *apache-release* profile. If such
> a profile cannot be found, the build will break.
> * {{-P ?apache-release}} will activate the *apache-release* profile. If such
> a profile cannot be found, the build will continue but log a warning.
> {color:#ff}
> Note that this breaks the current behaviour of Maven 3 in two ways:
> {color}
> # {{-P apache-release}} will currently log a warning and not break the build.
> That behaviour can be restored by adding the {{?}}.
> # A profile that has an identifier that not valid (i.e., contains anything
> else than {{a}} - {{z}}, {{A}} to {{Z}}, {{0}} - {{9}}, {{-}}, {{_}} or
> {{.}}) will break the build.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-7051) Optionally skip non-existing profiles
[
https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297489#comment-17297489
]
Hudson commented on MNG-7051:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #114
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/master/114/
> Optionally skip non-existing profiles
> -
>
> Key: MNG-7051
> URL: https://issues.apache.org/jira/browse/MNG-7051
> Project: Maven
> Issue Type: Sub-task
> Components: Profiles
>Reporter: Maarten Mulders
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> For Maven 4, the behaviour of the {{-P}} command line option will change:
> * {{-P apache-release}} will activate the *apache-release* profile. If such
> a profile cannot be found, the build will break.
> * {{-P ?apache-release}} will activate the *apache-release* profile. If such
> a profile cannot be found, the build will continue but log a warning.
> {color:#ff}
> Note that this breaks the current behaviour of Maven 3 in two ways:
> {color}
> # {{-P apache-release}} will currently log a warning and not break the build.
> That behaviour can be restored by adding the {{?}}.
> # A profile that has an identifier that not valid (i.e., contains anything
> else than {{a}} - {{z}}, {{A}} to {{Z}}, {{0}} - {{9}}, {{-}}, {{_}} or
> {{.}}) will break the build.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] asfgit closed pull request #452: [MNG-7051] Update deprecated methods related to profile selection
asfgit closed pull request #452: URL: https://github.com/apache/maven/pull/452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-7112) --projects flag should honor --non-recursive flag
[
https://issues.apache.org/jira/browse/MNG-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters reassigned MNG-7112:
---
Assignee: Martin Kanters
> --projects flag should honor --non-recursive flag
> -
>
> Key: MNG-7112
> URL: https://issues.apache.org/jira/browse/MNG-7112
> Project: Maven
> Issue Type: Improvement
> Components: Reactor and workspace
>Affects Versions: 4.0.x-candidate
>Reporter: Martin Kanters
>Assignee: Martin Kanters
>Priority: Major
>
> In MNG-6981 and MNG-7102 the behavior around selecting aggregate projects has
> changed.
> Now, when an aggregate is (de)selected, the aggregate project and all its
> children will be (de)selected in the reactor.
> Before, just the aggregate was (de)selected and children were not taken into
> account.
> Because there is no good workaround currently and there is a need for it, we
> should offer a way to bring the old behavior back.
> {{\-N}} or {{\--non-recursive}} is currently used to only select one project,
> and it will not take its children into account during project collection
> (before the reactor flags are applied).
> After discussion on the mailing list, the proposed implementation is to use
> {{\--non-recursive}} together with {{\--projects}} to restore the old
> non-recursive behavior we had before.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] MartinKanters merged pull request #453: [MNG-7051] When an optional profile could not be found, an info message should be thrown instead of a warning.
MartinKanters merged pull request #453: URL: https://github.com/apache/maven/pull/453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters merged pull request #102: [MNG-7051] When an optional profile could not be found, an info message should be thrown instead of a warning.
MartinKanters merged pull request #102: URL: https://github.com/apache/maven-integration-testing/pull/102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7112) --projects flag should honor --non-recursive flag
Martin Kanters created MNG-7112:
---
Summary: --projects flag should honor --non-recursive flag
Key: MNG-7112
URL: https://issues.apache.org/jira/browse/MNG-7112
Project: Maven
Issue Type: Improvement
Components: Reactor and workspace
Affects Versions: 4.0.x-candidate
Reporter: Martin Kanters
In MNG-6981 and MNG-7102 the behavior around selecting aggregate projects has
changed.
Now, when an aggregate is (de)selected, the aggregate project and all its
children will be (de)selected in the reactor.
Before, just the aggregate was (de)selected and children were not taken into
account.
Because there is no good workaround currently and there is a need for it, we
should offer a way to bring the old behavior back.
{{\-N}} or {{\--non-recursive}} is currently used to only select one project,
and it will not take its children into account during project collection
(before the reactor flags are applied).
After discussion on the mailing list, the proposed implementation is to use
{{\--non-recursive}} together with {{\--projects}} to restore the old
non-recursive behavior we had before.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] MartinKanters edited a comment on pull request #448: [MNG-7102] The child modules of excluded projects are now excluded
MartinKanters edited a comment on pull request #448: URL: https://github.com/apache/maven/pull/448#issuecomment-792767072 > I wonder what would happen if I have this: > > root: mod_a, mod_b, mod_c > mod_c: mod_c_1, mod_c_2, mod_c_3 > mod_c_2: mod_c_2_1, mod_c_2_2, mod_c_2_3 > mod_c_2_2: mod_c_2_2_1, mod_c_2_2_2 > > `mvn -pl !mod_c2,mod_c_2_2` > > I think this should be the equivalent of `mvn -pl mod_c_2_2`. @michael-o Good point, I discussed this with @mthmulders and we both agree your desired outcome should be the actual outcome. It was not the case though, so we had to change the DefaultGraphBuilder a bit more, please see the last commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #448: [MNG-7102] The child modules of excluded projects are now excluded
MartinKanters commented on pull request #448: URL: https://github.com/apache/maven/pull/448#issuecomment-792767072 > I wonder what would happen if I have this: > > root: mod_a, mod_b, mod_c > mod_c: mod_c_1, mod_c_2, mod_c_3 > mod_c_2: mod_c_2_1, mod_c_2_2, mod_c_2_3 > mod_c_2_2: mod_c_2_2_1, mod_c_2_2_2 > > `mvn -pl !mod_c2,mod_c_2_2` > > I think this should be the equivalent of `mvn -pl mod_c_2_2`. @michael-o Good point, I discussed this with @mthmulders and we both agree your desired outcome should be reality. It was not the case though, so we had to change the DefaultGraphBuilder a bit more, please see the last commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #446: [MNG-6511] - Optional project selection
mthmulders commented on a change in pull request #446:
URL: https://github.com/apache/maven/pull/446#discussion_r589428068
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -176,38 +177,69 @@ public DefaultGraphBuilder( BuildResumptionDataRepository
buildResumptionDataRep
{
List result = projects;
-if ( !request.getSelectedProjects().isEmpty() )
+ProjectActivation projectActivation = request.getProjectActivation();
+Set requiredSelectors =
projectActivation.getRequiredActiveProjectSelectors();
+Set optionalSelectors =
projectActivation.getOptionalActiveProjectSelectors();
+if ( !requiredSelectors.isEmpty() || !optionalSelectors.isEmpty() )
{
-File reactorDirectory = getReactorDirectory( request );
+Set selectedProjects = new HashSet<>(
requiredSelectors.size() + optionalSelectors.size() );
+selectedProjects.addAll( getProjectsBySelectors( request,
projects, requiredSelectors, true ) );
+selectedProjects.addAll( getProjectsBySelectors( request,
projects, optionalSelectors, false ) );
+
+// it can be empty when an optional project is missing from the
reactor, fallback to returning all projects
+if ( !selectedProjects.isEmpty() )
+{
+result = new ArrayList<>( selectedProjects );
+
+result = includeAlsoMakeTransitively( result, request, graph );
+
+// Order the new list in the original order
+List sortedProjects = graph.getSortedProjects();
+result.sort( comparing( sortedProjects::indexOf ) );
+}
+}
+
+return result;
+}
-Collection selectedProjects = new LinkedHashSet<>();
+private Set getProjectsBySelectors( MavenExecutionRequest
request, List projects,
+ Set
projectSelectors, boolean required )
+throws MavenExecutionException
+{
+Set selectedProjects = new LinkedHashSet<>();
+File reactorDirectory = getReactorDirectory( request );
-for ( String selector : request.getSelectedProjects() )
+for ( String selector : projectSelectors )
+{
+Optional optSelectedProject = projects.stream()
+.filter( project -> isMatchingProject( project, selector,
reactorDirectory ) )
+.findFirst();
+if ( !optSelectedProject.isPresent() )
{
-MavenProject selectedProject = projects.stream()
-.filter( project -> isMatchingProject( project,
selector, reactorDirectory ) )
-.findFirst()
-.orElseThrow( () -> new MavenExecutionException(
-"Could not find the selected project in the
reactor: " + selector, request.getPom() ) );
-selectedProjects.add( selectedProject );
-
-List children =
selectedProject.getCollectedProjects();
-if ( children != null )
+String message = "Could not find the selected project in the
reactor: " + selector;
+if ( required )
+{
+throw new MavenExecutionException( message,
request.getPom() );
+}
+else
{
-selectedProjects.addAll( children );
+LOGGER.warn( message );
Review comment:
Will address this
[separately](https://github.com/apache/maven/pull/453), to avoid messing up
this one, which is about projects.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters opened a new pull request #102: [MNG-7051] When an optional profile could not be found, an info message should be thrown instead of a warning.
MartinKanters opened a new pull request #102: URL: https://github.com/apache/maven-integration-testing/pull/102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters opened a new pull request #453: [MNG-7051] When an optional profile could not be found, an info message should be thrown instead of a warning.
MartinKanters opened a new pull request #453: URL: https://github.com/apache/maven/pull/453 This PR is raised because the functionality should be consistent with project selection: https://github.com/apache/maven/pull/446#discussion_r579859091 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] rmannibucau commented on a change in pull request #340: [SUREFIRE-1892] ensure systemPropertyVariables values are stringified
rmannibucau commented on a change in pull request #340:
URL: https://github.com/apache/maven-surefire/pull/340#discussion_r589395119
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -3623,9 +3623,20 @@ public void setSystemProperties( Properties
systemProperties )
}
@SuppressWarnings( "UnusedDeclaration" )
-public void setSystemPropertyVariables( Map
systemPropertyVariables )
+public void setSystemPropertyVariables( Map
systemPropertyVariables )
{
-this.systemPropertyVariables = systemPropertyVariables;
+if (systemPropertyVariables != null)
+{
+this.systemPropertyVariables = new HashMap<>();
Review comment:
It can only for duplicates - it is system properties ;) - and here it is
not allowed so all good
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] rmannibucau commented on a change in pull request #340: [SUREFIRE-1892] ensure systemPropertyVariables values are stringified
rmannibucau commented on a change in pull request #340:
URL: https://github.com/apache/maven-surefire/pull/340#discussion_r589394853
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -3623,9 +3623,20 @@ public void setSystemProperties( Properties
systemProperties )
}
@SuppressWarnings( "UnusedDeclaration" )
-public void setSystemPropertyVariables( Map
systemPropertyVariables )
+public void setSystemPropertyVariables( Map
systemPropertyVariables )
{
-this.systemPropertyVariables = systemPropertyVariables;
+if (systemPropertyVariables != null)
+{
+this.systemPropertyVariables = new HashMap<>();
+for ( final Map.Entry entry :
systemPropertyVariables.entrySet() )
+{
+this.systemPropertyVariables.put( entry.getKey(),
String.valueOf( entry.getValue() ) );
+}
+}
+else
Review comment:
it is an abstract class and a public method, we can't assume it I guess
so even if you are supposed to be true, there is no reason it is true in
practise so thought being defensive was saner.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #446: [MNG-6511] - Optional project selection
mthmulders commented on a change in pull request #446:
URL: https://github.com/apache/maven/pull/446#discussion_r589386978
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumptionDataRepository
buildResumptionDataRep
{
List result = projects;
-if ( !request.getExcludedProjects().isEmpty() )
+ProjectActivation projectActivation = request.getProjectActivation();
+Set requiredSelectors =
projectActivation.getRequiredInactiveProjectSelectors();
+Set optionalSelectors =
projectActivation.getOptionalInactiveProjectSelectors();
+if ( !requiredSelectors.isEmpty() || !optionalSelectors.isEmpty() )
{
-File reactorDirectory = getReactorDirectory( request );
+Set excludedProjects = new HashSet<>(
requiredSelectors.size() + optionalSelectors.size() );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, requiredSelectors, true ) );
+excludedProjects.addAll( getProjectsBySelectors( request,
projects, optionalSelectors, false ) );
Review comment:
Yes: because these changes detect when `-pl` leads to no modules being
selected, and the `DefaultGraphBuilder` then aborts the process, we will no
longer get the "No goals have been specified" message.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #340: [SUREFIRE-1892] ensure systemPropertyVariables values are stringified
Tibor17 commented on a change in pull request #340:
URL: https://github.com/apache/maven-surefire/pull/340#discussion_r589386968
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -3623,9 +3623,20 @@ public void setSystemProperties( Properties
systemProperties )
}
@SuppressWarnings( "UnusedDeclaration" )
-public void setSystemPropertyVariables( Map
systemPropertyVariables )
+public void setSystemPropertyVariables( Map
systemPropertyVariables )
{
-this.systemPropertyVariables = systemPropertyVariables;
+if (systemPropertyVariables != null)
+{
+this.systemPropertyVariables = new HashMap<>();
Review comment:
Does the order of the entries matter? Let's see what the ITs would say.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #340: [SUREFIRE-1892] ensure systemPropertyVariables values are stringified
Tibor17 commented on a change in pull request #340:
URL: https://github.com/apache/maven-surefire/pull/340#discussion_r589385444
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -3623,9 +3623,20 @@ public void setSystemProperties( Properties
systemProperties )
}
@SuppressWarnings( "UnusedDeclaration" )
-public void setSystemPropertyVariables( Map
systemPropertyVariables )
+public void setSystemPropertyVariables( Map
systemPropertyVariables )
{
-this.systemPropertyVariables = systemPropertyVariables;
+if (systemPropertyVariables != null)
+{
+this.systemPropertyVariables = new HashMap<>();
+for ( final Map.Entry entry :
systemPropertyVariables.entrySet() )
+{
+this.systemPropertyVariables.put( entry.getKey(),
String.valueOf( entry.getValue() ) );
+}
+}
+else
Review comment:
The "else" is not needed. The setter is called and not the field, so
there is only one entry point, i.e. the setter. Or?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #340: [SUREFIRE-1892] ensure systemPropertyVariables values are stringified
Tibor17 commented on a change in pull request #340:
URL: https://github.com/apache/maven-surefire/pull/340#discussion_r589384582
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -3623,9 +3623,20 @@ public void setSystemProperties( Properties
systemProperties )
}
@SuppressWarnings( "UnusedDeclaration" )
-public void setSystemPropertyVariables( Map
systemPropertyVariables )
+public void setSystemPropertyVariables( Map
systemPropertyVariables )
{
-this.systemPropertyVariables = systemPropertyVariables;
+if (systemPropertyVariables != null)
+{
+this.systemPropertyVariables = new HashMap<>();
+for ( final Map.Entry entry :
systemPropertyVariables.entrySet() )
+{
+this.systemPropertyVariables.put( entry.getKey(),
String.valueOf( entry.getValue() ) );
Review comment:
See how the getter is used and how the null check looks like. I think it
is something like `val == null ? "" : val`. It would be nice to extract this
treatment or even more code to a private static method and call it from both
places.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #340: [SUREFIRE-1892] ensure systemPropertyVariables values are stringified
Tibor17 commented on pull request #340:
URL: https://github.com/apache/maven-surefire/pull/340#issuecomment-792721126
Pls see the CI logs and fix the chceckstyle:
```
Error:
src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:[3628,13]
(whitespace) ParenPad: '(' is not followed by whitespace.
Error:
src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:[3628,44]
(whitespace) ParenPad: ')' is not preceded with whitespace.
Error:
src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java:[2008,41]
(whitespace) ParenPad: '(' is not followed by whitespace.
Error:
src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java:[2008,54]
(whitespace) ParenPad: '(' is not followed by whitespace.
Error:
src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java:[2008,69]
(whitespace) ParenPad: ')' is not preceded with whitespace.
Error:
src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java:[2008,70]
(whitespace) ParenPad: ')' is not preceded with whitespace.
Error:
src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java:[2009,22]
(whitespace) ParenPad: '(' is not followed by whitespace.
Error:
src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java:[2009,35]
(whitespace) ParenPad: '(' is not followed by whitespace.
Error:
src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java:[2009,52]
(whitespace) ParenPad: ')' is not preceded with whitespace.
Error:
src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java:[2009,88]
(whitespace) ParenPad: ')' is not preceded with whitespace.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-5828) Artifact download loses proxy username during transfer, failing download
[
https://issues.apache.org/jira/browse/MNG-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297240#comment-17297240
]
Michael Osipov commented on MNG-5828:
-
Are you joking? Look at the stack trace, fix your truststore setup. It is
completely unrelated to this.
> Artifact download loses proxy username during transfer, failing download
>
>
> Key: MNG-5828
> URL: https://issues.apache.org/jira/browse/MNG-5828
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.3.3
> Environment: Windows 7 Enterprise SP1 x64
>Reporter: John Elion
>Priority: Minor
> Labels: close-pending
> Attachments: failed-dbg.log, failed.log, hauser_install_verbose.txt,
> pom.xml, settings.xml
>
>
> Executing 'mvn site' causes Maven to successfully download most artifacts,
> but several failures are reported with the message
> [WARNING] Could not transfer metadata
> org.codehaus.mojo:findbugs-maven-plugin/maven-metadata.xml from/to central
> (https://repo.maven.apache.org/maven2): Error transferring file: Unable to
> tunnel through proxy. Proxy returns "HTTP/1.1 407 authenticationrequired"
> from
> https://repo.maven.apache.org/maven2/org/codehaus/mojo/findbugs-maven-plugin/maven-metadata.xml
> with proxyInfo ProxyInfo{host='mamwg.gdc4s.com', userName='null', port=8080,
> type='https', nonProxyHosts='null'}
> The proxy configuration does specify a username, and a "mvn -X" log shows
> Maven to be aware of the username a few lines earlier.
> [DEBUG] Using connector BasicRepositoryConnector with priority 0.0 for
> https://repo.maven.apache.org/maven2 via mamwg.gdc4s.com:8080 with
> username=p58042, password=***
> I don't see a way to attach, but if I can do so after saving I will attach a
> fairly simple pom file, settings.xml (stripped of passwords), and plain and
> debug log files that will reproduce the error with the commands 'mvn -s
> settings.xml site' and 'mvn -X -s settings.xml site'.
> I have listed this as "minor" because my end build results thus far have been
> successful and the components which have failed to download have apparently
> not impacted my building or testing - in some cases it appears the component
> is already downloaded to my local repository; however, there are hundreds of
> these warnings in my build logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] gnodet commented on pull request #442: Fix maven parallel builds
gnodet commented on pull request #442: URL: https://github.com/apache/maven/pull/442#issuecomment-792626463 @rfscholte I've added another commit which fix a deadlock. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-5828) Artifact download loses proxy username during transfer, failing download
[
https://issues.apache.org/jira/browse/MNG-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297210#comment-17297210
]
Daniel Hauser edited comment on MNG-5828 at 3/8/21, 9:33 AM:
-
[~michael-o], I've uploaded the verbose output for a install command, I hope
that's what you mean: [^hauser_install_verbose.txt]
My settings are completely vanilla, only the following config for our corp
proxy was added:
{noformat}
fronius_http true
http at-wsa-01.fronius.com
8080 hauser.daniel
*** {noformat}
was (Author: danhau):
[~michael-o], I've uploaded the verbose output for a install command, I hope
that's what you mean: [^hauser_install_verbose.txt]
> Artifact download loses proxy username during transfer, failing download
>
>
> Key: MNG-5828
> URL: https://issues.apache.org/jira/browse/MNG-5828
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.3.3
> Environment: Windows 7 Enterprise SP1 x64
>Reporter: John Elion
>Priority: Minor
> Labels: close-pending
> Attachments: failed-dbg.log, failed.log, hauser_install_verbose.txt,
> pom.xml, settings.xml
>
>
> Executing 'mvn site' causes Maven to successfully download most artifacts,
> but several failures are reported with the message
> [WARNING] Could not transfer metadata
> org.codehaus.mojo:findbugs-maven-plugin/maven-metadata.xml from/to central
> (https://repo.maven.apache.org/maven2): Error transferring file: Unable to
> tunnel through proxy. Proxy returns "HTTP/1.1 407 authenticationrequired"
> from
> https://repo.maven.apache.org/maven2/org/codehaus/mojo/findbugs-maven-plugin/maven-metadata.xml
> with proxyInfo ProxyInfo{host='mamwg.gdc4s.com', userName='null', port=8080,
> type='https', nonProxyHosts='null'}
> The proxy configuration does specify a username, and a "mvn -X" log shows
> Maven to be aware of the username a few lines earlier.
> [DEBUG] Using connector BasicRepositoryConnector with priority 0.0 for
> https://repo.maven.apache.org/maven2 via mamwg.gdc4s.com:8080 with
> username=p58042, password=***
> I don't see a way to attach, but if I can do so after saving I will attach a
> fairly simple pom file, settings.xml (stripped of passwords), and plain and
> debug log files that will reproduce the error with the commands 'mvn -s
> settings.xml site' and 'mvn -X -s settings.xml site'.
> I have listed this as "minor" because my end build results thus far have been
> successful and the components which have failed to download have apparently
> not impacted my building or testing - in some cases it appears the component
> is already downloaded to my local repository; however, there are hundreds of
> these warnings in my build logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MNG-5828) Artifact download loses proxy username during transfer, failing download
[
https://issues.apache.org/jira/browse/MNG-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297210#comment-17297210
]
Daniel Hauser edited comment on MNG-5828 at 3/8/21, 9:33 AM:
-
[~michael-o], I've uploaded the verbose output for a install command, I hope
that's what you mean: [^hauser_install_verbose.txt]
My settings are completely vanilla, only the following config for our corp
proxy was added:
{quote}
fronius_http
true
http
at-wsa-01.fronius.com
8080
hauser.daniel
***
{quote}
was (Author: danhau):
[~michael-o], I've uploaded the verbose output for a install command, I hope
that's what you mean: [^hauser_install_verbose.txt]
My settings are completely vanilla, only the following config for our corp
proxy was added:
{noformat}
fronius_http true
http at-wsa-01.fronius.com
8080 hauser.daniel
*** {noformat}
> Artifact download loses proxy username during transfer, failing download
>
>
> Key: MNG-5828
> URL: https://issues.apache.org/jira/browse/MNG-5828
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.3.3
> Environment: Windows 7 Enterprise SP1 x64
>Reporter: John Elion
>Priority: Minor
> Labels: close-pending
> Attachments: failed-dbg.log, failed.log, hauser_install_verbose.txt,
> pom.xml, settings.xml
>
>
> Executing 'mvn site' causes Maven to successfully download most artifacts,
> but several failures are reported with the message
> [WARNING] Could not transfer metadata
> org.codehaus.mojo:findbugs-maven-plugin/maven-metadata.xml from/to central
> (https://repo.maven.apache.org/maven2): Error transferring file: Unable to
> tunnel through proxy. Proxy returns "HTTP/1.1 407 authenticationrequired"
> from
> https://repo.maven.apache.org/maven2/org/codehaus/mojo/findbugs-maven-plugin/maven-metadata.xml
> with proxyInfo ProxyInfo{host='mamwg.gdc4s.com', userName='null', port=8080,
> type='https', nonProxyHosts='null'}
> The proxy configuration does specify a username, and a "mvn -X" log shows
> Maven to be aware of the username a few lines earlier.
> [DEBUG] Using connector BasicRepositoryConnector with priority 0.0 for
> https://repo.maven.apache.org/maven2 via mamwg.gdc4s.com:8080 with
> username=p58042, password=***
> I don't see a way to attach, but if I can do so after saving I will attach a
> fairly simple pom file, settings.xml (stripped of passwords), and plain and
> debug log files that will reproduce the error with the commands 'mvn -s
> settings.xml site' and 'mvn -X -s settings.xml site'.
> I have listed this as "minor" because my end build results thus far have been
> successful and the components which have failed to download have apparently
> not impacted my building or testing - in some cases it appears the component
> is already downloaded to my local repository; however, there are hundreds of
> these warnings in my build logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MNG-5828) Artifact download loses proxy username during transfer, failing download
[
https://issues.apache.org/jira/browse/MNG-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297210#comment-17297210
]
Daniel Hauser edited comment on MNG-5828 at 3/8/21, 9:30 AM:
-
[~michael-o], I've uploaded the verbose output for a install command, I hope
that's what you mean: [^hauser_install_verbose.txt]
was (Author: danhau):
[~michael-o], I've uploaded the verbose output for a install command, I hope
that's what you mean: [^hauser_install_verbose.txt]
> Artifact download loses proxy username during transfer, failing download
>
>
> Key: MNG-5828
> URL: https://issues.apache.org/jira/browse/MNG-5828
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.3.3
> Environment: Windows 7 Enterprise SP1 x64
>Reporter: John Elion
>Priority: Minor
> Labels: close-pending
> Attachments: failed-dbg.log, failed.log, hauser_install_verbose.txt,
> pom.xml, settings.xml
>
>
> Executing 'mvn site' causes Maven to successfully download most artifacts,
> but several failures are reported with the message
> [WARNING] Could not transfer metadata
> org.codehaus.mojo:findbugs-maven-plugin/maven-metadata.xml from/to central
> (https://repo.maven.apache.org/maven2): Error transferring file: Unable to
> tunnel through proxy. Proxy returns "HTTP/1.1 407 authenticationrequired"
> from
> https://repo.maven.apache.org/maven2/org/codehaus/mojo/findbugs-maven-plugin/maven-metadata.xml
> with proxyInfo ProxyInfo{host='mamwg.gdc4s.com', userName='null', port=8080,
> type='https', nonProxyHosts='null'}
> The proxy configuration does specify a username, and a "mvn -X" log shows
> Maven to be aware of the username a few lines earlier.
> [DEBUG] Using connector BasicRepositoryConnector with priority 0.0 for
> https://repo.maven.apache.org/maven2 via mamwg.gdc4s.com:8080 with
> username=p58042, password=***
> I don't see a way to attach, but if I can do so after saving I will attach a
> fairly simple pom file, settings.xml (stripped of passwords), and plain and
> debug log files that will reproduce the error with the commands 'mvn -s
> settings.xml site' and 'mvn -X -s settings.xml site'.
> I have listed this as "minor" because my end build results thus far have been
> successful and the components which have failed to download have apparently
> not impacted my building or testing - in some cases it appears the component
> is already downloaded to my local repository; however, there are hundreds of
> these warnings in my build logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-5828) Artifact download loses proxy username during transfer, failing download
[
https://issues.apache.org/jira/browse/MNG-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297210#comment-17297210
]
Daniel Hauser commented on MNG-5828:
[~michael-o], I've uploaded the verbose output for a install command, I hope
that's what you mean: [^hauser_install_verbose.txt]
> Artifact download loses proxy username during transfer, failing download
>
>
> Key: MNG-5828
> URL: https://issues.apache.org/jira/browse/MNG-5828
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.3.3
> Environment: Windows 7 Enterprise SP1 x64
>Reporter: John Elion
>Priority: Minor
> Labels: close-pending
> Attachments: failed-dbg.log, failed.log, hauser_install_verbose.txt,
> pom.xml, settings.xml
>
>
> Executing 'mvn site' causes Maven to successfully download most artifacts,
> but several failures are reported with the message
> [WARNING] Could not transfer metadata
> org.codehaus.mojo:findbugs-maven-plugin/maven-metadata.xml from/to central
> (https://repo.maven.apache.org/maven2): Error transferring file: Unable to
> tunnel through proxy. Proxy returns "HTTP/1.1 407 authenticationrequired"
> from
> https://repo.maven.apache.org/maven2/org/codehaus/mojo/findbugs-maven-plugin/maven-metadata.xml
> with proxyInfo ProxyInfo{host='mamwg.gdc4s.com', userName='null', port=8080,
> type='https', nonProxyHosts='null'}
> The proxy configuration does specify a username, and a "mvn -X" log shows
> Maven to be aware of the username a few lines earlier.
> [DEBUG] Using connector BasicRepositoryConnector with priority 0.0 for
> https://repo.maven.apache.org/maven2 via mamwg.gdc4s.com:8080 with
> username=p58042, password=***
> I don't see a way to attach, but if I can do so after saving I will attach a
> fairly simple pom file, settings.xml (stripped of passwords), and plain and
> debug log files that will reproduce the error with the commands 'mvn -s
> settings.xml site' and 'mvn -X -s settings.xml site'.
> I have listed this as "minor" because my end build results thus far have been
> successful and the components which have failed to download have apparently
> not impacted my building or testing - in some cases it appears the component
> is already downloaded to my local repository; however, there are hundreds of
> these warnings in my build logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-5828) Artifact download loses proxy username during transfer, failing download
[
https://issues.apache.org/jira/browse/MNG-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Hauser updated MNG-5828:
---
Attachment: hauser_install_verbose.txt
> Artifact download loses proxy username during transfer, failing download
>
>
> Key: MNG-5828
> URL: https://issues.apache.org/jira/browse/MNG-5828
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.3.3
> Environment: Windows 7 Enterprise SP1 x64
>Reporter: John Elion
>Priority: Minor
> Labels: close-pending
> Attachments: failed-dbg.log, failed.log, hauser_install_verbose.txt,
> pom.xml, settings.xml
>
>
> Executing 'mvn site' causes Maven to successfully download most artifacts,
> but several failures are reported with the message
> [WARNING] Could not transfer metadata
> org.codehaus.mojo:findbugs-maven-plugin/maven-metadata.xml from/to central
> (https://repo.maven.apache.org/maven2): Error transferring file: Unable to
> tunnel through proxy. Proxy returns "HTTP/1.1 407 authenticationrequired"
> from
> https://repo.maven.apache.org/maven2/org/codehaus/mojo/findbugs-maven-plugin/maven-metadata.xml
> with proxyInfo ProxyInfo{host='mamwg.gdc4s.com', userName='null', port=8080,
> type='https', nonProxyHosts='null'}
> The proxy configuration does specify a username, and a "mvn -X" log shows
> Maven to be aware of the username a few lines earlier.
> [DEBUG] Using connector BasicRepositoryConnector with priority 0.0 for
> https://repo.maven.apache.org/maven2 via mamwg.gdc4s.com:8080 with
> username=p58042, password=***
> I don't see a way to attach, but if I can do so after saving I will attach a
> fairly simple pom file, settings.xml (stripped of passwords), and plain and
> debug log files that will reproduce the error with the commands 'mvn -s
> settings.xml site' and 'mvn -X -s settings.xml site'.
> I have listed this as "minor" because my end build results thus far have been
> successful and the components which have failed to download have apparently
> not impacted my building or testing - in some cases it appears the component
> is already downloaded to my local repository; however, there are hundreds of
> these warnings in my build logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-7111) Deadlock when reading pom
[
https://issues.apache.org/jira/browse/MNG-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297186#comment-17297186
]
Guillaume Nodet commented on MNG-7111:
--
I've added a fix to the above PR with
https://github.com/apache/maven/pull/442/commits/fbcad5d20454cf754ec6165028ea578c39a047fc
> Deadlock when reading pom
> -
>
> Key: MNG-7111
> URL: https://issues.apache.org/jira/browse/MNG-7111
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
>
> I'm running into the following deadlock while building Apache Camel with the
> current master:
> {code}
> "TransformThread-16@4333" daemon prio=5 tid=0x20 nid=NA waiting
> java.lang.Thread.State: WAITING
>blocks TransformThread-17@4342
> at java.lang.Object.wait(Object.java:-1)
> at java.io.PipedInputStream.read(PipedInputStream.java:326)
> at java.io.PipedInputStream.read(PipedInputStream.java:377)
> at java.io.FilterInputStream.read(FilterInputStream.java:133)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:271)
> - locked <0x1163> (a java.io.BufferedInputStream)
> at
> org.codehaus.plexus.util.xml.XmlReader.getBOMEncoding(XmlReader.java:620)
> at
> org.codehaus.plexus.util.xml.XmlReader.doRawStream(XmlReader.java:440)
> at org.codehaus.plexus.util.xml.XmlReader.(XmlReader.java:178)
> at org.codehaus.plexus.util.xml.XmlReader.(XmlReader.java:145)
> at
> org.codehaus.plexus.util.xml.XmlStreamReader.(XmlStreamReader.java:84)
> at
> org.codehaus.plexus.util.ReaderFactory.newXmlReader(ReaderFactory.java:109)
> at
> org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:116)
> at
> org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:90)
> at
> org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:97)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readRawModel(DefaultModelBuilder.java:736)
> at
> org.apache.maven.model.building.DefaultModelBuilder.access$200(DefaultModelBuilder.java:99)
> at
> org.apache.maven.model.building.DefaultModelBuilder$DefaultTransformerContextBuilder$1.findRawModel(DefaultModelBuilder.java:1588)
> at
> org.apache.maven.model.building.DefaultModelBuilder$DefaultTransformerContextBuilder$1.lambda$getRawModel$1(DefaultModelBuilder.java:1570)
> at
> org.apache.maven.model.building.DefaultModelBuilder$DefaultTransformerContextBuilder$1$$Lambda$129.1344264523.apply(Unknown
> Source:-1)
> at
> java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1705)
> - locked <0x115e> (a
> java.util.concurrent.ConcurrentHashMap$ReservationNode)
> at
> org.apache.maven.model.building.DefaultModelBuilder$DefaultTransformerContextBuilder$1.getRawModel(DefaultModelBuilder.java:1569)
> at
> org.apache.maven.model.building.DefaultBuildPomXMLFilterFactory.lambda$getDependencyKeyToVersionMapper$3(DefaultBuildPomXMLFilterFactory.java:67)
> at
> org.apache.maven.model.building.DefaultBuildPomXMLFilterFactory$$Lambda$87.1867108691.apply(Unknown
> Source:-1)
> at
> org.apache.maven.xml.sax.filter.ReactorDependencyXMLFilter.getVersion(ReactorDependencyXMLFilter.java:156)
> at
> org.apache.maven.xml.sax.filter.ReactorDependencyXMLFilter.endElement(ReactorDependencyXMLFilter.java:112)
> at
> org.xml.sax.helpers.XMLFilterImpl.endElement(XMLFilterImpl.java:570)
> at
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:610)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanEndElement(XMLDocumentFragmentScannerImpl.java:1718)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2883)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:605)
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:534)
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:888)
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:824)
> at
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
> at
> com.sun.org.apache.xerces.internal.parsers
[jira] [Commented] (MNG-7111) Deadlock when reading pom
[
https://issues.apache.org/jira/browse/MNG-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297155#comment-17297155
]
Guillaume Nodet commented on MNG-7111:
--
This happens with the fix in https://github.com/apache/maven/pull/442. This
may not happen when using a simple {{HashMap}} but that still makes the usage
of the {{computeIfAbsent}} method invalid.
> Deadlock when reading pom
> -
>
> Key: MNG-7111
> URL: https://issues.apache.org/jira/browse/MNG-7111
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
>
> I'm running into the following deadlock while building Apache Camel with the
> current master:
> {code}
> "TransformThread-16@4333" daemon prio=5 tid=0x20 nid=NA waiting
> java.lang.Thread.State: WAITING
>blocks TransformThread-17@4342
> at java.lang.Object.wait(Object.java:-1)
> at java.io.PipedInputStream.read(PipedInputStream.java:326)
> at java.io.PipedInputStream.read(PipedInputStream.java:377)
> at java.io.FilterInputStream.read(FilterInputStream.java:133)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:271)
> - locked <0x1163> (a java.io.BufferedInputStream)
> at
> org.codehaus.plexus.util.xml.XmlReader.getBOMEncoding(XmlReader.java:620)
> at
> org.codehaus.plexus.util.xml.XmlReader.doRawStream(XmlReader.java:440)
> at org.codehaus.plexus.util.xml.XmlReader.(XmlReader.java:178)
> at org.codehaus.plexus.util.xml.XmlReader.(XmlReader.java:145)
> at
> org.codehaus.plexus.util.xml.XmlStreamReader.(XmlStreamReader.java:84)
> at
> org.codehaus.plexus.util.ReaderFactory.newXmlReader(ReaderFactory.java:109)
> at
> org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:116)
> at
> org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:90)
> at
> org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:97)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readRawModel(DefaultModelBuilder.java:736)
> at
> org.apache.maven.model.building.DefaultModelBuilder.access$200(DefaultModelBuilder.java:99)
> at
> org.apache.maven.model.building.DefaultModelBuilder$DefaultTransformerContextBuilder$1.findRawModel(DefaultModelBuilder.java:1588)
> at
> org.apache.maven.model.building.DefaultModelBuilder$DefaultTransformerContextBuilder$1.lambda$getRawModel$1(DefaultModelBuilder.java:1570)
> at
> org.apache.maven.model.building.DefaultModelBuilder$DefaultTransformerContextBuilder$1$$Lambda$129.1344264523.apply(Unknown
> Source:-1)
> at
> java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1705)
> - locked <0x115e> (a
> java.util.concurrent.ConcurrentHashMap$ReservationNode)
> at
> org.apache.maven.model.building.DefaultModelBuilder$DefaultTransformerContextBuilder$1.getRawModel(DefaultModelBuilder.java:1569)
> at
> org.apache.maven.model.building.DefaultBuildPomXMLFilterFactory.lambda$getDependencyKeyToVersionMapper$3(DefaultBuildPomXMLFilterFactory.java:67)
> at
> org.apache.maven.model.building.DefaultBuildPomXMLFilterFactory$$Lambda$87.1867108691.apply(Unknown
> Source:-1)
> at
> org.apache.maven.xml.sax.filter.ReactorDependencyXMLFilter.getVersion(ReactorDependencyXMLFilter.java:156)
> at
> org.apache.maven.xml.sax.filter.ReactorDependencyXMLFilter.endElement(ReactorDependencyXMLFilter.java:112)
> at
> org.xml.sax.helpers.XMLFilterImpl.endElement(XMLFilterImpl.java:570)
> at
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:610)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanEndElement(XMLDocumentFragmentScannerImpl.java:1718)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2883)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:605)
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:534)
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:888)
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:824)
> at
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLPars
