[jira] [Moved] (MNG-7135) maven crashes with jdk 16
[ https://issues.apache.org/jira/browse/MNG-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MASFRES-44 to MNG-7135: Key: MNG-7135 (was: MASFRES-44) Project: Maven (was: Apache Maven Resource Bundles) > maven crashes with jdk 16 > - > > Key: MNG-7135 > URL: https://issues.apache.org/jira/browse/MNG-7135 > Project: Maven > Issue Type: Bug > Environment: Linux Mint 20.1 >Reporter: J. K. Singer >Priority: Major > > Maven does not work with JDK 16, still works with JDK 15, albeit with warning > > export JAVA_HOME=/opt/jdk-15 > mvn archetype:generate -DarchetypeArtifactId=maven-archetype-quickstart > -DarchetypeVersion=1.4 -DgroupId="com.example" -DartifactId="FailDemo" > -Dpackage="com.example.FailDemo" -DinteractiveMode=false > WARNING: An illegal reflective access operation has occurred > WARNING: Illegal reflective access by > com.google.inject.internal.cglib.core.$ReflectUtils$1 > (file:/usr/share/maven/lib/guice.jar) to method > java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) > export JAVA_HOME=/opt/jdk-16 > mvn archetype:generate -DarchetypeArtifactId=maven-archetype-quickstart > -DarchetypeVersion=1.4 -DgroupId="com.example" -DartifactId="FailDemo" > -Dpackage="com.example.FailDemo" -DinteractiveMode=false > [ERROR] Error executing Maven. > [ERROR] java.lang.IllegalStateException: Unable to load cache item > [ERROR] Caused by: Unable to load cache item > [ERROR] Caused by: Could not initialize class > com.google.inject.internal.cglib.core.$MethodWrapper -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MASFRES-44) maven crashes with jdk 16
[ https://issues.apache.org/jira/browse/MASFRES-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314110#comment-17314110 ] Michael Osipov commented on MASFRES-44: --- Which Maven version? > maven crashes with jdk 16 > - > > Key: MASFRES-44 > URL: https://issues.apache.org/jira/browse/MASFRES-44 > Project: Apache Maven Resource Bundles > Issue Type: Bug > Environment: Linux Mint 20.1 >Reporter: J. K. Singer >Priority: Major > > Maven does not work with JDK 16, still works with JDK 15, albeit with warning > > export JAVA_HOME=/opt/jdk-15 > mvn archetype:generate -DarchetypeArtifactId=maven-archetype-quickstart > -DarchetypeVersion=1.4 -DgroupId="com.example" -DartifactId="FailDemo" > -Dpackage="com.example.FailDemo" -DinteractiveMode=false > WARNING: An illegal reflective access operation has occurred > WARNING: Illegal reflective access by > com.google.inject.internal.cglib.core.$ReflectUtils$1 > (file:/usr/share/maven/lib/guice.jar) to method > java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) > export JAVA_HOME=/opt/jdk-16 > mvn archetype:generate -DarchetypeArtifactId=maven-archetype-quickstart > -DarchetypeVersion=1.4 -DgroupId="com.example" -DartifactId="FailDemo" > -Dpackage="com.example.FailDemo" -DinteractiveMode=false > [ERROR] Error executing Maven. > [ERROR] java.lang.IllegalStateException: Unable to load cache item > [ERROR] Caused by: Unable to load cache item > [ERROR] Caused by: Could not initialize class > com.google.inject.internal.cglib.core.$MethodWrapper -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1015) Add tag signing support to prepare goal
[ https://issues.apache.org/jira/browse/MRELEASE-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314039#comment-17314039 ] Hudson commented on MRELEASE-1015: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #32 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/32/ > Add tag signing support to prepare goal > --- > > Key: MRELEASE-1015 > URL: https://issues.apache.org/jira/browse/MRELEASE-1015 > Project: Maven Release Plugin > Issue Type: New Feature > Components: Git >Affects Versions: 3.0.0-M1 >Reporter: Brian Demers >Assignee: Robert Scholte >Priority: Major > Fix For: 3.0.0, 3.0.0-M3 > > > git-exe now supports signed tags (woot!), we need to pass this through via > the release plugin. > https://github.com/apache/maven-release/pull/23 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-release] rfscholte commented on pull request #20: [MRELEASE-798] - allow additional files to be commited at release
rfscholte commented on pull request #20: URL: https://github.com/apache/maven-release/pull/20#issuecomment-812665724 As mentioned in Jira, this is not the approach I'd like to see. Hence I'm closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] rfscholte closed pull request #20: [MRELEASE-798] - allow additional files to be commited at release
rfscholte closed pull request #20: URL: https://github.com/apache/maven-release/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r606372077 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ## @@ -501,6 +504,12 @@ @Parameter( property = "excludedGroups" ) private String excludedGroups; +@Parameter( property = "junitIncludeEngine" ) Review comment: I expected to finish it today but ok I will wait for you till Tuesday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] rfscholte commented on pull request #23: [MRELEASE-1015] Add `signTag` option to release:prepare goal
rfscholte commented on pull request #23: URL: https://github.com/apache/maven-release/pull/23#issuecomment-812663596 Merged with https://github.com/apache/maven-release/commit/814230235034885d1d785f7e124452f12718d402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] rfscholte closed pull request #23: [MRELEASE-1015] Add `signTag` option to release:prepare goal
rfscholte closed pull request #23: URL: https://github.com/apache/maven-release/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRELEASE-1015) Add tag signing support to prepare goal
[ https://issues.apache.org/jira/browse/MRELEASE-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MRELEASE-1015. Fix Version/s: 3.0.0-M3 3.0.0 Assignee: Robert Scholte Resolution: Fixed Fixed in [814230235034885d1d785f7e124452f12718d402|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=814230235034885d1d785f7e124452f12718d402] > Add tag signing support to prepare goal > --- > > Key: MRELEASE-1015 > URL: https://issues.apache.org/jira/browse/MRELEASE-1015 > Project: Maven Release Plugin > Issue Type: New Feature > Components: Git >Affects Versions: 3.0.0-M1 >Reporter: Brian Demers >Assignee: Robert Scholte >Priority: Major > Fix For: 3.0.0, 3.0.0-M3 > > > git-exe now supports signed tags (woot!), we need to pass this through via > the release plugin. > https://github.com/apache/maven-release/pull/23 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] MartinKanters commented on a change in pull request #463: Extend mvn help text for various features of Maven 4.0.0
MartinKanters commented on a change in pull request #463: URL: https://github.com/apache/maven/pull/463#discussion_r606357348 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -121,11 +121,11 @@ public CLIManager() options.addOption( Option.builder( Character.toString( QUIET ) ).longOpt( "quiet" ).desc( "Quiet output - only show errors" ).build() ); options.addOption( Option.builder( Character.toString( DEBUG ) ).longOpt( "debug" ).desc( "Produce execution debug output" ).build() ); options.addOption( Option.builder( Character.toString( ERRORS ) ).longOpt( "errors" ).desc( "Produce execution error messages" ).build() ); -options.addOption( Option.builder( Character.toString( NON_RECURSIVE ) ).longOpt( "non-recursive" ).desc( "Do not recurse into sub-projects" ).build() ); +options.addOption( Option.builder( Character.toString( NON_RECURSIVE ) ).longOpt( "non-recursive" ).desc( "Do not recurse into sub-projects. When used together with -pl, do not recurse into sub-projects of selected aggregators" ).build() ); options.addOption( Option.builder( Character.toString( UPDATE_SNAPSHOTS ) ).longOpt( "update-snapshots" ).desc( "Forces a check for missing releases and updated snapshots on remote repositories" ).build() ); -options.addOption( Option.builder( Character.toString( ACTIVATE_PROFILES ) ).longOpt( "activate-profiles" ).desc( "Comma-delimited list of profiles to activate" ).hasArg().build() ); +options.addOption( Option.builder( Character.toString( ACTIVATE_PROFILES ) ).longOpt( "activate-profiles" ).desc( "Comma-delimited list of profiles to activate. Prefixing a profile with ! excludes it, and ? marks it as optional" ).hasArg().build() ); Review comment: Ah, that sounds good. When there's more space, we should take a look at explaining the flags a bit better I think. But perhaps for now we should stick with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-1854) Support include/exclude junit test engine
[ https://issues.apache.org/jira/browse/SUREFIRE-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1854: --- Labels: junit5 (was: ) > Support include/exclude junit test engine > - > > Key: SUREFIRE-1854 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1854 > Project: Maven Surefire > Issue Type: New Feature > Components: JUnit 5.x support, Maven Surefire Plugin >Affects Versions: 2.22.2 >Reporter: Adam >Assignee: Tibor Digana >Priority: Major > Labels: junit5 > > It could be very important for my project to support include/exclude junit > test engine by Maven Surefire Plugin. > Junit Console Launcher have existing support for this: > [https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher-options] > Similar solution exists for Gradle: > https://junit.org/junit5/docs/current/user-guide/#running-tests-build-gradle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SUREFIRE-1854) Support include/exclude junit test engine
[ https://issues.apache.org/jira/browse/SUREFIRE-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1854: -- Assignee: Tibor Digana > Support include/exclude junit test engine > - > > Key: SUREFIRE-1854 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1854 > Project: Maven Surefire > Issue Type: New Feature > Components: JUnit 5.x support, Maven Surefire Plugin >Affects Versions: 2.22.2 >Reporter: Adam >Assignee: Tibor Digana >Priority: Major > > It could be very important for my project to support include/exclude junit > test engine by Maven Surefire Plugin. > Junit Console Launcher have existing support for this: > [https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher-options] > Similar solution exists for Gradle: > https://junit.org/junit5/docs/current/user-guide/#running-tests-build-gradle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SUREFIRE-1854) Support include/exclude junit test engine
[ https://issues.apache.org/jira/browse/SUREFIRE-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1854: --- Fix Version/s: 3.0.0-M6 > Support include/exclude junit test engine > - > > Key: SUREFIRE-1854 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1854 > Project: Maven Surefire > Issue Type: New Feature > Components: JUnit 5.x support, Maven Surefire Plugin >Affects Versions: 2.22.2 >Reporter: Adam >Assignee: Tibor Digana >Priority: Major > Labels: junit5 > Fix For: 3.0.0-M6 > > > It could be very important for my project to support include/exclude junit > test engine by Maven Surefire Plugin. > Junit Console Launcher have existing support for this: > [https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher-options] > Similar solution exists for Gradle: > https://junit.org/junit5/docs/current/user-guide/#running-tests-build-gradle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] rmannibucau commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
rmannibucau commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812647803 @hboutemy I understand the 7118 point, I can backport it but it also means adding something to enable user to not break OOTB from what was discussed on the list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MASFRES-44) maven crashes with jdk 16
J. K. Singer created MASFRES-44: --- Summary: maven crashes with jdk 16 Key: MASFRES-44 URL: https://issues.apache.org/jira/browse/MASFRES-44 Project: Apache Maven Resource Bundles Issue Type: Bug Environment: Linux Mint 20.1 Reporter: J. K. Singer Maven does not work with JDK 16, still works with JDK 15, albeit with warning export JAVA_HOME=/opt/jdk-15 mvn archetype:generate -DarchetypeArtifactId=maven-archetype-quickstart -DarchetypeVersion=1.4 -DgroupId="com.example" -DartifactId="FailDemo" -Dpackage="com.example.FailDemo" -DinteractiveMode=false WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) export JAVA_HOME=/opt/jdk-16 mvn archetype:generate -DarchetypeArtifactId=maven-archetype-quickstart -DarchetypeVersion=1.4 -DgroupId="com.example" -DartifactId="FailDemo" -Dpackage="com.example.FailDemo" -DinteractiveMode=false [ERROR] Error executing Maven. [ERROR] java.lang.IllegalStateException: Unable to load cache item [ERROR] Caused by: Unable to load cache item [ERROR] Caused by: Could not initialize class com.google.inject.internal.cglib.core.$MethodWrapper -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-surefire] adam11grafik commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
adam11grafik commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r606343723 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ## @@ -501,6 +504,12 @@ @Parameter( property = "excludedGroups" ) private String excludedGroups; +@Parameter( property = "junitIncludeEngine" ) Review comment: Ok, thank you. I will try to do this on Tuesday :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
hboutemy commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812634619 I won't discuss more MNG-7118: I just say that without MNG-7118, the CVE range won't mark this as unaffected I just want to prevent from another independent mess: the branch chosen as starting point contains MNG-5868 that is not part of 3.8.1 (I won't discuss about other commits that are less important: I won't be picky) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
rmannibucau commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812618240 @hboutemy just answered on the list. Long story short, MNG-7118 does not fix the security issue, just default it but it is bypassed in most CI and this PR is only to enable to get the security fix (external:http support) but avoids to break OOTB the 3.6 users. So all good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r606320356 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ## @@ -501,6 +504,12 @@ @Parameter( property = "excludedGroups" ) private String excludedGroups; +@Parameter( property = "junitIncludeEngine" ) Review comment: yes, the trick is called an Abstcation. Let's jump to the class `SurefirePlugin`, and consider the field [printSummary](https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java#L100) and its [setter](https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java#L702) and [getter](https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java#L696). Now jump to the class `IntegrationTestMojo`. The field with name [printSummary](https://github.com/apache/maven-surefire/blob/master/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java#L117), [setter](https://github.com/apache/maven-surefire/blob/master/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java#L692) and [getter](https://github.com/apache/maven-surefire/blob/master/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java#L686). These were concrete implementations. But notice that both classes implement the same interface through extension of the abstract class `AbstractSurefireMojo`, see [this](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L162). So the [interface](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireExecutionParameters.java) declares abstract methods I spoke before, the [setter](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireExecutionParameters.java#L83) and [getter](https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireExecutionParameters.java#L81). The task for you is to rename your fields to `includeJUnit5Engines` and `excludeJUnit5Engines`. Then change the type to `String[]`. The IntelliJ IDEA will automatically update the getter and setter. Write both abstract getter and setter in the interface `SurefireExecutionParameters`. Implement them in `SurefirePlugin` and `IntegrationTestMojo`. Move both fields [this](https://github.com/apache/maven-surefire/pull/344/commits/e8ef4f5153d5c3f82639e4ec8cd1b1364202dad8#diff-38e379eb63d7dcd2deb45902b4a494517e4ce54c29913bcf74e7d9243ebb7011R507) and [this](https://github.com/apache/maven-surefire/pull/344/commits/e8ef4f5153d5c3f82639e4ec8cd1b1364202dad8#diff-38e379eb63d7dcd2deb45902b4a494517e4ce54c29913bcf74e7d9243ebb7011R511) to `SurefirePlugin` and `IntegrationTestMojo`. Then remove the getters and setters in `AbstractSurefireMojo from Line 3815 to 3836. Try to compile the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
hboutemy commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812609342 as sent to the mailing list, MNG-7118 block HTTP by default is the security fix: MNG-7116, MNG-7117 and MNG-7128 are just prerequisites: with this PR, the release keeps being vulnerable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-385) Support for Multi-Release-JARs
[ https://issues.apache.org/jira/browse/MSHADE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313926#comment-17313926 ] Markus Karg commented on MSHADE-385: I confirm that this ticket can be closed. Unfortunately I do not have the rights to perform this ticket action. > Support for Multi-Release-JARs > -- > > Key: MSHADE-385 > URL: https://issues.apache.org/jira/browse/MSHADE-385 > Project: Maven Shade Plugin > Issue Type: New Feature >Affects Versions: 3.3.0 >Reporter: Markus Karg >Priority: Major > > Maven Shade Plugin currently is unable to deal with multi-release JARs, hence > it always (and only) picks the lowest commen nominator (fallback) class. > > Actually the plugin should instead produce a multi-release JAR, hence pick > all class versions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHADE-385) Support for Multi-Release-JARs
[ https://issues.apache.org/jira/browse/MSHADE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313924#comment-17313924 ] Markus Karg commented on MSHADE-385: Romain, sorry for the confusion. I double-checked MSHADE and in fact it is working pretty-well with MJARs. My fault simply was that I forgot to _explicitly_ provide `true` in MSHADE's manifest transformer config, as I assumed that MSHADE would do that _automatically_ once it detects a `version` folder in one of the shaded dependencies. Silly me. ;) > Support for Multi-Release-JARs > -- > > Key: MSHADE-385 > URL: https://issues.apache.org/jira/browse/MSHADE-385 > Project: Maven Shade Plugin > Issue Type: New Feature >Affects Versions: 3.3.0 >Reporter: Markus Karg >Priority: Major > > Maven Shade Plugin currently is unable to deal with multi-release JARs, hence > it always (and only) picks the lowest commen nominator (fallback) class. > > Actually the plugin should instead produce a multi-release JAR, hence pick > all class versions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7045) Drop CDI API from Maven
[ https://issues.apache.org/jira/browse/MNG-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313920#comment-17313920 ] Hudson commented on MNG-7045: - Build unstable in Jenkins: Maven » Maven TLP » maven » master #131 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/master/131/ > Drop CDI API from Maven > --- > > Key: MNG-7045 > URL: https://issues.apache.org/jira/browse/MNG-7045 > Project: Maven > Issue Type: Bug > Components: core >Reporter: Romain Manni-Bucau >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: 4.0.0, 4.0.0-alpha-1 > > > This is an old leak which triggered a lot of regressions and still triggers > bugs in mojos. > Since there is on real justification in maven itself (@Typed is not since > there are alternative and cdi is not used in any piece of maven), let's drop > it. > If a plugin needs it, it already has it since cdi-api is outdated anyway. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7112) --projects flag should honor --non-recursive flag
[
https://issues.apache.org/jira/browse/MNG-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313919#comment-17313919
]
Hudson commented on MNG-7112:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » master #131
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/master/131/
> --projects flag should honor --non-recursive flag
> -
>
> Key: MNG-7112
> URL: https://issues.apache.org/jira/browse/MNG-7112
> Project: Maven
> Issue Type: Improvement
> Components: Reactor and workspace
>Affects Versions: 4.0.x-candidate
>Reporter: Martin Kanters
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> In MNG-6981 and MNG-7102 the behavior around selecting aggregate projects has
> changed.
> Now, when an aggregate is (de)selected, the aggregate project and all its
> children will be (de)selected in the reactor.
> Before, just the aggregate was (de)selected and children were not taken into
> account.
> Because there is no good workaround currently and there is a need for it, we
> should offer a way to bring the old behavior back.
> {{\-N}} or {{\--non-recursive}} is currently used to only select one project,
> and it will not take its children into account during project collection
> (before the reactor flags are applied).
> After discussion on the mailing list, the proposed implementation is to use
> {{\--non-recursive}} together with {{\--projects}} to restore the old
> non-recursive behavior we had before.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] rfscholte commented on a change in pull request #463: Extend mvn help text for various features of Maven 4.0.0
rfscholte commented on a change in pull request #463: URL: https://github.com/apache/maven/pull/463#discussion_r606263973 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -121,11 +121,11 @@ public CLIManager() options.addOption( Option.builder( Character.toString( QUIET ) ).longOpt( "quiet" ).desc( "Quiet output - only show errors" ).build() ); options.addOption( Option.builder( Character.toString( DEBUG ) ).longOpt( "debug" ).desc( "Produce execution debug output" ).build() ); options.addOption( Option.builder( Character.toString( ERRORS ) ).longOpt( "errors" ).desc( "Produce execution error messages" ).build() ); -options.addOption( Option.builder( Character.toString( NON_RECURSIVE ) ).longOpt( "non-recursive" ).desc( "Do not recurse into sub-projects" ).build() ); +options.addOption( Option.builder( Character.toString( NON_RECURSIVE ) ).longOpt( "non-recursive" ).desc( "Do not recurse into sub-projects. When used together with -pl, do not recurse into sub-projects of selected aggregators" ).build() ); options.addOption( Option.builder( Character.toString( UPDATE_SNAPSHOTS ) ).longOpt( "update-snapshots" ).desc( "Forces a check for missing releases and updated snapshots on remote repositories" ).build() ); -options.addOption( Option.builder( Character.toString( ACTIVATE_PROFILES ) ).longOpt( "activate-profiles" ).desc( "Comma-delimited list of profiles to activate" ).hasArg().build() ); +options.addOption( Option.builder( Character.toString( ACTIVATE_PROFILES ) ).longOpt( "activate-profiles" ).desc( "Comma-delimited list of profiles to activate. Prefixing a profile with ! excludes it, and ? marks it as optional" ).hasArg().build() ); Review comment: This is my concern too. The (default) help output should be compact, it used to fit on 1 page. With the new jansi we're probably gaining some space due to the width calculation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MJAR-275) outputTimestamp not applied to module-info; breaks reproducible builds
[
https://issues.apache.org/jira/browse/MJAR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313902#comment-17313902
]
Anand Beh edited comment on MJAR-275 at 4/2/21, 2:20 PM:
-
I may have some good news on the inclusion of JDK patch versions. I took Jorge
Solorzano's advice and used the --release flag, with interesting results.
Additionally, I added JDK 16 to the analysis matrix.
Using JDK 11 and --release 11, the JDK version includes the patch version as
Michael Osipov previously noted:
{code:java}
SourceFile: "module-info.java"
Module:
#5,0// "me.a248.mjar275"
#0
1 // requires
#6,8000 // "java.base" ACC_MANDATED
#7 // 11.0.10
1 // exports
#8,0// me/a248/mjar275
0 // opens
0 // uses
0 // provides
{code}
Using JDK 16 and --release 11, the JDK version vanishes:
{code:java}
SourceFile: "module-info.java"
Module:
#6,0// "me.a248.mjar275"
#0
1 // requires
#8,8000 // "java.base" ACC_MANDATED
#0
1 // exports
#10,0 // me/a248/mjar275
0 // opens
0 // uses
0 // provides{code}
If you would like to reproduce these results, I have updated the reproducer to
include module-info.hash.sh.
{code:java}
# Compiles module-info with --release 11
# Uses JDK set by environment
./module-info-hash.sh 11
{code}
Results are as follows:
|| ||JDK 11||JDK 16||
|--release 11|Patch version is present|No version present|
|--release 16|n/a|Appears that the patch version is gone, but not really,
because JDK 16 has not had a patch release yet.|
was (Author: a248):
I may have some good news on the inclusion of JDK patch versions. I took Jorge
Solorzano's advice and used the --release flag, with interesting results.
Additionally, I added JDK 16 to the analysis matrix.
Using JDK 11 and --release 11, the JDK version includes the patch version as
Michael Osipov previously noted:
{code:java}
SourceFile: "module-info.java"
Module:
#5,0// "me.a248.mjar275"
#0
1 // requires
#6,8000 // "java.base" ACC_MANDATED
#7 // 11.0.10
1 // exports
#8,0// me/a248/mjar275
0 // opens
0 // uses
0 // provides
{code}
{code:java}
{code}
Using JDK 16 and --release 11, the JDK version vanishes:
{code:java}
SourceFile: "module-info.java"
Module:
#6,0// "me.a248.mjar275"
#0
1 // requires
#8,8000 // "java.base" ACC_MANDATED
#0
1 // exports
#10,0 // me/a248/mjar275
0 // opens
0 // uses
0 // provides{code}
If you would like to reproduce these results, I have updated the reproducer to
include module-info.hash.sh.
{code:java}
# Compiles module-info with --release 11
# Uses JDK set by environment
./module-info-hash.sh 11
{code}
Results are as follows:
|| ||JDK 11||JDK 16||
|--release 11|Patch version is present|No version present|
|--release 16|n/a|Appears that the patch version is gone, but not really,
because JDK 16 has not had a patch release yet.|
> outputTimestamp not applied to module-info; breaks reproducible builds
> --
>
> Key: MJAR-275
> URL: https://issues.apache.org/jira/browse/MJAR-275
> Project: Maven JAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
> Environment: Mac OS X 10.14.6
> JDK 15 (build 15+36)
> JDK 11 (build 11.0.8+10)
>Reporter: Anand Beh
>Priority: Minor
> Attachments: MCOMPILER-439.zip, Screenshot 2020-10-25 at 2.35.59
> PM.png
>
>
> Setting {{project.build.outputTimestamp}} to a fixed value allows creating
> reproducible builds per this guide:
> [https://maven.apache.org/guides/mini/guide-reproducible-builds.html
>
[GitHub] [maven] MartinKanters commented on a change in pull request #463: Extend mvn help text for various features of Maven 4.0.0
MartinKanters commented on a change in pull request #463: URL: https://github.com/apache/maven/pull/463#discussion_r606258893 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -121,11 +121,11 @@ public CLIManager() options.addOption( Option.builder( Character.toString( QUIET ) ).longOpt( "quiet" ).desc( "Quiet output - only show errors" ).build() ); options.addOption( Option.builder( Character.toString( DEBUG ) ).longOpt( "debug" ).desc( "Produce execution debug output" ).build() ); options.addOption( Option.builder( Character.toString( ERRORS ) ).longOpt( "errors" ).desc( "Produce execution error messages" ).build() ); -options.addOption( Option.builder( Character.toString( NON_RECURSIVE ) ).longOpt( "non-recursive" ).desc( "Do not recurse into sub-projects" ).build() ); +options.addOption( Option.builder( Character.toString( NON_RECURSIVE ) ).longOpt( "non-recursive" ).desc( "Do not recurse into sub-projects. When used together with -pl, do not recurse into sub-projects of selected aggregators" ).build() ); options.addOption( Option.builder( Character.toString( UPDATE_SNAPSHOTS ) ).longOpt( "update-snapshots" ).desc( "Forces a check for missing releases and updated snapshots on remote repositories" ).build() ); -options.addOption( Option.builder( Character.toString( ACTIVATE_PROFILES ) ).longOpt( "activate-profiles" ).desc( "Comma-delimited list of profiles to activate" ).hasArg().build() ); +options.addOption( Option.builder( Character.toString( ACTIVATE_PROFILES ) ).longOpt( "activate-profiles" ).desc( "Comma-delimited list of profiles to activate. Prefixing a profile with ! excludes it, and ? marks it as optional" ).hasArg().build() ); Review comment: We strived for conciseness, as this text is now already four lines long (for profiles already seven, which makes it the longest option in mvn help by far). By writing out the symbols in full, this will increase even further. Are you sure you want this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAR-275) outputTimestamp not applied to module-info; breaks reproducible builds
[
https://issues.apache.org/jira/browse/MJAR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313902#comment-17313902
]
Anand Beh commented on MJAR-275:
I may have some good news on the inclusion of JDK patch versions. I took Jorge
Solorzano's advice and used the --release flag, with interesting results.
Additionally, I added JDK 16 to the analysis matrix.
Using JDK 11 and --release 11, the JDK version includes the patch version as
Michael Osipov previously noted:
{code:java}
SourceFile: "module-info.java"
Module:
#5,0// "me.a248.mjar275"
#0
1 // requires
#6,8000 // "java.base" ACC_MANDATED
#7 // 11.0.10
1 // exports
#8,0// me/a248/mjar275
0 // opens
0 // uses
0 // provides
{code}
{code:java}
{code}
Using JDK 16 and --release 11, the JDK version vanishes:
{code:java}
SourceFile: "module-info.java"
Module:
#6,0// "me.a248.mjar275"
#0
1 // requires
#8,8000 // "java.base" ACC_MANDATED
#0
1 // exports
#10,0 // me/a248/mjar275
0 // opens
0 // uses
0 // provides{code}
If you would like to reproduce these results, I have updated the reproducer to
include module-info.hash.sh.
{code:java}
# Compiles module-info with --release 11
# Uses JDK set by environment
./module-info-hash.sh 11
{code}
Results are as follows:
|| ||JDK 11||JDK 16||
|--release 11|Patch version is present|No version present|
|--release 16|n/a|Appears that the patch version is gone, but not really,
because JDK 16 has not had a patch release yet.|
> outputTimestamp not applied to module-info; breaks reproducible builds
> --
>
> Key: MJAR-275
> URL: https://issues.apache.org/jira/browse/MJAR-275
> Project: Maven JAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
> Environment: Mac OS X 10.14.6
> JDK 15 (build 15+36)
> JDK 11 (build 11.0.8+10)
>Reporter: Anand Beh
>Priority: Minor
> Attachments: MCOMPILER-439.zip, Screenshot 2020-10-25 at 2.35.59
> PM.png
>
>
> Setting {{project.build.outputTimestamp}} to a fixed value allows creating
> reproducible builds per this guide:
> [https://maven.apache.org/guides/mini/guide-reproducible-builds.html
> |https://maven.apache.org/guides/mini/guide-reproducible-builds.html]However,
> if one adds a module-info file to the project, reproducible builds break.
> This is caused by module-info.class using the latest timestamp and not
> {{project.build.outputTimestamp}}. I was able to identify the problem using
> diffoscope: [https://diffoscope.org/.|https://diffoscope.org/] With it I
> determined the timestamp across 2 builds was constant for all but the
> module-info.class:
>
> {code:java}
> -rw 2.0 fat 862 bl defN 20-Oct-17 00:40
> space/arim/libertybans/api/select/SelectionOrder.class
> │ -rw 2.0 fat 1113 bl defN 20-Oct-17 00:40
> space/arim/libertybans/api/select/SelectionOrderBuilder.class
> │ -rw 2.0 fat 2285 bl defN 20-Oct-17 00:40
> META-INF/maven/space.arim.libertybans/bans-api/pom.xml
> │ -rw 2.0 fat 74 bl defN 20-Oct-17 00:40
> META-INF/maven/space.arim.libertybans/bans-api/pom.properties
> │ --rw 2.0 fat 557 bl defN 20-Oct-25 12:39 module-info.class
> │ +-rw 2.0 fat 557 bl defN 20-Oct-25 12:41 module-info.class
> {code}
>
> Note the + and - which are diffoscope's way of indicating the difference
> between the .jar files. Here the {{project.build.outputTimestamp}} is on 17
> October. As shown, module-info has a "rebellious" timestamp.
>
> *EDIT:*
> Example project to reproduce the bug:
> [https://github.com/A248/MJAR-275|https://github.com/A248/MCOMPILER-439]
> (Renamed from [https://github.com/A248/MCOMPILER-439])
> Source code is also provided as an attachment below
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNG-7112) --projects flag should honor --non-recursive flag
[
https://issues.apache.org/jira/browse/MNG-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters closed MNG-7112.
---
Fix Version/s: 4.0.0-alpha-1
4.0.0
Resolution: Fixed
Done in
[7c742c298b60f60b1f8b92e43e4952ee128a4cd0|https://github.com/apache/maven/commit/7c742c298b60f60b1f8b92e43e4952ee128a4cd0]
> --projects flag should honor --non-recursive flag
> -
>
> Key: MNG-7112
> URL: https://issues.apache.org/jira/browse/MNG-7112
> Project: Maven
> Issue Type: Improvement
> Components: Reactor and workspace
>Affects Versions: 4.0.x-candidate
>Reporter: Martin Kanters
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> In MNG-6981 and MNG-7102 the behavior around selecting aggregate projects has
> changed.
> Now, when an aggregate is (de)selected, the aggregate project and all its
> children will be (de)selected in the reactor.
> Before, just the aggregate was (de)selected and children were not taken into
> account.
> Because there is no good workaround currently and there is a need for it, we
> should offer a way to bring the old behavior back.
> {{\-N}} or {{\--non-recursive}} is currently used to only select one project,
> and it will not take its children into account during project collection
> (before the reactor flags are applied).
> After discussion on the mailing list, the proposed implementation is to use
> {{\--non-recursive}} together with {{\--projects}} to restore the old
> non-recursive behavior we had before.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] MartinKanters closed pull request #459: [MNG-7112] --projects flag should honor --non-recursive flag
MartinKanters closed pull request #459: URL: https://github.com/apache/maven/pull/459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters closed pull request #104: [MNG-7112] --projects flag should honor --non-recursive flag
MartinKanters closed pull request #104: URL: https://github.com/apache/maven-integration-testing/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] adam11grafik commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
adam11grafik commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r606255188 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ## @@ -501,6 +504,12 @@ @Parameter( property = "excludedGroups" ) private String excludedGroups; +@Parameter( property = "junitIncludeEngine" ) Review comment: Hmm I follow simillar approach like for "groups" but now I am a little confused regarding those fields... Logic to load values for those fields is in AbstractSurefireMojo but if I will not define them here, so how I can get values for them? Can you provide me some example field with simillar flow which you expect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MARCHETYPES-72) Include empty .mvn/jvm.config and .mvn/maven.config in all archetypes
[ https://issues.apache.org/jira/browse/MARCHETYPES-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maarten Mulders updated MARCHETYPES-72: --- Description: All [Maven archetypes|https://maven.apache.org/archetypes/index.html] should generate two empty files in the *.mvn* folder of the generated project: *jvm.config* and *maven.config*. There are two reasons for this: # This points users to the fact that they can use those files to customise their build. # If the project is a multi-module project or is later converted to a multi-module project, Maven will be able to reliably determine the root of that multi-module project. was: All [Maven archetypes|https://maven.apache.org/archetypes/index.html] should generate two (possibly empty) files in the *.mvn* folder of the generated project: *jvm.config* and *maven.config*. There are two reasons for this: # This points users to the fact that they can use those files to customise their build. For that reason, we might even include a comment in those files referring them to [the documentation|https://maven.apache.org/configure.html]. # If the project is a multi-module project or is later converted to a multi-module project, Maven will be able to reliably determine the root of that multi-module project. > Include empty .mvn/jvm.config and .mvn/maven.config in all archetypes > - > > Key: MARCHETYPES-72 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-72 > Project: Maven Archetype Bundles > Issue Type: Improvement >Reporter: Maarten Mulders >Priority: Minor > > All [Maven archetypes|https://maven.apache.org/archetypes/index.html] should > generate two empty files in the *.mvn* folder of the generated project: > *jvm.config* and *maven.config*. > There are two reasons for this: > # This points users to the fact that they can use those files to customise > their build. > # If the project is a multi-module project or is later converted to a > multi-module project, Maven will be able to reliably determine the root of > that multi-module project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MARCHETYPES-72) Include empty .mvn/jvm.config and .mvn/maven.config in all archetypes
Maarten Mulders created MARCHETYPES-72: -- Summary: Include empty .mvn/jvm.config and .mvn/maven.config in all archetypes Key: MARCHETYPES-72 URL: https://issues.apache.org/jira/browse/MARCHETYPES-72 Project: Maven Archetype Bundles Issue Type: Improvement Reporter: Maarten Mulders All [Maven archetypes|https://maven.apache.org/archetypes/index.html] should generate two (possibly empty) files in the *.mvn* folder of the generated project: *jvm.config* and *maven.config*. There are two reasons for this: # This points users to the fact that they can use those files to customise their build. For that reason, we might even include a comment in those files referring them to [the documentation|https://maven.apache.org/configure.html]. # If the project is a multi-module project or is later converted to a multi-module project, Maven will be able to reliably determine the root of that multi-module project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1062) Require Java 8
[ https://issues.apache.org/jira/browse/MRELEASE-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313882#comment-17313882 ] Hudson commented on MRELEASE-1062: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #31 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/31/ > Require Java 8 > -- > > Key: MRELEASE-1062 > URL: https://issues.apache.org/jira/browse/MRELEASE-1062 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Minor > Fix For: 3.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] rmannibucau commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
rmannibucau commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812537590 @aheritier external:* was my first try but has too much side effects and does not fulfill the same goal, this is why i went with this option. At that time i thought we should have enabled external:pattern:xxx instead of hardcode it but for now i'm just trying to drop some blocker. @slachiewicz IMHO a security fix is *not* a new feature as justifying a N+1 but something required in the affected version branch as discussed on the list. 3.8.1 was a core dev choice, not an user one IMHO and I'm just trying to catch up here. @michael-o i reviewed the changelog and most of the changes are dead changes for the resolver so think it is fine to use the 1.6, there are other more impacting bumps in patch versions in general. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRELEASE-1062) Require Java 8
[ https://issues.apache.org/jira/browse/MRELEASE-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MRELEASE-1062. Resolution: Fixed Fixed in [dc25df898f987f787ea040e539e162536bc7d022|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=dc25df898f987f787ea040e539e162536bc7d022] > Require Java 8 > -- > > Key: MRELEASE-1062 > URL: https://issues.apache.org/jira/browse/MRELEASE-1062 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Minor > Fix For: 3.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r606227151 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ## @@ -501,6 +504,12 @@ @Parameter( property = "excludedGroups" ) private String excludedGroups; +@Parameter( property = "junitIncludeEngine" ) Review comment: I know it is quite a lot of work with the PR but it is always with a new feature. Pls add a Javadoc on the top of these fields and see how we use to write the Javadoc in another parts. Additionally every feature has to be documented. Regarding JUnit5 add a new chanper with your feature [here](https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDOAP-62) Require Maven 3.1.1 (drop dependency to Maven 3.0)
Sylwester Lachiewicz created MDOAP-62: - Summary: Require Maven 3.1.1 (drop dependency to Maven 3.0) Key: MDOAP-62 URL: https://issues.apache.org/jira/browse/MDOAP-62 Project: Maven DOAP Plugin Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] michael-o commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
michael-o commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812507500 @rmannibucau You can go with a new Resolver 1.4.x first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] aheritier commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
aheritier commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812505480 @rmannibucau no it's not possible with 3.6.x to do `external:http:// ` It's necessarily `external:*` which is what everyone taking care of security should do to use only the corporate repository `external:http://` is a new feature, this is why it is in 3.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slachiewicz commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
slachiewicz commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812505301 If it's so easy to apply workaround to security issue for 3.6.3 - why still new release 3.8.x? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rmannibucau edited a comment on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
rmannibucau edited a comment on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812504123 @michael-o as explains the topic, the goal is to provide maintenance of our versions to end users. Minimal requirement is to backport security fix on versions. Here we violated all versioning policies by not doing that + jumping from 2 versions (which can't be taken into acocunt in any project stack versioning policy) so just trying to solve that for this time. Edit: resolver 1.6 is needed to get blocked support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
rmannibucau commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812504123 @michael-o as explains the topic, the goal is to provide maintenance of our versions to end users. Minimal requirement is to backport security fix on versions. Here we violated all versioning policies by not doing that + jumping from 2 versions (which can't be taken into acocunt in any project stack versioning policy) so just trying to solve that for this time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
michael-o commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812503634 Using Maven Resolver 1.6.x in a patch release is wrong. Too much has changed there. It should be another 1.4.x if you need to. I also do not understand the purpose of this because 3.8.x is a drop-in replacement except the new mirror handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #463: Extend mvn help text for various features of Maven 4.0.0
michael-o commented on a change in pull request #463: URL: https://github.com/apache/maven/pull/463#discussion_r606207118 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -121,11 +121,11 @@ public CLIManager() options.addOption( Option.builder( Character.toString( QUIET ) ).longOpt( "quiet" ).desc( "Quiet output - only show errors" ).build() ); options.addOption( Option.builder( Character.toString( DEBUG ) ).longOpt( "debug" ).desc( "Produce execution debug output" ).build() ); options.addOption( Option.builder( Character.toString( ERRORS ) ).longOpt( "errors" ).desc( "Produce execution error messages" ).build() ); -options.addOption( Option.builder( Character.toString( NON_RECURSIVE ) ).longOpt( "non-recursive" ).desc( "Do not recurse into sub-projects" ).build() ); +options.addOption( Option.builder( Character.toString( NON_RECURSIVE ) ).longOpt( "non-recursive" ).desc( "Do not recurse into sub-projects. When used together with -pl, do not recurse into sub-projects of selected aggregators" ).build() ); options.addOption( Option.builder( Character.toString( UPDATE_SNAPSHOTS ) ).longOpt( "update-snapshots" ).desc( "Forces a check for missing releases and updated snapshots on remote repositories" ).build() ); -options.addOption( Option.builder( Character.toString( ACTIVATE_PROFILES ) ).longOpt( "activate-profiles" ).desc( "Comma-delimited list of profiles to activate" ).hasArg().build() ); +options.addOption( Option.builder( Character.toString( ACTIVATE_PROFILES ) ).longOpt( "activate-profiles" ).desc( "Comma-delimited list of profiles to activate. Prefixing a profile with ! excludes it, and ? marks it as optional" ).hasArg().build() ); Review comment: I would rather write: ...with an exclamation mark (!) ex, and question mark (?) marks it... ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -136,9 +136,9 @@ public CLIManager() options.addOption( Option.builder( FAIL_FAST ).longOpt( "fail-fast" ).desc( "Stop at first failure in reactorized builds" ).build() ); options.addOption( Option.builder( FAIL_AT_END ).longOpt( "fail-at-end" ).desc( "Only fail the build afterwards; allow all non-impacted builds to continue" ).build() ); options.addOption( Option.builder( FAIL_NEVER ).longOpt( "fail-never" ).desc( "NEVER fail the build, regardless of project result" ).build() ); -options.addOption( Option.builder( RESUME ).longOpt( "resume" ).desc( "Resume reactor from the last failed project, using the resume.properties file in the build directory " ).build() ); +options.addOption( Option.builder( RESUME ).longOpt( "resume" ).desc( "Resume reactor from the last failed project, using the resume.properties file in the build directory" ).build() ); options.addOption( Option.builder( RESUME_FROM ).longOpt( "resume-from" ).hasArg().desc( "Resume reactor from specified project" ).build() ); -options.addOption( Option.builder( PROJECT_LIST ).longOpt( "projects" ).desc( "Comma-delimited list of specified reactor projects to build instead of all projects. A project can be specified by [groupId]:artifactId or by its relative path" ).hasArg().build() ); +options.addOption( Option.builder( PROJECT_LIST ).longOpt( "projects" ).desc( "Comma-delimited list of specified reactor projects to build instead of all projects. A project can be specified by [groupId]:artifactId or by its relative path. Prefixing a project with ! excludes it, and ? marks it as optional" ).hasArg().build() ); Review comment: Same here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
rmannibucau commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-81244 @aheritier hmm, can you point me on the doc to do it for all external:http:// (3.6 equivalent) and not on a per repo basis please? Didn't find it. This is the expected fix I wanted to backport, if already doable no issue to close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] aheritier commented on pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
aheritier commented on pull request #462: URL: https://github.com/apache/maven/pull/462#issuecomment-812498516 -1 for me. It's creating too much confusion to have 2 releases doing the same thing 3.6.x users have a workaround (declare a mirror *) which they should already use if they have such security concerns -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles
[
https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313820#comment-17313820
]
Hudson commented on MRELEASE-1042:
--
Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #30
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/30/
> releaseProfiles get overriden by activeProfiles
> ---
>
> Key: MRELEASE-1042
> URL: https://issues.apache.org/jira/browse/MRELEASE-1042
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: perform
>Affects Versions: 3.0.0-M2
>Reporter: Arnaud Heritier
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.0-M3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I tried to release a project with 3.0.0-M2 and potentially it is another
> problem related to MRELEASE-1038 [~rfscholte] [~olamy]
>
> In our corporate POM we have a pluginManagement entry:
> {code:java}
>
> maven-release-plugin
> 2.5.3
>
> forked-path
> false
> cloudbees-internal-release
>
>
> {code}
> My project extends it and has no settings related to the release plugin
> In my user settings I have
> {code:java}
>
> cloudbees-internal-deploy
> cloudbees-snapshots
> apache-staging
>
> {code}
> Then I release my project using 3.0.0-M2 with
> {code:java}
> mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform
> {code}
> The perform step is taking my user profiles but not the ones from
> "releaseProfiles"
> {noformat}
> [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout &&
> /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s
> /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml
> -f pom.xml deploy -P
> cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f
> pom.xml{noformat}
> Not sure if it could be because I call the release plugin with the full GAV
> but it is strange ...
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r606194405 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ## @@ -501,6 +504,12 @@ @Parameter( property = "excludedGroups" ) private String excludedGroups; +@Parameter( property = "junitIncludeEngine" ) Review comment: Both instance fileds are in wrong class. We have two plugins in this project, so you have to generate getter and setter for these fields. Both must be in `SurefirPlugin` class, see [this](https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java#L99) and also in [here](https://github.com/apache/maven-surefire/blob/master/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java#L116). The reson is the prefix in the property. Due to AbstractSurefireMojo is an abstract class, you have to generate getters and setters and use them instead of fields in AbstractSurefireMojo. Regarding the naming conventions pls start the name of fields and properties with "include" and "exclude", and rename junit to "junit5" to make it clear that we are not aiming for JUnit4 and 3. Additionally both should be String[] because the history shows us that people want to have more than one value in our config properties, pls see [the tutorial for MOJO](https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#parameter-types-with-multiple-values). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRELEASE-1062) Require Java 8
Robert Scholte created MRELEASE-1062: Summary: Require Java 8 Key: MRELEASE-1062 URL: https://issues.apache.org/jira/browse/MRELEASE-1062 Project: Maven Release Plugin Issue Type: Improvement Reporter: Robert Scholte Assignee: Robert Scholte Fix For: 3.0.0-M3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r606194405 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ## @@ -501,6 +504,12 @@ @Parameter( property = "excludedGroups" ) private String excludedGroups; +@Parameter( property = "junitIncludeEngine" ) Review comment: Both instance fileds are in wrong class. We have two plugins in this project, so you have to generate getter and setter for these fields. Both must be in `SurefirPlugin` class, see [this](https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java#L99) and also in [here](https://github.com/apache/maven-surefire/blob/master/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java#L116). The reson is the prefix in the property. Due to AbstractSurefireMojo is an abstract class, you have to generate getters and setters and use them instead of fields in AbstractSurefireMojo. Regarding the naming conventions pls start the name of fields and properties with "include" and "exclude", and rename junit to "junit5" to make it clear that we are aiming for not JUnit4 and 3. Additionally both should be String[] because the history shows us that people want to have more than one value in our config properties, pls see [the tutorial for MOJO](https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#parameter-types-with-multiple-values). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r606194405 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ## @@ -501,6 +504,12 @@ @Parameter( property = "excludedGroups" ) private String excludedGroups; +@Parameter( property = "junitIncludeEngine" ) Review comment: Both instance fileds are in wrong class. We have two plugins in this project, so you have to generate getter and setter for these fields. Both must be in `SurefirPlugin` class, see [this](https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java#L99) and also in [here](https://github.com/apache/maven-surefire/blob/master/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java#L116). The reson is the prefix in the property. Due to AbstractSurefireMojo is an abstract class, you have to generate getters and setters and use them instead of fields in AbstractSurefireMojo. Regarding the naming conventions pls start the name of fields and properties with "include" and "exclude", and raname junit to "junit5" to make it clear that we are aiming for not JUnit4 and 3. Additionally both should be String[] because the history shows us that people want to have more than one value in our config properties, pls see [the tutorial for MOJO](https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#parameter-types-with-multiple-values). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #456: Run GitHub actions integration tests with Java 16
mthmulders commented on pull request #456: URL: https://github.com/apache/maven/pull/456#issuecomment-812486116 > But the [ASM changelog](https://asm.ow2.io/versions.html) says Java 17 support was only added with ASM 9.1. That version is only included in [Groovy 4.0.0-alpha-2](https://github.com/apache/groovy/blob/1136910170fd100fb2d792db95ec08b935f29530/versions.properties#L20). Turns out ASM 9.1 is not in Groovy 4.0.0-alpha-2 either - it is only in HEAD. According to [the Groovy issue tracker](https://issues.apache.org/jira/browse/GROOVY-9943), it may end up in Groovy 3.0.8 and/or 4.0.0-alpha-3. Both of them are not released at this point. Therefore, I will create a separate merge request to add Java 17-ea to the matrix, and this merge request will only add Java 16. We can then merge this one on short notice, and merge the other one when there is a suitable Groovy version available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] rfscholte closed pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
rfscholte closed pull request #56: URL: https://github.com/apache/maven-release/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] rfscholte commented on pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
rfscholte commented on pull request #56: URL: https://github.com/apache/maven-release/pull/56#issuecomment-812486023 Merged with https://github.com/apache/maven-release/commit/a553e1921a3633848e8a886a0286bf45047b9ab5 Thanks for the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles
[
https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MRELEASE-1042.
Resolution: Fixed
Fixed in
[a553e1921a3633848e8a886a0286bf45047b9ab5|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=a553e1921a3633848e8a886a0286bf45047b9ab5]
> releaseProfiles get overriden by activeProfiles
> ---
>
> Key: MRELEASE-1042
> URL: https://issues.apache.org/jira/browse/MRELEASE-1042
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: perform
>Affects Versions: 3.0.0-M2
>Reporter: Arnaud Heritier
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.0-M3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I tried to release a project with 3.0.0-M2 and potentially it is another
> problem related to MRELEASE-1038 [~rfscholte] [~olamy]
>
> In our corporate POM we have a pluginManagement entry:
> {code:java}
>
> maven-release-plugin
> 2.5.3
>
> forked-path
> false
> cloudbees-internal-release
>
>
> {code}
> My project extends it and has no settings related to the release plugin
> In my user settings I have
> {code:java}
>
> cloudbees-internal-deploy
> cloudbees-snapshots
> apache-staging
>
> {code}
> Then I release my project using 3.0.0-M2 with
> {code:java}
> mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform
> {code}
> The perform step is taking my user profiles but not the ones from
> "releaseProfiles"
> {noformat}
> [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout &&
> /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s
> /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml
> -f pom.xml deploy -P
> cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f
> pom.xml{noformat}
> Not sure if it could be because I call the release plugin with the full GAV
> but it is strange ...
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MDOAP-61) The DOAP plugin is failing for Log4j 2.
[
https://issues.apache.org/jira/browse/MDOAP-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313804#comment-17313804
]
Sylwester Lachiewicz commented on MDOAP-61:
---
com.ibm.icu have issues with Java version parsing. Here also more info:
https://stackoverflow.com/questions/64040255/invalid-version-number-version-number-may-be-negative-or-greater-than-255
> The DOAP plugin is failing for Log4j 2.
> ---
>
> Key: MDOAP-61
> URL: https://issues.apache.org/jira/browse/MDOAP-61
> Project: Maven DOAP Plugin
> Issue Type: Bug
>Affects Versions: 1.2
>Reporter: Ralph Goers
>Priority: Major
> Attachments: doap_log4j.rdf
>
>
> While trying to build the Log4j site for the next release I encountered a
> failure in the doap pluign. It is getting
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-doap-plugin:1.2:generate (default-cli) on
> project log4j: Execution default-cli of goal
> org.apache.maven.plugins:maven-doap-plugin:1.2:generate failed: An API
> incompatibility was encountered while executing
> org.apache.maven.plugins:maven-doap-plugin:1.2:generate:
> java.lang.ExceptionInInitializerError: null
> [ERROR] -
> [ERROR] realm =plugin>org.apache.maven.plugins:maven-doap-plugin:1.2
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] =
> file:/Users/rgoers/.m2/repository/org/apache/maven/plugins/maven-doap-plugin/1.2/maven-doap-plugin-1.2.jar
> [ERROR] urls[1] =
> file:/Users/rgoers/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
> [ERROR] urls[2] =
> file:/Users/rgoers/.m2/repository/junit/junit/3.8.1/junit-3.8.1.jar
> [ERROR] urls[3] =
> file:/Users/rgoers/.m2/repository/org/apache/maven/scm/maven-scm-api/1.9.2/maven-scm-api-1.9.2.jar
> [ERROR] urls[4] =
> file:/Users/rgoers/.m2/repository/org/apache/maven/scm/maven-scm-manager-plexus/1.9.2/maven-scm-manager-plexus-1.9.2.jar
> [ERROR] urls[5] =
> file:/Users/rgoers/.m2/repository/org/apache/maven/scm/maven-scm-provider-svn-commons/1.9.2/maven-scm-provider-svn-commons-1.9.2.jar
> [ERROR] urls[6] =
> file:/Users/rgoers/.m2/repository/org/apache/maven/scm/maven-scm-provider-svnexe/1.9.2/maven-scm-provider-svnexe-1.9.2.jar
> [ERROR] urls[7] =
> file:/Users/rgoers/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar
> [ERROR] urls[8] =
> file:/Users/rgoers/.m2/repository/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.9.2/maven-scm-provider-cvs-commons-1.9.2.jar
> [ERROR] urls[9] =
> file:/Users/rgoers/.m2/repository/org/apache/maven/scm/maven-scm-provider-cvsexe/1.9.2/maven-scm-provider-cvsexe-1.9.2.jar
> [ERROR] urls[10] =
> file:/Users/rgoers/.m2/repository/org/apache/maven/scm/maven-scm-provider-cvsjava/1.9.2/maven-scm-provider-cvsjava-1.9.2.jar
> [ERROR] urls[11] =
> file:/Users/rgoers/.m2/repository/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar
> [ERROR] urls[12] =
> file:/Users/rgoers/.m2/repository/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar
> [ERROR] urls[13] =
> file:/Users/rgoers/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.20/plexus-utils-3.0.20.jar
> [ERROR] urls[14] =
> file:/Users/rgoers/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
> [ERROR] urls[15] =
> file:/Users/rgoers/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-10/plexus-i18n-1.0-beta-10.jar
> [ERROR] urls[16] =
> file:/Users/rgoers/.m2/repository/com/hp/hpl/jena/jena/2.6.3/jena-2.6.3.jar
> [ERROR] urls[17] =
> file:/Users/rgoers/.m2/repository/com/hp/hpl/jena/iri/0.8/iri-0.8.jar
> [ERROR] urls[18] =
> file:/Users/rgoers/.m2/repository/com/hp/hpl/jena/iri/0.8/iri-0.8-sources.jar
> [ERROR] urls[19] =
> file:/Users/rgoers/.m2/repository/com/ibm/icu/icu4j/3.4.4/icu4j-3.4.4.jar
> [ERROR] urls[20] =
> file:/Users/rgoers/.m2/repository/xerces/xercesImpl/2.7.1/xercesImpl-2.7.1.jar
> [ERROR] urls[21] =
> file:/Users/rgoers/.m2/repository/org/slf4j/slf4j-log4j12/1.5.8/slf4j-log4j12-1.5.8.jar
> [ERROR] urls[22] =
> file:/Users/rgoers/.m2/repository/log4j/log4j/1.2.13/log4j-1.2.13.jar
> [ERROR] urls[23] =
> file:/Users/rgoers/.m2/repository/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar
> [ERROR] urls[24] =
> file:/Users/rgoers/.m2/repository/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar
> [ERROR] urls[25] =
> file:/Users/rgoers/.m2/repository/commons-codec/commons-codec/1.2/commons-codec-1.2.jar
> [ERROR] Number of foreign imports: 1
> [ERROR] import: Entry[import from realm ClassRealm[maven.api, parent: null]]
> [ERROR]
> [ERROR] -
> [ERROR] : Invalid version number: Version number
[jira] [Closed] (MENFORCER-382) Enforcer plugin does not work with Java 16
[
https://issues.apache.org/jira/browse/MENFORCER-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed MENFORCER-382.
--
Resolution: Invalid
> Enforcer plugin does not work with Java 16
> --
>
> Key: MENFORCER-382
> URL: https://issues.apache.org/jira/browse/MENFORCER-382
> Project: Maven Enforcer Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-M3
>Reporter: Jordan Zimmerman
>Priority: Major
>
> I tried building with Java 16 and get this error:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce (default) on
> project missioncontrol-root: Execution default of goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce failed:
> Unknown JDK version given. Should be something like "1.7", "8", "11", "12" ->
> [Help 1]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-812472479 The build is succesful now. Pls squash all commits in one, I would like to see it as one commit and make the last review. Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] olamy merged pull request #63: Fix typo
olamy merged pull request #63: URL: https://github.com/apache/maven-archetype/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] lmagnien opened a new pull request #63: Fix typo
lmagnien opened a new pull request #63: URL: https://github.com/apache/maven-archetype/pull/63 The archetype.languages and archetype.filteredExtensions default values were wrong because they were switched -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters opened a new pull request #463: Extend mvn help text for various features of Maven 4.0.0
MartinKanters opened a new pull request #463: URL: https://github.com/apache/maven/pull/463 This PR intends to briefly explain the new features of 4.0.0 (and the undocumented exclusion prefix). In [MNGSITE-444](https://issues.apache.org/jira/browse/MNGSITE-444) we will extend the documentation on the site in more detail. --- Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rmannibucau commented on a change in pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
rmannibucau commented on a change in pull request #462: URL: https://github.com/apache/maven/pull/462#discussion_r606136287 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepository.java ## @@ -73,6 +73,12 @@ @Deprecated void setBlacklisted( boolean blackListed ); +/** @since 3.8.1 **/ Review comment: Good catch, fixed, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] eolivelli commented on a change in pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
eolivelli commented on a change in pull request #462: URL: https://github.com/apache/maven/pull/462#discussion_r606133878 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepository.java ## @@ -73,6 +73,12 @@ @Deprecated void setBlacklisted( boolean blackListed ); +/** @since 3.8.1 **/ Review comment: 3.6.? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] nfalco79 commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
nfalco79 commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r606108773
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
@rfscholte, @slachiewicz please could you finalize this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] nfalco79 commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
nfalco79 commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r606108773
##
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
-ReleaseDescriptor releaseDescriptor =
-loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ReleaseDescriptorBuilder builder =
+loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+List allProfiles = new ArrayList<>();
Review comment:
@rfscholte please could you finalize this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] rmannibucau opened a new pull request #462: [MNG-7134] Backport security fix in 3.6.x branch
rmannibucau opened a new pull request #462: URL: https://github.com/apache/maven/pull/462 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7134) Backport 3.8.1 security fixes in 3.6.x branch
Romain Manni-Bucau created MNG-7134: --- Summary: Backport 3.8.1 security fixes in 3.6.x branch Key: MNG-7134 URL: https://issues.apache.org/jira/browse/MNG-7134 Project: Maven Issue Type: Task Reporter: Romain Manni-Bucau -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-integration-testing] asfgit closed pull request #105: [MNG-7045] Upgrade to IT to use Groovy 4.0.0-alpha-2
asfgit closed pull request #105: URL: https://github.com/apache/maven-integration-testing/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on a change in pull request #459: [MNG-7112] --projects flag should honor --non-recursive flag
MartinKanters commented on a change in pull request #459: URL: https://github.com/apache/maven/pull/459#discussion_r606099395 ## File path: maven-core/src/test/java/org/apache/maven/graph/DefaultGraphBuilderTest.java ## @@ -390,6 +400,7 @@ private Dependency toDependency( MavenProject mavenProject ) private String resumeFrom = ""; private String makeBehavior = ""; private File requestedPom = new File( PARENT_MODULE, "pom.xml" ); +private boolean isRecursive = true; Review comment: Yep, I agree. It's changed now, and I've found and fixed some other inconsistencies around that parameter as well. Ready to be reviewed again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
