[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332952#comment-17332952
]
Tamás Cservenák commented on MRESOLVER-153:
---
[~Brand] I think this is fine so far, and thank you for testing!
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt,
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed on the {{TrackingFileManager}}
> ([https://github.com/apache/maven-resolver/pull/67]). This now leads to
> concurrent writes on the {{resolver-status.properties}} file in our tests and
> causes the error during the {{Properties#load()}}
[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332937#comment-17332937
]
Guy Brand edited comment on MRESOLVER-153 at 4/27/21, 5:31 AM:
---
I've executed the tests and extracted two that failed with the above error. One
is with the {{-Daether.syncContext.impl=global}} system property set and one
without.
Just read the above comments and nice that you could find the root cause. I
hope with these logs you can verify it. Do you need anything else from me?
[^with-global-sync-context.txt] [^without-global-sync-context.txt]
was (Author: brand):
I've executed the tests and extracted two that failed with the above error. One
is with the {{-Daether.syncContext.impl=global}} system property set and one
without.
Just read the above comments and nice that you could find the root cause. I
hope with these logs you can verify it. Do you need anything else from me?
[^with-global-sync-context.txt] [^without-global-sync-context.txt]
[^with-global-sync-context.txt]
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt,
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at
[jira] [Updated] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guy Brand updated MRESOLVER-153:
Attachment: without-global-sync-context.txt
with-global-sync-context.txt
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt,
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed on the {{TrackingFileManager}}
> ([https://github.com/apache/maven-resolver/pull/67]). This now leads to
> concurrent writes on the {{resolver-status.properties}} file in our tests and
> causes the error during the {{Properties#load()}} method wich then throws the
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332937#comment-17332937
]
Guy Brand commented on MRESOLVER-153:
-
I've executed the tests and extracted two that failed with the above error. One
is with the {{-Daether.syncContext.impl=global}} system property set and one
without.
Just read the above comments and nice that you could find the root cause. I
hope with these logs you can verify it. Do you need anything else from me?
[^with-global-sync-context.txt] [^without-global-sync-context.txt]
[^with-global-sync-context.txt]
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png, with-global-sync-context.txt,
> without-global-sync-context.txt
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that
[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request #16: Bump mavenPluginToolsVersion from 3.6.0 to 3.6.1
dependabot[bot] opened a new pull request #16: URL: https://github.com/apache/maven-help-plugin/pull/16 Bumps `mavenPluginToolsVersion` from 3.6.0 to 3.6.1. Updates `maven-plugin-tools-generators` from 3.6.0 to 3.6.1 Commits https://github.com/apache/maven-plugin-tools/commit/a6e2a968b1e760328662ac7a0a71df8b15d29803;>a6e2a96 [maven-release-plugin] prepare release maven-plugin-tools-3.6.1 https://github.com/apache/maven-plugin-tools/commit/f727d265de6e3935d1153832d475bb635b44c630;>f727d26 Update plugins https://github.com/apache/maven-plugin-tools/commit/129217b00c49aaaedbcf829e272f22cb40ef3338;>129217b Clean up plugins https://github.com/apache/maven-plugin-tools/commit/620b085450e635fe2772a04b0b180f2e2fea8530;>620b085 Clean up code https://github.com/apache/maven-plugin-tools/commit/d3e52d08be0f53a65424ffc5088b1718a46a2666;>d3e52d0 [MPLUGIN-348] Why does maven-plugin-plugin always warn if goalPrefix is set? https://github.com/apache/maven-plugin-tools/commit/5417a1caa74ba1d83b613735d2f9a85d20c88f88;>5417a1c [MPLUGIN-365] Don't log a warning when packaging type unsupported - info is ... https://github.com/apache/maven-plugin-tools/commit/e477e6c029be51a41c1b20ebfb2980dfa5c38b56;>e477e6c [MPLUGIN-360] generated plugin-help.xml ignores descriptor mojo outputDirectory https://github.com/apache/maven-plugin-tools/commit/2f29e9a3822a3eba50bd921f111ffce1f8182f54;>2f29e9a [MPLUGIN-369] - Upgrade ASM Api version to ASM9 in visitors - in sync with th... https://github.com/apache/maven-plugin-tools/commit/9d1289e02f4c1f0a2b6b2598f2cfd5f01460fa22;>9d1289e [MPLUGIN-367] Improve https://github.com/Execute;>@Execute(lifecycle...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/30;>#30) https://github.com/apache/maven-plugin-tools/commit/f574628a311097eeb7c06b1838e6a1d92c71f27f;>f574628 [MPLUGIN-368] Improve https://github.com/Execute;>@Execute(goal...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/31;>#31) Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.0...maven-plugin-tools-3.6.1;>compare view Updates `maven-plugin-annotations` from 3.6.0 to 3.6.1 Commits https://github.com/apache/maven-plugin-tools/commit/a6e2a968b1e760328662ac7a0a71df8b15d29803;>a6e2a96 [maven-release-plugin] prepare release maven-plugin-tools-3.6.1 https://github.com/apache/maven-plugin-tools/commit/f727d265de6e3935d1153832d475bb635b44c630;>f727d26 Update plugins https://github.com/apache/maven-plugin-tools/commit/129217b00c49aaaedbcf829e272f22cb40ef3338;>129217b Clean up plugins https://github.com/apache/maven-plugin-tools/commit/620b085450e635fe2772a04b0b180f2e2fea8530;>620b085 Clean up code https://github.com/apache/maven-plugin-tools/commit/d3e52d08be0f53a65424ffc5088b1718a46a2666;>d3e52d0 [MPLUGIN-348] Why does maven-plugin-plugin always warn if goalPrefix is set? https://github.com/apache/maven-plugin-tools/commit/5417a1caa74ba1d83b613735d2f9a85d20c88f88;>5417a1c [MPLUGIN-365] Don't log a warning when packaging type unsupported - info is ... https://github.com/apache/maven-plugin-tools/commit/e477e6c029be51a41c1b20ebfb2980dfa5c38b56;>e477e6c [MPLUGIN-360] generated plugin-help.xml ignores descriptor mojo outputDirectory https://github.com/apache/maven-plugin-tools/commit/2f29e9a3822a3eba50bd921f111ffce1f8182f54;>2f29e9a [MPLUGIN-369] - Upgrade ASM Api version to ASM9 in visitors - in sync with th... https://github.com/apache/maven-plugin-tools/commit/9d1289e02f4c1f0a2b6b2598f2cfd5f01460fa22;>9d1289e [MPLUGIN-367] Improve https://github.com/Execute;>@Execute(lifecycle...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/30;>#30) https://github.com/apache/maven-plugin-tools/commit/f574628a311097eeb7c06b1838e6a1d92c71f27f;>f574628 [MPLUGIN-368] Improve https://github.com/Execute;>@Execute(goal...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/31;>#31) Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.0...maven-plugin-tools-3.6.1;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot
[jira] [Created] (SUREFIRE-1910) Missleading error message when using -Dtest=....
Christoph Läubrich created SUREFIRE-1910:
Summary: Missleading error message when using -Dtest=
Key: SUREFIRE-1910
URL: https://issues.apache.org/jira/browse/SUREFIRE-1910
Project: Maven Surefire
Issue Type: Bug
Affects Versions: 2.22.2
Reporter: Christoph Läubrich
I run
{noformat}
mvn clean verify -Dtest=abc
{noformat}
then I get the following error message:
{noformat}
No tests were executed! (Set -DfailIfNoTests=false to ignore this error.)
{noformat}
This is missleading as failIfNoTests is false by default. Actually I have to
set surefire.failIfNoSpecifiedTests=false
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #47: Bump maven-plugin-plugin from 3.6.0 to 3.6.1
dependabot[bot] opened a new pull request #47: URL: https://github.com/apache/maven-jlink-plugin/pull/47 Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.6.0 to 3.6.1. Commits https://github.com/apache/maven-plugin-tools/commit/a6e2a968b1e760328662ac7a0a71df8b15d29803;>a6e2a96 [maven-release-plugin] prepare release maven-plugin-tools-3.6.1 https://github.com/apache/maven-plugin-tools/commit/f727d265de6e3935d1153832d475bb635b44c630;>f727d26 Update plugins https://github.com/apache/maven-plugin-tools/commit/129217b00c49aaaedbcf829e272f22cb40ef3338;>129217b Clean up plugins https://github.com/apache/maven-plugin-tools/commit/620b085450e635fe2772a04b0b180f2e2fea8530;>620b085 Clean up code https://github.com/apache/maven-plugin-tools/commit/d3e52d08be0f53a65424ffc5088b1718a46a2666;>d3e52d0 [MPLUGIN-348] Why does maven-plugin-plugin always warn if goalPrefix is set? https://github.com/apache/maven-plugin-tools/commit/5417a1caa74ba1d83b613735d2f9a85d20c88f88;>5417a1c [MPLUGIN-365] Don't log a warning when packaging type unsupported - info is ... https://github.com/apache/maven-plugin-tools/commit/e477e6c029be51a41c1b20ebfb2980dfa5c38b56;>e477e6c [MPLUGIN-360] generated plugin-help.xml ignores descriptor mojo outputDirectory https://github.com/apache/maven-plugin-tools/commit/2f29e9a3822a3eba50bd921f111ffce1f8182f54;>2f29e9a [MPLUGIN-369] - Upgrade ASM Api version to ASM9 in visitors - in sync with th... https://github.com/apache/maven-plugin-tools/commit/9d1289e02f4c1f0a2b6b2598f2cfd5f01460fa22;>9d1289e [MPLUGIN-367] Improve https://github.com/Execute;>@Execute(lifecycle...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/30;>#30) https://github.com/apache/maven-plugin-tools/commit/f574628a311097eeb7c06b1838e6a1d92c71f27f;>f574628 [MPLUGIN-368] Improve https://github.com/Execute;>@Execute(goal...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/31;>#31) Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.0...maven-plugin-tools-3.6.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] dependabot[bot] opened a new pull request #25: Bump mavenPluginToolsVersion from 3.6.0 to 3.6.1
dependabot[bot] opened a new pull request #25: URL: https://github.com/apache/maven-parent/pull/25 Bumps `mavenPluginToolsVersion` from 3.6.0 to 3.6.1. Updates `maven-plugin-annotations` from 3.6.0 to 3.6.1 Commits https://github.com/apache/maven-plugin-tools/commit/a6e2a968b1e760328662ac7a0a71df8b15d29803;>a6e2a96 [maven-release-plugin] prepare release maven-plugin-tools-3.6.1 https://github.com/apache/maven-plugin-tools/commit/f727d265de6e3935d1153832d475bb635b44c630;>f727d26 Update plugins https://github.com/apache/maven-plugin-tools/commit/129217b00c49aaaedbcf829e272f22cb40ef3338;>129217b Clean up plugins https://github.com/apache/maven-plugin-tools/commit/620b085450e635fe2772a04b0b180f2e2fea8530;>620b085 Clean up code https://github.com/apache/maven-plugin-tools/commit/d3e52d08be0f53a65424ffc5088b1718a46a2666;>d3e52d0 [MPLUGIN-348] Why does maven-plugin-plugin always warn if goalPrefix is set? https://github.com/apache/maven-plugin-tools/commit/5417a1caa74ba1d83b613735d2f9a85d20c88f88;>5417a1c [MPLUGIN-365] Don't log a warning when packaging type unsupported - info is ... https://github.com/apache/maven-plugin-tools/commit/e477e6c029be51a41c1b20ebfb2980dfa5c38b56;>e477e6c [MPLUGIN-360] generated plugin-help.xml ignores descriptor mojo outputDirectory https://github.com/apache/maven-plugin-tools/commit/2f29e9a3822a3eba50bd921f111ffce1f8182f54;>2f29e9a [MPLUGIN-369] - Upgrade ASM Api version to ASM9 in visitors - in sync with th... https://github.com/apache/maven-plugin-tools/commit/9d1289e02f4c1f0a2b6b2598f2cfd5f01460fa22;>9d1289e [MPLUGIN-367] Improve https://github.com/Execute;>@Execute(lifecycle...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/30;>#30) https://github.com/apache/maven-plugin-tools/commit/f574628a311097eeb7c06b1838e6a1d92c71f27f;>f574628 [MPLUGIN-368] Improve https://github.com/Execute;>@Execute(goal...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/31;>#31) Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.0...maven-plugin-tools-3.6.1;>compare view Updates `maven-plugin-plugin` from 3.6.0 to 3.6.1 Commits https://github.com/apache/maven-plugin-tools/commit/a6e2a968b1e760328662ac7a0a71df8b15d29803;>a6e2a96 [maven-release-plugin] prepare release maven-plugin-tools-3.6.1 https://github.com/apache/maven-plugin-tools/commit/f727d265de6e3935d1153832d475bb635b44c630;>f727d26 Update plugins https://github.com/apache/maven-plugin-tools/commit/129217b00c49aaaedbcf829e272f22cb40ef3338;>129217b Clean up plugins https://github.com/apache/maven-plugin-tools/commit/620b085450e635fe2772a04b0b180f2e2fea8530;>620b085 Clean up code https://github.com/apache/maven-plugin-tools/commit/d3e52d08be0f53a65424ffc5088b1718a46a2666;>d3e52d0 [MPLUGIN-348] Why does maven-plugin-plugin always warn if goalPrefix is set? https://github.com/apache/maven-plugin-tools/commit/5417a1caa74ba1d83b613735d2f9a85d20c88f88;>5417a1c [MPLUGIN-365] Don't log a warning when packaging type unsupported - info is ... https://github.com/apache/maven-plugin-tools/commit/e477e6c029be51a41c1b20ebfb2980dfa5c38b56;>e477e6c [MPLUGIN-360] generated plugin-help.xml ignores descriptor mojo outputDirectory https://github.com/apache/maven-plugin-tools/commit/2f29e9a3822a3eba50bd921f111ffce1f8182f54;>2f29e9a [MPLUGIN-369] - Upgrade ASM Api version to ASM9 in visitors - in sync with th... https://github.com/apache/maven-plugin-tools/commit/9d1289e02f4c1f0a2b6b2598f2cfd5f01460fa22;>9d1289e [MPLUGIN-367] Improve https://github.com/Execute;>@Execute(lifecycle...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/30;>#30) https://github.com/apache/maven-plugin-tools/commit/f574628a311097eeb7c06b1838e6a1d92c71f27f;>f574628 [MPLUGIN-368] Improve https://github.com/Execute;>@Execute(goal...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/31;>#31) Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.0...maven-plugin-tools-3.6.1;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will
[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request #38: Bump maven-plugin-plugin from 3.6.0 to 3.6.1
dependabot[bot] opened a new pull request #38: URL: https://github.com/apache/maven-apache-parent/pull/38 Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.6.0 to 3.6.1. Commits https://github.com/apache/maven-plugin-tools/commit/a6e2a968b1e760328662ac7a0a71df8b15d29803;>a6e2a96 [maven-release-plugin] prepare release maven-plugin-tools-3.6.1 https://github.com/apache/maven-plugin-tools/commit/f727d265de6e3935d1153832d475bb635b44c630;>f727d26 Update plugins https://github.com/apache/maven-plugin-tools/commit/129217b00c49aaaedbcf829e272f22cb40ef3338;>129217b Clean up plugins https://github.com/apache/maven-plugin-tools/commit/620b085450e635fe2772a04b0b180f2e2fea8530;>620b085 Clean up code https://github.com/apache/maven-plugin-tools/commit/d3e52d08be0f53a65424ffc5088b1718a46a2666;>d3e52d0 [MPLUGIN-348] Why does maven-plugin-plugin always warn if goalPrefix is set? https://github.com/apache/maven-plugin-tools/commit/5417a1caa74ba1d83b613735d2f9a85d20c88f88;>5417a1c [MPLUGIN-365] Don't log a warning when packaging type unsupported - info is ... https://github.com/apache/maven-plugin-tools/commit/e477e6c029be51a41c1b20ebfb2980dfa5c38b56;>e477e6c [MPLUGIN-360] generated plugin-help.xml ignores descriptor mojo outputDirectory https://github.com/apache/maven-plugin-tools/commit/2f29e9a3822a3eba50bd921f111ffce1f8182f54;>2f29e9a [MPLUGIN-369] - Upgrade ASM Api version to ASM9 in visitors - in sync with th... https://github.com/apache/maven-plugin-tools/commit/9d1289e02f4c1f0a2b6b2598f2cfd5f01460fa22;>9d1289e [MPLUGIN-367] Improve https://github.com/Execute;>@Execute(lifecycle...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/30;>#30) https://github.com/apache/maven-plugin-tools/commit/f574628a311097eeb7c06b1838e6a1d92c71f27f;>f574628 [MPLUGIN-368] Improve https://github.com/Execute;>@Execute(goal...) docs (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/31;>#31) Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.0...maven-plugin-tools-3.6.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332767#comment-17332767
]
Michael Osipov edited comment on MRESOLVER-153 at 4/26/21, 10:00 PM:
-
So, first of all, I made a mistake. My analysis for removing the
synchronization was not good enough. I need to apologize for that. The purpose
of the change was to remove synchronization because it is done on the outside
({{SyncContext}}) already and analyzing the hierarchy from above it truly is
except one small case:
{{o.e.a.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}.
So what is causing this race condition? Resolver wants to resolve (download)
{{maven-metadata.xml}} from all known repositories for the *same*
{{G(A(V)?)?}}. Each file instance has its distinct name on the file system (no
race conditions possible), *but* some management data is written to
{{resolver-status.properties}} next (same level) to these metadata. Since
{{executor.execute( errorForwarder.wrap( task ) )}} is running in parallel
multiple threads write to the same file concurrently. The {{SyncContext}} does
not apply here and it causes the race condition you see. The read fails because
the previous writes have corrupted the file.
There are several entry points for
{{DefaultMetadataResolver.resolveMetadata()}}. I can reproduce the issue with
the IT case.
[~cstamas], it'd be nice if you could confirm my observations.
While we need to discuss a proper solution, I consider this behavior ugly
because it completely breaks our sync idea.
I think there are two options:
* Add named sync into {{ResolverTask}}
* Inline code of {{ResolverTask}}, use {{RepositoryConnector}} directly, and
record stuff in serial to avoid race conditions.
Looking at {{ResolverTask}} is runs off a parallel executor which hands off to
a parallel executor again. I don't think that there is huge gain in that.
Please comment.
was (Author: michael-o):
So, first of all, I made a mistake. My analysis for removing the
synchronization was not good enough. I need to apologize for that. The purpose
of the change was to remove synchronization because it is done on the outside
({{SyncContext}}) already and analyzing the hierarchy from above it truly is
except one small case:
{{o.e.a.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}.
So what is causing this race condition? Resolver wants to resolve (download)
{{maven-metadata.xml}} from all known repositories for the *same*
{{G(A(V)?)?}}. Each file instance has its distinct name on the file system (no
race conditions possible), *but* some management data is written to
{{resolver-status.properties}} next (same level) to these metadata. Since
{{executor.execute( errorForwarder.wrap( task ) )}} is running in parallel
multiple threads write to the same file concurrently. The {{SyncContext}} does
not apply here and it causes the race condition you see. The read fails because
the previous writes have corrupted the file.
There are several entry points for
{{DefaultMetadataResolver.resolveMetadata()}}. I can reproduce the issue with
the IT case.
[~cstamas], it'd be nice if you could confirm my observations.
While we need to discuss a proper solution, I consider this behavior ugly
because it completely breaks our sync idea.
I think there are two options:
* Add named sync into {{ResolverTask}}
* Inline code of {{ResolverTask}}, use {{RepositoryConnector}} directly, and
record stuff in serial to avoid race conditions.
Looking at {{ResolverTask}} is runs off an parallel executor which hands off to
a parallel executor again. I don't think that there is huge gain in that.
Please comment.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
[jira] [Updated] (MSHARED-985) XmlWriterUtil does not behave according to spec and is platform dependent
[ https://issues.apache.org/jira/browse/MSHARED-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MSHARED-985: -- Component/s: maven-shared-utils > XmlWriterUtil does not behave according to spec and is platform dependent > - > > Key: MSHARED-985 > URL: https://issues.apache.org/jira/browse/MSHARED-985 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Priority: Minor > > Most methods are documented as "Convenience method to write one > CRLF." > However it does not write a CRLF. Instead it writes a platform dependent line > separator. This interferes with reproducible builds, among other problems. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-983) remove org.codehaus.plexus.logging.AbstractLogEnabled
[ https://issues.apache.org/jira/browse/MSHARED-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MSHARED-983: -- Component/s: maven-shared-utils > remove org.codehaus.plexus.logging.AbstractLogEnabled > - > > Key: MSHARED-983 > URL: https://issues.apache.org/jira/browse/MSHARED-983 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Priority: Major > > The problem is > public abstract class AbstractJavaTool > extends AbstractLogEnabled implements JavaTool > > This should be replaced with SLF4J to remove a lot of transitive dependencies > on plexus-container. > > However this change is backwards incompatible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-986) XmlStreamWriter is pointless
[
https://issues.apache.org/jira/browse/MSHARED-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MSHARED-986:
--
Component/s: maven-shared-utils
> XmlStreamWriter is pointless
>
>
> Key: MSHARED-986
> URL: https://issues.apache.org/jira/browse/MSHARED-986
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-shared-utils
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> ```
> /**
> * We just wrap the commons StreamWriter to not get into troubles
> * by exposing shaded commons-io packages
> */
> public class XmlStreamWriter
> extends org.apache.commons.io.output.XmlStreamWriter
> {
> ```
> This fails to do anything since org.apache.commons.io.output.XmlStreamWriter
> is still exposed through the supertype.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332767#comment-17332767
]
Michael Osipov commented on MRESOLVER-153:
--
So, first of all, I made a mistake. My analysis for removing the
synchronization was not good enough. I need to apologize for that. The purpose
of the change was to remove synchronization because it is done on the outside
({{SyncContext}}) already and analyzing the hierarchy from above it truly is
except one small case:
{{o.e.a.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}.
So what is causing this race condition? Resolver wants to resolve (download)
{{maven-metadata.xml}} from all known repositories for the *same*
{{G(A(V)?)?}}. Each file instance has its distinct name on the file system (no
race conditions possible), *but* some management data is written to
{{resolver-status.properties}} next (same level) to these metadata. Since
{{executor.execute( errorForwarder.wrap( task ) )}} is running in parallel
multiple threads write to the same file concurrently. The {{SyncContext}} does
not apply here and it causes the race condition you see. The read fails because
the previous writes have corrupted the file.
There are several entry points for
{{DefaultMetadataResolver.resolveMetadata()}}. I can reproduce the issue with
the IT case.
[~cstamas], it'd be nice if you could confirm my observations.
While we need to discuss a proper solution, I consider this behavior ugly
because it completely breaks our sync idea.
I think there are two options:
* Add named sync into {{ResolverTask}}
* Inline code of {{ResolverTask}}, use {{RepositoryConnector}} directly, and
record stuff in serial to avoid race conditions.
Looking at {{ResolverTask}} is runs off an parallel executor which hands off to
a parallel executor again. I don't think that there is huge gain in that.
Please comment.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
>
[jira] [Assigned] (MNG-7090) mvnDebug does not work on Java 11+
[
https://issues.apache.org/jira/browse/MNG-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-7090:
---
Assignee: Michael Osipov
> mvnDebug does not work on Java 11+
> --
>
> Key: MNG-7090
> URL: https://issues.apache.org/jira/browse/MNG-7090
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> When {{mvnDebug}} is executed on Java 11 remote debugging does not work
> because the socket binds to localhost only, see:
> https://github.com/OpenLiberty/open-liberty/issues/7833.
> We need to change {{address=8000}} to {{address=*:8000}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] michael-o commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
michael-o commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-827149215 I can live with that change. If no one objects in the next couple of days, I'll test and then merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] elharo merged pull request #86: avoid reusing fixtures
elharo merged pull request #86: URL: https://github.com/apache/maven-shared-utils/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332712#comment-17332712
]
Michael Osipov edited comment on MRESOLVER-153 at 4/26/21, 8:09 PM:
Here is the call hierarchy:
{noformat}
o.e.a.internal.impl.TrackingFileManager.read(File):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.readRepos(File):
"_remote.repositories" sibling of {artifactFilePath}
|-- public
o.e.a.internal.impl.EnhancedLocalRepositoryManager.find(RepositorySystemSession,
LocalArtifactRequest)
|--- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
| (versionResult = versionResolver.resolveVersion( session, versionRequest
))
|- metadataResolver.resolveMetadata( session, metadataReqs )
| private
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.read(File)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.checkArtifact(RepositorySystemSession,
UpdateCheck):
"{artifactFilePath}.lastUpdated"
|--- private
o.e.a.internal.impl.DefaultArtifactResolver.gatherDownloads(RepositorySystemSession,
ResolutionGroup)
| private
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
ResolutionGroup)
|- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|-- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.checkMetadata(RepositorySystemSession,
UpdateCheck):
"resolver-status.properties" sibling of {metadataFilePath}
|--- private
o.e.a.internal.impl.DefaultMetadataResolver.resolve(RepositorySystemSession,
Collection)
| public
o.e.a.internal.impl.DefaultMetadataResolver.resolveMetadata(RepositorySystemSession,
Collection): syncContext.acquire( null, metadata )
(write)
o.e.a.internal.impl.TrackingFileManager.update(File, Map):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.addRepo(File,
Collection): "_remote.repositories" sibling of {artifactFilePath}
|-- private
o.e.a.internal.impl.EnhancedLocalRepositoryManager.addArtifact(Artifact,
Collection, boolean)
|--- public
o.e.a.internal.impl.EnhancedLocalRepositoryManager.add(RepositorySystemSession,
LocalArtifactRegistration)
| private
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
ResolutionGroup)
|- private
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
ResolutionGroup)
|-- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|--- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
| private
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession,
RequestTrace, Artifact, LocalRepositoryManager, File, FileTransformer)
|- private
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession,
RequestTrace, Artifact)
|-- private o.e.a.internal.impl.DefaultInstaller.install(SyncContext,
RepositorySystemSession, InstallRequest): syncContext.acquire( artifacts,
Utils.combine( request.getMetadata(), metadatas ) )
|--- public
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession,
InstallRequest) (write)
| private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.write(File, String,
String, Exception)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.touchArtifact(RepositorySystemSession,
UpdateCheck):
"{artifactFilePath}.lastUpdated"
|--- private
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
ResolutionGroup)
| private
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
ResolutionGroup)
|- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|-- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.touchMetadata(RepositorySystemSession,
UpdateCheck):
"resolver-status.properties" sibling of {metadataFilePath}
|--- public
[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332712#comment-17332712
]
Michael Osipov edited comment on MRESOLVER-153 at 4/26/21, 8:09 PM:
Here is the call hierarchy:
{noformat}
o.e.a.internal.impl.TrackingFileManager.read(File):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.readRepos(File):
"_remote.repositories" sibling of {artifactFilePath}
|-- public
o.e.a.internal.impl.EnhancedLocalRepositoryManager.find(RepositorySystemSession,
LocalArtifactRequest)
|--- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
| (versionResult = versionResolver.resolveVersion( session, versionRequest
))
|- metadataResolver.resolveMetadata( session, metadataReqs )
| private
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.read(File)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.checkArtifact(RepositorySystemSession,
UpdateCheck):
"{artifactFilePath}.lastUpdated"
|--- private
o.e.a.internal.impl.DefaultArtifactResolver.gatherDownloads(RepositorySystemSession,
ResolutionGroup)
| private
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
ResolutionGroup)
|- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|-- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.checkMetadata(RepositorySystemSession,
UpdateCheck):
"resolver-status.properties" sibling of {metadataFilePath}
|--- private
o.e.a.internal.impl.DefaultMetadataResolver.resolve(RepositorySystemSession,
Collection)
| public
o.e.a.internal.impl.DefaultMetadataResolver.resolveMetadata(RepositorySystemSession,
Collection): syncContext.acquire( null, metadata )
(write)
o.e.a.internal.impl.TrackingFileManager.update(File, Map):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.addRepo(File,
Collection): "_remote.repositories" sibling of {artifactFilePath}
|-- private
o.e.a.internal.impl.EnhancedLocalRepositoryManager.addArtifact(Artifact,
Collection, boolean)
|--- public
o.e.a.internal.impl.EnhancedLocalRepositoryManager.add(RepositorySystemSession,
LocalArtifactRegistration)
| private
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
ResolutionGroup)
|- private
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
ResolutionGroup)
|-- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|--- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
| private
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession,
RequestTrace, Artifact, LocalRepositoryManager, File, FileTransformer)
|- private
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession,
RequestTrace, Artifact)
|-- private o.e.a.internal.impl.DefaultInstaller.install(SyncContext,
RepositorySystemSession, InstallRequest): syncContext.acquire( artifacts,
Utils.combine( request.getMetadata(), metadatas ) )
|--- public
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession,
InstallRequest) (write)
| private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.write(File, String,
String, Exception)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.touchArtifact(RepositorySystemSession,
UpdateCheck):
"{artifactFilePath}.lastUpdated"
|--- private
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
ResolutionGroup)
| private
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
ResolutionGroup)
|- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|-- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.touchMetadata(RepositorySystemSession,
UpdateCheck):
"resolver-status.properties" sibling of {metadataFilePath}
|--- public
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332712#comment-17332712
]
Michael Osipov commented on MRESOLVER-153:
--
Here is the call hierarchy:
{nformat}
o.e.a.internal.impl.TrackingFileManager.read(File):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.readRepos(File):
"_remote.repositories" sibling of {artifactFilePath}
|-- public
o.e.a.internal.impl.EnhancedLocalRepositoryManager.find(RepositorySystemSession,
LocalArtifactRequest)
|--- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
| (versionResult = versionResolver.resolveVersion( session, versionRequest
))
|- metadataResolver.resolveMetadata( session, metadataReqs )
| private
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.read(File)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.checkArtifact(RepositorySystemSession,
UpdateCheck):
"{artifactFilePath}.lastUpdated"
|--- private
o.e.a.internal.impl.DefaultArtifactResolver.gatherDownloads(RepositorySystemSession,
ResolutionGroup)
| private
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
ResolutionGroup)
|- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|-- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.checkMetadata(RepositorySystemSession,
UpdateCheck):
"resolver-status.properties" sibling of {metadataFilePath}
|--- private
o.e.a.internal.impl.DefaultMetadataResolver.resolve(RepositorySystemSession,
Collection)
| public
o.e.a.internal.impl.DefaultMetadataResolver.resolveMetadata(RepositorySystemSession,
Collection): syncContext.acquire( null, metadata )
(write)
o.e.a.internal.impl.TrackingFileManager.update(File, Map):
|- private o.e.a.internal.impl.EnhancedLocalRepositoryManager.addRepo(File,
Collection): "_remote.repositories" sibling of {artifactFilePath}
|-- private
o.e.a.internal.impl.EnhancedLocalRepositoryManager.addArtifact(Artifact,
Collection, boolean)
|--- public
o.e.a.internal.impl.EnhancedLocalRepositoryManager.add(RepositorySystemSession,
LocalArtifactRegistration)
| private
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
ResolutionGroup)
|- private
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
ResolutionGroup)
|-- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|--- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
| private
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession,
RequestTrace, Artifact, LocalRepositoryManager, File, FileTransformer)
|- private
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession,
RequestTrace, Artifact)
|-- private o.e.a.internal.impl.DefaultInstaller.install(SyncContext,
RepositorySystemSession, InstallRequest): syncContext.acquire( artifacts,
Utils.combine( request.getMetadata(), metadatas ) )
|--- public
o.e.a.internal.impl.DefaultInstaller.install(RepositorySystemSession,
InstallRequest) (write)
| private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|- private o.e.a.internal.impl.DefaultUpdateCheckManager.write(File, String,
String, Exception)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.touchArtifact(RepositorySystemSession,
UpdateCheck):
"{artifactFilePath}.lastUpdated"
|--- private
o.e.a.internal.impl.DefaultArtifactResolver.evaluateDownloads(RepositorySystemSession,
ResolutionGroup)
| private
o.e.a.internal.impl.DefaultArtifactResolver.performDownloads(RepositorySystemSession,
ResolutionGroup)
|- private
o.e.a.internal.impl.DefaultArtifactResolver.resolve(RepositorySystemSession,
Collection)
|-- public
o.e.a.internal.impl.DefaultArtifactResolver.resolveArtifacts(RepositorySystemSession,
Collection): syncContext.acquire( artifacts, null )
(write)
|-- public
o.e.a.internal.impl.DefaultUpdateCheckManager.touchMetadata(RepositorySystemSession,
UpdateCheck):
"resolver-status.properties" sibling of {metadataFilePath}
|--- public o.e.a.internal.impl.DefaultMetadataResolver.ResolveTask.run()
| private
[jira] [Commented] (MNG-7090) mvnDebug does not work on Java 11+
[
https://issues.apache.org/jira/browse/MNG-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332702#comment-17332702
]
Dufour Guillaume commented on MNG-7090:
---
https://github.com/apache/maven/pull/469
> mvnDebug does not work on Java 11+
> --
>
> Key: MNG-7090
> URL: https://issues.apache.org/jira/browse/MNG-7090
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Priority: Major
>
> When {{mvnDebug}} is executed on Java 11 remote debugging does not work
> because the socket binds to localhost only, see:
> https://github.com/OpenLiberty/open-liberty/issues/7833.
> We need to change {{address=8000}} to {{address=*:8000}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Issue Comment Deleted] (MNG-7090) mvnDebug does not work on Java 11+
[
https://issues.apache.org/jira/browse/MNG-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dufour Guillaume updated MNG-7090:
--
Comment: was deleted
(was: https://github.com/apache/maven/pull/469)
> mvnDebug does not work on Java 11+
> --
>
> Key: MNG-7090
> URL: https://issues.apache.org/jira/browse/MNG-7090
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Priority: Major
>
> When {{mvnDebug}} is executed on Java 11 remote debugging does not work
> because the socket binds to localhost only, see:
> https://github.com/OpenLiberty/open-liberty/issues/7833.
> We need to change {{address=8000}} to {{address=*:8000}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] Dufgui commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
Dufgui commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-827090808 I add POSIX default value and align mvnDebug and mvnwDebug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (DOXIA-588) The Sink.JUSTIFY_XXX has no effect
[
https://issues.apache.org/jira/browse/DOXIA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned DOXIA-588:
Assignee: Michael Osipov
> The Sink.JUSTIFY_XXX has no effect
> --
>
> Key: DOXIA-588
> URL: https://issues.apache.org/jira/browse/DOXIA-588
> Project: Maven Doxia
> Issue Type: Bug
>Reporter: QualiteSys QualiteSys
>Assignee: Michael Osipov
>Priority: Minor
>
> Hello
> I wish to use custom column alignments in tables.
> The Sink.JUSTIFY_LEFT or RIGHT seams not working.
>
> Is this code valid ?
> {code:java} sink.table();
> int[] j = {
> Sink.JUSTIFY_LEFT,
> Sink.JUSTIFY_RIGHT
> };
> sink.tableRows(j, true);{code}
> I haven't found examples up to now.
> Thanks for your help
> Didier
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-shared-utils] elharo commented on a change in pull request #86: avoid reusing fixtures
elharo commented on a change in pull request #86:
URL: https://github.com/apache/maven-shared-utils/pull/86#discussion_r620575581
##
File path:
src/test/java/org/apache/maven/shared/utils/xml/XmlWriterUtilTest.java
##
@@ -86,7 +75,6 @@ public void testWriteLineBreakXMLWriterInt()
{
XmlWriterUtil.writeLineBreak( xmlWriter, 10 );
writer.close();
-assertTrue( StringUtils.countMatches( output.toString(),
XmlWriterUtil.LS ) == 10 );
Review comment:
done
##
File path:
src/test/java/org/apache/maven/shared/utils/xml/XmlWriterUtilTest.java
##
@@ -86,7 +75,6 @@ public void testWriteLineBreakXMLWriterInt()
{
XmlWriterUtil.writeLineBreak( xmlWriter, 10 );
writer.close();
-assertTrue( StringUtils.countMatches( output.toString(),
XmlWriterUtil.LS ) == 10 );
Review comment:
nope, just an error. I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Reopened] (MSHARED-121) FilteringUtils.escapeWindowsPath doesn't handle paths that leave out the drive letter.
[
https://issues.apache.org/jira/browse/MSHARED-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold reopened MSHARED-121:
---
my mistake. was looking in wrong project
> FilteringUtils.escapeWindowsPath doesn't handle paths that leave out the
> drive letter.
> --
>
> Key: MSHARED-121
> URL: https://issues.apache.org/jira/browse/MSHARED-121
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
>Affects Versions: maven-filtering-1.0-beta-3
>Reporter: John Dennis Casey
>Priority: Major
> Attachments:
> 0001-MSHARED-121-Don-t-require-a-drive-letter-to-escape-a.patch,
> FilteringUtilsTest.java
>
>
> FilteringUtils.escapeWindowsPath requires a drive letter to be present in the
> path, or at least the string {noformat}":\\"{noformat} to be present in order
> to trigger escaping the value as a windows path.
> In cases where the path is an absolute reference to a file on the current
> drive (no drive letter is included), or when the path starts with an
> unresolved expression (in cases where n+1 level interpolation will eventually
> resolve the expression), escaping doesn't happen at all.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MSHARED-121) FilteringUtils.escapeWindowsPath doesn't handle paths that leave out the drive letter.
[
https://issues.apache.org/jira/browse/MSHARED-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MSHARED-121.
---
Resolution: Resolved
Obsolete. This class appears to have been deleted.
> FilteringUtils.escapeWindowsPath doesn't handle paths that leave out the
> drive letter.
> --
>
> Key: MSHARED-121
> URL: https://issues.apache.org/jira/browse/MSHARED-121
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
>Affects Versions: maven-filtering-1.0-beta-3
>Reporter: John Dennis Casey
>Priority: Major
> Attachments:
> 0001-MSHARED-121-Don-t-require-a-drive-letter-to-escape-a.patch,
> FilteringUtilsTest.java
>
>
> FilteringUtils.escapeWindowsPath requires a drive letter to be present in the
> path, or at least the string {noformat}":\\"{noformat} to be present in order
> to trigger escaping the value as a windows path.
> In cases where the path is an absolute reference to a file on the current
> drive (no drive letter is included), or when the path starts with an
> unresolved expression (in cases where n+1 level interpolation will eventually
> resolve the expression), escaping doesn't happen at all.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MSHARED-121) FilteringUtils.escapeWindowsPath doesn't handle paths that leave out the drive letter.
[
https://issues.apache.org/jira/browse/MSHARED-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold closed MSHARED-121.
-
> FilteringUtils.escapeWindowsPath doesn't handle paths that leave out the
> drive letter.
> --
>
> Key: MSHARED-121
> URL: https://issues.apache.org/jira/browse/MSHARED-121
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
>Affects Versions: maven-filtering-1.0-beta-3
>Reporter: John Dennis Casey
>Priority: Major
> Attachments:
> 0001-MSHARED-121-Don-t-require-a-drive-letter-to-escape-a.patch,
> FilteringUtilsTest.java
>
>
> FilteringUtils.escapeWindowsPath requires a drive letter to be present in the
> path, or at least the string {noformat}":\\"{noformat} to be present in order
> to trigger escaping the value as a windows path.
> In cases where the path is an absolute reference to a file on the current
> drive (no drive letter is included), or when the path starts with an
> unresolved expression (in cases where n+1 level interpolation will eventually
> resolve the expression), escaping doesn't happen at all.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-shared-utils] mthmulders commented on a change in pull request #86: avoid reusing fixtures
mthmulders commented on a change in pull request #86:
URL: https://github.com/apache/maven-shared-utils/pull/86#discussion_r620565790
##
File path:
src/test/java/org/apache/maven/shared/utils/xml/XmlWriterUtilTest.java
##
@@ -86,7 +75,6 @@ public void testWriteLineBreakXMLWriterInt()
{
XmlWriterUtil.writeLineBreak( xmlWriter, 10 );
writer.close();
-assertTrue( StringUtils.countMatches( output.toString(),
XmlWriterUtil.LS ) == 10 );
Review comment:
Did you remove the assertion on purpose? If so, why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MSHARED-986) XmlStreamWriter is pointless
Elliotte Rusty Harold created MSHARED-986:
-
Summary: XmlStreamWriter is pointless
Key: MSHARED-986
URL: https://issues.apache.org/jira/browse/MSHARED-986
Project: Maven Shared Components
Issue Type: Bug
Reporter: Elliotte Rusty Harold
```
/**
* We just wrap the commons StreamWriter to not get into troubles
* by exposing shaded commons-io packages
*/
public class XmlStreamWriter
extends org.apache.commons.io.output.XmlStreamWriter
{
```
This fails to do anything since org.apache.commons.io.output.XmlStreamWriter is
still exposed through the supertype.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MSHARED-985) XmlWriterUtil does not behave according to spec and is platform dependent
Elliotte Rusty Harold created MSHARED-985: - Summary: XmlWriterUtil does not behave according to spec and is platform dependent Key: MSHARED-985 URL: https://issues.apache.org/jira/browse/MSHARED-985 Project: Maven Shared Components Issue Type: Bug Reporter: Elliotte Rusty Harold Most methods are documented as "Convenience method to write one CRLF." However it does not write a CRLF. Instead it writes a platform dependent line separator. This interferes with reproducible builds, among other problems. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-shared-utils] elharo opened a new pull request #86: avoid reusing fixtures
elharo opened a new pull request #86: URL: https://github.com/apache/maven-shared-utils/pull/86 @mthmulders -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Deleted] (MNG-7147) test
[ https://issues.apache.org/jira/browse/MNG-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov deleted MNG-7147: > test > > > Key: MNG-7147 > URL: https://issues.apache.org/jira/browse/MNG-7147 > Project: Maven > Issue Type: Bug >Reporter: test1 >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332629#comment-17332629
]
Michael Osipov edited comment on MRESOLVER-153 at 4/26/21, 5:37 PM:
The biggest problem is:
{{org.eclipse.aether.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}
This resolves (downloads) metadata completely w/o any synchronization.
[~cstamas], I need to completely analyze which tracking files are written and
check what kind of synchro they have, if any. Annoying. I don't understand why
the {{ResolverTask}} is not subject to.
was (Author: michael-o):
The biggest problem is:
{{org.eclipse.aether.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}
This resolves (downloads) metadata completely w/o any synchronization.
[~cstamas], I need to completely analyze with tracking files are written and
check what kind of synchro they have, if any. Annoying. I don't understand why
the {{ResolverTask}} is not subject to.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
>
[jira] [Commented] (DOXIA-588) The Sink.JUSTIFY_XXX has no effect
[
https://issues.apache.org/jira/browse/DOXIA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332640#comment-17332640
]
ASF GitHub Bot commented on DOXIA-588:
--
qualitesys opened a new pull request #61:
URL: https://github.com/apache/maven-doxia/pull/61
See Jira ticket https://issues.apache.org/jira/browse/DOXIA-588
Source code patch
Update Unit test as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The Sink.JUSTIFY_XXX has no effect
> --
>
> Key: DOXIA-588
> URL: https://issues.apache.org/jira/browse/DOXIA-588
> Project: Maven Doxia
> Issue Type: Bug
>Reporter: QualiteSys QualiteSys
>Priority: Minor
>
> Hello
> I wish to use custom column alignments in tables.
> The Sink.JUSTIFY_LEFT or RIGHT seams not working.
>
> Is this code valid ?
> {code:java} sink.table();
> int[] j = {
> Sink.JUSTIFY_LEFT,
> Sink.JUSTIFY_RIGHT
> };
> sink.tableRows(j, true);{code}
> I haven't found examples up to now.
> Thanks for your help
> Didier
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332629#comment-17332629
]
Michael Osipov commented on MRESOLVER-153:
--
The biggest problem is:
{{org.eclipse.aether.internal.impl.DefaultMetadataResolver.ResolveTask.run()}}
This resolves (downloads) metadata completely w/o any synchronization.
[~cstamas], I need to completely analyze with tracking files are written and
check what kind of synchro they have, if any. Annoying. I don't understand why
the {{ResolverTask}} is not subject to.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332623#comment-17332623
]
Michael Osipov commented on MRESOLVER-153:
--
[~Brand], please combine both. Make two runs with {{...impl}} and without, but
with the longer defines set.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed on the {{TrackingFileManager}}
> ([https://github.com/apache/maven-resolver/pull/67]). This now leads to
> concurrent writes on the {{resolver-status.properties}} file in our tests and
> causes the error during the {{Properties#load()}} method wich then throws
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332620#comment-17332620
]
Michael Osipov commented on MRESOLVER-153:
--
Update to the matter. I have partially to revert my statement. They do not
overlap. This properties file is for metadata only: {{maven-metadata.xml}}. I
will keep investigating while [~Brand] will provide the requried input.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed on the {{TrackingFileManager}}
> ([https://github.com/apache/maven-resolver/pull/67]). This now leads to
> concurrent writes on the
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332611#comment-17332611
]
Guy Brand commented on MRESOLVER-153:
-
So then I'll just run the tests again with {{-Daether.syncContext.impl=global}}
set? Or should I also run it with what you explained here
https://issues.apache.org/jira/browse/MRESOLVER-153?focusedCommentId=17332568=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17332568
?
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed on the {{TrackingFileManager}}
>
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332588#comment-17332588
]
Michael Osipov commented on MRESOLVER-153:
--
Shit, I think I know where this comes from.
{{org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read(File)}} is
called from
{{org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkArtifact(RepositorySystemSession,
UpdateCheck)}} as well as
{{org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata(RepositorySystemSession,
UpdateCheck)}} which bubble up to:
{code:java}
try ( SyncContext syncContext = syncContextFactory.newInstance(
session, false ) )
{
Collection artifacts = new ArrayList<>( requests.size() );
for ( ArtifactRequest request : requests )
{
if ( request.getArtifact().getProperty(
ArtifactProperties.LOCAL_PATH, null ) != null )
{
continue;
}
artifacts.add( request.getArtifact() );
}
syncContext.acquire( artifacts, null );
return resolve( session, requests );
}
{code}
and
{code:java}
try ( SyncContext syncContext = syncContextFactory.newInstance(
session, false ) )
{
Collection metadata = new ArrayList<>( requests.size() );
for ( MetadataRequest request : requests )
{
metadata.add( request.getMetadata() );
}
syncContext.acquire( null, metadata );
return resolve( session, requests );
}
{code}
As you can see there is not "internal files lock". We solely focus on
publically available metadata. I need to understand whether those kind of files
are always read/written for both artifacts and metadata and introduce implicit
locks for each element to block access.
There are two ways to verify that:
1. Use the global lock: {{-Daether.syncContext.impl=global}} and report back
2. I can provide a patched version of Resolver with artifact/metadata prefix.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
>
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332568#comment-17332568
]
Michael Osipov commented on MRESOLVER-153:
--
[~Brand], bad news, but let's analyze that. Please add the following to the
command line:
{noformat}
-V -Dorg.slf4j.simpleLogger.showThreadName=true -B
-Dorg.slf4j.simpleLogger.log.org.eclipse.aether=trace -l {{concurrent.log}}
{noformat}
and upload {{concurrent.log.gz}}. Remove information you cannot/don't want to
disclose. I ran a least a thousand iterations here and never observed it. But
it depends on the project. Maybe there is something I have missed.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
>
[GitHub] [maven-script-interpreter] asfgit closed pull request #36: Bump actions/setup-java from v1 to v2
asfgit closed pull request #36: URL: https://github.com/apache/maven-script-interpreter/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-script-interpreter] dependabot[bot] commented on pull request #36: Bump actions/setup-java from v1 to v2
dependabot[bot] commented on pull request #36: URL: https://github.com/apache/maven-script-interpreter/pull/36#issuecomment-826947237 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker] asfgit closed pull request #9: Bump actions/setup-java from v1 to v2
asfgit closed pull request #9: URL: https://github.com/apache/maven-invoker/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker] dependabot[bot] commented on pull request #9: Bump actions/setup-java from v1 to v2
dependabot[bot] commented on pull request #9: URL: https://github.com/apache/maven-invoker/pull/9#issuecomment-826942081 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDOCCK-35) Upgrade Http Client
[ https://issues.apache.org/jira/browse/MDOCCK-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332517#comment-17332517 ] Tim te Beek commented on MDOCCK-35: --- A first attempt up at https://github.com/apache/maven-docck-plugin/pull/1 Had to move HttpClient builder to execute method, as proxy setup was in execute. Following redirects seems to be the default, hence no direct 1 to 1 replacement for that. The only thing I couldn't work out a direct parallel for was preemptive authentication with the proxy. There might be some hints in here if that's still needed: https://github.com/apache/httpcomponents-client/blob/5.0.x/httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientPreemptiveBasicAuthentication.java > Upgrade Http Client > --- > > Key: MDOCCK-35 > URL: https://issues.apache.org/jira/browse/MDOCCK-35 > Project: Maven Documentation Checker Plugin > Issue Type: Dependency upgrade >Reporter: Robert Scholte >Priority: Major > Labels: up-for-grabs > > This plugin is still using the outdated commons-httpclient 3.1 > This should be updated to a more recent version as described at > https://hc.apache.org/httpcomponents-client-5.0.x/index.html > The structure has changed, so expect usage of new classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-docck-plugin] timtebeek opened a new pull request #1: [MDOCCK-35] - Upgrade Http Client
timtebeek opened a new pull request #1: URL: https://github.com/apache/maven-docck-plugin/pull/1 For https://issues.apache.org/jira/browse/MDOCCK-35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332501#comment-17332501
]
Guy Brand commented on MRESOLVER-153:
-
[~michael-o] Thanks a lot for providing a custom distribution. This made it
easy to rerun all our tests based on this Maven version. I reran all our tests
on Linux, Windows and OSX. We still face these issues on all operating systems,
but the most occurrences are on OSX (as initially reported). So in short this
still does not work as expected.
> resolver-status.properties file is corrupted due to concurrent writes
> -
>
> Key: MRESOLVER-153
> URL: https://issues.apache.org/jira/browse/MRESOLVER-153
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.1
> Environment: OSX 11.1 on adoptopenjdk-11.0.8+10
>Reporter: Guy Brand
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback, 1.7.0
>
> Attachments: screenshot-1.png
>
>
> In our integration tests which run with Maven {{4.0.0-alpha-1-SNAPSHOT}}
> after [this
> commit|https://github.com/apache/maven/commit/7c7de41562a8d83635e8fa21c3a3340298b508a1],
> we face the following error:
> {code:java}
> [main] [INFO]
>
> [main] [INFO] BUILD FAILURE
> [main] [INFO]
>
> [main] [INFO] Total time: 0.243 s
> [main] [INFO] Finished at: 2020-12-23T13:48:59+01:00
> [main] [INFO]
>
> [main] [ERROR] Malformed \u encoding.
> java.lang.IllegalArgumentException: Malformed \u encoding.
> at java.util.Properties.loadConvert (Properties.java:675)
> at java.util.Properties.load0 (Properties.java:451)
> at java.util.Properties.load (Properties.java:404)
> at org.eclipse.aether.internal.impl.TrackingFileManager.read
> (TrackingFileManager.java:56)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.read
> (DefaultUpdateCheckManager.java:511)
> at org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkMetadata
> (DefaultUpdateCheckManager.java:250)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolve
> (DefaultMetadataResolver.java:302)
> at org.eclipse.aether.internal.impl.DefaultMetadataResolver.resolveMetadata
> (DefaultMetadataResolver.java:181)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveMetadata
> (DefaultRepositorySystem.java:277)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolveFromRepository
> (DefaultPluginVersionResolver.java:134)
> at
> org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver.resolve
> (DefaultPluginVersionResolver.java:97)
> at
> org.apache.maven.lifecycle.internal.LifecyclePluginResolver.resolveMissingPluginVersions
> (LifecyclePluginResolver.java:67)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:104)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator.calculateTaskSegments
> (DefaultLifecycleTaskSegmentCalculator.java:86)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:92)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:321)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
> {code}
> It's not consistently failing and OSX based CI agents fail more often than
> Linux or Windows ones. After some investigations we saw that as part of
> https://issues.apache.org/jira/browse/MRESOLVER-132 the synchronization has
> been removed on the {{TrackingFileManager}}
>
[jira] [Updated] (MSHARED-952) PrettyPrintXmlWriter output is platform dependent
[ https://issues.apache.org/jira/browse/MSHARED-952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arnaud Heritier updated MSHARED-952: Fix Version/s: (was: maven-shared-utils-3.4.0) maven-shared-utils-3.3.4 > PrettyPrintXmlWriter output is platform dependent > - > > Key: MSHARED-952 > URL: https://issues.apache.org/jira/browse/MSHARED-952 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Critical > Fix For: maven-shared-utils-3.3.4 > > > This makes the test platform dependent. All this code can be ripped out. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-969) Environment variable with null value
[
https://issues.apache.org/jira/browse/MSHARED-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arnaud Heritier updated MSHARED-969:
Fix Version/s: (was: maven-shared-utils-3.4.0)
maven-shared-utils-3.3.4
> Environment variable with null value
>
>
> Key: MSHARED-969
> URL: https://issues.apache.org/jira/browse/MSHARED-969
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-shared-utils
>Affects Versions: maven-shared-utils-3.3.3
>Reporter: Slawomir Jaranowski
>Assignee: Martin Kanters
>Priority: Major
> Fix For: maven-shared-utils-3.3.4
>
>
> When we add environment variable with {{null}} value then to executed process
> is pass variable with {{"null"}} as string.
> Variable with {{null}} value should not be set, when executed process will
> try to get this variable will receive {{null}} as we expect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MSHARED-962) Upgrade Jansi to 2.0.1
[ https://issues.apache.org/jira/browse/MSHARED-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arnaud Heritier updated MSHARED-962: Fix Version/s: (was: maven-shared-utils-3.4.0) maven-shared-utils-3.3.4 > Upgrade Jansi to 2.0.1 > -- > > Key: MSHARED-962 > URL: https://issues.apache.org/jira/browse/MSHARED-962 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-shared-utils >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: maven-shared-utils-3.3.4 > > > Changelog: [https://github.com/fusesource/jansi/blob/master/changelog.md] > Performance optimizations, particularly for Windows > Utilize VIRTUAL_TERMINAL native feature in recent Windows versions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-973) Upgrade Jansi to 2.2.0
[ https://issues.apache.org/jira/browse/MSHARED-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arnaud Heritier updated MSHARED-973: Fix Version/s: (was: maven-shared-utils-3.4.0) maven-shared-utils-3.3.4 > Upgrade Jansi to 2.2.0 > -- > > Key: MSHARED-973 > URL: https://issues.apache.org/jira/browse/MSHARED-973 > Project: Maven Shared Components > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Robert Scholte >Priority: Major > Fix For: maven-shared-utils-3.3.4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-954) Deprecate StringUtils.unifyLineSeparator
[ https://issues.apache.org/jira/browse/MSHARED-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arnaud Heritier updated MSHARED-954: Fix Version/s: (was: maven-shared-utils-3.4.0) maven-shared-utils-3.3.4 > Deprecate StringUtils.unifyLineSeparator > > > Key: MSHARED-954 > URL: https://issues.apache.org/jira/browse/MSHARED-954 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: maven-shared-utils-3.3.4 > > > This method produces platform dependent code and contributes to > non-reproducible builds. In the context of Maven this is almost never what's > needed. Use an explicit line separator such as "\n" or "\r\n" instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-951) Checked exception converted to raw runtime exception
[
https://issues.apache.org/jira/browse/MSHARED-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arnaud Heritier updated MSHARED-951:
Fix Version/s: (was: maven-shared-utils-3.4.0)
maven-shared-utils-3.3.4
> Checked exception converted to raw runtime exception
>
>
> Key: MSHARED-951
> URL: https://issues.apache.org/jira/browse/MSHARED-951
> Project: Maven Shared Components
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: maven-shared-utils-3.3.4
>
>
> In Xpp3DOMBuilder
> ```
> public static Xpp3Dom build( @WillClose InputStream is, @Nonnull String
> encoding, boolean trim )
> throws XmlPullParserException
> {
> try
> {
> Reader reader = new InputStreamReader( is, encoding );
> return build( reader, trim );
> }
> catch ( UnsupportedEncodingException e )
> {
> throw new RuntimeException( e );
> }
> }
> ```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-shared-utils] asfgit closed pull request #85: Javadoc cleanup in preparation of release
asfgit closed pull request #85: URL: https://github.com/apache/maven-shared-utils/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEPLOY-178) Use information provided in pom.xml of JAR
[ https://issues.apache.org/jira/browse/MDEPLOY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332066#comment-17332066 ] Clemens Hübner commented on MDEPLOY-178: Any chance of making this configurable? We have a large setup where this is undesirable and breaks our builds. > Use information provided in pom.xml of JAR > -- > > Key: MDEPLOY-178 > URL: https://issues.apache.org/jira/browse/MDEPLOY-178 > Project: Maven Deploy Plugin > Issue Type: New Feature > Components: deploy:deploy-file >Affects Versions: 2.8.1 >Reporter: Dominik Schmucki >Assignee: Robert Scholte >Priority: Minor > Fix For: 3.0.0-M1 > > Attachments: DeployFileMojo-usePomInJar.patch > > > We need to upload several third-party JARs to our repository. All we have is > the JARs (which were built by Maven). The maven-install-plugin has a feature > which allows to use the information (groupId, artifactId, version) from the > packaged pom.xml. Adding this feature to the maven-deploy-plugin would allow > us to simplify the maintenance of our repository. > The attached patch is based on the maven-install-plugin. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] rfscholte commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
rfscholte commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-826775051 these changes are done on the mvnwdebug scripts, i.e. the files that are added to the Maven Project when calling `mvn wrapper` in Maven 4. These changes need to be in line with https://github.com/apache/maven/tree/master/apache-maven/src/assembly/maven/bin. It is now maintainted separately to keep the order script in line with Maven 3, but it should be reordered with https://issues.apache.org/jira/browse/MNG-7073 . This should reduce the number of files that are combined to the new script -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
michael-o commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-826765362 This looks OK now for me, will test in the next couple of days... @Dufgui Do you want to convert the default value to POSIX `:-`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
michael-o commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-826764676 @Dufgui No need to close, everything is fine. @rfscholte @hboutemy WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
rmannibucau commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-826754315 @Dufgui I'd be to use "localhost:8000" which works on java 8, 11 etc by default and if not sufficient rely on MAVEN_OPTS until we use a script tomcat-like to handle properly the configuration of this option but not a half baked solution, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] Dufgui commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
Dufgui commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-826714633 So what do you propose? I close this? or I do what ? sorry i don't understand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] Dufgui commented on a change in pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
Dufgui commented on a change in pull request #469:
URL: https://github.com/apache/maven/pull/469#discussion_r620165827
##
File path: apache-maven/src/assembly/shared/mvnwDebug
##
@@ -27,7 +27,11 @@
# MAVEN_SKIP_RC (Optional) Flag to disable loading of mavenrc files.
# -
-MAVEN_DEBUG_OPTS="-Xdebug
-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=0.0.0.0:8000"
+if [ -z "${MAVEN_DEBUG_HOST}" ]; then
+MAVEN_DEBUG_HOST='localhost'
Review comment:
ho sorry you are right. i will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] Dufgui commented on pull request #470: Mng 6294
Dufgui commented on pull request #470: URL: https://github.com/apache/maven/pull/470#issuecomment-826712068 https://github.com/apache/maven/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] Dufgui edited a comment on pull request #470: Mng 6294
Dufgui edited a comment on pull request #470: URL: https://github.com/apache/maven/pull/470#issuecomment-826711102 yes but i don't know how to reuse it, if i am not the author. I rebase the code and do what is asked in the other PR. Is it possible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] Dufgui commented on pull request #470: Mng 6294
Dufgui commented on pull request #470: URL: https://github.com/apache/maven/pull/470#issuecomment-826711102 yes but i don't know how to reuse it, if i am not the author. I rebase the code and do what is asked in the other PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] elharo commented on pull request #1: MINSTALL-115: installAtEnd fails with multiple class realms
elharo commented on pull request #1: URL: https://github.com/apache/maven-install-plugin/pull/1#issuecomment-826708934 Is this still in progress? Should we close it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-171) Resolver fails when compiled on Java 9+ and run on Java 8 due to JDK API breakage
[
https://issues.apache.org/jira/browse/MRESOLVER-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331947#comment-17331947
]
Hudson commented on MRESOLVER-171:
--
Build succeeded in Jenkins: Maven » Maven TLP » maven-resolver » master #65
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/65/
> Resolver fails when compiled on Java 9+ and run on Java 8 due to JDK API
> breakage
> -
>
> Key: MRESOLVER-171
> URL: https://issues.apache.org/jira/browse/MRESOLVER-171
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.7.0
>
>
> When Resolver is compiled with Java 9+ and run with Maven core or something
> else with Java 8 one can observe the following:
> {noformat}
> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.488
> s <<< FAILURE! - in
> org.apache.maven.repository.internal.DefaultVersionResolverTest
> [ERROR] testResolveSeparateInstalledClassifiedNonUniqueVersionedArtifacts
> Time elapsed: 0.243 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultVersionResolverTest.testResolveSeparateInstalledClassifiedNonUniqueVersionedArtifacts(DefaultVersionResolverTest.java:50)
> [INFO] Running org.apache.maven.repository.internal.DefaultModelResolverTest
> [ERROR] Tests run: 10, Failures: 4, Errors: 4, Skipped: 0, Time elapsed:
> 0.729 s <<< FAILURE! - in
> org.apache.maven.repository.internal.DefaultModelResolverTest
> [ERROR]
> testResolveDependencySuccessfullyResolvesExistingDependencyWithoutRange Time
> elapsed: 0.075 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencySuccessfullyResolvesExistingDependencyWithoutRange(DefaultModelResolverTest.java:186)
> [ERROR] testResolveParentSuccessfullyResolvesExistingParentWithoutRange Time
> elapsed: 0.07 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveParentSuccessfullyResolvesExistingParentWithoutRange(DefaultModelResolverTest.java:114)
> [ERROR]
> testResolveParentSuccessfullyResolvesExistingParentUsingHighestVersion Time
> elapsed: 0.089 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveParentSuccessfullyResolvesExistingParentUsingHighestVersion(DefaultModelResolverTest.java:126)
> [ERROR]
> testResolveDependencyThrowsUnresolvableModelExceptionWhenNoMatchingVersionFound
> Time elapsed: 0.068 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: Expected 'UnresolvableModelException'
> not thrown. ==> Unexpected exception type thrown ==> expected:
> but was:
>
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencyThrowsUnresolvableModelExceptionWhenNoMatchingVersionFound(DefaultModelResolverTest.java:154)
> Caused by: java.lang.NoSuchMethodError:
> java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.lambda$testResolveDependencyThrowsUnresolvableModelExceptionWhenNoMatchingVersionFound$4(DefaultModelResolverTest.java:156)
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencyThrowsUnresolvableModelExceptionWhenNoMatchingVersionFound(DefaultModelResolverTest.java:154)
> [ERROR]
> testResolveDependencySuccessfullyResolvesExistingDependencyUsingHighestVersion
> Time elapsed: 0.06 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencySuccessfullyResolvesExistingDependencyUsingHighestVersion(DefaultModelResolverTest.java:198)
> [ERROR]
> testResolveDependencyThrowsUnresolvableModelExceptionWhenUsingRangesWithoutUpperBound
> Time elapsed: 0.061 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: Expected 'UnresolvableModelException'
> not thrown. ==> Unexpected exception type thrown ==> expected:
> but was:
>
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencyThrowsUnresolvableModelExceptionWhenUsingRangesWithoutUpperBound(DefaultModelResolverTest.java:170)
> Caused by: java.lang.NoSuchMethodError:
> java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
>
[jira] [Closed] (MRESOLVER-171) Resolver fails when compiled on Java 9+ and run on Java 8 due to JDK API breakage
[
https://issues.apache.org/jira/browse/MRESOLVER-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MRESOLVER-171.
Resolution: Fixed
Fixed with
[7939a6909d02a5b4356efaff4005902ced9e26f8|https://gitbox.apache.org/repos/asf?p=maven-resolver.git=commit=7939a6909d02a5b4356efaff4005902ced9e26f8].
> Resolver fails when compiled on Java 9+ and run on Java 8 due to JDK API
> breakage
> -
>
> Key: MRESOLVER-171
> URL: https://issues.apache.org/jira/browse/MRESOLVER-171
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 1.6.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.7.0
>
>
> When Resolver is compiled with Java 9+ and run with Maven core or something
> else with Java 8 one can observe the following:
> {noformat}
> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.488
> s <<< FAILURE! - in
> org.apache.maven.repository.internal.DefaultVersionResolverTest
> [ERROR] testResolveSeparateInstalledClassifiedNonUniqueVersionedArtifacts
> Time elapsed: 0.243 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultVersionResolverTest.testResolveSeparateInstalledClassifiedNonUniqueVersionedArtifacts(DefaultVersionResolverTest.java:50)
> [INFO] Running org.apache.maven.repository.internal.DefaultModelResolverTest
> [ERROR] Tests run: 10, Failures: 4, Errors: 4, Skipped: 0, Time elapsed:
> 0.729 s <<< FAILURE! - in
> org.apache.maven.repository.internal.DefaultModelResolverTest
> [ERROR]
> testResolveDependencySuccessfullyResolvesExistingDependencyWithoutRange Time
> elapsed: 0.075 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencySuccessfullyResolvesExistingDependencyWithoutRange(DefaultModelResolverTest.java:186)
> [ERROR] testResolveParentSuccessfullyResolvesExistingParentWithoutRange Time
> elapsed: 0.07 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveParentSuccessfullyResolvesExistingParentWithoutRange(DefaultModelResolverTest.java:114)
> [ERROR]
> testResolveParentSuccessfullyResolvesExistingParentUsingHighestVersion Time
> elapsed: 0.089 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveParentSuccessfullyResolvesExistingParentUsingHighestVersion(DefaultModelResolverTest.java:126)
> [ERROR]
> testResolveDependencyThrowsUnresolvableModelExceptionWhenNoMatchingVersionFound
> Time elapsed: 0.068 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: Expected 'UnresolvableModelException'
> not thrown. ==> Unexpected exception type thrown ==> expected:
> but was:
>
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencyThrowsUnresolvableModelExceptionWhenNoMatchingVersionFound(DefaultModelResolverTest.java:154)
> Caused by: java.lang.NoSuchMethodError:
> java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.lambda$testResolveDependencyThrowsUnresolvableModelExceptionWhenNoMatchingVersionFound$4(DefaultModelResolverTest.java:156)
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencyThrowsUnresolvableModelExceptionWhenNoMatchingVersionFound(DefaultModelResolverTest.java:154)
> [ERROR]
> testResolveDependencySuccessfullyResolvesExistingDependencyUsingHighestVersion
> Time elapsed: 0.06 s <<< ERROR!
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencySuccessfullyResolvesExistingDependencyUsingHighestVersion(DefaultModelResolverTest.java:198)
> [ERROR]
> testResolveDependencyThrowsUnresolvableModelExceptionWhenUsingRangesWithoutUpperBound
> Time elapsed: 0.061 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: Expected 'UnresolvableModelException'
> not thrown. ==> Unexpected exception type thrown ==> expected:
> but was:
>
> at
> org.apache.maven.repository.internal.DefaultModelResolverTest.testResolveDependencyThrowsUnresolvableModelExceptionWhenUsingRangesWithoutUpperBound(DefaultModelResolverTest.java:170)
> Caused by: java.lang.NoSuchMethodError:
> java.nio.ByteBuffer.mark()Ljava/nio/ByteBuffer;
> at
>
[GitHub] [maven] michael-o commented on pull request #470: Mng 6294
michael-o commented on pull request #470: URL: https://github.com/apache/maven/pull/470#issuecomment-826605650 Please note that there is already a PR for this issue... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] Dufgui commented on a change in pull request #470: Mng 6294
Dufgui commented on a change in pull request #470:
URL: https://github.com/apache/maven/pull/470#discussion_r620057883
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/MavenPluginValidator.java
##
@@ -19,63 +19,16 @@
* under the License.
*/
-import java.util.ArrayList;
import java.util.List;
-
import org.apache.maven.artifact.Artifact;
import org.apache.maven.plugin.descriptor.PluginDescriptor;
/**
* MavenPluginValidator
*/
-public class MavenPluginValidator
+public interface MavenPluginValidator
{
-private final Artifact pluginArtifact;
-
-private List errors = new ArrayList<>();
-
-private boolean firstDescriptor = true;
-
-public MavenPluginValidator( Artifact pluginArtifact )
-{
-this.pluginArtifact = pluginArtifact;
-}
-
-public void validate( PluginDescriptor pluginDescriptor )
-{
-/*
- * NOTE: For plugins that depend on other plugin artifacts the plugin
realm contains more than one plugin
- * descriptor. However, only the first descriptor is of interest.
- */
-if ( !firstDescriptor )
Review comment:
This code seems to be unused because before the MavenPluginValidator is
created by each pluginDescriptor in DefaultMavenPluginManager:
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java#L246
I don't think we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o edited a comment on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
michael-o edited a comment on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-826360204 > > > @michael-o right but 0.0.0.0 will come back next the hour after the release as a CVE so not an option sadly. > @Dufgui java 8 is the last one with lib/jre so I guess we can test the presence to adjust the option? That's nonsense because the Java 8 call implicitly binds on all interfaces anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte closed pull request #58: MJAVADOC-661: Fix for tagletArtifact fails to scan multi-release JARs (MRJARs) for Taglets
rfscholte closed pull request #58: URL: https://github.com/apache/maven-javadoc-plugin/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte closed pull request #31: [MJAVADOC-624] tagletArtifacts throws exception in case artifact is a Java 9+ module
rfscholte closed pull request #31: URL: https://github.com/apache/maven-javadoc-plugin/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #90: [MSHADE-382] - Add property to skip execution
rmannibucau commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-826077229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] Dufgui commented on a change in pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
Dufgui commented on a change in pull request #469:
URL: https://github.com/apache/maven/pull/469#discussion_r619872748
##
File path: apache-maven/src/assembly/shared/mvnwDebug
##
@@ -27,7 +27,11 @@
# MAVEN_SKIP_RC (Optional) Flag to disable loading of mavenrc files.
# -
-MAVEN_DEBUG_OPTS="-Xdebug
-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=0.0.0.0:8000"
+if [ -z "${MAVEN_DEBUG_HOST}" ]; then
+MAVEN_DEBUG_HOST='localhost'
Review comment:
No it's only available for bash. Not for sh. i prefere to use the most
standard simple way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-shade-plugin] mkarg edited a comment on pull request #90: [MSHADE-382] - Add property to skip execution
mkarg edited a comment on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-826286867 @aalmiray For the sake of getting progress, I give up to insist on the command line property. Andres, will you remove it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
michael-o commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-826355168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
rmannibucau commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-826354122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] mthmulders commented on pull request #85: WIP: Javadoc cleanup in preparation of release
mthmulders commented on pull request #85: URL: https://github.com/apache/maven-shared-utils/pull/85#issuecomment-826135482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] mthmulders commented on pull request #107: [GitHub CI] Use the loopback address for connecting to an in-process web server
mthmulders commented on pull request #107: URL: https://github.com/apache/maven-integration-testing/pull/107#issuecomment-826294054 Thank you for your efforts, @michael-o. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] MartinKanters commented on pull request #85: Javadoc cleanup in preparation of release
MartinKanters commented on pull request #85: URL: https://github.com/apache/maven-shared-utils/pull/85#issuecomment-826547997 > > Did you remove the default messages on these methods on purpose? If so, don't you think it adds value? > > The remarks like "By default, bold cyan" refer to one particular implementation (the `AnsiMessageBuilder`) but they may not apply to other implementations (such as the `PlainMessageBuilder`). The interface should refrain from describing such implementation details, I would argue. Right, makes sense to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] Dufgui commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
Dufgui commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-826356676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders closed pull request #468: Please ignore me
mthmulders closed pull request #468: URL: https://github.com/apache/maven/pull/468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #470: Mng 6294
michael-o commented on a change in pull request #470:
URL: https://github.com/apache/maven/pull/470#discussion_r619893688
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/MavenPluginValidator.java
##
@@ -19,63 +19,16 @@
* under the License.
*/
-import java.util.ArrayList;
import java.util.List;
-
import org.apache.maven.artifact.Artifact;
import org.apache.maven.plugin.descriptor.PluginDescriptor;
/**
* MavenPluginValidator
*/
-public class MavenPluginValidator
+public interface MavenPluginValidator
{
-private final Artifact pluginArtifact;
-
-private List errors = new ArrayList<>();
-
-private boolean firstDescriptor = true;
-
-public MavenPluginValidator( Artifact pluginArtifact )
-{
-this.pluginArtifact = pluginArtifact;
-}
-
-public void validate( PluginDescriptor pluginDescriptor )
-{
-/*
- * NOTE: For plugins that depend on other plugin artifacts the plugin
realm contains more than one plugin
- * descriptor. However, only the first descriptor is of interest.
- */
-if ( !firstDescriptor )
Review comment:
How is this solved after removal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] asfgit closed pull request #96: [MRESOLVER-170] Deprecate org.eclipse.aether.spi.log
asfgit closed pull request #96: URL: https://github.com/apache/maven-resolver/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0
michael-o commented on a change in pull request #469:
URL: https://github.com/apache/maven/pull/469#discussion_r619864958
##
File path: apache-maven/src/assembly/shared/mvnwDebug
##
@@ -27,7 +27,11 @@
# MAVEN_SKIP_RC (Optional) Flag to disable loading of mavenrc files.
# -
-MAVEN_DEBUG_OPTS="-Xdebug
-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=0.0.0.0:8000"
+if [ -z "${MAVEN_DEBUG_HOST}" ]; then
+MAVEN_DEBUG_HOST='localhost'
Review comment:
Rather use `${...:-DEFAULT_VALUE}`.
##
File path: apache-maven/src/assembly/shared/mvnwDebug
##
@@ -27,7 +27,11 @@
# MAVEN_SKIP_RC (Optional) Flag to disable loading of mavenrc files.
# -
-MAVEN_DEBUG_OPTS="-Xdebug
-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=0.0.0.0:8000"
+if [ -z "${MAVEN_DEBUG_HOST}" ]; then
+MAVEN_DEBUG_HOST='localhost'
Review comment:
I don't agree:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on pull request #62: [MJAVADOC-660] - No periods without complete sentences in @param fixes
rfscholte commented on pull request #62: URL: https://github.com/apache/maven-javadoc-plugin/pull/62#issuecomment-826074972 Merged with https://github.com/apache/maven-javadoc-plugin/commit/d4c10752a85024d50db1f36caf1098f966f4bf2a Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] asfgit closed pull request #107: [GitHub CI] Use the loopback address for connecting to an in-process web server
asfgit closed pull request #107: URL: https://github.com/apache/maven-integration-testing/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] mkarg commented on pull request #90: [MSHADE-382] - Add property to skip execution
mkarg commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-826072860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on pull request #58: MJAVADOC-661: Fix for tagletArtifact fails to scan multi-release JARs (MRJARs) for Taglets
rfscholte commented on pull request #58: URL: https://github.com/apache/maven-javadoc-plugin/pull/58#issuecomment-826129275 Merged with https://github.com/apache/maven-javadoc-plugin/commit/981ac787ef2339dca42cbd2fe624a013bf5f810e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on pull request #34: [MJAVADOC-628] - add javadoc.io link pattern when option is …
rfscholte commented on pull request #34: URL: https://github.com/apache/maven-javadoc-plugin/pull/34#issuecomment-826088500 Closing this PR as this is based on the fixed third party URL. Will need to work on a dynamic solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte closed pull request #59: [MJAVADOC-662] The fix operation wrongly generate illegal javadoc for static final fields.
rfscholte closed pull request #59: URL: https://github.com/apache/maven-javadoc-plugin/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte closed pull request #62: [MJAVADOC-660] - No periods without complete sentences in @param fixes
rfscholte closed pull request #62: URL: https://github.com/apache/maven-javadoc-plugin/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] rfscholte commented on pull request #90: [MSHADE-382] - Add property to skip execution
rfscholte commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-826086792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on pull request #66: Added code block to README
rfscholte commented on pull request #66: URL: https://github.com/apache/maven-javadoc-plugin/pull/66#issuecomment-826087314 Actually, most people moved from IRC to the `#maven` on https://the-asf.slack.com/ , it is probably time to remove IRC as official channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #107: [GitHub CI] Use the loopback address for connecting to an in-process web server
michael-o commented on pull request #107: URL: https://github.com/apache/maven-integration-testing/pull/107#issuecomment-826140003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] stephenc commented on pull request #90: [MSHADE-382] - Add property to skip execution
stephenc commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-826128207 If @rfscholte is coming from the view that command line arguments shouldn't affect the built artifact... (which I agree with) and if robert intends to put energy behind making that happen... then I'm against adding technical debt (which this parameter would be introducing) If robert is not prepared to put energy behind removing the other skip properties and starting to flag warnings if your pom dependency versions are controlled by a property... then from a pragmatist view let's add the tech debt. Really a question of where Robert is preparing to spend his energy as to whether I think we should merge or not -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte closed pull request #34: [MJAVADOC-628] - add javadoc.io link pattern when option is …
rfscholte closed pull request #34: URL: https://github.com/apache/maven-javadoc-plugin/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] asfgit closed pull request #77: [MRESOLVER-145] SyncContext implementations
asfgit closed pull request #77: URL: https://github.com/apache/maven-resolver/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on pull request #59: [MJAVADOC-662] The fix operation wrongly generate illegal javadoc for static final fields.
rfscholte commented on pull request #59: URL: https://github.com/apache/maven-javadoc-plugin/pull/59#issuecomment-826084467 Merged with https://github.com/apache/maven-javadoc-plugin/commit/e7a3fe0ed8d7be61de9cc458751b5a24f640fba8 Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
