[jira] [Created] (MSHARED-988) Sanitize dependencies
Tamás Cservenák created MSHARED-988: --- Summary: Sanitize dependencies Key: MSHARED-988 URL: https://issues.apache.org/jira/browse/MSHARED-988 Project: Maven Shared Components Issue Type: Task Components: maven-common-artifact-filters Reporter: Tamás Cservenák Sanitize dependencies: Among dependencies there are doubled artifacts (org.eclipse.aether vs apache.maven.resolver), clean this up. Pull changes for shared-utils (update dependency) to that with MSHARED-983 applied. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-common-artifact-filters] cstamas commented on a change in pull request #17: Sanitize dependencies
cstamas commented on a change in pull request #17:
URL:
https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623622953
##
File path: pom.xml
##
@@ -98,59 +98,45 @@
org.apache.maven
maven-artifact
${maven.version}
+ provided
org.apache.maven
maven-model
${maven.version}
+ provided
org.apache.maven
maven-core
${maven.version}
+ provided
-
- org.apache.maven
- maven-plugin-api
- ${maven.version}
-
+
commons-io
commons-io
2.6
-
- org.eclipse.aether
- aether-api
- ${aether.version}
-
-
- org.eclipse.aether
- aether-util
- ${aether.version}
-
-
- org.eclipse.sisu
- org.eclipse.sisu.plexus
- 0.0.0.M5
-
+
+
org.apache.maven.resolver
maven-resolver-api
- 1.4.2
+ ${resolver.version}
provided
org.apache.maven.resolver
maven-resolver-util
- 1.4.2
+ ${resolver.version}
provided
org.apache.maven.shared
maven-shared-utils
- 3.3.3
+ 3.3.5-SNAPSHOT
Review comment:
Sure, just FTR this PR depends on
https://github.com/apache/maven-shared-utils/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEPLOY-284) Enhance deploy plugin to use new maven resolver implementation for sha256/sha512 digests
[ https://issues.apache.org/jira/browse/MDEPLOY-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337081#comment-17337081 ] David Milet commented on MDEPLOY-284: - I think you can close this request as invalid. Apparently, the maven-deploy plugin already uses the resolver. adding -Daether.checksums.algorithms="SHA-256,SHA-512" to the maven option works. > Enhance deploy plugin to use new maven resolver implementation for > sha256/sha512 digests > > > Key: MDEPLOY-284 > URL: https://issues.apache.org/jira/browse/MDEPLOY-284 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy, deploy:deploy-file >Affects Versions: 3.0.0-M1 >Reporter: David Milet >Priority: Critical > > Maven resolver now supports generation of sha256/sha512 digests. > It seems deploy plugin uses artifact transfer implementation, and generates > only md5 and sha1 digests. > This is an enhancement request to update code to use maven resolver to upload > artifacts to remote repository with sha256/sha512 digests -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MDEPLOY-284) Enhance deploy plugin to use new maven resolver implementation for sha256/sha512 digests
[ https://issues.apache.org/jira/browse/MDEPLOY-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Milet updated MDEPLOY-284: Priority: Trivial (was: Critical) > Enhance deploy plugin to use new maven resolver implementation for > sha256/sha512 digests > > > Key: MDEPLOY-284 > URL: https://issues.apache.org/jira/browse/MDEPLOY-284 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy, deploy:deploy-file >Affects Versions: 3.0.0-M1 >Reporter: David Milet >Priority: Trivial > > Maven resolver now supports generation of sha256/sha512 digests. > It seems deploy plugin uses artifact transfer implementation, and generates > only md5 and sha1 digests. > This is an enhancement request to update code to use maven resolver to upload > artifacts to remote repository with sha256/sha512 digests -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MDEPLOY-284) Enhance deploy plugin to use new maven resolver implementation for sha256/sha512 digests
[ https://issues.apache.org/jira/browse/MDEPLOY-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Milet updated MDEPLOY-284: Summary: Enhance deploy plugin to use new maven resolver implementation for sha256/sha512 digests (was: Enhance deploy plugin to use new maven resolver implementation for sha256/sha256 digests) > Enhance deploy plugin to use new maven resolver implementation for > sha256/sha512 digests > > > Key: MDEPLOY-284 > URL: https://issues.apache.org/jira/browse/MDEPLOY-284 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy, deploy:deploy-file >Affects Versions: 3.0.0-M1 >Reporter: David Milet >Priority: Critical > > Maven resolver now supports generation of sha256/sha512 digests. > It seems deploy plugin uses artifact transfer implementation, and generates > only md5 and sha1 digests. > This is an enhancement request to update code to use maven resolver to upload > artifacts to remote repository with sha256/sha512 digests -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MDEPLOY-284) Enhance deploy plugin to use new maven resolver implementation for sha256/sha256 digests
David Milet created MDEPLOY-284: --- Summary: Enhance deploy plugin to use new maven resolver implementation for sha256/sha256 digests Key: MDEPLOY-284 URL: https://issues.apache.org/jira/browse/MDEPLOY-284 Project: Maven Deploy Plugin Issue Type: Improvement Components: deploy:deploy, deploy:deploy-file Affects Versions: 3.0.0-M1 Reporter: David Milet Maven resolver now supports generation of sha256/sha512 digests. It seems deploy plugin uses artifact transfer implementation, and generates only md5 and sha1 digests. This is an enhancement request to update code to use maven resolver to upload artifacts to remote repository with sha256/sha512 digests -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1787) Support multiple runners (JUnit4, TestNG, other) and their API in JUnit5 Provider
[ https://issues.apache.org/jira/browse/SUREFIRE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335809#comment-17335809 ] Jesse Glick commented on SUREFIRE-1787: --- Appears to have caused a regression: SUREFIRE-1911 > Support multiple runners (JUnit4, TestNG, other) and their API in JUnit5 > Provider > - > > Key: SUREFIRE-1787 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1787 > Project: Maven Surefire > Issue Type: Improvement > Components: JUnit 5.x support, Maven Failsafe Plugin, Maven Surefire > Plugin >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SUREFIRE-1911) Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
Jesse Glick created SUREFIRE-1911:
-
Summary: Groovy-based JUnit 4 tests no longer run w/ 5 in classpath
Key: SUREFIRE-1911
URL: https://issues.apache.org/jira/browse/SUREFIRE-1911
Project: Maven Surefire
Issue Type: Bug
Components: Junit 4.x support, Maven Surefire Plugin
Affects Versions: 3.0.0-M5
Reporter: Jesse Glick
Using Maven 3.8.1 and JDK 8,
https://github.com/jenkins-infra/pipeline-library/commit/48fc69bdd3f7e3adbebea76b8bf68edfe5ed3e32
causes {{mvn test}} to not do anything:
{code:none}
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
{code}
In 3.0.0-M3, or for that matter 3.0.0-M4, this runs a variety of tests as
expected. {{git bisect}} points to the fix of SUREFIRE-1787 as the culprit:
{code:none}
d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041 is the first bad commit
commit d5bbb3f9ae37ff5ad2bb7e8b3c11d1f24ea6f041
Author: tibordigana
Date: Sat May 2 13:08:16 2020 +0200
[SUREFIRE-1787] Support multiple runners (JUnit4, TestNG, other) and their
API in JUnit5 Provider
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-common-artifact-filters] elharo commented on a change in pull request #17: Sanitize dependencies
elharo commented on a change in pull request #17:
URL:
https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623375282
##
File path: pom.xml
##
@@ -98,59 +98,45 @@
org.apache.maven
maven-artifact
${maven.version}
+ provided
org.apache.maven
maven-model
${maven.version}
+ provided
org.apache.maven
maven-core
${maven.version}
+ provided
-
- org.apache.maven
- maven-plugin-api
- ${maven.version}
-
+
commons-io
commons-io
2.6
-
- org.eclipse.aether
- aether-api
- ${aether.version}
-
-
- org.eclipse.aether
- aether-util
- ${aether.version}
-
-
- org.eclipse.sisu
- org.eclipse.sisu.plexus
- 0.0.0.M5
-
+
+
org.apache.maven.resolver
maven-resolver-api
- 1.4.2
+ ${resolver.version}
provided
org.apache.maven.resolver
maven-resolver-util
- 1.4.2
+ ${resolver.version}
provided
org.apache.maven.shared
maven-shared-utils
- 3.3.3
+ 3.3.5-SNAPSHOT
Review comment:
no dependencies on snapshot versions please
##
File path:
src/main/java/org/apache/maven/shared/artifact/filter/ScopeArtifactFilter.java
##
@@ -25,7 +25,7 @@
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.DefaultArtifact;
import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
-import org.codehaus.plexus.logging.Logger;
+import org.slf4j.Logger;
Review comment:
can this change be separated into its own PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #101: [MRESOLVER-153] Make TrackingFileManager use NamedLocks
cstamas commented on pull request #101: URL: https://github.com/apache/maven-resolver/pull/101#issuecomment-829542955 @cstamas note to myself: split this in two: drop SyncContextFactory imples (other than named), and implement locking in TFM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas commented on a change in pull request #17: Sanitize dependencies
cstamas commented on a change in pull request #17: URL: https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623340569 ## File path: pom.xml ## @@ -55,9 +55,9 @@ -3.1.1 7 -0.9.0.M2 +3.1.1 +1.6.2 Review comment: resolver should be binary compatible, at least the used bits, but we can lower if really needed (hopefully not) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] slachiewicz commented on a change in pull request #17: Sanitize dependencies
slachiewicz commented on a change in pull request #17: URL: https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623331483 ## File path: pom.xml ## @@ -55,9 +55,9 @@ -3.1.1 7 -0.9.0.M2 +3.1.1 +1.6.2 Review comment: I'm not sure about minimal resolver version here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas edited a comment on pull request #17: Sanitize dependencies
cstamas edited a comment on pull request #17: URL: https://github.com/apache/maven-common-artifact-filters/pull/17#issuecomment-829442072 Setting maven-* artifacts to provided may affect consumers, so I may revert that change. Still, the presence of maven-plugin-api _assumes_ this artifact is consumed *only by plugins*? As in that case, we can assume plugin do depend on maven-plugin-api, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas edited a comment on pull request #17: Sanitize dependencies
cstamas edited a comment on pull request #17: URL: https://github.com/apache/maven-common-artifact-filters/pull/17#issuecomment-829442072 Setting maven-* artifacts to provided may affect consumers, so I may revert that change. Still, the presence of maven-plugin-api _assumes_ this artifact is consumed *only by plugins*? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas commented on pull request #17: Sanitize dependencies
cstamas commented on pull request #17: URL: https://github.com/apache/maven-common-artifact-filters/pull/17#issuecomment-829442072 Setting maven-* artifacts to provided may affect consumers, so I may revert. Still, the presence of maven-plugin-api _assumes_ this artifact is consumed *only by plugins*? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas opened a new pull request #17: Sanitize dependencies
cstamas opened a new pull request #17: URL: https://github.com/apache/maven-common-artifact-filters/pull/17 Double artifacts (org.eclipse.aether vs maven-resolver) and other. Removed them and it just works. Reordered properties, removed superfluous dependencies. Used snapshot version for maven-shared-utils:3.3.5-SNAPSHOT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] cstamas opened a new pull request #87: Drop plexus container default
cstamas opened a new pull request #87: URL: https://github.com/apache/maven-shared-utils/pull/87 The complete container was only here to make use of AbstractLogEnabled ancient class, that uses ancient logging. Changes: * Drop p-c-d * Reorder deps by scope, test last. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-987) m-a-t: Prepare for future, simplify it
[
https://issues.apache.org/jira/browse/MSHARED-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335485#comment-17335485
]
Tamás Cservenák commented on MSHARED-987:
-
Updated this issue, removed the "drop 3.0 support" for now. It's gonna become a
module, so "drop 3.0" will become "drop the 3.0 module".
> m-a-t: Prepare for future, simplify it
> --
>
> Key: MSHARED-987
> URL: https://issues.apache.org/jira/browse/MSHARED-987
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-artifact-transfer
>Reporter: Tamás Cservenák
>Priority: Major
>
> Overhaul to maven-artifact-transfer:
> * -support only Maven 3.1+ (no sense to support 10 years old legacy)~- gave
> up on this
> * drop use of Plexus completely, switch to JSR330
> * but, be prepare (have indirection in place) for future resolver
> {{org.apache}} rename
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MSHARED-987) m-a-t: Prepare for future, simplify it
[
https://issues.apache.org/jira/browse/MSHARED-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák updated MSHARED-987:
Description:
Overhaul to maven-artifact-transfer:
* -support only Maven 3.1+ (no sense to support 10 years old legacy)~- gave up
on this
* drop use of Plexus completely, switch to JSR330
* but, be prepare (have indirection in place) for future resolver
{{org.apache}} rename
was:
Overhaul to maven-artifact-transfer:
* ~~support only Maven 3.1+ (no sense to support 10 years old legacy)~~ gave
up on this
* drop use of Plexus completely, switch to JSR330
* but, be prepare (have indirection in place) for future resolver
{{org.apache}} rename
> m-a-t: Prepare for future, simplify it
> --
>
> Key: MSHARED-987
> URL: https://issues.apache.org/jira/browse/MSHARED-987
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-artifact-transfer
>Reporter: Tamás Cservenák
>Priority: Major
>
> Overhaul to maven-artifact-transfer:
> * -support only Maven 3.1+ (no sense to support 10 years old legacy)~- gave
> up on this
> * drop use of Plexus completely, switch to JSR330
> * but, be prepare (have indirection in place) for future resolver
> {{org.apache}} rename
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MSHARED-987) m-a-t: Prepare for future, simplify it
[
https://issues.apache.org/jira/browse/MSHARED-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák updated MSHARED-987:
Description:
Overhaul to maven-artifact-transfer:
* ~~support only Maven 3.1+ (no sense to support 10 years old legacy)~~ gave
up on this
* drop use of Plexus completely, switch to JSR330
* but, be prepare (have indirection in place) for future resolver
{{org.apache}} rename
was:
Overhaul to maven-artifact-transfer:
* support only Maven 3.1+ (no sense to support 10 years old legacy)
* drop use of Plexus completely, switch to JSR330
* but, be prepare (have indirection in place) for future resolver
{{org.apache}} rename
> m-a-t: Prepare for future, simplify it
> --
>
> Key: MSHARED-987
> URL: https://issues.apache.org/jira/browse/MSHARED-987
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-artifact-transfer
>Reporter: Tamás Cservenák
>Priority: Major
>
> Overhaul to maven-artifact-transfer:
> * ~~support only Maven 3.1+ (no sense to support 10 years old legacy)~~ gave
> up on this
> * drop use of Plexus completely, switch to JSR330
> * but, be prepare (have indirection in place) for future resolver
> {{org.apache}} rename
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MSHARED-987) m-a-t: Prepare for future, simplify it
[
https://issues.apache.org/jira/browse/MSHARED-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák updated MSHARED-987:
Summary: m-a-t: Prepare for future, simplify it (was: m-a-t: Drop legacy,
prepare for future)
> m-a-t: Prepare for future, simplify it
> --
>
> Key: MSHARED-987
> URL: https://issues.apache.org/jira/browse/MSHARED-987
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-artifact-transfer
>Reporter: Tamás Cservenák
>Priority: Major
>
> Overhaul to maven-artifact-transfer:
> * support only Maven 3.1+ (no sense to support 10 years old legacy)
> * drop use of Plexus completely, switch to JSR330
> * but, be prepare (have indirection in place) for future resolver
> {{org.apache}} rename
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
