[jira] [Updated] (MNG-5987) Document the algorithm calculating the order of plugin executions inside a phase.
[ https://issues.apache.org/jira/browse/MNG-5987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-5987: --- Description: Users continuously report issues regarding the order of plugin executions: repeating that *"this order is not expected to be guaranteed inside a phase"* is not convincing for them. The algorithm used to calculate the order of executions performed by Maven needs to be documented: - declaration order in the POM - inheritance merging from parent POM, - merging of profiles and other plugin containers, - the order of executions of multiple executions in the same lifecycle phase, etc. based on Model Building https://maven.apache.org/ref/current/maven-model-builder/ ... was: Users continuously report issues regarding the order of plugin executions: repeating that this order is not expected to be guaranteed inside a phase is not convincing for them. The algorithm used to calculate the order of executions performed by Maven needs to be documented: - declaration order in the POM - inheritance merging from parent POM, - merging of profiles and other plugin containers, - the order of executions of multiple executions in the same lifecycle phase, etc. > Document the algorithm calculating the order of plugin executions inside a > phase. > - > > Key: MNG-5987 > URL: https://issues.apache.org/jira/browse/MNG-5987 > Project: Maven > Issue Type: Improvement > Components: Documentation: General >Reporter: Christian Schulte >Priority: Critical > > Users continuously report issues regarding the order of plugin executions: > repeating that *"this order is not expected to be guaranteed inside a phase"* > is not convincing for them. > The algorithm used to calculate the order of executions performed by Maven > needs to be documented: > - declaration order in the POM > - inheritance merging from parent POM, > - merging of profiles and other plugin containers, > - the order of executions of multiple executions in the same lifecycle phase, > etc. > based on Model Building > https://maven.apache.org/ref/current/maven-model-builder/ ... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-5987) Document the algorithm calculating the order of plugin executions inside a phase.
[ https://issues.apache.org/jira/browse/MNG-5987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-5987: --- Description: Users continuously report issues regarding the order of plugin executions: repeating that *"this order is not expected to be guaranteed inside a phase"* is not convincing for them. The algorithm used to calculate the order of executions performed by Maven needs to be documented: - declaration order in the POM - inheritance merging from parent POM, - merging of profiles and other plugin containers, - the order of executions of multiple executions in the same lifecycle phase, etc. based on Model Building https://maven.apache.org/ref/current/maven-model-builder/ ... was: Users continuously report issues regarding the order of plugin executions: repeating that *"this order is not expected to be guaranteed inside a phase"* is not convincing for them. The algorithm used to calculate the order of executions performed by Maven needs to be documented: - declaration order in the POM - inheritance merging from parent POM, - merging of profiles and other plugin containers, - the order of executions of multiple executions in the same lifecycle phase, etc. based on Model Building https://maven.apache.org/ref/current/maven-model-builder/ ... > Document the algorithm calculating the order of plugin executions inside a > phase. > - > > Key: MNG-5987 > URL: https://issues.apache.org/jira/browse/MNG-5987 > Project: Maven > Issue Type: Improvement > Components: Documentation: General >Reporter: Christian Schulte >Priority: Critical > > Users continuously report issues regarding the order of plugin executions: > repeating that *"this order is not expected to be guaranteed inside a phase"* > is not convincing for them. > The algorithm used to calculate the order of executions performed by Maven > needs to be documented: > - declaration order in the POM > - inheritance merging from parent POM, > - merging of profiles and other plugin containers, > - the order of executions of multiple executions in the same lifecycle phase, > etc. > based on Model Building > https://maven.apache.org/ref/current/maven-model-builder/ ... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-5987) Document the algorithm calculating the order of plugin executions inside a phase.
[ https://issues.apache.org/jira/browse/MNG-5987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-5987: --- Summary: Document the algorithm calculating the order of plugin executions inside a phase. (was: Document the algorithm calculating the order of plugin executions.) > Document the algorithm calculating the order of plugin executions inside a > phase. > - > > Key: MNG-5987 > URL: https://issues.apache.org/jira/browse/MNG-5987 > Project: Maven > Issue Type: Improvement > Components: Documentation: General >Reporter: Christian Schulte >Priority: Critical > > Users continuously report issues regarding the order of plugin executions: > repeating that this order is not expected to be guaranteed inside a phase is > not convincing for them. > The algorithm used to calculate the order of executions performed by Maven > needs to be documented: > - declaration order in the POM > - inheritance merging from parent POM, > - merging of profiles and other plugin containers, > - the order of executions of multiple executions in the same lifecycle phase, > etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-indexer] dependabot[bot] opened a new pull request #106: Bump checkstyle from 8.41.1 to 8.42
dependabot[bot] opened a new pull request #106: URL: https://github.com/apache/maven-indexer/pull/106 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.41.1 to 8.42. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-8.42 https://checkstyle.org/releasenotes.html#Release_8.42;>https://checkstyle.org/releasenotes.html#Release_8.42 Commits https://github.com/checkstyle/checkstyle/commit/10a3a0777ced10983ebe6266c998957c10dba8f0;>10a3a07 [maven-release-plugin] prepare release checkstyle-8.42 https://github.com/checkstyle/checkstyle/commit/a66fa89891944d46e33a2b5365d0407791355bdd;>a66fa89 doc: release notes 8.42 https://github.com/checkstyle/checkstyle/commit/797bef246535c549917ad3e78abd527c38d8a58a;>797bef2 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/9469;>#9469: Update example of AST for TokenTypes.LITERAL_CLASS https://github.com/checkstyle/checkstyle/commit/21ef1ae6e15433470c25342e5cd1e6b00c8f07da;>21ef1ae dependency: bump equalsverifier from 3.5.5 to 3.6 https://github.com/checkstyle/checkstyle/commit/532603e9005139061c595feb3567ef1ad011aa4a;>532603e Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/9496;>#9496: update code example of AST for TokenTypes.LITERAL_SWITCH https://github.com/checkstyle/checkstyle/commit/69a6a6aaf2f6986862e15a3e8e720163fb34da72;>69a6a6a dependency: bump maven-jxr-plugin from 3.0.0 to 3.1.1 https://github.com/checkstyle/checkstyle/commit/d41327b26bf531f916616e772c6f851bcfe1480e;>d41327b dependency: bump pitest-maven from 1.6.4 to 1.6.5 https://github.com/checkstyle/checkstyle/commit/5e270a5647ecb31f1738e232e255568d487220a2;>5e270a5 dependency: bump ant from 1.10.9 to 1.10.10 https://github.com/checkstyle/checkstyle/commit/d8be8dd28494735688c349f53f5f9e485cf67795;>d8be8dd dependency: bump guava from 30.0-jre to 30.1.1-jre https://github.com/checkstyle/checkstyle/commit/75a36a1a039ad1fe95fb02d7177b087313adc07b;>75a36a1 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/9498;>#9498: add code example of AST for TokenTypes.LITERAL_THIS Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.41.1...checkstyle-8.42;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] slachiewicz merged pull request #104: Bump checkstyle from 8.41.1 to 8.42
slachiewicz merged pull request #104: URL: https://github.com/apache/maven-indexer/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWAR-441) Allow "outdatedCheckPath" parameter to be set to cover web app dir root (everything in the web app directory)
[ https://issues.apache.org/jira/browse/MWAR-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340316#comment-17340316 ] Scott Kurz commented on MWAR-441: - Opened PR: [https://github.com/apache/maven-war-plugin/pull/19] Using char of "/" as special root path.. open to other ideas. The "*" reads better in XML.. though would be worse if it were exposed via a -D property, (though most of these parms aren't exposed as properties it seems). > Allow "outdatedCheckPath" parameter to be set to cover web app dir root > (everything in the web app directory) > - > > Key: MWAR-441 > URL: https://issues.apache.org/jira/browse/MWAR-441 > Project: Maven WAR Plugin > Issue Type: Improvement >Affects Versions: 3.3.1 >Reporter: Scott Kurz >Priority: Minor > > I would like to subject something copied to the WAR root, e.g. a JSP to the > same "outdated" check for goals like *war:exploded* . > I don't see a way to do that currently. An empty String or absent config > value triggers the default of *WEB-INF/lib/* > I'm not too familiar with mojo File-typed parameters. Is there a construct > or pattern that lets you use either a relative or absolute path like you can > with the *webappDirectory, warSourceDirectory* parameters, but relative to > the webappDirectory rather than basedir? > E.g. for *warSourceDirectory* I can specify: *src/main/webapp* or an > absolute path. If I could do something like that for *outdatedCheckPath* > today that would meet my needs. But maybe this parameter resolution only > works conveniently relative to the basedir? > > If this parameter must remain a "prefix" or path relative to the > webappDirectory, maybe it just needs a special syntax like '.' or '*' to > cover everything. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-war-plugin] scottkurz opened a new pull request #19: [MWAR-441] - Allow "outdatedCheckPath" parameter to be set to cover web app dir root (everything in the web app directory)
scottkurz opened a new pull request #19: URL: https://github.com/apache/maven-war-plugin/pull/19 Following this checklist to help us incorporate your contribution quickly and easily: - [X ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWAR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MWAR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MWAR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MASSEMBLY-952) Add support for GZIP-ing an existing TAR file
[ https://issues.apache.org/jira/browse/MASSEMBLY-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340303#comment-17340303 ] Steven Paligo edited comment on MASSEMBLY-952 at 5/6/21, 4:41 PM: -- I use Maven to build my code into Docker images. Docker saves its images as TAR files, which can be quite large. I would like to use the Assembly plugin to GZIP the tarball so it is a more manageable size. I'd argue that is an assembly and within scope. was (Author: spaligo): I use Maven to build my code into Docker images. Docker saves its images as TAR files, which can be quite large. I would like to use the Assembly plugin to GZIP the tarball. I'd argue that is an assembly and within scope. > Add support for GZIP-ing an existing TAR file > - > > Key: MASSEMBLY-952 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-952 > Project: Maven Assembly Plugin > Issue Type: New Feature >Affects Versions: 3.3.0 >Reporter: Steven Paligo >Priority: Major > > The Maven Assembly Plugin allows the user to create a TAR file and GZIP it > (using the "tar.gz" format). However it doesn't support GZIP-ing an existing > TAR file. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MASSEMBLY-952) Add support for GZIP-ing an existing TAR file
[ https://issues.apache.org/jira/browse/MASSEMBLY-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340303#comment-17340303 ] Steven Paligo commented on MASSEMBLY-952: - I use Maven to build my code into Docker images. Docker saves its images as TAR files, which can be quite large. I would like to use the Assembly plugin to GZIP the tarball. I'd argue that is an assembly and within scope. > Add support for GZIP-ing an existing TAR file > - > > Key: MASSEMBLY-952 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-952 > Project: Maven Assembly Plugin > Issue Type: New Feature >Affects Versions: 3.3.0 >Reporter: Steven Paligo >Priority: Major > > The Maven Assembly Plugin allows the user to create a TAR file and GZIP it > (using the "tar.gz" format). However it doesn't support GZIP-ing an existing > TAR file. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-indexer] carlspring commented on pull request #104: Bump checkstyle from 8.41.1 to 8.42
carlspring commented on pull request #104: URL: https://github.com/apache/maven-indexer/pull/104#issuecomment-833648399 This looks safe to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on pull request #77: [MJAVADOC-642] do not try to read from links in offline mode.
rfscholte commented on pull request #77: URL: https://github.com/apache/maven-javadoc-plugin/pull/77#issuecomment-833562277 Please don't split the check for package-list and element-list. If there's no element-list you shouldn't log, as the package-list could exist. Only if oth are missing, there's a reason to log. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-gpg-plugin] bmarwell commented on a change in pull request #11: [MGPG-81] check format in constructor
bmarwell commented on a change in pull request #11:
URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r627420794
##
File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java
##
@@ -32,54 +32,46 @@
*/
public class GpgVersion implements Comparable
{
-private final String rawVersion;
-private GpgVersion( String rawVersion )
-{
-this.rawVersion = rawVersion;
-}
+private static final Pattern VERSION_PATTERN = Pattern.compile(
"(\\d+\\.)+(\\d+)" );
Review comment:
Works on mac, too:
```
$ gpgconf --query-swdb gnupg
gnupg:2.2.21:-::32849:::
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MINDEXER-127) Maven repository indexing error: java.nio.channels.OverlappingFileLockException
[ https://issues.apache.org/jira/browse/MINDEXER-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340203#comment-17340203 ] Victor Rubezhny commented on MINDEXER-127: -- A pull-request is created in order to fix the issue. > Maven repository indexing error: > java.nio.channels.OverlappingFileLockException > --- > > Key: MINDEXER-127 > URL: https://issues.apache.org/jira/browse/MINDEXER-127 > Project: Maven Indexer > Issue Type: Bug >Affects Versions: 6.0.0 >Reporter: Victor Rubezhny >Priority: Major > > The `openAndWarmup()` method is invoked twice from `purge()` method of > `org.apache.maven.index.context.DefaultIndexingContext` which results into > `OverlappingFileLockException` during the index re-indexing, because the > `openAndWarmup()` method call creates a `FileLock` for an index and the > second call tries to create and add the second `FileLock` for the same index > which is erroneous: > ``` > java.nio.channels.OverlappingFileLockException > at java.base/sun.nio.ch.FileLockTable.checkList(FileLockTable.java:229) > at java.base/sun.nio.ch.FileLockTable.add(FileLockTable.java:123) > at java.base/sun.nio.ch.FileChannelImpl.tryLock(FileChannelImpl.java:1154) > at java.base/java.nio.channels.FileChannel.tryLock(FileChannel.java:1165) > at > org.apache.maven.index.context.DefaultIndexingContext.unlockForcibly(DefaultIndexingContext.java:927) > at > org.apache.maven.index.context.DefaultIndexingContext.prepareIndex(DefaultIndexingContext.java:244) > at > org.apache.maven.index.context.DefaultIndexingContext.purge(DefaultIndexingContext.java:612) > at > org.eclipse.m2e.core.internal.index.nexus.NexusIndexManager.purgeCurrentIndex(NexusIndexManager.java:529) > at > org.eclipse.m2e.core.internal.index.nexus.NexusIndexManager.reindexWorkspace(NexusIndexManager.java:561) > at > org.eclipse.m2e.core.internal.index.nexus.NexusIndexManager.updateIndex(NexusIndexManager.java:1072) > at > org.eclipse.m2e.core.internal.index.nexus.NexusIndex.updateIndex(NexusIndex.java:147) > at > org.eclipse.m2e.core.ui.internal.preferences.MavenSettingsPreferencePage$2.runInWorkspace(MavenSettingsPreferencePage.java:263) > at > org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:42) > at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63) > ``` > The referencing issue is reported at: > https://github.com/eclipse-m2e/m2e-core/issues/169 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-indexer] vrubezhny opened a new pull request #105: MINDEXER-127: Maven repository indexing error: java.nio.channels.Over…
vrubezhny opened a new pull request #105: URL: https://github.com/apache/maven-indexer/pull/105 …lappingFileLockException The fix prevents the openAndWarmup() method of DefaultIndexingContext to be invoked twice during purge() method call in order to prevent an attempt to lock twice the same incex as this method is invoked from a subsequent prepareIndex() method call. Signed-off-by: Victor Rubezhny -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINDEXER-127) Maven repository indexing error: java.nio.channels.OverlappingFileLockException
Victor Rubezhny created MINDEXER-127: Summary: Maven repository indexing error: java.nio.channels.OverlappingFileLockException Key: MINDEXER-127 URL: https://issues.apache.org/jira/browse/MINDEXER-127 Project: Maven Indexer Issue Type: Bug Affects Versions: 6.0.0 Reporter: Victor Rubezhny The `openAndWarmup()` method is invoked twice from `purge()` method of `org.apache.maven.index.context.DefaultIndexingContext` which results into `OverlappingFileLockException` during the index re-indexing, because the `openAndWarmup()` method call creates a `FileLock` for an index and the second call tries to create and add the second `FileLock` for the same index which is erroneous: ``` java.nio.channels.OverlappingFileLockException at java.base/sun.nio.ch.FileLockTable.checkList(FileLockTable.java:229) at java.base/sun.nio.ch.FileLockTable.add(FileLockTable.java:123) at java.base/sun.nio.ch.FileChannelImpl.tryLock(FileChannelImpl.java:1154) at java.base/java.nio.channels.FileChannel.tryLock(FileChannel.java:1165) at org.apache.maven.index.context.DefaultIndexingContext.unlockForcibly(DefaultIndexingContext.java:927) at org.apache.maven.index.context.DefaultIndexingContext.prepareIndex(DefaultIndexingContext.java:244) at org.apache.maven.index.context.DefaultIndexingContext.purge(DefaultIndexingContext.java:612) at org.eclipse.m2e.core.internal.index.nexus.NexusIndexManager.purgeCurrentIndex(NexusIndexManager.java:529) at org.eclipse.m2e.core.internal.index.nexus.NexusIndexManager.reindexWorkspace(NexusIndexManager.java:561) at org.eclipse.m2e.core.internal.index.nexus.NexusIndexManager.updateIndex(NexusIndexManager.java:1072) at org.eclipse.m2e.core.internal.index.nexus.NexusIndex.updateIndex(NexusIndex.java:147) at org.eclipse.m2e.core.ui.internal.preferences.MavenSettingsPreferencePage$2.runInWorkspace(MavenSettingsPreferencePage.java:263) at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:42) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63) ``` The referencing issue is reported at: https://github.com/eclipse-m2e/m2e-core/issues/169 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #11: [MGPG-81] check format in constructor
Syquel commented on a change in pull request #11:
URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r627387383
##
File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java
##
@@ -32,54 +32,46 @@
*/
public class GpgVersion implements Comparable
{
-private final String rawVersion;
-private GpgVersion( String rawVersion )
-{
-this.rawVersion = rawVersion;
-}
+private static final Pattern VERSION_PATTERN = Pattern.compile(
"(\\d+\\.)+(\\d+)" );
Review comment:
It might be even better to use `gpgconf --query-swdb gnupg` instead of
`gpg --version`, because gpgconf returns [machine-readable
output](https://github.com/gpg/gnupg/blob/master/tools/gpgconf.c#L360).
> $ gpgconf --query-swdb gnupg
> gnupg:2.2.27:-::32849:::
although I don't know if that would work with all distributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] bmarwell opened a new pull request #77: [MJAVADOC-642] do not try to read from links in offline mode.
bmarwell opened a new pull request #77: URL: https://github.com/apache/maven-javadoc-plugin/pull/77 - output error stack traces in debug mode. Pulled out a trimmed-lowercase-link variable for readability and added a null check which oddly occured after creating this PR. Please note that not even the non-integration-tests can be run behind a proxy. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-docck-plugin] timtebeek commented on pull request #1: [MDOCCK-35] - Upgrade Http Client
timtebeek commented on pull request #1: URL: https://github.com/apache/maven-docck-plugin/pull/1#issuecomment-833469892 Posted some comments in the issue, which might be best to repeat here to ensure they're seen before a merge: > Had to move HttpClient builder to execute method, as proxy setup was in execute. > Following redirects seems to be the default, hence no direct 1 to 1 replacement for that. > The only thing I couldn't work out a direct parallel for was preemptive authentication with the proxy. There might be some hints in here if that's still needed: https://github.com/apache/httpcomponents-client/blob/5.0.x/httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientPreemptiveBasicAuthentication.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #11: [MGPG-81] check format in constructor
Syquel commented on a change in pull request #11:
URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r627354122
##
File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java
##
@@ -32,54 +32,46 @@
*/
public class GpgVersion implements Comparable
{
-private final String rawVersion;
-private GpgVersion( String rawVersion )
-{
-this.rawVersion = rawVersion;
-}
+private static final Pattern VERSION_PATTERN = Pattern.compile(
"(\\d+\\.)+(\\d+)" );
Review comment:
There are two patterns AFAIK: One in
[GpgVersionParser.GpgVersionConsumer](https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/GpgVersionParser.java#L113)
and this one here.
This one could possibly be removed and `GpgVersionParser.GpgVersionConsumer`
could pass the extracted version number to `GpgVersion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-gpg-plugin] Tibor17 commented on a change in pull request #11: [MGPG-81] check format in constructor
Tibor17 commented on a change in pull request #11:
URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r627307690
##
File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java
##
@@ -32,54 +32,46 @@
*/
public class GpgVersion implements Comparable
{
-private final String rawVersion;
-private GpgVersion( String rawVersion )
-{
-this.rawVersion = rawVersion;
-}
+private static final Pattern VERSION_PATTERN = Pattern.compile(
"(\\d+\\.)+(\\d+)" );
Review comment:
@Syquel
@elharo
How many times these patterns exist in the project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340121#comment-17340121
]
Benjamin Marwell commented on MJAVADOC-642:
---
Here is a sampel configuration:
{code:xml}
http://docs.oracle.com/javase/7/docs/api
http://static.netty.io/3.5/api
http://google-guice.googlecode.com/git/javadoc
http://fasterxml.github.com/jackson-databind/javadoc/2.0.4
https://developers.google.com/protocol-buffers/docs/reference/java
true
true
true
true
true
{code}
Output behind proxy:
{code}
[WARN] Error fetching link:
https://github.com/javaee/jaxb-spec/jaxb-api/apidocs. Ignored it.
[WARN] Error fetching link: http://www.slf4j.org/apidocs. Ignored it.
[WARN] Error fetching link: http://findbugs.sourceforge.net/apidocs. Ignored it.
[WARN] Error fetching link: http://cdi-spec.org/apidocs. Ignored it.
[WARN] Error fetching link: http://www.jqno.nl/equalsverifier/apidocs. Ignored
it.
[WARN] Error fetching link: https://checkerframework.org/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: http://hamcrest.org/JavaHamcrest/apidocs. Ignored
it.
[WARN] Error fetching link: https://github.com/mockito/mockito/apidocs. Ignored
it.
{code}
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MJAVADOC-642) Setting maven.javadoc.isoffline seems to have no effect
[
https://issues.apache.org/jira/browse/MJAVADOC-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340121#comment-17340121
]
Benjamin Marwell edited comment on MJAVADOC-642 at 5/6/21, 9:49 AM:
Here is a sample configuration:
{code:xml}
http://docs.oracle.com/javase/7/docs/api
http://static.netty.io/3.5/api
http://google-guice.googlecode.com/git/javadoc
http://fasterxml.github.com/jackson-databind/javadoc/2.0.4
https://developers.google.com/protocol-buffers/docs/reference/java
true
true
true
true
true
{code}
Output behind proxy:
{code}
[WARN] Error fetching link:
https://github.com/javaee/jaxb-spec/jaxb-api/apidocs. Ignored it.
[WARN] Error fetching link: http://www.slf4j.org/apidocs. Ignored it.
[WARN] Error fetching link: http://findbugs.sourceforge.net/apidocs. Ignored it.
[WARN] Error fetching link: http://cdi-spec.org/apidocs. Ignored it.
[WARN] Error fetching link: http://www.jqno.nl/equalsverifier/apidocs. Ignored
it.
[WARN] Error fetching link: https://checkerframework.org/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: http://hamcrest.org/JavaHamcrest/apidocs. Ignored
it.
[WARN] Error fetching link: https://github.com/mockito/mockito/apidocs. Ignored
it.
{code}
was (Author: mampf86):
Here is a sampel configuration:
{code:xml}
http://docs.oracle.com/javase/7/docs/api
http://static.netty.io/3.5/api
http://google-guice.googlecode.com/git/javadoc
http://fasterxml.github.com/jackson-databind/javadoc/2.0.4
https://developers.google.com/protocol-buffers/docs/reference/java
true
true
true
true
true
{code}
Output behind proxy:
{code}
[WARN] Error fetching link:
https://github.com/javaee/jaxb-spec/jaxb-api/apidocs. Ignored it.
[WARN] Error fetching link: http://www.slf4j.org/apidocs. Ignored it.
[WARN] Error fetching link: http://findbugs.sourceforge.net/apidocs. Ignored it.
[WARN] Error fetching link: http://cdi-spec.org/apidocs. Ignored it.
[WARN] Error fetching link: http://www.jqno.nl/equalsverifier/apidocs. Ignored
it.
[WARN] Error fetching link: https://checkerframework.org/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: http://hamcrest.org/JavaHamcrest/apidocs. Ignored
it.
[WARN] Error fetching link: https://github.com/mockito/mockito/apidocs. Ignored
it.
{code}
> Setting maven.javadoc.isoffline seems to have no effect
> ---
>
> Key: MJAVADOC-642
> URL: https://issues.apache.org/jira/browse/MJAVADOC-642
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.1
>Reporter: Thomas Cunningham
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> I'm trying to work around MJAVADOC-641 and the proxy issues that we are
> having, and I'd like to set isOffline to true. I tried to do this my
> setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't
> seem to take effect. Setting isOffline to true within the
> allows my build to succeed.
> Am I using the wrong command line property for isOffline?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-7080) Add a --color argument
[
https://issues.apache.org/jira/browse/MNG-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340079#comment-17340079
]
Hudson commented on MNG-7080:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #161
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/master/161/
> Add a --color argument
> --
>
> Key: MNG-7080
> URL: https://issues.apache.org/jira/browse/MNG-7080
> Project: Maven
> Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> This would be cleaner than having to use {{-Dstyle.color=xxx}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340075#comment-17340075
]
Hudson commented on MNG-7032:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #162
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/master/162/
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Assignee: Martin Kanters
>Priority: Major
> Labels: easyfix
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-7080) Add a --color argument
[
https://issues.apache.org/jira/browse/MNG-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7080:
Fix Version/s: 4.0.0
> Add a --color argument
> --
>
> Key: MNG-7080
> URL: https://issues.apache.org/jira/browse/MNG-7080
> Project: Maven
> Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> This would be cleaner than having to use {{-Dstyle.color=xxx}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-7079) Upgrade to jansi 2.2.0
[ https://issues.apache.org/jira/browse/MNG-7079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7079: Fix Version/s: 4.0.0 > Upgrade to jansi 2.2.0 > -- > > Key: MNG-7079 > URL: https://issues.apache.org/jira/browse/MNG-7079 > Project: Maven > Issue Type: Improvement >Reporter: Guillaume Nodet >Assignee: Martin Kanters >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7032:
Fix Version/s: 4.0.0
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Assignee: Martin Kanters
>Priority: Major
> Labels: easyfix
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNG-7032) Option -B still showing formatting when used with --version
[
https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters closed MNG-7032.
---
Fix Version/s: (was: 4.0.x-candidate)
4.0.0-alpha-1
Assignee: Martin Kanters
Resolution: Fixed
Thanks for contributing!
> Option -B still showing formatting when used with --version
> ---
>
> Key: MNG-7032
> URL: https://issues.apache.org/jira/browse/MNG-7032
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Logging
>Affects Versions: 3.6.3
> Environment: Running Ubuntu 20.04.1 LTS (Focal Fossa)
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: /opt/java/jdk-11.0.8+10
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-54-generic", arch: "amd64", family: "unix"
>Reporter: Christian Koop
>Assignee: Martin Kanters
>Priority: Major
> Labels: easyfix
> Fix For: 4.0.0-alpha-1
>
>
> When running {{mvn -B --version}} the first line ({{'Apache Maven 3.6.3'}})
> is written in bold although the option {{-B}} should have stripped that as it
> does with color in combination with other options.
> This causes an issue when logging to a file as the ASCII escape sequence is
> written to it in plain text (causing confusion).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNG-7080) Add a --color argument
[
https://issues.apache.org/jira/browse/MNG-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters closed MNG-7080.
---
Fix Version/s: 4.0.0-alpha-1
Assignee: Martin Kanters
Resolution: Fixed
Thanks for contributing!
> Add a --color argument
> --
>
> Key: MNG-7080
> URL: https://issues.apache.org/jira/browse/MNG-7080
> Project: Maven
> Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0-alpha-1
>
>
> This would be cleaner than having to use {{-Dstyle.color=xxx}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] MartinKanters merged pull request #435: [MNG-7032] Evaluate --help and --version after configuring the logging/color
MartinKanters merged pull request #435: URL: https://github.com/apache/maven/pull/435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters merged pull request #436: [MNG-7080] Add a --color option to simplify color support
MartinKanters merged pull request #436: URL: https://github.com/apache/maven/pull/436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
