[GitHub] [maven-invoker-plugin] olamy merged pull request #47: Bump doxiaVersion from 1.9.1 to 1.10
olamy merged pull request #47: URL: https://github.com/apache/maven-invoker-plugin/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] olamy merged pull request #41: Bump maven-project-info-reports-plugin from 3.1.1 to 3.1.2
olamy merged pull request #41: URL: https://github.com/apache/maven-invoker-plugin/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] olamy commented on pull request #48: Bump doxiaSitetoolsVersion from 1.9.2 to 1.10
olamy commented on pull request #48: URL: https://github.com/apache/maven-invoker-plugin/pull/48#issuecomment-894607626 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] olamy commented on pull request #56: Bump maven-enforcer-plugin from 3.0.0-M3 to 3.0.0
olamy commented on pull request #56: URL: https://github.com/apache/maven-invoker-plugin/pull/56#issuecomment-894607601 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] olamy commented on pull request #55: Bump plexus-utils from 3.1.0 to 3.4.0
olamy commented on pull request #55: URL: https://github.com/apache/maven-invoker-plugin/pull/55#issuecomment-894607586 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] olamy opened a new pull request #58: [MINVOKER-274] upgrade to groovy 3.0.8
olamy opened a new pull request #58: URL: https://github.com/apache/maven-invoker-plugin/pull/58 Signed-off-by: Olivier Lamy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-274) Use Groovy 3.x to prevent Java9+ warnings about Groovy 2.x using illegal reflection
[
https://issues.apache.org/jira/browse/MINVOKER-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395093#comment-17395093
]
Olivier Lamy commented on MINVOKER-274:
---
it looks groovy-all 3.0.8 do not have a jar including everything. So we must
use groovy artifactId and add all the jars previously included with using
groovy-all
> Use Groovy 3.x to prevent Java9+ warnings about Groovy 2.x using illegal
> reflection
> ---
>
> Key: MINVOKER-274
> URL: https://issues.apache.org/jira/browse/MINVOKER-274
> Project: Maven Invoker Plugin
> Issue Type: Improvement
> Environment: JDK9+
>Reporter: Bertrand Martin
>Assignee: Olivier Lamy
>Priority: Major
> Labels: Java8
> Fix For: 3.2.3
>
>
> h1. Problem
> Running integration tests with *maven-invoker-plugin* in JDK with version >=
> 9 (incl. OpenJDK 11, 14, 15, etc.) will generate these un-aesthetic messages:
> {noformat}
> [INFO] run post-build script verify.groovy
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.codehaus.groovy.reflection.CachedClass
> (file:/d:/Dev2/maven/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar)
> to method java.lang.Object.clone()
> WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {noformat}
> h1. Specification
> Use Groovy 3.x which solved all illegal accesses that were in 2.x.
> Most current version is:
> {code:xml}
> org.codehaus.groovy
> groovy-all
> 3.0.7
> pom
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MINVOKER-281) Require Java 8
[ https://issues.apache.org/jira/browse/MINVOKER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395073#comment-17395073 ] Hudson commented on MINVOKER-281: - Build failed in Jenkins: Maven » Maven TLP » maven-invoker-plugin » master #61 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-invoker-plugin/job/master/61/ > Require Java 8 > -- > > Key: MINVOKER-281 > URL: https://issues.apache.org/jira/browse/MINVOKER-281 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.2.3 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MINVOKER-274) Use Groovy 3.x to prevent Java9+ warnings about Groovy 2.x using illegal reflection
[
https://issues.apache.org/jira/browse/MINVOKER-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy updated MINVOKER-274:
--
Fix Version/s: (was: next-release)
3.2.3
> Use Groovy 3.x to prevent Java9+ warnings about Groovy 2.x using illegal
> reflection
> ---
>
> Key: MINVOKER-274
> URL: https://issues.apache.org/jira/browse/MINVOKER-274
> Project: Maven Invoker Plugin
> Issue Type: Improvement
> Environment: JDK9+
>Reporter: Bertrand Martin
>Priority: Major
> Labels: Java8
> Fix For: 3.2.3
>
>
> h1. Problem
> Running integration tests with *maven-invoker-plugin* in JDK with version >=
> 9 (incl. OpenJDK 11, 14, 15, etc.) will generate these un-aesthetic messages:
> {noformat}
> [INFO] run post-build script verify.groovy
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.codehaus.groovy.reflection.CachedClass
> (file:/d:/Dev2/maven/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar)
> to method java.lang.Object.clone()
> WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {noformat}
> h1. Specification
> Use Groovy 3.x which solved all illegal accesses that were in 2.x.
> Most current version is:
> {code:xml}
> org.codehaus.groovy
> groovy-all
> 3.0.7
> pom
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MINVOKER-274) Use Groovy 3.x to prevent Java9+ warnings about Groovy 2.x using illegal reflection
[
https://issues.apache.org/jira/browse/MINVOKER-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy reassigned MINVOKER-274:
-
Assignee: Olivier Lamy
> Use Groovy 3.x to prevent Java9+ warnings about Groovy 2.x using illegal
> reflection
> ---
>
> Key: MINVOKER-274
> URL: https://issues.apache.org/jira/browse/MINVOKER-274
> Project: Maven Invoker Plugin
> Issue Type: Improvement
> Environment: JDK9+
>Reporter: Bertrand Martin
>Assignee: Olivier Lamy
>Priority: Major
> Labels: Java8
> Fix For: 3.2.3
>
>
> h1. Problem
> Running integration tests with *maven-invoker-plugin* in JDK with version >=
> 9 (incl. OpenJDK 11, 14, 15, etc.) will generate these un-aesthetic messages:
> {noformat}
> [INFO] run post-build script verify.groovy
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.codehaus.groovy.reflection.CachedClass
> (file:/d:/Dev2/maven/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar)
> to method java.lang.Object.clone()
> WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {noformat}
> h1. Specification
> Use Groovy 3.x which solved all illegal accesses that were in 2.x.
> Most current version is:
> {code:xml}
> org.codehaus.groovy
> groovy-all
> 3.0.7
> pom
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MINVOKER-281) Require Java 8
[ https://issues.apache.org/jira/browse/MINVOKER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy resolved MINVOKER-281. --- Resolution: Fixed > Require Java 8 > -- > > Key: MINVOKER-281 > URL: https://issues.apache.org/jira/browse/MINVOKER-281 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.2.3 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-invoker-plugin] olamy merged pull request #57: [MINVOKER-281] java 8 as minimum
olamy merged pull request #57: URL: https://github.com/apache/maven-invoker-plugin/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-tree] belingueres opened a new pull request #7: MSHARED-994 - fix collect dependencies when artifact has 'war' packaging
belingueres opened a new pull request #7: URL: https://github.com/apache/maven-dependency-tree/pull/7 Added verbose-war IT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHARED-994) DependencyCollectorBuilder does not collect dependencies when artifact has 'war' packaging
Gabriel Belingueres created MSHARED-994: --- Summary: DependencyCollectorBuilder does not collect dependencies when artifact has 'war' packaging Key: MSHARED-994 URL: https://issues.apache.org/jira/browse/MSHARED-994 Project: Maven Shared Components Issue Type: Bug Components: maven-dependency-tree Environment: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /home/gabriel/.sdkman/candidates/maven/current Java version: 1.8.0_232, vendor: AdoptOpenJDK, runtime: /home/gabriel/.sdkman/candidates/java/8.0.232.hs-adpt/jre Default locale: es_AR, platform encoding: UTF-8 OS name: "linux", version: "5.11.0-25-generic", arch: "amd64", family: "unix" Reporter: Gabriel Belingueres The collection graph is empty when project packaging is 'war'. Affected version is 3.1.0 (I can't choose it from the Jira's Create Issue dialog.) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAVADOC-687) Upgrade Jetty Version to last 9.4.x
[ https://issues.apache.org/jira/browse/MJAVADOC-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395019#comment-17395019 ] Hudson commented on MJAVADOC-687: - Build failed in Jenkins: Maven » Maven TLP » maven-javadoc-plugin » master #90 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-javadoc-plugin/job/master/90/ > Upgrade Jetty Version to last 9.4.x > --- > > Key: MJAVADOC-687 > URL: https://issues.apache.org/jira/browse/MJAVADOC-687 > Project: Maven Javadoc Plugin > Issue Type: Task >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MJAVADOC-687) Upgrade Jetty Version to last 9.4.x
[ https://issues.apache.org/jira/browse/MJAVADOC-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy resolved MJAVADOC-687. --- Resolution: Fixed > Upgrade Jetty Version to last 9.4.x > --- > > Key: MJAVADOC-687 > URL: https://issues.apache.org/jira/browse/MJAVADOC-687 > Project: Maven Javadoc Plugin > Issue Type: Task >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-javadoc-plugin] olamy merged pull request #92: [MJAVADOC-687] Upgrade Jetty Version to last 9.4.x
olamy merged pull request #92: URL: https://github.com/apache/maven-javadoc-plugin/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] cquoss commented on pull request #109: [SCM-947]
cquoss commented on pull request #109: URL: https://github.com/apache/maven-scm/pull/109#issuecomment-894525127 Yes. You are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scripting-plugin] rmannibucau commented on a change in pull request #4: [MSCRIPTING-7] binding the session and servers helper in binding context
rmannibucau commented on a change in pull request #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#discussion_r684363382 ## File path: src/main/java/org/apache/maven/plugins/scripting/EvalMojo.java ## @@ -73,8 +84,10 @@ public void execute() AbstractScriptEvaluator execute = constructExecute(); Bindings bindings = new SimpleBindings(); + bindings.put( "session", session ); bindings.put( "project", project ); bindings.put( "log", getLog() ); + bindings.put( "servers", new Servers( session, settingsDecrypter ) ); Review comment: What I want is a Server#password in clear but I don't want to decipher all servers upfront. From what I saw, getSettings() is NOT clear there so I would have to "clearify" it before binding it which I want to avoid so I thought using a lazy simple accessor is more script friendly than exposing the session and letting user use plexus container to do lookups to decipher values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-50) POM element for coding standard/formatting descriptor
[ https://issues.apache.org/jira/browse/MNG-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394755#comment-17394755 ] Delany commented on MNG-50: --- It seems like this should be plugin-specific—where the documentation is the implementation. There will probably be more exceptions than standards anyway. See https://code.revelc.net/formatter-maven-plugin/format-mojo.html > POM element for coding standard/formatting descriptor > - > > Key: MNG-50 > URL: https://issues.apache.org/jira/browse/MNG-50 > Project: Maven > Issue Type: New Feature > Components: FDPFC, POM >Reporter: Jason van Zyl >Priority: Minor > Fix For: Issues to be reviewed for 4.x > > > Add a field to the POM that describes the coding standard used by a project. > This value could then be used to create a link to a standard set of documents > describing the chose coding standard: sun, turbine, gnu or what have you. > This could possibly be combined with some other properties that might > generally control source formatting and verification type plugins like > checkstyle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-scripting-plugin] rfscholte commented on a change in pull request #4: [MSCRIPTING-7] binding the session and servers helper in binding context
rfscholte commented on a change in pull request #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#discussion_r684207177 ## File path: src/main/java/org/apache/maven/plugins/scripting/EvalMojo.java ## @@ -73,8 +84,10 @@ public void execute() AbstractScriptEvaluator execute = constructExecute(); Bindings bindings = new SimpleBindings(); + bindings.put( "session", session ); bindings.put( "project", project ); bindings.put( "log", getLog() ); + bindings.put( "servers", new Servers( session, settingsDecrypter ) ); Review comment: If I understand what you need and staying close to what Maven offers, I think you should focus on `session.getRepositorySession().getAuthenticationSelector().getAuthentication(RemoteRepository)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] michael-o commented on pull request #109: [SCM-947]
michael-o commented on pull request #109: URL: https://github.com/apache/maven-scm/pull/109#issuecomment-894175059 I have merge SCM-948, am I good to review this now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] pzygielo edited a comment on pull request #57: [MINVOKER-281] java 8 as minimum
pzygielo edited a comment on pull request #57: URL: https://github.com/apache/maven-invoker-plugin/pull/57#issuecomment-894162386 As you are changing `InstallMojo.java` anyway, could you consider to fix l. ~651, and remove unused method, please? (came in #5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] pzygielo commented on pull request #57: [MINVOKER-281] java 8 as minimum
pzygielo commented on pull request #57: URL: https://github.com/apache/maven-invoker-plugin/pull/57#issuecomment-894162386 As you are changing `InstallMojo.java` anyway, could you consider to fix l. ~651, and remove unused method, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scripting-plugin] rmannibucau commented on a change in pull request #4: [MSCRIPTING-7] binding the session and servers helper in binding context
rmannibucau commented on a change in pull request #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#discussion_r684098220 ## File path: src/main/java/org/apache/maven/plugins/scripting/EvalMojo.java ## @@ -73,8 +84,10 @@ public void execute() AbstractScriptEvaluator execute = constructExecute(); Bindings bindings = new SimpleBindings(); + bindings.put( "session", session ); bindings.put( "project", project ); bindings.put( "log", getLog() ); + bindings.put( "servers", new Servers( session, settingsDecrypter ) ); Review comment: Do we have it already? I would like to avoid to decipher the whole settings each time (this is done only when needed) because it can slow down the execution a lt for nothing in practise. Happy to wrap it in a MavenScripting wrapper which would expose this kind of API (so script would use mavenScripting.servers.find(...)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] olamy opened a new pull request #57: [MINVOKER-281] java 8 as minimum
olamy opened a new pull request #57: URL: https://github.com/apache/maven-invoker-plugin/pull/57 Signed-off-by: Olivier Lamy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINVOKER-281) Require Java 8
[ https://issues.apache.org/jira/browse/MINVOKER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy reassigned MINVOKER-281: - Assignee: Olivier Lamy > Require Java 8 > -- > > Key: MINVOKER-281 > URL: https://issues.apache.org/jira/browse/MINVOKER-281 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.2.3 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-scripting-plugin] rfscholte commented on pull request #4: [MSCRIPTING-7] binding the session and servers helper in binding context
rfscholte commented on pull request #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-894090842 Don't forget to update https://github.com/apache/maven-scripting-plugin/blob/master/src/site/markdown/script-context.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSCRIPTING-7) Session is not bound in scripting bindings
[ https://issues.apache.org/jira/browse/MSCRIPTING-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated MSCRIPTING-7: Labels: pull-request-available (was: ) > Session is not bound in scripting bindings > -- > > Key: MSCRIPTING-7 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-7 > Project: Maven Scripting > Issue Type: Task >Affects Versions: 3.0.0 >Reporter: Romain Manni-Bucau >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-scripting-plugin] rfscholte commented on a change in pull request #4: [MSCRIPTING-7] binding the session and servers helper in binding context
rfscholte commented on a change in pull request #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#discussion_r684042106 ## File path: src/main/java/org/apache/maven/plugins/scripting/EvalMojo.java ## @@ -73,8 +84,10 @@ public void execute() AbstractScriptEvaluator execute = constructExecute(); Bindings bindings = new SimpleBindings(); + bindings.put( "session", session ); bindings.put( "project", project ); bindings.put( "log", getLog() ); + bindings.put( "servers", new Servers( session, settingsDecrypter ) ); Review comment: I have doubts about this one, `servers` has never been used as a variable. Better to stick to `settings` with resolved values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNGSITE-457) Typo in "Maven in 30 minutes"-tutorial
[
https://issues.apache.org/jira/browse/MNGSITE-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Wollmann updated MNGSITE-457:
--
Description:
The official Maven turial page
([Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources])
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial. Currently, the provided
file tree is confusing because of its inconsistency.
was:
The official Maven turial page
([Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources])
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
> Typo in "Maven in 30 minutes"-tutorial
> --
>
> Key: MNGSITE-457
> URL: https://issues.apache.org/jira/browse/MNGSITE-457
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Alex Wollmann
>Priority: Trivial
>
> The official Maven turial page
> ([Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources])
> contains the following symbolized file tree:
> {code:java}
> my-app
> |-- pom.xml
> `-- src
> |-- main
> | |-- java
> | | `-- com
> | | `-- mycompany
> | | `-- app
> | | `-- App.java
> | `-- resources
> | `-- META-INF
> | |-- application.properties
> `-- test
> |-- java
> | `-- com
> | `-- mycompany
> | `-- app
> | `-- AppTest.java
> `-- resources
> `-- test.properties
> {code}
>
> The pipe symbol in line 12 should be removed by a backtick in order to match
> the formatting that is used throughout the tutorial. Currently, the provided
> file tree is confusing because of its inconsistency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNGSITE-457) Typo in "Maven in 30 minutes"-tutorial
[
https://issues.apache.org/jira/browse/MNGSITE-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Wollmann updated MNGSITE-457:
--
Description:
The turial page
([Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources])
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
was:
The turial page
[Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources]
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
> Typo in "Maven in 30 minutes"-tutorial
> --
>
> Key: MNGSITE-457
> URL: https://issues.apache.org/jira/browse/MNGSITE-457
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Alex Wollmann
>Priority: Trivial
>
> The turial page
> ([Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources])
> contains the following symbolized file tree:
> {code:java}
> my-app
> |-- pom.xml
> `-- src
> |-- main
> | |-- java
> | | `-- com
> | | `-- mycompany
> | | `-- app
> | | `-- App.java
> | `-- resources
> | `-- META-INF
> | |-- application.properties
> `-- test
> |-- java
> | `-- com
> | `-- mycompany
> | `-- app
> | `-- AppTest.java
> `-- resources
> `-- test.properties
> {code}
>
> The pipe symbol in line 12 should be removed by a backtick in order to match
> the formatting that is used throughout the tutorial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNGSITE-457) Typo in "Maven in 30 minutes"-tutorial
[
https://issues.apache.org/jira/browse/MNGSITE-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Wollmann updated MNGSITE-457:
--
Description:
The turial page
[Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources]
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
was:
The turial page
[Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources]contains
the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
> Typo in "Maven in 30 minutes"-tutorial
> --
>
> Key: MNGSITE-457
> URL: https://issues.apache.org/jira/browse/MNGSITE-457
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Alex Wollmann
>Priority: Trivial
>
> The turial page
> [Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources]
> contains the following symbolized file tree:
> {code:java}
> my-app
> |-- pom.xml
> `-- src
> |-- main
> | |-- java
> | | `-- com
> | | `-- mycompany
> | | `-- app
> | | `-- App.java
> | `-- resources
> | `-- META-INF
> | |-- application.properties
> `-- test
> |-- java
> | `-- com
> | `-- mycompany
> | `-- app
> | `-- AppTest.java
> `-- resources
> `-- test.properties
> {code}
>
> The pipe symbol in line 12 should be removed by a backtick in order to match
> the formatting that is used throughout the tutorial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNGSITE-457) Typo in "Maven in 30 minutes"-tutorial
[
https://issues.apache.org/jira/browse/MNGSITE-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Wollmann updated MNGSITE-457:
--
Description:
The official Maven turial page
([Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources])
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
was:
The turial page
([Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources])
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
> Typo in "Maven in 30 minutes"-tutorial
> --
>
> Key: MNGSITE-457
> URL: https://issues.apache.org/jira/browse/MNGSITE-457
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Alex Wollmann
>Priority: Trivial
>
> The official Maven turial page
> ([Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources])
> contains the following symbolized file tree:
> {code:java}
> my-app
> |-- pom.xml
> `-- src
> |-- main
> | |-- java
> | | `-- com
> | | `-- mycompany
> | | `-- app
> | | `-- App.java
> | `-- resources
> | `-- META-INF
> | |-- application.properties
> `-- test
> |-- java
> | `-- com
> | `-- mycompany
> | `-- app
> | `-- AppTest.java
> `-- resources
> `-- test.properties
> {code}
>
> The pipe symbol in line 12 should be removed by a backtick in order to match
> the formatting that is used throughout the tutorial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNGSITE-457) Typo in "Maven in 30 minutes"-tutorial
[
https://issues.apache.org/jira/browse/MNGSITE-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Wollmann updated MNGSITE-457:
--
Description:
The turial page
[Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources]contains
the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
was:
The turial page
[Link|[https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources]|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources)]
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
> Typo in "Maven in 30 minutes"-tutorial
> --
>
> Key: MNGSITE-457
> URL: https://issues.apache.org/jira/browse/MNGSITE-457
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Alex Wollmann
>Priority: Trivial
>
> The turial page
> [Link|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources]contains
> the following symbolized file tree:
> {code:java}
> my-app
> |-- pom.xml
> `-- src
> |-- main
> | |-- java
> | | `-- com
> | | `-- mycompany
> | | `-- app
> | | `-- App.java
> | `-- resources
> | `-- META-INF
> | |-- application.properties
> `-- test
> |-- java
> | `-- com
> | `-- mycompany
> | `-- app
> | `-- AppTest.java
> `-- resources
> `-- test.properties
> {code}
>
> The pipe symbol in line 12 should be removed by a backtick in order to match
> the formatting that is used throughout the tutorial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-scripting-plugin] rmannibucau opened a new pull request #4: binding the session and servers helper in binding context
rmannibucau opened a new pull request #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSCRIPTING) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSCRIPTING-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSCRIPTING-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSCRIPTING-7) Session is not bound in scripting bindings
Romain Manni-Bucau created MSCRIPTING-7: --- Summary: Session is not bound in scripting bindings Key: MSCRIPTING-7 URL: https://issues.apache.org/jira/browse/MSCRIPTING-7 Project: Maven Scripting Issue Type: Task Affects Versions: 3.0.0 Reporter: Romain Manni-Bucau -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNGSITE-457) Typo in "Maven in 30 minutes"-tutorial
[
https://issues.apache.org/jira/browse/MNGSITE-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Wollmann updated MNGSITE-457:
--
Description:
The turial page
[Link|[https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources]|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources)]
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
was:
The turial page
[Link]([https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources)]
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
> Typo in "Maven in 30 minutes"-tutorial
> --
>
> Key: MNGSITE-457
> URL: https://issues.apache.org/jira/browse/MNGSITE-457
> Project: Maven Project Web Site
> Issue Type: Bug
>Reporter: Alex Wollmann
>Priority: Trivial
>
> The turial page
> [Link|[https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources]|https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources)]
> contains the following symbolized file tree:
> {code:java}
> my-app
> |-- pom.xml
> `-- src
> |-- main
> | |-- java
> | | `-- com
> | | `-- mycompany
> | | `-- app
> | | `-- App.java
> | `-- resources
> | `-- META-INF
> | |-- application.properties
> `-- test
> |-- java
> | `-- com
> | `-- mycompany
> | `-- app
> | `-- AppTest.java
> `-- resources
> `-- test.properties
> {code}
>
> The pipe symbol in line 12 should be removed by a backtick in order to match
> the formatting that is used throughout the tutorial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MNGSITE-457) Typo in "Maven in 30 minutes"-tutorial
Alex Wollmann created MNGSITE-457:
-
Summary: Typo in "Maven in 30 minutes"-tutorial
Key: MNGSITE-457
URL: https://issues.apache.org/jira/browse/MNGSITE-457
Project: Maven Project Web Site
Issue Type: Bug
Reporter: Alex Wollmann
The turial page
[Link]([https://maven.apache.org/guides/getting-started/index.html#How_do_I_compile_my_application_sources)]
contains the following symbolized file tree:
{code:java}
my-app
|-- pom.xml
`-- src
|-- main
| |-- java
| | `-- com
| | `-- mycompany
| | `-- app
| | `-- App.java
| `-- resources
| `-- META-INF
| |-- application.properties
`-- test
|-- java
| `-- com
| `-- mycompany
| `-- app
| `-- AppTest.java
`-- resources
`-- test.properties
{code}
The pipe symbol in line 12 should be removed by a backtick in order to match
the formatting that is used throughout the tutorial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
