[GitHub] [maven] mickaelistria commented on pull request #570: [MNG-7285] - Test showcasing regression
mickaelistria commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938393511 > this stopped working in 3.8.2, not 3.8.3, right? Yes. We just noticed it in 3.8.3 because some other issues prevented m2e from adopting 3.8.2. But the test does fail starting from 3.8.2. > this specific case would be fixed by prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts #521, but I don't think this is exactly what happens in m2e because there are thread pools, right? It depends. Eclipse Platform has a job API and some specific threads (UI, workers, monitors...). Some use thread pools, some other just pass values along known threads; but usually we cannot rely on thread inheritance. So indeed, fix #521 would not work. I don't have a good understanding of MNG-6843 to propose a better solution, but my impression is that usage of ThreadLocal in a MavenProject is not a good idea as it can have a different lifecycle from what ThreadLocal is meant for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-1950) maven-surefire-plugin goes wrong with Junit-5.6.2
liang created SUREFIRE-1950: --- Summary: maven-surefire-plugin goes wrong with Junit-5.6.2 Key: SUREFIRE-1950 URL: https://issues.apache.org/jira/browse/SUREFIRE-1950 Project: Maven Surefire Issue Type: Bug Reporter: liang Test in error: initializationError -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-install-plugin] cstamas closed pull request #14: Install At End, Variant 2
cstamas closed pull request #14: URL: https://github.com/apache/maven-install-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] famod commented on pull request #570: [MNG-7285] - Test showcasing regression
famod commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938180266 A few things: - this stopped working in 3.8.2, not 3.8.3, right? - this specific case would be fixed by #521 - but I don't think is exactly what happens in m2e because there are thread pools, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] olamy merged pull request #79: Bump junit from 4.13.1 to 4.13.2
olamy merged pull request #79: URL: https://github.com/apache/maven-archetype/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-deploy-plugin] cstamas closed pull request #14: [MDEPLOY-280] Ability so skip specified classifiers from deploy
cstamas closed pull request #14: URL: https://github.com/apache/maven-deploy-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-deploy-plugin] cstamas closed pull request #18: Update plugin
cstamas closed pull request #18: URL: https://github.com/apache/maven-deploy-plugin/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] bmarwell commented on pull request #9: [MINSTALL-164] - Create GitHub Actions
bmarwell commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937792838 @cstamas done. Do we want to update the JDKs? Do you need additional JDKs (like OpenJ9)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #130: Updated Redisson and HZ doco
michael-o commented on a change in pull request #130:
URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724030140
##
File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm
##
@@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock
implementations are the follo
${esc.hash}${esc.hash} Open Issues/Notes
-- It only works when Sisu DI is used and not the bundled `AetherModule` or
- `ServiceLocator` (Maven uses Sisu dependency injection).
- Usage from plugins has not been tested yet.
- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
of dependency injection.
+${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators
+
+To use this implementation within your project, depending on how you
integrate, you have following options:
+- If you use Sisu DI, then all you need is to provide this module (and it's
dependencies) on classpath and you are done.
Review comment:
its
##
File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm
##
@@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock
implementations are the follo
${esc.hash}${esc.hash} Open Issues/Notes
-- It only works when Sisu DI is used and not the bundled `AetherModule` or
- `ServiceLocator` (Maven uses Sisu dependency injection).
- Usage from plugins has not been tested yet.
- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
of dependency injection.
+${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators
+
+To use this implementation within your project, depending on how you
integrate, you have following options:
+- If you use Sisu DI, then all you need is to provide this module (and it's
dependencies) on classpath and you are done.
+- If you use Guice, you need to add this module (and it's dependencies)
upfront, and bind them explicitly.
Review comment:
its
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas commented on pull request #14: Install At End, Variant 2
cstamas commented on pull request #14: URL: https://github.com/apache/maven-install-plugin/pull/14#issuecomment-937529860 Superseded by https://github.com/apache/maven-install-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #566: [MNG-6762] Resolve .mvn/settings.xml relatively in multi module projects
MartinKanters commented on pull request #566: URL: https://github.com/apache/maven/pull/566#issuecomment-937498369 I'm wondering whether that's worth the effort and potential overhead, rather than supporting both or either of the environment variable syntaxes in `maven.config` and then adjusting the syntax to the right OS during the shell/command script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #130: Updated Redisson and HZ doco
michael-o commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937677949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a change in pull request #568: MNG-7287 - Simplify assertion with simpler and equivalent calls.
slawekjaranowski commented on a change in pull request #568:
URL: https://github.com/apache/maven/pull/568#discussion_r724460160
##
File path:
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/VersionRangeTest.java
##
@@ -753,6 +754,7 @@ public void testCache()
restrictions = version.getRestrictions();
assertEquals( 0, restrictions.size(), CHECK_NUM_RESTRICTIONS );
-assertFalse( spec.equals( version ), "check
!VersionRange.createFromVersionSpec(x).equals(VersionRange.createFromVersion(x))"
);
+assertNotEquals( spec, version,
+"check
!VersionRange.createFromVersionSpec(x).equals(VersionRange.createFromVersion(x))"
);
Review comment:
`equals` test
##
File path:
maven-compat/src/test/java/org/apache/maven/project/inheritance/t06/ProjectInheritanceTest.java
##
@@ -71,15 +71,14 @@ public void testDependencyManagement()
assertNotNull( set, "No artifacts" );
assertTrue( set.size() > 0, "No Artifacts" );
Iterator iter = set.iterator();
-assertTrue( set.size() == 4, "Set size should be 4, is " + set.size()
);
+assertEquals( 4, set.size(), "Set size should be 4, is " + set.size()
);
while ( iter.hasNext() )
{
Artifact artifact = (Artifact) iter.next();
System.out.println( "Artifact: " +
artifact.getDependencyConflictId() + " " + artifact.getVersion()
+ " Optional=" + ( artifact.isOptional() ? "true" : "false" ) );
-assertTrue( artifact.getVersion().equals( "1.0" ),
-"Incorrect version for " +
artifact.getDependencyConflictId() );
+assertEquals( "1.0", artifact.getVersion(), "Incorrect version for
" + artifact.getDependencyConflictId() );
Review comment:
equals test
##
File path:
maven-compat/src/test/java/org/apache/maven/project/inheritance/t07/ProjectInheritanceTest.java
##
@@ -70,19 +71,18 @@ public void testDependencyManagement()
Set set = project1.getArtifacts();
assertNotNull( set, "No artifacts" );
assertTrue( set.size() > 0, "No Artifacts" );
-assertTrue( set.size() == 3, "Set size should be 3, is " + set.size()
);
+assertEquals( 3, set.size(), "Set size should be 3, is " + set.size()
);
for ( Object aSet : set )
{
Artifact artifact = (Artifact) aSet;
-assertFalse( artifact.getArtifactId().equals( "t07-d" ) );
+assertNotEquals( "t07-d", artifact.getArtifactId() );
Review comment:
equals test
##
File path:
maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/OrArtifactFilterTest.java
##
@@ -47,12 +48,12 @@ public void testEquals()
OrArtifactFilter filter2 = new OrArtifactFilter( Arrays.asList(
newSubFilter() ) );
-assertFalse( filter1.equals( null ) );
-assertTrue( filter1.equals( filter1 ) );
+assertNotEquals( null, filter1 );
+assertEquals( filter1, filter1 );
assertEquals( filter1.hashCode(), filter1.hashCode() );
-assertFalse( filter1.equals( filter2 ) );
-assertFalse( filter2.equals( filter1 ) );
+assertNotEquals( filter1, filter2 );
+assertNotEquals( filter2, filter1 );
Review comment:
equals test
##
File path:
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
##
@@ -189,20 +190,20 @@ public void testHashCode()
{
ArtifactVersion v1 = newArtifactVersion( "1" );
ArtifactVersion v2 = newArtifactVersion( "1.0" );
-assertEquals( true, v1.equals( v2 ) );
+assertTrue( v1.equals( v2 ) );
assertEquals( v1.hashCode(), v2.hashCode() );
}
@Test
public void testEqualsNullSafe()
{
-assertFalse( newArtifactVersion( "1" ).equals( null ) );
+assertNotEquals( null, newArtifactVersion( "1" ) );
}
@Test
public void testEqualsTypeSafe()
{
-assertFalse( newArtifactVersion( "1" ).equals(
"non-an-artifact-version-instance" ) );
+assertNotEquals( "non-an-artifact-version-instance",
newArtifactVersion( "1" ) );
Review comment:
the same show what we want to test
##
File path:
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
##
@@ -189,20 +190,20 @@ public void testHashCode()
{
ArtifactVersion v1 = newArtifactVersion( "1" );
ArtifactVersion v2 = newArtifactVersion( "1.0" );
-assertEquals( true, v1.equals( v2 ) );
+assertTrue( v1.equals( v2 ) );
assertEquals( v1.hashCode(), v2.hashCode() );
}
@Test
public void testEqualsNullSafe()
{
-assertFalse( newArtifactVersion( "1" ).equals( null ) );
+assertNotEquals( null, newArtifactVersion( "1" ) );
Review co
[GitHub] [maven-resolver] cstamas merged pull request #130: Updated Redisson and HZ doco
cstamas merged pull request #130: URL: https://github.com/apache/maven-resolver/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a change in pull request #570: [MNG-7285] - Test showcasing regression
slawekjaranowski commented on a change in pull request #570: URL: https://github.com/apache/maven/pull/570#discussion_r724537513 ## File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java ## @@ -43,6 +43,8 @@ import org.apache.maven.shared.utils.io.FileUtils; +import junit.framework.TestResult; Review comment: where is used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] gnodet merged pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method
gnodet merged pull request #125: URL: https://github.com/apache/maven-resolver/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #130: Updated Redisson and HZ doco
cstamas commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937647249 @michael-o did you like the video? :wink: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters closed pull request #120: [MNG-6762] Test whether a settings.xml file can be referenced relatively to the .mvn directory instead of working directory
MartinKanters closed pull request #120: URL: https://github.com/apache/maven-integration-testing/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas commented on pull request #12: Update plugin
cstamas commented on pull request #12: URL: https://github.com/apache/maven-install-plugin/pull/12#issuecomment-937581976 Superseded by https://github.com/apache/maven-install-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] gnodet commented on pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method
gnodet commented on pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#issuecomment-937554545 @michael-o @cstamas @rmannibucau can one of you create a version in JIRA for the next version, I can't create one as the fixVersion for the jira issue : https://issues.apache.org/jira/browse/MRESOLVER-204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #131: File advisory locking based NamedLocks
michael-o commented on a change in pull request #131:
URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724214698
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
+localRepositoryBasedir.getPath(), k ->
+{
+try
+{
+return new File( localRepositoryBasedir, ".locks"
).getCanonicalFile().toPath();
Review comment:
`getCanonicalFile()` can be very expensive, especially on Windows. Do we
really need it?
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
+localRepositoryBasedi
[GitHub] [maven-resolver] cstamas commented on a change in pull request #130: Updated Redisson and HZ doco
cstamas commented on a change in pull request #130:
URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724033873
##
File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm
##
@@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock
implementations are the follo
${esc.hash}${esc.hash} Open Issues/Notes
-- It only works when Sisu DI is used and not the bundled `AetherModule` or
- `ServiceLocator` (Maven uses Sisu dependency injection).
- Usage from plugins has not been tested yet.
- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
of dependency injection.
+${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators
+
+To use this implementation within your project, depending on how you
integrate, you have following options:
+- If you use Sisu DI, then all you need is to provide this module (and it's
dependencies) on classpath and you are done.
Review comment:
https://www.youtube.com/watch?v=O6UaU_Dzysc
##
File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm
##
@@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock
implementations are the follo
${esc.hash}${esc.hash} Open Issues/Notes
-- It only works when Sisu DI is used and not the bundled `AetherModule` or
- `ServiceLocator` (Maven uses Sisu dependency injection).
- Usage from plugins has not been tested yet.
- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
of dependency injection.
+${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators
+
+To use this implementation within your project, depending on how you
integrate, you have following options:
+- If you use Sisu DI, then all you need is to provide this module (and it's
dependencies) on classpath and you are done.
+- If you use Guice, you need to add this module (and it's dependencies)
upfront, and bind them explicitly.
Review comment:
https://www.youtube.com/watch?v=O6UaU_Dzysc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #570: [MNG-7285] - Test showcasing regression
michael-o commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938128652 @famod -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas commented on pull request #13: Install At End, Variant 1
cstamas commented on pull request #13: URL: https://github.com/apache/maven-install-plugin/pull/13#issuecomment-937529968 Superseded by https://github.com/apache/maven-install-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] olamy merged pull request #76: Bump maven-invoker from 3.0.1 to 3.1.0
olamy merged pull request #76: URL: https://github.com/apache/maven-archetype/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method
michael-o commented on pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#issuecomment-937560709 @gnodet Created. Go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks
cstamas commented on a change in pull request #131:
URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724224501
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
Review comment:
Purpose is to get canonical file only once, to cache it.
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
+localRepositoryBasedir.getPath(), k ->
+{
+try
+{
+return new File( localRepositoryBasedir, ".locks"
).getCanonicalFile().toPath();
Review comment:
That's why is in computeIfAbsent, to calculat
[GitHub] [maven-deploy-plugin] cstamas commented on pull request #18: Update plugin
cstamas commented on pull request #18: URL: https://github.com/apache/maven-deploy-plugin/pull/18#issuecomment-937583034 Superseded by https://github.com/apache/maven-deploy-plugin/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas commented on pull request #9: [MINSTALL-164] - Create GitHub Actions
cstamas commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937584306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas commented on pull request #1: [MINSTALL-115] installAtEnd fails with multiple class realms
cstamas commented on pull request #1: URL: https://github.com/apache/maven-install-plugin/pull/1#issuecomment-937530270 Check out https://github.com/apache/maven-install-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas closed pull request #12: Update plugin
cstamas closed pull request #12: URL: https://github.com/apache/maven-install-plugin/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #565: Mojo API update proposal
mthmulders commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r724474642
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/MojoLog.java
##
@@ -22,24 +22,35 @@
import org.apache.maven.plugin.logging.Log;
import org.slf4j.Logger;
+import javax.inject.Provider;
+
import static java.util.Objects.requireNonNull;
/**
- * @author jdcasey
+ * Mojo {@link Log} implementation that lazily creates {@link Logger}
instances.
+ *
+ * @since TBD
*/
-public class MojoLogWrapper
+public class MojoLog
implements Log
{
-private final Logger logger;
+private final Provider loggerProvider;
+
+private volatile Logger logger;
-public MojoLogWrapper( Logger logger )
+public MojoLog( Provider loggerProvider )
{
-this.logger = requireNonNull( logger );
+this.loggerProvider = requireNonNull( loggerProvider );
+this.logger = null;
}
-public void debug( CharSequence content )
+private Logger getLogger()
{
-logger.debug( toString( content ) );
+if ( logger == null )
Review comment:
I guess this is not thread-safe - multiple threads could run through
this one method at the same time, causing multiple `Logger` instances to be
created. Is that a problem?
##
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java
##
@@ -33,7 +33,11 @@
*/
public interface Mojo
{
-/** The component role hint for Plexus container */
+/** The component role hint for Plexus container
+ *
+ * @deprecated do not use legacy Plexus API to look up by string.
Review comment:
To be even more helpful for consumers of this API, what *should* they do
instead?
##
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##
@@ -75,7 +76,8 @@
private boolean parallel;
-private final Map>>
pluginContextsByProjectAndPluginKey =
+@SuppressWarnings( "checkstyle:linelength" )
+private final ConcurrentMap>> pluginContextsByProjectAndPluginKey =
Review comment:
There are three `String` occurrences in this line. Maybe a line of doc
saying which `String` holds what value is a good idea. Something like
projectId -> pluginKey -> ??? -> Context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] famod edited a comment on pull request #570: [MNG-7285] - Test showcasing regression
famod edited a comment on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938180266 A few things: - this stopped working in 3.8.2, not 3.8.3, right? - this specific case would be fixed by #521 - but I don't think this is exactly what happens in m2e because there are thread pools, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #476: [MNG-7156] Parallel build can cause issues between clean and forked g…
gnodet commented on pull request #476: URL: https://github.com/apache/maven/pull/476#issuecomment-937813747 > Cool, I think I saw some of issues while using mvnd that should be solved... Fwiw, it's not really urgent, as it has already been integrated into `mvnd` ... https://github.com/mvndaemon/mvnd/blob/master/daemon/src/main/java/org/mvndaemon/mvnd/execution/LockingEventSpy.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on a change in pull request #476: [MNG-7156] Parallel build can cause issues between clean and forked g…
cstamas commented on a change in pull request #476: URL: https://github.com/apache/maven/pull/476#discussion_r724151436 ## File path: maven-core/src/main/java/org/apache/maven/execution/LockingEventSpy.java ## @@ -0,0 +1,96 @@ +package org.apache.maven.execution; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.locks.Lock; +import java.util.concurrent.locks.ReentrantLock; + +import javax.inject.Named; +import javax.inject.Singleton; + +import org.apache.maven.eventspy.AbstractEventSpy; +import org.apache.maven.eventspy.EventSpy; +import org.apache.maven.project.MavenProject; +import org.eclipse.aether.SessionData; +import org.eclipse.sisu.Typed; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * EventSpy implementation that provides a per-project locking mechanism + * to make sure a given project can not be build twice concurrently. + * This case can happen when running parallel builds with forked lifecycles. + */ +@Singleton +@Named +@Typed( EventSpy.class ) +public class LockingEventSpy extends AbstractEventSpy Review comment: I think EventSpy for now will do, while Martin is right, seems "awkward". I am rather to change MavenCli and support discovery (should be trivial) but for start, this PR is a "go-go-go" for me, and we can latest refactor this into listener... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas closed pull request #13: Install At End, Variant 1
cstamas closed pull request #13: URL: https://github.com/apache/maven-install-plugin/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #129: Update build plugins
cstamas commented on a change in pull request #129: URL: https://github.com/apache/maven-resolver/pull/129#discussion_r724028309 ## File path: pom.xml ## @@ -366,16 +367,23 @@ + + org.apache.maven.plugins + maven-jxr-plugin + 3.1.1 Review comment: This above is in pluginMgmt, and removed the version from one in profile, as it will use the value from pluginMgmt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method
cstamas commented on a change in pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#discussion_r723889022 ## File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java ## @@ -81,4 +82,8 @@ public Object get( Object key ) return data.get( key ); } +public Object computeIfAbsent( Object key, Function mappingFunction ) Review comment: am +1 for both: leave as is (method in CM is defined for a reason like this), or supplier. Actually: * +1 leave as is (least effort) * +0.9 for Supplier :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] rmannibucau commented on a change in pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method
rmannibucau commented on a change in pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#discussion_r723880468 ## File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java ## @@ -81,4 +82,8 @@ public Object get( Object key ) return data.get( key ); } +public Object computeIfAbsent( Object key, Function mappingFunction ) Review comment: it is also true it could be a supplier since the key is in the signature as well or an unaryoperator which is a fn a->a. We don't have to align on the underlying impl (map) but the nice thing with a fn is that, when the computing depends on the key you don't need to pass it each time and can reuse a method ref. An unaryoperator being a function, the signature complies to it so overall I think it is a good one @cstamas . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o removed a comment on pull request #130: Updated Redisson and HZ doco
michael-o removed a comment on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937677949 > > > @michael-o did you like the video? 😉 Which? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas edited a comment on pull request #9: [MINSTALL-164] - Create GitHub Actions
cstamas edited a comment on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] gnodet commented on a change in pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method
gnodet commented on a change in pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#discussion_r723887906 ## File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java ## @@ -81,4 +82,8 @@ public Object get( Object key ) return data.get( key ); } +public Object computeIfAbsent( Object key, Function mappingFunction ) Review comment: @rmannibucau @cstamas honestly, I agree with you. I've used the `computeIfAbsent` method on the map a lot of time, and I've always been puzzled about the inclusion of the key in the signature which is most of the time useless. I wanted to keep the `Map` compatibility, but if you guys don't think it's necessary, I'm more than happy to just use a `Supplier`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] bmarwell merged pull request #9: [MINSTALL-164] - Create GitHub Actions
bmarwell merged pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] slawekjaranowski commented on pull request #9: [MINSTALL-164] - Create GitHub Actions
slawekjaranowski commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937889620 And I see it is another way for GA ... here be using build in containers ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] famod edited a comment on pull request #570: [MNG-7285] - Test showcasing regression
famod edited a comment on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938180266 A few things: - this stopped working in 3.8.2, not 3.8.3, right? - this specific case would be fixed by #521 - but I don't think this is exactly what happens in m2e because there are thread pools, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] famod commented on pull request #570: [MNG-7285] - Test showcasing regression
famod commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938180266 A few things: - this stopped working in 3.8.2, not 3.8.3, right? - this specific case would be fixed by #521 - but I don't think is exactly what happens in m2e because there are thread pools, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a change in pull request #570: [MNG-7285] - Test showcasing regression
slawekjaranowski commented on a change in pull request #570: URL: https://github.com/apache/maven/pull/570#discussion_r724537513 ## File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java ## @@ -43,6 +43,8 @@ import org.apache.maven.shared.utils.io.FileUtils; +import junit.framework.TestResult; Review comment: where is used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #570: [MNG-7285] - Test showcasing regression
michael-o commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938128652 @famod -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7285) [Regression] MavenProject.getArtifacts() not returning correct value across multiple threads
[ https://issues.apache.org/jira/browse/MNG-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425779#comment-17425779 ] Mickael Istria commented on MNG-7285: - PR at [https://github.com/apache/maven/pull/570] shows the regression. This same test is working with maven 3.8.1 and starts failing since 3.8.3. I think any mojo that uses project.getArtifacts() can get faulty result if using parallel build. > [Regression] MavenProject.getArtifacts() not returning correct value across > multiple threads > > > Key: MNG-7285 > URL: https://issues.apache.org/jira/browse/MNG-7285 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.8.2, 3.8.3 >Reporter: Mickael Istria >Priority: Critical > > Patch for MNG-6843 seems to cause that when trying to use > MavenProject.getArtifacts() across different threads, some of them get an > incorrect result. > This cause an issue in m2e where we schedule a lot of work and don't have > much control over which thread will do the work (there is a thread pool); > we've faced several regressions because of this issue when trying to adopt > 3.8.3 from 3.8.1. More details at > [https://github.com/eclipse-m2e/m2e-core/pull/346|https://github.com/eclipse-m2e/m2e-core/pull/350] > , > [https://github.com/eclipse-m2e/m2e-core/pull/347|https://github.com/eclipse-m2e/m2e-core/pull/350] > and [https://github.com/eclipse-m2e/m2e-core/pull/350] . > I'll try to capture it in a test case for maven repo in the next days. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MNG-7285) [Regression] MavenProject.getArtifacts() not returning correct value across multiple threads
[ https://issues.apache.org/jira/browse/MNG-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Istria updated MNG-7285: Affects Version/s: 3.8.2 > [Regression] MavenProject.getArtifacts() not returning correct value across > multiple threads > > > Key: MNG-7285 > URL: https://issues.apache.org/jira/browse/MNG-7285 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.8.2, 3.8.3 >Reporter: Mickael Istria >Priority: Critical > > Patch for MNG-6843 seems to cause that when trying to use > MavenProject.getArtifacts() across different threads, some of them get an > incorrect result. > This cause an issue in m2e where we schedule a lot of work and don't have > much control over which thread will do the work (there is a thread pool); > we've faced several regressions because of this issue when trying to adopt > 3.8.3 from 3.8.1. More details at > [https://github.com/eclipse-m2e/m2e-core/pull/346|https://github.com/eclipse-m2e/m2e-core/pull/350] > , > [https://github.com/eclipse-m2e/m2e-core/pull/347|https://github.com/eclipse-m2e/m2e-core/pull/350] > and [https://github.com/eclipse-m2e/m2e-core/pull/350] . > I'll try to capture it in a test case for maven repo in the next days. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] mickaelistria opened a new pull request #570: [MNG-7285 - Test showcasing regression
mickaelistria opened a new pull request #570: URL: https://github.com/apache/maven/pull/570 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #565: Mojo API update proposal
mthmulders commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r724474642
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/MojoLog.java
##
@@ -22,24 +22,35 @@
import org.apache.maven.plugin.logging.Log;
import org.slf4j.Logger;
+import javax.inject.Provider;
+
import static java.util.Objects.requireNonNull;
/**
- * @author jdcasey
+ * Mojo {@link Log} implementation that lazily creates {@link Logger}
instances.
+ *
+ * @since TBD
*/
-public class MojoLogWrapper
+public class MojoLog
implements Log
{
-private final Logger logger;
+private final Provider loggerProvider;
+
+private volatile Logger logger;
-public MojoLogWrapper( Logger logger )
+public MojoLog( Provider loggerProvider )
{
-this.logger = requireNonNull( logger );
+this.loggerProvider = requireNonNull( loggerProvider );
+this.logger = null;
}
-public void debug( CharSequence content )
+private Logger getLogger()
{
-logger.debug( toString( content ) );
+if ( logger == null )
Review comment:
I guess this is not thread-safe - multiple threads could run through
this one method at the same time, causing multiple `Logger` instances to be
created. Is that a problem?
##
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java
##
@@ -33,7 +33,11 @@
*/
public interface Mojo
{
-/** The component role hint for Plexus container */
+/** The component role hint for Plexus container
+ *
+ * @deprecated do not use legacy Plexus API to look up by string.
Review comment:
To be even more helpful for consumers of this API, what *should* they do
instead?
##
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##
@@ -75,7 +76,8 @@
private boolean parallel;
-private final Map>>
pluginContextsByProjectAndPluginKey =
+@SuppressWarnings( "checkstyle:linelength" )
+private final ConcurrentMap>> pluginContextsByProjectAndPluginKey =
Review comment:
There are three `String` occurrences in this line. Maybe a line of doc
saying which `String` holds what value is a good idea. Something like
projectId -> pluginKey -> ??? -> Context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a change in pull request #568: MNG-7287 - Simplify assertion with simpler and equivalent calls.
slawekjaranowski commented on a change in pull request #568:
URL: https://github.com/apache/maven/pull/568#discussion_r724460160
##
File path:
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/VersionRangeTest.java
##
@@ -753,6 +754,7 @@ public void testCache()
restrictions = version.getRestrictions();
assertEquals( 0, restrictions.size(), CHECK_NUM_RESTRICTIONS );
-assertFalse( spec.equals( version ), "check
!VersionRange.createFromVersionSpec(x).equals(VersionRange.createFromVersion(x))"
);
+assertNotEquals( spec, version,
+"check
!VersionRange.createFromVersionSpec(x).equals(VersionRange.createFromVersion(x))"
);
Review comment:
`equals` test
##
File path:
maven-compat/src/test/java/org/apache/maven/project/inheritance/t06/ProjectInheritanceTest.java
##
@@ -71,15 +71,14 @@ public void testDependencyManagement()
assertNotNull( set, "No artifacts" );
assertTrue( set.size() > 0, "No Artifacts" );
Iterator iter = set.iterator();
-assertTrue( set.size() == 4, "Set size should be 4, is " + set.size()
);
+assertEquals( 4, set.size(), "Set size should be 4, is " + set.size()
);
while ( iter.hasNext() )
{
Artifact artifact = (Artifact) iter.next();
System.out.println( "Artifact: " +
artifact.getDependencyConflictId() + " " + artifact.getVersion()
+ " Optional=" + ( artifact.isOptional() ? "true" : "false" ) );
-assertTrue( artifact.getVersion().equals( "1.0" ),
-"Incorrect version for " +
artifact.getDependencyConflictId() );
+assertEquals( "1.0", artifact.getVersion(), "Incorrect version for
" + artifact.getDependencyConflictId() );
Review comment:
equals test
##
File path:
maven-compat/src/test/java/org/apache/maven/project/inheritance/t07/ProjectInheritanceTest.java
##
@@ -70,19 +71,18 @@ public void testDependencyManagement()
Set set = project1.getArtifacts();
assertNotNull( set, "No artifacts" );
assertTrue( set.size() > 0, "No Artifacts" );
-assertTrue( set.size() == 3, "Set size should be 3, is " + set.size()
);
+assertEquals( 3, set.size(), "Set size should be 3, is " + set.size()
);
for ( Object aSet : set )
{
Artifact artifact = (Artifact) aSet;
-assertFalse( artifact.getArtifactId().equals( "t07-d" ) );
+assertNotEquals( "t07-d", artifact.getArtifactId() );
Review comment:
equals test
##
File path:
maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/OrArtifactFilterTest.java
##
@@ -47,12 +48,12 @@ public void testEquals()
OrArtifactFilter filter2 = new OrArtifactFilter( Arrays.asList(
newSubFilter() ) );
-assertFalse( filter1.equals( null ) );
-assertTrue( filter1.equals( filter1 ) );
+assertNotEquals( null, filter1 );
+assertEquals( filter1, filter1 );
assertEquals( filter1.hashCode(), filter1.hashCode() );
-assertFalse( filter1.equals( filter2 ) );
-assertFalse( filter2.equals( filter1 ) );
+assertNotEquals( filter1, filter2 );
+assertNotEquals( filter2, filter1 );
Review comment:
equals test
##
File path:
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
##
@@ -189,20 +190,20 @@ public void testHashCode()
{
ArtifactVersion v1 = newArtifactVersion( "1" );
ArtifactVersion v2 = newArtifactVersion( "1.0" );
-assertEquals( true, v1.equals( v2 ) );
+assertTrue( v1.equals( v2 ) );
assertEquals( v1.hashCode(), v2.hashCode() );
}
@Test
public void testEqualsNullSafe()
{
-assertFalse( newArtifactVersion( "1" ).equals( null ) );
+assertNotEquals( null, newArtifactVersion( "1" ) );
}
@Test
public void testEqualsTypeSafe()
{
-assertFalse( newArtifactVersion( "1" ).equals(
"non-an-artifact-version-instance" ) );
+assertNotEquals( "non-an-artifact-version-instance",
newArtifactVersion( "1" ) );
Review comment:
the same show what we want to test
##
File path:
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
##
@@ -189,20 +190,20 @@ public void testHashCode()
{
ArtifactVersion v1 = newArtifactVersion( "1" );
ArtifactVersion v2 = newArtifactVersion( "1.0" );
-assertEquals( true, v1.equals( v2 ) );
+assertTrue( v1.equals( v2 ) );
assertEquals( v1.hashCode(), v2.hashCode() );
}
@Test
public void testEqualsNullSafe()
{
-assertFalse( newArtifactVersion( "1" ).equals( null ) );
+assertNotEquals( null, newArtifactVersion( "1" ) );
Review co
[jira] [Created] (MWRAPPER-14) Make maven wrapper functional
Tamás Cservenák created MWRAPPER-14:
---
Summary: Make maven wrapper functional
Key: MWRAPPER-14
URL: https://issues.apache.org/jira/browse/MWRAPPER-14
Project: Maven Wrapper
Issue Type: Task
Reporter: Tamás Cservenák
Make a wrapper a normal wrapper. The wrapper is not meant to be part of any
distribution, but a lightweight way to bootstrap maven without the need to
install it onto target machine.
With legacy wrapper:
* checked out project "just works"
* you know it builds with proper maven
* exclude any mistake like install ancient mvn version or some disto mutilated
mvn
This is the main goal, and by having apache groupId, {{wrapper:wrapper}} should
work like before.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] arturobernalg opened a new pull request #569: MNG-7288 - Remove redundant local variables.
arturobernalg opened a new pull request #569: URL: https://github.com/apache/maven/pull/569 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X ] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-7287) Simplify assertion with simpler and equivalent calls.
[ https://issues.apache.org/jira/browse/MNG-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MNG-7287: Assignee: Karl Heinz Marbaise > Simplify assertion with simpler and equivalent calls. > - > > Key: MNG-7287 > URL: https://issues.apache.org/jira/browse/MNG-7287 > Project: Maven > Issue Type: Sub-task >Reporter: Arturo Bernal >Assignee: Karl Heinz Marbaise >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MNG-7288) Remove redundant local variables
Arturo Bernal created MNG-7288: -- Summary: Remove redundant local variables Key: MNG-7288 URL: https://issues.apache.org/jira/browse/MNG-7288 Project: Maven Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] arturobernalg opened a new pull request #568: MNG-7287 - Simplify assertion with simpler and equivalent calls.
arturobernalg opened a new pull request #568: URL: https://github.com/apache/maven/pull/568 Following this checklist to help us incorporate your contribution quickly and easily: - [X ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X ] Each commit in the pull request should have a meaningful subject line and body. - [ X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ X] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7287) Simplify assertion with simpler and equivalent calls.
Arturo Bernal created MNG-7287: -- Summary: Simplify assertion with simpler and equivalent calls. Key: MNG-7287 URL: https://issues.apache.org/jira/browse/MNG-7287 Project: Maven Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MNG-7286) Improvements:
Arturo Bernal created MNG-7286: -- Summary: Improvements: Key: MNG-7286 URL: https://issues.apache.org/jira/browse/MNG-7286 Project: Maven Issue Type: Improvement Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-install-plugin] cstamas commented on pull request #9: [MINSTALL-164] - Create GitHub Actions
cstamas commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937895491 Cool, thanks! @slawekjaranowski @bmarwell am fine, I really just wanted to have ITs run here as well. But we started a discussion on ML to do this for all reposes (or shared? am not into GAs too much)... that would be great to implement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] slawekjaranowski commented on pull request #9: [MINSTALL-164] - Create GitHub Actions
slawekjaranowski commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937889620 And I see it is another way for GA ... here be using build in containers ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks
cstamas commented on a change in pull request #131:
URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724233857
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
Review comment:
... and it may change, if executes within mvnd for example :wink:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks
cstamas commented on a change in pull request #131:
URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724226914
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
+localRepositoryBasedir.getPath(), k ->
+{
+try
+{
+return new File( localRepositoryBasedir, ".locks"
).getCanonicalFile().toPath();
+}
+catch ( IOException e )
+{
+throw new UncheckedIOException( e );
+}
+}
+);
+
+String fileName = baseDir.resolve( name ).toAbsolutePath().toString();
Review comment:
Yes, commit b5328161f298c62ad1b74d3f40d9ae50d7d5dd9e adds a "mapper"
that is FS friendly, shamelessly stolen from Takari Local Repo project :smile:
Now, how to prevent "mis-configuration" is yet to be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks
cstamas commented on a change in pull request #131:
URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724225265
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
+localRepositoryBasedir.getPath(), k ->
+{
+try
+{
+return new File( localRepositoryBasedir, ".locks"
).getCanonicalFile().toPath();
Review comment:
That's why is in computeIfAbsent, to calculate it only once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks
cstamas commented on a change in pull request #131:
URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724224501
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
Review comment:
Purpose is to get canonical file only once, to cache it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #131: File advisory locking based NamedLocks
michael-o commented on a change in pull request #131:
URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724214698
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
+localRepositoryBasedir.getPath(), k ->
+{
+try
+{
+return new File( localRepositoryBasedir, ".locks"
).getCanonicalFile().toPath();
Review comment:
`getCanonicalFile()` can be very expensive, especially on Windows. Do we
really need it?
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java
##
@@ -0,0 +1,91 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.named.support.FileLockNamedLockFactorySupport;
+import org.eclipse.aether.named.support.NamedLockSupport;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.File;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * A {@link SessionAwareNamedLockFactory} that uses advisory file locking.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( FileLockNamedLockFactory.NAME )
+public class FileLockNamedLockFactory
+extends FileLockNamedLockFactorySupport
+implements SessionAwareNamedLockFactory
+{
+public static final String NAME = "file-lock";
+
+private final ConcurrentHashMap baseDirs;
+
+public FileLockNamedLockFactory()
+{
+this.baseDirs = new ConcurrentHashMap<>();
+}
+
+@Override
+public NamedLockSupport getLock( final RepositorySystemSession session,
final String name )
+{
+File localRepositoryBasedir =
session.getLocalRepository().getBasedir();
+Path baseDir = baseDirs.computeIfAbsent(
+localRepositoryBasedi
[GitHub] [maven] gnodet commented on pull request #476: [MNG-7156] Parallel build can cause issues between clean and forked g…
gnodet commented on pull request #476: URL: https://github.com/apache/maven/pull/476#issuecomment-937813747 > Cool, I think I saw some of issues while using mvnd that should be solved... Fwiw, it's not really urgent, as it has already been integrated into `mvnd` ... https://github.com/mvndaemon/mvnd/blob/master/daemon/src/main/java/org/mvndaemon/mvnd/execution/LockingEventSpy.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas opened a new pull request #131: File advisory locking based NamedLocks
cstamas opened a new pull request #131: URL: https://github.com/apache/maven-resolver/pull/131 This PR returns the removed FileNamedLocks from original PR and will try to make them work as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] bmarwell commented on pull request #9: [MINSTALL-164] - Create GitHub Actions
bmarwell commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937792838 @cstamas done. Do we want to update the JDKs? Do you need additional JDKs (like OpenJ9)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] bmarwell merged pull request #9: [MINSTALL-164] - Create GitHub Actions
bmarwell merged pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MCHECKSTYLE-406) Make plugin compatible with Checkstyle 8.44
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425536#comment-17425536
]
Alexander Kriegisch edited comment on MCHECKSTYLE-406 at 10/7/21, 12:55 PM:
When Shared Resources 4 is released, this problem will go away, at least for
the case reported here, by configuring the plugin as follows:
{code:xml}
org.apache.maven.plugins
maven-checkstyle-plugin
3.1.2
com.puppycrawl.tools
checkstyle
9.0.1
org.apache.maven.shared
maven-shared-resources
4
{code}
I.e., this plugin could be upgraded to Shared Resources 4, as soon as it is
available on Maven Central.
was (Author: kriegaex):
When Shared Resources 4 is released, this problem will go away, at least for
the case reported here, by configuring the plugin as follows:
{code:xml}
org.apache.maven.plugins
maven-checkstyle-plugin
3.1.2
com.puppycrawl.tools
checkstyle
9.0.1
org.apache.maven.shared
maven-shared-resources
4
{code}
> Make plugin compatible with Checkstyle 8.44
> ---
>
> Key: MCHECKSTYLE-406
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-406
> Project: Maven Checkstyle Plugin
> Issue Type: Dependency upgrade
>Affects Versions: 3.1.2
>Reporter: Alexander Kriegisch
>Priority: Major
>
> On GitHub, Dependabot suggests upgrading Checkstyle to something more recent
> than 8.41.1, but the corresponding builds fail, both for 8.43 and 8.44, e.g.
> [this
> build|https://github.com/dev-aspectj/aspectj-maven-plugin/pull/20/checks?check_run_id=2933248023]:
> {code}
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on
> project aspectj-maven-plugin: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report: Failed during checkstyle
> configuration: cannot initialize module TreeWalker - cannot initialize module
> JavadocMethod - Property 'scope' does not exist, please check the
> documentation -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on
> project aspectj-maven-plugin: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> (...)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.plugins.site.render.SiteMojo.execute
> (SiteMojo.java:151)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> (...)
> Caused by: org.apache.maven.reporting.MavenReportException: Failed during
> checkstyle configuration
> at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure
> (AutomaticBean.java:201)
> at
> org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
> (DefaultCheckstyleExecutor.java:167)
> at
> org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport
> (AbstractCheckstyleReport.java:533)
> (...)
> {code}
> This is in no way urgent, but as Dependabot keeps bugging me with this for
> every new Checkstyle version, I thought I should mention it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MCHECKSTYLE-406) Make plugin compatible with Checkstyle 8.44
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425536#comment-17425536
]
Alexander Kriegisch edited comment on MCHECKSTYLE-406 at 10/7/21, 12:54 PM:
When Shared Resources 4 is released, this problem will go away, at least for
the case reported here, by configuring the plugin as follows:
{code:xml}
org.apache.maven.plugins
maven-checkstyle-plugin
3.1.2
com.puppycrawl.tools
checkstyle
9.0.1
org.apache.maven.shared
maven-shared-resources
4
{code}
was (Author: kriegaex):
When Shared Resources 4 is released, this problem will go away, at least for
the case reported here.
> Make plugin compatible with Checkstyle 8.44
> ---
>
> Key: MCHECKSTYLE-406
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-406
> Project: Maven Checkstyle Plugin
> Issue Type: Dependency upgrade
>Affects Versions: 3.1.2
>Reporter: Alexander Kriegisch
>Priority: Major
>
> On GitHub, Dependabot suggests upgrading Checkstyle to something more recent
> than 8.41.1, but the corresponding builds fail, both for 8.43 and 8.44, e.g.
> [this
> build|https://github.com/dev-aspectj/aspectj-maven-plugin/pull/20/checks?check_run_id=2933248023]:
> {code}
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on
> project aspectj-maven-plugin: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report: Failed during checkstyle
> configuration: cannot initialize module TreeWalker - cannot initialize module
> JavadocMethod - Property 'scope' does not exist, please check the
> documentation -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on
> project aspectj-maven-plugin: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> (...)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.plugins.site.render.SiteMojo.execute
> (SiteMojo.java:151)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> (...)
> Caused by: org.apache.maven.reporting.MavenReportException: Failed during
> checkstyle configuration
> at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure
> (AutomaticBean.java:201)
> at
> org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
> (DefaultCheckstyleExecutor.java:167)
> at
> org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport
> (AbstractCheckstyleReport.java:533)
> (...)
> {code}
> This is in no way urgent, but as Dependabot keeps bugging me with this for
> every new Checkstyle version, I thought I should mention it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] cstamas commented on a change in pull request #476: [MNG-7156] Parallel build can cause issues between clean and forked g…
cstamas commented on a change in pull request #476: URL: https://github.com/apache/maven/pull/476#discussion_r724151436 ## File path: maven-core/src/main/java/org/apache/maven/execution/LockingEventSpy.java ## @@ -0,0 +1,96 @@ +package org.apache.maven.execution; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.locks.Lock; +import java.util.concurrent.locks.ReentrantLock; + +import javax.inject.Named; +import javax.inject.Singleton; + +import org.apache.maven.eventspy.AbstractEventSpy; +import org.apache.maven.eventspy.EventSpy; +import org.apache.maven.project.MavenProject; +import org.eclipse.aether.SessionData; +import org.eclipse.sisu.Typed; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * EventSpy implementation that provides a per-project locking mechanism + * to make sure a given project can not be build twice concurrently. + * This case can happen when running parallel builds with forked lifecycles. + */ +@Singleton +@Named +@Typed( EventSpy.class ) +public class LockingEventSpy extends AbstractEventSpy Review comment: I think EventSpy for now will do, while Martin is right, seems "awkward". I am rather to change MavenCli and support discovery (should be trivial) but for start, this PR is a "go-go-go" for me, and we can latest refactor this into listener... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCHECKSTYLE-406) Make plugin compatible with Checkstyle 8.44
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425536#comment-17425536
]
Alexander Kriegisch commented on MCHECKSTYLE-406:
-
When Shared Resources 4 is released, this problem will go away, at least for
the case reported here.
> Make plugin compatible with Checkstyle 8.44
> ---
>
> Key: MCHECKSTYLE-406
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-406
> Project: Maven Checkstyle Plugin
> Issue Type: Dependency upgrade
>Affects Versions: 3.1.2
>Reporter: Alexander Kriegisch
>Priority: Major
>
> On GitHub, Dependabot suggests upgrading Checkstyle to something more recent
> than 8.41.1, but the corresponding builds fail, both for 8.43 and 8.44, e.g.
> [this
> build|https://github.com/dev-aspectj/aspectj-maven-plugin/pull/20/checks?check_run_id=2933248023]:
> {code}
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on
> project aspectj-maven-plugin: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report: Failed during checkstyle
> configuration: cannot initialize module TreeWalker - cannot initialize module
> JavadocMethod - Property 'scope' does not exist, please check the
> documentation -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on
> project aspectj-maven-plugin: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> (...)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.plugins.site.render.SiteMojo.execute
> (SiteMojo.java:151)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> (...)
> Caused by: org.apache.maven.reporting.MavenReportException: Failed during
> checkstyle configuration
> at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure
> (AutomaticBean.java:201)
> at
> org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
> (DefaultCheckstyleExecutor.java:167)
> at
> org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport
> (AbstractCheckstyleReport.java:533)
> (...)
> {code}
> This is in no way urgent, but as Dependabot keeps bugging me with this for
> every new Checkstyle version, I thought I should mention it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-pdf-plugin] dependabot[bot] opened a new pull request #12: Bump mavenVersion from 3.1.1 to 3.8.3
dependabot[bot] opened a new pull request #12: URL: https://github.com/apache/maven-pdf-plugin/pull/12 Bumps `mavenVersion` from 3.1.1 to 3.8.3. Updates `maven-core` from 3.1.1 to 3.8.3 Commits https://github.com/apache/maven/commit/ff8e977a158738155dc465c6a97ffaf31982d739";>ff8e977 [maven-release-plugin] prepare release maven-3.8.3 https://github.com/apache/maven/commit/0a6bbb8301717d386e6588a7ea32e3e2451c7060";>0a6bbb8 [MNG-7235] Speed improvements when calculating the sorted project graph https://github.com/apache/maven/commit/8882a9c599013182e42f0c7c321396c23b84dbe0";>8882a9c [MNG-7164] Add constructor MojoExecutionException(Throwable) https://github.com/apache/maven/commit/ab54d17dc2ec355c1e002e8751739edd9a96fcc3";>ab54d17 [MNG-7253] Display relocation message defined in model https://github.com/apache/maven/commit/8c66edc0417f37540b3a6ef4b266ff88bdbd8327";>8c66edc [MNG-7254] Expand Windows native libraries for Jansi due to JDK-8195129 (work... https://github.com/apache/maven/commit/d1aa1e1f0a891609256c60b2b7b5b8efaceea563";>d1aa1e1 [MNG-7252] Fix warnings issued by dependency:analyze https://github.com/apache/maven/commit/93f9e85955abb40bb090bad689f15fa9969ef9ba";>93f9e85 [MNG-7045] Drop CDI API from Maven https://github.com/apache/maven/commit/98a9d089bda8870fd658208d98bdc73a5f039b0f";>98a9d08 [MNG-7236] The DefaultPluginVersionResolver should cache results for the session https://github.com/apache/maven/commit/1ea42b0371f1bc99a4e0629c3734ad4ccfc0dcbd";>1ea42b0 [MNG-7219] [Regression] plexus-cipher missing from transitive dependencies https://github.com/apache/maven/commit/4e5b3d55545e5f03f05ac7b0cd1b56689df36201";>4e5b3d5 [MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project Additional commits viewable in https://github.com/apache/maven/compare/maven-3.1.1...maven-3.8.3";>compare view Updates `maven-compat` from 3.1.1 to 3.8.3 Commits https://github.com/apache/maven/commit/ff8e977a158738155dc465c6a97ffaf31982d739";>ff8e977 [maven-release-plugin] prepare release maven-3.8.3 https://github.com/apache/maven/commit/0a6bbb8301717d386e6588a7ea32e3e2451c7060";>0a6bbb8 [MNG-7235] Speed improvements when calculating the sorted project graph https://github.com/apache/maven/commit/8882a9c599013182e42f0c7c321396c23b84dbe0";>8882a9c [MNG-7164] Add constructor MojoExecutionException(Throwable) https://github.com/apache/maven/commit/ab54d17dc2ec355c1e002e8751739edd9a96fcc3";>ab54d17 [MNG-7253] Display relocation message defined in model https://github.com/apache/maven/commit/8c66edc0417f37540b3a6ef4b266ff88bdbd8327";>8c66edc [MNG-7254] Expand Windows native libraries for Jansi due to JDK-8195129 (work... https://github.com/apache/maven/commit/d1aa1e1f0a891609256c60b2b7b5b8efaceea563";>d1aa1e1 [MNG-7252] Fix warnings issued by dependency:analyze https://github.com/apache/maven/commit/93f9e85955abb40bb090bad689f15fa9969ef9ba";>93f9e85 [MNG-7045] Drop CDI API from Maven https://github.com/apache/maven/commit/98a9d089bda8870fd658208d98bdc73a5f039b0f";>98a9d08 [MNG-7236] The DefaultPluginVersionResolver should cache results for the session https://github.com/apache/maven/commit/1ea42b0371f1bc99a4e0629c3734ad4ccfc0dcbd";>1ea42b0 [MNG-7219] [Regression] plexus-cipher missing from transitive dependencies https://github.com/apache/maven/commit/4e5b3d55545e5f03f05ac7b0cd1b56689df36201";>4e5b3d5 [MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project Additional commits viewable in https://github.com/apache/maven/compare/maven-3.1.1...maven-3.8.3";>compare view Updates `maven-plugin-api` from 3.1.1 to 3.8.3 Commits https://github.com/apache/maven/commit/ff8e977a158738155dc465c6a97ffaf31982d739";>ff8e977 [maven-release-plugin] prepare release maven-3.8.3 https://github.com/apache/maven/commit/0a6bbb8301717d386e6588a7ea32e3e2451c7060";>0a6bbb8 [MNG-7235] Speed improvements when calculating the sorted project graph https://github.com/apache/maven/commit/8882a9c599013182e42f0c7c321396c23b84dbe0";>8882a9c [MNG-7164] Add constructor MojoExecutionException(Throwable) https://github.com/apache/maven/commit/ab54d17dc2ec355c1e002e8751739edd9a96fcc3";>ab54d17 [MNG-7253] Display relocation message defined in model https://github.com/apache/maven/commit/8c66edc0417f37540b3a6ef4b266ff88bdbd8327";>8c66edc [MNG-7254] Expand Windows native libraries for Jansi due to JDK-8195129 (work... https://github.com/apache/maven/commit/d1aa1e1f0a891609256c60b2b7b5b8efaceea563";>d1aa1e1 [MNG-7252] Fix warnings issued by dependency:analyze https://github.com/apache/maven/commit/93f9e85955abb40bb090bad689f15fa9969ef9ba";>93f9e85 [MNG-7045] Drop CDI API from Maven https://github.com/apache/maven/commit/98a9d089bda8870fd658208d98bdc73a5f039b0f";>98a9d08 [MNG-7236] The DefaultPluginVersionResolver should cache results for the
[jira] [Commented] (MSHARED-990) Checkstyle config: Swap scope and exclude scope to access modifier in the check JavadocMethodCheck.
[ https://issues.apache.org/jira/browse/MSHARED-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425535#comment-17425535 ] Alexander Kriegisch commented on MSHARED-990: - I hope the current release vote will be positive. I just locally built version 4 and can confirm that it also solves MCHECKSTYLE-406. > Checkstyle config: Swap scope and exclude scope to access modifier in the > check JavadocMethodCheck. > --- > > Key: MSHARED-990 > URL: https://issues.apache.org/jira/browse/MSHARED-990 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-shared-resources >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: maven-shared-resources-4 > > > In Checkstyle 8.42 scope property for JavadocMethod and MissingJavadocMethod > modules was replaced with accessModifiers (see > [checkstyle/checkstyle#7417|https://github.com/checkstyle/checkstyle/issues/7417]). > Migration Notes: > Property excludeScope was dropped and scope property was from > https://checkstyle.org/property_types.html#scope to accessModifiers of type > https://checkstyle.org/property_types.html#access_modifiers . > The change to accessModifiers basically combines scope and excludeScope into > 1 field and allows you specify the exact modifiers you want to validate > methods with. Scope ambiguously only let you choose 1 specific modifier, and > any other modifers above it in our type documentation were included, > regardless if you wanted to include them or not. With accessModifiers you can > now write out any and all modifiers you wish to cover, with no ambiguity. > Examples: > scope => accessModifiers > private => private, package, protected, and public > package => package, protected, and public > protected => protected, and public > public => public > excludeScope only allowed you to remove that 1 specific modifier. So scope of > private and excludeScope of package included the modifiers private, > protected, and public. With access modifiers you can have the same config > with: > > > > Scope did support anonymous inner classes. Since that is technically not a > modifier, it is no longer supported and there is workaround. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-install-plugin] cstamas edited a comment on pull request #9: [MINSTALL-164] - Create GitHub Actions
cstamas edited a comment on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 @aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions: * gives amazingly fast builds (well, off US office hours at least) * gives feedback about "full build" here, on this very page (makes easier to spot what to review what not) * has up to date Java versions (Jenkins lags), has macOS builds (Jenkins has not) All in all, is great help for reviewers but also for PR submitter (all this IF action covers ITs etc... as many maven projects does not run ITs in GH action yet, about to clean up) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas edited a comment on pull request #9: [MINSTALL-164] - Create GitHub Actions
cstamas edited a comment on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 @aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions: * gives amazingly fast builds (well, off US office hours at least) * gives feedback about "full build" here, on this very page (makes easier to spot what to review what not) * has up to date Java versions (Jenkins lags), has macOS builds (Jenkins has not) All in all, is great help for reviewers but also for PR submitter (all this IF action covers ITs etc... as many maven projects does not run ITs in GH action yet, about to clean up) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas edited a comment on pull request #9: [MINSTALL-164] - Create GitHub Actions
cstamas edited a comment on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 @aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions: * gives amazingly fast builds (well, off US office hours at least) * gives feedback about "full build" here, on this very page (makes easier to spot what to review what not) * has up to date Java versions (Jenkins lags), has macOS builds (Jenkins has not) All in all, is great help for reviewers but also for PR submitter (all this is action covers ITs etc... as many maven projects does not run ITs in GH action yet, about to clean up) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas commented on pull request #9: [MINSTALL-164] - Create GitHub Actions
cstamas commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 @aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions: * gives amazingly fast builds (well, off US office hours at least) * gives feedback about "full build" here, on this very page (makes easier to spot what to review what not) * has up to date Java versions (Jenkins lags), has macOS builds (Jenkins has not) All in all, is great help for reviewers but also for PR submitter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-testing] cstamas opened a new pull request #19: Get rid of warnings, cleanup
cstamas opened a new pull request #19: URL: https://github.com/apache/maven-plugin-testing/pull/19 Changes: * get rid of unused Plexus XML and properties * sligh updates * use jar-no-fork * remove prerequisite, this is not a maven-plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-deploy-plugin] cstamas closed pull request #14: [MDEPLOY-280] Ability so skip specified classifiers from deploy
cstamas closed pull request #14: URL: https://github.com/apache/maven-deploy-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas merged pull request #130: Updated Redisson and HZ doco
cstamas merged pull request #130: URL: https://github.com/apache/maven-resolver/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #130: Updated Redisson and HZ doco
michael-o commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937678715 > > > @michael-o did you like the video? 😉 I never understood Monty Python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o removed a comment on pull request #130: Updated Redisson and HZ doco
michael-o removed a comment on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937677949 > > > @michael-o did you like the video? 😉 Which? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #130: Updated Redisson and HZ doco
michael-o commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937677949 > > > @michael-o did you like the video? 😉 Which? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] olamy merged pull request #79: Bump junit from 4.13.1 to 4.13.2
olamy merged pull request #79: URL: https://github.com/apache/maven-archetype/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] olamy merged pull request #76: Bump maven-invoker from 3.0.1 to 3.1.0
olamy merged pull request #76: URL: https://github.com/apache/maven-archetype/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-393) Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories some unknown protocol
[
https://issues.apache.org/jira/browse/MENFORCER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425464#comment-17425464
]
Quentin Caillard commented on MENFORCER-393:
I have this message when upgrading to 3.0.0 from 3.0.0-M3
[WARNING] Rule 5: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps
failed with message:
Could not build dependency tree Could not collect dependencies:
com.mac:mac-bc360-custom:jar:9.3.2-SNAPSHOT ()
> Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories
> some unknown protocol
> ---
>
> Key: MENFORCER-393
> URL: https://issues.apache.org/jira/browse/MENFORCER-393
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.0.0
>Reporter: johnny willer gasperi goncalves
>Priority: Major
> Attachments: enforcer_output
>
>
> After upgrading to 3.0.0, it's not possible to validate the POM anymore, an
> error like
> {code:java}
> Could not build dependency tree Could not collect dependencies:
> {jarname}{code}
> happens.
>
> I'm attaching the `mvn validate -X` dump (i have omitted some jars from the
> output)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-resolver] cstamas commented on pull request #130: Updated Redisson and HZ doco
cstamas commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937647249 @michael-o did you like the video? :wink: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #130: Updated Redisson and HZ doco
cstamas commented on a change in pull request #130:
URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724033997
##
File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm
##
@@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock
implementations are the follo
${esc.hash}${esc.hash} Open Issues/Notes
-- It only works when Sisu DI is used and not the bundled `AetherModule` or
- `ServiceLocator` (Maven uses Sisu dependency injection).
- Usage from plugins has not been tested yet.
- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
of dependency injection.
+${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators
+
+To use this implementation within your project, depending on how you
integrate, you have following options:
+- If you use Sisu DI, then all you need is to provide this module (and it's
dependencies) on classpath and you are done.
+- If you use Guice, you need to add this module (and it's dependencies)
upfront, and bind them explicitly.
Review comment:
https://www.youtube.com/watch?v=O6UaU_Dzysc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #130: Updated Redisson and HZ doco
cstamas commented on a change in pull request #130:
URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724033873
##
File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm
##
@@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock
implementations are the follo
${esc.hash}${esc.hash} Open Issues/Notes
-- It only works when Sisu DI is used and not the bundled `AetherModule` or
- `ServiceLocator` (Maven uses Sisu dependency injection).
- Usage from plugins has not been tested yet.
- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
of dependency injection.
+${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators
+
+To use this implementation within your project, depending on how you
integrate, you have following options:
+- If you use Sisu DI, then all you need is to provide this module (and it's
dependencies) on classpath and you are done.
Review comment:
https://www.youtube.com/watch?v=O6UaU_Dzysc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #130: Updated Redisson and HZ doco
michael-o commented on a change in pull request #130:
URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724030140
##
File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm
##
@@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock
implementations are the follo
${esc.hash}${esc.hash} Open Issues/Notes
-- It only works when Sisu DI is used and not the bundled `AetherModule` or
- `ServiceLocator` (Maven uses Sisu dependency injection).
- Usage from plugins has not been tested yet.
- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
of dependency injection.
+${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators
+
+To use this implementation within your project, depending on how you
integrate, you have following options:
+- If you use Sisu DI, then all you need is to provide this module (and it's
dependencies) on classpath and you are done.
Review comment:
its
##
File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm
##
@@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock
implementations are the follo
${esc.hash}${esc.hash} Open Issues/Notes
-- It only works when Sisu DI is used and not the bundled `AetherModule` or
- `ServiceLocator` (Maven uses Sisu dependency injection).
- Usage from plugins has not been tested yet.
- The `furnace-maven-plugin` does not work this implementation because it uses
`ServiceLocator` instead
of dependency injection.
+${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators
+
+To use this implementation within your project, depending on how you
integrate, you have following options:
+- If you use Sisu DI, then all you need is to provide this module (and it's
dependencies) on classpath and you are done.
+- If you use Guice, you need to add this module (and it's dependencies)
upfront, and bind them explicitly.
Review comment:
its
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #129: Update build plugins
cstamas commented on a change in pull request #129: URL: https://github.com/apache/maven-resolver/pull/129#discussion_r724028309 ## File path: pom.xml ## @@ -366,16 +367,23 @@ + + org.apache.maven.plugins + maven-jxr-plugin + 3.1.1 Review comment: This above is in pluginMgmt, and removed the version from one in profile, as it will use the value from pluginMgmt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-693) NPE if URL is not defined in a dependency
[
https://issues.apache.org/jira/browse/MJAVADOC-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425448#comment-17425448
]
Roberto Benedetti commented on MJAVADOC-693:
I tried the latest snapshot and it works fine.
> NPE if URL is not defined in a dependency
> -
>
> Key: MJAVADOC-693
> URL: https://issues.apache.org/jira/browse/MJAVADOC-693
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.3.1
> Environment: Windows 10, Temurin JDK 1.8.0_302, Maven 3.8.2
>Reporter: Roberto Benedetti
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.3.2
>
> Attachments: npe-test.zip
>
>
> Same as MJAVADOC-686 but version is 3.3.1.
> Test case attached. Just run
> {noformat}
> mvn install
> {noformat}
> and then
> {noformat}
> mvn javadoc:javadoc
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-resolver] cstamas opened a new pull request #130: Updated Redisson and HZ doco
cstamas opened a new pull request #130: URL: https://github.com/apache/maven-resolver/pull/130 Make it clear that "it only works with Sisu" is meant for integrators, not "end users" wishing to use them with Maven. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-204) Add a SessionData#computeIfAbsent method
[ https://issues.apache.org/jira/browse/MRESOLVER-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MRESOLVER-204. - Resolution: Fixed > Add a SessionData#computeIfAbsent method > > > Key: MRESOLVER-204 > URL: https://issues.apache.org/jira/browse/MRESOLVER-204 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 1.7.3 > > > See https://github.com/apache/maven/pull/531#discussion_r705635537 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-install-plugin] cstamas commented on pull request #9: [MINSTALL-164] - Create GitHub Actions
cstamas commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937584306 Pls pls merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-deploy-plugin] cstamas commented on pull request #18: Update plugin
cstamas commented on pull request #18: URL: https://github.com/apache/maven-deploy-plugin/pull/18#issuecomment-937583034 Superseded by https://github.com/apache/maven-deploy-plugin/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
