date:20211118

[GitHub] [maven-archetype] dependabot[bot] opened a new pull request #85: Bump groovy from 2.4.16 to 3.0.9

2021-11-18 Thread GitBox



dependabot[bot] opened a new pull request #85:
URL: https://github.com/apache/maven-archetype/pull/85


   Bumps [groovy](https://github.com/apache/groovy) from 2.4.16 to 3.0.9.
   
   Commits
   
   See full diff in https://github.com/apache/groovy/commits;>compare view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.groovy:groovy=maven=2.4.16=3.0.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-install-plugin] slawekjaranowski commented on a change in pull request #15: [MINSTALL-115] Install At End feature (no extension)

2021-11-18 Thread GitBox



slawekjaranowski commented on a change in pull request #15:
URL: 
https://github.com/apache/maven-install-plugin/pull/15#discussion_r752748545



##
File path: src/main/java/org/apache/maven/plugins/install/InstallMojo.java
##
@@ -91,53 +86,68 @@
 public void execute()
 throws MojoExecutionException, MojoFailureException
 {
+
+final String projectKey = project.getGroupId() + ":" + 
project.getArtifactId() + ":" + project.getVersion();
 boolean addedInstallRequest = false;
 if ( skip )
 {
+getPluginContext().put( INSTALL_PROCESSED_MARKER, Boolean.FALSE );
 getLog().info( "Skipping artifact installation" );
 }
 else
 {
-// CHECKSTYLE_OFF: LineLength
-ProjectInstallerRequest projectInstallerRequest =
-new ProjectInstallerRequest().setProject( project );
-// CHECKSTYLE_ON: LineLength
-
 if ( !installAtEnd )
 {
-installProject( session.getProjectBuildingRequest(), 
projectInstallerRequest );
+installProject( project );
 }
 else
 {
-INSTALLREQUESTS.add( projectInstallerRequest );
+getPluginContext().put( INSTALL_PROCESSED_MARKER, Boolean.TRUE 
);
 addedInstallRequest = true;
 }
 }
 
-boolean projectsReady = READYPROJECTSCOUNTER.incrementAndGet() == 
reactorProjects.size();
-if ( projectsReady )
+if ( allProjectsMarked() )
 {
-synchronized ( INSTALLREQUESTS )
+for ( MavenProject reactorProject : reactorProjects )
 {
-while ( !INSTALLREQUESTS.isEmpty() )
+Map pluginContext = session.getPluginContext( 
pluginDescriptor, reactorProject );
+Boolean install = (Boolean) pluginContext.get( 
INSTALL_PROCESSED_MARKER );
+if ( !install )
 {
-installProject( session.getProjectBuildingRequest(), 
INSTALLREQUESTS.remove( 0 ) );
+getLog().info( "Project " + projectKey + " skipped 
install" );

Review comment:
   `projectKey` should be computed from `reactorProject` in this place
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 commented on pull request #396: [SUREFIRE-1957] Get rid of maven-artifact-transfer

2021-11-18 Thread GitBox



Tibor17 commented on pull request #396:
URL: https://github.com/apache/maven-surefire/pull/396#issuecomment-973378093


   @slawekjaranowski 
   Thx for contributing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1827) The console output is not flushed

2021-11-18 Thread Ian Springer (Jira)



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446201#comment-17446201
 ] 

Ian Springer commented on SUREFIRE-1827:


I think we are also encountering this issue. We have a suite of 2000 unit tests 
that is consuming over 2GB of heap. We are running 3.0.0-M5.

 

I wasted quite a few hours debugging why our unit tests were running out of 
heap. Would you please release 3.0.0-M6, so we can get a fix for this?

> The console output is not flushed
> -
>
> Key: SUREFIRE-1827
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1827
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, process 
> forking
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M6
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [maven-surefire] Tibor17 commented on pull request #393: [SUREFIRE-1954] move inner class ProviderList to upper level

2021-11-18 Thread GitBox



Tibor17 commented on pull request #393:
URL: https://github.com/apache/maven-surefire/pull/393#issuecomment-973349950


   @slawekjaranowski 
   Pls rebase to remote master and resolve the conflicts in 
`AbstractSurefireMojo` and `AbstractSurefireMojoTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (SUREFIRE-1957) Get rid of maven-artifact-transfer

2021-11-18 Thread Tibor Digana (Jira)



 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed SUREFIRE-1957.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=189b0de398814ec669dcae06db59fcac8989d0bb

> Get rid of maven-artifact-transfer
> --
>
> Key: SUREFIRE-1957
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1957
> Project: Maven Surefire
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> It looks like is used only in 
> {{org.apache.maven.plugin.surefire.SurefireDependencyResolver}}
>  
> Allows migration to Maven 3.1+



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [maven-surefire] Tibor17 merged pull request #396: [SUREFIRE-1957] Get rid of maven-artifact-transfer

2021-11-18 Thread GitBox



Tibor17 merged pull request #396:
URL: https://github.com/apache/maven-surefire/pull/396


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SUREFIRE-1954) Fail on multiple test framework

2021-11-18 Thread Tibor Digana (Jira)



 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1954:
---
Fix Version/s: 3.0.0-M6

> Fail on multiple test framework
> ---
>
> Key: SUREFIRE-1954
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1954
> Project: Maven Surefire
>  Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> When multiple test frameworks are present on project classpath surefire 
> chooses one framework for running test.
> During automatically provider discover some of type test can be *skipped* 
> without any knowledge and information for developer.
> It is danger situation than developer can add *second* test framework to 
> project and in the result some of test will be *skipped silently.*
> We can force usage one or more needed providers by adding those to plugin 
> dependency and we can have control on executing test.
> h3. Proposition
> - add options {{failOnMultipleFrameworks}} *false* by default
> h3. Scenario 1 - default
> h4. when
>  - {{failOnMultipleFrameworks = *false*}}
>  - many tests framework on classpath
>  - no providers on plugin dependency
> h4. then
>  - current behavior - choose first provider with warning about skipped elses
> h3. Scenario 2
> h4. when
>  - {{failOnMultipleFrameworks = *true*}}
>  - many tests framework on classpath
>  - no providers on plugin dependency
> h4. then
>  - fail plugin execution with reason
> h3. Scenario 3
> h4. when
>  - many tests framework on classpath
>  - selected providers on plugin dependency
> h4. then
>  - ignore {{failOnMultipleFrameworks}}
>  - use providers from dependency list, no warning



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Assigned] (SUREFIRE-1954) Fail on multiple test framework

2021-11-18 Thread Tibor Digana (Jira)



 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana reassigned SUREFIRE-1954:
--

Assignee: Tibor Digana

> Fail on multiple test framework
> ---
>
> Key: SUREFIRE-1954
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1954
> Project: Maven Surefire
>  Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Assignee: Tibor Digana
>Priority: Major
>
> When multiple test frameworks are present on project classpath surefire 
> chooses one framework for running test.
> During automatically provider discover some of type test can be *skipped* 
> without any knowledge and information for developer.
> It is danger situation than developer can add *second* test framework to 
> project and in the result some of test will be *skipped silently.*
> We can force usage one or more needed providers by adding those to plugin 
> dependency and we can have control on executing test.
> h3. Proposition
> - add options {{failOnMultipleFrameworks}} *false* by default
> h3. Scenario 1 - default
> h4. when
>  - {{failOnMultipleFrameworks = *false*}}
>  - many tests framework on classpath
>  - no providers on plugin dependency
> h4. then
>  - current behavior - choose first provider with warning about skipped elses
> h3. Scenario 2
> h4. when
>  - {{failOnMultipleFrameworks = *true*}}
>  - many tests framework on classpath
>  - no providers on plugin dependency
> h4. then
>  - fail plugin execution with reason
> h3. Scenario 3
> h4. when
>  - many tests framework on classpath
>  - selected providers on plugin dependency
> h4. then
>  - ignore {{failOnMultipleFrameworks}}
>  - use providers from dependency list, no warning



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



michael-o commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-973305961


   > I think we said and concluded that the threadSafe annotation set to false 
doesn't remove the warning. Whether the plugin(s) are actually threadSafe is 
another topic imho and was not discussed here or did I miss someting?
   
   Correct


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



Lonzak commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-973302748


   I think we said and concluded that the threadSafe annotation set to false 
doesn't remove the warning. Whether the plugin(s) are actually threadSafe is 
another topic imho and was not discussed here or did I miss someting?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (MRESOLVER-225) Shared GitHub Actions

2021-11-18 Thread Slawomir Jaranowski (Jira)

Slawomir Jaranowski created MRESOLVER-225:
-

 Summary: Shared GitHub Actions
 Key: MRESOLVER-225
 URL: https://issues.apache.org/jira/browse/MRESOLVER-225
 Project: Maven Resolver
  Issue Type: Improvement
  Components: Ant Tasks
Reporter: Slawomir Jaranowski






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [maven-invoker-plugin] famod commented on pull request #67: Bump groovy-all from 3.0.8 to 3.0.9

2021-11-18 Thread GitBox



famod commented on pull request #67:
URL: 
https://github.com/apache/maven-invoker-plugin/pull/67#issuecomment-973224310


    for merging this (and for a release not so far in the future), because 
it's needed for Java 18 compatibility.
   
   I just had to update it manually in Quarkus: 
https://github.com/quarkusio/quarkus/pull/21549


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MTOOLCHAINS-39) Can't unzip/unjar maven-toolchain-1.0.jar that is available at Maven Central

2021-11-18 Thread Michael Osipov (Jira)



[ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446128#comment-17446128
 ] 

Michael Osipov commented on MTOOLCHAINS-39:
---

For reference:
{noformat}
$ ldd /usr/bin/unzip
/usr/bin/unzip:
libarchive.so.7 => /usr/lib/libarchive.so.7 (0x80025)
libc.so.7 => /lib/libc.so.7 (0x800323000)
libz.so.6 => /lib/libz.so.6 (0x80071b000)
libbz2.so.4 => /usr/lib/libbz2.so.4 (0x800737000)
liblzma.so.5 => /usr/lib/liblzma.so.5 (0x80074d000)
libbsdxml.so.4 => /lib/libbsdxml.so.4 (0x800779000)
libcrypto.so.111 => /lib/libcrypto.so.111 (0x8007a6000)
libmd.so.6 => /lib/libmd.so.6 (0x800a98000)
libthr.so.3 => /lib/libthr.so.3 (0x800ab6000)
{noformat}

> Can't unzip/unjar maven-toolchain-1.0.jar that is available at Maven Central
> 
>
> Key: MTOOLCHAINS-39
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-39
> Project: Maven Toolchains Plugin
>  Issue Type: Bug
>Affects Versions: 1.0
>Reporter: Thomas Cunningham
>Priority: Major
>
> jar tvf maven-toolchain-1.0.jar that is available from maven central reports 
> reasonable results 
> However
> jar xvf doesn't work
> ❯ jar xvf maven-toolchain-1.0.jar
>  inflated: META-INF
> java.io.IOException: META-INF : could not create directory
>     at jdk.jartool/sun.tools.jar.Main.extractFile(Main.java:1449)
>     at jdk.jartool/sun.tools.jar.Main.extract(Main.java:1364)
>     at jdk.jartool/sun.tools.jar.Main.run(Main.java:409)
>     at jdk.jartool/sun.tools.jar.Main.main(Main.java:1681)
> unzip doesn't work
> ❯ unzip maven-toolchain-1.0.jar
> Archive:  maven-toolchain-1.0.jar
> replace META-INF? [y]es, [n]o, [A]ll, [N]one, [r]ename: A
>   inflating: META-INF
> checkdir error:  META-INF exists but is not directory
>                  unable to process META-INF/MANIFEST.MF.
>   inflating: org
> checkdir error:  org exists but is not directory
>                  unable to process org/apache.
> checkdir error:  org exists but is not directory
>                  unable to process org/apache/maven.
> checkdir error:  org exists but is not directory
>                  unable to process org/apache/maven/toolchain.
> checkdir error:  org exists but is not directory
>                  unable to process org/apache/maven/toolchain/java.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/java/DefaultJavaToolchainFactory.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/java/JavaToolChain.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/java/DefaultJavaToolChain.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/ToolchainManagerPrivate.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/DefaultToolchain.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/ToolchainPrivate.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/MisconfiguredToolchainException.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/ToolchainManager.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/ToolchainFactory$1.class.
> checkdir error:  org exists but is not directory
>                  unable to process org/apache/maven/toolchain/model.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/model/ToolchainModel.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/model/PersistedToolchains.class.
> checkdir error:  org exists but is not directory
>                  unable to process org/apache/maven/toolchain/model/io.
> checkdir error:  org exists but is not directory
>                  unable to process org/apache/maven/toolchain/model/io/xpp3.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Reader.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
> org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Writer.class.
> checkdir error:  org exists but is not directory
>                  unable to process 
>

[jira] [Comment Edited] (MTOOLCHAINS-39) Can't unzip/unjar maven-toolchain-1.0.jar that is available at Maven Central

2021-11-18 Thread Michael Osipov (Jira)



[ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446123#comment-17446123
 ] 

Michael Osipov edited comment on MTOOLCHAINS-39 at 11/18/21, 8:01 PM:
--

Well, I can confirm this and thanks to you I learned a bit more about ZIP 
today. Lets dive into the analysis:

My setup:
{noformat}
osipovmi@deblndw011x:/tmp/maven-toolchains
$ uname -a
FreeBSD deblndw011x.ad001.siemens.net 12.2-STABLE FreeBSD 12.2-STABLE #0: Thu 
Sep 23 18:58:50 CEST 2021
osipovmi@deblndw011x:/tmp/maven-toolchains
$ which unzip
/usr/bin/unzip
osipovmi@deblndw011x:/tmp/maven-toolchains
$ pkg which /usr/local/bin/zipdetails
/usr/local/bin/zipdetails was installed by package perl5-5.30.3_1
osipovmi@deblndw011x:/tmp/maven-toolchains
$ java -version
openjdk version "1.8.0_302"
OpenJDK Runtime Environment (build 1.8.0_302-b08)
OpenJDK 64-Bit Server VM (build 25.302-b08, mixed mode)
{noformat}

Lets unzip first:
{noformat}
$ unzip maven-toolchain-1.0.jar
Archive:  maven-toolchain-1.0.jar
 extracting: META-INF
 extracting: META-INF/MANIFEST.MF
 extracting: org
 extracting: org/apache
 extracting: org/apache/maven
 extracting: org/apache/maven/toolchain
 extracting: org/apache/maven/toolchain/java
 extracting: org/apache/maven/toolchain/java/DefaultJavaToolchainFactory.class
 extracting: org/apache/maven/toolchain/java/JavaToolChain.class
 extracting: org/apache/maven/toolchain/java/DefaultJavaToolChain.class
 extracting: org/apache/maven/toolchain/ToolchainManagerPrivate.class
 extracting: org/apache/maven/toolchain/DefaultToolchain.class
 extracting: org/apache/maven/toolchain/ToolchainPrivate.class
 extracting: org/apache/maven/toolchain/MisconfiguredToolchainException.class
 extracting: org/apache/maven/toolchain/ToolchainManager.class
 extracting: org/apache/maven/toolchain/ToolchainFactory$1.class
 extracting: org/apache/maven/toolchain/model
 extracting: org/apache/maven/toolchain/model/ToolchainModel.class
 extracting: org/apache/maven/toolchain/model/PersistedToolchains.class
 extracting: org/apache/maven/toolchain/model/io
 extracting: org/apache/maven/toolchain/model/io/xpp3
 extracting: 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Reader.class
 extracting: 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Writer.class
 extracting: 
org/apache/maven/toolchain/RequirementMatcherFactory$ExactMatcher.class
 extracting: org/apache/maven/toolchain/Toolchain.class
 extracting: org/apache/maven/toolchain/RequirementMatcherFactory.class
 extracting: org/apache/maven/toolchain/RequirementMatcherFactory$1.class
 extracting: org/apache/maven/toolchain/ToolchainManagerPrivate$1.class
 extracting: org/apache/maven/toolchain/DefaultToolchainManager.class
 extracting: org/apache/maven/toolchain/ToolchainFactory.class
 extracting: org/apache/maven/toolchain/ToolchainManager$1.class
 extracting: 
org/apache/maven/toolchain/RequirementMatcherFactory$VersionMatcher.class
 extracting: org/apache/maven/toolchain/RequirementMatcher.class
 extracting: META-INF/plexus
 extracting: META-INF/plexus/components.xml
 extracting: META-INF/maven
 extracting: META-INF/maven/org.apache.maven
 extracting: META-INF/maven/org.apache.maven/maven-toolchain
 extracting: META-INF/maven/org.apache.maven/maven-toolchain/pom.xml
 extracting: META-INF/maven/org.apache.maven/maven-toolchain/pom.properties
osipovmi@deblndw011x:/tmp/maven-toolchains
$ unzip maven-toolchain-2.0.9.jar
Archive:  maven-toolchain-2.0.9.jar
   creating: META-INF/
 extracting: META-INF/MANIFEST.MF
 extracting: META-INF/LICENSE
 extracting: META-INF/NOTICE
   creating: META-INF/plexus/
 extracting: META-INF/plexus/components.xml
   creating: org/
   creating: org/apache/
   creating: org/apache/maven/
   creating: org/apache/maven/toolchain/
 extracting: org/apache/maven/toolchain/DefaultToolchain.class
 extracting: org/apache/maven/toolchain/DefaultToolchainManager.class
   creating: org/apache/maven/toolchain/java/
 extracting: org/apache/maven/toolchain/java/DefaultJavaToolChain.class
 extracting: org/apache/maven/toolchain/java/DefaultJavaToolchainFactory.class
 extracting: org/apache/maven/toolchain/java/JavaToolChain.class
 extracting: org/apache/maven/toolchain/MisconfiguredToolchainException.class
   creating: org/apache/maven/toolchain/model/
   creating: org/apache/maven/toolchain/model/io/
   creating: org/apache/maven/toolchain/model/io/xpp3/
 extracting: 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Reader.class
 extracting: 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Writer.class
 extracting: org/apache/maven/toolchain/model/PersistedToolchains.class
 extracting: org/apache/maven/toolchain/model/ToolchainModel.class
 extracting: org/apache/maven/toolchain/RequirementMatcher.class
 extracting: org/apache/maven/toolchain/RequirementMatcherFactory$1.class
 extracting:

[jira] [Commented] (MTOOLCHAINS-39) Can't unzip/unjar maven-toolchain-1.0.jar that is available at Maven Central

2021-11-18 Thread Michael Osipov (Jira)



[ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446123#comment-17446123
 ] 

Michael Osipov commented on MTOOLCHAINS-39:
---

Well, I can confirm this and thanks to you I learned a bit more about ZIP 
today. Lets dive into the analysis:

My setup:
{noformat}
osipovmi@deblndw011x:/tmp/maven-toolchains
$ uname -a
FreeBSD deblndw011x.ad001.siemens.net 12.2-STABLE FreeBSD 12.2-STABLE #0: Thu 
Sep 23 18:58:50 CEST 2021
osipovmi@deblndw011x:/tmp/maven-toolchains
$ which unzip
/usr/bin/unzip
osipovmi@deblndw011x:/tmp/maven-toolchains
$ pkg which /usr/local/bin/zipdetails
/usr/local/bin/zipdetails was installed by package perl5-5.30.3_1
osipovmi@deblndw011x:/tmp/maven-toolchains
$ java -version
openjdk version "1.8.0_302"
OpenJDK Runtime Environment (build 1.8.0_302-b08)
OpenJDK 64-Bit Server VM (build 25.302-b08, mixed mode)
{noformat}

Lets unzip first:
{noformat}
$ unzip maven-toolchain-1.0.jar
Archive:  maven-toolchain-1.0.jar
 extracting: META-INF
 extracting: META-INF/MANIFEST.MF
 extracting: org
 extracting: org/apache
 extracting: org/apache/maven
 extracting: org/apache/maven/toolchain
 extracting: org/apache/maven/toolchain/java
 extracting: org/apache/maven/toolchain/java/DefaultJavaToolchainFactory.class
 extracting: org/apache/maven/toolchain/java/JavaToolChain.class
 extracting: org/apache/maven/toolchain/java/DefaultJavaToolChain.class
 extracting: org/apache/maven/toolchain/ToolchainManagerPrivate.class
 extracting: org/apache/maven/toolchain/DefaultToolchain.class
 extracting: org/apache/maven/toolchain/ToolchainPrivate.class
 extracting: org/apache/maven/toolchain/MisconfiguredToolchainException.class
 extracting: org/apache/maven/toolchain/ToolchainManager.class
 extracting: org/apache/maven/toolchain/ToolchainFactory$1.class
 extracting: org/apache/maven/toolchain/model
 extracting: org/apache/maven/toolchain/model/ToolchainModel.class
 extracting: org/apache/maven/toolchain/model/PersistedToolchains.class
 extracting: org/apache/maven/toolchain/model/io
 extracting: org/apache/maven/toolchain/model/io/xpp3
 extracting: 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Reader.class
 extracting: 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Writer.class
 extracting: 
org/apache/maven/toolchain/RequirementMatcherFactory$ExactMatcher.class
 extracting: org/apache/maven/toolchain/Toolchain.class
 extracting: org/apache/maven/toolchain/RequirementMatcherFactory.class
 extracting: org/apache/maven/toolchain/RequirementMatcherFactory$1.class
 extracting: org/apache/maven/toolchain/ToolchainManagerPrivate$1.class
 extracting: org/apache/maven/toolchain/DefaultToolchainManager.class
 extracting: org/apache/maven/toolchain/ToolchainFactory.class
 extracting: org/apache/maven/toolchain/ToolchainManager$1.class
 extracting: 
org/apache/maven/toolchain/RequirementMatcherFactory$VersionMatcher.class
 extracting: org/apache/maven/toolchain/RequirementMatcher.class
 extracting: META-INF/plexus
 extracting: META-INF/plexus/components.xml
 extracting: META-INF/maven
 extracting: META-INF/maven/org.apache.maven
 extracting: META-INF/maven/org.apache.maven/maven-toolchain
 extracting: META-INF/maven/org.apache.maven/maven-toolchain/pom.xml
 extracting: META-INF/maven/org.apache.maven/maven-toolchain/pom.properties
osipovmi@deblndw011x:/tmp/maven-toolchains
$ unzip maven-toolchain-2.0.9.jar
Archive:  maven-toolchain-2.0.9.jar
   creating: META-INF/
 extracting: META-INF/MANIFEST.MF
 extracting: META-INF/LICENSE
 extracting: META-INF/NOTICE
   creating: META-INF/plexus/
 extracting: META-INF/plexus/components.xml
   creating: org/
   creating: org/apache/
   creating: org/apache/maven/
   creating: org/apache/maven/toolchain/
 extracting: org/apache/maven/toolchain/DefaultToolchain.class
 extracting: org/apache/maven/toolchain/DefaultToolchainManager.class
   creating: org/apache/maven/toolchain/java/
 extracting: org/apache/maven/toolchain/java/DefaultJavaToolChain.class
 extracting: org/apache/maven/toolchain/java/DefaultJavaToolchainFactory.class
 extracting: org/apache/maven/toolchain/java/JavaToolChain.class
 extracting: org/apache/maven/toolchain/MisconfiguredToolchainException.class
   creating: org/apache/maven/toolchain/model/
   creating: org/apache/maven/toolchain/model/io/
   creating: org/apache/maven/toolchain/model/io/xpp3/
 extracting: 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Reader.class
 extracting: 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Writer.class
 extracting: org/apache/maven/toolchain/model/PersistedToolchains.class
 extracting: org/apache/maven/toolchain/model/ToolchainModel.class
 extracting: org/apache/maven/toolchain/RequirementMatcher.class
 extracting: org/apache/maven/toolchain/RequirementMatcherFactory$1.class
 extracting: 
org/apache/maven/toolchain/RequirementMatcherFactory$ExactMatcher.class

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #68: [MINVOKER-271] fix detection of setup projects

2021-11-18 Thread GitBox



slawekjaranowski commented on pull request #68:
URL: 
https://github.com/apache/maven-invoker-plugin/pull/68#issuecomment-973096877


   Thanks for approval.
   
   @michael-o do you want to review also? ... or can be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



michael-o commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-973095540


   So, are we dropping this of add thi intentionally saying that we have 
analyzed and concluded that it is not threadsafe?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (MTOOLCHAINS-39) Can't unzip/unjar maven-toolchain-1.0.jar that is available at Maven Central

2021-11-18 Thread Thomas Cunningham (Jira)

Thomas Cunningham created MTOOLCHAINS-39:


 Summary: Can't unzip/unjar maven-toolchain-1.0.jar that is 
available at Maven Central
 Key: MTOOLCHAINS-39
 URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-39
 Project: Maven Toolchains Plugin
  Issue Type: Bug
Affects Versions: 1.0
Reporter: Thomas Cunningham


jar tvf maven-toolchain-1.0.jar that is available from maven central reports 
reasonable results 

However

jar xvf doesn't work

❯ jar xvf maven-toolchain-1.0.jar
 inflated: META-INF
java.io.IOException: META-INF : could not create directory
    at jdk.jartool/sun.tools.jar.Main.extractFile(Main.java:1449)
    at jdk.jartool/sun.tools.jar.Main.extract(Main.java:1364)
    at jdk.jartool/sun.tools.jar.Main.run(Main.java:409)
    at jdk.jartool/sun.tools.jar.Main.main(Main.java:1681)

unzip doesn't work

❯ unzip maven-toolchain-1.0.jar
Archive:  maven-toolchain-1.0.jar
replace META-INF? [y]es, [n]o, [A]ll, [N]one, [r]ename: A
  inflating: META-INF
checkdir error:  META-INF exists but is not directory
                 unable to process META-INF/MANIFEST.MF.
  inflating: org
checkdir error:  org exists but is not directory
                 unable to process org/apache.
checkdir error:  org exists but is not directory
                 unable to process org/apache/maven.
checkdir error:  org exists but is not directory
                 unable to process org/apache/maven/toolchain.
checkdir error:  org exists but is not directory
                 unable to process org/apache/maven/toolchain/java.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/java/DefaultJavaToolchainFactory.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/java/JavaToolChain.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/java/DefaultJavaToolChain.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/ToolchainManagerPrivate.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/DefaultToolchain.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/ToolchainPrivate.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/MisconfiguredToolchainException.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/ToolchainManager.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/ToolchainFactory$1.class.
checkdir error:  org exists but is not directory
                 unable to process org/apache/maven/toolchain/model.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/model/ToolchainModel.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/model/PersistedToolchains.class.
checkdir error:  org exists but is not directory
                 unable to process org/apache/maven/toolchain/model/io.
checkdir error:  org exists but is not directory
                 unable to process org/apache/maven/toolchain/model/io/xpp3.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Reader.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/model/io/xpp3/MavenToolchainsXpp3Writer.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/RequirementMatcherFactory$ExactMatcher.class.
checkdir error:  org exists but is not directory
                 unable to process org/apache/maven/toolchain/Toolchain.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/RequirementMatcherFactory.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/RequirementMatcherFactory$1.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/ToolchainManagerPrivate$1.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/DefaultToolchainManager.class.
checkdir error:  org exists but is not directory
                 unable to process 
org/apache/maven/toolchain/ToolchainFactory.class.
checkdir error:  org exists but is not directory
                 unable to process

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



Lonzak commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-972947699


    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] rmannibucau commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-18 Thread GitBox



rmannibucau commented on a change in pull request #607:
URL: https://github.com/apache/maven/pull/607#discussion_r752312394



##
File path: 
maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java
##
@@ -0,0 +1,200 @@
+package org.apache.maven.caching;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.commons.io.FilenameUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+import org.apache.maven.caching.xml.build.Scm;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.lifecycle.internal.ProjectIndex;
+import org.apache.maven.lifecycle.internal.builder.BuilderCommon;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.plugin.MojoExecution;
+import org.apache.maven.project.MavenProject;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.apache.commons.lang3.StringUtils.removeStart;
+import static org.apache.commons.lang3.StringUtils.trim;
+import static org.apache.maven.artifact.Artifact.LATEST_VERSION;
+import static org.apache.maven.artifact.Artifact.SNAPSHOT_VERSION;
+
+/**
+ * ProjectUtils
+ */
+public class ProjectUtils
+{
+
+private static final List PHASES = Arrays.asList(
+//clean
+"pre-clean", "clean", "post-clean",
+// default
+"validate", "initialize", "generate-sources", "process-sources", 
"generate-resources", "process-resources",
+"compile", "process-classes", "generate-test-sources", 
"process-test-sources", "generate-test-resources",
+"process-test-resources", "test-compile", "process-test-classes", 
"test", "prepare-package", "package",
+"pre-integration-test", "integration-test", 
"post-integration-test", "verify", "install", "deploy",
+//site
+"pre-site", "site", "post-site", "site-deploy" );
+
+/**
+ * @param phase
+ * @param other
+ * @return true if the given phase is later than the other in maven 
lifecycle. Example: isLaterPhase("install",
+ * "clean") returns true;
+ */
+public static boolean isLaterPhase( String phase, String other )
+{
+if ( !PHASES.contains( phase ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + phase 
);
+}
+if ( !PHASES.contains( other ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + other 
);
+}
+
+return PHASES.indexOf( phase ) > PHASES.indexOf( other );
+}
+
+public static boolean isBuilding( Dependency dependency, ProjectIndex 
projectIndex )
+{
+final MavenProject key = new MavenProject();
+key.setGroupId( dependency.getGroupId() );
+key.setArtifactId( dependency.getArtifactId() );
+key.setVersion( dependency.getVersion() );
+return projectIndex.getProjects().containsKey( BuilderCommon.getKey( 
key ) );
+}
+
+public static boolean isPomPackaging( MavenProject project )
+{
+return project.getPackaging().equals( "pom" ) && !new File( getSrcDir( 
project ) ).exists();
+}
+
+public static boolean isPom( Artifact artifact )
+{
+return artifact.getType().equals( "pom" );
+}
+
+public static boolean isPom( Dependency dependency )
+{
+return dependency.getType().equals( "pom" );
+}
+
+public static boolean isSnapshot( String version )
+{
+return version.endsWith( SNAPSHOT_VERSION ) || version.endsWith( 
LATEST_VERSION );
+}
+
+public static String getTargetDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"target" );
+}
+
+public static String getSrcDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"src" );
+}
+
+public static String normalizedName( Artifact artifact )
+{
+
+if (

[GitHub] [maven] gnodet commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-18 Thread GitBox



gnodet commented on a change in pull request #607:
URL: https://github.com/apache/maven/pull/607#discussion_r752292371



##
File path: 
maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java
##
@@ -0,0 +1,200 @@
+package org.apache.maven.caching;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.commons.io.FilenameUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+import org.apache.maven.caching.xml.build.Scm;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.lifecycle.internal.ProjectIndex;
+import org.apache.maven.lifecycle.internal.builder.BuilderCommon;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.plugin.MojoExecution;
+import org.apache.maven.project.MavenProject;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.apache.commons.lang3.StringUtils.removeStart;
+import static org.apache.commons.lang3.StringUtils.trim;
+import static org.apache.maven.artifact.Artifact.LATEST_VERSION;
+import static org.apache.maven.artifact.Artifact.SNAPSHOT_VERSION;
+
+/**
+ * ProjectUtils
+ */
+public class ProjectUtils
+{
+
+private static final List PHASES = Arrays.asList(
+//clean
+"pre-clean", "clean", "post-clean",
+// default
+"validate", "initialize", "generate-sources", "process-sources", 
"generate-resources", "process-resources",
+"compile", "process-classes", "generate-test-sources", 
"process-test-sources", "generate-test-resources",
+"process-test-resources", "test-compile", "process-test-classes", 
"test", "prepare-package", "package",
+"pre-integration-test", "integration-test", 
"post-integration-test", "verify", "install", "deploy",
+//site
+"pre-site", "site", "post-site", "site-deploy" );
+
+/**
+ * @param phase
+ * @param other
+ * @return true if the given phase is later than the other in maven 
lifecycle. Example: isLaterPhase("install",
+ * "clean") returns true;
+ */
+public static boolean isLaterPhase( String phase, String other )
+{
+if ( !PHASES.contains( phase ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + phase 
);
+}
+if ( !PHASES.contains( other ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + other 
);
+}
+
+return PHASES.indexOf( phase ) > PHASES.indexOf( other );
+}
+
+public static boolean isBuilding( Dependency dependency, ProjectIndex 
projectIndex )
+{
+final MavenProject key = new MavenProject();
+key.setGroupId( dependency.getGroupId() );
+key.setArtifactId( dependency.getArtifactId() );
+key.setVersion( dependency.getVersion() );
+return projectIndex.getProjects().containsKey( BuilderCommon.getKey( 
key ) );
+}
+
+public static boolean isPomPackaging( MavenProject project )
+{
+return project.getPackaging().equals( "pom" ) && !new File( getSrcDir( 
project ) ).exists();
+}
+
+public static boolean isPom( Artifact artifact )
+{
+return artifact.getType().equals( "pom" );
+}
+
+public static boolean isPom( Dependency dependency )
+{
+return dependency.getType().equals( "pom" );
+}
+
+public static boolean isSnapshot( String version )
+{
+return version.endsWith( SNAPSHOT_VERSION ) || version.endsWith( 
LATEST_VERSION );
+}
+
+public static String getTargetDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"target" );
+}
+
+public static String getSrcDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"src" );
+}
+
+public static String normalizedName( Artifact artifact )
+{
+
+if (

[GitHub] [maven] gnodet commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-18 Thread GitBox



gnodet commented on a change in pull request #607:
URL: https://github.com/apache/maven/pull/607#discussion_r752289718



##
File path: 
maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java
##
@@ -0,0 +1,200 @@
+package org.apache.maven.caching;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.commons.io.FilenameUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+import org.apache.maven.caching.xml.build.Scm;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.lifecycle.internal.ProjectIndex;
+import org.apache.maven.lifecycle.internal.builder.BuilderCommon;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.plugin.MojoExecution;
+import org.apache.maven.project.MavenProject;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.apache.commons.lang3.StringUtils.removeStart;
+import static org.apache.commons.lang3.StringUtils.trim;
+import static org.apache.maven.artifact.Artifact.LATEST_VERSION;
+import static org.apache.maven.artifact.Artifact.SNAPSHOT_VERSION;
+
+/**
+ * ProjectUtils
+ */
+public class ProjectUtils
+{
+
+private static final List PHASES = Arrays.asList(
+//clean
+"pre-clean", "clean", "post-clean",
+// default
+"validate", "initialize", "generate-sources", "process-sources", 
"generate-resources", "process-resources",
+"compile", "process-classes", "generate-test-sources", 
"process-test-sources", "generate-test-resources",
+"process-test-resources", "test-compile", "process-test-classes", 
"test", "prepare-package", "package",
+"pre-integration-test", "integration-test", 
"post-integration-test", "verify", "install", "deploy",
+//site
+"pre-site", "site", "post-site", "site-deploy" );
+
+/**
+ * @param phase
+ * @param other
+ * @return true if the given phase is later than the other in maven 
lifecycle. Example: isLaterPhase("install",
+ * "clean") returns true;
+ */
+public static boolean isLaterPhase( String phase, String other )
+{
+if ( !PHASES.contains( phase ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + phase 
);
+}
+if ( !PHASES.contains( other ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + other 
);
+}
+
+return PHASES.indexOf( phase ) > PHASES.indexOf( other );
+}
+
+public static boolean isBuilding( Dependency dependency, ProjectIndex 
projectIndex )
+{
+final MavenProject key = new MavenProject();
+key.setGroupId( dependency.getGroupId() );
+key.setArtifactId( dependency.getArtifactId() );
+key.setVersion( dependency.getVersion() );
+return projectIndex.getProjects().containsKey( BuilderCommon.getKey( 
key ) );
+}
+
+public static boolean isPomPackaging( MavenProject project )
+{
+return project.getPackaging().equals( "pom" ) && !new File( getSrcDir( 
project ) ).exists();
+}
+
+public static boolean isPom( Artifact artifact )
+{
+return artifact.getType().equals( "pom" );
+}
+
+public static boolean isPom( Dependency dependency )
+{
+return dependency.getType().equals( "pom" );
+}
+
+public static boolean isSnapshot( String version )
+{
+return version.endsWith( SNAPSHOT_VERSION ) || version.endsWith( 
LATEST_VERSION );
+}
+
+public static String getTargetDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"target" );
+}
+
+public static String getSrcDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"src" );
+}
+
+public static String normalizedName( Artifact artifact )
+{
+
+if (

[GitHub] [maven] rmannibucau commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-18 Thread GitBox



rmannibucau commented on a change in pull request #607:
URL: https://github.com/apache/maven/pull/607#discussion_r752287558



##
File path: 
maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java
##
@@ -0,0 +1,200 @@
+package org.apache.maven.caching;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.commons.io.FilenameUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+import org.apache.maven.caching.xml.build.Scm;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.lifecycle.internal.ProjectIndex;
+import org.apache.maven.lifecycle.internal.builder.BuilderCommon;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.plugin.MojoExecution;
+import org.apache.maven.project.MavenProject;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.apache.commons.lang3.StringUtils.removeStart;
+import static org.apache.commons.lang3.StringUtils.trim;
+import static org.apache.maven.artifact.Artifact.LATEST_VERSION;
+import static org.apache.maven.artifact.Artifact.SNAPSHOT_VERSION;
+
+/**
+ * ProjectUtils
+ */
+public class ProjectUtils
+{
+
+private static final List PHASES = Arrays.asList(
+//clean
+"pre-clean", "clean", "post-clean",
+// default
+"validate", "initialize", "generate-sources", "process-sources", 
"generate-resources", "process-resources",
+"compile", "process-classes", "generate-test-sources", 
"process-test-sources", "generate-test-resources",
+"process-test-resources", "test-compile", "process-test-classes", 
"test", "prepare-package", "package",
+"pre-integration-test", "integration-test", 
"post-integration-test", "verify", "install", "deploy",
+//site
+"pre-site", "site", "post-site", "site-deploy" );
+
+/**
+ * @param phase
+ * @param other
+ * @return true if the given phase is later than the other in maven 
lifecycle. Example: isLaterPhase("install",
+ * "clean") returns true;
+ */
+public static boolean isLaterPhase( String phase, String other )
+{
+if ( !PHASES.contains( phase ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + phase 
);
+}
+if ( !PHASES.contains( other ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + other 
);
+}
+
+return PHASES.indexOf( phase ) > PHASES.indexOf( other );
+}
+
+public static boolean isBuilding( Dependency dependency, ProjectIndex 
projectIndex )
+{
+final MavenProject key = new MavenProject();
+key.setGroupId( dependency.getGroupId() );
+key.setArtifactId( dependency.getArtifactId() );
+key.setVersion( dependency.getVersion() );
+return projectIndex.getProjects().containsKey( BuilderCommon.getKey( 
key ) );
+}
+
+public static boolean isPomPackaging( MavenProject project )
+{
+return project.getPackaging().equals( "pom" ) && !new File( getSrcDir( 
project ) ).exists();
+}
+
+public static boolean isPom( Artifact artifact )
+{
+return artifact.getType().equals( "pom" );
+}
+
+public static boolean isPom( Dependency dependency )
+{
+return dependency.getType().equals( "pom" );
+}
+
+public static boolean isSnapshot( String version )
+{
+return version.endsWith( SNAPSHOT_VERSION ) || version.endsWith( 
LATEST_VERSION );
+}
+
+public static String getTargetDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"target" );
+}
+
+public static String getSrcDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"src" );
+}
+
+public static String normalizedName( Artifact artifact )
+{
+
+if (

[GitHub] [maven] gnodet commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-18 Thread GitBox



gnodet commented on a change in pull request #607:
URL: https://github.com/apache/maven/pull/607#discussion_r752283531



##
File path: 
maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java
##
@@ -0,0 +1,200 @@
+package org.apache.maven.caching;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.commons.io.FilenameUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+import org.apache.maven.caching.xml.build.Scm;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.lifecycle.internal.ProjectIndex;
+import org.apache.maven.lifecycle.internal.builder.BuilderCommon;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.plugin.MojoExecution;
+import org.apache.maven.project.MavenProject;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.apache.commons.lang3.StringUtils.removeStart;
+import static org.apache.commons.lang3.StringUtils.trim;
+import static org.apache.maven.artifact.Artifact.LATEST_VERSION;
+import static org.apache.maven.artifact.Artifact.SNAPSHOT_VERSION;
+
+/**
+ * ProjectUtils
+ */
+public class ProjectUtils
+{
+
+private static final List PHASES = Arrays.asList(
+//clean
+"pre-clean", "clean", "post-clean",
+// default
+"validate", "initialize", "generate-sources", "process-sources", 
"generate-resources", "process-resources",
+"compile", "process-classes", "generate-test-sources", 
"process-test-sources", "generate-test-resources",
+"process-test-resources", "test-compile", "process-test-classes", 
"test", "prepare-package", "package",
+"pre-integration-test", "integration-test", 
"post-integration-test", "verify", "install", "deploy",
+//site
+"pre-site", "site", "post-site", "site-deploy" );
+
+/**
+ * @param phase
+ * @param other
+ * @return true if the given phase is later than the other in maven 
lifecycle. Example: isLaterPhase("install",
+ * "clean") returns true;
+ */
+public static boolean isLaterPhase( String phase, String other )
+{
+if ( !PHASES.contains( phase ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + phase 
);
+}
+if ( !PHASES.contains( other ) )
+{
+throw new IllegalArgumentException( "Unsupported phase: " + other 
);
+}
+
+return PHASES.indexOf( phase ) > PHASES.indexOf( other );
+}
+
+public static boolean isBuilding( Dependency dependency, ProjectIndex 
projectIndex )
+{
+final MavenProject key = new MavenProject();
+key.setGroupId( dependency.getGroupId() );
+key.setArtifactId( dependency.getArtifactId() );
+key.setVersion( dependency.getVersion() );
+return projectIndex.getProjects().containsKey( BuilderCommon.getKey( 
key ) );
+}
+
+public static boolean isPomPackaging( MavenProject project )
+{
+return project.getPackaging().equals( "pom" ) && !new File( getSrcDir( 
project ) ).exists();
+}
+
+public static boolean isPom( Artifact artifact )
+{
+return artifact.getType().equals( "pom" );
+}
+
+public static boolean isPom( Dependency dependency )
+{
+return dependency.getType().equals( "pom" );
+}
+
+public static boolean isSnapshot( String version )
+{
+return version.endsWith( SNAPSHOT_VERSION ) || version.endsWith( 
LATEST_VERSION );
+}
+
+public static String getTargetDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"target" );
+}
+
+public static String getSrcDir( MavenProject project )
+{
+return FilenameUtils.concat( project.getBasedir().getAbsolutePath(), 
"src" );
+}
+
+public static String normalizedName( Artifact artifact )
+{
+
+if (

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



michael-o commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-972895839


   So, basically the outcome of this is a noop?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] gnodet commented on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-18 Thread GitBox



gnodet commented on pull request #610:
URL: https://github.com/apache/maven/pull/610#issuecomment-972869098


   I've changed this PR to a draft until we can get #607 in a more mature state.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MRESOLVER-224) DefaultVersionResolver is inflicting ArtifactNotFoundException for classifiers with SNAPSHOT version

2021-11-18 Thread Tuomas Kiviaho (Jira)



[ 
https://issues.apache.org/jira/browse/MRESOLVER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445842#comment-17445842
 ] 

Tuomas Kiviaho commented on MRESOLVER-224:
--

I found a reference to this oddity via blame. MNG-4955 states that this is a 
remnant from fixing the early days of metadata files (MNG-4452).  It's still 
unclear to me what this exactly fixed even though there is a clear explanation 
for it. 

I can't fathom why it wouldn't have without this fix. Maybe if the metadata for 
{{SNAPSHOT:jar}} was missing all-together then falling back to 
whatever repo with the latest {{SNAPSHOT}} key would function as a fallback, 
but that's not the described use case.



> DefaultVersionResolver is inflicting ArtifactNotFoundException for 
> classifiers with SNAPSHOT version
> 
>
> Key: MRESOLVER-224
> URL: https://issues.apache.org/jira/browse/MRESOLVER-224
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.3
>Reporter: Tuomas Kiviaho
>Priority: Major
>
> I use classifier artifact along with the artifact itself as a dependency in a 
> Maven Invoker Plugin project. The project that calls the invoker has the 
> artifact itself as a dependency, but no reference to the classifier.
> This causes resolving of the maven-metadata.xml for the project itself plus 
> downloading of the dependency artifact.When invoker is called the artifact is 
> already downloaded to the local repo and cached with SNAPSHOT key.
> This causes the DefaultVersionResolver to merge the version information of 
> the SNAPSHOT:jar artifact that is now being resolved with the 
> already downloaded SNAPSHOT key. Since the local version is newer than the 
> repo version the DefaultVersionResolver thinks SNAPSHOT:jar to 
> be outdated thus overriding it with local repo.
> Since the SNAPSHOT:jar doesn't exist in the local repo there 
> are no remote report left to try the DefaultArtifactResolver fails ultimately 
> to ArtifactNotFoundException since there was no download task.
> {code:java}
> [INFO] [DEBUG] Resolving artifact 
> .:jar::-SNAPSHOT from 
> []{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SUREFIRE-1373) Tests annotated with @NotThreadSafe are not executed in isolation

2021-11-18 Thread Jira



[ 
https://issues.apache.org/jira/browse/SUREFIRE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445805#comment-17445805
 ] 

Thierry Ygé commented on SUREFIRE-1373:
---

+1 I was also reading the same as [~sebastiankirsch] , and thought that 
@NotThreadSafe annotated classes would at the end sequentially.

Would be great to solve it indeed.

> Tests annotated with @NotThreadSafe are not executed in isolation
> -
>
> Key: SUREFIRE-1373
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1373
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: Sebastian Kirsch
>Assignee: Tibor Digana
>Priority: Major
> Fix For: Backlog
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The [surefire 
> documentation|http://maven.apache.org/components/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html]
>  states that 
> bq. you can apply the JCIP annotation @net.jcip.annotations.NotThreadSafe on 
> the Java class of JUnit test (pure test class, Suite, Parameterized, etc.) in 
> order to execute it in single Thread instance. The Thread has name 
> maven-surefire-plugin@NotThreadSafe and it is executed at the end of the test 
> run.
> However, the thread is run in parallel to the other tests being executed, 
> which contradicts the documentation and defeats the purpose of running tests 
> sequentially in a single thread.
> See https://github.com/sebastiankirsch/surefire-nonthreadsafe for a test case.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [maven-enforcer] vebits commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

2021-11-18 Thread GitBox



vebits commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-972736245


   Any ETA on a 3.0.1 release with this change? @slachiewicz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



Lonzak commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-972723395


   @pzygielo Yes the warning doesn't go away since it is set to `false`. So 
skipping it or setting it to false (warning-wise) is the same result.  It must 
be set to true to remove the warning. As the warning states using `@threadSafe` 
(without true or false) means it is true and only then the warning goes away. I 
mistakenly thought when setting it to false would also remove the warning since 
a plugin writer explicitly stated the threadsafety...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-scm] pzygielo commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



pzygielo commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-972711956


   I guess in runtime just `plugin.xml` is used, as 
[`@Mojo`](https://github.com/apache/maven-plugin-tools/blob/a6e2a968b1e760328662ac7a0a71df8b15d29803/maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Mojo.java#L36)
 is 
[`RetentionPolicy.CLASS`](https://docs.oracle.com/javase/7/docs/api/java/lang/annotation/RetentionPolicy.html#CLASS)
 only.
   And changes presented here have no impact on `plugin.xml` produced for scm 
plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

2021-11-18 Thread Michael Osipov (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445794#comment-17445794
 ] 

Michael Osipov commented on MNG-7338:
-

[~mthmulders], maybe this could be done in the startup scripts? WDYT?

> Reduce carbon footprint in CI
> -
>
> Key: MNG-7338
> URL: https://issues.apache.org/jira/browse/MNG-7338
> Project: Maven
>  Issue Type: Bug
>Reporter: Jörg Hohwiller
>Priority: Major
>
> MNG-4198 was closed with a simple workaround to add {{-B}} option.
> However, if you look at the real world you will notice that in travis, 
> circle-ci, jenkins, github-actions, etc. 99% of the builds do not use it (not 
> even by defaults from the makers of build templates) and hence 80% of the log 
> files are pure spam and waste:
> {code}
> Progress (2): 0.9/2.6 MB | 160/502 kB
> Progress (2): 0.9/2.6 MB | 164/502 kB
> Progress (2): 0.9/2.6 MB | 168/502 kB
> Progress (2): 0.9/2.6 MB | 172/502 kB
> Progress (2): 0.9/2.6 MB | 176/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 184/502 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 4.1/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 8.2/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 12/196 kB 
> Progress (3): 1.0/2.6 MB | 184/502 kB | 16/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 20/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 25/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 29/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 33/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 37/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 41/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 45/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 49/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 53/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 57/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 61/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 66/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 70/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 74/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 78/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 82/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 86/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 90/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 94/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 98/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 102/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 106/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 111/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 188/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 193/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 197/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 201/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 205/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 209/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 213/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 217/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 221/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 225/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 229/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 233/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 238/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 242/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 246/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 250/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 254/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 258/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 262/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 266/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 270/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 274/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 279/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 283/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 287/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 291/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 295/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 299/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 303/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 307/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 311/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 311/502 kB | 115/196 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 4.1/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 8.2/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 12/220 kB 
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 16/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 20/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 25/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 29/220 kB
> Progress (4): 1.0/2.6

[jira] [Comment Edited] (MNG-7338) Reduce carbon footprint in CI

2021-11-18 Thread Michael Osipov (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445763#comment-17445763
 ] 

Michael Osipov edited comment on MNG-7338 at 11/18/21, 9:41 AM:


 Note {{MAVEN_OPTS}}, this is a misnomer. It is for passing opts to the JVM, 
not Maven. We are thinking to rename this varible to {{MAVEN_JVM_OPTS}} or 
similar. You need {{MAVEN_ARGS}}, see MNG-7193. Anyway, I agree it does not 
make sense to print intermediate progress when stdout is not attached to a 
terminal. Maybe we could wire this with Jansi to autodetect that.


was (Author: michael-o):
 Not {{MAVEN_OPTS}}, this is a misnomer. It is for passing opts to the JVM, not 
Maven. We are thinking to rename this varible to {{MAVEN_JVM_OPTS}} or similar. 
You need {{MAVEN_ARGS}}, see MNG-7193. Anyway, I agree it does not make sense 
to print intermediate progress when stdout is not attached to a terminal. Maybe 
we could wire this with Jansi to autodetect that.

> Reduce carbon footprint in CI
> -
>
> Key: MNG-7338
> URL: https://issues.apache.org/jira/browse/MNG-7338
> Project: Maven
>  Issue Type: Bug
>Reporter: Jörg Hohwiller
>Priority: Major
>
> MNG-4198 was closed with a simple workaround to add {{-B}} option.
> However, if you look at the real world you will notice that in travis, 
> circle-ci, jenkins, github-actions, etc. 99% of the builds do not use it (not 
> even by defaults from the makers of build templates) and hence 80% of the log 
> files are pure spam and waste:
> {code}
> Progress (2): 0.9/2.6 MB | 160/502 kB
> Progress (2): 0.9/2.6 MB | 164/502 kB
> Progress (2): 0.9/2.6 MB | 168/502 kB
> Progress (2): 0.9/2.6 MB | 172/502 kB
> Progress (2): 0.9/2.6 MB | 176/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 184/502 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 4.1/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 8.2/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 12/196 kB 
> Progress (3): 1.0/2.6 MB | 184/502 kB | 16/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 20/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 25/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 29/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 33/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 37/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 41/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 45/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 49/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 53/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 57/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 61/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 66/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 70/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 74/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 78/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 82/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 86/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 90/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 94/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 98/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 102/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 106/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 111/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 188/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 193/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 197/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 201/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 205/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 209/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 213/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 217/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 221/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 225/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 229/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 233/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 238/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 242/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 246/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 250/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 254/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 258/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 262/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 266/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 270/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 274/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 279/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 283/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 287/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 291/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 295/502 kB |

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

2021-11-18 Thread Maarten Mulders (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445775#comment-17445775
 ] 

Maarten Mulders commented on MNG-7338:
--

I like the idea of at least recognising the {{CI}} environment variable. It may 
not be the only way to auto-detect if we should run in batch mode, but at least 
it is one that will work out-of-the-box in many popular environments.

> Reduce carbon footprint in CI
> -
>
> Key: MNG-7338
> URL: https://issues.apache.org/jira/browse/MNG-7338
> Project: Maven
>  Issue Type: Bug
>Reporter: Jörg Hohwiller
>Priority: Major
>
> MNG-4198 was closed with a simple workaround to add {{-B}} option.
> However, if you look at the real world you will notice that in travis, 
> circle-ci, jenkins, github-actions, etc. 99% of the builds do not use it (not 
> even by defaults from the makers of build templates) and hence 80% of the log 
> files are pure spam and waste:
> {code}
> Progress (2): 0.9/2.6 MB | 160/502 kB
> Progress (2): 0.9/2.6 MB | 164/502 kB
> Progress (2): 0.9/2.6 MB | 168/502 kB
> Progress (2): 0.9/2.6 MB | 172/502 kB
> Progress (2): 0.9/2.6 MB | 176/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 184/502 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 4.1/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 8.2/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 12/196 kB 
> Progress (3): 1.0/2.6 MB | 184/502 kB | 16/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 20/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 25/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 29/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 33/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 37/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 41/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 45/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 49/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 53/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 57/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 61/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 66/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 70/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 74/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 78/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 82/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 86/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 90/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 94/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 98/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 102/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 106/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 111/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 188/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 193/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 197/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 201/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 205/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 209/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 213/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 217/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 221/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 225/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 229/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 233/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 238/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 242/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 246/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 250/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 254/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 258/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 262/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 266/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 270/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 274/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 279/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 283/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 287/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 291/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 295/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 299/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 303/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 307/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 311/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 311/502 kB | 115/196 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 4.1/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 8.2/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 12/220 kB 
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 16/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB |

[jira] [Commented] (MRESOLVER-224) DefaultVersionResolver is inflicting ArtifactNotFoundException for classifiers with SNAPSHOT version

2021-11-18 Thread Tuomas Kiviaho (Jira)



[ 
https://issues.apache.org/jira/browse/MRESOLVER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445771#comment-17445771
 ] 

Tuomas Kiviaho commented on MRESOLVER-224:
--

Here are the metadatas to give a clearer picture of the local repo state just 
prior to invoker:integration-test goal execution. It seems that invoker:install 
goal generates (partial???) {{maven-metadata-local.xml}} that I may have 
mistaken as the actual local repository while debugging since they both point 
to the same location in my settings. And for sure that one is missing 
references to pom and other artifacts.

But still it's the weird aftermath that 
{{DefaultVersionResolver::resolveVersion}} applies when the metadataresults 
have been already merged together successfully. It can't be just an 
optimization to see if the metadata of the local repo is newer than the remote 
since that's done already so have no idea what the code snippet in my first 
comment is all about. 

This logic is ultimately causing the failure and invoker is just a contributor 
to the cause.

As a work-a-round I need to start finding an alternative/patch for 
invoker:install for the time being, but it would be nice to get clarification 
on what is going on with the version resolver post processing the snapshot 
classifiers repo in such way.

{code:xml|title=maven-metadata-local.xml}

  mygroupid
  myartifactid
  x.y.z-SNAPSHOT
  

  true

2027135742
  

{code}

{code:xml|title=maven-metadata-repo.xml}


  mygroupid
  myartifactid
  x.y.z-SNAPSHOT
  

  2022.112753
  2

2022112753

  
jar
x.y.z-2022.112753-2
2022112753
  
  
pom
x.y.z-2022.112753-2
2022112753
  
  
myclassifier
jar
x.y.z-2022.112753-2
2022112753
  
  
sources
jar
x.y.z-2022.112753-2
2022112753
  

  

{code}


> DefaultVersionResolver is inflicting ArtifactNotFoundException for 
> classifiers with SNAPSHOT version
> 
>
> Key: MRESOLVER-224
> URL: https://issues.apache.org/jira/browse/MRESOLVER-224
> Project: Maven Resolver
>  Issue Type: Bug
>  Components: Resolver
>Affects Versions: 1.6.3
>Reporter: Tuomas Kiviaho
>Priority: Major
>
> I use classifier artifact along with the artifact itself as a dependency in a 
> Maven Invoker Plugin project. The project that calls the invoker has the 
> artifact itself as a dependency, but no reference to the classifier.
> This causes resolving of the maven-metadata.xml for the project itself plus 
> downloading of the dependency artifact.When invoker is called the artifact is 
> already downloaded to the local repo and cached with SNAPSHOT key.
> This causes the DefaultVersionResolver to merge the version information of 
> the SNAPSHOT:jar artifact that is now being resolved with the 
> already downloaded SNAPSHOT key. Since the local version is newer than the 
> repo version the DefaultVersionResolver thinks SNAPSHOT:jar to 
> be outdated thus overriding it with local repo.
> Since the SNAPSHOT:jar doesn't exist in the local repo there 
> are no remote report left to try the DefaultArtifactResolver fails ultimately 
> to ArtifactNotFoundException since there was no download task.
> {code:java}
> [INFO] [DEBUG] Resolving artifact 
> .:jar::-SNAPSHOT from 
> []{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

2021-11-18 Thread Michael Osipov (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445763#comment-17445763
 ] 

Michael Osipov commented on MNG-7338:
-

 Not {{MAVEN_OPTS}}, this is a misnomer. It is for passing opts to the JVM, not 
Maven. We are thinking to rename this varible to {{MAVEN_JVM_OPTS}} or similar. 
You need {{MAVEN_ARGS}}, see MNG-7193. Anyway, I agree it does not make sense 
to print intermediate progress when stdout is not attached to a terminal.

> Reduce carbon footprint in CI
> -
>
> Key: MNG-7338
> URL: https://issues.apache.org/jira/browse/MNG-7338
> Project: Maven
>  Issue Type: Bug
>Reporter: Jörg Hohwiller
>Priority: Major
>
> MNG-4198 was closed with a simple workaround to add {{-B}} option.
> However, if you look at the real world you will notice that in travis, 
> circle-ci, jenkins, github-actions, etc. 99% of the builds do not use it (not 
> even by defaults from the makers of build templates) and hence 80% of the log 
> files are pure spam and waste:
> {code}
> Progress (2): 0.9/2.6 MB | 160/502 kB
> Progress (2): 0.9/2.6 MB | 164/502 kB
> Progress (2): 0.9/2.6 MB | 168/502 kB
> Progress (2): 0.9/2.6 MB | 172/502 kB
> Progress (2): 0.9/2.6 MB | 176/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 184/502 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 4.1/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 8.2/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 12/196 kB 
> Progress (3): 1.0/2.6 MB | 184/502 kB | 16/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 20/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 25/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 29/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 33/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 37/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 41/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 45/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 49/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 53/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 57/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 61/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 66/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 70/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 74/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 78/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 82/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 86/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 90/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 94/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 98/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 102/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 106/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 111/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 188/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 193/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 197/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 201/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 205/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 209/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 213/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 217/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 221/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 225/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 229/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 233/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 238/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 242/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 246/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 250/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 254/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 258/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 262/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 266/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 270/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 274/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 279/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 283/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 287/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 291/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 295/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 299/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 303/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 307/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 311/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 311/502 kB | 115/196 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 4.1/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 8.2/220 kB
> Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 12/220 kB 
> Progress (4): 1.0/2.6 MB | 311/502

[jira] [Comment Edited] (MNG-7338) Reduce carbon footprint in CI

2021-11-18 Thread Michael Osipov (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445763#comment-17445763
 ] 

Michael Osipov edited comment on MNG-7338 at 11/18/21, 9:14 AM:


 Not {{MAVEN_OPTS}}, this is a misnomer. It is for passing opts to the JVM, not 
Maven. We are thinking to rename this varible to {{MAVEN_JVM_OPTS}} or similar. 
You need {{MAVEN_ARGS}}, see MNG-7193. Anyway, I agree it does not make sense 
to print intermediate progress when stdout is not attached to a terminal. Maybe 
we could wire this with Jansi to autodetect that.


was (Author: michael-o):
 Not {{MAVEN_OPTS}}, this is a misnomer. It is for passing opts to the JVM, not 
Maven. We are thinking to rename this varible to {{MAVEN_JVM_OPTS}} or similar. 
You need {{MAVEN_ARGS}}, see MNG-7193. Anyway, I agree it does not make sense 
to print intermediate progress when stdout is not attached to a terminal.

> Reduce carbon footprint in CI
> -
>
> Key: MNG-7338
> URL: https://issues.apache.org/jira/browse/MNG-7338
> Project: Maven
>  Issue Type: Bug
>Reporter: Jörg Hohwiller
>Priority: Major
>
> MNG-4198 was closed with a simple workaround to add {{-B}} option.
> However, if you look at the real world you will notice that in travis, 
> circle-ci, jenkins, github-actions, etc. 99% of the builds do not use it (not 
> even by defaults from the makers of build templates) and hence 80% of the log 
> files are pure spam and waste:
> {code}
> Progress (2): 0.9/2.6 MB | 160/502 kB
> Progress (2): 0.9/2.6 MB | 164/502 kB
> Progress (2): 0.9/2.6 MB | 168/502 kB
> Progress (2): 0.9/2.6 MB | 172/502 kB
> Progress (2): 0.9/2.6 MB | 176/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 0.9/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 180/502 kB
> Progress (2): 1.0/2.6 MB | 184/502 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 4.1/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 8.2/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 12/196 kB 
> Progress (3): 1.0/2.6 MB | 184/502 kB | 16/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 20/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 25/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 29/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 33/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 37/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 41/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 45/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 49/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 53/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 57/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 61/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 66/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 70/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 74/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 78/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 82/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 86/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 90/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 94/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 98/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 102/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 106/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 111/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 188/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 193/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 197/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 201/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 205/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 209/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 213/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 217/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 221/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 225/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 229/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 233/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 238/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 242/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 246/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 250/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 254/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 258/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 262/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 266/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 270/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 274/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 279/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 283/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 287/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 291/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 295/502 kB | 115/196 kB
> Progress (3): 1.0/2.6 MB | 299/502 kB | 115/196

[GitHub] [maven-scm] pzygielo commented on a change in pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



pzygielo commented on a change in pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#discussion_r752018662



##
File path: 
maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java
##
@@ -31,6 +31,7 @@
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
 import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Mojo;

Review comment:
   I smell unused import.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-scm] pzygielo commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



pzygielo commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-972653112


   @Lonzak - what is your maven version?
   
   I still can't see it being fixed by [current 
changes](85b640113bf9e943534c0f63850bf0a5bd6942fb).
   ```shell
   $ git tag -d v34 ; mvn -V scm:tag -DpushChanges=false 
-DconnectionUrl=scm:git:git://server/repo -Dtag=v34 -T4
   Deleted tag 'v34' (was 0d8d2a7)
   Apache Maven 3.8.3 (ff8e977a158738155dc465c6a97ffaf31982d739)
   Maven home: /usr/local/apps/apache-maven-3.8.3
   Java version: 11.0.13, vendor: Red Hat, Inc., runtime: 
/usr/lib/jvm/java-11-openjdk-11.0.13.0.8-2.fc35.x86_64
   Default locale: en_GB, platform encoding: UTF-8
   OS name: "linux", version: "5.14.17-301.fc35.x86_64", arch: "amd64", family: 
"unix"
   [INFO] Scanning for projects...
   [INFO] 
   [INFO] Using the MultiThreadedBuilder implementation with a thread count of 4
   [INFO] 
   [INFO] < xavier >-
   [INFO] Building Xavier 1-SNAPSHOT
   [INFO] [ jar 
]-
   [WARNING] *
   [WARNING] * Your build is requesting parallel execution, but project  *
   [WARNING] * contains the following plugin(s) that have goals not marked   *
   [WARNING] * as @threadSafe to support parallel building.  *
   [WARNING] * While this /may/ work fine, please look for plugin updates*
   [WARNING] * and/or request plugins be made thread-safe.   *
   [WARNING] * If reporting an issue, report it against the plugin in*
   [WARNING] * question, not against maven-core  *
   [WARNING] *
   [WARNING] The following plugins are not marked @threadSafe in Xavier:
   [WARNING] org.apache.maven.plugins:maven-scm-plugin:1.11.3-SNAPSHOT
   [WARNING] Enable debug to see more precisely which goals are not marked 
@threadSafe.
   [WARNING] *
   [INFO] 
   [INFO] --- maven-scm-plugin:1.11.3-SNAPSHOT:tag (default-cli) @ xavier ---
   [INFO] Final Tag Name: 'v34'
   [INFO] Executing: /bin/sh -c cd '/tmp/xavier' && 'git' 'tag' '-F' 
'/tmp/maven-scm-1378539639.commit' 'v34'
   [INFO] Working directory: /tmp/xavier
   [INFO] Executing: /bin/sh -c cd '/tmp/xavier' && 'git' 'ls-files'
   [INFO] Working directory: /tmp/xavier
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time:  1.867 s (Wall Clock)
   [INFO] Finished at: 2021-11-18T09:41:22+01:00
   [INFO] 

   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (MNG-7338) Reduce carbon footprint in CI

2021-11-18 Thread Jira

Jörg Hohwiller created MNG-7338:
---

 Summary: Reduce carbon footprint in CI
 Key: MNG-7338
 URL: https://issues.apache.org/jira/browse/MNG-7338
 Project: Maven
  Issue Type: Bug
Reporter: Jörg Hohwiller


MNG-4198 was closed with a simple workaround to add {{-B}} option.
However, if you look at the real world you will notice that in travis, 
circle-ci, jenkins, github-actions, etc. 99% of the builds do not use it (not 
even by defaults from the makers of build templates) and hence 80% of the log 
files are pure spam and waste:
{code}
Progress (2): 0.9/2.6 MB | 160/502 kB
Progress (2): 0.9/2.6 MB | 164/502 kB
Progress (2): 0.9/2.6 MB | 168/502 kB
Progress (2): 0.9/2.6 MB | 172/502 kB
Progress (2): 0.9/2.6 MB | 176/502 kB
Progress (2): 0.9/2.6 MB | 180/502 kB
Progress (2): 0.9/2.6 MB | 180/502 kB
Progress (2): 1.0/2.6 MB | 180/502 kB
Progress (2): 1.0/2.6 MB | 184/502 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 4.1/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 8.2/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 12/196 kB 
Progress (3): 1.0/2.6 MB | 184/502 kB | 16/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 20/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 25/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 29/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 33/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 37/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 41/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 45/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 49/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 53/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 57/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 61/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 66/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 70/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 74/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 78/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 82/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 86/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 90/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 94/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 98/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 102/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 106/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 111/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 184/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 188/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 193/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 197/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 201/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 205/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 209/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 213/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 217/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 221/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 225/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 229/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 233/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 238/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 242/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 246/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 250/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 254/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 258/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 262/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 266/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 270/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 274/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 279/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 283/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 287/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 291/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 295/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 299/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 303/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 307/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 311/502 kB | 115/196 kB
Progress (3): 1.0/2.6 MB | 311/502 kB | 115/196 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 4.1/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 8.2/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 12/220 kB 
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 16/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 20/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 25/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 29/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 33/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 37/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 41/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 45/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 49/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 53/220 kB
Progress (4): 1.0/2.6 MB | 311/502 kB | 115/196 kB | 57/220 kB
Progress (4): 1.0/2.6 MB |

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-18 Thread GitBox



Lonzak commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-972638227


   @pzygielo Damn it - initially I had set it to true and only on the tag mojo. 
(Then the warning disappeared). Afterwards I thought lets add it to the parent 
to set it for all mojos and since nobody knew whether they were threadsafe it 
was changed to false (and I didn't test again)... Sorry for the confusion - so 
maybe the goal should be to make it threadSafe ;-)
   I'll try to investigate the issue I had with the parallel execution - must 
be related to something different then ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

42 matches

Mail list logo