[jira] [Commented] (MRELEASE-1066) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows
[ https://issues.apache.org/jira/browse/MRELEASE-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467521#comment-17467521 ] Michael Osipov commented on MRELEASE-1066: -- You are describing a typical Windows problem of exclusive file locking when open. POSIX does not suffer from this. Let's see how far we get. If we have leaks, we must fix them, but we cannot and will not fix Windows. > FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows > --- > > Key: MRELEASE-1066 > URL: https://issues.apache.org/jira/browse/MRELEASE-1066 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare > Environment: Windows >Reporter: Elliotte Rusty Harold >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > Fix For: 3.0.0 > > > This bug is shared (likely because of code copied from one place to another) > between the similar methods in commons IO, codehaus-plexus-utils, and > maven-shared-utils. > I don't have an isolated test case because this bug is platform specific and > I've only seen it in Travis CI builds on Windows using JDK 7 through 15. I > don't have a Windows system handy to test it. However it is reproducible. > Typical code that triggers it is in RestoreBackupPomsPhaseTest in > maven-release: > ``` > // copy poms so tests are valid without clean > File sourceDir = getTestFile( "src/test/resources" + projectPath ); > File testDir = getTestFile( "target/test-classes" + projectPath ); > FileUtils.copyDirectoryStructure( sourceDir, testDir ); > ``` > I don't know whether there might be something weird in the setup of those two > directories that's involved. > Typical error message is: > Caused by: java.nio.file.FileSystemException: > F:\jenkins\jenkins-slave\workspace\maven-box_maven-release_windows@2@2\windows-jdk8-m3.6.x_build\maven-release-manager\target\test-classes\projects\restore-backup-poms\basic-pom\pom.xml: > The process cannot access the file because it is being used by another > process > "The process cannot access the file because it is being used by another > process" I think points to the root of the bug. This is a Windows file system > error message. > Some history is here where I noticed it: > https://github.com/apache/maven-release/pull/42 > In this case, I started with plexus-utils 3.1.0 which worked, upgraded t > plexus-utils 3.3.0, which didn't. And then tried the FileUtils.copyDirectory > from both maven-shared-utils and commons-io, all of which failed in the same > way. > I think this is caused by the use of NIO, which doesn't work quite the same > when copying files on Windows as on Linux and Mac OS X. > Also see https://issues.apache.org/jira/browse/IO-663?filter=-2 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 edited a comment on pull request #422: URL: https://github.com/apache/maven-surefire/pull/422#issuecomment-1003637159 @slawekjaranowski One of our colleagues told me that the Github CI reserves 14GB of disk space. Maybe the problem is that we execute 20 parallel builds. We should try to avoid the duplicates (push, pull_request) which makes 1.4GB per each run configuration. I would propose to additionally overriding the Java version with min and max, means 8 and 17 only, if 10 parallel builds still does not help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on pull request #422: URL: https://github.com/apache/maven-surefire/pull/422#issuecomment-1003637159 @slawekjaranowski One of our colleagues told me that the Github CI reserves 14GB of disk space. Maybe the problem is that we execute 20 parallel builds. We should try to avoid the duplicates (push, pull_request) which makes 1.4GB. I would propose to additionally overriding the Java version with min and max, means 8 and 17 only, if 10 parallel builds still does not help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #424: Surefire shared utils,
Tibor17 edited a comment on pull request #424: URL: https://github.com/apache/maven-surefire/pull/424#issuecomment-1003632660 @slawekjaranowski I agree that comparing the Java version would be more straightaway solution. To get there I had to proceed with the first two commits. The first makes the module `surefire-shared-utils` available to our project with current project version. And then I had to upgrade `commons-lang3` of course. And the third commit is just our method in module `surefire-api`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #424: Surefire shared utils,
Tibor17 commented on pull request #424: URL: https://github.com/apache/maven-surefire/pull/424#issuecomment-1003632660 @slawekjaranowski I agree that comparing the Java version would be more straightaway solution. To get there I had to proceed with the first two commits. The first makes the module `surefire-shared-utils` available to our project with current project version. And then I had to upgrade `comon-lang3` of course. And the third commit is just our method in module `surefire-api`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 opened a new pull request #424: Surefire shared utils,
Tibor17 opened a new pull request #424: URL: https://github.com/apache/maven-surefire/pull/424 We are aiming for an upgrade of the version of `org.apache.maven.surefire.shared.lang3.JavaVersion` which means that we have to install/deploy **current version** of `surefire-shared-utils`. Then we are able to implement the method `isSecurityManagerSupported()` within the module `surefire-api` using the enum `JavaVersion`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1066) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows
[ https://issues.apache.org/jira/browse/MRELEASE-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467513#comment-17467513 ] elharo commented on MRELEASE-1066: -- That commit might be a workaround, but I don't think it gets at the root of the bug though it does suggest what the problem might be. Based on that commit it look as if the problem is that NIO on windows can't copy open files whereas NIO on other platforms and non-NIO solutions can. Ideally this should be fixed so that `FileUtils.copyDirectory` works when files are open, or, at the absolute least, it fails with amore descriptive error message. > FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows > --- > > Key: MRELEASE-1066 > URL: https://issues.apache.org/jira/browse/MRELEASE-1066 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare > Environment: Windows >Reporter: Elliotte Rusty Harold >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > Fix For: 3.0.0 > > > This bug is shared (likely because of code copied from one place to another) > between the similar methods in commons IO, codehaus-plexus-utils, and > maven-shared-utils. > I don't have an isolated test case because this bug is platform specific and > I've only seen it in Travis CI builds on Windows using JDK 7 through 15. I > don't have a Windows system handy to test it. However it is reproducible. > Typical code that triggers it is in RestoreBackupPomsPhaseTest in > maven-release: > ``` > // copy poms so tests are valid without clean > File sourceDir = getTestFile( "src/test/resources" + projectPath ); > File testDir = getTestFile( "target/test-classes" + projectPath ); > FileUtils.copyDirectoryStructure( sourceDir, testDir ); > ``` > I don't know whether there might be something weird in the setup of those two > directories that's involved. > Typical error message is: > Caused by: java.nio.file.FileSystemException: > F:\jenkins\jenkins-slave\workspace\maven-box_maven-release_windows@2@2\windows-jdk8-m3.6.x_build\maven-release-manager\target\test-classes\projects\restore-backup-poms\basic-pom\pom.xml: > The process cannot access the file because it is being used by another > process > "The process cannot access the file because it is being used by another > process" I think points to the root of the bug. This is a Windows file system > error message. > Some history is here where I noticed it: > https://github.com/apache/maven-release/pull/42 > In this case, I started with plexus-utils 3.1.0 which worked, upgraded t > plexus-utils 3.3.0, which didn't. And then tried the FileUtils.copyDirectory > from both maven-shared-utils and commons-io, all of which failed in the same > way. > I think this is caused by the use of NIO, which doesn't work quite the same > when copying files on Windows as on Linux and Mac OS X. > Also see https://issues.apache.org/jira/browse/IO-663?filter=-2 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-mvnd] gnodet commented on issue #291: Daemon crashing when building big project.
gnodet commented on issue #291: URL: https://github.com/apache/maven-mvnd/issues/291#issuecomment-1003614925 > Sorry to bump something so old but have we considered making the `mvnd.maxHeapSize` config default to `null` so that the JVM can decide the Xmx? This will bring it in line with vanilla Maven which leaves the heap size to the JVM unless an explicit `-Xmx` is passed? > > It was a bit frustrating to discover that the daemon is crashing because it is low on memory especially since the observable failure is the lost keepalives instead of an OOM. This is a possibility, could you open a new issue for that ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRELEASE-932) ReleaseFailureException of an artifact with version as a property
[
https://issues.apache.org/jira/browse/MRELEASE-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-932:
Summary: ReleaseFailureException of an artifact with version as a property
(was: ReleaseFailureException of an artifact wich version as a property)
> ReleaseFailureException of an artifact with version as a property
> -
>
> Key: MRELEASE-932
> URL: https://issues.apache.org/jira/browse/MRELEASE-932
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 2.5.1, 2.5.3
> Environment: Maven 3.2.1
> Windows 7
> Intel Core i7
>Reporter: Antoine
>Priority: Major
> Labels: bug
> Attachments: MRELEASE-932.zip
>
>
> After updating the release maven plugin from version 2.0.0 to 2.5.1, I've got
> the following exception:
> {noformat}
> message : Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:2.5.1:prepare (default-cli) on
> project ping-parent: The artifact (com.mycompagny.myapp:myapp-client)
> requires a different version (15.4.0) than what is found (12.2.1) for the
> expression (version.client.tested) in the project
> (com.mycompagny.myapp:myapp-client).
> cause : The artifact (com.mycompagny.myapp:myapp-client) requires a different
> version (15.4.0) than what is found (12.2.1) for the expression
> (version.client.tested) in the project (com.mycompagny.myapp:myapp-client).
> Stack trace :
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-release-plugin:2.5.1:prepare
> (default-cli) on project ping-parent: The artifact
> (fr.generali.gael.ping:ping-injection-client) requires a different version
> (15.4.1-git) than what is found (15.4.0) for the expression
> (version.client.tested) in the project
> (fr.generali.gael.ping:ping-client-test).
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java
> {noformat}
> This error happens in a multi-module application.
> For testing purpose, we depends from an older version of an artefact of the
> same application.
> When the artefact version is an expression (ie. $\{version.client.tested\}),
> the
> [AbstractRewritePomsPhase|http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven.release/maven-release-manager/2.5.1/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java/#545]
> class do a chek.
> If we don't use the expression (i.e. properties), the release is working.
> Maven configuration that fails:
> {code}
>
> 12.1.0
>
>
> ${project.groupId}
> myapp-client
> ${version.client.tested}
>
> {code}
> Maven configuration that is working:
> {code}
>
> ${project.groupId}
> myapp-client
> 12.1.0
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #419: [SUREFIRE-1926] Console logs should be synchronized
Tibor17 commented on a change in pull request #419:
URL: https://github.com/apache/maven-surefire/pull/419#discussion_r777135263
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ReportsMerger.java
##
@@ -0,0 +1,36 @@
+package org.apache.maven.plugin.surefire.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.surefire.api.suite.RunResult;
+
+import java.io.File;
+import java.util.Collection;
+
+/**
+ * This interface is used to merge reports in {@link
org.apache.maven.plugin.surefire.booterclient.ForkStarter}.
+ */
+public interface ReportsMerger
+{
+void runStarting();
+void mergeFromOtherFactories( Collection factories
);
+File getReportsDirectory();
+RunResult close();
Review comment:
The close method is closing the status, no matter that the class name is
factory, it really does closing the reports after JVM exit. But I do not want
to spend time on talking about theory with design patterns. I was aiming for
not giving the developer a chance to call the method I am reimplementing since
this class is polymorphic - it has two usages in ForkStarter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MRELEASE-932) ReleaseFailureException of an artifact wich version as a property
[
https://issues.apache.org/jira/browse/MRELEASE-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-932:
Summary: ReleaseFailureException of an artifact wich version as a property
(was: ReleaseFailureException of an artefact wich version as a property)
> ReleaseFailureException of an artifact wich version as a property
> -
>
> Key: MRELEASE-932
> URL: https://issues.apache.org/jira/browse/MRELEASE-932
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 2.5.1, 2.5.3
> Environment: Maven 3.2.1
> Windows 7
> Intel Core i7
>Reporter: Antoine
>Priority: Major
> Labels: bug
> Attachments: MRELEASE-932.zip
>
>
> After updating the release maven plugin from version 2.0.0 to 2.5.1, I've got
> the following exception:
> {noformat}
> message : Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:2.5.1:prepare (default-cli) on
> project ping-parent: The artifact (com.mycompagny.myapp:myapp-client)
> requires a different version (15.4.0) than what is found (12.2.1) for the
> expression (version.client.tested) in the project
> (com.mycompagny.myapp:myapp-client).
> cause : The artifact (com.mycompagny.myapp:myapp-client) requires a different
> version (15.4.0) than what is found (12.2.1) for the expression
> (version.client.tested) in the project (com.mycompagny.myapp:myapp-client).
> Stack trace :
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-release-plugin:2.5.1:prepare
> (default-cli) on project ping-parent: The artifact
> (fr.generali.gael.ping:ping-injection-client) requires a different version
> (15.4.1-git) than what is found (15.4.0) for the expression
> (version.client.tested) in the project
> (fr.generali.gael.ping:ping-client-test).
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java
> {noformat}
> This error happens in a multi-module application.
> For testing purpose, we depends from an older version of an artefact of the
> same application.
> When the artefact version is an expression (ie. $\{version.client.tested\}),
> the
> [AbstractRewritePomsPhase|http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven.release/maven-release-manager/2.5.1/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java/#545]
> class do a chek.
> If we don't use the expression (i.e. properties), the release is working.
> Maven configuration that fails:
> {code}
>
> 12.1.0
>
>
> ${project.groupId}
> myapp-client
> ${version.client.tested}
>
> {code}
> Maven configuration that is working:
> {code}
>
> ${project.groupId}
> myapp-client
> 12.1.0
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRELEASE-1070) Creating branch from a tag
[ https://issues.apache.org/jira/browse/MRELEASE-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467486#comment-17467486 ] Michael Osipov commented on MRELEASE-1070: -- There is not way, this process is not supported currently. > Creating branch from a tag > -- > > Key: MRELEASE-1070 > URL: https://issues.apache.org/jira/browse/MRELEASE-1070 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Peter Kronenberg >Priority: Major > > What is the correct process for using `release:branch` to create a branch > from a tag in order to create a Hotfix? If I just checkout the tag, the > plugin complains because I have a detached Head. If I checkout the tag with > a temporary branch name, then the plugin creates my new branch, but it also > commits changes to my temp branch, which I really just want to delete > > I'm using a command line like this > `mvn release:branch -DbranchName="peter-test-90.90.90-SNAPSHOT" > -DupdateBranchVersions=true -DupdateWorkingCopyVersions=false > -DreleaseVersion="90.90.90-SNAPSHOT"` > > Is there a way I can just tell it which tag that I want to create a branch > off of? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MRELEASE-938) Need better support for staging release candidates with git and Nexus
[
https://issues.apache.org/jira/browse/MRELEASE-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467484#comment-17467484
]
Michael Osipov commented on MRELEASE-938:
-
I personally don't understand why this complexity is required. Consider you are
voting on release 3.0.5, the vote fails for various reasons, drop the staging
repo, cancel the vote, fix the issue and roll 3.0.6. Versions are cheap. Set
the burned version to archived in JIRA and add all tickets from 3.0.5 to 3.0.6
+ new ones, you are done. This is what we hav been doing with Maven ecosystem
releases for years now.
> Need better support for staging release candidates with git and Nexus
> -
>
> Key: MRELEASE-938
> URL: https://issues.apache.org/jira/browse/MRELEASE-938
> Project: Maven Release Plugin
> Issue Type: Improvement
>Reporter: Christopher Tubbs
>Priority: Major
>
> Use case:
> An ASF project creates git tags which are GPG-signed named "rel/"
> after a release is voted on. If the release passes, the contents of the
> pom.xml files should refer to this final tag, and not any intermediate
> release candidate tag name.
> To avoid pushing the release prior to building a release candidate and
> publishing it to the staging maven repository, the configuration sets
> {{false}} and
> {{true}}, and the tag name is created with
> {{rel/@\{project.version\}}}.
> There is still a risk of a release manager accidentally pushing the tag
> created by the maven-release-plugin, which has the final name, but is not GPG
> signed, and should not be pushed, because it cannot (and should not) change
> once it is.
> What might be useful here is an alternate, intermediate name,
> {{@\{project.version\}}} which can be used as the checkout tag for the
> perform step.
> Alternatively, no tag actually has to be created in this case (a GPG-signed
> tag is manually created later). Unless {{suppressCommitBeforeTag}} is set,
> the perform step can check out from {{HEAD~1}}, instead. An option to skip
> tag creation entirely could work under these circumstances.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MRELEASE-938) Need better support for staging release candidates with git and Nexus
[
https://issues.apache.org/jira/browse/MRELEASE-938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-938:
Fix Version/s: waiting-for-feedback
> Need better support for staging release candidates with git and Nexus
> -
>
> Key: MRELEASE-938
> URL: https://issues.apache.org/jira/browse/MRELEASE-938
> Project: Maven Release Plugin
> Issue Type: Improvement
>Reporter: Christopher Tubbs
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Use case:
> An ASF project creates git tags which are GPG-signed named "rel/"
> after a release is voted on. If the release passes, the contents of the
> pom.xml files should refer to this final tag, and not any intermediate
> release candidate tag name.
> To avoid pushing the release prior to building a release candidate and
> publishing it to the staging maven repository, the configuration sets
> {{false}} and
> {{true}}, and the tag name is created with
> {{rel/@\{project.version\}}}.
> There is still a risk of a release manager accidentally pushing the tag
> created by the maven-release-plugin, which has the final name, but is not GPG
> signed, and should not be pushed, because it cannot (and should not) change
> once it is.
> What might be useful here is an alternate, intermediate name,
> {{@\{project.version\}}} which can be used as the checkout tag for the
> perform step.
> Alternatively, no tag actually has to be created in this case (a GPG-signed
> tag is manually created later). Unless {{suppressCommitBeforeTag}} is set,
> the perform step can check out from {{HEAD~1}}, instead. An option to skip
> tag creation entirely could work under these circumstances.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MRELEASE-948) Add options to verify release based on release.zip
[ https://issues.apache.org/jira/browse/MRELEASE-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-948: Fix Version/s: waiting-for-feedback > Add options to verify release based on release.zip > -- > > Key: MRELEASE-948 > URL: https://issues.apache.org/jira/browse/MRELEASE-948 > Project: Maven Release Plugin > Issue Type: New Feature > Components: perform >Affects Versions: 2.5.3 >Reporter: Robert Scholte >Priority: Major > Fix For: waiting-for-feedback > > > For Apache projects, the release.zip is the official release and not the > scm-tag(!). In such case it is much more important to verify that file, > especially if there generated files like DEPENDENCIES are added, which might > cause the rat-plugin to fail. These failures are not detected when building > based on the tag. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MRELEASE-948) Add options to verify release based on release.zip
[ https://issues.apache.org/jira/browse/MRELEASE-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467483#comment-17467483 ] Michael Osipov commented on MRELEASE-948: - I consider this to be very ASF-specific and partially out of scope for a general plugin. > Add options to verify release based on release.zip > -- > > Key: MRELEASE-948 > URL: https://issues.apache.org/jira/browse/MRELEASE-948 > Project: Maven Release Plugin > Issue Type: New Feature > Components: perform >Affects Versions: 2.5.3 >Reporter: Robert Scholte >Priority: Major > > For Apache projects, the release.zip is the official release and not the > scm-tag(!). In such case it is much more important to verify that file, > especially if there generated files like DEPENDENCIES are added, which might > cause the rat-plugin to fail. These failures are not detected when building > based on the tag. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MRELEASE-1061) Not able to stop version increment in pom.xml with the release prepare
[ https://issues.apache.org/jira/browse/MRELEASE-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1061: - Issue Type: New Feature (was: Bug) > Not able to stop version increment in pom.xml with the release prepare > --- > > Key: MRELEASE-1061 > URL: https://issues.apache.org/jira/browse/MRELEASE-1061 > Project: Maven Release Plugin > Issue Type: New Feature > Components: prepare >Affects Versions: 2.5.3 >Reporter: Nikunj Ramani >Priority: Major > > Hello Team, > Here is my requirement: > I have two profiles (32 Bit and 64 Bit) in my pom.xml. And I want them to be > executed one by one and expecting (tasks release prepare and release perform) > them to push build artifacts in artifact repository. > * Expected points : > ** For 32 Bit and 64 Bit separate .jar will be created with the same version > (1.0) as per below expected directory structure. > -->ABC > --> 32 Bit > --> 1.0 > ABC_32Bit-1.0.jar > --> 64 Bit > --> 1.0 > ABC_64Bit-1.0.jar > * Problem facing : > ** We have a Bamboo plan with two tasks. > ** 1. for 32 Bit -->release:prepare release:perform -P "32Bit,!64Bit" > ** 2. for 64 Bit -->release:prepare release:perform -P "!32Bit,64Bit" > ** But, when task 1 for 32 Bit is getting executed it increment the version > number (2.0) in pom.xml file. Pushes the builds in artifacts repository with > the notation (ABC_32Bit-1.0.jar) > ** 64 Bit task uses that newly updated pom.xml file with (2.0), it creates > build on that version. And updates the version (3.0) in pom.xml file. Pushes > the builds in artifacts repository with the notation (ABC_64Bit-2.0.jar) > ** So, finally we get directory structure as below, which is not expected. > --> ABC > --> 32 Bit > --> 1.0 > ABC_32Bit-1.0.jar > --> 64 Bit > --> 2.0 > ABC_64Bit-2.0.jar > I have even tried to use release:rollback command in between above mentioned > tasks. After executing 32 Bit task to make pom.xml file fresh (before > executing 32 Bit profile) for executing 64 Bit profile to avoid version > increment in pom.xml. > Again it is not working and giving error as "cannot restore from a missing > backup POM" > * 1. for 32 Bit -->release:prepare release:perform -P "32Bit,!64Bit" > * 2. release:rollback > * 3. for 64 Bit -->release:prepare release:perform -P "!32Bit,64Bit" > Hope you guys got my problem. If not feel free to open discussion. > Thanks -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MRELEASE-1061) Not able to stop version increment in pom.xml with the release prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467479#comment-17467479
]
Michael Osipov commented on MRELEASE-1061:
--
This is a common problem when you want to compile native code for different
arch/OS one release. This isn't supported for now. It would likely take a
significant amount of time to write a {{release:multi-perform}} goal.
> Not able to stop version increment in pom.xml with the release prepare
> ---
>
> Key: MRELEASE-1061
> URL: https://issues.apache.org/jira/browse/MRELEASE-1061
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 2.5.3
>Reporter: Nikunj Ramani
>Priority: Major
>
> Hello Team,
> Here is my requirement:
> I have two profiles (32 Bit and 64 Bit) in my pom.xml. And I want them to be
> executed one by one and expecting (tasks release prepare and release perform)
> them to push build artifacts in artifact repository.
> * Expected points :
> ** For 32 Bit and 64 Bit separate .jar will be created with the same version
> (1.0) as per below expected directory structure.
> -->ABC
> --> 32 Bit
> --> 1.0
> ABC_32Bit-1.0.jar
> --> 64 Bit
> --> 1.0
> ABC_64Bit-1.0.jar
> * Problem facing :
> ** We have a Bamboo plan with two tasks.
> ** 1. for 32 Bit -->release:prepare release:perform -P "32Bit,!64Bit"
> ** 2. for 64 Bit -->release:prepare release:perform -P "!32Bit,64Bit"
> ** But, when task 1 for 32 Bit is getting executed it increment the version
> number (2.0) in pom.xml file. Pushes the builds in artifacts repository with
> the notation (ABC_32Bit-1.0.jar)
> ** 64 Bit task uses that newly updated pom.xml file with (2.0), it creates
> build on that version. And updates the version (3.0) in pom.xml file. Pushes
> the builds in artifacts repository with the notation (ABC_64Bit-2.0.jar)
> ** So, finally we get directory structure as below, which is not expected.
> --> ABC
> --> 32 Bit
> --> 1.0
> ABC_32Bit-1.0.jar
> --> 64 Bit
> --> 2.0
> ABC_64Bit-2.0.jar
> I have even tried to use release:rollback command in between above mentioned
> tasks. After executing 32 Bit task to make pom.xml file fresh (before
> executing 32 Bit profile) for executing 64 Bit profile to avoid version
> increment in pom.xml.
> Again it is not working and giving error as "cannot restore from a missing
> backup POM"
> * 1. for 32 Bit -->release:prepare release:perform -P "32Bit,!64Bit"
> * 2. release:rollback
> * 3. for 64 Bit -->release:prepare release:perform -P "!32Bit,64Bit"
> Hope you guys got my problem. If not feel free to open discussion.
> Thanks
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MRELEASE-932) ReleaseFailureException of an artefact wich version as a property
[
https://issues.apache.org/jira/browse/MRELEASE-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-932:
Description:
After updating the release maven plugin from version 2.0.0 to 2.5.1, I've got
the following exception:
{noformat}
message : Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.5.1:prepare (default-cli) on
project ping-parent: The artifact (com.mycompagny.myapp:myapp-client) requires
a different version (15.4.0) than what is found (12.2.1) for the expression
(version.client.tested) in the project (com.mycompagny.myapp:myapp-client).
cause : The artifact (com.mycompagny.myapp:myapp-client) requires a different
version (15.4.0) than what is found (12.2.1) for the expression
(version.client.tested) in the project (com.mycompagny.myapp:myapp-client).
Stack trace :
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.5.1:prepare (default-cli) on
project ping-parent: The artifact (fr.generali.gael.ping:ping-injection-client)
requires a different version (15.4.1-git) than what is found (15.4.0) for the
expression (version.client.tested) in the project
(fr.generali.gael.ping:ping-client-test).
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java
{noformat}
This error happens in a multi-module application.
For testing purpose, we depends from an older version of an artefact of the
same application.
When the artefact version is an expression (ie. $\{version.client.tested\}),
the
[AbstractRewritePomsPhase|http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven.release/maven-release-manager/2.5.1/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java/#545]
class do a chek.
If we don't use the expression (i.e. properties), the release is working.
Maven configuration that fails:
{code}
12.1.0
${project.groupId}
myapp-client
${version.client.tested}
{code}
Maven configuration that is working:
{code}
${project.groupId}
myapp-client
12.1.0
{code}
was:
After updating the release maven plugin from version 2.0.0 to 2.5.1, I've got
the following exception:
{quote}
message : Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.5.1:prepare (default-cli) on
project ping-parent: The artifact (com.mycompagny.myapp:myapp-client) requires
a different version (15.4.0) than what is found (12.2.1) for the expression
(version.client.tested) in the project (com.mycompagny.myapp:myapp-client).
cause : The artifact (com.mycompagny.myapp:myapp-client) requires a different
version (15.4.0) than what is found (12.2.1) for the expression
(version.client.tested) in the project (com.mycompagny.myapp:myapp-client).
Stack trace :
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.5.1:prepare (default-cli) on
project ping-parent: The artifact (fr.generali.gael.ping:ping-injection-client)
requires a different version (15.4.1-git) than what is found (15.4.0) for the
expression (version.client.tested) in the project
(fr.generali.gael.ping:ping-client-test).
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java
{quote}
This error happens in a multi-module application.
For testing purpose, we depends from an older version of an artefact of the
same application.
When the artefact version is an expression (ie. $\{version.client.tested\}),
the
[AbstractRewritePomsPhase|http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven.release/maven-release-manager/2.5.1/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java/#545]
class do a chek.
If we don't use the expression (i.e. properties), the release is working.
Maven configuration that fails:
{code}
12.1.0
${project.groupId}
myapp-client
${version.client.tested}
{code}
Maven configuration that is working:
{code}
${project.groupId}
myapp-client
12.1.0
{code}
> ReleaseFailureException of an artefact wich version as a property
> -
>
> Key: MRELEASE-932
> URL:
[jira] [Updated] (MRELEASE-1073) Pre-Release generation
[ https://issues.apache.org/jira/browse/MRELEASE-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1073: - Fix Version/s: waiting-for-feedback > Pre-Release generation > -- > > Key: MRELEASE-1073 > URL: https://issues.apache.org/jira/browse/MRELEASE-1073 > Project: Maven Release Plugin > Issue Type: New Feature >Reporter: Stéphane Passignat >Priority: Major > Fix For: waiting-for-feedback > > > Before generating a final release, it's often required to publish several > kind of beta version. When one is validated, it's intended to become a pure > release. > SCM aspect: > * create a tag > * create a branch (option) > Process impact: > * be able to generate a release from a tag or revision > * be able to generate a pre-release from a tag or revision > Version number: > * the version is calculated looking at the scm tags (ex: 1.0-SNAPSHOT become > 1.0.beta14 if the tags matching the tag pattern have as higher number > 1.0.beta13) > > > There are maybe some discussion about the version number. Should it be .beta > or -beta... > > I think it would be great to have this feature in the release plugin, keeping > in one consistent tool all release facets. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MRELEASE-1073) Pre-Release generation
[
https://issues.apache.org/jira/browse/MRELEASE-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467476#comment-17467476
]
Michael Osipov commented on MRELEASE-1073:
--
I don't really understand the purpose of your request. If you moved from
SNAPSHOT to {{-beta-13}} the Release Plugin will properly increment here. If
you are not happy with the release policy, you can write you own. Please
explain.
> Pre-Release generation
> --
>
> Key: MRELEASE-1073
> URL: https://issues.apache.org/jira/browse/MRELEASE-1073
> Project: Maven Release Plugin
> Issue Type: New Feature
>Reporter: Stéphane Passignat
>Priority: Major
>
> Before generating a final release, it's often required to publish several
> kind of beta version. When one is validated, it's intended to become a pure
> release.
> SCM aspect:
> * create a tag
> * create a branch (option)
> Process impact:
> * be able to generate a release from a tag or revision
> * be able to generate a pre-release from a tag or revision
> Version number:
> * the version is calculated looking at the scm tags (ex: 1.0-SNAPSHOT become
> 1.0.beta14 if the tags matching the tag pattern have as higher number
> 1.0.beta13)
>
>
> There are maybe some discussion about the version number. Should it be .beta
> or -beta...
>
> I think it would be great to have this feature in the release plugin, keeping
> in one consistent tool all release facets.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-release] michael-o commented on pull request #86: MRELEASE-1072 reuse original tag for next development version in case
michael-o commented on pull request #86: URL: https://github.com/apache/maven-release/pull/86#issuecomment-1003605736 This causes failures with master: ``` [ERROR] RewritePomsForDevelopmentPhaseTest.testRewriteBasicPomWithGitFromTag:292->AbstractReleaseTestCase.comparePomFiles:248->AbstractReleaseTestCase.comparePomFiles:254->AbstractReleaseTestCase.comparePomFiles:271->AbstractReleaseTestCase.comparePomFiles:287->AbstractReleaseTestCase.comparePomFiles:350 Check the transformed POM D:\Entwicklung\Projekte\maven-release\maven-release-manager\target\test-classes\projects\rewrite-for-development\basic-pom-with-git-from-tag\pom.xml Expected text value 'original-label' but was 'release-label' - comparing original-label at /project[1]/scm[1]/tag[1]/text()[1] to release-label at /project[1]/scm[1]/tag[1]/text()[1] [ERROR] RewritePomsForDevelopmentPhaseTest.testRewriteBasicPomWithGit:271->AbstractReleaseTestCase.comparePomFiles:248->AbstractReleaseTestCase.comparePomFiles:254->AbstractReleaseTestCase.comparePomFiles:271->AbstractReleaseTestCase.comparePomFiles:287->AbstractReleaseTestCase.comparePomFiles:350 Check the transformed POM D:\Entwicklung\Projekte\maven-release\maven-release-manager\target\test-classes\projects\rewrite-for-development\basic-pom-with-git\pom.xml Expected text value 'HEAD' but was 'release-label' - comparing HEAD at /project[1]/scm[1]/tag[1]/text()[1] to release-label at /project[1]/scm[1]/tag[1]/text()[1] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467474#comment-17467474
]
Michael Osipov commented on MRELEASE-1072:
--
Shouldn't this be fixed in the translator itself? I am still trying to
understand the problem.
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-1072:
-
Description: In case that the original {{project.scm}} section contains a
tag element (e.g. with value "trunk") this is removed during prepare for the
next snapshot version. The tagged/release version contains the properly
adjusted tag element. (was: In case the original {{project.scm}} section
contains a tag element (e.g. with value "trunk") this is removed during prepare
for the next snapshot version. The tagged/release version contains the properly
adjusted tag element.)
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439640#comment-17439640
]
Michael Osipov edited comment on MRELEASE-1072 at 1/1/22, 7:14 PM:
---
Where is the bug? You mean it is not re-added afterwards?
was (Author: michael-o):
Where is the bug? You mean it is not readded afterwards?
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case the original {{project.scm}} section contains a tag element (e.g.
> with value "trunk") this is removed during prepare for the next snapshot
> version. The tagged/release version contains the properly adjusted tag
> element.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-release] michael-o closed pull request #13: [MRELEASE-980] Allow commit comments to be controlled
michael-o closed pull request #13: URL: https://github.com/apache/maven-release/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #13: [MRELEASE-980] Allow commit comments to be controlled
michael-o commented on pull request #13: URL: https://github.com/apache/maven-release/pull/13#issuecomment-1003604091 PR has already been merged with afd175d0a5ddf5c99011451fa9b4e6a357e50c41. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1003603066 I don't have access to the NEXUS issue :-( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1003602899 > Both issues are correct but are rather follow-ups to [MNG-7375](https://issues.apache.org/jira/browse/MNG-7375). My question is about how to deal with a missing prefix within `Metadata.merge` (this can happen even if the XSD would say it is mandatory, e.g. by a bug like in this case through `staging-maven-plugin`). Would a validator really prevent `null` being passed to `Metadata.merge`? The validator would fail the build with an appropriate error message before anything being merged. I.e., source and target are validated upfront before merge happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] kwin commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)
kwin commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1003600016 Both issues are correct but are rather follow-ups to MNG-7375. My question is about how to deal with a missing prefix within `Metadata.merge` (this can happen even if the XSD would say it is mandatory, e.g. by a bug like in this case through `staging-maven-plugin`). Would a validator really prevent `null` being passed to `Metadata.merge`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 edited a comment on pull request #422: URL: https://github.com/apache/maven-surefire/pull/422#issuecomment-1003593211 This investigation has helped me. It looks like the GH build runs out of disk space. I made a [ZIP of the largest sub-module](https://github.com/apache/maven-surefire/actions/runs/1643753265) and its target folder occupies 1.2GB and I deleted binary files. So the real consumption of the disk space must be much bigger. The problem is that the ZIP does not contain the logs of the last 40 integration test however they were executed but their files are no more on the disk! Still we are somewhere in the middle of the entire test set. How can we prove my hypothesis other way that the particular build runs out of disk space? It looks like one build crashed but the other did not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 edited a comment on pull request #422: URL: https://github.com/apache/maven-surefire/pull/422#issuecomment-1003593211 This investigation has helped me. It looks like the GH build runs out of disk space. I made a [ZIP of the largest sub-module](https://github.com/apache/maven-surefire/actions/runs/1643753265) and its target folder occupies 1.2GB and I deleted binary files. So the real consumption of the disk space must be much bigger. The problem is that the ZIP does not contain the logs of the last 40 integration test however they were executed but their files are no more on the disk! Still we are somewhere in the middle of the entire test set. How can we prove my hypothesis other way that the particular build runs out of disk space? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 edited a comment on pull request #422: URL: https://github.com/apache/maven-surefire/pull/422#issuecomment-1003593211 This investigation has helped me. It looks like the GH build runs out of disk space. I made a ZIP of the largest sub-module and its target folder occupies 1.2GB and I deleted binary files. So the real consumption of the disk space must be much bigger. The problem is that the ZIP does not contain the logs of the last 40 integration test however they were executed but their files are no more on the disk! Still we are somewhere in the middle of the entire test set. How can we prove my hypothesis other way that the particular build runs out of disk space? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on pull request #422: URL: https://github.com/apache/maven-surefire/pull/422#issuecomment-1003593211 This investigating has helped me. It looks like the GH build runs out of disk space. I made a ZIP of the largest sub-module and its target folder occupies 1.2GB and I deleted binary files. So the real consumption of the disk space must be much bigger. The problem is that the ZIP does not contain the logs of the last 40 integration test however they were executed but their files are no more on the disk! Still we are somewhere in the middle of the entire test set. How can we prove my hypothesis other way that the particular build runs out of disk space? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1076) Upgrade Plexus Utils to 3.4.1
[ https://issues.apache.org/jira/browse/MRELEASE-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467466#comment-17467466 ] Hudson commented on MRELEASE-1076: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #86 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/86/ > Upgrade Plexus Utils to 3.4.1 > - > > Key: MRELEASE-1076 > URL: https://issues.apache.org/jira/browse/MRELEASE-1076 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0-M4 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
slawekjaranowski commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777124681
##
File path: .github/workflows/maven-verify.yml
##
@@ -15,19 +15,49 @@
# specific language governing permissions and limitations
# under the License.
-name: Verify
+name: GitHub CI
on:
push:
branches-ignore:
- dependabot/**
pull_request:
+
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v1
+
+ - name: Set up JDK ${{ matrix.java }}
+uses: actions/setup-java@v2.4.0
+with:
+ distribution: ${{ matrix.jdk }}
+ java-version: ${{ matrix.java }}
+ cache: 'maven'
+
+ - name: Build with Maven
+run: mvn clean install -e -B -V -nsu --no-transfer-progress -P run-its
-Dfailsafe-integration-test-port=8083
+
+ - name: Upload artifact surefire-its
+uses: actions/upload-artifact@v2-preview
+if: failure()
+with:
+ name: ${{ matrix.os }}-surefire-its
+ path: |
+surefire-its/target/*/log.txt
+surefire-its/target/**/surefire-reports/*
+surefire-its/target/**/failsafe-reports/*
+!surefire-its/target/failsafe-reports
Review comment:
by the way attached artifacts has size > 1GB ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
slawekjaranowski commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777124494
##
File path: .github/workflows/maven-verify.yml
##
@@ -15,19 +15,49 @@
# specific language governing permissions and limitations
# under the License.
-name: Verify
+name: GitHub CI
on:
push:
branches-ignore:
- dependabot/**
pull_request:
+
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v1
+
+ - name: Set up JDK ${{ matrix.java }}
+uses: actions/setup-java@v2.4.0
+with:
+ distribution: ${{ matrix.jdk }}
+ java-version: ${{ matrix.java }}
+ cache: 'maven'
+
+ - name: Build with Maven
+run: mvn clean install -e -B -V -nsu --no-transfer-progress -P run-its
-Dfailsafe-integration-test-port=8083
+
+ - name: Upload artifact surefire-its
+uses: actions/upload-artifact@v2-preview
+if: failure()
+with:
+ name: ${{ matrix.os }}-surefire-its
+ path: |
+surefire-its/target/*/log.txt
+surefire-its/target/**/surefire-reports/*
+surefire-its/target/**/failsafe-reports/*
+!surefire-its/target/failsafe-reports
Review comment:
That is because we have two events:
- push to branches
- pull_request
I try to discover how prevent it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] asfgit closed pull request #92: [MRELEASE-1076] Upgrade Plexus Utils to 3.4.1
asfgit closed pull request #92: URL: https://github.com/apache/maven-release/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1003586710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] asfgit closed pull request #90: [MRELEASE-1075] Move CVS-based tests to Subversion or Git
asfgit closed pull request #90: URL: https://github.com/apache/maven-release/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRELEASE-1076) Upgrade Plexus Utils to 3.4.1
[ https://issues.apache.org/jira/browse/MRELEASE-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1076. Resolution: Fixed Fixed with [53d6743ecee3f62067c31c083ffa68ad062dc75e|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=53d6743ecee3f62067c31c083ffa68ad062dc75e]. > Upgrade Plexus Utils to 3.4.1 > - > > Key: MRELEASE-1076 > URL: https://issues.apache.org/jira/browse/MRELEASE-1076 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0-M4 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven] kwin commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)
kwin commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1003583874 So how should the merge deal with a missing prefix? Throw an ISE or IAE? Where would the validator be hooked in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRELEASE-1075) Move CVS-based tests to Subversion or Git
[ https://issues.apache.org/jira/browse/MRELEASE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1075. Resolution: Fixed Fixed with [ac76d691586c139684a3bca684ffbe13b80244a3|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=ac76d691586c139684a3bca684ffbe13b80244a3]. > Move CVS-based tests to Subversion or Git > - > > Key: MRELEASE-1075 > URL: https://issues.apache.org/jira/browse/MRELEASE-1075 > Project: Maven Release Plugin > Issue Type: Task >Affects Versions: 3.0.0-M4 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0 > > > Some tests use CVS to complete, with Maven SCM 1.12.2 CVS is deprecated and > removed from the default providers list, but still can be added explicitly. > Change our tests to use default providers. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MRELEASE-1074) Upgrade Maven SCM to 1.12.2
[ https://issues.apache.org/jira/browse/MRELEASE-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1074. Resolution: Fixed Fixed with [309652bd0fda03c6d0c4e31026301ffa6e59f9f3|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=309652bd0fda03c6d0c4e31026301ffa6e59f9f3]. > Upgrade Maven SCM to 1.12.2 > --- > > Key: MRELEASE-1074 > URL: https://issues.apache.org/jira/browse/MRELEASE-1074 > Project: Maven Release Plugin > Issue Type: Dependency upgrade > Components: scm >Affects Versions: 3.0.0-M4 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-release] asfgit merged pull request #91: [MRELEASE-1074] Upgrade Maven SCM to 1.12.2
asfgit merged pull request #91: URL: https://github.com/apache/maven-release/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-965) Upload completes but doesn't update stdout - making it look like a freeze
[ https://issues.apache.org/jira/browse/MRELEASE-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467457#comment-17467457 ] Michael Osipov commented on MRELEASE-965: - Well, invoked Maven is run in batch mode when the outer Maven is running in batch mode. I guess this can only be fixed MRELEASE-1048. > Upload completes but doesn't update stdout - making it look like a freeze > - > > Key: MRELEASE-965 > URL: https://issues.apache.org/jira/browse/MRELEASE-965 > Project: Maven Release Plugin > Issue Type: Bug > Components: stage >Affects Versions: 2.5.3 > Environment: JAVA Version: 1.7.0_101 > OS: Linux 3.10.0-327.28.3.el7.x86_64 >Reporter: Julian Gamble >Priority: Major > > Maven completes the upload - but the stdout freezes and the program does not > exit cleanly - giving the impression that that the upload is in progress and > running slow. > 15:27:42.370 [INFO] > > 15:27:42.370 [INFO] > > 15:27:42.370 [INFO] Building Panorama Barista Package epee-b359 > 15:27:42.370 [INFO] > > 15:27:42.370 [INFO] > 15:27:42.370 [INFO] --- maven-deploy-plugin:2.7:deploy-file (default-cli) @ > projectname --- > 15:27:42.666 Uploading: https://server.com/artifactory/mydir/myfile.zip > 15:27:42.822 2/277171 KB > 15:27:42.822 4/277171 KB > 15:27:42.822 6/277171 KB > ... > 15:27:42.885 290/277171 KB > 15:27:42.885 292/277171 KB > 15:27:42.885 294/277171 KB > 15:27:42.885 296/277171 KB > Go cancelled this job as it has not generated any console output for more > than 10 minute(s)15:38:06.339 [go] Start to execute cancel task: Kills child > processes -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777122090
##
File path: .github/workflows/maven-verify.yml
##
@@ -15,19 +15,49 @@
# specific language governing permissions and limitations
# under the License.
-name: Verify
+name: GitHub CI
on:
push:
branches-ignore:
- dependabot/**
pull_request:
+
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v1
+
+ - name: Set up JDK ${{ matrix.java }}
+uses: actions/setup-java@v2.4.0
+with:
+ distribution: ${{ matrix.jdk }}
+ java-version: ${{ matrix.java }}
+ cache: 'maven'
+
+ - name: Build with Maven
+run: mvn clean install -e -B -V -nsu --no-transfer-progress -P run-its
-Dfailsafe-integration-test-port=8083
+
+ - name: Upload artifact surefire-its
+uses: actions/upload-artifact@v2-preview
+if: failure()
+with:
+ name: ${{ matrix.os }}-surefire-its
+ path: |
+surefire-its/target/*/log.txt
+surefire-its/target/**/surefire-reports/*
+surefire-its/target/**/failsafe-reports/*
+!surefire-its/target/failsafe-reports
Review comment:
@slawekjaranowski
The build runs every configuration twice, means `push` and `pull_request`.
This is the waste and I also could not avoid it in my scripts. Do you know how
to do it? This would save the h/w resources in favor of others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777121785
##
File path: .github/workflows/maven-verify.yml
##
@@ -15,19 +15,49 @@
# specific language governing permissions and limitations
# under the License.
-name: Verify
+name: GitHub CI
on:
push:
branches-ignore:
- dependabot/**
pull_request:
+
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v1
+
+ - name: Set up JDK ${{ matrix.java }}
+uses: actions/setup-java@v2.4.0
+with:
+ distribution: ${{ matrix.jdk }}
+ java-version: ${{ matrix.java }}
+ cache: 'maven'
+
+ - name: Build with Maven
+run: mvn clean install -e -B -V -nsu --no-transfer-progress -P run-its
-Dfailsafe-integration-test-port=8083
+
+ - name: Upload artifact surefire-its
+uses: actions/upload-artifact@v2-preview
+if: failure()
+with:
+ name: ${{ matrix.os }}-surefire-its
+ path: |
+surefire-its/target/*/log.txt
+surefire-its/target/**/surefire-reports/*
+surefire-its/target/**/failsafe-reports/*
+!surefire-its/target/failsafe-reports
Review comment:
The commit message is `investigating`. The commit does not mean anything
for this Jira issue. We are discussing the timeout in the Slack/INFRA channel
and I need to get the archive of `surefire-its/target` with all the dump files
and logs. This was happening one year ago and I came over this problem by
splitting the test set in two. Currently I am waiting for the build to complete
and I hope the archive files would appear in the attachment. Then I want to go
inside and analyse the logs and test content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777121785
##
File path: .github/workflows/maven-verify.yml
##
@@ -15,19 +15,49 @@
# specific language governing permissions and limitations
# under the License.
-name: Verify
+name: GitHub CI
on:
push:
branches-ignore:
- dependabot/**
pull_request:
+
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v1
+
+ - name: Set up JDK ${{ matrix.java }}
+uses: actions/setup-java@v2.4.0
+with:
+ distribution: ${{ matrix.jdk }}
+ java-version: ${{ matrix.java }}
+ cache: 'maven'
+
+ - name: Build with Maven
+run: mvn clean install -e -B -V -nsu --no-transfer-progress -P run-its
-Dfailsafe-integration-test-port=8083
+
+ - name: Upload artifact surefire-its
+uses: actions/upload-artifact@v2-preview
+if: failure()
+with:
+ name: ${{ matrix.os }}-surefire-its
+ path: |
+surefire-its/target/*/log.txt
+surefire-its/target/**/surefire-reports/*
+surefire-its/target/**/failsafe-reports/*
+!surefire-its/target/failsafe-reports
Review comment:
The commit message is `investigating`. The commit does not mean anything
for this Jira issue. We are discussing the timeout in the Slack/INFRA channel
and I need to get the archive of `surefire-its/target` with all the dump files
and logs. This was happening one year ago and I came over this issue by
splitting the test set in two. Currently I am waiting for the build to complete
and I hope the archive files would appear in the attachment. Then I want to go
inside and analyse the logs and test content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MRELEASE-1066) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows
[ https://issues.apache.org/jira/browse/MRELEASE-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRELEASE-1066: Assignee: Slawomir Jaranowski > FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows > --- > > Key: MRELEASE-1066 > URL: https://issues.apache.org/jira/browse/MRELEASE-1066 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare > Environment: Windows >Reporter: Elliotte Rusty Harold >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > > This bug is shared (likely because of code copied from one place to another) > between the similar methods in commons IO, codehaus-plexus-utils, and > maven-shared-utils. > I don't have an isolated test case because this bug is platform specific and > I've only seen it in Travis CI builds on Windows using JDK 7 through 15. I > don't have a Windows system handy to test it. However it is reproducible. > Typical code that triggers it is in RestoreBackupPomsPhaseTest in > maven-release: > ``` > // copy poms so tests are valid without clean > File sourceDir = getTestFile( "src/test/resources" + projectPath ); > File testDir = getTestFile( "target/test-classes" + projectPath ); > FileUtils.copyDirectoryStructure( sourceDir, testDir ); > ``` > I don't know whether there might be something weird in the setup of those two > directories that's involved. > Typical error message is: > Caused by: java.nio.file.FileSystemException: > F:\jenkins\jenkins-slave\workspace\maven-box_maven-release_windows@2@2\windows-jdk8-m3.6.x_build\maven-release-manager\target\test-classes\projects\restore-backup-poms\basic-pom\pom.xml: > The process cannot access the file because it is being used by another > process > "The process cannot access the file because it is being used by another > process" I think points to the root of the bug. This is a Windows file system > error message. > Some history is here where I noticed it: > https://github.com/apache/maven-release/pull/42 > In this case, I started with plexus-utils 3.1.0 which worked, upgraded t > plexus-utils 3.3.0, which didn't. And then tried the FileUtils.copyDirectory > from both maven-shared-utils and commons-io, all of which failed in the same > way. > I think this is caused by the use of NIO, which doesn't work quite the same > when copying files on Windows as on Linux and Mac OS X. > Also see https://issues.apache.org/jira/browse/IO-663?filter=-2 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MRELEASE-1066) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows
[ https://issues.apache.org/jira/browse/MRELEASE-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467453#comment-17467453 ] Michael Osipov commented on MRELEASE-1066: -- Fixed with [f94b60e4abf5d40ed9422d9961fc789ded5f4ad9|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=f94b60e4abf5d40ed9422d9961fc789ded5f4ad9]. > FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows > --- > > Key: MRELEASE-1066 > URL: https://issues.apache.org/jira/browse/MRELEASE-1066 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare > Environment: Windows >Reporter: Elliotte Rusty Harold >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > > This bug is shared (likely because of code copied from one place to another) > between the similar methods in commons IO, codehaus-plexus-utils, and > maven-shared-utils. > I don't have an isolated test case because this bug is platform specific and > I've only seen it in Travis CI builds on Windows using JDK 7 through 15. I > don't have a Windows system handy to test it. However it is reproducible. > Typical code that triggers it is in RestoreBackupPomsPhaseTest in > maven-release: > ``` > // copy poms so tests are valid without clean > File sourceDir = getTestFile( "src/test/resources" + projectPath ); > File testDir = getTestFile( "target/test-classes" + projectPath ); > FileUtils.copyDirectoryStructure( sourceDir, testDir ); > ``` > I don't know whether there might be something weird in the setup of those two > directories that's involved. > Typical error message is: > Caused by: java.nio.file.FileSystemException: > F:\jenkins\jenkins-slave\workspace\maven-box_maven-release_windows@2@2\windows-jdk8-m3.6.x_build\maven-release-manager\target\test-classes\projects\restore-backup-poms\basic-pom\pom.xml: > The process cannot access the file because it is being used by another > process > "The process cannot access the file because it is being used by another > process" I think points to the root of the bug. This is a Windows file system > error message. > Some history is here where I noticed it: > https://github.com/apache/maven-release/pull/42 > In this case, I started with plexus-utils 3.1.0 which worked, upgraded t > plexus-utils 3.3.0, which didn't. And then tried the FileUtils.copyDirectory > from both maven-shared-utils and commons-io, all of which failed in the same > way. > I think this is caused by the use of NIO, which doesn't work quite the same > when copying files on Windows as on Linux and Mac OS X. > Also see https://issues.apache.org/jira/browse/IO-663?filter=-2 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MRELEASE-1066) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows
[ https://issues.apache.org/jira/browse/MRELEASE-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1066. Fix Version/s: 3.0.0 Resolution: Fixed > FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows > --- > > Key: MRELEASE-1066 > URL: https://issues.apache.org/jira/browse/MRELEASE-1066 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare > Environment: Windows >Reporter: Elliotte Rusty Harold >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > Fix For: 3.0.0 > > > This bug is shared (likely because of code copied from one place to another) > between the similar methods in commons IO, codehaus-plexus-utils, and > maven-shared-utils. > I don't have an isolated test case because this bug is platform specific and > I've only seen it in Travis CI builds on Windows using JDK 7 through 15. I > don't have a Windows system handy to test it. However it is reproducible. > Typical code that triggers it is in RestoreBackupPomsPhaseTest in > maven-release: > ``` > // copy poms so tests are valid without clean > File sourceDir = getTestFile( "src/test/resources" + projectPath ); > File testDir = getTestFile( "target/test-classes" + projectPath ); > FileUtils.copyDirectoryStructure( sourceDir, testDir ); > ``` > I don't know whether there might be something weird in the setup of those two > directories that's involved. > Typical error message is: > Caused by: java.nio.file.FileSystemException: > F:\jenkins\jenkins-slave\workspace\maven-box_maven-release_windows@2@2\windows-jdk8-m3.6.x_build\maven-release-manager\target\test-classes\projects\restore-backup-poms\basic-pom\pom.xml: > The process cannot access the file because it is being used by another > process > "The process cannot access the file because it is being used by another > process" I think points to the root of the bug. This is a Windows file system > error message. > Some history is here where I noticed it: > https://github.com/apache/maven-release/pull/42 > In this case, I started with plexus-utils 3.1.0 which worked, upgraded t > plexus-utils 3.3.0, which didn't. And then tried the FileUtils.copyDirectory > from both maven-shared-utils and commons-io, all of which failed in the same > way. > I think this is caused by the use of NIO, which doesn't work quite the same > when copying files on Windows as on Linux and Mac OS X. > Also see https://issues.apache.org/jira/browse/IO-663?filter=-2 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-release] michael-o commented on pull request #86: MRELEASE-1072 reuse original tag for next development version in case
michael-o commented on pull request #86: URL: https://github.com/apache/maven-release/pull/86#issuecomment-1003580600 Will look into this as soon as my other open PRs are merged. @kwin Please ping me by ned of next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #35: fix: add .gitattributes to auto configure line endings
michael-o commented on pull request #35: URL: https://github.com/apache/maven-release/pull/35#issuecomment-1003580506 Limit attributes to files truly in the reposity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o closed pull request #35: fix: add .gitattributes to auto configure line endings
michael-o closed pull request #35: URL: https://github.com/apache/maven-release/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #79: Bump scmVersion from 1.11.3 to 1.12.0
michael-o commented on pull request #79: URL: https://github.com/apache/maven-release/pull/79#issuecomment-1003580299 Superseded by #91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o closed pull request #79: Bump scmVersion from 1.11.3 to 1.12.0
michael-o closed pull request #79: URL: https://github.com/apache/maven-release/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] dependabot[bot] commented on pull request #79: Bump scmVersion from 1.11.3 to 1.12.0
dependabot[bot] commented on pull request #79: URL: https://github.com/apache/maven-release/pull/79#issuecomment-1003580303 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] dependabot[bot] commented on pull request #80: Bump plexus-utils from 3.0.15 to 3.4.1
dependabot[bot] commented on pull request #80: URL: https://github.com/apache/maven-release/pull/80#issuecomment-1003580264 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o closed pull request #80: Bump plexus-utils from 3.0.15 to 3.4.1
michael-o closed pull request #80: URL: https://github.com/apache/maven-release/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #80: Bump plexus-utils from 3.0.15 to 3.4.1
michael-o commented on pull request #80: URL: https://github.com/apache/maven-release/pull/80#issuecomment-1003580254 Superseded by #92. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRELEASE-1076) Upgrade Plexus Utils to 3.4.1
Michael Osipov created MRELEASE-1076: Summary: Upgrade Plexus Utils to 3.4.1 Key: MRELEASE-1076 URL: https://issues.apache.org/jira/browse/MRELEASE-1076 Project: Maven Release Plugin Issue Type: Dependency upgrade Affects Versions: 3.0.0-M4 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.0.0 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-release] michael-o commented on pull request #81: Bump maven-scm-manager-plexus from 1.8 to 1.12.0
michael-o commented on pull request #81: URL: https://github.com/apache/maven-release/pull/81#issuecomment-1003579873 Superseded by #91. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o closed pull request #81: Bump maven-scm-manager-plexus from 1.8 to 1.12.0
michael-o closed pull request #81: URL: https://github.com/apache/maven-release/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] dependabot[bot] commented on pull request #81: Bump maven-scm-manager-plexus from 1.8 to 1.12.0
dependabot[bot] commented on pull request #81: URL: https://github.com/apache/maven-release/pull/81#issuecomment-1003579879 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o edited a comment on pull request #87: [MRELEASE-1066] fix XmlStreamReader not closed in unit test
michael-o edited a comment on pull request #87: URL: https://github.com/apache/maven-release/pull/87#issuecomment-1003579744 Fixed with f94b60e4abf5d40ed9422d9961fc789ded5f4ad9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #87: [MRELEASE-1066] fix XmlStreamReader not closed in unit test
michael-o commented on pull request #87: URL: https://github.com/apache/maven-release/pull/87#issuecomment-1003579744 Fixed with 94b60e4abf5d40ed9422d9961fc789ded5f4ad9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o closed pull request #87: [MRELEASE-1066] fix XmlStreamReader not closed in unit test
michael-o closed pull request #87: URL: https://github.com/apache/maven-release/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
slawekjaranowski commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777115790
##
File path: .github/workflows/maven-verify.yml
##
@@ -15,19 +15,49 @@
# specific language governing permissions and limitations
# under the License.
-name: Verify
+name: GitHub CI
on:
push:
branches-ignore:
- dependabot/**
pull_request:
+
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v1
+
+ - name: Set up JDK ${{ matrix.java }}
+uses: actions/setup-java@v2.4.0
+with:
+ distribution: ${{ matrix.jdk }}
+ java-version: ${{ matrix.java }}
+ cache: 'maven'
+
+ - name: Build with Maven
+run: mvn clean install -e -B -V -nsu --no-transfer-progress -P run-its
-Dfailsafe-integration-test-port=8083
+
+ - name: Upload artifact surefire-its
+uses: actions/upload-artifact@v2-preview
+if: failure()
+with:
+ name: ${{ matrix.os }}-surefire-its
+ path: |
+surefire-its/target/*/log.txt
+surefire-its/target/**/surefire-reports/*
+surefire-its/target/**/failsafe-reports/*
+!surefire-its/target/failsafe-reports
Review comment:
Don't do it in this way
it is step backward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
slawekjaranowski commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777115536
##
File path: .github/workflows/maven-verify.yml
##
@@ -25,9 +25,29 @@ on:
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin, zulu]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+steps:
+- name: Verify
+ uses:
apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
Review comment:
We can extend this workflow with artifacts upload support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on pull request #422: URL: https://github.com/apache/maven-surefire/pull/422#issuecomment-1003571346 This CI script will publish archived artifacts for further analysis. We need to find out why the JVM exists after one hour of execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
slawekjaranowski commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777115453
##
File path: .github/workflows/maven-verify.yml
##
@@ -25,9 +25,29 @@ on:
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin, zulu]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+steps:
+- name: Verify
+ uses:
apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
Review comment:
it is shared workflow ... can not be uses as step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MRELEASE-1075) Move CVS-based tests to Subversion or Git
Michael Osipov created MRELEASE-1075: Summary: Move CVS-based tests to Subversion or Git Key: MRELEASE-1075 URL: https://issues.apache.org/jira/browse/MRELEASE-1075 Project: Maven Release Plugin Issue Type: Task Affects Versions: 3.0.0-M4 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.0.0 Some tests use CVS to complete, with Maven SCM 1.12.2 CVS is deprecated and removed from the default providers list, but still can be added explicitly. Change our tests to use default providers. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
slawekjaranowski commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777113282
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/util/internal/ObjectUtils.java
##
@@ -44,4 +46,11 @@ private ObjectUtils()
{
return ManagementFactory.getRuntimeMXBean().getSystemProperties();
}
+
+public static boolean isSecurityManagerSupported()
+{
+ClassLoader classLoader = ObjectUtils.class.getClassLoader();
+Class smClass = tryLoadClass( classLoader,
"java.lang.SecurityManager" );
+return smClass != null && !smClass.isAnnotationPresent(
Deprecated.class );
+}
Review comment:
what about Java Version from commons lang3 is is accessible by
`org.apache.maven.surefire.shared.lang3.JavaVersion`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski opened a new pull request #423: Deploy artifacts only for master branch
slawekjaranowski opened a new pull request #423: URL: https://github.com/apache/maven-surefire/pull/423 We shouldn't deploy artifact from feature branches. Branches in more cases have the same version ... so is overridden in repository manager. --- Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #419: [SUREFIRE-1926] Console logs should be synchronized
slawekjaranowski commented on a change in pull request #419: URL: https://github.com/apache/maven-surefire/pull/419#discussion_r777111725 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java ## @@ -206,7 +207,7 @@ public void run() // if tests failed, but if this does not happen then printing warning to console is the only way to // inform the users. String msg = "ForkStarter IOException: " + e.getLocalizedMessage() + "."; -File reportsDir = defaultReporterFactory.getReportsDirectory(); +File reportsDir = reportMerger.getReportsDirectory(); Review comment: maybe I don't see something ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #419: [SUREFIRE-1926] Console logs should be synchronized
slawekjaranowski commented on a change in pull request #419: URL: https://github.com/apache/maven-surefire/pull/419#discussion_r777111661 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java ## @@ -206,7 +207,7 @@ public void run() // if tests failed, but if this does not happen then printing warning to console is the only way to // inform the users. String msg = "ForkStarter IOException: " + e.getLocalizedMessage() + "."; -File reportsDir = defaultReporterFactory.getReportsDirectory(); +File reportsDir = reportMerger.getReportsDirectory(); Review comment: `reportMerger` and `startupReportConfiguration` are final variable `startupReportConfiguration` is pass to `reportMerger` constructor ... `CloseableCloser` is inner class which use variable from ForkStarter instance is it possible that we have different instance of `startupReportConfiguration`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777110752
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/util/internal/ObjectUtils.java
##
@@ -44,4 +46,11 @@ private ObjectUtils()
{
return ManagementFactory.getRuntimeMXBean().getSystemProperties();
}
+
+public static boolean isSecurityManagerSupported()
+{
+ClassLoader classLoader = ObjectUtils.class.getClassLoader();
+Class smClass = tryLoadClass( classLoader,
"java.lang.SecurityManager" );
+return smClass != null && !smClass.isAnnotationPresent(
Deprecated.class );
+}
Review comment:
It was my previous solution but the class appears in module
surefire-booter. This is surefire-api, so we cannot inherit it and cannot
duplicate the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
slawekjaranowski commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r777108931
##
File path:
surefire-providers/surefire-junit3/src/test/java/org/apache/maven/surefire/junit/JUnitTestSetTest.java
##
@@ -22,15 +22,19 @@
import junit.framework.Test;
import junit.framework.TestCase;
import junit.framework.TestSuite;
+import org.apache.maven.surefire.api.testset.TestSetFailedException;
import org.apache.maven.surefire.common.junit3.JUnit3Reflector;
import org.apache.maven.surefire.api.report.ReportEntry;
import org.apache.maven.surefire.api.report.RunListener;
import org.apache.maven.surefire.api.report.RunMode;
import org.apache.maven.surefire.api.report.TestSetReportEntry;
+import org.apache.maven.surefire.shared.lang3.JavaVersion;
Review comment:
In test classes we can use direct comons - not shaded
##
File path:
surefire-providers/surefire-junit3/src/test/java/org/apache/maven/surefire/junit/JUnitTestSetTest.java
##
@@ -54,6 +58,32 @@ public void testExecuteSuiteClass()
succeededTests.get( 0 ).getName() );
}
+public void testSystemManager()
+{
+float javaVersion = Float.parseFloat(
JavaVersion.JAVA_RECENT.toString() );
+boolean isDeprecated = javaVersion >= 17;
+try
+{
+JUnit3Provider.setSystemManager( "java.lang.SecurityManager" );
+
+if ( isDeprecated )
+{
+fail();
+}
+
+Object sm = invokeGetter( System.class, null, "getSecurityManager"
);
Review comment:
System.getSecurityManager() is public ... why by reflections
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/util/internal/ObjectUtils.java
##
@@ -44,4 +46,11 @@ private ObjectUtils()
{
return ManagementFactory.getRuntimeMXBean().getSystemProperties();
}
+
+public static boolean isSecurityManagerSupported()
+{
+ClassLoader classLoader = ObjectUtils.class.getClassLoader();
+Class smClass = tryLoadClass( classLoader,
"java.lang.SecurityManager" );
+return smClass != null && !smClass.isAnnotationPresent(
Deprecated.class );
+}
Review comment:
Is checking java version >= 17 not enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #419: [SUREFIRE-1926] Console logs should be synchronized
Tibor17 commented on a change in pull request #419: URL: https://github.com/apache/maven-surefire/pull/419#discussion_r777108528 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java ## @@ -206,7 +207,7 @@ public void run() // if tests failed, but if this does not happen then printing warning to console is the only way to // inform the users. String msg = "ForkStarter IOException: " + e.getLocalizedMessage() + "."; -File reportsDir = defaultReporterFactory.getReportsDirectory(); +File reportsDir = reportMerger.getReportsDirectory(); Review comment: Because there must be abstraction. There are two DefaultReporterFactory instances. One is per fork, and another is the "merger". We simply cannot allow ForkStarter or the developer who is not aware of Surefire insides to call other methods than the "merger" can expose. Now, the answer for the following questions why this interface ReportsMerger exists in here is the fact that I implement the method writeTestOutput(). Of course I cannot allow the "merger" to call this method by any reason even if by mistake. So the ReportsMerger becomes a subinterface with limitted access excluding writeTestOutput() to prevent from calling it, to prevent from calling new implementation of this method, so that it will be called only in ForkClient and not in ForkStarter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-973) Please keep the property performRelease or provide an alternative for it
[
https://issues.apache.org/jira/browse/MRELEASE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467417#comment-17467417
]
Michael Osipov commented on MRELEASE-973:
-
[~rocher.suchard], thanks. [~o.b.fischer], what is your opinion?
> Please keep the property performRelease or provide an alternative for it
>
>
> Key: MRELEASE-973
> URL: https://issues.apache.org/jira/browse/MRELEASE-973
> Project: Maven Release Plugin
> Issue Type: Wish
> Components: perform
>Affects Versions: 3.0.0-M1
>Reporter: Oliver B. Fischer
>Priority: Critical
> Labels: compatibility, feature
> Fix For: waiting-for-feedback
>
>
> MRELEASE-896 deprecates the {{useReleaseProfile}} and changed its default
> value from {{true}} to {{false}}.
> Unfortunately this disabled also the setting of the property
> {{performRelease}} which we use to enable multiple profiles during the
> release process.
> At least we need a possibility to enable multiple, sometimes different,
> profiles during a release and its preparation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRELEASE-973) Please keep the property performRelease or provide an alternative for it
[
https://issues.apache.org/jira/browse/MRELEASE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467415#comment-17467415
]
Rocher Suchard commented on MRELEASE-973:
-
Hello,
I'd like first to comment this was not my issue: I simply commented with the
fact that [~rfscholte] reply can't work due to MRELEASE-1038
As I'm using the to enable gpg plugin, I can say this
alternative work and that I no longer have the "The requested profile "pom.xml"
could not be activated because it does not exist.".
=> For me, not from [~o.b.fischer] view point, the MRELEASE-1038 is fixed and
this one is fixed due to that.
Rocher
> Please keep the property performRelease or provide an alternative for it
>
>
> Key: MRELEASE-973
> URL: https://issues.apache.org/jira/browse/MRELEASE-973
> Project: Maven Release Plugin
> Issue Type: Wish
> Components: perform
>Affects Versions: 3.0.0-M1
>Reporter: Oliver B. Fischer
>Priority: Critical
> Labels: compatibility, feature
> Fix For: waiting-for-feedback
>
>
> MRELEASE-896 deprecates the {{useReleaseProfile}} and changed its default
> value from {{true}} to {{false}}.
> Unfortunately this disabled also the setting of the property
> {{performRelease}} which we use to enable multiple profiles during the
> release process.
> At least we need a possibility to enable multiple, sometimes different,
> profiles during a release and its preparation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SUREFIRE-1738) Unable to compile maven-surefire-plugin
[
https://issues.apache.org/jira/browse/SUREFIRE-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1738.
--
Resolution: Not A Problem
> Unable to compile maven-surefire-plugin
> ---
>
> Key: SUREFIRE-1738
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1738
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4
> Environment: JDKs: Zulu 8, Oracle 8, Oracle 7, Oracle 6, Zulu 11.
> Maven: 3.2.5, 3.3.5, 3.5.9,3.6.0
> Ubuntu Linux
>Reporter: Akom
>Assignee: Tibor Digana
>Priority: Major
> Labels: waiting-for-feedback
> Attachments: log.animal.sniffer.txt, log.compile.failure.txt,
> log.jacoco.txt
>
>
> I was trying to put together a PR but realized that I can't compile master
> even without any of my changes.
> I've tried many combinations of :
> *JDKs*: {color:#de350b}Zulu 8{color}, Oracle 8, Oracle 7, Oracle 6, Zulu 11.
> *Maven*: 3.2.5, 3.3.5, 3.5.9, {color:#de350b}3.6.0{color}
> I'm on commit *db16777568e87447813b2ee1b15e9b079211f098* (current master).
> *Command*: {color:#0747a6}mvn test [-Danimal.sniffer.skip=true]
> [-Djacoco.skip=true]{color}
> *Tools used* for logs below: Zulu 8 + Maven 3.6.0
> Errors encountered (separate errors, depending on what is turned off):
> # Compilation error in *maven-surefire-common* module. No actual errors are
> shown.
> # Error in *animal.sniffer* plugin (turned off with
> -Danimal.sniffer.skip=true)
> # Error in *jacoco* plugin (turned off with -Djacoco.skip=true)
> h2. Compilation Error Detail
> [^log.compile.failure.txt]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
> (default-compile) on project maven-surefire-common: Compilation failure
> h2. Animal Sniffer Error Detail
>
> [^log.animal.sniffer.txt]
> [ERROR] Bad class file
> /home/thisuser/workspace/maven-surefire/surefire-extensions-api/target/classes/org/apache/maven/surefire/extensions/StatelessTestsetInfoConsoleReportEventListener.class
> h2. Jacoco Error Detail
> [^log.jacoco.txt]
> [ERROR] Failed to execute goal
> org.jacoco:jacoco-maven-plugin:0.8.5:instrument (jacoco-instrumentation) on
> project surefire-extensions-api: Unable to instrument file.: Error while
> instrumenting
> /home/thisuser/workspace/maven-surefire/surefire-extensions-api/target/classes/org/apache/maven/surefire/extensions/StatelessTestsetInfoConsoleReportEventListener.class.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (SUREFIRE-1738) Unable to compile maven-surefire-plugin
[
https://issues.apache.org/jira/browse/SUREFIRE-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1738:
--
Assignee: Tibor Digana
> Unable to compile maven-surefire-plugin
> ---
>
> Key: SUREFIRE-1738
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1738
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4
> Environment: JDKs: Zulu 8, Oracle 8, Oracle 7, Oracle 6, Zulu 11.
> Maven: 3.2.5, 3.3.5, 3.5.9,3.6.0
> Ubuntu Linux
>Reporter: Akom
>Assignee: Tibor Digana
>Priority: Major
> Labels: waiting-for-feedback
> Attachments: log.animal.sniffer.txt, log.compile.failure.txt,
> log.jacoco.txt
>
>
> I was trying to put together a PR but realized that I can't compile master
> even without any of my changes.
> I've tried many combinations of :
> *JDKs*: {color:#de350b}Zulu 8{color}, Oracle 8, Oracle 7, Oracle 6, Zulu 11.
> *Maven*: 3.2.5, 3.3.5, 3.5.9, {color:#de350b}3.6.0{color}
> I'm on commit *db16777568e87447813b2ee1b15e9b079211f098* (current master).
> *Command*: {color:#0747a6}mvn test [-Danimal.sniffer.skip=true]
> [-Djacoco.skip=true]{color}
> *Tools used* for logs below: Zulu 8 + Maven 3.6.0
> Errors encountered (separate errors, depending on what is turned off):
> # Compilation error in *maven-surefire-common* module. No actual errors are
> shown.
> # Error in *animal.sniffer* plugin (turned off with
> -Danimal.sniffer.skip=true)
> # Error in *jacoco* plugin (turned off with -Djacoco.skip=true)
> h2. Compilation Error Detail
> [^log.compile.failure.txt]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
> (default-compile) on project maven-surefire-common: Compilation failure
> h2. Animal Sniffer Error Detail
>
> [^log.animal.sniffer.txt]
> [ERROR] Bad class file
> /home/thisuser/workspace/maven-surefire/surefire-extensions-api/target/classes/org/apache/maven/surefire/extensions/StatelessTestsetInfoConsoleReportEventListener.class
> h2. Jacoco Error Detail
> [^log.jacoco.txt]
> [ERROR] Failed to execute goal
> org.jacoco:jacoco-maven-plugin:0.8.5:instrument (jacoco-instrumentation) on
> project surefire-extensions-api: Unable to instrument file.: Error while
> instrumenting
> /home/thisuser/workspace/maven-surefire/surefire-extensions-api/target/classes/org/apache/maven/surefire/extensions/StatelessTestsetInfoConsoleReportEventListener.class.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-1738) Unable to compile maven-surefire-plugin
[
https://issues.apache.org/jira/browse/SUREFIRE-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467414#comment-17467414
]
Tibor Digana commented on SUREFIRE-1738:
It was not problem with Beanshell or
-Djavadoc.skip -Danimal.sniffer.skip=true -Djacoco.skip=true
or
-Xdoclint:none
or
other conspiracy theory with ** MAVEN_OPTS.
> Unable to compile maven-surefire-plugin
> ---
>
> Key: SUREFIRE-1738
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1738
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4
> Environment: JDKs: Zulu 8, Oracle 8, Oracle 7, Oracle 6, Zulu 11.
> Maven: 3.2.5, 3.3.5, 3.5.9,3.6.0
> Ubuntu Linux
>Reporter: Akom
>Priority: Major
> Labels: waiting-for-feedback
> Attachments: log.animal.sniffer.txt, log.compile.failure.txt,
> log.jacoco.txt
>
>
> I was trying to put together a PR but realized that I can't compile master
> even without any of my changes.
> I've tried many combinations of :
> *JDKs*: {color:#de350b}Zulu 8{color}, Oracle 8, Oracle 7, Oracle 6, Zulu 11.
> *Maven*: 3.2.5, 3.3.5, 3.5.9, {color:#de350b}3.6.0{color}
> I'm on commit *db16777568e87447813b2ee1b15e9b079211f098* (current master).
> *Command*: {color:#0747a6}mvn test [-Danimal.sniffer.skip=true]
> [-Djacoco.skip=true]{color}
> *Tools used* for logs below: Zulu 8 + Maven 3.6.0
> Errors encountered (separate errors, depending on what is turned off):
> # Compilation error in *maven-surefire-common* module. No actual errors are
> shown.
> # Error in *animal.sniffer* plugin (turned off with
> -Danimal.sniffer.skip=true)
> # Error in *jacoco* plugin (turned off with -Djacoco.skip=true)
> h2. Compilation Error Detail
> [^log.compile.failure.txt]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
> (default-compile) on project maven-surefire-common: Compilation failure
> h2. Animal Sniffer Error Detail
>
> [^log.animal.sniffer.txt]
> [ERROR] Bad class file
> /home/thisuser/workspace/maven-surefire/surefire-extensions-api/target/classes/org/apache/maven/surefire/extensions/StatelessTestsetInfoConsoleReportEventListener.class
> h2. Jacoco Error Detail
> [^log.jacoco.txt]
> [ERROR] Failed to execute goal
> org.jacoco:jacoco-maven-plugin:0.8.5:instrument (jacoco-instrumentation) on
> project surefire-extensions-api: Unable to instrument file.: Error while
> instrumenting
> /home/thisuser/workspace/maven-surefire/surefire-extensions-api/target/classes/org/apache/maven/surefire/extensions/StatelessTestsetInfoConsoleReportEventListener.class.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-1738) Unable to compile maven-surefire-plugin
[
https://issues.apache.org/jira/browse/SUREFIRE-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467413#comment-17467413
]
Tibor Digana commented on SUREFIRE-1738:
[~akomakom]
We know about this. The jacoco processes the test classes. The first run of mvn
install is okay but you have to clean the target folders like this mvn -nsu
clean install.
> Unable to compile maven-surefire-plugin
> ---
>
> Key: SUREFIRE-1738
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1738
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4
> Environment: JDKs: Zulu 8, Oracle 8, Oracle 7, Oracle 6, Zulu 11.
> Maven: 3.2.5, 3.3.5, 3.5.9,3.6.0
> Ubuntu Linux
>Reporter: Akom
>Priority: Major
> Labels: waiting-for-feedback
> Attachments: log.animal.sniffer.txt, log.compile.failure.txt,
> log.jacoco.txt
>
>
> I was trying to put together a PR but realized that I can't compile master
> even without any of my changes.
> I've tried many combinations of :
> *JDKs*: {color:#de350b}Zulu 8{color}, Oracle 8, Oracle 7, Oracle 6, Zulu 11.
> *Maven*: 3.2.5, 3.3.5, 3.5.9, {color:#de350b}3.6.0{color}
> I'm on commit *db16777568e87447813b2ee1b15e9b079211f098* (current master).
> *Command*: {color:#0747a6}mvn test [-Danimal.sniffer.skip=true]
> [-Djacoco.skip=true]{color}
> *Tools used* for logs below: Zulu 8 + Maven 3.6.0
> Errors encountered (separate errors, depending on what is turned off):
> # Compilation error in *maven-surefire-common* module. No actual errors are
> shown.
> # Error in *animal.sniffer* plugin (turned off with
> -Danimal.sniffer.skip=true)
> # Error in *jacoco* plugin (turned off with -Djacoco.skip=true)
> h2. Compilation Error Detail
> [^log.compile.failure.txt]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
> (default-compile) on project maven-surefire-common: Compilation failure
> h2. Animal Sniffer Error Detail
>
> [^log.animal.sniffer.txt]
> [ERROR] Bad class file
> /home/thisuser/workspace/maven-surefire/surefire-extensions-api/target/classes/org/apache/maven/surefire/extensions/StatelessTestsetInfoConsoleReportEventListener.class
> h2. Jacoco Error Detail
> [^log.jacoco.txt]
> [ERROR] Failed to execute goal
> org.jacoco:jacoco-maven-plugin:0.8.5:instrument (jacoco-instrumentation) on
> project surefire-extensions-api: Unable to instrument file.: Error while
> instrumenting
> /home/thisuser/workspace/maven-surefire/surefire-extensions-api/target/classes/org/apache/maven/surefire/extensions/StatelessTestsetInfoConsoleReportEventListener.class.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #419: [SUREFIRE-1926] Console logs should be synchronized
slawekjaranowski commented on a change in pull request #419:
URL: https://github.com/apache/maven-surefire/pull/419#discussion_r777105793
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java
##
@@ -65,7 +65,7 @@
* @author Kristian Rosenvold
*/
public class DefaultReporterFactory
-implements ReporterFactory
+implements ReporterFactory, ReportsMerger
Review comment:
next responsibility for this class - maybe will be possible create
separate class
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
##
@@ -206,7 +207,7 @@ public void run()
// if tests failed, but if this does not happen then
printing warning to console is the only way to
// inform the users.
String msg = "ForkStarter IOException: " +
e.getLocalizedMessage() + ".";
-File reportsDir =
defaultReporterFactory.getReportsDirectory();
+File reportsDir = reportMerger.getReportsDirectory();
Review comment:
why not
```
startupReportConfiguration.getReportsDirectory();
```
than we can remove this method from `ReportsMerger` interface.
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ReportsMerger.java
##
@@ -0,0 +1,36 @@
+package org.apache.maven.plugin.surefire.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.surefire.api.suite.RunResult;
+
+import java.io.File;
+import java.util.Collection;
+
+/**
+ * This interface is used to merge reports in {@link
org.apache.maven.plugin.surefire.booterclient.ForkStarter}.
+ */
+public interface ReportsMerger
+{
+void runStarting();
+void mergeFromOtherFactories( Collection factories
);
+File getReportsDirectory();
+RunResult close();
Review comment:
Name of method is not corresponding to what is doing ... inside `close`
method - there are calling
- `mergeTestHistoryResult`
- `runCompleted`
- and `close` on all listerneres colected in `mergeFromOtherFactories`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MRELEASE-1074) Upgrade Maven SCM to 1.12.2
Michael Osipov created MRELEASE-1074: Summary: Upgrade Maven SCM to 1.12.2 Key: MRELEASE-1074 URL: https://issues.apache.org/jira/browse/MRELEASE-1074 Project: Maven Release Plugin Issue Type: Dependency upgrade Components: scm Affects Versions: 3.0.0-M4 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.0.0 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439640#comment-17439640
]
Michael Osipov edited comment on MRELEASE-1072 at 1/1/22, 11:28 AM:
Where is the bug? You mean it is not readded afterwards?
was (Author: michael-o):
Where is the bug? You mean it is not readied afterwards?
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
>
> In case the original {{project.scm}} section contains a tag element (e.g.
> with value "trunk") this is removed during prepare for the next snapshot
> version. The tagged/release version contains the properly adjusted tag
> element.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRELEASE-973) Please keep the property performRelease or provide an alternative for it
[
https://issues.apache.org/jira/browse/MRELEASE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467403#comment-17467403
]
Michael Osipov commented on MRELEASE-973:
-
[~rocher.suchard], M4 has been delivered can your problem be solved with it?
> Please keep the property performRelease or provide an alternative for it
>
>
> Key: MRELEASE-973
> URL: https://issues.apache.org/jira/browse/MRELEASE-973
> Project: Maven Release Plugin
> Issue Type: Wish
> Components: perform
>Affects Versions: 3.0.0-M1
>Reporter: Oliver B. Fischer
>Priority: Critical
> Labels: compatibility, feature
> Fix For: waiting-for-feedback
>
>
> MRELEASE-896 deprecates the {{useReleaseProfile}} and changed its default
> value from {{true}} to {{false}}.
> Unfortunately this disabled also the setting of the property
> {{performRelease}} which we use to enable multiple profiles during the
> release process.
> At least we need a possibility to enable multiple, sometimes different,
> profiles during a release and its preparation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MRELEASE-973) Please keep the property performRelease or provide an alternative for it
[
https://issues.apache.org/jira/browse/MRELEASE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-973:
Fix Version/s: waiting-for-feedback
> Please keep the property performRelease or provide an alternative for it
>
>
> Key: MRELEASE-973
> URL: https://issues.apache.org/jira/browse/MRELEASE-973
> Project: Maven Release Plugin
> Issue Type: Wish
> Components: perform
>Affects Versions: 3.0.0-M1
>Reporter: Oliver B. Fischer
>Priority: Critical
> Labels: compatibility, feature
> Fix For: waiting-for-feedback
>
>
> MRELEASE-896 deprecates the {{useReleaseProfile}} and changed its default
> value from {{true}} to {{false}}.
> Unfortunately this disabled also the setting of the property
> {{performRelease}} which we use to enable multiple profiles during the
> release process.
> At least we need a possibility to enable multiple, sometimes different,
> profiles during a release and its preparation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MRELEASE-1046) Upgrade Plexus Utils to 3.3.0
[ https://issues.apache.org/jira/browse/MRELEASE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1046: - Fix Version/s: (was: 3.0.0-M4) > Upgrade Plexus Utils to 3.3.0 > - > > Key: MRELEASE-1046 > URL: https://issues.apache.org/jira/browse/MRELEASE-1046 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M2 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MRELEASE-1046) Upgrade Plexus Utils to 3.3.0
[ https://issues.apache.org/jira/browse/MRELEASE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1046. Resolution: Fixed The issue has been addressed. It is causing regression a new bug must be spawned. > Upgrade Plexus Utils to 3.3.0 > - > > Key: MRELEASE-1046 > URL: https://issues.apache.org/jira/browse/MRELEASE-1046 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M4, 3.0.0-M2 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (MRELEASE-1046) Upgrade Plexus Utils to 3.3.0
[ https://issues.apache.org/jira/browse/MRELEASE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRELEASE-1046: Assignee: Michael Osipov > Upgrade Plexus Utils to 3.3.0 > - > > Key: MRELEASE-1046 > URL: https://issues.apache.org/jira/browse/MRELEASE-1046 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M4, 3.0.0-M2 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SCM-883) ScmFileSet DEFAULT_EXCLUDES too restrictive
[ https://issues.apache.org/jira/browse/SCM-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467401#comment-17467401 ] Michael Osipov commented on SCM-883: [~Köntopp], was lange währt, wird endlich gut! > ScmFileSet DEFAULT_EXCLUDES too restrictive > --- > > Key: SCM-883 > URL: https://issues.apache.org/jira/browse/SCM-883 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-api >Affects Versions: 1.9.5 >Reporter: Fabian Köntopp >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0-M1, 1.12.1, 1.12.2 > > > We are trying to automate a process in which a default *.gitignore* file > *only* (ignoring the current state of the repository) is added to a > repository at the root level. Because of the DEFAULT_EXCLUDES in the > ScmFileSet-Class this is impossible because .gitignore is listed there and > the default excludes are always added to the final exlude list. > In my opinion the .gitignore file should not be listed there because such > files are part of a git repository. At least it should be possible to > override the excludes completely without the DEFAULT_EXCLUDES always being > added. -- This message was sent by Atlassian Jira (v8.20.1#820001)
