[jira] [Reopened] (MRESOLVER-235) Managed dependencies are not honoured when resolving a dependency graph
[ https://issues.apache.org/jira/browse/MRESOLVER-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reopened MRESOLVER-235: --- Assignee: Guillaume Nodet Reopening this issue because though the problem is similar to MRESOLVER-9, the exact issue and solution is different. > Managed dependencies are not honoured when resolving a dependency graph > --- > > Key: MRESOLVER-235 > URL: https://issues.apache.org/jira/browse/MRESOLVER-235 > Project: Maven Resolver > Issue Type: Bug >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-site] hboutemy commented on a change in pull request #287: Maven Repositories documentation
hboutemy commented on a change in pull request #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r788437909 ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,88 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store artifacts. Your dependencies are being downloaded from repositories, +and your artifacts are being stored (installed, uploaded) into repositories as well. This is one of the +fundamental concepts of Maven since its inception: Maven command line tool and Maven Repositories were mold together +and developed since the beginning of Maven project itself. + +As you may know, Maven addresses artifacts using coordinates, that are most often represented as +`groupId:artifactId:version`, or GAV in short or when informally used (please note that Artifact coordinates has +more fields, but for brevity we still call the coordinates "GAV", not "GAVCE"). The artifact coordinate uniquely +describe the artifact you are referring to, but does not tell anything about its source (or origin). It is up to +Maven to figure out (or you to tell Maven how to figure it out). + +While Maven internally uses notion of "artifact" thoroughly (just look at sources!), end user may never hit this name. +That's due the fact, that while for Maven, "everything is artifact" (internally), the end users actually speak about +"projects", "parent projects", "dependencies", "build plugins", "build extensions" and so on. + +## Artifact properties + +The artifacts that Maven (internally) uses has following (among many others, but for our topic related) properties: + +| Name | Description | +||-| +| groupId| The artifact group name | +| artifactId | The artifact name | +| version| The artifact version | +| classifier | The artifact distinguishing classifier | +| extension | The artifact extension | + +And some more, a bit of special one: `baseVersion` that is actually derived from version (or other way around, +depends on context): for release artifacts holds same value as `version`, for snapshot artifacts holds "non-timestamped +snapshot version". For example, for `version` "1.0-20220119.164608-1" value the `baseVersion` would have value +"1.0-SNAPSHOT". + +## But where do I set artifact extension? + +In short, nowhere. Or maybe "you rarely have to". Maven POM (where you declare your project, parent project, +dependencies, plugins and other), maps those elements onto artifact coordinates with some simple mapping. In case +of "project" and "parent project" (aka POMs): Review comment: very good question: here is my answer https://github.com/apache/maven-site/commit/22f23df1049da80b794eab430d415c56dfd97f54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-481) JPMS Regression: cannot access (requires static module not include anymore)
[
https://issues.apache.org/jira/browse/MCOMPILER-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479103#comment-17479103
]
Olivier Lamy commented on MCOMPILER-481:
[~rfscholte] I started a branch called MCOMPILER-481-requires-static-included
draft PR [https://github.com/apache/maven-compiler-plugin/pull/82]
This PR include the sample project as a new IT test.
simple change ResolvePathsRequest.setIncludeStatic(true) do not fix the problem
I made some other changes in plexus-java see draft PR
[https://github.com/codehaus-plexus/plexus-languages/pull/106] the changes fix
this problem but there is now 2 test failures
still investigating
> JPMS Regression: cannot access (requires static module not include
> anymore)
> ---
>
> Key: MCOMPILER-481
> URL: https://issues.apache.org/jira/browse/MCOMPILER-481
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Simone Bordet
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: compiler-bug.tar.gz
>
>
> Version 3.8.1 is not affected.
> The problem lies in how the module-path is constructed by the
> maven-compiler-plugin – not sure what changes from 3.8.1 caused this.
> In 3.8.1:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> In 3.9.0:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> Running with 3.9.0 yields:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project compiler-bug-app: Compilation failure
> [ERROR]
>
[GitHub] [maven-compiler-plugin] olamy opened a new pull request #82: [MCOMPILER-481] compiler plugin should include static module for compilation
olamy opened a new pull request #82: URL: https://github.com/apache/maven-compiler-plugin/pull/82 Signed-off-by: Olivier Lamy Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a change in pull request #63: [MPOM-288] - Update m-plugin-p to 3.6.4
ctubbsii commented on a change in pull request #63:
URL: https://github.com/apache/maven-apache-parent/pull/63#discussion_r788361219
##
File path: pom.xml
##
@@ -92,10 +92,21 @@ under the License.
${maven.compiler.target}
1.7
2.22.2
+3.6.4
posix
2021-07-14T15:10:38Z
+
+
+
+org.apache.maven.plugin-tools
+maven-plugin-annotations
+${maven.plugin.tools.version}
+
Review comment:
@kwin Even if it is extremely unlikely (I'm not going to say never,
because people are creative), it's still going to create confusion, because
people assume if the scope isn't specified, it is `compile`. Maven is built
around a certain amount of convention. The more you break those conventions,
the more it gets confusing.
For the users who might actually want it in the `compile` scope, you're
really creating a problem for them, because now they have to explicitly add
`compile`... *and* they probably have to leave a comment in for
other developers, because lots of developers would just delete that line
because they know it's not necessary most of the time.
If users actually want it to be `provided` (and yeah, they probably would
much of the time for this one), then they're probably going to set it
explicitly anyway. When they do, the one in the ``
section is redundant and adds no value.
So, best case scenario, when users are following conventions, it does not
serve a purpose because it's redundant. Worst case scenario, you're really
screwing with people's understanding of Maven because you've broken a pretty
widely known convention.
The `` section is useful when it helps with dependency
convergence (version management, transitive dependency exclusions, etc.). But
setting the scope there severely disrupts conventions and has substantial
downstream impact on anybody using this as a parent POM, because it quite
literally alters their class paths.
I strongly advise against breaking conventions like this in such a widely
used parent POM that could break people's understanding of how Maven works, or
messes with which jars are available in which class paths. In general, I
strongly recommend against setting the scope in any ``
section, unless it's `pom` and `import`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request #92: Bump slf4j-simple from 1.7.32 to 1.7.33
dependabot[bot] opened a new pull request #92: URL: https://github.com/apache/maven-invoker-plugin/pull/92 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.32 to 1.7.33. Commits https://github.com/qos-ch/slf4j/commit/2758a974264ab65df3af1d473eb9423ca978c14a;>2758a97 prepare release 1.7.33 https://github.com/qos-ch/slf4j/commit/a0681b72eb0d7c40733f02633e4f2677997b6fce;>a0681b7 fix SLF4J-499 https://github.com/qos-ch/slf4j/commit/c89dc3db0f84e0e529fd518f9b3085ad8f2499da;>c89dc3d Merge branch '1.7-maintenance' of github.com:qos-ch/slf4j into 1.7-maintenance https://github.com/qos-ch/slf4j/commit/0d2bd398f738f751a0814d9a0032310812773978;>0d2bd39 add slf4j-reload4j module https://github.com/qos-ch/slf4j/commit/ae9ee009f6ffbeae5a9ace85017b027aa5090ab3;>ae9ee00 start work on 1.7.33-SNAPSHOT See full diff in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] zonepanda opened a new issue #586: Using mvnd installed in WIN10 and run it in a git shell window, it will blocked, after a enter key pressed, got a null exception!
zonepanda opened a new issue #586: URL: https://github.com/apache/maven-mvnd/issues/586 I download mvnd-0.7.1-windows-amd64 into my WIN10 computer, and running mvnd in a git shell window, it blocked, after enter pressed, a null pointer exception throws out, and then the cmd works out. Stacks below: $ mvnd --version Exception in thread "Thread-0" java.lang.NullPointerException at org.mvndaemon.mvnd.common.logging.TerminalOutput.readInputLoop(TerminalOutput.java:477) at java.lang.Thread.run(Thread.java:833) at com.oracle.svm.core.thread.JavaThreads.threadStartRoutine(JavaThreads.java:596) at com.oracle.svm.core.windows.WindowsJavaThreads.osThreadStartRoutine(WindowsJavaThreads.java:138) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #399: [SUREFIRE-1963] Detecting multiple test-frameworks
Tibor17 edited a comment on pull request #399: URL: https://github.com/apache/maven-surefire/pull/399#issuecomment-1016979180 @slawekjaranowski It would be great to have a sample project, in your GH, with several options and the playground with dependencies and the ignored tests. I think, we should start this way and we do it in customers the same way when the users decide to open a ticket in ASF Jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
Tibor17 commented on a change in pull request #389:
URL: https://github.com/apache/maven-surefire/pull/389#discussion_r788253466
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##
@@ -231,6 +225,21 @@ private void execute( TestsToRun testsToRun,
RunListenerAdapter adapter )
} );
}
}
+
+private void closeLauncher()
+{
+if ( launcher instanceof AutoCloseable )
+{
+try
+{
+( (AutoCloseable) launcher ).close();
+}
+catch ( Exception e )
+{
+throw new SurefireReflectionException( e );
Review comment:
@papegaaij
ok, no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #399: [SUREFIRE-1963] Detecting multiple test-frameworks
Tibor17 commented on pull request #399: URL: https://github.com/apache/maven-surefire/pull/399#issuecomment-1016979180 @slawekjaranowski It would be great to have a sample project with several options and the playground with dependencies and the ignored tests. I think, we should start this way and we do it in customers the same way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] ibabiankou commented on pull request #144: Use BFS approach
ibabiankou commented on pull request #144: URL: https://github.com/apache/maven-resolver/pull/144#issuecomment-1016938859 @caiwei-ebay FYI: I've pushed some changes, but a few of the original comments are still to be addressed. I also want to have a fresh look at the naming and javadoc after that. I'll try to wrap it up tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] ibabiankou commented on a change in pull request #144: Use BFS approach
ibabiankou commented on a change in pull request #144:
URL: https://github.com/apache/maven-resolver/pull/144#discussion_r788205320
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -343,36 +358,75 @@ private static String getId( Artifact a )
return a.getGroupId() + ':' + a.getArtifactId() + ':' +
a.getClassifier() + ':' + a.getExtension();
}
+private void processNode( Args args, Results results, DependencyNode
current )
+{
+DataPool.DependencyNodeTraceContext traceContext =
args.pool.getTraceContext( current );
+if ( traceContext == null || !traceContext.recursive )
+{
+return;
+}
+
+DependencySelector selector = traceContext.depSelector;
+DependencyManager manager = traceContext.depManager;
+DependencyTraverser traverser = traceContext.depTraverser;
+VersionFilter filter = traceContext.verFilter;
+
+if ( traceContext.isRoot )
+{
+//Should not cache the children of root node just like original
DFS solution
Review comment:
I moved the caching logic back to the place where it used to be, it
makes smaller diff and simplifies the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] ibabiankou commented on a change in pull request #144: Use BFS approach
ibabiankou commented on a change in pull request #144:
URL: https://github.com/apache/maven-resolver/pull/144#discussion_r788204275
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DataPool.java
##
@@ -182,6 +187,89 @@ public void putChildren( Object key, List
children )
nodes.put( key, children );
}
+public DependencyNodeTraceContext getTraceContext( DependencyNode node )
+{
+return nodeTraceContexts.get( node );
+}
+
+public void putTraceContext( DependencyNode node,
DependencyNodeTraceContext context )
+{
+nodeTraceContexts.put( node, context );
+}
+
+public void putParent( DependencyNode node, DependencyNode parent )
+{
+nodeParents.put( node, parent );
+}
+
+
+/**
+ * Get all parents of current node (including current node) following the
top-down sequence (parent -> child)
+ *
+ * @return
+ */
+public List getAllNodes( DependencyNode current )
+{
+return getAllNodes( current, true );
+}
+
+public List getAllNodes( DependencyNode current, boolean
reverse )
+{
+List nodes = new ArrayList<>();
+nodes.add( current );
+
+DependencyNode parent = nodeParents.get( current );
+while ( parent != null )
+{
+nodes.add( parent );
+parent = nodeParents.get( parent );
+}
+
+if ( reverse )
+{
+Collections.reverse( nodes );
+}
+return nodes;
+}
+
+/**
+ * Trace the objects required for inheritance
+ */
+static final class DependencyNodeTraceContext
+{
+DependencySelector depSelector;
+DependencyManager depManager;
+DependencyTraverser depTraverser;
+VersionFilter verFilter;
+List repositories;
+List dependencies;
+List managedDependencies;
+List allNodes;
+boolean isRoot;
+boolean recursive;
+
+@SuppressWarnings( "checkstyle:parameternumber" )
+DependencyNodeTraceContext( DependencySelector depSelector,
+DependencyManager depManager,
+DependencyTraverser depTraverser,
+VersionFilter verFilter,
+List repositories,
+List dependencies,
+List managedDependencies,
List allNodes,
+boolean recursive )
Review comment:
When `recursive` of original implementation is `false`, the instance of
this context is not created, so this one is always `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-apache-parent] kwin commented on a change in pull request #63: [MPOM-288] - Update m-plugin-p to 3.6.4
kwin commented on a change in pull request #63:
URL: https://github.com/apache/maven-apache-parent/pull/63#discussion_r788171242
##
File path: pom.xml
##
@@ -92,10 +92,21 @@ under the License.
${maven.compiler.target}
1.7
2.22.2
+3.6.4
posix
2021-07-14T15:10:38Z
+
+
+
+org.apache.maven.plugin-tools
+maven-plugin-annotations
+${maven.plugin.tools.version}
+
Review comment:
This particular dependency should IMHO never be used with another scope,
so this may warrant to set scope in depMgmt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 closed pull request #424: Surefire shared utils,
Tibor17 closed pull request #424: URL: https://github.com/apache/maven-surefire/pull/424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 edited a comment on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1016883323 Hi @imonteroperez ;-) Yes of course we will use your ITs. I am glad that you have joined us again! We also need to have updates of the documentation (Javadoc) of the config parameters. Do you have it as well in your commits? Can we use it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1016883323 Hi @imonteroperez :-) Yes of course we will use your ITs. I am glad that you have joined us again! We also need to have updates of the documentation (Javadoc) of the config parameters. Do you have it as well in your commits? Can we use it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7047) Validate that repo configuration does not contain any expression
[ https://issues.apache.org/jira/browse/MNG-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478978#comment-17478978 ] Hudson commented on MNG-7047: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-5995-x #4 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-5995-x/4/ > Validate that repo configuration does not contain any expression > > > Key: MNG-7047 > URL: https://issues.apache.org/jira/browse/MNG-7047 > Project: Maven > Issue Type: Improvement > Components: Inheritance and Interpolation >Affects Versions: 3.6.3 >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Minor > Fix For: 4.0.0, 4.0.0-alpha-1 > > > MNG-7046 reverts the option to allow expressions in the repository > configuration. This should be secured in the ModelValidator to prevent > regression in the future. > As of Maven 4 expressions in the repository will fail the build. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-5561) Plugin relocation loses configuration
[
https://issues.apache.org/jira/browse/MNG-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478979#comment-17478979
]
Hudson commented on MNG-5561:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-5995-x #4
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-5995-x/4/
> Plugin relocation loses configuration
> -
>
> Key: MNG-5561
> URL: https://issues.apache.org/jira/browse/MNG-5561
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle
>Affects Versions: 3.1.1
>Reporter: Julien CARSIQUE
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: screenshot-1.png
>
>
> Hi,
> Applying a relocation on a plugin seems to lose its configuration.
> In the following sample, I relocated "nuxeo-distribution-tools" to
> "ant-assembly-maven-plugin" and the missing configured parameter is
> "buildFile". The relocation itself went well but the execution fails because
> of a missing parameter.
> {code:title=~/.m2/repository/org/nuxeo/build/nuxeo-distribution-tools/2.0-SNAPSHOT/nuxeo-distribution-tools-2.0-SNAPSHOT.pom}
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd;>
> 4.0.0
> org.nuxeo.build
> nuxeo-distribution-tools
> 2.0-SNAPSHOT
> maven-plugin
> Nuxeo Distribution Build
> Assemble Nuxeo distributions
>
>
> ant-assembly-maven-plugin
>
>
> {code}
> {code:title=executed POM extract}
>
>
>
> org.nuxeo.build
>
> nuxeo-distribution-tools
>
>
>
>
> assemble
> package
>
>
> src/main/assemble/assembly.xml
>
>
> build
>
>
>
>
>
>
> {code}
> Here is the diff between an "mvn package -X" with nuxeo-distribution-tools
> (ie: with relocation; line starting with "<") and another one with
> ant-assembly-maven-plugin (ie: without relocation; line starting with ">"):
> {noformat}< [DEBUG] Dependency collection stats:
> {ConflictMarker.analyzeTime=1, ConflictMarker.markTime=0,
> ConflictMarker.nodeCount=72, ConflictIdSorter.graphTime=0,
> ConflictIdSorter.topsortTime=0, ConflictIdSorter.conflictIdCount=34,
> ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=1,
> ConflictResolver.conflictItemCount=71,
> DefaultDependencyCollector.collectTime=10,
> DefaultDependencyCollector.transformTime=2}
> > [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=1,
> > ConflictMarker.markTime=0, ConflictMarker.nodeCount=72,
> > ConflictIdSorter.graphTime=0, ConflictIdSorter.topsortTime=0,
> > ConflictIdSorter.conflictIdCount=34,
> > ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2,
> > ConflictResolver.conflictItemCount=71,
> > DefaultDependencyCollector.collectTime=65,
> > DefaultDependencyCollector.transformTime=3}
> ---
> < [DEBUG] Created new class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> < [DEBUG] Importing foreign packages into class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> > [DEBUG] Created new class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> > [DEBUG] Importing foreign packages into class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> ---
> < [DEBUG] Populating class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> > [DEBUG] Populating class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> ---
> < [DEBUG] Configuring mojo
> org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT:build from plugin
> realm
> ClassRealm[plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT,
> parent: sun.misc.Launcher$AppClassLoader@591ce4fe]
> > [DEBUG] Configuring mojo
> > org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT:build from plugin
> > realm
> > ClassRealm[plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT,
> > parent: sun.misc.Launcher$AppClassLoader@77fe0d66]
> ---
> > [DEBUG] (f) buildFile =
> > /home/julien/ws-ssd/nuxeo/nuxeo-distribution/nuxeo-distribution-resources/src/main/assemble/assembly.xml{noformat}
> The last line highlights the missing parameter.
> Indeed, it seems that in case of a relocation, all the "Parameter" Mojo
> fields take their default value (or none) whereas the "Component" fields are
> still properly injected.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-7217) Completely update CLI handling according to Commons CLI 1.5 documentation
[
https://issues.apache.org/jira/browse/MNG-7217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478981#comment-17478981
]
Hudson commented on MNG-7217:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-5995-x #4
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-5995-x/4/
> Completely update CLI handling according to Commons CLI 1.5 documentation
> -
>
> Key: MNG-7217
> URL: https://issues.apache.org/jira/browse/MNG-7217
> Project: Maven
> Issue Type: Task
> Components: Command Line
>Reporter: Michael Osipov
>Assignee: Maarten Mulders
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> We currently don't have code which complies with the documentation of Commons
> CLI 1.5. As soon as we move we can address a few issues, e.g., support of
> {{--}} to separate options from real args.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6326) Build continues when core extensions aren't found
[ https://issues.apache.org/jira/browse/MNG-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478980#comment-17478980 ] Hudson commented on MNG-6326: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-5995-x #4 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-5995-x/4/ > Build continues when core extensions aren't found > - > > Key: MNG-6326 > URL: https://issues.apache.org/jira/browse/MNG-6326 > Project: Maven > Issue Type: Bug > Components: Bootstrap Build >Affects Versions: 3.5.2 >Reporter: Matt Biggs >Assignee: Guillaume Nodet >Priority: Critical > Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5 > > > If you define a core extension in *.mvn/extensions.xml* which then can't be > retrieved/found the build issues a warning and then continues leading to > unexpected behaviour depending on the functionality provided by the > extension. > If the extension is defined in the pom and not found the build fails. I would > have expected it to fail when not found in the external extensions.xml file > too as it's quite easy to miss the fact it failed to retrieve it. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7045) Drop CDI API from Maven
[ https://issues.apache.org/jira/browse/MNG-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478976#comment-17478976 ] Hudson commented on MNG-7045: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-5995-x #4 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-5995-x/4/ > Drop CDI API from Maven > --- > > Key: MNG-7045 > URL: https://issues.apache.org/jira/browse/MNG-7045 > Project: Maven > Issue Type: Bug > Components: Core >Reporter: Romain Manni-Bucau >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: 3.8.3, 4.0.0, 4.0.0-alpha-1 > > > This is an old leak which triggered a lot of regressions and still triggers > bugs in mojos. > Since there is on real justification in maven itself (@Typed is not since > there are alternative and cdi is not used in any piece of maven), let's drop > it. > If a plugin needs it, it already has it since cdi-api is outdated anyway. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MWRAPPER-14) Make maven wrapper functional
[
https://issues.apache.org/jira/browse/MWRAPPER-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478977#comment-17478977
]
Hudson commented on MWRAPPER-14:
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-5995-x #4
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-5995-x/4/
> Make maven wrapper functional
> -
>
> Key: MWRAPPER-14
> URL: https://issues.apache.org/jira/browse/MWRAPPER-14
> Project: Maven Wrapper
> Issue Type: Task
>Affects Versions: 3.0.2
>Reporter: Tamás Cservenák
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.1.0
>
>
> Make a wrapper a normal wrapper. The wrapper is not meant to be part of any
> distribution, but a lightweight way to bootstrap maven without the need to
> install it onto target machine.
> With legacy wrapper:
> * checked out project "just works"
> * you know it builds with proper maven
> * exclude any mistake like install ancient mvn version or some distro
> mutilated mvn
> This is the main goal, and by having apache groupId, {{wrapper:wrapper}}
> should work like before.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-7335) [Regression] Parallel build fails due to missing JAR artifacts in compilePath
[
https://issues.apache.org/jira/browse/MNG-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478975#comment-17478975
]
Hudson commented on MNG-7335:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-5995-x #4
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-5995-x/4/
> [Regression] Parallel build fails due to missing JAR artifacts in compilePath
> -
>
> Key: MNG-7335
> URL: https://issues.apache.org/jira/browse/MNG-7335
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.4, 4.0.0-alpha-1
> Environment: - Linux (tested Docker using maven:3-jdk-8 tag): happens
> most times.
> - Windows 10: happens sometimes.
>Reporter: Falko Modler
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
>
> *The following was cloned from MNG-6843 which was fixed in 3.8.2 and 3.8.3,
> but came back in 3.8.4 due to MNG-7312:*
> Build of our multi module (57) Java maven project is failing phase when
> running it as parallel in 4 threads (mvn -T 4 clean install). The failure
> happens during compilation because packages/classes from compile dependencies
> cannot be found:
> {noformat}
> [main] [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile
> (default-compile) on project common: Compilation failure: Compilation
> failure:
> [main] [ERROR]
> /home/common/src/main/java/com/foo/ZonedDateTimeParser.java:[6,32] package
> org.apache.commons.lang3 does not exist{noformat}
> After enabling debug logging (with thread names) I have found out that a
> compile path of the failing module is empty (besides target/classes):
> When running in 4 threads (-T 4):
> {noformat}
> [BuilderThread 2] [DEBUG] (f) compilePath = [/home/common/target/classes]
> ...
> [BuilderThread 2] [DEBUG] Command line options:
> [BuilderThread 2] [DEBUG] -d /home/common/target/classes -classpath
> /home/common/target/classes: -sourcepath
> /home/common/src/main/java:/home/common/target/generated-sources/annotations:
> -s /home/common/target/generated-sources/annotations -g -nowarn -target 1.8
> -source 1.8 -encoding UTF-8{noformat}
> When running in a single thread (-T 1):
> {noformat}
> [BuilderThread 0] [DEBUG] (f) compilePath = [/home/common/target/classes,
> /root/.m2/repository/commons-beanutils/commons-beanutils/1.9.3/commons-beanutils-1.9.3.jar,
>
> /root/.m2/repository/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar,
>
> /root/.m2/repository/org/apache/commons/commons-collections4/4.3/commons-collections4-4.3.jar,
>
> /root/.m2/repository/org/apache/commons/commons-lang3/3.9/commons-lang3-3.9.jar,
> /root/.m2/repository/org/jooq/jool-java-8/0.9.14/jool-java-8-0.9.14.jar,
> /root/.m2/repository/org/slf4j/slf4j-api/1.7.26/slf4j-api-1.7.26.jar,
> /root/.m2/repository/org/springframework/spring-beans/5.1.8.RELEASE/spring-beans-5.1.8.RELEASE.jar,
>
> /root/.m2/repository/org/springframework/spring-core/5.1.8.RELEASE/spring-core-5.1.8.RELEASE.jar,
>
> /root/.m2/repository/org/springframework/spring-context/5.1.8.RELEASE/spring-context-5.1.8.RELEASE.jar]
> ...
> [BuilderThread 0] [DEBUG] Command line options:
> [BuilderThread 0] [DEBUG] -d /home/common/target/classes -classpath
> /home/common/target/classes:/root/.m2/repository/commons-beanutils/commons-beanutils/1.9.3/commons-beanutils-1.9.3.jar:/root/.m2/repository/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar:/root/.m2/repository/org/apache/commons/commons-collections4/4.3/commons-collections4-4.3.jar:/root/.m2/repository/org/apache/commons/commons-lang3/3.9/commons-lang3-3.9.jar:/root/.m2/repository/org/jooq/jool-java-8/0.9.14/jool-java-8-0.9.14.jar:/root/.m2/repository/org/slf4j/slf4j-api/1.7.26/slf4j-api-1.7.26.jar:/root/.m2/repository/org/springframework/spring-beans/5.1.8.RELEASE/spring-beans-5.1.8.RELEASE.jar:/root/.m2/repository/org/springframework/spring-core/5.1.8.RELEASE/spring-core-5.1.8.RELEASE.jar:/root/.m2/repository/org/springframework/spring-context/5.1.8.RELEASE/spring-context-5.1.8.RELEASE.jar:
> -sourcepath
> /home/common/src/main/java:/home/common/target/generated-sources/annotations:
> -s /home/common/target/generated-sources/annotations -g -nowarn -target 1.8
> -source 1.8 -encoding UTF-8{noformat}
> After adding custom log messages I have found out that the root cause is that
> org.apache.maven.project.MavenProject.setArtifactFilter() is called with null
> artifactFilter parameter. The call happens for the failing module from a
> thread that is building another module. The call stack is:
> {code:java}
> "BuilderThread 0@2513" prio=5 tid=0xe nid=NA runnable
> java.lang.Thread.State: RUNNABLE
> at
>
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422: URL: https://github.com/apache/maven-surefire/pull/422#discussion_r788128773 ## File path: surefire-providers/surefire-junit3/src/test/java/org/apache/maven/surefire/junit/JUnitTestSetTest.java ## @@ -22,15 +22,19 @@ import junit.framework.Test; import junit.framework.TestCase; import junit.framework.TestSuite; +import org.apache.maven.surefire.api.testset.TestSetFailedException; import org.apache.maven.surefire.common.junit3.JUnit3Reflector; import org.apache.maven.surefire.api.report.ReportEntry; import org.apache.maven.surefire.api.report.RunListener; import org.apache.maven.surefire.api.report.RunMode; import org.apache.maven.surefire.api.report.TestSetReportEntry; +import org.apache.maven.surefire.shared.lang3.JavaVersion; Review comment: @slawekjaranowski It has certain purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r788127548
##
File path: .github/workflows/maven-verify.yml
##
@@ -15,19 +15,49 @@
# specific language governing permissions and limitations
# under the License.
-name: Verify
+name: GitHub CI
on:
push:
branches-ignore:
- dependabot/**
pull_request:
+
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+
+steps:
+ - name: Checkout
+uses: actions/checkout@v1
+
+ - name: Set up JDK ${{ matrix.java }}
+uses: actions/setup-java@v2.4.0
+with:
+ distribution: ${{ matrix.jdk }}
+ java-version: ${{ matrix.java }}
+ cache: 'maven'
+
+ - name: Build with Maven
+run: mvn clean install -e -B -V -nsu --no-transfer-progress -P run-its
-Dfailsafe-integration-test-port=8083
+
+ - name: Upload artifact surefire-its
+uses: actions/upload-artifact@v2-preview
+if: failure()
+with:
+ name: ${{ matrix.os }}-surefire-its
+ path: |
+surefire-its/target/*/log.txt
+surefire-its/target/**/surefire-reports/*
+surefire-its/target/**/failsafe-reports/*
+!surefire-its/target/failsafe-reports
Review comment:
@slawekjaranowski
This change does not exit in this branch any longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r788127170
##
File path: .github/workflows/maven-verify.yml
##
@@ -25,9 +25,29 @@ on:
jobs:
build:
-name: Verify
-uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
-with:
- ff-goal: 'install'
- verify-goal: 'install -P run-its'
- verify-fail-fast: false
+strategy:
+ matrix:
+os: [ubuntu-latest, windows-latest, macOS-latest]
+java: [8, 11, 17]
+jdk: [temurin, zulu]
+ fail-fast: false
+
+runs-on: ${{ matrix.os }}
+timeout-minutes: 120
+steps:
+- name: Verify
+ uses:
apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v1
Review comment:
@slawekjaranowski
This change does not exit in this branch any longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r788126504
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/util/internal/ObjectUtils.java
##
@@ -44,4 +46,11 @@ private ObjectUtils()
{
return ManagementFactory.getRuntimeMXBean().getSystemProperties();
}
+
+public static boolean isSecurityManagerSupported()
+{
+ClassLoader classLoader = ObjectUtils.class.getClassLoader();
+Class smClass = tryLoadClass( classLoader,
"java.lang.SecurityManager" );
+return smClass != null && !smClass.isAnnotationPresent(
Deprecated.class );
+}
Review comment:
@slawekjaranowski
Now JavaVersion is in use!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r788126157
##
File path:
surefire-providers/surefire-junit3/src/test/java/org/apache/maven/surefire/junit/JUnitTestSetTest.java
##
@@ -54,6 +58,32 @@ public void testExecuteSuiteClass()
succeededTests.get( 0 ).getName() );
}
+public void testSystemManager()
+{
+float javaVersion = Float.parseFloat(
JavaVersion.JAVA_RECENT.toString() );
+boolean isDeprecated = javaVersion >= 17;
+try
+{
+JUnit3Provider.setSystemManager( "java.lang.SecurityManager" );
+
+if ( isDeprecated )
+{
+fail();
+}
+
+Object sm = invokeGetter( System.class, null, "getSecurityManager"
);
Review comment:
@slawekjaranowski
SecurityManager can be deleted in any major version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a change in pull request #63: [MPOM-288] - Update m-plugin-p to 3.6.4
ctubbsii commented on a change in pull request #63:
URL: https://github.com/apache/maven-apache-parent/pull/63#discussion_r788113195
##
File path: pom.xml
##
@@ -92,10 +92,21 @@ under the License.
${maven.compiler.target}
1.7
2.22.2
+3.6.4
posix
2021-07-14T15:10:38Z
+
+
+
+org.apache.maven.plugin-tools
+maven-plugin-annotations
+${maven.plugin.tools.version}
+
Review comment:
If this was in the regular ``, I would agree with those
users above who suggested adding the `provided` scope. However, this is in the
`` section. Adding the scope there would override the
default `compile` scope that most people omit when they actually *use* a
dependency in the regular `` section in their own POM. Changing
that behavior so it's `provided` instead of `compile` can be very confusing to
users, and to avoid that confusion, they will redundantly specify the scope
themselves anyway. So, placing it here can create confusion, and doesn't really
offer much benefit.
So, I don't think the parent POM should manage the scope for the users in a
`` section. Instead, the scope should be omitted here, as
it currently is, so it defaults to `compile` like users expect when they omit
the scope. If they want to mark it `provided`, or any other scope, they should
specify the scope themselves when they declare the dependency in their regular
`` section of their own POM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPOM-281) Update maven-plugin-plugin to 3.6.4
[ https://issues.apache.org/jira/browse/MPOM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478953#comment-17478953 ] Slawomir Jaranowski commented on MPOM-281: -- We have defined version of Maven Plugin Tools in ASF parent pom and in Maven parent pom ... > Update maven-plugin-plugin to 3.6.4 > --- > > Key: MPOM-281 > URL: https://issues.apache.org/jira/browse/MPOM-281 > Project: Maven POMs > Issue Type: Task > Components: maven >Reporter: Tamás Cservenák >Priority: Major > Fix For: MAVEN-35 > > > h1. Release Notes - Maven Plugin Tools - Version 3.6.4 > h2. Bug > * [MPLUGIN-382] - Too many dependencies in plugin descriptor > * [MPLUGIN-383] - Missing prerequisites in plugin pom > * [MPLUGIN-384] - Nexus Staging Plugin - incompatibility > h2. Task > * [MPLUGIN-386] - Filter out maven-archiver and maven-jxr from scope > warning > h2. Dependency upgrade > * [MPLUGIN-387] - Upgrade dependencies -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MENFORCER-411) DependencyConvergence should support including/excluding certain dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478947#comment-17478947
]
Matt Nelson commented on MENFORCER-411:
---
{quote}Can you give an example of how there would be a later build failure from
one of the causes you mentioned?{quote}
Maven has deterministic class path ordering[1]. Introducing an option to ignore
convergence errors on specific dependencies could introduce build failures if
the pom is reordered or sorted. In this scenario the error would be later in
the build (compile or test) and it would not be as immediately clear that it is
a convergence error.
[1]
https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Transitive_Dependencies
> DependencyConvergence should support including/excluding certain dependencies
> -
>
> Key: MENFORCER-411
> URL: https://issues.apache.org/jira/browse/MENFORCER-411
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
> Components: Standard Rules
>Affects Versions: 3.0.1
>Reporter: Forrest Feaser
>Priority: Major
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> It would be nice if the DependencyConvergence rule could specify certain
> dependencies that should/should not fail the build. This might be useful if
> your project has a lot of dependency conflicts, but you know there are just a
> few troublesome ones that cause issues, and you don't want to resolve the
> conflicts for your entire project.
> Here is my PR: https://github.com/apache/maven-enforcer/pull/136
> Do I need to sign the Contributor License Agreement for this?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-apache-parent] slawekjaranowski commented on a change in pull request #63: [MPOM-288] - Update m-plugin-p to 3.6.4
slawekjaranowski commented on a change in pull request #63:
URL: https://github.com/apache/maven-apache-parent/pull/63#discussion_r788107366
##
File path: pom.xml
##
@@ -92,10 +92,21 @@ under the License.
${maven.compiler.target}
1.7
2.22.2
+3.6.4
posix
2021-07-14T15:10:38Z
+
+
+
+org.apache.maven.plugin-tools
+maven-plugin-annotations
+${maven.plugin.tools.version}
+
Review comment:
should be `provided`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MPOM-288) Update to m-plugin-p 3.6.4 and manage dependency "maven-plugin-annotations"
[ https://issues.apache.org/jira/browse/MPOM-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-288: - Summary: Update to m-plugin-p 3.6.4 and manage dependency "maven-plugin-annotations" (was: Update to m-plugin-p 1.6.4 and manage dependency "maven-plugin-annotations") > Update to m-plugin-p 3.6.4 and manage dependency "maven-plugin-annotations" > --- > > Key: MPOM-288 > URL: https://issues.apache.org/jira/browse/MPOM-288 > Project: Maven POMs > Issue Type: Improvement > Components: asf >Reporter: Konrad Windszus >Priority: Minor > > As the version of m-plugin-p and the used annotations should be the same it > would be useful to manage the dependency for "maven-plugin-annotations" in > the ASF parent as well and use a dedicated property for the version of all > maven-plugin tools. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] papegaaij commented on a change in pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
papegaaij commented on a change in pull request #389:
URL: https://github.com/apache/maven-surefire/pull/389#discussion_r788098364
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##
@@ -231,6 +225,21 @@ private void execute( TestsToRun testsToRun,
RunListenerAdapter adapter )
} );
}
}
+
+private void closeLauncher()
+{
+if ( launcher instanceof AutoCloseable )
+{
+try
+{
+( (AutoCloseable) launcher ).close();
+}
+catch ( Exception e )
+{
+throw new SurefireReflectionException( e );
Review comment:
`SurefireReflectionException` only has one constructor, the one taking a
`Throwable cause`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MENFORCER-411) DependencyConvergence should support including/excluding certain dependencies
[ https://issues.apache.org/jira/browse/MENFORCER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478877#comment-17478877 ] Forrest Feaser commented on MENFORCER-411: -- [~MattNelson] I'm not sure I fully understand what you're getting at. The main idea of this ticket is that a developer can select which dependencies they'd like to check for convergence, and any issues resulting from those not checked would be their responsibility. Can you give an example of how there would be a later build failure from one of the causes you mentioned? > DependencyConvergence should support including/excluding certain dependencies > - > > Key: MENFORCER-411 > URL: https://issues.apache.org/jira/browse/MENFORCER-411 > Project: Maven Enforcer Plugin > Issue Type: Improvement > Components: Standard Rules >Affects Versions: 3.0.1 >Reporter: Forrest Feaser >Priority: Major > Original Estimate: 4h > Remaining Estimate: 4h > > It would be nice if the DependencyConvergence rule could specify certain > dependencies that should/should not fail the build. This might be useful if > your project has a lot of dependency conflicts, but you know there are just a > few troublesome ones that cause issues, and you don't want to resolve the > conflicts for your entire project. > Here is my PR: https://github.com/apache/maven-enforcer/pull/136 > Do I need to sign the Contributor License Agreement for this? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-apache-parent] ctubbsii commented on a change in pull request #64: [MPOM-287] - Disable m2e warning for m-remote-resource-p:process
ctubbsii commented on a change in pull request #64: URL: https://github.com/apache/maven-apache-parent/pull/64#discussion_r787992599 ## File path: pom.xml ## @@ -299,6 +299,32 @@ under the License. apache-rat-plugin 0.13 + + + org.eclipse.m2e + lifecycle-mapping + 1.0.0 + + + + + + +org.apache.maven.plugins +maven-remote-resources-plugin +[1.7.0,1.8.0) + + process + + + + + + + + + + Review comment: I figure this section can just be deleted when the plugin version is bumped to one where support was added. But, if the metadata is added to do anything other than ignore inside the plugin itself, and the user specifies a newer version than what's in the parent POM here, then I guess you are right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] kwin commented on a change in pull request #64: [MPOM-287] - Disable m2e warning for m-remote-resource-p:process
kwin commented on a change in pull request #64: URL: https://github.com/apache/maven-apache-parent/pull/64#discussion_r787990780 ## File path: pom.xml ## @@ -299,6 +299,32 @@ under the License. apache-rat-plugin 0.13 + + + org.eclipse.m2e + lifecycle-mapping + 1.0.0 + + + + + + +org.apache.maven.plugins +maven-remote-resources-plugin +[1.7.0,1.8.0) + + process + + + + + + + + + + Review comment: > putting this in a profile activated by the presence of the m2e.version property. Thanks for the hint, done in https://github.com/apache/maven-apache-parent/pull/64/commits/607c15461c90b41552e05ad7e310002209d7c6eb. > This is useful to suppress no matter what version of the plugin is used. So, you can just specify a versionRange of [0,) I disagree, I enabled it for `[0,1.8)` because hopefully the not yet released plugin 1.8 will add support. In case there is this section in the pom.xml unconditionally you prevent that potential support from becoming active. In general it is dangerous to disable it for all versions, as you never know which support is added in future versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a change in pull request #64: [MPOM-287] - Disable m2e warning for m-remote-resource-p:process
ctubbsii commented on a change in pull request #64: URL: https://github.com/apache/maven-apache-parent/pull/64#discussion_r787990726 ## File path: pom.xml ## @@ -481,5 +481,45 @@ under the License. + + only-eclipse + + + m2e.version + + + + + + + + org.eclipse.m2e + lifecycle-mapping + 1.0.0 + + + + + + +org.apache.maven.plugins +maven-remote-resources-plugin +[0,1.8.0) Review comment: Can ignore all versions. That way this doesn't need to be updated when the version of the plugin is bumped. ```suggestion [0,) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-1982) Fix failures (java.nio.ChartBuffer) when compiled on Java 9+ and run on Java 8
[ https://issues.apache.org/jira/browse/SUREFIRE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1982. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=747c757c0f6885554ff054ee0b1effbbe3325f46 > Fix failures (java.nio.ChartBuffer) when compiled on Java 9+ and run on Java 8 > -- > > Key: SUREFIRE-1982 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1982 > Project: Maven Surefire > Issue Type: Bug >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SUREFIRE-1982) Fix failures (java.nio.ChartBuffer) when compiled on Java 9+ and run on Java 8
Tibor Digana created SUREFIRE-1982: -- Summary: Fix failures (java.nio.ChartBuffer) when compiled on Java 9+ and run on Java 8 Key: SUREFIRE-1982 URL: https://issues.apache.org/jira/browse/SUREFIRE-1982 Project: Maven Surefire Issue Type: Bug Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 3.0.0-M6 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-apache-parent] ctubbsii commented on a change in pull request #64: [MPOM-287] - Disable m2e warning for m-remote-resource-p:process
ctubbsii commented on a change in pull request #64: URL: https://github.com/apache/maven-apache-parent/pull/64#discussion_r787960531 ## File path: pom.xml ## @@ -299,6 +299,32 @@ under the License. apache-rat-plugin 0.13 + + + org.eclipse.m2e + lifecycle-mapping + 1.0.0 + + + + + + +org.apache.maven.plugins +maven-remote-resources-plugin +[1.7.0,1.8.0) + + process + + + + + + + + + + Review comment: I strongly recommend putting this in a profile activated by the presence of the `m2e.version` property. Also, there's no reason to restrict the version. This is useful to suppress no matter what version of the plugin is used. So, you can just specify a versionRange of `[0,)` Example: https://github.com/apache/accumulo/blob/main/pom.xml#L1247-L1351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a change in pull request #64: [MPOM-287] - Disable m2e warning for m-remote-resource-p:process
ctubbsii commented on a change in pull request #64: URL: https://github.com/apache/maven-apache-parent/pull/64#discussion_r787960531 ## File path: pom.xml ## @@ -299,6 +299,32 @@ under the License. apache-rat-plugin 0.13 + + + org.eclipse.m2e + lifecycle-mapping + 1.0.0 + + + + + + +org.apache.maven.plugins +maven-remote-resources-plugin +[1.7.0,1.8.0) + + process + + + + + + + + + + Review comment: I strongly recommend putting this in a profile activated by the presence of the `m2e.version` property. Also, there's no reason to restrict the version. This is useful to suppress no matter what version of the plugin is used. So, you can just specify a versionRange of `[0,)` Example: https://github.com/apache/accumulo/blob/main/pom.xml#L1247-L1351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a change in pull request #64: [MPOM-287] - Disable m2e warning for m-remote-resource-p:process
ctubbsii commented on a change in pull request #64: URL: https://github.com/apache/maven-apache-parent/pull/64#discussion_r787960531 ## File path: pom.xml ## @@ -299,6 +299,32 @@ under the License. apache-rat-plugin 0.13 + + + org.eclipse.m2e + lifecycle-mapping + 1.0.0 + + + + + + +org.apache.maven.plugins +maven-remote-resources-plugin +[1.7.0,1.8.0) + + process + + + + + + + + + + Review comment: I strongly recommend putting this in a profile activated by the presence of the `m2e.version` property. Also, there's no reason to restrict the version. This is useful to suppress no matter what version of the plugin is used. So, you can just specify a versionRange of `[0,)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
Tibor17 commented on pull request #389: URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-1016650449 LGTM Some test has timed out in the `surefire-api` module but I am convinced it has nothing to do with this change. Let's wait for the CI to complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
Tibor17 commented on a change in pull request #389:
URL: https://github.com/apache/maven-surefire/pull/389#discussion_r787793027
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##
@@ -231,6 +225,21 @@ private void execute( TestsToRun testsToRun,
RunListenerAdapter adapter )
} );
}
}
+
+private void closeLauncher()
+{
+if ( launcher instanceof AutoCloseable )
+{
+try
+{
+( (AutoCloseable) launcher ).close();
+}
+catch ( Exception e )
+{
+throw new SurefireReflectionException( e );
Review comment:
pls use `throw new SurefireReflectionException( e.grtLocalMessage(), e
);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-mvnd] findepi commented on pull request #585: Fix user's pronoun in mvnd.properties comment
findepi commented on pull request #585: URL: https://github.com/apache/maven-mvnd/pull/585#issuecomment-1016588995 thanks @gnodet for the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] cstamas commented on a change in pull request #287: Maven Repositories documentation
cstamas commented on a change in pull request #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r787865760 ## File path: content/markdown/repositories/layout.md ## @@ -0,0 +1,41 @@ +# Maven Repository Layout + + + +The layout is responsible to translate the artifact coordinates into generic path, that is later used to construct some +URI (file path, URL, it depends on context). Obviously, since Maven inception in 2002. the layout evolved as well. +Due simplicity, we will cover current layout (aka "maven2" or "default"), as since Maven 3.x release, the deprecated +"Maven1 layout" is not supported anymore. + +The original premise of layout was simplicity: from historical perspective, a remote repository was expected to be run +by some compute with file storage (where artifacts were laid down) and served by a HTTP server, essentially publishing +the files on file paths for consumption (mainly for HTTP GET requests). Actually, the reason of layout change between +Maven1 and Maven2 (the today's "default") was exactly that: Maven1 layout was stressing the underlying file system +way too much, it was not scaling in this setup. Review comment: Our doco (and sources, plugins, etc) are still full of references to "legacy", so IMO is okay in short to cover this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] cstamas commented on a change in pull request #287: Maven Repositories documentation
cstamas commented on a change in pull request #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r787865163 ## File path: content/markdown/repositories/layout.md ## @@ -0,0 +1,41 @@ +# Maven Repository Layout + + + +The layout is responsible to translate the artifact coordinates into generic path, that is later used to construct some +URI (file path, URL, it depends on context). Obviously, since Maven inception in 2002. the layout evolved as well. +Due simplicity, we will cover current layout (aka "maven2" or "default"), as since Maven 3.x release, the deprecated +"Maven1 layout" is not supported anymore. + +The original premise of layout was simplicity: from historical perspective, a remote repository was expected to be run +by some compute with file storage (where artifacts were laid down) and served by a HTTP server, essentially publishing Review comment: "from historical perspective, a remote repository was expected to be"... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] cstamas commented on a change in pull request #287: Maven Repositories documentation
cstamas commented on a change in pull request #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r787864251 ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,32 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store build artifacts. Your dependencies are being downloaded from repositories, +and your built artifacts are being stored (installed, uploaded) into repositories as well. This is one of the +fundamental concept of Maven since its inception: Maven command line tool and Maven Repositories were mold together +and developed since inception of Maven project itself. + +Maven addresses artifacts using coordinates, that are most often represented as `groupId`:`artifactId`:`version`, +or GAV in short (or informally). The artifact coordinates uniquely describes the artifact you are referring to, but +does not tell anything about its source (or origin). It is up to Maven to figure out (or you to tell Maven how Review comment: source as "origin", not source as "source code" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] cstamas commented on a change in pull request #287: Maven Repositories documentation
cstamas commented on a change in pull request #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r787861988 ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,32 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store build artifacts. Your dependencies are being downloaded from repositories, Review comment: IMHO, a parent POM is a build artifact, but whatever :stuck_out_tongue: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-1975) JDK18 - The Security Manager is deprecated and will be removed in a future release
[
https://issues.apache.org/jira/browse/SUREFIRE-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1975:
---
Issue Type: Bug (was: Test)
> JDK18 - The Security Manager is deprecated and will be removed in a future
> release
> --
>
> Key: SUREFIRE-1975
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1975
> Project: Maven Surefire
> Issue Type: Bug
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> We won't run the integration test \{{Surefire34SecurityManagerIT}} since of
> JDK 17.
> We won't support SecurityManager in JUnit3 Surefire Provider since of JDK 17.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SUREFIRE-1938) Upgrade Apache commons-compress to Version 1.21
[ https://issues.apache.org/jira/browse/SUREFIRE-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1938. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=f535a329214427ecae43c146b6afbd5b52df3435 > Upgrade Apache commons-compress to Version 1.21 > --- > > Key: SUREFIRE-1938 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1938 > Project: Maven Surefire > Issue Type: Dependency upgrade > Components: Maven Failsafe Plugin, Maven Surefire Plugin, > surefire-shared-utils >Reporter: Johannes >Assignee: Tibor Digana >Priority: Critical > Fix For: 3.0.0-M6 > > > Apache commons compress before 1.21 exposes these CVE-2021-35515, > CVE-2021-35516, CVE-2021-35517 > and CVE-2021-36090 critical vulnerabilities. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (SUREFIRE-1938) Upgrade Apache commons-compress to Version 1.21
[ https://issues.apache.org/jira/browse/SUREFIRE-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1938: -- Assignee: Tibor Digana > Upgrade Apache commons-compress to Version 1.21 > --- > > Key: SUREFIRE-1938 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1938 > Project: Maven Surefire > Issue Type: Dependency upgrade > Components: Maven Failsafe Plugin, Maven Surefire Plugin, > surefire-shared-utils >Reporter: Johannes >Assignee: Tibor Digana >Priority: Critical > Fix For: 3.0.0-M6 > > > Apache commons compress before 1.21 exposes these CVE-2021-35515, > CVE-2021-35516, CVE-2021-35517 > and CVE-2021-36090 critical vulnerabilities. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SUREFIRE-1937) Upgrade Apache commons-io to Version 2.11.0
[ https://issues.apache.org/jira/browse/SUREFIRE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1937. -- Assignee: Tibor Digana Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=a682178645b2d8bd120abd7b2873335f59180f96 > Upgrade Apache commons-io to Version 2.11.0 > --- > > Key: SUREFIRE-1937 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1937 > Project: Maven Surefire > Issue Type: Dependency upgrade > Components: Maven Failsafe Plugin, Maven Surefire Plugin, > surefire-shared-utils >Affects Versions: 3.0.0-M5 >Reporter: Johannes >Assignee: Tibor Digana >Priority: Critical > Fix For: 3.0.0-M6 > > > CommonsIO before and including 2.7 exposes a critical vulnerability > [https://nvd.nist.gov/vuln/detail/CVE-2021-29425] which is fixed in later > versions. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SUREFIRE-1980) Upgrade Apache commons-lang3 to 3.12.0
[ https://issues.apache.org/jira/browse/SUREFIRE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1980. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=cf115537ba0f763e2f7d6a61c785b40549a25fa4 > Upgrade Apache commons-lang3 to 3.12.0 > -- > > Key: SUREFIRE-1980 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1980 > Project: Maven Surefire > Issue Type: Dependency upgrade > Components: Maven Failsafe Plugin, Maven Surefire Plugin, > surefire-shared-utils >Reporter: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (SUREFIRE-1980) Upgrade Apache commons-lang3 to 3.12.0
[ https://issues.apache.org/jira/browse/SUREFIRE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1980: -- Assignee: Tibor Digana > Upgrade Apache commons-lang3 to 3.12.0 > -- > > Key: SUREFIRE-1980 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1980 > Project: Maven Surefire > Issue Type: Dependency upgrade > Components: Maven Failsafe Plugin, Maven Surefire Plugin, > surefire-shared-utils >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SUREFIRE-1981) Upgrade Apache maven-shared-utils to 3.3.4
[ https://issues.apache.org/jira/browse/SUREFIRE-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1981. -- Assignee: Tibor Digana Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=2da8f9b34da908b146e671d4b996a41bf81a9014 > Upgrade Apache maven-shared-utils to 3.3.4 > -- > > Key: SUREFIRE-1981 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1981 > Project: Maven Surefire > Issue Type: Dependency upgrade > Components: Maven Failsafe Plugin, Maven Surefire Plugin, > surefire-shared-utils >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-mvnd] gnodet merged pull request #585: Fix user's pronoun in mvnd.properties comment
gnodet merged pull request #585: URL: https://github.com/apache/maven-mvnd/pull/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 merged pull request #444: [SUREFIRE-1937] [SUREFIRE-1938] [SUREFIRE-1980] [SUREFIRE-1981]
Tibor17 merged pull request #444: URL: https://github.com/apache/maven-surefire/pull/444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] papegaaij commented on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
papegaaij commented on pull request #389: URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-1016545576 @Tibor17 I've rebased the PR and squashed the commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #287: Maven Repositories documentation
michael-o commented on a change in pull request #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r787819250 ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,32 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store build artifacts. Your dependencies are being downloaded from repositories, +and your built artifacts are being stored (installed, uploaded) into repositories as well. This is one of the +fundamental concept of Maven since its inception: Maven command line tool and Maven Repositories were mold together Review comment: concepts ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,32 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store build artifacts. Your dependencies are being downloaded from repositories, +and your built artifacts are being stored (installed, uploaded) into repositories as well. This is one of the +fundamental concept of Maven since its inception: Maven command line tool and Maven Repositories were mold together +and developed since inception of Maven project itself. Review comment: the inception ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,32 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store build artifacts. Your dependencies are being downloaded from repositories, Review comment: remove build since POMs aren't build artifact, but are artifacts as well. ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,32 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store build artifacts. Your dependencies are being downloaded from repositories, +and your built artifacts are being stored (installed, uploaded) into repositories as well. This is one of the +fundamental concept of Maven since its inception: Maven command line tool and Maven Repositories were mold together +and developed since inception of Maven project itself. Review comment: the inception this is a repition of the former inception. Reads strange. ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,32 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store build artifacts. Your dependencies are being downloaded from repositories, +and your built artifacts are being stored (installed, uploaded) into repositories as well. This is one of the +fundamental concept of Maven since its inception: Maven command line tool and Maven Repositories were mold together +and developed since inception of Maven project itself. + +Maven addresses artifacts using coordinates, that are most often represented as `groupId`:`artifactId`:`version`, +or GAV in short (or informally). The artifact coordinates uniquely describes the artifact you are referring to, but Review comment: describe ## File path: content/markdown/repositories/layout.md ## @@ -0,0 +1,41 @@ +# Maven Repository Layout + + + +The layout is responsible to translate the artifact coordinates into generic path, that is later used to construct some Review comment: paths ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,32 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store build artifacts. Your dependencies are being downloaded from repositories, +and your built artifacts are being stored (installed, uploaded) into repositories as well. This is one of the Review comment: same with typo ## File path: content/markdown/repositories/layout.md ## @@ -0,0 +1,41 @@ +# Maven Repository Layout + + + +The layout is responsible to translate the artifact coordinates into generic path, that is later used to construct some +URI (file path, URL, it depends on context). Obviously, since Maven inception in 2002. the layout evolved as well. Review comment: Maven's inception ## File path: content/markdown/repositories/index.md ## @@ -0,0 +1,32 @@ +# Maven Repositories + + + +Apache Maven uses repositories to store build artifacts. Your dependencies are being downloaded from repositories, +and your built artifacts are being stored (installed, uploaded) into repositories as well. This is one of the +fundamental concept of Maven since its inception: Maven command line tool and Maven Repositories were mold together +and developed since inception of Maven project itself. + +Maven addresses artifacts using coordinates, that are most often represented as `groupId`:`artifactId`:`version`, +or GAV in short (or informally). The artifact coordinates uniquely describes the artifact you are referring to, but +does not tell anything about its source (or origin). It is up to Maven to figure out (or you to tell Maven how Review comment: source => location. Source is rather an SCM, no? ## File path:
[GitHub] [maven-mvnd] findepi commented on a change in pull request #585: Fix user's pronoun in mvnd.properties comment
findepi commented on a change in pull request #585:
URL: https://github.com/apache/maven-mvnd/pull/585#discussion_r787829810
##
File path: dist/src/main/distro/conf/mvnd.properties
##
@@ -86,7 +86,7 @@
# MVND_MIN_THREADS
# The minimum number of threads to use when constructing the default {@code
-T} parameter for the daemon.
# This value is ignored if the user passes @{@code -T}, @{@code --threads} or
{@code -Dmvnd.threads} on the command
-# line or if he sets {@code mvnd.threads} in {@code ~/.m2/mvnd.properties}.
+# line or if they set {@code mvnd.threads} in {@code ~/.m2/mvnd.properties}.
Review comment:
I enabled `Allow edits by maintainers` if this is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
Tibor17 edited a comment on pull request #389: URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-1016536386 @papegaaij Pls squash both commits. I have made the review but I prefer one commit in the final review. Thx. Looks fine so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
Tibor17 commented on pull request #389: URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-1016536386 @papegaaij Pls squash both commit. I have made the review but I prefer one commit in the final review. Thx. Looks fine so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] cstamas opened a new pull request #287: Maven Repositories documentation
cstamas opened a new pull request #287: URL: https://github.com/apache/maven-site/pull/287 An attempt to create comprehensive documentation about Maven Repositories, something that is missing very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] Stephan202 commented on a change in pull request #585: Fix user's pronoun in mvnd.properties comment
Stephan202 commented on a change in pull request #585:
URL: https://github.com/apache/maven-mvnd/pull/585#discussion_r787767758
##
File path: dist/src/main/distro/conf/mvnd.properties
##
@@ -86,7 +86,7 @@
# MVND_MIN_THREADS
# The minimum number of threads to use when constructing the default {@code
-T} parameter for the daemon.
# This value is ignored if the user passes @{@code -T}, @{@code --threads} or
{@code -Dmvnd.threads} on the command
-# line or if he sets {@code mvnd.threads} in {@code ~/.m2/mvnd.properties}.
+# line or if they set {@code mvnd.threads} in {@code ~/.m2/mvnd.properties}.
Review comment:
@gnodet I don't have access to this branch; @findepi did apply the
change (modulo the word "explicitly", which LGTM).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #58: Bump slf4j-simple from 1.7.32 to 1.7.33
dependabot[bot] opened a new pull request #58: URL: https://github.com/apache/maven-artifact-transfer/pull/58 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.32 to 1.7.33. Commits https://github.com/qos-ch/slf4j/commit/2758a974264ab65df3af1d473eb9423ca978c14a;>2758a97 prepare release 1.7.33 https://github.com/qos-ch/slf4j/commit/a0681b72eb0d7c40733f02633e4f2677997b6fce;>a0681b7 fix SLF4J-499 https://github.com/qos-ch/slf4j/commit/c89dc3db0f84e0e529fd518f9b3085ad8f2499da;>c89dc3d Merge branch '1.7-maintenance' of github.com:qos-ch/slf4j into 1.7-maintenance https://github.com/qos-ch/slf4j/commit/0d2bd398f738f751a0814d9a0032310812773978;>0d2bd39 add slf4j-reload4j module https://github.com/qos-ch/slf4j/commit/ae9ee009f6ffbeae5a9ace85017b027aa5090ab3;>ae9ee00 start work on 1.7.33-SNAPSHOT See full diff in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] slachiewicz merged pull request #65: Revert "Bump maven-compiler-plugin from 3.8.1 to 3.9.0"
slachiewicz merged pull request #65: URL: https://github.com/apache/maven-apache-parent/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] slachiewicz opened a new pull request #65: Revert "Bump maven-compiler-plugin from 3.8.1 to 3.9.0"
slachiewicz opened a new pull request #65: URL: https://github.com/apache/maven-apache-parent/pull/65 Reverts apache/maven-apache-parent#62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] papegaaij commented on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
papegaaij commented on pull request #389: URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-1016426984 The `LauncherSession` is explicitly meant to provide a state over all tests. It is completely separate from `Extension`. This patch will only effect projects that already use these `LauncherSessions`. For that, they have to implement `LauncherSessionListener` and put the classname in a service file for the `ServiceLoader` to pick it up. If a project makes use of `LauncherSessionListener`, they will, without this patch, see a new session being started for every test, which actually is incorrect behavior. The javadoc on `LauncherSession` explains this: `The LauncherSession API is the main entry point for client code that wishes to repeatedly discover and execute tests using one or more test engines.` This is exactly what Surefire does, hence it should use `LauncherSession` to do this. What a user does with a `LauncherSessionListener` implementation is up to the user. The javadoc does not give any guidelines. The Gradle documentation actually points to this interface for once-per-vm setup and teardown: https://docs.gradle.com/enterprise/test-distribution-gradle-plugin/#junit_5_8_and_later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia] dependabot[bot] opened a new pull request #87: Bump slf4jVersion from 1.7.32 to 1.7.33
dependabot[bot] opened a new pull request #87: URL: https://github.com/apache/maven-doxia/pull/87 Bumps `slf4jVersion` from 1.7.32 to 1.7.33. Updates `slf4j-api` from 1.7.32 to 1.7.33 Commits https://github.com/qos-ch/slf4j/commit/2758a974264ab65df3af1d473eb9423ca978c14a;>2758a97 prepare release 1.7.33 https://github.com/qos-ch/slf4j/commit/a0681b72eb0d7c40733f02633e4f2677997b6fce;>a0681b7 fix SLF4J-499 https://github.com/qos-ch/slf4j/commit/c89dc3db0f84e0e529fd518f9b3085ad8f2499da;>c89dc3d Merge branch '1.7-maintenance' of github.com:qos-ch/slf4j into 1.7-maintenance https://github.com/qos-ch/slf4j/commit/0d2bd398f738f751a0814d9a0032310812773978;>0d2bd39 add slf4j-reload4j module https://github.com/qos-ch/slf4j/commit/ae9ee009f6ffbeae5a9ace85017b027aa5090ab3;>ae9ee00 start work on 1.7.33-SNAPSHOT See full diff in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33;>compare view Updates `slf4j-simple` from 1.7.32 to 1.7.33 Commits https://github.com/qos-ch/slf4j/commit/2758a974264ab65df3af1d473eb9423ca978c14a;>2758a97 prepare release 1.7.33 https://github.com/qos-ch/slf4j/commit/a0681b72eb0d7c40733f02633e4f2677997b6fce;>a0681b7 fix SLF4J-499 https://github.com/qos-ch/slf4j/commit/c89dc3db0f84e0e529fd518f9b3085ad8f2499da;>c89dc3d Merge branch '1.7-maintenance' of github.com:qos-ch/slf4j into 1.7-maintenance https://github.com/qos-ch/slf4j/commit/0d2bd398f738f751a0814d9a0032310812773978;>0d2bd39 add slf4j-reload4j module https://github.com/qos-ch/slf4j/commit/ae9ee009f6ffbeae5a9ace85017b027aa5090ab3;>ae9ee00 start work on 1.7.33-SNAPSHOT See full diff in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on a change in pull request #585: Fix user's pronoun in mvnd.properties comment
gnodet commented on a change in pull request #585:
URL: https://github.com/apache/maven-mvnd/pull/585#discussion_r787686257
##
File path: dist/src/main/distro/conf/mvnd.properties
##
@@ -86,7 +86,7 @@
# MVND_MIN_THREADS
# The minimum number of threads to use when constructing the default {@code
-T} parameter for the daemon.
# This value is ignored if the user passes @{@code -T}, @{@code --threads} or
{@code -Dmvnd.threads} on the command
-# line or if he sets {@code mvnd.threads} in {@code ~/.m2/mvnd.properties}.
+# line or if they set {@code mvnd.threads} in {@code ~/.m2/mvnd.properties}.
Review comment:
@Stephan202 can you change the PR with your last proposal please ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MCOMPILER-481) JPMS Regression: cannot access (requires static module not include anymore)
[
https://issues.apache.org/jira/browse/MCOMPILER-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478630#comment-17478630
]
Robert Scholte commented on MCOMPILER-481:
--
Found it, it was MJAVADOC-677 that required this change.
> JPMS Regression: cannot access (requires static module not include
> anymore)
> ---
>
> Key: MCOMPILER-481
> URL: https://issues.apache.org/jira/browse/MCOMPILER-481
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Simone Bordet
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: compiler-bug.tar.gz
>
>
> Version 3.8.1 is not affected.
> The problem lies in how the module-path is constructed by the
> maven-compiler-plugin – not sure what changes from 3.8.1 caused this.
> In 3.8.1:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> In 3.9.0:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> Running with 3.9.0 yields:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project compiler-bug-app: Compilation failure
> [ERROR]
> /home/simon/tmp/compiler-bug/app/src/test/java/org/test/app/MainTest.java:[12,38]
> cannot access org.eclipse.jetty.util.ajax.JSON
> [ERROR] class file for org.eclipse.jetty.util.ajax.JSON not found {code}
> Class {{JSON}} is in {{{}jetty-util-10.0.7.jar{}}}.
> In 3.9.0 this jar is missing from the module-path, causing the error.
> Attached you can find a reproducer: switch the maven-compiler-plugin version
> from 3.8.1 (works) to 3.9.0 (does not
[jira] [Commented] (MCOMPILER-481) JPMS Regression: cannot access (requires static module not include anymore)
[
https://issues.apache.org/jira/browse/MCOMPILER-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478628#comment-17478628
]
Robert Scholte commented on MCOMPILER-481:
--
`ResolvePathsRequest.setIncludeStatic(true)` did fix it for me, still wondering
if this is the right approach.
> JPMS Regression: cannot access (requires static module not include
> anymore)
> ---
>
> Key: MCOMPILER-481
> URL: https://issues.apache.org/jira/browse/MCOMPILER-481
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Simone Bordet
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: compiler-bug.tar.gz
>
>
> Version 3.8.1 is not affected.
> The problem lies in how the module-path is constructed by the
> maven-compiler-plugin – not sure what changes from 3.8.1 caused this.
> In 3.8.1:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> In 3.9.0:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> Running with 3.9.0 yields:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project compiler-bug-app: Compilation failure
> [ERROR]
> /home/simon/tmp/compiler-bug/app/src/test/java/org/test/app/MainTest.java:[12,38]
> cannot access org.eclipse.jetty.util.ajax.JSON
> [ERROR] class file for org.eclipse.jetty.util.ajax.JSON not found {code}
> Class {{JSON}} is in {{{}jetty-util-10.0.7.jar{}}}.
> In 3.9.0 this jar is missing from the module-path, causing the error.
> Attached you can find a reproducer: switch the
[GitHub] [maven-resolver] cstamas edited a comment on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas edited a comment on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016326439 @michael-o actually no, changed my mind re `ByteBuffer`: it is so proliferated even in public API (see transfer listener etc), that I think it is okay (even w/ some overhead) to keep same thing internally as well. That said, I did simplify things where ByteBuffer was kinda "overused" or whatever. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-13) rename remote.cache.* properties to build.cache.*
[ https://issues.apache.org/jira/browse/MBUILDCACHE-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478608#comment-17478608 ] Maximilian Novikov commented on MBUILDCACHE-13: --- >is it really restricted to remote build cache no, it's just historical naming "maven.build.cache" should work > rename remote.cache.* properties to build.cache.* > - > > Key: MBUILDCACHE-13 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-13 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Herve Boutemy >Priority: Major > > current parameters are named "remote.cache.*": > https://maven.apache.org/extensions/maven-build-cache-extension/parameters.html > is it really restricted to remote build cache? Or just historical naming done > before we chose "build cache" as the keyword (instead of unclear "cache") -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven] michael-o commented on a change in pull request #660: [MNG-7391] add execution strategy+runner required by Maven Build Cache
michael-o commented on a change in pull request #660:
URL: https://github.com/apache/maven/pull/660#discussion_r787663794
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycles.java
##
@@ -43,7 +43,7 @@
@Component( role = DefaultLifecycles.class )
public class DefaultLifecycles
{
-public static final String[] STANDARD_LIFECYCLES = { "default", "clean",
"site" };
+public static final String[] STANDARD_LIFECYCLES = { "clean", "default",
"site" };
Review comment:
Is this a fix? How it is related to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
Tibor17 commented on pull request #389: URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-1016377341 I understand that you are aiming for loading heavy resources only once. On the other hand the unit tests have a rule where each test/method has isolated context. How can we ensure such rule in this patch? The interface `Extension` is marker interface and has many implementations. We only need to guarantee that the session you have implemented would not make e.g. `BeforeEachCallback` stateful across all tests (before-each represents stateless resource). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] papegaaij commented on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
papegaaij commented on pull request #389: URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-1016353322 We have been running a patched build for several months now with this change and it works very well. The downside to this solution in relation to the jira issue is that it only helps when the framework actually makes use of the launcher sessions. This is still very rare as it is a new feature. It is however the recommended way (by JUnit) of doing this and they seem reluctant to make other changes in this regard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
Tibor17 commented on pull request #389: URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-1016344148 @papegaaij We are in hurry with many PRs. Pls let us review again against Jira... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016326439 @michael-o actually no, changed my mind re `ByteBuffer`: it is so proliferated even in public API (see transfer listener etc), that I think it is okay (even w/ some overhead) to keep same thing internally as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] kwin commented on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
kwin commented on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016313402 My bad, I thought that https://docs.oracle.com/javase/8/docs/api/java/util/LinkedHashSet.html was implementing a `SortedSet` (set with an order), but it does not. Also `SortedSet` does always assume that the sorting is based on a comparator or natural ordering which is obviously not true for `LinkedHashSet`. So keeping `List` is fine for me (maybe mentioning that every item is only supposed to appear once). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139:
URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787601498
##
File path:
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/checksum/ChecksumAlgorithmHelper.java
##
@@ -0,0 +1,106 @@
+package org.eclipse.aether.spi.connector.checksum;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.BufferedInputStream;
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.Buffer;
+import java.nio.ByteBuffer;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Helper for checksum operations.
+ *
+ * @since TBD
+ */
+public final class ChecksumAlgorithmHelper
+{
+private ChecksumAlgorithmHelper()
+{
+// nop
+}
+
+/**
+ * Calculates checksums for specified data.
+ *
+ * @param dataThe content for which to calculate checksums, must
not be {@code null}.
+ * @param factories The checksum algorithm factories to use, must not be
{@code null}.
+ * @return The calculated checksums, indexed by algorithm name, or the
exception that occurred while trying to
+ * calculate it, never {@code null}.
+ * @throws IOException In case of any problem.
+ */
+public static Map calculate( byte[] data,
List factories )
+throws IOException
+{
+return calculate( new ByteArrayInputStream( data ), factories );
+}
+
+/**
+ * Calculates checksums for specified file.
+ *
+ * @param fileThe file for which to calculate checksums, must not
be {@code null}.
+ * @param factories The checksum algorithm factories to use, must not be
{@code null}.
+ * @return The calculated checksums, indexed by algorithm name, or the
exception that occurred while trying to
+ * calculate it, never {@code null}.
+ * @throws IOException In case of any problem.
+ */
+public static Map calculate( File file,
List factories )
+throws IOException
+{
+return calculate( new BufferedInputStream( new FileInputStream( file )
), factories );
+}
+
+private static Map calculate( InputStream inputStream,
List factories )
+throws IOException
+{
+LinkedHashMap algorithms = new
LinkedHashMap<>();
+factories.forEach( f -> algorithms.put( f.getName(), f.getAlgorithm()
) );
+try ( InputStream in = inputStream )
+{
+ByteBuffer byteBuffer = ByteBuffer.allocate( 32 * 1024 );
Review comment:
Changing to `byte[]` for simplicity sake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139:
URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787601048
##
File path:
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/checksum/ChecksumAlgorithm.java
##
@@ -0,0 +1,46 @@
+package org.eclipse.aether.spi.connector.checksum;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.nio.ByteBuffer;
+
+/**
+ * Implementation performing checksum calculation for specific algorithm.
Instances of this interface are stateful,
+ * non-thread safe, and should not be reused.
+ *
+ * @since TBD
+ */
+public interface ChecksumAlgorithm
+{
+/**
+ * Updates the checksum algorithm inner state with input.
+ */
+void update( ByteBuffer input );
Review comment:
frankly, am more for `byte[]` due simplicity, but did not want to stir a
lot around this code will make it `byte[]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas edited a comment on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas edited a comment on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016296713 > This is exactly what is needed here IIUC. I don't quite get you: one run I can configure maven like `-Daether.checksums.algorithms=SHA-1,MD5` and other run I can use `-Daether.checksums.algorithms=MD5,SHA-1`... this means that in first run I want resolver to first ask for SHA-1s (like it does by default), then in second run I want resolver to first ask MD5s for some reason (reversed order). So in case of layout, it is more "user ordered list". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016296713 > This is exactly what is needed here IIUC. I don't quite get you: one run I can configure maven like `-Daether.checksums.algorithms=SHA-1,MD5` and other run I can use `-Daether.checksums.algorithms=MD5,SHA-1`... this means that in first run I want resolver to first ask for SHA-1s (like it does by default), then in second run I want resolver to first ask MD5s for some reason (reversed order). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] kwin commented on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
kwin commented on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016291896 SortedSet: > "A Set that further provides a total ordering on its elements." from https://docs.oracle.com/javase/8/docs/api/java/util/SortedSet.html This is exactly what is needed here IIUC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016289307 > Why not using `SortedSet` then instead of `List` for the layout? Well, in case of layout it is not "sorted" per se, but "in order as user defined", no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas edited a comment on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas edited a comment on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016279906 @michael-o other "global" answers: * algorithm names `Set` vs `List`: important distinction, ~~factory~~ selector really does not propose any "order", hence it gives you the set of supported algorithm names w/o any order. OTOH, the **order of checksums in layout** is very important: that's the order how resolver will ask for them (and "first found, the logic stops" -- hence, today if you have SHA-1 ONLY but no MD5, build will still work as resolver with be satisfied with SHA-1 that it asks for the first time). Hence, order when used in layout is important. This is reflected by the fact, that selector gives you (unordered) names it supports, that is usually superset of the names used by layout. OTOH, the layout DOES DEFINE the order, as actually that is the order it asks for, Finally, due this, the user config (comma separated LIST is a list, has order, but we also want to make sure it is unique -- `SHA-1, MD5, MD5` is wrong). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139:
URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787586267
##
File path:
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java
##
@@ -571,25 +587,26 @@ private void uploadChecksums( File file, byte[] bytes )
}
try
{
-Set algos = new HashSet<>();
-for ( RepositoryLayout.Checksum checksum : checksums )
+ArrayList algorithms = new
ArrayList<>();
+for ( RepositoryLayout.ChecksumLocation checksumLocation :
checksums )
{
-algos.add( checksum.getAlgorithm() );
+algorithms.add(
checksumLocation.getChecksumAlgorithmFactory() );
}
-Map sumsByAlgo;
+Map sumsByAlgo;
Review comment:
The `sumsByAlgo` was always populated from (now deprecated)
`ChecksumUtils.calc` method, that in turn returned non-string in map value ONLY
in case of `NoSuchAlgorithmException`. This PR OTOH makes sure that checksums
"fail fast", so you cannot even start (get factory from selector) for algorithm
that does not exists. So to say, old code was more forgiving if you asked for
algorithm not supported by MessageDigester (all this as actual "name
evaluation" was happening way before, and it just accepted any string), while
in this PR you must pass in a factory, that you can obtain ONLY for existing
algorithms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] kwin commented on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
kwin commented on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016285437 Why not using `SortedSet` then instead of `List` for the layout? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787580506 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/Maven2RepositoryLayoutFactory.java ## @@ -83,23 +106,33 @@ public RepositoryLayout newInstance( RepositorySystemSession session, RemoteRepo throw new NoRepositoryLayoutException( repository ); } boolean forSignature = ConfigUtils.getBoolean( session, false, CONFIG_PROP_SIGNATURE_CHECKSUMS ); -List checksumsAlgorithms = Arrays.asList( ConfigUtils.getString( session, -DEFAULT_CHECKSUMS_ALGORITHMS, CONFIG_PROP_CHECKSUMS_ALGORITHMS ).split( "," ) ); +// ensure order of (potentially user set) algorithm list is kept and is unique +LinkedHashSet checksumsAlgorithmNames = new LinkedHashSet<>( Arrays.asList( Review comment: User provides a "comma separated list", hence it is a LIST, and in case of layout, ORDER DOES MATTER (as that is the order resolver will ask for checksum). Here we also ensure that list is _unique_. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787580506 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/Maven2RepositoryLayoutFactory.java ## @@ -83,23 +106,33 @@ public RepositoryLayout newInstance( RepositorySystemSession session, RemoteRepo throw new NoRepositoryLayoutException( repository ); } boolean forSignature = ConfigUtils.getBoolean( session, false, CONFIG_PROP_SIGNATURE_CHECKSUMS ); -List checksumsAlgorithms = Arrays.asList( ConfigUtils.getString( session, -DEFAULT_CHECKSUMS_ALGORITHMS, CONFIG_PROP_CHECKSUMS_ALGORITHMS ).split( "," ) ); +// ensure order of (potentially user set) algorithm list is kept and is unique +LinkedHashSet checksumsAlgorithmNames = new LinkedHashSet<>( Arrays.asList( Review comment: User provides a "comma separated list", hence it is a LIST, and in case of layout, ORDER DOES MATTER (as that is the order resolver will ask for checksum). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139:
URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787579778
##
File path:
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/checksum/ChecksumAlgorithmFactorySelector.java
##
@@ -0,0 +1,44 @@
+package org.eclipse.aether.spi.connector.checksum;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Set;
+
+/**
+ * Component performing selection of {@link ChecksumAlgorithmFactory} based on
known factory names.
+ *
+ * @since TBD
+ */
+public interface ChecksumAlgorithmFactorySelector
+{
+/**
+ * Returns factory for given algorithm name, or throws if algorithm not
supported.
+ *
+ * @throws IllegalArgumentException if asked algorithm name is not
supported.
+ */
+ChecksumAlgorithmFactory select( String algorithmName ) throws
IllegalArgumentException;
+
+/**
+ * Returns a set of supported algorithm names. This set represents ALL the
algorithms supported by Resolver, and is
+ * NOT in any relation to given repository layout used checksums, returned
by method {@link
+ *
org.eclipse.aether.spi.connector.layout.RepositoryLayout#getChecksumAlgorithmNames()}
(is super set of it).
+ */
+Set getChecksumAlgorithmNames();
Review comment:
In this case, this is selector, "all supported algorithms by resolver"
this is unordered (set), no order defined or needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139:
URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787578984
##
File path:
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java
##
@@ -126,55 +122,63 @@ public URI getLocation()
@Override
public String toString()
{
-return location + " (" + algorithm + ")";
+return location + " (" + checksumAlgorithmFactory.getName() + ")";
}
-
}
+/**
+ * Returns the collection of checksum names this instance of layout uses,
never {@code null}.
+ *
+ * @since TBD
+ */
+List getChecksumAlgorithmNames();
Review comment:
This is layout property, order is important (but the returned list is
also unique).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1016279906 @michael-o other "global" answers: * algorithm names `Set` vs `List`: important distinction, factory really does not propose any "order", hence it gives you the set of supported algorithm names w/o any order. OTOH, the **order of checksums in layout** is very important: that's the order how resolver will ask for them (and "first found, the logic stops" -- hence, today if you have SHA-1 ONLY but no MD5, build will still work as resolver with be satisfied with SHA-1 that it asks for the first time). Hence, order when used in layout is important. This is reflected by the fact, that selector gives you (unordered) names it supports, that is usually superset of the names used by layout. OTOH, the layout DOES DEFINE the order, as actually that is the order it asks for, Finally, due this, the user config (comma separated LIST is a list, has order, but we also want to make sure it is unique -- `SHA-1, MD5, MD5` is wrong). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139:
URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787570194
##
File path:
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/checksum/ChecksumAlgorithmHelper.java
##
@@ -0,0 +1,106 @@
+package org.eclipse.aether.spi.connector.checksum;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.BufferedInputStream;
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.Buffer;
+import java.nio.ByteBuffer;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Helper for checksum operations.
+ *
+ * @since TBD
+ */
+public final class ChecksumAlgorithmHelper
+{
+private ChecksumAlgorithmHelper()
+{
+// nop
+}
+
+/**
+ * Calculates checksums for specified data.
+ *
+ * @param dataThe content for which to calculate checksums, must
not be {@code null}.
+ * @param factories The checksum algorithm factories to use, must not be
{@code null}.
+ * @return The calculated checksums, indexed by algorithm name, or the
exception that occurred while trying to
+ * calculate it, never {@code null}.
+ * @throws IOException In case of any problem.
+ */
+public static Map calculate( byte[] data,
List factories )
+throws IOException
+{
+return calculate( new ByteArrayInputStream( data ), factories );
+}
+
+/**
+ * Calculates checksums for specified file.
+ *
+ * @param fileThe file for which to calculate checksums, must not
be {@code null}.
+ * @param factories The checksum algorithm factories to use, must not be
{@code null}.
+ * @return The calculated checksums, indexed by algorithm name, or the
exception that occurred while trying to
+ * calculate it, never {@code null}.
+ * @throws IOException In case of any problem.
+ */
+public static Map calculate( File file,
List factories )
+throws IOException
+{
+return calculate( new BufferedInputStream( new FileInputStream( file )
), factories );
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139:
URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787569872
##
File path:
maven-resolver-connector-basic/src/test/java/org/eclipse/aether/connector/basic/ChecksumCalculatorTest.java
##
@@ -39,22 +42,16 @@
public class ChecksumCalculatorTest
{
-private static final String SHA512 = "SHA-512";
-
-private static final String SHA256 = "SHA-256";
-
-private static final String SHA1 = "SHA-1";
-
-private static final String MD5 = "MD5";
-
private File file;
+private final TestChecksumAlgorithmSelector selector = new
TestChecksumAlgorithmSelector();
+
private ChecksumCalculator newCalculator( String... algos )
{
-List checksums = new ArrayList<>();
+List checksums = new ArrayList<>();
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible
cstamas commented on a change in pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#discussion_r787569310 ## File path: maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/ChecksumValidator.java ## @@ -63,21 +62,23 @@ boolean fetchChecksum( URI remote, File local ) private final ChecksumPolicy checksumPolicy; -private final Collection checksums; +private final Collection checksums; Review comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
