[jira] [Created] (MBUILDCACHE-15) maven.build.cache.enabled parameter is broken
Maximilian Novikov created MBUILDCACHE-15: - Summary: maven.build.cache.enabled parameter is broken Key: MBUILDCACHE-15 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-15 Project: Maven Build Cache Extension Issue Type: Bug Reporter: Maximilian Novikov $ mvn install -DskipTests -P versionlessMavenDist -Dmaven.build.cache.enabled=false [INFO] Cache disabled by command line flag, project will be built fully and not cached [ERROR] Internal error: com.google.inject.ProvisionException: Unable to provision, see the following errors: [ERROR] [ERROR] 1) Error injecting constructor, java.lang.IllegalStateException: Cache is not initialized. Actual state: DISABLED [ERROR] at org.apache.maven.buildcache.RemoteCacheRepositoryProvider.(Unknown Source) [ERROR] at ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.0.0-SNAPSHOT, parent: ClassRealm[plexus.core, parent: null]] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule) [ERROR] while locating org.apache.maven.buildcache.RemoteCacheRepositoryProvider [ERROR] at ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.0.0-SNAPSHOT, parent: ClassRealm[plexus.core, parent: null]] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule) [ERROR] while locating org.apache.maven.buildcache.RemoteCacheRepository annotated with @com.google.inject.name.Named(value="#factory#") [ERROR] at org.eclipse.sisu.wire.LocatorWiring [ERROR] while locating org.apache.maven.buildcache.RemoteCacheRepository [ERROR] for the 1st parameter of org.apache.maven.buildcache.LocalCacheRepositoryImpl.(Unknown Source) [ERROR] at ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.0.0-SNAPSHOT, parent: ClassRealm[plexus.core, parent: null]] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule) [ERROR] while locating org.apache.maven.buildcache.LocalCacheRepositoryImpl [ERROR] while locating java.lang.Object annotated with * [ERROR] at org.eclipse.sisu.wire.LocatorWiring [ERROR] while locating org.apache.maven.buildcache.LocalCacheRepository [ERROR] for the 5th parameter of org.apache.maven.buildcache.CacheControllerImpl.(Unknown Source) [ERROR] at ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.0.0-SNAPSHOT, parent: ClassRealm[plexus.core, parent: null]] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule) [ERROR] while locating org.apache.maven.buildcache.CacheControllerImpl [ERROR] while locating java.lang.Object annotated with * [ERROR] at org.eclipse.sisu.wire.LocatorWiring [ERROR] while locating org.apache.maven.buildcache.CacheController [ERROR] for the 2nd parameter of org.apache.maven.buildcache.CacheLifecycleParticipant.(Unknown Source) [ERROR] at ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.0.0-SNAPSHOT, parent: ClassRealm[plexus.core, parent: null]] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule) [ERROR] while locating org.apache.maven.buildcache.CacheLifecycleParticipant [ERROR] while locating java.lang.Object annotated with * [ERROR] [ERROR] 1 error [ERROR] -> [Help 1] org.apache.maven.InternalErrorException: Internal error: com.google.inject.ProvisionException: Unable to provision, see the following errors: 1) Error injecting constructor, java.lang.IllegalStateException: Cache is not initialized. Actual state: DISABLED at org.apache.maven.buildcache.RemoteCacheRepositoryProvider.(Unknown Source) at ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.0.0-SNAPSHOT, parent: ClassRealm[plexus.core, parent: null]] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule) while locating org.apache.maven.buildcache.RemoteCacheRepositoryProvider at ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.0.0-SNAPSHOT, parent: ClassRealm[plexus.core, parent: null]] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule) while locating org.apache.maven.buildcache.RemoteCacheRepository annotated with @com.google.inject.name.Named(value="#factory#") at org.eclipse.sisu.wire.LocatorWiring while locating org.apache.maven.buildcache.RemoteCacheRepository for the 1st parameter of org.apache.maven.buildcache.LocalCacheRepositoryImpl.(Unknown Source) at ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.0.0-SNAPSHOT, parent: ClassRealm[plexus.core, parent: null]] (via modules: org.eclipse.sisu.wire.WireModule ->
[GitHub] [maven-mvnd] oscerd opened a new pull request #591: Upgrade SLF4J to version 1.7.33
oscerd opened a new pull request #591: URL: https://github.com/apache/maven-mvnd/pull/591 2022-01-13 - Release of SLF4J 1.7.33 • SLF4J now ships with the slf4j-reload4j module delegating to the reload4j backend. Reload4j is a drop-in replacement for log4j version 1.2.17. • SimpleLogger now prints the thread Id if instructed to do so. This fixes SLF4J-499 requested by Michael Osipov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7393) API change: let `canGenerateReport` throw an Exception
[
https://issues.apache.org/jira/browse/MNG-7393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MNG-7393:
--
Description:
Hi everyone,
the `{{{}AbstractReportMojo{}}}` declares a method
`{{{}canGenerateReport(){}}}`.
However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}} or
{{{}MavenReportEx{}}}, which is most unfortunate.
It is being used twice:
Once in {{execute() throws MojoExEx}}
and in
{{generate() throws MavenReportEx}} (and is called by execute()).
This way, there is no way for reporting plugins to scan for files, because
{{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot be
wrapped. However, the {{IOException}} from that method is useless anyway,
because it is never declared in any methods it calls.
Therefore please consider:
* Declaring any Exception on `{{{}canGenerateReports(){}}}`
* Removing the declared {{IOException}} in PlexusUtils ([PR
exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and
Maven-Utils (issue: tbd).
Thanks!
was:
Hi everyone,
the `AbstractReportMojo` declares a method `canGenerateReport`.
However, it is unable to throw any exceptions. Not even MojoExecutionEx or
MavenReportEx, which is most unfortunate.
It is being used twice:
Once in execute() throws MojoExEx
and in
generate() throws MavenReportEx (and is called by execute()).
This way, there is no way for reporting plugins to scan for files, because
FileUtils::getFiles DOES throw a IOException, which then cannot be wrapped.
However, the IOException from that method is useless anyway, because it is
never declared in any methods it calls.
Therefore please consider:
* Declaring any Exception on `canGenerateReports`
* Removing the declared IOException in PlexusUtils ([PR
exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and
Maven-Utils (issue: tbd).
Thanks!
> API change: let `canGenerateReport` throw an Exception
> --
>
> Key: MNG-7393
> URL: https://issues.apache.org/jira/browse/MNG-7393
> Project: Maven
> Issue Type: Improvement
>Reporter: Benjamin Marwell
>Priority: Major
>
> Hi everyone,
> the `{{{}AbstractReportMojo{}}}` declares a method
> `{{{}canGenerateReport(){}}}`.
> However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}}
> or {{{}MavenReportEx{}}}, which is most unfortunate.
> It is being used twice:
> Once in {{execute() throws MojoExEx}}
> and in
> {{generate() throws MavenReportEx}} (and is called by execute()).
> This way, there is no way for reporting plugins to scan for files, because
> {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot
> be wrapped. However, the {{IOException}} from that method is useless anyway,
> because it is never declared in any methods it calls.
> Therefore please consider:
> * Declaring any Exception on `{{{}canGenerateReports(){}}}`
> * Removing the declared {{IOException}} in PlexusUtils ([PR
> exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and
> Maven-Utils (issue: tbd).
> Thanks!
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MNG-7393) API change: let `canGenerateReport` throw an Exception
Benjamin Marwell created MNG-7393: - Summary: API change: let `canGenerateReport` throw an Exception Key: MNG-7393 URL: https://issues.apache.org/jira/browse/MNG-7393 Project: Maven Issue Type: Improvement Reporter: Benjamin Marwell Hi everyone, the `AbstractReportMojo` declares a method `canGenerateReport`. However, it is unable to throw any exceptions. Not even MojoExecutionEx or MavenReportEx, which is most unfortunate. It is being used twice: Once in execute() throws MojoExEx and in generate() throws MavenReportEx (and is called by execute()). This way, there is no way for reporting plugins to scan for files, because FileUtils::getFiles DOES throw a IOException, which then cannot be wrapped. However, the IOException from that method is useless anyway, because it is never declared in any methods it calls. Therefore please consider: * Declaring any Exception on `canGenerateReports` * Removing the declared IOException in PlexusUtils ([PR exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and Maven-Utils (issue: tbd). Thanks! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request #44: Bump mavenPluginToolsVersion from 3.6.2 to 3.6.4
dependabot[bot] opened a new pull request #44: URL: https://github.com/apache/maven-help-plugin/pull/44 Bumps `mavenPluginToolsVersion` from 3.6.2 to 3.6.4. Updates `maven-plugin-tools-generators` from 3.6.2 to 3.6.4 Commits https://github.com/apache/maven-plugin-tools/commit/33eb6d9df8be0e9cd0ac9b684741382b3d0e0fc7;>33eb6d9 [maven-release-plugin] prepare release maven-plugin-tools-3.6.4 https://github.com/apache/maven-plugin-tools/commit/c8ddcdcb10d342a5a5e2f38245bb569af5730c7c;>c8ddcdc [MPLUGIN-387] Bump Ant to 1.9.16 https://github.com/apache/maven-plugin-tools/commit/f14830dba00667fc661a520557fcdff6a8b0d1ad;>f14830d [MPLUGIN-387] Bump xmlunit to 1.6 https://github.com/apache/maven-plugin-tools/commit/036fdebb5cdbab68d79550cc6a0991f2a96ce4c8;>036fdeb [MPLUGIN-387] Bump plexus-compiler-manager to 2.8.8 https://github.com/apache/maven-plugin-tools/commit/d296e04045026716f1fba5d296a0dd4330cc7f92;>d296e04 [MPLUGIN-387] Switch from fest-assert to AssertJ 2.9.1 https://github.com/apache/maven-plugin-tools/commit/9ff352cc5680fe4e672dd99d0ff9160fc51a1317;>9ff352c [MPLUGIN-387] Bump plexus-archiver to 4.2.5 https://github.com/apache/maven-plugin-tools/commit/f6461047666e7c2dc0103042088825fd6a16a8ab;>f646104 [MPLUGIN-387] Upgrade BeanShell to 2.0b6 https://github.com/apache/maven-plugin-tools/commit/db1803198a77a40917a533e70ece7f066b783bf1;>db18031 [MPLUGIN-387] Bump junit to 4.13.2 https://github.com/apache/maven-plugin-tools/commit/c7ae057613aab21957197f93d33d6c0e2eb55bf8;>c7ae057 Added Dependabot configuration https://github.com/apache/maven-plugin-tools/commit/86d870fbc4a3aa1cd3b8da8a2fde015e5e8dfe43;>86d870f [MPLUGIN-387] Upgrade Doxia/Doxia Tools to 1.11.1 Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.2...maven-plugin-tools-3.6.4;>compare view Updates `maven-plugin-annotations` from 3.6.2 to 3.6.4 Commits https://github.com/apache/maven-plugin-tools/commit/33eb6d9df8be0e9cd0ac9b684741382b3d0e0fc7;>33eb6d9 [maven-release-plugin] prepare release maven-plugin-tools-3.6.4 https://github.com/apache/maven-plugin-tools/commit/c8ddcdcb10d342a5a5e2f38245bb569af5730c7c;>c8ddcdc [MPLUGIN-387] Bump Ant to 1.9.16 https://github.com/apache/maven-plugin-tools/commit/f14830dba00667fc661a520557fcdff6a8b0d1ad;>f14830d [MPLUGIN-387] Bump xmlunit to 1.6 https://github.com/apache/maven-plugin-tools/commit/036fdebb5cdbab68d79550cc6a0991f2a96ce4c8;>036fdeb [MPLUGIN-387] Bump plexus-compiler-manager to 2.8.8 https://github.com/apache/maven-plugin-tools/commit/d296e04045026716f1fba5d296a0dd4330cc7f92;>d296e04 [MPLUGIN-387] Switch from fest-assert to AssertJ 2.9.1 https://github.com/apache/maven-plugin-tools/commit/9ff352cc5680fe4e672dd99d0ff9160fc51a1317;>9ff352c [MPLUGIN-387] Bump plexus-archiver to 4.2.5 https://github.com/apache/maven-plugin-tools/commit/f6461047666e7c2dc0103042088825fd6a16a8ab;>f646104 [MPLUGIN-387] Upgrade BeanShell to 2.0b6 https://github.com/apache/maven-plugin-tools/commit/db1803198a77a40917a533e70ece7f066b783bf1;>db18031 [MPLUGIN-387] Bump junit to 4.13.2 https://github.com/apache/maven-plugin-tools/commit/c7ae057613aab21957197f93d33d6c0e2eb55bf8;>c7ae057 Added Dependabot configuration https://github.com/apache/maven-plugin-tools/commit/86d870fbc4a3aa1cd3b8da8a2fde015e5e8dfe43;>86d870f [MPLUGIN-387] Upgrade Doxia/Doxia Tools to 1.11.1 Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.2...maven-plugin-tools-3.6.4;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it
[GitHub] [maven-indexer] dependabot[bot] opened a new pull request #161: Bump slf4j.version from 1.7.32 to 1.7.33
dependabot[bot] opened a new pull request #161: URL: https://github.com/apache/maven-indexer/pull/161 Bumps `slf4j.version` from 1.7.32 to 1.7.33. Updates `slf4j-api` from 1.7.32 to 1.7.33 Commits https://github.com/qos-ch/slf4j/commit/2758a974264ab65df3af1d473eb9423ca978c14a;>2758a97 prepare release 1.7.33 https://github.com/qos-ch/slf4j/commit/a0681b72eb0d7c40733f02633e4f2677997b6fce;>a0681b7 fix SLF4J-499 https://github.com/qos-ch/slf4j/commit/c89dc3db0f84e0e529fd518f9b3085ad8f2499da;>c89dc3d Merge branch '1.7-maintenance' of github.com:qos-ch/slf4j into 1.7-maintenance https://github.com/qos-ch/slf4j/commit/0d2bd398f738f751a0814d9a0032310812773978;>0d2bd39 add slf4j-reload4j module https://github.com/qos-ch/slf4j/commit/ae9ee009f6ffbeae5a9ace85017b027aa5090ab3;>ae9ee00 start work on 1.7.33-SNAPSHOT See full diff in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33;>compare view Updates `jcl-over-slf4j` from 1.7.32 to 1.7.33 Commits https://github.com/qos-ch/slf4j/commit/2758a974264ab65df3af1d473eb9423ca978c14a;>2758a97 prepare release 1.7.33 https://github.com/qos-ch/slf4j/commit/a0681b72eb0d7c40733f02633e4f2677997b6fce;>a0681b7 fix SLF4J-499 https://github.com/qos-ch/slf4j/commit/c89dc3db0f84e0e529fd518f9b3085ad8f2499da;>c89dc3d Merge branch '1.7-maintenance' of github.com:qos-ch/slf4j into 1.7-maintenance https://github.com/qos-ch/slf4j/commit/0d2bd398f738f751a0814d9a0032310812773978;>0d2bd39 add slf4j-reload4j module https://github.com/qos-ch/slf4j/commit/ae9ee009f6ffbeae5a9ace85017b027aa5090ab3;>ae9ee00 start work on 1.7.33-SNAPSHOT See full diff in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request #66: Bump maven-compiler-plugin from 3.8.1 to 3.9.0
dependabot[bot] opened a new pull request #66: URL: https://github.com/apache/maven-apache-parent/pull/66 Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.8.1 to 3.9.0. Commits https://github.com/apache/maven-compiler-plugin/commit/aeb15b6cf38ee44391febf23310a4f2b432ab444;>aeb15b6 [maven-release-plugin] prepare release maven-compiler-plugin-3.9.0 https://github.com/apache/maven-compiler-plugin/commit/6335382f97aad2e69b9f9a0a4af3cf801cd29273;>6335382 Shared GitHub Acton v2 https://github.com/apache/maven-compiler-plugin/commit/8d5d3cd68db3cefb947e1e1bf5fd83ac231ef00d;>8d5d3cd Fix site build https://github.com/apache/maven-compiler-plugin/commit/ce4eb1e353d176f8573f7a3ba893fc3ec42ec21b;>ce4eb1e Bump plexus-component-metadata from 2.1.0 to 2.1.1 https://github.com/apache/maven-compiler-plugin/commit/f875750ee9bcf07bb25b470c5ceb73d7dccfbe12;>f875750 Bump mockito-core from 4.1.0 to 4.2.0 https://github.com/apache/maven-compiler-plugin/commit/5463357ebc1c65a4e25bfd8ea4c453a618b66bf1;>5463357 fix CI site goal https://github.com/apache/maven-compiler-plugin/commit/859c9039e4b73367a0d9486cc63b98ec1cc1fa6f;>859c903 Update plugins https://github.com/apache/maven-compiler-plugin/commit/b0de9bc0fbe9416e81b6a13cb9e67fdf891192af;>b0de9bc Bump mockito-core from 4.0.0 to 4.1.0 https://github.com/apache/maven-compiler-plugin/commit/f95dd463d904276564ac47ee822c37ac8751f4e9;>f95dd46 Bump plexusCompilerVersion from 2.8.8 to 2.9.0 https://github.com/apache/maven-compiler-plugin/commit/26900cfe598981a516b66e01843e79f1c486a147;>26900cf Bump mockito-core from 2.28.2 to 4.0.0 Additional commits viewable in https://github.com/apache/maven-compiler-plugin/compare/maven-compiler-plugin-3.8.1...maven-compiler-plugin-3.9.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] wypro opened a new issue #590: When MVND is used to compile a project, the addClasspath parameter in the manifest of the configuration item compiled by maven-jar-plugin is invali
wypro opened a new issue #590: URL: https://github.com/apache/maven-mvnd/issues/590   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] 501956430 opened a new issue #589: docker jenkins mvnd configured build error！
501956430 opened a new issue #589: URL: https://github.com/apache/maven-mvnd/issues/589 1、In container configuration information： https://user-images.githubusercontent.com/20204491/150455225-ebe3ecab-f851-4bcd-9ddf-262ccff63bb2.png;> 2、jenkins build error： https://user-images.githubusercontent.com/20204491/150455509-63f5be53-2fc1-4a91-af2e-10a3c989403a.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #398: [SUREFIRE-1962] Unit test for ProviderInfo#isApplicable
Tibor17 commented on pull request #398: URL: https://github.com/apache/maven-surefire/pull/398#issuecomment-1018079885 @slawekjaranowski Nice exam. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #387: [SUREFIRE-1939] Fix NPE in SystemUtils.toJdkHomeFromJvmExec if java home has 2 components
Tibor17 commented on a change in pull request #387: URL: https://github.com/apache/maven-surefire/pull/387#discussion_r789267882 ## File path: surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java ## @@ -98,6 +98,15 @@ public void incorrectJdkPath() assertThat( SystemUtils.isJava9AtLeast( incorrect.getAbsolutePath() ) ).isFalse(); } +@Test +public void incorrectJdkPathShouldNotNPE() Review comment: @CMoH We can accept this fix for the unit test but more important would be to back track the callers in `AbstractSurefireMojo` and see if this NPE may happen and may have some influence, and where if any. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #391: [SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro…
Tibor17 commented on a change in pull request #391:
URL: https://github.com/apache/maven-surefire/pull/391#discussion_r789266542
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
##
@@ -653,6 +653,12 @@ private RunResult fork( Object testSet, PropertiesWrapper
providerProperties, Fo
{
runResult = timeout(
reporter.getGlobalRunStatistics().getRunResult() );
}
+else if ( forkClient.isErrorInFork() )
+{
+final StackTraceWriter stackTrace =
forkClient.getErrorInFork();
+booterForkException =
+new SurefireBooterForkException(
stackTrace.writeTraceToString() );
+}
Review comment:
@fl4via
Pls have a look at the comments and answers. How can we continue with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1946) Stack trace is ommited by ForkStarter.fork if forkClient.isErrorInFork
[
https://issues.apache.org/jira/browse/SUREFIRE-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479769#comment-17479769
]
Tibor Digana commented on SUREFIRE-1946:
[~fl4via]
We need to finish or resolve this ticket.
I wanted to ping you. Pls have a look to my comments above and respond to me
back, thx.
> Stack trace is ommited by ForkStarter.fork if forkClient.isErrorInFork
> --
>
> Key: SUREFIRE-1946
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1946
> Project: Maven Surefire
> Issue Type: Bug
> Components: process forking
>Affects Versions: 3.0.0-M5
>Reporter: Flavia Rainone
>Priority: Major
> Labels: waiting-for-feedback
>
> If there is an error in the fork client (forkClient.isErrorInFork), only the
> title of the exception is shown, and without the stack trace that caused that
> exception, it is hard to be able to figure what is causing the error.
> In my case, I'm getting a NPE, and the output shows solely:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test)
> on project undertow-core: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /home/fla/Development/projects/undertow/core/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] There was an error in the forked process
> [ERROR] Test mechanism :: java.lang.NullPointerException
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There
> was an error in the forked process
> [ERROR] Test mechanism :: java.lang.NullPointerException
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:733)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:305)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:265)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1314)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1159)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:932)
> [ERROR] at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> [ERROR] at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> [ERROR] at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> [ERROR] at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:957)
> [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:289)
> [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:193)
> [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [ERROR] at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [ERROR] at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [ERROR] at java.lang.reflect.Method.invoke(Method.java:498)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
> [ERROR] at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
> [ERROR]
> [ERROR] -> [Help 1]
> [ERROR]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #422: [SUREFIRE-1975] JDK18 - The Security Manager is deprecated and will be removed in a future release
Tibor17 commented on a change in pull request #422:
URL: https://github.com/apache/maven-surefire/pull/422#discussion_r788126157
##
File path:
surefire-providers/surefire-junit3/src/test/java/org/apache/maven/surefire/junit/JUnitTestSetTest.java
##
@@ -54,6 +58,32 @@ public void testExecuteSuiteClass()
succeededTests.get( 0 ).getName() );
}
+public void testSystemManager()
+{
+float javaVersion = Float.parseFloat(
JavaVersion.JAVA_RECENT.toString() );
+boolean isDeprecated = javaVersion >= 17;
+try
+{
+JUnit3Provider.setSystemManager( "java.lang.SecurityManager" );
+
+if ( isDeprecated )
+{
+fail();
+}
+
+Object sm = invokeGetter( System.class, null, "getSecurityManager"
);
Review comment:
@slawekjaranowski
SecurityManager can be deleted in any major version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MENFORCER-411) DependencyConvergence should support including/excluding certain dependencies
[ https://issues.apache.org/jira/browse/MENFORCER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479730#comment-17479730 ] Forrest Feaser commented on MENFORCER-411: -- [~MattNelson] Sorry this is long... I don't think reordering the dependencies would result in any unexpected behavior (with respect to what can reasonably be expected). The dependency conflicts are computed in the same manner as before, the errors are just filtered afterwards according to which dependencies are included/excluded by the user. Yes, the dependency that maven chooses might change depending on the order of dependencies in the POM, but it won't affect which convergence conflicts exist. The build failing from the rule would only depend on what dependencies the user chooses to include/exclude, and whether or not conflicts exist between them. If the POM gets reordered and maven chooses a dependency that does cause issues (because it is incompatible with the previously chosen version), and the user excluded that dependency from convergence checking, there might be a failure later in the build. However, that would be the responsibility of the user, not that of the plugin, because the user chose not to enforce convergence for that dependency. You would get the same errors from reordering if you were to not use the DependencyConvergence rule at all. It's not a false sense of correctness because there can be no expectation that it will be completely correct if any dependencies are excluded. I don't see any reason why DependencyConvergence has to be all or nothing. My changes simply add more granularity if you want to ensure convergence for specific dependencies. Please correct me if I'm still misunderstanding. > DependencyConvergence should support including/excluding certain dependencies > - > > Key: MENFORCER-411 > URL: https://issues.apache.org/jira/browse/MENFORCER-411 > Project: Maven Enforcer Plugin > Issue Type: Improvement > Components: Standard Rules >Affects Versions: 3.0.1 >Reporter: Forrest Feaser >Priority: Major > Original Estimate: 4h > Remaining Estimate: 4h > > It would be nice if the DependencyConvergence rule could specify certain > dependencies that should/should not fail the build. This might be useful if > your project has a lot of dependency conflicts, but you know there are just a > few troublesome ones that cause issues, and you don't want to resolve the > conflicts for your entire project. > Here is my PR: https://github.com/apache/maven-enforcer/pull/136 > Do I need to sign the Contributor License Agreement for this? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-mvnd] honnix commented on issue #588: Local settings.xml results current folder used as repository
honnix commented on issue #588: URL: https://github.com/apache/maven-mvnd/issues/588#issuecomment-1017909406 @gnodet I can confirm that the build from main branch fixes this issue. Thanks for the help! I'm closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] honnix closed issue #588: Local settings.xml results current folder used as repository
honnix closed issue #588: URL: https://github.com/apache/maven-mvnd/issues/588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-13) rename remote.cache.* properties to build.cache.*
[ https://issues.apache.org/jira/browse/MBUILDCACHE-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479634#comment-17479634 ] ASF GitHub Bot commented on MBUILDCACHE-13: --- maximilian-novikov-db opened a new pull request #3: URL: https://github.com/apache/maven-build-cache-extension/pull/3 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > rename remote.cache.* properties to build.cache.* > - > > Key: MBUILDCACHE-13 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-13 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Herve Boutemy >Priority: Major > Labels: pull-request-available > > current parameters are named "remote.cache.*": > https://maven.apache.org/extensions/maven-build-cache-extension/parameters.html > is it really restricted to remote build cache? Or just historical naming done > before we chose "build cache" as the keyword (instead of unclear "cache") -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-build-cache-extension] maximilian-novikov-db opened a new pull request #3: [MBUILDCACHE-13] rename remote.cache.* properties to maven.build.cache.*
maximilian-novikov-db opened a new pull request #3: URL: https://github.com/apache/maven-build-cache-extension/pull/3 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-51) Refactor using Java Path API (NIO.2)
[ https://issues.apache.org/jira/browse/MWRAPPER-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479574#comment-17479574 ] Jorge Solórzano commented on MWRAPPER-51: - I think this is ready for review! > Refactor using Java Path API (NIO.2) > > > Key: MWRAPPER-51 > URL: https://issues.apache.org/jira/browse/MWRAPPER-51 > Project: Maven Wrapper > Issue Type: Improvement > Components: Maven Wrapper Jar, Maven Wrapper Plugin >Affects Versions: 3.1.0 >Reporter: Jorge Solórzano >Priority: Normal > Labels: pull-request-available > > The project could be improved by using the Java Path API (NIO.2) available > since Java 7 and also include some checks in paths and in some cases even > improve the performance. > * [https://www.oracle.com/technical-resources/articles/javase/nio.html] > * [https://blogs.oracle.com/javamagazine/post/path-files-input-output] > This will help to have a cleaner code and improve the code base. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MWRAPPER-51) Refactor using Java Path API (NIO.2)
[ https://issues.apache.org/jira/browse/MWRAPPER-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Solórzano updated MWRAPPER-51: Component/s: Maven Wrapper Jar Maven Wrapper Plugin > Refactor using Java Path API (NIO.2) > > > Key: MWRAPPER-51 > URL: https://issues.apache.org/jira/browse/MWRAPPER-51 > Project: Maven Wrapper > Issue Type: Improvement > Components: Maven Wrapper Jar, Maven Wrapper Plugin, Maven Wrapper > Scripts >Affects Versions: 3.1.0 >Reporter: Jorge Solórzano >Priority: Normal > > The project could be improved by using the Java Path API (NIO.2) available > since Java 7 and also include some checks in paths and in some cases even > improve the performance. > * [https://www.oracle.com/technical-resources/articles/javase/nio.html] > * [https://blogs.oracle.com/javamagazine/post/path-files-input-output] > This will help to have a cleaner code and improve the code base. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MWRAPPER-51) Refactor using Java Path API (NIO.2)
[ https://issues.apache.org/jira/browse/MWRAPPER-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Solórzano updated MWRAPPER-51: Labels: pull-request-available (was: ) > Refactor using Java Path API (NIO.2) > > > Key: MWRAPPER-51 > URL: https://issues.apache.org/jira/browse/MWRAPPER-51 > Project: Maven Wrapper > Issue Type: Improvement > Components: Maven Wrapper Jar, Maven Wrapper Plugin >Affects Versions: 3.1.0 >Reporter: Jorge Solórzano >Priority: Normal > Labels: pull-request-available > > The project could be improved by using the Java Path API (NIO.2) available > since Java 7 and also include some checks in paths and in some cases even > improve the performance. > * [https://www.oracle.com/technical-resources/articles/javase/nio.html] > * [https://blogs.oracle.com/javamagazine/post/path-files-input-output] > This will help to have a cleaner code and improve the code base. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MWRAPPER-51) Refactor using Java Path API (NIO.2)
[ https://issues.apache.org/jira/browse/MWRAPPER-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Solórzano updated MWRAPPER-51: Component/s: (was: Maven Wrapper Scripts) > Refactor using Java Path API (NIO.2) > > > Key: MWRAPPER-51 > URL: https://issues.apache.org/jira/browse/MWRAPPER-51 > Project: Maven Wrapper > Issue Type: Improvement > Components: Maven Wrapper Jar, Maven Wrapper Plugin >Affects Versions: 3.1.0 >Reporter: Jorge Solórzano >Priority: Normal > > The project could be improved by using the Java Path API (NIO.2) available > since Java 7 and also include some checks in paths and in some cases even > improve the performance. > * [https://www.oracle.com/technical-resources/articles/javase/nio.html] > * [https://blogs.oracle.com/javamagazine/post/path-files-input-output] > This will help to have a cleaner code and improve the code base. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-mvnd] honnix commented on issue #588: Local settings.xml results current folder used as repository
honnix commented on issue #588: URL: https://github.com/apache/maven-mvnd/issues/588#issuecomment-1017753166 Aha, I see. I will give it a try later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #588: Local settings.xml results current folder used as repository
gnodet commented on issue #588: URL: https://github.com/apache/maven-mvnd/issues/588#issuecomment-1017697945 > @gnodet Thanks for the info. Do you mean it's caused by changes made in #573? No, I meant it's the same issue. This should already be fixed in the master branch if you can build it and give it a try to confirm, that would be awesome ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] honnix commented on issue #588: Local settings.xml results current folder used as repository
honnix commented on issue #588: URL: https://github.com/apache/maven-mvnd/issues/588#issuecomment-1017691401 @gnodet Thanks for the info. Do you mean it's caused by changes made in #573? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet edited a comment on issue #588: Local settings.xml results current folder used as repository
gnodet edited a comment on issue #588: URL: https://github.com/apache/maven-mvnd/issues/588#issuecomment-1017687128 I think this is caused by https://github.com/apache/maven-mvnd/issues/553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #588: Local settings.xml results current folder used as repository
gnodet commented on issue #588: URL: https://github.com/apache/maven-mvnd/issues/588#issuecomment-1017687128 I think this is caused by https://github.com/apache/maven-mvnd/pull/573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MPIR-405) Regression in the maven site rendering due to Doxia change to HTML 5
[ https://issues.apache.org/jira/browse/MPIR-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwénaël Ruelland updated MPIR-405: -- Description: Doxia and Maven Site Plugin projects updated the HTML rendering from HTML 4 to 5. Leading to a correct generation of previously missing figure and figcaption tags. Now the lines of the report have twice the height, and the report is harder to scroll to. The rendering regression is seeable on every projects with icons for info, warning, error. The last OK maven site plugin is 3.7.1, the first NOK is 3.8.2 (through to 3.10) Fixing may include work on * Maven Site (+Doxia), can't fix. * maven-project-info-reports-plugin, waiting for review * Versions Maven Plugin, waiting for review [!https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png!|https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png] [!https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png!|https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png] [!https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png!|https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png] [!https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png!|https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png] was: Doxia and Maven Site Plugin projects updated the HTML rendering from HTML 4 to 5. Leading to a correct generation of previously missing figure and figcaption tags. Now the lines of the report have twice the height, and the report is harder to scroll to. The rendering regression is seeable on every projects with icons for info, warning, error. The last OK maven site plugin is 3.7.1, the first NOK is 3.8.2 (through to 3.10) Fixing may include work on * Maven Site (+Doxia), working on it. * maven-project-info-reports-plugin * Versions Maven Plugin [!https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png!|https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png] [!https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png!|https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png] [!https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png!|https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png] [!https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png!|https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png] > Regression in the maven site rendering due to Doxia change to HTML 5 > > > Key: MPIR-405 > URL: https://issues.apache.org/jira/browse/MPIR-405 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependency-convergence >Reporter: Gwénaël Ruelland >Priority: Trivial > > Doxia and Maven Site Plugin projects updated the HTML rendering from HTML 4 > to 5. Leading to a correct generation of previously missing figure and > figcaption tags. > Now the lines of the report have twice the height, and the report is harder > to scroll to. > The rendering regression is seeable on every projects with icons for info, > warning, error. > The last OK maven site plugin is 3.7.1, the first NOK is 3.8.2 (through to > 3.10) > Fixing may include work on > * Maven Site (+Doxia), can't fix. > * maven-project-info-reports-plugin, waiting for review > * Versions Maven Plugin, waiting for review > [!https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png!|https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png] > [!https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png!|https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png] > [!https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png!|https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png] > [!https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png!|https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MPIR-406) Dependencies listed randomly instead of alphanumerical order
[ https://issues.apache.org/jira/browse/MPIR-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479447#comment-17479447 ] Michael Osipov commented on MPIR-406: - So modified the visualization modifies reality. > Dependencies listed randomly instead of alphanumerical order > > > Key: MPIR-406 > URL: https://issues.apache.org/jira/browse/MPIR-406 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Reporter: Gwénaël Ruelland >Priority: Trivial > Attachments: image-2022-01-20-11-00-35-884.png, > image-2022-01-20-11-02-06-548.png > > > Dependency tree in the HTML report has dependencies unsorted which is a pain > to search/check visually. > Here is a visual of the fix. > !image-2022-01-20-11-02-06-548.png! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MBUILDCACHE-13) rename remote.cache.* properties to build.cache.*
[ https://issues.apache.org/jira/browse/MBUILDCACHE-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479440#comment-17479440 ] ASF GitHub Bot commented on MBUILDCACHE-13: --- maximilian-novikov-db closed pull request #2: URL: https://github.com/apache/maven-build-cache-extension/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > rename remote.cache.* properties to build.cache.* > - > > Key: MBUILDCACHE-13 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-13 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Herve Boutemy >Priority: Major > Labels: pull-request-available > > current parameters are named "remote.cache.*": > https://maven.apache.org/extensions/maven-build-cache-extension/parameters.html > is it really restricted to remote build cache? Or just historical naming done > before we chose "build cache" as the keyword (instead of unclear "cache") -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-build-cache-extension] maximilian-novikov-db closed pull request #2: [MBUILDCACHE-13] rename remote.cache.* properties to maven.build.cache.*
maximilian-novikov-db closed pull request #2: URL: https://github.com/apache/maven-build-cache-extension/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPIR-406) Dependencies listed randomly instead of alphanumerical order
[ https://issues.apache.org/jira/browse/MPIR-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479404#comment-17479404 ] Herve Boutemy commented on MPIR-406: that's not random either: it's proper dependencies order > Dependencies listed randomly instead of alphanumerical order > > > Key: MPIR-406 > URL: https://issues.apache.org/jira/browse/MPIR-406 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Reporter: Gwénaël Ruelland >Priority: Trivial > Attachments: image-2022-01-20-11-00-35-884.png, > image-2022-01-20-11-02-06-548.png > > > Dependency tree in the HTML report has dependencies unsorted which is a pain > to search/check visually. > Here is a visual of the fix. > !image-2022-01-20-11-02-06-548.png! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MBUILDCACHE-13) rename remote.cache.* properties to build.cache.*
[
https://issues.apache.org/jira/browse/MBUILDCACHE-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479399#comment-17479399
]
ASF GitHub Bot commented on MBUILDCACHE-13:
---
AlexanderAshitkin commented on a change in pull request #2:
URL:
https://github.com/apache/maven-build-cache-extension/pull/2#discussion_r788804500
##
File path: src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java
##
@@ -737,7 +737,7 @@ public boolean isForcedExecution( MavenProject project,
MojoExecution execution
{
return true;
}
-String alwaysRunPlugins = project.getProperties().getProperty(
"remote.cache.alwaysRunPlugins" );
+String alwaysRunPlugins = project.getProperties().getProperty(
"maven.build.cache.alwaysRunPlugins" );
Review comment:
please extract to constant and add annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> rename remote.cache.* properties to build.cache.*
> -
>
> Key: MBUILDCACHE-13
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-13
> Project: Maven Build Cache Extension
> Issue Type: Task
>Reporter: Herve Boutemy
>Priority: Major
> Labels: pull-request-available
>
> current parameters are named "remote.cache.*":
> https://maven.apache.org/extensions/maven-build-cache-extension/parameters.html
> is it really restricted to remote build cache? Or just historical naming done
> before we chose "build cache" as the keyword (instead of unclear "cache")
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a change in pull request #2: [MBUILDCACHE-13] rename remote.cache.* properties to maven.build.cache.*
AlexanderAshitkin commented on a change in pull request #2:
URL:
https://github.com/apache/maven-build-cache-extension/pull/2#discussion_r788804500
##
File path: src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java
##
@@ -737,7 +737,7 @@ public boolean isForcedExecution( MavenProject project,
MojoExecution execution
{
return true;
}
-String alwaysRunPlugins = project.getProperties().getProperty(
"remote.cache.alwaysRunPlugins" );
+String alwaysRunPlugins = project.getProperties().getProperty(
"maven.build.cache.alwaysRunPlugins" );
Review comment:
please extract to constant and add annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPIR-406) Dependencies listed randomly instead of alphanumerical order
[ https://issues.apache.org/jira/browse/MPIR-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479386#comment-17479386 ] Michael Osipov commented on MPIR-406: - That's not a bug. > Dependencies listed randomly instead of alphanumerical order > > > Key: MPIR-406 > URL: https://issues.apache.org/jira/browse/MPIR-406 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Reporter: Gwénaël Ruelland >Priority: Trivial > Attachments: image-2022-01-20-11-00-35-884.png, > image-2022-01-20-11-02-06-548.png > > > Dependency tree in the HTML report has dependencies unsorted which is a pain > to search/check visually. > Here is a visual of the fix. > !image-2022-01-20-11-02-06-548.png! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-mvnd] honnix commented on issue #588: Local settings.xml results current folder used as repository
honnix commented on issue #588: URL: https://github.com/apache/maven-mvnd/issues/588#issuecomment-1017514221 Tried using `mvnd -s .../.m2/settings.xml`, `mvn -gs .../.m2/settings.xml` and `mvn -Dmaven.settings=.../.m2/settings.xml`. But none of them works and the one in current folder is still being picked up. Also tried making the `settings.xml` in the project root folder malformed, and that broke the build, which means it is indeed picked up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] honnix opened a new issue #588: Local settings.xml results current folder used as repository
honnix opened a new issue #588: URL: https://github.com/apache/maven-mvnd/issues/588 For a reason, we have a valid `settings.xml` file under our project root folder. This file is not intended to be used by Maven when building and it is only meant to be packed into a container. It seems `mvnd` will by default use that file, treat the folder where this file sits as `maven repository` root, and download artifacts to the folder. Is this an intended behaviour? Plain maven does not seem to be bothered by the existence of this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] opened a new pull request #45: Bump slf4j-api from 1.7.32 to 1.7.33
dependabot[bot] opened a new pull request #45: URL: https://github.com/apache/maven-jxr/pull/45 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.32 to 1.7.33. Commits https://github.com/qos-ch/slf4j/commit/2758a974264ab65df3af1d473eb9423ca978c14a;>2758a97 prepare release 1.7.33 https://github.com/qos-ch/slf4j/commit/a0681b72eb0d7c40733f02633e4f2677997b6fce;>a0681b7 fix SLF4J-499 https://github.com/qos-ch/slf4j/commit/c89dc3db0f84e0e529fd518f9b3085ad8f2499da;>c89dc3d Merge branch '1.7-maintenance' of github.com:qos-ch/slf4j into 1.7-maintenance https://github.com/qos-ch/slf4j/commit/0d2bd398f738f751a0814d9a0032310812773978;>0d2bd39 add slf4j-reload4j module https://github.com/qos-ch/slf4j/commit/ae9ee009f6ffbeae5a9ace85017b027aa5090ab3;>ae9ee00 start work on 1.7.33-SNAPSHOT See full diff in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] gnodet commented on pull request #145: [MRESOLVER-9] Managed dependencies are not honoured when resolving a …
gnodet commented on pull request #145: URL: https://github.com/apache/maven-resolver/pull/145#issuecomment-1017441343 I've opened #146 to use a different jira issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] gnodet closed pull request #145: [MRESOLVER-9] Managed dependencies are not honoured when resolving a …
gnodet closed pull request #145: URL: https://github.com/apache/maven-resolver/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] gnodet opened a new pull request #146: [1.6.x][MRESOLVER-235] Fix dependency management issue
gnodet opened a new pull request #146: URL: https://github.com/apache/maven-resolver/pull/146 This PR provides a fix for MRESOLVER-235 / MNG-7003. However, the fix breaks two ITs: mng4720 and mng4396. For mng4720, so core of the IT is not broken, but as specifically commented in the IT see https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4720DependencyManagementExclusionMergeTest.java#L70, one of the dependency is not included anymore. The PR contains unit tests that replicate the ITs for mng4720 and for MNG-7003. I'm not sure there's any way to fix both at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-project-info-reports-plugin] sultan opened a new pull request #29: Fixed [MPIR-405] regression in the maven site rendering + [MPIR-406] dependencies sorting
sultan opened a new pull request #29: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/29 https://issues.apache.org/jira/browse/MPIR-405 Maven Site Plugin and Doxia switching to HTML 5 broke all the reports that includes images. Including other report plugins. The proposed fix allows to return back to the original compact format that was more synthetic. https://issues.apache.org/jira/browse/MPIR-406 Dependencies are now sorted in the report which eases search and visual control of exclusions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] mailbyms opened a new issue #587: will there be an official docker image on docker hub
mailbyms opened a new issue #587: URL: https://github.com/apache/maven-mvnd/issues/587 will there be an official docker image on docker hub? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MPIR-406) Dependencies listed randomly instead of alphanumerical order
[ https://issues.apache.org/jira/browse/MPIR-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwénaël Ruelland updated MPIR-406: -- Description: Dependency tree in the HTML report has dependencies unsorted which is a pain to search/check visually. Here is a visual of the fix. !image-2022-01-20-11-02-06-548.png! was: Dependency tree in the HTML report has dependencies unsorted which is a pain to search/check visually. !image-2022-01-20-11-02-06-548.png! > Dependencies listed randomly instead of alphanumerical order > > > Key: MPIR-406 > URL: https://issues.apache.org/jira/browse/MPIR-406 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Reporter: Gwénaël Ruelland >Priority: Trivial > Attachments: image-2022-01-20-11-00-35-884.png, > image-2022-01-20-11-02-06-548.png > > > Dependency tree in the HTML report has dependencies unsorted which is a pain > to search/check visually. > Here is a visual of the fix. > !image-2022-01-20-11-02-06-548.png! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (MPIR-406) Dependencies listed randomly instead of alphanumerical order
Gwénaël Ruelland created MPIR-406: - Summary: Dependencies listed randomly instead of alphanumerical order Key: MPIR-406 URL: https://issues.apache.org/jira/browse/MPIR-406 Project: Maven Project Info Reports Plugin Issue Type: Bug Components: dependencies Reporter: Gwénaël Ruelland Attachments: image-2022-01-20-11-00-35-884.png, image-2022-01-20-11-02-06-548.png Dependency tree in the HTML report has dependencies unsorted which is a pain to search/check visually. !image-2022-01-20-11-02-06-548.png! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MPIR-405) Regression in the maven site rendering due to Doxia change to HTML 5
[ https://issues.apache.org/jira/browse/MPIR-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwénaël Ruelland updated MPIR-405: -- Description: Doxia and Maven Site Plugin projects updated the HTML rendering from HTML 4 to 5. Leading to a correct generation of previously missing figure and figcaption tags. Now the lines of the report have twice the height, and the report is harder to scroll to. The rendering regression is seeable on every projects with icons for info, warning, error. The last OK maven site plugin is 3.7.1, the first NOK is 3.8.2 (through to 3.10) Fixing may include work on * Maven Site (+Doxia), working on it. * maven-project-info-reports-plugin * Versions Maven Plugin [!https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png!|https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png] [!https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png!|https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png] [!https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png!|https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png] [!https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png!|https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png] was: Doxia and Maven Site Plugin projects updated the HTML rendering from HTML 4 to 5. Leading to a correct generation of previously missing figure and figcaption tags. The rendering regression is seeable on every projects with icons for info, warning, error. The last OK maven site plugin is 3.7.1, the first NOK is 3.8.2 (through to 3.10) Fixing may include work on * Maven Site (+Doxia), working on it. * maven-project-info-reports-plugin * Versions Maven Plugin [!https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png!|https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png] [!https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png!|https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png] [!https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png!|https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png] [!https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png!|https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png] > Regression in the maven site rendering due to Doxia change to HTML 5 > > > Key: MPIR-405 > URL: https://issues.apache.org/jira/browse/MPIR-405 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependency-convergence >Reporter: Gwénaël Ruelland >Priority: Trivial > > Doxia and Maven Site Plugin projects updated the HTML rendering from HTML 4 > to 5. Leading to a correct generation of previously missing figure and > figcaption tags. > Now the lines of the report have twice the height, and the report is harder > to scroll to. > The rendering regression is seeable on every projects with icons for info, > warning, error. > The last OK maven site plugin is 3.7.1, the first NOK is 3.8.2 (through to > 3.10) > Fixing may include work on > * Maven Site (+Doxia), working on it. > * maven-project-info-reports-plugin > * Versions Maven Plugin > [!https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png!|https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png] > [!https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png!|https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png] > [!https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png!|https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png] > [!https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png!|https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-mvnd] Chris9809 commented on issue #578: Exception in thread "main" org.mvndaemon.mvnd.common.DaemonException$ConnectException: Timeout waiting to connect to the Maven daemon.
Chris9809 commented on issue #578: URL: https://github.com/apache/maven-mvnd/issues/578#issuecomment-1017251888 Same problem, and log shows ``` java Exception in thread "main" java.lang.reflect.InvocationTargetException at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.mvndaemon.mvnd.common.MavenDaemon.main(MavenDaemon.java:84) Caused by: java.lang.NoClassDefFoundError: org/apache/commons/cli/ParseException at org.mvndaemon.mvnd.daemon.Server.(Server.java:121) ... 5 more Caused by: java.lang.ClassNotFoundException: org.apache.commons.cli.ParseException at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at org.mvndaemon.mvnd.common.MavenDaemon$1.findClass(MavenDaemon.java:69) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 6 more ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPIR-405) Regression in the maven site rendering due to Doxia change to HTML 5
Gwénaël Ruelland created MPIR-405: - Summary: Regression in the maven site rendering due to Doxia change to HTML 5 Key: MPIR-405 URL: https://issues.apache.org/jira/browse/MPIR-405 Project: Maven Project Info Reports Plugin Issue Type: Bug Components: dependency-convergence Reporter: Gwénaël Ruelland Doxia and Maven Site Plugin projects updated the HTML rendering from HTML 4 to 5. Leading to a correct generation of previously missing figure and figcaption tags. The rendering regression is seeable on every projects with icons for info, warning, error. The last OK maven site plugin is 3.7.1, the first NOK is 3.8.2 (through to 3.10) Fixing may include work on * Maven Site (+Doxia), working on it. * maven-project-info-reports-plugin * Versions Maven Plugin [!https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png!|https://user-images.githubusercontent.com/5782559/150302148-d1ce757d-4ab2-4fbc-abf8-4c9cdb9a19d2.png] [!https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png!|https://user-images.githubusercontent.com/5782559/150302161-98f7859a-ce1a-4600-a489-9cca2044d8db.png] [!https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png!|https://user-images.githubusercontent.com/5782559/150302169-643e0412-0c21-4817-b522-ec9042952695.png] [!https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png!|https://user-images.githubusercontent.com/5782559/150302184-cf52fb62-a446-40e7-9b64-d5e2d9f4ed50.png] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
Tibor17 commented on pull request #389: URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-1017233013 Thx for contributing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-1935) Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
[
https://issues.apache.org/jira/browse/SUREFIRE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1935.
--
Resolution: Fixed
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=97afea1ba129e2f9d932f504d3789385e8006865
> Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
> -
>
> Key: SUREFIRE-1935
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1935
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, process forking
>Affects Versions: 3.0.0-M5
>Reporter: Emond Papegaaij
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: forkedtests.zip
>
>
> When running tests with forkCount > 1 on the JUnit 5 Platform, the
> {{JUnitPlatformProvider}} keeps restarting the entire launcher, causing the
> life cycle of the tests to change. When an {{Extension}} registers an
> expensive resource in the root store, this resource is now created over and
> over again for every test class. An example of such an {{Extension}} is the
> {{ArquillianExtension}}. The recreation of this resource causes the tests to
> create and destroy all containers associated with the test for every class,
> rather than once per fork.
> I've attached a very simple example project that contains 4 tests and a dummy
> extension that registers an object in the root store. The output clearly
> indicates the problem:
> {code}
> $ mvn surefire:test -DforkCount=1
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< nl.topicus:forkedtests
> >---
> [INFO] Building forkedtests 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-cli) @ forkedtests ---
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running nl.topicus.test.Test2
> Performing heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.021
> s - in nl.topicus.test.Test2
> [INFO] Running nl.topicus.test.Test1
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.001
> s - in nl.topicus.test.Test1
> [INFO] Running nl.topicus.test.Test3
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.002
> s - in nl.topicus.test.Test3
> [INFO] Running nl.topicus.test.Test4
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.001
> s - in nl.topicus.test.Test4
> Discarding heavy calculation
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 8.816 s
> [INFO] Finished at: 2021-08-13T12:50:40+02:00
> [INFO]
>
> {code}
> Compared to running with {{forkCount=2}} (notice how the heavy calculation is
> performed 4 times, where it should only run twice):
> {code}
> $ mvn surefire:test -DforkCount=2
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< nl.topicus:forkedtests
> >---
> [INFO] Building forkedtests 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-cli) @ forkedtests ---
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running nl.topicus.test.Test2
> [INFO] Running nl.topicus.test.Test1
> Performing heavy calculation
> Performing heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.025
> s - in nl.topicus.test.Test2
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.022
> s - in nl.topicus.test.Test1
> Discarding heavy calculation
> Discarding heavy calculation
> [INFO] Running nl.topicus.test.Test3
> [INFO] Running nl.topicus.test.Test4
> Performing heavy calculation
> Performing heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.002
> s - in nl.topicus.test.Test3
> Discarding heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.002
> s - in nl.topicus.test.Test4
> Discarding heavy calculation
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
[GitHub] [maven-surefire] Tibor17 merged pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
Tibor17 merged pull request #389: URL: https://github.com/apache/maven-surefire/pull/389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-13) rename remote.cache.* properties to build.cache.*
[ https://issues.apache.org/jira/browse/MBUILDCACHE-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479176#comment-17479176 ] ASF GitHub Bot commented on MBUILDCACHE-13: --- maximilian-novikov-db opened a new pull request #2: URL: https://github.com/apache/maven-build-cache-extension/pull/2 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > rename remote.cache.* properties to build.cache.* > - > > Key: MBUILDCACHE-13 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-13 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Herve Boutemy >Priority: Major > > current parameters are named "remote.cache.*": > https://maven.apache.org/extensions/maven-build-cache-extension/parameters.html > is it really restricted to remote build cache? Or just historical naming done > before we chose "build cache" as the keyword (instead of unclear "cache") -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MBUILDCACHE-13) rename remote.cache.* properties to build.cache.*
[ https://issues.apache.org/jira/browse/MBUILDCACHE-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated MBUILDCACHE-13: -- Labels: pull-request-available (was: ) > rename remote.cache.* properties to build.cache.* > - > > Key: MBUILDCACHE-13 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-13 > Project: Maven Build Cache Extension > Issue Type: Task >Reporter: Herve Boutemy >Priority: Major > Labels: pull-request-available > > current parameters are named "remote.cache.*": > https://maven.apache.org/extensions/maven-build-cache-extension/parameters.html > is it really restricted to remote build cache? Or just historical naming done > before we chose "build cache" as the keyword (instead of unclear "cache") -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SUREFIRE-1935) Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
[
https://issues.apache.org/jira/browse/SUREFIRE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1935:
---
Summary: Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
(was: forkCount > 1 disrupts the JupiterTestEngine life cycle )
> Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession
> -
>
> Key: SUREFIRE-1935
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1935
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, process forking
>Affects Versions: 3.0.0-M5
>Reporter: Emond Papegaaij
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: forkedtests.zip
>
>
> When running tests with forkCount > 1 on the JUnit 5 Platform, the
> {{JUnitPlatformProvider}} keeps restarting the entire launcher, causing the
> life cycle of the tests to change. When an {{Extension}} registers an
> expensive resource in the root store, this resource is now created over and
> over again for every test class. An example of such an {{Extension}} is the
> {{ArquillianExtension}}. The recreation of this resource causes the tests to
> create and destroy all containers associated with the test for every class,
> rather than once per fork.
> I've attached a very simple example project that contains 4 tests and a dummy
> extension that registers an object in the root store. The output clearly
> indicates the problem:
> {code}
> $ mvn surefire:test -DforkCount=1
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< nl.topicus:forkedtests
> >---
> [INFO] Building forkedtests 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-cli) @ forkedtests ---
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running nl.topicus.test.Test2
> Performing heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.021
> s - in nl.topicus.test.Test2
> [INFO] Running nl.topicus.test.Test1
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.001
> s - in nl.topicus.test.Test1
> [INFO] Running nl.topicus.test.Test3
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.002
> s - in nl.topicus.test.Test3
> [INFO] Running nl.topicus.test.Test4
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.001
> s - in nl.topicus.test.Test4
> Discarding heavy calculation
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 8.816 s
> [INFO] Finished at: 2021-08-13T12:50:40+02:00
> [INFO]
>
> {code}
> Compared to running with {{forkCount=2}} (notice how the heavy calculation is
> performed 4 times, where it should only run twice):
> {code}
> $ mvn surefire:test -DforkCount=2
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< nl.topicus:forkedtests
> >---
> [INFO] Building forkedtests 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-cli) @ forkedtests ---
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running nl.topicus.test.Test2
> [INFO] Running nl.topicus.test.Test1
> Performing heavy calculation
> Performing heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.025
> s - in nl.topicus.test.Test2
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.022
> s - in nl.topicus.test.Test1
> Discarding heavy calculation
> Discarding heavy calculation
> [INFO] Running nl.topicus.test.Test3
> [INFO] Running nl.topicus.test.Test4
> Performing heavy calculation
> Performing heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.002
> s - in nl.topicus.test.Test3
> Discarding heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.002
> s - in nl.topicus.test.Test4
> Discarding heavy calculation
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 4, Failures: 0, Errors: 0,
[GitHub] [maven-build-cache-extension] maximilian-novikov-db opened a new pull request #2: [MBUILDCACHE-13] rename remote.cache.* properties to maven.build.cache.*
maximilian-novikov-db opened a new pull request #2: URL: https://github.com/apache/maven-build-cache-extension/pull/2 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-1935) forkCount > 1 disrupts the JupiterTestEngine life cycle
[
https://issues.apache.org/jira/browse/SUREFIRE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1935:
---
Fix Version/s: 3.0.0-M6
> forkCount > 1 disrupts the JupiterTestEngine life cycle
>
>
> Key: SUREFIRE-1935
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1935
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, process forking
>Affects Versions: 3.0.0-M5
>Reporter: Emond Papegaaij
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: forkedtests.zip
>
>
> When running tests with forkCount > 1 on the JUnit 5 Platform, the
> {{JUnitPlatformProvider}} keeps restarting the entire launcher, causing the
> life cycle of the tests to change. When an {{Extension}} registers an
> expensive resource in the root store, this resource is now created over and
> over again for every test class. An example of such an {{Extension}} is the
> {{ArquillianExtension}}. The recreation of this resource causes the tests to
> create and destroy all containers associated with the test for every class,
> rather than once per fork.
> I've attached a very simple example project that contains 4 tests and a dummy
> extension that registers an object in the root store. The output clearly
> indicates the problem:
> {code}
> $ mvn surefire:test -DforkCount=1
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< nl.topicus:forkedtests
> >---
> [INFO] Building forkedtests 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-cli) @ forkedtests ---
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running nl.topicus.test.Test2
> Performing heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.021
> s - in nl.topicus.test.Test2
> [INFO] Running nl.topicus.test.Test1
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.001
> s - in nl.topicus.test.Test1
> [INFO] Running nl.topicus.test.Test3
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.002
> s - in nl.topicus.test.Test3
> [INFO] Running nl.topicus.test.Test4
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.001
> s - in nl.topicus.test.Test4
> Discarding heavy calculation
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 8.816 s
> [INFO] Finished at: 2021-08-13T12:50:40+02:00
> [INFO]
>
> {code}
> Compared to running with {{forkCount=2}} (notice how the heavy calculation is
> performed 4 times, where it should only run twice):
> {code}
> $ mvn surefire:test -DforkCount=2
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< nl.topicus:forkedtests
> >---
> [INFO] Building forkedtests 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-cli) @ forkedtests ---
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running nl.topicus.test.Test2
> [INFO] Running nl.topicus.test.Test1
> Performing heavy calculation
> Performing heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.025
> s - in nl.topicus.test.Test2
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.022
> s - in nl.topicus.test.Test1
> Discarding heavy calculation
> Discarding heavy calculation
> [INFO] Running nl.topicus.test.Test3
> [INFO] Running nl.topicus.test.Test4
> Performing heavy calculation
> Performing heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.002
> s - in nl.topicus.test.Test3
> Discarding heavy calculation
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.002
> s - in nl.topicus.test.Test4
> Discarding heavy calculation
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
