[jira] [Created] (MINDEXER-133) Reset the correct stream in IndexDataReader
Tamás Cservenák created MINDEXER-133: Summary: Reset the correct stream in IndexDataReader Key: MINDEXER-133 URL: https://issues.apache.org/jira/browse/MINDEXER-133 Project: Maven Indexer Issue Type: Bug Reporter: Tamás Cservenák Reset the correct stream in IndexDataReader -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-indexer] cstamas commented on a change in pull request #164: [MINDEXER-132] use Java 7 Files.createTempDirectory() API
cstamas commented on a change in pull request #164:
URL: https://github.com/apache/maven-indexer/pull/164#discussion_r797333856
##
File path:
indexer-core/src/main/java/org/apache/maven/index/updater/DefaultIndexUpdater.java
##
@@ -190,9 +191,7 @@ private Date loadIndexDirectory( final IndexUpdateRequest
updateRequest, final R
{
updateRequest.getIndexTempDir().mkdirs();
}
-File indexDir = File.createTempFile( remoteIndexFile, ".dir" ,
updateRequest.getIndexTempDir() );
-indexDir.delete();
-indexDir.mkdirs();
+File indexDir = Files.createTempDirectory(
updateRequest.getIndexTempDir().toPath(), remoteIndexFile ).toFile();
Review comment:
updateRequest.getIndexTempDir() is nullable, above is nullcheck
performed. Better make `File indexDir` above IF and then update it in IF (add
ELSE as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-indexer] hboutemy opened a new pull request #164: [MINDEXER-132] use Java 7 Files.createTempDirectory() API
hboutemy opened a new pull request #164: URL: https://github.com/apache/maven-indexer/pull/164 https://issues.apache.org/jira/browse/MINDEXER-132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINDEXER-132) use Files.createTempDirectory(...) instead of custom code around File.createTempFile(...)
Herve Boutemy created MINDEXER-132: -- Summary: use Files.createTempDirectory(...) instead of custom code around File.createTempFile(...) Key: MINDEXER-132 URL: https://issues.apache.org/jira/browse/MINDEXER-132 Project: Maven Indexer Issue Type: Improvement Affects Versions: 6.0.0 Reporter: Herve Boutemy Fix For: 6.0.1 since Java 7, a perfect API for temp directory creation was introduced: let's use it -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (MINDEXER-122) Add getName() to Record.EntryKey
[
https://issues.apache.org/jira/browse/MINDEXER-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy reassigned MINDEXER-122:
--
Assignee: Sylwester Lachiewicz
> Add getName() to Record.EntryKey
>
>
> Key: MINDEXER-122
> URL: https://issues.apache.org/jira/browse/MINDEXER-122
> Project: Maven Indexer
> Issue Type: Improvement
>Reporter: Stephen Buergler
>Assignee: Sylwester Lachiewicz
>Priority: Trivial
> Fix For: 6.0.1
>
>
> Currently I'm doing this to pull the name field out of EntryKey
> {code:java}
> @SneakyThrows
> private static MethodHandle entryKeyNameField() {
> return MethodHandles.privateLookupIn(EntryKey.class,
> MethodHandles.lookup())
> .findGetter(EntryKey.class, "name", String.class);
> }
> private static final MethodHandle entryKeyNameField = entryKeyNameField();
> @SneakyThrows
> static String getName(EntryKey entryKey) {
> return (String) entryKeyNameField.invokeExact(entryKey);
> }
> {code}
> It would be nice if getName() was a method on EntryKey itself.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (MINDEXER-123) Fix an InputStream leak in indexer-reader Utils
[
https://issues.apache.org/jira/browse/MINDEXER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy reassigned MINDEXER-123:
--
Assignee: Enrico Olivelli
> Fix an InputStream leak in indexer-reader Utils
> ---
>
> Key: MINDEXER-123
> URL: https://issues.apache.org/jira/browse/MINDEXER-123
> Project: Maven Indexer
> Issue Type: Bug
>Reporter: Stephen Buergler
>Assignee: Enrico Olivelli
>Priority: Trivial
> Fix For: 6.0.1
>
>
> There is a leak of an InputReader in Utils.
> {code:java}
> /**
> * Creates and loads {@link Properties} from provided {@link Resource} if
> exists, and closes the resource. If not
> * exists, returns {@code null}.
> */
> public static Properties loadProperties( final Resource resource )
> throws IOException
> {
> final InputStream inputStream = resource.read();
> if ( inputStream == null )
> {
> return null;
> }
> return loadProperties( resource.read() );
> }
> {code}
> Depending on how the Resource is implemented this probably leaks the
> InputStream returned by the first .read() call. I'm under the understanding
> that .read() should return a new InputStream every time it is called but I
> don't have any evidence that that is true other than that's how the Resource
> in the unit test is implemented.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-checkstyle-plugin] slachiewicz merged pull request #63: Bump build-helper-maven-plugin from 3.2.0 to 3.3.0
slachiewicz merged pull request #63: URL: https://github.com/apache/maven-checkstyle-plugin/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz merged pull request #65: Bump animal-sniffer-maven-plugin from 1.20 to 1.21
slachiewicz merged pull request #65: URL: https://github.com/apache/maven-checkstyle-plugin/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] dependabot[bot] opened a new pull request #65: Bump animal-sniffer-maven-plugin from 1.20 to 1.21
dependabot[bot] opened a new pull request #65: URL: https://github.com/apache/maven-checkstyle-plugin/pull/65 Bumps [animal-sniffer-maven-plugin](https://github.com/mojohaus/animal-sniffer) from 1.20 to 1.21. Release notes Sourced from https://github.com/mojohaus/animal-sniffer/releases";>animal-sniffer-maven-plugin's releases. 1.21.0 🚀 New features and improvements Cache signatures so that multiple runs of the mojo can reuse loaded signatures (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/165";>#165) https://github.com/gnodet";>@gnodet 🐛 Bug Fixes Remove incorrect handling of covariant return types (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/83";>#83) https://github.com/ogolberg";>@ogolberg 📦 Dependency updates Bump maven-plugin-annotations from 3.6.2 to 3.6.4 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/188";>#188) https://github.com/dependabot";>@dependabot Bump maven-plugin-plugin from 3.6.2 to 3.6.4 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/189";>#189) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.17.6 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/190";>#190) https://github.com/dependabot";>@dependabot Bump build-helper-maven-plugin from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/185";>#185) https://github.com/dependabot";>@dependabot Bump plexus-container-default from 2.1.0 to 2.1.1 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/184";>#184) https://github.com/dependabot";>@dependabot Bump maven-plugin-plugin from 3.6.1 to 3.6.2 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/183";>#183) https://github.com/dependabot";>@dependabot Bump maven-plugin-annotations from 3.6.1 to 3.6.2 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/182";>#182) https://github.com/dependabot";>@dependabot Bump junit from 4.13 to 4.13.1 in /animal-sniffer-maven-plugin/src/it/github-5-test-classes (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/180";>#180) https://github.com/dependabot";>@dependabot Bump mojo-parent from 63 to 65 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/181";>#181) https://github.com/dependabot";>@dependabot Bump ant from 1.10.11 to 1.10.12 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/177";>#177) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump plexus-utils from 3.4.0 to 3.4.1 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/174";>#174) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.2.0 to 2.3.0 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/173";>#173) https://github.com/dependabot";>@dependabot Bump maven-enforcer-plugin from 3.0.0-M3 to 3.0.0 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/169";>#169) https://github.com/dependabot";>@dependabot Bump enforcer-api from 1.4.1 to 3.0.0 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/170";>#170) https://github.com/dependabot";>@dependabot Bump plexus-utils from 3.3.0 to 3.4.0 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/168";>#168) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.1.0 to 2.2.0 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/171";>#171) https://github.com/dependabot";>@dependabot Bump asm from 9.1 to 9.2 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/166";>#166) https://github.com/dependabot";>@dependabot Bump ant from 1.10.10 to 1.10.11 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/167";>#167) https://github.com/dependabot";>@dependabot Bump maven-plugin-plugin from 3.6.0 to 3.6.1 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/157";>#157) https://github.com/dependabot";>@dependabot Bump maven-plugin-annotations from 3.6.0 to 3.6.1 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/158";>#158) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 1 to 2.1.0 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/161";>#161) https://github.com/dependabot";>@dependabot Bump httpclient from 4.1.1 to 4.5.13 in /animal-sniffer-maven-plugin/src/it/manimalsniffer-6 (https://github-redirect.dependabot.com/mojohaus/animal-sniffer/issues/164";>#164) https://github.com/dependabot";>@dependabot Bump actions/cache from 2.
[GitHub] [maven] laeubi opened a new pull request #673: [3.8.x][MNG-7395] - Support system-properties in extension.xml
laeubi opened a new pull request #673: URL: https://github.com/apache/maven/pull/673 This is a back-port of https://github.com/apache/maven/pull/665 to Maven 3.8.x This adds support for having basic interpolation in `.mvn/extensions.xml` to either: 1. Specify a (default) version in `.mvn/jvm.config` 2. Specify a version on the commandline with `mvn -D=some.version=1.2.3` Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/MNG/issues/MNG-7395) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #92: Bump maven-plugin-plugin from 3.6.2 to 3.6.4
dependabot[bot] opened a new pull request #92: URL: https://github.com/apache/maven-jlink-plugin/pull/92 Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.6.2 to 3.6.4. Commits https://github.com/apache/maven-plugin-tools/commit/33eb6d9df8be0e9cd0ac9b684741382b3d0e0fc7";>33eb6d9 [maven-release-plugin] prepare release maven-plugin-tools-3.6.4 https://github.com/apache/maven-plugin-tools/commit/c8ddcdcb10d342a5a5e2f38245bb569af5730c7c";>c8ddcdc [MPLUGIN-387] Bump Ant to 1.9.16 https://github.com/apache/maven-plugin-tools/commit/f14830dba00667fc661a520557fcdff6a8b0d1ad";>f14830d [MPLUGIN-387] Bump xmlunit to 1.6 https://github.com/apache/maven-plugin-tools/commit/036fdebb5cdbab68d79550cc6a0991f2a96ce4c8";>036fdeb [MPLUGIN-387] Bump plexus-compiler-manager to 2.8.8 https://github.com/apache/maven-plugin-tools/commit/d296e04045026716f1fba5d296a0dd4330cc7f92";>d296e04 [MPLUGIN-387] Switch from fest-assert to AssertJ 2.9.1 https://github.com/apache/maven-plugin-tools/commit/9ff352cc5680fe4e672dd99d0ff9160fc51a1317";>9ff352c [MPLUGIN-387] Bump plexus-archiver to 4.2.5 https://github.com/apache/maven-plugin-tools/commit/f6461047666e7c2dc0103042088825fd6a16a8ab";>f646104 [MPLUGIN-387] Upgrade BeanShell to 2.0b6 https://github.com/apache/maven-plugin-tools/commit/db1803198a77a40917a533e70ece7f066b783bf1";>db18031 [MPLUGIN-387] Bump junit to 4.13.2 https://github.com/apache/maven-plugin-tools/commit/c7ae057613aab21957197f93d33d6c0e2eb55bf8";>c7ae057 Added Dependabot configuration https://github.com/apache/maven-plugin-tools/commit/86d870fbc4a3aa1cd3b8da8a2fde015e5e8dfe43";>86d870f [MPLUGIN-387] Upgrade Doxia/Doxia Tools to 1.11.1 Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.2...maven-plugin-tools-3.6.4";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] dependabot[bot] opened a new pull request #46: Bump mavenPluginToolsVersion from 3.6.2 to 3.6.4
dependabot[bot] opened a new pull request #46: URL: https://github.com/apache/maven-parent/pull/46 Bumps `mavenPluginToolsVersion` from 3.6.2 to 3.6.4. Updates `maven-plugin-annotations` from 3.6.2 to 3.6.4 Commits https://github.com/apache/maven-plugin-tools/commit/33eb6d9df8be0e9cd0ac9b684741382b3d0e0fc7";>33eb6d9 [maven-release-plugin] prepare release maven-plugin-tools-3.6.4 https://github.com/apache/maven-plugin-tools/commit/c8ddcdcb10d342a5a5e2f38245bb569af5730c7c";>c8ddcdc [MPLUGIN-387] Bump Ant to 1.9.16 https://github.com/apache/maven-plugin-tools/commit/f14830dba00667fc661a520557fcdff6a8b0d1ad";>f14830d [MPLUGIN-387] Bump xmlunit to 1.6 https://github.com/apache/maven-plugin-tools/commit/036fdebb5cdbab68d79550cc6a0991f2a96ce4c8";>036fdeb [MPLUGIN-387] Bump plexus-compiler-manager to 2.8.8 https://github.com/apache/maven-plugin-tools/commit/d296e04045026716f1fba5d296a0dd4330cc7f92";>d296e04 [MPLUGIN-387] Switch from fest-assert to AssertJ 2.9.1 https://github.com/apache/maven-plugin-tools/commit/9ff352cc5680fe4e672dd99d0ff9160fc51a1317";>9ff352c [MPLUGIN-387] Bump plexus-archiver to 4.2.5 https://github.com/apache/maven-plugin-tools/commit/f6461047666e7c2dc0103042088825fd6a16a8ab";>f646104 [MPLUGIN-387] Upgrade BeanShell to 2.0b6 https://github.com/apache/maven-plugin-tools/commit/db1803198a77a40917a533e70ece7f066b783bf1";>db18031 [MPLUGIN-387] Bump junit to 4.13.2 https://github.com/apache/maven-plugin-tools/commit/c7ae057613aab21957197f93d33d6c0e2eb55bf8";>c7ae057 Added Dependabot configuration https://github.com/apache/maven-plugin-tools/commit/86d870fbc4a3aa1cd3b8da8a2fde015e5e8dfe43";>86d870f [MPLUGIN-387] Upgrade Doxia/Doxia Tools to 1.11.1 Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.2...maven-plugin-tools-3.6.4";>compare view Updates `maven-plugin-plugin` from 3.6.2 to 3.6.4 Commits https://github.com/apache/maven-plugin-tools/commit/33eb6d9df8be0e9cd0ac9b684741382b3d0e0fc7";>33eb6d9 [maven-release-plugin] prepare release maven-plugin-tools-3.6.4 https://github.com/apache/maven-plugin-tools/commit/c8ddcdcb10d342a5a5e2f38245bb569af5730c7c";>c8ddcdc [MPLUGIN-387] Bump Ant to 1.9.16 https://github.com/apache/maven-plugin-tools/commit/f14830dba00667fc661a520557fcdff6a8b0d1ad";>f14830d [MPLUGIN-387] Bump xmlunit to 1.6 https://github.com/apache/maven-plugin-tools/commit/036fdebb5cdbab68d79550cc6a0991f2a96ce4c8";>036fdeb [MPLUGIN-387] Bump plexus-compiler-manager to 2.8.8 https://github.com/apache/maven-plugin-tools/commit/d296e04045026716f1fba5d296a0dd4330cc7f92";>d296e04 [MPLUGIN-387] Switch from fest-assert to AssertJ 2.9.1 https://github.com/apache/maven-plugin-tools/commit/9ff352cc5680fe4e672dd99d0ff9160fc51a1317";>9ff352c [MPLUGIN-387] Bump plexus-archiver to 4.2.5 https://github.com/apache/maven-plugin-tools/commit/f6461047666e7c2dc0103042088825fd6a16a8ab";>f646104 [MPLUGIN-387] Upgrade BeanShell to 2.0b6 https://github.com/apache/maven-plugin-tools/commit/db1803198a77a40917a533e70ece7f066b783bf1";>db18031 [MPLUGIN-387] Bump junit to 4.13.2 https://github.com/apache/maven-plugin-tools/commit/c7ae057613aab21957197f93d33d6c0e2eb55bf8";>c7ae057 Added Dependabot configuration https://github.com/apache/maven-plugin-tools/commit/86d870fbc4a3aa1cd3b8da8a2fde015e5e8dfe43";>86d870f [MPLUGIN-387] Upgrade Doxia/Doxia Tools to 1.11.1 Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.2...maven-plugin-tools-3.6.4";>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade
[jira] [Resolved] (MCOMPILER-482) JPMS regression: optional transitive module is not found
[
https://issues.apache.org/jira/browse/MCOMPILER-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy resolved MCOMPILER-482.
Resolution: Fixed
PR merged
SNAPSHOT deployed
> JPMS regression: optional transitive module is not found
>
>
> Key: MCOMPILER-482
> URL: https://issues.apache.org/jira/browse/MCOMPILER-482
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Martin Tzvetanov Grigorov
>Assignee: Olivier Lamy
>Priority: Minor
>
> Apache Wicket's build fails with maven-compiler-plugin:3.9.0:
>
> {code:java}
> [INFO] --- maven-compiler-plugin:3.9.0:compile (default-compile) @
> wicket-core ---
> [WARNING]
>
> [WARNING] * Required filename-based automodules detected:
> [commons-fileupload2-2.0-SNAPSHOT.jar]. Please don't publish this project to
> a public artifact repository! *
> [WARNING]
>
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 836 source files to
> /home/martin/git/apache/wicket/wicket-core/target/classes
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] module not found: org.apiguardian.api
> [INFO] 1 error
> [INFO] -
> {code}
>
> Wicket-core module depends on JUnit Jupiter API:
> [https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/module-info.java#L31]
> and apiguardian comes as a transitive dependency of it.
>
> To reproduce:
> 1) git clone [https://github.com/apache/wicket.git]
> 2) edit pom.xml (line 195) to change the version of maven-compiler-plugin
> from 3.8.1 to 3.9.0
> 3) export JAVA_HOME=/path/to/jdk-17 (also you need to have an entry for JDK
> 17 in ~/.m2/toolchains.xml)
> 4) mvn verify
>
> https://issues.apache.org/jira/browse/MCOMPILER-481 looks similar but I am
> not sure it is the same!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (MCOMPILER-481) JPMS Regression: cannot access (requires static module not include anymore)
[
https://issues.apache.org/jira/browse/MCOMPILER-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy resolved MCOMPILER-481.
Resolution: Fixed
PR merge
> JPMS Regression: cannot access (requires static module not include
> anymore)
> ---
>
> Key: MCOMPILER-481
> URL: https://issues.apache.org/jira/browse/MCOMPILER-481
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Simone Bordet
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: compiler-bug.tar.gz
>
>
> Version 3.8.1 is not affected.
> The problem lies in how the module-path is constructed by the
> maven-compiler-plugin – not sure what changes from 3.8.1 caused this.
> In 3.8.1:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> In 3.9.0:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> Running with 3.9.0 yields:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project compiler-bug-app: Compilation failure
> [ERROR]
> /home/simon/tmp/compiler-bug/app/src/test/java/org/test/app/MainTest.java:[12,38]
> cannot access org.eclipse.jetty.util.ajax.JSON
> [ERROR] class file for org.eclipse.jetty.util.ajax.JSON not found {code}
> Class {{JSON}} is in {{{}jetty-util-10.0.7.jar{}}}.
> In 3.9.0 this jar is missing from the module-path, causing the error.
> Attached you can find a reproducer: switch the maven-compiler-plugin version
> from 3.8.1 (works) to 3.9.0 (does not work) in the main POM.
--
This message was sent by Atlassian Jira
(v8.
[GitHub] [maven-compiler-plugin] olamy merged pull request #82: [MCOMPILER-481] compiler plugin should include static module for compilation
olamy merged pull request #82: URL: https://github.com/apache/maven-compiler-plugin/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MDEP-779) dependency:analyze should list the classes that cause a used undeclared dependency
[
https://issues.apache.org/jira/browse/MDEP-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MDEP-779.
Resolution: Fixed
> dependency:analyze should list the classes that cause a used undeclared
> dependency
> --
>
> Key: MDEP-779
> URL: https://issues.apache.org/jira/browse/MDEP-779
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: analyze-dep-mgt
>Reporter: Joseph Walton
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> When {{dependency:analyze}} shows that a module has used classes from an
> undeclared dependency, it may not be clear which classes are involved. In
> particular, on large projects where modules and packages don't have a clear
> 1:1 relationship.
> It would be useful if there was (opt-in?) display of the classes involved.
> This could make it significantly quicker to identify the specific issue
> without switching to another tool.
> For example:
> {noformat}
> [WARNING] Used undeclared dependencies found:
> [WARNING]xml-apis:xml-apis:jar:1.0.b2:compile
> [WARNING]class org.apache.xmlcommons.Version
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (MDEP-779) dependency:analyze should list the classes that cause a used undeclared dependency
[
https://issues.apache.org/jira/browse/MDEP-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MDEP-779:
Assignee: Slawomir Jaranowski (was: Sylwester Lachiewicz)
> dependency:analyze should list the classes that cause a used undeclared
> dependency
> --
>
> Key: MDEP-779
> URL: https://issues.apache.org/jira/browse/MDEP-779
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: analyze-dep-mgt
>Reporter: Joseph Walton
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> When {{dependency:analyze}} shows that a module has used classes from an
> undeclared dependency, it may not be clear which classes are involved. In
> particular, on large projects where modules and packages don't have a clear
> 1:1 relationship.
> It would be useful if there was (opt-in?) display of the classes involved.
> This could make it significantly quicker to identify the specific issue
> without switching to another tool.
> For example:
> {noformat}
> [WARNING] Used undeclared dependencies found:
> [WARNING]xml-apis:xml-apis:jar:1.0.b2:compile
> [WARNING]class org.apache.xmlcommons.Version
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #178: MDEP-779 show class names used in undeclared dependencies
slawekjaranowski merged pull request #178: URL: https://github.com/apache/maven-dependency-plugin/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1024) Replace deprecated code
[
https://issues.apache.org/jira/browse/MSHARED-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485478#comment-17485478
]
Hudson commented on MSHARED-1024:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-api » master #50
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-api/job/master/50/
> Replace deprecated code
> ---
>
> Key: MSHARED-1024
> URL: https://issues.apache.org/jira/browse/MSHARED-1024
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-reporting-api
>Affects Versions: maven-reporting-api-3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-3.1.0
>
>
> * Codehaus Doxia Sink interface is deprecated and have been replaced with
> Maven Doxia Sink interface a long time ago
> * {{$\{reports\}}} is deprecated and will fail with the next major version
> Doxia with {{}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MSHARED-1032) API change: let canGenerateReport() throw an Exception
[
https://issues.apache.org/jira/browse/MSHARED-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSHARED-1032:
Fix Version/s: (was: maven-reporting-api-3.1.0)
> API change: let canGenerateReport() throw an Exception
> --
>
> Key: MSHARED-1032
> URL: https://issues.apache.org/jira/browse/MSHARED-1032
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-api
>Affects Versions: maven-reporting-api-3.0
>Reporter: Benjamin Marwell
>Priority: Major
>
> Hi everyone,
> the [`{{AbstractReportMojo}}` in
> reporting-impl|https://maven.apache.org/shared/maven-reporting-impl/apidocs/org/apache/maven/reporting/AbstractMavenReport.html]
> implements a method [`{{canGenerateReport()}}` from
> reporting-api|https://maven.apache.org/shared/maven-reporting-api/apidocs/org/apache/maven/reporting/MavenReport.html].
> However, it is unable to throw any exceptions. Not even {{MojoExecutionEx}}
> or {{{}MavenReportEx{}}}, which is most unfortunate.
> It is being used twice:
> Once in {{execute() throws MojoExEx}}
> and in
> {{generate() throws MavenReportEx}} (and is called by execute()).
> This way, there is no way for reporting plugins to scan for files, because
> {{FileUtils::getFiles}} DOES throw a {{{}IOException{}}}, which then cannot
> be wrapped. However, the {{IOException}} from that method is useless anyway,
> because it is never declared in any methods it calls.
> Therefore please consider:
> * Declaring any Exception on `{{{}canGenerateReports(){}}}`
> * Removing the declared {{IOException}} in PlexusUtils ([PR
> exists|https://github.com/codehaus-plexus/plexus-utils/issues/180]) and
> Maven-Utils (issue: tbd).
> Thanks!
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MSHARED-1024) Replace deprecated code
[
https://issues.apache.org/jira/browse/MSHARED-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MSHARED-1024.
---
Resolution: Fixed
Fixed with
[35fc61e158aef235c2b7760e53c6d05c0529ab54|https://gitbox.apache.org/repos/asf?p=maven-reporting-api.git;a=commit;h=35fc61e158aef235c2b7760e53c6d05c0529ab54].
> Replace deprecated code
> ---
>
> Key: MSHARED-1024
> URL: https://issues.apache.org/jira/browse/MSHARED-1024
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-reporting-api
>Affects Versions: maven-reporting-api-3.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-3.1.0
>
>
> * Codehaus Doxia Sink interface is deprecated and have been replaced with
> Maven Doxia Sink interface a long time ago
> * {{$\{reports\}}} is deprecated and will fail with the next major version
> Doxia with {{}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-reporting-api] asfgit closed pull request #2: [MSHARED-1024] Replace deprecated code
asfgit closed pull request #2: URL: https://github.com/apache/maven-reporting-api/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7406) Strange formatting of warning/errors from project building
[
https://issues.apache.org/jira/browse/MNG-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485471#comment-17485471
]
Michael Osipov commented on MNG-7406:
-
Repeating stuff is a common problem everywhere it Maven. Dreaded:
{noformat}
throw Exception("Shit happened: " + e.getMessage(), e);
{noformat}
> Strange formatting of warning/errors from project building
> --
>
> Key: MNG-7406
> URL: https://issues.apache.org/jira/browse/MNG-7406
> Project: Maven
> Issue Type: Improvement
> Components: Errors
>Affects Versions: 4.0.x-candidate
>Reporter: Maarten Mulders
>Assignee: Maarten Mulders
>Priority: Minor
> Fix For: 4.0.0-alpha-1
>
> Attachments: image.png
>
>
> If Maven finds an error while building the model, it throws a
> {{{}ProjectBuildingException{}}}. When that makes it to the CLI, it is
> printed in a bit strange way:
> !image.png!
> Note how the message reads:
> {code:java}
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project foo:bar:1.0-SNAPSHOT (/private/tmp/ner/bar/pom.xml) has
> 1 error
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] {code}
> # It contains a severity marker *twice*
> # It repeats the error/warning message
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-invoker-plugin] michael-o merged pull request #96: Use localized format to avoid space before colon in English
michael-o merged pull request #96: URL: https://github.com/apache/maven-invoker-plugin/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] pzygielo commented on pull request #96: Use localized format to avoid space before colon in English
pzygielo commented on pull request #96: URL: https://github.com/apache/maven-invoker-plugin/pull/96#issuecomment-1027152024 I suppose IT https://github.com/apache/maven-invoker-plugin/blob/e7fd10daab1e5c5282a1b2e30b152edd0558bbab/src/it/invoker-report/pom.xml#L26 kind of shows the (tiny) difference | before | after | |-|-| |  |  | Not sure if it deserves the update (it would need to consider localization I think). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] ibabiankou closed pull request #142: [MRESOLVER-7] Download dependency POMs in parallel
ibabiankou closed pull request #142: URL: https://github.com/apache/maven-resolver/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] ibabiankou commented on pull request #142: [MRESOLVER-7] Download dependency POMs in parallel
ibabiankou commented on pull request #142: URL: https://github.com/apache/maven-resolver/pull/142#issuecomment-1027133750 @Tibor17 Thanks for pointing this out, however, I'm a bit puzzled as I don't see a good alternative here 🤔 Do you have any ideas from the top of your head? @cstamas The plan is to first focus on reviewing and merging #144, then work on either this one or #136. I'll close this one for now and re-open or open another one later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #668: [3.8.x][MNG-7400] - Allow more WorkspaceReader's to participate
gnodet commented on pull request #668: URL: https://github.com/apache/maven/pull/668#issuecomment-1027095681 @michael-o is the release manager for 3.8.x branch, so I'll defer to him -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] laeubi commented on pull request #668: [3.8.x][MNG-7400] - Allow more WorkspaceReader's to participate
laeubi commented on pull request #668: URL: https://github.com/apache/maven/pull/668#issuecomment-1027073568 @gnodet anything left here to do until it could be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] pzygielo commented on pull request #96: Use localized format to avoid space before colon in English
pzygielo commented on pull request #96: URL: https://github.com/apache/maven-invoker-plugin/pull/96#issuecomment-1027069254 > If you see this, you know it has been a Frenchman. Now I do, indeed. Before - I had no idea about such rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #672: [MNG-7406] Better display of project building errors
michael-o commented on pull request #672: URL: https://github.com/apache/maven/pull/672#issuecomment-1027022647 Interesting, will happily review next couple of days... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] michael-o commented on pull request #96: Use localized format to avoid space before colon in English
michael-o commented on pull request #96: URL: https://github.com/apache/maven-invoker-plugin/pull/96#issuecomment-1027021968 If you see this, you know it has been a Frenchman. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders opened a new pull request #672: [MNG-7406] Better display of project building errors
mthmulders opened a new pull request #672: URL: https://github.com/apache/maven/pull/672 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [MNG-7406](https://issues.apache.org/jira/browse/MNG-7406) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the [Core IT][core-its] successfully - running them on GitHub Actions as a line of first defence. ICLA and CCLA signed. [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7406) Strange formatting of warning/errors from project building
[
https://issues.apache.org/jira/browse/MNG-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485319#comment-17485319
]
Maarten Mulders commented on MNG-7406:
--
The issue is caused by two things:
# the {{ProjectBuildingException}} formats its contained information (a list of
{{ProjectBuildingResult}} objects) and stores it _in its message_
# the {{DefaultMaven}} prints the {{ProjectBuildingResult}} objects using
their {{toString}} (including severity and, when available, location info)
> Strange formatting of warning/errors from project building
> --
>
> Key: MNG-7406
> URL: https://issues.apache.org/jira/browse/MNG-7406
> Project: Maven
> Issue Type: Improvement
> Components: Errors
>Affects Versions: 4.0.x-candidate
>Reporter: Maarten Mulders
>Assignee: Maarten Mulders
>Priority: Minor
> Fix For: 4.0.0-alpha-1
>
> Attachments: image.png
>
>
> If Maven finds an error while building the model, it throws a
> {{{}ProjectBuildingException{}}}. When that makes it to the CLI, it is
> printed in a bit strange way:
> !image.png!
> Note how the message reads:
> {code:java}
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project foo:bar:1.0-SNAPSHOT (/private/tmp/ner/bar/pom.xml) has
> 1 error
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] {code}
> # It contains a severity marker *twice*
> # It repeats the error/warning message
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRESOLVER-238) Create shaded transport-http
[ https://issues.apache.org/jira/browse/MRESOLVER-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485315#comment-17485315 ] Tamás Cservenák commented on MRESOLVER-238: --- Tested: * core extension HAS access to included (non-shaded) http-client * build extension and mojo HAS NOT access to included (non-shaded) http-client Hence, this works as expected. > Create shaded transport-http > > > Key: MRESOLVER-238 > URL: https://issues.apache.org/jira/browse/MRESOLVER-238 > Project: Maven Resolver > Issue Type: Task >Reporter: Tamás Cservenák >Priority: Major > > Very similarly as we have wagon-http with shaded in httpClient and > commons-coded. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MNG-7406) Strange formatting of warning/errors from project building
[
https://issues.apache.org/jira/browse/MNG-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Mulders updated MNG-7406:
-
Description:
If Maven finds an error while building the model, it throws a
{{{}ProjectBuildingException{}}}. When that makes it to the CLI, it is printed
in a bit strange way:
!image.png!
Note how the message reads:
{code:java}
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] The expression ${pom.organization.name} is no longer supported. Please
use ${project.organization.name} instead.
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project foo:bar:1.0-SNAPSHOT (/private/tmp/ner/bar/pom.xml) has 1
error
[ERROR] The expression ${pom.organization.name} is no longer supported.
Please use ${project.organization.name} instead.
[ERROR] {code}
# It contains a severity marker *twice*
# It repeats the error/warning message
was:
If Maven finds an error while building the model, it throws a
{{{}ProjectBuildingException{}}}. When that makes it to the CLI, it is printed
in a bit strange way:
!image.png!
Note how the message reads:
{code:java}
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] The expression ${pom.organization.name} is no longer supported. Please
use ${project.organization.name} instead.
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project foo:bar:1.0-SNAPSHOT (/private/tmp/ner/bar/pom.xml) has 1
error
[ERROR] The expression ${pom.organization.name} is no longer supported.
Please use ${project.organization.name} instead.
[ERROR] {code}
1. It contains a severity marker *twice*
1. It repeats the error/warning message
> Strange formatting of warning/errors from project building
> --
>
> Key: MNG-7406
> URL: https://issues.apache.org/jira/browse/MNG-7406
> Project: Maven
> Issue Type: Improvement
> Components: Errors
>Affects Versions: 4.0.x-candidate
>Reporter: Maarten Mulders
>Assignee: Maarten Mulders
>Priority: Minor
> Fix For: 4.0.0-alpha-1
>
> Attachments: image.png
>
>
> If Maven finds an error while building the model, it throws a
> {{{}ProjectBuildingException{}}}. When that makes it to the CLI, it is
> printed in a bit strange way:
> !image.png!
> Note how the message reads:
> {code:java}
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project foo:bar:1.0-SNAPSHOT (/private/tmp/ner/bar/pom.xml) has
> 1 error
> [ERROR] The expression ${pom.organization.name} is no longer supported.
> Please use ${project.organization.name} instead.
> [ERROR] {code}
> # It contains a severity marker *twice*
> # It repeats the error/warning message
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MNG-7406) Strange formatting of warning/errors from project building
Maarten Mulders created MNG-7406:
Summary: Strange formatting of warning/errors from project building
Key: MNG-7406
URL: https://issues.apache.org/jira/browse/MNG-7406
Project: Maven
Issue Type: Improvement
Components: Errors
Affects Versions: 4.0.x-candidate
Reporter: Maarten Mulders
Assignee: Maarten Mulders
Fix For: 4.0.0-alpha-1
Attachments: image.png
If Maven finds an error while building the model, it throws a
{{{}ProjectBuildingException{}}}. When that makes it to the CLI, it is printed
in a bit strange way:
!image.png!
Note how the message reads:
{code:java}
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] The expression ${pom.organization.name} is no longer supported. Please
use ${project.organization.name} instead.
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project foo:bar:1.0-SNAPSHOT (/private/tmp/ner/bar/pom.xml) has 1
error
[ERROR] The expression ${pom.organization.name} is no longer supported.
Please use ${project.organization.name} instead.
[ERROR] {code}
1. It contains a severity marker *twice*
1. It repeats the error/warning message
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-resolver] michael-o commented on pull request #149: [MRESOLVER-238] Create shaded transport-http
michael-o commented on pull request #149: URL: https://github.com/apache/maven-resolver/pull/149#issuecomment-1026887457 50 Shades of Resolver... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-238) Create shaded transport-http
[ https://issues.apache.org/jira/browse/MRESOLVER-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MRESOLVER-238. - Resolution: Won't Fix Not doing this, as this is wrong. Maven - if it leaks - should prevent it leaking. > Create shaded transport-http > > > Key: MRESOLVER-238 > URL: https://issues.apache.org/jira/browse/MRESOLVER-238 > Project: Maven Resolver > Issue Type: Task >Reporter: Tamás Cservenák >Priority: Major > > Very similarly as we have wagon-http with shaded in httpClient and > commons-coded. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MRESOLVER-238) Create shaded transport-http
[ https://issues.apache.org/jira/browse/MRESOLVER-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-238: -- Fix Version/s: (was: 1.8.0) > Create shaded transport-http > > > Key: MRESOLVER-238 > URL: https://issues.apache.org/jira/browse/MRESOLVER-238 > Project: Maven Resolver > Issue Type: Task >Reporter: Tamás Cservenák >Priority: Major > > Very similarly as we have wagon-http with shaded in httpClient and > commons-coded. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-resolver] cstamas closed pull request #149: [MRESOLVER-238] Create shaded transport-http
cstamas closed pull request #149: URL: https://github.com/apache/maven-resolver/pull/149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #149: [MRESOLVER-238] Create shaded transport-http
cstamas commented on pull request #149: URL: https://github.com/apache/maven-resolver/pull/149#issuecomment-1026881288 Nope, not doing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #149: [MRESOLVER-238] Create shaded transport-http
cstamas commented on pull request #149: URL: https://github.com/apache/maven-resolver/pull/149#issuecomment-1026874526 Am really unsure do we want this. Originally wagon-http had shaded in http-client to not pollute plugins classpath. But this -- in case of transport-http -- would also prevent extension/addition of ChecksumExtractor as it uses http-client classes... Hence, as "pollution" issue will be gone with maven-core-api, I think this can wait... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet opened a new pull request #671: [MNG-7405] Update animal-sniffer to 1.21
gnodet opened a new pull request #671: URL: https://github.com/apache/maven/pull/671 This saves quite some time on the build. https://issues.apache.org/jira/browse/MNG-7405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7405) Update animal-sniffer to 1.21
Guillaume Nodet created MNG-7405: Summary: Update animal-sniffer to 1.21 Key: MNG-7405 URL: https://issues.apache.org/jira/browse/MNG-7405 Project: Maven Issue Type: Improvement Affects Versions: 4.0.0-alpha-1 Reporter: Guillaume Nodet Assignee: Guillaume Nodet -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MRESOLVER-238) Create shaded transport-http
[ https://issues.apache.org/jira/browse/MRESOLVER-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485256#comment-17485256 ] Tamás Cservenák commented on MRESOLVER-238: --- Am actually unsure is this is right thing to do... What is the problem with having http-client in maven $LIB? > Create shaded transport-http > > > Key: MRESOLVER-238 > URL: https://issues.apache.org/jira/browse/MRESOLVER-238 > Project: Maven Resolver > Issue Type: Task >Reporter: Tamás Cservenák >Priority: Major > Fix For: 1.8.0 > > > Very similarly as we have wagon-http with shaded in httpClient and > commons-coded. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-resolver] cstamas opened a new pull request #149: [MRESOLVER-238] Create shaded transport-http
cstamas opened a new pull request #149: URL: https://github.com/apache/maven-resolver/pull/149 That looks very same to that of wagon-http. --- https://issues.apache.org/jira/browse/MRESOLVER-238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRESOLVER-238) Create shaded transport-http
Tamás Cservenák created MRESOLVER-238: - Summary: Create shaded transport-http Key: MRESOLVER-238 URL: https://issues.apache.org/jira/browse/MRESOLVER-238 Project: Maven Resolver Issue Type: Task Reporter: Tamás Cservenák Fix For: 1.8.0 Very similarly as we have wagon-http with shaded in httpClient and commons-coded. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven] gnodet closed pull request #427: [MNG-6727] Changed expression check to project.version and project.parent.version
gnodet closed pull request #427: URL: https://github.com/apache/maven/pull/427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-6727) Using version range in parent and CI Friendly Version fails
[
https://issues.apache.org/jira/browse/MNG-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-6727.
Resolution: Fixed
Fixed with
[https://github.com/apache/maven/commit/d79485ff23c9017d47424ff24da1d6dd3c414a60]
and
[https://github.com/apache/maven/commit/1d473233f21b63f351ded6904f4f9f98db3faaf1]
> Using version range in parent and CI Friendly Version fails
> ---
>
> Key: MNG-6727
> URL: https://issues.apache.org/jira/browse/MNG-6727
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation, POM, Reactor and Workspace
>Affects Versions: 3.5.2, 3.6.1, 3.6.2, 3.6.3
>Reporter: Tom Kiemes
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.x-candidate, 3.8.x-candidate
>
>
> We would like to pass a [version
> range|https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html] to
> the parent which should be possible since 3.5.0
> At the same time, we would like to use [CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html] for the artifact
> itself.
> Both on their own work well, but combined they don't.
> {{}}
> {{http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> }}{{xsi:schemaLocation="[http://maven.apache.org/POM/4.0.0]
> [http://maven.apache.org/xsd/maven-4.0.0.xsd]";>}}
> {{ 4.0.0}}
> {{ }}
> {{ org.springframework.boot}}
> {{ spring-boot-starter-parent}}
> {{ [2.1,3.0)}}
> {{ }}
> {{ com.example}}
> {{ test}}
> {{ ${revision}}}
> {{ pom}}
> {{ }}
> {{ 0.0.1}}
> {{ }}
> {{}}
>
> The resulting error is:
> {{The project com.example:test:${revision} (/Users/d045390/scratch/test.pom)
> has 1 error}}
> {{[ERROR] Version must be a constant @ line 13, column 12}}
>
> Changing the version range of the parent to a fixed version e.g.
> \{{2.1.5.Release}}, building works.
> Changing the artifact version from ${revision} to a fixed version e.g. 0.0.1
> without using the {{properties}} works as well.
> So it somehow must be the combination of both features which are actually not
> really related or am I missing something?
> PS: I left the modules out for abbreviation purpose. The pom itself can still
> be used to reproduced
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-6727) Using version range in parent and CI Friendly Version fails
[
https://issues.apache.org/jira/browse/MNG-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-6727:
-
Fix Version/s: 4.0.0
4.0.0-alpha-1
3.8.5
(was: 4.0.x-candidate)
(was: 3.8.x-candidate)
> Using version range in parent and CI Friendly Version fails
> ---
>
> Key: MNG-6727
> URL: https://issues.apache.org/jira/browse/MNG-6727
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation, POM, Reactor and Workspace
>Affects Versions: 3.5.2, 3.6.1, 3.6.2, 3.6.3
>Reporter: Tom Kiemes
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
>
> We would like to pass a [version
> range|https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html] to
> the parent which should be possible since 3.5.0
> At the same time, we would like to use [CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html] for the artifact
> itself.
> Both on their own work well, but combined they don't.
> {{}}
> {{http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> }}{{xsi:schemaLocation="[http://maven.apache.org/POM/4.0.0]
> [http://maven.apache.org/xsd/maven-4.0.0.xsd]";>}}
> {{ 4.0.0}}
> {{ }}
> {{ org.springframework.boot}}
> {{ spring-boot-starter-parent}}
> {{ [2.1,3.0)}}
> {{ }}
> {{ com.example}}
> {{ test}}
> {{ ${revision}}}
> {{ pom}}
> {{ }}
> {{ 0.0.1}}
> {{ }}
> {{}}
>
> The resulting error is:
> {{The project com.example:test:${revision} (/Users/d045390/scratch/test.pom)
> has 1 error}}
> {{[ERROR] Version must be a constant @ line 13, column 12}}
>
> Changing the version range of the parent to a fixed version e.g.
> \{{2.1.5.Release}}, building works.
> Changing the artifact version from ${revision} to a fixed version e.g. 0.0.1
> without using the {{properties}} works as well.
> So it somehow must be the combination of both features which are actually not
> really related or am I missing something?
> PS: I left the modules out for abbreviation purpose. The pom itself can still
> be used to reproduced
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] gnodet merged pull request #670: [3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version
gnodet merged pull request #670: URL: https://github.com/apache/maven/pull/670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-1996) Upgrade plexus-java to Version 1.1.1
[ https://issues.apache.org/jira/browse/SUREFIRE-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1996. -- Fix Version/s: 3.0.0-M6 Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=2643f60eb22d3843c25b906053653abe37c94df7 > Upgrade plexus-java to Version 1.1.1 > > > Key: SUREFIRE-1996 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1996 > Project: Maven Surefire > Issue Type: Dependency upgrade > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MENFORCER-396) Faulty banned repositories
[
https://issues.apache.org/jira/browse/MENFORCER-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485236#comment-17485236
]
Delany commented on MENFORCER-396:
--
One other thing, this is a valid repository URL
{code:java}
file:///C:\ws\TARGA-2.2.0-adhoc\cardinal\provided/ {code}
But if I try whitelist it, the enforcer complains
{noformat}
Execution fail of goal
org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce failed:
Illegal/unsupported escape sequence near index 14
15:13:29 [ERROR] file:///C:\ws\TARGA-2.2.0-adhoc\cardinal\provided/
15:13:29 [ERROR] ^{noformat}
> Faulty banned repositories
> --
>
> Key: MENFORCER-396
> URL: https://issues.apache.org/jira/browse/MENFORCER-396
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0
>Reporter: Delany
>Priority: Minor
> Attachments: pom.xml
>
>
> To start with, the sample XML on
> [https://maven.apache.org/enforcer/enforcer-rules/bannedRepositories.html] is
> invalid.
> After correcting the XML, if I choose to whitelist, I get
> {quote}Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce
> (enforce-banned-repositories) on project dummy: Unable to parse configuration
> of mojo org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce for
> parameter allowedRepositories: Cannot create instance of interface
> org.apache.maven.enforcer.rule.api.EnforcerRule:
> org.apache.maven.enforcer.rule.api.EnforcerRule.()
> {quote}
> Then I try unsuccessfully to blacklist [http://0.0.0.0/*] and others. The
> dependency:list-repositories goal on the other hand manages to find this
> repository.
> [^pom.xml]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (SUREFIRE-1996) Upgrade plexus-java to Version 1.1.1
Tibor Digana created SUREFIRE-1996: -- Summary: Upgrade plexus-java to Version 1.1.1 Key: SUREFIRE-1996 URL: https://issues.apache.org/jira/browse/SUREFIRE-1996 Project: Maven Surefire Issue Type: Dependency upgrade Components: Maven Failsafe Plugin, Maven Surefire Plugin Reporter: Tibor Digana Assignee: Tibor Digana -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-jxr] dependabot[bot] opened a new pull request #46: Bump plexus-java from 1.1.0 to 1.1.1
dependabot[bot] opened a new pull request #46: URL: https://github.com/apache/maven-jxr/pull/46 Bumps [plexus-java](https://github.com/codehaus-plexus/plexus-languages) from 1.1.0 to 1.1.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-languages/releases";>plexus-java's releases. 1.1.1 🐛 Bug Fixes requires static from deeper level must be included if requested. see MCOMPILER-481 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/106";>#106) https://github.com/olamy";>@olamy 📦 Dependency updates Bump guice from 4.2.3 to 5.1.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/109";>#109) https://github.com/dependabot";>@dependabot Bump mockito-core from 4.3.0 to 4.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/110";>#110) https://github.com/dependabot";>@dependabot Bump mockito-core from 4.2.0 to 4.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/108";>#108) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.17.5 to 5.17.6 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/107";>#107) https://github.com/dependabot";>@dependabot Bump maven-compiler-plugin from 3.8.1 to 3.9.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/103";>#103) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.17.5 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/105";>#105) https://github.com/dependabot";>@dependabot Bump maven-shared-resources from 3 to 4 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/99";>#99) https://github.com/dependabot";>@dependabot Bump mockito-core from 4.1.0 to 4.2.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/102";>#102) https://github.com/dependabot";>@dependabot Bump mockito-core from 3.12.4 to 4.1.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/101";>#101) https://github.com/dependabot";>@dependabot Bump qdox from 2.0.0 to 2.0.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/100";>#100) https://github.com/dependabot";>@dependabot Bump sisu-maven-plugin from 0.3.4 to 0.3.5 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/96";>#96) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.3.0 to 3.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/95";>#95) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/97";>#97) https://github.com/dependabot";>@dependabot Bump mockito-core from 3.12.1 to 3.12.4 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/94";>#94) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.2.0 to 2.3.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/92";>#92) https://github.com/dependabot";>@dependabot Commits https://github.com/codehaus-plexus/plexus-languages/commit/cdb4bff9baf67232ba0abe5eb1db702a396ecdb2";>cdb4bff [maven-release-plugin] prepare release plexus-languages-1.1.1 https://github.com/codehaus-plexus/plexus-languages/commit/86e0436075daeba07b702a8429251dd9829f39df";>86e0436 requires static from deeper level must be included if requested. see MCOMPILE... https://github.com/codehaus-plexus/plexus-languages/commit/7d9c4a4063dac1e4aba4e4c784693d70aced8821";>7d9c4a4 Merge pull request https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/109";>#109 from codehaus-plexus/dependabot/maven/com.google.inje... https://github.com/codehaus-plexus/plexus-languages/commit/e20fb761a6bcfb7024f90a8a3c55b59c37031e13";>e20fb76 Merge pull request https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/110";>#110 from codehaus-plexus/dependabot/maven/org.mockito-moc... https://github.com/codehaus-plexus/plexus-languages/commit/c94c9efb111b3c11a45b34ef8345eaa09bf91ba9";>c94c9ef Bump mockito-core from 4.3.0 to 4.3.1 https://github.com/codehaus-plexus/plexus-languages/commit/1f0491911f028b776a96e3f211599fc4b2f8ce31";>1f04919 Merge pull request https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/108";>#108 from codehaus-plexus/dependabot/maven/org.mockito-moc... https://github.com/codehaus-plexus/plexus-languages/commit/acb10ab75caa7f0e960e5139eca55bda0d30872a";>acb10ab Bump guice from 4.2.3 to 5.1.0 https://github.com/codehaus-plexus/plexus-languages/commit/3ed346cffc9124ad784e0a9afcde0f2fcbe02137";>3ed346
[GitHub] [maven-invoker-plugin] slawekjaranowski merged pull request #95: Correct doc: Replace `activeByDefault` by `activeProfiles`.
slawekjaranowski merged pull request #95: URL: https://github.com/apache/maven-invoker-plugin/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-6727) Using version range in parent and CI Friendly Version fails
[
https://issues.apache.org/jira/browse/MNG-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-6727:
---
Assignee: Guillaume Nodet (was: Michael Osipov)
> Using version range in parent and CI Friendly Version fails
> ---
>
> Key: MNG-6727
> URL: https://issues.apache.org/jira/browse/MNG-6727
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation, POM, Reactor and Workspace
>Affects Versions: 3.5.2, 3.6.1, 3.6.2, 3.6.3
>Reporter: Tom Kiemes
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.x-candidate, 3.8.x-candidate
>
>
> We would like to pass a [version
> range|https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html] to
> the parent which should be possible since 3.5.0
> At the same time, we would like to use [CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html] for the artifact
> itself.
> Both on their own work well, but combined they don't.
> {{}}
> {{http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> }}{{xsi:schemaLocation="[http://maven.apache.org/POM/4.0.0]
> [http://maven.apache.org/xsd/maven-4.0.0.xsd]";>}}
> {{ 4.0.0}}
> {{ }}
> {{ org.springframework.boot}}
> {{ spring-boot-starter-parent}}
> {{ [2.1,3.0)}}
> {{ }}
> {{ com.example}}
> {{ test}}
> {{ ${revision}}}
> {{ pom}}
> {{ }}
> {{ 0.0.1}}
> {{ }}
> {{}}
>
> The resulting error is:
> {{The project com.example:test:${revision} (/Users/d045390/scratch/test.pom)
> has 1 error}}
> {{[ERROR] Version must be a constant @ line 13, column 12}}
>
> Changing the version range of the parent to a fixed version e.g.
> \{{2.1.5.Release}}, building works.
> Changing the artifact version from ${revision} to a fixed version e.g. 0.0.1
> without using the {{properties}} works as well.
> So it somehow must be the combination of both features which are actually not
> really related or am I missing something?
> PS: I left the modules out for abbreviation purpose. The pom itself can still
> be used to reproduced
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MENFORCER-396) Faulty banned repositories
[
https://issues.apache.org/jira/browse/MENFORCER-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485214#comment-17485214
]
Delany edited comment on MENFORCER-396 at 2/1/22, 12:18 PM:
I don't know what was going on here, but it works now.
The example XML is still broken though:
https://maven.apache.org/enforcer/enforcer-rules/bannedRepositories.html
One strange thing I did notice is that the allowedRepositories tag can have an
allowedPluginRepository tag.
was (Author: delany):
I don't know what was going on here, but it works now.
The example code is still broken though.
One strange thing I did notice is that the allowedRepositories tag can have an
allowedPluginRepository tag.
> Faulty banned repositories
> --
>
> Key: MENFORCER-396
> URL: https://issues.apache.org/jira/browse/MENFORCER-396
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0
>Reporter: Delany
>Priority: Minor
> Attachments: pom.xml
>
>
> To start with, the sample XML on
> [https://maven.apache.org/enforcer/enforcer-rules/bannedRepositories.html] is
> invalid.
> After correcting the XML, if I choose to whitelist, I get
> {quote}Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce
> (enforce-banned-repositories) on project dummy: Unable to parse configuration
> of mojo org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce for
> parameter allowedRepositories: Cannot create instance of interface
> org.apache.maven.enforcer.rule.api.EnforcerRule:
> org.apache.maven.enforcer.rule.api.EnforcerRule.()
> {quote}
> Then I try unsuccessfully to blacklist [http://0.0.0.0/*] and others. The
> dependency:list-repositories goal on the other hand manages to find this
> repository.
> [^pom.xml]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MENFORCER-396) Faulty banned repositories
[
https://issues.apache.org/jira/browse/MENFORCER-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485214#comment-17485214
]
Delany commented on MENFORCER-396:
--
I don't know what was going on here, but it works now.
The example code is still broken though.
One strange thing I did notice is that the allowedRepositories tag can have an
allowedPluginRepository tag.
> Faulty banned repositories
> --
>
> Key: MENFORCER-396
> URL: https://issues.apache.org/jira/browse/MENFORCER-396
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0
>Reporter: Delany
>Priority: Minor
> Attachments: pom.xml
>
>
> To start with, the sample XML on
> [https://maven.apache.org/enforcer/enforcer-rules/bannedRepositories.html] is
> invalid.
> After correcting the XML, if I choose to whitelist, I get
> {quote}Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce
> (enforce-banned-repositories) on project dummy: Unable to parse configuration
> of mojo org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce for
> parameter allowedRepositories: Cannot create instance of interface
> org.apache.maven.enforcer.rule.api.EnforcerRule:
> org.apache.maven.enforcer.rule.api.EnforcerRule.()
> {quote}
> Then I try unsuccessfully to blacklist [http://0.0.0.0/*] and others. The
> dependency:list-repositories goal on the other hand manages to find this
> repository.
> [^pom.xml]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-invoker-plugin] slawekjaranowski merged pull request #94: Remove unused parameter
slawekjaranowski merged pull request #94: URL: https://github.com/apache/maven-invoker-plugin/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on issue #592: How to integrate mvnd in jenkins?
ppalaga commented on issue #592: URL: https://github.com/apache/maven-mvnd/issues/592#issuecomment-1026759188 > @gnodet We are now using Jenkins' maven command to build code, how to build through mvnd @hongchangliu you said what you do and what you'd like to do, but you have not answered @gnodet's question, why do you want to do that? What expectations do you have from mvnd on Jenkins? By answering those questions, you'd perhaps realize yourself that your expectations are unrealistic. But maybe not, it depends on what you really expect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] mdrie opened a new pull request #95: Correct doc: Replace `activeByDefault` by `activeProfiles`.
mdrie opened a new pull request #95: URL: https://github.com/apache/maven-invoker-plugin/pull/95 `activeByDefault` does not work with extensions from `.mvn/extensions.xml`. It might also be more fragile, if other profiles are used, since it only has effect, if no other profiles are activated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-786) Sealed classes not supported
[
https://issues.apache.org/jira/browse/MDEP-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485172#comment-17485172
]
Slawomir Jaranowski commented on MDEP-786:
--
Should work with the latest snapshot version 3.3.0-SNAPSHOT.
> Sealed classes not supported
>
>
> Key: MDEP-786
> URL: https://issues.apache.org/jira/browse/MDEP-786
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze
>Affects Versions: 3.2.0
>Reporter: Jordan Zimmerman
>Priority: Major
>
> Use of Java 17's sealed classes generates an error:
> {{PermittedSubclasses requires ASM9}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MDEP-786) Sealed classes not supported
Jordan Zimmerman created MDEP-786:
-
Summary: Sealed classes not supported
Key: MDEP-786
URL: https://issues.apache.org/jira/browse/MDEP-786
Project: Maven Dependency Plugin
Issue Type: Bug
Components: analyze
Affects Versions: 3.2.0
Reporter: Jordan Zimmerman
Use of Java 17's sealed classes generates an error:
{{PermittedSubclasses requires ASM9}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MCOMPILER-481) JPMS Regression: cannot access (requires static module not include anymore)
[
https://issues.apache.org/jira/browse/MCOMPILER-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485124#comment-17485124
]
Olivier Lamy commented on MCOMPILER-481:
ETA plexus-java released.
still the m-c-p PR to merge
> JPMS Regression: cannot access (requires static module not include
> anymore)
> ---
>
> Key: MCOMPILER-481
> URL: https://issues.apache.org/jira/browse/MCOMPILER-481
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Simone Bordet
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.9.1
>
> Attachments: compiler-bug.tar.gz
>
>
> Version 3.8.1 is not affected.
> The problem lies in how the module-path is constructed by the
> maven-compiler-plugin – not sure what changes from 3.8.1 caused this.
> In 3.8.1:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> In 3.9.0:
> {code:java}
> -d
> /home/simon/tmp/compiler-bug/app/target/test-classes
> -classpath
> /home/simon/tmp/compiler-bug/app/target/test-classes
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util-ajax/10.0.7/jetty-util-ajax-10.0.7.jar
>
> /home/simon/.m2/repository/org/eclipse/jetty/jetty-util/10.0.7/jetty-util-10.0.7.jar
>
> /home/simon/.m2/repository/org/slf4j/slf4j-api/2.0.0-alpha5/slf4j-api-2.0.0-alpha5.jar
>
> /home/simon/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.8.2/junit-jupiter-api-5.8.2.jar
>
> /home/simon/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar
>
> /home/simon/.m2/repository/org/junit/platform/junit-platform-commons/1.8.2/junit-platform-commons-1.8.2.jar
>
> /home/simon/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar
>
> --module-path
> /home/simon/tmp/compiler-bug/app/target/classes
>
> /home/simon/.m2/repository/org/example/compiler-bug-service/1.0-SNAPSHOT/compiler-bug-service-1.0-SNAPSHOT.jar
>
> -sourcepath
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> -s
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
> -g
> -nowarn
> --release
> 11
> -encoding
> UTF-8
> --patch-module
> compiler.bug.app=/home/simon/tmp/compiler-bug/app/target/classes
> /home/simon/tmp/compiler-bug/app/src/test/java
>
> /home/simon/tmp/compiler-bug/app/target/generated-test-sources/test-annotations
>
> --add-reads
> compiler.bug.app=ALL-UNNAMED {code}
> Running with 3.9.0 yields:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project compiler-bug-app: Compilation failure
> [ERROR]
> /home/simon/tmp/compiler-bug/app/src/test/java/org/test/app/MainTest.java:[12,38]
> cannot access org.eclipse.jetty.util.ajax.JSON
> [ERROR] class file for org.eclipse.jetty.util.ajax.JSON not found {code}
> Class {{JSON}} is in {{{}jetty-util-10.0.7.jar{}}}.
> In 3.9.0 this jar is missing from the module-path, causing the error.
> Attached you can find a reproducer: switch the maven-compiler-plugin version
> from 3.8.1 (works) to 3.9.0 (doe
[jira] [Commented] (MNG-7244) Change from deprecated WARNING to FAIL the build for usage of pom.X placeholders
[
https://issues.apache.org/jira/browse/MNG-7244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485115#comment-17485115
]
Maarten Mulders commented on MNG-7244:
--
{quote}Prefix and prefixless should be done in two tickets to make the
intention clear.{quote}
I've added MNG-7404 for that.
> Change from deprecated WARNING to FAIL the build for usage of pom.X
> placeholders
>
>
> Key: MNG-7244
> URL: https://issues.apache.org/jira/browse/MNG-7244
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 4.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Assignee: Maarten Mulders
>Priority: Minor
> Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
>
> Currently we produce a {{WARNING}} in case of using {{pom.version}} or alike.
> I would suggest to change {{WARNING}} into a failing build in such use cases.
> {code}
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for 'com.soebes.examples.j2ee:appasm:pom:1.0-SNAPSHOT'
> [WARNING] The expression ${pom.version} is deprecated. Please use
> ${project.version} instead.
> {code}
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (MNG-7404) Change from deprecated WARNING to FAIL the build for usage of {X} placeholders rather than ${project.X}
[
https://issues.apache.org/jira/browse/MNG-7404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Mulders reassigned MNG-7404:
Assignee: (was: Maarten Mulders)
> Change from deprecated WARNING to FAIL the build for usage of {X}
> placeholders rather than ${project.X}
> ---
>
> Key: MNG-7404
> URL: https://issues.apache.org/jira/browse/MNG-7404
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 4.0.0-alpha-1
>Reporter: Maarten Mulders
>Priority: Minor
> Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
>
> Currently we produce a {{WARNING}} in case of using {{version}} or alike.
> I would suggest to change {{WARNING}} into a failing build in such use cases.
> {code}
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for 'com.soebes.examples.j2ee:appasm:pom:1.0-SNAPSHOT'
> [WARNING] The expression ${version} is deprecated. Please use
> ${project.version} instead.
> {code}
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-7404) Change from deprecated WARNING to FAIL the build for usage of {X} placeholders rather than ${project.X}
[
https://issues.apache.org/jira/browse/MNG-7404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Mulders updated MNG-7404:
-
Description:
Currently we produce a {{WARNING}} in case of using {{version}} or alike.
I would suggest to change {{WARNING}} into a failing build in such use cases.
{code}
[WARNING]
[WARNING] Some problems were encountered while building the effective model for
'com.soebes.examples.j2ee:appasm:pom:1.0-SNAPSHOT'
[WARNING] The expression ${version} is deprecated. Please use
${project.version} instead.
{code}
WDYT?
was:
Currently we produce a {{WARNING}} in case of using {{pom.version}} or alike.
I would suggest to change {{WARNING}} into a failing build in such use cases.
{code}
[WARNING]
[WARNING] Some problems were encountered while building the effective model for
'com.soebes.examples.j2ee:appasm:pom:1.0-SNAPSHOT'
[WARNING] The expression ${pom.version} is deprecated. Please use
${project.version} instead.
{code}
WDYT?
> Change from deprecated WARNING to FAIL the build for usage of {X}
> placeholders rather than ${project.X}
> ---
>
> Key: MNG-7404
> URL: https://issues.apache.org/jira/browse/MNG-7404
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 4.0.0-alpha-1
>Reporter: Maarten Mulders
>Assignee: Maarten Mulders
>Priority: Minor
> Labels: must-be-in-4.0.0-alpha-1
> Fix For: 4.0.x-candidate
>
>
> Currently we produce a {{WARNING}} in case of using {{version}} or alike.
> I would suggest to change {{WARNING}} into a failing build in such use cases.
> {code}
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for 'com.soebes.examples.j2ee:appasm:pom:1.0-SNAPSHOT'
> [WARNING] The expression ${version} is deprecated. Please use
> ${project.version} instead.
> {code}
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MNG-7404) Change from deprecated WARNING to FAIL the build for usage of {X} placeholders rather than ${project.X}
Maarten Mulders created MNG-7404:
Summary: Change from deprecated WARNING to FAIL the build for
usage of {X} placeholders rather than ${project.X}
Key: MNG-7404
URL: https://issues.apache.org/jira/browse/MNG-7404
Project: Maven
Issue Type: Improvement
Affects Versions: 4.0.0-alpha-1
Reporter: Maarten Mulders
Assignee: Maarten Mulders
Fix For: 4.0.x-candidate
Currently we produce a {{WARNING}} in case of using {{pom.version}} or alike.
I would suggest to change {{WARNING}} into a failing build in such use cases.
{code}
[WARNING]
[WARNING] Some problems were encountered while building the effective model for
'com.soebes.examples.j2ee:appasm:pom:1.0-SNAPSHOT'
[WARNING] The expression ${pom.version} is deprecated. Please use
${project.version} instead.
{code}
WDYT?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-compiler-plugin] olamy commented on a change in pull request #82: [MCOMPILER-481] compiler plugin should include static module for compilation
olamy commented on a change in pull request #82: URL: https://github.com/apache/maven-compiler-plugin/pull/82#discussion_r796351209 ## File path: src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java ## @@ -231,6 +231,7 @@ protected void preparePaths( Set sourceFiles ) ResolvePathsRequest request = ResolvePathsRequest.ofFiles( dependencyArtifacts ) + .setIncludeStatic( true ) Review comment: in the case of https://issues.apache.org/jira/browse/MCOMPILER-481 we do if we want to be backward compat with previous version (or make it configurable). but my understanding on `static` means required for compilation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on a change in pull request #82: [MCOMPILER-481] compiler plugin should include static module for compilation
olamy commented on a change in pull request #82: URL: https://github.com/apache/maven-compiler-plugin/pull/82#discussion_r796351209 ## File path: src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java ## @@ -231,6 +231,7 @@ protected void preparePaths( Set sourceFiles ) ResolvePathsRequest request = ResolvePathsRequest.ofFiles( dependencyArtifacts ) + .setIncludeStatic( true ) Review comment: in the case of https://issues.apache.org/jira/browse/MCOMPILER-481 we do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPIR-412) Dependency report generates non-well-formed output if the POM of a depdendency cannot be parsed
[
https://issues.apache.org/jira/browse/MPIR-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MPIR-412.
---
Resolution: Fixed
Fixed with
[d85aec37c385d64196f7db5c3c27b400b46032ca|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=d85aec37c385d64196f7db5c3c27b400b46032ca].
> Dependency report generates non-well-formed output if the POM of a
> depdendency cannot be parsed
> ---
>
> Key: MPIR-412
> URL: https://issues.apache.org/jira/browse/MPIR-412
> Project: Maven Project Info Reports Plugin
> Issue Type: Bug
> Components: dependencies
>Affects Versions: 3.1.2
>Reporter: Jukka Matilainen
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.2.1
>
>
> If there is dependency whose POM cannot be parsed, the output from the
> dependency report is not well-formed, with start and end tags not matching
> each other.
> This causes problems when using maven-pdf-plugin, which skips the depedency
> report entirely if it is not well-formed.
> h3. How to reproduce
> 1. Use the following POM:
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd";>
> 4.0.0
> fi.iki.jkmatila
> repro-dependency-report-bug
> 1.0-SNAPSHOT
>
>
>
> xml-apis
> xml-apis-ext
> 1.3.04
>
>
>
>
>
> org.apache.maven.plugins
> maven-project-info-reports-plugin
> 3.1.2
>
>
>
>
> {code}
> 2. Run this command:
> {code:bash}
> mvn project-info-reports:dependencies
> {code}
> Note that since there is a problem with the POM of
> xml-apis:xml-apis-ext:jar:1.3.04 (the {{distributionManagement}} tag contains
> a {{status}} tag inside), there is a message displayed about that:
> {quote}[INFO] Unable to create Maven project from repository for artifact
> 'xml-apis:xml-apis-ext:jar:1.3.04', for more information run with -X
> {quote}
> h3. Expected results
> Even if there is a dependency with problems in its POM, I would expect the
> generated dependency report to be well-formed (even if the details for that
> dependency are missing), so that maven-pdf-plugin can process that dependency
> report.
> h3. Observed results
> The generated Dependency Tree secion in the dependency report is not
> well-formed, with start tags and end tags not matching each other. This
> causes problems with maven-pdf-plugin.
> {code:bash}
> $ xmllint --noout target/site/dependencies.html
> target/site/dependencies.html:94: parser error : Opening and ending tag
> mismatch: div line 94 and td
> ; vertical-align: text-bottom;"> style="display:none">
> [...]{code}
> Here is an excerpt from the generated file
> {{{}target/site/dependencies.html{}}}, with whitespace and indentation
> manually added to make it more clear:
> {code:xml}
>
> Dependency Tree
>
>
> fi.iki.jkmatila:repro-dependency-report-bug:jar:1.0-SNAPSHOT
>onclick="toggleDependencyDetails( '_dep0', '_img1' );" style="cursor:
> pointer; vertical-align: text-bottom;">
>
>
>
> repro-dependency-report-bug
>
>
>
> Description: There is currently no description
> associated with this project.
> Project Licenses: No licenses are defined for this
> project.
>
>
>
>
>
>
> xml-apis:xml-apis-ext:jar:1.3.04 (compile)
>alt="[Information]" onclick="toggleDependencyDetails( '_dep2', '_img3' );"
> style="cursor: pointer; vertical-align: text-bottom;">
>
>
>
>
>
>
>
>
>
>
> {code}
> There are end tags {{}} generated in the output without the
> corresponding start tags.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-project-info-reports-plugin] asfgit closed pull request #31: [MPIR-412] Fix dependency report tag balance when exception
asfgit closed pull request #31: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
