[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #484: Support junit-platform-runner and junit-platform-suite-engine in plugin dependencies
slawekjaranowski commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820809901
##
File path: surefire-its/src/test/resources/junit5-suite/pom.xml
##
@@ -0,0 +1,80 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
+ org.example
+ junit5-suite
+ 1.0-SNAPSHOT
+
+
+UTF-8
+
${java.specification.version}
+
${java.specification.version}
+
+
+
+
+ org.junit.jupiter
+ junit-jupiter-api
+ 5.8.0
+ test
+
+
+ org.junit.platform
+ junit-platform-suite-api
+ 1.8.0
+ test
+
+
+
+
+
+
+
+ org.apache.maven.plugins
+ maven-surefire-plugin
+ ${surefire.version}
+
+
+ JUnit5Tests
+
+
+
+
+ org.junit.jupiter
+ junit-jupiter-engine
+ 5.8.2
Review comment:
does should be the same version as for api?
the same for suite-api and suite-engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #484: Support junit-platform-runner and junit-platform-suite-engine in plugin dependencies
slawekjaranowski commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820807539
##
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##
@@ -411,6 +411,42 @@ Using JUnit 5 Platform
+---+
+** JUnit5 Suite
+
+ For more information see this
+
{{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}}
+ and the
{{{https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine}tutorial}}.
+
++---+
+
+
+org.junit.jupiter
+junit-jupiter-engine
+5.8.2
+test
+
+
+org.junit.platform
+junit-platform-suite-engine
+1.8.2
+test
+
+
+
+
+
+org.apache.maven.plugins
+maven-surefire-plugin
+
+
+JUnit5Tests
Review comment:
such explanation should be put in example,
what inclusion is for and what value should contains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502332#comment-17502332
]
Hudson commented on MNG-6972:
-
Build failed in Jenkins: Maven » Maven TLP » maven » PR-676 #6
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-676/6/
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-7045) Drop CDI API from Maven
[ https://issues.apache.org/jira/browse/MNG-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502331#comment-17502331 ] Hudson commented on MNG-7045: - Build failed in Jenkins: Maven » Maven TLP » maven » PR-676 #6 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-676/6/ > Drop CDI API from Maven > --- > > Key: MNG-7045 > URL: https://issues.apache.org/jira/browse/MNG-7045 > Project: Maven > Issue Type: Bug > Components: Core >Reporter: Romain Manni-Bucau >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: 3.8.3, 4.0.0, 4.0.0-alpha-1 > > > This is an old leak which triggered a lot of regressions and still triggers > bugs in mojos. > Since there is on real justification in maven itself (@Typed is not since > there are alternative and cdi is not used in any piece of maven), let's drop > it. > If a plugin needs it, it already has it since cdi-api is outdated anyway. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7045) Drop CDI API from Maven
[ https://issues.apache.org/jira/browse/MNG-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502324#comment-17502324 ] Hudson commented on MNG-7045: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-660 #6 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-660/6/ > Drop CDI API from Maven > --- > > Key: MNG-7045 > URL: https://issues.apache.org/jira/browse/MNG-7045 > Project: Maven > Issue Type: Bug > Components: Core >Reporter: Romain Manni-Bucau >Assignee: Michael Osipov >Priority: Major > Labels: up-for-grabs > Fix For: 3.8.3, 4.0.0, 4.0.0-alpha-1 > > > This is an old leak which triggered a lot of regressions and still triggers > bugs in mojos. > Since there is on real justification in maven itself (@Typed is not since > there are alternative and cdi is not used in any piece of maven), let's drop > it. > If a plugin needs it, it already has it since cdi-api is outdated anyway. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502325#comment-17502325
]
Hudson commented on MNG-6972:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » PR-660 #6
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-660/6/
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-compiler-plugin] dependabot[bot] opened a new pull request #99: Bump maven-plugins from 34 to 35
dependabot[bot] opened a new pull request #99: URL: https://github.com/apache/maven-compiler-plugin/pull/99 Bumps [maven-plugins](https://github.com/apache/maven-parent) from 34 to 35. Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-6806) Provide Maven BOM
[
https://issues.apache.org/jira/browse/MNG-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502271#comment-17502271
]
Konrad Windszus edited comment on MNG-6806 at 3/7/22, 2:27 PM:
---
It seems that some dependencies are not (yet) managed by the BOM
(https://github.com/apache/maven/blob/master/maven-bom/pom.xml) but they are
(at least partially) provided through the Core Classloader
(https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml):
# plexus-utils
# wagon-api
# maven-resolver-api, maven-resolver-spi, maven-resolver-impl
# plexus-container
# plexus-component-annotations
# JAnsi
IMHO every dependency which is always loaded through the Core classloader
should be managed in the BOM as otherwise plugins may wrongly assume, they can
determine the version.
was (Author: kwin):
It seems that some dependencies are yet managed by the BOM
(https://github.com/apache/maven/blob/master/maven-bom/pom.xml) but they are
(at least partially) provided through the Core Classloader
(https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml):
# plexus-utils
# wagon-api
# maven-resolver-api, maven-resolver-spi, maven-resolver-impl
# plexus-container
# plexus-component-annotations
# JAnsi
IMHO every dependency which is always loaded through the Core classloader
should be managed in the BOM as otherwise plugins may wrongly assume, they can
determine the version.
> Provide Maven BOM
> -
>
> Key: MNG-6806
> URL: https://issues.apache.org/jira/browse/MNG-6806
> Project: Maven
> Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> Maven libraries should always have the same version to ensure they work as
> expected, hence the preferred way to manage that is with a bom.
> Let's introduce the {{maven-dependencies}}, a
> [bom|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies]
> for Maven dependencies. We will likely need the same for plugins.
> See https://www.baeldung.com/spring-maven-bom about how to write and use the
> bom.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6806) Provide Maven BOM
[
https://issues.apache.org/jira/browse/MNG-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502298#comment-17502298
]
Michael Osipov commented on MNG-6806:
-
I would ask our experts: [~cstamas], [~gnodet]. I'd consider that this will all
go way when the new Maven Core API is ready.
> Provide Maven BOM
> -
>
> Key: MNG-6806
> URL: https://issues.apache.org/jira/browse/MNG-6806
> Project: Maven
> Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> Maven libraries should always have the same version to ensure they work as
> expected, hence the preferred way to manage that is with a bom.
> Let's introduce the {{maven-dependencies}}, a
> [bom|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies]
> for Maven dependencies. We will likely need the same for plugins.
> See https://www.baeldung.com/spring-maven-bom about how to write and use the
> bom.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (WAGON-614) Deprecate Wagon FTP Provider
[ https://issues.apache.org/jira/browse/WAGON-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502296#comment-17502296 ] Kenneth Wayman commented on WAGON-614: -- (y) Awesome, thanks for your help. > Deprecate Wagon FTP Provider > > > Key: WAGON-614 > URL: https://issues.apache.org/jira/browse/WAGON-614 > Project: Maven Wagon > Issue Type: Task > Components: wagon-ftp >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.5.0 > > > This provider is untested by us for years now (even if commons-net underlying > implementation continues to be maintained > https://commons.apache.org/proper/commons-net/ ), because FTP has almost > everywhere superseded by SSH or HTTP. > We are deprecating this provider to be removed in 4.0.0. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (WAGON-614) Deprecate Wagon FTP Provider
[ https://issues.apache.org/jira/browse/WAGON-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502294#comment-17502294 ] Michael Osipov commented on WAGON-614: -- Makes sense, I'd go with the easiest approach as well. I consider that SSH would be a drop-in replacement for you. But as said: You have plenty of time to consider another solution. Don't expect to change before next year. > Deprecate Wagon FTP Provider > > > Key: WAGON-614 > URL: https://issues.apache.org/jira/browse/WAGON-614 > Project: Maven Wagon > Issue Type: Task > Components: wagon-ftp >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.5.0 > > > This provider is untested by us for years now (even if commons-net underlying > implementation continues to be maintained > https://commons.apache.org/proper/commons-net/ ), because FTP has almost > everywhere superseded by SSH or HTTP. > We are deprecating this provider to be removed in 4.0.0. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-verifier] kwin opened a new pull request #9: [MSHARED-1043] Deprecate methods leveraging JUnit4 assertions
kwin opened a new pull request #9: URL: https://github.com/apache/maven-verifier/pull/9 Provide alternatives relying on framework agnostic exception instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-300) Replace Google Analytics with ASF Matomo
[ https://issues.apache.org/jira/browse/MPOM-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MPOM-300. - > Replace Google Analytics with ASF Matomo > > > Key: MPOM-300 > URL: https://issues.apache.org/jira/browse/MPOM-300 > Project: Maven POMs > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > > While GA is still allowed according to the [ASF Privacy > Policy|https://www.apache.org/foundation/policies/privacy.html], there's now > [an ASF Matomo instance|https://matomo.privacy.apache.org/]. > * Matomo doesn't track full IPs, doesn't track sessions after closing the > browser, etc. > * Additionally, GA is already illegal in some countries,, like France. > Let's replace the GA code with Matomo. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (MPOM-300) Replace Google Analytics with ASF Matomo
[ https://issues.apache.org/jira/browse/MPOM-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MPOM-300: - Assignee: Benjamin Marwell > Replace Google Analytics with ASF Matomo > > > Key: MPOM-300 > URL: https://issues.apache.org/jira/browse/MPOM-300 > Project: Maven POMs > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > > While GA is still allowed according to the [ASF Privacy > Policy|https://www.apache.org/foundation/policies/privacy.html], there's now > [an ASF Matomo instance|https://matomo.privacy.apache.org/]. > * Matomo doesn't track full IPs, doesn't track sessions after closing the > browser, etc. > * Additionally, GA is already illegal in some countries,, like France. > Let's replace the GA code with Matomo. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (MPOM-300) Replace Google Analytics with ASF Matomo
[ https://issues.apache.org/jira/browse/MPOM-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MPOM-300. --- Resolution: Fixed > Replace Google Analytics with ASF Matomo > > > Key: MPOM-300 > URL: https://issues.apache.org/jira/browse/MPOM-300 > Project: Maven POMs > Issue Type: Improvement >Reporter: Benjamin Marwell >Priority: Major > > While GA is still allowed according to the [ASF Privacy > Policy|https://www.apache.org/foundation/policies/privacy.html], there's now > [an ASF Matomo instance|https://matomo.privacy.apache.org/]. > * Matomo doesn't track full IPs, doesn't track sessions after closing the > browser, etc. > * Additionally, GA is already illegal in some countries,, like France. > Let's replace the GA code with Matomo. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (MNG-6806) Provide Maven BOM
[
https://issues.apache.org/jira/browse/MNG-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502271#comment-17502271
]
Konrad Windszus edited comment on MNG-6806 at 3/7/22, 1:38 PM:
---
It seems that some dependencies are yet managed by the BOM
(https://github.com/apache/maven/blob/master/maven-bom/pom.xml) but they are
(at least partially) provided through the Core Classloader
(https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml):
# plexus-utils
# wagon-api
# maven-resolver-api, maven-resolver-spi, maven-resolver-impl
# plexus-container
# plexus-component-annotations
# JAnsi
IMHO every dependency which is always loaded through the Core classloader
should be managed in the BOM as otherwise plugins may wrongly assume, they can
determine the version.
was (Author: kwin):
It seems that some dependencies are yet managed by the BOM
(https://github.com/apache/maven/blob/master/maven-bom/pom.xml) but they are
(at least partially) provided through the Core Classloader
(https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml):
# plexus-utils
# wagon-api
# maven-resolver-api, maven-resolver-spi, maven-resolver-impl
# plexus-container
# plexus-component-annotations
# JAnsi
IMHO every dependency which is always loaded through the Core classloader
should be managed in the BOM.
> Provide Maven BOM
> -
>
> Key: MNG-6806
> URL: https://issues.apache.org/jira/browse/MNG-6806
> Project: Maven
> Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> Maven libraries should always have the same version to ensure they work as
> expected, hence the preferred way to manage that is with a bom.
> Let's introduce the {{maven-dependencies}}, a
> [bom|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies]
> for Maven dependencies. We will likely need the same for plugins.
> See https://www.baeldung.com/spring-maven-bom about how to write and use the
> bom.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6806) Provide Maven BOM
[
https://issues.apache.org/jira/browse/MNG-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502271#comment-17502271
]
Konrad Windszus commented on MNG-6806:
--
It seems that some dependencies are yet managed by the BOM
(https://github.com/apache/maven/blob/master/maven-bom/pom.xml) but they are
(at least partially) provided through the Core Classloader
(https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml):
# plexus-utils
# wagon-api
# maven-resolver-api, maven-resolver-spi, maven-resolver-impl
# plexus-container
# plexus-component-annotations
# JAnsi
IMHO every dependency which is always loaded through the Core classloader
should be managed in the BOM.
> Provide Maven BOM
> -
>
> Key: MNG-6806
> URL: https://issues.apache.org/jira/browse/MNG-6806
> Project: Maven
> Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> Maven libraries should always have the same version to ensure they work as
> expected, hence the preferred way to manage that is with a bom.
> Let's introduce the {{maven-dependencies}}, a
> [bom|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies]
> for Maven dependencies. We will likely need the same for plugins.
> See https://www.baeldung.com/spring-maven-bom about how to write and use the
> bom.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (WAGON-614) Deprecate Wagon FTP Provider
[ https://issues.apache.org/jira/browse/WAGON-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502269#comment-17502269 ] Kenneth Wayman commented on WAGON-614: -- Not really. We use it because at the time our team was quite familiar with FTPS so it was the quickest way to get up and running. > Deprecate Wagon FTP Provider > > > Key: WAGON-614 > URL: https://issues.apache.org/jira/browse/WAGON-614 > Project: Maven Wagon > Issue Type: Task > Components: wagon-ftp >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.5.0 > > > This provider is untested by us for years now (even if commons-net underlying > implementation continues to be maintained > https://commons.apache.org/proper/commons-net/ ), because FTP has almost > everywhere superseded by SSH or HTTP. > We are deprecating this provider to be removed in 4.0.0. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7278) Drop use of Plexus Logger in Maven Core
[
https://issues.apache.org/jira/browse/MNG-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502263#comment-17502263
]
Tamás Cservenák commented on MNG-7278:
--
Will do.
> Drop use of Plexus Logger in Maven Core
> ---
>
> Key: MNG-7278
> URL: https://issues.apache.org/jira/browse/MNG-7278
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> We decided to switch to SLF4J logging eons ago, so clean up logging:
> * drop Plexus Logger use in Maven-Core
> * align logger uses (we have injected, directly acquired, static, final)
>
> Make all core component do this:
> {noformat}
> private final Logger logger = LoggerFactory.getLogger( getClass() );
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml
[
https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502262#comment-17502262
]
Tamás Cservenák commented on MNG-7055:
--
I would try to backport it, it's a real shame that two of most important
plugins (install and deploy) were NEVER released for maven 3 as 3.x.x
> Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into
> maven-metadata.xml
> -
>
> Key: MNG-7055
> URL: https://issues.apache.org/jira/browse/MNG-7055
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories, Plugins and Lifecycle
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Blocker
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> Copying [~michael-o]'s comment from mailing list on HEAD with Maven core ITs:
> https://markmail.org/message/ggcioupa6yaet4xe#query:+page:1+mid:noyp5d3iyclrfgyp+state:results
> {noformat}[ERROR] Tests run: 834, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 287.261 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR]
> testitMNG3372(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
> Time elapsed: 1.5 s <<< ERROR!
> org.apache.maven.it.VerificationException:
> Exit code was non-zero: 1; command line and log =
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn
> --global-settings
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/settings.xml
> -s
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-3372/direct-using-prefix/settings.xml
> -e --batch-mode
> -Dmaven.repo.local=/net/home/osipovmi/var/Projekte/maven-integration-testing/repo
> mng3372:test
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for
> org.apache.maven.its.mng3372:project:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins [maven-clean-plugin,
> maven-resources-plugin, maven-jar-plugin, maven-compiler-plugin,
> maven-surefire-plugin, maven-install-plugin, maven-deploy-plugin,
> maven-site-plugin], you should define versions in pluginManagement section of
> your pom.xml or parent @ line 6, column 14
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
> [WARNING]
> [INFO] Downloading from central:
> file:target/null/org/apache/maven/its/mng3372/maven-metadata.xml
> [INFO] Downloading from central:
> file:target/null/org/apache/maven/plugins/maven-metadata.xml
> [INFO] Downloading from central:
> file:target/null/org/codehaus/mojo/maven-metadata.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.056 s
> [INFO] Finished at: 2020-06-04T22:03:01+02:00
> [INFO]
>
> [ERROR] No plugin found for prefix 'mng3372' in the current project and in the
> plugin groups [org.apache.maven.its.mng3372, org.apache.maven.plugins,
> org.codehaus.mojo] available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)] -> [Help 1]
> org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin
> found
> for prefix 'mng3372' in the current project and in the plugin groups
> [org.apache.maven.its.mng3372, org.apache.maven.plugins, org.codehaus.mojo]
> available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)]
> at
> org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver.resolve(DefaultPluginPrefixResolver.java:98)
> at
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.findPluginForPrefix(MojoDescriptorCreator.java:269)
> at
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.getMojoDescript{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MPIR-415) Wrong old goal name in "Incompatibility Notice" table in website
Tilman Hausherr created MPIR-415: Summary: Wrong old goal name in "Incompatibility Notice" table in website Key: MPIR-415 URL: https://issues.apache.org/jira/browse/MPIR-415 Project: Maven Project Info Reports Plugin Issue Type: Bug Reporter: Tilman Hausherr https://maven.apache.org/plugins/maven-project-info-reports-plugin/ The "Incompatibility Notice" table has "issue-management" twice. I suspect the left one should have been "issue-tracking". -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (MDEP-794) It is not respecting the includeScope and excludeScope
[
https://issues.apache.org/jira/browse/MDEP-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499054#comment-17499054
]
Cristiano Gavião edited comment on MDEP-794 at 3/7/22, 11:27 AM:
-
[^Deps.7z]
[~sjaranowski] , let me know if you can reproduce the issue with those simple
projects.
was (Author: cvgaviao):
[^Deps.7z]
> It is not respecting the includeScope and excludeScope
> --
>
> Key: MDEP-794
> URL: https://issues.apache.org/jira/browse/MDEP-794
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: copy-dependencies
>Affects Versions: 3.2.0
> Environment: Both Windows and Linux
>Reporter: Cristiano Gavião
>Priority: Critical
> Attachments: Deps.7z
>
>
> I'm using the copyDependencies to build a distribution package and I'm
> getting junit.jar and others on it.
> {code:java}
>
> maven-dependency-plugin
> 3.2.0
>
> sources,javadoc,full,pom
> system
> compile
>
> {code}
>
> {code:java}
> [DEBUG] Configuring mojo
> org.apache.maven.plugins:maven-dependency-plugin:3.2.0:copy-dependencies from
> plugin realm
> ClassRealm[plugin>org.apache.maven.plugins:maven-dependency-plugin:3.2.0,
> parent: sun.misc.Launcher$AppClassLoader@18b4aac2]
> [DEBUG] Configuring mojo
> 'org.apache.maven.plugins:maven-dependency-plugin:3.2.0:copy-dependencies'
> with basic configurator -->
> [DEBUG] (f) addParentPoms = false
> [DEBUG] (s) copyPom = false
> [DEBUG] (f) excludeArtifactIds = jdk.tools
> [DEBUG] (f) excludeClassifiers = sources,javadoc,full,pom
> [DEBUG] (f) excludeScope = system
> [DEBUG] (f) excludeTransitive = false
> [DEBUG] (s) failOnMissingClassifierArtifact = false
> [DEBUG] (f) includeScope = compile
> [DEBUG] (s) markersDirectory =
> C:\Users\cristianoga\git-code\p-stripping\target\dependency-maven-plugin-markers
> [DEBUG] (f) outputAbsoluteArtifactFilename = false
> [DEBUG] (s) outputDirectory =
> C:\Users\cristianoga\git-code\p-stripping\target\dependency
> [DEBUG] (f) overWriteIfNewer = true
> [DEBUG] (f) overWriteReleases = false
> [DEBUG] (f) overWriteSnapshots = false
> [DEBUG] (s) prependGroupId = false {code}
> {code:java}
> [INFO] Copying junit-4.13.2.jar to
> C:\Users\cristianoga\git-code\p-stripping\target\dependency\junit-4.13.2.jar
> [INFO] Copying hamcrest-core-1.3.jar to
> C:\Users\cristianoga\git-code\p-stripping\target\dependency\hamcrest-core-1.3.jar
> [INFO] Copying mockito-core-3.12.4.jar to
> C:\Users\cristianoga\git-code\p-stripping\target\dependency\mockito-core-3.12.4.jar
> [INFO] Copying byte-buddy-1.11.13.jar to
> C:\Users\cristianoga\git-code\p-stripping\target\dependency\byte-buddy-1.11.13.jar
> [INFO] Copying byte-buddy-agent-1.11.13.jar to
> C:\Users\cristianoga\git-code\p-stripping\target\dependency\byte-buddy-agent-1.11.13.jar
> [INFO] Copying objenesis-3.2.jar to
> C:\Users\cristianoga\git-code\p-stripping\target\dependency\objenesis-3.2.jar
> [INFO] Copying dbunit-2.7.2.jar to
> C:\Users\cristianoga\git-code\p-stripping\target\dependency\dbunit-2.7.2.jar
> [INFO] Copying h2-1.4.200.jar to
> C:\Users\cristianoga\git-code\p-stripping\target\dependency\h2-1.4.200.jar
> [INFO] Copying assertj-core-3.21.0.jar to
> C:\Users\cristianoga\git-code\p-stripping\target\dependency\assertj-core-3.21.0.jar
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (SUREFIRE-2029) Parallel execution but surefire.forkNumber is the same
[
https://issues.apache.org/jira/browse/SUREFIRE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500368#comment-17500368
]
Falko Modler edited comment on SUREFIRE-2029 at 3/7/22, 10:50 AM:
--
I think I'm seeing something similar (with maven-surefire-plugin). Which Maven
version are you using?
_Edit: 3.8.4 on my side_
was (Author: famod):
I think I'm seeing something similar (with maven-surefire-plugin). Which Maven
version are you using?
> Parallel execution but surefire.forkNumber is the same
> --
>
> Key: SUREFIRE-2029
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2029
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Nathan McDonald
>Priority: Minor
>
> We have a multi module maven project, and due to our legacy architecture
> different modules are using the same underlying database.
> We are using the one db per fork strategy mentioned, and each test clears the
> database before running its test.
> This seems to work fine. But when running the full build on azure with:
> {noformat}
> mvn ... -T 1C -pl {modulesToBuild} -amd{noformat}
>
> See output kicking off build like:
> {noformat}
> [INFO] Using the MultiThreadedBuilder implementation with a thread count of
> 8{noformat}
>
> We occasionally see one long running test fail, and have traced cause that
> another test is running in parallel and clearing the database before long
> running test completes . This would only seem to be possible if parallel
> forks running but same surefire.forkNumber being set for multiple forks.
> Outputting logs of when tests start and end, with log outputting
> "Thread#$threadId\{$forkNumber}, e.g. Thread#7\{3} for thread with id 7,
> where surefire.forkNumber is 3
> Looking at logs we can see test starts on thread/fork 1, clears db as
> expected, and 30 seconds later logs that it completes (with error that is
> shown later).
> But we can see just moments later, another test starts up and also clears the
> database, but is using same thread/fork:
> {noformat}
> 2022-03-01T16:30:59.5953417Z 2022-03-01 16:30:59.585 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:30:59.7150510Z 2022-03-01 16:30:59.711 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:78 - Thread#1{1} - running
> setup for
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> …
> {noformat}
> 2022-03-01T16:31:01.1305751Z 2022-03-01 16:31:01.128 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:31:01.6123984Z [INFO] Tests run: 2, Failures: 0, Errors: 0,
> Skipped: 0, Time elapsed: 24.715 s - in
> e.t.b.h.w.c.FinancialStatementReportItemRestControllerIT
> 2022-03-01T16:31:01.6124965Z [INFO] Running
> e.t.b.h.w.c.KeyInformationRestControllerIT{noformat}
> …
> {noformat}
> 2022-03-01T16:31:29.1656587Z 2022-03-01 16:31:29.164 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:94 - Thread#1{1} - complete
> test
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> This isn't consistent though. Can see other cases where this works, but the
> logs found where it is working can see long running test running on separate
> fork:
> Thread#1\{3}
> Obviously there are separate threads/forks running here, so seems like
> somewhere between maven multi module and -T 1C, there is not always
> assigning unique forkNumber to each fork.
> I figure best practice is probably having separate modules not use same db,
> so possibly this issue is existing but not being hit by people as would only
> cause issue if same fork number used for separate modules on different
> databases.
> Still looking into issue our side will update if find workaround or more
> detailed information.
> Our surefire/failsafe config is in the root inherited by all other sub
> modules:
> {code:java}
>
>org.apache.maven.plugins
>maven-surefire-plugin
>
> 2
> @{argLine} -DforkNumber=${surefire.forkNumber}
> false
>
>
>
>org.apache.maven.plugins
>maven-failsafe-plugin
>
> 1
> @{argLine} -DforkNumber=${surefire.forkNumber}
> false
>
> ${project.build.directory}/surefire-reports
>
>
>
>
> integration-test
> verify
>
>
>
> {code}
> mvn version info:
> {noformat}
> Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f)
> Maven home: /usr/local/apache-maven
> Java version: 11.0.13, vendor: Red Hat, Inc., runtime:
> /usr/lib/jvm/java-11-openjdk-11.0.13.0.8-1.el7_9.x86_64
>
[GitHub] [maven-verifier] olamy merged pull request #8: fix Jira link
olamy merged pull request #8: URL: https://github.com/apache/maven-verifier/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1043) Get rid of JUnit4 dependency
[
https://issues.apache.org/jira/browse/MSHARED-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502174#comment-17502174
]
Konrad Windszus commented on MSHARED-1043:
--
All {{assertXYZ}} methods should probably be removed or moved to a dedicated
JUnit4 submodule. Only the {{verifyXYZ}} methods throwing the testing
framework agnostic {{VerificationException}} should be kept in the
{{Verifier}}. That requires a major version upgrade though, and probably
requires as first step deprecation of all {{assertXYZ}} methods in {{Verifier}}.
> Get rid of JUnit4 dependency
>
>
> Key: MSHARED-1043
> URL: https://issues.apache.org/jira/browse/MSHARED-1043
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-verifier
>Reporter: Konrad Windszus
>Priority: Major
>
> Maven verifier should be testing framework agnostic, but it currently has a
> dependency on JUnit4 due to assertions used in
> {{org.apache.maven.it.Verifier}}
> (https://github.com/apache/maven-verifier/blob/master/src/main/java/org/apache/maven/it/Verifier.java#L62)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MSHARED-1043) Get rid of JUnit4 dependency
Konrad Windszus created MSHARED-1043:
Summary: Get rid of JUnit4 dependency
Key: MSHARED-1043
URL: https://issues.apache.org/jira/browse/MSHARED-1043
Project: Maven Shared Components
Issue Type: Improvement
Components: maven-verifier
Reporter: Konrad Windszus
Maven verifier should be testing framework agnostic, but it currently has a
dependency on JUnit4 due to assertions used in {{org.apache.maven.it.Verifier}}
(https://github.com/apache/maven-verifier/blob/master/src/main/java/org/apache/maven/it/Verifier.java#L62)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
