[GitHub] [maven] laeubi commented on pull request #706: [MNG-7432] Proposed UT for maven-3.9.x and 3.8.x
laeubi commented on PR #706: URL: https://github.com/apache/maven/pull/706#issuecomment-1087121092 @michael-o whats the process here, should the test be included (with `@Ignore`) and then the fix with enabling it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MSHADE-417) Nul bytes appended to small files by maven-shade-plugin
[
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516607#comment-17516607
]
Max Zerzouri edited comment on MSHADE-417 at 4/4/22 3:05 AM:
-
bq. Not sure about your use case for null bytes, do you have some sample? Max
analyzis is right but also means we create a shade of nothing which sounds like
a project setup error.
As far as I can tell, this applies to normal usage of the shade plugin: reading
a file out of an existing jar and putting that file into a new jar.
When it's copying a file from an existing jar into the shaded jar, it checks to
see if the file within the jar is another zip/jar file, though I don't
understand the code enough or the problem involved in that PR to know why it
needs to have special handling for nested jars.
EDIT: looking into the error described in [MSHADE-378], I guess it's a
workaround for a limitation in some class loading used in Spring Boot, which
apparently requires nested jars to be uncompressed in the outer jar:
[JarFile.java:327|https://github.com/spring-projects/spring-boot/blob/ac93dc3252f36929dae41986d70ae9d091bb409f/spring-boot-project/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/jar/JarFile.java#L327]
was (Author: JIRAUSER287337):
bq. Not sure about your use case for null bytes, do you have some sample? Max
analyzis is right but also means we create a shade of nothing which sounds like
a project setup error.
As far as I can tell, this applies to normal usage of the shade plugin: reading
a file out of an existing jar and putting that file into a new jar.
When it's copying a file from an existing jar into the shaded jar, it checks to
see if the file within the jar is another zip/jar file, though I don't
understand the code enough or the problem involved in that PR to know why it
needs to have special handling for nested jars.
EDIT: looking into the error described in [MSHADE-378], I guess it's a
workaround for a limitation in some class loading used in Spring Boot, which
apparently requires nested jars to be uncompressed in the outer jar.
> Nul bytes appended to small files by maven-shade-plugin
> ---
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Max Zerzouri
>Priority: Major
> Attachments: original-shadetest-0.0.0.jar, pom.xml,
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> : 61 a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> : 6100 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in
> the previous version, 3.2.4.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MSHADE-417) Nul bytes appended to small files by maven-shade-plugin
[
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516607#comment-17516607
]
Max Zerzouri edited comment on MSHADE-417 at 4/4/22 2:51 AM:
-
bq. Not sure about your use case for null bytes, do you have some sample? Max
analyzis is right but also means we create a shade of nothing which sounds like
a project setup error.
As far as I can tell, this applies to normal usage of the shade plugin: reading
a file out of an existing jar and putting that file into a new jar.
When it's copying a file from an existing jar into the shaded jar, it checks to
see if the file within the jar is another zip/jar file, though I don't
understand the code enough or the problem involved in that PR to know why it
needs to have special handling for nested jars.
EDIT: looking into the error described in [MSHADE-378], I guess it's a
workaround for a limitation in some class loading used in Spring Boot, which
apparently requires nested jars to be uncompressed in the outer jar.
was (Author: JIRAUSER287337):
bq. Not sure about your use case for null bytes, do you have some sample? Max
analyzis is right but also means we create a shade of nothing which sounds like
a project setup error.
As far as I can tell, this applies to normal usage of the shade plugin: reading
a file out of an existing jar and putting that file into a new jar.
When it's copying a file from an existing jar into the shaded jar, it checks to
see if the file within the jar is another zip/jar file, though I don't
understand the code enough or the problem involved in that PR to know why it
needs to have special handling for nested jars.
> Nul bytes appended to small files by maven-shade-plugin
> ---
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Max Zerzouri
>Priority: Major
> Attachments: original-shadetest-0.0.0.jar, pom.xml,
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> : 61 a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> : 6100 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in
> the previous version, 3.2.4.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MSHADE-417) Nul bytes appended to small files by maven-shade-plugin
[
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516607#comment-17516607
]
Max Zerzouri commented on MSHADE-417:
-
bq. Not sure about your use case for null bytes, do you have some sample? Max
analyzis is right but also means we create a shade of nothing which sounds like
a project setup error.
As far as I can tell, this applies to normal usage of the shade plugin: reading
a file out of an existing jar and putting that file into a new jar.
When it's copying a file from an existing jar into the shaded jar, it checks to
see if the file within the jar is another zip/jar file, though I don't
understand the code enough or the problem involved in that PR to know why it
needs to have special handling for nested jars.
> Nul bytes appended to small files by maven-shade-plugin
> ---
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Max Zerzouri
>Priority: Major
> Attachments: original-shadetest-0.0.0.jar, pom.xml,
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> : 61 a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> : 6100 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in
> the previous version, 3.2.4.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-parent] slachiewicz commented on pull request #49: [MPOM-294] Remove surefire from Maven site reports
slachiewicz commented on PR #49: URL: https://github.com/apache/maven-parent/pull/49#issuecomment-1086995219 https://maven.apache.org/surefire/surefire-report.html i would say that report is empty becouse running test was disabled while site publish runs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] Tibor17 commented on pull request #49: [MPOM-294] Remove surefire from Maven site reports
Tibor17 commented on PR #49: URL: https://github.com/apache/maven-parent/pull/49#issuecomment-1086992301 @slachiewicz So, this zero report told me that we should ask the developer if the unit tests are really not interesting to write. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] slachiewicz commented on pull request #52: [MPOM-296] Remove pmd from Maven site reports
slachiewicz commented on PR #52: URL: https://github.com/apache/maven-parent/pull/52#issuecomment-1086990967 https://maven.apache.org/jxr/pmd.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] Tibor17 commented on pull request #53: [MPOM-297] Remove taglist from Maven site reports
Tibor17 commented on PR #53: URL: https://github.com/apache/maven-parent/pull/53#issuecomment-1086990716 Not the release mgt can do something about this report at the release time. The important is what happens after the release, in the next dev iteration... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] slachiewicz commented on pull request #51: [MPOM-295] Remove checkstyle from Maven site reports
slachiewicz commented on PR #51: URL: https://github.com/apache/maven-parent/pull/51#issuecomment-1086990371 https://maven.apache.org/wagon/checkstyle-aggregate.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] slachiewicz commented on pull request #49: [MPOM-294] Remove surefire from Maven site reports
slachiewicz commented on PR #49: URL: https://github.com/apache/maven-parent/pull/49#issuecomment-1086990134 https://maven.apache.org/wagon/surefire-report.html. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] belingueres opened a new pull request, #144: Fix [MNG-828]
belingueres opened a new pull request, #144: URL: https://github.com/apache/maven-integration-testing/pull/144 * Make datetime parsing Locale independent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] Tibor17 commented on pull request #49: [MPOM-294] Remove surefire from Maven site reports
Tibor17 commented on PR #49: URL: https://github.com/apache/maven-parent/pull/49#issuecomment-1086963530 hm, I do not understand his change. The CI result is used to fail due to Socket time out. The same has happened in the latest surefire result vote. The build was red, we tried to restart the build for 3 days, and finally the build has got green at the end of the Vote. Instead of removing the surefire report, we should adjust the process and the template should be changed and a new entry should be added along with Site link, SHA512, etc. If one report is going to be removed, there should be some substitution but mandatory substitution done in prior. This would improve the process while you prepare the release on your own, but this should not be all. This PR seems to be incomplete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on pull request #51: [MPOM-295] Remove checkstyle from Maven site reports
slawekjaranowski commented on PR #51: URL: https://github.com/apache/maven-parent/pull/51#issuecomment-1086956261 https://maven.apache.org/plugins/maven-clean-plugin/checkstyle.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters
slawekjaranowski commented on PR #705: URL: https://github.com/apache/maven/pull/705#issuecomment-1086955985 @belingueres I'm working on it. I will do fix for params with type like `List`, `arrays`, etc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] hboutemy commented on pull request #51: [MPOM-295] Remove checkstyle from Maven site reports
hboutemy commented on PR #51: URL: https://github.com/apache/maven-parent/pull/51#issuecomment-1086955259 > show empty page in our site report @slachiewicz what site do you call "our site"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #142: [MNG-828] add regression test for listing plugin configuration values in debug
slawekjaranowski commented on PR #142: URL: https://github.com/apache/maven-integration-testing/pull/142#issuecomment-1086952970 @belingueres PR are welcome -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] belingueres commented on pull request #142: [MNG-828] add regression test for listing plugin configuration values in debug
belingueres commented on PR #142: URL: https://github.com/apache/maven-integration-testing/pull/142#issuecomment-1086948665 Date parsing section of the test fails with a ParseException on my machine since AM/PM texts are Locale-dependent. Replace: ``` -Date date = new SimpleDateFormat( "-MM-dd HH:mm:ss.S a" ).parse( "2008-11-09 11:59:03.0 AM" ); +Date date = new SimpleDateFormat( "-MM-dd HH:mm:ss.S a", Locale.US ).parse( "2008-11-09 11:59:03.0 AM" ); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode
[
https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516592#comment-17516592
]
Gabriel Belingueres commented on MNG-828:
-
Date parsing section of the test fails with a ParseException on my machine
since AM/PM texts are Locale-dependent. Replace:
{color:#b21818}- Date date = new SimpleDateFormat( "-MM-dd
HH:mm:ss.S a" ).parse( "2008-11-09 11:59:03.0 AM" );{color}{color:#00}
{color}
{color:#18b218}+ Date date = new SimpleDateFormat( "-MM-dd
HH:mm:ss.S a", Locale.US ).parse( "2008-11-09 11:59:03.0 AM" );{color}
{color:#00} {color}
> log all mojo parameters and their populated values in debug mode
>
>
> Key: MNG-828
> URL: https://issues.apache.org/jira/browse/MNG-828
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
>Reporter: Brett Porter
>Assignee: Brett Porter
>Priority: Minor
> Fix For: 2.0 (RC)
>
>
> when we have this, we should remove the debugging code from plugins such as
> ear that do this manually.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-parent] slachiewicz commented on pull request #51: [MPOM-295] Remove checkstyle from Maven site reports
slachiewicz commented on pull request #51: URL: https://github.com/apache/maven-parent/pull/51#issuecomment-1086934746 +1 not useful to show empty page in our site report -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] slachiewicz commented on pull request #49: [MPOM-294] Remove surefire from Maven site reports
slachiewicz commented on pull request #49: URL: https://github.com/apache/maven-parent/pull/49#issuecomment-1086934483 Knowing that we would have new pom soon - any decisions here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516526#comment-17516526
]
Hudson commented on MPOM-314:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-parent » master #19
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/19/
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-36
>
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MPOM-314.
Resolution: Fixed
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-36
>
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-parent] slawekjaranowski merged pull request #61: [MPOM-314] Upgrade modello-maven-plugin from 1.11 to 2.0.0
slawekjaranowski merged pull request #61: URL: https://github.com/apache/maven-parent/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MPOM-314:
Assignee: Slawomir Jaranowski
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-36
>
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MPOM-314:
-
Fix Version/s: MAVEN-36
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-36
>
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516518#comment-17516518
]
Herve Boutemy commented on MPOM-314:
then no hesitation: just upgrade Modello to 2
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRESOLVER-247) Avoid unnecessary dependency resolution by a Skip solution based on BFS
[
https://issues.apache.org/jira/browse/MRESOLVER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516516#comment-17516516
]
Hudson commented on MRESOLVER-247:
--
Build succeeded in Jenkins: Maven » Maven TLP » maven-resolver » master #16
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/16/
> Avoid unnecessary dependency resolution by a Skip solution based on BFS
> ---
>
> Key: MRESOLVER-247
> URL: https://issues.apache.org/jira/browse/MRESOLVER-247
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Affects Versions: 1.7.3
>Reporter: wei cai
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.8.0
>
> Attachments: exclusion-matters.png, skip-duplicate.png,
> skip-version-conflicts.png
>
>
> h1. *Background*
> This Jira is related with MRESOLVER-240 and MRESOLVER-228
> There were discussions about the DFS or BFS algorithm for maven resolver in
> MRESOLVER-228, Changing to BFS would make MRESOLVER-228 & MRESOLVER-7 much
> easier to implement. Here is the plan for multiple changes requested recently:
> * DFS > BFS - preparation for parallel download
> * Skip approach - avoid unnecessary version resolution （Covered in this JIRA）
> * Download descriptors in parallel (MRESOLVER-7)
> h1. *The phenomenon*
> When comes to resolve the huge amount of dependencies of an enterprise level
> project, the maven resolver is very slow to resolve the dependency
> graph/tree. Take one of our app as example, it could take *10minutes+ and 16G
> memory* to print out the result of {*}mvn dependency:tree{*}.
> This is because there are many dependencies declared in the project, and some
> of the dependencies would introduce *600+* transitive dependencies, and
> exclusions are widely used to solve dependency conflicts.
> By checking the
> [code|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L500],
> we know the exclusion is also part of the cache key. This means when the
> exclusions up the tree differs, the cached resolution result for the same GAV
> won't be picked up and need s to be recalculated.
>
> !exclusion-matters.png!
>
> From above figure, we know:
> * In 1st case, D will be resolved only once as there are no exclusions/same
> exclusions up the tree.
> * In 2nd case, the B and C have different exclusions and D needs to be
> recalculated, if D is a heavy dependency which introduce many transitive
> dependencies, all D and its children (D & E in this case) need to be
> recalculated. Recalculating all of these nodes introduces 2 issues:
> ** Slow in resolving dependencies.
> ** Lots of DependencyNodes cached (all calculated/recalculated nodes would
> be cached) and will consume huge memory.
> h1. Solution
> To improve the speed of maven resolver's dependency resolution, I
> implemented a skip approach to avoid unnecessary dependency resolution.
> h2. *CASE 1: Skip duplicate node (omitted duplicate case in dependency tree)*
> !skip-duplicate.png!
> From above figure:
> * The R#3 is resolved at depth 2, in the BFS solution, we already know R#3
> is the winner.
> * The R#5 won't be the winner, however here we force resolved this node as
> it is more left than the last resolved R#3 node. This is because maven picks
> up widest scope present among conflicting dependencies (scopes of the
> conflicts may differ), we need to *retain the conflict paths* by using a
> strategy like:
> ** R#3 locates in coordinate (2 - depth, 2 - sequence in given depth) while
> R#5 locates in (3,1), R#5 is more left than R#3, so we need to force resolve
> R#5.
> ** If there is a R#6 which is more left than R#5, then need to force resolve
> R#6.
> * The R#8 is at depth 3 and the R#12 at depth 4 are simply skipped as R#3 is
> already resolved at depth 2. This is because the same node with deeper depth
> won't be picked up by maven as maven employs a "nearest transitive dependency
> in the tree depth and the first in resolution" strategy.
> h2. *CASE 2: Skip version conflict (omitted conflict case in dependency tree)*
> *!skip-version-conflicts.png!*
> In above figure.
> * The D1 (D with version 1, #4) is resolved, in the BFS solution, we already
> know D1 is the winner
> * When comes to resolve D2 (D with version 2, after #4), we know D2 is
> having a different version and it conflicts with D1, D2 will be skipped as it
> won't be picked up by maven, all D2's children *won't be resolved* then.
> After we enabled the resolver patch in maven, we are seeing 10% ~70% build
> time reduced for different projects depend on how complex the dependencies
> are, and the
[jira] [Commented] (MCOMPILER-489) User property for multiReleaseOutput
[ https://issues.apache.org/jira/browse/MCOMPILER-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516515#comment-17516515 ] Robert Scholte commented on MCOMPILER-489: -- This would turn the parameter into a variable(adjustable via commandline) and that doesn't make sense to me. In case of multirelease in general you need to execute the compiler multiple times. I would expect once for Java 8 where multiReleaseOutput is false, for the others it must be true. > User property for multiReleaseOutput > > > Key: MCOMPILER-489 > URL: https://issues.apache.org/jira/browse/MCOMPILER-489 > Project: Maven Compiler Plugin > Issue Type: Improvement >Reporter: John Patrick >Priority: Minor > Labels: CompilerOptions > > Add support so multiReleaseOutput can be provided as a user property. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-resolver] asfgit closed pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
asfgit closed pull request #158: URL: https://github.com/apache/maven-resolver/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1086884203 @caiwei-ebay Can you first please pick up this PR #160 to make it coexist? I will merge this is a few moments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-417) Nul bytes appended to small files by maven-shade-plugin
[
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516511#comment-17516511
]
Herve Boutemy commented on MSHADE-417:
--
shade is not really a classical packaging plugin, packaging files from disk to
an archive
if you want to do more than bug fixing but fully reworking SHADE-387 or even
the whole plugin, that's not the same question
> Nul bytes appended to small files by maven-shade-plugin
> ---
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Max Zerzouri
>Priority: Major
> Attachments: original-shadetest-0.0.0.jar, pom.xml,
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> : 61 a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> : 6100 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in
> the previous version, 3.2.4.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] slawekjaranowski commented on a change in pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters
slawekjaranowski commented on a change in pull request #705:
URL: https://github.com/apache/maven/pull/705#discussion_r841217441
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##
@@ -70,7 +85,7 @@ public void notifyFieldChangeUsingSetter( String fieldName,
Object value, Object
{
delegate.notifyFieldChangeUsingSetter( fieldName, value, target );
-if ( mojo == target )
+if ( mojo == target && value != null )
Review comment:
Probably some my test ... not needed to move
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##
@@ -80,18 +95,83 @@ public void notifyFieldChangeUsingReflection( String
fieldName, Object value, Ob
{
delegate.notifyFieldChangeUsingReflection( fieldName, value, target );
-if ( mojo == target )
+if ( mojo == target && value != null )
{
notify( fieldName, value );
}
}
private void notify( String fieldName, Object value )
{
-if ( value != null )
+missingParameters.remove( fieldName );
+
+if ( logger.isWarnEnabled() )
+{
+warnDeprecated( fieldName, value );
+}
+}
+
+private void warnDeprecated( String fieldName, Object value )
+{
+Parameter parameter = mojoDescriptor.getParameterMap().get( fieldName
);
+String deprecated = parameter.getDeprecated();
+if ( deprecated != null && !deprecated.isEmpty() )
+{
+Object defaultValue = evaluateValue( parameter.getDefaultValue() );
+if ( !toString( value ).equals( toString( defaultValue ) ) )
Review comment:
In order to not print warning for params with default value with
properties and not set in plugin configuration.
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##
@@ -80,18 +95,83 @@ public void notifyFieldChangeUsingReflection( String
fieldName, Object value, Ob
{
delegate.notifyFieldChangeUsingReflection( fieldName, value, target );
-if ( mojo == target )
+if ( mojo == target && value != null )
{
notify( fieldName, value );
}
}
private void notify( String fieldName, Object value )
{
-if ( value != null )
+missingParameters.remove( fieldName );
+
+if ( logger.isWarnEnabled() )
+{
+warnDeprecated( fieldName, value );
+}
+}
+
+private void warnDeprecated( String fieldName, Object value )
+{
+Parameter parameter = mojoDescriptor.getParameterMap().get( fieldName
);
+String deprecated = parameter.getDeprecated();
+if ( deprecated != null && !deprecated.isEmpty() )
+{
+Object defaultValue = evaluateValue( parameter.getDefaultValue() );
+if ( !toString( value ).equals( toString( defaultValue ) ) )
+{
+StringBuilder sb = new StringBuilder( " Parameter '" );
+sb.append( fieldName ).append( '\'' );
+if ( parameter.getExpression() != null )
+{
+String userProperty = parameter.getExpression().replace(
"${", "'" ).replace( '}', '\'' );
+sb.append( " (User Property " ).append( userProperty
).append( ")" );
+}
+sb.append( " is deprecated. " ).append( deprecated );
+
+logger.warn( MessageUtils.buffer().warning( sb.toString()
).toString() );
+}
+}
+}
+
+private Object evaluateValue( String value )
+{
+try
{
-missingParameters.remove( fieldName );
+return expressionEvaluator.evaluate( value );
}
+catch ( ExpressionEvaluationException e )
+{
+// should not happen here
+}
+return value;
}
+/**
+ * Creates a human-friendly string representation of the specified object.
+ *
+ * @param obj The object to create a string representation for, may be
null.
+ * @return The string representation, never null.
+ */
+private static String toString( Object obj )
+{
+String str;
+if ( obj != null && obj.getClass().isArray() )
+{
+int n = Array.getLength( obj );
+StringBuilder buf = new StringBuilder( 256 );
+StringJoiner sj = new StringJoiner( ", ", "[", "]" );
+for ( int i = 0; i < n; i++ )
+{
+sj.add( String.valueOf( Array.get( obj, i ) ) );
+}
+buf.append( sj.toString() );
Review comment:
code copied from `DebugConfigurationListener#toString` and use
`StringJoiner` .. to fix
##
File path:
[jira] [Comment Edited] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516504#comment-17516504
]
Slawomir Jaranowski edited comment on MPOM-314 at 4/3/22 12:34 PM:
---
Java 8 is already required by ASF parent from version 24 - MPOM-263
was (Author: slawekjaranowski):
Java 8 is already required by AFS parent from version 24 - MPOM-263
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516504#comment-17516504
]
Slawomir Jaranowski commented on MPOM-314:
--
Java 8 is already required by AFS parent from version 24 - MPOM-263
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MPOM-314:
-
Component/s: maven
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
> Components: maven
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1086855540 > There is obviously a slight improvement, but not in my setup. I agree with @cstamas that DFS should stay default, both switchable until we get a clearer picture. @michael-o @cstamas Sure. Thank you! Not sure if @ibabiankou has time to continue on the parallel downloading patch based on BFS approach. @ibabiankou Would you mind if I implement it for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] caiwei-ebay commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
caiwei-ebay commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1086855540 > There is obviously a slight improvement, but not in my setup. I agree with @cstamas that DFS should stay default, both switchable until we get a clearer picture. @michael-o @cstamas Sure. Thank you! Not sure if @ibabiankou has time to continue on the parallel downloading patch based on BFS approach. @ibabiankou Would you mind if I implement it for you? _This is caiwei-ebay. I have to use this github account to post the thread as I don't have 2FA for that account as of now._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516499#comment-17516499
]
Herve Boutemy commented on MPOM-314:
Yes, the Java 8 prerequisite is the only reason why we switched to Modello 2
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] delanym opened a new pull request #505: [SUREFIRE-2055] Always show random seed
delanym opened a new pull request #505: URL: https://github.com/apache/maven-surefire/pull/505 Always show the random seed when using the random runOrder. This is so tests that fail because of their runOrder can be replayed without necessarily knowing the build command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516495#comment-17516495
]
Michael Osipov commented on MPOM-314:
-
The the POM should also require Java 8 if it does not already.
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] michael-o commented on a change in pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters
michael-o commented on a change in pull request #705:
URL: https://github.com/apache/maven/pull/705#discussion_r841205390
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##
@@ -80,18 +95,83 @@ public void notifyFieldChangeUsingReflection( String
fieldName, Object value, Ob
{
delegate.notifyFieldChangeUsingReflection( fieldName, value, target );
-if ( mojo == target )
+if ( mojo == target && value != null )
{
notify( fieldName, value );
}
}
private void notify( String fieldName, Object value )
{
-if ( value != null )
+missingParameters.remove( fieldName );
+
+if ( logger.isWarnEnabled() )
+{
+warnDeprecated( fieldName, value );
+}
+}
+
+private void warnDeprecated( String fieldName, Object value )
+{
+Parameter parameter = mojoDescriptor.getParameterMap().get( fieldName
);
+String deprecated = parameter.getDeprecated();
+if ( deprecated != null && !deprecated.isEmpty() )
+{
+Object defaultValue = evaluateValue( parameter.getDefaultValue() );
+if ( !toString( value ).equals( toString( defaultValue ) ) )
+{
+StringBuilder sb = new StringBuilder( " Parameter '" );
+sb.append( fieldName ).append( '\'' );
+if ( parameter.getExpression() != null )
+{
+String userProperty = parameter.getExpression().replace(
"${", "'" ).replace( '}', '\'' );
+sb.append( " (User Property " ).append( userProperty
).append( ")" );
+}
+sb.append( " is deprecated. " ).append( deprecated );
Review comment:
You haven't even evaluated the content of `deprecated`, how do you know
then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters
michael-o commented on a change in pull request #705:
URL: https://github.com/apache/maven/pull/705#discussion_r841205299
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##
@@ -80,18 +95,83 @@ public void notifyFieldChangeUsingReflection( String
fieldName, Object value, Ob
{
delegate.notifyFieldChangeUsingReflection( fieldName, value, target );
-if ( mojo == target )
+if ( mojo == target && value != null )
{
notify( fieldName, value );
}
}
private void notify( String fieldName, Object value )
{
-if ( value != null )
+missingParameters.remove( fieldName );
+
+if ( logger.isWarnEnabled() )
+{
+warnDeprecated( fieldName, value );
+}
+}
+
+private void warnDeprecated( String fieldName, Object value )
+{
+Parameter parameter = mojoDescriptor.getParameterMap().get( fieldName
);
+String deprecated = parameter.getDeprecated();
+if ( deprecated != null && !deprecated.isEmpty() )
+{
+Object defaultValue = evaluateValue( parameter.getDefaultValue() );
+if ( !toString( value ).equals( toString( defaultValue ) ) )
Review comment:
Why does the dafault value matter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters
michael-o commented on a change in pull request #705:
URL: https://github.com/apache/maven/pull/705#discussion_r841205101
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##
@@ -80,18 +95,83 @@ public void notifyFieldChangeUsingReflection( String
fieldName, Object value, Ob
{
delegate.notifyFieldChangeUsingReflection( fieldName, value, target );
-if ( mojo == target )
+if ( mojo == target && value != null )
{
notify( fieldName, value );
}
}
private void notify( String fieldName, Object value )
{
-if ( value != null )
+missingParameters.remove( fieldName );
+
+if ( logger.isWarnEnabled() )
+{
+warnDeprecated( fieldName, value );
+}
+}
+
+private void warnDeprecated( String fieldName, Object value )
+{
+Parameter parameter = mojoDescriptor.getParameterMap().get( fieldName
);
+String deprecated = parameter.getDeprecated();
+if ( deprecated != null && !deprecated.isEmpty() )
+{
+Object defaultValue = evaluateValue( parameter.getDefaultValue() );
+if ( !toString( value ).equals( toString( defaultValue ) ) )
+{
+StringBuilder sb = new StringBuilder( " Parameter '" );
+sb.append( fieldName ).append( '\'' );
+if ( parameter.getExpression() != null )
+{
+String userProperty = parameter.getExpression().replace(
"${", "'" ).replace( '}', '\'' );
+sb.append( " (User Property " ).append( userProperty
).append( ")" );
+}
+sb.append( " is deprecated. " ).append( deprecated );
+
+logger.warn( MessageUtils.buffer().warning( sb.toString()
).toString() );
+}
+}
+}
+
+private Object evaluateValue( String value )
+{
+try
{
-missingParameters.remove( fieldName );
+return expressionEvaluator.evaluate( value );
}
+catch ( ExpressionEvaluationException e )
+{
+// should not happen here
+}
+return value;
}
+/**
+ * Creates a human-friendly string representation of the specified object.
+ *
+ * @param obj The object to create a string representation for, may be
null.
+ * @return The string representation, never null.
+ */
+private static String toString( Object obj )
+{
+String str;
+if ( obj != null && obj.getClass().isArray() )
+{
+int n = Array.getLength( obj );
+StringBuilder buf = new StringBuilder( 256 );
+StringJoiner sj = new StringJoiner( ", ", "[", "]" );
+for ( int i = 0; i < n; i++ )
+{
+sj.add( String.valueOf( Array.get( obj, i ) ) );
+}
+buf.append( sj.toString() );
Review comment:
Why do you need `buf` if there is only one append?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters
michael-o commented on a change in pull request #705:
URL: https://github.com/apache/maven/pull/705#discussion_r841204414
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##
@@ -70,7 +85,7 @@ public void notifyFieldChangeUsingSetter( String fieldName,
Object value, Object
{
delegate.notifyFieldChangeUsingSetter( fieldName, value, target );
-if ( mojo == target )
+if ( mojo == target && value != null )
Review comment:
Why move here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters
michael-o commented on a change in pull request #705:
URL: https://github.com/apache/maven/pull/705#discussion_r841204414
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##
@@ -70,7 +85,7 @@ public void notifyFieldChangeUsingSetter( String fieldName,
Object value, Object
{
delegate.notifyFieldChangeUsingSetter( fieldName, value, target );
-if ( mojo == target )
+if ( mojo == target && value != null )
Review comment:
Why this null check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (SUREFIRE-2055) Always show random seed
Delany created SUREFIRE-2055: Summary: Always show random seed Key: SUREFIRE-2055 URL: https://issues.apache.org/jira/browse/SUREFIRE-2055 Project: Maven Surefire Issue Type: Improvement Components: Maven Surefire Plugin Affects Versions: 3.0.0-M6 Reporter: Delany When I run tests in random order I get the message "Tests will run in random order. To reproduce ordering use flag -Dsurefire.runOrder.random.seed=55174043965113" When I provide the seed, I don't get the message, so there's no record of the seed in the log. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (WAGON-616) Deprecate Wagon SSH Provider
[
https://issues.apache.org/jira/browse/WAGON-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495720#comment-17495720
]
Michael Osipov edited comment on WAGON-616 at 4/3/22 10:54 AM:
---
Provider:
https://maven.apache.org/wagon/wagon-providers/wagon-ssh-external/index.html
Additionally to the issues in the description: I have been the sole maintainer
of Wagon for past four years, it requires a tremendous amount of time to
understand issues and properly fix them. Given that millions use it and almost
no one aids me, it pushes me into a position that it simply makes no sense to
support multiple providers for the same protocol if there is virtually no
benefit. SSH is here to stay, for whatever reasons you are using it. The
OpenBSD team supports OpenSSH, we wrap it. Minimal effort. Given that a rewrite
to Apache MINA will require a lot of time, I won't do unless someone is willing
to pay for it. Most of the discussions happened internally that we don't want
to support multiple routes and need to minimize our effort. We also have this:
https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup
was (Author: michael-o):
Provider:
https://maven.apache.org/wagon/wagon-providers/wagon-ssh-external/index.html
Additionally to the issues in the description: I have been the sole maintainer
of Wagon for past four years, it requires a tremendous amount of time to
understand issues and properly fix them. Given that millions use it and almost
no one aids me, it pushes me into a position that it simply makes no sense to
support multiple providers for the same protocol if there is virtually no
benefit. SSH is here to stay, for whatehver reasons you are using it. The
OpenBSD team supports OpenSSH, we wrap it. Minimal effort. Given that a rewrite
to Apache MINA will require a lot of time, I won't do unless someone is willing
to pay for it. Most of the discussions happened internally that we don't want
to support multiple routes and need to minimize our effort. We also have this:
https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup
> Deprecate Wagon SSH Provider
>
>
> Key: WAGON-616
> URL: https://issues.apache.org/jira/browse/WAGON-616
> Project: Maven Wagon
> Issue Type: Task
> Components: wagon-ssh
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.5.0
>
>
> This provider has serious implications and implementation issues:
> - JSch http://www.jcraft.com/jsch/ failed to provide a source repository,
> accept contributions and address issues.
> - Too complex and low level.
> - It is disputed whether this is open source at all.
> The sshexe ({{scp}}) provider remains until someone wants to write something
> on top of Apache MINA SSHD.
> We are deprecating this provider to be removed in 4.0.0.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] slawekjaranowski commented on pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters
slawekjaranowski commented on pull request #705: URL: https://github.com/apache/maven/pull/705#issuecomment-1086835519 before merge commits will be squashed - I only wanted to show my change to original contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1086835372 Measured with: ``` time /tmp/apache-maven-4.0.0-alpha-1-SNAPSHOT-$type/bin/mvn clean package -DskipTests -Dmaven.repo.local=repo-$type -Drat.skip ``` Maven with three modified Resolvers: ``` Apache Maven 4.0.0-alpha-1-SNAPSHOT (d92538b80f302fc40530468efe7ca7bf63b7ba52) Maven home: /tmp/apache-maven-4.0.0-alpha-1-SNAPSHOT-dfs Java version: 1.8.0_312, vendor: OpenJDK BSD Porting Team, runtime: /usr/local/openjdk8/jre Default locale: de_DE, platform encoding: UTF-8 OS name: "freebsd", version: "12.3-stable", arch: "amd64", family: "unix" ``` CPU: ``` $ sysctl hw.model | grep Intel hw.model: Intel(R) Xeon(R) CPU E5-2640 v4 @ 2.40GHz ``` There is obviously a slight improvement, but not in my setup. I agree with @cstamas that DFS should stay default, both switchable until we get a clearer picture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1086835372 Measured with: ``` time /tmp/apache-maven-4.0.0-alpha-1-SNAPSHOT-$type/bin/mvn clean package -DskipTests -Dmaven.repo.local=repo-$type -Drat.skip Apache Maven 4.0.0-alpha-1-SNAPSHOT (d92538b80f302fc40530468efe7ca7bf63b7ba52) Maven home: /tmp/apache-maven-4.0.0-alpha-1-SNAPSHOT-dfs Java version: 1.8.0_312, vendor: OpenJDK BSD Porting Team, runtime: /usr/local/openjdk8/jre Default locale: de_DE, platform encoding: UTF-8 OS name: "freebsd", version: "12.3-stable", arch: "amd64", family: "unix" $ sysctl hw.model | grep Intel hw.model: Intel(R) Xeon(R) CPU E5-2640 v4 @ 2.40GHz ``` There is obviously a slight improvement, but not in my setup. I agree with @cstamas that DFS should stay default, both switchable until we get a clearer picture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1086834944 Applied to the same project: ``` DFS: real0m8,572s user0m36,779s sys 0m2,146s real0m8,836s user0m36,965s sys 0m2,263s real0m9,503s user0m38,102s sys 0m1,894s files 3781/size 149475589 BFS: real0m9,197s user0m39,057s sys 0m2,029s real0m8,990s user0m40,182s sys 0m2,208s real0m10,089s user0m39,784s sys 0m2,282s real0m9,368s user0m38,168s sys 0m1,956s files 3781/149475589 BFS+Skip: real0m7,626s user0m36,197s sys 0m1,841s real0m7,854s user0m36,422s sys 0m1,866s real0m7,691s user0m36,856s sys 0m1,881s files 3469/148963737 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1086833583 Applied to Maven master: ``` DFS: real0m46,534s user3m22,501s sys 0m9,949s real0m47,781s user3m28,036s sys 0m9,140s real0m45,600s user3m28,505s sys 0m9,094s real0m45,897s user3m22,993s sys 0m9,688s files 5956/size 117773603 BFS: real0m46,439s user3m29,663s sys 0m9,719s real0m46,493s user3m28,344s sys 0m10,211s real0m45,420s user3m25,507s sys 0m9,739s real0m46,235s user3m22,838s sys 0m9,855s files 5910/117358698 BFS+Skip: real0m49,960s user3m32,234s sys 0m9,616s real0m47,292s user3m27,262s sys 0m9,852s real0m46,010s user3m26,432s sys 0m9,429s real0m47,018s user3m28,777s sys 0m9,604s files 5742/117195446 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1086833583 Applied to Maven master: DFS: real0m46,534s user3m22,501s sys 0m9,949s real0m47,781s user3m28,036s sys 0m9,140s real0m45,600s user3m28,505s sys 0m9,094s real0m45,897s user3m22,993s sys 0m9,688s files 5956/size 117773603 BFS: real0m46,439s user3m29,663s sys 0m9,719s real0m46,493s user3m28,344s sys 0m10,211s real0m45,420s user3m25,507s sys 0m9,739s real0m46,235s user3m22,838s sys 0m9,855s files 5910/117358698 BFS+Skip: real0m49,960s user3m32,234s sys 0m9,616s real0m47,292s user3m27,262s sys 0m9,852s real0m46,010s user3m26,432s sys 0m9,429s real0m47,018s user3m28,777s sys 0m9,604s files 5742/117195446 Testing on the demo project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-417) Nul bytes appended to small files by maven-shade-plugin
[
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516486#comment-17516486
]
Michael Osipov commented on MSHADE-417:
---
[~hboutemy], it is not related to this bug. The point I am trying to make it
that:
* The library used is inconsistent with other packaging plugins,
* It changes a lot of metadata and this I consider plain wrong.
> Nul bytes appended to small files by maven-shade-plugin
> ---
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Max Zerzouri
>Priority: Major
> Attachments: original-shadetest-0.0.0.jar, pom.xml,
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> : 61 a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> : 6100 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in
> the previous version, 3.2.4.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MRELEASE-1080) Maven 3.8.4 exits with non-zero status from release:perform or :prepare even when successful
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516485#comment-17516485 ] Michael Osipov commented on MRELEASE-1080: -- [~L.Viegas], there is a decent workaround to how deal with this issue until it is fixed upstream. Any reason not to use it? > Maven 3.8.4 exits with non-zero status from release:perform or :prepare even > when successful > > > Key: MRELEASE-1080 > URL: https://issues.apache.org/jira/browse/MRELEASE-1080 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform, prepare >Affects Versions: 3.0.0-M5 > Environment: Windows 10, Git for Windows Bourne Again Shell, Maven > 3.8.4 >Reporter: Mirko Klemm >Assignee: Michael Osipov >Priority: Major > Labels: exit, shell > Fix For: 3.0.0-M6 > > > When doing a "release:prepare" or "release:perform", the maven process always > exits with a shell exit status of 1, even when the goal has finished with a > "BUILD SUCCESS" message, where it actually should return 0. > This doesn't seem to have been the case with 2.x versions of the plugin. > This is an important bug since it messes up using maven and the release > plugin in shell scripts. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
[
https://issues.apache.org/jira/browse/MPOM-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MPOM-314:
-
Description:
Release notes:
[https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
For {{modello-maven-plugin}} params: {{useJava5}}
changed to: {{javaSource}} -
[https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
{{Maven Core}} use version 2.0.0
was:
Release notes:
[https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
For {{modello-maven-plugin}} params: {{useJava5}}
changed to: {{javaSource}} -
[https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> Upgrade modello-maven-plugin from 1.11 to 2.0.0
> ---
>
> Key: MPOM-314
> URL: https://issues.apache.org/jira/browse/MPOM-314
> Project: Maven POMs
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Release notes:
> [https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
> For {{modello-maven-plugin}} params: {{useJava5}}
> changed to: {{javaSource}} -
> [https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
> {{Maven Core}} use version 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (SUREFIRE-2054) Support pluggable starters
Christoph Läubrich created SUREFIRE-2054: Summary: Support pluggable starters Key: SUREFIRE-2054 URL: https://issues.apache.org/jira/browse/SUREFIRE-2054 Project: Maven Surefire Issue Type: Improvement Reporter: Christoph Läubrich Currently Surefire has two (internal) Starters: Forked: https://github.com/apache/maven-surefire/blob/daf717e65716e3e77951757596c11d83754338e2/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2437 InProcess: https://github.com/apache/maven-surefire/blob/daf717e65716e3e77951757596c11d83754338e2/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2454 [Tycho|https://www.eclipse.org/tycho/sitedocs/tycho-surefire-plugin/plugin-info.html] (and [BND|https://github.com/bndtools/bnd/tree/master/maven/bnd-testing-maven-plugin]) both offer "surefire-like" plugins that internally use surefire/junit. I think this is a bit wasted effort, as actually most parts of surefire (configuration and alike) could simply be reused, both plugins simply need a mean to start the process differently. My idea would be to make the Starters plugable, like one can plug in different platforms. Lookin at both Forked/InProcess the share a lot of common parameters and the run methods only differ in passing the effectiveProperties. So I think it should be possible to derive a common "SurefireStarter" interface that an extender has to implement togehter with a "SurefireStarterFactory" that is used to construct such a starter passing the necessary information (e.g. the AbstractSurefireMojo and selected providers and so on...). Of course this would be more an SPI than a API and result in rather tightly coupled plugins, but could make all this more reusable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (JXR-169) Use of deprecated velocity configuration keys
[
https://issues.apache.org/jira/browse/JXR-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516483#comment-17516483
]
Slawomir Jaranowski commented on JXR-169:
-
[~michael-o] Are there issues for Doxia which can be linked for track?
> Use of deprecated velocity configuration keys
> --
>
> Key: JXR-169
> URL: https://issues.apache.org/jira/browse/JXR-169
> Project: Maven JXR
> Issue Type: Improvement
> Components: maven2 jxr plugin
>Affects Versions: 3.2.0
>Reporter: Dave Wichers
>Priority: Minor
>
> When I run: mvn site, using my project's pom:
> [https://github.com/nahsra/antisamy/blob/main/pom.xml]
> I'm seeing the following warnings. I think this means these jxr-plugins are
> using old resource names. Unless I'm doing something wrong in my pom. But I
> can't find any references to these resources in my project, so I'm assuming
> its a problem in your project. Can you confirm this is an issue in maven-jxr
> and you can fix it? Or is it my fault?
> The velocity configuration key changes are described here:
> https://velocity.apache.org/engine/devel/configuration-property-changes-in-2.1.html
> [*INFO*] Generating "{*}Source Xref{*}" report *---*
> maven-jxr-plugin:3.2.0:jxr
> [*WARNING*] configuration key 'resource.loader' has been deprecated in favor
> of 'resource.loaders'
> [*WARNING*] configuration key 'classpath.resource.loader.class' has been
> deprecated in favor of 'resource.loader.classpath.class'
> [*WARNING*] configuration key 'velocimacro.library' has been deprecated in
> favor of 'velocimacro.library.path'
> [*INFO*] Generating "{*}Test Source Xref{*}" report *---*
> maven-jxr-plugin:3.2.0:test-jxr
> [*WARNING*] configuration key 'resource.loader' has been deprecated in favor
> of 'resource.loaders'
> [*WARNING*] configuration key 'classpath.resource.loader.class' has been
> deprecated in favor of 'resource.loader.classpath.class'
> [*WARNING*] configuration key 'velocimacro.library' has been deprecated in
> favor of 'velocimacro.library.path'
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-parent] dependabot[bot] commented on pull request #47: Bump modello-maven-plugin from 1.11 to 2.0.0
dependabot[bot] commented on pull request #47: URL: https://github.com/apache/maven-parent/pull/47#issuecomment-1086820382 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski closed pull request #47: Bump modello-maven-plugin from 1.11 to 2.0.0
slawekjaranowski closed pull request #47: URL: https://github.com/apache/maven-parent/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on pull request #47: Bump modello-maven-plugin from 1.11 to 2.0.0
slawekjaranowski commented on pull request #47: URL: https://github.com/apache/maven-parent/pull/47#issuecomment-1086820377 Should be done manually - configuration params was changed. https://issues.apache.org/jira/browse/MPOM-314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPOM-314) Upgrade modello-maven-plugin from 1.11 to 2.0.0
Slawomir Jaranowski created MPOM-314:
Summary: Upgrade modello-maven-plugin from 1.11 to 2.0.0
Key: MPOM-314
URL: https://issues.apache.org/jira/browse/MPOM-314
Project: Maven POMs
Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski
Release notes:
[https://github.com/codehaus-plexus/modello/releases/tag/modello-2.0.0]
For {{modello-maven-plugin}} params: {{useJava5}}
changed to: {{javaSource}} -
[https://codehaus-plexus.github.io/modello/modello-maven-plugin/java-mojo.html#javaSource]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JXR-169) Use of deprecated velocity configuration keys
[
https://issues.apache.org/jira/browse/JXR-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516481#comment-17516481
]
Michael Osipov commented on JXR-169:
Doxia in general will move to Velocity 2.x in version 2. Though, this will take
time.
> Use of deprecated velocity configuration keys
> --
>
> Key: JXR-169
> URL: https://issues.apache.org/jira/browse/JXR-169
> Project: Maven JXR
> Issue Type: Improvement
> Components: maven2 jxr plugin
>Affects Versions: 3.2.0
>Reporter: Dave Wichers
>Priority: Minor
>
> When I run: mvn site, using my project's pom:
> [https://github.com/nahsra/antisamy/blob/main/pom.xml]
> I'm seeing the following warnings. I think this means these jxr-plugins are
> using old resource names. Unless I'm doing something wrong in my pom. But I
> can't find any references to these resources in my project, so I'm assuming
> its a problem in your project. Can you confirm this is an issue in maven-jxr
> and you can fix it? Or is it my fault?
> The velocity configuration key changes are described here:
> https://velocity.apache.org/engine/devel/configuration-property-changes-in-2.1.html
> [*INFO*] Generating "{*}Source Xref{*}" report *---*
> maven-jxr-plugin:3.2.0:jxr
> [*WARNING*] configuration key 'resource.loader' has been deprecated in favor
> of 'resource.loaders'
> [*WARNING*] configuration key 'classpath.resource.loader.class' has been
> deprecated in favor of 'resource.loader.classpath.class'
> [*WARNING*] configuration key 'velocimacro.library' has been deprecated in
> favor of 'velocimacro.library.path'
> [*INFO*] Generating "{*}Test Source Xref{*}" report *---*
> maven-jxr-plugin:3.2.0:test-jxr
> [*WARNING*] configuration key 'resource.loader' has been deprecated in favor
> of 'resource.loaders'
> [*WARNING*] configuration key 'classpath.resource.loader.class' has been
> deprecated in favor of 'resource.loader.classpath.class'
> [*WARNING*] configuration key 'velocimacro.library' has been deprecated in
> favor of 'velocimacro.library.path'
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-resolver] michael-o commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1086816709 Testing now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1084978033 > @michael-o @cstamas @jebeaudet Created a sample project to demonstrate the maven resolver slowness when comes to resolve duplicate dependencies (same GAV) with different exclusions or version conflict dependencies. And also shared the performance test result w/ the BFS + Skipper patch in below repository. > > https://github.com/caiwei-ebay/slowprojectdemo I will try this tomorrow. Unfortunately, @ibabiankou is out of reach. If I don't hear any objections, I am going to merge this this weekend then @cstamas can work on top to create a switch between DFS and BFS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-313) Execute checkstyle in early phase of the build
[ https://issues.apache.org/jira/browse/MPOM-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516469#comment-17516469 ] Hudson commented on MPOM-313: - Build succeeded in Jenkins: Maven » Maven TLP » maven-parent » master #18 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/18/ > Execute checkstyle in early phase of the build > -- > > Key: MPOM-313 > URL: https://issues.apache.org/jira/browse/MPOM-313 > Project: Maven POMs > Issue Type: Improvement > Components: maven >Reporter: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-36 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (MPOM-313) Execute checkstyle in early phase of the build
[ https://issues.apache.org/jira/browse/MPOM-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MPOM-313: Assignee: Slawomir Jaranowski > Execute checkstyle in early phase of the build > -- > > Key: MPOM-313 > URL: https://issues.apache.org/jira/browse/MPOM-313 > Project: Maven POMs > Issue Type: Improvement > Components: maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-36 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MPOM-313) Execute checkstyle in early phase of the build
[ https://issues.apache.org/jira/browse/MPOM-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-313. Resolution: Fixed > Execute checkstyle in early phase of the build > -- > > Key: MPOM-313 > URL: https://issues.apache.org/jira/browse/MPOM-313 > Project: Maven POMs > Issue Type: Improvement > Components: maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-36 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-parent] slawekjaranowski merged pull request #55: [MPOM-313] execute checkstyle in early phase of the build
slawekjaranowski merged pull request #55: URL: https://github.com/apache/maven-parent/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-305) Set minimum enforced Maven version to 3.2.5
[ https://issues.apache.org/jira/browse/MPOM-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-305. Resolution: Fixed > Set minimum enforced Maven version to 3.2.5 > --- > > Key: MPOM-305 > URL: https://issues.apache.org/jira/browse/MPOM-305 > Project: Maven POMs > Issue Type: Task > Components: asf >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-26 > > > Used plugins required Maven 3.2.5 > - maven-compiler-plugin from 3.9.0 > - maven-plugin-plugin from 3.6.4 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MPOM-305) Set minimum enforced Maven version to 3.2.5
[ https://issues.apache.org/jira/browse/MPOM-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516468#comment-17516468 ] Hudson commented on MPOM-305: - Build succeeded in Jenkins: Maven » Maven TLP » maven-apache-parent » master #19 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-apache-parent/job/master/19/ > Set minimum enforced Maven version to 3.2.5 > --- > > Key: MPOM-305 > URL: https://issues.apache.org/jira/browse/MPOM-305 > Project: Maven POMs > Issue Type: Task > Components: asf >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-26 > > > Used plugins required Maven 3.2.5 > - maven-compiler-plugin from 3.9.0 > - maven-plugin-plugin from 3.6.4 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-apache-parent] slawekjaranowski merged pull request #76: [MPOM-305] Set minimum enforced Maven version to 3.2.5
slawekjaranowski merged pull request #76: URL: https://github.com/apache/maven-apache-parent/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MASSEMBLY-949) Examples should refer to https instead of http
[ https://issues.apache.org/jira/browse/MASSEMBLY-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516465#comment-17516465 ] Slawomir Jaranowski commented on MASSEMBLY-949: --- PR are welcome > Examples should refer to https instead of http > -- > > Key: MASSEMBLY-949 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-949 > Project: Maven Assembly Plugin > Issue Type: Task > Components: site >Affects Versions: 3.3.0 >Reporter: Krosheninnikov Artem >Priority: Minor > > Examples in pages like this [1] point to http while they can/should point to > https > [1] http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html -- This message was sent by Atlassian Jira (v8.20.1#820001)
