[GitHub] [maven-dependency-analyzer] dependabot[bot] opened a new pull request, #58: Bump asm from 9.2 to 9.3
dependabot[bot] opened a new pull request, #58: URL: https://github.com/apache/maven-dependency-analyzer/pull/58 Bumps asm from 9.2 to 9.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844548223
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -3114,9 +3114,12 @@ protected void warnIfIllegalFailOnFlakeCount() throws
MojoFailureException
private void printDefaultSeedIfNecessary()
{
-if ( getRunOrderRandomSeed() == null && getRunOrder().equals(
RunOrder.RANDOM.name() ) )
+if ( getRunOrder().equals( RunOrder.RANDOM.name() ) )
{
-setRunOrderRandomSeed( System.nanoTime() );
+if ( getRunOrderRandomSeed() == null )
+{
+setRunOrderRandomSeed( System.nanoTime() );
Review Comment:
@slawekjaranowski runOrder can be other than random and so
`DefaultRunOrderCalculator` may obtain null seed.
@delanym see my comment
https://github.com/apache/maven-surefire/pull/505#discussion_r844543780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844543780
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
@delanym I made `RunOrderParameters` immutable because the contributor did
not implement it right and the setter was not necessary. Pls rebase you branch
on `origin/master`. You should exclude the fallback value `System.nanoTime()`
in the `DefaultRunOrderCalculator` constructor and use it only in MOJO. It does
not make sense to do one thing twice with the seed.
Finally `this.random = new Random( runOrderRandomSeed == null ?
System.nanoTime() : runOrderRandomSeed );` would become `random =
runOrderRandomSeed == null ? null : new Random( runOrderRandomSeed );`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844543780
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
@delanym I made `RunOrderParameters` immutable because the contributor did
not implement it right and the setter was not necessary. Pls rebase you branch
on `origin/master`. You should exclude the fallback value `System.nanoTime()`
in the `DefaultRunOrderCalculator` constructor and use it only in MOJO. It does
not make sense to do one thing twice with the seed.
Finally `this.random = new Random( runOrderRandomSeed == null ?
System.nanoTime() : runOrderRandomSeed );` would become `this.random =
runOrderRandomSeed == null ? null : new Random( runOrderRandomSeed );`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844543780
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
@delanym I made `RunOrderParameters` immutable because the contributor did
not implement it right and the setter was not necessary. You should exclude the
fallback value `System.nanoTime()` in the `DefaultRunOrderCalculator`
constructor and use it only in MOJO. It does not make sense to do one thing
twice with the seed.
Finally `this.random = new Random( runOrderRandomSeed == null ?
System.nanoTime() : runOrderRandomSeed );` would become `this.random =
runOrderRandomSeed == null ? null : new Random( runOrderRandomSeed );`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844543780
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
@delanym I made `RunOrderParameters` immutable because the contributor did
not implement it right and the setter was not necessary. You should exclude the
fallback value `System.nanoTime()` in the `DefaultRunOrderCalculator`
constructor and use it only in MOJO. It does not make sense to do one thing
twice with the seed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844516213
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
@slawekjaranowski Do you remember all the years we solved together with
Robert and Infra team because the Windows paths were limited on the file
system? They are!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844514843
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
@delanym
We are doing these things twice. The seed is set to `System.nanoTime()` if
it was NULL, see `DefaultRunOrderCalculator`.
This means that the only work here should be different, we should change the
condition in the IF statement but nothing more. WDYT? Pls comment on this!
```
Long runOrderRandomSeed = runOrderParameters.getRunOrderRandomSeed();
if ( runOrderRandomSeed == null )
{
runOrderRandomSeed = System.nanoTime();
runOrderParameters.setRunOrderRandomSeed( runOrderRandomSeed );
}
this.random = new Random( runOrderRandomSeed );
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844514843
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
@delanym
We are doing these things twice. The seed is set to `System.nanoTime()` if
it was NULL, see `DefaultRunOrderCalculator`.
This means that the only work here is to change the condition in the IF
statement but nothing more!
```
Long runOrderRandomSeed = runOrderParameters.getRunOrderRandomSeed();
if ( runOrderRandomSeed == null )
{
runOrderRandomSeed = System.nanoTime();
runOrderParameters.setRunOrderRandomSeed( runOrderRandomSeed );
}
this.random = new Random( runOrderRandomSeed );
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2029) Parallel execution but surefire.forkNumber is the same
[
https://issues.apache.org/jira/browse/SUREFIRE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518510#comment-17518510
]
Nathan McDonald commented on SUREFIRE-2029:
---
That's not how I read the documentation. It says you have fork count in
failsafe configured to 3. But then with -T 2, this is saying you get numbers 1
through 6, implying that -T2 splits off 2 forks for multi module builds. each
of those forks can then run parallel builds that could then create 3 forks
each, resulting in 6 forks (1 through 6).
If mvn -T is not supported, then surely documentation should state that in case
where fork count is 3, and mvn -T 2 is used, then ${surefire.forkNumber}
ranging from 1 to 3 (where same forkNumber could be used in different modules
running in different forks)
> Parallel execution but surefire.forkNumber is the same
> --
>
> Key: SUREFIRE-2029
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2029
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Nathan McDonald
>Priority: Minor
> Fix For: waiting-for-apache-feedback
>
>
> We have a multi module maven project, and due to our legacy architecture
> different modules are using the same underlying database.
> We are using the one db per fork strategy mentioned, and each test clears the
> database before running its test.
> This seems to work fine. But when running the full build on azure with:
> {noformat}
> mvn ... -T 1C -pl {modulesToBuild} -amd{noformat}
>
> See output kicking off build like:
> {noformat}
> [INFO] Using the MultiThreadedBuilder implementation with a thread count of
> 8{noformat}
>
> We occasionally see one long running test fail, and have traced cause that
> another test is running in parallel and clearing the database before long
> running test completes . This would only seem to be possible if parallel
> forks running but same surefire.forkNumber being set for multiple forks.
> Outputting logs of when tests start and end, with log outputting
> "Thread#$threadId\{$forkNumber}, e.g. Thread#7\{3} for thread with id 7,
> where surefire.forkNumber is 3
> Looking at logs we can see test starts on thread/fork 1, clears db as
> expected, and 30 seconds later logs that it completes (with error that is
> shown later).
> But we can see just moments later, another test starts up and also clears the
> database, but is using same thread/fork:
> {noformat}
> 2022-03-01T16:30:59.5953417Z 2022-03-01 16:30:59.585 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:30:59.7150510Z 2022-03-01 16:30:59.711 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:78 - Thread#1{1} - running
> setup for
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> …
> {noformat}
> 2022-03-01T16:31:01.1305751Z 2022-03-01 16:31:01.128 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:31:01.6123984Z [INFO] Tests run: 2, Failures: 0, Errors: 0,
> Skipped: 0, Time elapsed: 24.715 s - in
> e.t.b.h.w.c.FinancialStatementReportItemRestControllerIT
> 2022-03-01T16:31:01.6124965Z [INFO] Running
> e.t.b.h.w.c.KeyInformationRestControllerIT{noformat}
> …
> {noformat}
> 2022-03-01T16:31:29.1656587Z 2022-03-01 16:31:29.164 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:94 - Thread#1{1} - complete
> test
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> This isn't consistent though. Can see other cases where this works, but the
> logs found where it is working can see long running test running on separate
> fork:
> Thread#1\{3}
> Obviously there are separate threads/forks running here, so seems like
> somewhere between maven multi module and -T 1C, there is not always
> assigning unique forkNumber to each fork.
> I figure best practice is probably having separate modules not use same db,
> so possibly this issue is existing but not being hit by people as would only
> cause issue if same fork number used for separate modules on different
> databases.
> Still looking into issue our side will update if find workaround or more
> detailed information.
> Our surefire/failsafe config is in the root inherited by all other sub
> modules:
> {code:java}
>
>org.apache.maven.plugins
>maven-surefire-plugin
>
> 2
> @{argLine} -DforkNumber=${surefire.forkNumber}
> false
>
>
>
>org.apache.maven.plugins
>maven-failsafe-plugin
>
> 1
> @{argLine} -DforkNumber=${surefire.forkNumber}
> false
>
> ${project.build.directory}/surefire-reports
>
>
>
[jira] [Comment Edited] (SUREFIRE-2029) Parallel execution but surefire.forkNumber is the same
[
https://issues.apache.org/jira/browse/SUREFIRE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518507#comment-17518507
]
Tibor Digana edited comment on SUREFIRE-2029 at 4/6/22 11:16 PM:
-
Acctualy ,the documentation talks about this risk.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
Configuration:
{noformat}
3
{noformat}
{noformat}
In case of a multi module project with tests in different modules, you could
also use, say, mvn -T 2 ... to start the build, yielding values for
${surefire.forkNumber} ranging from 1 to 6.
{noformat}
So, essentially, it says that you have 2 modules at least, two modules may run
in parallel, and each surefire plugin has the same config forkCount=3. The
Maven is not able to guarantee that you will have unique number. It could be
possible only if the Maven did not use the ClassWorlds Class Loader, but due to
we use Class Loaders the static context is different and the singletons can not
be shared.
was (Author: tibor17):
Acctualy ,the documentation talks about this risk.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
Configuration:
{noformat}
3
{noformat}
{noformat}
In case of a multi module project with tests in different modules, you could
also use, say, mvn -T 2 ... to start the build, yielding values for
${surefire.forkNumber} ranging from 1 to 6.
{noformat}
So, essentially, it says that you have 2 modules at least, two modules may run
in parallel, and each surefire plugin has the same config forkNumber=2. The
Maven is not able to guarantee that you will have unique number. It could be
possible only if the Maven did not use the ClassWorlds Class Loader, but due to
we use Class Loaders the static context is different and the singletons can not
be shared.
> Parallel execution but surefire.forkNumber is the same
> --
>
> Key: SUREFIRE-2029
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2029
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Nathan McDonald
>Priority: Minor
> Fix For: waiting-for-apache-feedback
>
>
> We have a multi module maven project, and due to our legacy architecture
> different modules are using the same underlying database.
> We are using the one db per fork strategy mentioned, and each test clears the
> database before running its test.
> This seems to work fine. But when running the full build on azure with:
> {noformat}
> mvn ... -T 1C -pl {modulesToBuild} -amd{noformat}
>
> See output kicking off build like:
> {noformat}
> [INFO] Using the MultiThreadedBuilder implementation with a thread count of
> 8{noformat}
>
> We occasionally see one long running test fail, and have traced cause that
> another test is running in parallel and clearing the database before long
> running test completes . This would only seem to be possible if parallel
> forks running but same surefire.forkNumber being set for multiple forks.
> Outputting logs of when tests start and end, with log outputting
> "Thread#$threadId\{$forkNumber}, e.g. Thread#7\{3} for thread with id 7,
> where surefire.forkNumber is 3
> Looking at logs we can see test starts on thread/fork 1, clears db as
> expected, and 30 seconds later logs that it completes (with error that is
> shown later).
> But we can see just moments later, another test starts up and also clears the
> database, but is using same thread/fork:
> {noformat}
> 2022-03-01T16:30:59.5953417Z 2022-03-01 16:30:59.585 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:30:59.7150510Z 2022-03-01 16:30:59.711 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:78 - Thread#1{1} - running
> setup for
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> …
> {noformat}
> 2022-03-01T16:31:01.1305751Z 2022-03-01 16:31:01.128 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:31:01.6123984Z [INFO] Tests run: 2, Failures: 0, Errors: 0,
> Skipped: 0, Time elapsed: 24.715 s - in
> e.t.b.h.w.c.FinancialStatementReportItemRestControllerIT
> 2022-03-01T16:31:01.6124965Z [INFO] Running
> e.t.b.h.w.c.KeyInformationRestControllerIT{noformat}
> …
> {noformat}
> 2022-03-01T16:31:29.1656587Z 2022-03-01 16:31:29.164 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:94 - Thread#1{1} - complete
> test
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> This isn't consistent though. Can see other cases where this works, but the
> logs found where it
[jira] [Comment Edited] (SUREFIRE-2029) Parallel execution but surefire.forkNumber is the same
[
https://issues.apache.org/jira/browse/SUREFIRE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518507#comment-17518507
]
Tibor Digana edited comment on SUREFIRE-2029 at 4/6/22 11:14 PM:
-
Acctualy ,the documentation talks about this risk.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
Configuration:
{noformat}
3
{noformat}
{noformat}
In case of a multi module project with tests in different modules, you could
also use, say, mvn -T 2 ... to start the build, yielding values for
${surefire.forkNumber} ranging from 1 to 6.
{noformat}
So, essentially, it says that you have 2 modules at least, two modules may run
in parallel, and each surefire plugin has the same config forkNumber=2. The
Maven is not able to guarantee that you will have unique number. It could be
possible only if the Maven did not use the ClassWorlds Class Loader, but due to
we use Class Loaders the static context is different and the singletons can not
be shared.
was (Author: tibor17):
Acctualy ,the documentation talks about this risk.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
Configuration:
{noformat}
3
{noformat}
{noformat}
In case of a multi module project with tests in different modules, you could
also use, say, mvn -T 2 ... to start the build, yielding values for
${surefire.forkNumber} ranging from 1 to 6.
{noformat}
So, essentially, it says that you have 2 modules at least, two modules may run
in parallel, and each surefire plugin has the same config forkNumber=2.
> Parallel execution but surefire.forkNumber is the same
> --
>
> Key: SUREFIRE-2029
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2029
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Nathan McDonald
>Priority: Minor
> Fix For: waiting-for-apache-feedback
>
>
> We have a multi module maven project, and due to our legacy architecture
> different modules are using the same underlying database.
> We are using the one db per fork strategy mentioned, and each test clears the
> database before running its test.
> This seems to work fine. But when running the full build on azure with:
> {noformat}
> mvn ... -T 1C -pl {modulesToBuild} -amd{noformat}
>
> See output kicking off build like:
> {noformat}
> [INFO] Using the MultiThreadedBuilder implementation with a thread count of
> 8{noformat}
>
> We occasionally see one long running test fail, and have traced cause that
> another test is running in parallel and clearing the database before long
> running test completes . This would only seem to be possible if parallel
> forks running but same surefire.forkNumber being set for multiple forks.
> Outputting logs of when tests start and end, with log outputting
> "Thread#$threadId\{$forkNumber}, e.g. Thread#7\{3} for thread with id 7,
> where surefire.forkNumber is 3
> Looking at logs we can see test starts on thread/fork 1, clears db as
> expected, and 30 seconds later logs that it completes (with error that is
> shown later).
> But we can see just moments later, another test starts up and also clears the
> database, but is using same thread/fork:
> {noformat}
> 2022-03-01T16:30:59.5953417Z 2022-03-01 16:30:59.585 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:30:59.7150510Z 2022-03-01 16:30:59.711 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:78 - Thread#1{1} - running
> setup for
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> …
> {noformat}
> 2022-03-01T16:31:01.1305751Z 2022-03-01 16:31:01.128 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:31:01.6123984Z [INFO] Tests run: 2, Failures: 0, Errors: 0,
> Skipped: 0, Time elapsed: 24.715 s - in
> e.t.b.h.w.c.FinancialStatementReportItemRestControllerIT
> 2022-03-01T16:31:01.6124965Z [INFO] Running
> e.t.b.h.w.c.KeyInformationRestControllerIT{noformat}
> …
> {noformat}
> 2022-03-01T16:31:29.1656587Z 2022-03-01 16:31:29.164 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:94 - Thread#1{1} - complete
> test
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> This isn't consistent though. Can see other cases where this works, but the
> logs found where it is working can see long running test running on separate
> fork:
> Thread#1\{3}
> Obviously there are separate threads/forks running here, so seems like
> somewhere between maven multi module and -T 1C, there is not always
> assigning unique
[jira] [Comment Edited] (SUREFIRE-2029) Parallel execution but surefire.forkNumber is the same
[
https://issues.apache.org/jira/browse/SUREFIRE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518507#comment-17518507
]
Tibor Digana edited comment on SUREFIRE-2029 at 4/6/22 11:12 PM:
-
Acctualy ,the documentation talks about this risk.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
Configuration:
{noformat}
3
{noformat}
{noformat}
In case of a multi module project with tests in different modules, you could
also use, say, mvn -T 2 ... to start the build, yielding values for
${surefire.forkNumber} ranging from 1 to 6.
{noformat}
So, essentially, it says that you have 2 modules at least, two modules may run
in parallel, and each surefire plugin has the same config forkNumber=2.
was (Author: tibor17):
Acctualy ,the documentation talks about this risk.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
Configuration:
{noformat}
3
{noformat}
{noformat}
In case of a multi module project with tests in different modules, you could
also use, say, mvn -T 2 ... to start the build, yielding values for
${surefire.forkNumber} ranging from 1 to 6.
{noformat}
> Parallel execution but surefire.forkNumber is the same
> --
>
> Key: SUREFIRE-2029
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2029
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Nathan McDonald
>Priority: Minor
> Fix For: waiting-for-apache-feedback
>
>
> We have a multi module maven project, and due to our legacy architecture
> different modules are using the same underlying database.
> We are using the one db per fork strategy mentioned, and each test clears the
> database before running its test.
> This seems to work fine. But when running the full build on azure with:
> {noformat}
> mvn ... -T 1C -pl {modulesToBuild} -amd{noformat}
>
> See output kicking off build like:
> {noformat}
> [INFO] Using the MultiThreadedBuilder implementation with a thread count of
> 8{noformat}
>
> We occasionally see one long running test fail, and have traced cause that
> another test is running in parallel and clearing the database before long
> running test completes . This would only seem to be possible if parallel
> forks running but same surefire.forkNumber being set for multiple forks.
> Outputting logs of when tests start and end, with log outputting
> "Thread#$threadId\{$forkNumber}, e.g. Thread#7\{3} for thread with id 7,
> where surefire.forkNumber is 3
> Looking at logs we can see test starts on thread/fork 1, clears db as
> expected, and 30 seconds later logs that it completes (with error that is
> shown later).
> But we can see just moments later, another test starts up and also clears the
> database, but is using same thread/fork:
> {noformat}
> 2022-03-01T16:30:59.5953417Z 2022-03-01 16:30:59.585 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:30:59.7150510Z 2022-03-01 16:30:59.711 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:78 - Thread#1{1} - running
> setup for
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> …
> {noformat}
> 2022-03-01T16:31:01.1305751Z 2022-03-01 16:31:01.128 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:31:01.6123984Z [INFO] Tests run: 2, Failures: 0, Errors: 0,
> Skipped: 0, Time elapsed: 24.715 s - in
> e.t.b.h.w.c.FinancialStatementReportItemRestControllerIT
> 2022-03-01T16:31:01.6124965Z [INFO] Running
> e.t.b.h.w.c.KeyInformationRestControllerIT{noformat}
> …
> {noformat}
> 2022-03-01T16:31:29.1656587Z 2022-03-01 16:31:29.164 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:94 - Thread#1{1} - complete
> test
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> This isn't consistent though. Can see other cases where this works, but the
> logs found where it is working can see long running test running on separate
> fork:
> Thread#1\{3}
> Obviously there are separate threads/forks running here, so seems like
> somewhere between maven multi module and -T 1C, there is not always
> assigning unique forkNumber to each fork.
> I figure best practice is probably having separate modules not use same db,
> so possibly this issue is existing but not being hit by people as would only
> cause issue if same fork number used for separate modules on different
> databases.
> Still looking into issue our side will update if find workaround or more
> detailed information.
> Our surefire/failsafe config is in the
[jira] [Commented] (SUREFIRE-2029) Parallel execution but surefire.forkNumber is the same
[
https://issues.apache.org/jira/browse/SUREFIRE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518507#comment-17518507
]
Tibor Digana commented on SUREFIRE-2029:
Acctualy ,the documentation talks about this risk.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
Configuration:
{noformat}
3
{noformat}
{noformat}
In case of a multi module project with tests in different modules, you could
also use, say, mvn -T 2 ... to start the build, yielding values for
${surefire.forkNumber} ranging from 1 to 6.
{noformat}
> Parallel execution but surefire.forkNumber is the same
> --
>
> Key: SUREFIRE-2029
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2029
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Nathan McDonald
>Priority: Minor
> Fix For: waiting-for-apache-feedback
>
>
> We have a multi module maven project, and due to our legacy architecture
> different modules are using the same underlying database.
> We are using the one db per fork strategy mentioned, and each test clears the
> database before running its test.
> This seems to work fine. But when running the full build on azure with:
> {noformat}
> mvn ... -T 1C -pl {modulesToBuild} -amd{noformat}
>
> See output kicking off build like:
> {noformat}
> [INFO] Using the MultiThreadedBuilder implementation with a thread count of
> 8{noformat}
>
> We occasionally see one long running test fail, and have traced cause that
> another test is running in parallel and clearing the database before long
> running test completes . This would only seem to be possible if parallel
> forks running but same surefire.forkNumber being set for multiple forks.
> Outputting logs of when tests start and end, with log outputting
> "Thread#$threadId\{$forkNumber}, e.g. Thread#7\{3} for thread with id 7,
> where surefire.forkNumber is 3
> Looking at logs we can see test starts on thread/fork 1, clears db as
> expected, and 30 seconds later logs that it completes (with error that is
> shown later).
> But we can see just moments later, another test starts up and also clears the
> database, but is using same thread/fork:
> {noformat}
> 2022-03-01T16:30:59.5953417Z 2022-03-01 16:30:59.585 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:30:59.7150510Z 2022-03-01 16:30:59.711 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:78 - Thread#1{1} - running
> setup for
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> …
> {noformat}
> 2022-03-01T16:31:01.1305751Z 2022-03-01 16:31:01.128 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:31:01.6123984Z [INFO] Tests run: 2, Failures: 0, Errors: 0,
> Skipped: 0, Time elapsed: 24.715 s - in
> e.t.b.h.w.c.FinancialStatementReportItemRestControllerIT
> 2022-03-01T16:31:01.6124965Z [INFO] Running
> e.t.b.h.w.c.KeyInformationRestControllerIT{noformat}
> …
> {noformat}
> 2022-03-01T16:31:29.1656587Z 2022-03-01 16:31:29.164 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:94 - Thread#1{1} - complete
> test
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> This isn't consistent though. Can see other cases where this works, but the
> logs found where it is working can see long running test running on separate
> fork:
> Thread#1\{3}
> Obviously there are separate threads/forks running here, so seems like
> somewhere between maven multi module and -T 1C, there is not always
> assigning unique forkNumber to each fork.
> I figure best practice is probably having separate modules not use same db,
> so possibly this issue is existing but not being hit by people as would only
> cause issue if same fork number used for separate modules on different
> databases.
> Still looking into issue our side will update if find workaround or more
> detailed information.
> Our surefire/failsafe config is in the root inherited by all other sub
> modules:
> {code:java}
>
>org.apache.maven.plugins
>maven-surefire-plugin
>
> 2
> @{argLine} -DforkNumber=${surefire.forkNumber}
> false
>
>
>
>org.apache.maven.plugins
>maven-failsafe-plugin
>
> 1
> @{argLine} -DforkNumber=${surefire.forkNumber}
> false
>
> ${project.build.directory}/surefire-reports
>
>
>
>
> integration-test
> verify
>
>
>
> {code}
> mvn version info:
> {noformat}
> Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f)
> Maven
[jira] [Commented] (MINVOKER-299) IT test filtering-extensions fails on Maven 3.8.5
[
https://issues.apache.org/jira/browse/MINVOKER-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518478#comment-17518478
]
Hudson commented on MINVOKER-299:
-
Build failed in Jenkins: Maven » Maven TLP » maven-invoker-plugin » master #12
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-invoker-plugin/job/master/12/
> IT test filtering-extensions fails on Maven 3.8.5
> -
>
> Key: MINVOKER-299
> URL: https://issues.apache.org/jira/browse/MINVOKER-299
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> There are two issues:
> - unparsable xml - duplicate root tag {{}}
> - given artifact in test not exist anywhere, so can not be found
> Before MNG-6326 such errors was skipped.
> original {{.mvn/extensions.xml}} used in test:
> {code:xml}
> http://maven.apache.org/EXTENSIONS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0
> http://maven.apache.org/xsd/core-extensions-1.0.0.xsd;>
>
>
> @project.groupId@
> @project.artifactId@
> @project.version@
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #111: Bump junit from 4.12 to 4.13.1 in /src/it/postbuild-executed-only-once/src/it/project
dependabot[bot] commented on PR #111: URL: https://github.com/apache/maven-invoker-plugin/pull/111#issuecomment-1090837892 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski closed pull request #111: Bump junit from 4.12 to 4.13.1 in /src/it/postbuild-executed-only-once/src/it/project
slawekjaranowski closed pull request #111: Bump junit from 4.12 to 4.13.1 in /src/it/postbuild-executed-only-once/src/it/project URL: https://github.com/apache/maven-invoker-plugin/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #111: Bump junit from 4.12 to 4.13.1 in /src/it/postbuild-executed-only-once/src/it/project
dependabot[bot] opened a new pull request, #111: URL: https://github.com/apache/maven-invoker-plugin/pull/111 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases;>junit's releases. JUnit 4.13.1 Please refer to the https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md;>release notes for details. JUnit 4.13 Please refer to the https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md;>release notes for details. JUnit 4.13 RC 2 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes;>release notes for details. JUnit 4.13 RC 1 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes;>release notes for details. JUnit 4.13 Beta 3 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes;>release notes for details. JUnit 4.13 Beta 2 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes;>release notes for details. JUnit 4.13 Beta 1 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes;>release notes for details. Commits https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66;>1b683f4 [maven-release-plugin] prepare release r4.13.1 https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2;>ce6ce3a Draft 4.13.1 release notes https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24;>c29dd82 Change version to 4.13.1-SNAPSHOT https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567;>1d17486 Add a link to assertThrows in exception testing https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9;>543905d Use separate line for annotation in Javadoc https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944;>510e906 Add sub headlines to class Javadoc https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae;>610155b Merge pull request from GHSA-269g-pwp5-87pp https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec;>b6cfd1e Explicitly wrap float parameter for consistency (https://github-redirect.dependabot.com/junit-team/junit4/issues/1671;>#1671) https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646;>a5d205c Fix GitHub link in FAQ (https://github-redirect.dependabot.com/junit-team/junit4/issues/1672;>#1672) https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8;>3a5c6b4 Deprecated since jdk9 replacing constructor instance of Double and Float (https://github-redirect.dependabot.com/junit-team/junit4/issues/1660;>#1660) Additional commits viewable in https://github.com/junit-team/junit4/compare/r4.12...r4.13.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-invoker-plugin/network/alerts).
[jira] [Closed] (MINVOKER-299) IT test filtering-extensions fails on Maven 3.8.5
[
https://issues.apache.org/jira/browse/MINVOKER-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MINVOKER-299.
Resolution: Fixed
> IT test filtering-extensions fails on Maven 3.8.5
> -
>
> Key: MINVOKER-299
> URL: https://issues.apache.org/jira/browse/MINVOKER-299
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> There are two issues:
> - unparsable xml - duplicate root tag {{}}
> - given artifact in test not exist anywhere, so can not be found
> Before MNG-6326 such errors was skipped.
> original {{.mvn/extensions.xml}} used in test:
> {code:xml}
> http://maven.apache.org/EXTENSIONS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0
> http://maven.apache.org/xsd/core-extensions-1.0.0.xsd;>
>
>
> @project.groupId@
> @project.artifactId@
> @project.version@
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-invoker-plugin] slawekjaranowski merged pull request #110: [MINVOKER-299] fix filtering-extensions test
slawekjaranowski merged PR #110: URL: https://github.com/apache/maven-invoker-plugin/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-299) IT test filtering-extensions fails on Maven 3.8.5
[
https://issues.apache.org/jira/browse/MINVOKER-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518468#comment-17518468
]
Michael Osipov commented on MINVOKER-299:
-
Yes
> IT test filtering-extensions fails on Maven 3.8.5
> -
>
> Key: MINVOKER-299
> URL: https://issues.apache.org/jira/browse/MINVOKER-299
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> There are two issues:
> - unparsable xml - duplicate root tag {{}}
> - given artifact in test not exist anywhere, so can not be found
> Before MNG-6326 such errors was skipped.
> original {{.mvn/extensions.xml}} used in test:
> {code:xml}
> http://maven.apache.org/EXTENSIONS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0
> http://maven.apache.org/xsd/core-extensions-1.0.0.xsd;>
>
>
> @project.groupId@
> @project.artifactId@
> @project.version@
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Subelman updated SUREFIRE-2063:
--
Description:
Since v3.3.0-M6 fails when using to export or open a package. The
failure is produced when using --add-opens or --add-exports in .
The execution doesn't fail with v3.3.0-M5 or earlier.
As an example, it fails when using the following :
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project
testing:
{code}
was:
Since v3.3.0-M6 fails when using to export or open a package. The
failure is produced when using --add-opens or --add-exports in .
This doesn't happen with v3.3.0-M5.
As an example, it fails when using the following :
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project
testing:
{code}
> Adding configuration using with --add-opens or --add-exports fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Priority: Major
>
> Since v3.3.0-M6 fails when using to export or open a package. The
> failure is produced when using --add-opens or --add-exports in .
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following :
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
[jira] [Updated] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Subelman updated SUREFIRE-2063:
--
Description:
Since v3.3.0-M6 fails when using to export or open a package. The
failure is produced when using --add-opens or --add-exports in .
This doesn't happen with v3.3.0-M5.
As an example, it fails when using the following :
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project
testing:
{code}
was:
Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
This doesn't happen with v3.3.0-M5.
As an example, fails when using the following :
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test) on
project testing:
{code}
> Adding configuration using with --add-opens or --add-exports fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Priority: Major
>
> Since v3.3.0-M6 fails when using to export or open a package. The
> failure is produced when using --add-opens or --add-exports in .
> This doesn't happen with v3.3.0-M5.
> As an example, it fails when using the following :
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 9.157 s
> [INFO]
[jira] [Updated] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Subelman updated SUREFIRE-2063:
--
Description:
Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
This doesn't happen with v3.3.0-M5.
As an example, fails when using the following :
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test) on
project testing:
{code}
was:
Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
As an example, fails when using the following :
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test) on
project testing:
{code}
> Adding configuration using with --add-opens or --add-exports fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Priority: Major
>
> Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
> This doesn't happen with v3.3.0-M5.
> As an example, fails when using the following :
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO]
>
> [ERROR] Failed to execute
[jira] [Updated] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Subelman updated SUREFIRE-2063:
--
Description:
Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
As an example, fails when using the following :
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test) on
project testing:
{code}
was:
Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
As an example, fails when using the following :
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test) on
project testing:
{code}
> Adding configuration using with --add-opens or --add-exports fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Priority: Major
>
> Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
> As an example, fails when using the following :
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
>
[jira] [Updated] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Subelman updated SUREFIRE-2063:
--
Description:
Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
As an example, fails when using the following :
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test) on
project testing:
{code}
was:
Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
As an example, using the following fails:
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test) on
project testing:
{code}
> Adding configuration using with --add-opens or --add-exports fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Priority: Major
>
> Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
>
> As an example, fails when using the following :
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
>
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
>
[jira] [Created] (SUREFIRE-2063) Adding configuration using with--add-opens or --add-exports fails
Daniel Subelman created SUREFIRE-2063:
-
Summary: Adding configuration using with--add-opens or
--add-exports fails
Key: SUREFIRE-2063
URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
Project: Maven Surefire
Issue Type: Bug
Affects Versions: 3.0.0-M6
Reporter: Daniel Subelman
Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
As an example, using the following fails:
{code:java}
--add-opens
org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
--add-opens
org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
{code}
The failure log:
{code:java}
[INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
Error: Could not find or load main class --add-opens
Caused by: java.lang.ClassNotFoundException: --add-opens
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 9.157 s
[INFO] Finished at: 2022-04-06T16:28:23-04:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test) on
project testing:
{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Subelman updated SUREFIRE-2063:
--
Summary: Adding configuration using with --add-opens or
--add-exports fails (was: Adding configuration using with--add-opens
or --add-exports fails)
> Adding configuration using with --add-opens or --add-exports fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Priority: Major
>
> Since v3.3.0-M6 fails when using with --add-opens or --add-exports.
> As an example, using the following fails:
>
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
>
>
> The failure log:
>
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (default-test) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test)
> on project testing:
> {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Deleted] (MWAR-449) ISO8859-1 properties files get changed into UTF-8 when filtered
[
https://issues.apache.org/jira/browse/MWAR-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov deleted MWAR-449:
> ISO8859-1 properties files get changed into UTF-8 when filtered
> ---
>
> Key: MWAR-449
> URL: https://issues.apache.org/jira/browse/MWAR-449
> Project: Maven WAR Plugin
> Issue Type: Improvement
>Reporter: Dennis Lundberg
>Priority: Major
>
> This issue is similar to
> https://issues.apache.org/jira/browse/MRESOURCES-171, but for filtering web
> resources in maven-war-plugin.
> We add properties files that have ISO-8859-1 encoding, as per the Java 8
> requirements, as web resources in a war project. When these resources are
> filtered they get converted to the encoding specified by the
> project.build.sourceEncoding. There is a parameter resourceEncoding that can
> be used to change the encoding for web reources, but it applies to all web
> resource files which is not always what you want.
> Here is the configuration used:
> {code:xml}
>
>
>
> org.apache.maven.plugins
> maven-war-plugin
> 3.3.2
>
>
>
> WEB-INF/classes
> true
> src/main/webapp/WEB-INF/classes
>
>
>
>
>
>
> {code}
> We propose to add a new parameter propertiesEncoding to the AbstractWarMojo.
> If the value of this parameter is set and filtering is enabled and a web
> resource file is a properties file, then the value of the parameter is used
> as encoding when filtering the file.
> If the parameter is not specified it defaults to
> project.build.sourceEncoding, thus keeping the current behavior of the plugin
> unchanged.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Deleted] (MWAR-451) ISO8859-1 properties files get changed into UTF-8 when filtered
[
https://issues.apache.org/jira/browse/MWAR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov deleted MWAR-451:
> ISO8859-1 properties files get changed into UTF-8 when filtered
> ---
>
> Key: MWAR-451
> URL: https://issues.apache.org/jira/browse/MWAR-451
> Project: Maven WAR Plugin
> Issue Type: New Feature
>Reporter: Dennis Lundberg
>Priority: Major
>
> This issue is similar to
> https://issues.apache.org/jira/browse/MRESOURCES-171, but for filtering web
> resources in maven-war-plugin.
> We add properties files that have ISO-8859-1 encoding, as per the Java 8
> requirements, as web resources in a war project. When these resources are
> filtered they get converted to the encoding specified by the
> project.build.sourceEncoding. There is a parameter resourceEncoding that can
> be used to change the encoding for web reources, but it applies to all web
> resource files which is not always what you want.
> Here is the configuration used:
> {code:xml}
>
>
>
> org.apache.maven.plugins
> maven-war-plugin
> 3.3.2
>
>
>
> WEB-INF/classes
> true
> src/main/webapp/WEB-INF/classes
>
>
>
>
>
>
> {code}
> We propose to add a new parameter propertiesEncoding to the AbstractWarMojo.
> If the value of this parameter is set and filtering is enabled and a web
> resource file is a properties file, then the value of the parameter is used
> as encoding when filtering the file.
> If the parameter is not specified it defaults to
> project.build.sourceEncoding, thus keeping the current behavior of the plugin
> unchanged.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2029) Parallel execution but surefire.forkNumber is the same
[
https://issues.apache.org/jira/browse/SUREFIRE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518448#comment-17518448
]
Tibor Digana commented on SUREFIRE-2029:
I understand that you want to reach one unique number. It would mean that the
plugin must have a responsibility for the plugins in another POMs, their plugin
executions and Maven execution itself. If anything is changed in Maven, we
have to change this feature in surefire as well. If it happens, it means that
we created unnecessary coupling which is unwanted.
If you want to associate the plugin execution with the name of SQL database, I
would recommend you to use {{project.artifactId}} combined with {{forkNumber}}.
The artifactIds are typically unique in multimodule projects.
Can you guys [~famod] [~milosh] check it out? The interpolation with artifactId
is not supported yet, I guess.
> Parallel execution but surefire.forkNumber is the same
> --
>
> Key: SUREFIRE-2029
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2029
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Nathan McDonald
>Priority: Minor
> Fix For: waiting-for-apache-feedback
>
>
> We have a multi module maven project, and due to our legacy architecture
> different modules are using the same underlying database.
> We are using the one db per fork strategy mentioned, and each test clears the
> database before running its test.
> This seems to work fine. But when running the full build on azure with:
> {noformat}
> mvn ... -T 1C -pl {modulesToBuild} -amd{noformat}
>
> See output kicking off build like:
> {noformat}
> [INFO] Using the MultiThreadedBuilder implementation with a thread count of
> 8{noformat}
>
> We occasionally see one long running test fail, and have traced cause that
> another test is running in parallel and clearing the database before long
> running test completes . This would only seem to be possible if parallel
> forks running but same surefire.forkNumber being set for multiple forks.
> Outputting logs of when tests start and end, with log outputting
> "Thread#$threadId\{$forkNumber}, e.g. Thread#7\{3} for thread with id 7,
> where surefire.forkNumber is 3
> Looking at logs we can see test starts on thread/fork 1, clears db as
> expected, and 30 seconds later logs that it completes (with error that is
> shown later).
> But we can see just moments later, another test starts up and also clears the
> database, but is using same thread/fork:
> {noformat}
> 2022-03-01T16:30:59.5953417Z 2022-03-01 16:30:59.585 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:30:59.7150510Z 2022-03-01 16:30:59.711 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:78 - Thread#1{1} - running
> setup for
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> …
> {noformat}
> 2022-03-01T16:31:01.1305751Z 2022-03-01 16:31:01.128 [main] INFO
> e.t.b.h.w.c.AbstractIT:556 - Thread#1{1} - Clearing the database before test
> 2022-03-01T16:31:01.6123984Z [INFO] Tests run: 2, Failures: 0, Errors: 0,
> Skipped: 0, Time elapsed: 24.715 s - in
> e.t.b.h.w.c.FinancialStatementReportItemRestControllerIT
> 2022-03-01T16:31:01.6124965Z [INFO] Running
> e.t.b.h.w.c.KeyInformationRestControllerIT{noformat}
> …
> {noformat}
> 2022-03-01T16:31:29.1656587Z 2022-03-01 16:31:29.164 [main] INFO
> e.t.b.a.w.c.AnalysisJobDownloadControllerTest:94 - Thread#1{1} - complete
> test
> AnalysisJobDownloadControllerTest#downloadTransactionsAfterAppendingDuplicateRecords{noformat}
> This isn't consistent though. Can see other cases where this works, but the
> logs found where it is working can see long running test running on separate
> fork:
> Thread#1\{3}
> Obviously there are separate threads/forks running here, so seems like
> somewhere between maven multi module and -T 1C, there is not always
> assigning unique forkNumber to each fork.
> I figure best practice is probably having separate modules not use same db,
> so possibly this issue is existing but not being hit by people as would only
> cause issue if same fork number used for separate modules on different
> databases.
> Still looking into issue our side will update if find workaround or more
> detailed information.
> Our surefire/failsafe config is in the root inherited by all other sub
> modules:
> {code:java}
>
>org.apache.maven.plugins
>maven-surefire-plugin
>
> 2
> @{argLine} -DforkNumber=${surefire.forkNumber}
> false
>
>
>
>org.apache.maven.plugins
>maven-failsafe-plugin
>
> 1
> @{argLine} -DforkNumber=${surefire.forkNumber}
>
[jira] [Updated] (MINVOKER-299) IT test filtering-extensions fails on Maven 3.8.5
[
https://issues.apache.org/jira/browse/MINVOKER-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MINVOKER-299:
-
Fix Version/s: 3.3.0
> IT test filtering-extensions fails on Maven 3.8.5
> -
>
> Key: MINVOKER-299
> URL: https://issues.apache.org/jira/browse/MINVOKER-299
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> There are two issues:
> - unparsable xml - duplicate root tag {{}}
> - given artifact in test not exist anywhere, so can not be found
> Before MNG-6326 such errors was skipped.
> original {{.mvn/extensions.xml}} used in test:
> {code:xml}
> http://maven.apache.org/EXTENSIONS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0
> http://maven.apache.org/xsd/core-extensions-1.0.0.xsd;>
>
>
> @project.groupId@
> @project.artifactId@
> @project.version@
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MINVOKER-299) IT test filtering-extensions fails on Maven 3.8.5
[
https://issues.apache.org/jira/browse/MINVOKER-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518353#comment-17518353
]
Slawomir Jaranowski edited comment on MINVOKER-299 at 4/6/22 7:13 PM:
--
I described a problem - is it ok?
was (Author: slawekjaranowski):
I described a problem - is it ok
> IT test filtering-extensions fails on Maven 3.8.5
> -
>
> Key: MINVOKER-299
> URL: https://issues.apache.org/jira/browse/MINVOKER-299
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> There are two issues:
> - unparsable xml - duplicate root tag {{}}
> - given artifact in test not exist anywhere, so can not be found
> Before MNG-6326 such errors was skipped.
> original {{.mvn/extensions.xml}} used in test:
> {code:xml}
> http://maven.apache.org/EXTENSIONS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0
> http://maven.apache.org/xsd/core-extensions-1.0.0.xsd;>
>
>
> @project.groupId@
> @project.artifactId@
> @project.version@
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MINVOKER-299) IT test filtering-extensions fails on Maven 3.8.5
[
https://issues.apache.org/jira/browse/MINVOKER-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518353#comment-17518353
]
Slawomir Jaranowski commented on MINVOKER-299:
--
I described a problem - is it ok
> IT test filtering-extensions fails on Maven 3.8.5
> -
>
> Key: MINVOKER-299
> URL: https://issues.apache.org/jira/browse/MINVOKER-299
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> There are two issues:
> - unparsable xml - duplicate root tag {{}}
> - given artifact in test not exist anywhere, so can not be found
> Before MNG-6326 such errors was skipped.
> original {{.mvn/extensions.xml}} used in test:
> {code:xml}
> http://maven.apache.org/EXTENSIONS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0
> http://maven.apache.org/xsd/core-extensions-1.0.0.xsd;>
>
>
> @project.groupId@
> @project.artifactId@
> @project.version@
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski opened a new pull request, #515: [SUREFIRE-2062] Remove code corresponding to jdk 7 from IT tests
slawekjaranowski opened a new pull request, #515: URL: https://github.com/apache/maven-surefire/pull/515 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SUREFIRE-2062) Remove code corresponding to jdk 7 from IT tests
[
https://issues.apache.org/jira/browse/SUREFIRE-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned SUREFIRE-2062:
-
Assignee: Slawomir Jaranowski
> Remove code corresponding to jdk 7 from IT tests
>
>
> Key: SUREFIRE-2062
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2062
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Now jdk 8 is as minumum, we can remove codes like:
> {code:java}
> assumeJavaVersion( 1.8d ); {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (SUREFIRE-2062) Remove code corresponding to jdk 7 from IT tests
Slawomir Jaranowski created SUREFIRE-2062:
-
Summary: Remove code corresponding to jdk 7 from IT tests
Key: SUREFIRE-2062
URL: https://issues.apache.org/jira/browse/SUREFIRE-2062
Project: Maven Surefire
Issue Type: Improvement
Reporter: Slawomir Jaranowski
Now jdk 8 is as minumum, we can remove codes like:
{code:java}
assumeJavaVersion( 1.8d ); {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
slawekjaranowski commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844261998
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -3114,9 +3114,12 @@ protected void warnIfIllegalFailOnFlakeCount() throws
MojoFailureException
private void printDefaultSeedIfNecessary()
{
-if ( getRunOrderRandomSeed() == null && getRunOrder().equals(
RunOrder.RANDOM.name() ) )
+if ( getRunOrder().equals( RunOrder.RANDOM.name() ) )
{
-setRunOrderRandomSeed( System.nanoTime() );
+if ( getRunOrderRandomSeed() == null )
+{
+setRunOrderRandomSeed( System.nanoTime() );
Review Comment:
`runOrderRandomSeed` is never NULLm if is not provided it will be set to
`nanoTime`.
Currently is printed only when is not given in configuration, change
introduce to print always - also if is given by configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844229724
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -3114,9 +3114,12 @@ protected void warnIfIllegalFailOnFlakeCount() throws
MojoFailureException
private void printDefaultSeedIfNecessary()
{
-if ( getRunOrderRandomSeed() == null && getRunOrder().equals(
RunOrder.RANDOM.name() ) )
+if ( getRunOrder().equals( RunOrder.RANDOM.name() ) )
{
-setRunOrderRandomSeed( System.nanoTime() );
+if ( getRunOrderRandomSeed() == null )
+{
+setRunOrderRandomSeed( System.nanoTime() );
Review Comment:
Let's see the implementation, because the impl has much better opportunities
to use real random number if this parameter is NULL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844226860
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -3114,9 +3114,12 @@ protected void warnIfIllegalFailOnFlakeCount() throws
MojoFailureException
private void printDefaultSeedIfNecessary()
{
-if ( getRunOrderRandomSeed() == null && getRunOrder().equals(
RunOrder.RANDOM.name() ) )
+if ( getRunOrder().equals( RunOrder.RANDOM.name() ) )
{
-setRunOrderRandomSeed( System.nanoTime() );
+if ( getRunOrderRandomSeed() == null )
+{
+setRunOrderRandomSeed( System.nanoTime() );
Review Comment:
Personally I would expect some warning that the seed is missing.
If random, then yes, we should use random and prevent from any cohesion
between the neighbouring runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844223314
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
Hi @delanym . Nice to meet you after the release Vote!
I know that it is a matter of taste but these names of classes and methods
determine the length of folders on the file system in our CI. Using `WithSeed`
and `WithoutSeed` is shorter.
Now, I have realized that @delanym is using two executions which might be
utilized in some way.
@delanym what wat your point? You wanted to compare the XML reports and the
order of tests? Something else? If you want to make sure that the seed is set,
such situation can be verified with the old IT where a debug message can be
printed in the logs and the IT can check that the message was printed with seed
!= NULL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] pzygielo commented on pull request #125: (doc) Fix spurious Javadoc @param tag
pzygielo commented on PR #125: URL: https://github.com/apache/maven-javadoc-plugin/pull/125#issuecomment-1090510358 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
slawekjaranowski commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844184941
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
please consider to split into two test, eg:
- testRandomJUnit4PrintSeedWithGivenSeed
- testRandomJUnit4PrintSeedWithNoGivenSeed
##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
}
}
}
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
Review Comment:
please consider to split into two test, eg:
- testRandomJUnit4PrintSeedWithGivenSeed
- testRandomJUnit4PrintSeedWithNoGivenSeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] pzygielo closed pull request #126: [MJAVADOC-710] ITs for build breaking on removed/replaced param used
pzygielo closed pull request #126: [MJAVADOC-710] ITs for build breaking on removed/replaced param used URL: https://github.com/apache/maven-javadoc-plugin/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] pzygielo commented on pull request #126: [MJAVADOC-710] ITs for build breaking on removed/replaced param used
pzygielo commented on PR #126: URL: https://github.com/apache/maven-javadoc-plugin/pull/126#issuecomment-1090494676 Included in - #127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MJAVADOC-710) Usage of removed or replaced property does not cause the build to fail
Piotr Zygielo created MJAVADOC-710:
--
Summary: Usage of removed or replaced property does not cause the
build to fail
Key: MJAVADOC-710
URL: https://issues.apache.org/jira/browse/MJAVADOC-710
Project: Maven Javadoc Plugin
Issue Type: Bug
Affects Versions: 3.3.2
Reporter: Piotr Zygielo
Per https://issues.apache.org/jira/browse/MJAVADOC-509?focusedCommentId=16581261
{quote}Yes, additionalParam was replaced by additionalOptions in
MJAVADOC-475(https://issues.apache.org/jira/browse/MJAVADOC-475) and the build
will fail with 3.0.0 if this property is used.
{quote}
However current implementation does not do that. And as far as I've checked -
the original implementation didn't do in 3.0.0 neither.
This is due to {{mojo.getConfiguration()}} in
{{AbstractJavadocMojo.verifyRemovedParameter}} having only parameters plugin
committed for, and not all from {{}} element. Not at the moment
of goal execution, at least.
This causes problems when upgrading from pre-3 plugin as {{additionalparam}} is
silently ignored.
I see similar case is dealt in following way:
-
[https://github.com/apache/maven-jar-plugin/blob/0ad60f4f2862bf896b6c0dc57ea5a6999c49b0d4/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java#L107-L115]
-
[https://github.com/apache/maven-deploy-plugin/blob/36a2030c8851e21cd1e0bec01c3cea4dc6055a48/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java#L180-L188]
- and few others
which is to have {{@Deprecated}} parameter, and its presence is used for
breaking the build.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r844129180 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null Review Comment: shade plugins reset it cause it just needs to change it while dumping the pom (that said good point it breaks thread safety in concurrent builds). agree shade plugin breaks this rules and happy to get it fixed, it is just not that important cause shade plugin is generally in the end of the chain (so dowstream consumers list is empty) and it also handles itself the pom rewriting but you are right. long story short: I don't think we should re-read from the filesystem any pom model anytime in maven build otherwise the design itself is broken so I'm in favor of trying to not use the reader more than once per file. hope it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518264#comment-17518264 ] Hudson commented on MNG-828: Build unstable in Jenkins: Maven » Maven TLP » maven » PR-509 #11 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-509/11/ > log all mojo parameters and their populated values in debug mode > > > Key: MNG-828 > URL: https://issues.apache.org/jira/browse/MNG-828 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Brett Porter >Assignee: Brett Porter >Priority: Minor > Fix For: 2.0 (RC) > > > when we have this, we should remove the debugging code from plugins such as > ear that do this manually. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7447) Several Improvements by using Stream API
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518253#comment-17518253 ] Hudson commented on MNG-7447: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-700 #5 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-700/5/ > Several Improvements by using Stream API > > > Key: MNG-7447 > URL: https://issues.apache.org/jira/browse/MNG-7447 > Project: Maven > Issue Type: Sub-task >Affects Versions: 3.9.0, 4.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.9.0, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518254#comment-17518254 ] Hudson commented on MNG-828: Build unstable in Jenkins: Maven » Maven TLP » maven » PR-700 #5 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-700/5/ > log all mojo parameters and their populated values in debug mode > > > Key: MNG-828 > URL: https://issues.apache.org/jira/browse/MNG-828 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Brett Porter >Assignee: Brett Porter >Priority: Minor > Fix For: 2.0 (RC) > > > when we have this, we should remove the debugging code from plugins such as > ear that do this manually. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518251#comment-17518251 ] Hudson commented on MNG-828: Build unstable in Jenkins: Maven » Maven TLP » maven » PR-635 #15 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-635/15/ > log all mojo parameters and their populated values in debug mode > > > Key: MNG-828 > URL: https://issues.apache.org/jira/browse/MNG-828 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Brett Porter >Assignee: Brett Porter >Priority: Minor > Fix For: 2.0 (RC) > > > when we have this, we should remove the debugging code from plugins such as > ear that do this manually. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518240#comment-17518240 ] Hudson commented on MNG-828: Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-600 #11 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-600/11/ > log all mojo parameters and their populated values in debug mode > > > Key: MNG-828 > URL: https://issues.apache.org/jira/browse/MNG-828 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Brett Porter >Assignee: Brett Porter >Priority: Minor > Fix For: 2.0 (RC) > > > when we have this, we should remove the debugging code from plugins such as > ear that do this manually. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518239#comment-17518239 ] Hudson commented on MNG-828: Build unstable in Jenkins: Maven » Maven TLP » maven » PR-706 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-706/2/ > log all mojo parameters and their populated values in debug mode > > > Key: MNG-828 > URL: https://issues.apache.org/jira/browse/MNG-828 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Brett Porter >Assignee: Brett Porter >Priority: Minor > Fix For: 2.0 (RC) > > > when we have this, we should remove the debugging code from plugins such as > ear that do this manually. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7447) Several Improvements by using Stream API
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518238#comment-17518238 ] Hudson commented on MNG-7447: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-706 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-706/2/ > Several Improvements by using Stream API > > > Key: MNG-7447 > URL: https://issues.apache.org/jira/browse/MNG-7447 > Project: Maven > Issue Type: Sub-task >Affects Versions: 3.9.0, 4.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.9.0, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518236#comment-17518236 ] Hudson commented on MNG-828: Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-691 #6 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-691/6/ > log all mojo parameters and their populated values in debug mode > > > Key: MNG-828 > URL: https://issues.apache.org/jira/browse/MNG-828 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Brett Porter >Assignee: Brett Porter >Priority: Minor > Fix For: 2.0 (RC) > > > when we have this, we should remove the debugging code from plugins such as > ear that do this manually. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #192: Bump spring-core from 5.3.15 to 5.3.18 in /indexer-examples/indexer-examples-spring
dependabot[bot] opened a new pull request, #192: URL: https://github.com/apache/maven-indexer/pull/192 Bumps [spring-core](https://github.com/spring-projects/spring-framework) from 5.3.15 to 5.3.18. Release notes Sourced from https://github.com/spring-projects/spring-framework/releases;>spring-core's releases. v5.3.18 :star: New Features Restrict access to property paths on Class references https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28261;>#28261 Introduce cancel(boolean mayInterruptIfRunning) in ScheduledTask https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28233;>#28233 :lady_beetle: Bug Fixes Move off deprecated API in SessionTransactionData https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28234;>#28234 :notebook_with_decorative_cover: Documentation Introduce warnings in documentation of SerializationUtils https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28246;>#28246 Update copyright date in reference manual https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28237;>#28237 @Transactional test does not execute all JPA lifecycle callback methods https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28228;>#28228 :heart: Contributors We'd like to thank all the contributors who worked on this release! https://github.com/izeye;>@izeye https://github.com/quaff;>@quaff v5.3.17 :star: New Features Using DataClassRowMapper causes No property found for column debug messages in logs https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28179;>#28179 Improve diagnostics in SpEL for large array creation https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28145;>#28145 Support custom HTTP status in client-side REST testing support https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/28105;>#28105 AsyncRestTemplate logging too verbose https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28049;>#28049 :lady_beetle: Bug Fixes java.lang.NoClassDefFoundError: org/springframework/cglib/beans/BeanMapEmitter https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28110;>#28110 CronExpression fails to calculate properly next execution when running on the day of winter daylight saving time https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28095;>#28095 Private init/destroy method may be invoked twice https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28083;>#28083 MappingJacksonValue and Jackson2CodecSupport#registerObjectMappersForType do not work together https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28045;>#28045 SpEL fails to recover from error during MIXED mode compilation https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28043;>#28043 When returning a ResponseEntity with a Flux while the function is suspended, it fails to encode the body https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/27809;>#27809 :notebook_with_decorative_cover: Documentation Improve documentation for @EnabledIf and @DisabledIf test support https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28157;>#28157 Links to Spring Security are broken in the reference guide https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28135;>#28135 Document that transaction rollback rules may result in unintentional matches https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28125;>#28125 Improve documentation for TestContext events https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/27757;>#27757 Clarify behavior for generics support in BeanUtils.copyProperties https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/27259;>#27259 :hammer: Dependency Upgrades ... (truncated) Commits https://github.com/spring-projects/spring-framework/commit/707a24c48b21fc35e8be715afc80f020a24a9714;>707a24c Release v5.3.18 https://github.com/spring-projects/spring-framework/commit/002546b3e4b8d791ea6acccb81eb3168f51abb15;>002546b Refine PropertyDescriptor filtering https://github.com/spring-projects/spring-framework/commit/1627f57f1f77abe17dd607c75476b9e4cb22ffbb;>1627f57 Disable flaky integration tests for now https://github.com/spring-projects/spring-framework/commit/3811cd4c0a0be3aac6e842cf1890610ce986449d;>3811cd4 Introduce warnings in documentation of SerializationUtils https://github.com/spring-projects/spring-framework/commit/d927e3736483c8f1e0c012fa1027a198fc775f66;>d927e37
[jira] [Commented] (MNG-7447) Several Improvements by using Stream API
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518208#comment-17518208 ] Hudson commented on MNG-7447: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-394 #12 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-394/12/ > Several Improvements by using Stream API > > > Key: MNG-7447 > URL: https://issues.apache.org/jira/browse/MNG-7447 > Project: Maven > Issue Type: Sub-task >Affects Versions: 3.9.0, 4.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.9.0, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518209#comment-17518209 ] Hudson commented on MNG-828: Build unstable in Jenkins: Maven » Maven TLP » maven » PR-394 #12 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-394/12/ > log all mojo parameters and their populated values in debug mode > > > Key: MNG-828 > URL: https://issues.apache.org/jira/browse/MNG-828 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Brett Porter >Assignee: Brett Porter >Priority: Minor > Fix For: 2.0 (RC) > > > when we have this, we should remove the debugging code from plugins such as > ear that do this manually. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7447) Several Improvements by using Stream API
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518206#comment-17518206 ] Hudson commented on MNG-7447: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-705 #3 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-705/3/ > Several Improvements by using Stream API > > > Key: MNG-7447 > URL: https://issues.apache.org/jira/browse/MNG-7447 > Project: Maven > Issue Type: Sub-task >Affects Versions: 3.9.0, 4.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.9.0, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r844060718 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null Review Comment: it seems better to have a convention or rule that the original model should be equal to the pom file. the shade plugin also breaking this convention, it reverts the parent.relativePath after write the model to the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MWAR-451) ISO8859-1 properties files get changed into UTF-8 when filtered
Dennis Lundberg created MWAR-451:
Summary: ISO8859-1 properties files get changed into UTF-8 when
filtered
Key: MWAR-451
URL: https://issues.apache.org/jira/browse/MWAR-451
Project: Maven WAR Plugin
Issue Type: New Feature
Components: filtering
Affects Versions: 3.3.2
Reporter: Dennis Lundberg
This issue is similar to https://issues.apache.org/jira/browse/MRESOURCES-171,
but for filtering web resources in maven-war-plugin.
We add properties files that have ISO-8859-1 encoding, as per the Java 8
requirements, as web resources in a war project. When these resources are
filtered they get converted to the encoding specified by the
project.build.sourceEncoding. There is a parameter resourceEncoding that can be
used to change the encoding for web reources, but it applies to all web
resource files which is not always what you want.
Here is the configuration used:
{code:xml}
org.apache.maven.plugins
maven-war-plugin
3.3.2
WEB-INF/classes
true
src/main/webapp/WEB-INF/classes
{code}
We propose to add a new parameter propertiesEncoding to the AbstractWarMojo. If
the value of this parameter is set and filtering is enabled and a web resource
file is a properties file, then the value of the parameter is used as encoding
when filtering the file.
If the parameter is not specified it defaults to project.build.sourceEncoding,
thus keeping the current behavior of the plugin unchanged.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MWAR-450) ISO8859-1 properties files get changed into UTF-8 when filtered
Dennis Lundberg created MWAR-450:
Summary: ISO8859-1 properties files get changed into UTF-8 when
filtered
Key: MWAR-450
URL: https://issues.apache.org/jira/browse/MWAR-450
Project: Maven WAR Plugin
Issue Type: Improvement
Components: filtering
Affects Versions: 3.3.2
Reporter: Dennis Lundberg
This issue is similar to https://issues.apache.org/jira/browse/MRESOURCES-171,
but for filtering web resources in maven-war-plugin.
We add properties files that have ISO-8859-1 encoding, as per the Java 8
requirements, as web resources in a war project. When these resources are
filtered they get converted to the encoding specified by the
project.build.sourceEncoding. There is a parameter resourceEncoding that can be
used to change the encoding for web reources, but it applies to all web
resource files which is not always what you want.
Here is the configuration used:
{code:xml}
org.apache.maven.plugins
maven-war-plugin
3.3.2
WEB-INF/classes
true
src/main/webapp/WEB-INF/classes
{code}
We propose to add a new parameter propertiesEncoding to the AbstractWarMojo. If
the value of this parameter is set and filtering is enabled and a web resource
file is a properties file, then the value of the parameter is used as encoding
when filtering the file.
If the parameter is not specified it defaults to project.build.sourceEncoding,
thus keeping the current behavior of the plugin unchanged.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (MWAR-449) ISO8859-1 properties files get changed into UTF-8 when filtered
Dennis Lundberg created MWAR-449:
Summary: ISO8859-1 properties files get changed into UTF-8 when
filtered
Key: MWAR-449
URL: https://issues.apache.org/jira/browse/MWAR-449
Project: Maven WAR Plugin
Issue Type: Improvement
Components: filtering
Affects Versions: 3.3.2
Reporter: Dennis Lundberg
This issue is similar to https://issues.apache.org/jira/browse/MRESOURCES-171,
but for filtering web resources in maven-war-plugin.
We add properties files that have ISO-8859-1 encoding, as per the Java 8
requirements, as web resources in a war project. When these resources are
filtered they get converted to the encoding specified by the
project.build.sourceEncoding. There is a parameter resourceEncoding that can be
used to change the encoding for web reources, but it applies to all web
resource files which is not always what you want.
Here is the configuration used:
{code:xml}
org.apache.maven.plugins
maven-war-plugin
3.3.2
WEB-INF/classes
true
src/main/webapp/WEB-INF/classes
{code}
We propose to add a new parameter propertiesEncoding to the AbstractWarMojo. If
the value of this parameter is set and filtering is enabled and a web resource
file is a properties file, then the value of the parameter is used as encoding
when filtering the file.
If the parameter is not specified it defaults to project.build.sourceEncoding,
thus keeping the current behavior of the plugin unchanged.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518188#comment-17518188 ] Hudson commented on MNG-828: Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-565 #11 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-565/11/ > log all mojo parameters and their populated values in debug mode > > > Key: MNG-828 > URL: https://issues.apache.org/jira/browse/MNG-828 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Brett Porter >Assignee: Brett Porter >Priority: Minor > Fix For: 2.0 (RC) > > > when we have this, we should remove the debugging code from plugins such as > ear that do this manually. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MSKINS-174) Render breadcrumbs div conditionally
[ https://issues.apache.org/jira/browse/MSKINS-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518124#comment-17518124 ] Swarup Patra commented on MSKINS-174: - Of Det Contreely Behind Success Of moring Date By Free Sins > Render breadcrumbs div conditionally > > > Key: MSKINS-174 > URL: https://issues.apache.org/jira/browse/MSKINS-174 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.9 >Reporter: Konrad Windszus >Priority: Major > Attachments: breadcrumb-div.png > > > Currently the breadcrumb div is always rendered even if it is empty > (https://github.com/apache/maven-fluido-skin/blob/dda45e9236f90dc8493fcc917a99716212825573/src/main/resources/META-INF/maven/site.vm#L202). > That leads to the issue that a grey bar is rendered in case the publish date > is not rendered at the top (left or right): !breadcrumb-div.png! > That div should be rendered only conditionally in case there is > # at least one breadcrumb item or > # the publish date is positioned "left" or "right" -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843928400 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null +? project.getOriginalModel().clone() +: new MavenXpp3Reader().read( new FileInputStream( project.getFile() ) ); Review Comment: ok, now we use ModelReader to parse the pom -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843924166 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null Review Comment: Hmm, I just checked flatten code and it only works if `updatePomFile` is set to true no? So long story short, if you want it to work reliably you must ensure originalModel is set before shade plugin is executed. From a design point of view it is the responsability of flatten plugin to do that since it is the one hacking the user pom but an intermediary plugin setting it from a file when flatten plugin dumped its value would work too but I don't think there is any bug in shade there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843918306 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null +? project.getOriginalModel().clone() +: new MavenXpp3Reader().read( new FileInputStream( project.getFile() ) ); Review Comment: I think we can blame "history" there, xpp3 is kind of old these days ;). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843882391 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null +? project.getOriginalModel().clone() +: new MavenXpp3Reader().read( new FileInputStream( project.getFile() ) ); Review Comment: the flatten plugins (not only https://github.com/mojohaus) are using `MavenXpp3Reader` way~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2061) BLOCKED in urefire-forkedjvm-stream-flusher
Slawomir Jaranowski created SUREFIRE-2061:
-
Summary: BLOCKED in urefire-forkedjvm-stream-flusher
Key: SUREFIRE-2061
URL: https://issues.apache.org/jira/browse/SUREFIRE-2061
Project: Maven Surefire
Issue Type: Bug
Affects Versions: 3.0.0-M6
Reporter: Slawomir Jaranowski
>From time to time test execution is hung up - wait forever ...
Now I can't reproduce it, test rerun fix it.
The stack is:
{code}
2022-04-06 13:59:05
Full thread dump OpenJDK 64-Bit Server VM (25.322-b00 mixed mode):
"Attach Listener" #16 daemon prio=9 os_prio=31 tid=0x7fe48036a000
nid=0x380b waiting on condition [0x]
java.lang.Thread.State: RUNNABLE
"surefire-forkedjvm-command-thread" #12 daemon prio=5 os_prio=31
tid=0x7fe504a5c000 nid=0xa803 runnable [0x7db43000]
java.lang.Thread.State: RUNNABLE
at java.io.FileInputStream.readBytes(Native Method)
at java.io.FileInputStream.read(FileInputStream.java:255)
at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
- locked <0x0005c000ccb0> (a java.io.BufferedInputStream)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
- locked <0x0005c000ccd8> (a java.io.BufferedInputStream)
at
org.apache.maven.surefire.api.util.internal.Channels$3.readImpl(Channels.java:217)
at
org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleReadableChannel.read(AbstractNoninterruptibleReadableChannel.java:54)
at
org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:487)
at
org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:473)
at
org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readMessageType(AbstractStreamDecoder.java:118)
at
org.apache.maven.surefire.booter.stream.CommandDecoder.decode(CommandDecoder.java:87)
at
org.apache.maven.surefire.booter.spi.CommandChannelDecoder.decode(CommandChannelDecoder.java:67)
at
org.apache.maven.surefire.booter.CommandReader$CommandRunnable.run(CommandReader.java:345)
at java.lang.Thread.run(Thread.java:750)
"surefire-forkedjvm-stream-flusher" #10 daemon prio=5 os_prio=31
tid=0x7fe500969000 nid=0xa903 waiting for monitor entry [0x7da4]
java.lang.Thread.State: BLOCKED (on object monitor)
at java.io.BufferedOutputStream.write(BufferedOutputStream.java:117)
- waiting to lock <0x0005c000d498> (a java.io.BufferedOutputStream)
at
org.apache.maven.surefire.api.util.internal.Channels$4.writeImpl(Channels.java:253)
at
org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:72)
at
org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:45)
at
org.apache.maven.surefire.booter.spi.AbstractMasterProcessChannelProcessorFactory$1.run(AbstractMasterProcessChannelProcessorFactory.java:65)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:750)
"Service Thread" #9 daemon prio=9 os_prio=31 tid=0x7fe50003a800 nid=0x5603
runnable [0x]
java.lang.Thread.State: RUNNABLE
"C1 CompilerThread3" #8 daemon prio=9 os_prio=31 tid=0x7fe50001f800
nid=0x3f03 waiting on condition [0x]
java.lang.Thread.State: RUNNABLE
"C2 CompilerThread2" #7 daemon prio=9 os_prio=31 tid=0x7fe5e800
nid=0x4103 waiting on condition [0x]
java.lang.Thread.State: RUNNABLE
"C2 CompilerThread1" #6 daemon prio=9 os_prio=31 tid=0x7fe4f607e800
nid=0x3d03 waiting on condition [0x]
java.lang.Thread.State: RUNNABLE
"C2 CompilerThread0" #5 daemon prio=9 os_prio=31 tid=0x7fe5d800
nid=0x3b03 waiting on condition [0x]
java.lang.Thread.State: RUNNABLE
"Signal Dispatcher" #4 daemon prio=9 os_prio=31 tid=0x7fe4f607c800
nid=0x4303 runnable [0x]
[jira] [Updated] (SUREFIRE-2061) BLOCKED in surefire-forkedjvm-stream-flusher
[
https://issues.apache.org/jira/browse/SUREFIRE-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated SUREFIRE-2061:
--
Summary: BLOCKED in surefire-forkedjvm-stream-flusher (was: BLOCKED in
urefire-forkedjvm-stream-flusher)
> BLOCKED in surefire-forkedjvm-stream-flusher
>
>
> Key: SUREFIRE-2061
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2061
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> From time to time test execution is hung up - wait forever ...
> Now I can't reproduce it, test rerun fix it.
> The stack is:
> {code}
> 2022-04-06 13:59:05
> Full thread dump OpenJDK 64-Bit Server VM (25.322-b00 mixed mode):
> "Attach Listener" #16 daemon prio=9 os_prio=31 tid=0x7fe48036a000
> nid=0x380b waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "surefire-forkedjvm-command-thread" #12 daemon prio=5 os_prio=31
> tid=0x7fe504a5c000 nid=0xa803 runnable [0x7db43000]
>java.lang.Thread.State: RUNNABLE
> at java.io.FileInputStream.readBytes(Native Method)
> at java.io.FileInputStream.read(FileInputStream.java:255)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccb0> (a java.io.BufferedInputStream)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccd8> (a java.io.BufferedInputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$3.readImpl(Channels.java:217)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleReadableChannel.read(AbstractNoninterruptibleReadableChannel.java:54)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:487)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:473)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readMessageType(AbstractStreamDecoder.java:118)
> at
> org.apache.maven.surefire.booter.stream.CommandDecoder.decode(CommandDecoder.java:87)
> at
> org.apache.maven.surefire.booter.spi.CommandChannelDecoder.decode(CommandChannelDecoder.java:67)
> at
> org.apache.maven.surefire.booter.CommandReader$CommandRunnable.run(CommandReader.java:345)
> at java.lang.Thread.run(Thread.java:750)
> "surefire-forkedjvm-stream-flusher" #10 daemon prio=5 os_prio=31
> tid=0x7fe500969000 nid=0xa903 waiting for monitor entry
> [0x7da4]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at java.io.BufferedOutputStream.write(BufferedOutputStream.java:117)
> - waiting to lock <0x0005c000d498> (a java.io.BufferedOutputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$4.writeImpl(Channels.java:253)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:72)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:45)
> at
> org.apache.maven.surefire.booter.spi.AbstractMasterProcessChannelProcessorFactory$1.run(AbstractMasterProcessChannelProcessorFactory.java:65)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> "Service Thread" #9 daemon prio=9 os_prio=31 tid=0x7fe50003a800
> nid=0x5603 runnable [0x]
>java.lang.Thread.State: RUNNABLE
> "C1 CompilerThread3" #8 daemon prio=9 os_prio=31 tid=0x7fe50001f800
> nid=0x3f03 waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "C2 CompilerThread2" #7 daemon prio=9 os_prio=31 tid=0x7fe5e800
> nid=0x4103 waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "C2 CompilerThread1" #6 daemon prio=9 os_prio=31
[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843879478 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null +? project.getOriginalModel().clone() +: new MavenXpp3Reader().read( new FileInputStream( project.getFile() ) ); Review Comment: thx, let me fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843877455 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null +? project.getOriginalModel().clone() +: new MavenXpp3Reader().read( new FileInputStream( project.getFile() ) ); Review Comment: the inputstream will not be closed but the correct way to read a pom is org.apache.maven.model.io.ModelReader anyway -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843876935 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null Review Comment: it is ok to not fall back to original model when `getFile()` is null, throwing an exception instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843874851 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null +? project.getOriginalModel().clone() +: new MavenXpp3Reader().read( new FileInputStream( project.getFile() ) ); Review Comment: @jglick how to leak the resource? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] jglick commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
jglick commented on code in PR #129:
URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843869980
##
src/it/projects/MSHADE-323-compatible-with-flatten-pom/pom.xml:
##
@@ -0,0 +1,84 @@
+
+
+
+
+
+ 4.0.0
+
+ org.apache.maven.its.shade.flatten
+ test
+ 1.0
+
+ MSHADE-323
+
+Test that integration of shade and flatten plugins.
Review Comment:
```suggestion
Test the integration of Shade and Flatten plugins.
```
##
src/it/projects/MSHADE-323-compatible-with-flatten-pom/verify.groovy:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+File pomFile = new File( basedir, "target/dependency-reduced-pom.xml" );
+assert pomFile.isFile()
+
+def ns = new groovy.xml.Namespace("http://maven.apache.org/POM/4.0.0;)
Review Comment:
```suggestion
def ns = new groovy.xml.Namespace( "http://maven.apache.org/POM/4.0.0; )
```
for consistency
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set
artifactsToRemove )
origDeps = transitiveDeps;
}
-Model model = project.getOriginalModel();
+final Model model = project.getFile() == null
+? project.getOriginalModel().clone()
+: new MavenXpp3Reader().read( new FileInputStream(
project.getFile() ) );
Review Comment:
Possible resource leak?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] dependabot[bot] commented on pull request #514: Bump junit from 4.8.2 to 4.13.1 in /surefire-providers/surefire-junit47
dependabot[bot] commented on PR #514: URL: https://github.com/apache/maven-surefire/pull/514#issuecomment-1090178291 OK, I won't notify you about junit:junit again, unless you re-open this PR or update it yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 closed pull request #514: Bump junit from 4.8.2 to 4.13.1 in /surefire-providers/surefire-junit47
Tibor17 closed pull request #514: Bump junit from 4.8.2 to 4.13.1 in /surefire-providers/surefire-junit47 URL: https://github.com/apache/maven-surefire/pull/514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #514: Bump junit from 4.8.2 to 4.13.1 in /surefire-providers/surefire-junit47
Tibor17 commented on PR #514: URL: https://github.com/apache/maven-surefire/pull/514#issuecomment-1090178244 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-2060) JDK 18 support
[ https://issues.apache.org/jira/browse/SUREFIRE-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-2060. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=4ce1433c484d268e0c17604a071ad43d27de9e47 > JDK 18 support > -- > > Key: SUREFIRE-2060 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2060 > Project: Maven Surefire > Issue Type: Improvement >Affects Versions: 2.22.2 > Environment: Jenkins, Maven >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 2.22.3 > > > We updated integration tests, JaCoCo to 0.8.7, etc in order to support JDK 18 > in Jenkins. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SUREFIRE-2060) JDK 18 support
Tibor Digana created SUREFIRE-2060: -- Summary: JDK 18 support Key: SUREFIRE-2060 URL: https://issues.apache.org/jira/browse/SUREFIRE-2060 Project: Maven Surefire Issue Type: Improvement Affects Versions: 2.22.2 Environment: Jenkins, Maven Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 2.22.3 We updated integration tests, JaCoCo to 0.8.7, etc in order to support JDK 18 in Jenkins. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SUREFIRE-2059) includeJUnit5Engines and excludeJUnit5Engines have wrong user property
[ https://issues.apache.org/jira/browse/SUREFIRE-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-2059. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=f2d28b80218dc3f9b1222d212ef4fce080faed57 > includeJUnit5Engines and excludeJUnit5Engines have wrong user property > -- > > Key: SUREFIRE-2059 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2059 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.0.0-M6 >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M7 > > > The prefix is missing. > _surefire.includeJUnit5Engines_ > _failsafe.includeJUnit5Engines_ > _surefire.excludeJUnit5Engines_ > _failsafe.excludeJUnit5Engines_ > are expected. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843825833 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null Review Comment: @gzm55 this pr does not impl 1 since it should never use original model in case 1 but always file to enable to chain plugins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-1051) Require Java 8
[ https://issues.apache.org/jira/browse/MSHARED-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Solórzano updated MSHARED-1051: - Description: Didn't notice before that an issue already exists: MSHARED-991 This can be closed as I'm not allowed to close my own issue. Priority: Trivial (was: Major) > Require Java 8 > -- > > Key: MSHARED-1051 > URL: https://issues.apache.org/jira/browse/MSHARED-1051 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Trivial > Labels: pull-request-available > > Didn't notice before that an issue already exists: MSHARED-991 > This can be closed as I'm not allowed to close my own issue. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MSHARED-991) Require Java 8
[ https://issues.apache.org/jira/browse/MSHARED-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518019#comment-17518019 ] ASF GitHub Bot commented on MSHARED-991: jorsol opened a new pull request, #19: URL: https://github.com/apache/maven-archiver/pull/19 Also updates dependencies that target Java 8. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Require Java 8 > -- > > Key: MSHARED-991 > URL: https://issues.apache.org/jira/browse/MSHARED-991 > Project: Maven Shared Components > Issue Type: Task > Components: maven-archiver >Reporter: Sylwester Lachiewicz >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-archiver] jorsol opened a new pull request, #19: [MSHARED-991] - Require Java 8
jorsol opened a new pull request, #19: URL: https://github.com/apache/maven-archiver/pull/19 Also updates dependencies that target Java 8. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1051) Require Java 8
[ https://issues.apache.org/jira/browse/MSHARED-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518018#comment-17518018 ] ASF GitHub Bot commented on MSHARED-1051: - jorsol closed pull request #18: [MSHARED-1051] - Require Java 8 URL: https://github.com/apache/maven-archiver/pull/18 > Require Java 8 > -- > > Key: MSHARED-1051 > URL: https://issues.apache.org/jira/browse/MSHARED-1051 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-archiver] jorsol closed pull request #18: [MSHARED-1051] - Require Java 8
jorsol closed pull request #18: [MSHARED-1051] - Require Java 8 URL: https://github.com/apache/maven-archiver/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-1051) Require Java 8
[ https://issues.apache.org/jira/browse/MSHARED-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Solórzano updated MSHARED-1051: - Labels: pull-request-available (was: ) > Require Java 8 > -- > > Key: MSHARED-1051 > URL: https://issues.apache.org/jira/browse/MSHARED-1051 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MSHARED-1051) Require Java 8
[ https://issues.apache.org/jira/browse/MSHARED-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518014#comment-17518014 ] ASF GitHub Bot commented on MSHARED-1051: - jorsol opened a new pull request, #18: URL: https://github.com/apache/maven-archiver/pull/18 Also updates dependencies that target Java 8. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Require Java 8 > -- > > Key: MSHARED-1051 > URL: https://issues.apache.org/jira/browse/MSHARED-1051 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-archiver] jorsol opened a new pull request, #18: [MSHARED-1051] - Require Java 8
jorsol opened a new pull request, #18: URL: https://github.com/apache/maven-archiver/pull/18 Also updates dependencies that target Java 8. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2059) includeJUnit5Engines and excludeJUnit5Engines have wrong user property
Tibor Digana created SUREFIRE-2059: -- Summary: includeJUnit5Engines and excludeJUnit5Engines have wrong user property Key: SUREFIRE-2059 URL: https://issues.apache.org/jira/browse/SUREFIRE-2059 Project: Maven Surefire Issue Type: Improvement Components: Maven Failsafe Plugin, Maven Surefire Plugin Affects Versions: 3.0.0-M6 Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 3.0.0-M7 The prefix is missing. _surefire.includeJUnit5Engines_ _failsafe.includeJUnit5Engines_ _surefire.excludeJUnit5Engines_ _failsafe.excludeJUnit5Engines_ are expected. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-deploy-plugin] plotters commented on a diff in pull request #21: [doc] improve site documentation deploy-ssh-external example
plotters commented on code in PR #21: URL: https://github.com/apache/maven-deploy-plugin/pull/21#discussion_r843733793 ## src/site/apt/examples/deploy-ssh-external.apt: ## @@ -58,9 +58,26 @@ Deployment of artifacts in an external SSH command ++ - If you are deploying from Unix or have Cygwin installed you won't need to any additional configuration in your <<>> - file as everything will be taken from the environment. But if you are on Windows and are using something like <<>> then - you will need something like the following: + If you are deploying from Linux/Unix or have Cygwin installed you only need to add the location of your PEM based private key in your <<>> + +++ + + + ... + + + production-server Review Comment: thanks, consistency is improved now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
gzm55 commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843730700 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null Review Comment: ok, this pr is the first choice, which prefer a practice single source to get current raw model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SUREFIRE-2057) JPMS Regression: requires static module not include anymore
[ https://issues.apache.org/jira/browse/SUREFIRE-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517995#comment-17517995 ] Tibor Digana edited comment on SUREFIRE-2057 at 4/6/22 9:33 AM: Why you marked this as a blocker? Compiler's bug is not a blocker. was (Author: tibor17): Why you marked this as a blocker? > JPMS Regression: requires static module not include anymore > --- > > Key: SUREFIRE-2057 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2057 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Blocker > Fix For: 3.0.0-M7 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2057) JPMS Regression: requires static module not include anymore
[ https://issues.apache.org/jira/browse/SUREFIRE-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517995#comment-17517995 ] Tibor Digana commented on SUREFIRE-2057: Why you marked this as a blocker? > JPMS Regression: requires static module not include anymore > --- > > Key: SUREFIRE-2057 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2057 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Blocker > Fix For: 3.0.0-M7 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin
rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843695691 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set artifactsToRemove ) origDeps = transitiveDeps; } -Model model = project.getOriginalModel(); +final Model model = project.getFile() == null Review Comment: My guess is that it was the really original file but since maven is a chain (per module) it is in practise the current pom file - otherwise it can't really be used by any plugins and some do. So guess the choice is: 1. keep original untouched but means no plugin should use it except help/debug ones (so fix is to always read getFile()) 2. ensure flatten plugin updates original model to let downstream plugins consumes the post processing model Personally I think the option 2 is what makes the most sense for the ecosystem (inter-plugin operability). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-2056) BufferOverflowException when encoding message with null testId
[
https://issues.apache.org/jira/browse/SUREFIRE-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-2056.
--
Resolution: Fixed
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=8e301949173f20971c288484e5711b5496e5df49
> BufferOverflowException when encoding message with null testId
> --
>
> Key: SUREFIRE-2056
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2056
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Yoann Rodière
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> The problem seems to have been introduced here:
> https://github.com/apache/maven-surefire/commit/79db90338fb474f91c76991388a35bc412ee1d46#diff-a901d2e995f3d9e7ca75988975cefff9bb5f88686c3d0c8fc8696bc749253e8cR396
> {code}
> int bufferMaxLength = estimateBufferLength(
> eventType.getOpcode().length(), runMode, encoder, 0,
> testRunId == null ? 0 : 1, message );
> {code}
> The buffer estimate seems to ignore the testRunId field completely when the
> testRunId is null, but the {{encodeHeader}} method still adds content to the
> buffer even when the testRunId is null, resulting in a buffer overflow:
> https://github.com/apache/maven-surefire/commit/79db90338fb474f91c76991388a35bc412ee1d46#diff-2c1d8cdb8be334b20d2b1befed41ac6776b024a3a8ae040e2413569ead512a21R92-R97
> {code}
> result.put( (byte) ( testRunId == null ? 0 : 1 ) );
> if ( testRunId != null )
> {
> result.putLong( testRunId );
> }
> result.put( (byte) ':' );
> {code}
> Sending a PR shortly.
> Stack trace:
> {noformat}
> java.lang.IllegalStateException: Failed to load ApplicationContext
> at
> org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:132)
> at
> org.springframework.test.context.support.DefaultTestContext.getApplicationContext(DefaultTestContext.java:124)
> at
> org.springframework.test.context.support.DependencyInjectionTestExecutionListener.injectDependencies(DependencyInjectionTestExecutionListener.java:118)
> at
> org.springframework.test.context.support.DependencyInjectionTestExecutionListener.prepareTestInstance(DependencyInjectionTestExecutionListener.java:83)
> at
> org.springframework.boot.test.autoconfigure.SpringBootDependencyInjectionTestExecutionListener.prepareTestInstance(SpringBootDependencyInjectionTestExecutionListener.java:43)
> at
> org.springframework.test.context.TestContextManager.prepareTestInstance(TestContextManager.java:248)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.createTest(SpringJUnit4ClassRunner.java:227)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner$1.runReflectiveCall(SpringJUnit4ClassRunner.java:289)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.methodBlock(SpringJUnit4ClassRunner.java:291)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:246)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:97)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:190)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at
[GitHub] [maven-surefire] Tibor17 merged pull request #506: SUREFIRE-2056 BufferOverflowException when encoding message with null testId
Tibor17 merged PR #506: URL: https://github.com/apache/maven-surefire/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SUREFIRE-2056) BufferOverflowException when encoding message with null testId
[
https://issues.apache.org/jira/browse/SUREFIRE-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-2056:
--
Assignee: Tibor Digana
> BufferOverflowException when encoding message with null testId
> --
>
> Key: SUREFIRE-2056
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2056
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Yoann Rodière
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> The problem seems to have been introduced here:
> https://github.com/apache/maven-surefire/commit/79db90338fb474f91c76991388a35bc412ee1d46#diff-a901d2e995f3d9e7ca75988975cefff9bb5f88686c3d0c8fc8696bc749253e8cR396
> {code}
> int bufferMaxLength = estimateBufferLength(
> eventType.getOpcode().length(), runMode, encoder, 0,
> testRunId == null ? 0 : 1, message );
> {code}
> The buffer estimate seems to ignore the testRunId field completely when the
> testRunId is null, but the {{encodeHeader}} method still adds content to the
> buffer even when the testRunId is null, resulting in a buffer overflow:
> https://github.com/apache/maven-surefire/commit/79db90338fb474f91c76991388a35bc412ee1d46#diff-2c1d8cdb8be334b20d2b1befed41ac6776b024a3a8ae040e2413569ead512a21R92-R97
> {code}
> result.put( (byte) ( testRunId == null ? 0 : 1 ) );
> if ( testRunId != null )
> {
> result.putLong( testRunId );
> }
> result.put( (byte) ':' );
> {code}
> Sending a PR shortly.
> Stack trace:
> {noformat}
> java.lang.IllegalStateException: Failed to load ApplicationContext
> at
> org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:132)
> at
> org.springframework.test.context.support.DefaultTestContext.getApplicationContext(DefaultTestContext.java:124)
> at
> org.springframework.test.context.support.DependencyInjectionTestExecutionListener.injectDependencies(DependencyInjectionTestExecutionListener.java:118)
> at
> org.springframework.test.context.support.DependencyInjectionTestExecutionListener.prepareTestInstance(DependencyInjectionTestExecutionListener.java:83)
> at
> org.springframework.boot.test.autoconfigure.SpringBootDependencyInjectionTestExecutionListener.prepareTestInstance(SpringBootDependencyInjectionTestExecutionListener.java:43)
> at
> org.springframework.test.context.TestContextManager.prepareTestInstance(TestContextManager.java:248)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.createTest(SpringJUnit4ClassRunner.java:227)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner$1.runReflectiveCall(SpringJUnit4ClassRunner.java:289)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.methodBlock(SpringJUnit4ClassRunner.java:291)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:246)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:97)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:190)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
