[GitHub] [maven-mvnd] hboutemy commented on pull request #574: Refactor build and release workflows
hboutemy commented on PR #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1094197350 the process is here https://maven.apache.org/developers/release/maven-project-release-procedure.html it should not change much even if JReleaser helps at automating a few parts (or we'll discover where it still requires future improvements) What is important is to execute the vote for minimum 72h on a release candidate available somewhere in source-release archive form (be it Apache's repository or anywhere else) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7433) [REGRESSION] Multiple maven instances working on same source tree can lock each other
[ https://issues.apache.org/jira/browse/MNG-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520061#comment-17520061 ] Dan Tran commented on MNG-7433: --- [~cstamas] from your explanation, can I assume that all 'aggregating' mojo executions are serialized in a multi-threaded reactor build? and it has nothing to do with another Maven instant. so far I am not able to reproduce it by using 'aggregating' sleep mojo in a multi modules settings > [REGRESSION] Multiple maven instances working on same source tree can lock > each other > - > > Key: MNG-7433 > URL: https://issues.apache.org/jira/browse/MNG-7433 > Project: Maven > Issue Type: Bug >Affects Versions: 3.8.5 >Reporter: Dan Tran >Priority: Major > > I have a large multi modules java maven build where: > * phase 1 - basic build + unit tests + jacoco - 40 min > * phase 2 - sonar:sonar 20 min > * phase 3 - final packaging and basic smoke-test - 20 min > To take advantage of Maven multi-threaded build, during the reactor build, > one of our maven module spins another instance of Maven to run sonar:sonar > goal right after the basic build is done. > This means our phase 2 and phase 3 run in parallel sharing the same source > tree, same local maven repo (where sonar:sonar should have all needed > dependencies at the share local maven repo to run its task) > With maven-3.8.5, parallelization is no longer possible, phase 3 is blocked > until phase 2 is done. > I am able to trace it to https://github.com/apache/maven/pull/628 where the > locking started the happen > How does the lock mechanic work? there must be a local file where both Maven > instances are watching each other. Is there an option to disable this lock? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-site] thawkin3 opened a new pull request, #298: docs: add missing word on What Is Maven page
thawkin3 opened a new pull request, #298: URL: https://github.com/apache/maven-site/pull/298 The word "Maven" was missing in this sentence: > While takes an opinionated approach to project layout, some projects may not fit with this structure for historical reasons. Should be "While Maven takes" rather than "While takes". Nice and simple fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] (MNG-7433) [REGRESSION] Multiple maven instances working on same source tree can lock each other
[ https://issues.apache.org/jira/browse/MNG-7433 ] Dan Tran deleted comment on MNG-7433: --- was (Author: dantran): further testing and debugging show that all mojo, with 'aggregator = true' set at @Mojo, executions are serialized in multi-thread reactor build and it has nothing to do with _'another mvn instant'_. > [REGRESSION] Multiple maven instances working on same source tree can lock > each other > - > > Key: MNG-7433 > URL: https://issues.apache.org/jira/browse/MNG-7433 > Project: Maven > Issue Type: Bug >Affects Versions: 3.8.5 >Reporter: Dan Tran >Priority: Major > > I have a large multi modules java maven build where: > * phase 1 - basic build + unit tests + jacoco - 40 min > * phase 2 - sonar:sonar 20 min > * phase 3 - final packaging and basic smoke-test - 20 min > To take advantage of Maven multi-threaded build, during the reactor build, > one of our maven module spins another instance of Maven to run sonar:sonar > goal right after the basic build is done. > This means our phase 2 and phase 3 run in parallel sharing the same source > tree, same local maven repo (where sonar:sonar should have all needed > dependencies at the share local maven repo to run its task) > With maven-3.8.5, parallelization is no longer possible, phase 3 is blocked > until phase 2 is done. > I am able to trace it to https://github.com/apache/maven/pull/628 where the > locking started the happen > How does the lock mechanic work? there must be a local file where both Maven > instances are watching each other. Is there an option to disable this lock? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-7433) [REGRESSION] Multiple maven instances working on same source tree can lock each other
[ https://issues.apache.org/jira/browse/MNG-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520058#comment-17520058 ] Dan Tran commented on MNG-7433: --- further testing and debugging show that all mojo, with 'aggregator = true' set at @Mojo, executions are serialized in multi-thread reactor build and it has nothing to do with _'another mvn instant'_. > [REGRESSION] Multiple maven instances working on same source tree can lock > each other > - > > Key: MNG-7433 > URL: https://issues.apache.org/jira/browse/MNG-7433 > Project: Maven > Issue Type: Bug >Affects Versions: 3.8.5 >Reporter: Dan Tran >Priority: Major > > I have a large multi modules java maven build where: > * phase 1 - basic build + unit tests + jacoco - 40 min > * phase 2 - sonar:sonar 20 min > * phase 3 - final packaging and basic smoke-test - 20 min > To take advantage of Maven multi-threaded build, during the reactor build, > one of our maven module spins another instance of Maven to run sonar:sonar > goal right after the basic build is done. > This means our phase 2 and phase 3 run in parallel sharing the same source > tree, same local maven repo (where sonar:sonar should have all needed > dependencies at the share local maven repo to run its task) > With maven-3.8.5, parallelization is no longer possible, phase 3 is blocked > until phase 2 is done. > I am able to trace it to https://github.com/apache/maven/pull/628 where the > locking started the happen > How does the lock mechanic work? there must be a local file where both Maven > instances are watching each other. Is there an option to disable this lock? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
slawekjaranowski commented on code in PR #505: URL: https://github.com/apache/maven-surefire/pull/505#discussion_r846689352 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/DefaultRunOrderCalculator.java: ## @@ -55,7 +55,7 @@ public DefaultRunOrderCalculator( RunOrderParameters runOrderParameters, int thr this.runOrder = runOrderParameters.getRunOrder(); this.sortOrder = this.runOrder.length > 0 ? getSortOrderComparator( this.runOrder[0] ) : null; Long runOrderRandomSeed = runOrderParameters.getRunOrderRandomSeed(); -this.random = new Random( runOrderRandomSeed == null ? System.nanoTime() : runOrderRandomSeed ); +random = runOrderRandomSeed == null ? null : new Random( runOrderRandomSeed ); Review Comment: IMHO here `runOrderParameters.getRunOrderRandomSeed();` never be null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
slawekjaranowski commented on code in PR #505: URL: https://github.com/apache/maven-surefire/pull/505#discussion_r846689054 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/DefaultRunOrderCalculator.java: ## @@ -55,7 +55,7 @@ public DefaultRunOrderCalculator( RunOrderParameters runOrderParameters, int thr this.runOrder = runOrderParameters.getRunOrder(); this.sortOrder = this.runOrder.length > 0 ? getSortOrderComparator( this.runOrder[0] ) : null; Long runOrderRandomSeed = runOrderParameters.getRunOrderRandomSeed(); -this.random = new Random( runOrderRandomSeed == null ? System.nanoTime() : runOrderRandomSeed ); +random = runOrderRandomSeed == null ? null : new Random( runOrderRandomSeed ); Review Comment: Why change in this way ...? When `rundom` will be null we will have NPE from `Collections.shuffle( testClasses, random );` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517: URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846684997 ## surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java: ## @@ -37,33 +35,45 @@ * * @since 3.0.0-M6 */ -public class TestNG740Configurator extends TestNG60Configurator +public class TestNG740Configurator +extends TestNG60Configurator Review Comment: This specific revision was a minor format change to match the style used throughout this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517: URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846684997 ## surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java: ## @@ -37,33 +35,45 @@ * * @since 3.0.0-M6 */ -public class TestNG740Configurator extends TestNG60Configurator +public class TestNG740Configurator +extends TestNG60Configurator Review Comment: This specific change was a minor format change to match the style used throughout this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-133) Improve resolver performance by using breadth-first search
[ https://issues.apache.org/jira/browse/MRESOLVER-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520023#comment-17520023 ] Gregory Ducharme commented on MRESOLVER-133: Is there a way for me to obtain the proposed resolver and test with my own use cases? > Improve resolver performance by using breadth-first search > -- > > Key: MRESOLVER-133 > URL: https://issues.apache.org/jira/browse/MRESOLVER-133 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: 1.4.2 >Reporter: Gregory Ducharme >Priority: Major > Attachments: mvnbaddeps.zip > > > > I believe the maven resolver is unnecessarily inefficient because it performs > a depth-first search of components to resolve dependencies. Consider the case > when dependencies use version ranges, the user intent is for maven to resolve > with the highest versions of dependencies that satisfy all constraints. If > maven were to use a breadth-first search (and terminate searching as soon as > a solution is found) then in many cases a valid set of dependencies can be > resolved (at the top of the version ranges) without requiring that all > historical versions are resolvable. One should get the same answer with both > depth-first and breadth first strategies, but with the breadth-first approach > not being vulnerable to a missing parent POM somewhere in history making it > impossible to build the head of code. Additionally, I suspect that > breadth-first would be faster and use less memory than depth first. > > Additionally the depth-first approach has a weakness that when ny version of > a parent pom of a component referenced in a dependency tree of another > component is missing maven fails to resolve dependencies. One get a message > of the form: > Failed to execute goal on project module: Could not resolve dependencies for > project baddepdemo.project2:module:jar:1: Failed to collect dependencies ... > > Currently the only way to resolve this issue is one of three ways: > 1) restore a missing parent POM into the repository history, or > 2) delete all modules associated with the missing parent POM from the > repository > 3) manually adjust version ranges in consumer dependencies to exclude the > bad versions of dependencies that refer to the missing parent POM. > > What I would like is a configuration switch that would allow one to select > between the two search strategies So that the manual interventions described > above are not required. > > I have include a zip file that include the minimal projects needed to > demonstrate the dependency resolution problem: > project 1 has a module and parent pom. > project 2 is a single pom that has a dependency on the module in project 1. > Project 2 uses a dependency range [1,) that indicates that the latest version > of project1's module is to be used. > If one builds two versions (1 and 2) of project 1, project2 will resolve to > use version 2 as expected. However if you delete the parent pom of project1 > from the repository maven cannot resolve dependencies and fails. If the > version range in project 2 is changed to [2,) then the expected behavior is > observed. > The zip file contains a shell script (demo.sh) that can be run without > parameters to demonstrate the behavior when all versions are present in the > repository. Run it with 1 as a parameter (the lower end of the version range > used in project2) and the script will delete the parent pom from project 1 > and the error condition will be demonstrated. Run it with 2 and maven will > resolve dependencies as version1 of project1 is explicitly excluded from the > dependency resolution process. > > I am also willing to look at the source and propose a patch, but I would need > guidance on which modules/source I should look at. > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846676868
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
+if ( !options.containsKey( THREADCOUNT_PROP ) )
{
-if ( !"methods".equalsIgnoreCase( parallel ) &&
!"classes".equalsIgnoreCase( parallel ) )
-{
-throw new TestSetFailedException( "Unsupported TestNG parallel
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
-}
-Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
-Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
-invokeSetter( suite, "setParallel", enumClass, parallelEnum );
+// acquire default [threadcount] value to avoid superclass
hardcoding to 1
+options.put( THREADCOUNT_PROP, Integer.toString(
suite.getThreadCount() ) );
}
-String dataProviderThreadCount = options.get(
"dataproviderthreadcount" );
-if ( dataProviderThreadCount != null )
+// if [parallel] option is specified
+if ( options.containsKey( PARALLEL_PROP ) )
{
-suite.setDataProviderThreadCount( Integer.parseInt(
dataProviderThreadCount ) );
+// try to load the [ParallelMode] enumeration
+Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
+// if enumeration loaded
+if ( enumClass != null )
+{
+// extract [parallel] option
+String parallel = options.remove( PARALLEL_PROP );
+try
+{
+// convert [parallel] option to corresponding constant
+Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
+// set [XmlSuite] parallel mode to specified value
+invokeSetter( suite, "setParallel", enumClass,
parallelEnum );
+}
+catch ( IllegalArgumentException e )
+{
+throw new TestSetFailedException( "Unsupported TestNG
parallel setting: " + parallel, e );
+}
+}
}
+
+// invoke superclass handler
+super.configure( suite, options );
Review Comment:
I just committed revisions that use the refactoring approach you
recommended. This eliminates the need for careful management of the options map
and makes the code more readable. It also adds more error detection with
improved reporting of configuration issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846676868
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
+if ( !options.containsKey( THREADCOUNT_PROP ) )
{
-if ( !"methods".equalsIgnoreCase( parallel ) &&
!"classes".equalsIgnoreCase( parallel ) )
-{
-throw new TestSetFailedException( "Unsupported TestNG parallel
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
-}
-Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
-Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
-invokeSetter( suite, "setParallel", enumClass, parallelEnum );
+// acquire default [threadcount] value to avoid superclass
hardcoding to 1
+options.put( THREADCOUNT_PROP, Integer.toString(
suite.getThreadCount() ) );
}
-String dataProviderThreadCount = options.get(
"dataproviderthreadcount" );
-if ( dataProviderThreadCount != null )
+// if [parallel] option is specified
+if ( options.containsKey( PARALLEL_PROP ) )
{
-suite.setDataProviderThreadCount( Integer.parseInt(
dataProviderThreadCount ) );
+// try to load the [ParallelMode] enumeration
+Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
+// if enumeration loaded
+if ( enumClass != null )
+{
+// extract [parallel] option
+String parallel = options.remove( PARALLEL_PROP );
+try
+{
+// convert [parallel] option to corresponding constant
+Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
+// set [XmlSuite] parallel mode to specified value
+invokeSetter( suite, "setParallel", enumClass,
parallelEnum );
+}
+catch ( IllegalArgumentException e )
+{
+throw new TestSetFailedException( "Unsupported TestNG
parallel setting: " + parallel, e );
+}
+}
}
+
+// invoke superclass handler
+super.configure( suite, options );
Review Comment:
I just committed revisions that use the refactoring approach you
recommended. This eliminates the need for careful management of the options map
and makes the code more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (SUREFIRE-2061) BLOCKED in surefire-forkedjvm-stream-flusher
[
https://issues.apache.org/jira/browse/SUREFIRE-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520019#comment-17520019
]
Tibor Digana edited comment on SUREFIRE-2061 at 4/9/22 8:17 PM:
Hey [~sjaranowski], pls try to find the dump in target/surefire-reports.
It would be some exception, I guess, NPE or something similar.
was (Author: tibor17):
Hey [~sjaranowski], pls try to find the dump in target/surefire-reports.
It would some exception, I guess, NPE or something similar.
> BLOCKED in surefire-forkedjvm-stream-flusher
>
>
> Key: SUREFIRE-2061
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2061
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Slawomir Jaranowski
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> From time to time test execution is hung up - wait forever ...
> Now I can't reproduce it, test rerun fix it.
> The stack is:
> {code}
> 2022-04-06 13:59:05
> Full thread dump OpenJDK 64-Bit Server VM (25.322-b00 mixed mode):
> "Attach Listener" #16 daemon prio=9 os_prio=31 tid=0x7fe48036a000
> nid=0x380b waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "surefire-forkedjvm-command-thread" #12 daemon prio=5 os_prio=31
> tid=0x7fe504a5c000 nid=0xa803 runnable [0x7db43000]
>java.lang.Thread.State: RUNNABLE
> at java.io.FileInputStream.readBytes(Native Method)
> at java.io.FileInputStream.read(FileInputStream.java:255)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccb0> (a java.io.BufferedInputStream)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccd8> (a java.io.BufferedInputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$3.readImpl(Channels.java:217)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleReadableChannel.read(AbstractNoninterruptibleReadableChannel.java:54)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:487)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:473)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readMessageType(AbstractStreamDecoder.java:118)
> at
> org.apache.maven.surefire.booter.stream.CommandDecoder.decode(CommandDecoder.java:87)
> at
> org.apache.maven.surefire.booter.spi.CommandChannelDecoder.decode(CommandChannelDecoder.java:67)
> at
> org.apache.maven.surefire.booter.CommandReader$CommandRunnable.run(CommandReader.java:345)
> at java.lang.Thread.run(Thread.java:750)
> "surefire-forkedjvm-stream-flusher" #10 daemon prio=5 os_prio=31
> tid=0x7fe500969000 nid=0xa903 waiting for monitor entry
> [0x7da4]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at java.io.BufferedOutputStream.write(BufferedOutputStream.java:117)
> - waiting to lock <0x0005c000d498> (a java.io.BufferedOutputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$4.writeImpl(Channels.java:253)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:72)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:45)
> at
> org.apache.maven.surefire.booter.spi.AbstractMasterProcessChannelProcessorFactory$1.run(AbstractMasterProcessChannelProcessorFactory.java:65)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> "Service Thread" #9 daemon prio=9 os_prio=31 tid=0x7fe50003a800
> nid=0x5603 runnable [0x]
>java.lang.Thread.State: RUNNABLE
> "C1 CompilerThread3" #8 daemon prio=9 os_prio=31
[jira] [Commented] (SUREFIRE-2061) BLOCKED in surefire-forkedjvm-stream-flusher
[
https://issues.apache.org/jira/browse/SUREFIRE-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520019#comment-17520019
]
Tibor Digana commented on SUREFIRE-2061:
Hey [~sjaranowski], pls try to find the dump in target/surefire-reports.
It would some exception, I guess, NPE or something similar.
> BLOCKED in surefire-forkedjvm-stream-flusher
>
>
> Key: SUREFIRE-2061
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2061
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Slawomir Jaranowski
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> From time to time test execution is hung up - wait forever ...
> Now I can't reproduce it, test rerun fix it.
> The stack is:
> {code}
> 2022-04-06 13:59:05
> Full thread dump OpenJDK 64-Bit Server VM (25.322-b00 mixed mode):
> "Attach Listener" #16 daemon prio=9 os_prio=31 tid=0x7fe48036a000
> nid=0x380b waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "surefire-forkedjvm-command-thread" #12 daemon prio=5 os_prio=31
> tid=0x7fe504a5c000 nid=0xa803 runnable [0x7db43000]
>java.lang.Thread.State: RUNNABLE
> at java.io.FileInputStream.readBytes(Native Method)
> at java.io.FileInputStream.read(FileInputStream.java:255)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccb0> (a java.io.BufferedInputStream)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccd8> (a java.io.BufferedInputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$3.readImpl(Channels.java:217)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleReadableChannel.read(AbstractNoninterruptibleReadableChannel.java:54)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:487)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:473)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readMessageType(AbstractStreamDecoder.java:118)
> at
> org.apache.maven.surefire.booter.stream.CommandDecoder.decode(CommandDecoder.java:87)
> at
> org.apache.maven.surefire.booter.spi.CommandChannelDecoder.decode(CommandChannelDecoder.java:67)
> at
> org.apache.maven.surefire.booter.CommandReader$CommandRunnable.run(CommandReader.java:345)
> at java.lang.Thread.run(Thread.java:750)
> "surefire-forkedjvm-stream-flusher" #10 daemon prio=5 os_prio=31
> tid=0x7fe500969000 nid=0xa903 waiting for monitor entry
> [0x7da4]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at java.io.BufferedOutputStream.write(BufferedOutputStream.java:117)
> - waiting to lock <0x0005c000d498> (a java.io.BufferedOutputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$4.writeImpl(Channels.java:253)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:72)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:45)
> at
> org.apache.maven.surefire.booter.spi.AbstractMasterProcessChannelProcessorFactory$1.run(AbstractMasterProcessChannelProcessorFactory.java:65)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> "Service Thread" #9 daemon prio=9 os_prio=31 tid=0x7fe50003a800
> nid=0x5603 runnable [0x]
>java.lang.Thread.State: RUNNABLE
> "C1 CompilerThread3" #8 daemon prio=9 os_prio=31 tid=0x7fe50001f800
> nid=0x3f03 waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "C2 CompilerThread2" #7 daemon prio=9 os_prio=31 tid=0x7fe5e800
> nid=0x4103 wa
[jira] [Updated] (SUREFIRE-2061) BLOCKED in surefire-forkedjvm-stream-flusher
[
https://issues.apache.org/jira/browse/SUREFIRE-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-2061:
---
Fix Version/s: 3.0.0-M7
> BLOCKED in surefire-forkedjvm-stream-flusher
>
>
> Key: SUREFIRE-2061
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2061
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> From time to time test execution is hung up - wait forever ...
> Now I can't reproduce it, test rerun fix it.
> The stack is:
> {code}
> 2022-04-06 13:59:05
> Full thread dump OpenJDK 64-Bit Server VM (25.322-b00 mixed mode):
> "Attach Listener" #16 daemon prio=9 os_prio=31 tid=0x7fe48036a000
> nid=0x380b waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "surefire-forkedjvm-command-thread" #12 daemon prio=5 os_prio=31
> tid=0x7fe504a5c000 nid=0xa803 runnable [0x7db43000]
>java.lang.Thread.State: RUNNABLE
> at java.io.FileInputStream.readBytes(Native Method)
> at java.io.FileInputStream.read(FileInputStream.java:255)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccb0> (a java.io.BufferedInputStream)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccd8> (a java.io.BufferedInputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$3.readImpl(Channels.java:217)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleReadableChannel.read(AbstractNoninterruptibleReadableChannel.java:54)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:487)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:473)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readMessageType(AbstractStreamDecoder.java:118)
> at
> org.apache.maven.surefire.booter.stream.CommandDecoder.decode(CommandDecoder.java:87)
> at
> org.apache.maven.surefire.booter.spi.CommandChannelDecoder.decode(CommandChannelDecoder.java:67)
> at
> org.apache.maven.surefire.booter.CommandReader$CommandRunnable.run(CommandReader.java:345)
> at java.lang.Thread.run(Thread.java:750)
> "surefire-forkedjvm-stream-flusher" #10 daemon prio=5 os_prio=31
> tid=0x7fe500969000 nid=0xa903 waiting for monitor entry
> [0x7da4]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at java.io.BufferedOutputStream.write(BufferedOutputStream.java:117)
> - waiting to lock <0x0005c000d498> (a java.io.BufferedOutputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$4.writeImpl(Channels.java:253)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:72)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:45)
> at
> org.apache.maven.surefire.booter.spi.AbstractMasterProcessChannelProcessorFactory$1.run(AbstractMasterProcessChannelProcessorFactory.java:65)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> "Service Thread" #9 daemon prio=9 os_prio=31 tid=0x7fe50003a800
> nid=0x5603 runnable [0x]
>java.lang.Thread.State: RUNNABLE
> "C1 CompilerThread3" #8 daemon prio=9 os_prio=31 tid=0x7fe50001f800
> nid=0x3f03 waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "C2 CompilerThread2" #7 daemon prio=9 os_prio=31 tid=0x7fe5e800
> nid=0x4103 waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "C2 CompilerThread1" #6 daemon prio=9 os_prio=31 tid=0x7fe4f607e800
> nid=0x3d03 waiting on condition [0x0
[jira] [Assigned] (SUREFIRE-2061) BLOCKED in surefire-forkedjvm-stream-flusher
[
https://issues.apache.org/jira/browse/SUREFIRE-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-2061:
--
Assignee: Tibor Digana
> BLOCKED in surefire-forkedjvm-stream-flusher
>
>
> Key: SUREFIRE-2061
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2061
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Slawomir Jaranowski
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> From time to time test execution is hung up - wait forever ...
> Now I can't reproduce it, test rerun fix it.
> The stack is:
> {code}
> 2022-04-06 13:59:05
> Full thread dump OpenJDK 64-Bit Server VM (25.322-b00 mixed mode):
> "Attach Listener" #16 daemon prio=9 os_prio=31 tid=0x7fe48036a000
> nid=0x380b waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "surefire-forkedjvm-command-thread" #12 daemon prio=5 os_prio=31
> tid=0x7fe504a5c000 nid=0xa803 runnable [0x7db43000]
>java.lang.Thread.State: RUNNABLE
> at java.io.FileInputStream.readBytes(Native Method)
> at java.io.FileInputStream.read(FileInputStream.java:255)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccb0> (a java.io.BufferedInputStream)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0005c000ccd8> (a java.io.BufferedInputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$3.readImpl(Channels.java:217)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleReadableChannel.read(AbstractNoninterruptibleReadableChannel.java:54)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:487)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:473)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readMessageType(AbstractStreamDecoder.java:118)
> at
> org.apache.maven.surefire.booter.stream.CommandDecoder.decode(CommandDecoder.java:87)
> at
> org.apache.maven.surefire.booter.spi.CommandChannelDecoder.decode(CommandChannelDecoder.java:67)
> at
> org.apache.maven.surefire.booter.CommandReader$CommandRunnable.run(CommandReader.java:345)
> at java.lang.Thread.run(Thread.java:750)
> "surefire-forkedjvm-stream-flusher" #10 daemon prio=5 os_prio=31
> tid=0x7fe500969000 nid=0xa903 waiting for monitor entry
> [0x7da4]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at java.io.BufferedOutputStream.write(BufferedOutputStream.java:117)
> - waiting to lock <0x0005c000d498> (a java.io.BufferedOutputStream)
> at
> org.apache.maven.surefire.api.util.internal.Channels$4.writeImpl(Channels.java:253)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:72)
> at
> org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleWritableChannel.write(AbstractNoninterruptibleWritableChannel.java:45)
> at
> org.apache.maven.surefire.booter.spi.AbstractMasterProcessChannelProcessorFactory$1.run(AbstractMasterProcessChannelProcessorFactory.java:65)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:750)
> "Service Thread" #9 daemon prio=9 os_prio=31 tid=0x7fe50003a800
> nid=0x5603 runnable [0x]
>java.lang.Thread.State: RUNNABLE
> "C1 CompilerThread3" #8 daemon prio=9 os_prio=31 tid=0x7fe50001f800
> nid=0x3f03 waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "C2 CompilerThread2" #7 daemon prio=9 os_prio=31 tid=0x7fe5e800
> nid=0x4103 waiting on condition [0x]
>java.lang.Thread.State: RUNNABLE
> "C2 CompilerThread1" #6 daemon prio=9 os_prio=31 tid=0x7fe4f607e800
> ni
[GitHub] [maven-jar-plugin] jorsol commented on a diff in pull request #19: [MJAR-278] Update plugin (requires Maven 3.2.5+)
jorsol commented on code in PR #19: URL: https://github.com/apache/maven-jar-plugin/pull/19#discussion_r846670241 ## pom.xml: ## @@ -26,7 +26,6 @@ maven-plugins org.apache.maven.plugins 34 Review Comment: `35` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')
Tibor17 commented on PR #233: URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-1094109133 Hi @dejan2609 can you pls rebase this PR? thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846669797
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
Review Comment:
Handling of the [dataproviderthreadcount] option here was also redundant and
has likewise been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846669309
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
+if ( !options.containsKey( THREADCOUNT_PROP ) )
{
-if ( !"methods".equalsIgnoreCase( parallel ) &&
!"classes".equalsIgnoreCase( parallel ) )
-{
-throw new TestSetFailedException( "Unsupported TestNG parallel
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
-}
-Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
-Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
-invokeSetter( suite, "setParallel", enumClass, parallelEnum );
+// acquire default [threadcount] value to avoid superclass
hardcoding to 1
+options.put( THREADCOUNT_PROP, Integer.toString(
suite.getThreadCount() ) );
}
-String dataProviderThreadCount = options.get(
"dataproviderthreadcount" );
-if ( dataProviderThreadCount != null )
+// if [parallel] option is specified
+if ( options.containsKey( PARALLEL_PROP ) )
{
-suite.setDataProviderThreadCount( Integer.parseInt(
dataProviderThreadCount ) );
+// try to load the [ParallelMode] enumeration
+Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
+// if enumeration loaded
+if ( enumClass != null )
+{
+// extract [parallel] option
+String parallel = options.remove( PARALLEL_PROP );
+try
+{
+// convert [parallel] option to corresponding constant
+Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
+// set [XmlSuite] parallel mode to specified value
+invokeSetter( suite, "setParallel", enumClass,
parallelEnum );
+}
+catch ( IllegalArgumentException e )
+{
+throw new TestSetFailedException( "Unsupported TestNG
parallel setting: " + parallel, e );
+}
+}
}
+
+// invoke superclass handler
+super.configure( suite, options );
Review Comment:
I could do as you suggest and extract the logic to `setThreadCount` and
`setParallel` methods. My current approach was intended to limit the scope of
revisions to this single class. Would you prefer that I refactor the
implementation? This would reduce the complexity a bit while expanding the
scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846669309
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
+if ( !options.containsKey( THREADCOUNT_PROP ) )
{
-if ( !"methods".equalsIgnoreCase( parallel ) &&
!"classes".equalsIgnoreCase( parallel ) )
-{
-throw new TestSetFailedException( "Unsupported TestNG parallel
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
-}
-Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
-Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
-invokeSetter( suite, "setParallel", enumClass, parallelEnum );
+// acquire default [threadcount] value to avoid superclass
hardcoding to 1
+options.put( THREADCOUNT_PROP, Integer.toString(
suite.getThreadCount() ) );
}
-String dataProviderThreadCount = options.get(
"dataproviderthreadcount" );
-if ( dataProviderThreadCount != null )
+// if [parallel] option is specified
+if ( options.containsKey( PARALLEL_PROP ) )
{
-suite.setDataProviderThreadCount( Integer.parseInt(
dataProviderThreadCount ) );
+// try to load the [ParallelMode] enumeration
+Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
+// if enumeration loaded
+if ( enumClass != null )
+{
+// extract [parallel] option
+String parallel = options.remove( PARALLEL_PROP );
+try
+{
+// convert [parallel] option to corresponding constant
+Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
+// set [XmlSuite] parallel mode to specified value
+invokeSetter( suite, "setParallel", enumClass,
parallelEnum );
+}
+catch ( IllegalArgumentException e )
+{
+throw new TestSetFailedException( "Unsupported TestNG
parallel setting: " + parallel, e );
+}
+}
}
+
+// invoke superclass handler
+super.configure( suite, options );
Review Comment:
I could do as you suggest and extract the logic to `setThreadCount` and
setParallel` methods. My current approach was intended to limit the scope of
revisions to this single class. Would you prefer that I refactor the
implementation? This would reduce the complexity a bit while expanding the
scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846668357
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
+if ( !options.containsKey( THREADCOUNT_PROP ) )
{
-if ( !"methods".equalsIgnoreCase( parallel ) &&
!"classes".equalsIgnoreCase( parallel ) )
-{
-throw new TestSetFailedException( "Unsupported TestNG parallel
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
-}
-Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
-Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
-invokeSetter( suite, "setParallel", enumClass, parallelEnum );
+// acquire default [threadcount] value to avoid superclass
hardcoding to 1
+options.put( THREADCOUNT_PROP, Integer.toString(
suite.getThreadCount() ) );
}
-String dataProviderThreadCount = options.get(
"dataproviderthreadcount" );
-if ( dataProviderThreadCount != null )
+// if [parallel] option is specified
+if ( options.containsKey( PARALLEL_PROP ) )
{
-suite.setDataProviderThreadCount( Integer.parseInt(
dataProviderThreadCount ) );
+// try to load the [ParallelMode] enumeration
+Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
+// if enumeration loaded
+if ( enumClass != null )
+{
+// extract [parallel] option
+String parallel = options.remove( PARALLEL_PROP );
+try
+{
+// convert [parallel] option to corresponding constant
+Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
+// set [XmlSuite] parallel mode to specified value
+invokeSetter( suite, "setParallel", enumClass,
parallelEnum );
+}
+catch ( IllegalArgumentException e )
+{
+throw new TestSetFailedException( "Unsupported TestNG
parallel setting: " + parallel, e );
+}
+}
}
+
+// invoke superclass handler
+super.configure( suite, options );
Review Comment:
Look closer... The value of the [parallel] option is being **removed** from
the map. I'm processing the option here, and the removal of the option avoids
double-processing (with the resultant failure) in the superclass implementation.
As I pointed out in my comments, skipping the invocation of the superclass
implementation has the result that all other specified options get ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846668357
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
+if ( !options.containsKey( THREADCOUNT_PROP ) )
{
-if ( !"methods".equalsIgnoreCase( parallel ) &&
!"classes".equalsIgnoreCase( parallel ) )
-{
-throw new TestSetFailedException( "Unsupported TestNG parallel
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
-}
-Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
-Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
-invokeSetter( suite, "setParallel", enumClass, parallelEnum );
+// acquire default [threadcount] value to avoid superclass
hardcoding to 1
+options.put( THREADCOUNT_PROP, Integer.toString(
suite.getThreadCount() ) );
}
-String dataProviderThreadCount = options.get(
"dataproviderthreadcount" );
-if ( dataProviderThreadCount != null )
+// if [parallel] option is specified
+if ( options.containsKey( PARALLEL_PROP ) )
{
-suite.setDataProviderThreadCount( Integer.parseInt(
dataProviderThreadCount ) );
+// try to load the [ParallelMode] enumeration
+Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
+// if enumeration loaded
+if ( enumClass != null )
+{
+// extract [parallel] option
+String parallel = options.remove( PARALLEL_PROP );
+try
+{
+// convert [parallel] option to corresponding constant
+Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
+// set [XmlSuite] parallel mode to specified value
+invokeSetter( suite, "setParallel", enumClass,
parallelEnum );
+}
+catch ( IllegalArgumentException e )
+{
+throw new TestSetFailedException( "Unsupported TestNG
parallel setting: " + parallel, e );
+}
+}
}
+
+// invoke superclass handler
+super.configure( suite, options );
Review Comment:
Look closer... The value of the [parallel] option is being **removed** from
the map. I'm processing the option here, and the removal of the option avoids
double-processing (with the resultant failure) in the superclass implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846668194
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
Review Comment:
This code is redundant. The superclass implementation already processes the
[threadcount] option. The reason I'm acquiring the default value when the
option is unspecified is that the superclass implementation assigns a default
value of 1, whereas TestNG currently assigns a default value of 5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
Tibor17 commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846660194
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
+if ( !options.containsKey( THREADCOUNT_PROP ) )
{
-if ( !"methods".equalsIgnoreCase( parallel ) &&
!"classes".equalsIgnoreCase( parallel ) )
-{
-throw new TestSetFailedException( "Unsupported TestNG parallel
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
-}
-Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
-Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
-invokeSetter( suite, "setParallel", enumClass, parallelEnum );
+// acquire default [threadcount] value to avoid superclass
hardcoding to 1
+options.put( THREADCOUNT_PROP, Integer.toString(
suite.getThreadCount() ) );
}
-String dataProviderThreadCount = options.get(
"dataproviderthreadcount" );
-if ( dataProviderThreadCount != null )
+// if [parallel] option is specified
+if ( options.containsKey( PARALLEL_PROP ) )
{
-suite.setDataProviderThreadCount( Integer.parseInt(
dataProviderThreadCount ) );
+// try to load the [ParallelMode] enumeration
+Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
+// if enumeration loaded
+if ( enumClass != null )
+{
+// extract [parallel] option
+String parallel = options.remove( PARALLEL_PROP );
+try
+{
+// convert [parallel] option to corresponding constant
+Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
+// set [XmlSuite] parallel mode to specified value
+invokeSetter( suite, "setParallel", enumClass,
parallelEnum );
+}
+catch ( IllegalArgumentException e )
+{
+throw new TestSetFailedException( "Unsupported TestNG
parallel setting: " + parallel, e );
+}
+}
}
+
+// invoke superclass handler
+super.configure( suite, options );
Review Comment:
If you want to call the super method and these problems appear, it is a good
practice to create abstract protected methods `setThreadCount()` and
`setParallel()`, other too, in an interface - first in super type. This way the
merge logic would be the same because it will be defined in some super type but
every abstract protected method would implement it specifically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
Tibor17 commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846657279
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
+if ( !options.containsKey( THREADCOUNT_PROP ) )
{
-if ( !"methods".equalsIgnoreCase( parallel ) &&
!"classes".equalsIgnoreCase( parallel ) )
-{
-throw new TestSetFailedException( "Unsupported TestNG parallel
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
-}
-Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
-Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
-invokeSetter( suite, "setParallel", enumClass, parallelEnum );
+// acquire default [threadcount] value to avoid superclass
hardcoding to 1
+options.put( THREADCOUNT_PROP, Integer.toString(
suite.getThreadCount() ) );
}
-String dataProviderThreadCount = options.get(
"dataproviderthreadcount" );
-if ( dataProviderThreadCount != null )
+// if [parallel] option is specified
+if ( options.containsKey( PARALLEL_PROP ) )
{
-suite.setDataProviderThreadCount( Integer.parseInt(
dataProviderThreadCount ) );
+// try to load the [ParallelMode] enumeration
+Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
+// if enumeration loaded
+if ( enumClass != null )
+{
+// extract [parallel] option
+String parallel = options.remove( PARALLEL_PROP );
+try
+{
+// convert [parallel] option to corresponding constant
+Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
+// set [XmlSuite] parallel mode to specified value
+invokeSetter( suite, "setParallel", enumClass,
parallelEnum );
+}
+catch ( IllegalArgumentException e )
+{
+throw new TestSetFailedException( "Unsupported TestNG
parallel setting: " + parallel, e );
+}
+}
}
+
+// invoke superclass handler
+super.configure( suite, options );
Review Comment:
The problem is that the super method `configure(...)` in
`TestNGMapConfigurator` already calls the method `setParallel(String parallel)`
in TestNG. This is what we want to avoid and that's why we made the fix in #339
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-133) Improve resolver performance by using breadth-first search
[ https://issues.apache.org/jira/browse/MRESOLVER-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1751#comment-1751 ] Ivan Babiankou commented on MRESOLVER-133: -- [~michael-o] From the top of my head, I'd say the main points of the ticket are implemented: BFS, resolving newer versions first, and skipping resolution of the older versions. [~cannucklehead] what do you think about this? [~jhughes] Have a look at `MavenITmng3379ParallelArtifactDownloadsTest` it asserts artifacts are resolved (not sure if it's the best way to do that). IIUC you could do a similar thing: have a single dependency with a version range and expect only the expected artifact to be resolved. > Improve resolver performance by using breadth-first search > -- > > Key: MRESOLVER-133 > URL: https://issues.apache.org/jira/browse/MRESOLVER-133 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: 1.4.2 >Reporter: Gregory Ducharme >Priority: Major > Attachments: mvnbaddeps.zip > > > > I believe the maven resolver is unnecessarily inefficient because it performs > a depth-first search of components to resolve dependencies. Consider the case > when dependencies use version ranges, the user intent is for maven to resolve > with the highest versions of dependencies that satisfy all constraints. If > maven were to use a breadth-first search (and terminate searching as soon as > a solution is found) then in many cases a valid set of dependencies can be > resolved (at the top of the version ranges) without requiring that all > historical versions are resolvable. One should get the same answer with both > depth-first and breadth first strategies, but with the breadth-first approach > not being vulnerable to a missing parent POM somewhere in history making it > impossible to build the head of code. Additionally, I suspect that > breadth-first would be faster and use less memory than depth first. > > Additionally the depth-first approach has a weakness that when ny version of > a parent pom of a component referenced in a dependency tree of another > component is missing maven fails to resolve dependencies. One get a message > of the form: > Failed to execute goal on project module: Could not resolve dependencies for > project baddepdemo.project2:module:jar:1: Failed to collect dependencies ... > > Currently the only way to resolve this issue is one of three ways: > 1) restore a missing parent POM into the repository history, or > 2) delete all modules associated with the missing parent POM from the > repository > 3) manually adjust version ranges in consumer dependencies to exclude the > bad versions of dependencies that refer to the missing parent POM. > > What I would like is a configuration switch that would allow one to select > between the two search strategies So that the manual interventions described > above are not required. > > I have include a zip file that include the minimal projects needed to > demonstrate the dependency resolution problem: > project 1 has a module and parent pom. > project 2 is a single pom that has a dependency on the module in project 1. > Project 2 uses a dependency range [1,) that indicates that the latest version > of project1's module is to be used. > If one builds two versions (1 and 2) of project 1, project2 will resolve to > use version 2 as expected. However if you delete the parent pom of project1 > from the repository maven cannot resolve dependencies and fails. If the > version range in project 2 is changed to [2,) then the expected behavior is > observed. > The zip file contains a shell script (demo.sh) that can be run without > parameters to demonstrate the behavior when all versions are present in the > repository. Run it with 1 as a parameter (the lower end of the version range > used in project2) and the script will delete the parent pom from project 1 > and the error condition will be demonstrated. Run it with 2 and maven will > resolve dependencies as version1 of project1 is explicitly excluded from the > dependency resolution process. > > I am also willing to look at the source and propose a patch, but I would need > guidance on which modules/source I should look at. > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-resources-plugin] patpatpat123 commented on pull request #12: Bump commons-io from 2.6 to 2.11.0
patpatpat123 commented on PR #12: URL: https://github.com/apache/maven-resources-plugin/pull/12#issuecomment-1094073265 I gave it a go, but my level is very beginner in Java. This is quite technically difficult for me, as I am more of a "happy user" of this project rather than someone who can do meaningful code commit. Crossing my fingers someone with better coding skill bump into this. Again, thank you guys a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
Tibor17 commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846648490
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
+if ( !options.containsKey( THREADCOUNT_PROP ) )
{
-if ( !"methods".equalsIgnoreCase( parallel ) &&
!"classes".equalsIgnoreCase( parallel ) )
-{
-throw new TestSetFailedException( "Unsupported TestNG parallel
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
-}
-Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
-Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
-invokeSetter( suite, "setParallel", enumClass, parallelEnum );
+// acquire default [threadcount] value to avoid superclass
hardcoding to 1
+options.put( THREADCOUNT_PROP, Integer.toString(
suite.getThreadCount() ) );
}
-String dataProviderThreadCount = options.get(
"dataproviderthreadcount" );
-if ( dataProviderThreadCount != null )
+// if [parallel] option is specified
+if ( options.containsKey( PARALLEL_PROP ) )
{
-suite.setDataProviderThreadCount( Integer.parseInt(
dataProviderThreadCount ) );
+// try to load the [ParallelMode] enumeration
+Class enumClass = tryLoadClass( XmlSuite.class.getClassLoader(),
"org.testng.xml.XmlSuite$ParallelMode" );
+// if enumeration loaded
+if ( enumClass != null )
+{
+// extract [parallel] option
+String parallel = options.remove( PARALLEL_PROP );
+try
+{
+// convert [parallel] option to corresponding constant
+Enum parallelEnum = Enum.valueOf( enumClass,
parallel.toUpperCase() );
+// set [XmlSuite] parallel mode to specified value
+invokeSetter( suite, "setParallel", enumClass,
parallelEnum );
+}
+catch ( IllegalArgumentException e )
+{
+throw new TestSetFailedException( "Unsupported TestNG
parallel setting: " + parallel, e );
+}
+}
}
+
+// invoke superclass handler
+super.configure( suite, options );
Review Comment:
Check the inheritance because I think this is not ok either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
Tibor17 commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846648374
##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +35,45 @@
*
* @since 3.0.0-M6
*/
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
{
@Override
public void configure( XmlSuite suite, Map options )
throws TestSetFailedException
{
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt(
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+// if [threadcount] option in unspecified
Review Comment:
This part is not our goal, right?
It should be reverted back; otherwise we may expect a new bug. Why you
deleted the call `suite.setThreadCount( threadCount )`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option
Tibor17 commented on code in PR #517: URL: https://github.com/apache/maven-surefire/pull/517#discussion_r846644422 ## surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java: ## @@ -37,33 +35,45 @@ * * @since 3.0.0-M6 */ -public class TestNG740Configurator extends TestNG60Configurator +public class TestNG740Configurator +extends TestNG60Configurator Review Comment: guys, it's better to avoid doing any refactoring. It's only harder for reviewers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7447) Several Improvements by using Stream API
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519988#comment-17519988 ] Hudson commented on MNG-7447: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-700 #7 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-700/7/ > Several Improvements by using Stream API > > > Key: MNG-7447 > URL: https://issues.apache.org/jira/browse/MNG-7447 > Project: Maven > Issue Type: Sub-task >Affects Versions: 3.9.0, 4.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.9.0, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-resources-plugin] slachiewicz commented on pull request #12: Bump commons-io from 2.6 to 2.11.0
slachiewicz commented on PR #12: URL: https://github.com/apache/maven-resources-plugin/pull/12#issuecomment-1094039990 Yes it is possible. This is open source project and everyone is invited to open PR and contribute so anyone else would benefit from it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MJAVADOC-709) JDK 17 support
[
https://issues.apache.org/jira/browse/MJAVADOC-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519982#comment-17519982
]
Gili edited comment on MJAVADOC-709 at 4/9/22 2:00 PM:
---
Sorry for the false-alarm, you are right. I was mistakenly running
JDK17-specific configuration using a JDK11 runtime.
You can close this issue.
was (Author: cowwoc):
Sorry for the false-alarm, you are right. I was mistakenly running
JDK17-specific configuration using a JDK11 runtime.
> JDK 17 support
> --
>
> Key: MJAVADOC-709
> URL: https://issues.apache.org/jira/browse/MJAVADOC-709
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.3.2
>Reporter: Gili
>Priority: Blocker
> Fix For: waiting-for-feedback
>
>
> The latest release of the Javadoc plugin is 3.3.2. When I run the `jar` goal
> I get the following error:
> {code:java}
> Caused by: java.lang.module.InvalidModuleDescriptorException: Unsupported
> major.minor version 61.0
> at jdk.internal.module.ModuleInfo.invalidModuleDescriptor
> (ModuleInfo.java:1091)
> at jdk.internal.module.ModuleInfo.doRead (ModuleInfo.java:195)
> at jdk.internal.module.ModuleInfo.read (ModuleInfo.java:131)
> at java.lang.module.ModuleDescriptor.read (ModuleDescriptor.java:2487)
> at org.codehaus.plexus.languages.java.jpms.BinaryModuleInfoParser.parse
> (BinaryModuleInfoParser.java:37)
> at
> org.codehaus.plexus.languages.java.jpms.AbstractBinaryModuleInfoParser.getModuleDescriptor
> (AbstractBinaryModuleInfoParser.java:90)
> at
> org.codehaus.plexus.languages.java.jpms.AbstractBinaryModuleInfoParser.getModuleDescriptor
> (AbstractBinaryModuleInfoParser.java:38)
> at org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePath
> (LocationManager.java:364)
> at org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePath
> (LocationManager.java:135)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addJavadocOptions
> (AbstractJavadocMojo.java:5232)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport
> (AbstractJavadocMojo.java:2213)
> at org.apache.maven.plugins.javadoc.JavadocJar.doExecute
> (JavadocJar.java:189)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.execute
> (AbstractJavadocMojo.java:2041)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> at org.codehaus.classworlds.Launcher.main (Launcher.java:47){code}
> Please add JDK 17 and 18 support now that the latter is out.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-javadoc-plugin] dependabot[bot] merged pull request #117: Bump maven-archiver from 3.5.1 to 3.5.2
dependabot[bot] merged PR #117: URL: https://github.com/apache/maven-javadoc-plugin/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-498) "module not found" when Java 9 module-info present
[
https://issues.apache.org/jira/browse/MJAVADOC-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519973#comment-17519973
]
Hudson commented on MJAVADOC-498:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-javadoc-plugin » master
#10
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-javadoc-plugin/job/master/10/
> "module not found" when Java 9 module-info present
> --
>
> Key: MJAVADOC-498
> URL: https://issues.apache.org/jira/browse/MJAVADOC-498
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.0.0-M1
> Environment: Apache Maven 3.5.0
> (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T15:39:06-04:00)
> Maven home: /opt/local/share/java/maven3
> Java version: 9, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Russell Gold
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.0
>
>
> Using my project at
> https://github.com/meterware/simplestub/tree/287794112a6c2c932f2dbd6747a6339b73ab3718
> running {{javadoc:javadoc}} yields:
> {noformat}org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:javadoc
> (default-cli) on project simplestub: An error has occurred in Javadoc report
> generation:
> Exit code: 1 -
> /Users/rgold/projects/meterware/simplestub/src/main/java/module-info.java:3:
> error: module not found: org.objectweb.asm.commons
> requires org.objectweb.asm.commons;
> ^
> /Users/rgold/projects/meterware/simplestub/src/main/java/module-info.java:4:
> error: module not found: javassist
> requires javassist;
> ^
> Command line was:
> /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home/bin/javadoc
> @options @packages @argfile
> Refer to the generated Javadoc files in
> '/Users/rgold/projects/meterware/simplestub/target/site/apidocs' dir.
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:564)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: An error has
> occurred in Javadoc report generation:
> Exit code: 1 -
> /Users/rgold/projects/meterware/simplestub/src/main/java/module-info.java:3:
> error: module not found: org.objectweb.asm.commons
> requires org.objectweb.asm.commons;
> ^
> /Users/rgold/projects/meterware/simplestub/src/main/java/module-info.java:4:
> error: module not found: javassist
> requires javassist;
> ^
> Command line was:
> /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home/bin/javadoc
> @options @packages @argfile
> Refer to the generated Javadoc files in
> '/Users/rgold/projects/meterware/simplest
[jira] [Commented] (MJAVADOC-437) javadoc:aggregate fails on initial build
[
https://issues.apache.org/jira/browse/MJAVADOC-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519972#comment-17519972
]
Hudson commented on MJAVADOC-437:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-javadoc-plugin » master #9
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-javadoc-plugin/job/master/9/
> javadoc:aggregate fails on initial build
>
>
> Key: MJAVADOC-437
> URL: https://issues.apache.org/jira/browse/MJAVADOC-437
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.10.3
>Reporter: Harald Wellmann
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.10.4
>
>
> h3. Scenario
> Take a SNAPSHOT version of a reactor project with at least two JAR modules.
> Assume that no artifacts of the given SNAPSHOT version have been built before
> (this is usually the case just after running release:perform).
> h3. Actual Behaviour
> Now run {{mvn javadoc:aggregate}}. This build fails in the forked lifecycle.
> maven-javadoc-plugin unnecessarily tries to resolve the JAR artifacts of the
> current reactor (which are not avialable yet) and add them to the Javadoc
> classpath.
> h3. Expected Behaviour
> Aggregated Javadoc should be generated without problems. It is sufficient to
> take the sources of the current reactor and only put *external* dependencies
> on the Javadoc classpath.
> This is a duplicate of an 8 year old bug MJAVADOC-116 with 51 votes which has
> been closed without being fixed.
> A patch for this problem was submitted in MJAVADOC-362, but does not seem to
> have received attention by committers. (I admit the problem description is
> not very clear.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] cstamas commented on pull request #712: Provide file transformer API replacement in Maven
cstamas commented on PR #712: URL: https://github.com/apache/maven/pull/712#issuecomment-1093981282 > We will have `InstallRequestTransformer` and `DeployRequestTransformer` so when I implement different component for it will it possible that I will have different list of installed and deployed artifacts? That's right and true even today, yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] dependabot[bot] merged pull request #118: Bump plexus-archiver from 4.2.6 to 4.2.7
dependabot[bot] merged PR #118: URL: https://github.com/apache/maven-javadoc-plugin/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #106: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2
dependabot[bot] commented on PR #106: URL: https://github.com/apache/maven-invoker-plugin/pull/106#issuecomment-1093963185 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski closed pull request #106: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2
slawekjaranowski closed pull request #106: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2 URL: https://github.com/apache/maven-invoker-plugin/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #103: Bump maven-site-plugin from 3.10.0 to 3.11.0
dependabot[bot] commented on PR #103: URL: https://github.com/apache/maven-invoker-plugin/pull/103#issuecomment-1093963045 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski closed pull request #103: Bump maven-site-plugin from 3.10.0 to 3.11.0
slawekjaranowski closed pull request #103: Bump maven-site-plugin from 3.10.0 to 3.11.0 URL: https://github.com/apache/maven-invoker-plugin/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #107: Bump maven-plugins from 34 to 35
dependabot[bot] commented on PR #107: URL: https://github.com/apache/maven-invoker-plugin/pull/107#issuecomment-1093961688 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski closed pull request #107: Bump maven-plugins from 34 to 35
slawekjaranowski closed pull request #107: Bump maven-plugins from 34 to 35 URL: https://github.com/apache/maven-invoker-plugin/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] dependabot[bot] commented on pull request #17: Bump mavenVersion from 3.1.0 to 3.8.5
dependabot[bot] commented on PR #17: URL: https://github.com/apache/maven-resources-plugin/pull/17#issuecomment-1093959435 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] slawekjaranowski closed pull request #17: Bump mavenVersion from 3.1.0 to 3.8.5
slawekjaranowski closed pull request #17: Bump mavenVersion from 3.1.0 to 3.8.5 URL: https://github.com/apache/maven-resources-plugin/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-1964) Method filtering support on excludes and includes file
[
https://issues.apache.org/jira/browse/SUREFIRE-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1964:
---
Fix Version/s: 2.22.3
> Method filtering support on excludes and includes file
> --
>
> Key: SUREFIRE-1964
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1964
> Project: Maven Surefire
> Issue Type: New Feature
> Components: Maven Surefire Plugin
>Reporter: Ildefonso Montero
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.3, 3.0.0-M6
>
>
> The current code of Maven Surefire plugin does not provide capabilities for
> performing method filtering on includes/excludes based on files (using
> surefire.excludesFile or surefire.includesFile params)
> Main idea is to provide the same method filtering capabilities that we can
> perform nowadays using the -Dtest parameter but on the mentioned resources
> Thus, if we perform {{mvn test -Dsurefire.excludesFile=/foo/bar/file}} and it
> is using method filtering like:
>
> {code:java}
> test.SomeTest#test1
> test.SomeTest#test2
> test.SomeTest#test3
> test.SomeTest#test4
> test.SomeTest#test5
> test.SomeTest#test6 {code}
> on a project like:
> [https://github.com/jglick/simple-maven-project-with-tests] we obtain:
>
> {{Method filter prohibited in includes|excludes|includesFile|excludesFile
> parameter}}
> With method filtering enabled on these parameters, we will be able to obtain
> {code:java}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running test.SomeTest
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035
> s - in test.SomeTest
> [INFO] Running test.OtherTest
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001
> s - in test.OtherTest
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.808 s
> [INFO] Finished at: 2021-12-03T18:00:37+01:00
> [INFO]
>
> {code}
> were test.SomeTest test methods were directly ignored.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-javadoc-plugin] dependabot[bot] merged pull request #131: Bump junit from 4.12 to 4.13.1 in /src/it/projects/MJAVADOC-498_modulepath
dependabot[bot] merged PR #131: URL: https://github.com/apache/maven-javadoc-plugin/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] dependabot[bot] merged pull request #132: Bump commons-io from 2.2 to 2.7 in /src/it/projects/MJAVADOC-437/module2
dependabot[bot] merged PR #132: URL: https://github.com/apache/maven-javadoc-plugin/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] patpatpat123 commented on pull request #12: Bump commons-io from 2.6 to 2.11.0
patpatpat123 commented on PR #12: URL: https://github.com/apache/maven-resources-plugin/pull/12#issuecomment-1093942577 Understood @slawekjaranowski, and thank you for taking the time answering. Would it be possible to consider the migration up to java 8 (or above) of this project please? Looking at this table: https://endoflife.date/java I believe it will be beneficial for this project to use a supported Java version. This project is widely used, hopefully this is possible. Again, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #712: Provide file transformer API replacement in Maven
slawekjaranowski commented on PR #712: URL: https://github.com/apache/maven/pull/712#issuecomment-1093931583 Another idea maybe we should have dedicated transformers for poms where result should be visible in reactor for other modules - m-shade-p case. And another transformers for rest of artifacts - where result can be consumed once by install and deploy phase. Now we do the same transformations twice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #712: Provide file transformer API replacement in Maven
slawekjaranowski commented on PR #712: URL: https://github.com/apache/maven/pull/712#issuecomment-1093910484 I see another issue `TransformerContext` is used by `ConsumerModelSourceTransformer` but leak to other Maven core components. IMHO eache Transformer component implementation should be independent of internal core implementation. But it can be other issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #712: Provide file transformer API replacement in Maven
slawekjaranowski commented on PR #712: URL: https://github.com/apache/maven/pull/712#issuecomment-1093884007 We will have `InstallRequestTransformer` and `DeployRequestTransformer` so when I implement different component for it will it possible that I will have different list of installed and deployed artifacts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] delanym commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed
delanym commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r846615081
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -3114,9 +3114,8 @@ protected void warnIfIllegalFailOnFlakeCount() throws
MojoFailureException
private void printDefaultSeedIfNecessary()
{
-if ( getRunOrderRandomSeed() == null && getRunOrder().equals(
RunOrder.RANDOM.name() ) )
+if ( getRunOrder().equals( RunOrder.RANDOM.name() ) )
{
-setRunOrderRandomSeed( System.nanoTime() );
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #712: Provide file transformer API replacement in Maven
cstamas commented on code in PR #712:
URL: https://github.com/apache/maven/pull/712#discussion_r846613885
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -261,9 +261,37 @@ else if ( request.isUpdateSnapshots() )
mavenRepositorySystem.injectProxy( session,
request.getPluginArtifactRepositories() );
mavenRepositorySystem.injectAuthentication( session,
request.getPluginArtifactRepositories() );
-if ( Features.buildConsumer( request.getUserProperties() ).isActive() )
+if ( !installRequestTransformers.isEmpty() )
+{
+if ( logger.isDebugEnabled() )
+{
+logger.debug( "Applying install request transformers (shown in
order):" );
+for ( InstallRequestTransformer transformer :
installRequestTransformers )
+{
+logger.debug( " * {}", transformer.getClass() );
+}
+logger.debug( "" );
+}
+session.getData().set(
+InstallRequestTransformer.KEY,
+new ChainedInstallRequestTransformer(
installRequestTransformers )
+);
+}
+if ( !deployRequestTransformers.isEmpty() )
{
-session.setFileTransformerManager( a ->
getTransformersForArtifact( a, session.getData() ) );
Review Comment:
Do not use FileTransformer API anymore, in short. If this get's accepted,
you will want to implement DeployRequestTransformer component... but let's go
baby steps first, and make sure this would work for you too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MPOM-315) Upgrade Maven Clean Plugin from 3.1.0 to 3.2.0
[ https://issues.apache.org/jira/browse/MPOM-315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-315. Assignee: Slawomir Jaranowski Resolution: Fixed > Upgrade Maven Clean Plugin from 3.1.0 to 3.2.0 > -- > > Key: MPOM-315 > URL: https://issues.apache.org/jira/browse/MPOM-315 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: asf >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-26 > > > h1. Release Notes - Maven Clean Plugin - Version 3.2.0 > h2. New Feature > * [MCLEAN-95] - Provide a fast deletion option > h2. Improvement > * [MCLEAN-89] - Add GitHub Information > * [MCLEAN-90] - Custom search broken on pages rendered using Fluido Skin > 1.7 > * [MCLEAN-91] - Upgrade maven-plugins to 34 > * [MCLEAN-98] - Upgrade maven-plugin parent to 35 > > h2. Task > * [MCLEAN-94] - Update plugin dependencies > * [MCLEAN-97] - Require Java 8 > > h2. Dependency upgrade > * [MCLEAN-87] - Upgrade maven-plugins parent to version 32 > * [MCLEAN-92] - Require Maven 3.1.1 (drop dependency to Maven 3.0) > * [MCLEAN-96] - Require Maven 3.2.5+ -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-apache-parent] slawekjaranowski merged pull request #77: Bump maven-clean-plugin from 3.1.0 to 3.2.0
slawekjaranowski merged PR #77: URL: https://github.com/apache/maven-apache-parent/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] slawekjaranowski commented on pull request #12: Bump commons-io from 2.6 to 2.11.0
slawekjaranowski commented on PR #12: URL: https://github.com/apache/maven-resources-plugin/pull/12#issuecomment-1093848333 First we need switch code to Java 8 ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] dependabot[bot] commented on pull request #16: Bump maven-plugins from 34 to 35
dependabot[bot] commented on PR #16: URL: https://github.com/apache/maven-resources-plugin/pull/16#issuecomment-1093847965 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] slawekjaranowski closed pull request #16: Bump maven-plugins from 34 to 35
slawekjaranowski closed pull request #16: Bump maven-plugins from 34 to 35 URL: https://github.com/apache/maven-resources-plugin/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-5001) @readonly Mojo parameter annotation doesn't work any more
[
https://issues.apache.org/jira/browse/MNG-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519946#comment-17519946
]
Slawomir Jaranowski commented on MNG-5001:
--
After long time - my proposition is to in first step generate warning about it.
In most of case stop using read only params must be consulted with plugin
authors. And probably need new version of used plugin.
> @readonly Mojo parameter annotation doesn't work any more
> -
>
> Key: MNG-5001
> URL: https://issues.apache.org/jira/browse/MNG-5001
> Project: Maven
> Issue Type: Bug
> Components: Plugin API
>Affects Versions: 3.0-alpha-1, 3.0.2
>Reporter: Jochen Ehret
>Priority: Major
> Fix For: 4.0.x-candidate
>
> Attachments: log-maven-2.2.1.txt, log-maven-3.0.2.txt, pom.xml,
> readonlytest.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In Maven 2.2.1, the @readonly annotation works as described: You can't
> configure a Mojo parameter in the pom section. If you do, the
> build will fail:
> {noformat}[INFO] Error configuring: test:test-plugin. Reason: ERROR: Cannot
> override read-only parameter: testParameter in goal:
> test:dumpParameter{noformat}
> In Maven 3.0.2, the @readonly seems to have no effect:
> {noformat}[INFO] --- test-plugin:0.0.1-SNAPSHOT:dumpParameter (test-exec) @
> test-project ---
> testParameter: readonly parameter configured in pom{noformat}
> You can reproduce the behaviour with the attached example project. Log
> outputs for Maven 2.2.1 and 3.0.2 are also attached.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #132: Bump commons-io from 2.2 to 2.7 in /src/it/projects/MJAVADOC-437/module2
dependabot[bot] opened a new pull request, #132: URL: https://github.com/apache/maven-javadoc-plugin/pull/132 Bumps commons-io from 2.2 to 2.7. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-javadoc-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] olamy commented on pull request #119: Bump assertj-core from 3.21.0 to 3.22.0
olamy commented on PR #119: URL: https://github.com/apache/maven-javadoc-plugin/pull/119#issuecomment-1093844203 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] olamy commented on pull request #118: Bump plexus-archiver from 4.2.6 to 4.2.7
olamy commented on PR #118: URL: https://github.com/apache/maven-javadoc-plugin/pull/118#issuecomment-1093844059 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] olamy commented on pull request #117: Bump maven-archiver from 3.5.1 to 3.5.2
olamy commented on PR #117: URL: https://github.com/apache/maven-javadoc-plugin/pull/117#issuecomment-1093843919 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] olamy commented on pull request #114: Bump maven-plugin-plugin from 3.6.1 to 3.6.2
olamy commented on PR #114: URL: https://github.com/apache/maven-javadoc-plugin/pull/114#issuecomment-1093843773 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #114: Bump maven-plugin-plugin from 3.6.1 to 3.6.2
dependabot[bot] commented on PR #114: URL: https://github.com/apache/maven-javadoc-plugin/pull/114#issuecomment-1093843789 Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] olamy commented on pull request #121: Bump mrm-maven-plugin from 1.2.0 to 1.3.0
olamy commented on PR #121: URL: https://github.com/apache/maven-javadoc-plugin/pull/121#issuecomment-1093843610 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] dependabot[bot] closed pull request #122: Bump actions/checkout from 2 to 3
dependabot[bot] closed pull request #122: Bump actions/checkout from 2 to 3 URL: https://github.com/apache/maven-javadoc-plugin/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #122: Bump actions/checkout from 2 to 3
dependabot[bot] commented on PR #122: URL: https://github.com/apache/maven-javadoc-plugin/pull/122#issuecomment-1093843389 Looks like actions/checkout is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #131: Bump junit from 4.12 to 4.13.1 in /src/it/projects/MJAVADOC-498_modulepath
dependabot[bot] opened a new pull request, #131: URL: https://github.com/apache/maven-javadoc-plugin/pull/131 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13.1 Please refer to the https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md";>release notes for details. JUnit 4.13 Please refer to the https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md";>release notes for details. JUnit 4.13 RC 2 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes";>release notes for details. JUnit 4.13 RC 1 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes";>release notes for details. JUnit 4.13 Beta 3 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes";>release notes for details. JUnit 4.13 Beta 2 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes";>release notes for details. JUnit 4.13 Beta 1 Please refer to the https://github.com/junit-team/junit4/wiki/4.13-Release-Notes";>release notes for details. Commits https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66";>1b683f4 [maven-release-plugin] prepare release r4.13.1 https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2";>ce6ce3a Draft 4.13.1 release notes https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24";>c29dd82 Change version to 4.13.1-SNAPSHOT https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567";>1d17486 Add a link to assertThrows in exception testing https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9";>543905d Use separate line for annotation in Javadoc https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944";>510e906 Add sub headlines to class Javadoc https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae";>610155b Merge pull request from GHSA-269g-pwp5-87pp https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec";>b6cfd1e Explicitly wrap float parameter for consistency (https://github-redirect.dependabot.com/junit-team/junit4/issues/1671";>#1671) https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646";>a5d205c Fix GitHub link in FAQ (https://github-redirect.dependabot.com/junit-team/junit4/issues/1672";>#1672) https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8";>3a5c6b4 Deprecated since jdk9 replacing constructor instance of Double and Float (https://github-redirect.dependabot.com/junit-team/junit4/issues/1660";>#1660) Additional commits viewable in https://github.com/junit-team/junit4/compare/r4.12...r4.13.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](ht
[GitHub] [maven-javadoc-plugin] olamy commented on pull request #122: Bump actions/checkout from 2 to 3
olamy commented on PR #122: URL: https://github.com/apache/maven-javadoc-plugin/pull/122#issuecomment-1093843246 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #130: Bump spring-security-core from 2.0.4 to 4.2.17.RELEASE in /src/it/projects/MJAVADOC-526_aggr-managedDeps/javadoc-child
dependabot[bot] opened a new pull request, #130: URL: https://github.com/apache/maven-javadoc-plugin/pull/130 Bumps [spring-security-core](https://github.com/spring-projects/spring-security) from 2.0.4 to 4.2.17.RELEASE. Release notes Sourced from https://github.com/spring-projects/spring-security/releases";>spring-security-core's releases. 4.2.17.RELEASE :star: New Features HTTP Host header attack https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8639";>#8639 :beetle: Bug Fixes Fix AntPathRequestMatcher Javadoc https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8530";>#8530 Document NoOpPasswordEncoder will not be removed https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8525";>#8525 Spring Security BOM 4.2.14.RELEASE is missing https://github-redirect.dependabot.com/spring-projects/spring-security/issues/7975";>#7975 4.2.16.RELEASE :beetle: Bug Fixes Fix Javadoc punctuation https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8486";>#8486 Add ROLE_INFRASTRUCTURE to infrastructure beans https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8442";>#8442 SEC-2664: ActiveDirectoryLdapAuthenticationProvider should wrap communication exceptions in InternalAuthenticationServiceException https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8433";>#8433 Fix example in javadoc of FilterChainProxy https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8355";>#8355 4.2.15.RELEASE :star: New Features SwitchUserFilter vulnerable to CSRF https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8226";>#8226 Update Encryptors documentation for standard and stronger https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8219";>#8219 Typo 'properites' -> 'properties' in documentation https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8102";>#8102 :beetle: Bug Fixes HttpServletRequest.logout() not functioning https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8244";>#8244 Spring Security BOM 4.2.14.RELEASE is missing https://github-redirect.dependabot.com/spring-projects/spring-security/issues/7975";>#7975 :hammer: Dependency Upgrades Update to jackson-databind:2.8.11.6 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8273";>#8273 Update to appengine:1.9.79 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8272";>#8272 Update to spring-io-plugin:0.0.8.RELEASE https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8271";>#8271 Update to nekohtml:1.9.22 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8270";>#8270 Update to thymeleaf-layout-dialect:2.0.5 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8269";>#8269 Update to httpclient:4.2.6 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8268";>#8268 Update to taglibs-standard-jstlel:1.2.5 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8267";>#8267 Update to Jetty 8.1.22.v20160922 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8266";>#8266 Update to Tomcat 7.0.103 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8265";>#8265 Update to asciidoctor-gradle-plugin:1.5.7 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8264";>#8264 Update to Groovy 2.4.19 https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8263";>#8263 Update to spring-boot-gradle-plugin:1.5.22.RELEASE https://github-redirect.dependabot.com/spring-projects/spring-security/issues/8262";>#8262 4.2.14.RELEASE :star: New Features Build 4.2.x on Jenkins https://github-redirect.dependabot.com/spring-projects/spring-security/issues/7940";>#7940 ... (truncated) Commits https://github.com/spring-projects/spring-security/commit/54b28873eeed9a9d7cf72f21d1ae0542e99393ab";>54b2887 Release 4.2.17.RELEASE https://github.com/spring-projects/spring-security/commit/692ac213f9b93f68c38f8321c4d4b517d419e30a";>692ac21 Polish setAllowedHostnames https://github.com/spring-projects/spring-security/commit/e4e73631964de2ea7c72a1d3bdfef7b69d841aef";>e4e7363 Add support for allowedHostnames in StrictHttpFirewall https://github.com/spring-projects/spring-security/commit/75e248344b28dde79ba6315a42de6df91b884e8d";>75e2483 uploadArchives dependsOn mavenBom https://github.com/spring-projects/spring-security/commit/3ae6cdf05f38c6dee5722844b9cf7b78248cc323";>3ae6cdf Update AntPathRequestMatcher.java https://github.com/spring-proj
[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #129: Bump spring-webmvc from 4.3.29.RELEASE to 5.3.18 in /src/it/projects/MJAVADOC-434_fixcompile
dependabot[bot] opened a new pull request, #129: URL: https://github.com/apache/maven-javadoc-plugin/pull/129 Bumps [spring-webmvc](https://github.com/spring-projects/spring-framework) from 4.3.29.RELEASE to 5.3.18. Release notes Sourced from https://github.com/spring-projects/spring-framework/releases";>spring-webmvc's releases. v5.3.18 :star: New Features Restrict access to property paths on Class references https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28261";>#28261 Introduce cancel(boolean mayInterruptIfRunning) in ScheduledTask https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28233";>#28233 :lady_beetle: Bug Fixes Move off deprecated API in SessionTransactionData https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28234";>#28234 :notebook_with_decorative_cover: Documentation Introduce warnings in documentation of SerializationUtils https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28246";>#28246 Update copyright date in reference manual https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28237";>#28237 @Transactional test does not execute all JPA lifecycle callback methods https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28228";>#28228 :heart: Contributors We'd like to thank all the contributors who worked on this release! https://github.com/izeye";>@izeye https://github.com/quaff";>@quaff v5.3.17 :star: New Features Using DataClassRowMapper causes "No property found for column" debug messages in logs https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28179";>#28179 Improve diagnostics in SpEL for large array creation https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28145";>#28145 Support custom HTTP status in client-side REST testing support https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/28105";>#28105 AsyncRestTemplate logging too verbose https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28049";>#28049 :lady_beetle: Bug Fixes java.lang.NoClassDefFoundError: org/springframework/cglib/beans/BeanMapEmitter https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28110";>#28110 CronExpression fails to calculate properly next execution when running on the day of winter daylight saving time https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28095";>#28095 Private init/destroy method may be invoked twice https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28083";>#28083 MappingJacksonValue and Jackson2CodecSupport#registerObjectMappersForType do not work together https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28045";>#28045 SpEL fails to recover from error during MIXED mode compilation https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28043";>#28043 When returning a ResponseEntity with a Flux while the function is suspended, it fails to encode the body https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/27809";>#27809 :notebook_with_decorative_cover: Documentation Improve documentation for @EnabledIf and @DisabledIf test support https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28157";>#28157 Links to Spring Security are broken in the reference guide https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28135";>#28135 Document that transaction rollback rules may result in unintentional matches https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28125";>#28125 Improve documentation for TestContext events https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/27757";>#27757 Clarify behavior for generics support in BeanUtils.copyProperties https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/27259";>#27259 :hammer: Dependency Upgrades ... (truncated) Commits https://github.com/spring-projects/spring-framework/commit/707a24c48b21fc35e8be715afc80f020a24a9714";>707a24c Release v5.3.18 https://github.com/spring-projects/spring-framework/commit/002546b3e4b8d791ea6acccb81eb3168f51abb15";>002546b Refine PropertyDescriptor filtering https://github.com/spring-projects/spring-framework/commit/1627f57f1f77abe17dd607c75476b9e4cb22ffbb";>1627f57 Disable flaky integration tests for now https://github.com/spring-projects/spring-framework/commit/3811cd4c0a0be3aac6e842cf1890610ce986449d";>3811cd4 Introduce warnings in documentation of SerializationUtils https://github.com/spring-projects/spring-framework/commit/d927
[GitHub] [maven-javadoc-plugin] olamy merged pull request #128: use shared gh action/release-drafter
olamy merged PR #128: URL: https://github.com/apache/maven-javadoc-plugin/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas closed pull request #162: Proposed replacement for OOM-prone FileTransformer API.
cstamas closed pull request #162: Proposed replacement for OOM-prone FileTransformer API. URL: https://github.com/apache/maven-resolver/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-2062) Remove code corresponding to jdk 7 from IT tests
[
https://issues.apache.org/jira/browse/SUREFIRE-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed SUREFIRE-2062.
-
Fix Version/s: 3.0.0-M7
Resolution: Fixed
> Remove code corresponding to jdk 7 from IT tests
>
>
> Key: SUREFIRE-2062
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2062
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> Now jdk 8 is as minumum, we can remove codes like:
> {code:java}
> assumeJavaVersion( 1.8d ); {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski merged pull request #515: [SUREFIRE-2062] Remove code corresponding to jdk 7 from IT tests
slawekjaranowski merged PR #515: URL: https://github.com/apache/maven-surefire/pull/515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] hboutemy commented on pull request #51: [MPOM-295] Remove checkstyle from Maven site reports
hboutemy commented on PR #51: URL: https://github.com/apache/maven-parent/pull/51#issuecomment-1093840001 I was as clear as I could with my -1 = short answer to avoid long discussion that I thought would be avoided after the "I will not fight for it" early answer I got there is nothing to "fix" because nothing is broken with these reports but I agree that I would love to see the report on CI https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-clean-plugin/job/master/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #712: Use of the proposed new transformer API in Maven
cstamas commented on PR #712: URL: https://github.com/apache/maven/pull/712#issuecomment-1093838217 @slawekjaranowski just FYI https://github.com/apache/maven-resolver/commit/1c79c4f8b6573e9693f4ae61c14bff17755aa32d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #712: Use of the proposed new transformer API in Maven
slawekjaranowski commented on code in PR #712:
URL: https://github.com/apache/maven/pull/712#discussion_r846606690
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -261,9 +261,37 @@ else if ( request.isUpdateSnapshots() )
mavenRepositorySystem.injectProxy( session,
request.getPluginArtifactRepositories() );
mavenRepositorySystem.injectAuthentication( session,
request.getPluginArtifactRepositories() );
-if ( Features.buildConsumer( request.getUserProperties() ).isActive() )
+if ( !installRequestTransformers.isEmpty() )
+{
+if ( logger.isDebugEnabled() )
+{
+logger.debug( "Applying install request transformers (shown in
order):" );
+for ( InstallRequestTransformer transformer :
installRequestTransformers )
+{
+logger.debug( " * {}", transformer.getClass() );
+}
+logger.debug( "" );
+}
+session.getData().set(
+InstallRequestTransformer.KEY,
+new ChainedInstallRequestTransformer(
installRequestTransformers )
+);
+}
+if ( !deployRequestTransformers.isEmpty() )
{
-session.setFileTransformerManager( a ->
getTransformersForArtifact( a, session.getData() ) );
Review Comment:
do we remove both `setFileTransformerManager` and
`getFileTransformerManager` from `session`?
if not set what return get method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #712: Use of the proposed new transformer API in Maven
slawekjaranowski commented on PR #712: URL: https://github.com/apache/maven/pull/712#issuecomment-1093837719 Will be appreciate show example how plugin can add new transformers like signers. I use transformers in sign-m-p for build signatures. https://github.com/s4u/sign-maven-plugin/blob/master/src/main/java/org/simplify4u/plugins/sign/ArtifactSigner40.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #712: Use of the proposed new transformer API in Maven
cstamas commented on PR #712: URL: https://github.com/apache/maven/pull/712#issuecomment-1093835106 @slawekjaranowski so, this is new proposal. The interesting thing is that now we can define a "chain" of transformers, separately, for install and for deploy. The order of transformers is currently defined by SISU only (so sisu component ordering applies, as to everything in Maven, see https://www.eclipse.org/lists/sisu-users/msg00144.html, we can later refine this if needed). So, the point is, that now one can define for deploy only: * consumer-pom - transforms installed/deployed pom to consumer pom * signer - signs artifacts * CI build provenance - attaches some extra descriptor artifact * etc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] olamy opened a new pull request, #128: use shared gh action/release-drafter
olamy opened a new pull request, #128: URL: https://github.com/apache/maven-javadoc-plugin/pull/128 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #712: Use of the propsed ArtifactTransformer in Maven
cstamas commented on code in PR #712:
URL: https://github.com/apache/maven/pull/712#discussion_r846604072
##
maven-core/src/main/java/org/apache/maven/internal/aether/ConsumerPomArtifactTransformer.java:
##
@@ -0,0 +1,94 @@
+package org.apache.maven.internal.aether;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Provider;
+import javax.inject.Singleton;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.UncheckedIOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.StandardCopyOption;
+import java.util.Collection;
+import java.util.Collections;
+
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.model.building.TransformerContext;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.transform.ArtifactTransformer;
+
+@Named( ConsumerPomArtifactTransformer.NAME )
+@Singleton
+public class ConsumerPomArtifactTransformer implements ArtifactTransformer
+{
+public static final String NAME = "consumer-pom";
+
+private final Provider mavenSessionProvider;
+
+@Inject
+public ConsumerPomArtifactTransformer( Provider
mavenSessionProvider )
+{
+this.mavenSessionProvider = mavenSessionProvider;
+}
+
+@Override
+public Collection transformArtifact( Artifact artifact )
+{
+MavenSession mavenSession = mavenSessionProvider.get();
+TransformerContext context = (TransformerContext) mavenSession
+.getRepositorySession().getData().get( TransformerContext.KEY
);
+if ( "pom".equals( artifact.getExtension() ) && context != null )
+{
+// TODO: fix this, make it target rather
+Path buildOutputDirectory = Paths.get(
+
mavenSession.getCurrentProject().getBuild().getTestOutputDirectory() );
Review Comment:
is wip, nvm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski merged pull request #125: (doc) Fix spurious Javadoc @param tag
slawekjaranowski merged PR #125: URL: https://github.com/apache/maven-javadoc-plugin/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on pull request #51: [MPOM-295] Remove checkstyle from Maven site reports
slawekjaranowski commented on PR #51: URL: https://github.com/apache/maven-parent/pull/51#issuecomment-1093795228 My opinion is the same as @olamy ... we don't need store such information corresponding for release build time. Nowadays we have ci system for it. And when checkstyle find violation build will be break so report contains not important information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] slachiewicz commented on pull request #17: Bump mavenVersion from 3.1.0 to 3.8.5
slachiewicz commented on PR #17: URL: https://github.com/apache/maven-resources-plugin/pull/17#issuecomment-1093777624 Plugin use artifact version from Maven runtime, not declared here. So quickest way to address issue is to upgrade yours Maven installation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
