[GitHub] [maven-fluido-skin] olamy merged pull request #22: [MSKINS-177] Support Matomo (e.g. Apache Analytics) as macro

[GitBox]

olamy merged PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MSHADE-413) Maven share plugin enters endless loop

[Delany (Jira)]

[ 
https://issues.apache.org/jira/browse/MSHADE-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525446#comment-17525446
 ] 

Delany commented on MSHADE-413:
---

[https://github.com/hunterhacker/jdom/issues/199]

 

> Maven share plugin enters endless loop 
> ---
>
> Key: MSHADE-413
> URL: https://issues.apache.org/jira/browse/MSHADE-413
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.4
>Reporter: Robert Stupp
>Priority: Critical
>
> Two issues at play here:
> * {{ShadeMojo.createDependencyReducedPom()}} pulls in {{origDeps = 
> project.getDependencies()}} and later modifies these {{Dependency}} objects.
> * {{ShadeMojo.updateExcludesInDeps()}} enters it's own endless loop, 
> endlessly adding the exact same exclusions.
> This leads to a 
> [reproducible|https://github.com/projectnessie/nessie/issues/3678] endless 
> loop (see below).
> If the Shade plugin's not using the {{Dependency}} objects "owned by Maven 
> itself" (by setting {{promoteTransitiveDependencies}} to {{true}}), the build 
> passes fine.
> I think, _modifying_ the {{Dependency}} objects "owned by Maven itself" is 
> bad for two reasons (which IMO justify the increased priority of this 
> ticket): 
> # the reproducible endless loop
> # it breaks the correctness of the project build - at least plugins running 
> after the {{shade}} goal that use those dependencies.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MWAR-444) Update plugin (requires Maven 3.2.5+)

[Dennis Lundberg (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525439#comment-17525439
 ] 

Dennis Lundberg commented on MWAR-444:
--

I saw some other other recent plugin release that also used Maven 3.2.5, so 
I'll go ahead and merge the existing pull request. We can always update again 
at a later date.

> Update plugin (requires Maven 3.2.5+)
> -
>
> Key: MWAR-444
> URL: https://issues.apache.org/jira/browse/MWAR-444
> Project: Maven WAR Plugin
>  Issue Type: Task
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.3
>
>
> Update plugin
>  * require Maven 3.2.5+
>  * set maven bits to provided scope
>  * get rid of old baggage, update dependencies



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MWAR-448) packaging dependencies fails with "mvn install" but not "mvn package"

[Dennis Lundberg (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525438#comment-17525438
 ] 

Dennis Lundberg commented on MWAR-448:
--

In my opinion what you have described above is working as intended. If you add 
a dependency on some-parent and don't specify the type, Maven and its plugins 
will assume that some-parent produces a jar artifact. If some-parent does not 
produce a jar artifact (as is the case) then som plugins will fail if they 
cannot find that jar artifact.

So for things to work properly you must specify type=pom in some-parent, as 
well as any other place that uses some-parent as a dependency.

 

> packaging dependencies fails with "mvn install" but not "mvn package"
> -
>
> Key: MWAR-448
> URL: https://issues.apache.org/jira/browse/MWAR-448
> Project: Maven WAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.2
> Environment: maven 3.6.3 ( later versions have bugs which we can't 
> take in)
>Reporter: Kari J. Niemi
>Priority: Minor
> Fix For: waiting-for-feedback
>
>
> I think we discovered a minor odd difference with war-packaging between "mvn 
> package" or "mvn install". We would expect that only difference between the 
> two is that the latter also installs the produced stuff in the local maven 
> repository.
>  
> We are packaging a few jars to a war. We have a parent pom with some modules, 
> and that is defined as a dependency in the pom.xml that produces a 
> war-package. Like this:
> my-war-thingie:pom.xml (packaging:war)
>  * dependency: some-parent
> some-parent:pom.xml (packaging:pom)
>  * module1 (packaging:jar)
>  * module2 (packaging:jar)
> Earlier we had a different structure and everything was just fine: we did not 
> the have the child-modules but the parent-pom produced the jar. When we 
> changed the structure to the one described above: our CI was still OK, some 
> developers building OK as well -but some developers had failing maven builds 
> because of missing "some-parent.jar".
>  
> It was bit of devastating hunt, but finally we discovered that "mvn package" 
> was building OK, but "mvn install" looks for "some-parent.jar".
> We don't actually mind if the above scenario would fail in both cases, or if 
> it was successful - we would just expect that it works the same way for both. 
> If this is intended behaviour, it would be nice to have it documented.
> FWIW: in our case, we anyway wanted to define direct dependencies from the 
> war-packaging to the child-modules. So actually, we are OK wih our builds 
> already. But the difference caused so may doubts about our builds 
> reproducibility - and also, it seems like a bug - so I wanted to be good 
> citizen and report the problem.
> Edit: further note from our troubleshooting sessions: we don't have the 
> "type" for the dependency at all in my-war-thingie:pom.xml. Yesterday, we did 
> experiment setting the type as "pom" -and as a consequence,  both "mvn 
> package" and "mvn install" were successful. The default as we know, 
> should/would be "jar". Maybe the missing dependency type is for some odd 
> reason resolved differently for "maven package" and "maven install"?



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request, #80: Bump javax.servlet-api from 3.1.0 to 4.0.1

[GitBox]

dependabot[bot] opened a new pull request, #80:
URL: https://github.com/apache/maven-site-plugin/pull/80

   Bumps [javax.servlet-api](https://github.com/javaee/servlet-spec) from 3.1.0 
to 4.0.1.
   
   Commits
   
   https://github.com/javaee/servlet-spec/commit/5574e9b39d806120ac4d3539826a75b2cea0165a";>5574e9b
 [maven-release-plugin] prepare release 4.0.1
   https://github.com/javaee/servlet-spec/commit/6430adae88c7be1c4d750adee995c221bc39ebbc";>6430ada
 Update pom with latest copyright plugin version
   https://github.com/javaee/servlet-spec/commit/7265df0dca6923b5d925ec1f85850e2f58f65b9b";>7265df0
 Copyright changes. (https://github-redirect.dependabot.com/javaee/servlet-spec/issues/192";>#192)
   https://github.com/javaee/servlet-spec/commit/9a27193187705844371446cc15c3bfdcc96eee61";>9a27193
 [maven-release-plugin] prepare for next development iteration
   https://github.com/javaee/servlet-spec/commit/ef2740a68cefc1abd70860d26a6eb450bde8dd16";>ef2740a
 [maven-release-plugin] prepare release 4.0.0
   https://github.com/javaee/servlet-spec/commit/62e5c3981993ac5683111a02e3197006a5d6efa6";>62e5c39
 update the version to 4.0.0-SNAPSHOT
   https://github.com/javaee/servlet-spec/commit/10f86f36c02e6fec8cf55c180ba967959fe25703";>10f86f3
 Update Bundle-License MANIFEST.MF property
   https://github.com/javaee/servlet-spec/commit/779f3245062a4e1f04a428550612641383c30418";>779f324
 fix typo in skip test
   https://github.com/javaee/servlet-spec/commit/8ecb128589a8f2432cbe98448aaa6dfa7796c20d";>8ecb128
 Remove watermark, and add preposition where needed
   https://github.com/javaee/servlet-spec/commit/8c36bee945b8b2f713be32ef5d5856c03d26d755";>8c36bee
 Fix typo.  Insert preposition "to" after "corresponding" 
as necessary.
   Additional commits viewable in https://github.com/javaee/servlet-spec/compare/3.1.0...4.0.1";>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=javax.servlet:javax.servlet-api&package-manager=maven&previous-version=3.1.0&new-version=4.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-release] dependabot[bot] opened a new pull request, #109: Bump maven-parent from 34 to 35

[GitBox]

dependabot[bot] opened a new pull request, #109:
URL: https://github.com/apache/maven-release/pull/109

   Bumps [maven-parent](https://github.com/apache/maven-parent) from 34 to 35.
   
   Commits
   
   See full diff in https://github.com/apache/maven-parent/commits";>compare view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven:maven-parent&package-manager=maven&previous-version=34&new-version=35)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-archiver] Pruthvi-rsj opened a new pull request, #20: Update versions of - commons-compress and commons-io

[GitBox]

Pruthvi-rsj opened a new pull request, #20:
URL: https://github.com/apache/maven-archiver/pull/20

   Upgrading - commons-compress and commons-io to non vulnerable versions.
   Also these are minor version changes so they should be backward compatible.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MSHARED) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MSHARED-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-reporting-api] dependabot[bot] opened a new pull request, #8: Bump maven-javadoc-plugin from 3.3.2 to 3.4.0

[GitBox]

dependabot[bot] opened a new pull request, #8:
URL: https://github.com/apache/maven-reporting-api/pull/8

   Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) 
from 3.3.2 to 3.4.0.
   
   Commits
   
   https://github.com/apache/maven-javadoc-plugin/commit/40cc602f84dbb0689020b55b24970cdd7147722c";>40cc602
 [maven-release-plugin] prepare release maven-javadoc-plugin-3.4.0
   https://github.com/apache/maven-javadoc-plugin/commit/0c6b32fb5ec9c31b4e38d9f32616ff51102623da";>0c6b32f
 [MJAVADOC-714] Upgrade to Maven 3.2.5
   https://github.com/apache/maven-javadoc-plugin/commit/506cb74e6abc4b108121b0c586a15b75dd5ccc39";>506cb74
 [MJAVADOC-696] Invalid anchors in Javadoc and plugin mojo
   https://github.com/apache/maven-javadoc-plugin/commit/47d03d3a08cc58a93fa384f4661d79c350842b82";>47d03d3
 [MJAVADOC-712] Remove remains of org.codehaus.doxia.sink.Sink
   https://github.com/apache/maven-javadoc-plugin/commit/5fae3b656e131fa233982eebf0944b5253fc845e";>5fae3b6
 [MJAVADOC-711] Upgrade plugins in ITs
   https://github.com/apache/maven-javadoc-plugin/commit/03ca84372ab689c91dd0d5b63cc2ee12ee3c466b";>03ca843
 Bump maven-archiver from 3.5.1 to 3.5.2
   https://github.com/apache/maven-javadoc-plugin/commit/5dcfa6e70795d0b5cf5414a848e7e0aeb5541413";>5dcfa6e
 Bump plexus-archiver from 4.2.6 to 4.2.7
   https://github.com/apache/maven-javadoc-plugin/commit/ca00601609903a0e88a067b2aa3d49e88191937a";>ca00601
 Bump junit in /src/it/projects/MJAVADOC-498_modulepath
   https://github.com/apache/maven-javadoc-plugin/commit/2583554135dc04db58a435ebcbd2cd19f0d2563a";>2583554
 Bump commons-io from 2.2 to 2.7 in /src/it/projects/MJAVADOC-437/module2
   https://github.com/apache/maven-javadoc-plugin/commit/9dd7bddb3db6d0d230092d7fbbd4188a98a3a75e";>9dd7bdd
 use shared gh action/release-drafter (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/128";>#128)
   Additional commits viewable in https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.3.2...maven-javadoc-plugin-3.4.0";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.plugins:maven-javadoc-plugin&package-manager=maven&previous-version=3.3.2&new-version=3.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #114: Bump maven-site-plugin from 3.10.0 to 3.12.0

[GitBox]

dependabot[bot] opened a new pull request, #114:
URL: https://github.com/apache/maven-invoker-plugin/pull/114

   Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 
3.10.0 to 3.12.0.
   
   Release notes
   Sourced from https://github.com/apache/maven-site-plugin/releases";>maven-site-plugin's 
releases.
   
   3.11.0
   What's Changed
   
   [MSITE-812] Missing '/' in log when deploying documentation by 
site:stage by https://github.com/aajisaka";>@​aajisaka 
in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/1";>apache/maven-site-plugin#1
   [MSITE-828] Upgrade jetty to recent version. Update to java 1.8 
(required for jetty) by https://github.com/oflebbe";>@​oflebbe in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/3";>apache/maven-site-plugin#3
   MSITE-848 Update sitedescriptor.apt by https://github.com/ctubbsii";>@​ctubbsii in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/13";>apache/maven-site-plugin#13
   MSITE-847: Corrected link to prerequisite maven version. by https://github.com/KathrynN";>@​KathrynN in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/14";>apache/maven-site-plugin#14
   remove info about old version by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/19";>apache/maven-site-plugin#19
   update test dependencies by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/17";>apache/maven-site-plugin#17
   Only reference current version: created on website by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/18";>apache/maven-site-plugin#18
   [MNGSITE-393] assume Maven 3 as default by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/20";>apache/maven-site-plugin#20
   add .checkstyle to .gitignore by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/22";>apache/maven-site-plugin#22
   remove unused code by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/23";>apache/maven-site-plugin#23
   [MSITE-859] update apache commons lang and IO by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/25";>apache/maven-site-plugin#25
   [MSITE-757] remove Maven 2 support by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/24";>apache/maven-site-plugin#24
   [MSITE-757] drop Maven 2 mention by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/26";>apache/maven-site-plugin#26
   docs: use https by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/28";>apache/maven-site-plugin#28
   [MSITE-861] remove obsolete dependency by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/29";>apache/maven-site-plugin#29
   [MNGSITE-393] remove Maven 1 and 2 info by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/30";>apache/maven-site-plugin#30
   Fix script injection example in docs by https://github.com/strkkk";>@​strkkk in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/35";>apache/maven-site-plugin#35
   trivial change by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/38";>apache/maven-site-plugin#38
   [MSITE-871] Upgrade Maven Javadoc Plugin in integration tests by https://github.com/mthmulders";>@​mthmulders in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/39";>apache/maven-site-plugin#39
   Bump plexus-archiver from 4.2.4 to 4.2.5 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/47";>apache/maven-site-plugin#47
   Bump maven-shared-utils from 3.3.3 to 3.3.4 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/50";>apache/maven-site-plugin#50
   Bump slf4jVersion from 1.7.29 to 1.7.31 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/54";>apache/maven-site-plugin#54
   Bump slf4jVersion from 1.7.31 to 1.7.32 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/58";>apache/maven-site-plugin#58
   Add PR template by https://github.com/slawekjaranowski";>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/63";>apache/maven-site-plugin#63
   [MSITE-877] Shared GitHub Actions by https://gith

[GitHub] [maven-dependency-analyzer] dependabot[bot] commented on pull request #49: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2

[GitBox]

dependabot[bot] commented on PR #49:
URL: 
https://github.com/apache/maven-dependency-analyzer/pull/49#issuecomment-1104692127

   Superseded by #59.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-analyzer] dependabot[bot] opened a new pull request, #59: Bump maven-javadoc-plugin from 3.3.1 to 3.4.0

[GitBox]

dependabot[bot] opened a new pull request, #59:
URL: https://github.com/apache/maven-dependency-analyzer/pull/59

   Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) 
from 3.3.1 to 3.4.0.
   
   Release notes
   Sourced from https://github.com/apache/maven-javadoc-plugin/releases";>maven-javadoc-plugin's
 releases.
   
   3.3.2
   What's Changed
   
   [MJAVADOC-530] - Clean up additionalparam documentation by https://github.com/marschall";>@​marschall in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/6";>apache/maven-javadoc-plugin#6
   [MJAVADOC-538] Filter out 'Picked up' by https://github.com/risdenk";>@​risdenk in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/11";>apache/maven-javadoc-plugin#11
   [MJAVADOC-546] Allow to generate report in Spanish locale by https://github.com/belingueres";>@​belingueres in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/12";>apache/maven-javadoc-plugin#12
   [MJAVADOC-537] Explicitly the batchMode to true by https://github.com/joshiste";>@​joshiste in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/7";>apache/maven-javadoc-plugin#7
   fix mailing list url in README by https://github.com/rgdoliveira";>@​rgdoliveira in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/13";>apache/maven-javadoc-plugin#13
   [MJAVADOC-544] - Changed behaviour of Javadoc for temporary files 
encoding (options, argfile, ...) by https://github.com/michael-st";>@​michael-st in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/10";>apache/maven-javadoc-plugin#10
   [MJAVADOC-444] add aggregate-no-fork and aggregate-test-no-fork for 
non-forking versions of aggregate goals. by https://github.com/busbey";>@​busbey in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/2";>apache/maven-javadoc-plugin#2
   Avoid converting separator characters into newline. by https://github.com/cowwoc";>@​cowwoc in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/19";>apache/maven-javadoc-plugin#19
   [MJAVADOC-577] Fixed typos in User Guide. by https://github.com/glqdlt";>@​glqdlt in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/20";>apache/maven-javadoc-plugin#20
   Fix typo in additionalDependencies documentation by https://github.com/britter";>@​britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/23";>apache/maven-javadoc-plugin#23
   Add missing @since tags to sourceFile[Includes|Excludes] by 
https://github.com/britter";>@​britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/24";>apache/maven-javadoc-plugin#24
   Added example of --add-modules to aggregate FAQ. by https://github.com/cowwoc";>@​cowwoc in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/18";>apache/maven-javadoc-plugin#18
   Remove space typo in  markdown by https://github.com/nrbw";>@​nrbw in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/29";>apache/maven-javadoc-plugin#29
   [MJAVADOC-620] Do not ignore JARs w/o module info when building 
classpath by https://github.com/fwienber";>@​fwienber 
in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/35";>apache/maven-javadoc-plugin#35
   [MJAVADOC-626] Add a stale javadoc detection mechanism by https://github.com/gnodet";>@​gnodet in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/33";>apache/maven-javadoc-plugin#33
   [MJAVADOC-613] exclude skipped modules from javadoc aggregate by https://github.com/olamy";>@​olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/36";>apache/maven-javadoc-plugin#36
   [MJAVADOC-636] exclude some modules from aggregated javadoc by https://github.com/olamy";>@​olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/37";>apache/maven-javadoc-plugin#37
   [MJAVADOC-639] include requires static from external dependencies for 
all modules by https://github.com/olamy";>@​olamy in 
https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/38";>apache/maven-javadoc-plugin#38
   [MJAVADOC-638] upgrade Doxia Sitetools to 1.9.2 to remove dependency on 
Struts by https://github.com/olamy";>@​olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/39";>apache/maven-javadoc-plugin#39
   MJAVADOC-610 by https://github.com/olamy";>@​olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/40";>apache/maven-javadoc-plugin#40
   [MJAVADOC-644] Properly close DirectoryStream by https://github.com/britter";>@​britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/41";>apache/maven-javadoc-plugin#41
   update qdox by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/42";>apache/maven-javadoc

[GitHub] [maven-dependency-analyzer] dependabot[bot] closed pull request #49: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2

[GitBox]

dependabot[bot] closed pull request #49: Bump maven-javadoc-plugin from 3.3.1 
to 3.3.2
URL: https://github.com/apache/maven-dependency-analyzer/pull/49


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #78: Bump maven-javadoc-plugin from 3.3.2 to 3.4.0

[GitBox]

dependabot[bot] opened a new pull request, #78:
URL: https://github.com/apache/maven-apache-parent/pull/78

   Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) 
from 3.3.2 to 3.4.0.
   
   Commits
   
   https://github.com/apache/maven-javadoc-plugin/commit/40cc602f84dbb0689020b55b24970cdd7147722c";>40cc602
 [maven-release-plugin] prepare release maven-javadoc-plugin-3.4.0
   https://github.com/apache/maven-javadoc-plugin/commit/0c6b32fb5ec9c31b4e38d9f32616ff51102623da";>0c6b32f
 [MJAVADOC-714] Upgrade to Maven 3.2.5
   https://github.com/apache/maven-javadoc-plugin/commit/506cb74e6abc4b108121b0c586a15b75dd5ccc39";>506cb74
 [MJAVADOC-696] Invalid anchors in Javadoc and plugin mojo
   https://github.com/apache/maven-javadoc-plugin/commit/47d03d3a08cc58a93fa384f4661d79c350842b82";>47d03d3
 [MJAVADOC-712] Remove remains of org.codehaus.doxia.sink.Sink
   https://github.com/apache/maven-javadoc-plugin/commit/5fae3b656e131fa233982eebf0944b5253fc845e";>5fae3b6
 [MJAVADOC-711] Upgrade plugins in ITs
   https://github.com/apache/maven-javadoc-plugin/commit/03ca84372ab689c91dd0d5b63cc2ee12ee3c466b";>03ca843
 Bump maven-archiver from 3.5.1 to 3.5.2
   https://github.com/apache/maven-javadoc-plugin/commit/5dcfa6e70795d0b5cf5414a848e7e0aeb5541413";>5dcfa6e
 Bump plexus-archiver from 4.2.6 to 4.2.7
   https://github.com/apache/maven-javadoc-plugin/commit/ca00601609903a0e88a067b2aa3d49e88191937a";>ca00601
 Bump junit in /src/it/projects/MJAVADOC-498_modulepath
   https://github.com/apache/maven-javadoc-plugin/commit/2583554135dc04db58a435ebcbd2cd19f0d2563a";>2583554
 Bump commons-io from 2.2 to 2.7 in /src/it/projects/MJAVADOC-437/module2
   https://github.com/apache/maven-javadoc-plugin/commit/9dd7bddb3db6d0d230092d7fbbd4188a98a3a75e";>9dd7bdd
 use shared gh action/release-drafter (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/128";>#128)
   Additional commits viewable in https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.3.2...maven-javadoc-plugin-3.4.0";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.plugins:maven-javadoc-plugin&package-manager=maven&previous-version=3.3.2&new-version=3.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-help-plugin] dependabot[bot] closed pull request #52: Bump maven-site-plugin from 3.10.0 to 3.11.0

[GitBox]

dependabot[bot] closed pull request #52: Bump maven-site-plugin from 3.10.0 to 
3.11.0
URL: https://github.com/apache/maven-help-plugin/pull/52


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #55: Bump maven-site-plugin from 3.10.0 to 3.12.0

[GitBox]

dependabot[bot] opened a new pull request, #55:
URL: https://github.com/apache/maven-help-plugin/pull/55

   Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 
3.10.0 to 3.12.0.
   
   Release notes
   Sourced from https://github.com/apache/maven-site-plugin/releases";>maven-site-plugin's 
releases.
   
   3.11.0
   What's Changed
   
   [MSITE-812] Missing '/' in log when deploying documentation by 
site:stage by https://github.com/aajisaka";>@​aajisaka 
in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/1";>apache/maven-site-plugin#1
   [MSITE-828] Upgrade jetty to recent version. Update to java 1.8 
(required for jetty) by https://github.com/oflebbe";>@​oflebbe in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/3";>apache/maven-site-plugin#3
   MSITE-848 Update sitedescriptor.apt by https://github.com/ctubbsii";>@​ctubbsii in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/13";>apache/maven-site-plugin#13
   MSITE-847: Corrected link to prerequisite maven version. by https://github.com/KathrynN";>@​KathrynN in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/14";>apache/maven-site-plugin#14
   remove info about old version by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/19";>apache/maven-site-plugin#19
   update test dependencies by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/17";>apache/maven-site-plugin#17
   Only reference current version: created on website by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/18";>apache/maven-site-plugin#18
   [MNGSITE-393] assume Maven 3 as default by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/20";>apache/maven-site-plugin#20
   add .checkstyle to .gitignore by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/22";>apache/maven-site-plugin#22
   remove unused code by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/23";>apache/maven-site-plugin#23
   [MSITE-859] update apache commons lang and IO by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/25";>apache/maven-site-plugin#25
   [MSITE-757] remove Maven 2 support by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/24";>apache/maven-site-plugin#24
   [MSITE-757] drop Maven 2 mention by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/26";>apache/maven-site-plugin#26
   docs: use https by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/28";>apache/maven-site-plugin#28
   [MSITE-861] remove obsolete dependency by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/29";>apache/maven-site-plugin#29
   [MNGSITE-393] remove Maven 1 and 2 info by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/30";>apache/maven-site-plugin#30
   Fix script injection example in docs by https://github.com/strkkk";>@​strkkk in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/35";>apache/maven-site-plugin#35
   trivial change by https://github.com/elharo";>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/38";>apache/maven-site-plugin#38
   [MSITE-871] Upgrade Maven Javadoc Plugin in integration tests by https://github.com/mthmulders";>@​mthmulders in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/39";>apache/maven-site-plugin#39
   Bump plexus-archiver from 4.2.4 to 4.2.5 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/47";>apache/maven-site-plugin#47
   Bump maven-shared-utils from 3.3.3 to 3.3.4 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/50";>apache/maven-site-plugin#50
   Bump slf4jVersion from 1.7.29 to 1.7.31 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/54";>apache/maven-site-plugin#54
   Bump slf4jVersion from 1.7.31 to 1.7.32 by https://github.com/dependabot";>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/58";>apache/maven-site-plugin#58
   Add PR template by https://github.com/slawekjaranowski";>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/63";>apache/maven-site-plugin#63
   [MSITE-877] Shared GitHub Actions by https://github.co

[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #52: Bump maven-site-plugin from 3.10.0 to 3.11.0

[GitBox]

dependabot[bot] commented on PR #52:
URL: https://github.com/apache/maven-help-plugin/pull/52#issuecomment-1104690718

   Superseded by #55.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

Tibor17 commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104583550

   > > > > @dsubelman `argLine.replaceAll("\\s+", " ");` is nice. The code we 
have now still cannot trust the values which have a new line in system 
properties, e.g. `-DmyProp=my \n prop` but we cannot do anyting about it 
because we do not have smart mechanism to understand the structure of 
`argLine`. Till now nobody had any objections. The solution that we have is a 
kind of "too technical" but maybe this would stay untill the people would shout 
too much.
   > > > 
   > > > 
   > > > When you say '_maybe this would stay until the people would shout too 
much_', do you mean to merge this pull request or not?
   > > 
   > > 
   > > yes, of course, I would be glad to do that. I only want to open a 
discussion and tell you what I am thinking about and I want your opinions to be 
heard.
   > 
   > Understood, thanks for the clarification.
   > 
   > Why would you need to use `\n` in system properties? (like in your example 
`-DmyProp=my \n prop`) In those cases, if you replace the `\n` with whitespace, 
change the behavior? In other words, you may need not remove `\n` in those 
cases?
   
   @dsubelman 
   I don't need `\n` :-) but the users sometimes have crazy requirements. I 
just wanted to be prepared with some thoughts, nothing else. ok, we can finish 
this PR.
   
   @mthmulders 
   WDYT about using `argLine.replaceAll("\\s+", " ");` instead of what we have 
today?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support Matomo (e.g. Apache Analytics) as macro

[GitBox]

olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1104578871


   > Please remove it, it has no use these days.
   
   `CDATA` you mean? because I don't understand the link with the screenshot 
attached


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support Matomo (e.g. Apache Analytics) as macro

[GitBox]

olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1104569223

   > The CDATA block is broken: 
![grafik](https://user-images.githubusercontent.com/573017/164223219-de475bfa-4be3-44a1-bbc2-6e225ff9fb2b.png)
 
![grafik](https://user-images.githubusercontent.com/573017/164223342-7196c2a7-c0af-4e95-b141-c2895cc8bc4c.png)
   > 
   > Please remove it, it has no use these days.
   
   [interesting 
](https://github.com/apache/maven-parent/blob/d12d10719083fb4963204e6e2b49d99684df3c0b/src/site/site.xml#L67)
 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] dsubelman commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

dsubelman commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104543928

   > > > @dsubelman `argLine.replaceAll("\\s+", " ");` is nice. The code we 
have now still cannot trust the values which have a new line in system 
properties, e.g. `-DmyProp=my \n prop` but we cannot do anyting about it 
because we do not have smart mechanism to understand the structure of 
`argLine`. Till now nobody had any objections. The solution that we have is a 
kind of "too technical" but maybe this would stay untill the people would shout 
too much.
   > > 
   > > 
   > > When you say '_maybe this would stay until the people would shout too 
much_', do you mean to merge this pull request or not?
   > 
   > yes, of course, I would be glad to do that. I only want to open a 
discussion and tell you what I am thinking about and I want your opinions to be 
heard.
   
   Understood, thanks for the clarification. 
   
   Why would you use `\n` in system properties? In those cases, if you replace 
the `\n` with whitespace, change the behavior? In other words, you may need not 
remove `\n` in those cases?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

Tibor17 commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104465792

   > > @dsubelman `argLine.replaceAll("\\s+", " ");` is nice. The code we have 
now still cannot trust the values which have a new line in system properties, 
e.g. `-DmyProp=my \n prop` but we cannot do anyting about it because we do not 
have smart mechanism to understand the structure of `argLine`. Till now nobody 
had any objections. The solution that we have is a kind of "too technical" but 
maybe this would stay untill the people would shout too much.
   > 
   > When you say '_maybe this would stay until the people would shout too 
much_', do you mean to merge this pull request or not?
   
   yes, of course, I would be glad to do that.
   I only want to open a discussion and tell you what I am thinking about and I 
want your opinions to be heard.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] dsubelman commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

dsubelman commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104461256

   > @dsubelman `argLine.replaceAll("\\s+", " ");` is nice. The code we have 
now still cannot trust the values which have a new line in system properties, 
e.g. `-DmyProp=my \n prop` but we cannot do anyting about it because we do not 
have smart mechanism to understand the structure of `argLine`. Till now nobody 
had any objections. The solution that we have is a kind of "too technical" but 
maybe this would stay untill the people would shout too much.
   
   When you say '_maybe this would stay until the people would shout too 
much_', do you mean to merge this pull request or not?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #505: [SUREFIRE-2055] Always show random seed

[GitBox]

slawekjaranowski commented on PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#issuecomment-1104454929

   @Tibor17 any more remarks ... I'm going to merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (SUREFIRE-2055) Always show random seed

[Slawomir Jaranowski (Jira)]

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned SUREFIRE-2055:
-

Assignee: Slawomir Jaranowski

> Always show random seed
> ---
>
> Key: SUREFIRE-2055
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2055
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Delany
>Assignee: Slawomir Jaranowski
>Priority: Minor
>
> When I run tests in random order I get the message "Tests will run in random 
> order. To reproduce ordering use flag 
> -Dsurefire.runOrder.random.seed=55174043965113"
> When I provide the seed, I don't get the message, so there's no record of the 
> seed in the log.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-surefire] Tibor17 commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

Tibor17 commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104449216

   @dsubelman `argLine.replaceAll("\\s+", " ");` is nice.
   The code we have now still cannot trust the values which have a new line in 
system properties, e.g. `-DmyProp=my \n prop` but we cannot do anyting about it 
because we do not have smart mechanism to understand the structure of 
`argLine`. Till now nobody had any objections. The solution that we have is a 
kind of "too technical" but maybe this would stay untill the people would shout 
too much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] dsubelman commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

dsubelman commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104445284

   > @dsubelman Why you use quotation marks `' '`? These are Linux/Unix 
specific? We cannot use it if it is platform specific. We have the library 
`maven-shared-utils` with CLI utility which applies platform specific escaping 
characters. So, it is enough if we keep using one space character as before.
   
   It was to show the difference between the two approaches. Otherwise, you 
wouldn't be able to see all the difference between the outputs. Instead, I 
would use my initial proposal:
   
   argLine.replaceAll("\\s+", " ");


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

Tibor17 commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104439793

   @mthmulders 
   
   > > @mthmulders I have one more question. The developers would not be able 
to see the TAB because it is a white space. If the new guy would refactor it 
again, then this IT would not cover the purpose that it has now. I know it is a 
question of how the xml parser interprets the escaping characters in Maven but 
I would like to ask you for testing with escaping characters `	` on Maven 
3.2.x and 3.8.x. WDYT?
   > 
   > That's why I added XML comments saying those lines must be tab-indented. 
I've just tested locally: an XML file with `	` also breaks before the 
change in `DefaultForkConfiguration` (tested with Maven 4 SNAPSHOT, Maven 3.8.5 
and Maven 3.2.5). So it seems to work equally fine for the test. Just tell me 
which one you prefer @Tibor17: tab characters, XML entities, or both.
   
   As you said, the TAB as a white space works equaly with 
`-Dfoo.property="foo foo/foo/bar/1.0" 	 -Dbar.property="bar 
bar/foo/bar/2.0"`. AFAIK the developers they press CTRL+ALT+L in 
IntelliJ IDEA, sometimes they are blind to see all the comments and therefore 
nothing stops them to refactor the the source code. If they do it, then the 
character `	` would stay forever, so it would be the strongest guarantee 
that the purpose is still there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

Tibor17 commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104416689

   @dsubelman 
   Why you use quotation marks `' '`?
   These are Linux/Unix specific?
   We cannot use it if it is platform specific. We have the library 
`maven-shared-utils` with CLI utility which applies platform specific escaping 
characters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MJAVADOC-707) Plugin won't work if Automatic-Module-Name is used

[Christopher Tubbs (Jira)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525257#comment-17525257
 ] 

Christopher Tubbs commented on MJAVADOC-707:


Confirmed still a bug in the just released 3.4.0

> Plugin won't work if Automatic-Module-Name is used
> --
>
> Key: MJAVADOC-707
> URL: https://issues.apache.org/jira/browse/MJAVADOC-707
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.1, 3.3.2, 3.4.0
>Reporter: Christopher Tubbs
>Priority: Critical
>
> Using Automatic-Module-Name in a manifest (an intermediate step to help 
> transition to using modules) prevents this plugin from adding the necessary 
> dependencies to the class path, so it can build javadocs.
> maven-compiler-plugin seems to work fine, as does surefire and all the others 
> when Automatic-Module-Name entries appear in a project's jar manifests. 
> However, this plugin, as of 3.3.1, still does not work correctly with these.
> Instead of using the traditional class path, this plugin seems to force 
> treating the project as a module, even though it does not have any 
> module-info.java files, and most of its dependencies have not transitioned to 
> using modules.
> Here's a pull request that demonstrates adding the Automatic-Module-Name to 
> the manifest for a multi-module (Maven module) project, that fails on the 
> javadoc plugin:
> https://github.com/apache/accumulo/pull/2498 ; both javadoc:aggregate and 
> javadoc:jar are known to fail. I did not test with any other mojos.
> Not supporting this feature holds all projects back from being able to 
> transition to modules over time.
> http://branchandbound.net/blog/java/2017/12/automatic-module-name/
> https://docs.oracle.com/javase/9/docs/api/java/lang/module/ModuleFinder.html#automatic-modules



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MJAVADOC-707) Plugin won't work if Automatic-Module-Name is used

[Christopher Tubbs (Jira)]

 [ 
https://issues.apache.org/jira/browse/MJAVADOC-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher Tubbs updated MJAVADOC-707:
---
Affects Version/s: 3.4.0

> Plugin won't work if Automatic-Module-Name is used
> --
>
> Key: MJAVADOC-707
> URL: https://issues.apache.org/jira/browse/MJAVADOC-707
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.1, 3.3.2, 3.4.0
>Reporter: Christopher Tubbs
>Priority: Critical
>
> Using Automatic-Module-Name in a manifest (an intermediate step to help 
> transition to using modules) prevents this plugin from adding the necessary 
> dependencies to the class path, so it can build javadocs.
> maven-compiler-plugin seems to work fine, as does surefire and all the others 
> when Automatic-Module-Name entries appear in a project's jar manifests. 
> However, this plugin, as of 3.3.1, still does not work correctly with these.
> Instead of using the traditional class path, this plugin seems to force 
> treating the project as a module, even though it does not have any 
> module-info.java files, and most of its dependencies have not transitioned to 
> using modules.
> Here's a pull request that demonstrates adding the Automatic-Module-Name to 
> the manifest for a multi-module (Maven module) project, that fails on the 
> javadoc plugin:
> https://github.com/apache/accumulo/pull/2498 ; both javadoc:aggregate and 
> javadoc:jar are known to fail. I did not test with any other mojos.
> Not supporting this feature holds all projects back from being able to 
> transition to modules over time.
> http://branchandbound.net/blog/java/2017/12/automatic-module-name/
> https://docs.oracle.com/javase/9/docs/api/java/lang/module/ModuleFinder.html#automatic-modules



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MSHARED-1065) Upgrade plugins and components in UTs and ITs

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSHARED-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-1065:

Description: 
* Maven Javadoc Plugin to 3.4.0
* Maven Reporting Impl to 4.0.0-M1
* Maven Site Plugin 3.12.0
* Maven Project Info Reports Plugin 3.2.2

  was:
* Maven Javadoc Plugin to 3.4.0
* Maven Reporting Impl to 4.0.0-M1
* Maven Site Plugin 3.11.0
* Maven Project Info Reports Plugin 3.2.2


> Upgrade plugins and components in UTs and ITs
> -
>
> Key: MSHARED-1065
> URL: https://issues.apache.org/jira/browse/MSHARED-1065
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-exec
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-exec-2.0.0-M1
>
>
> * Maven Javadoc Plugin to 3.4.0
> * Maven Reporting Impl to 4.0.0-M1
> * Maven Site Plugin 3.12.0
> * Maven Project Info Reports Plugin 3.2.2



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MSHARED-1059) Upgrade Maven Reporting API to 4.0.0-M1

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MSHARED-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525177#comment-17525177
 ] 

Hudson commented on MSHARED-1059:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-impl » master 
#12

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-impl/job/master/12/

> Upgrade Maven Reporting API to 4.0.0-M1
> ---
>
> Key: MSHARED-1059
> URL: https://issues.apache.org/jira/browse/MSHARED-1059
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MSHARED-1055) Upgrade to Java 8

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MSHARED-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525175#comment-17525175
 ] 

Hudson commented on MSHARED-1055:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-impl » master 
#12

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-impl/job/master/12/

> Upgrade to Java 8
> -
>
> Key: MSHARED-1055
> URL: https://issues.apache.org/jira/browse/MSHARED-1055
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MSHARED-1057) Upgrade to Doxia/Doxia Sitetools to 2.0.0-M2

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MSHARED-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525176#comment-17525176
 ] 

Hudson commented on MSHARED-1057:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-impl » master 
#12

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-impl/job/master/12/

> Upgrade to Doxia/Doxia Sitetools to 2.0.0-M2
> 
>
> Key: MSHARED-1057
> URL: https://issues.apache.org/jira/browse/MSHARED-1057
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-reporting-impl] asfgit merged pull request #6: Doxia 2.0.0

[GitBox]

asfgit merged PR #6:
URL: https://github.com/apache/maven-reporting-impl/pull/6


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (MSHARED-1059) Upgrade Maven Reporting API to 4.0.0-M1

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MSHARED-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525166#comment-17525166
 ] 

Michael Osipov edited comment on MSHARED-1059 at 4/20/22 6:15 PM:
--

Fixed with  
[7965ebd3aa1de72ba28362e8cfd90495d8c5e2cf|https://gitbox.apache.org/repos/asf?p=maven-reporting-impl.git;a=commit;h=7965ebd3aa1de72ba28362e8cfd90495d8c5e2cf].


was (Author: michael-o):
7965ebd3aa1de72ba28362e8cfd90495d8c5e2cf

> Upgrade Maven Reporting API to 4.0.0-M1
> ---
>
> Key: MSHARED-1059
> URL: https://issues.apache.org/jira/browse/MSHARED-1059
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Closed] (MSHARED-1059) Upgrade Maven Reporting API to 4.0.0-M1

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSHARED-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MSHARED-1059.
---
Resolution: Fixed

7965ebd3aa1de72ba28362e8cfd90495d8c5e2cf

> Upgrade Maven Reporting API to 4.0.0-M1
> ---
>
> Key: MSHARED-1059
> URL: https://issues.apache.org/jira/browse/MSHARED-1059
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Closed] (MSHARED-1057) Upgrade to Doxia/Doxia Sitetools to 2.0.0-M2

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSHARED-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MSHARED-1057.
---
Resolution: Fixed

Fixed with  
[38e8f9850912f846d5efe747fcddbc728873e76a|https://gitbox.apache.org/repos/asf?p=maven-reporting-impl.git;a=commit;h=38e8f9850912f846d5efe747fcddbc728873e76a].

> Upgrade to Doxia/Doxia Sitetools to 2.0.0-M2
> 
>
> Key: MSHARED-1057
> URL: https://issues.apache.org/jira/browse/MSHARED-1057
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Closed] (MSHARED-1055) Upgrade to Java 8

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSHARED-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MSHARED-1055.
---
Resolution: Fixed

Fixed with  
[5efe4723c32aa674ff327c467f6bea776b88be83|https://gitbox.apache.org/repos/asf?p=maven-reporting-impl.git;a=commit;h=5efe4723c32aa674ff327c467f6bea776b88be83].

> Upgrade to Java 8
> -
>
> Key: MSHARED-1055
> URL: https://issues.apache.org/jira/browse/MSHARED-1055
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option

[GitBox]

sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r854356835


##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +36,77 @@
  *
  * @since 3.0.0-M6
  */
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
 {
+/**
+ * Convert and apply the value of the [threadcount] option.
+ * 
+ * @param suite TestNG {@link XmlSuite} object
+ * @param options Surefire plugin configuration options
+ * @throws TestSetFailedException if unable to convert specified 
[threadcount] setting
+ */
 @Override
-public void configure( XmlSuite suite, Map options )
+protected void configureThreadCount( XmlSuite suite, Map 
options )
 throws TestSetFailedException
 {
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt( 
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+String threadCount = options.get( THREADCOUNT_PROP );
+// if [threadcount] spec'd
+if ( threadCount != null )
 {
-if ( !"methods".equalsIgnoreCase( parallel ) && 
!"classes".equalsIgnoreCase( parallel ) )
+try
 {
-throw new TestSetFailedException( "Unsupported TestNG parallel 
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
+// convert and apply [threadcount] setting
+suite.setThreadCount( Integer.parseInt( threadCount ) );

Review Comment:
   Override of [threadCount] implementation removed. New issue opened here: 
https://issues.apache.org/jira/browse/SUREFIRE-2075



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option

[GitBox]

sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r854356835


##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +36,77 @@
  *
  * @since 3.0.0-M6
  */
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
 {
+/**
+ * Convert and apply the value of the [threadcount] option.
+ * 
+ * @param suite TestNG {@link XmlSuite} object
+ * @param options Surefire plugin configuration options
+ * @throws TestSetFailedException if unable to convert specified 
[threadcount] setting
+ */
 @Override
-public void configure( XmlSuite suite, Map options )
+protected void configureThreadCount( XmlSuite suite, Map 
options )
 throws TestSetFailedException
 {
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt( 
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+String threadCount = options.get( THREADCOUNT_PROP );
+// if [threadcount] spec'd
+if ( threadCount != null )
 {
-if ( !"methods".equalsIgnoreCase( parallel ) && 
!"classes".equalsIgnoreCase( parallel ) )
+try
 {
-throw new TestSetFailedException( "Unsupported TestNG parallel 
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
+// convert and apply [threadcount] setting
+suite.setThreadCount( Integer.parseInt( threadCount ) );

Review Comment:
   New issue opened here: https://issues.apache.org/jira/browse/SUREFIRE-2075



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SUREFIRE-2075) Implementation of TestNG "threadCount" option improperly overrides default value

[Scott Babcock (Jira)]

Scott Babcock created SUREFIRE-2075:
---

 Summary: Implementation of TestNG "threadCount" option improperly 
overrides default value
 Key: SUREFIRE-2075
 URL: https://issues.apache.org/jira/browse/SUREFIRE-2075
 Project: Maven Surefire
  Issue Type: Bug
  Components: TestNG support
Reporter: Scott Babcock


The implementation in *TestNGMapConfigurator* for the [threadCount] option 
injects a fixed default value of 1 if the plugin configuration does not 
explicitly specify this setting. This is unnecessary and undesirable, because 
TestNG provides a default value of 5 for [threadCount]. Also, this injected 
default value of 1 contradicts the Surefire 
[documentation|https://maven.apache.org/surefire/maven-surefire-plugin/examples/testng.html#Running_Tests_in_Parallel],
 and it results in sequential execution if any of the [parallel] modes are 
specified but [threadCount] is unspecified.

The solution is to allow TestNG to provide the default [threadCount] value if 
the configuration omits this setting.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option

[GitBox]

sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r854334421


##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +36,77 @@
  *
  * @since 3.0.0-M6
  */
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
 {
+/**
+ * Convert and apply the value of the [threadcount] option.
+ * 
+ * @param suite TestNG {@link XmlSuite} object
+ * @param options Surefire plugin configuration options
+ * @throws TestSetFailedException if unable to convert specified 
[threadcount] setting
+ */
 @Override
-public void configure( XmlSuite suite, Map options )
+protected void configureThreadCount( XmlSuite suite, Map 
options )
 throws TestSetFailedException
 {
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt( 
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+String threadCount = options.get( THREADCOUNT_PROP );
+// if [threadcount] spec'd
+if ( threadCount != null )
 {
-if ( !"methods".equalsIgnoreCase( parallel ) && 
!"classes".equalsIgnoreCase( parallel ) )
+try
 {
-throw new TestSetFailedException( "Unsupported TestNG parallel 
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
+// convert and apply [threadcount] setting
+suite.setThreadCount( Integer.parseInt( threadCount ) );

Review Comment:
   @Tibor17 As you indicated, TestNG provides a default value of 5. As I 
pointed out, the Surefire documentation also specifies 5 as the default value. 
There is no potential for the thread count to have any value other than 5 
unless an explicit assignment is made.
   I'll remove the code that overrides the default implementation for the 
thread count parameter. I'll open another issue regarding the improper behavior 
of the existing implementation (forcing the thread count to 1 in the absence of 
an explicit assignment).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] sbabcoc commented on a diff in pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option

[GitBox]

sbabcoc commented on code in PR #517:
URL: https://github.com/apache/maven-surefire/pull/517#discussion_r854334421


##
surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/conf/TestNG740Configurator.java:
##
@@ -37,33 +36,77 @@
  *
  * @since 3.0.0-M6
  */
-public class TestNG740Configurator extends TestNG60Configurator
+public class TestNG740Configurator
+extends TestNG60Configurator
 {
+/**
+ * Convert and apply the value of the [threadcount] option.
+ * 
+ * @param suite TestNG {@link XmlSuite} object
+ * @param options Surefire plugin configuration options
+ * @throws TestSetFailedException if unable to convert specified 
[threadcount] setting
+ */
 @Override
-public void configure( XmlSuite suite, Map options )
+protected void configureThreadCount( XmlSuite suite, Map 
options )
 throws TestSetFailedException
 {
-String threadCountAsString = options.get( THREADCOUNT_PROP );
-int threadCount = threadCountAsString == null ? 1 : parseInt( 
threadCountAsString );
-suite.setThreadCount( threadCount );
-
-String parallel = options.get( PARALLEL_PROP );
-if ( parallel != null )
+String threadCount = options.get( THREADCOUNT_PROP );
+// if [threadcount] spec'd
+if ( threadCount != null )
 {
-if ( !"methods".equalsIgnoreCase( parallel ) && 
!"classes".equalsIgnoreCase( parallel ) )
+try
 {
-throw new TestSetFailedException( "Unsupported TestNG parallel 
setting: "
-+ parallel + " ( only METHODS or CLASSES supported )" );
+// convert and apply [threadcount] setting
+suite.setThreadCount( Integer.parseInt( threadCount ) );

Review Comment:
   @Tibor17 As you indicated, TestNG provides a default value of 5. As I 
pointed out, the Surefire documentation also specifies 5 as the default value. 
There is no potential for the thread count to have anything other than 5 unless 
an explicit assignment is made.
   I'll remove the code that overrides the default implementation for the 
thread count parameter. I'll open another issue regarding the improper behavior 
of the existing implementation (forcing the thread count to 1 in the absence of 
an explicit assignment).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #145: Bump mockito.version from 4.4.0 to 4.5.0

[GitBox]

dependabot[bot] opened a new pull request, #145:
URL: https://github.com/apache/maven-enforcer/pull/145

   Bumps `mockito.version` from 4.4.0 to 4.5.0.
   Updates `mockito-core` from 4.4.0 to 4.5.0
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases";>mockito-core's 
releases.
   
   v4.5.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog 
Gradle Plugin
   4.5.0
   
   2022-04-19 - https://github.com/mockito/mockito/compare/v4.4.0...v4.5.0";>15 
commit(s) by Andrei Silviu Dragnea, Rafael Winterhalter, Rick Ossendrijver, 
dependabot[bot]
   Bump versions.errorprone from 2.13.0 to 2.13.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2621";>#2621)](https://github-redirect.dependabot.com/mockito/mockito/pull/2621";>mockito/mockito#2621)
   Bump versions.errorprone from 2.12.1 to 2.13.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2619";>#2619)](https://github-redirect.dependabot.com/mockito/mockito/pull/2619";>mockito/mockito#2619)
   Groovy inline [(https://github-redirect.dependabot.com/mockito/mockito/issues/2618";>#2618)](https://github-redirect.dependabot.com/mockito/mockito/pull/2618";>mockito/mockito#2618)
   Bump actions/setup-java from 2 to 3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2615";>#2615)](https://github-redirect.dependabot.com/mockito/mockito/pull/2615";>mockito/mockito#2615)
   Bump versions.bytebuddy from 1.12.8 to 1.12.9 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2614";>#2614)](https://github-redirect.dependabot.com/mockito/mockito/pull/2614";>mockito/mockito#2614)
   Support subclass mocks on Graal VM. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2613";>#2613)](https://github-redirect.dependabot.com/mockito/mockito/pull/2613";>mockito/mockito#2613)
   Bump com.diffplug.spotless from 6.4.1 to 6.4.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2611";>#2611)](https://github-redirect.dependabot.com/mockito/mockito/pull/2611";>mockito/mockito#2611)
   Bump kotlinx-coroutines-core from 1.6.0-native-mt to 1.6.1-native-mt 
[(https://github-redirect.dependabot.com/mockito/mockito/issues/2609";>#2609)](https://github-redirect.dependabot.com/mockito/mockito/pull/2609";>mockito/mockito#2609)
   Bump versions.errorprone from 2.10.0 to 2.12.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2608";>#2608)](https://github-redirect.dependabot.com/mockito/mockito/pull/2608";>mockito/mockito#2608)
   Bump kotlinVersion from 1.6.10 to 1.6.20 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2607";>#2607)](https://github-redirect.dependabot.com/mockito/mockito/pull/2607";>mockito/mockito#2607)
   Bump com.diffplug.spotless from 6.4.0 to 6.4.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2606";>#2606)](https://github-redirect.dependabot.com/mockito/mockito/pull/2606";>mockito/mockito#2606)
   Bump com.diffplug.spotless from 6.3.0 to 6.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2605";>#2605)](https://github-redirect.dependabot.com/mockito/mockito/pull/2605";>mockito/mockito#2605)
   Bump org.eclipse.osgi from 3.17.100 to 3.17.200 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2597";>#2597)](https://github-redirect.dependabot.com/mockito/mockito/pull/2597";>mockito/mockito#2597)
   Deprecate ListUtil and Fields classes [(https://github-redirect.dependabot.com/mockito/mockito/issues/2593";>#2593)](https://github-redirect.dependabot.com/mockito/mockito/pull/2593";>mockito/mockito#2593)
   mockito-errorprone seems not compatible with ErrorProne 2.11.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2554";>#2554)](https://github-redirect.dependabot.com/mockito/mockito/issues/2554";>mockito/mockito#2554)
   NullPointerException from Groovy metaclass methods when using 
mockito-inline (but not mockito-core) [(https://github-redirect.dependabot.com/mockito/mockito/issues/2522";>#2522)](https://github-redirect.dependabot.com/mockito/mockito/issues/2522";>mockito/mockito#2522)
   
   
   
   
   Commits
   
   https://github.com/mockito/mockito/commit/2c0bf94609300ed369198c3bd44c1555e88f8998";>2c0bf94
 Merge pull request https://github-redirect.dependabot.com/mockito/mockito/issues/2613";>#2613
 from mockito/graal-support
   https://github.com/mockito/mockito/commit/d23dc0e57a8360c8d80f69096cee24c20e4c7c26";>d23dc0e
 Support subclass mocks on Graal VM.
   https://github.com/mockito/mockito/commit/8314824b2c83aff91db140b58de7d9e7d9be5ebf";>8314824
 Bump versions.errorprone from 2.13.0 to 2.13.1 (https://github-redirect.dependabot.com/mockito/mockito/issues/2621";>#2621)
   https://github.com/mockito/mockito/commit/20f16278286b23aa8101cc646b4567560a432224";>20f1627
 Bump kotlinx-coroutines-core from 1.6.0-native-mt to 1.6.1-native-mt (https://github-redirect.dependabot.com/mockito/mockito/issues/2609";>#2609)
   https://github.c

[GitHub] [maven-surefire] dsubelman commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

dsubelman commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104101425

   > > If the test fails with escaping characters `	`, you can try using 
`String.replaceAll(String, String)` with regex.
   > > Instead of:
   > > ```
   > > return argLine
   > > .replace( "\n", " " )
   > > .replace( "\r", " " )
   > > .replace( "\t", " " );
   > > ```
   > > 
   > > 
   > > 
   > >   
   > > 
   > > 
   > >   
   > > 
   > > 
   > > 
   > >   
   > > You can do:
   > > ```
   > > return argLine.replaceAll("\\s+", " ");
   > > ```
   > 
   > It does, but it also matches spaces (which it currently doesn't). On the 
other hand, it's one regex vs. three, so that could be a benefit. What do you 
think, @Tibor17?
   
   It also replaces multiple consecutive whitespaces with a single whitespace:
   
   List whitespaces = List.of(
   "\n", 
   "\r",
   "\n\r",
   "\t", 
   " ",// single whitespace
   "  ",   // double whitespaces
   "   ",  // triple whitespace
   "",  // 	
   "\n\n\r\t",
   "  \n \n\r   \t   ");
   
   List stripWhitespaces = whitespaces.stream()
   .map(str -> str.replaceAll("\\s+", "' '")).toList();
   
   System.out.println(stripWhitespaces);
   
   Output:
   
   [' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ']


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] cstamas closed pull request #721: Check resolver 1.8.0 on maven master

[GitBox]

cstamas closed pull request #721: Check resolver 1.8.0 on maven master
URL: https://github.com/apache/maven/pull/721


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] cstamas opened a new pull request, #724: [MNG-7453] Update Resolver to 1.8.0

[GitBox]

cstamas opened a new pull request, #724:
URL: https://github.com/apache/maven/pull/724

   Updates Maven Resolver to 1.8.0.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] cstamas opened a new pull request, #723: [MNG-7453] Update Resolver to 1.8.0

[GitBox]

cstamas opened a new pull request, #723:
URL: https://github.com/apache/maven/pull/723

   Updates Maven Resolver to latest 1.8.0.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (MWAR-440) When it is necessary to build more than one WAR archive at the same time, it fails to set different web.xml

[Dennis Lundberg (Jira)]

 [ 
https://issues.apache.org/jira/browse/MWAR-440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Lundberg closed MWAR-440.

Resolution: Not A Problem

> When it is necessary to build more than one WAR archive at the same time, it 
> fails to set different web.xml
> ---
>
> Key: MWAR-440
> URL: https://issues.apache.org/jira/browse/MWAR-440
> Project: Maven WAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0, 3.2.0, 3.2.2
>Reporter: Tuzhilkin Mikhail
>Priority: Major
>
> In an assembly, I need to create 2 WAR archives with different web.xml files 
> at a time.
> For this I use the following plugin setting:
> {code:xml}
> 
> maven-war-plugin
> 3.2.2
> 
> web?.xml
> true
> 
> 
> 
> 1
> package
> 
> war
> 
> 
> false
> src/main/webapp/web1.xml
> web1
> 
> 
> 
> 2
> package
> 
> war
> 
> 
> false
> src/main/webapp/web2.xml
> web2
> 
> 
> 
> 
> {code}
> {code}
> Project structure:
> src/main/webapp/web1.xml
> src/main/webapp/web2.xml
> pom.xml
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> But the first of the specified files gets into both archives, despite the 
> different paths .
> {code}
> $ unzip -p web1.war WEB-INF/web.xml
> 
> 
> 
> $ unzip -p web2.war WEB-INF/web.xml
> 
> 
> 
> {code}
> Example project: [https://github.com/tuzhms/mwar-bug-example]



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MNG-7449) [REGRESSION] StringVisitorModelInterpolator NullPointerException

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7449:

Fix Version/s: (was: wontfix-candidate)

> [REGRESSION] StringVisitorModelInterpolator NullPointerException
> 
>
> Key: MNG-7449
> URL: https://issues.apache.org/jira/browse/MNG-7449
> Project: Maven
>  Issue Type: Bug
>  Components: Inheritance and Interpolation
>Affects Versions: 3.8.5
>Reporter: Ronnie de Lang
>Priority: Major
>
> Since Maven 3.8.5 our own custom Maven plugin is failing with a 
> NullPointerException when trying to interpolate Maven properties in a Maven 
> model.
> Code:
> {code:java}
> StringVisitorModelInterpolator interpolator = new 
> StringVisitorModelInterpolator();
> interpolated = interpolator.interpolateModel(model, null, new 
> DefaultModelBuildingRequest(), new ModelProblemCollector() {
> @Override
> public void add(ModelProblemCollectorRequest 
> modelProblemCollectorRequest) {
> problems.add(modelProblemCollectorRequest);
> }
> }); {code}
> Stacktrace:
> {code:java}
> [ERROR] Failed to execute goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> (default) on project DNL_PMDM_HelloYou: Execution default of goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> failed.: NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> (default) on project DNL_PMDM_HelloYou: Execution default of goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> failed.
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:306)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:127)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:498)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default of goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> failed.
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:301)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:127)
>     at or

[jira] [Closed] (MNG-7449) [REGRESSION] StringVisitorModelInterpolator NullPointerException

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MNG-7449.
---
Resolution: Information Provided

> [REGRESSION] StringVisitorModelInterpolator NullPointerException
> 
>
> Key: MNG-7449
> URL: https://issues.apache.org/jira/browse/MNG-7449
> Project: Maven
>  Issue Type: Bug
>  Components: Inheritance and Interpolation
>Affects Versions: 3.8.5
>Reporter: Ronnie de Lang
>Priority: Major
> Fix For: wontfix-candidate
>
>
> Since Maven 3.8.5 our own custom Maven plugin is failing with a 
> NullPointerException when trying to interpolate Maven properties in a Maven 
> model.
> Code:
> {code:java}
> StringVisitorModelInterpolator interpolator = new 
> StringVisitorModelInterpolator();
> interpolated = interpolator.interpolateModel(model, null, new 
> DefaultModelBuildingRequest(), new ModelProblemCollector() {
> @Override
> public void add(ModelProblemCollectorRequest 
> modelProblemCollectorRequest) {
> problems.add(modelProblemCollectorRequest);
> }
> }); {code}
> Stacktrace:
> {code:java}
> [ERROR] Failed to execute goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> (default) on project DNL_PMDM_HelloYou: Execution default of goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> failed.: NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> (default) on project DNL_PMDM_HelloYou: Execution default of goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> failed.
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:306)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:127)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:498)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default of goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> failed.
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:301)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (Lifecycl

[jira] [Updated] (MSKINS-177) Support Matomo (e.g. Apache Analytics) as macro

[Olivier Lamy (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSKINS-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy updated MSKINS-177:

Summary: Support Matomo (e.g. Apache Analytics) as macro  (was: Support 
Matomo Analytics (e.g. Apache Analytics) as macro)

> Support Matomo (e.g. Apache Analytics) as macro
> ---
>
> Key: MSKINS-177
> URL: https://issues.apache.org/jira/browse/MSKINS-177
> Project: Maven Skins
>  Issue Type: Improvement
>  Components: Fluido Skin
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: fluido-1.11.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MSKINS-177) Support Matomo Analytics (e.g. Apache Analytics) as macro

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSKINS-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSKINS-177:
--
Summary: Support Matomo Analytics (e.g. Apache Analytics) as macro  (was: 
Support native matomo (i.e Apache Analytics) as macro)

> Support Matomo Analytics (e.g. Apache Analytics) as macro
> -
>
> Key: MSKINS-177
> URL: https://issues.apache.org/jira/browse/MSKINS-177
> Project: Maven Skins
>  Issue Type: Improvement
>  Components: Fluido Skin
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: fluido-1.11.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

[GitBox]

olamy commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r854029481


##
pom.xml:
##
@@ -260,6 +261,7 @@ under the License.
   
 site
   
+  true

Review Comment:
   yes because it helps me when writing/debugging IT test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MWAR-440) When it is necessary to build more than one WAR archive at the same time, it fails to set different web.xml

[Tuzhilkin Mikhail (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524904#comment-17524904
 ] 

Tuzhilkin Mikhail commented on MWAR-440:


[~sjaranowski], I checked. Indeed, specifying different {{webappDirectory}} 
solves this problem.
{code:xml}


1
package

war


false
src/main/webapp/web1.xml
web1
${project.build.directory}/web1



2
package

war


false
src/main/webapp/web2.xml
web2
${project.build.directory}/web2



{code}
Thank you very much

> When it is necessary to build more than one WAR archive at the same time, it 
> fails to set different web.xml
> ---
>
> Key: MWAR-440
> URL: https://issues.apache.org/jira/browse/MWAR-440
> Project: Maven WAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0, 3.2.0, 3.2.2
>Reporter: Tuzhilkin Mikhail
>Priority: Major
>
> In an assembly, I need to create 2 WAR archives with different web.xml files 
> at a time.
> For this I use the following plugin setting:
> {code:xml}
> 
> maven-war-plugin
> 3.2.2
> 
> web?.xml
> true
> 
> 
> 
> 1
> package
> 
> war
> 
> 
> false
> src/main/webapp/web1.xml
> web1
> 
> 
> 
> 2
> package
> 
> war
> 
> 
> false
> src/main/webapp/web2.xml
> web2
> 
> 
> 
> 
> {code}
> {code}
> Project structure:
> src/main/webapp/web1.xml
> src/main/webapp/web2.xml
> pom.xml
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> But the first of the specified files gets into both archives, despite the 
> different paths .
> {code}
> $ unzip -p web1.war WEB-INF/web.xml
> 
> 
> 
> $ unzip -p web2.war WEB-INF/web.xml
> 
> 
> 
> {code}
> Example project: [https://github.com/tuzhms/mwar-bug-example]



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MNG-7449) [REGRESSION] StringVisitorModelInterpolator NullPointerException

[Ronnie de Lang (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524903#comment-17524903
 ] 

Ronnie de Lang commented on MNG-7449:
-

Thanks [~cstamas] for your explanation, that fixed the problem indeed.

> [REGRESSION] StringVisitorModelInterpolator NullPointerException
> 
>
> Key: MNG-7449
> URL: https://issues.apache.org/jira/browse/MNG-7449
> Project: Maven
>  Issue Type: Bug
>  Components: Inheritance and Interpolation
>Affects Versions: 3.8.5
>Reporter: Ronnie de Lang
>Priority: Major
> Fix For: wontfix-candidate
>
>
> Since Maven 3.8.5 our own custom Maven plugin is failing with a 
> NullPointerException when trying to interpolate Maven properties in a Maven 
> model.
> Code:
> {code:java}
> StringVisitorModelInterpolator interpolator = new 
> StringVisitorModelInterpolator();
> interpolated = interpolator.interpolateModel(model, null, new 
> DefaultModelBuildingRequest(), new ModelProblemCollector() {
> @Override
> public void add(ModelProblemCollectorRequest 
> modelProblemCollectorRequest) {
> problems.add(modelProblemCollectorRequest);
> }
> }); {code}
> Stacktrace:
> {code:java}
> [ERROR] Failed to execute goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> (default) on project DNL_PMDM_HelloYou: Execution default of goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> failed.: NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> (default) on project DNL_PMDM_HelloYou: Execution default of goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> failed.
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:306)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:127)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:498)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default of goal 
> nl.ing.cis.tools.deploy:deploy-configuration-maven-plugin:5.2.0:flatten 
> failed.
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:301)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuild

[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

[GitBox]

olamy commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r854027983


##
src/site/apt/ITs.apt:
##
@@ -32,6 +32,8 @@ Maven Fuido Skin ITs
 
   * {{{./mskins-14/index.html}Search}}
 
+  * {{{./mskins-177-apache-analytics/index.html}Apache Analytics}}
+

Review Comment:
   because all ITs are not linked and most complete one is more interesting



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

[GitBox]

michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r854013055


##
src/site/apt/index.apt.vm:
##
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
 
 +-+
 
+** Matomo (e.g ApacheAnalytics)

Review Comment:
   Space missing



##
src/site/apt/ITs.apt:
##
@@ -32,6 +32,8 @@ Maven Fuido Skin ITs
 
   * {{{./mskins-14/index.html}Search}}
 
+  * {{{./mskins-177-apache-analytics/index.html}Apache Analytics}}
+

Review Comment:
   Why isn't the second IT no linked?



##
pom.xml:
##
@@ -260,6 +261,7 @@ under the License.
   
 site
   
+  true

Review Comment:
   That's unrelated to this PR.



##
src/site/apt/index.apt.vm:
##
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
 
 +-+
 
+** Matomo (e.g ApacheAnalytics)
+
+  Users can optionally enable <>.
+  How to configure it for Apache Analytics, the <> element will 
contain some configuration (here some privacy setup) :

Review Comment:
   No French space before colon



##
src/site/apt/index.apt.vm:
##
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
 
 +-+
 
+** Matomo (e.g ApacheAnalytics)

Review Comment:
   e.g.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MWAR-444) Update plugin (requires Maven 3.2.5+)

[Jira]

[ 
https://issues.apache.org/jira/browse/MWAR-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524888#comment-17524888
 ] 

Tamás Cservenák commented on MWAR-444:
--

IMHO outdated as well.

> Update plugin (requires Maven 3.2.5+)
> -
>
> Key: MWAR-444
> URL: https://issues.apache.org/jira/browse/MWAR-444
> Project: Maven WAR Plugin
>  Issue Type: Task
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.3
>
>
> Update plugin
>  * require Maven 3.2.5+
>  * set maven bits to provided scope
>  * get rid of old baggage, update dependencies



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (MSKINS-177) Support native matomo (i.e Apache Analytics) as macro

[Olivier Lamy (Jira)]

 [ 
https://issues.apache.org/jira/browse/MSKINS-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy updated MSKINS-177:

Fix Version/s: fluido-1.11.0
   (was: fluido-1.12.0)

> Support native matomo (i.e Apache Analytics) as macro
> -
>
> Key: MSKINS-177
> URL: https://issues.apache.org/jira/browse/MSKINS-177
> Project: Maven Skins
>  Issue Type: Improvement
>  Components: Fluido Skin
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: fluido-1.11.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MWAR-444) Update plugin (requires Maven 3.2.5+)

[Slawomir Jaranowski (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524887#comment-17524887
 ] 

Slawomir Jaranowski commented on MWAR-444:
--

outdated discussion about Maven api version ... in first step 3.2.5 is ok, even 
we can target to 3.5.4

> Update plugin (requires Maven 3.2.5+)
> -
>
> Key: MWAR-444
> URL: https://issues.apache.org/jira/browse/MWAR-444
> Project: Maven WAR Plugin
>  Issue Type: Task
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.3
>
>
> Update plugin
>  * require Maven 3.2.5+
>  * set maven bits to provided scope
>  * get rid of old baggage, update dependencies



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

[GitBox]

olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1103797412

   > This should only be Matomo-specific, not ASF specific. Just make the full 
host a mandatory config option (next to site id) to make this feature usable 
outside ASF projects.
   
   isn't good enough? 
https://github.com/apache/maven-fluido-skin/pull/22/files#diff-85dce09d83956e168d3fdfc3bfe3119e82cb7d0e18083a0a475441337168fcee


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MWAR-440) When it is necessary to build more than one WAR archive at the same time, it fails to set different web.xml

[Slawomir Jaranowski (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524883#comment-17524883
 ] 

Slawomir Jaranowski commented on MWAR-440:
--

Second execution should have own space - so parameters like 
{{{}outputDirectory{}}}, {{{}webappDirectory{}}}, {{workDirectory}} should be 
changed.

I see that you only want have different one file ... but separate space can 
resolve your issue. 
Need to test which parameters should be changed, maybe one of them will be 
enough.

https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html

> When it is necessary to build more than one WAR archive at the same time, it 
> fails to set different web.xml
> ---
>
> Key: MWAR-440
> URL: https://issues.apache.org/jira/browse/MWAR-440
> Project: Maven WAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0, 3.2.0, 3.2.2
>Reporter: Tuzhilkin Mikhail
>Priority: Major
>
> In an assembly, I need to create 2 WAR archives with different web.xml files 
> at a time.
> For this I use the following plugin setting:
> {code:xml}
> 
> maven-war-plugin
> 3.2.2
> 
> web?.xml
> true
> 
> 
> 
> 1
> package
> 
> war
> 
> 
> false
> src/main/webapp/web1.xml
> web1
> 
> 
> 
> 2
> package
> 
> war
> 
> 
> false
> src/main/webapp/web2.xml
> web2
> 
> 
> 
> 
> {code}
> {code}
> Project structure:
> src/main/webapp/web1.xml
> src/main/webapp/web2.xml
> pom.xml
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> But the first of the specified files gets into both archives, despite the 
> different paths .
> {code}
> $ unzip -p web1.war WEB-INF/web.xml
> 
> 
> 
> $ unzip -p web2.war WEB-INF/web.xml
> 
> 
> 
> {code}
> Example project: [https://github.com/tuzhms/mwar-bug-example]



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Comment Edited] (MWAR-440) When it is necessary to build more than one WAR archive at the same time, it fails to set different web.xml

[Dennis Lundberg (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524872#comment-17524872
 ] 

Dennis Lundberg edited comment on MWAR-440 at 4/20/22 10:43 AM:


The reason for this seems to be that the time stamp of the two web.xml files 
are identical.

In the first run the war plugin copies files into 
target/mwar-bug-example/WEB-INF/ including web1.xml.

During the second run the war plugin copies files into 
target/mwar-bug-example/WEB-INF/ including web2.xml. But, here it realizes that 
the target fil target/mwar-bug-example/WEB-INF/web.xml has an identical file 
name and time stamp. Therefor it skips that file. This can be seen in the log 
if you run Maven with the -X option. Here are the output from the first run:
{noformat}
[INFO] Processing war project
[INFO] Copying webapp resources 
[C:\Users\dlg01\Downloads\mwar-bug-example-master\src\main\webapp]
[DEBUG]  + web1.xml has been copied.
[DEBUG]  + web2.xml has been copied.
[DEBUG] Dump of the current build pathSet content -->
[DEBUG] web1.xml
[DEBUG] web2.xml
[DEBUG] -- end of dump --
[DEBUG]  + WEB-INF/web.xml has been copied.
[INFO] Webapp assembled in [316 msecs]{noformat}
And here is the output from the second run:
{noformat}
[INFO] Processing war project
[INFO] Copying webapp resources 
[C:\Users\dlg01\Downloads\mwar-bug-example-master\src\main\webapp]
[DEBUG]  + web1.xml has been copied.
[DEBUG]  + web2.xml has been copied.
[DEBUG] Dump of the current build pathSet content -->
[DEBUG] web1.xml
[DEBUG] web2.xml
[DEBUG] -- end of dump --
[DEBUG]  * WEB-INF/web.xml is up to date.
[INFO] Webapp assembled in [266 msecs] {noformat}
 


was (Author: dennisl):
The reason for this seems to be that the time stamp of the two web.xml files 
are identical.

In the first run the war plugin copies files into 
target/mwar-bug-example/WEB-INF/ including web1.xml.

During the second run the war plugin copies files into 
target/mwar-bug-example/WEB-INF/ including web2.xml. But, here it realizes that 
the target fil target/mwar-bug-example/WEB-INF/web.xml has an identical file 
name and time stamp. Therefor it skips that file. This can be seen in the log 
if you run Maven with the -X option. Here are the output from the first run:
{noformat}
[INFO] Processing war project
[INFO] Copying webapp resources 
[C:\Users\dlg01\Downloads\mwar-bug-example-master\src\main\webapp]
[DEBUG]  + web1.xml has been copied.
[DEBUG]  + web2.xml has been copied.
[DEBUG] Dump of the current build pathSet content -->
[DEBUG] web1.xml
[DEBUG] web2.xml
[DEBUG] -- end of dump --
[DEBUG]  * WEB-INF/web.xml is up to date.
[INFO] Webapp assembled in [266 msecs]{noformat}
And here is the output from the second run:
{noformat}
[INFO] Processing war project
[INFO] Copying webapp resources 
[C:\Users\dlg01\Downloads\mwar-bug-example-master\src\main\webapp]
[DEBUG]  + web1.xml has been copied.
[DEBUG]  + web2.xml has been copied.
[DEBUG] Dump of the current build pathSet content -->
[DEBUG] web1.xml
[DEBUG] web2.xml
[DEBUG] -- end of dump --
[DEBUG]  * WEB-INF/web.xml is up to date.
[INFO] Webapp assembled in [266 msecs] {noformat}
 

> When it is necessary to build more than one WAR archive at the same time, it 
> fails to set different web.xml
> ---
>
> Key: MWAR-440
> URL: https://issues.apache.org/jira/browse/MWAR-440
> Project: Maven WAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0, 3.2.0, 3.2.2
>Reporter: Tuzhilkin Mikhail
>Priority: Major
>
> In an assembly, I need to create 2 WAR archives with different web.xml files 
> at a time.
> For this I use the following plugin setting:
> {code:xml}
> 
> maven-war-plugin
> 3.2.2
> 
> web?.xml
> true
> 
> 
> 
> 1
> package
> 
> war
> 
> 
> false
> src/main/webapp/web1.xml
> web1
> 
> 
> 
> 2
> package
> 
> war
> 
> 
> false
> src/main/webapp/web2.xml
> web2
> 
> 
> 
> 
> {code}
> {code}
> Project structure:
> src/main/webapp/web1.xml
> src/main/webapp/web2.xml
> pom.xml
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> But the first of the specified files gets into both archives, despite the 
> different paths .
> {code}
> $ unzip -p web1.war WEB-INF/web.xml
> 
> 
> 
> $ unzip -p web2.war WEB-INF/web.xml
> 
> 
> 
> {code}
> Example project: [https://github.com/tuzhms/mwar-bug-example]



--
This message was sent by Atlassian Jira
(v8.20.7#

[jira] [Commented] (MWAR-444) Update plugin (requires Maven 3.2.5+)

[Dennis Lundberg (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524873#comment-17524873
 ] 

Dennis Lundberg commented on MWAR-444:
--

[~cstamas] I was refering to the discussion in the pull request on GitHub here: 
https://github.com/apache/maven-war-plugin/pull/20

> Update plugin (requires Maven 3.2.5+)
> -
>
> Key: MWAR-444
> URL: https://issues.apache.org/jira/browse/MWAR-444
> Project: Maven WAR Plugin
>  Issue Type: Task
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.3
>
>
> Update plugin
>  * require Maven 3.2.5+
>  * set maven bits to provided scope
>  * get rid of old baggage, update dependencies



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MWAR-440) When it is necessary to build more than one WAR archive at the same time, it fails to set different web.xml

[Dennis Lundberg (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524872#comment-17524872
 ] 

Dennis Lundberg commented on MWAR-440:
--

The reason for this seems to be that the time stamp of the two web.xml files 
are identical.

In the first run the war plugin copies files into 
target/mwar-bug-example/WEB-INF/ including web1.xml.

During the second run the war plugin copies files into 
target/mwar-bug-example/WEB-INF/ including web2.xml. But, here it realizes that 
the target fil target/mwar-bug-example/WEB-INF/web.xml has an identical file 
name and time stamp. Therefor it skips that file. This can be seen in the log 
if you run Maven with the -X option. Here are the output from the first run:
{noformat}
[INFO] Processing war project
[INFO] Copying webapp resources 
[C:\Users\dlg01\Downloads\mwar-bug-example-master\src\main\webapp]
[DEBUG]  + web1.xml has been copied.
[DEBUG]  + web2.xml has been copied.
[DEBUG] Dump of the current build pathSet content -->
[DEBUG] web1.xml
[DEBUG] web2.xml
[DEBUG] -- end of dump --
[DEBUG]  * WEB-INF/web.xml is up to date.
[INFO] Webapp assembled in [266 msecs]{noformat}
And here is the output from the second run:
{noformat}
[INFO] Processing war project
[INFO] Copying webapp resources 
[C:\Users\dlg01\Downloads\mwar-bug-example-master\src\main\webapp]
[DEBUG]  + web1.xml has been copied.
[DEBUG]  + web2.xml has been copied.
[DEBUG] Dump of the current build pathSet content -->
[DEBUG] web1.xml
[DEBUG] web2.xml
[DEBUG] -- end of dump --
[DEBUG]  * WEB-INF/web.xml is up to date.
[INFO] Webapp assembled in [266 msecs] {noformat}
 

> When it is necessary to build more than one WAR archive at the same time, it 
> fails to set different web.xml
> ---
>
> Key: MWAR-440
> URL: https://issues.apache.org/jira/browse/MWAR-440
> Project: Maven WAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0, 3.2.0, 3.2.2
>Reporter: Tuzhilkin Mikhail
>Priority: Major
>
> In an assembly, I need to create 2 WAR archives with different web.xml files 
> at a time.
> For this I use the following plugin setting:
> {code:xml}
> 
> maven-war-plugin
> 3.2.2
> 
> web?.xml
> true
> 
> 
> 
> 1
> package
> 
> war
> 
> 
> false
> src/main/webapp/web1.xml
> web1
> 
> 
> 
> 2
> package
> 
> war
> 
> 
> false
> src/main/webapp/web2.xml
> web2
> 
> 
> 
> 
> {code}
> {code}
> Project structure:
> src/main/webapp/web1.xml
> src/main/webapp/web2.xml
> pom.xml
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> {code:xml}
> 
> 
> 
> 
> {code}
> But the first of the specified files gets into both archives, despite the 
> different paths .
> {code}
> $ unzip -p web1.war WEB-INF/web.xml
> 
> 
> 
> $ unzip -p web2.war WEB-INF/web.xml
> 
> 
> 
> {code}
> Example project: [https://github.com/tuzhms/mwar-bug-example]



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

[GitBox]

olamy commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r853973657


##
pom.xml:
##
@@ -260,6 +261,7 @@ under the License.
   
 site
   
+  true

Review Comment:
   because when running IT locally it's more convenient to have the output of 
failed test in the console rather than looking into a build.log file.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MWAR-444) Update plugin (requires Maven 3.2.5+)

[Slawomir Jaranowski (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524853#comment-17524853
 ] 

Slawomir Jaranowski commented on MWAR-444:
--

[~dennisl] - Great hearing about next release. Please verify other issues for 
release. eg. like: MWAR-452

> Update plugin (requires Maven 3.2.5+)
> -
>
> Key: MWAR-444
> URL: https://issues.apache.org/jira/browse/MWAR-444
> Project: Maven WAR Plugin
>  Issue Type: Task
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.3
>
>
> Update plugin
>  * require Maven 3.2.5+
>  * set maven bits to provided scope
>  * get rid of old baggage, update dependencies



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Assigned] (MWAR-452) One page about Skinny WARs

[Slawomir Jaranowski (Jira)]

 [ 
https://issues.apache.org/jira/browse/MWAR-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MWAR-452:


Assignee: Slawomir Jaranowski

> One page about Skinny WARs
> --
>
> Key: MWAR-452
> URL: https://issues.apache.org/jira/browse/MWAR-452
> Project: Maven WAR Plugin
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> We have:
> - https://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html
> - https://maven.apache.org/plugins/maven-ear-plugin/examples/skinny-wars.html
> Both site contains the same information and very similar (almost identical) 
> content.
> {{Skinny WARs}} is feature of {{m-ear-p}} so page should be maintained in one 
> place in {{m-ear-p}} project.
> In {{m-war-p}} we can link to site in {{m-ear-p}} project.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Created] (MWAR-452) One page about Skinny WARs

[Slawomir Jaranowski (Jira)]

Slawomir Jaranowski created MWAR-452:


 Summary: One page about Skinny WARs
 Key: MWAR-452
 URL: https://issues.apache.org/jira/browse/MWAR-452
 Project: Maven WAR Plugin
  Issue Type: Improvement
Reporter: Slawomir Jaranowski
 Fix For: next-release


We have:
- https://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html
- https://maven.apache.org/plugins/maven-ear-plugin/examples/skinny-wars.html

Both site contains the same information and very similar (almost identical) 
content.

{{Skinny WARs}} is feature of {{m-ear-p}} so page should be maintained in one 
place in {{m-ear-p}} project.

In {{m-war-p}} we can link to site in {{m-ear-p}} project.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-war-plugin] slawekjaranowski commented on a diff in pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…

[GitBox]

slawekjaranowski commented on code in PR #22:
URL: https://github.com/apache/maven-war-plugin/pull/22#discussion_r853930705


##
src/it/MWAR-450/verify.bsh:
##
@@ -0,0 +1,94 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+File target = new File( basedir, "target/mwar450/WEB-INF/classes" );
+if ( !target.exists() || !target.isDirectory() )
+{
+System.err.println( "target/mwar450/WEB-INF/classes is missing or is 
not a directory." );
+return false;
+}
+
+// Load and check log4j.xml
+File log4jxml = new File( target, "log4j.xml" );
+if ( !log4jxml.exists() || log4jxml.isDirectory() )
+{
+System.err.println( "log4j.xml is missing or is a directory." );
+return false;
+}
+FileInputStream fis = new FileInputStream ( log4jxml );
+String paramContent = IOUtil.toString ( fis, "UTF-8" );
+System.out.println( "content='" + paramContent + "'" );
+int indexOf = paramContent.indexOf( "This file is encoded in UTF-8 and 
should remain so after filtering - åäö" );
+if ( indexOf < 0 )
+{
+  System.err.println( "Non-ascii characters changed encoding during 
filtering" );
+  return false;
+}
+
+// Load and check my.properties
+File myProperties = new File( target, "my.properties" );
+if ( !myProperties.exists() || myProperties.isDirectory() )
+{
+System.err.println( "my.properties is missing or is a directory." );
+return false;
+}
+Properties properties = new Properties();

Review Comment:
   In jdk9 encoding of properties was changed.
   
https://docs.oracle.com/javase/9/intl/internationalization-enhancements-jdk-9.htm
   
   Maybe good assertions will be length of file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (MWAR-420) build failure in lifecycle deploy: 'Could not copy webapp sources'

[Dennis Lundberg (Jira)]

 [ 
https://issues.apache.org/jira/browse/MWAR-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Lundberg closed MWAR-420.

Fix Version/s: 3.3.0
   Resolution: Fixed

This seems to have been resolved in Maven War Plugin 3.3.0.

> build failure in lifecycle deploy: 'Could not copy webapp sources'
> --
>
> Key: MWAR-420
> URL: https://issues.apache.org/jira/browse/MWAR-420
> Project: Maven WAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.0, 3.2.1, 3.2.2
>Reporter: Bruno Marti
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: build-error.log, testWarPlugin.zip
>
>
> Since version 3.2.x there is a build failure in maven-war-plugin on lifecycle 
> 'deploy'.
> {code:java}
> mvn package package -e{code}
> If you build sample webapp (see attachement: [^testWarPlugin.zip]) with 
> version 3.2.2 following error occurs:
> {code:java}
> [INFO] --- maven-war-plugin:3.2.2:war (default-war) @ testWarPlugin ---
> [INFO] Packaging webapp
> [INFO] Assembling webapp [testWarPlugin] in 
> [C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT]
> [INFO] Processing war project
> [INFO] Copying webapp resources [C:\TEMP\testWarPlugin\src\main\webapp]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5.106 s
> [INFO] Finished at: 2018-11-07T10:11:58+01:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-war-plugin:3.2.2:war (default-war) on project 
> testWarPlugin: Could not copy webapp sources 
> [C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT]: 
> C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT\images\ajaxloading.gif
>  -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-war-plugin:3.2.2:war (default-war) on 
> project testWarPlugin: Could not copy webapp sources 
> [C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT]
> ...
> Caused by: java.nio.file.AccessDeniedException: 
> C:\TEMP\testWarPlugin\target\testWarPlugin-1.0-SNAPSHOT\images\ajaxloading.gif
>     at sun.nio.fs.WindowsException.translateToIOException 
> (WindowsException.java:83)
>     at sun.nio.fs.WindowsException.rethrowAsIOException 
> (WindowsException.java:97)
>     at sun.nio.fs.WindowsException.rethrowAsIOException 
> (WindowsException.java:102)
>     at sun.nio.fs.WindowsFileCopy.copy (WindowsFileCopy.java:165)
>     at sun.nio.fs.WindowsFileSystemProvider.copy 
> (WindowsFileSystemProvider.java:278)
>     at java.nio.file.Files.copy (Files.java:1274)
> {code}
> It only occurs on {color:#ff}windows{color} and with 
> maven-war-plugin{color:#ff} 3.2.x{color}. Fullstacktrace here: 
> [^build-error.log]
> Version {color:#14892c}3.1.0 and older{color} works fine



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MWAR-444) Update plugin (requires Maven 3.2.5+)

[Jira]

[ 
https://issues.apache.org/jira/browse/MWAR-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524813#comment-17524813
 ] 

Tamás Cservenák commented on MWAR-444:
--

What disagreement you mean, can you point me there? Also, are you bound to some 
old Maven version?

> Update plugin (requires Maven 3.2.5+)
> -
>
> Key: MWAR-444
> URL: https://issues.apache.org/jira/browse/MWAR-444
> Project: Maven WAR Plugin
>  Issue Type: Task
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.3
>
>
> Update plugin
>  * require Maven 3.2.5+
>  * set maven bits to provided scope
>  * get rid of old baggage, update dependencies



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Created] (MDEP-801) includeClassifers not working ?

[Jira]

François Régnier created MDEP-801:
-

 Summary: includeClassifers not working ?
 Key: MDEP-801
 URL: https://issues.apache.org/jira/browse/MDEP-801
 Project: Maven Dependency Plugin
  Issue Type: Bug
  Components: copy-dependencies
Affects Versions: 3.3.0
Reporter: François Régnier


Hello,

I want to copy dependencies with several classifiers.

A working solution is:
{code:java}
                
                    org.apache.maven.plugins
                    maven-dependency-plugin
                    ${dependency.plugin.version}
                    
                        
                            download-escrow-sources
                            
                                copy-dependencies
                            
                            package
                            
                                runtime
                                sources
                            
${project.build.directory}/escrow-sources
                                
com.xxx,com.yyy
                                true
                                true
                            
                        
                        
                            download-escrow-scripts
                            
                                copy-dependencies
                            
                            package
                            
                                runtime
                                scripts
                                
${project.build.directory}/escrow-sources
                                
com.xxx,com.yyy
                                true
                               true
                            
                        
                    
                
 {code}
But rather than duplicate the executions, i think i can use the 
includeClassifers:
{code:java}
                
                    org.apache.maven.plugins
                    maven-dependency-plugin
                    ${dependency.plugin.version}
                    
                        
                            download-escrow-sources
                            
                                copy-dependencies
                            
                            package
                            
                                runtime
                                
scripts,sources
                                
${project.build.directory}/escrow-sources
                                
com.xxx,com.yyy
                                true
                                true
                            
                        
                    
                
 {code}
But in this second case only "scripts" classifiers are copied and "sources" are 
missing.

Is there a bug ? Or do i misunderstood something ?

Thanks,

François

 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (MWAR-444) Update plugin (requires Maven 3.2.5+)

[Dennis Lundberg (Jira)]

[ 
https://issues.apache.org/jira/browse/MWAR-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524812#comment-17524812
 ] 

Dennis Lundberg commented on MWAR-444:
--

I'm working on MWAR-450 and would like to make a release of that , when it is 
finished. Should this issue be included in the next version? There seems to be 
disagreement on GitHub regarding which version och Maven to require.

> Update plugin (requires Maven 3.2.5+)
> -
>
> Key: MWAR-444
> URL: https://issues.apache.org/jira/browse/MWAR-444
> Project: Maven WAR Plugin
>  Issue Type: Task
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.3
>
>
> Update plugin
>  * require Maven 3.2.5+
>  * set maven bits to provided scope
>  * get rid of old baggage, update dependencies



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

mthmulders commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1103638849

   > If the test fails with escaping characters `	`, you can try using 
`String.replaceAll(String, String)` with regex.
   > 
   > Instead of:
   > 
   > ```
   > return argLine
   > .replace( "\n", " " )
   > .replace( "\r", " " )
   > .replace( "\t", " " );
   > ```
   > 
   > You can do:
   > 
   > ```
   > return argLine.replaceAll("\\s+", " ");
   > ```
   
   It does, but it also matches spaces (which it currently doesn't). On the 
other hand, it's one regex vs. three, so that could be a benefit. What do you 
think, @Tibor17?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

mthmulders commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-110363

   > @mthmulders I have one more question. The developers would not be able to 
see the TAB because it is a white space. If the new guy would refactor it 
again, then this IT would not cover the purpose that it has now. I know it is a 
question of how the xml parser interprets the escaping characters in Maven but 
I would like to ask you for testing with escaping characters `	` on Maven 
3.2.x and 3.8.x. WDYT?
   
   That's why I added XML comments saying those lines must be tab-indented. 
I've just tested locally: an XML file with `	` also breaks before the 
change in `DefaultForkConfiguration` (tested with Maven 4 SNAPSHOT, Maven 3.8.5 
and Maven 3.2.5). So it seems to work equally fine for the test. Just tell me 
which one you prefer @Tibor17: tab characters, XML entities, or both.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-war-plugin] dennisl commented on a diff in pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…

[GitBox]

dennisl commented on code in PR #22:
URL: https://github.com/apache/maven-war-plugin/pull/22#discussion_r853882133


##
src/it/MWAR-450/verify.bsh:
##
@@ -0,0 +1,94 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+File target = new File( basedir, "target/mwar450/WEB-INF/classes" );
+if ( !target.exists() || !target.isDirectory() )
+{
+System.err.println( "target/mwar450/WEB-INF/classes is missing or is 
not a directory." );
+return false;
+}
+
+// Load and check log4j.xml
+File log4jxml = new File( target, "log4j.xml" );
+if ( !log4jxml.exists() || log4jxml.isDirectory() )
+{
+System.err.println( "log4j.xml is missing or is a directory." );
+return false;
+}
+FileInputStream fis = new FileInputStream ( log4jxml );
+String paramContent = IOUtil.toString ( fis, "UTF-8" );
+System.out.println( "content='" + paramContent + "'" );
+int indexOf = paramContent.indexOf( "This file is encoded in UTF-8 and 
should remain so after filtering - åäö" );
+if ( indexOf < 0 )
+{
+  System.err.println( "Non-ascii characters changed encoding during 
filtering" );
+  return false;
+}
+
+// Load and check my.properties
+File myProperties = new File( target, "my.properties" );
+if ( !myProperties.exists() || myProperties.isDirectory() )
+{
+System.err.println( "my.properties is missing or is a directory." );
+return false;
+}
+Properties properties = new Properties();
+FileInputStream fis = new FileInputStream( myProperties );
+properties.load( fis );
+fis.close();
+String property = properties.get( "my.property" );
+System.out.println( "my.property='" + property + "'" );
+if ( !"Characters that should be encoded in ISO-8859-1: åäö".equals( 
property ) )
+{
+System.err.println( "Non-ascii characters has wrong encoding after 
filtering" );
+return false;
+}
+
+File myfile = new File( target, "myfile.txt" );
+if ( !myfile.exists() || myfile.isDirectory() )
+{
+System.err.println( "myfile.txt is missing or is a directory." );
+return false;
+}
+FileInputStream fis = new FileInputStream ( myfile );
+String paramContent = IOUtil.toString ( fis, "UTF-8" );
+System.out.println( "content='" + paramContent + "'" );

Review Comment:
   Same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-war-plugin] dennisl commented on a diff in pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…

[GitBox]

dennisl commented on code in PR #22:
URL: https://github.com/apache/maven-war-plugin/pull/22#discussion_r853881940


##
src/it/MWAR-450/verify.bsh:
##
@@ -0,0 +1,94 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+File target = new File( basedir, "target/mwar450/WEB-INF/classes" );
+if ( !target.exists() || !target.isDirectory() )
+{
+System.err.println( "target/mwar450/WEB-INF/classes is missing or is 
not a directory." );
+return false;
+}
+
+// Load and check log4j.xml
+File log4jxml = new File( target, "log4j.xml" );
+if ( !log4jxml.exists() || log4jxml.isDirectory() )
+{
+System.err.println( "log4j.xml is missing or is a directory." );
+return false;
+}
+FileInputStream fis = new FileInputStream ( log4jxml );
+String paramContent = IOUtil.toString ( fis, "UTF-8" );
+System.out.println( "content='" + paramContent + "'" );
+int indexOf = paramContent.indexOf( "This file is encoded in UTF-8 and 
should remain so after filtering - åäö" );
+if ( indexOf < 0 )
+{
+  System.err.println( "Non-ascii characters changed encoding during 
filtering" );
+  return false;
+}
+
+// Load and check my.properties
+File myProperties = new File( target, "my.properties" );
+if ( !myProperties.exists() || myProperties.isDirectory() )
+{
+System.err.println( "my.properties is missing or is a directory." );
+return false;
+}
+Properties properties = new Properties();
+FileInputStream fis = new FileInputStream( myProperties );
+properties.load( fis );
+fis.close();
+String property = properties.get( "my.property" );
+System.out.println( "my.property='" + property + "'" );

Review Comment:
   Same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-war-plugin] dennisl commented on a diff in pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…

[GitBox]

dennisl commented on code in PR #22:
URL: https://github.com/apache/maven-war-plugin/pull/22#discussion_r853881671


##
src/it/MWAR-450/verify.bsh:
##
@@ -0,0 +1,94 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+File target = new File( basedir, "target/mwar450/WEB-INF/classes" );
+if ( !target.exists() || !target.isDirectory() )
+{
+System.err.println( "target/mwar450/WEB-INF/classes is missing or is 
not a directory." );
+return false;
+}
+
+// Load and check log4j.xml
+File log4jxml = new File( target, "log4j.xml" );
+if ( !log4jxml.exists() || log4jxml.isDirectory() )
+{
+System.err.println( "log4j.xml is missing or is a directory." );
+return false;
+}
+FileInputStream fis = new FileInputStream ( log4jxml );
+String paramContent = IOUtil.toString ( fis, "UTF-8" );
+System.out.println( "content='" + paramContent + "'" );

Review Comment:
   We have tried this on both Windows (CP-1252) and Linux (UTF-8), and the 
output from the integration test looks fine for us, without mangled characters. 
Which platform did you have problems on?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-war-plugin] dennisl commented on a diff in pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…

[GitBox]

dennisl commented on code in PR #22:
URL: https://github.com/apache/maven-war-plugin/pull/22#discussion_r853879086


##
src/it/MWAR-450/pom.xml:
##
@@ -0,0 +1,55 @@
+
+
+
+
+
+  4.0.0
+
+  org.apache.maven.its.war
+  mwar450
+  1.0-SNAPSHOT
+  war
+
+  
+UTF-8
+  
+
+  
+mwar450
+
+  
+org.apache.maven.plugins
+maven-war-plugin
+@project.version@
+
+  
+  ISO-8859-1
+  
+
+  WEB-INF/classes
+  true
+  src/main/webapp/WEB-INF/classes

Review Comment:
   No they don't in our use case. We like to separate our config files from our 
resources. This way the config files end up readable in the exploded war, 
instead of being packaged in the jar file of the project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-war-plugin] dennisl commented on a diff in pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…

[GitBox]

dennisl commented on code in PR #22:
URL: https://github.com/apache/maven-war-plugin/pull/22#discussion_r853876360


##
pom.xml:
##
@@ -118,7 +118,7 @@
 
   org.apache.maven.shared
   maven-shared-utils
-  3.2.1
+  3.3.3

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

[GitBox]

mthmulders commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1103590512

   > @mthmulders What was the reason that the only Java `1.8` was working in 
the old IT? I am just interested.
   
   At first, I thought (due to the original report in JIRA) that the problem 
only appeared when using module flags. So my test case mimicked that. But the 
test had a problem causing it to fail. Since the test was written to only run 
on Java 9 and above, it would always fail on Java 9+, but never run on Java 1.8 
- hence only 1.8 was green...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

[GitBox]

slawekjaranowski commented on PR #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-1103582231

   @Stephan202 , @vebits please drop a line on Maven dev list ... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

[GitBox]

michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r853812905


##
pom.xml:
##
@@ -101,6 +101,7 @@ under the License.
 2.3.2
 1.11.2
 3.8.2
+1.11.2-SNAPSHOT

Review Comment:
   Not required anymore.



##
pom.xml:
##
@@ -260,6 +261,7 @@ under the License.
   
 site
   
+  true

Review Comment:
   What does this change in this case?



##
pom.xml:
##
@@ -38,8 +38,8 @@ under the License.
   2011
 
   
-
scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git
-
scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git
+
scm:git:https://github.com/apache/maven-fluido-skin.git
+
scm:git:https://github.com/apache/maven-fluido-skin.git

Review Comment:
   The repos on ASF infra. Please drop this, it is unrelated to the issue.



##
src/site/apt/index.apt.vm:
##
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
 
 +-+
 
+** Matomo (i.e ApacheAnalytics)

Review Comment:
   e.g.,



##
src/site/apt/index.apt.vm:
##
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
 
 +-+
 
+** Matomo (i.e ApacheAnalytics)
+
+  Users can optionally enable <>.
+  How to configure it for Apache Analytics:

Review Comment:
   This sample doesn't actually show how to configure for Apache Analytics, 
values aren't filled.



##
src/it/mskins-177-apache-analytics/src/site/site.xml:
##
@@ -0,0 +1,54 @@
+
+
+
+
+http://maven.apache.org/DECORATION/1.1.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+  xsi:schemaLocation="http://maven.apache.org/DECORATION/1.1.0 
http://maven.apache.org/xsd/decoration-1.1.0.xsd";
+  name="${skinName}">
+
+  
+${skinGroupId}
+${skinArtifactId}
+${skinVersion}
+  
+
+  
+  
+
+  3
+  analytics.apache.org

Review Comment:
   Thats not a url, but rather a hostname. You should provide a full URL for 
maximun flexiblity.



##
src/main/resources/META-INF/maven/site.vm:
##
@@ -52,6 +52,11 @@
 #**##end
 #**##if( $headContent )$headContent#end
 #**##googleAnalytics( $decoration.googleAnalyticsAccountId )
+#**##if (  $decoration.getCustomValue( 'matomo.url' ) && 
$decoration.getCustomValue( 'matomo.url' ) != ''
+&& $decoration.getCustomValue( 'matomo.siteId' ) && 
$decoration.getCustomValue( 'matomo.siteId' ) != ''
+  )
+#*  *##matomo( $decoration.custom.getChild('matomo') )

Review Comment:
   This test should be pushed into the macro, just like here:
   
https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/META-INF/maven/site-macros.vm#L548-L570



##
src/it/mskins-177-apache-analytics/src/site/site.xml:
##
@@ -0,0 +1,54 @@
+
+
+
+
+http://maven.apache.org/DECORATION/1.1.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+  xsi:schemaLocation="http://maven.apache.org/DECORATION/1.1.0 
http://maven.apache.org/xsd/decoration-1.1.0.xsd";
+  name="${skinName}">
+
+  
+${skinGroupId}
+${skinArtifactId}
+${skinVersion}
+  
+
+  
+  
+
+  3
+  analytics.apache.org
+  
+
+
+
+Bar
+  
+

Review Comment:
   I like this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org