[GitHub] [maven-surefire] sbabcoc opened a new pull request, #528: SUREFIRE-2075: Only set thread count if specified in configuration
sbabcoc opened a new pull request, #528: URL: https://github.com/apache/maven-surefire/pull/528 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] olamy merged pull request #112: add release drafter configuration
olamy merged PR #112: URL: https://github.com/apache/maven-release/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] olamy opened a new pull request, #112: add release drafter configuration
olamy opened a new pull request, #112: URL: https://github.com/apache/maven-release/pull/112 Signed-off-by: Olivier Lamy Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-script-interpreter] dependabot[bot] opened a new pull request, #69: Bump maven-shared-components from 34 to 36
dependabot[bot] opened a new pull request, #69: URL: https://github.com/apache/maven-script-interpreter/pull/69 Bumps [maven-shared-components](https://github.com/apache/maven-parent) from 34 to 36. Release notes Sourced from https://github.com/apache/maven-parent/releases";>maven-shared-components's releases. 36 What's Changed [MPOM-300] switch from GA to ASF Matomo. by https://github.com/bmarwell";>@bmarwell in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 [MPOM-308] Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/59";>apache/maven-parent#59 Bump taglist-maven-plugin from 2.4 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/45";>apache/maven-parent#45 Bump maven-jxr-plugin from 3.1.1 to 3.2.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/60";>apache/maven-parent#60 [MPOM-313] execute checkstyle in early phase of the build by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 [MPOM-314] Upgrade modello-maven-plugin from 1.11 to 2.0.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/61";>apache/maven-parent#61 Bump apache from 25 to 26 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/62";>apache/maven-parent#62 New Contributors https://github.com/bmarwell";>@bmarwell made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 https://github.com/olamy";>@olamy made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 Full Changelog: https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36";>https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36 35 What's Changed docs: remove out of date comment by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-parent/pull/8";>apache/maven-parent#8 [MPOM-252] remove broken mail list archives by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-parent/pull/18";>apache/maven-parent#18 Bump plexus-utils from 3.1.0 to 3.3.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/13";>apache/maven-parent#13 Bump maven-toolchains-plugin from 1.1 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/10";>apache/maven-parent#10 Bump plexus-container-default from 1.0-alpha-30 to 2.1.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/11";>apache/maven-parent#11 Bump plexus-component-annotations from 2.0.0 to 2.1.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/15";>apache/maven-parent#15 Bump mavenPluginToolsVersion from 3.5.2 to 3.6.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/16";>apache/maven-parent#16 Bump modello-maven-plugin from 1.9.1 to 1.11 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/12";>apache/maven-parent#12 Bump maven-jxr-plugin from 2.5 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/9";>apache/maven-parent#9 Bump maven-pmd-plugin from 3.8 to 3.13.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/17";>apache/maven-parent#17 Bump maven-pmd-plugin from 3.14.0 to 3.15.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/28";>apache/maven-parent#28 [MPOM-268] - Removed unused property by https://github.com/khmarbaise";>@khmarbaise in https://github-redirect.dependabot.com/apache/maven-parent/pull/29";>apache/maven-parent#29 Bump mavenPluginToolsVersion from 3.6.0 to 3.6.1 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/25";>apache/maven-parent#25 [MPOM-270] Fix enforcer plugin by https://github.com/cstamas";>@cstamas in https://github-redirect.dependabot.com/apache/maven-parent/pull/32";>apache/maven-parent#32 [MPOM-271] Add "drop legacy dependencies" profile by https://github.
[GitHub] [maven-invoker-plugin] dependabot[bot] closed pull request #113: Bump mockito-core from 4.3.1 to 4.5.0
dependabot[bot] closed pull request #113: Bump mockito-core from 4.3.1 to 4.5.0 URL: https://github.com/apache/maven-invoker-plugin/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #115: Bump mockito-core from 4.3.1 to 4.5.1
dependabot[bot] opened a new pull request, #115: URL: https://github.com/apache/maven-invoker-plugin/pull/115 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.3.1 to 4.5.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.5.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.5.1 2022-04-21 - https://github.com/mockito/mockito/compare/v4.5.0...v4.5.1";>2 commit(s) by Jeremy Landis, dependabot[bot] Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>#2623: Use zulu distribution and java 11 for release GHA job [(https://github-redirect.dependabot.com/mockito/mockito/issues/2624";>#2624)](https://github-redirect.dependabot.com/mockito/mockito/pull/2624";>mockito/mockito#2624) Missing errorprone module for 4.5.0 in central as release was done with jdk 8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>#2623)](https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>mockito/mockito#2623) Bump kotlinVersion from 1.6.20 to 1.6.21 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2622";>#2622)](https://github-redirect.dependabot.com/mockito/mockito/pull/2622";>mockito/mockito#2622) Missing net.bytebuddy.utility.GraalImageCode exception If you encounter any issues with missing ByteBuddy classes, make sure you are using ByteBuddy 1.12 or higher. v4.5.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.5.0 2022-04-19 - https://github.com/mockito/mockito/compare/v4.4.0...v4.5.0";>15 commit(s) by Andrei Silviu Dragnea, Rafael Winterhalter, Rick Ossendrijver, dependabot[bot] Bump versions.errorprone from 2.13.0 to 2.13.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2621";>#2621)](https://github-redirect.dependabot.com/mockito/mockito/pull/2621";>mockito/mockito#2621) Bump versions.errorprone from 2.12.1 to 2.13.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2619";>#2619)](https://github-redirect.dependabot.com/mockito/mockito/pull/2619";>mockito/mockito#2619) Groovy inline [(https://github-redirect.dependabot.com/mockito/mockito/issues/2618";>#2618)](https://github-redirect.dependabot.com/mockito/mockito/pull/2618";>mockito/mockito#2618) Bump actions/setup-java from 2 to 3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2615";>#2615)](https://github-redirect.dependabot.com/mockito/mockito/pull/2615";>mockito/mockito#2615) Bump versions.bytebuddy from 1.12.8 to 1.12.9 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2614";>#2614)](https://github-redirect.dependabot.com/mockito/mockito/pull/2614";>mockito/mockito#2614) Support subclass mocks on Graal VM. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2613";>#2613)](https://github-redirect.dependabot.com/mockito/mockito/pull/2613";>mockito/mockito#2613) Bump com.diffplug.spotless from 6.4.1 to 6.4.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2611";>#2611)](https://github-redirect.dependabot.com/mockito/mockito/pull/2611";>mockito/mockito#2611) Bump kotlinx-coroutines-core from 1.6.0-native-mt to 1.6.1-native-mt [(https://github-redirect.dependabot.com/mockito/mockito/issues/2609";>#2609)](https://github-redirect.dependabot.com/mockito/mockito/pull/2609";>mockito/mockito#2609) Bump versions.errorprone from 2.10.0 to 2.12.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2608";>#2608)](https://github-redirect.dependabot.com/mockito/mockito/pull/2608";>mockito/mockito#2608) Bump kotlinVersion from 1.6.10 to 1.6.20 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2607";>#2607)](https://github-redirect.dependabot.com/mockito/mockito/pull/2607";>mockito/mockito#2607) Bump com.diffplug.spotless from 6.4.0 to 6.4.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2606";>#2606)](https://github-redirect.dependabot.com/mockito/mockito/pull/2606";>mockito/mockito#2606) Bump com.diffplug.spotless from 6.3.0 to 6.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2605";>#2605)](https://github-redirect.dependabot.com/mockito/mockito/pull/2605";>mockito/mockito#2605) Bump org.eclipse.osgi from 3.17.100 to 3.17.200 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2597";>#2597)](https://github-redirect.dependabot.com/mockito/mockito/pull/2597";>mockito/mockito#2597) Deprecate ListUtil and Fields classes [(https://github-redirect.dependabot.com/mockito/mockito/issues/2593";>#2593)](https://github-redirect.dependabot.com/mockito/mockito/pull/2593";>mockito/mockito#2593) mockito-errorprone seems not compatible with ErrorProne 2.11.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2554";>#2554)](https://github-redirect.dependabot.c
[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #113: Bump mockito-core from 4.3.1 to 4.5.0
dependabot[bot] commented on PR #113: URL: https://github.com/apache/maven-invoker-plugin/pull/113#issuecomment-1108091519 Superseded by #115. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #95: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2
dependabot[bot] closed pull request #95: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2 URL: https://github.com/apache/maven-jlink-plugin/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #95: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2
dependabot[bot] commented on PR #95: URL: https://github.com/apache/maven-jlink-plugin/pull/95#issuecomment-1108088464 Superseded by #105. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #105: Bump maven-javadoc-plugin from 3.3.1 to 3.4.0
dependabot[bot] opened a new pull request, #105: URL: https://github.com/apache/maven-jlink-plugin/pull/105 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.1 to 3.4.0. Release notes Sourced from https://github.com/apache/maven-javadoc-plugin/releases";>maven-javadoc-plugin's releases. 3.3.2 What's Changed [MJAVADOC-530] - Clean up additionalparam documentation by https://github.com/marschall";>@marschall in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/6";>apache/maven-javadoc-plugin#6 [MJAVADOC-538] Filter out 'Picked up' by https://github.com/risdenk";>@risdenk in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/11";>apache/maven-javadoc-plugin#11 [MJAVADOC-546] Allow to generate report in Spanish locale by https://github.com/belingueres";>@belingueres in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/12";>apache/maven-javadoc-plugin#12 [MJAVADOC-537] Explicitly the batchMode to true by https://github.com/joshiste";>@joshiste in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/7";>apache/maven-javadoc-plugin#7 fix mailing list url in README by https://github.com/rgdoliveira";>@rgdoliveira in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/13";>apache/maven-javadoc-plugin#13 [MJAVADOC-544] - Changed behaviour of Javadoc for temporary files encoding (options, argfile, ...) by https://github.com/michael-st";>@michael-st in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/10";>apache/maven-javadoc-plugin#10 [MJAVADOC-444] add aggregate-no-fork and aggregate-test-no-fork for non-forking versions of aggregate goals. by https://github.com/busbey";>@busbey in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/2";>apache/maven-javadoc-plugin#2 Avoid converting separator characters into newline. by https://github.com/cowwoc";>@cowwoc in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/19";>apache/maven-javadoc-plugin#19 [MJAVADOC-577] Fixed typos in User Guide. by https://github.com/glqdlt";>@glqdlt in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/20";>apache/maven-javadoc-plugin#20 Fix typo in additionalDependencies documentation by https://github.com/britter";>@britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/23";>apache/maven-javadoc-plugin#23 Add missing @since tags to sourceFile[Includes|Excludes] by https://github.com/britter";>@britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/24";>apache/maven-javadoc-plugin#24 Added example of --add-modules to aggregate FAQ. by https://github.com/cowwoc";>@cowwoc in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/18";>apache/maven-javadoc-plugin#18 Remove space typo in markdown by https://github.com/nrbw";>@nrbw in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/29";>apache/maven-javadoc-plugin#29 [MJAVADOC-620] Do not ignore JARs w/o module info when building classpath by https://github.com/fwienber";>@fwienber in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/35";>apache/maven-javadoc-plugin#35 [MJAVADOC-626] Add a stale javadoc detection mechanism by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/33";>apache/maven-javadoc-plugin#33 [MJAVADOC-613] exclude skipped modules from javadoc aggregate by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/36";>apache/maven-javadoc-plugin#36 [MJAVADOC-636] exclude some modules from aggregated javadoc by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/37";>apache/maven-javadoc-plugin#37 [MJAVADOC-639] include requires static from external dependencies for all modules by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/38";>apache/maven-javadoc-plugin#38 [MJAVADOC-638] upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/39";>apache/maven-javadoc-plugin#39 MJAVADOC-610 by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/40";>apache/maven-javadoc-plugin#40 [MJAVADOC-644] Properly close DirectoryStream by https://github.com/britter";>@britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/41";>apache/maven-javadoc-plugin#41 update qdox by https://github.com/elharo";>@elharo in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/42";>apache/maven-javadoc-plug
[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #80: Bump maven-site-plugin from 3.11.0 to 3.12.0
dependabot[bot] opened a new pull request, #80: URL: https://github.com/apache/maven-apache-parent/pull/80 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.11.0 to 3.12.0. Commits https://github.com/apache/maven-site-plugin/commit/8c597d8db03633feb010cacb2a036b1cceb29aee";>8c597d8 [maven-release-plugin] prepare release maven-site-plugin-3.12.0 https://github.com/apache/maven-site-plugin/commit/32be6ad8b99916dec6f908484f2d690044bf0b47";>32be6ad [MSITE-888] Upgrade to Maven 3.2.5 https://github.com/apache/maven-site-plugin/commit/bf434e5d0e37ce85392a96587ad2f4ec58c63641";>bf434e5 [MSITE-891] Upgrade plugins in ITs https://github.com/apache/maven-site-plugin/commit/5f10ad146fec988f892a56b82b83e5c41ede3604";>5f10ad1 [MSITE-890] Upgrade Jetty to 9.4.46.v20220331 https://github.com/apache/maven-site-plugin/commit/606a327097202f3f90bfd60e66a7c4cb6a53d004";>606a327 [MSITE-857] Jetty engine fails to resolve web.xml DTD behind corporate proxy https://github.com/apache/maven-site-plugin/commit/522eddd70e4b822d8a14eba845c94b3f88edef7e";>522eddd [MSITE-889] Upgrade Plexus Utils to 3.3.1 https://github.com/apache/maven-site-plugin/commit/d1bfb429cc41a79fbbeaed3fa725fbcb9cd9285d";>d1bfb42 [MSITE-887] Deprecate templateFile parameter https://github.com/apache/maven-site-plugin/commit/6c42df388a5b8f50fe6e35ec4d74cb5981a13831";>6c42df3 Add undeclared dependency https://github.com/apache/maven-site-plugin/commit/73df7bb9e0f9c2e421e79a8733302d557fa1b0ad";>73df7bb Remove unused properties https://github.com/apache/maven-site-plugin/commit/7a3ed19c5ff6339615b997d97dcfbae926dfbad1";>7a3ed19 [MSITE-886] Upgrade Maven Wagon to 3.5.1 Additional commits viewable in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.11.0...maven-site-plugin-3.12.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-site] dependabot[bot] opened a new pull request, #19: Bump maven-pdf-plugin from 1.5.1 to 1.6.0
dependabot[bot] opened a new pull request, #19: URL: https://github.com/apache/maven-doxia-site/pull/19 Bumps [maven-pdf-plugin](https://github.com/apache/maven-pdf-plugin) from 1.5.1 to 1.6.0. Commits https://github.com/apache/maven-pdf-plugin/commit/45d1d872064e0c4ae9d7a2029fd0734fe3bdde7a";>45d1d87 [maven-release-plugin] prepare release maven-pdf-plugin-1.6.0 https://github.com/apache/maven-pdf-plugin/commit/80eaf0ede5ad96ea77b8ce12400ca9dda77c4142";>80eaf0e [MPDF-103] Upgrade plugins in ITs https://github.com/apache/maven-pdf-plugin/commit/f9c3095ddee783de18da3ff0ee230ebd8b09ba06";>f9c3095 [MPDF-102] Upgrade Maven Plugin Plugin to 3.6.4 https://github.com/apache/maven-pdf-plugin/commit/dcc0e620721ba817e0d9817dbcfdc881d687e672";>dcc0e62 Clean up dependencies https://github.com/apache/maven-pdf-plugin/commit/633df598fec78fbaf6281f6ac8add33957032090";>633df59 [MPDF-101] Upgrade Maven to 3.2.5 https://github.com/apache/maven-pdf-plugin/commit/8f89c50d3144b49401f94607f6ea19c30878eb97";>8f89c50 [MPDF-100] Remove remains of org.codehaus.doxia.sink.Sink https://github.com/apache/maven-pdf-plugin/commit/24f4b73f2fe256e085f8a48f67e91d49c0fa6e1a";>24f4b73 Update CI URL https://github.com/apache/maven-pdf-plugin/commit/c8d7d283c94699b55901bba13916cb7665a5d270";>c8d7d28 Bump maven-reporting-exec from 1.5.1 to 1.6.0 https://github.com/apache/maven-pdf-plugin/commit/7f4409b650dfba1d5902a33ad9ca44015fd95d16";>7f4409b Bump maven-reporting-api from 3.0 to 3.1.0 https://github.com/apache/maven-pdf-plugin/commit/85648ff27fcf5d5898b19e6233f9a4dad00320d9";>85648ff Bump maven-reporting-impl from 3.0.0 to 3.1.0 Additional commits viewable in https://github.com/apache/maven-pdf-plugin/compare/maven-pdf-plugin-1.5.1...maven-pdf-plugin-1.6.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] dependabot[bot] opened a new pull request, #26: Bump doxia-tools from 35 to 36
dependabot[bot] opened a new pull request, #26: URL: https://github.com/apache/maven-doxia-converter/pull/26 Bumps [doxia-tools](https://github.com/apache/maven-parent) from 35 to 36. Release notes Sourced from https://github.com/apache/maven-parent/releases";>doxia-tools's releases. 36 What's Changed [MPOM-300] switch from GA to ASF Matomo. by https://github.com/bmarwell";>@bmarwell in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 [MPOM-308] Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/59";>apache/maven-parent#59 Bump taglist-maven-plugin from 2.4 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/45";>apache/maven-parent#45 Bump maven-jxr-plugin from 3.1.1 to 3.2.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/60";>apache/maven-parent#60 [MPOM-313] execute checkstyle in early phase of the build by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 [MPOM-314] Upgrade modello-maven-plugin from 1.11 to 2.0.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/61";>apache/maven-parent#61 Bump apache from 25 to 26 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/62";>apache/maven-parent#62 New Contributors https://github.com/bmarwell";>@bmarwell made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 https://github.com/olamy";>@olamy made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 Full Changelog: https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36";>https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36 Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-site] dependabot[bot] opened a new pull request, #18: Bump maven-parent from 36-SNAPSHOT to 36
dependabot[bot] opened a new pull request, #18: URL: https://github.com/apache/maven-doxia-site/pull/18 Bumps [maven-parent](https://github.com/apache/maven-parent) from 36-SNAPSHOT to 36. Release notes Sourced from https://github.com/apache/maven-parent/releases";>maven-parent's releases. 36 What's Changed [MPOM-300] switch from GA to ASF Matomo. by https://github.com/bmarwell";>@bmarwell in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 [MPOM-308] Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/59";>apache/maven-parent#59 Bump taglist-maven-plugin from 2.4 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/45";>apache/maven-parent#45 Bump maven-jxr-plugin from 3.1.1 to 3.2.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/60";>apache/maven-parent#60 [MPOM-313] execute checkstyle in early phase of the build by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 [MPOM-314] Upgrade modello-maven-plugin from 1.11 to 2.0.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/61";>apache/maven-parent#61 Bump apache from 25 to 26 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/62";>apache/maven-parent#62 New Contributors https://github.com/bmarwell";>@bmarwell made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 https://github.com/olamy";>@olamy made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 Full Changelog: https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36";>https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36 Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wrapper] dependabot[bot] opened a new pull request, #39: Bump maven-parent from 35 to 36
dependabot[bot] opened a new pull request, #39: URL: https://github.com/apache/maven-wrapper/pull/39 Bumps [maven-parent](https://github.com/apache/maven-parent) from 35 to 36. Release notes Sourced from https://github.com/apache/maven-parent/releases";>maven-parent's releases. 36 What's Changed [MPOM-300] switch from GA to ASF Matomo. by https://github.com/bmarwell";>@bmarwell in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 [MPOM-308] Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/59";>apache/maven-parent#59 Bump taglist-maven-plugin from 2.4 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/45";>apache/maven-parent#45 Bump maven-jxr-plugin from 3.1.1 to 3.2.0 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/60";>apache/maven-parent#60 [MPOM-313] execute checkstyle in early phase of the build by https://github.com/olamy";>@olamy in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 [MPOM-314] Upgrade modello-maven-plugin from 1.11 to 2.0.0 by https://github.com/slawekjaranowski";>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/61";>apache/maven-parent#61 Bump apache from 25 to 26 by https://github.com/dependabot";>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/62";>apache/maven-parent#62 New Contributors https://github.com/bmarwell";>@bmarwell made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/58";>apache/maven-parent#58 https://github.com/olamy";>@olamy made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/55";>apache/maven-parent#55 Full Changelog: https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36";>https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36 Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] basil commented on pull request #506: [SUREFIRE-2056] BufferOverflowException when encoding message with null testId
basil commented on PR #506: URL: https://github.com/apache/maven-surefire/pull/506#issuecomment-1107958413 I have hit this issue upgrading various Jenkins plugins to M6, especially when the tests write to standard out. I have been able to work around it by avoiding the use of standard out from tests, but it would be nice to have a fix released. I would hate to have to revert the whole Jenkins plugin ecosystem back to M5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] mthmulders commented on a diff in pull request #527: [SUREFIRE-2063] Allow consecutive spaces in argLine
mthmulders commented on code in PR #527: URL: https://github.com/apache/maven-surefire/pull/527#discussion_r857172932 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/DefaultForkConfiguration.java: ## @@ -251,9 +251,9 @@ private String interpolateArgLineWithPropertyExpressions() } @Nonnull -private static String stripWhitespace( @Nonnull String argLine ) +static String stripWhitespace( @Nonnull String argLine ) Review Comment: Ah, well, I thought about doing that, but eventually refrained from it. I'll revert the visibility change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
michael-o commented on code in PR #168: URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857172821 ## src/site/markdown/configuration.md: ## @@ -47,6 +47,15 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.dependencyCollector.impl` | String | The name of the dependency collector implementation to use: depth-first (original) named `df`, and breadth-first (new in 1.8.0) named `bf`. Both collectors produce equivalent results, but they may differ performance wise, depending on project being applied to. Our experience shows that existing `df` is well suited for smaller to medium size projects, while `bf` may perform better on huge projects with many dependencies. Experiment (and come back to us!) to figure out which one suits you the better. | `"df"` | no `aether.dependencyCollector.bf.skipper` | boolean | Flag controlling whether to skip resolving duplicate/conflicting nodes during the breadth-first (`bf`) dependency collection process. | `true` | no `aether.dependencyManager.verbose` | boolean | Flag controlling the verbose mode for dependency management. If enabled, the original attributes of a dependency before its update due to dependency managemnent will be recorded in the node's `DependencyNode#getData()` when building a dependency graph. | `false` | no +`aether.enhancedLocalRepository.localPrefix` | String | The prefix to use for locally installed artifacts. | `"installed"` | no +`aether.enhancedLocalRepository.snapshotPrefix` | String | The prefix to use for snapshot artifacts. | `"snapshot"` | no +`aether.enhancedLocalRepository.split` | boolean | Whether LRM should split local and remote artifacts. | `false` | no +`aether.enhancedLocalRepository.splitLocal` | boolean | Whether locally installed artifacts should be split by version (release/snapshot). | `false` | no +`aether.enhancedLocalRepository.splitRemote` | boolean | Whether cached artifacts should be split by version (release/snapshot). | `false` | no +`aether.enhancedLocalRepository.splitRemoteRepository` | boolean | Whether cached artifacts should be split by origin repository (repository ID). | `false` | no +`aether.enhancedLocalRepository.splitRemoteRepositoryLast` | boolean | For cached artifacts, if both `splitRemote` and `splitRemoteRepository` are set to `true` sets the splitting order: by default it is repositoryId/version (false) or version/repositoryId (true) | `false` | no +`aether.enhancedLocalRepository.remotePrefix` | String | The prefix to use for downloaded and cached artifacts. | `"cached"` | no +`aether.enhancedLocalRepository.releasePrefix` | String | The prefix to use for release artifacts. | `"release"` | no Review Comment: As in the linked Maven issues, those should be truly plural: `snapshots` and `releases`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
michael-o commented on code in PR #168:
URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857172735
##
maven-resolver-api/src/main/java/org/eclipse/aether/artifact/AbstractArtifact.java:
##
@@ -43,9 +43,12 @@ public boolean isSnapshot()
return isSnapshot( getVersion() );
}
-private static boolean isSnapshot( String version )
+/**
+ * Returns {@code true} if passed in artifact version is a snapshot
version.
+ */
+public static boolean isSnapshot( String version )
{
-return version.endsWith( SNAPSHOT ) || SNAPSHOT_TIMESTAMP.matcher(
version ).matches();
+return version != null && ( version.endsWith( SNAPSHOT ) ||
SNAPSHOT_TIMESTAMP.matcher( version ).matches() );
Review Comment:
Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] pzygielo commented on a diff in pull request #527: [SUREFIRE-2063] Allow consecutive spaces in argLine
pzygielo commented on code in PR #527: URL: https://github.com/apache/maven-surefire/pull/527#discussion_r857172458 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/DefaultForkConfiguration.java: ## @@ -251,9 +251,9 @@ private String interpolateArgLineWithPropertyExpressions() } @Nonnull -private static String stripWhitespace( @Nonnull String argLine ) +static String stripWhitespace( @Nonnull String argLine ) Review Comment: With this access change I expected to see plenty of new UTs - but there is none committed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
cstamas commented on code in PR #168:
URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857163820
##
maven-resolver-api/src/main/java/org/eclipse/aether/artifact/AbstractArtifact.java:
##
@@ -43,9 +43,12 @@ public boolean isSnapshot()
return isSnapshot( getVersion() );
}
-private static boolean isSnapshot( String version )
+/**
+ * Returns {@code true} if passed in artifact version is a snapshot
version.
+ */
+public static boolean isSnapshot( String version )
{
-return version.endsWith( SNAPSHOT ) || SNAPSHOT_TIMESTAMP.matcher(
version ).matches();
+return version != null && ( version.endsWith( SNAPSHOT ) ||
SNAPSHOT_TIMESTAMP.matcher( version ).matches() );
Review Comment:
This is method that was private before and made it now public, so I added
here nullcheck as parameter is string, so nulcheck is better for robustness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
michael-o commented on code in PR #168:
URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857161165
##
src/site/markdown/local-repository.md:
##
@@ -83,6 +83,12 @@ need to re-download the "whole universe". Similarly,
deletion of cached ones
can happen based even on origin repository (if split by remote repository
was enabled beforehand).
+Example configuration with split by remote repository:
+```java
+$ mvn ... -Daether.enhancedLocalRepository.split=true \
+ -Daether.enhancedLocalRepository.splitRemoteRepository=true
Review Comment:
According to my tests even `=true` is not necessary and implied by the system
##
src/site/markdown/local-repository.md:
##
@@ -91,12 +97,21 @@ would constantly overwrite each other. It was easy to get
into "false error"
state, where partial overlapping content were present in local repository from
different branches. Today, one can just define unique "local prefix" for each
branch it is working on (or even by project, like
-`-Daether.enhancedLocalRepository.localPrefix=${project}/${branch}`) and the
+`-Daether.enhancedLocalRepository.localPrefix=$PROJECT/$BRANCH`, but use
+actual values, these expressions are merely example, there is no interpolation
Review Comment:
an exmaple
##
src/site/markdown/local-repository.md:
##
@@ -91,12 +97,21 @@ would constantly overwrite each other. It was easy to get
into "false error"
state, where partial overlapping content were present in local repository from
different branches. Today, one can just define unique "local prefix" for each
branch it is working on (or even by project, like
-`-Daether.enhancedLocalRepository.localPrefix=${project}/${branch}`) and the
+`-Daether.enhancedLocalRepository.localPrefix=$PROJECT/$BRANCH`, but use
+actual values, these expressions are merely example, there is no interpolation
+happening!) and the
local repository becomes usable even simultaneously, even concurrently from
different terminals, as different projects and their branches can simply
coexist in local repository. They will land in different places, due different
prefixes.
+Example configuration for branches:
+```java
+$ mvn ... -Daether.enhancedLocalRepository.split=true \
+
-Daether.enhancedLocalRepository.localPrefix=maven-resolver/mresolver-253
+ -Daether.enhancedLocalRepository.splitRemoteRepository=true
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
michael-o commented on code in PR #168: URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857159731 ## src/site/markdown/local-repository.md: ## @@ -0,0 +1,116 @@ +# Local Repository + + +Maven Resolver implements "local repository" (that is used by Maven itself +as well), that since the beginning of time was "mixed bag of beans", +it served twofold purposes: to "cache" the artifacts downloaded from Review Comment: drop quotes ## src/site/markdown/local-repository.md: ## @@ -0,0 +1,116 @@ +# Local Repository + + +Maven Resolver implements "local repository" (that is used by Maven itself +as well), that since the beginning of time was "mixed bag of beans", +it served twofold purposes: to "cache" the artifacts downloaded from +remote, but also to "host" the artifacts locally installed (locally built and +installed, to be more precise). Both of these artifacts were stored in bulk +in local repository. + +Local repository implementations implement the `LocalRepositoryManager` (LRM) +interface, and resolver out of the box provides two implementations for it: +"simple" and "enhanced". + +## Simple LRM + +Simple is fully functional LRM implementation, but is used +mainly in tests, is not recommended in production environments. + +To manually instantiate a simple LRM, one needs to invoke following code: + +```java +LocalRepositoryManager simple = new SimpleLocalRepositoryManagerFactory() +.newInstance( session, new LocalRepository( baseDir ) ); +``` + +Note: this code snippet above instantiates a component, that is not +recommended way to use it, as it should be rather injected whenever possible. +This example above is merely a showcase how to obtain LRM implementation +in unit tests. + +## Enhanced LRM + +Enhanced LRM on the other hand is "enhanced" with several extra Review Comment: drop quotes ## src/site/markdown/local-repository.md: ## @@ -0,0 +1,116 @@ +# Local Repository + + +Maven Resolver implements "local repository" (that is used by Maven itself +as well), that since the beginning of time was "mixed bag of beans", +it served twofold purposes: to "cache" the artifacts downloaded from +remote, but also to "host" the artifacts locally installed (locally built and +installed, to be more precise). Both of these artifacts were stored in bulk +in local repository. + +Local repository implementations implement the `LocalRepositoryManager` (LRM) +interface, and resolver out of the box provides two implementations for it: +"simple" and "enhanced". + +## Simple LRM + +Simple is fully functional LRM implementation, but is used +mainly in tests, is not recommended in production environments. + +To manually instantiate a simple LRM, one needs to invoke following code: + +```java +LocalRepositoryManager simple = new SimpleLocalRepositoryManagerFactory() +.newInstance( session, new LocalRepository( baseDir ) ); +``` + +Note: this code snippet above instantiates a component, that is not +recommended way to use it, as it should be rather injected whenever possible. +This example above is merely a showcase how to obtain LRM implementation +in unit tests. + +## Enhanced LRM + +Enhanced LRM on the other hand is "enhanced" with several extra +features, one most notable is scoping cached content by its origin and context: +if you downloaded an artifact A1 from repository R1 +and later initiate build that requires same artifact A1, but repository R1 +is not defined in build, the A1 artifact cached from R1 remote repository should be handled +as not present, and needs to be re-downloaded, despite same coordinates. +Those two, originating from two different repositories may not be the same thing. +This is meant to protect users from "bad practice" (artifact coordinates are +unique in ideal world). + +### Split local repository + +Latest addition to enhanced LRM is "split" feature. By default, "split" +feature is **not enabled**, enhanced LRM behaves as it behaved in all +previous versions of resolver. + +Enhanced LRM is able to split the content of local repository by +several conditions: + +* differentiate between "cached" and locally "installed" artifacts +* differentiate "cached" artifacts based on their origin (remote repository) +* differentiate between "release" and "snapshot" versioned artifacts + +The "split" feature is implemented by `LocalPathPrefixComposer` interface, +that adds different "prefixes" for the locally stored artifacts, based on +their context. + + Use cases + +Most direct use case is simpler local repository eviction. One can delete all +its own locally built artifacts without deleting the cached ones, hence, no +need to re-download the "whole universe". Similarly, deletion of cached ones +can happen based even on origin repository (if split by remote repository +was enabled beforehand). + +Another use case is interesting for "branched development". Before, split fe
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
cstamas commented on code in PR #168: URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857159935 ## src/site/markdown/configuration.md: ## @@ -47,6 +47,15 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.dependencyCollector.impl` | String | The name of the dependency collector implementation to use: depth-first (original) named `df`, and breadth-first (new in 1.8.0) named `bf`. Both collectors produce equivalent results, but they may differ performance wise, depending on project being applied to. Our experience shows that existing `df` is well suited for smaller to medium size projects, while `bf` may perform better on huge projects with many dependencies. Experiment (and come back to us!) to figure out which one suits you the better. | `"df"` | no `aether.dependencyCollector.bf.skipper` | boolean | Flag controlling whether to skip resolving duplicate/conflicting nodes during the breadth-first (`bf`) dependency collection process. | `true` | no `aether.dependencyManager.verbose` | boolean | Flag controlling the verbose mode for dependency management. If enabled, the original attributes of a dependency before its update due to dependency managemnent will be recorded in the node's `DependencyNode#getData()` when building a dependency graph. | `false` | no +`aether.enhancedLocalRepository.localPrefix` | String | The prefix to use for locally installed artifacts. | `"installed"` | no +`aether.enhancedLocalRepository.snapshotPrefix` | String | The prefix to use for snapshot artifacts. | `"snapshot"` | no +`aether.enhancedLocalRepository.split` | boolean | Whether LRM should split local and remote artifacts. | `false` | no +`aether.enhancedLocalRepository.splitLocal` | boolean | Whether locally installed artifacts should be split by version (release/snapshot). | `false` | no +`aether.enhancedLocalRepository.splitRemote` | boolean | Whether cached artifacts should be split by version (release/snapshot). | `false` | no +`aether.enhancedLocalRepository.splitRemoteRepository` | boolean | Whether cached artifacts should be split by origin repository (repository ID). | `false` | no +`aether.enhancedLocalRepository.splitRemoteRepositoryLast` | boolean | For cached artifacts, if both `splitRemote` and `splitRemoteRepository` are set to `true` sets the splitting order: by default it is repositoryId/version (false) or version/repositoryId (true) | `false` | no Review Comment: Having ability to get `cached/repo/release` (false, default) vs `cached/release/repo` (true)? It depends who wants what: default will put all coming from one subdirectory (repo), while non-default may "spread" stuff coming dependending is artifact release or snapshot (as repo may have both enabled, that is completely valid). I find it useful, as the way you may want split may depend on why you want split, what is your use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
michael-o commented on code in PR #168:
URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857159430
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/LocalPathPrefixComposerFactorySupport.java:
##
@@ -0,0 +1,178 @@
+package org.eclipse.aether.internal.impl;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.AbstractArtifact;
+import org.eclipse.aether.metadata.Metadata;
+import org.eclipse.aether.util.ConfigUtils;
+
+/**
+ * Support class for {@link LocalPathPrefixComposerFactory} implementations:
it predefines and makes re-usable
+ * common configuration getters, and defines a support class for {@link
LocalPathPrefixComposer} carrying same.
+ *
+ * @since TBD
+ */
+public abstract class LocalPathPrefixComposerFactorySupport implements
LocalPathPrefixComposerFactory
+{
+private static final String CONF_PROP_SPLIT =
"aether.enhancedLocalRepository.split";
+
+private static final boolean DEFAULT_SPLIT = false;
+private static final String CONF_PROP_LOCAL_PREFIX =
"aether.enhancedLocalRepository.localPrefix";
+
+private static final String DEFAULT_LOCAL_PREFIX = "installed";
+
+private static final String CONF_PROP_SPLIT_LOCAL =
"aether.enhancedLocalRepository.splitLocal";
+
+private static final boolean DEFAULT_SPLIT_LOCAL = false;
+
+private static final String CONF_PROP_REMOTE_PREFIX =
"aether.enhancedLocalRepository.remotePrefix";
+
+private static final String DEFAULT_REMOTE_PREFIX = "cached";
+
+private static final String CONF_PROP_SPLIT_REMOTE =
"aether.enhancedLocalRepository.splitRemote";
+
+private static final boolean DEFAULT_SPLIT_REMOTE = false;
+
+private static final String CONF_PROP_SPLIT_REMOTE_REPOSITORY =
+"aether.enhancedLocalRepository.splitRemoteRepository";
+
+private static final boolean DEFAULT_SPLIT_REMOTE_REPOSITORY = false;
+
+private static final String CONF_PROP_SPLIT_REMOTE_REPOSITORY_LAST =
+"aether.enhancedLocalRepository.splitRemoteRepositoryLast";
+
+private static final boolean DEFAULT_SPLIT_REMOTE_REPOSITORY_LAST = false;
+
+private static final String CONF_PROP_RELEASE_PREFIX =
"aether.enhancedLocalRepository.releasePrefix";
+
+private static final String DEFAULT_RELEASE_PREFIX = "release";
+
+private static final String CONF_PROP_SNAPSHOT_PREFIX =
"aether.enhancedLocalRepository.snapshotPrefix";
+
+private static final String DEFAULT_SNAPSHOT_PREFIX = "snapshot";
+
+protected boolean isSplit( RepositorySystemSession session )
+{
+return ConfigUtils.getBoolean(
+session, DEFAULT_SPLIT, CONF_PROP_SPLIT );
+}
+
+protected String getLocalPrefix( RepositorySystemSession session )
+{
+return ConfigUtils.getString(
+session, DEFAULT_LOCAL_PREFIX, CONF_PROP_LOCAL_PREFIX );
+}
+
+protected boolean isSplitLocal( RepositorySystemSession session )
+{
+return ConfigUtils.getBoolean(
+session, DEFAULT_SPLIT_LOCAL, CONF_PROP_SPLIT_LOCAL );
+}
+
+protected String getRemotePrefix( RepositorySystemSession session )
+{
+return ConfigUtils.getString(
+session, DEFAULT_REMOTE_PREFIX, CONF_PROP_REMOTE_PREFIX );
+}
+
+protected boolean isSplitRemote( RepositorySystemSession session )
+{
+return ConfigUtils.getBoolean(
+session, DEFAULT_SPLIT_REMOTE, CONF_PROP_SPLIT_REMOTE );
+}
+
+protected boolean isSplitRemoteRepository( RepositorySystemSession session
)
+{
+return ConfigUtils.getBoolean(
+session, DEFAULT_SPLIT_REMOTE_REPOSITORY,
CONF_PROP_SPLIT_REMOTE_REPOSITORY );
+}
+
+protected boolean isSplitRemoteRepositoryLast( RepositorySystemSession
session )
+{
+return ConfigUtils.getBoolean(
+session, DEFAULT_SPLIT_REMOTE_REPOSITORY_LAST,
CONF_PROP_SPLIT_REMOTE_REPOSITORY_LAST );
+}
+
+protected String getReleasePrefix( RepositorySystemSession session )
+{
+return ConfigUtils.getString(
+session, DEFAULT
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
michael-o commented on code in PR #168: URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857159138 ## src/site/markdown/configuration.md: ## @@ -47,6 +47,15 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.dependencyCollector.impl` | String | The name of the dependency collector implementation to use: depth-first (original) named `df`, and breadth-first (new in 1.8.0) named `bf`. Both collectors produce equivalent results, but they may differ performance wise, depending on project being applied to. Our experience shows that existing `df` is well suited for smaller to medium size projects, while `bf` may perform better on huge projects with many dependencies. Experiment (and come back to us!) to figure out which one suits you the better. | `"df"` | no `aether.dependencyCollector.bf.skipper` | boolean | Flag controlling whether to skip resolving duplicate/conflicting nodes during the breadth-first (`bf`) dependency collection process. | `true` | no `aether.dependencyManager.verbose` | boolean | Flag controlling the verbose mode for dependency management. If enabled, the original attributes of a dependency before its update due to dependency managemnent will be recorded in the node's `DependencyNode#getData()` when building a dependency graph. | `false` | no +`aether.enhancedLocalRepository.localPrefix` | String | The prefix to use for locally installed artifacts. | `"installed"` | no +`aether.enhancedLocalRepository.snapshotPrefix` | String | The prefix to use for snapshot artifacts. | `"snapshot"` | no +`aether.enhancedLocalRepository.split` | boolean | Whether LRM should split local and remote artifacts. | `false` | no +`aether.enhancedLocalRepository.splitLocal` | boolean | Whether locally installed artifacts should be split by version (release/snapshot). | `false` | no +`aether.enhancedLocalRepository.splitRemote` | boolean | Whether cached artifacts should be split by version (release/snapshot). | `false` | no +`aether.enhancedLocalRepository.splitRemoteRepository` | boolean | Whether cached artifacts should be split by origin repository (repository ID). | `false` | no +`aether.enhancedLocalRepository.splitRemoteRepositoryLast` | boolean | For cached artifacts, if both `splitRemote` and `splitRemoteRepository` are set to `true` sets the splitting order: by default it is repositoryId/version (false) or version/repositoryId (true) | `false` | no Review Comment: Let me rephrase: What is the benefit having this feature? What usecase does it solve? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] sleberrigaud opened a new pull request, #111: [MRELEASE-1022] Use versions defined in `release.properties` when doing `release:prepare`
sleberrigaud opened a new pull request, #111: URL: https://github.com/apache/maven-release/pull/111 this also works with version passed as arguments on the command line. I was facing https://issues.apache.org/jira/browse/MRELEASE-1022, as trying to follow the documentation https://maven.apache.org/maven-release/maven-release-plugin/examples/non-interactive-release.html would not work (the multi-module & using properties file in particular) I went and looked at the code, added test that would reproduce, and fixed them. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Please let me know if you'd rather I file a contributor license. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRESOLVER-253) Dynamic prefixes for LRM
[ https://issues.apache.org/jira/browse/MRESOLVER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-253: -- Description: Enhances existing "enhanced" LRM (local repository manager) with "prefix" from from path prefix composer. Default behavior is not changed (will not use prefix, local repository will work as before). The point in change is that it introduce a "composer", that is composing LRM path prefixes, and is able to apply different strategies, and split local repository into "installed" (locally built and installed) and "cached" (downloaded from remote), etc. There are several composer options out of the box: * split between "cached" and locally "installed" artifacts * split "cached" artifacts based on their origin (remote repository) * split between "release" and "snapshot" versioned artifacts These properties can all be configured via resolver "configuration", essentially via session configuration. was: Enhances existing "enhanced" LRM (local repository manager) with "dynamic prefix". Default behaviour is not changed (uses NOOP composer). The point in change is that it introduces a "composer", that is composing LRM path prefix, and is able to apply different strategies, and split local repository into "local" (locally built and installed) and "remote" (downloaded from remote, cache really), etc. There are 3 composers, but they are extensible (just implement new `DynamicLocalRepositoryManagerFactory` component): * `noop` - makes enhanced LRM behave exactly same as before, this is the default composer. * `split` - splits by local and remote release/snapshot * `split-repository` - as split but factors in remote repoId as well, basically splits cache by origin > Dynamic prefixes for LRM > > > Key: MRESOLVER-253 > URL: https://issues.apache.org/jira/browse/MRESOLVER-253 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Enhances existing "enhanced" LRM (local repository manager) with "prefix" > from from path prefix composer. Default behavior is not changed (will not use > prefix, local repository will work as before). > The point in change is that it introduce a "composer", that is composing LRM > path prefixes, and is able to apply different strategies, and split local > repository into "installed" (locally built and installed) and "cached" > (downloaded from remote), etc. > There are several composer options out of the box: > * split between "cached" and locally "installed" artifacts > * split "cached" artifacts based on their origin (remote repository) > * split between "release" and "snapshot" versioned artifacts > These properties can all be configured via resolver "configuration", > essentially via session configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7457) Warn about deprecated plugin Mojo
[ https://issues.apache.org/jira/browse/MNG-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527189#comment-17527189 ] Hudson commented on MNG-7457: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #37 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/37/ > Warn about deprecated plugin Mojo > - > > Key: MNG-7457 > URL: https://issues.apache.org/jira/browse/MNG-7457 > Project: Maven > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > Plugin Mojo can be marked as deprecated by author. > Maven should log warnings if deprecated Mojo is used in build plan. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-surefire] mthmulders opened a new pull request, #527: [SUREFIRE-2063] Allow consecutive spaces in argLine
mthmulders opened a new pull request, #527: URL: https://github.com/apache/maven-surefire/pull/527 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. [**SUREFIRE-2063**](https://issues.apache.org/jira/browse/SUREFIRE-2063) - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7457) Warn about deprecated plugin Mojo
[ https://issues.apache.org/jira/browse/MNG-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527186#comment-17527186 ] Hudson commented on MNG-7457: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #23 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/23/ > Warn about deprecated plugin Mojo > - > > Key: MNG-7457 > URL: https://issues.apache.org/jira/browse/MNG-7457 > Project: Maven > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > Plugin Mojo can be marked as deprecated by author. > Maven should log warnings if deprecated Mojo is used in build plan. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #153: [MNG-7457] Warn about deprecated plugin Mojo
slawekjaranowski merged PR #153: URL: https://github.com/apache/maven-integration-testing/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #153: [MNG-7457] Warn about deprecated plugin Mojo
slawekjaranowski commented on PR #153: URL: https://github.com/apache/maven-integration-testing/pull/153#issuecomment-1107844972 coresponding PR - master - https://github.com/apache/maven/pull/726 - 3.9.x - https://github.com/apache/maven/pull/727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #168: [MRESOLVER-253] Split LRM
cstamas commented on PR #168: URL: https://github.com/apache/maven-resolver/pull/168#issuecomment-1107832484 > I think this new feature truly deserves a separate page of description. For many, it'd be hard to follow. I agree here, so will draft a new page for "split LRM" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #168: [MRESOLVER-253] Split LRM
cstamas commented on PR #168: URL: https://github.com/apache/maven-resolver/pull/168#issuecomment-1107832038 > Are these expected? As far as I see, those for GA go into releases, and GAV into snapshots if it is a snapshot of course. Can metadata still properly refreshed? Split by snapshot/release is nearly impossible for Metadata, as they are "mixed bag of beans": while an Artifact can be ONLY this or that (snapshot or release), Metadata is not like that. Hence: * G level metadata is always "release" * GA level metadata is always "release" (while it can, as seen above, enlist versions that are mixed) * GAV level metadata is "release" or "snapshot" based on V it carries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
cstamas commented on code in PR #168:
URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857119220
##
maven-resolver-api/src/main/java/org/eclipse/aether/artifact/AbstractArtifact.java:
##
@@ -43,9 +43,12 @@ public boolean isSnapshot()
return isSnapshot( getVersion() );
}
-private static boolean isSnapshot( String version )
+/**
+ * Returns {@code true} if passed in artifact version is a snapshot
version.
+ */
+public static boolean isSnapshot( String version )
{
-return version.endsWith( SNAPSHOT ) || SNAPSHOT_TIMESTAMP.matcher(
version ).matches();
+return version != null && ( version.endsWith( SNAPSHOT ) ||
SNAPSHOT_TIMESTAMP.matcher( version ).matches() );
Review Comment:
If we fully rely on correctness of Metadata interface implementations (as
javadoc "enforces" it cannot be null), then never, otherwise...
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/LocalPathPrefixComposerFactorySupport.java:
##
@@ -0,0 +1,178 @@
+package org.eclipse.aether.internal.impl;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.AbstractArtifact;
+import org.eclipse.aether.metadata.Metadata;
+import org.eclipse.aether.util.ConfigUtils;
+
+/**
+ * Support class for {@link LocalPathPrefixComposerFactory} implementations:
it predefines and makes re-usable
+ * common configuration getters, and defines a support class for {@link
LocalPathPrefixComposer} carrying same.
+ *
+ * @since TBD
+ */
+public abstract class LocalPathPrefixComposerFactorySupport implements
LocalPathPrefixComposerFactory
+{
+private static final String CONF_PROP_SPLIT =
"aether.enhancedLocalRepository.split";
+
+private static final boolean DEFAULT_SPLIT = false;
+private static final String CONF_PROP_LOCAL_PREFIX =
"aether.enhancedLocalRepository.localPrefix";
+
+private static final String DEFAULT_LOCAL_PREFIX = "installed";
+
+private static final String CONF_PROP_SPLIT_LOCAL =
"aether.enhancedLocalRepository.splitLocal";
+
+private static final boolean DEFAULT_SPLIT_LOCAL = false;
+
+private static final String CONF_PROP_REMOTE_PREFIX =
"aether.enhancedLocalRepository.remotePrefix";
+
+private static final String DEFAULT_REMOTE_PREFIX = "cached";
+
+private static final String CONF_PROP_SPLIT_REMOTE =
"aether.enhancedLocalRepository.splitRemote";
+
+private static final boolean DEFAULT_SPLIT_REMOTE = false;
+
+private static final String CONF_PROP_SPLIT_REMOTE_REPOSITORY =
+"aether.enhancedLocalRepository.splitRemoteRepository";
+
+private static final boolean DEFAULT_SPLIT_REMOTE_REPOSITORY = false;
+
+private static final String CONF_PROP_SPLIT_REMOTE_REPOSITORY_LAST =
+"aether.enhancedLocalRepository.splitRemoteRepositoryLast";
+
+private static final boolean DEFAULT_SPLIT_REMOTE_REPOSITORY_LAST = false;
+
+private static final String CONF_PROP_RELEASE_PREFIX =
"aether.enhancedLocalRepository.releasePrefix";
+
+private static final String DEFAULT_RELEASE_PREFIX = "release";
+
+private static final String CONF_PROP_SNAPSHOT_PREFIX =
"aether.enhancedLocalRepository.snapshotPrefix";
+
+private static final String DEFAULT_SNAPSHOT_PREFIX = "snapshot";
+
+protected boolean isSplit( RepositorySystemSession session )
+{
+return ConfigUtils.getBoolean(
+session, DEFAULT_SPLIT, CONF_PROP_SPLIT );
+}
+
+protected String getLocalPrefix( RepositorySystemSession session )
+{
+return ConfigUtils.getString(
+session, DEFAULT_LOCAL_PREFIX, CONF_PROP_LOCAL_PREFIX );
+}
+
+protected boolean isSplitLocal( RepositorySystemSession session )
+{
+return ConfigUtils.getBoolean(
+session, DEFAULT_SPLIT_LOCAL, CONF_PROP_SPLIT_LOCAL );
+}
+
+protected String getRemotePrefix( RepositorySystemSession session )
+{
+return ConfigUtils.getString(
+session, DEFAULT_REMOTE_PREFIX, CONF_PROP_REMOTE_PREFIX );
+}
+
+protected boolean isSplitRemot
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
cstamas commented on code in PR #168: URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857118981 ## src/site/markdown/configuration.md: ## @@ -47,6 +47,15 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.dependencyCollector.impl` | String | The name of the dependency collector implementation to use: depth-first (original) named `df`, and breadth-first (new in 1.8.0) named `bf`. Both collectors produce equivalent results, but they may differ performance wise, depending on project being applied to. Our experience shows that existing `df` is well suited for smaller to medium size projects, while `bf` may perform better on huge projects with many dependencies. Experiment (and come back to us!) to figure out which one suits you the better. | `"df"` | no `aether.dependencyCollector.bf.skipper` | boolean | Flag controlling whether to skip resolving duplicate/conflicting nodes during the breadth-first (`bf`) dependency collection process. | `true` | no `aether.dependencyManager.verbose` | boolean | Flag controlling the verbose mode for dependency management. If enabled, the original attributes of a dependency before its update due to dependency managemnent will be recorded in the node's `DependencyNode#getData()` when building a dependency graph. | `false` | no +`aether.enhancedLocalRepository.localPrefix` | String | The prefix to use for locally installed artifacts. | `"installed"` | no +`aether.enhancedLocalRepository.snapshotPrefix` | String | The prefix to use for snapshot artifacts. | `"snapshot"` | no +`aether.enhancedLocalRepository.split` | boolean | Whether LRM should split local and remote artifacts. | `false` | no +`aether.enhancedLocalRepository.splitLocal` | boolean | Whether locally installed artifacts should be split by version (release/snapshot). | `false` | no +`aether.enhancedLocalRepository.splitRemote` | boolean | Whether cached artifacts should be split by version (release/snapshot). | `false` | no +`aether.enhancedLocalRepository.splitRemoteRepository` | boolean | Whether cached artifacts should be split by origin repository (repository ID). | `false` | no +`aether.enhancedLocalRepository.splitRemoteRepositoryLast` | boolean | For cached artifacts, if both `splitRemote` and `splitRemoteRepository` are set to `true` sets the splitting order: by default it is repositoryId/version (false) or version/repositoryId (true) | `false` | no Review Comment: I don't quite get the question: this version? how much is of use? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7457) Warn about deprecated plugin Mojo
[ https://issues.apache.org/jira/browse/MNG-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527152#comment-17527152 ] Hudson commented on MNG-7457: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #22 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/22/ > Warn about deprecated plugin Mojo > - > > Key: MNG-7457 > URL: https://issues.apache.org/jira/browse/MNG-7457 > Project: Maven > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > Plugin Mojo can be marked as deprecated by author. > Maven should log warnings if deprecated Mojo is used in build plan. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MNG-7457) Warn about deprecated plugin Mojo
[ https://issues.apache.org/jira/browse/MNG-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MNG-7457. Resolution: Fixed > Warn about deprecated plugin Mojo > - > > Key: MNG-7457 > URL: https://issues.apache.org/jira/browse/MNG-7457 > Project: Maven > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > Plugin Mojo can be marked as deprecated by author. > Maven should log warnings if deprecated Mojo is used in build plan. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MNG-7457) Warn about deprecated plugin Mojo
[ https://issues.apache.org/jira/browse/MNG-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-7457: - Fix Version/s: 3.9.0 > Warn about deprecated plugin Mojo > - > > Key: MNG-7457 > URL: https://issues.apache.org/jira/browse/MNG-7457 > Project: Maven > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > Plugin Mojo can be marked as deprecated by author. > Maven should log warnings if deprecated Mojo is used in build plan. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven] slawekjaranowski merged pull request #727: [MNG-7457] Warn about deprecated plugin Mojo
slawekjaranowski merged PR #727: URL: https://github.com/apache/maven/pull/727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSITE-895) Upgrade plugins and components in ITs
Michael Osipov created MSITE-895: Summary: Upgrade plugins and components in ITs Key: MSITE-895 URL: https://issues.apache.org/jira/browse/MSITE-895 Project: Maven Site Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 4.0.0-M1 * Maven Project Info Reports Plugin to 3.4.0 * Taglist Maven Plugin to 3.0.0 * Maven to 3.2.5 * Maven Reporting Impl to 4.0.0-M1 * Maven Plugin Plugin to 3.6.4 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MSITE-894) Upgrade Maven Reporting Exec to 2.0.0-M1
Michael Osipov created MSITE-894: Summary: Upgrade Maven Reporting Exec to 2.0.0-M1 Key: MSITE-894 URL: https://issues.apache.org/jira/browse/MSITE-894 Project: Maven Site Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 4.0.0-M1 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MSITE-893) Upgrade Maven Reporting API to 4.0.0-M1
Michael Osipov created MSITE-893: Summary: Upgrade Maven Reporting API to 4.0.0-M1 Key: MSITE-893 URL: https://issues.apache.org/jira/browse/MSITE-893 Project: Maven Site Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 4.0.0-M1 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MSITE-892) Upgrade to Doxia/Doxia Sitetools to 2.0.0-M2
Michael Osipov created MSITE-892: Summary: Upgrade to Doxia/Doxia Sitetools to 2.0.0-M2 Key: MSITE-892 URL: https://issues.apache.org/jira/browse/MSITE-892 Project: Maven Site Plugin Issue Type: Dependency upgrade Components: doxia integration Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 4.0.0-M1 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (SUREFIRE-2064) Implementation of TestNG "parallel" option fails with default value
[
https://issues.apache.org/jira/browse/SUREFIRE-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-2064:
---
Fix Version/s: 2.22.3
> Implementation of TestNG "parallel" option fails with default value
> ---
>
> Key: SUREFIRE-2064
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2064
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
>Affects Versions: 3.0.0-M6
>Reporter: Scott Babcock
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.3, 3.0.0-M7
>
>
> The latest release of Maven Surefire attempts to resolve an incompatibility
> with TestNG 7.4+, but the way the fix was implemented causes projects that
> don't specify parallel execution to fail:
> {code:java}
> [ERROR] There was an error in the forked process
> [ERROR] Unsupported TestNG parallel setting: none ( only METHODS or CLASSES
> supported )
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There
> was an error in the forked process
> [ERROR] Unsupported TestNG parallel setting: none ( only METHODS or CLASSES
> supported )
> {code}
> "none" is the default value that gets passed in if no [parallel] setting is
> specified. TestNG actually supports NONE as a valid value, along with TESTS
> and INSTANCES. There are two deprecated values as well (TRUE and FALSE),
> which cause TestNG to log a warning and translate to equivalent supported
> values (METHODS and NONE respectively).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-mvnd] imbennie opened a new issue, #619: Problem when running in Cygwin with ENV “JAVA_HOME” itself.
imbennie opened a new issue, #619: URL: https://github.com/apache/maven-mvnd/issues/619 This problem seems like #156 but has a little difference. I had SDKMAN in my Cygiwn and have several java versions installed. So Cygwin has its own `JAVA_HOME`. ``` ~ » echo $JAVA_HOME /home/Bennie/.sdkman/candidates/java/current ``` And when i checkout mvnd version ``` ~ » mvnd -v mvnd native client 0.7.1-windows-amd64 (97c587c11383a67b5bd0ff8388bd94c694b91c1e) Terminal: org.jline.terminal.impl.jansi.win.JansiWinSysTerminal Exception in thread "main" java.lang.RuntimeException: Could not get a real path from path \home\Bennie\.sdkman\candidates\java\current at org.mvndaemon.mvnd.client.DaemonParameters.javaHome(DaemonParameters.java:144) at org.mvndaemon.mvnd.client.DaemonConnector.connect(DaemonConnector.java:99) at org.mvndaemon.mvnd.client.DefaultClient.execute(DefaultClient.java:272) at org.mvndaemon.mvnd.client.DefaultClient.main(DefaultClient.java:118) ``` That's the problem what is. I'm trying `mvnd -v` agin after edit `java.home` in the `conf/mvnd.properties` with following, But still got the same error output before. ``` java.home=/home/Bennie/.sdkman/candidates/java/8.0.322-tem ``` After read the #156 I find out maybe the @gnodet doesn't have a `JAVA_HOME` in Cygwin itself which just copied from Windows one. Thus I unset the JAVA_HOME and ran `mvnd -v` agin. ``` ~ » unset JAVA_HOME ~ » mvnd -v mvnd native client 0.7.1-windows-amd64 (97c587c11383a67b5bd0ff8388bd94c694b91c1e) Terminal: org.jline.terminal.impl.jansi.win.JansiWinSysTerminal Exception in thread "main" java.lang.RuntimeException: Could not get a real path from path \home\Bennie\.sdkman\candidates\java\8.0.322-tem at org.mvndaemon.mvnd.client.DaemonParameters.javaHome(DaemonParameters.java:144) at org.mvndaemon.mvnd.client.DaemonConnector.connect(DaemonConnector.java:99) at org.mvndaemon.mvnd.client.DefaultClient.execute(DefaultClient.java:272) at org.mvndaemon.mvnd.client.DefaultClient.main(DefaultClient.java:118) ``` This time the `java.home` path in output is point to our's one. Verified that the `unset JAVA_HOME` operation is valid. But the problem still does what it does. I checked out the #156 bug-fixed details. Found out the `java.home` path start with `\cygdrive\`, So edit `java.home` in the `conf/mvnd.properties` again. Then It's just worked. ``` java.home=/cygdrive/d/Tools/cygwin/home/Bennie/.sdkman/candidates/java/8.0.322-tem ~ » mvnd -v mvnd native client 0.7.1-windows-amd64 (97c587c11383a67b5bd0ff8388bd94c694b91c1e) Terminal: org.jline.terminal.impl.jansi.win.JansiWinSysTerminal Apache Maven 3.8.3 (ff8e977a158738155dc465c6a97ffaf31982d739) Maven home: D:\Tools\cygwin\home\Bennie\.sdkman\candidates\mvnd\0.7.1\mvn Java version: 1.8.0_322, vendor: Temurin, runtime: D:\Tools\cygwin\home\Bennie\.sdkman\candidates\java\8.0.322-tem\jre Default locale: zh_CN, platform encoding: GBK OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" ``` Finally: 1. Is there a good way to solve this problem? 2. This is may be a bug? due the `java.home` property override by `$JAVA_HOME`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4
Tibor17 commented on code in PR #516:
URL: https://github.com/apache/maven-surefire/pull/516#discussion_r857087085
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java:
##
@@ -312,7 +312,7 @@ private void addTestMethodStats()
for ( WrappedReportEntry reportEntry :
detailsForThis.getReportEntries() )
{
TestMethodStats methodStats =
-new TestMethodStats( reportEntry.getClassMethodName(),
reportEntry.getReportEntryType(),
+new TestMethodStats( reportEntry.getReportClassMethodName(),
reportEntry.getReportEntryType(),
Review Comment:
@chalmagr I do not think this is right because source/name is always
extracted from JUnit4 Description which encodes both strings as follows
`name(source)` and JUnit ensures that the descrption is unique. Typically,
junit encodes `name` as `method[]`. If this is wrong, then the problem is
in provider and not in this class TSRL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4
Tibor17 commented on code in PR #516:
URL: https://github.com/apache/maven-surefire/pull/516#discussion_r857087085
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java:
##
@@ -312,7 +312,7 @@ private void addTestMethodStats()
for ( WrappedReportEntry reportEntry :
detailsForThis.getReportEntries() )
{
TestMethodStats methodStats =
-new TestMethodStats( reportEntry.getClassMethodName(),
reportEntry.getReportEntryType(),
+new TestMethodStats( reportEntry.getReportClassMethodName(),
reportEntry.getReportEntryType(),
Review Comment:
@chalmagr I do not think this is right because source/name is always
extracted from JUnit4 Description which encodes both strings as follows
`name(source)` and JUnit ensures that the descrption is unique. Typically,
junit encodes `name` as `]>()`. If this is wrong, then the
problem is in provider and not in this class TSRL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-script-interpreter] slawekjaranowski commented on pull request #68: [MSHARED-1068] Upgrade Groovy to 4.0.2
slawekjaranowski commented on PR #68: URL: https://github.com/apache/maven-script-interpreter/pull/68#issuecomment-1107795772 So we should merge first PR and will be clear -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4
Tibor17 commented on code in PR #516:
URL: https://github.com/apache/maven-surefire/pull/516#discussion_r857087085
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java:
##
@@ -312,7 +312,7 @@ private void addTestMethodStats()
for ( WrappedReportEntry reportEntry :
detailsForThis.getReportEntries() )
{
TestMethodStats methodStats =
-new TestMethodStats( reportEntry.getClassMethodName(),
reportEntry.getReportEntryType(),
+new TestMethodStats( reportEntry.getReportClassMethodName(),
reportEntry.getReportEntryType(),
Review Comment:
@chalmagr I do not think this is right because source/name is always
extracted from JUnit4 Description which encodes both strings as follows
`name(source)` and JUnit ensures that the descrption is unique. Typically,
junit encodes `name` as `]>(class)`. If this is wrong, then the
problem is in provider and not in this class TSRL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-7457) Warn about deprecated plugin Mojo
[ https://issues.apache.org/jira/browse/MNG-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-7457: - Issue Type: New Feature (was: Improvement) > Warn about deprecated plugin Mojo > - > > Key: MNG-7457 > URL: https://issues.apache.org/jira/browse/MNG-7457 > Project: Maven > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 4.0.0-alpha-1, 4.0.0 > > > Plugin Mojo can be marked as deprecated by author. > Maven should log warnings if deprecated Mojo is used in build plan. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MNG-7464) Warn about using read-only parameters for Mojo in configuration
Slawomir Jaranowski created MNG-7464: Summary: Warn about using read-only parameters for Mojo in configuration Key: MNG-7464 URL: https://issues.apache.org/jira/browse/MNG-7464 Project: Maven Issue Type: New Feature Reporter: Slawomir Jaranowski -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-script-interpreter] slachiewicz commented on pull request #68: [MSHARED-1068] Upgrade Groovy to 4.0.2
slachiewicz commented on PR #68: URL: https://github.com/apache/maven-script-interpreter/pull/68#issuecomment-1107793922 Yes, this PR is based on commit for java 8 as Groove 4 requires newer java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-script-interpreter] slachiewicz commented on a diff in pull request #67: [MSHARED-1002] Require Java 8
slachiewicz commented on code in PR #67: URL: https://github.com/apache/maven-script-interpreter/pull/67#discussion_r857091721 ## pom.xml: ## @@ -22,7 +22,7 @@ org.apache.maven.shared maven-shared-components -34 +36 Review Comment: I don't think it would have value, first i updated java and then updated pom. In pom.xml we have almost nothing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-script-interpreter] slawekjaranowski commented on pull request #68: [MSHARED-1068] Upgrade Groovy to 4.0.2
slawekjaranowski commented on PR #68: URL: https://github.com/apache/maven-script-interpreter/pull/68#issuecomment-1107793481 For Java 8 exists another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-script-interpreter] slawekjaranowski commented on a diff in pull request #67: [MSHARED-1002] Require Java 8
slawekjaranowski commented on code in PR #67: URL: https://github.com/apache/maven-script-interpreter/pull/67#discussion_r857091580 ## pom.xml: ## @@ -22,7 +22,7 @@ org.apache.maven.shared maven-shared-components -34 +36 Review Comment: maybe separate PR and issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7457) Warn about deprecated plugin Mojo
[ https://issues.apache.org/jira/browse/MNG-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527127#comment-17527127 ] Hudson commented on MNG-7457: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #36 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/36/ > Warn about deprecated plugin Mojo > - > > Key: MNG-7457 > URL: https://issues.apache.org/jira/browse/MNG-7457 > Project: Maven > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 4.0.0-alpha-1, 4.0.0 > > > Plugin Mojo can be marked as deprecated by author. > Maven should log warnings if deprecated Mojo is used in build plan. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-5222) Maven 3 no longer logs warnings about deprecated plugin parameters.
[ https://issues.apache.org/jira/browse/MNG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527128#comment-17527128 ] Hudson commented on MNG-5222: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #36 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/36/ > Maven 3 no longer logs warnings about deprecated plugin parameters. > --- > > Key: MNG-5222 > URL: https://issues.apache.org/jira/browse/MNG-5222 > Project: Maven > Issue Type: Bug > Components: Plugins and Lifecycle >Affects Versions: 3.0.3 >Reporter: Christian Schulte >Assignee: Slawomir Jaranowski >Priority: Minor > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Providing a value for a deprecated plugin parameter, Maven 2.2.1 used to log > a warning. Currently Maven 3 does not. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4
Tibor17 commented on code in PR #516:
URL: https://github.com/apache/maven-surefire/pull/516#discussion_r857087085
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java:
##
@@ -312,7 +312,7 @@ private void addTestMethodStats()
for ( WrappedReportEntry reportEntry :
detailsForThis.getReportEntries() )
{
TestMethodStats methodStats =
-new TestMethodStats( reportEntry.getClassMethodName(),
reportEntry.getReportEntryType(),
+new TestMethodStats( reportEntry.getReportClassMethodName(),
reportEntry.getReportEntryType(),
Review Comment:
@chalmagr I do not think this is right because source/name is always
extracted from JUnit4 Description which encodes both strings as follows
`name(source)` and JUnit ensures that the descrption is unique. Typically,
junit encodes `name` as `[]`. If this is wrong, then the problem is
in provider and not in this class TSRL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] slawekjaranowski opened a new pull request, #727: [MNG-7457] Warn about deprecated plugin Mojo
slawekjaranowski opened a new pull request, #727: URL: https://github.com/apache/maven/pull/727 (cherry picked from commit 702f52d0ea7c5e90b495bc05f079ca3e952766a8) --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7400) Allow more WorkspaceReaders to participate
[
https://issues.apache.org/jira/browse/MNG-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527096#comment-17527096
]
Hudson commented on MNG-7400:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Allow more WorkspaceReaders to participate
> --
>
> Key: MNG-7400
> URL: https://issues.apache.org/jira/browse/MNG-7400
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.8.4
>Reporter: Christoph Läubrich
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> Currently there are two kind of {{WorkspaceReaders}} the reactor one and the
> one obtained from the {{RepositorySystemSession}} (which is eed by an IDE
> scoped component in
> {{org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory}}).
> In [Tycho|https://github.com/eclipse/tycho] we have the demand to supply a
> {{WorkspaceReader}} as there is a so called "target platform" as the source
> of artifacts.
> Now it does not seem correct to declare it as an IDE, and of course we don't
> want to block the IDE use-case.
> Another issue is that at the time the IDE component is injected there is no
> session and thus a session scoped component won't work as well so even if we
> would use this we are rather "blind".
> It would be good to have maven discover {{WorkspaceReaders}} as it discovers
> {{AbstractMavenLifecycleParticipants}} in the following way, right before the
> session is fixed:
> {code:java}
> for ( WorkspaceReader reader : getWorkspaceReader( session.getProjects() ) )
> {
> //chain them together with the current workspace reader(s)
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7391) add MojoExecution strategy and runner required by Maven Build Cache Extension
[ https://issues.apache.org/jira/browse/MNG-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527111#comment-17527111 ] Hudson commented on MNG-7391: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > add MojoExecution strategy and runner required by Maven Build Cache Extension > - > > Key: MNG-7391 > URL: https://issues.apache.org/jira/browse/MNG-7391 > Project: Maven > Issue Type: New Feature > Components: Core >Reporter: Herve Boutemy >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1 > > > Maven Build Cache Extension has been provided as a maven-core update, but > extracted to a separate module then a separate Git repository to provide an > extension: see MNG-7129 == MBUILDCACHE-1 > the extension just requires a small API in Maven core to be able to inject > Build Cache: MojoExecution strategy and runner > By default, MojoExecution strategy is to run Mojos > Build Cache Extension can has a more advanced strategy that can introduce > cache = inject MojoExecution result taken from cache to avoid running the Mojo -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message
[
https://issues.apache.org/jira/browse/MNG-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527121#comment-17527121
]
Hudson commented on MNG-7438:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> add execution id to "Configuring mojo xxx with basic configurator" debug
> message
>
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin
> realm
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5,
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic
> configurator -->
> [DEBUG] (s) additionalClasspathElements = []
> [DEBUG] (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic
> configurator}}" line, it completely hides the fact that configuration is
> valid for an execution id, that has a default value when nobody defined any
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin
> realm
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5,
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test'
> with basic configurator -->
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7457) Warn about deprecated plugin Mojo
[ https://issues.apache.org/jira/browse/MNG-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527124#comment-17527124 ] Hudson commented on MNG-7457: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Warn about deprecated plugin Mojo > - > > Key: MNG-7457 > URL: https://issues.apache.org/jira/browse/MNG-7457 > Project: Maven > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 4.0.0-alpha-1, 4.0.0 > > > Plugin Mojo can be marked as deprecated by author. > Maven should log warnings if deprecated Mojo is used in build plan. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml
[
https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527123#comment-17527123
]
Hudson commented on MNG-7055:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into
> maven-metadata.xml
> -
>
> Key: MNG-7055
> URL: https://issues.apache.org/jira/browse/MNG-7055
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories, Plugins and Lifecycle
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Blocker
> Fix For: 3.9.0, 3.9.0-candidate, 4.0.0-alpha-1, 4.0.0
>
>
> Copying [~michael-o]'s comment from mailing list on HEAD with Maven core ITs:
> https://markmail.org/message/ggcioupa6yaet4xe#query:+page:1+mid:noyp5d3iyclrfgyp+state:results
> {noformat}[ERROR] Tests run: 834, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 287.261 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR]
> testitMNG3372(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
> Time elapsed: 1.5 s <<< ERROR!
> org.apache.maven.it.VerificationException:
> Exit code was non-zero: 1; command line and log =
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn
> --global-settings
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/settings.xml
> -s
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-3372/direct-using-prefix/settings.xml
> -e --batch-mode
> -Dmaven.repo.local=/net/home/osipovmi/var/Projekte/maven-integration-testing/repo
> mng3372:test
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for
> org.apache.maven.its.mng3372:project:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins [maven-clean-plugin,
> maven-resources-plugin, maven-jar-plugin, maven-compiler-plugin,
> maven-surefire-plugin, maven-install-plugin, maven-deploy-plugin,
> maven-site-plugin], you should define versions in pluginManagement section of
> your pom.xml or parent @ line 6, column 14
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
> [WARNING]
> [INFO] Downloading from central:
> file:target/null/org/apache/maven/its/mng3372/maven-metadata.xml
> [INFO] Downloading from central:
> file:target/null/org/apache/maven/plugins/maven-metadata.xml
> [INFO] Downloading from central:
> file:target/null/org/codehaus/mojo/maven-metadata.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.056 s
> [INFO] Finished at: 2020-06-04T22:03:01+02:00
> [INFO]
>
> [ERROR] No plugin found for prefix 'mng3372' in the current project and in the
> plugin groups [org.apache.maven.its.mng3372, org.apache.maven.plugins,
> org.codehaus.mojo] available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)] -> [Help 1]
> org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin
> found
> for prefix 'mng3372' in the current project and in the plugin groups
> [org.apache.maven.its.mng3372, org.apache.maven.plugins, org.codehaus.mojo]
> available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)]
> at
> org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver.resolve(DefaultPluginPrefixResolver.java:98)
> at
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.findPluginForPrefix(MojoDescriptorCreator.java:269)
> at
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.getMojoDescript{noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7370) Upgrade Maven Wagon to 3.5.1
[ https://issues.apache.org/jira/browse/MNG-7370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527080#comment-17527080 ] Hudson commented on MNG-7370: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Upgrade Maven Wagon to 3.5.1 > > > Key: MNG-7370 > URL: https://issues.apache.org/jira/browse/MNG-7370 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-5222) Maven 3 no longer logs warnings about deprecated plugin parameters.
[ https://issues.apache.org/jira/browse/MNG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527119#comment-17527119 ] Hudson commented on MNG-5222: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Maven 3 no longer logs warnings about deprecated plugin parameters. > --- > > Key: MNG-5222 > URL: https://issues.apache.org/jira/browse/MNG-5222 > Project: Maven > Issue Type: Bug > Components: Plugins and Lifecycle >Affects Versions: 3.0.3 >Reporter: Christian Schulte >Assignee: Slawomir Jaranowski >Priority: Minor > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Providing a value for a deprecated plugin parameter, Maven 2.2.1 used to log > a warning. Currently Maven 3 does not. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7377) Add .vscode/ to .gitignore
[ https://issues.apache.org/jira/browse/MNG-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527081#comment-17527081 ] Hudson commented on MNG-7377: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Add .vscode/ to .gitignore > -- > > Key: MNG-7377 > URL: https://issues.apache.org/jira/browse/MNG-7377 > Project: Maven > Issue Type: Task >Reporter: Jeff Hodges >Assignee: Michael Osipov >Priority: Major > > vscode adds a `.vscode` directory to the top of a git repo it's opened in. > This is harmless, but the apache-rat plugin configured in the maven's > top-level `pom.xml` sounds the alarm on it and doesn't even allow the code to > compile. That means anyone reading maven's code in vscode will have a failing > build > I've got a patch I'll post that ignores the `.vscode` dir in the rat's config > and in `.gitignore`. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7453) Upgrade Maven Resolver to 1.8.0
[ https://issues.apache.org/jira/browse/MNG-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527122#comment-17527122 ] Hudson commented on MNG-7453: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Upgrade Maven Resolver to 1.8.0 > --- > > Key: MNG-7453 > URL: https://issues.apache.org/jira/browse/MNG-7453 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > Maven Resolver 1.8 will bring multiple improvements in many area: extensible > checksum algorithms, provided checksum, ability for signature resolution, > smart checksum, new BF collection along with "old" DF collector, etc. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7432) [REGRESSION] Resolver session contains non-MavenWorkspaceReader
[ https://issues.apache.org/jira/browse/MNG-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527118#comment-17527118 ] Hudson commented on MNG-7432: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > [REGRESSION] Resolver session contains non-MavenWorkspaceReader > --- > > Key: MNG-7432 > URL: https://issues.apache.org/jira/browse/MNG-7432 > Project: Maven > Issue Type: Bug >Affects Versions: 3.8.5 >Reporter: Falko Modler >Assignee: Tamás Cservenák >Priority: Critical > Fix For: 3.8.6, 3.9.0, 4.0.0 > > > As Resolver session contains non-MavenWorkspaceReader, the reactor models > (already resolved w/ profiles applied) are re-built when using Resolver > within Mojo, instead to get them via ReactorReader as expected. The rebuilt > models will lack explicit (-P on CLI) profiles applied, as resolver itself is > not maven aware, hence there is no way to "tell" resolver to apply them. > Building reactor models w/ profiles applied is NOT done using resolver, but > by Maven when loading up reactor, as profiles are NOT applied for downstream > transitive dependencies (see discussion on MNG-1388 why). > --- > The README of the following reproducer says it all: > https://github.com/aloubyansky/playground/tree/maven-3.8.5-profile-activation > Initially discussed here: > https://github.com/quarkusio/quarkus/pull/24285#issuecomment-1067368625 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7454) Include resolver-transport-http in Maven
[
https://issues.apache.org/jira/browse/MNG-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527120#comment-17527120
]
Hudson commented on MNG-7454:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Include resolver-transport-http in Maven
>
>
> Key: MNG-7454
> URL: https://issues.apache.org/jira/browse/MNG-7454
> Project: Maven
> Issue Type: New Feature
> Components: Dependencies
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> We should include maven-resolver-transport-http (along with existing
> maven-resolver-transport-wagon) but retain Wagon as default transport, while
> offer ability for users to use http transport to utilize new resolver
> features like "smart checksums".
> On positive side, this will finally get rid of shaded httpClient and
> wagon-http-shaded as well.
> To switch transport use {{-Dmaven.resolver.transport}} with following values:
> * {{wagon}} - to use wagon (is default as well)
> * {{native}} - to use resolver own highly optimized HTTP and FILE transport
> (supports "smart checksums")
> * {{auto}} - to rely on resolver own discovery, or if another transport
> extension used
> The selected transport can be seen in debug (-X) output on line `[DEBUG]
> Using transporter XXX...`
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7441) Update Version of (optional) Logback to Address CVE-2021-42550
[
https://issues.apache.org/jira/browse/MNG-7441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527117#comment-17527117
]
Hudson commented on MNG-7441:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Update Version of (optional) Logback to Address CVE-2021-42550
> --
>
> Key: MNG-7441
> URL: https://issues.apache.org/jira/browse/MNG-7441
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 3.8.5
>Reporter: Mac Hale
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> [CVE-2021-42550|https://nvd.nist.gov/vuln/detail/CVE-2021-42550] is present
> in Logback versions 1.2.7 and earlier. Maven (optionally) uses v 1.2.1.
> Please update to Logback 1.2.9, which includes a fix as per
> [https://jira.qos.ch/browse/LOGBACK-1591|[https://jira.qos.ch/browse/LOGBACK-1591].]
> I see ch.qos.logback 1.2.1 in {{./pom.xml}} and ch.qos.logback without a
> version specified in {{./maven-embedder/pom.xml}}
> But I'm no expert on this code base so it's possible there are other
> versioned references.
> Edit: One could argue, as the Logback team has done, that the CVE is
> unimportant since in order to exploit it one must already have compromised
> the system. However, security scanners pick this up as an issue, causing
> unnecessary work and justifications.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7452) Remove JDK7 run on Maven 3.9.X Branch
[ https://issues.apache.org/jira/browse/MNG-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527116#comment-17527116 ] Hudson commented on MNG-7452: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Remove JDK7 run on Maven 3.9.X Branch > - > > Key: MNG-7452 > URL: https://issues.apache.org/jira/browse/MNG-7452 > Project: Maven > Issue Type: Task >Affects Versions: 3.9.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.9.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7447) Several Improvements by using Stream API
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527115#comment-17527115 ] Hudson commented on MNG-7447: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Several Improvements by using Stream API > > > Key: MNG-7447 > URL: https://issues.apache.org/jira/browse/MNG-7447 > Project: Maven > Issue Type: Sub-task >Affects Versions: 3.9.0, 4.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 3.9.0, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7349) Limit relocation warning message to direct dependencies only
[
https://issues.apache.org/jira/browse/MNG-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527093#comment-17527093
]
Hudson commented on MNG-7349:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Limit relocation warning message to direct dependencies only
>
>
> Key: MNG-7349
> URL: https://issues.apache.org/jira/browse/MNG-7349
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.8.3, 3.8.4
>Reporter: Joep Weijers
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> In the
> [commit|https://github.com/apache/maven/commit/a1ba33069fad1fb9c6e9cd458ad233ff3a74aadd]
> that solved MNG-7253, the check for relocations was moved from the
> DefaultProjectDependenciesResolver to the DefaultArtifactDescriptorReader.
> This means that the relocation messages are not only shown on project
> dependencies, but on any artifact that is read.
> This may lead to unfixable WARNINGS in the output if a plugin transitively
> uses a relocated artifact.
> This can be reproduced by calling {{mvn dependency:tree}} with a simple,
> empty {{{}pom.xml{}}}. This will give the following warning:
> {code:java}
> [WARNING] The artifact xml-apis:xml-apis:jar:2.0.2 has been relocated to
> xml-apis:xml-apis:jar:1.0.b2
> {code}
> The default maven-dependency-plugin version is 2.8 and it depends on
> {{{}org.apache.maven.reporting:maven-reporting-impl:2.0.5{}}}, which depends
> on {{commons-validator:commons-validator:1.2.0}} which depends on
> {{{}xml-apis:xml-apis:2.0.2{}}}.
> In this particular case, updating to a recent maven-dependency-plugin version
> solves the issue. But since the transitive dependencies of plugins are not
> under the control of the end users, I don't think this warning should be
> shown.
> *Workaround:*
> Stay on Maven 3.8.2 or disable logging on the DefaultArtifactDescriptorReader:
> {code:java}
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.repository.internal.DefaultArtifactDescriptorReader=error
> {code}
> Although this disables all relocation messages, including the ones you might
> be interested in.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7252) Fix warnings issued by dependency:analyze
[
https://issues.apache.org/jira/browse/MNG-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527070#comment-17527070
]
Hudson commented on MNG-7252:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Fix warnings issued by dependency:analyze
> -
>
> Key: MNG-7252
> URL: https://issues.apache.org/jira/browse/MNG-7252
> Project: Maven
> Issue Type: Task
> Components: Dependencies
>Affects Versions: 3.8.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.8.3
>
>
> At least the following needs to be addressed:
> {noformat}
> 373 [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @
> maven-model-builder ---
> 374 [WARNING] Used undeclared dependencies found:
> 375 [WARNING]org.apache.commons:commons-lang3:jar:3.8.1:compile
> 633 [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @
> maven-resolver-provider ---
> 634 [WARNING] Unused declared dependencies found:
> 638 [WARNING]org.slf4j:slf4j-api:jar:1.7.32:compile
> 724 [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @
> maven-core ---
> 725 [WARNING] Used undeclared dependencies found:
> 726 [WARNING]org.slf4j:slf4j-api:jar:1.7.32:compile
> 727 [WARNING]org.codehaus.plexus:plexus-interpolation:jar:1.26:compile
> 861 [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @
> maven-embedder ---
> 864 [WARNING] Unused declared dependencies found:
> 865 [WARNING]javax.annotation:javax.annotation-api:jar:1.2:compile
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7236) The DefaultPluginVersionResolver should cache results for the session
[ https://issues.apache.org/jira/browse/MNG-7236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527068#comment-17527068 ] Hudson commented on MNG-7236: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > The DefaultPluginVersionResolver should cache results for the session > - > > Key: MNG-7236 > URL: https://issues.apache.org/jira/browse/MNG-7236 > Project: Maven > Issue Type: Improvement >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.8.3, 4.0.0-alpha-1, 4.0.0 > > > During a reactor build, it would be better to cache the resolved version for > plugins, both for performance reasons and for reproducibility. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7386) ModelMerger$MergingList is not serializable
[
https://issues.apache.org/jira/browse/MNG-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527092#comment-17527092
]
Hudson commented on MNG-7386:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> ModelMerger$MergingList is not serializable
> ---
>
> Key: MNG-7386
> URL: https://issues.apache.org/jira/browse/MNG-7386
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.6.3, 3.8.4
>Reporter: Kostiantyn Liutovych
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> Hello!
> [Spotless Maven plugin|https://github.com/diffplug/spotless] serializes
> {{org.apache.maven.model.Plugin}} instances to fingerprint plugin's
> configuration. Serialization fails for Maven 3.6.3 with:
> {code}
> java.io.NotSerializableException:
> org.apache.maven.model.merge.ModelMerger$MergingList
> {code}
> when plugin configuration comes from {{pluginManagement}}. Class
> {{org.apache.maven.model.Plugin}} implements {{java.io.Serializable}},
> however nested class {{org.apache.maven.model.merge.ModelMerger$MergingList}}
> does not.
> Would it be possible to make {{MergingList}} serializable or make
> {{Plugin#dependencies}} field always hold a serializable collection?
> Related issue for the Spotless Maven plugin:
> https://github.com/diffplug/spotless/issues/1073 and PR with a workaround
> https://github.com/diffplug/spotless/pull/1074.
> Thank you!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7408) Explain reporting plugin version automatic selection (in Maven 3)
[ https://issues.apache.org/jira/browse/MNG-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527095#comment-17527095 ] Hudson commented on MNG-7408: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Explain reporting plugin version automatic selection (in Maven 3) > - > > Key: MNG-7408 > URL: https://issues.apache.org/jira/browse/MNG-7408 > Project: Maven > Issue Type: Improvement > Components: Sites & Reporting >Affects Versions: 3.8.4 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0 > > > reporting plugin version looks like normal version = you need to define a > version for build stability > https://maven.apache.org/ref/3.8.4/maven-model/maven.html#class_reporting > in Maven 2, it did not even benefit from pluginManagement version selection > but since Maven 3 MNG-4162, it benefits not only from pluginManagement > version but also from plugin: we need to make that clear, because versions of > report plugins are a pain for users who don't know about this, because it > force them to define a property that will be used both in > pluginManagement/plugin and reporting > and since Maven Site Plugin 3.4, it also benefits from pluginManagement > configuration > see https://maven.apache.org/shared/maven-reporting-exec/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527110#comment-17527110
]
Hudson commented on MNG-6972:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7445) to refactor some useless code
[ https://issues.apache.org/jira/browse/MNG-7445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527114#comment-17527114 ] Hudson commented on MNG-7445: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > to refactor some useless code > - > > Key: MNG-7445 > URL: https://issues.apache.org/jira/browse/MNG-7445 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.8.5 > Environment: macos, linux ,windwos >Reporter: jackyHu >Assignee: Karl Heinz Marbaise >Priority: Trivial > Labels: refactor > Fix For: 3.8.6, 3.9.0, 4.0.0 > > Attachments: wenjian.jpg > > Original Estimate: 1h > Remaining Estimate: 1h > > the code at > maven-core/src/main/java/org/apache/maven/settings/DefaultMavenSettingsBuilder.java > and the return statement (at line 158 and 162)been writen twice ,but they > could be only write once. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7381) Shorten parallel builder thread name to artifactId, conditionally with groupId
[
https://issues.apache.org/jira/browse/MNG-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527090#comment-17527090
]
Hudson commented on MNG-7381:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Shorten parallel builder thread name to artifactId, conditionally with groupId
> --
>
> Key: MNG-7381
> URL: https://issues.apache.org/jira/browse/MNG-7381
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.8.2, 3.8.3, 3.8.4
>Reporter: Falko Modler
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> Following up on MNG-6471, the thread name that is now generated can easily
> exceed 60 chars or more, e.g.:
> {noformat}
> [mvn-builder-de.somecorp.foo.barbazx:register-server:jar:2.0.0.local-dev3] ...
> {noformat}
> This devaluates {{-Dorg.slf4j.simpleLogger.showThreadName=true}} as the only
> easily availble option to differentiate where a logline comes from.
> As discussed
> [here|https://github.com/apache/maven/pull/177#issuecomment-1005975037] (and
> in the following comments), one idea is to make the pattern configurable (or
> simpler, have a toggle to include the entire module id or only its
> artifactId).
> A slightly different approach could try to detect whether there are
> "duplicate" artifactIds in the reactor and only append the groupId for those.
> In any way, type, classfier and version don't seem to add anything valuable.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7350) Introduce a factory for ModelCache
[
https://issues.apache.org/jira/browse/MNG-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527112#comment-17527112
]
Hudson commented on MNG-7350:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Introduce a factory for ModelCache
> --
>
> Key: MNG-7350
> URL: https://issues.apache.org/jira/browse/MNG-7350
> Project: Maven
> Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate
>
>
> {{mvnd}} does redefine a few maven classes in order to plugin its caching
> layer.
> One of those class is the {{ProjectBuilder}}, but that's only because the
> {{ModelCache}} is created using a direct call on the implementation.
> This ticket aims to introduce a {{ModelCacheFactory}} so that {{mvnd}} can
> simply define a custom factory instead of redefining the full
> {{ProjectBuilder}}.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7395) Support interpolation in extensions.xml
[
https://issues.apache.org/jira/browse/MNG-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527098#comment-17527098
]
Hudson commented on MNG-7395:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Support interpolation in extensions.xml
> ---
>
> Key: MNG-7395
> URL: https://issues.apache.org/jira/browse/MNG-7395
> Project: Maven
> Issue Type: New Feature
>Reporter: Christoph Läubrich
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> Currently an entry has to be the following form:
> {code:xml}
>
> org.eclipse.tycho
> tycho-build
> 2.7.0-SNAPSHOT
>
> {code}
> This has the drawback that I always need to edit the extension.xml file and
> there is no way to specify it on the commandline.
> The proposal is to allow the follwoing:
> {code:xml}
>
> org.eclipse.tycho
> tycho-build
> ${tycho-version|2.6.0}
>
> {code}
> I would then expect the following:
> # If no systemproperty with name 'tycho-version' exits, the value after the |
> is used as a default
> # If a systemproperty with name 'tycho-version' exits it is used as a version
> That way I can call mvn -Dtycho-version=2.7.0-SNAPSHOT clean install to
> override the default version.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-6878) Upgrade Guice to 4.2.3
[
https://issues.apache.org/jira/browse/MNG-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527106#comment-17527106
]
Hudson commented on MNG-6878:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Upgrade Guice to 4.2.3
> --
>
> Key: MNG-6878
> URL: https://issues.apache.org/jira/browse/MNG-6878
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> h4. Changes since Guice 4.2.2 [https://github.com/google/guice/wiki/Guice423]
> [http://google.github.io/guice/api-docs/4.2.3/api-diffs/changes.html]
> * Java14 support (updated asm).
> * Added {{Injector.getElements}} API, to expose all Element SPI types from
> the Injector.
> * Added {{Injector.getAllMembersInjectorInjectionPoints}} API, to expose
> injection points created by arbitrary members injection.
> * Added {{getAlternateKeys}} to Multibinder SPI types
> ({{MultibinderBinding}}, {{MapBinderBinding}}, {{OptionalBinderBinding}}), to
> explicitly list the other keys these bindings are available as.
> * Scan for (and bind) @Provides-like methods in a consistent ordering,
> rather than relying on the non-deterministic Class.getDeclaredMembers
> ordering.
> * Update {{DaggerAdapter}} to work with newer dagger code.
> * Fixed a [subtle
> bug|https://github.com/google/guice/commit/f8cc1718a33a868e9951f7d3d6b4f74d8b1a1548]
> with eager singleton evaluation.
> * Updated {{@RequestScope}}'s scope annotation to the JSR330 {{@Scope}}, so
> it can be reused by non-Guice DI systems.
> * Clarified the error message when an injectable constructor is missing.
> * Add deprecated overloads to various {{Modules}} methods, to make it
> clearer when calling them is unnecessary.
> * Added factory methods to {{Modules}} for common Binder configuration
> methods, to make it easier to configure them.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-6326) Build continues when core extensions aren't found
[ https://issues.apache.org/jira/browse/MNG-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527085#comment-17527085 ] Hudson commented on MNG-6326: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Build continues when core extensions aren't found > - > > Key: MNG-6326 > URL: https://issues.apache.org/jira/browse/MNG-6326 > Project: Maven > Issue Type: Bug > Components: Bootstrap & Build >Affects Versions: 3.5.2 >Reporter: Matt Biggs >Assignee: Guillaume Nodet >Priority: Critical > Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0 > > > If you define a core extension in *.mvn/extensions.xml* which then can't be > retrieved/found the build issues a warning and then continues leading to > unexpected behaviour depending on the functionality provided by the > extension. > If the extension is defined in the pom and not found the build fails. I would > have expected it to fail when not found in the external extensions.xml file > too as it's quite easy to miss the fact it failed to retrieve it. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7407) Introduce a ModelVersionProcessor component to make CI Friendly Versions pluggable
[ https://issues.apache.org/jira/browse/MNG-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527097#comment-17527097 ] Hudson commented on MNG-7407: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Introduce a ModelVersionProcessor component to make CI Friendly Versions > pluggable > -- > > Key: MNG-7407 > URL: https://issues.apache.org/jira/browse/MNG-7407 > Project: Maven > Issue Type: New Feature >Affects Versions: 3.8.4 >Reporter: Christoph Läubrich >Assignee: Michael Osipov >Priority: Major > Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0 > > > Currently the handling for https://maven.apache.org/maven-ci-friendly.html is > hard wired into maven. > For Tycho we like to replace/extend the default handling for this to supply > the user with some automatic derived values for some of the variables. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-6826) Remove condition check for JDK8+ in FileSizeFormatTest
[ https://issues.apache.org/jira/browse/MNG-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527108#comment-17527108 ] Hudson commented on MNG-6826: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Remove condition check for JDK8+ in FileSizeFormatTest > -- > > Key: MNG-6826 > URL: https://issues.apache.org/jira/browse/MNG-6826 > Project: Maven > Issue Type: Improvement > Components: Bootstrap & Build >Affects Versions: 3.6.3 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Trivial > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > Conditions to check for JDK8+ in FileSizeFormatTest test cases are obsolete > with the lift to JDK8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7428) Upgrade Maven Parent to 35
[ https://issues.apache.org/jira/browse/MNG-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527103#comment-17527103 ] Hudson commented on MNG-7428: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Upgrade Maven Parent to 35 > -- > > Key: MNG-7428 > URL: https://issues.apache.org/jira/browse/MNG-7428 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7413) Fix POM model documentation confusion on report plugins, distribution repository and profile build
[
https://issues.apache.org/jira/browse/MNG-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527113#comment-17527113
]
Hudson commented on MNG-7413:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Fix POM model documentation confusion on report plugins, distribution
> repository and profile build
> --
>
> Key: MNG-7413
> URL: https://issues.apache.org/jira/browse/MNG-7413
> Project: Maven
> Issue Type: Bug
> Components: Documentation: General, POM
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Minor
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> after upgrading Modello to 2.0.0, it detected following conflicts in POM
> documentation:
> {noformat}
> [warn] model class repository/org.apache.maven.model.Repository with tagName
> repository gets duplicate anchorName class_repository, conflicting with model
> class repository/org.apache.maven.model.DeploymentRepository
> [warn] model class plugin/org.apache.maven.model.ReportPlugin with tagName
> plugin gets duplicate anchorName class_plugin, conflicting with model class
> plugin/org.apache.maven.model.Plugin
> [warn] model class build/org.apache.maven.model.BuildBase with tagName build
> gets duplicate anchorName class_build, conflicting with model class
> build/org.apache.maven.model.Build
> {noformat}
> it corresponds to:
> - "repository" link
> https://maven.apache.org/ref/3.6.3/maven-model/maven.html#class_repository is
> the same for project/repository, but also for
> distributionManagement/repository which does not have same fields
> - "plugin" link
> https://maven.apache.org/ref/3.6.3/maven-model/maven.html#class_plugin is the
> same from build plugin but also report plugin which does not have same fields
> - 'build" link
> https://maven.apache.org/ref/3.6.3/maven-model/maven.html#class_build is for
> build and profile/build
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7385) Improve documentation on repository metadata
[ https://issues.apache.org/jira/browse/MNG-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527091#comment-17527091 ] Hudson commented on MNG-7385: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Improve documentation on repository metadata > > > Key: MNG-7385 > URL: https://issues.apache.org/jira/browse/MNG-7385 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Affects Versions: 3.8.4 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0 > > > working on MNG-7375, it is clear that current documentation on repository > metadata (I wrote in 2020...) needs more details: > https://maven.apache.org/ref/3.8.4/maven-repository-metadata/index.html > and there is one specific question to document: given > [org.apache.maven.artifact.repository.metadata.GroupRepositoryMetadata|https://maven.apache.org/ref/3.8.4/maven-compat/apidocs/org/apache/maven/artifact/repository/metadata/GroupRepositoryMetadata.html] > has been put in maven-compat, it seems it means that plugins information is > considered "compat" only and will be removed in the future > => we need to confirm and document (for example by marking some generated > classes as deprecated) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7347) SessionScoped beans should be singletons for a given session
[ https://issues.apache.org/jira/browse/MNG-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527086#comment-17527086 ] Hudson commented on MNG-7347: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > SessionScoped beans should be singletons for a given session > > > Key: MNG-7347 > URL: https://issues.apache.org/jira/browse/MNG-7347 > Project: Maven > Issue Type: Bug >Affects Versions: 3.8.4 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-5561) Plugin relocation loses configuration
[
https://issues.apache.org/jira/browse/MNG-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527083#comment-17527083
]
Hudson commented on MNG-5561:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Plugin relocation loses configuration
> -
>
> Key: MNG-5561
> URL: https://issues.apache.org/jira/browse/MNG-5561
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle
>Affects Versions: 3.1.1
>Reporter: Julien CARSIQUE
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
> Attachments: screenshot-1.png
>
>
> Hi,
> Applying a relocation on a plugin seems to lose its configuration.
> In the following sample, I relocated "nuxeo-distribution-tools" to
> "ant-assembly-maven-plugin" and the missing configured parameter is
> "buildFile". The relocation itself went well but the execution fails because
> of a missing parameter.
> {code:title=~/.m2/repository/org/nuxeo/build/nuxeo-distribution-tools/2.0-SNAPSHOT/nuxeo-distribution-tools-2.0-SNAPSHOT.pom}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd";>
> 4.0.0
> org.nuxeo.build
> nuxeo-distribution-tools
> 2.0-SNAPSHOT
> maven-plugin
> Nuxeo Distribution Build
> Assemble Nuxeo distributions
>
>
> ant-assembly-maven-plugin
>
>
> {code}
> {code:title=executed POM extract}
>
>
>
> org.nuxeo.build
>
> nuxeo-distribution-tools
>
>
>
>
> assemble
> package
>
>
> src/main/assemble/assembly.xml
>
>
> build
>
>
>
>
>
>
> {code}
> Here is the diff between an "mvn package -X" with nuxeo-distribution-tools
> (ie: with relocation; line starting with "<") and another one with
> ant-assembly-maven-plugin (ie: without relocation; line starting with ">"):
> {noformat}< [DEBUG] Dependency collection stats:
> {ConflictMarker.analyzeTime=1, ConflictMarker.markTime=0,
> ConflictMarker.nodeCount=72, ConflictIdSorter.graphTime=0,
> ConflictIdSorter.topsortTime=0, ConflictIdSorter.conflictIdCount=34,
> ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=1,
> ConflictResolver.conflictItemCount=71,
> DefaultDependencyCollector.collectTime=10,
> DefaultDependencyCollector.transformTime=2}
> > [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=1,
> > ConflictMarker.markTime=0, ConflictMarker.nodeCount=72,
> > ConflictIdSorter.graphTime=0, ConflictIdSorter.topsortTime=0,
> > ConflictIdSorter.conflictIdCount=34,
> > ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2,
> > ConflictResolver.conflictItemCount=71,
> > DefaultDependencyCollector.collectTime=65,
> > DefaultDependencyCollector.transformTime=3}
> ---
> < [DEBUG] Created new class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> < [DEBUG] Importing foreign packages into class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> > [DEBUG] Created new class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> > [DEBUG] Importing foreign packages into class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> ---
> < [DEBUG] Populating class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> > [DEBUG] Populating class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> ---
> < [DEBUG] Configuring mojo
> org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT:build from plugin
> realm
> ClassRealm[plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT,
> parent: sun.misc.Launcher$AppClassLoader@591ce4fe]
> > [DEBUG] Configuring mojo
> > org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT:build from plugin
> > realm
> > ClassRealm[plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT,
> > parent: sun.misc.Launcher$AppClassLoader@77fe0d66]
> ---
> > [DEBUG] (f) buildFile =
> > /home/julien/ws-ssd/nuxeo/nuxeo-distribution/nuxeo-distribution-resources/src/main/assemble/assembly.xml{noformat}
> The last line highlights the missing parameter.
> Indeed, it seems that in case of a relocation, all the "Parameter" Mojo
> fields take their default value (or none) whereas the "Component" fields are
> still properly injected.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7402) BuildListCalculator never detaches the classloader
[ https://issues.apache.org/jira/browse/MNG-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527100#comment-17527100 ] Hudson commented on MNG-7402: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > BuildListCalculator never detaches the classloader > -- > > Key: MNG-7402 > URL: https://issues.apache.org/jira/browse/MNG-7402 > Project: Maven > Issue Type: Bug >Affects Versions: 3.8.4 >Reporter: Christoph Läubrich >Assignee: Michael Osipov >Priority: Major > Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0 > > > https://github.com/apache/maven/blob/6b607109d3ce045106924139e96705fe7c42172e/maven-core/src/main/java/org/apache/maven/lifecycle/internal/BuildListCalculator.java#L63 > Her there is attachToThread called but never detached. This seems to be a > leak, at least the threads current contextclassloader is never restored. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7219) [Regression] plexus-cipher missing from transitive dependencies
[
https://issues.apache.org/jira/browse/MNG-7219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527067#comment-17527067
]
Hudson commented on MNG-7219:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> [Regression] plexus-cipher missing from transitive dependencies
> ---
>
> Key: MNG-7219
> URL: https://issues.apache.org/jira/browse/MNG-7219
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 3.8.2
>Reporter: Nils Breunese
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.8.3, 4.0.0-alpha-1, 4.0.0
>
>
> I have a project that uses
> {{org.apache.maven.plugin-testing:maven-plugin-testing-harness:3.3.0}} for
> testing a Maven plugin.
> After upgrading the project’s Maven dependencies from Maven 3.8.1 to 3.8.2 I
> got this error message when running tests:
> {code}
> Error injecting:
> org.sonatype.plexus.components.sec.dispatcher.DefaultSecDispatcher
> java.lang.NoClassDefFoundError:
> org/sonatype/plexus/components/cipher/PlexusCipher... 117 more
> {code}
> {{PlexusCipher}} is a class in the {{plexus-cipher}} artifact, which is a
> transitive dependency of {{maven-core}} 3.8.1:
> {code}
> [INFO] org.example:plexus-cipher-mystery:jar:1.0-SNAPSHOT
> [INFO] \- org.apache.maven:maven-core:jar:3.8.1:compile
> [INFO]+- org.apache.maven:maven-model:jar:3.8.1:compile
> [INFO]+- org.apache.maven:maven-settings:jar:3.8.1:compile
> [INFO]+- org.apache.maven:maven-settings-builder:jar:3.8.1:compile
> [INFO]| +- org.codehaus.plexus:plexus-interpolation:jar:1.25:compile
> [INFO]| \- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.4:compile
> [INFO]| \- org.sonatype.plexus:plexus-cipher:jar:1.4:compile
> [INFO]+- org.apache.maven:maven-builder-support:jar:3.8.1:compile
> (…snip…)
> {code}
> But {{plexus-cipher}} is not a transitive dependency of {{maven-core}} 3.8.2:
> {code}
> [INFO] org.example:plexus-cipher-mystery:jar:1.0-SNAPSHOT
> [INFO] \- org.apache.maven:maven-core:jar:3.8.2:compile
> [INFO]+- org.apache.maven:maven-model:jar:3.8.2:compile
> [INFO]+- org.apache.maven:maven-settings:jar:3.8.2:compile
> [INFO]+- org.apache.maven:maven-settings-builder:jar:3.8.2:compile
> [INFO]| +- org.codehaus.plexus:plexus-interpolation:jar:1.25:compile
> [INFO]| \- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.4:compile
> [INFO]+- org.apache.maven:maven-builder-support:jar:3.8.2:compile
> (…snip…)
> {code}
> Both {{maven-core}} 3.8.1 and 3.8.2 have a transitive dependency on
> {{org.sonatype.plexus:plexus-sec-dispatcher:jar:1.4}}. When using
> {{maven-core}} 3.8.1 {{plexus-sec-dispatcher}} has a dependency on
> plexus-cipher, but when using {{maven-core}} 3.8.2 it doesn’t.
> The [{{pom.xml}} of
> {{plexus-sec-dispatcher:1.4}}|https://search.maven.org/artifact/org.sonatype.plexus/plexus-sec-dispatcher/1.4/jar]
> indeed declares a dependency on {{plexus-cipher}} 1.4, but it’s not there
> when depending on {{maven-core}} 3.8.2.
> This regression was [confirmed by Michael Osipov on the Maven Users mailing
> list|https://lists.apache.org/thread.html/r7f5a62fd35dc6698c8f7097734f7c4acf4bb657d6c721e8a7bc76b8c%40%3Cusers.maven.apache.org%3E].
> He mentioned that it was caused by commit
> 41efc134a9067b58a5ab01e9b8b05d2bd84a94f0, which was done for MNG-6886
> ("upgrade plexus-cipher to 1.8 and update changed groupId"). A global
> exclusion was performed, but not all affected modules were properly updated
> (so the change wasn't complete):
> {code}
> [DEBUG] org.apache.maven:maven-settings-builder:jar:3.8.2
> [DEBUG]org.apache.maven:maven-builder-support:jar:3.8.2:compile
> [DEBUG]javax.inject:javax.inject:jar:1:compile
> [DEBUG]org.codehaus.plexus:plexus-interpolation:jar:1.25:compile
> [DEBUG]org.codehaus.plexus:plexus-utils:jar:3.2.1:compile
> [DEBUG]org.apache.maven:maven-settings:jar:3.8.2:compile
> [DEBUG]org.sonatype.plexus:plexus-sec-dispatcher:jar:1.4:compile
> (exclusions managed from [org.sonatype.plexus:plexus-cipher:*:*])
> [DEBUG]junit:junit:jar:4.12:test
> [DEBUG] org.hamcrest:hamcrest-core:jar:1.3:test (scope managed from
> compile) (version managed from 1.3)
> [INFO] org.apache.maven:maven-settings-builder:jar:3.8.2
> [INFO] +- org.apache.maven:maven-builder-support:jar:3.8.2:compile
> [INFO] +- javax.inject:javax.inject:jar:1:compile
> [INFO] +- org.codehaus.plexus:plexus-interpolation:jar:1.25:compile
> [INFO] +- org.codehaus.plexus:plexus-utils:jar:3.2.1:compile
> [INFO] +- org.apache.maven:maven-settings:jar:3.8.2:compile
> [INFO] +- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.4:compile
> [INFO] \- junit:junit:j
[jira] [Commented] (MNG-7019) Notify also at start when profile is missing
[ https://issues.apache.org/jira/browse/MNG-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527109#comment-17527109 ] Hudson commented on MNG-7019: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Notify also at start when profile is missing > > > Key: MNG-7019 > URL: https://issues.apache.org/jira/browse/MNG-7019 > Project: Maven > Issue Type: Sub-task > Components: Profiles >Affects Versions: 3.6.3 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > This will implement the first task on the list. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7156) Parallel build can cause issues between clean and forked goals
[
https://issues.apache.org/jira/browse/MNG-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527078#comment-17527078
]
Hudson commented on MNG-7156:
-
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/
> Parallel build can cause issues between clean and forked goals
> --
>
> Key: MNG-7156
> URL: https://issues.apache.org/jira/browse/MNG-7156
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> Running {{mvn -T12 clean verify -Papache-release}} From
> [https://github.com/apache/jackrabbit-filevault] leads to various exceptions
> caused by the invocation of the {{clean}} goal.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge
[ https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527101#comment-17527101 ] Hudson commented on MNG-5180: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Versioning's snapshot version list is not included in metadata merge > -- > > Key: MNG-5180 > URL: https://issues.apache.org/jira/browse/MNG-5180 > Project: Maven > Issue Type: Bug >Affects Versions: 3.0.3 >Reporter: Noam Y. Tenne >Assignee: Michael Osipov >Priority: Major > Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0 > > Attachments: MavenMetadataSnapshotVersionsMergeTest.java > > > Versioning#snapshotVersions is not being merged when using Metadata#merge. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7068) Active dependency management for Google Guice/Guava
[ https://issues.apache.org/jira/browse/MNG-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527107#comment-17527107 ] Hudson commented on MNG-7068: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/ > Active dependency management for Google Guice/Guava > --- > > Key: MNG-7068 > URL: https://issues.apache.org/jira/browse/MNG-7068 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.6.3 >Reporter: Boris Unckel >Assignee: Michael Osipov >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > The current pom includes com.google.inject:guice with the default transitive > dependency of com.google.guava:guava. Guava has declared several > dependencies, which are not needed at runtime. Only > com.google.guava:failureaccess is needed. > The proposal is first to add com.google.guava:guava to the excludes of guice. > Second guava and failureaccess shall be added as direct dependencies. > This has two advantages: Downstream projects only get the needed dependencies > and the version of guava can be independently set. > The runtime dependencies for Guava are explained in the last section of the > [README|https://github.com/google/guava/tree/v30.1] "Important Warnings" #3 -- This message was sent by Atlassian Jira (v8.20.7#820007)
