[jira] [Updated] (MINDEXER-160) Update spring and plexus-utils
[ https://issues.apache.org/jira/browse/MINDEXER-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MINDEXER-160: - Description: Upgrades: * spring (spring-demo) 5.3.19 -> 5.3.20 * plexus-utils (transitive) 3.2.0 -> 3.4.2 was: Upgrades: * spring 5.3.19 -> 5.3.20 * plexus-utils (transitive) 3.2.0 -> 3.4.2 > Update spring and plexus-utils > -- > > Key: MINDEXER-160 > URL: https://issues.apache.org/jira/browse/MINDEXER-160 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamás Cservenák >Priority: Major > Fix For: 6.2.1 > > > Upgrades: > * spring (spring-demo) 5.3.19 -> 5.3.20 > * plexus-utils (transitive) 3.2.0 -> 3.4.2 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MINDEXER-160) Update spring and plexus-utils
[ https://issues.apache.org/jira/browse/MINDEXER-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MINDEXER-160: - Summary: Update spring and plexus-utils (was: Update dependencies) > Update spring and plexus-utils > -- > > Key: MINDEXER-160 > URL: https://issues.apache.org/jira/browse/MINDEXER-160 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamás Cservenák >Priority: Major > Fix For: 6.2.1 > > > Upgrades: > * spring 5.3.19 -> 5.3.20 > * plexus-utils (transitive) 3.2.0 -> 3.4.2 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (MINDEXER-159) Upgrade maven bundle plugin to 5.1.6
[ https://issues.apache.org/jira/browse/MINDEXER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MINDEXER-159: Assignee: Tamás Cservenák > Upgrade maven bundle plugin to 5.1.6 > > > Key: MINDEXER-159 > URL: https://issues.apache.org/jira/browse/MINDEXER-159 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 6.2.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MINDEXER-160) Update dependencies
Tamás Cservenák created MINDEXER-160: Summary: Update dependencies Key: MINDEXER-160 URL: https://issues.apache.org/jira/browse/MINDEXER-160 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamás Cservenák Fix For: 6.2.1 Upgrades: * spring 5.3.19 -> 5.3.20 * plexus-utils (transitive) 3.2.0 -> 3.4.2 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli
[
https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543793#comment-17543793
]
Hans Aikema commented on MSHARED-831:
-
[~hboutemy]
{quote}I have a question for [~aikebah]: do you really use mvn clean
project-info-reports:dependencies for serious use, instead of generating the
full site?
{quote}
It was the information in the docs that got me thinking there would be
something wrong in the code of the plugin. By using one of maven's own
reporting mojos I validated that the issue (reporting section configuration not
taken into account during direct-plugin-goal-invocation) was not isolated to
our plugin. That's the only reason why I had the
project-info-reports:dependencies as a direct invocation.
I see no reason to run a reporting-plugin configured in the reporting section
outside the maven site generation for serious use.
As for the cases where there might be a good reason I see no problem in then
having to move configuration to the build/plugins section to have it taken into
account in both direct-goal invocation and site generation.
I'm perfectly fine with closing this one as a wontfix (assuming that something
resembling a docsfixed resolution is not available, otherwise that would be
more appropriate in my view - the reported issue was solved by bringing the
docs in line with the actual implementation)
As a side-note: The new text needs a typo-fix in line 635
https://github.com/apache/maven-site/blob/b3db55e331c3070e79870f96196268a4d60ad208/content/apt/guides/mini/guide-configuring-plugins.apt#L635
`Sine` should be `Since`
> Configuration in reporting section not taken into account when running from
> cli
> ---
>
> Key: MSHARED-831
> URL: https://issues.apache.org/jira/browse/MSHARED-831
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl 3.0
>Reporter: Hans Aikema
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Investigating on [https://github.com/jeremylong/DependencyCheck/issues/1444]
> my conclusion is that plugin configuration using the reporting section does
> not work as documented on
> [https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_reporting_Tag_VS_build_Tag]
> When configuring the plugin using the reporting section of the pom the
> configuration is not applied when calling the plugin goal from the CLI
> whereas the guide states that it is first looked up there and only when not
> found searched for in the build section.
> Don't know if this is the intended behaviour of the CLI-invocation of the
> plugins (and thus a documentation bug) or an actual bug in the configuration
> evaluation, but I spotted similar behaviour with the
> maven-project-info-reports-plugin
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-assembly-plugin] dependabot[bot] commented on pull request #56: Bump mockito-core from 2.28.2 to 4.5.1
dependabot[bot] commented on PR #56: URL: https://github.com/apache/maven-assembly-plugin/pull/56#issuecomment-1140699312 Superseded by #65. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] dependabot[bot] closed pull request #56: Bump mockito-core from 2.28.2 to 4.5.1
dependabot[bot] closed pull request #56: Bump mockito-core from 2.28.2 to 4.5.1 URL: https://github.com/apache/maven-assembly-plugin/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] dependabot[bot] opened a new pull request, #65: Bump mockito-core from 2.28.2 to 4.6.0
dependabot[bot] opened a new pull request, #65: URL: https://github.com/apache/maven-assembly-plugin/pull/65 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.6.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.6.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.6.0 2022-05-27 - https://github.com/mockito/mockito/compare/v4.5.1...v4.6.0";>14 commit(s) by Hervé Boutemy, K. Siva Prasad Reddy, Rafael Winterhalter, dependabot[bot] Bump shipkit-changelog from 1.1.15 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2654";>#2654)](https://github-redirect.dependabot.com/mockito/mockito/pull/2654";>mockito/mockito#2654) Bump versions.errorprone from 2.13.1 to 2.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2653";>#2653)](https://github-redirect.dependabot.com/mockito/mockito/pull/2653";>mockito/mockito#2653) Bump shipkit-auto-version from 1.1.20 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2651";>#2651)](https://github-redirect.dependabot.com/mockito/mockito/pull/2651";>mockito/mockito#2651) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648 : Add support for customising strictness via https://github.com/Mock";>@Mock annotation and MockSettings [(https://github-redirect.dependabot.com/mockito/mockito/issues/2650";>#2650)](https://github-redirect.dependabot.com/mockito/mockito/pull/2650";>mockito/mockito#2650) Any way to enable Strict Stubbing when using Mockito.mock() without using https://github.com/Mock";>@Mock? [(https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648)](https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>mockito/mockito#2648) Reintroduce inheriting type annotations from interfaces if only one interface is mocked, including additional interfaces. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2645";>#2645)](https://github-redirect.dependabot.com/mockito/mockito/pull/2645";>mockito/mockito#2645) Bump com.diffplug.spotless from 6.6.0 to 6.6.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2643";>#2643)](https://github-redirect.dependabot.com/mockito/mockito/pull/2643";>mockito/mockito#2643) fix Reproducible Build issue [(https://github-redirect.dependabot.com/mockito/mockito/issues/2642";>#2642)](https://github-redirect.dependabot.com/mockito/mockito/pull/2642";>mockito/mockito#2642) Bump com.diffplug.spotless from 6.5.2 to 6.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2641";>#2641)](https://github-redirect.dependabot.com/mockito/mockito/pull/2641";>mockito/mockito#2641) Mockito mock of interfaces lost annotation information [(https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>#2640)](https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>mockito/mockito#2640) Bump material from 1.5.0 to 1.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2637";>#2637)](https://github-redirect.dependabot.com/mockito/mockito/pull/2637";>mockito/mockito#2637) Bump com.diffplug.spotless from 6.5.1 to 6.5.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2636";>#2636)](https://github-redirect.dependabot.com/mockito/mockito/pull/2636";>mockito/mockito#2636) Bump versions.bytebuddy from 1.12.9 to 1.12.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2635";>#2635)](https://github-redirect.dependabot.com/mockito/mockito/pull/2635";>mockito/mockito#2635) Bump com.diffplug.spotless from 6.5.0 to 6.5.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2632";>#2632)](https://github-redirect.dependabot.com/mockito/mockito/pull/2632";>mockito/mockito#2632) Bump com.diffplug.spotless from 6.4.2 to 6.5.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2631";>#2631)](https://github-redirect.dependabot.com/mockito/mockito/pull/2631";>mockito/mockito#2631) v4.5.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.5.1 2022-04-21 - https://github.com/mockito/mockito/compare/v4.5.0...v4.5.1";>2 commit(s) by Jeremy Landis, dependabot[bot] Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>#2623: Use zulu distribution and java 11 for release GHA job [(https://github-redirect.dependabot.com/mockito/mockito/issues/2624";>#2624)](https://github-redirect.dependabot.com/mockito/mockito/pull/2624";>mockito/mockito#2624) Missing errorprone module for 4.5.0 in central as release was done with jdk 8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>#2623)](https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>mockito/mockito#2623) Bump kotlinVersion from 1.6.20 to 1.6.21 [(
[jira] [Commented] (SUREFIRE-2065) Test Reports Inconsistencies with Parameterized and junit4
[
https://issues.apache.org/jira/browse/SUREFIRE-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543773#comment-17543773
]
Aaron Braunstein commented on SUREFIRE-2065:
This issue also causes @ParameterizedTest
[name|https://junit.org/junit5/docs/current/api/org.junit.jupiter.params/org/junit/jupiter/params/ParameterizedTest.html#name()]
to have no effect in junit 5 tests right?
{code:java}
public static Stream params() {
return Stream.of("Hello World");
}
@ParameterizedTest(name = "{index}: {0}")
@MethodSource("params")
public void test(String param) {} {code}
Expected: test(String)[1: Hello World]
Actual: test(String)[1]
> Test Reports Inconsistencies with Parameterized and junit4
> --
>
> Key: SUREFIRE-2065
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2065
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support
>Affects Versions: 3.0.0-M5, 3.0.0-M6, 3.0.0-M7
>Reporter: Christian Marquez Grabia
>Priority: Minor
>
> Running parameterized tests with the junit-platform provider causes tests to
> be counted as single test (unlike using junit4 provider). This makes the
> tests to be marked as 'Flaky' and marks the build as successful if the retry
> failed count is greater than zero. Reports also show a single test run even
> if there were multiple tests with different parameters.
> For a sample project with the problem see
> [surefire-flaky-issue|https://github.com/chalmagr/surefire-flaky-report]
> This is also a possibly related to issue SUREFIRE-2010 and may help in the
> resolution of it.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-archetype] dependabot[bot] closed pull request #93: Bump maven-invoker-plugin from 3.2.1 to 3.2.2
dependabot[bot] closed pull request #93: Bump maven-invoker-plugin from 3.2.1 to 3.2.2 URL: https://github.com/apache/maven-archetype/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] dependabot[bot] commented on pull request #93: Bump maven-invoker-plugin from 3.2.1 to 3.2.2
dependabot[bot] commented on PR #93: URL: https://github.com/apache/maven-archetype/pull/93#issuecomment-1140683152 Superseded by #108. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] dependabot[bot] opened a new pull request, #108: Bump maven-invoker-plugin from 3.2.1 to 3.3.0
dependabot[bot] opened a new pull request, #108: URL: https://github.com/apache/maven-archetype/pull/108 Bumps [maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.2.1 to 3.3.0. Release notes Sourced from https://github.com/apache/maven-invoker-plugin/releases";>maven-invoker-plugin's releases. 3.3.0 :boom: Breaking changes https://issues.apache.org/jira/browse/MINVOKER-304";>[MINVOKER-304] - Use only common groovy modules - xml, json (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/124";>#124) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-281";>[MINVOKER-281] - java 8 as minimum (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/57";>#57) https://github.com/olamy";>@olamy 🚀 New features and improvements https://issues.apache.org/jira/browse/MINVOKER-269";>[MINVOKER-269] - Execute forked Maven in quiet mode (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/123";>#123) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-288";>[MINVOKER-288] - Failed setup job cause skip rest of jobs (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/122";>#122) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-303";>[MINVOKER-303] - Print build summary at the end after logs (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/119";>#119) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-294";>[MINVOKER-294] - Allow override mavenExecutable in invoker.properties (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/118";>#118) https://github.com/slawekjaranowski";>@slawekjaranowski 🐛 Bug Fixes https://issues.apache.org/jira/browse/MINVOKER-299";>[MINVOKER-299] - fix filtering-extensions test (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/110";>#110) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-297";>[MINVOKER-297] - NPE when non-existing Maven Home (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/104";>#104) https://github.com/slawekjaranowski";>@slawekjaranowski Fix Modello namespace (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/100";>#100) https://github.com/pzygielo";>@pzygielo https://issues.apache.org/jira/browse/MINVOKER-273";>[MINVOKER-273] - Environment variable with empty value (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/49";>#49) https://github.com/slawekjaranowski";>@slawekjaranowski 📦 Dependency updates Bump plexus-utils from 3.4.1 to 3.4.2 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/121";>#121) https://github.com/dependabot";>@dependabot https://issues.apache.org/jira/browse/MINVOKER-301";>[MINVOKER-301] - Upgrade Parent to 36 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/117";>#117) https://github.com/slawekjaranowski";>@slawekjaranowski Bump groovy-all from 3.0.9 to 3.0.10 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/108";>#108) https://github.com/dependabot";>@dependabot Bump mockito-core from 4.3.1 to 4.5.1 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/115";>#115) https://github.com/dependabot";>@dependabot Bump maven-invoker from 3.1.0 to 3.2.0 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/112";>#112) https://github.com/dependabot";>@dependabot https://issues.apache.org/jira/browse/MINVOKER-298";>[MINVOKER-298] - Upgrade Maven Reporting to 3.1.0 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/105";>#105) https://github.com/slawekjaranowski";>@slawekjaranowski Bump mockito-core from 4.2.0 to 4.3.1 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/98";>#98) https://github.com/dependabot";>@dependabot Bump slf4j-simple from 1.7.35 to 1.7.36 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/99";>#99) https://github.com/dependabot";>@dependabot Bump slf4j-simple from 1.7.33 to 1.7.35 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/93";>#93) https://github.com/dependabot";>@dependabot Bump slf4j-simple from 1.7.32 to 1.7.33 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/92";>#92) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.20.2 to 3.22.0 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/90";>#90) https://github.com/dependabot";>@dependabot Bump maven-site-plugin
[GitHub] [maven-release] dependabot[bot] commented on pull request #113: Bump mockito-core from 2.28.2 to 4.5.1
dependabot[bot] commented on PR #113: URL: https://github.com/apache/maven-release/pull/113#issuecomment-1140680168 Superseded by #137. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] dependabot[bot] closed pull request #113: Bump mockito-core from 2.28.2 to 4.5.1
dependabot[bot] closed pull request #113: Bump mockito-core from 2.28.2 to 4.5.1 URL: https://github.com/apache/maven-release/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] dependabot[bot] opened a new pull request, #137: Bump mockito-core from 2.28.2 to 4.6.0
dependabot[bot] opened a new pull request, #137: URL: https://github.com/apache/maven-release/pull/137 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.6.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.6.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.6.0 2022-05-27 - https://github.com/mockito/mockito/compare/v4.5.1...v4.6.0";>14 commit(s) by Hervé Boutemy, K. Siva Prasad Reddy, Rafael Winterhalter, dependabot[bot] Bump shipkit-changelog from 1.1.15 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2654";>#2654)](https://github-redirect.dependabot.com/mockito/mockito/pull/2654";>mockito/mockito#2654) Bump versions.errorprone from 2.13.1 to 2.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2653";>#2653)](https://github-redirect.dependabot.com/mockito/mockito/pull/2653";>mockito/mockito#2653) Bump shipkit-auto-version from 1.1.20 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2651";>#2651)](https://github-redirect.dependabot.com/mockito/mockito/pull/2651";>mockito/mockito#2651) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648 : Add support for customising strictness via https://github.com/Mock";>@Mock annotation and MockSettings [(https://github-redirect.dependabot.com/mockito/mockito/issues/2650";>#2650)](https://github-redirect.dependabot.com/mockito/mockito/pull/2650";>mockito/mockito#2650) Any way to enable Strict Stubbing when using Mockito.mock() without using https://github.com/Mock";>@Mock? [(https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648)](https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>mockito/mockito#2648) Reintroduce inheriting type annotations from interfaces if only one interface is mocked, including additional interfaces. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2645";>#2645)](https://github-redirect.dependabot.com/mockito/mockito/pull/2645";>mockito/mockito#2645) Bump com.diffplug.spotless from 6.6.0 to 6.6.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2643";>#2643)](https://github-redirect.dependabot.com/mockito/mockito/pull/2643";>mockito/mockito#2643) fix Reproducible Build issue [(https://github-redirect.dependabot.com/mockito/mockito/issues/2642";>#2642)](https://github-redirect.dependabot.com/mockito/mockito/pull/2642";>mockito/mockito#2642) Bump com.diffplug.spotless from 6.5.2 to 6.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2641";>#2641)](https://github-redirect.dependabot.com/mockito/mockito/pull/2641";>mockito/mockito#2641) Mockito mock of interfaces lost annotation information [(https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>#2640)](https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>mockito/mockito#2640) Bump material from 1.5.0 to 1.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2637";>#2637)](https://github-redirect.dependabot.com/mockito/mockito/pull/2637";>mockito/mockito#2637) Bump com.diffplug.spotless from 6.5.1 to 6.5.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2636";>#2636)](https://github-redirect.dependabot.com/mockito/mockito/pull/2636";>mockito/mockito#2636) Bump versions.bytebuddy from 1.12.9 to 1.12.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2635";>#2635)](https://github-redirect.dependabot.com/mockito/mockito/pull/2635";>mockito/mockito#2635) Bump com.diffplug.spotless from 6.5.0 to 6.5.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2632";>#2632)](https://github-redirect.dependabot.com/mockito/mockito/pull/2632";>mockito/mockito#2632) Bump com.diffplug.spotless from 6.4.2 to 6.5.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2631";>#2631)](https://github-redirect.dependabot.com/mockito/mockito/pull/2631";>mockito/mockito#2631) v4.5.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.5.1 2022-04-21 - https://github.com/mockito/mockito/compare/v4.5.0...v4.5.1";>2 commit(s) by Jeremy Landis, dependabot[bot] Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>#2623: Use zulu distribution and java 11 for release GHA job [(https://github-redirect.dependabot.com/mockito/mockito/issues/2624";>#2624)](https://github-redirect.dependabot.com/mockito/mockito/pull/2624";>mockito/mockito#2624) Missing errorprone module for 4.5.0 in central as release was done with jdk 8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>#2623)](https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>mockito/mockito#2623) Bump kotlinVersion from 1.6.20 to 1.6.21 [(https:
[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #104: Bump mockito-core from 4.2.0 to 4.5.1
dependabot[bot] closed pull request #104: Bump mockito-core from 4.2.0 to 4.5.1 URL: https://github.com/apache/maven-jlink-plugin/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #104: Bump mockito-core from 4.2.0 to 4.5.1
dependabot[bot] commented on PR #104: URL: https://github.com/apache/maven-jlink-plugin/pull/104#issuecomment-1140669632 Superseded by #108. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #108: Bump mockito-core from 4.2.0 to 4.6.0
dependabot[bot] opened a new pull request, #108: URL: https://github.com/apache/maven-jlink-plugin/pull/108 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.2.0 to 4.6.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.6.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.6.0 2022-05-27 - https://github.com/mockito/mockito/compare/v4.5.1...v4.6.0";>14 commit(s) by Hervé Boutemy, K. Siva Prasad Reddy, Rafael Winterhalter, dependabot[bot] Bump shipkit-changelog from 1.1.15 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2654";>#2654)](https://github-redirect.dependabot.com/mockito/mockito/pull/2654";>mockito/mockito#2654) Bump versions.errorprone from 2.13.1 to 2.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2653";>#2653)](https://github-redirect.dependabot.com/mockito/mockito/pull/2653";>mockito/mockito#2653) Bump shipkit-auto-version from 1.1.20 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2651";>#2651)](https://github-redirect.dependabot.com/mockito/mockito/pull/2651";>mockito/mockito#2651) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648 : Add support for customising strictness via https://github.com/Mock";>@Mock annotation and MockSettings [(https://github-redirect.dependabot.com/mockito/mockito/issues/2650";>#2650)](https://github-redirect.dependabot.com/mockito/mockito/pull/2650";>mockito/mockito#2650) Any way to enable Strict Stubbing when using Mockito.mock() without using https://github.com/Mock";>@Mock? [(https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648)](https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>mockito/mockito#2648) Reintroduce inheriting type annotations from interfaces if only one interface is mocked, including additional interfaces. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2645";>#2645)](https://github-redirect.dependabot.com/mockito/mockito/pull/2645";>mockito/mockito#2645) Bump com.diffplug.spotless from 6.6.0 to 6.6.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2643";>#2643)](https://github-redirect.dependabot.com/mockito/mockito/pull/2643";>mockito/mockito#2643) fix Reproducible Build issue [(https://github-redirect.dependabot.com/mockito/mockito/issues/2642";>#2642)](https://github-redirect.dependabot.com/mockito/mockito/pull/2642";>mockito/mockito#2642) Bump com.diffplug.spotless from 6.5.2 to 6.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2641";>#2641)](https://github-redirect.dependabot.com/mockito/mockito/pull/2641";>mockito/mockito#2641) Mockito mock of interfaces lost annotation information [(https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>#2640)](https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>mockito/mockito#2640) Bump material from 1.5.0 to 1.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2637";>#2637)](https://github-redirect.dependabot.com/mockito/mockito/pull/2637";>mockito/mockito#2637) Bump com.diffplug.spotless from 6.5.1 to 6.5.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2636";>#2636)](https://github-redirect.dependabot.com/mockito/mockito/pull/2636";>mockito/mockito#2636) Bump versions.bytebuddy from 1.12.9 to 1.12.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2635";>#2635)](https://github-redirect.dependabot.com/mockito/mockito/pull/2635";>mockito/mockito#2635) Bump com.diffplug.spotless from 6.5.0 to 6.5.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2632";>#2632)](https://github-redirect.dependabot.com/mockito/mockito/pull/2632";>mockito/mockito#2632) Bump com.diffplug.spotless from 6.4.2 to 6.5.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2631";>#2631)](https://github-redirect.dependabot.com/mockito/mockito/pull/2631";>mockito/mockito#2631) v4.5.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.5.1 2022-04-21 - https://github.com/mockito/mockito/compare/v4.5.0...v4.5.1";>2 commit(s) by Jeremy Landis, dependabot[bot] Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>#2623: Use zulu distribution and java 11 for release GHA job [(https://github-redirect.dependabot.com/mockito/mockito/issues/2624";>#2624)](https://github-redirect.dependabot.com/mockito/mockito/pull/2624";>mockito/mockito#2624) Missing errorprone module for 4.5.0 in central as release was done with jdk 8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>#2623)](https://github-redirect.dependabot.com/mockito/mockito/issues/2623";>mockito/mockito#2623) Bump kotlinVersion from 1.6.20 to 1.6.21 [(htt
[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #125: Bump mockito-core from 4.5.1 to 4.6.0
dependabot[bot] opened a new pull request, #125: URL: https://github.com/apache/maven-invoker-plugin/pull/125 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.5.1 to 4.6.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.6.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.6.0 2022-05-27 - https://github.com/mockito/mockito/compare/v4.5.1...v4.6.0";>14 commit(s) by Hervé Boutemy, K. Siva Prasad Reddy, Rafael Winterhalter, dependabot[bot] Bump shipkit-changelog from 1.1.15 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2654";>#2654)](https://github-redirect.dependabot.com/mockito/mockito/pull/2654";>mockito/mockito#2654) Bump versions.errorprone from 2.13.1 to 2.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2653";>#2653)](https://github-redirect.dependabot.com/mockito/mockito/pull/2653";>mockito/mockito#2653) Bump shipkit-auto-version from 1.1.20 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2651";>#2651)](https://github-redirect.dependabot.com/mockito/mockito/pull/2651";>mockito/mockito#2651) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648 : Add support for customising strictness via https://github.com/Mock";>@Mock annotation and MockSettings [(https://github-redirect.dependabot.com/mockito/mockito/issues/2650";>#2650)](https://github-redirect.dependabot.com/mockito/mockito/pull/2650";>mockito/mockito#2650) Any way to enable Strict Stubbing when using Mockito.mock() without using https://github.com/Mock";>@Mock? [(https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648)](https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>mockito/mockito#2648) Reintroduce inheriting type annotations from interfaces if only one interface is mocked, including additional interfaces. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2645";>#2645)](https://github-redirect.dependabot.com/mockito/mockito/pull/2645";>mockito/mockito#2645) Bump com.diffplug.spotless from 6.6.0 to 6.6.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2643";>#2643)](https://github-redirect.dependabot.com/mockito/mockito/pull/2643";>mockito/mockito#2643) fix Reproducible Build issue [(https://github-redirect.dependabot.com/mockito/mockito/issues/2642";>#2642)](https://github-redirect.dependabot.com/mockito/mockito/pull/2642";>mockito/mockito#2642) Bump com.diffplug.spotless from 6.5.2 to 6.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2641";>#2641)](https://github-redirect.dependabot.com/mockito/mockito/pull/2641";>mockito/mockito#2641) Mockito mock of interfaces lost annotation information [(https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>#2640)](https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>mockito/mockito#2640) Bump material from 1.5.0 to 1.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2637";>#2637)](https://github-redirect.dependabot.com/mockito/mockito/pull/2637";>mockito/mockito#2637) Bump com.diffplug.spotless from 6.5.1 to 6.5.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2636";>#2636)](https://github-redirect.dependabot.com/mockito/mockito/pull/2636";>mockito/mockito#2636) Bump versions.bytebuddy from 1.12.9 to 1.12.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2635";>#2635)](https://github-redirect.dependabot.com/mockito/mockito/pull/2635";>mockito/mockito#2635) Bump com.diffplug.spotless from 6.5.0 to 6.5.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2632";>#2632)](https://github-redirect.dependabot.com/mockito/mockito/pull/2632";>mockito/mockito#2632) Bump com.diffplug.spotless from 6.4.2 to 6.5.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2631";>#2631)](https://github-redirect.dependabot.com/mockito/mockito/pull/2631";>mockito/mockito#2631) Commits https://github.com/mockito/mockito/commit/93bba1171c7f41585ea8cc9c7ecc140929772124";>93bba11 Bump shipkit-changelog from 1.1.15 to 1.2.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2654";>#2654) https://github.com/mockito/mockito/commit/70cf2d2f48506fca24f16963e9c3d2223898ae5a";>70cf2d2 Add support for customizing strictness via @Mock annotation and `MockSettin... https://github.com/mockito/mockito/commit/6ce278b47367c18373572009e836056c64ac9e97";>6ce278b Bump versions.errorprone from 2.13.1 to 2.14.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2653";>#2653) https://github.com/mockito/mockito/commit/7d2e4cce07a7842eaab3e15351d1f1a89f59e122";>7d2e4cc Bump shipkit-auto-version from 1.1.20 to 1.2.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2651";>#265
[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #83: Bump maven-scm-plugin from 1.12.2 to 1.13.0
dependabot[bot] opened a new pull request, #83: URL: https://github.com/apache/maven-apache-parent/pull/83 Bumps [maven-scm-plugin](https://github.com/apache/maven-scm) from 1.12.2 to 1.13.0. Commits https://github.com/apache/maven-scm/commit/c0ec320773176b97a1bd90a2c92d4c93d15917ec";>c0ec320 [maven-release-plugin] prepare release maven-scm-1.13.0 https://github.com/apache/maven-scm/commit/021294fdb802e7722425ae81d6c9e73c9c4984f0";>021294f Rename GitInfoCommandTckTest because it is not a TCK test https://github.com/apache/maven-scm/commit/52c2cda64d476831513175e06383d4d6b87cd945";>52c2cda [SCM-980] Remove code duplication in ListMojo https://github.com/apache/maven-scm/commit/d7107dac448fa0117c35726e5ea52260340f3574";>d7107da [SCM-943] scm:check-local-modification does not support excludes https://github.com/apache/maven-scm/commit/bf86295f0369b36ec14ea29e192a13aad20003b8";>bf86295 Ignore .factorypath https://github.com/apache/maven-scm/commit/8249f5fa869cf9d4d005777b0fe5e0b9ffc1bae5";>8249f5f Style improvements https://github.com/apache/maven-scm/commit/92a09124c9a0827a694dbf54a6e96370903bf658";>92a0912 [SCM-913] NPE on ChangeSet.toString() when no mergedRevisions are set https://github.com/apache/maven-scm/commit/68dd19445310da62e046652dacdab68ce574e7da";>68dd194 Remove useless prerequisites https://github.com/apache/maven-scm/commit/718bd036eb022c6af7e908ca972f937ec4a9df16";>718bd03 [SCM-972] Deprecate SCM Logger in favor of SLF4J https://github.com/apache/maven-scm/commit/35dcd5c717a0845f46f1350d947a50d82cfff83c";>35dcd5c [SCM-978] Upgrade Maven to 3.2.5 (https://github-redirect.dependabot.com/apache/maven-scm/issues/136";>#136) Additional commits viewable in https://github.com/apache/maven-scm/compare/maven-scm-1.12.2...maven-scm-1.13.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #82: Bump maven-invoker-plugin from 3.2.2 to 3.3.0
dependabot[bot] opened a new pull request, #82: URL: https://github.com/apache/maven-apache-parent/pull/82 Bumps [maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.2.2 to 3.3.0. Release notes Sourced from https://github.com/apache/maven-invoker-plugin/releases";>maven-invoker-plugin's releases. 3.3.0 :boom: Breaking changes https://issues.apache.org/jira/browse/MINVOKER-304";>[MINVOKER-304] - Use only common groovy modules - xml, json (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/124";>#124) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-281";>[MINVOKER-281] - java 8 as minimum (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/57";>#57) https://github.com/olamy";>@olamy 🚀 New features and improvements https://issues.apache.org/jira/browse/MINVOKER-269";>[MINVOKER-269] - Execute forked Maven in quiet mode (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/123";>#123) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-288";>[MINVOKER-288] - Failed setup job cause skip rest of jobs (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/122";>#122) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-303";>[MINVOKER-303] - Print build summary at the end after logs (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/119";>#119) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-294";>[MINVOKER-294] - Allow override mavenExecutable in invoker.properties (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/118";>#118) https://github.com/slawekjaranowski";>@slawekjaranowski 🐛 Bug Fixes https://issues.apache.org/jira/browse/MINVOKER-299";>[MINVOKER-299] - fix filtering-extensions test (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/110";>#110) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MINVOKER-297";>[MINVOKER-297] - NPE when non-existing Maven Home (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/104";>#104) https://github.com/slawekjaranowski";>@slawekjaranowski Fix Modello namespace (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/100";>#100) https://github.com/pzygielo";>@pzygielo https://issues.apache.org/jira/browse/MINVOKER-273";>[MINVOKER-273] - Environment variable with empty value (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/49";>#49) https://github.com/slawekjaranowski";>@slawekjaranowski 📦 Dependency updates Bump plexus-utils from 3.4.1 to 3.4.2 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/121";>#121) https://github.com/dependabot";>@dependabot https://issues.apache.org/jira/browse/MINVOKER-301";>[MINVOKER-301] - Upgrade Parent to 36 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/117";>#117) https://github.com/slawekjaranowski";>@slawekjaranowski Bump groovy-all from 3.0.9 to 3.0.10 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/108";>#108) https://github.com/dependabot";>@dependabot Bump mockito-core from 4.3.1 to 4.5.1 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/115";>#115) https://github.com/dependabot";>@dependabot Bump maven-invoker from 3.1.0 to 3.2.0 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/112";>#112) https://github.com/dependabot";>@dependabot https://issues.apache.org/jira/browse/MINVOKER-298";>[MINVOKER-298] - Upgrade Maven Reporting to 3.1.0 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/105";>#105) https://github.com/slawekjaranowski";>@slawekjaranowski Bump mockito-core from 4.2.0 to 4.3.1 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/98";>#98) https://github.com/dependabot";>@dependabot Bump slf4j-simple from 1.7.35 to 1.7.36 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/99";>#99) https://github.com/dependabot";>@dependabot Bump slf4j-simple from 1.7.33 to 1.7.35 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/93";>#93) https://github.com/dependabot";>@dependabot Bump slf4j-simple from 1.7.32 to 1.7.33 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/92";>#92) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.20.2 to 3.22.0 (https://github-redirect.dependabot.com/apache/maven-invoker-plugin/issues/90";>#90) https://github.com/dependabot";>@dependabot Bump maven-site-plugi
[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #214: Bump checkstyle from 9.3 to 10.3
dependabot[bot] opened a new pull request, #214: URL: https://github.com/apache/maven-indexer/pull/214 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.3 to 10.3. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's releases. checkstyle-10.3 https://checkstyle.org/releasenotes.html#Release_10.3";>https://checkstyle.org/releasenotes.html#Release_10.3 checkstyle-10.2 https://checkstyle.org/releasenotes.html#Release_10.2";>https://checkstyle.org/releasenotes.html#Release_10.2 checkstyle-10.1 https://checkstyle.org/releasenotes.html#Release_10.1";>https://checkstyle.org/releasenotes.html#Release_10.1 checkstyle-10.0 https://checkstyle.org/releasenotes.html#Release_10.0";>https://checkstyle.org/releasenotes.html#Release_10.0 Commits https://github.com/checkstyle/checkstyle/commit/a6ee9b43d012c1d6476148974cdb1be7fc27c313";>a6ee9b4 [maven-release-plugin] prepare release checkstyle-10.3 https://github.com/checkstyle/checkstyle/commit/9e1c669e6942a66727635b7bb239a3ddca6bd86f";>9e1c669 doc: release notes 10.3 https://github.com/checkstyle/checkstyle/commit/cddf6a5745a2b8c9c4bfa0186cfff418ca281dcf";>cddf6a5 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11666";>#11666: Added LITERAL_CASE support for WhitespaceAfter check https://github.com/checkstyle/checkstyle/commit/3ca6f75b82b16e6c4a5a73a4387227deb0c5ff13";>3ca6f75 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11564";>#11564: Wercker service will be shutdown on October 31st, 2022 https://github.com/checkstyle/checkstyle/commit/51408f83b03311e2c4a86cb28410d4bd7b3388be";>51408f8 dependency: bump mockito-inline from 4.5.1 to 4.6.0 https://github.com/checkstyle/checkstyle/commit/45c8df0a9cc64309be470d1ba31d6cfe6ba9069c";>45c8df0 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11460";>#11460: Fixed the default behavior of SuppressoinXpathSingleFilter https://github.com/checkstyle/checkstyle/commit/b9e8362e9a58f80a6933d701f4a00c33b91bbc0a";>b9e8362 dependency: bump junit-pioneer from 1.7.0 to 1.7.1 https://github.com/checkstyle/checkstyle/commit/962865b042cd56532fcdb28a6b7124aeb98821d7";>962865b minor: Use -n instead of ! -z https://github.com/checkstyle/checkstyle/commit/14667989a7f7e0365aba835d0acef5aec58eef65";>1466798 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11637";>#11637: Used Shellcheck to resolve SC2236 in Shell Script https://github.com/checkstyle/checkstyle/commit/1f818582e13da540bef1e0cea01d2848661c183d";>1f81858 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11662";>#11662: Fixed NoSuchFileException during maven-compiler-plugin:3.10.1:t... Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.3...checkstyle-10.3";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #209: Bump checkstyle from 9.3 to 10.2
dependabot[bot] commented on PR #209: URL: https://github.com/apache/maven-indexer/pull/209#issuecomment-114071 Superseded by #214. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] closed pull request #209: Bump checkstyle from 9.3 to 10.2
dependabot[bot] closed pull request #209: Bump checkstyle from 9.3 to 10.2 URL: https://github.com/apache/maven-indexer/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wrapper] dependabot[bot] opened a new pull request, #46: Bump mockito-core from 4.5.1 to 4.6.0
dependabot[bot] opened a new pull request, #46: URL: https://github.com/apache/maven-wrapper/pull/46 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.5.1 to 4.6.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.6.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.6.0 2022-05-27 - https://github.com/mockito/mockito/compare/v4.5.1...v4.6.0";>14 commit(s) by Hervé Boutemy, K. Siva Prasad Reddy, Rafael Winterhalter, dependabot[bot] Bump shipkit-changelog from 1.1.15 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2654";>#2654)](https://github-redirect.dependabot.com/mockito/mockito/pull/2654";>mockito/mockito#2654) Bump versions.errorprone from 2.13.1 to 2.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2653";>#2653)](https://github-redirect.dependabot.com/mockito/mockito/pull/2653";>mockito/mockito#2653) Bump shipkit-auto-version from 1.1.20 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2651";>#2651)](https://github-redirect.dependabot.com/mockito/mockito/pull/2651";>mockito/mockito#2651) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648 : Add support for customising strictness via https://github.com/Mock";>@Mock annotation and MockSettings [(https://github-redirect.dependabot.com/mockito/mockito/issues/2650";>#2650)](https://github-redirect.dependabot.com/mockito/mockito/pull/2650";>mockito/mockito#2650) Any way to enable Strict Stubbing when using Mockito.mock() without using https://github.com/Mock";>@Mock? [(https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648)](https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>mockito/mockito#2648) Reintroduce inheriting type annotations from interfaces if only one interface is mocked, including additional interfaces. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2645";>#2645)](https://github-redirect.dependabot.com/mockito/mockito/pull/2645";>mockito/mockito#2645) Bump com.diffplug.spotless from 6.6.0 to 6.6.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2643";>#2643)](https://github-redirect.dependabot.com/mockito/mockito/pull/2643";>mockito/mockito#2643) fix Reproducible Build issue [(https://github-redirect.dependabot.com/mockito/mockito/issues/2642";>#2642)](https://github-redirect.dependabot.com/mockito/mockito/pull/2642";>mockito/mockito#2642) Bump com.diffplug.spotless from 6.5.2 to 6.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2641";>#2641)](https://github-redirect.dependabot.com/mockito/mockito/pull/2641";>mockito/mockito#2641) Mockito mock of interfaces lost annotation information [(https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>#2640)](https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>mockito/mockito#2640) Bump material from 1.5.0 to 1.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2637";>#2637)](https://github-redirect.dependabot.com/mockito/mockito/pull/2637";>mockito/mockito#2637) Bump com.diffplug.spotless from 6.5.1 to 6.5.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2636";>#2636)](https://github-redirect.dependabot.com/mockito/mockito/pull/2636";>mockito/mockito#2636) Bump versions.bytebuddy from 1.12.9 to 1.12.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2635";>#2635)](https://github-redirect.dependabot.com/mockito/mockito/pull/2635";>mockito/mockito#2635) Bump com.diffplug.spotless from 6.5.0 to 6.5.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2632";>#2632)](https://github-redirect.dependabot.com/mockito/mockito/pull/2632";>mockito/mockito#2632) Bump com.diffplug.spotless from 6.4.2 to 6.5.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2631";>#2631)](https://github-redirect.dependabot.com/mockito/mockito/pull/2631";>mockito/mockito#2631) Commits https://github.com/mockito/mockito/commit/93bba1171c7f41585ea8cc9c7ecc140929772124";>93bba11 Bump shipkit-changelog from 1.1.15 to 1.2.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2654";>#2654) https://github.com/mockito/mockito/commit/70cf2d2f48506fca24f16963e9c3d2223898ae5a";>70cf2d2 Add support for customizing strictness via @Mock annotation and `MockSettin... https://github.com/mockito/mockito/commit/6ce278b47367c18373572009e836056c64ac9e97";>6ce278b Bump versions.errorprone from 2.13.1 to 2.14.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2653";>#2653) https://github.com/mockito/mockito/commit/7d2e4cce07a7842eaab3e15351d1f1a89f59e122";>7d2e4cc Bump shipkit-auto-version from 1.1.20 to 1.2.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2651";>#2651) htt
[GitHub] [maven-enforcer] josephw commented on a diff in pull request #152: MENFORCER-420: cache dependencies across rules
josephw commented on code in PR #152: URL: https://github.com/apache/maven-enforcer/pull/152#discussion_r884346819 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/EnforcerRuleHelper.java: ## @@ -131,4 +132,13 @@ List getComponentList ( String role ) * @return the container */ PlexusContainer getContainer(); + +/** + * Gets a cached value, or uses the provided producer to compute it. + * + * @param key a key to identify the value stored + * @param producer a supplier for the value if it's not already present + * @return a previously-cached or freshly-computed value + */ +Object getCache( String key, Supplier producer ); Review Comment: I considered this; it's a nicer API signature. However, there's no enforcement that keys are distinct, so getting a cache response that had previously been produced by a `Supplier` of a different `` would lead to types that were inconsistent with the generics. I could make this more elaborate (e.g. passing in a `Class` and enforcing that), but I went with a version that I think makes the necessary runtime check clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINDEXER-159) Upgrade maven bundle plugin to 5.1.6
[ https://issues.apache.org/jira/browse/MINDEXER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543723#comment-17543723 ] Hudson commented on MINDEXER-159: - Build succeeded in Jenkins: Maven » Maven TLP » maven-indexer » master #39 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-indexer/job/master/39/ > Upgrade maven bundle plugin to 5.1.6 > > > Key: MINDEXER-159 > URL: https://issues.apache.org/jira/browse/MINDEXER-159 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamás Cservenák >Priority: Major > Fix For: 6.2.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (MINDEXER-159) Upgrade maven bundle plugin to 5.1.6
[ https://issues.apache.org/jira/browse/MINDEXER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MINDEXER-159. -- Resolution: Fixed > Upgrade maven bundle plugin to 5.1.6 > > > Key: MINDEXER-159 > URL: https://issues.apache.org/jira/browse/MINDEXER-159 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamás Cservenák >Priority: Major > Fix For: 6.2.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MINDEXER-159) Upgrade maven bundle plugin to 5.1.6
[ https://issues.apache.org/jira/browse/MINDEXER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MINDEXER-159. > Upgrade maven bundle plugin to 5.1.6 > > > Key: MINDEXER-159 > URL: https://issues.apache.org/jira/browse/MINDEXER-159 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamás Cservenák >Priority: Major > Fix For: 6.2.1 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-indexer] cstamas merged pull request #213: [MINDEXER-159] Update m-bundle-p
cstamas merged PR #213: URL: https://github.com/apache/maven-indexer/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINDEXER-157) After import all groups and root groups are inverted in the IndexingContext
[
https://issues.apache.org/jira/browse/MINDEXER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák updated MINDEXER-157:
-
Issue Type: Bug (was: Improvement)
> After import all groups and root groups are inverted in the IndexingContext
> ---
>
> Key: MINDEXER-157
> URL: https://issues.apache.org/jira/browse/MINDEXER-157
> Project: Maven Indexer
> Issue Type: Bug
>Reporter: Matthias Bläsing
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 6.2.1
>
>
> I investigated a regression introduced into the NetBeans codebase by the
> update of maven indexer to 6.2.0
> ([https://github.com/apache/netbeans/issues/4102)] It turned out, that maven
> indexer after loading the index needs to explicitly rebuild the group lists
> as they are not stored with the index any longer. Rebuilding on demand is not
> an option for us, so a solution using a cached version was tried.
> The idea is, that after the index is updated, the current group lists will be
> dumped into cache files and when the index is loaded from scratch, that cache
> is used to initialize all groups and root groups. This seemed to work ok, but
> the results were strange - only the root groups were returned. Debugging
> showed, that the all groups list was very short (~950 groups for maven
> central) while the root groups list was very long (~66.000 groups for maven
> central). The opposite ratio was expected.
> The issue can be traced into _DefaultIndexUpdater#loadIndexDirectory_ where
> _IndexingContext#replace_ is called with the with the wrong order or
> parameters. The declared method:
> {code:java}
> public interface IndexingContext {
> void replace( Directory directory, Set allGroups, Set
> rootGroups ) throws IOException;
> }{code}
> is called as:
> {code:java}
> private Date loadIndexDirectory( final IndexUpdateRequest updateRequest,
> final ResourceFetcher fetcher,
> final boolean merge, final String
> remoteIndexFile )
> throws IOException
> {
> // ...
> updateRequest.getIndexingContext().replace( directory,
> rootGroups, allGroups );
> // ...
> }
> {code}
> The last two parameters need to be reversed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-indexer] cstamas opened a new pull request, #213: [MINDEXER-159] Update m-bundle-p
cstamas opened a new pull request, #213: URL: https://github.com/apache/maven-indexer/pull/213 To make build reproducible --- https://issues.apache.org/jira/browse/MINDEXER-159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] br0nstein commented on pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4
br0nstein commented on PR #516: URL: https://github.com/apache/maven-surefire/pull/516#issuecomment-1140517354 @chalmagr ping for update, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINDEXER-159) Upgrade maven bundle plugin to 5.1.6
Tamás Cservenák created MINDEXER-159: Summary: Upgrade maven bundle plugin to 5.1.6 Key: MINDEXER-159 URL: https://issues.apache.org/jira/browse/MINDEXER-159 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamás Cservenák Fix For: 6.2.1 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MINDEXER-157) After import all groups and root groups are inverted in the IndexingContext
[
https://issues.apache.org/jira/browse/MINDEXER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543717#comment-17543717
]
Hudson commented on MINDEXER-157:
-
Build unstable in Jenkins: Maven » Maven TLP » maven-indexer » master #37
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-indexer/job/master/37/
> After import all groups and root groups are inverted in the IndexingContext
> ---
>
> Key: MINDEXER-157
> URL: https://issues.apache.org/jira/browse/MINDEXER-157
> Project: Maven Indexer
> Issue Type: Improvement
>Reporter: Matthias Bläsing
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 6.2.1
>
>
> I investigated a regression introduced into the NetBeans codebase by the
> update of maven indexer to 6.2.0
> ([https://github.com/apache/netbeans/issues/4102)] It turned out, that maven
> indexer after loading the index needs to explicitly rebuild the group lists
> as they are not stored with the index any longer. Rebuilding on demand is not
> an option for us, so a solution using a cached version was tried.
> The idea is, that after the index is updated, the current group lists will be
> dumped into cache files and when the index is loaded from scratch, that cache
> is used to initialize all groups and root groups. This seemed to work ok, but
> the results were strange - only the root groups were returned. Debugging
> showed, that the all groups list was very short (~950 groups for maven
> central) while the root groups list was very long (~66.000 groups for maven
> central). The opposite ratio was expected.
> The issue can be traced into _DefaultIndexUpdater#loadIndexDirectory_ where
> _IndexingContext#replace_ is called with the with the wrong order or
> parameters. The declared method:
> {code:java}
> public interface IndexingContext {
> void replace( Directory directory, Set allGroups, Set
> rootGroups ) throws IOException;
> }{code}
> is called as:
> {code:java}
> private Date loadIndexDirectory( final IndexUpdateRequest updateRequest,
> final ResourceFetcher fetcher,
> final boolean merge, final String
> remoteIndexFile )
> throws IOException
> {
> // ...
> updateRequest.getIndexingContext().replace( directory,
> rootGroups, allGroups );
> // ...
> }
> {code}
> The last two parameters need to be reversed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-release] michael-o opened a new pull request, #136: [MRELEASE-1098] Drop o.a.m.shared.release.env.ReleaseEnvironment.getL…
michael-o opened a new pull request, #136: URL: https://github.com/apache/maven-release/pull/136 …ocale() This closes #136 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINDEXER-157) After import all groups and root groups are inverted in the IndexingContext
[
https://issues.apache.org/jira/browse/MINDEXER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák closed MINDEXER-157.
> After import all groups and root groups are inverted in the IndexingContext
> ---
>
> Key: MINDEXER-157
> URL: https://issues.apache.org/jira/browse/MINDEXER-157
> Project: Maven Indexer
> Issue Type: Improvement
>Reporter: Matthias Bläsing
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 6.2.1
>
>
> I investigated a regression introduced into the NetBeans codebase by the
> update of maven indexer to 6.2.0
> ([https://github.com/apache/netbeans/issues/4102)] It turned out, that maven
> indexer after loading the index needs to explicitly rebuild the group lists
> as they are not stored with the index any longer. Rebuilding on demand is not
> an option for us, so a solution using a cached version was tried.
> The idea is, that after the index is updated, the current group lists will be
> dumped into cache files and when the index is loaded from scratch, that cache
> is used to initialize all groups and root groups. This seemed to work ok, but
> the results were strange - only the root groups were returned. Debugging
> showed, that the all groups list was very short (~950 groups for maven
> central) while the root groups list was very long (~66.000 groups for maven
> central). The opposite ratio was expected.
> The issue can be traced into _DefaultIndexUpdater#loadIndexDirectory_ where
> _IndexingContext#replace_ is called with the with the wrong order or
> parameters. The declared method:
> {code:java}
> public interface IndexingContext {
> void replace( Directory directory, Set allGroups, Set
> rootGroups ) throws IOException;
> }{code}
> is called as:
> {code:java}
> private Date loadIndexDirectory( final IndexUpdateRequest updateRequest,
> final ResourceFetcher fetcher,
> final boolean merge, final String
> remoteIndexFile )
> throws IOException
> {
> // ...
> updateRequest.getIndexingContext().replace( directory,
> rootGroups, allGroups );
> // ...
> }
> {code}
> The last two parameters need to be reversed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (MINDEXER-157) After import all groups and root groups are inverted in the IndexingContext
[
https://issues.apache.org/jira/browse/MINDEXER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák resolved MINDEXER-157.
--
Resolution: Fixed
> After import all groups and root groups are inverted in the IndexingContext
> ---
>
> Key: MINDEXER-157
> URL: https://issues.apache.org/jira/browse/MINDEXER-157
> Project: Maven Indexer
> Issue Type: Improvement
>Reporter: Matthias Bläsing
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 6.2.1
>
>
> I investigated a regression introduced into the NetBeans codebase by the
> update of maven indexer to 6.2.0
> ([https://github.com/apache/netbeans/issues/4102)] It turned out, that maven
> indexer after loading the index needs to explicitly rebuild the group lists
> as they are not stored with the index any longer. Rebuilding on demand is not
> an option for us, so a solution using a cached version was tried.
> The idea is, that after the index is updated, the current group lists will be
> dumped into cache files and when the index is loaded from scratch, that cache
> is used to initialize all groups and root groups. This seemed to work ok, but
> the results were strange - only the root groups were returned. Debugging
> showed, that the all groups list was very short (~950 groups for maven
> central) while the root groups list was very long (~66.000 groups for maven
> central). The opposite ratio was expected.
> The issue can be traced into _DefaultIndexUpdater#loadIndexDirectory_ where
> _IndexingContext#replace_ is called with the with the wrong order or
> parameters. The declared method:
> {code:java}
> public interface IndexingContext {
> void replace( Directory directory, Set allGroups, Set
> rootGroups ) throws IOException;
> }{code}
> is called as:
> {code:java}
> private Date loadIndexDirectory( final IndexUpdateRequest updateRequest,
> final ResourceFetcher fetcher,
> final boolean merge, final String
> remoteIndexFile )
> throws IOException
> {
> // ...
> updateRequest.getIndexingContext().replace( directory,
> rootGroups, allGroups );
> // ...
> }
> {code}
> The last two parameters need to be reversed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-indexer] cstamas merged pull request #211: [MINDEXER-157] After import all groups and root groups are inverted in the IndexingContext
cstamas merged PR #211: URL: https://github.com/apache/maven-indexer/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINDEXER-157) After import all groups and root groups are inverted in the IndexingContext
[
https://issues.apache.org/jira/browse/MINDEXER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák reassigned MINDEXER-157:
Assignee: Tamás Cservenák
> After import all groups and root groups are inverted in the IndexingContext
> ---
>
> Key: MINDEXER-157
> URL: https://issues.apache.org/jira/browse/MINDEXER-157
> Project: Maven Indexer
> Issue Type: Improvement
>Reporter: Matthias Bläsing
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 6.2.1
>
>
> I investigated a regression introduced into the NetBeans codebase by the
> update of maven indexer to 6.2.0
> ([https://github.com/apache/netbeans/issues/4102)] It turned out, that maven
> indexer after loading the index needs to explicitly rebuild the group lists
> as they are not stored with the index any longer. Rebuilding on demand is not
> an option for us, so a solution using a cached version was tried.
> The idea is, that after the index is updated, the current group lists will be
> dumped into cache files and when the index is loaded from scratch, that cache
> is used to initialize all groups and root groups. This seemed to work ok, but
> the results were strange - only the root groups were returned. Debugging
> showed, that the all groups list was very short (~950 groups for maven
> central) while the root groups list was very long (~66.000 groups for maven
> central). The opposite ratio was expected.
> The issue can be traced into _DefaultIndexUpdater#loadIndexDirectory_ where
> _IndexingContext#replace_ is called with the with the wrong order or
> parameters. The declared method:
> {code:java}
> public interface IndexingContext {
> void replace( Directory directory, Set allGroups, Set
> rootGroups ) throws IOException;
> }{code}
> is called as:
> {code:java}
> private Date loadIndexDirectory( final IndexUpdateRequest updateRequest,
> final ResourceFetcher fetcher,
> final boolean merge, final String
> remoteIndexFile )
> throws IOException
> {
> // ...
> updateRequest.getIndexingContext().replace( directory,
> rootGroups, allGroups );
> // ...
> }
> {code}
> The last two parameters need to be reversed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (MINDEXER-157) After import all groups and root groups are inverted in the IndexingContext
[
https://issues.apache.org/jira/browse/MINDEXER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák updated MINDEXER-157:
-
Fix Version/s: 6.2.1
> After import all groups and root groups are inverted in the IndexingContext
> ---
>
> Key: MINDEXER-157
> URL: https://issues.apache.org/jira/browse/MINDEXER-157
> Project: Maven Indexer
> Issue Type: Improvement
>Reporter: Matthias Bläsing
>Priority: Major
> Fix For: 6.2.1
>
>
> I investigated a regression introduced into the NetBeans codebase by the
> update of maven indexer to 6.2.0
> ([https://github.com/apache/netbeans/issues/4102)] It turned out, that maven
> indexer after loading the index needs to explicitly rebuild the group lists
> as they are not stored with the index any longer. Rebuilding on demand is not
> an option for us, so a solution using a cached version was tried.
> The idea is, that after the index is updated, the current group lists will be
> dumped into cache files and when the index is loaded from scratch, that cache
> is used to initialize all groups and root groups. This seemed to work ok, but
> the results were strange - only the root groups were returned. Debugging
> showed, that the all groups list was very short (~950 groups for maven
> central) while the root groups list was very long (~66.000 groups for maven
> central). The opposite ratio was expected.
> The issue can be traced into _DefaultIndexUpdater#loadIndexDirectory_ where
> _IndexingContext#replace_ is called with the with the wrong order or
> parameters. The declared method:
> {code:java}
> public interface IndexingContext {
> void replace( Directory directory, Set allGroups, Set
> rootGroups ) throws IOException;
> }{code}
> is called as:
> {code:java}
> private Date loadIndexDirectory( final IndexUpdateRequest updateRequest,
> final ResourceFetcher fetcher,
> final boolean merge, final String
> remoteIndexFile )
> throws IOException
> {
> // ...
> updateRequest.getIndexingContext().replace( directory,
> rootGroups, allGroups );
> // ...
> }
> {code}
> The last two parameters need to be reversed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1095) Upgrade Maven SCM to 1.13.0
[ https://issues.apache.org/jira/browse/MRELEASE-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543714#comment-17543714 ] Hudson commented on MRELEASE-1095: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #48 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/48/ > Upgrade Maven SCM to 1.13.0 > --- > > Key: MRELEASE-1095 > URL: https://issues.apache.org/jira/browse/MRELEASE-1095 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M6 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (MRELEASE-1098) Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale()
[ https://issues.apache.org/jira/browse/MRELEASE-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRELEASE-1098: Assignee: Michael Osipov > Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale() > > > Key: MRELEASE-1098 > URL: https://issues.apache.org/jira/browse/MRELEASE-1098 > Project: Maven Release Plugin > Issue Type: Task >Affects Versions: 3.0.0-M5 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M6 > > > No bundles are translated, all our code is English, nothing else. Other > messages aren't even externalized. It makes not sense to provide an unused > option. See also: > https://github.com/apache/maven-release/pull/135#discussion_r884282247 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRELEASE-1098) Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale()
[ https://issues.apache.org/jira/browse/MRELEASE-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543713#comment-17543713 ] Michael Osipov commented on MRELEASE-1098: -- Bundles have been removed as part of MRELEASE-1097. > Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale() > > > Key: MRELEASE-1098 > URL: https://issues.apache.org/jira/browse/MRELEASE-1098 > Project: Maven Release Plugin > Issue Type: Task >Affects Versions: 3.0.0-M5 >Reporter: Michael Osipov >Priority: Major > Fix For: 3.0.0-M6 > > > No bundles are translated, all our code is English, nothing else. Other > messages aren't even externalized. It makes not sense to provide an unused > option. See also: > https://github.com/apache/maven-release/pull/135#discussion_r884282247 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MRELEASE-1098) Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale()
[ https://issues.apache.org/jira/browse/MRELEASE-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1098: - Summary: Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale() (was: Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale() and message bundles) > Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale() > > > Key: MRELEASE-1098 > URL: https://issues.apache.org/jira/browse/MRELEASE-1098 > Project: Maven Release Plugin > Issue Type: Task >Affects Versions: 3.0.0-M5 >Reporter: Michael Osipov >Priority: Major > Fix For: 3.0.0-M6 > > > No bundles are translated, all our code is English, nothing else. Other > messages aren't even externalized. It makes not sense to provide an unused > option. See also: > https://github.com/apache/maven-release/pull/135#discussion_r884282247 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MRELEASE-1095) Upgrade Maven SCM to 1.13.0
[ https://issues.apache.org/jira/browse/MRELEASE-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1095. Resolution: Fixed Fixed with [6d588fa88f1b35051a60d2d68761a6fd3595a68d|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=6d588fa88f1b35051a60d2d68761a6fd3595a68d]. > Upgrade Maven SCM to 1.13.0 > --- > > Key: MRELEASE-1095 > URL: https://issues.apache.org/jira/browse/MRELEASE-1095 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M6 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-release] asfgit closed pull request #131: [MRELEASE-1095] Upgrade Maven SCM to 1.13.0
asfgit closed pull request #131: [MRELEASE-1095] Upgrade Maven SCM to 1.13.0 URL: https://github.com/apache/maven-release/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas commented on a diff in pull request #15: [MINSTALL-115] Install At End feature (no extension)
cstamas commented on code in PR #15:
URL:
https://github.com/apache/maven-install-plugin/pull/15#discussion_r884314134
##
src/main/java/org/apache/maven/plugins/install/InstallMojo.java:
##
@@ -94,50 +89,70 @@ public void execute()
boolean addedInstallRequest = false;
if ( skip )
{
+getPluginContext().put( INSTALL_PROCESSED_MARKER, Boolean.FALSE );
getLog().info( "Skipping artifact installation" );
}
else
{
-// CHECKSTYLE_OFF: LineLength
-ProjectInstallerRequest projectInstallerRequest =
-new ProjectInstallerRequest().setProject( project );
-// CHECKSTYLE_ON: LineLength
-
if ( !installAtEnd )
{
-installProject( session.getProjectBuildingRequest(),
projectInstallerRequest );
+installProject( project );
}
else
{
-INSTALLREQUESTS.add( projectInstallerRequest );
+getPluginContext().put( INSTALL_PROCESSED_MARKER, Boolean.TRUE
);
addedInstallRequest = true;
}
}
-boolean projectsReady = READYPROJECTSCOUNTER.incrementAndGet() ==
reactorProjects.size();
-if ( projectsReady )
+if ( allProjectsMarked() )
Review Comment:
Neglect that above. Instead: this does NOT modify the existing feature (when
it forced you to use plugin as extension), and will fix this in some newer PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MRELEASE-1096) Cleanups and updates
[ https://issues.apache.org/jira/browse/MRELEASE-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRELEASE-1096: Assignee: Michael Osipov > Cleanups and updates > > > Key: MRELEASE-1096 > URL: https://issues.apache.org/jira/browse/MRELEASE-1096 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Niels Basjes >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M6 > > > In many places old plugins and related todos are open. > Several of the integration tests still use ancient dependencies. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MRELEASE-1096) Cleanups and updates
[ https://issues.apache.org/jira/browse/MRELEASE-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1096: - Fix Version/s: 3.0.0-M6 > Cleanups and updates > > > Key: MRELEASE-1096 > URL: https://issues.apache.org/jira/browse/MRELEASE-1096 > Project: Maven Release Plugin > Issue Type: Improvement >Reporter: Niels Basjes >Priority: Major > Fix For: 3.0.0-M6 > > > In many places old plugins and related todos are open. > Several of the integration tests still use ancient dependencies. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-release] michael-o commented on pull request #132: [MRELEASE-1096] Many cleanups and updates
michael-o commented on PR #132: URL: https://github.com/apache/maven-release/pull/132#issuecomment-1140509339 @cstamas Can you have a look at those two open questions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543703#comment-17543703
]
Michael Osipov edited comment on MRELEASE-1072 at 5/29/22 7:21 PM:
---
I'm trying to figure out if it is a regression or a missing edge case, to know
if I should study the MRELEASE-988 big refactoring or if it's really about
adding new code.
Do you have a real work example visible, so I can look at dry run tests, before
digging into code, please?
was (Author: hboutemy):
I'm trying to figure out if it is a regression or a missing edge case, to know
if I should study teh MRELEASE-988 big refactoring or if it's really about
adding new code
do you have a real work example visible, so I can look at dry run tests, before
digging into code, please?
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRELEASE-1097) clarify goal vs phase terms in output and documentation
[
https://issues.apache.org/jira/browse/MRELEASE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543709#comment-17543709
]
Hudson commented on MRELEASE-1097:
--
Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #47
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/47/
> clarify goal vs phase terms in output and documentation
> ---
>
> Key: MRELEASE-1097
> URL: https://issues.apache.org/jira/browse/MRELEASE-1097
> Project: Maven Release Plugin
> Issue Type: Improvement
>Affects Versions: 3.0.0-M5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> {noformat}$ mvn release:prepare -DdryRun
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< groupId:artifactId >---
> [INFO] Building Name 1.4.2-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-release-plugin:3.0.0-M5:prepare (default-cli) @ artifactId
> ---
> [INFO] phase verify-release-configuration (dry-run)
> [INFO] starting prepare goal in dry-run mode, composed of 17 phases:
> check-poms, scm-check-modifications, check-dependency-snapshots,
> create-backup-poms, map-release-versions, input-variables,
> map-development-versions, rewrite-poms-for-release, generate-release-poms,
> run-preparation-goals, scm-commit-release, scm-tag,
> rewrite-poms-for-development, remove-release-poms, run-completion-goals,
> scm-commit-development, end-release
> {noformat}
> "phase verify-release-configuration" but "starting prepare goal in dry-run
> mode, composed of 17 phases"
> {noformat}$ mvn release:perform -DdryRun
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< groupId:artifactId >---
> [INFO] Building Name 1.4.2-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-release-plugin:3.0.0-M5:perform (default-cli) @ artifactId
> ---
> [INFO] phase verify-release-configuration (dry-run)
> [INFO] starting perform goal in dry-run mode, composed of 3 phases:
> verify-completed-prepare-phases, checkout-project-from-scm, run-perform-goals
> {noformat}
> same "phase verify-release-configuration" than previously
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-install-plugin] cstamas commented on a diff in pull request #15: [MINSTALL-115] Install At End feature (no extension)
cstamas commented on code in PR #15:
URL:
https://github.com/apache/maven-install-plugin/pull/15#discussion_r884313348
##
src/main/java/org/apache/maven/plugins/install/InstallMojo.java:
##
@@ -94,50 +89,70 @@ public void execute()
boolean addedInstallRequest = false;
if ( skip )
{
+getPluginContext().put( INSTALL_PROCESSED_MARKER, Boolean.FALSE );
getLog().info( "Skipping artifact installation" );
}
else
{
-// CHECKSTYLE_OFF: LineLength
-ProjectInstallerRequest projectInstallerRequest =
-new ProjectInstallerRequest().setProject( project );
-// CHECKSTYLE_ON: LineLength
-
if ( !installAtEnd )
{
-installProject( session.getProjectBuildingRequest(),
projectInstallerRequest );
+installProject( project );
}
else
{
-INSTALLREQUESTS.add( projectInstallerRequest );
+getPluginContext().put( INSTALL_PROCESSED_MARKER, Boolean.TRUE
);
addedInstallRequest = true;
}
}
-boolean projectsReady = READYPROJECTSCOUNTER.incrementAndGet() ==
reactorProjects.size();
-if ( projectsReady )
+if ( allProjectsMarked() )
{
-synchronized ( INSTALLREQUESTS )
+for ( MavenProject reactorProject : reactorProjects )
{
-while ( !INSTALLREQUESTS.isEmpty() )
+Map pluginContext = session.getPluginContext(
pluginDescriptor, reactorProject );
+Boolean install = (Boolean) pluginContext.get(
INSTALL_PROCESSED_MARKER );
+if ( !install )
+{
+getLog().info(
+"Project " + getProjectReferenceId( reactorProject ) +
" skipped install"
+);
Review Comment:
The message you refers to is when maven is invoked with
`-Dmaven.install.skip`, when whole m-install-p is skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884312950
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java:
##
@@ -71,11 +72,12 @@ protected ReleaseResult execute( ReleaseDescriptor
releaseDescriptor, ReleaseEnv
String goals = getGoals( releaseDescriptor );
if ( !StringUtils.isEmpty( goals ) )
{
-logInfo( result, "Executing goals '" + goals + "'..." );
-if ( logArguments && ( additionalArguments != null ) )
+logInfo( result, "Executing goals '" + buffer().strong( goals
) + "'..." );
+if ( logArguments )
{
// logging arguments may log secrets: should be activated
only on dryRun
-logInfo( result, "with additional arguments: " +
additionalArguments );
+logInfo( result, "with additional arguments: "
++ ( additionalArguments == null ? "(none)" :
additionalArguments ) );
Review Comment:
Then the test should include null and empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MRELEASE-1097) clarify goal vs phase terms in output and documentation
[
https://issues.apache.org/jira/browse/MRELEASE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy closed MRELEASE-1097.
---
Assignee: Herve Boutemy
Resolution: Fixed
done in
https://github.com/apache/maven-release/commit/6f9c8b7c798f288d78fe6d41ad4dc2705cf2b897
> clarify goal vs phase terms in output and documentation
> ---
>
> Key: MRELEASE-1097
> URL: https://issues.apache.org/jira/browse/MRELEASE-1097
> Project: Maven Release Plugin
> Issue Type: Improvement
>Affects Versions: 3.0.0-M5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> {noformat}$ mvn release:prepare -DdryRun
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< groupId:artifactId >---
> [INFO] Building Name 1.4.2-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-release-plugin:3.0.0-M5:prepare (default-cli) @ artifactId
> ---
> [INFO] phase verify-release-configuration (dry-run)
> [INFO] starting prepare goal in dry-run mode, composed of 17 phases:
> check-poms, scm-check-modifications, check-dependency-snapshots,
> create-backup-poms, map-release-versions, input-variables,
> map-development-versions, rewrite-poms-for-release, generate-release-poms,
> run-preparation-goals, scm-commit-release, scm-tag,
> rewrite-poms-for-development, remove-release-poms, run-completion-goals,
> scm-commit-development, end-release
> {noformat}
> "phase verify-release-configuration" but "starting prepare goal in dry-run
> mode, composed of 17 phases"
> {noformat}$ mvn release:perform -DdryRun
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< groupId:artifactId >---
> [INFO] Building Name 1.4.2-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-release-plugin:3.0.0-M5:perform (default-cli) @ artifactId
> ---
> [INFO] phase verify-release-configuration (dry-run)
> [INFO] starting perform goal in dry-run mode, composed of 3 phases:
> verify-completed-prepare-phases, checkout-project-from-scm, run-perform-goals
> {noformat}
> same "phase verify-release-configuration" than previously
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884312385
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java:
##
@@ -71,11 +72,12 @@ protected ReleaseResult execute( ReleaseDescriptor
releaseDescriptor, ReleaseEnv
String goals = getGoals( releaseDescriptor );
if ( !StringUtils.isEmpty( goals ) )
{
-logInfo( result, "Executing goals '" + goals + "'..." );
-if ( logArguments && ( additionalArguments != null ) )
+logInfo( result, "Executing goals '" + buffer().strong( goals
) + "'..." );
Review Comment:
same answer as the other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884312361
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java:
##
@@ -71,11 +72,12 @@ protected ReleaseResult execute( ReleaseDescriptor
releaseDescriptor, ReleaseEnv
String goals = getGoals( releaseDescriptor );
if ( !StringUtils.isEmpty( goals ) )
{
-logInfo( result, "Executing goals '" + goals + "'..." );
-if ( logArguments && ( additionalArguments != null ) )
+logInfo( result, "Executing goals '" + buffer().strong( goals
) + "'..." );
+if ( logArguments )
{
// logging arguments may log secrets: should be activated
only on dryRun
-logInfo( result, "with additional arguments: " +
additionalArguments );
+logInfo( result, "with additional arguments: "
++ ( additionalArguments == null ? "(none)" :
additionalArguments ) );
Review Comment:
yes, it happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] hboutemy merged pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
hboutemy merged PR #135: URL: https://github.com/apache/maven-release/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543703#comment-17543703
]
Herve Boutemy commented on MRELEASE-1072:
-
I'm trying to figure out if it is a regression or a missing edge case, to know
if I should study teh MRELEASE-988 big refactoring or if it's really about
adding new code
do you have a real work example visible, so I can look at dry run tests, before
digging into code, please?
> scm.tag removed for next snapshot during prepare
>
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml
[
https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7055:
Fix Version/s: (was: 3.9.0-candidate)
> Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into
> maven-metadata.xml
> -
>
> Key: MNG-7055
> URL: https://issues.apache.org/jira/browse/MNG-7055
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories, Plugins and Lifecycle
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Blocker
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Copying [~michael-o]'s comment from mailing list on HEAD with Maven core ITs:
> https://markmail.org/message/ggcioupa6yaet4xe#query:+page:1+mid:noyp5d3iyclrfgyp+state:results
> {noformat}[ERROR] Tests run: 834, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 287.261 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR]
> testitMNG3372(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
> Time elapsed: 1.5 s <<< ERROR!
> org.apache.maven.it.VerificationException:
> Exit code was non-zero: 1; command line and log =
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn
> --global-settings
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/settings.xml
> -s
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-3372/direct-using-prefix/settings.xml
> -e --batch-mode
> -Dmaven.repo.local=/net/home/osipovmi/var/Projekte/maven-integration-testing/repo
> mng3372:test
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for
> org.apache.maven.its.mng3372:project:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins [maven-clean-plugin,
> maven-resources-plugin, maven-jar-plugin, maven-compiler-plugin,
> maven-surefire-plugin, maven-install-plugin, maven-deploy-plugin,
> maven-site-plugin], you should define versions in pluginManagement section of
> your pom.xml or parent @ line 6, column 14
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
> [WARNING]
> [INFO] Downloading from central:
> file:target/null/org/apache/maven/its/mng3372/maven-metadata.xml
> [INFO] Downloading from central:
> file:target/null/org/apache/maven/plugins/maven-metadata.xml
> [INFO] Downloading from central:
> file:target/null/org/codehaus/mojo/maven-metadata.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.056 s
> [INFO] Finished at: 2020-06-04T22:03:01+02:00
> [INFO]
>
> [ERROR] No plugin found for prefix 'mng3372' in the current project and in the
> plugin groups [org.apache.maven.its.mng3372, org.apache.maven.plugins,
> org.codehaus.mojo] available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)] -> [Help 1]
> org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin
> found
> for prefix 'mng3372' in the current project and in the plugin groups
> [org.apache.maven.its.mng3372, org.apache.maven.plugins, org.codehaus.mojo]
> available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)]
> at
> org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver.resolve(DefaultPluginPrefixResolver.java:98)
> at
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.findPluginForPrefix(MojoDescriptorCreator.java:269)
> at
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.getMojoDescript{noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (MNG-7487) Fix deadlock during forked lifecycle executions
[ https://issues.apache.org/jira/browse/MNG-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7487: Issue Type: Bug (was: Improvement) > Fix deadlock during forked lifecycle executions > --- > > Key: MNG-7487 > URL: https://issues.apache.org/jira/browse/MNG-7487 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 3.8.5 >Reporter: Michael Osipov >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0 > > > As it turns out the locking for forking and aggregators is incomplete and > causes regressions like MNG-7433 in 3.8.5. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MRELEASE-1025) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files
[
https://issues.apache.org/jira/browse/MRELEASE-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MRELEASE-1025.
Fix Version/s: 3.0.0-M4
Assignee: Sylwester Lachiewicz
Resolution: Fixed
[~s...@dod.no], thanks for the confirmation.
> release:prepare and release:update-version sets line endings to crlf for all
> lines except the first and last lines of the pom.xml files
> ---
>
> Key: MRELEASE-1025
> URL: https://issues.apache.org/jira/browse/MRELEASE-1025
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 2.5.3
> Environment: debian 9.8 "stretch", amd64, openjdk 8u212-b01-1~deb9u1,
> maven 3.3.9-4
>Reporter: Steinar Bang
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Labels: debian-issue
> Fix For: 3.0.0-M4
>
>
> For these two projects
> * https://github.com/steinarb/authservice
> * https://github.com/steinarb/osgi-service
> line endings in the pom.xml files are messed up when I do
> {noformat}
> mvn release:prepare
> {noformat}
> or bump versions with e.g.
> {noformat}
> mvn --batch-mode release:update-versions -DdevelopmentVersion=1.0.2-SNAPSHOT
> {noformat}
> What happens to the line endings are:
> # First line stays at lf
> # Last line stays at lf
> # All of the intervening lines get crlf
> # The line endings were initially lf (at least they were meant to be)
> # I run the "mvn release:prepare" and "mvn:update-version" commands from a
> command line on Debian GNU/linux
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #152: MENFORCER-420: cache dependencies across rules
slawekjaranowski commented on PR #152: URL: https://github.com/apache/maven-enforcer/pull/152#issuecomment-1140499713 Please - run `mvn -Prun-its clean verify` - squash to one final commit - put jira issue in brackets square in commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1025) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files
[
https://issues.apache.org/jira/browse/MRELEASE-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543695#comment-17543695
]
Steinar Bang commented on MRELEASE-1025:
This issue has been fixed by MRELEASE-1056, which has moved
maven-release-plugin from JDom 1 to JDom 2.
I have verified that doing a release with maven-release-plugin 3.0.0-M5 does
not mess up the line endings of the pom files.
> release:prepare and release:update-version sets line endings to crlf for all
> lines except the first and last lines of the pom.xml files
> ---
>
> Key: MRELEASE-1025
> URL: https://issues.apache.org/jira/browse/MRELEASE-1025
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 2.5.3
> Environment: debian 9.8 "stretch", amd64, openjdk 8u212-b01-1~deb9u1,
> maven 3.3.9-4
>Reporter: Steinar Bang
>Priority: Major
> Labels: debian-issue
>
> For these two projects
> * https://github.com/steinarb/authservice
> * https://github.com/steinarb/osgi-service
> line endings in the pom.xml files are messed up when I do
> {noformat}
> mvn release:prepare
> {noformat}
> or bump versions with e.g.
> {noformat}
> mvn --batch-mode release:update-versions -DdevelopmentVersion=1.0.2-SNAPSHOT
> {noformat}
> What happens to the line endings are:
> # First line stays at lf
> # Last line stays at lf
> # All of the intervening lines get crlf
> # The line endings were initially lf (at least they were meant to be)
> # I run the "mvn release:prepare" and "mvn:update-version" commands from a
> command line on Debian GNU/linux
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884306441
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java:
##
@@ -71,11 +72,12 @@ protected ReleaseResult execute( ReleaseDescriptor
releaseDescriptor, ReleaseEnv
String goals = getGoals( releaseDescriptor );
if ( !StringUtils.isEmpty( goals ) )
{
-logInfo( result, "Executing goals '" + goals + "'..." );
-if ( logArguments && ( additionalArguments != null ) )
+logInfo( result, "Executing goals '" + buffer().strong( goals
) + "'..." );
+if ( logArguments )
{
// logging arguments may log secrets: should be activated
only on dryRun
-logInfo( result, "with additional arguments: " +
additionalArguments );
+logInfo( result, "with additional arguments: "
++ ( additionalArguments == null ? "(none)" :
additionalArguments ) );
Review Comment:
Stupid question: Can this string be empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7476) Display a warning when an aggregator mojo is locking other mojo executions
[ https://issues.apache.org/jira/browse/MNG-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543694#comment-17543694 ] ASF GitHub Bot commented on MNG-7476: - michael-o commented on PR #736: URL: https://github.com/apache/maven/pull/736#issuecomment-1140496544 IT aligned and blessed. > Display a warning when an aggregator mojo is locking other mojo executions > -- > > Key: MNG-7476 > URL: https://issues.apache.org/jira/browse/MNG-7476 > Project: Maven > Issue Type: Improvement >Affects Versions: 3.8.5 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven] michael-o commented on pull request #736: [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other mojos executions
michael-o commented on PR #736: URL: https://github.com/apache/maven/pull/736#issuecomment-1140496544 IT aligned and blessed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884304201
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -305,11 +300,11 @@ else if ( releaseDescriptor.isBranchCreation() )
if ( releaseDescriptor.isInteractive() )
{
-if ( messageKey == null )
+if ( messageFormat == null )
{
-messageKey = getMapversionPromptKey( releaseDescriptor
);
+messageFormat = getMapversionPromptFormat(
releaseDescriptor );
}
-String message = MessageFormat.format(
resourceBundle.getString( messageKey ), project.getName(),
+String message = MessageFormat.format( messageFormat,
project.getName(),
Review Comment:
ok, will simplify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884301513
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java:
##
@@ -71,11 +72,12 @@ protected ReleaseResult execute( ReleaseDescriptor
releaseDescriptor, ReleaseEnv
String goals = getGoals( releaseDescriptor );
if ( !StringUtils.isEmpty( goals ) )
{
-logInfo( result, "Executing goals '" + goals + "'..." );
-if ( logArguments && ( additionalArguments != null ) )
+logInfo( result, "Executing goals '" + buffer().strong( goals
) + "'..." );
+if ( logArguments )
{
// logging arguments may log secrets: should be activated
only on dryRun
-logInfo( result, "with additional arguments: " +
additionalArguments );
+logInfo( result, "with additional arguments: "
++ ( additionalArguments == null ? "" :
additionalArguments ) );
Review Comment:
Maybe this is just a matter of taste, but what about: `(none)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884304085 ## maven-release-plugin/src/it/projects/perform/MRELEASE-818/verify.groovy: ## @@ -20,7 +20,7 @@ File buildLog = new File( basedir, 'build.log' ) assert buildLog.exists() -def localCheckoutExpr = /\Q[INFO] This would be a LOCAL check out to perform the release ...\E/ +def localCheckoutExpr = /\Q[INFO] This would be a LOCAL check out to perform the release from / Review Comment: fixed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884303936
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -305,11 +300,11 @@ else if ( releaseDescriptor.isBranchCreation() )
if ( releaseDescriptor.isInteractive() )
{
-if ( messageKey == null )
+if ( messageFormat == null )
{
-messageKey = getMapversionPromptKey( releaseDescriptor
);
+messageFormat = getMapversionPromptFormat(
releaseDescriptor );
}
-String message = MessageFormat.format(
resourceBundle.getString( messageKey ), project.getName(),
+String message = MessageFormat.format( messageFormat,
project.getName(),
Review Comment:
I think this can be a `String#format()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884304018
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckoutProjectFromScm.java:
##
@@ -270,13 +270,19 @@ public ReleaseResult simulate( ReleaseDescriptor
releaseDescriptor, ReleaseEnvir
{
ReleaseResult result = new ReleaseResult();
+MavenProject rootProject = ReleaseUtil.getRootProject( reactorProjects
);
+File checkoutDirectory =
+FileUtils.resolveFile( rootProject.getBasedir(),
releaseDescriptor.getCheckoutDirectory() );
+
if ( releaseDescriptor.isLocalCheckout() )
{
-logInfo( result, "This would be a LOCAL check out to perform the
release ..." );
+logInfo( result,
+ "This would be a LOCAL check out to perform the release
from " + checkoutDirectory + "..." );
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884303955
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java:
##
@@ -71,11 +72,12 @@ protected ReleaseResult execute( ReleaseDescriptor
releaseDescriptor, ReleaseEnv
String goals = getGoals( releaseDescriptor );
if ( !StringUtils.isEmpty( goals ) )
{
-logInfo( result, "Executing goals '" + goals + "'..." );
-if ( logArguments && ( additionalArguments != null ) )
+logInfo( result, "Executing goals '" + buffer().strong( goals
) + "'..." );
+if ( logArguments )
{
// logging arguments may log secrets: should be activated
only on dryRun
-logInfo( result, "with additional arguments: " +
additionalArguments );
+logInfo( result, "with additional arguments: "
++ ( additionalArguments == null ? "" :
additionalArguments ) );
Review Comment:
you're right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884303864
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -308,9 +309,8 @@ else if ( releaseDescriptor.isBranchCreation() )
{
messageKey = getMapversionPromptKey( releaseDescriptor
);
}
-String message =
-MessageFormat.format( resourceBundle.getString(
messageKey ), project.getName(),
-projectId );
+String message = MessageFormat.format(
resourceBundle.getString( messageKey ), project.getName(),
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7476) Display a warning when an aggregator mojo is locking other mojo executions
[ https://issues.apache.org/jira/browse/MNG-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543690#comment-17543690 ] ASF GitHub Bot commented on MNG-7476: - michael-o commented on PR #736: URL: https://github.com/apache/maven/pull/736#issuecomment-1140493570 Polished commits, they are now subsequently, standalone testable (tested actually). As with previous releases I have created a JIRA issue which address the problem which in turn solves the regression. Immediately visible in the changelog. This PR works decently with the fixed IT PR. Only one open question needs to be answered by @gnodet. Will align IT as well. Thank your for the effort. > Display a warning when an aggregator mojo is locking other mojo executions > -- > > Key: MNG-7476 > URL: https://issues.apache.org/jira/browse/MNG-7476 > Project: Maven > Issue Type: Improvement >Affects Versions: 3.8.5 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven] michael-o commented on pull request #736: [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other mojos executions
michael-o commented on PR #736: URL: https://github.com/apache/maven/pull/736#issuecomment-1140493570 Polished commits, they are now subsequently, standalone testable (tested actually). As with previous releases I have created a JIRA issue which address the problem which in turn solves the regression. Immediately visible in the changelog. This PR works decently with the fixed IT PR. Only one open question needs to be answered by @gnodet. Will align IT as well. Thank your for the effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7487) Fix deadlock during forked lifecycle executions
Michael Osipov created MNG-7487: --- Summary: Fix deadlock during forked lifecycle executions Key: MNG-7487 URL: https://issues.apache.org/jira/browse/MNG-7487 Project: Maven Issue Type: Improvement Components: Core Affects Versions: 3.8.5 Reporter: Michael Osipov Assignee: Guillaume Nodet Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0 As it turns out the locking for forking and aggregators is incomplete and causes regressions like MNG-7433 in 3.8.5. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543688#comment-17543688 ] ASF GitHub Bot commented on MRESOLVER-262: -- cstamas commented on PR #182: URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1140492617 > > > How does this change the message usage when this type of information is collected by default? > > > > > > I don't quite get the question here... > > Stupid typo: memory usage I foresee minimal change, as this does not duplicates any collection, is really just new "step" instance per collect step. Still, AFAIR @khmarbaise had some benchmark framework, so would be good to compare on insanely huge projects I guess > Provide contextual data in trace data for collector invoked requests > > > Key: MRESOLVER-262 > URL: https://issues.apache.org/jira/browse/MRESOLVER-262 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > During collection several RepositoryEvents are fired, but they does not carry > any context related data regarding artifact collection. > Simplest solution would be to extend RequestTrace to provide: > * request context > * the artifact path (from root to leaf) > * leaf artifact being collected -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7476) Display a warning when an aggregator mojo is locking other mojo executions
[
https://issues.apache.org/jira/browse/MNG-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543687#comment-17543687
]
ASF GitHub Bot commented on MNG-7476:
-
michael-o commented on code in PR #736:
URL: https://github.com/apache/maven/pull/736#discussion_r884276548
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java:
##
@@ -220,20 +223,44 @@ private void execute( MavenSession session, MojoExecution
mojoExecution, Project
* TODO: ideally, the builder should take care of the ordering in a
smarter way
* TODO: and concurrency issues fixed with MNG-7157
*/
-private static class ProjectLock implements AutoCloseable
+private class ProjectLock implements AutoCloseable
{
final Lock acquiredAggregatorLock;
-final Lock acquiredProjectLock;
+final OwnerReentrantLock acquiredProjectLock;
-ProjectLock( MavenSession session, MojoDescriptor mojoDescriptor,
ReadWriteLock aggregatorLock )
+ProjectLock( MavenSession session, MojoDescriptor mojoDescriptor )
{
+mojos.put( Thread.currentThread(), mojoDescriptor );
Review Comment:
this duplicates
https://github.com/apache/maven/pull/736/files#diff-afa12cb60ed6ee8f6ad777fc0a0b4db1726b94306d7bda74f930ee95a27a9195R350.
Intended? I assume since the finally block removes, this must go and the
caller's put will remain.
> Display a warning when an aggregator mojo is locking other mojo executions
> --
>
> Key: MNG-7476
> URL: https://issues.apache.org/jira/browse/MNG-7476
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.8.5
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-resolver] cstamas commented on pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect
cstamas commented on PR #182: URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1140492617 > > > How does this change the message usage when this type of information is collected by default? > > > > > > I don't quite get the question here... > > Stupid typo: memory usage I foresee minimal change, as this does not duplicates any collection, is really just new "step" instance per collect step. Still, AFAIR @khmarbaise had some benchmark framework, so would be good to compare on insanely huge projects I guess -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #736: [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other mojos executions
michael-o commented on code in PR #736:
URL: https://github.com/apache/maven/pull/736#discussion_r884276548
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java:
##
@@ -220,20 +223,44 @@ private void execute( MavenSession session, MojoExecution
mojoExecution, Project
* TODO: ideally, the builder should take care of the ordering in a
smarter way
* TODO: and concurrency issues fixed with MNG-7157
*/
-private static class ProjectLock implements AutoCloseable
+private class ProjectLock implements AutoCloseable
{
final Lock acquiredAggregatorLock;
-final Lock acquiredProjectLock;
+final OwnerReentrantLock acquiredProjectLock;
-ProjectLock( MavenSession session, MojoDescriptor mojoDescriptor,
ReadWriteLock aggregatorLock )
+ProjectLock( MavenSession session, MojoDescriptor mojoDescriptor )
{
+mojos.put( Thread.currentThread(), mojoDescriptor );
Review Comment:
this duplicates
https://github.com/apache/maven/pull/736/files#diff-afa12cb60ed6ee8f6ad777fc0a0b4db1726b94306d7bda74f930ee95a27a9195R350.
Intended? I assume since the finally block removes, this must go and the
caller's put will remain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests
[
https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543686#comment-17543686
]
ASF GitHub Bot commented on MRESOLVER-262:
--
cstamas commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884300349
##
maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,113 @@
+package org.apache.maven.resolver.examples.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A demo class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ */
+public class ReverseTreeRepositoryListener
+extends AbstractRepositoryListener
+{
+@Override
+public void artifactResolved( RepositoryEvent event )
+{
+requireNonNull( event, "event cannot be null" );
+
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
+while ( trace != null )
+{
+if ( trace.getData() instanceof CollectStepData )
+{
+collectStepTrace = (CollectStepData) trace.getData();
+break;
+}
+trace = trace.getParent();
+}
+
+if ( collectStepTrace == null )
+{
+return;
+}
+
+Artifact resolvedArtifact = event.getArtifact();
+Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
+
+if ( isInScope( resolvedArtifact, nodeArtifact ) )
+{
+Dependency node = collectStepTrace.getNode();
+String trackingData = node.toString() + " (" +
collectStepTrace.getContext() + ")\n";
+String indent = "";
+ListIterator iter = collectStepTrace.getPath()
+.listIterator( collectStepTrace.getPath().size() );
+while ( iter.hasPrevious() )
+{
+DependencyNode curr = iter.previous();
+indent += " ";
+trackingData += indent + curr + " (" +
collectStepTrace.getContext() + ")\n";
+}
+try
+{
+Path trackingDir =
resolvedArtifact.getFile().getParentFile().toPath().resolve( ".tracking" );
+Files.createDirectories( trackingDir );
+Path trackingFile = trackingDir.resolve(
collectStepTrace.getPath().get( 0 )
+.getArtifact().toString().replace( ":", "_" ) );
+Files.write( trackingFile, trackingData.getBytes(
StandardCharsets.UTF_8 ) );
+System.out.println( trackingData );
+}
+catch ( IOException e )
+{
+throw new UncheckedIOException( e );
+}
+}
+}
+
+/**
+ * The event "artifact resolved" if fired WHENEVER an artifact is
resolved, BUT, it happens also when an artifact
+ * descriptor (model, the POM) is being built, and parent (and parent of
parent...) is being asked for. Hence, this
+ * method "filters" out in WHICH artifact are we interested in, but it
intentionally neglects extension, as
+ * ArtifactDescriptorReader modifies extension to "pom" during collect. So
all we have to rely on is GAV only.
+ */
+private boolean isInScope( Artifact artifact, Artifact nodeArtifact )
+{
+return Objects.equals( artifact
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect
cstamas commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884300349
##
maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,113 @@
+package org.apache.maven.resolver.examples.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A demo class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ */
+public class ReverseTreeRepositoryListener
+extends AbstractRepositoryListener
+{
+@Override
+public void artifactResolved( RepositoryEvent event )
+{
+requireNonNull( event, "event cannot be null" );
+
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
+while ( trace != null )
+{
+if ( trace.getData() instanceof CollectStepData )
+{
+collectStepTrace = (CollectStepData) trace.getData();
+break;
+}
+trace = trace.getParent();
+}
+
+if ( collectStepTrace == null )
+{
+return;
+}
+
+Artifact resolvedArtifact = event.getArtifact();
+Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
+
+if ( isInScope( resolvedArtifact, nodeArtifact ) )
+{
+Dependency node = collectStepTrace.getNode();
+String trackingData = node.toString() + " (" +
collectStepTrace.getContext() + ")\n";
+String indent = "";
+ListIterator iter = collectStepTrace.getPath()
+.listIterator( collectStepTrace.getPath().size() );
+while ( iter.hasPrevious() )
+{
+DependencyNode curr = iter.previous();
+indent += " ";
+trackingData += indent + curr + " (" +
collectStepTrace.getContext() + ")\n";
+}
+try
+{
+Path trackingDir =
resolvedArtifact.getFile().getParentFile().toPath().resolve( ".tracking" );
+Files.createDirectories( trackingDir );
+Path trackingFile = trackingDir.resolve(
collectStepTrace.getPath().get( 0 )
+.getArtifact().toString().replace( ":", "_" ) );
+Files.write( trackingFile, trackingData.getBytes(
StandardCharsets.UTF_8 ) );
+System.out.println( trackingData );
+}
+catch ( IOException e )
+{
+throw new UncheckedIOException( e );
+}
+}
+}
+
+/**
+ * The event "artifact resolved" if fired WHENEVER an artifact is
resolved, BUT, it happens also when an artifact
+ * descriptor (model, the POM) is being built, and parent (and parent of
parent...) is being asked for. Hence, this
+ * method "filters" out in WHICH artifact are we interested in, but it
intentionally neglects extension, as
+ * ArtifactDescriptorReader modifies extension to "pom" during collect. So
all we have to rely on is GAV only.
+ */
+private boolean isInScope( Artifact artifact, Artifact nodeArtifact )
+{
+return Objects.equals( artifact.getGroupId(),
nodeArtifact.getGroupId() )
+&& Objects.equals( artifact.getArtifactId(),
nodeArtifact.getArtifactId() )
+&& Objects.equals( artifact.getVersion(),
nodeArtifact.getVersion() );
+}
Review Comment:
No, it doe
[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests
[
https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543673#comment-17543673
]
ASF GitHub Bot commented on MRESOLVER-262:
--
cstamas commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884301868
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java:
##
@@ -290,6 +290,33 @@ public final CollectResult collectDependencies(
RepositorySystemSession session,
return result;
}
+/**
+ * Creates child {@link RequestTrace} instance from passed in {@link
RequestTrace} and parameters by creating
+ * {@link CollectStepDataImpl} instance out of passed in data. Caller must
ensure that passed in parameters are
+ * NOT affected by threading (or that there is no multi threading
involved). In other words, the passed in values
+ * should be immutable.
+ *
+ * @param trace The current trace instance.
+ * @param context The context from {@link
CollectRequest#getRequestContext()}, never {@code null}.
+ * @param pathList representing the path of dependency nodes, never
{@code null}. Caller must ensure, that this
+ *list does not change during the lifetime of the
requested {@link RequestTrace} instance. If it may
+ *change, simplest is to pass here a copy of used list.
+ * @param nodeCurrently collected node, that collector came by
following the passed in path.
+ * @return A child request trance instance, never {@code null}.
+ */
+protected RequestTrace collectStepTrace( RequestTrace trace, String
context, List path,
Review Comment:
Am least certain about this method: it does "too little" IMHO. For example,
it could just take a copy the passed in "path" parameter list, but OTOH, am
unsure how big penalty (heap, GC wise) would this introduce. Hence, am leaving
this decision (to copy or not copy the list) to subclass, as subclass should
know does it requires a copy or not, or in other words, is it multi threaded or
not.
DF for sure does not need to copy it (reason more why not to copy it here).
BF once goes to "multi threaded POM download" it may, but as I see, each thread
will have it's own context, and context carries the list, so again, I see no
need for list copy.
> Provide contextual data in trace data for collector invoked requests
>
>
> Key: MRESOLVER-262
> URL: https://issues.apache.org/jira/browse/MRESOLVER-262
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamás Cservenák
>Priority: Major
> Fix For: 1.8.1
>
>
> During collection several RepositoryEvents are fired, but they does not carry
> any context related data regarding artifact collection.
> Simplest solution would be to extend RequestTrace to provide:
> * request context
> * the artifact path (from root to leaf)
> * leaf artifact being collected
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect
cstamas commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884301868
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java:
##
@@ -290,6 +290,33 @@ public final CollectResult collectDependencies(
RepositorySystemSession session,
return result;
}
+/**
+ * Creates child {@link RequestTrace} instance from passed in {@link
RequestTrace} and parameters by creating
+ * {@link CollectStepDataImpl} instance out of passed in data. Caller must
ensure that passed in parameters are
+ * NOT affected by threading (or that there is no multi threading
involved). In other words, the passed in values
+ * should be immutable.
+ *
+ * @param trace The current trace instance.
+ * @param context The context from {@link
CollectRequest#getRequestContext()}, never {@code null}.
+ * @param pathList representing the path of dependency nodes, never
{@code null}. Caller must ensure, that this
+ *list does not change during the lifetime of the
requested {@link RequestTrace} instance. If it may
+ *change, simplest is to pass here a copy of used list.
+ * @param nodeCurrently collected node, that collector came by
following the passed in path.
+ * @return A child request trance instance, never {@code null}.
+ */
+protected RequestTrace collectStepTrace( RequestTrace trace, String
context, List path,
Review Comment:
Am least certain about this method: it does "too little" IMHO. For example,
it could just take a copy the passed in "path" parameter list, but OTOH, am
unsure how big penalty (heap, GC wise) would this introduce. Hence, am leaving
this decision (to copy or not copy the list) to subclass, as subclass should
know does it requires a copy or not, or in other words, is it multi threaded or
not.
DF for sure does not need to copy it (reason more why not to copy it here).
BF once goes to "multi threaded POM download" it may, but as I see, each thread
will have it's own context, and context carries the list, so again, I see no
need for list copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884302074
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -199,9 +201,15 @@ private void transform( ReleaseDescriptor
releaseDescriptor, ReleaseEnvironment
{
result.setStartTime( ( startTime >= 0 ) ? startTime :
System.currentTimeMillis() );
+URI root = ReleaseUtil.getRootProject( reactorProjects
).getBasedir().toURI();
+
for ( MavenProject project : reactorProjects )
{
-logInfo( result, "Transforming '" + project.getName() + "'..." );
+URI pom = project.getFile().toURI();
+logInfo( result,
+ "Transforming " + root.relativize( pom ).getPath() + ' '
Review Comment:
True, but `URI` has its problems and `Path` is a new solid API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884302026
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManagerListener.java:
##
@@ -86,16 +86,9 @@ public void goalStart( String goal, List phases )
public void phaseStart( String name )
{
-if ( goal == null || ( ( currentPhase + 1 ) >= phases.size() ) )
Review Comment:
Right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884301967 ## maven-release-plugin/src/it/projects/perform/MRELEASE-818/verify.groovy: ## @@ -20,7 +20,7 @@ File buildLog = new File( basedir, 'build.log' ) assert buildLog.exists() -def localCheckoutExpr = /\Q[INFO] This would be a LOCAL check out to perform the release ...\E/ +def localCheckoutExpr = /\Q[INFO] This would be a LOCAL check out to perform the release from / Review Comment: Note, this will fail! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests
[
https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543670#comment-17543670
]
ASF GitHub Bot commented on MRESOLVER-262:
--
cstamas commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884301868
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java:
##
@@ -290,6 +290,33 @@ public final CollectResult collectDependencies(
RepositorySystemSession session,
return result;
}
+/**
+ * Creates child {@link RequestTrace} instance from passed in {@link
RequestTrace} and parameters by creating
+ * {@link CollectStepDataImpl} instance out of passed in data. Caller must
ensure that passed in parameters are
+ * NOT affected by threading (or that there is no multi threading
involved). In other words, the passed in values
+ * should be immutable.
+ *
+ * @param trace The current trace instance.
+ * @param context The context from {@link
CollectRequest#getRequestContext()}, never {@code null}.
+ * @param pathList representing the path of dependency nodes, never
{@code null}. Caller must ensure, that this
+ *list does not change during the lifetime of the
requested {@link RequestTrace} instance. If it may
+ *change, simplest is to pass here a copy of used list.
+ * @param nodeCurrently collected node, that collector came by
following the passed in path.
+ * @return A child request trance instance, never {@code null}.
+ */
+protected RequestTrace collectStepTrace( RequestTrace trace, String
context, List path,
Review Comment:
Am least certain about this method: it does "too little" IMHO. For example,
it could just take a copy the passed in "path" parameter list, but OTOH, am
unsure how big penalty (heap, GC wise) would this introduce. Hence, am leaving
this decision (to copy or not copy the list) to subclass, as subclass should
know does it requires a copy or not, or in other words, is it multi threaded or
not.
> Provide contextual data in trace data for collector invoked requests
>
>
> Key: MRESOLVER-262
> URL: https://issues.apache.org/jira/browse/MRESOLVER-262
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamás Cservenák
>Priority: Major
> Fix For: 1.8.1
>
>
> During collection several RepositoryEvents are fired, but they does not carry
> any context related data regarding artifact collection.
> Simplest solution would be to extend RequestTrace to provide:
> * request context
> * the artifact path (from root to leaf)
> * leaf artifact being collected
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect
cstamas commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884301868
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java:
##
@@ -290,6 +290,33 @@ public final CollectResult collectDependencies(
RepositorySystemSession session,
return result;
}
+/**
+ * Creates child {@link RequestTrace} instance from passed in {@link
RequestTrace} and parameters by creating
+ * {@link CollectStepDataImpl} instance out of passed in data. Caller must
ensure that passed in parameters are
+ * NOT affected by threading (or that there is no multi threading
involved). In other words, the passed in values
+ * should be immutable.
+ *
+ * @param trace The current trace instance.
+ * @param context The context from {@link
CollectRequest#getRequestContext()}, never {@code null}.
+ * @param pathList representing the path of dependency nodes, never
{@code null}. Caller must ensure, that this
+ *list does not change during the lifetime of the
requested {@link RequestTrace} instance. If it may
+ *change, simplest is to pass here a copy of used list.
+ * @param nodeCurrently collected node, that collector came by
following the passed in path.
+ * @return A child request trance instance, never {@code null}.
+ */
+protected RequestTrace collectStepTrace( RequestTrace trace, String
context, List path,
Review Comment:
Am least certain about this method: it does "too little" IMHO. For example,
it could just take a copy the passed in "path" parameter list, but OTOH, am
unsure how big penalty (heap, GC wise) would this introduce. Hence, am leaving
this decision (to copy or not copy the list) to subclass, as subclass should
know does it requires a copy or not, or in other words, is it multi threaded or
not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884301848
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhase.java:
##
@@ -99,7 +101,7 @@ private ReleaseResult runLogic( ReleaseDescriptor
releaseDescriptor, ReleaseEnvi
{
ReleaseResult result = new ReleaseResult();
-logInfo( result, "Simulating perform goals '" + getGoals(
releaseDescriptor )
+logInfo( result, "Simulating perform goals '" + buffer().strong(
getGoals( releaseDescriptor ) )
Review Comment:
Right, agreed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884301793
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -308,9 +309,8 @@ else if ( releaseDescriptor.isBranchCreation() )
{
messageKey = getMapversionPromptKey( releaseDescriptor
);
}
-String message =
-MessageFormat.format( resourceBundle.getString(
messageKey ), project.getName(),
-projectId );
+String message = MessageFormat.format(
resourceBundle.getString( messageKey ), project.getName(),
Review Comment:
https://issues.apache.org/jira/browse/MRELEASE-1098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MRELEASE-1098) Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale() and message bundles
Michael Osipov created MRELEASE-1098: Summary: Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale() and message bundles Key: MRELEASE-1098 URL: https://issues.apache.org/jira/browse/MRELEASE-1098 Project: Maven Release Plugin Issue Type: Task Affects Versions: 3.0.0-M5 Reporter: Michael Osipov Fix For: 3.0.0-M6 No bundles are translated, all our code is English, nothing else. Other messages aren't even externalized. It makes not sense to provide an unused option. See also: https://github.com/apache/maven-release/pull/135#discussion_r884282247 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884282247
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -308,9 +309,8 @@ else if ( releaseDescriptor.isBranchCreation() )
{
messageKey = getMapversionPromptKey( releaseDescriptor
);
}
-String message =
-MessageFormat.format( resourceBundle.getString(
messageKey ), project.getName(),
-projectId );
+String message = MessageFormat.format(
resourceBundle.getString( messageKey ), project.getName(),
Review Comment:
I wonder whether those bundles were of use at all during the last couple of
years. I consider them pointless because other messages are hardcoded as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884301575
##
maven-release-plugin/src/site/apt/examples/perform-release.apt.vm:
##
@@ -29,7 +29,7 @@ Perform a Release
Performing a release runs the following release phases
{{{../../maven-release-manager/#perform}by default}}:
- * Checkout from an SCM URL with optional tag
+ * Checkout from an SCM URL with optional tag to <<>>
(<<>> by default)
Review Comment:
Alright, makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884301513
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java:
##
@@ -71,11 +72,12 @@ protected ReleaseResult execute( ReleaseDescriptor
releaseDescriptor, ReleaseEnv
String goals = getGoals( releaseDescriptor );
if ( !StringUtils.isEmpty( goals ) )
{
-logInfo( result, "Executing goals '" + goals + "'..." );
-if ( logArguments && ( additionalArguments != null ) )
+logInfo( result, "Executing goals '" + buffer().strong( goals
) + "'..." );
+if ( logArguments )
{
// logging arguments may log secrets: should be activated
only on dryRun
-logInfo( result, "with additional arguments: " +
additionalArguments );
+logInfo( result, "with additional arguments: "
++ ( additionalArguments == null ? "" :
additionalArguments ) );
Review Comment:
Maybe this is just a matter of taste, but was about: `(none)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests
[
https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543669#comment-17543669
]
ASF GitHub Bot commented on MRESOLVER-262:
--
cstamas commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884300349
##
maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,113 @@
+package org.apache.maven.resolver.examples.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A demo class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ */
+public class ReverseTreeRepositoryListener
+extends AbstractRepositoryListener
+{
+@Override
+public void artifactResolved( RepositoryEvent event )
+{
+requireNonNull( event, "event cannot be null" );
+
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
+while ( trace != null )
+{
+if ( trace.getData() instanceof CollectStepData )
+{
+collectStepTrace = (CollectStepData) trace.getData();
+break;
+}
+trace = trace.getParent();
+}
+
+if ( collectStepTrace == null )
+{
+return;
+}
+
+Artifact resolvedArtifact = event.getArtifact();
+Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
+
+if ( isInScope( resolvedArtifact, nodeArtifact ) )
+{
+Dependency node = collectStepTrace.getNode();
+String trackingData = node.toString() + " (" +
collectStepTrace.getContext() + ")\n";
+String indent = "";
+ListIterator iter = collectStepTrace.getPath()
+.listIterator( collectStepTrace.getPath().size() );
+while ( iter.hasPrevious() )
+{
+DependencyNode curr = iter.previous();
+indent += " ";
+trackingData += indent + curr + " (" +
collectStepTrace.getContext() + ")\n";
+}
+try
+{
+Path trackingDir =
resolvedArtifact.getFile().getParentFile().toPath().resolve( ".tracking" );
+Files.createDirectories( trackingDir );
+Path trackingFile = trackingDir.resolve(
collectStepTrace.getPath().get( 0 )
+.getArtifact().toString().replace( ":", "_" ) );
+Files.write( trackingFile, trackingData.getBytes(
StandardCharsets.UTF_8 ) );
+System.out.println( trackingData );
+}
+catch ( IOException e )
+{
+throw new UncheckedIOException( e );
+}
+}
+}
+
+/**
+ * The event "artifact resolved" if fired WHENEVER an artifact is
resolved, BUT, it happens also when an artifact
+ * descriptor (model, the POM) is being built, and parent (and parent of
parent...) is being asked for. Hence, this
+ * method "filters" out in WHICH artifact are we interested in, but it
intentionally neglects extension, as
+ * ArtifactDescriptorReader modifies extension to "pom" during collect. So
all we have to rely on is GAV only.
+ */
+private boolean isInScope( Artifact artifact, Artifact nodeArtifact )
+{
+return Objects.equals( artifact
[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases
hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884301129
##
maven-release-plugin/src/site/apt/examples/perform-release.apt.vm:
##
@@ -29,7 +29,7 @@ Perform a Release
Performing a release runs the following release phases
{{{../../maven-release-manager/#perform}by default}}:
- * Checkout from an SCM URL with optional tag
+ * Checkout from an SCM URL with optional tag to <<>>
(<<>> by default)
Review Comment:
it is documentation, not code: in code, the official property is used
in documentation, I wrote the default value that is the concrete value that
people know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect
cstamas commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884300349
##
maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,113 @@
+package org.apache.maven.resolver.examples.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A demo class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ */
+public class ReverseTreeRepositoryListener
+extends AbstractRepositoryListener
+{
+@Override
+public void artifactResolved( RepositoryEvent event )
+{
+requireNonNull( event, "event cannot be null" );
+
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
+while ( trace != null )
+{
+if ( trace.getData() instanceof CollectStepData )
+{
+collectStepTrace = (CollectStepData) trace.getData();
+break;
+}
+trace = trace.getParent();
+}
+
+if ( collectStepTrace == null )
+{
+return;
+}
+
+Artifact resolvedArtifact = event.getArtifact();
+Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
+
+if ( isInScope( resolvedArtifact, nodeArtifact ) )
+{
+Dependency node = collectStepTrace.getNode();
+String trackingData = node.toString() + " (" +
collectStepTrace.getContext() + ")\n";
+String indent = "";
+ListIterator iter = collectStepTrace.getPath()
+.listIterator( collectStepTrace.getPath().size() );
+while ( iter.hasPrevious() )
+{
+DependencyNode curr = iter.previous();
+indent += " ";
+trackingData += indent + curr + " (" +
collectStepTrace.getContext() + ")\n";
+}
+try
+{
+Path trackingDir =
resolvedArtifact.getFile().getParentFile().toPath().resolve( ".tracking" );
+Files.createDirectories( trackingDir );
+Path trackingFile = trackingDir.resolve(
collectStepTrace.getPath().get( 0 )
+.getArtifact().toString().replace( ":", "_" ) );
+Files.write( trackingFile, trackingData.getBytes(
StandardCharsets.UTF_8 ) );
+System.out.println( trackingData );
+}
+catch ( IOException e )
+{
+throw new UncheckedIOException( e );
+}
+}
+}
+
+/**
+ * The event "artifact resolved" if fired WHENEVER an artifact is
resolved, BUT, it happens also when an artifact
+ * descriptor (model, the POM) is being built, and parent (and parent of
parent...) is being asked for. Hence, this
+ * method "filters" out in WHICH artifact are we interested in, but it
intentionally neglects extension, as
+ * ArtifactDescriptorReader modifies extension to "pom" during collect. So
all we have to rely on is GAV only.
+ */
+private boolean isInScope( Artifact artifact, Artifact nodeArtifact )
+{
+return Objects.equals( artifact.getGroupId(),
nodeArtifact.getGroupId() )
+&& Objects.equals( artifact.getArtifactId(),
nodeArtifact.getArtifactId() )
+&& Objects.equals( artifact.getVersion(),
nodeArtifact.getVersion() );
+}
Review Comment:
No, it doe
