[GitHub] [maven-fluido-skin] kwin commented on pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
kwin commented on PR #36: URL: https://github.com/apache/maven-fluido-skin/pull/36#issuecomment-1154790597 The reasoning is outlined in https://issues.apache.org/jira/browse/MSKINS-193. In short "Google must not collect data about a visitor of a site generated by maven-fluido-skin". As you can see in this PR, the external resources have been removed completely (which is even faster than delivering it from any CDN :-)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
stevecrox commented on PR #36: URL: https://github.com/apache/maven-fluido-skin/pull/36#issuecomment-1154782537 Could I ask the thinking behind the change? The facebook, pwiki and google analytic options all require external resources to function and even if those resources were bundled with the skin the functionality for social media and google parts require internet access to work. The css here references a CDN resource which should be cached by the browser so should mean it loads quickly. Which has me struggling to understand your motivation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #125: [MNG-7160] Integration test for extension classloading strategy
michael-o commented on PR #125: URL: https://github.com/apache/maven-integration-testing/pull/125#issuecomment-1154758648 Will run today again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MASFRES-55) Artifacts missing from the nexus-maven-repository-index
[ https://issues.apache.org/jira/browse/MASFRES-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MASFRES-55. - Resolution: Invalid Wrong project. > Artifacts missing from the nexus-maven-repository-index > --- > > Key: MASFRES-55 > URL: https://issues.apache.org/jira/browse/MASFRES-55 > Project: Apache Maven Resource Bundles > Issue Type: Bug > Components: apache-jar-resource-bundle >Reporter: Dave Harmon >Priority: Minor > > I downloaded a central index following the instructions from > [https://maven.apache.org/repository/central-index.html.] However some > artifacts are missing and I'm hoping someone could tell me where to find the > missing parts of the dataset. > > I downloaded the full index, all the incremental updates appear to be in the > full index. The full index has entries for all the versions of spring-boot, > but only the javadocs, sources, and modules, e.g. it has > [https://repo1.maven.org/maven2/org/springframework/spring-beans/5.3.0/spring-beans-5.3.0-javadoc.jar.sha1] > in the central index, but not > [https://repo1.maven.org/maven2/org/springframework/spring-beans/5.3.0/spring-beans-5.3.0.jar.sha1]. > > > I only need the entry for the distributable artifact, since the data exists > clearly and is accessible via other search functionality, e.g. > [https://search.maven.org/solrsearch/select?q=1:bd01e44fd597fd8e14fb4ff2bc11362305b3a0b8.] > Can someone help me understand why the data isn't in the central index and > where I might be able to find it? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-archetype] olamy merged pull request #109: adding a debug message for getRemoteCatalog
olamy merged PR #109: URL: https://github.com/apache/maven-archetype/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MASFRES-55) Artifacts missing from the nexus-maven-repository-index
Dave Harmon created MASFRES-55: -- Summary: Artifacts missing from the nexus-maven-repository-index Key: MASFRES-55 URL: https://issues.apache.org/jira/browse/MASFRES-55 Project: Apache Maven Resource Bundles Issue Type: Bug Components: apache-jar-resource-bundle Reporter: Dave Harmon I downloaded a central index following the instructions from [https://maven.apache.org/repository/central-index.html.] However some artifacts are missing and I'm hoping someone could tell me where to find the missing parts of the dataset. I downloaded the full index, all the incremental updates appear to be in the full index. The full index has entries for all the versions of spring-boot, but only the javadocs, sources, and modules, e.g. it has [https://repo1.maven.org/maven2/org/springframework/spring-beans/5.3.0/spring-beans-5.3.0-javadoc.jar.sha1] in the central index, but not [https://repo1.maven.org/maven2/org/springframework/spring-beans/5.3.0/spring-beans-5.3.0.jar.sha1]. I only need the entry for the distributable artifact, since the data exists clearly and is accessible via other search functionality, e.g. [https://search.maven.org/solrsearch/select?q=1:bd01e44fd597fd8e14fb4ff2bc11362305b3a0b8.] Can someone help me understand why the data isn't in the central index and where I might be able to find it? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #34: Mskins 191 dynamic library retrieval
stevecrox commented on PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#issuecomment-1154476408 Everything but sub menus from the topbar should now be restored and fully functional. Gone through the various integration tests compared the new/old on firefox and edge and everything seems to appear as appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (ARCHETYPE-631) allow goal.txt in integration-testing to be filtered
[
https://issues.apache.org/jira/browse/ARCHETYPE-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553794#comment-17553794
]
Slawomir Jaranowski commented on ARCHETYPE-631:
---
Do you think about {{goal.txt}} for maven-invoker-plugin ... it was removed
MINVOKER-199
> allow goal.txt in integration-testing to be filtered
>
>
> Key: ARCHETYPE-631
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-631
> Project: Maven Archetype
> Issue Type: New Feature
> Components: Creator
>Affects Versions: 3.2.1
>Reporter: Jordan Amar
>Priority: Major
>
> I need to pass on a dynamic property to the command line contained in
> goal.txt. More specifically i need to pass a maven property like "-gs
> path/to/global/settings.xml".
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (ARCHETYPE-631) allow goal.txt in integration-testing to be filtered
Jordan Amar created ARCHETYPE-631: - Summary: allow goal.txt in integration-testing to be filtered Key: ARCHETYPE-631 URL: https://issues.apache.org/jira/browse/ARCHETYPE-631 Project: Maven Archetype Issue Type: New Feature Components: Creator Affects Versions: 3.2.1 Reporter: Jordan Amar I need to pass on a dynamic property to the command line contained in goal.txt. More specifically i need to pass a maven property like "-gs path/to/global/settings.xml". -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-surefire] dependabot[bot] opened a new pull request, #546: Bump mavenVersion from 3.2.5 to 3.8.6
dependabot[bot] opened a new pull request, #546: URL: https://github.com/apache/maven-surefire/pull/546 Bumps `mavenVersion` from 3.2.5 to 3.8.6. Updates `maven-core` from 3.2.5 to 3.8.6 Release notes Sourced from https://github.com/apache/maven/releases";>maven-core's releases. 3.8.5 What's Changed [3.8.x][MNG-7156][MNG-7285] Add locking in MojoExecutor by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/628";>apache/maven#628 [MNG-6326] Make the build fail if core extensions can not be loaded by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/648";>apache/maven#648 [3.8.x][MNG-7347] SessionScoped beans should be singletons for a given session by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/653";>apache/maven#653 [3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/656";>apache/maven#656 [3.8.x][MNG-7349] Limit relocation warning message to direct dependencies only by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/657";>apache/maven#657 [3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/670";>apache/maven#670 [3.8.x][MNG-7395] - Support system-properties in extension.xml by https://github.com/laeubi";>@laeubi in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 New Contributors https://github.com/laeubi";>@laeubi made their first contribution in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 Full Changelog: https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5";>https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5 3.8.4 What's Changed [MNG-6302] logging the module count by https://github.com/rmannibucau";>@rmannibucau in https://github-redirect.dependabot.com/apache/maven/pull/136";>apache/maven#136 [MNG-6424] - Upgrade plexus-interpolation to 1.25 by https://github.com/shemic87";>@shemic87 in https://github-redirect.dependabot.com/apache/maven/pull/172";>apache/maven#172 Update Jenkins build to use Maven 3.5.4 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/179";>apache/maven#179 [MNG-6473] Update Mockito to 2.21.0 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/181";>apache/maven#181 MNG-6414 Add more Apache license headers to skip downloading license … by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/167";>apache/maven#167 [MNG-6479] Upgrade XMLUnit to 2.2.1 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/183";>apache/maven#183 Fixed typo in exception logging by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/170";>apache/maven#170 [MNG-6490] Maven fails reporting circular dependency when the depende… by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/188";>apache/maven#188 [MNG-6261] - using java File api to compare by https://github.com/fabcipriano";>@fabcipriano in https://github-redirect.dependabot.com/apache/maven/pull/192";>apache/maven#192 MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependencies() by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/193";>apache/maven#193 [MNG-6559] Fix mailing list URL by https://github.com/johnlinp";>@johnlinp in https://github-redirect.dependabot.com/apache/maven/pull/230";>apache/maven#230 [MNG-6611] Update animal-sniffer-maven-plugin to version 1.17 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/237";>apache/maven#237 [MNG-6405] Fix basedir in MavenProject.deepCopy by https://github.com/jglick";>@jglick in https://github-redirect.dependabot.com/apache/maven/pull/225";>apache/maven#225 [MNG-6655] Add support for "release" qualifier by https://github.com/michael-o";>@michael-o in https://github-redirect.dependabot.com/apache/maven/pull/249";>apache/maven#249 Always deploy snapshot from master by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/250";>apache/maven#250 [MNG-6665] toolchain.xml file should support environment variables by https://github.com/MartinKanters";>@MartinKanters in https://github-
[GitHub] [maven-gh-actions-shared] cstamas commented on pull request #46: Add more FF flags
cstamas commented on PR #46: URL: https://github.com/apache/maven-gh-actions-shared/pull/46#issuecomment-1154205558 But isn't this true even now, without this PR? As I see this is an OR condition and that area is not changed, so as I read, even now it should run steps for both, "push" and "pull_request" events... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] dependabot[bot] opened a new pull request, #39: Bump mavenVersion from 3.2.5 to 3.8.6
dependabot[bot] opened a new pull request, #39: URL: https://github.com/apache/maven-filtering/pull/39 Bumps `mavenVersion` from 3.2.5 to 3.8.6. Updates `maven-core` from 3.2.5 to 3.8.6 Release notes Sourced from https://github.com/apache/maven/releases";>maven-core's releases. 3.8.5 What's Changed [3.8.x][MNG-7156][MNG-7285] Add locking in MojoExecutor by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/628";>apache/maven#628 [MNG-6326] Make the build fail if core extensions can not be loaded by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/648";>apache/maven#648 [3.8.x][MNG-7347] SessionScoped beans should be singletons for a given session by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/653";>apache/maven#653 [3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/656";>apache/maven#656 [3.8.x][MNG-7349] Limit relocation warning message to direct dependencies only by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/657";>apache/maven#657 [3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/670";>apache/maven#670 [3.8.x][MNG-7395] - Support system-properties in extension.xml by https://github.com/laeubi";>@laeubi in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 New Contributors https://github.com/laeubi";>@laeubi made their first contribution in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 Full Changelog: https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5";>https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5 3.8.4 What's Changed [MNG-6302] logging the module count by https://github.com/rmannibucau";>@rmannibucau in https://github-redirect.dependabot.com/apache/maven/pull/136";>apache/maven#136 [MNG-6424] - Upgrade plexus-interpolation to 1.25 by https://github.com/shemic87";>@shemic87 in https://github-redirect.dependabot.com/apache/maven/pull/172";>apache/maven#172 Update Jenkins build to use Maven 3.5.4 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/179";>apache/maven#179 [MNG-6473] Update Mockito to 2.21.0 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/181";>apache/maven#181 MNG-6414 Add more Apache license headers to skip downloading license … by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/167";>apache/maven#167 [MNG-6479] Upgrade XMLUnit to 2.2.1 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/183";>apache/maven#183 Fixed typo in exception logging by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/170";>apache/maven#170 [MNG-6490] Maven fails reporting circular dependency when the depende… by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/188";>apache/maven#188 [MNG-6261] - using java File api to compare by https://github.com/fabcipriano";>@fabcipriano in https://github-redirect.dependabot.com/apache/maven/pull/192";>apache/maven#192 MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependencies() by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/193";>apache/maven#193 [MNG-6559] Fix mailing list URL by https://github.com/johnlinp";>@johnlinp in https://github-redirect.dependabot.com/apache/maven/pull/230";>apache/maven#230 [MNG-6611] Update animal-sniffer-maven-plugin to version 1.17 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/237";>apache/maven#237 [MNG-6405] Fix basedir in MavenProject.deepCopy by https://github.com/jglick";>@jglick in https://github-redirect.dependabot.com/apache/maven/pull/225";>apache/maven#225 [MNG-6655] Add support for "release" qualifier by https://github.com/michael-o";>@michael-o in https://github-redirect.dependabot.com/apache/maven/pull/249";>apache/maven#249 Always deploy snapshot from master by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/250";>apache/maven#250 [MNG-6665] toolchain.xml file should support environment variables by https://github.com/MartinKanters";>@MartinKanters in https://github-r
[jira] [Commented] (SUREFIRE-2058) Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging
[
https://issues.apache.org/jira/browse/SUREFIRE-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553681#comment-17553681
]
Richard Harris commented on SUREFIRE-2058:
--
[~zoltan.meze] yes - we've upgraded onwards to 3.0.0-M7 and the tests failures
started showing up properly and failing the builds again, so we're all good.
Thanks.
> Corrupted STDOUT by directly writing to native stream in forked JVM 1 with
> UTF-8 console logging
>
>
> Key: SUREFIRE-2058
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2058
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Zoltan Meze
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> With 3.0.0-M6 surefire and slf4j + logback, most test runs end up with:
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1. {code}
> This only affects *3.0.0-M6* (3.0.0-M5 version is working fine in test
> project).
>
> After some digging, there are two different scenarios (most likely caused by
> the same issue):
> * 2-byte character at position 1023 (or N * 1024 - 1) in log message is
> causing the following warning
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1.
> {code}
> To reproduce this issue logback (with slf4j) should be used.
> Not able to reproduce with System.out.println.
> * 4-byte character at position 1023 (or N * 1024 - 1) in log message.
> Can be reproduced with System.out.println (logback not required in this case).
> This blocks surefire entirely at (from jstack):
> {code:java}
> "fork-1-event-thread" #30 daemon prio=5 os_prio=0 cpu=32350.09ms
> elapsed=32.94s tid=0x7ff8292d7800 nid=0x3caef runnable
> [0x7ff7876f6000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.decodeString(AbstractStreamDecoder.java:350)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:322)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:196)
> at
> org.apache.maven.surefire.stream.EventDecoder.decode(EventDecoder.java:176)
> at
> org.apache.maven.plugin.surefire.extensions.EventConsumerThread.run(EventConsumerThread.java:73)
> {code}
>
> Project with reproducible tests (for both scenarios, more in README):
> [https://github.com/zoltanmeze/surefire-corrupted-channel]
>
> One workaround on M6 for now is to use different charset (instead of default
> UTF-8) or limit message size.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SUREFIRE-2058) Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging
[
https://issues.apache.org/jira/browse/SUREFIRE-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553669#comment-17553669
]
Jesse Glick commented on SUREFIRE-2058:
---
I was able to confirm that M7 fixes at least one variety of the stream
corruption problem mentioned in the plugin FAQ.
([details|https://github.com/jenkinsci/plugin-pom/pull/557#issuecomment-1154075116])
Thanks!
> Corrupted STDOUT by directly writing to native stream in forked JVM 1 with
> UTF-8 console logging
>
>
> Key: SUREFIRE-2058
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2058
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Zoltan Meze
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> With 3.0.0-M6 surefire and slf4j + logback, most test runs end up with:
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1. {code}
> This only affects *3.0.0-M6* (3.0.0-M5 version is working fine in test
> project).
>
> After some digging, there are two different scenarios (most likely caused by
> the same issue):
> * 2-byte character at position 1023 (or N * 1024 - 1) in log message is
> causing the following warning
> {code:java}
> [WARNING] Corrupted channel by directly writing to native stream in forked
> JVM 1.
> {code}
> To reproduce this issue logback (with slf4j) should be used.
> Not able to reproduce with System.out.println.
> * 4-byte character at position 1023 (or N * 1024 - 1) in log message.
> Can be reproduced with System.out.println (logback not required in this case).
> This blocks surefire entirely at (from jstack):
> {code:java}
> "fork-1-event-thread" #30 daemon prio=5 os_prio=0 cpu=32350.09ms
> elapsed=32.94s tid=0x7ff8292d7800 nid=0x3caef runnable
> [0x7ff7876f6000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.decodeString(AbstractStreamDecoder.java:350)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:322)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readString(AbstractStreamDecoder.java:196)
> at
> org.apache.maven.surefire.stream.EventDecoder.decode(EventDecoder.java:176)
> at
> org.apache.maven.plugin.surefire.extensions.EventConsumerThread.run(EventConsumerThread.java:73)
> {code}
>
> Project with reproducible tests (for both scenarios, more in README):
> [https://github.com/zoltanmeze/surefire-corrupted-channel]
>
> One workaround on M6 for now is to use different charset (instead of default
> UTF-8) or limit message size.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MENFORCER-402) RequireUpperBoundDeps now follow scope provided transitive dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553654#comment-17553654
]
Thomas Mortagne commented on MENFORCER-402:
---
> I guess this is because microprofile-metrics has it defined as a runtime
> dependency (no scope):
> https://repo1.maven.org/maven2/org/eclipse/microprofile/metrics/microprofile-metrics-api/3.0/microprofile-metrics-api-3.0.pom
It's probably the trigger, yes, but it's still a bug.
> RequireUpperBoundDeps now follow scope provided transitive dependencies
> ---
>
> Key: MENFORCER-402
> URL: https://issues.apache.org/jira/browse/MENFORCER-402
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.0.0
>Reporter: Thomas Mortagne
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.1.0
>
>
> I have a dependency on org.infinispan:infinispan-core:12.1.7.Final and
> upgrading to the enforcer plugin 3.0.0 suddenly made my module fail because
> infinispan-core have conflicting provided dependencies on
> javax.annotation-api:
> {noformat}
> Require upper bound dependencies error for
> javax.annotation:javax.annotation-api:1.3.1 [provided] paths to dependency
> are:
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-commons:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-component-processor:12.1.7.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostream:protostream-types:4.4.1.Final
> +-javax.annotation:javax.annotation-api:1.3.2 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostream:protostream-processor:4.4.1.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.2 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-commons:12.1.7.Final
> +-org.infinispan:infinispan-commons-jdk11:12.1.7.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> {noformat}
> It's not clear if this was done on purpose since I cannot find anything about
> that in the release note, but I might have missed it. Problem is that
> provided scope dependencies are not necessarily used at runtime (it's often
> used as a way to avoid making transitive a dependency you only need at build
> time) and adding an for a non-transitive dependency feels quite
> weird.
> At least if this is not a bug, it would be nice to make this behavior
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MENFORCER-402) RequireUpperBoundDeps now follow scope provided transitive dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553652#comment-17553652
]
subes commented on MENFORCER-402:
-
I guess this is because microprofile-metrics has it defined as a runtime
dependency (no scope):
[https://repo1.maven.org/maven2/org/eclipse/microprofile/metrics/microprofile-metrics-api/3.0/microprofile-metrics-api-3.0.pom]
> RequireUpperBoundDeps now follow scope provided transitive dependencies
> ---
>
> Key: MENFORCER-402
> URL: https://issues.apache.org/jira/browse/MENFORCER-402
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.0.0
>Reporter: Thomas Mortagne
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.1.0
>
>
> I have a dependency on org.infinispan:infinispan-core:12.1.7.Final and
> upgrading to the enforcer plugin 3.0.0 suddenly made my module fail because
> infinispan-core have conflicting provided dependencies on
> javax.annotation-api:
> {noformat}
> Require upper bound dependencies error for
> javax.annotation:javax.annotation-api:1.3.1 [provided] paths to dependency
> are:
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-commons:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-component-processor:12.1.7.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostream:protostream-types:4.4.1.Final
> +-javax.annotation:javax.annotation-api:1.3.2 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostream:protostream-processor:4.4.1.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.2 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-commons:12.1.7.Final
> +-org.infinispan:infinispan-commons-jdk11:12.1.7.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> {noformat}
> It's not clear if this was done on purpose since I cannot find anything about
> that in the release note, but I might have missed it. Problem is that
> provided scope dependencies are not necessarily used at runtime (it's often
> used as a way to avoid making transitive a dependency you only need at build
> time) and adding an for a non-transitive dependency feels quite
> weird.
> At least if this is not a bug, it would be nice to make this behavior
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MENFORCER-402) RequireUpperBoundDeps now follow scope provided transitive dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553611#comment-17553611
]
Thomas Mortagne commented on MENFORCER-402:
---
This definitely fixed most use cases, but I just hit the following:
{noformat}
[INFO] --- maven-enforcer-plugin:3.1.0:enforce (enforce-upper-bounds) @
xwiki-platform-legacy-eventstream-store-hibernate ---
Downloading from central:
https://repo1.maven.org/maven2/biz/aQute/bndlib/2.0.0.20130123-133441/bndlib-2.0.0.20130123-133441.pom
Downloaded from central:
https://repo1.maven.org/maven2/biz/aQute/bndlib/2.0.0.20130123-133441/bndlib-2.0.0.20130123-133441.pom
(2.0 kB at 5.7 kB/s)
Downloading from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-core/3.23.1/javaparser-core-3.23.1.pom
Downloaded from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-core/3.23.1/javaparser-core-3.23.1.pom
(4.9 kB at 106 kB/s)
Downloading from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-parent/3.23.1/javaparser-parent-3.23.1.pom
Downloaded from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-parent/3.23.1/javaparser-parent-3.23.1.pom
(22 kB at 422 kB/s)
Downloading from central:
https://repo1.maven.org/maven2/com/github/luben/zstd-jni/1.5.2-2/zstd-jni-1.5.2-2.pom
Downloaded from central:
https://repo1.maven.org/maven2/com/github/luben/zstd-jni/1.5.2-2/zstd-jni-1.5.2-2.pom
(1.9 kB at 28 kB/s)
[ERROR] Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed
with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for
jakarta.enterprise:jakarta.enterprise.cdi-api:2.0.1 [runtime] paths to
dependency are:
+-org.xwiki.platform:xwiki-platform-legacy-eventstream-store-hibernate:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-eventstream-store-common:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-oldcore:14.5-SNAPSHOT
+-jakarta.transaction:jakarta.transaction-api:1.3.3 (managed) <--
jakarta.transaction:jakarta.transaction-api:1.3.3
+-jakarta.enterprise:jakarta.enterprise.cdi-api:2.0.1 [runtime]
and
+-org.xwiki.platform:xwiki-platform-legacy-eventstream-store-hibernate:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-eventstream-store-common:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-oldcore:14.5-SNAPSHOT
+-org.xwiki.commons:xwiki-commons-cache-infinispan:14.5-SNAPSHOT [runtime]
+-org.eclipse.microprofile.metrics:microprofile-metrics-api:3.0
[runtime] (managed) <--
org.eclipse.microprofile.metrics:microprofile-metrics-api:3.0 [runtime]
+-jakarta.enterprise:jakarta.enterprise.cdi-api:2.0.2 [runtime]
{noformat}
I checked jakarta.transaction-api and jakarta.enterprise.cdi-api is scope
provided so not sure how it ended up thinking it was runtime.
> RequireUpperBoundDeps now follow scope provided transitive dependencies
> ---
>
> Key: MENFORCER-402
> URL: https://issues.apache.org/jira/browse/MENFORCER-402
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Plugin
>Affects Versions: 3.0.0
>Reporter: Thomas Mortagne
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.1.0
>
>
> I have a dependency on org.infinispan:infinispan-core:12.1.7.Final and
> upgrading to the enforcer plugin 3.0.0 suddenly made my module fail because
> infinispan-core have conflicting provided dependencies on
> javax.annotation-api:
> {noformat}
> Require upper bound dependencies error for
> javax.annotation:javax.annotation-api:1.3.1 [provided] paths to dependency
> are:
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-commons:12.1.7.Final
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan:infinispan-component-processor:12.1.7.Final [provided]
> +-javax.annotation:javax.annotation-api:1.3.1 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostream:protostream-types:4.4.1.Final
> +-javax.annotation:javax.annotation-api:1.3.2 [provided]
> and
> +-org.xwiki.commons:xwiki-commons-cache-infinispan:13.9-SNAPSHOT
> +-org.infinispan:infinispan-core:12.1.7.Final
> +-org.infinispan.protostr
[jira] [Comment Edited] (MENFORCER-402) RequireUpperBoundDeps now follow scope provided transitive dependencies
[
https://issues.apache.org/jira/browse/MENFORCER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553611#comment-17553611
]
Thomas Mortagne edited comment on MENFORCER-402 at 6/13/22 2:27 PM:
This definitely fixed most use cases, but I just hit the following:
{noformat}
[INFO] --- maven-enforcer-plugin:3.1.0:enforce (enforce-upper-bounds) @
xwiki-platform-legacy-eventstream-store-hibernate ---
Downloading from central:
https://repo1.maven.org/maven2/biz/aQute/bndlib/2.0.0.20130123-133441/bndlib-2.0.0.20130123-133441.pom
Downloaded from central:
https://repo1.maven.org/maven2/biz/aQute/bndlib/2.0.0.20130123-133441/bndlib-2.0.0.20130123-133441.pom
(2.0 kB at 5.7 kB/s)
Downloading from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-core/3.23.1/javaparser-core-3.23.1.pom
Downloaded from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-core/3.23.1/javaparser-core-3.23.1.pom
(4.9 kB at 106 kB/s)
Downloading from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-parent/3.23.1/javaparser-parent-3.23.1.pom
Downloaded from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-parent/3.23.1/javaparser-parent-3.23.1.pom
(22 kB at 422 kB/s)
Downloading from central:
https://repo1.maven.org/maven2/com/github/luben/zstd-jni/1.5.2-2/zstd-jni-1.5.2-2.pom
Downloaded from central:
https://repo1.maven.org/maven2/com/github/luben/zstd-jni/1.5.2-2/zstd-jni-1.5.2-2.pom
(1.9 kB at 28 kB/s)
[ERROR] Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed
with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for
jakarta.enterprise:jakarta.enterprise.cdi-api:2.0.1 [runtime] paths to
dependency are:
+-org.xwiki.platform:xwiki-platform-legacy-eventstream-store-hibernate:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-eventstream-store-common:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-oldcore:14.5-SNAPSHOT
+-jakarta.transaction:jakarta.transaction-api:1.3.3 (managed) <--
jakarta.transaction:jakarta.transaction-api:1.3.3
+-jakarta.enterprise:jakarta.enterprise.cdi-api:2.0.1 [runtime]
and
+-org.xwiki.platform:xwiki-platform-legacy-eventstream-store-hibernate:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-eventstream-store-common:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-oldcore:14.5-SNAPSHOT
+-org.xwiki.commons:xwiki-commons-cache-infinispan:14.5-SNAPSHOT [runtime]
+-org.eclipse.microprofile.metrics:microprofile-metrics-api:3.0
[runtime] (managed) <--
org.eclipse.microprofile.metrics:microprofile-metrics-api:3.0 [runtime]
+-jakarta.enterprise:jakarta.enterprise.cdi-api:2.0.2 [runtime]
{noformat}
I checked
https://repo1.maven.org/maven2/jakarta/transaction/jakarta.transaction-api/1.3.3/jakarta.transaction-api-1.3.3.pom
and jakarta.enterprise.cdi-api is scope provided so not sure how it ended up
thinking it was runtime.
was (Author: tmortagne):
This definitely fixed most use cases, but I just hit the following:
{noformat}
[INFO] --- maven-enforcer-plugin:3.1.0:enforce (enforce-upper-bounds) @
xwiki-platform-legacy-eventstream-store-hibernate ---
Downloading from central:
https://repo1.maven.org/maven2/biz/aQute/bndlib/2.0.0.20130123-133441/bndlib-2.0.0.20130123-133441.pom
Downloaded from central:
https://repo1.maven.org/maven2/biz/aQute/bndlib/2.0.0.20130123-133441/bndlib-2.0.0.20130123-133441.pom
(2.0 kB at 5.7 kB/s)
Downloading from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-core/3.23.1/javaparser-core-3.23.1.pom
Downloaded from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-core/3.23.1/javaparser-core-3.23.1.pom
(4.9 kB at 106 kB/s)
Downloading from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-parent/3.23.1/javaparser-parent-3.23.1.pom
Downloaded from central:
https://repo1.maven.org/maven2/com/github/javaparser/javaparser-parent/3.23.1/javaparser-parent-3.23.1.pom
(22 kB at 422 kB/s)
Downloading from central:
https://repo1.maven.org/maven2/com/github/luben/zstd-jni/1.5.2-2/zstd-jni-1.5.2-2.pom
Downloaded from central:
https://repo1.maven.org/maven2/com/github/luben/zstd-jni/1.5.2-2/zstd-jni-1.5.2-2.pom
(1.9 kB at 28 kB/s)
[ERROR] Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed
with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for
jakarta.enterprise:jakarta.enterprise.cdi-api:2.0.1 [runtime] paths to
dependency are:
+-org.xwiki.platform:xwiki-platform-legacy-eventstream-store-hibernate:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-eventstream-store-common:14.5-SNAPSHOT
+-org.xwiki.platform:xwiki-platform-oldcore:14.5-SNAPSHOT
+-jakarta.transaction:j
[GitHub] [maven-compiler-plugin] dependabot[bot] opened a new pull request, #134: Bump maven-enforcer-plugin from 3.0.0-M3 to 3.1.0
dependabot[bot] opened a new pull request, #134: URL: https://github.com/apache/maven-compiler-plugin/pull/134 Bumps [maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.0.0-M3 to 3.1.0. Release notes Sourced from https://github.com/apache/maven-enforcer/releases";>maven-enforcer-plugin's releases. 3.1.0 🚀 New features and improvements https://issues.apache.org/jira/browse/MENFORCER-420";>[MENFORCER-420] - cache dependencies across rules (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/152";>#152) https://github.com/josephw";>@josephw https://issues.apache.org/jira/browse/MENFORCER-409";>[MENFORCER-409] - Log at ERROR level when is set (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/133";>#133) https://github.com/electrum";>@electrum 🐛 Bug Fixes https://issues.apache.org/jira/browse/MENFORCER-389";>[MENFORCER-389] - Allow filtering of parent in requireReleaseDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/157";>#157) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-421";>[MENFORCER-421] - Use currently build artifacts in IT tests (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/159";>#159) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-402";>[MENFORCER-402] - fix provided dependencies in RequireUpperBoundDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/140";>#140) https://github.com/subes";>@subes 📦 Dependency updates Bump mockito.version from 4.6.0 to 4.6.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/161";>#161) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.23.0 to 3.23.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/160";>#160) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.22.0 to 3.23.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/158";>#158) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.5.1 to 4.6.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/156";>#156) https://github.com/dependabot";>@dependabot https://issues.apache.org/jira/browse/MENFORCER-419";>[MENFORCER-419] - Upgrade Maven to 3.2.5 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/154";>#154) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-418";>[MENFORCER-418] - Upgrade Parent to 36 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/153";>#153) https://github.com/slawekjaranowski";>@slawekjaranowski Bump plexus-utils from 3.4.1 to 3.4.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/151";>#151) https://github.com/dependabot";>@dependabot Bump maven-dependency-tree from 3.1.0 to 3.1.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/150";>#150) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.3.1 to 3.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/147";>#147) https://github.com/dependabot";>@dependabot Bump maven-surefire-plugin from 3.0.0-M5 to 3.0.0-M6 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/148";>#148) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.2.2 to 3.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/149";>#149) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.4.0 to 4.5.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/146";>#146) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.21.0 to 3.22.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/134";>#134) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.2.0 to 4.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/142";>#142) https://github.com/dependabot";>@dependabot Bump maven-jxr-plugin from 3.1.1 to 3.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/143";>#143) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/144";>#144) https://github.com/dependabot";>@dependabot Bump mrm-maven-plugin from 1.2.0 to 1.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/129";>#129) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.1.0 to 4.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/132";>#132) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.2.0 to 3.3.1 (https://git
[GitHub] [maven-jar-plugin] dependabot[bot] commented on pull request #44: Bump mavenVersion from 3.1.0 to 3.8.6
dependabot[bot] commented on PR #44: URL: https://github.com/apache/maven-jar-plugin/pull/44#issuecomment-1153914807 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jar-plugin] slachiewicz closed pull request #44: Bump mavenVersion from 3.1.0 to 3.8.6
slachiewicz closed pull request #44: Bump mavenVersion from 3.1.0 to 3.8.6 URL: https://github.com/apache/maven-jar-plugin/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-antrun-plugin] dependabot[bot] opened a new pull request, #58: Bump maven-enforcer-plugin from 3.0.0 to 3.1.0
dependabot[bot] opened a new pull request, #58: URL: https://github.com/apache/maven-antrun-plugin/pull/58 Bumps [maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.0.0 to 3.1.0. Release notes Sourced from https://github.com/apache/maven-enforcer/releases";>maven-enforcer-plugin's releases. 3.1.0 🚀 New features and improvements https://issues.apache.org/jira/browse/MENFORCER-420";>[MENFORCER-420] - cache dependencies across rules (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/152";>#152) https://github.com/josephw";>@josephw https://issues.apache.org/jira/browse/MENFORCER-409";>[MENFORCER-409] - Log at ERROR level when is set (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/133";>#133) https://github.com/electrum";>@electrum 🐛 Bug Fixes https://issues.apache.org/jira/browse/MENFORCER-389";>[MENFORCER-389] - Allow filtering of parent in requireReleaseDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/157";>#157) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-421";>[MENFORCER-421] - Use currently build artifacts in IT tests (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/159";>#159) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-402";>[MENFORCER-402] - fix provided dependencies in RequireUpperBoundDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/140";>#140) https://github.com/subes";>@subes 📦 Dependency updates Bump mockito.version from 4.6.0 to 4.6.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/161";>#161) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.23.0 to 3.23.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/160";>#160) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.22.0 to 3.23.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/158";>#158) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.5.1 to 4.6.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/156";>#156) https://github.com/dependabot";>@dependabot https://issues.apache.org/jira/browse/MENFORCER-419";>[MENFORCER-419] - Upgrade Maven to 3.2.5 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/154";>#154) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-418";>[MENFORCER-418] - Upgrade Parent to 36 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/153";>#153) https://github.com/slawekjaranowski";>@slawekjaranowski Bump plexus-utils from 3.4.1 to 3.4.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/151";>#151) https://github.com/dependabot";>@dependabot Bump maven-dependency-tree from 3.1.0 to 3.1.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/150";>#150) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.3.1 to 3.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/147";>#147) https://github.com/dependabot";>@dependabot Bump maven-surefire-plugin from 3.0.0-M5 to 3.0.0-M6 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/148";>#148) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.2.2 to 3.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/149";>#149) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.4.0 to 4.5.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/146";>#146) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.21.0 to 3.22.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/134";>#134) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.2.0 to 4.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/142";>#142) https://github.com/dependabot";>@dependabot Bump maven-jxr-plugin from 3.1.1 to 3.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/143";>#143) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/144";>#144) https://github.com/dependabot";>@dependabot Bump mrm-maven-plugin from 1.2.0 to 1.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/129";>#129) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.1.0 to 4.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/132";>#132) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.2.0 to 3.3.1 (https://github-red
[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553564#comment-17553564 ] ASF GitHub Bot commented on MSHARED-1066: - jorsol commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153871255 We need to move this forward to also move https://github.com/apache/maven-jar-plugin/pull/43 and release maven-jar-plugin 3.3.0 > Upgrade Plexus Archiver to 4.3.0 > > > Key: MSHARED-1066 > URL: https://issues.apache.org/jira/browse/MSHARED-1066 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Major > Fix For: maven-archiver-3.6.0 > > > Maven Archiver 3.6.0 should update to Plexus Archiver 4.3.0 (once it's > released), it contains fixes to reproducible modular jars and also target > Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-archiver] jorsol commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods
jorsol commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153871255 We need to move this forward to also move https://github.com/apache/maven-jar-plugin/pull/43 and release maven-jar-plugin 3.3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pdf-plugin] dependabot[bot] opened a new pull request, #27: Bump maven-enforcer-plugin from 3.0.0-M3 to 3.1.0
dependabot[bot] opened a new pull request, #27: URL: https://github.com/apache/maven-pdf-plugin/pull/27 Bumps [maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.0.0-M3 to 3.1.0. Release notes Sourced from https://github.com/apache/maven-enforcer/releases";>maven-enforcer-plugin's releases. 3.1.0 🚀 New features and improvements https://issues.apache.org/jira/browse/MENFORCER-420";>[MENFORCER-420] - cache dependencies across rules (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/152";>#152) https://github.com/josephw";>@josephw https://issues.apache.org/jira/browse/MENFORCER-409";>[MENFORCER-409] - Log at ERROR level when is set (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/133";>#133) https://github.com/electrum";>@electrum 🐛 Bug Fixes https://issues.apache.org/jira/browse/MENFORCER-389";>[MENFORCER-389] - Allow filtering of parent in requireReleaseDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/157";>#157) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-421";>[MENFORCER-421] - Use currently build artifacts in IT tests (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/159";>#159) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-402";>[MENFORCER-402] - fix provided dependencies in RequireUpperBoundDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/140";>#140) https://github.com/subes";>@subes 📦 Dependency updates Bump mockito.version from 4.6.0 to 4.6.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/161";>#161) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.23.0 to 3.23.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/160";>#160) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.22.0 to 3.23.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/158";>#158) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.5.1 to 4.6.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/156";>#156) https://github.com/dependabot";>@dependabot https://issues.apache.org/jira/browse/MENFORCER-419";>[MENFORCER-419] - Upgrade Maven to 3.2.5 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/154";>#154) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-418";>[MENFORCER-418] - Upgrade Parent to 36 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/153";>#153) https://github.com/slawekjaranowski";>@slawekjaranowski Bump plexus-utils from 3.4.1 to 3.4.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/151";>#151) https://github.com/dependabot";>@dependabot Bump maven-dependency-tree from 3.1.0 to 3.1.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/150";>#150) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.3.1 to 3.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/147";>#147) https://github.com/dependabot";>@dependabot Bump maven-surefire-plugin from 3.0.0-M5 to 3.0.0-M6 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/148";>#148) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.2.2 to 3.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/149";>#149) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.4.0 to 4.5.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/146";>#146) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.21.0 to 3.22.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/134";>#134) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.2.0 to 4.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/142";>#142) https://github.com/dependabot";>@dependabot Bump maven-jxr-plugin from 3.1.1 to 3.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/143";>#143) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/144";>#144) https://github.com/dependabot";>@dependabot Bump mrm-maven-plugin from 1.2.0 to 1.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/129";>#129) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.1.0 to 4.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/132";>#132) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.2.0 to 3.3.1 (https://github-red
[GitHub] [maven-pdf-plugin] dependabot[bot] opened a new pull request, #26: Bump mavenVersion from 3.2.5 to 3.8.6
dependabot[bot] opened a new pull request, #26: URL: https://github.com/apache/maven-pdf-plugin/pull/26 Bumps `mavenVersion` from 3.2.5 to 3.8.6. Updates `maven-core` from 3.2.5 to 3.8.6 Release notes Sourced from https://github.com/apache/maven/releases";>maven-core's releases. 3.8.5 What's Changed [3.8.x][MNG-7156][MNG-7285] Add locking in MojoExecutor by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/628";>apache/maven#628 [MNG-6326] Make the build fail if core extensions can not be loaded by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/648";>apache/maven#648 [3.8.x][MNG-7347] SessionScoped beans should be singletons for a given session by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/653";>apache/maven#653 [3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/656";>apache/maven#656 [3.8.x][MNG-7349] Limit relocation warning message to direct dependencies only by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/657";>apache/maven#657 [3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version by https://github.com/gnodet";>@gnodet in https://github-redirect.dependabot.com/apache/maven/pull/670";>apache/maven#670 [3.8.x][MNG-7395] - Support system-properties in extension.xml by https://github.com/laeubi";>@laeubi in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 New Contributors https://github.com/laeubi";>@laeubi made their first contribution in https://github-redirect.dependabot.com/apache/maven/pull/673";>apache/maven#673 Full Changelog: https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5";>https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5 3.8.4 What's Changed [MNG-6302] logging the module count by https://github.com/rmannibucau";>@rmannibucau in https://github-redirect.dependabot.com/apache/maven/pull/136";>apache/maven#136 [MNG-6424] - Upgrade plexus-interpolation to 1.25 by https://github.com/shemic87";>@shemic87 in https://github-redirect.dependabot.com/apache/maven/pull/172";>apache/maven#172 Update Jenkins build to use Maven 3.5.4 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/179";>apache/maven#179 [MNG-6473] Update Mockito to 2.21.0 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/181";>apache/maven#181 MNG-6414 Add more Apache license headers to skip downloading license … by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/167";>apache/maven#167 [MNG-6479] Upgrade XMLUnit to 2.2.1 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/183";>apache/maven#183 Fixed typo in exception logging by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/170";>apache/maven#170 [MNG-6490] Maven fails reporting circular dependency when the depende… by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/188";>apache/maven#188 [MNG-6261] - using java File api to compare by https://github.com/fabcipriano";>@fabcipriano in https://github-redirect.dependabot.com/apache/maven/pull/192";>apache/maven#192 MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependencies() by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/193";>apache/maven#193 [MNG-6559] Fix mailing list URL by https://github.com/johnlinp";>@johnlinp in https://github-redirect.dependabot.com/apache/maven/pull/230";>apache/maven#230 [MNG-6611] Update animal-sniffer-maven-plugin to version 1.17 by https://github.com/slachiewicz";>@slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/237";>apache/maven#237 [MNG-6405] Fix basedir in MavenProject.deepCopy by https://github.com/jglick";>@jglick in https://github-redirect.dependabot.com/apache/maven/pull/225";>apache/maven#225 [MNG-6655] Add support for "release" qualifier by https://github.com/michael-o";>@michael-o in https://github-redirect.dependabot.com/apache/maven/pull/249";>apache/maven#249 Always deploy snapshot from master by https://github.com/mickaelistria";>@mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/250";>apache/maven#250 [MNG-6665] toolchain.xml file should support environment variables by https://github.com/MartinKanters";>@MartinKanters in https://github-
[jira] [Commented] (MWRAPPER-68) MVNW_REPOURL improperly formed distributionUrl
[ https://issues.apache.org/jira/browse/MWRAPPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553503#comment-17553503 ] Dan Tran commented on MWRAPPER-68: -- I am facing same issue after upgrading to 3.1.1 > MVNW_REPOURL improperly formed distributionUrl > -- > > Key: MWRAPPER-68 > URL: https://issues.apache.org/jira/browse/MWRAPPER-68 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Jar >Affects Versions: 3.1.1 >Reporter: HumanFund >Priority: Major > > In Maven Wrapper v3.1.1, Installer::createDist(), file > maven-wrapper/src/main/java/org/apache/maven/wrapper/Installer.java, was > updated on line 74 to be: > distributionUrl = new URI( mvnwRepoUrl ).resolve( "/" ).resolve( mvnPath ); > The above update is causing the distributionUrl to be improperly formed based > on the MVNW_REPOURL environment variable and the mvnPath which is extracted > from the distributionUrl in maven-wrapper.properties, specifically the > substring starting with "org/apache/maven". > The update was introduced in the following commit: > [https://github.com/apache/maven-wrapper/commit/22a3268def96e5e648aa97a49d9e146e529b7c87#diff-193f3775e6efb0b6ed01219b21272f9eb3861965ce3af3586a0ce8eb153359c0] > An example of the results are shown below. Note the "Downloading" URI does > not include the entire repo url, only the scheme, host, and port, then the > maven path is appended. > The repo url is getting truncated by the call to resolve( "/" ) on line 74. > I do not currently see a purpose for having this call in place. I made the > following update to line 74 and it works fine: > distributionUrl = new URI( mvnwRepoUrl ).resolve( mvnPath ); > Note that in Maven Wrapper v3.1.0, the distributionUrl was formed simply by > appending the maven path to the MVNW_REPOURL: > distributionUrl = new URI( mvnwRepoUrl + "/" + mvnPath ); > Example output demonstrating issue: > [exec] [INFO] Apache Maven Wrapper 3.1.1 > [exec] [INFO] Detected MVNW_REPOURL environment variable > [http://localhost:8081/repository/repo-maven-apache-org-maven2/] > [exec] [INFO] Installing Maven distribution > /home/myexamplehome/maven/wrapper/dists/apache-maven-3.6.3-bin/cf3cf814 > [exec] [INFO] Downloading > [http://localhost:8081/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip] > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-archiver] jorsol commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods
jorsol commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153728671 > Kk, but it would be good to sort out maven-archiver changes, make a release **soon**: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20fixVersion%20%3D%20maven-archiver-3.6.0 This should be ready for review, after merging this and https://github.com/apache/maven-archiver/pull/24. After that, a release can be made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553498#comment-17553498 ] ASF GitHub Bot commented on MSHARED-1066: - jorsol commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153728671 > Kk, but it would be good to sort out maven-archiver changes, make a release **soon**: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20fixVersion%20%3D%20maven-archiver-3.6.0 This should be ready for review, after merging this and https://github.com/apache/maven-archiver/pull/24. After that, a release can be made. > Upgrade Plexus Archiver to 4.3.0 > > > Key: MSHARED-1066 > URL: https://issues.apache.org/jira/browse/MSHARED-1066 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Major > Fix For: maven-archiver-3.6.0 > > > Maven Archiver 3.6.0 should update to Plexus Archiver 4.3.0 (once it's > released), it contains fixes to reproducible modular jars and also target > Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSHARED-1082) Update Plexus IO to 3.3.1
[ https://issues.apache.org/jira/browse/MSHARED-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553496#comment-17553496 ] ASF GitHub Bot commented on MSHARED-1082: - jorsol opened a new pull request, #24: URL: https://github.com/apache/maven-archiver/pull/24 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Update Plexus IO to 3.3.1 > - > > Key: MSHARED-1082 > URL: https://issues.apache.org/jira/browse/MSHARED-1082 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-archiver] jorsol opened a new pull request, #24: [MSHARED-1082] - Update Plexus IO to 3.3.1
jorsol opened a new pull request, #24: URL: https://github.com/apache/maven-archiver/pull/24 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHARED-1082) Update Plexus IO to 3.3.1
Jorge Solórzano created MSHARED-1082: Summary: Update Plexus IO to 3.3.1 Key: MSHARED-1082 URL: https://issues.apache.org/jira/browse/MSHARED-1082 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-archiver Affects Versions: maven-archiver-3.5.2 Reporter: Jorge Solórzano -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-ear-plugin] dependabot[bot] closed pull request #49: Bump plexus-archiver from 4.2.4 to 4.2.7
dependabot[bot] closed pull request #49: Bump plexus-archiver from 4.2.4 to 4.2.7 URL: https://github.com/apache/maven-ear-plugin/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] dependabot[bot] commented on pull request #49: Bump plexus-archiver from 4.2.4 to 4.2.7
dependabot[bot] commented on PR #49: URL: https://github.com/apache/maven-ear-plugin/pull/49#issuecomment-1153688387 Superseded by #56. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] dependabot[bot] opened a new pull request, #56: Bump plexus-archiver from 4.2.4 to 4.3.0
dependabot[bot] opened a new pull request, #56: URL: https://github.com/apache/maven-ear-plugin/pull/56 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.2.4 to 4.3.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-archiver/releases";>plexus-archiver's releases. Plexus Archiver 4.2.7 🚀 New features and improvements Respect order of META-INF/ and META-INF/MANIFEST.MF entries in a JAR file (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/189";>#189) https://github.com/michael-o";>@michael-o Plexus Archiver 4.2.6 This release updates commons-compress to 1.21 which contains security fixed for https://github.com/advisories/GHSA-xqfj-vm6h-2x34";>CVE-2021-35517 https://github.com/advisories/GHSA-crv7-7245-f45f";>CVE-2021-35516 https://github.com/advisories/GHSA-7hfm-57qf-j43q";>CVE-2021-35515 https://github.com/advisories/GHSA-mc84-pj99-q6hh";>CVE-2021-36090 This version requires Java 8 as minimum (commons-compress 1.21 requires Java 8). 🚀 New features and improvements FileInputStream, FileOutputStream, FileReader and FileWriter are no longer used (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/183";>#183) https://github.com/jorsol";>@jorsol Code cleanup (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/172";>#172) https://github.com/olamy";>@olamy 📦 Dependency updates Bump plexus from 7 to 8 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/179";>#179) https://github.com/dependabot";>@dependabot Bump plexus-utils from 3.3.0 to 3.4.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/181";>#181) https://github.com/dependabot";>@dependabot Bump commons-compress from 1.20 to 1.21 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/177";>#177) https://github.com/dependabot";>@dependabot Plexus Archiver 4.2.5 🚀 New features and improvements Speed improvements (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/157";>#157) https://github.com/gnodet";>@gnodet 🐛 Bug Fixes Fix use of a mismatching Unicode path extra field in zip unarchiving (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/167";>#167) https://github.com/cwalther";>@cwalther In some cases zip archiver may update the file path but not the Unicode path extra field. This would result in Plexus Archiver extracting the file using wrong (obsolete) path. Now Plexus Archiver follows the specification and in this case will ignore the extra filed and extract the file in the correct location. 📦 Dependency updates Bump plexus from 6.5 to 7 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/158";>#158) https://github.com/dependabot";>@dependabot Bump xz from 1.8 to 1.9 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/165";>#165) https://github.com/dependabot";>@dependabot Commits https://github.com/codehaus-plexus/plexus-archiver/commit/88d132ad0cb904d1786c9a4ec4b8318ac66f3864";>88d132a [maven-release-plugin] prepare release plexus-archiver-4.3.0 https://github.com/codehaus-plexus/plexus-archiver/commit/e135a2b6671fa098b429bc28eb178af256326b79";>e135a2b Bump plexus from 8 to 10 https://github.com/codehaus-plexus/plexus-archiver/commit/e8eecf29c068c20dca8a126a7c7d28a184e8e318";>e8eecf2 switch build badge from Travis to GH https://github.com/codehaus-plexus/plexus-archiver/commit/d715d6437afbb75c913d0e8d76ef2e00b8a0e322";>d715d64 Bump release-drafter/release-drafter from 5.19.0 to 5.20.0 https://github.com/codehaus-plexus/plexus-archiver/commit/50c5fc07ae7e84e7d9a33fe22e2e409ec6aa8a08";>50c5fc0 Rename setTime method to setZipEntryTime https://github.com/codehaus-plexus/plexus-archiver/commit/ee2f99da1d8fc90b5a9c9722176c0c8b88ea";>ee2f99d Bump plexus-io from 3.2.0 to 3.3.1 https://github.com/codehaus-plexus/plexus-archiver/commit/c2a06d64b76458d12cc4e7fab9b9b82cbd686cf5";>c2a06d6 Bump plexus-utils from 3.4.1 to 3.4.2 https://github.com/codehaus-plexus/plexus-archiver/commit/6d0cb3607a7c35e12ddaa9a133885caa777b177d";>6d0cb36 remove old release tag value https://github.com/codehaus-plexus/plexus-archiver/commit/581e306276b780092b43cd5b9a230f9960fa27c2";>581e306 Convert InputStreamSupplier to lambdas https://github.com/codehaus-plexus/plexus-archiver/commit/7eb5a660a9ccb2968ce4f172baaa949c72e87f87";>7eb5a66 Delete codeql-analysis.yml Additional commits viewable in https://github.com/codehaus-plexus/plexus-archiver/compare/plexus-archiver-4.2.4...plexus-archiver-4.3.0";>compare view [ from 3.0.0-M3 to 3.1.0. Release notes Sourced from https://github.com/apache/maven-enforcer/releases";>maven-enforcer-plugin's releases. 3.1.0 🚀 New features and improvements https://issues.apache.org/jira/browse/MENFORCER-420";>[MENFORCER-420] - cache dependencies across rules (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/152";>#152) https://github.com/josephw";>@josephw https://issues.apache.org/jira/browse/MENFORCER-409";>[MENFORCER-409] - Log at ERROR level when is set (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/133";>#133) https://github.com/electrum";>@electrum 🐛 Bug Fixes https://issues.apache.org/jira/browse/MENFORCER-389";>[MENFORCER-389] - Allow filtering of parent in requireReleaseDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/157";>#157) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-421";>[MENFORCER-421] - Use currently build artifacts in IT tests (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/159";>#159) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-402";>[MENFORCER-402] - fix provided dependencies in RequireUpperBoundDeps (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/140";>#140) https://github.com/subes";>@subes 📦 Dependency updates Bump mockito.version from 4.6.0 to 4.6.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/161";>#161) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.23.0 to 3.23.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/160";>#160) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.22.0 to 3.23.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/158";>#158) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.5.1 to 4.6.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/156";>#156) https://github.com/dependabot";>@dependabot https://issues.apache.org/jira/browse/MENFORCER-419";>[MENFORCER-419] - Upgrade Maven to 3.2.5 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/154";>#154) https://github.com/slawekjaranowski";>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-418";>[MENFORCER-418] - Upgrade Parent to 36 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/153";>#153) https://github.com/slawekjaranowski";>@slawekjaranowski Bump plexus-utils from 3.4.1 to 3.4.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/151";>#151) https://github.com/dependabot";>@dependabot Bump maven-dependency-tree from 3.1.0 to 3.1.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/150";>#150) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.3.1 to 3.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/147";>#147) https://github.com/dependabot";>@dependabot Bump maven-surefire-plugin from 3.0.0-M5 to 3.0.0-M6 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/148";>#148) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.2.2 to 3.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/149";>#149) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.4.0 to 4.5.1 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/146";>#146) https://github.com/dependabot";>@dependabot Bump assertj-core from 3.21.0 to 3.22.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/134";>#134) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.2.0 to 4.4.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/142";>#142) https://github.com/dependabot";>@dependabot Bump maven-jxr-plugin from 3.1.1 to 3.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/143";>#143) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/144";>#144) https://github.com/dependabot";>@dependabot Bump mrm-maven-plugin from 1.2.0 to 1.3.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/129";>#129) https://github.com/dependabot";>@dependabot Bump mockito.version from 4.1.0 to 4.2.0 (https://github-redirect.dependabot.com/apache/maven-enforcer/issues/132";>#132) https://github.com/dependabot";>@dependabot Bump maven-javadoc-plugin from 3.2.0 to 3.3.1 (https://github-red
[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553477#comment-17553477 ] ASF GitHub Bot commented on MSHARED-1066: - cstamas commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153681346 Kk, but it would be good to sort out maven-archiver changes, make a release: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20fixVersion%20%3D%20maven-archiver-3.6.0 As MASSEMBLY is eagerly waiting updates https://issues.apache.org/jira/issues/?jql=project%20%3D%20MASSEMBLY%20AND%20fixVersion%20%3D%203.4.0 > Upgrade Plexus Archiver to 4.3.0 > > > Key: MSHARED-1066 > URL: https://issues.apache.org/jira/browse/MSHARED-1066 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Major > Fix For: maven-archiver-3.6.0 > > > Maven Archiver 3.6.0 should update to Plexus Archiver 4.3.0 (once it's > released), it contains fixes to reproducible modular jars and also target > Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-archiver] cstamas commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods
cstamas commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153681346 Kk, but it would be good to sort out maven-archiver changes, make a release: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20fixVersion%20%3D%20maven-archiver-3.6.0 As MASSEMBLY is eagerly waiting updates https://issues.apache.org/jira/issues/?jql=project%20%3D%20MASSEMBLY%20AND%20fixVersion%20%3D%203.4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553473#comment-17553473 ] ASF GitHub Bot commented on MSHARED-1066: - jorsol commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153669519 > Can we split out the two thing here? Update p-archiver (and plexus-io) is unrelated to repro methods, is it? Removed plexus-io update as is actually unrelated (will open a follow-up PR). The update of plexus-archiver and reproducible methods are actually related, the reproducible methods depends on plexus-archiver 4.3.0 as plexus-archiver also contains changes to methods. It's split in two commits, and to make them two different PRs, the plexus-archiver update should be merged first and then the reproducible methods later, yet since the dependency update is a really small change I would like to keep them together. > Upgrade Plexus Archiver to 4.3.0 > > > Key: MSHARED-1066 > URL: https://issues.apache.org/jira/browse/MSHARED-1066 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Major > Fix For: maven-archiver-3.6.0 > > > Maven Archiver 3.6.0 should update to Plexus Archiver 4.3.0 (once it's > released), it contains fixes to reproducible modular jars and also target > Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-archiver] jorsol commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods
jorsol commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153669519 > Can we split out the two thing here? Update p-archiver (and plexus-io) is unrelated to repro methods, is it? Removed plexus-io update as is actually unrelated (will open a follow-up PR). The update of plexus-archiver and reproducible methods are actually related, the reproducible methods depends on plexus-archiver 4.3.0 as plexus-archiver also contains changes to methods. It's split in two commits, and to make them two different PRs, the plexus-archiver update should be merged first and then the reproducible methods later, yet since the dependency update is a really small change I would like to keep them together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MASSEMBLY-961) Upgrade maven-archiver to 3.6.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MASSEMBLY-961: - Assignee: Tamás Cservenák > Upgrade maven-archiver to 3.6.0 > --- > > Key: MASSEMBLY-961 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-961 > Project: Maven Assembly Plugin > Issue Type: Dependency upgrade >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (MASSEMBLY-962) Upgrade maven-common-artifact-filters to 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MASSEMBLY-962: - Assignee: Tamás Cservenák > Upgrade maven-common-artifact-filters to 3.3.0 > -- > > Key: MASSEMBLY-962 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-962 > Project: Maven Assembly Plugin > Issue Type: Dependency upgrade >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0
[
https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553461#comment-17553461
]
ASF GitHub Bot commented on MSHARED-1066:
-
michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-archiver/pull/22#discussion_r895481447
##
src/main/java/org/apache/maven/archiver/MavenArchiver.java:
##
@@ -812,28 +814,70 @@ public void setBuildJdkSpecDefaultEntry( boolean
buildJdkSpecDefaultEntry )
* @return the parsed timestamp, may be null if
null input or input contains only 1
* character
* @since 3.5.0
- * @throws java.lang.IllegalArgumentException if the outputTimestamp is
neither ISO 8601 nor an integer
+ * @throws IllegalArgumentException if the outputTimestamp is neither ISO
8601 nor an integer
+ * @deprecated Use {@link #parseBuildOutputTimestamp(String)} instead.
*/
+@Deprecated
public Date parseOutputTimestamp( String outputTimestamp )
{
+return parseBuildOutputTimestamp( outputTimestamp ).map( Date::from
).orElse( null );
+}
+
+/**
+ * Configure Reproducible Builds archive creation if a timestamp is
provided.
+ *
+ * @param outputTimestamp the value of {@code
${project.build.outputTimestamp}} (may be {@code null})
+ * @return the parsed timestamp as {@link java.util.Date}
+ * @since 3.5.0
+ * @see #parseOutputTimestamp
+ * @deprecated Use {@link #configureReproducibleBuild(String)} instead.
+ */
+@Deprecated
+public Date configureReproducible( String outputTimestamp )
+{
+configureReproducibleBuild( outputTimestamp );
+return parseOutputTimestamp( outputTimestamp );
+}
+
+/**
+ * Parse output timestamp configured for Reproducible Builds' archive
entries.
+ *
+ * Either as {@link java.time.format.DateTimeFormatter#ISO_INSTANT} or
as a number representing seconds since the
+ * epoch (like https://reproducible-builds.org/docs/source-date-epoch/";>SOURCE_DATE_EPOCH).
+ *
+ * @param outputTimestamp the value of {@code
${project.build.outputTimestamp}} (may be {@code null})
+ * @return the parsed timestamp as an {@code Optional}, {@code
empty} if input is {@code null} or input
+ * contains only 1 character (not a number)
+ * @since 3.6.0
+ * @throws IllegalArgumentException if the outputTimestamp is neither ISO
8601 nor an integer
+ */
+public static Optional parseBuildOutputTimestamp( String
outputTimestamp )
+{
+// Fail-fast on nulls
+if ( outputTimestamp == null )
+{
+return Optional.empty();
+}
+
+// Number representing seconds since the epoch
if ( StringUtils.isNumeric( outputTimestamp ) &&
StringUtils.isNotEmpty( outputTimestamp ) )
Review Comment:
WTF? Joder!
> Upgrade Plexus Archiver to 4.3.0
>
>
> Key: MSHARED-1066
> URL: https://issues.apache.org/jira/browse/MSHARED-1066
> Project: Maven Shared Components
> Issue Type: Dependency upgrade
> Components: maven-archiver
>Affects Versions: maven-archiver-3.5.2
>Reporter: Jorge Solórzano
>Priority: Major
> Fix For: maven-archiver-3.6.0
>
>
> Maven Archiver 3.6.0 should update to Plexus Archiver 4.3.0 (once it's
> released), it contains fixes to reproducible modular jars and also target
> Java 8.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553460#comment-17553460 ] ASF GitHub Bot commented on MSHARED-1066: - cstamas commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153653839 Can we split out the two thing here? Update p-archiver (and plexus-io) is unrelated to repro methods, is it? > Upgrade Plexus Archiver to 4.3.0 > > > Key: MSHARED-1066 > URL: https://issues.apache.org/jira/browse/MSHARED-1066 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-archiver >Affects Versions: maven-archiver-3.5.2 >Reporter: Jorge Solórzano >Priority: Major > Fix For: maven-archiver-3.6.0 > > > Maven Archiver 3.6.0 should update to Plexus Archiver 4.3.0 (once it's > released), it contains fixes to reproducible modular jars and also target > Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-archiver] michael-o commented on a diff in pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods
michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-archiver/pull/22#discussion_r895481447
##
src/main/java/org/apache/maven/archiver/MavenArchiver.java:
##
@@ -812,28 +814,70 @@ public void setBuildJdkSpecDefaultEntry( boolean
buildJdkSpecDefaultEntry )
* @return the parsed timestamp, may be null if
null input or input contains only 1
* character
* @since 3.5.0
- * @throws java.lang.IllegalArgumentException if the outputTimestamp is
neither ISO 8601 nor an integer
+ * @throws IllegalArgumentException if the outputTimestamp is neither ISO
8601 nor an integer
+ * @deprecated Use {@link #parseBuildOutputTimestamp(String)} instead.
*/
+@Deprecated
public Date parseOutputTimestamp( String outputTimestamp )
{
+return parseBuildOutputTimestamp( outputTimestamp ).map( Date::from
).orElse( null );
+}
+
+/**
+ * Configure Reproducible Builds archive creation if a timestamp is
provided.
+ *
+ * @param outputTimestamp the value of {@code
${project.build.outputTimestamp}} (may be {@code null})
+ * @return the parsed timestamp as {@link java.util.Date}
+ * @since 3.5.0
+ * @see #parseOutputTimestamp
+ * @deprecated Use {@link #configureReproducibleBuild(String)} instead.
+ */
+@Deprecated
+public Date configureReproducible( String outputTimestamp )
+{
+configureReproducibleBuild( outputTimestamp );
+return parseOutputTimestamp( outputTimestamp );
+}
+
+/**
+ * Parse output timestamp configured for Reproducible Builds' archive
entries.
+ *
+ * Either as {@link java.time.format.DateTimeFormatter#ISO_INSTANT} or
as a number representing seconds since the
+ * epoch (like https://reproducible-builds.org/docs/source-date-epoch/";>SOURCE_DATE_EPOCH).
+ *
+ * @param outputTimestamp the value of {@code
${project.build.outputTimestamp}} (may be {@code null})
+ * @return the parsed timestamp as an {@code Optional}, {@code
empty} if input is {@code null} or input
+ * contains only 1 character (not a number)
+ * @since 3.6.0
+ * @throws IllegalArgumentException if the outputTimestamp is neither ISO
8601 nor an integer
+ */
+public static Optional parseBuildOutputTimestamp( String
outputTimestamp )
+{
+// Fail-fast on nulls
+if ( outputTimestamp == null )
+{
+return Optional.empty();
+}
+
+// Number representing seconds since the epoch
if ( StringUtils.isNumeric( outputTimestamp ) &&
StringUtils.isNotEmpty( outputTimestamp ) )
Review Comment:
WTF? Joder!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-archiver] cstamas commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods
cstamas commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1153653839 Can we split out the two thing here? Update p-archiver (and plexus-io) is unrelated to repro methods, is it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MASSEMBLY-962) Upgrade maven-common-artifact-filters to 3.3.0
Tamás Cservenák created MASSEMBLY-962: - Summary: Upgrade maven-common-artifact-filters to 3.3.0 Key: MASSEMBLY-962 URL: https://issues.apache.org/jira/browse/MASSEMBLY-962 Project: Maven Assembly Plugin Issue Type: Dependency upgrade Reporter: Tamás Cservenák Fix For: 3.4.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MASSEMBLY-961) Upgrade maven-archiver to 3.6.0
Tamás Cservenák created MASSEMBLY-961: - Summary: Upgrade maven-archiver to 3.6.0 Key: MASSEMBLY-961 URL: https://issues.apache.org/jira/browse/MASSEMBLY-961 Project: Maven Assembly Plugin Issue Type: Dependency upgrade Reporter: Tamás Cservenák Fix For: 3.4.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MASSEMBLY-960) Upgrade Maven Filtering to 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MASSEMBLY-960: -- Issue Type: Dependency upgrade (was: Task) > Upgrade Maven Filtering to 3.3.0 > > > Key: MASSEMBLY-960 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-960 > Project: Maven Assembly Plugin > Issue Type: Dependency upgrade >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 3.4.0 > > > Update maven-filtering to latest one after MSHARED-1080 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0
[
https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553453#comment-17553453
]
ASF GitHub Bot commented on MSHARED-1066:
-
jorsol commented on code in PR #22:
URL: https://github.com/apache/maven-archiver/pull/22#discussion_r895467830
##
src/main/java/org/apache/maven/archiver/MavenArchiver.java:
##
@@ -812,28 +814,70 @@ public void setBuildJdkSpecDefaultEntry( boolean
buildJdkSpecDefaultEntry )
* @return the parsed timestamp, may be null if
null input or input contains only 1
* character
* @since 3.5.0
- * @throws java.lang.IllegalArgumentException if the outputTimestamp is
neither ISO 8601 nor an integer
+ * @throws IllegalArgumentException if the outputTimestamp is neither ISO
8601 nor an integer
+ * @deprecated Use {@link #parseBuildOutputTimestamp(String)} instead.
*/
+@Deprecated
public Date parseOutputTimestamp( String outputTimestamp )
{
+return parseBuildOutputTimestamp( outputTimestamp ).map( Date::from
).orElse( null );
+}
+
+/**
+ * Configure Reproducible Builds archive creation if a timestamp is
provided.
+ *
+ * @param outputTimestamp the value of {@code
${project.build.outputTimestamp}} (may be {@code null})
+ * @return the parsed timestamp as {@link java.util.Date}
+ * @since 3.5.0
+ * @see #parseOutputTimestamp
+ * @deprecated Use {@link #configureReproducibleBuild(String)} instead.
+ */
+@Deprecated
+public Date configureReproducible( String outputTimestamp )
+{
+configureReproducibleBuild( outputTimestamp );
+return parseOutputTimestamp( outputTimestamp );
+}
+
+/**
+ * Parse output timestamp configured for Reproducible Builds' archive
entries.
+ *
+ * Either as {@link java.time.format.DateTimeFormatter#ISO_INSTANT} or
as a number representing seconds since the
+ * epoch (like https://reproducible-builds.org/docs/source-date-epoch/";>SOURCE_DATE_EPOCH).
+ *
+ * @param outputTimestamp the value of {@code
${project.build.outputTimestamp}} (may be {@code null})
+ * @return the parsed timestamp as an {@code Optional}, {@code
empty} if input is {@code null} or input
+ * contains only 1 character (not a number)
+ * @since 3.6.0
+ * @throws IllegalArgumentException if the outputTimestamp is neither ISO
8601 nor an integer
+ */
+public static Optional parseBuildOutputTimestamp( String
outputTimestamp )
+{
+// Fail-fast on nulls
+if ( outputTimestamp == null )
+{
+return Optional.empty();
+}
+
+// Number representing seconds since the epoch
if ( StringUtils.isNumeric( outputTimestamp ) &&
StringUtils.isNotEmpty( outputTimestamp ) )
Review Comment:
Yeah, that shocked me as well, but that utility method doesn't handle empty
values and return true for an empty value.
> Upgrade Plexus Archiver to 4.3.0
>
>
> Key: MSHARED-1066
> URL: https://issues.apache.org/jira/browse/MSHARED-1066
> Project: Maven Shared Components
> Issue Type: Dependency upgrade
> Components: maven-archiver
>Affects Versions: maven-archiver-3.5.2
>Reporter: Jorge Solórzano
>Priority: Major
> Fix For: maven-archiver-3.6.0
>
>
> Maven Archiver 3.6.0 should update to Plexus Archiver 4.3.0 (once it's
> released), it contains fixes to reproducible modular jars and also target
> Java 8.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-archiver] jorsol commented on a diff in pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods
jorsol commented on code in PR #22:
URL: https://github.com/apache/maven-archiver/pull/22#discussion_r895467830
##
src/main/java/org/apache/maven/archiver/MavenArchiver.java:
##
@@ -812,28 +814,70 @@ public void setBuildJdkSpecDefaultEntry( boolean
buildJdkSpecDefaultEntry )
* @return the parsed timestamp, may be null if
null input or input contains only 1
* character
* @since 3.5.0
- * @throws java.lang.IllegalArgumentException if the outputTimestamp is
neither ISO 8601 nor an integer
+ * @throws IllegalArgumentException if the outputTimestamp is neither ISO
8601 nor an integer
+ * @deprecated Use {@link #parseBuildOutputTimestamp(String)} instead.
*/
+@Deprecated
public Date parseOutputTimestamp( String outputTimestamp )
{
+return parseBuildOutputTimestamp( outputTimestamp ).map( Date::from
).orElse( null );
+}
+
+/**
+ * Configure Reproducible Builds archive creation if a timestamp is
provided.
+ *
+ * @param outputTimestamp the value of {@code
${project.build.outputTimestamp}} (may be {@code null})
+ * @return the parsed timestamp as {@link java.util.Date}
+ * @since 3.5.0
+ * @see #parseOutputTimestamp
+ * @deprecated Use {@link #configureReproducibleBuild(String)} instead.
+ */
+@Deprecated
+public Date configureReproducible( String outputTimestamp )
+{
+configureReproducibleBuild( outputTimestamp );
+return parseOutputTimestamp( outputTimestamp );
+}
+
+/**
+ * Parse output timestamp configured for Reproducible Builds' archive
entries.
+ *
+ * Either as {@link java.time.format.DateTimeFormatter#ISO_INSTANT} or
as a number representing seconds since the
+ * epoch (like https://reproducible-builds.org/docs/source-date-epoch/";>SOURCE_DATE_EPOCH).
+ *
+ * @param outputTimestamp the value of {@code
${project.build.outputTimestamp}} (may be {@code null})
+ * @return the parsed timestamp as an {@code Optional}, {@code
empty} if input is {@code null} or input
+ * contains only 1 character (not a number)
+ * @since 3.6.0
+ * @throws IllegalArgumentException if the outputTimestamp is neither ISO
8601 nor an integer
+ */
+public static Optional parseBuildOutputTimestamp( String
outputTimestamp )
+{
+// Fail-fast on nulls
+if ( outputTimestamp == null )
+{
+return Optional.empty();
+}
+
+// Number representing seconds since the epoch
if ( StringUtils.isNumeric( outputTimestamp ) &&
StringUtils.isNotEmpty( outputTimestamp ) )
Review Comment:
Yeah, that shocked me as well, but that utility method doesn't handle empty
values and return true for an empty value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on a diff in pull request #37: [MSKINS-194] load GitHub ribbon with CSS
kwin commented on code in PR #37: URL: https://github.com/apache/maven-fluido-skin/pull/37#discussion_r895392726 ## src/main/resources/css/gh-fork-ribbon.css: ## @@ -0,0 +1,124 @@ +/*! + * "Fork me on GitHub" CSS ribbon v0.2.3 | MIT License + * https://github.com/simonwhitaker/github-fork-ribbon-css Review Comment: Do we need to reflect this 3rd party license somehow, e.g. in LICENSE? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] kwin opened a new pull request, #37: [MSKINS-194] load GitHub ribbon with CSS
kwin opened a new pull request, #37: URL: https://github.com/apache/maven-fluido-skin/pull/37 prevent loading images from AWS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz merged pull request #81: Bump maven-enforcer-plugin from 3.0.0 to 3.1.0
slachiewicz merged PR #81: URL: https://github.com/apache/maven-checkstyle-plugin/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
