[jira] [Reopened] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reopened MSKINS-188: > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: fluido-1.11.1 > > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSKINS-188: --- Fix Version/s: (was: fluido-1.11.1) > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-pmd-plugin] dependabot[bot] commented on pull request #70: Bump mavenVersion from 3.2.5 to 3.8.5
dependabot[bot] commented on PR #70: URL: https://github.com/apache/maven-pmd-plugin/pull/70#issuecomment-1166353984 OK, I won't notify you about any of these dependencies again, unless you re-open this PR or update them yourself. 😢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] dependabot[bot] closed pull request #70: Bump mavenVersion from 3.2.5 to 3.8.5
dependabot[bot] closed pull request #70: Bump mavenVersion from 3.2.5 to 3.8.5 URL: https://github.com/apache/maven-pmd-plugin/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] slachiewicz commented on pull request #70: Bump mavenVersion from 3.2.5 to 3.8.5
slachiewicz commented on PR #70: URL: https://github.com/apache/maven-pmd-plugin/pull/70#issuecomment-1166353978 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-282) Replace the current 'arguments' parameter with specialized version for each mojo (eg. 'argumentsRelease')
[
https://issues.apache.org/jira/browse/MRELEASE-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558817#comment-17558817
]
Pablo Caraballo Llorente commented on MRELEASE-282:
---
By the way, it's worth mentioning that this is happening with the latest
versions, which at the date are: Maven {{3.8.6}} and {{release-plugin}}
{{3.0.0-M6}}.
> Replace the current 'arguments' parameter with specialized version for each
> mojo (eg. 'argumentsRelease')
> -
>
> Key: MRELEASE-282
> URL: https://issues.apache.org/jira/browse/MRELEASE-282
> Project: Maven Release Plugin
> Issue Type: Improvement
> Components: prepare
>Affects Versions: 2.0-beta-6
> Environment: mvn 2.0.7
> WinXP
>Reporter: Marcel Schutte
>Priority: Major
>
> There is currently no way to configure the release:prepare and
> release:perform mojos with different values for the 'arguments' parameter.
> Brett said the solution should be to use unique names for the parameters [1]
> [2].
> I am aware that it is possible to use profiles for this. However, I want to
> declare the default behavior in my pom, not leave it to the user to provide
> the correct profile.
> There is a workaround available [3], however, this means you have to
> duplicate the default values for and plugin configuration.
> Some context for this improvement request is [4]
> [1] http://jira.codehaus.org/browse/MNG-1446
> [2] http://jira.codehaus.org/browse/MCOMPILER-15
> [3] http://jira.codehaus.org/browse/MRELEASE-59
> [4] http://www.nabble.com/release-plugin-configuration-tf4377660s177.html
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-deploy-plugin] michael-o commented on pull request #20: [MDEPLOY-193] Deploy At End feature (no extension)
michael-o commented on PR #20: URL: https://github.com/apache/maven-deploy-plugin/pull/20#issuecomment-1166346790 Same here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] michael-o commented on pull request #15: [MINSTALL-115] Install At End feature (no extension)
michael-o commented on PR #15: URL: https://github.com/apache/maven-install-plugin/pull/15#issuecomment-1166346381 Will check on train tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-deploy-plugin] cstamas commented on pull request #20: [MDEPLOY-193] Deploy At End feature (no extension)
cstamas commented on PR #20: URL: https://github.com/apache/maven-deploy-plugin/pull/20#issuecomment-1166346368 @gnodet @michael-o @slawekjaranowski ping, let's agree all this PR does is: * not changing existing behaviour (re last module) * but removes the requirement for extension So IMHO is def an improvement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] cstamas commented on pull request #15: [MINSTALL-115] Install At End feature (no extension)
cstamas commented on PR #15: URL: https://github.com/apache/maven-install-plugin/pull/15#issuecomment-1166346220 @gnodet @michael-o ping, Guillaume, you have change requests here (unsure what). But let's agree all this PR does is: * not changing existing behaviour (re last module) * but removes the requirement for extension So IMHO is def an improvement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on issue #659: wmic is required on windows
ppalaga commented on issue #659: URL: https://github.com/apache/maven-mvnd/issues/659#issuecomment-1166341332 Hi @j3rem1e, thanks for the report. Could you please explain what is GPO? What would you expect from mvnd in this situation? Maybe an explicit error message? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] slawekjaranowski merged pull request #65: Bump mrm-maven-plugin from 1.3.0 to 1.4.0
slawekjaranowski merged PR #65: URL: https://github.com/apache/maven-help-plugin/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558777#comment-17558777 ] Hudson commented on MSKINS-188: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-fluido-skin » master #27 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-fluido-skin/job/master/27/ > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: fluido-1.11.1 > > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSKINS-188. -- Assignee: Slawomir Jaranowski Resolution: Fixed > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: fluido-1.11.1 > > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-fluido-skin] khmarbaise commented on pull request #38: [MSKINS-175] upgrade jquery
khmarbaise commented on PR #38: URL: https://github.com/apache/maven-fluido-skin/pull/38#issuecomment-1166276703 By repeating something it becomes not true. Demanding is not insulting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #39: [MSKINS-188] improve maven logo
michael-o commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166273464 > For the record, as a Maven committer (who is not currently active) I disagree with the approach to merging. We could have merged this through a manual squash merge while retaining the author metadata. > > To the author, the commit rework would mean that your commit is fully attributable to you as both committer and author which is something that would be nice to have but shouldn’t be a roadblock Correct, we always retain authorship. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stephenc commented on pull request #39: [MSKINS-188] improve maven logo
stephenc commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166272334 For the record, as a Maven committer (who is not currently active) I disagree with the approach to merging. We could have merged this through a manual squash merge while retaining the author metadata. To the author, the commit rework would mean that your commit is fully attributable to you as both committer and author which is something that would be nice to have but shouldn’t be a roadblock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6965) Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their classpath
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558770#comment-17558770
]
Hudson commented on MNG-6965:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-762 #3
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-762/3/
> Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their
> classpath
>
>
> Key: MNG-6965
> URL: https://issues.apache.org/jira/browse/MNG-6965
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle
>Affects Versions: 3.6.0, 3.6.3
> Environment: Win7, Win10, at least one variant of Linux (not sure
> which)
>Reporter: Mark Nolan
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Labels: archetype
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
> Attachments: pom.xml
>
>
> A simple minimal archetype pom following the manual pages downloads
> plexus-utils 1.1, even though it is not (apparently) declared anywhere. This
> version is banned at my organization (edited to add: due to vulnerabilities),
> meaning such a pom always fails.
>
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> 0.0.1-SNAPSHOT
> maven-archetype
> test
>
>
>
> org.apache.maven.archetype
> archetype-packaging
> 3.1.2
>
>
>
>
>
> org.apache.maven.plugins
> maven-archetype-plugin
> 3.1.2
>
>
>
>
>
> {code}
> Running any goal, such as mvn -X clean, produces the following before the
> goal is executed:
> {code}
> [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=952800,
> ConflictMarker.markTime=586900, ConflictMarker.nodeCount=1,
> ConflictIdSorter.graphTime=549200, ConflictIdSorter.topsortTime=586700,
> ConflictIdSorter.conflictIdCount=1, ConflictIdSorter.conflictIdCycleCount=0,
> ConflictResolver.totalTime=3313100, ConflictResolver.conflictItemCount=1,
> DefaultDependencyCollector.collectTime=66890900,
> DefaultDependencyCollector.transformTime=8523500}
> [DEBUG] org.apache.maven.archetype:archetype-packaging:jar:3.1.2:
> [DEBUG]org.codehaus.plexus:plexus-utils:jar:1.1:runtime
> {code}
>
> As far as I can see, there is no declared dependency on plexus-utils:1.1.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-fluido-skin] michael-o commented on pull request #40: [MSKINS-195] Added the missing protocol part back into the button.
michael-o commented on PR #40: URL: https://github.com/apache/maven-fluido-skin/pull/40#issuecomment-1166270801 Demanding is not insulting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558767#comment-17558767 ] Stephen Crocker commented on MSKINS-97: --- I've closed my commit, after being frequently insulted by [~michael-o] I'm then presented with a requirement I view as bad practice by [~sjaranowski] who can't justify their position with reason. I am not going to waste additional effort trying to help a project that doesn't want it. > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > Attachments: bootstrap5-sidebar.png, bootstrap5-topbar.png > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-191) Update how project retreives bootstrap libraries
[ https://issues.apache.org/jira/browse/MSKINS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558766#comment-17558766 ] Stephen Crocker commented on MSKINS-191: I've closed my commit, after being frequently insulted by [~michael-o] I'm then presented with a requirement I view as bad practice by [~sjaranowski] who can't justify their position with reason. I am not going to waste additional effort trying to help a project that doesn't want it. > Update how project retreives bootstrap libraries > > > Key: MSKINS-191 > URL: https://issues.apache.org/jira/browse/MSKINS-191 > Project: Maven Skins > Issue Type: New Feature >Reporter: Stephen Crocker >Priority: Major > Attachments: bootstrap3-sidebar.png, bootstrap3-topbar.png > > > Currently the Bootstrap library is included within the project itself, > Bootstrap builds and deploys into the NPM repository. We can use the > com.github.eirslett:frontend-maven-plugin plugin to pull down the boostrap > plugins and setting the project up for packaging. This should simplify > updates to the boostrap library. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-fluido-skin] stevecrox closed pull request #38: [MSKINS-175] upgrade jquery
stevecrox closed pull request #38: [MSKINS-175] upgrade jquery URL: https://github.com/apache/maven-fluido-skin/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #38: [MSKINS-175] upgrade jquery
stevecrox commented on PR #38: URL: https://github.com/apache/maven-fluido-skin/pull/38#issuecomment-1166267604 I've closed my commit, after being frequently insulted by [~michael-o] I'm then presented with a requirement I view as bad practice by [~sjaranowski] who can't justify their position with reason. I am not going to waste additional effort trying to help a project that doesn't want it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox closed pull request #40: [MSKINS-195] Added the missing protocol part back into the button.
stevecrox closed pull request #40: [MSKINS-195] Added the missing protocol part back into the button. URL: https://github.com/apache/maven-fluido-skin/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #40: [MSKINS-195] Added the missing protocol part back into the button.
stevecrox commented on PR #40: URL: https://github.com/apache/maven-fluido-skin/pull/40#issuecomment-1166267576 I've closed my commit, after being frequently insulted by [~michael-o] I'm then presented with a requirement I view as bad practice by [~sjaranowski] who can't justify their position with reason. I am not going to waste additional effort trying to help a project that doesn't want it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558765#comment-17558765 ] Stephen Crocker commented on MSKINS-188: I've closed my commit, after being frequently insulted by [~michael-o] I'm then presented with a requirement I view as bad practice by [~sjaranowski] who can't justify their position with reason. I am not going to waste additional effort trying to help a project that doesn't want it. > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Priority: Major > Fix For: fluido-1.11.1 > > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-fluido-skin] stevecrox closed pull request #34: [MSKINS-191] dynamic library retrieval
stevecrox closed pull request #34: [MSKINS-191] dynamic library retrieval URL: https://github.com/apache/maven-fluido-skin/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #39: [MSKINS-188] improve maven logo
stevecrox commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166267183 I'm sorry picking one git hash value to roll back to over another is the same effort. You've wasted me time, do it yourself I'm done with being insulted by the Maven team. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox closed pull request #39: [MSKINS-188] improve maven logo
stevecrox closed pull request #39: [MSKINS-188] improve maven logo URL: https://github.com/apache/maven-fluido-skin/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] slawekjaranowski commented on pull request #39: [MSKINS-188] improve maven logo
slawekjaranowski commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166265991 Simply we require linear commit on master branch - from master perspective final result is important - we needn't history of work on PR in master. Another reason is to have easy possibility to revert only one commit not many, if will needed. I hope we don't waste your and our time for such discussion - please simply respect our easy requirement. We can also accept PR and squash during merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #39: [MSKINS-188] improve maven logo
stevecrox commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166253424 I don't see any reasoning in that statement and its phrased in an unnecessary way. I've already explained sound reasons for squashing a commit. This project appears to be following some variation of [Feature Branch Workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/feature-branch-workflow). The key requirement of that approach is to ensure main (master is not inclusive) branch is always buildable and releasable. The only reasons a commit in a branch matter are for the reasons I've outlined. I'm not going to squash it and I figure you have the following choices. - Provide a solid engineering based reason for squashing - Accept the PR - Reject the PR If you accept it, I'll happily keep plugin away at updating the skin to Bootstrap v5 with all the UI aspects the project appears to value (I'm not sure I agree with a number of them some but whatever..). If you reject it, I'll just fork and rename the project and release it as Bootstrap v5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] adangel opened a new pull request, #73: [MPMD-345] - Upgrade to PMD 6.47.0
adangel opened a new pull request, #73: URL: https://github.com/apache/maven-pmd-plugin/pull/73 https://issues.apache.org/jira/browse/MPMD-345 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPMD) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPMD-XXX] - Subject of the JIRA Ticket`, where you replace `MPMD-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPMD-345) Upgrade to PMD 6.47.0
Andreas Dangel created MPMD-345: --- Summary: Upgrade to PMD 6.47.0 Key: MPMD-345 URL: https://issues.apache.org/jira/browse/MPMD-345 Project: Maven PMD Plugin Issue Type: Dependency upgrade Components: CPD, PMD Reporter: Andreas Dangel Assignee: Andreas Dangel Fix For: 3.17.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MPMD-345) Upgrade to PMD 6.47.0
[ https://issues.apache.org/jira/browse/MPMD-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-345: Fix Version/s: 3.18.0 (was: 3.17.0) > Upgrade to PMD 6.47.0 > - > > Key: MPMD-345 > URL: https://issues.apache.org/jira/browse/MPMD-345 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.18.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-fluido-skin] michael-o commented on pull request #39: [MSKINS-188] improve maven logo
michael-o commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166244688 > Why? > > Squashing should be used on long standing branches where people have made a mess of the commit chain (e.g. committing changes and a second commit to revert, or merging main into the branch periodically rather than rebasing). > > But this is a feature branch from main, the resulting merge will ensure a continuous single chain of commits appear in the git changelog. No intermediate mess on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #39: [MSKINS-188] improve maven logo
stevecrox commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166243693 Why? Squashing should be used on long standing branches where people have made a mess of the commit chain (e.g. committing changes and a second commit to revert, or merging main into the branch periodically rather than rebasing). But this is a feature branch from main, the resulting merge will ensure a continuous single chain of commits appear in the git changelog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] slawekjaranowski commented on pull request #39: [MSKINS-188] improve maven logo
slawekjaranowski commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166243030 Finally please squash to one commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSKINS-188: --- Component/s: Fluido Skin > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Priority: Major > Fix For: fluido-1.11.1 > > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558748#comment-17558748 ] Slawomir Jaranowski commented on MSKINS-188: PR is only for fluido skin. > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Fix For: fluido-1.11.1 > > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #39: [MSKINS-188] improve maven logo
michael-o commented on code in PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#discussion_r906661843 ## src/main/resources/META-INF/maven/site.vm: ## @@ -222,14 +222,17 @@ #* *##if ( $searchEnabled ) #**##googleSearch( false ) #* *##end - + #**##facebookLike( $sideBarEnabled ) #**##followTwitter( $sideBarEnabled ) #**##flattrBody( $sideBarEnabled ) -#**##builtByLogo( $decoration.poweredBy ) + Review Comment: Drop this line, we have commit messages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #39: [MSKINS-188] improve maven logo
stevecrox commented on PR #39: URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166242124 So .. knowing its only 116 x 116 on a 4k screen gave me a target. One of the factors I've included is accessibility I have worked with several people with sight issues and a common seems to be a 48" monitor combined with a few different ways of adding zoom on top. While working on the bootstrap upgrades I've been checking layout by reducing it to <578px width (for phones) and also leaving a normal layout but zoomed to 400% (it results in a display size similar to my co-workers setup). - Using Gwenview reducing it to 5% (122 x 122) cut the size down to 14Kib, then zooming into 400% it looked like a blocky mess. - Using Gwenview reducing it to 10% (245 x 245) cut the size down to 26Kib, then zooming into 400% it starts getting blocky but looks ok. - Using Gwenview reducing it to 15% (367 x 367) cut the size down to 44Kib, then zooming into 400% it looks pretty good but is larger than my screen I did a quick build of the Integration Tests and in v2.8 the side bar takes the entire screen width so checking with Gwenview was pretty accurate. Is there any chance you could get the image size at a 400% zoom? I'm inclined to go with the 10% sized image (which I've committed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558746#comment-17558746 ] Michael Osipov commented on MSKINS-188: --- FYI: Default skin is dead, I plan to remove it in the future. Don't fiddle with. > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Fix For: fluido-1.11.1 > > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSKINS-188: --- Fix Version/s: fluido-1.11.1 > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Fix For: fluido-1.11.1 > > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558742#comment-17558742 ] Slawomir Jaranowski commented on MSKINS-188: Result is !image-2022-06-25-10-44-43-268.png|width=333,height=334! Looks fine for me. One doubt which I have is size of image. currently has 540 KB and resolution 2450 × 2450 which is scaled to 116 x 116 on my screen. We will put such big image to all project which use skin. I'm thinking if such big size is realy needed. > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSKINS-188: --- Attachment: image-2022-06-25-10-44-43-268.png > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
