[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit
[
https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567565#comment-17567565
]
ASF GitHub Bot commented on SCM-945:
kwin commented on PR #153:
URL: https://github.com/apache/maven-scm/pull/153#issuecomment-1186392521
I need it for the IT.
> Support OpenSSH private keys with maven-scm-provider-jgit
> -
>
> Key: SCM-945
> URL: https://issues.apache.org/jira/browse/SCM-945
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 1.11.2
>Reporter: Konrad Windszus
>Priority: Major
>
> For SSH based authentication with private keys in the OpenSSH format the
> following error is being emitted: {{invalid privatekey: ...}}
> This is due to the use of JGit 4.5.4
> (https://github.com/apache/maven-scm/blob/c5eb2c187568809e0dc0ea9ac83031f1dcb5ad1a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml#L53)
> which used JSch which lacks support for those private keys. JGit 5.2 comes
> with a new SSH implementation
> (https://bugs.eclipse.org/bugs/show_bug.cgi?id=520927) and should by that
> also support OpenSSH private keys.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-scm] kwin commented on pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD
kwin commented on PR #153: URL: https://github.com/apache/maven-scm/pull/153#issuecomment-1186392521 I need it for the IT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINSTALL-160) generatePom=true with 3.0.0-M1 does not generate minimal POM but copies existing one
[
https://issues.apache.org/jira/browse/MINSTALL-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák updated MINSTALL-160:
-
Fix Version/s: 3.0.1
> generatePom=true with 3.0.0-M1 does not generate minimal POM but copies
> existing one
>
>
> Key: MINSTALL-160
> URL: https://issues.apache.org/jira/browse/MINSTALL-160
> Project: Maven Install Plugin
> Issue Type: Bug
> Components: install:install-file
>Affects Versions: 3.0.0-M1
>Reporter: Václav Haisman
>Priority: Major
> Fix For: 3.0.1
>
>
> I am using install:install-file with generatePom=true to install JAR with
> minimal POM file. This has stopped working with 3.0.0-M1. With 3.0.0-M1, it
> copeis existing project pom.xml instead of generating a minimal one.
>
> This is easily reproducible with minimal project:
> {code:java}
>
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> maven.install.plugin.issue
> maven.install.plugin.issue
> 1.0-SNAPSHOT
> jar
> maven.install.plugin.issue
>
> 1.6
> 1.6
>
>
>
>
>
> maven-install-plugin
>
> 3.0.0-M1
>
>
>
>
>
>
> maven-install-plugin
>
>
> default-install
> none
> install
>
>
> custom-install
> install
>
> install-file
>
>
>
> ${project.build.directory}/${project.artifactId}-${project.version}.${project.packaging}
> true
>
>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SCM-925) RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing
[ https://issues.apache.org/jira/browse/SCM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567545#comment-17567545 ] ASF GitHub Bot commented on SCM-925: michael-o commented on PR #144: URL: https://github.com/apache/maven-scm/pull/144#issuecomment-1186296375 Still waiting about the duplicate addition of the file. > RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing > - > > Key: SCM-925 > URL: https://issues.apache.org/jira/browse/SCM-925 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-jgit >Affects Versions: 1.11.2 >Reporter: Georg Tsakumagos >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M2 > > Attachments: maven-scm-provider-jgit.log > > Time Spent: 10m > Remaining Estimate: 0h > > The git scm plugins differs in support for the scm command _remove_. This > breaks the goal _prepare-with-pom_ of the _maven-release-plugin_ using the > _maven-scm-provider-jgit_. The method is not fully implemented and throws an > UnsupportedOperationException. > Referring to the ["Maven SCM Providers > Matrix"|https://maven.apache.org/scm/matrix.html] this feature is documented > as supported and should be implemented in the _jgit_ provider like in > maven-scm-provider-gitexe. > > ||Variant||remove supported||Source|| > |maven-scm-provider-gitexe|(/)|[Github - GitExeScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java#L97]| > |maven-scm-provider-jgit|(x)|[Github - JGitScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java#L113]| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-scm] michael-o commented on pull request #144: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
michael-o commented on PR #144: URL: https://github.com/apache/maven-scm/pull/144#issuecomment-1186296375 Still waiting about the duplicate addition of the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SCM-991) GitDiffConsumer cannot parse moved files
[
https://issues.apache.org/jira/browse/SCM-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SCM-991.
--
Resolution: Fixed
Fixed with
[07d51d34ec386d527ecc584e67514ff862caca1e|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=07d51d34ec386d527ecc584e67514ff862caca1e].
> GitDiffConsumer cannot parse moved files
>
>
> Key: SCM-991
> URL: https://issues.apache.org/jira/browse/SCM-991
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe, maven-scm-provider-jgit
>Reporter: Jean-Noel Rouvignac
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
> Attachments: SCM-991.patch
>
>
> {{GitDiffConsumer}} keep outputting {{Unparseable line:}} when diffing a
> commit where a file was moved using {{{}git mv{}}}.
> The {{Unparseable line:}} message is output by
> {{[GitDiffConsumer.consumeLine()|https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/command/diff/GitDiffConsumer.java]}}
> because the code does not know how to handle the line starting with
> "similarity":
> {code:java}
> diff --git a/org/pager/PagerTest.java b/org/pager/LocalPagerTest.java
> similarity index 87%
> rename from org/pager/PagerTest.java
> rename to org/pager/LocalPagerTest.java
> index 5d0f7b7705..90c87686c7 100644
> --- a/org/pager/PagerTest.java
> +++ b/org/pager/LocalPagerTest.java
> @@ -30,7 +30,7 @@ import org.testng.annotations.DataProvider;
> import org.testng.annotations.Test;
>
> @Test
> -public class PagerTest {
> +public class LocalPagerTest {
> {code}
> I am using git version 2.25.1 .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SCM-991) GitDiffConsumer cannot parse moved files
[
https://issues.apache.org/jira/browse/SCM-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567542#comment-17567542
]
ASF GitHub Bot commented on SCM-991:
asfgit closed pull request #151: [SCM-991] GitDiffConsumer cannot parse moved
files
URL: https://github.com/apache/maven-scm/pull/151
> GitDiffConsumer cannot parse moved files
>
>
> Key: SCM-991
> URL: https://issues.apache.org/jira/browse/SCM-991
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe, maven-scm-provider-jgit
>Reporter: Jean-Noel Rouvignac
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
> Attachments: SCM-991.patch
>
>
> {{GitDiffConsumer}} keep outputting {{Unparseable line:}} when diffing a
> commit where a file was moved using {{{}git mv{}}}.
> The {{Unparseable line:}} message is output by
> {{[GitDiffConsumer.consumeLine()|https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/command/diff/GitDiffConsumer.java]}}
> because the code does not know how to handle the line starting with
> "similarity":
> {code:java}
> diff --git a/org/pager/PagerTest.java b/org/pager/LocalPagerTest.java
> similarity index 87%
> rename from org/pager/PagerTest.java
> rename to org/pager/LocalPagerTest.java
> index 5d0f7b7705..90c87686c7 100644
> --- a/org/pager/PagerTest.java
> +++ b/org/pager/LocalPagerTest.java
> @@ -30,7 +30,7 @@ import org.testng.annotations.DataProvider;
> import org.testng.annotations.Test;
>
> @Test
> -public class PagerTest {
> +public class LocalPagerTest {
> {code}
> I am using git version 2.25.1 .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-scm] asfgit closed pull request #151: [SCM-991] GitDiffConsumer cannot parse moved files
asfgit closed pull request #151: [SCM-991] GitDiffConsumer cannot parse moved files URL: https://github.com/apache/maven-scm/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on a diff in pull request #14: Update module:
michael-o commented on code in PR #14:
URL:
https://github.com/apache/maven-reporting-exec/pull/14#discussion_r922721145
##
pom.xml:
##
@@ -77,46 +77,42 @@
org.apache.maven
maven-artifact
${mavenVersion}
+ provided
org.apache.maven
maven-core
${mavenVersion}
+ provided
org.apache.maven
maven-model
${mavenVersion}
+ provided
org.apache.maven
maven-plugin-api
${mavenVersion}
+ provided
org.apache.maven
maven-settings
${mavenVersion}
+ provided
org.apache.maven
maven-settings-builder
${mavenVersion}
-
-
- org.apache.maven.shared
- maven-shared-utils
- 3.3.4
-
-
- org.codehaus.plexus
- plexus-component-annotations
provided
org.codehaus.plexus
plexus-utils
- 3.1.0
+ 3.4.2
Review Comment:
@hboutemy WDYT? For me, all MSITE ITs are working. I am fine with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-rar-plugin] cstamas commented on a diff in pull request #3: [MRAR-87] Upgrade to Maven 3.3.9 and drop legacy
cstamas commented on code in PR #3:
URL: https://github.com/apache/maven-rar-plugin/pull/3#discussion_r922699723
##
src/main/java/org/apache/maven/plugins/rar/internal/RarLifecycleMappingProvider.java:
##
@@ -0,0 +1,105 @@
+package org.apache.maven.plugins.rar.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Named;
+import javax.inject.Provider;
+import javax.inject.Singleton;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.maven.lifecycle.mapping.Lifecycle;
+import org.apache.maven.lifecycle.mapping.LifecycleMapping;
+
+/**
+ * {@code rar} packaging plugins bindings provider for {@code default}
lifecycle.
+ */
+@Singleton
+@Named( "rar" )
+public final class RarLifecycleMappingProvider
+implements Provider
+{
+@SuppressWarnings( "checkstyle:linelength" )
+private static final String[] BINDINGS =
+{
+"process-resources",
"org.apache.maven.plugins:maven-resources-plugin:3.2.0:resources",
+"compile",
"org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile",
+"process-test-resources",
"org.apache.maven.plugins:maven-resources-plugin:3.2.0:testResources",
+"test-compile",
"org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile",
+"test",
"org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test",
+"package", "org.apache.maven.plugins:maven-rar-plugin:" +
RarLifecycleMappingProvider.class.getPackage().getImplementationVersion() +
":rar",
+"install",
"org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install",
+"deploy",
"org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy"
+};
+
+private final Lifecycle defaultLifecycle;
+
+private final LifecycleMapping lifecycleMapping;
+
+public RarLifecycleMappingProvider()
+{
+HashMap bindings = new HashMap<>();
+for ( int i = 0; i < BINDINGS.length; i = i + 2 )
+{
+bindings.put( BINDINGS[i], BINDINGS[i + 1] );
+}
+this.defaultLifecycle = new Lifecycle();
+this.defaultLifecycle.setId( "default" );
+this.defaultLifecycle.setPhases( bindings );
Review Comment:
raise prerequisite to 3.3.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-rar-plugin] cstamas commented on a diff in pull request #3: [MRAR-87] Upgrade to Maven 3.3.9 and drop legacy
cstamas commented on code in PR #3:
URL: https://github.com/apache/maven-rar-plugin/pull/3#discussion_r922699614
##
src/main/java/org/apache/maven/plugins/rar/internal/RarLifecycleMappingProvider.java:
##
@@ -0,0 +1,105 @@
+package org.apache.maven.plugins.rar.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Named;
+import javax.inject.Provider;
+import javax.inject.Singleton;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.maven.lifecycle.mapping.Lifecycle;
+import org.apache.maven.lifecycle.mapping.LifecycleMapping;
+import org.apache.maven.lifecycle.mapping.LifecyclePhase;
+
+/**
+ * {@code rar} packaging plugins bindings provider for {@code default}
lifecycle.
+ */
+@Singleton
+@Named( "rar" )
+public final class RarLifecycleMappingProvider
+implements Provider
+{
+@SuppressWarnings( "checkstyle:linelength" )
+private static final String[] BINDINGS =
+{
+"process-resources",
"org.apache.maven.plugins:maven-resources-plugin:3.2.0:resources",
+"compile",
"org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile",
+"process-test-resources",
"org.apache.maven.plugins:maven-resources-plugin:3.2.0:testResources",
+"test-compile",
"org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile",
+"test",
"org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test",
+"package", "org.apache.maven.plugins:maven-rar-plugin:" +
RarLifecycleMappingProvider.class.getPackage().getImplementationVersion() +
":rar",
Review Comment:
makes sense. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MDEPLOY-282) Revert MDEPLOY-231
[ https://issues.apache.org/jira/browse/MDEPLOY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MDEPLOY-282: Fix Version/s: (was: 3.0.0) > Revert MDEPLOY-231 > -- > > Key: MDEPLOY-282 > URL: https://issues.apache.org/jira/browse/MDEPLOY-282 > Project: Maven Deploy Plugin > Issue Type: Task >Affects Versions: 3.0.0-M1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > > It does not logically make sense to have an IT which verifies the presence of > checksums because MDEPLOY does not generate them. MRESOLVER does that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-949) Examples should refer to https instead of http
[ https://issues.apache.org/jira/browse/MASSEMBLY-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567506#comment-17567506 ] Hudson commented on MASSEMBLY-949: -- Build failed in Jenkins: Maven » Maven TLP » maven-assembly-plugin » master #23 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-assembly-plugin/job/master/23/ > Examples should refer to https instead of http > -- > > Key: MASSEMBLY-949 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-949 > Project: Maven Assembly Plugin > Issue Type: Task > Components: site >Affects Versions: 3.3.0 >Reporter: Krosheninnikov Artem >Priority: Minor > Fix For: 3.4.2 > > > Examples in pages like this [1] point to http while they can/should point to > https > [1] http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-942) Make "single" goal m2e-friendly by using BuildContext
[ https://issues.apache.org/jira/browse/MASSEMBLY-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567505#comment-17567505 ] Sylwester Lachiewicz commented on MASSEMBLY-942: also side effect here: [https://github.com/codehaus-plexus/plexus-build-api/issues/21] > Make "single" goal m2e-friendly by using BuildContext > - > > Key: MASSEMBLY-942 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-942 > Project: Maven Assembly Plugin > Issue Type: Improvement > Components: maven-archiver >Reporter: Mickael Istria >Priority: Major > > When using the maven-assembly-plugin "single" goal in Eclipse m2e, it shows > the usual errors regarding unsupported goals. > For best results in m2e (and all consumers, and for non-CLI builds in > general), the maven-assembly-plugin should leverage BuildContext and declare > m2e capabilities, as described in > https://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MASSEMBLY-949) Examples should refer to https instead of http
[ https://issues.apache.org/jira/browse/MASSEMBLY-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MASSEMBLY-949. -- Resolution: Fixed > Examples should refer to https instead of http > -- > > Key: MASSEMBLY-949 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-949 > Project: Maven Assembly Plugin > Issue Type: Task > Components: site >Affects Versions: 3.3.0 >Reporter: Krosheninnikov Artem >Priority: Minor > > Examples in pages like this [1] point to http while they can/should point to > https > [1] http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MASSEMBLY-949) Examples should refer to https instead of http
[ https://issues.apache.org/jira/browse/MASSEMBLY-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MASSEMBLY-949: --- Fix Version/s: 3.4.2 > Examples should refer to https instead of http > -- > > Key: MASSEMBLY-949 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-949 > Project: Maven Assembly Plugin > Issue Type: Task > Components: site >Affects Versions: 3.3.0 >Reporter: Krosheninnikov Artem >Priority: Minor > Fix For: 3.4.2 > > > Examples in pages like this [1] point to http while they can/should point to > https > [1] http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MASSEMBLY-968) the plugins xsd is not exists
[ https://issues.apache.org/jira/browse/MASSEMBLY-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MASSEMBLY-968: -- Assignee: Sylwester Lachiewicz > the plugins xsd is not exists > - > > Key: MASSEMBLY-968 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-968 > Project: Maven Assembly Plugin > Issue Type: Task > Components: site >Reporter: Jacky >Assignee: Sylwester Lachiewicz >Priority: Minor > Labels: easyfix > > [http://maven.apache.org/plugins/maven-assembly-plugin/] > has a link to > > [http://maven.apache.org/xsd/assembly-2.1.0.xsd|http://maven.apache.org/xsd/assembly-2.0.0.xsd] > [http://maven.apache.org/xsd/assembly-2.1.1.xsd|http://maven.apache.org/xsd/assembly-2.0.0.xsd] > not exist~ > h4. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MASSEMBLY-968) the plugins xsd is not exists
[ https://issues.apache.org/jira/browse/MASSEMBLY-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MASSEMBLY-968. -- Resolution: Fixed site updated > the plugins xsd is not exists > - > > Key: MASSEMBLY-968 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-968 > Project: Maven Assembly Plugin > Issue Type: Task > Components: site >Reporter: Jacky >Priority: Minor > Labels: easyfix > > [http://maven.apache.org/plugins/maven-assembly-plugin/] > has a link to > > [http://maven.apache.org/xsd/assembly-2.1.0.xsd|http://maven.apache.org/xsd/assembly-2.0.0.xsd] > [http://maven.apache.org/xsd/assembly-2.1.1.xsd|http://maven.apache.org/xsd/assembly-2.0.0.xsd] > not exist~ > h4. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-965) Symbolic links get copied with absolute path
[
https://issues.apache.org/jira/browse/MASSEMBLY-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567498#comment-17567498
]
Sylwester Lachiewicz commented on MASSEMBLY-965:
plexus-io or plexus-archiver or maven-archiver
> Symbolic links get copied with absolute path
>
>
> Key: MASSEMBLY-965
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-965
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.4.0
>Reporter: Marc Guillemot
>Priority: Major
>
> Copied symbolic links in a `` have an absolute path as target and
> not the one of the original resource.
> Example:
> Source: {{foo -> ../my-file1}}
> Assembly: {{foo ->/home/marc/projects/demo/src/somestuff/myfile1}}
> This is a regression compared to 3.3.0. According to git bisect, the problem
> has been introduced with commit
> [https://github.com/apache/maven-assembly-plugin/commit/937750250bfe06333f92351fa1a19a9cd5e59d28]
> Pull Request with failing integration test follows.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567494#comment-17567494 ] Per Nyfelt commented on MASSEMBLY-969: -- Thank you, i can confirm that switching to GATCV (and GATV where appropriate) works fine on 3.4.1 > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Assignee: Tamás Cservenák >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MCOMPILER-498) Recompilation when class name doesn't match file name
T3rm1 created MCOMPILER-498:
---
Summary: Recompilation when class name doesn't match file name
Key: MCOMPILER-498
URL: https://issues.apache.org/jira/browse/MCOMPILER-498
Project: Maven Compiler Plugin
Issue Type: Bug
Reporter: T3rm1
The compiler plugin detects a file as stale whenever the class defined inside
has a different name than the file.
Steps to reproduce:
Create a file named {{SpecialTest.java}} in directory {{{}foo{}}}.
Paste in following content:
{code:java}
package foo;
class UncommonTest {
}
class CommonTest {
} {code}
Run {{mvn -X test-compile}}
It'll report on each invocation: {{[DEBUG] Stale source detected:
F:\Git\bug\src\test\java\foo\SpecialTest.java}}
That's because the plugin is looking for a file {{{}SpecialTest.class{}}}.
This is a problem because it can easily happen that you have a typo in your
class or file name so that they don't match.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567461#comment-17567461 ] Tamás Cservenák edited comment on MASSEMBLY-969 at 7/16/22 10:27 AM: - Summary: problem is MSHARED-1104 in shared component, this fixes it: [https://github.com/apache/maven-common-artifact-filters/pull/29] Solution for m-assembly-p is update (once released) the shared component (and added IT): [https://github.com/apache/maven-assembly-plugin/pull/83] was (Author: cstamas): Summary: problem is in shared component, this fixes it: [https://github.com/apache/maven-common-artifact-filters/pull/29] Solution for m-assembly-p is update (once released) the shared component (and added IT): https://github.com/apache/maven-assembly-plugin/pull/83 > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Assignee: Tamás Cservenák >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-assembly-plugin] cstamas commented on pull request #83: [MASSEMBLY-969] Update common artifact filters
cstamas commented on PR #83: URL: https://github.com/apache/maven-assembly-plugin/pull/83#issuecomment-1186137154 The IT failed as expected, as https://github.com/apache/maven-common-artifact-filters/pull/29 is not yet merged, hence, fix is not yet deployed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567461#comment-17567461 ] Tamás Cservenák commented on MASSEMBLY-969: --- Summary: problem is in shared component, this fixes it: [https://github.com/apache/maven-common-artifact-filters/pull/29] Solution for m-assembly-p is update (once released) the shared component (and added IT): https://github.com/apache/maven-assembly-plugin/pull/83 > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Assignee: Tamás Cservenák >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MSHARED-1104) Pattern w/ 4 elements may be GATV or GATC
[ https://issues.apache.org/jira/browse/MSHARED-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MSHARED-1104: Assignee: Tamás Cservenák > Pattern w/ 4 elements may be GATV or GATC > - > > Key: MSHARED-1104 > URL: https://issues.apache.org/jira/browse/MSHARED-1104 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-common-artifact-filters >Affects Versions: maven-common-artifact-filters-3.3.0 >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: maven-common-artifact-filters-3.3.1 > > > Currently pattern having 4 tokens (X:Y:Z:Q) are parsed as GATV patterns by > PatternIncludesArtifactFilter. > Seems older code (before rewrite) recognized these patterns as both GATV and > GATC. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MASSEMBLY-969: - Assignee: Tamás Cservenák > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Assignee: Tamás Cservenák >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567460#comment-17567460 ] Tamás Cservenák commented on MASSEMBLY-969: --- Created IT based on supplied pom and assembly descriptor > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7516) Support CI-Friendly-Versions in parent pom references
[
https://issues.apache.org/jira/browse/MNG-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567458#comment-17567458
]
Christoph Läubrich commented on MNG-7516:
-
If you can explain more I might came up with a solution :)
But maybe my explanation is wrong (or it is a problem in my setup):
{code}
group.of.parent
artifact.of.parent
1
../..
{code}
And assume that my parents version also resolves to 1 as well then I get an
error like this:
{code:java}
Non-resolvable parent POM for group.of.parent:artifact.of.parent:1: Could not
find artifact and 'parent.relativePath' points at wrong local POM
{code}
So it seems maven feels that, even if both resolve to the same version (one
times cifriendly and one time static), they do not match. This *might* be a
rare setup but has surprised me a bit.
Another case is if I use
{code:java}
org.eclipse
eclipse-platform-parent
${revision}
../eclipse-platform-parent
org.eclipse.equinox.p2
rt.equinox.p2
pom
1.2.3
{code}
it also fails, of course one cant inherit any property from the parent, but it
would be useful to do so in the case one releases a bunch of projects and
parent.version==importing.pom.version ...
> Support CI-Friendly-Versions in parent pom references
> -
>
> Key: MNG-7516
> URL: https://issues.apache.org/jira/browse/MNG-7516
> Project: Maven
> Issue Type: New Feature
>Reporter: Christoph Läubrich
>Priority: Major
>
> I just noticed that one could use CI-riendly versions in the version of the
> project but not in the version of the parent.
> Is there any reason for not supporting this?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7516) Support CI-Friendly-Versions in parent pom references
[ https://issues.apache.org/jira/browse/MNG-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567456#comment-17567456 ] Michael Osipov commented on MNG-7516: - Maybe to avoid chicken and egg problems? > Support CI-Friendly-Versions in parent pom references > - > > Key: MNG-7516 > URL: https://issues.apache.org/jira/browse/MNG-7516 > Project: Maven > Issue Type: New Feature >Reporter: Christoph Läubrich >Priority: Major > > I just noticed that one could use CI-riendly versions in the version of the > project but not in the version of the parent. > Is there any reason for not supporting this? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7516) Support CI-Friendly-Versions in parent pom references
Christoph Läubrich created MNG-7516: --- Summary: Support CI-Friendly-Versions in parent pom references Key: MNG-7516 URL: https://issues.apache.org/jira/browse/MNG-7516 Project: Maven Issue Type: New Feature Reporter: Christoph Läubrich I just noticed that one could use CI-riendly versions in the version of the project but not in the version of the parent. Is there any reason for not supporting this? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567455#comment-17567455 ] Tamás Cservenák commented on MASSEMBLY-969: --- Tested on provided test project, it works as expected. > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-assembly-plugin] cstamas opened a new pull request, #83: [MASSEMBLY-969] Update common artifact filters
cstamas opened a new pull request, #83: URL: https://github.com/apache/maven-assembly-plugin/pull/83 As version 3.3.0 has an unwanted change regarding 4 elements pattern and are parsed as GATV only, while before they were parsed as GATC as well. --- https://issues.apache.org/jira/browse/MASSEMBLY-969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MASSEMBLY-969: -- Affects Version/s: 3.4.0 > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.0, 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MASSEMBLY-969: -- Fix Version/s: 3.4.2 > Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0 > - > > Key: MASSEMBLY-969 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-969 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Affects Versions: 3.4.1 > Environment: Apache Maven 3.8.5 > (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Java version: 17.0.3, vendor: BellSoft > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix" >Reporter: Per Nyfelt >Priority: Critical > Fix For: 3.4.2 > > Attachments: assembly.xml, pom.xml > > > In 3.3.0 i can do the following to get the java fx base jar + the platform > specific jar into one directory (i have 3 similar dependency sets for each > platform so I can set the module-path to that directory depending on the os): > > false > runtime > lib/linux > false > > org.openjfx:javafx-base > org.openjfx:javafx-controls > org.openjfx:javafx-media > org.openjfx:javafx-web > org.openjfx:javafx-swing > org.openjfx:javafx-graphics:jar:linux > > > org.openjfx:javafx-base:jar:mac > org.openjfx:javafx-base:jar:win > org.openjfx:javafx-controls:jar:mac > org.openjfx:javafx-controls:jar:win > org.openjfx:javafx-media:jar:mac > org.openjfx:javafx-media:jar:win > org.openjfx:javafx-web:jar:mac > org.openjfx:javafx-web:jar:win > org.openjfx:javafx-swing:jar:mac > org.openjfx:javafx-swing:jar:win > > > > in 3.3.0 this gives me the following jars: > javafx-base-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-media-18.0.1-linux.jar > javafx-web-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-graphics-18.0.1-linux.jar > javafx-swing-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-controls-18.0.1.jar > javafx-media-18.0.1.jar > javafx-swing-18.0.1-linux.jar > However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get > ALL of the jar i.e. > javafx-base-18.0.1.jar > javafx-base-18.0.1-linux.jar > javafx-base-18.0.1-mac.jar > javafx-base-18.0.1-win.jar > javafx-controls-18.0.1.jar > javafx-controls-18.0.1-linux.jar > javafx-controls-18.0.1-mac.jar > javafx-controls-18.0.1-win.jar > javafx-media-18.0.1.jar > javafx-media-18.0.1-linux.jar > javafx-media-18.0.1-mac.jar > javafx-media-18.0.1-win.jar > javafx-swing-18.0.1.jar > javafx-swing-18.0.1-linux.jar > javafx-swing-18.0.1-mac.jar > javafx-swing-18.0.1-win.jar > javafx-web-18.0.1.jar > javafx-web-18.0.1-linux.jar > javafx-web-18.0.1-mac.jar > javafx-web-18.0.1-win.jar > > The assembly plugin also complains about this: > [WARNING] The following patterns were never triggered in this artifact > inclusion filter: > o 'org.openjfx:javafx-graphics:jar:linux' > [WARNING] The following patterns were never triggered in this artifact > exclusion filter: > o 'org.openjfx:javafx-base:jar:mac' > o 'org.openjfx:javafx-base:jar:win' > o 'org.openjfx:javafx-controls:jar:mac' > o 'org.openjfx:javafx-controls:jar:win' > o 'org.openjfx:javafx-media:jar:mac' > o 'org.openjfx:javafx-media:jar:win' > o 'org.openjfx:javafx-web:jar:mac' > o 'org.openjfx:javafx-web:jar:win' > o 'org.openjfx:javafx-swing:jar:mac' > o 'org.openjfx:javafx-swing:jar:win' > I think that this is either a bug in the code or the documentation for how to > combine inclusions and exclusions to get the desired effect. The full pom.xml > and assembly.xml is attached for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHARED-1104) Pattern w/ 4 elements may be GATV or GATC
Tamás Cservenák created MSHARED-1104: Summary: Pattern w/ 4 elements may be GATV or GATC Key: MSHARED-1104 URL: https://issues.apache.org/jira/browse/MSHARED-1104 Project: Maven Shared Components Issue Type: Bug Components: maven-common-artifact-filters Affects Versions: maven-common-artifact-filters-3.3.0 Reporter: Tamás Cservenák Fix For: maven-common-artifact-filters-3.3.1 Currently pattern having 4 tokens (X:Y:Z:Q) are parsed as GATV patterns by PatternIncludesArtifactFilter. Seems older code (before rewrite) recognized these patterns as both GATV and GATC. -- This message was sent by Atlassian Jira (v8.20.10#820010)
