[jira] [Commented] (MPMD-335) PMD 3.15.0 and 3.16.0 do not use project repository

2022-09-19 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606917#comment-17606917
 ] 

Michael Osipov commented on MPMD-335:
-

[~navkast] , without any additional required information this cannot be 
analyzed.

> PMD 3.15.0 and 3.16.0 do not use project repository
> ---
>
> Key: MPMD-335
> URL: https://issues.apache.org/jira/browse/MPMD-335
> Project: Maven PMD Plugin
>  Issue Type: Bug
>Reporter: Andre Kalamandeen
>Priority: Major
>
> I've tried to upgrade PMD to 3.16.0 and noticed that when building it tries 
> to get artifacts from the default maven repository instead of the repository 
> configured in the project.
> This causes issues with the build as certain artifacts are only available in 
> the custom repository.
>  
> The build error:
> {code:java}
> Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.16.0:pmd 
> failed: org.apache.maven.reporting.MavenReportException: 
> org.eclipse.aether.resolution.DependencyResolutionException: The following 
> artifacts could not be resolved: [REMOVED]: Failure to find [REMOVED] in 
> https://repo.maven.apache.org/maven2 was cached in the local repository, 
> resolution will not be reattempted until the update interval of central has 
> elapsed or updates are forced {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-artifact-transfer] slachiewicz merged pull request #78: Bump maven-shared-components from 34 to 37

2022-09-19 Thread GitBox


slachiewicz merged PR #78:
URL: https://github.com/apache/maven-artifact-transfer/pull/78


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-artifact-transfer] slachiewicz merged pull request #79: Shared GitHub actions v3

2022-09-19 Thread GitBox


slachiewicz merged PR #79:
URL: https://github.com/apache/maven-artifact-transfer/pull/79


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7391) Add MojoExecution strategy and runner required by Maven Build Cache Extension

2022-09-19 Thread Red (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606845#comment-17606845
 ] 

Red commented on MNG-7391:
--

I added maven-build-cache-extension in my project, everytime i execute *mvn 
clean package* , if hit cache, there will be no jar in target dir, is it as 
expected or something goes wrong 
!image-2022-09-20-11-03-44-847.png!

> Add MojoExecution strategy and runner required by Maven Build Cache Extension
> -
>
> Key: MNG-7391
> URL: https://issues.apache.org/jira/browse/MNG-7391
> Project: Maven
>  Issue Type: New Feature
>  Components: Core
>Reporter: Herve Boutemy
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
> Attachments: image-2022-09-14-14-14-58-145.png, 
> image-2022-09-14-19-16-00-915.png, image-2022-09-14-19-18-12-181.png, 
> image-2022-09-20-11-03-44-847.png
>
>
> Maven Build Cache Extension has been provided as a maven-core update, but 
> extracted to a separate module then a separate Git repository to provide an 
> extension: see MNG-7129 == MBUILDCACHE-1
> the extension just requires a small API in Maven core to be able to inject 
> Build Cache: MojoExecution strategy and runner
> By default, MojoExecution strategy is to run Mojos
> Build Cache Extension can has a more advanced strategy that can introduce 
> cache = inject MojoExecution result taken from cache to avoid running the Mojo



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7391) Add MojoExecution strategy and runner required by Maven Build Cache Extension

2022-09-19 Thread Red (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Red updated MNG-7391:
-
Attachment: image-2022-09-20-11-03-44-847.png

> Add MojoExecution strategy and runner required by Maven Build Cache Extension
> -
>
> Key: MNG-7391
> URL: https://issues.apache.org/jira/browse/MNG-7391
> Project: Maven
>  Issue Type: New Feature
>  Components: Core
>Reporter: Herve Boutemy
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
> Attachments: image-2022-09-14-14-14-58-145.png, 
> image-2022-09-14-19-16-00-915.png, image-2022-09-14-19-18-12-181.png, 
> image-2022-09-20-11-03-44-847.png
>
>
> Maven Build Cache Extension has been provided as a maven-core update, but 
> extracted to a separate module then a separate Git repository to provide an 
> extension: see MNG-7129 == MBUILDCACHE-1
> the extension just requires a small API in Maven core to be able to inject 
> Build Cache: MojoExecution strategy and runner
> By default, MojoExecution strategy is to run Mojos
> Build Cache Extension can has a more advanced strategy that can introduce 
> cache = inject MojoExecution result taken from cache to avoid running the Mojo



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPMD-335) PMD 3.15.0 and 3.16.0 do not use project repository

2022-09-19 Thread Naveen Kasthuri (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606811#comment-17606811
 ] 

Naveen Kasthuri commented on MPMD-335:
--

[~michael-o] I think this is a valid ticket. Custom repositories do not work 
for me either. If I downgrade to v3.13.0 - it works. With no other changes 
except an upgrade to v3.19.0, I receive the DependencyResolutionException.

> PMD 3.15.0 and 3.16.0 do not use project repository
> ---
>
> Key: MPMD-335
> URL: https://issues.apache.org/jira/browse/MPMD-335
> Project: Maven PMD Plugin
>  Issue Type: Bug
>Reporter: Andre Kalamandeen
>Priority: Major
>
> I've tried to upgrade PMD to 3.16.0 and noticed that when building it tries 
> to get artifacts from the default maven repository instead of the repository 
> configured in the project.
> This causes issues with the build as certain artifacts are only available in 
> the custom repository.
>  
> The build error:
> {code:java}
> Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.16.0:pmd 
> failed: org.apache.maven.reporting.MavenReportException: 
> org.eclipse.aether.resolution.DependencyResolutionException: The following 
> artifacts could not be resolved: [REMOVED]: Failure to find [REMOVED] in 
> https://repo.maven.apache.org/maven2 was cached in the local repository, 
> resolution will not be reattempted until the update interval of central has 
> elapsed or updates are forced {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request, #78: Bump maven-shared-components from 34 to 37

2022-09-19 Thread GitBox


dependabot[bot] opened a new pull request, #78:
URL: https://github.com/apache/maven-artifact-transfer/pull/78

   Bumps [maven-shared-components](https://github.com/apache/maven-parent) from 
34 to 37.
   
   Release notes
   Sourced from https://github.com/apache/maven-parent/releases;>maven-shared-components's
 releases.
   
   37
   What's Changed
   
   [MPOM-317] Upgrade fluido skin to 1.11.0 by https://github.com/slawekjaranowski;>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-parent/pull/66;>apache/maven-parent#66
   Bump maven-pmd-plugin from 3.16.0 to 3.17.0 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/64;>apache/maven-parent#64
   [MPOM-322] Add ASF Data Privacy by https://github.com/slawekjaranowski;>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-parent/pull/65;>apache/maven-parent#65
   [MPOM-324] Drop Social Media Plug-ins from documentation by https://github.com/slawekjaranowski;>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-parent/pull/67;>apache/maven-parent#67
   [MPOM-331] Upgrade Surefire to 3.0.0-M7 by https://github.com/slachiewicz;>@​slachiewicz in https://github-redirect.dependabot.com/apache/maven-parent/pull/68;>apache/maven-parent#68
   [MPOM-334] Upgrade fluido skin to 1.11.1 by https://github.com/slawekjaranowski;>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-parent/pull/70;>apache/maven-parent#70
   Bump maven-toolchains-plugin from 3.0.0 to 3.1.0 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/69;>apache/maven-parent#69
   Bump extra-enforcer-rules from 1.5.1 to 1.6.0 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/71;>apache/maven-parent#71
   Bump apache from 26 to 27 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/72;>apache/maven-parent#72
   
   Full Changelog: https://github.com/apache/maven-parent/compare/maven-parent-36...maven-parent-37;>https://github.com/apache/maven-parent/compare/maven-parent-36...maven-parent-37
   36
   What's Changed
   
   [MPOM-300] switch from GA to ASF Matomo. by https://github.com/bmarwell;>@​bmarwell in https://github-redirect.dependabot.com/apache/maven-parent/pull/58;>apache/maven-parent#58
   [MPOM-308] Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0 by https://github.com/slawekjaranowski;>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-parent/pull/59;>apache/maven-parent#59
   Bump taglist-maven-plugin from 2.4 to 3.0.0 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/45;>apache/maven-parent#45
   Bump maven-jxr-plugin from 3.1.1 to 3.2.0 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/60;>apache/maven-parent#60
   [MPOM-313] execute checkstyle in early phase of the build by https://github.com/olamy;>@​olamy in https://github-redirect.dependabot.com/apache/maven-parent/pull/55;>apache/maven-parent#55
   [MPOM-314] Upgrade modello-maven-plugin from 1.11 to 2.0.0 by https://github.com/slawekjaranowski;>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-parent/pull/61;>apache/maven-parent#61
   Bump apache from 25 to 26 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/62;>apache/maven-parent#62
   
   New Contributors
   
   https://github.com/bmarwell;>@​bmarwell made 
their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/58;>apache/maven-parent#58
   https://github.com/olamy;>@​olamy made their 
first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/55;>apache/maven-parent#55
   
   Full Changelog: https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36;>https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36
   35
   What's Changed
   
   docs: remove out of date comment by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-parent/pull/8;>apache/maven-parent#8
   [MPOM-252] remove broken mail list archives by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-parent/pull/18;>apache/maven-parent#18
   Bump plexus-utils from 3.1.0 to 3.3.0 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/13;>apache/maven-parent#13
   Bump maven-toolchains-plugin from 1.1 to 3.0.0 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/10;>apache/maven-parent#10
   Bump plexus-container-default from 1.0-alpha-30 to 

[GitHub] [maven-artifact-transfer] dependabot[bot] closed pull request #75: Bump slf4j-api from 1.7.32 to 2.0.1

2022-09-19 Thread GitBox


dependabot[bot] closed pull request #75: Bump slf4j-api from 1.7.32 to 2.0.1
URL: https://github.com/apache/maven-artifact-transfer/pull/75


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #75: Bump slf4j-api from 1.7.32 to 2.0.1

2022-09-19 Thread GitBox


dependabot[bot] commented on PR #75:
URL: 
https://github.com/apache/maven-artifact-transfer/pull/75#issuecomment-1251646337

   Looks like org.slf4j:slf4j-api is no longer being updated by Dependabot, so 
this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MSHARED-1134) Remove / deprecate internal debug mode in Verifier

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1134:
-
Summary: Remove / deprecate internal debug mode in Verifier  (was: Remove / 
deprecate debug mode in Verifier)

> Remove / deprecate internal debug mode in Verifier
> --
>
> Key: MSHARED-1134
> URL: https://issues.apache.org/jira/browse/MSHARED-1134
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> In Verifier we have {{debug}} field and corresponding constructors and 
> setters for it
> Behavior for this flags was probably execute Verifier in {{debug}} mode, so
> - *only* in constructor original {{System.out/err}} are saved
> - *only* in {{setDebug}} method {{System.out/err}} are overrided
> - Verifier during executions use {{System.out.println(..)}} as logging purpose
> - in {{displayStreamBuffers}} we can print before recoded logs
> And finally method {{resetStreams}} must be called on {{Verifier}} in order 
> to restore original {{System.out/err}} stream.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1146) Deprecate multivariant constructors for removal

2022-09-19 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1146:


 Summary: Deprecate multivariant constructors for removal
 Key: MSHARED-1146
 URL: https://issues.apache.org/jira/browse/MSHARED-1146
 Project: Maven Shared Components
  Issue Type: Task
  Components: maven-verifier
Reporter: Slawomir Jaranowski
 Fix For: maven-verifier-2.0.0


We have many variants of constructors, one with project base directory should 
be enough.

Rest of options should be set by setters methods.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7541) Native support for powershell to start maven

2022-09-19 Thread Jurrian Fahner (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606731#comment-17606731
 ] 

Jurrian Fahner commented on MNG-7541:
-

* The readability of the script can be improved because powershell is more 
feature rich.
 * It enables writing unit tests (this will improve readability and may also 
lower the barrier to entry): [https://pester.dev/]
 * Powershell is available since windows 7. Windows 10 and/or 11 are nowadays 
the base for many developer laptops/PCs.
 * We can get rid of cmd.exe script and replace it with powershell (which 
lowers maintainability effort), the mvn.cmd script will hold something like: 
PowerShell.exe -command mvn.ps1

It will likely not have a life altering impact probably... ;)

> Native support for powershell to start maven
> 
>
> Key: MNG-7541
> URL: https://issues.apache.org/jira/browse/MNG-7541
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.8.3
> Environment: windows 10 / 11
>Reporter: Jurrian Fahner
>Priority: Trivial
>  Labels: Script, Windows10, Windows11
>
> Maven has two files in the bin dir:
> ||command||its use||
> |mvn|POSIX shell|
> |mvn.cmd|cmd.exe|
> On windows there are two ways to write scripts, by using cmd.exe or using 
> powershell.
> If you enter mvn in powershell it will look for `mvn.ps1` on the PATH first. 
> If it doesn't find anything it will execute `mvn.cmd` as fall-back.
> When running maven for starting a server for development purposes and you do 
> ctrl-c to exit the server it will ask the question: Terminate batch job (Y/N)?
> As far as I know it is default behaviour of cmd.exe.
> Well if I don't want to terminate, I wouldn't press ctrl-c. ;)
> It is not the case (as far as I know that Microsoft is going to deprecate 
> cmd.exe in favor of powershell: 
> [https://devblogs.microsoft.com/commandline/rumors-of-cmds-death-have-been-greatly-exaggerated/]
> Allthough I think it would be a good move for maven to have also a powershell 
> script as well... It is possible to integrate elegant support for native help 
> in powershell, `get-help mvn`.
> But it also increases the maintenance effort as well. I don't know whether 
> this cost outweigh the benefits, though...
> By the way I would happy to contribute if it is appreciated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (SUREFIRE-2032) When declare the @Disabled annotation at the class level, skip displayed in other test class

2022-09-19 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet reassigned SUREFIRE-2032:
-

Assignee: Guillaume Nodet

> When declare the @Disabled annotation at the class level, skip displayed in 
> other test class
> 
>
> Key: SUREFIRE-2032
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2032
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: xie tao
>Assignee: Guillaume Nodet
>Priority: Major
> Attachments: test report.png
>
>
> When declare the @Disabled annotation at the class level, skip displayed in 
> other test class。
> junit5: 5.8.2
> surefire: 3.0.0-M5
> I have a test class like
> {code:java}
> public abstract class TagTest {
>   @Tag("red")
>   public static class RedTest extends TagTest {
>   }
>   @Disabled
>   @Tag("orange")
>   public static class OrangeTest extends TagTest {
>   }
>   @Test
>   public void test1() {
> // Do Nothing
>   }
>   @Test
>   public void test2() {
> // Do Nothing
>   }
> }
> {code}
> Run with the following command:
> {code:java}
> mvn test -Dgroups="red|orange"
> {code}
> !test report.png!
>  
> TagTest$RedTest has only 2 test case.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1075) Upgrade Parent to 36

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1075:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Upgrade Parent to 36
> 
>
> Key: MSHARED-1075
> URL: https://issues.apache.org/jira/browse/MSHARED-1075
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1125) Require Maven args to be provided one by one

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1125:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Require Maven args to be provided one by one
> 
>
> Key: MSHARED-1125
> URL: https://issues.apache.org/jira/browse/MSHARED-1125
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-verifier
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>
> For the next major we shall require user configuration to provide each 
> argument passed to Maven to be separate. This will avoid edge cases and 
> remove the requirement to pipe this through faulty/incomplete CLI parse 
> Maven/Plexus Shared Utils.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1127) Remove main method from Verifier

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1127:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Remove main method from Verifier
> 
>
> Key: MSHARED-1127
> URL: https://issues.apache.org/jira/browse/MSHARED-1127
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>
> There is {{main}} method in Verifier, it is undocumented feature and probably 
> not used. 
> Verifier should be called form test code not from command line.
> We can also remove code used only for it.
> Code use in main method parse arguments for command line.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1135) Deprecate Verifier#setMavenDebug(boolean) for removal

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1135:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Deprecate Verifier#setMavenDebug(boolean) for removal
> -
>
> Key: MSHARED-1135
> URL: https://issues.apache.org/jira/browse/MSHARED-1135
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Major
>  Labels: up-for-grabs
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>
> This method has two issues:
>  * The used option has been deprecated in favor of {{-X}}
>  * The code overhead for just passing {{-X}} is not justified. This can 
> simply be added by client code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1126) Bump maven-shared-components from 36 to 37

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1126:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Bump maven-shared-components from 36 to 37
> --
>
> Key: MSHARED-1126
> URL: https://issues.apache.org/jira/browse/MSHARED-1126
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1124) Add new version of methods filterFile and newDefaultFilterMap

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1124:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Add new version of methods filterFile and newDefaultFilterMap
> -
>
> Key: MSHARED-1124
> URL: https://issues.apache.org/jira/browse/MSHARED-1124
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>
> Deprecated method 
> {code}
> Verifier#filterFile(java.lang.String, java.lang.String, java.lang.String, 
> java.util.Properties)
> {code}
> is used about 262 times by Maven core integration test, most of case we have 
> code, like:
> {code}
> verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", 
> verifier.newDefaultFilterProperties() );
> {code}
> With a new method can  be replaced by:
> {code}
> verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8" );
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1137) Revise Verifier#getDefaultMavenHome()/#getExecutable()

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1137:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Revise Verifier#getDefaultMavenHome()/#getExecutable()
> --
>
> Key: MSHARED-1137
> URL: https://issues.apache.org/jira/browse/MSHARED-1137
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>
> This method contains relics from the past:
>  * {{M2_HOME}} has be removed years ago, so can this go
>  * In the last 10 years we have never advocated a Maven installation on 
> \{{${user.home}/.m2/}}, so this can go as well
> All we care about is {{{}maven.home{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1129) Replace CLI options with CLI args

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1129:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Replace CLI options with CLI args
> -
>
> Key: MSHARED-1129
> URL: https://issues.apache.org/jira/browse/MSHARED-1129
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-verifier
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>
> As it turns out now, any type of arguments are passed, not just options or 
> goals. Therefore, everything which is {{cliOptions}} needs to be renamed to 
> {{cliArgs}} otherwise the naming is misleading. There is not logical change, 
> just renaming.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1089) Update maven-verifier to JDK 8 / Junit 5

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1089:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Update maven-verifier to JDK 8 / Junit 5
> 
>
> Key: MSHARED-1089
> URL: https://issues.apache.org/jira/browse/MSHARED-1089
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-verifier
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1128) Deprecate all executeGoal(s) methods

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1128:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Deprecate all executeGoal(s) methods
> 
>
> Key: MSHARED-1128
> URL: https://issues.apache.org/jira/browse/MSHARED-1128
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>
> Methods {{executeGoal(s)}} take as argument Maven goal for executing test.
> From command line executing perspective all of goals are next cli arguments.
> So instead of:
> {code}
> verifier.executeGoal( "package" );
> {code}
> we can use:
> {code}
> verifier.addCliOption( "package" );
> verifier.execute();
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1142) Remove e.getMessage() duplication when e is passed as object

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1142:
-
Fix Version/s: maven-verifier-2.0.0-M1

> Remove e.getMessage() duplication when e is passed as object
> 
>
> Key: MSHARED-1142
> URL: https://issues.apache.org/jira/browse/MSHARED-1142
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Michael Osipov
>Priority: Major
>  Labels: up-for-grabs
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>
> In many spots this is code:
> {noformat}
> throw new Exception( "Failed to run Maven: " + e.getMessage(), e ); {noformat}
> {{e.getMessage()}} is redundant because {{e}} is already passed to the new 
> exception. It will duplicate the message. Zero benefit. We shall remove them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-690) Change package from org.apache.maven.it to org.apache.maven.shared.verifier

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-690:

Fix Version/s: maven-verifier-2.0.0-M1

> Change package from org.apache.maven.it to org.apache.maven.shared.verifier
> ---
>
> Key: MSHARED-690
> URL: https://issues.apache.org/jira/browse/MSHARED-690
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-verifier
>Affects Versions: maven-verifier-1.7.0
>Reporter: Karl Heinz Marbaise
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: maven-verifier-2.0.0, maven-verifier-2.0.0-M1
>
>
> I think it makes sense to change the package name from 
> {{org.apache.maven.it}} to {{org.apache.maven.shared.verifier}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1089) Update maven-verifier to JDK 8 / Junit 5

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1089:
-
Issue Type: Dependency upgrade  (was: Bug)

> Update maven-verifier to JDK 8 / Junit 5
> 
>
> Key: MSHARED-1089
> URL: https://issues.apache.org/jira/browse/MSHARED-1089
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-verifier
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1137) Revise Verifier#getDefaultMavenHome()/#getExecutable()

2022-09-19 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606696#comment-17606696
 ] 

Hudson commented on MSHARED-1137:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-verifier » master #44

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-verifier/job/master/44/

> Revise Verifier#getDefaultMavenHome()/#getExecutable()
> --
>
> Key: MSHARED-1137
> URL: https://issues.apache.org/jira/browse/MSHARED-1137
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> This method contains relics from the past:
>  * {{M2_HOME}} has be removed years ago, so can this go
>  * In the last 10 years we have never advocated a Maven installation on 
> \{{${user.home}/.m2/}}, so this can go as well
> All we care about is {{{}maven.home{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1137) Revise Verifier#getDefaultMavenHome()/#getExecutable()

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1137.

Resolution: Fixed

> Revise Verifier#getDefaultMavenHome()/#getExecutable()
> --
>
> Key: MSHARED-1137
> URL: https://issues.apache.org/jira/browse/MSHARED-1137
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> This method contains relics from the past:
>  * {{M2_HOME}} has be removed years ago, so can this go
>  * In the last 10 years we have never advocated a Maven installation on 
> \{{${user.home}/.m2/}}, so this can go as well
> All we care about is {{{}maven.home{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-verifier] slawekjaranowski merged pull request #46: [MSHARED-1137] get default Maven home only from maven.home system property

2022-09-19 Thread GitBox


slawekjaranowski merged PR #46:
URL: https://github.com/apache/maven-verifier/pull/46


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #164: MJAVADOC-731 update parent, get rid of legacy

2022-09-19 Thread GitBox


michael-o commented on code in PR #164:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/164#discussion_r974509735


##
src/main/java/org/apache/maven/plugins/javadoc/resolver/ResourceResolver.java:
##
@@ -415,14 +412,15 @@ private Collection resolveAndUnpack( final 
List artifacts,
 if ( propagateErrors )
 {
 throw new ArtifactResolutionException( "Failed to retrieve 
valid un-archiver component: "
-+ a.getType(), a, e );
++ a.getExtension(), RepositoryUtils.toArtifact( a ), e 
);
 }
 }
 catch ( final ArchiverException e )
 {
 if ( propagateErrors )
 {
-throw new ArtifactResolutionException( "Failed to unpack: 
" + a.getId(), a, e );
+throw new ArtifactResolutionException( "Failed to unpack: 
" + a.toString(),

Review Comment:
   `toString()` will be automatically invoked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #164: MJAVADOC-731 update parent, get rid of legacy

2022-09-19 Thread GitBox


michael-o commented on code in PR #164:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/164#discussion_r974509182


##
src/main/java/org/apache/maven/plugins/javadoc/resolver/ResourceResolver.java:
##
@@ -19,26 +19,29 @@
  * under the License.
  */
 
+

Review Comment:
   Seems like one empty line too much...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] kwin commented on a diff in pull request #164: MJAVADOC-731 update parent, get rid of legacy

2022-09-19 Thread GitBox


kwin commented on code in PR #164:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/164#discussion_r974507150


##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -19,17 +19,54 @@
  * under the License.
  */
 
+

Review Comment:
   not sure why it was previously not following the recommended import order: 
https://maven.apache.org/developers/conventions/code.html#java-code-convention-import-layouts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] kwin commented on a diff in pull request #164: MJAVADOC-731 update parent, get rid of legacy

2022-09-19 Thread GitBox


kwin commented on code in PR #164:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/164#discussion_r974505341


##
pom.xml:
##
@@ -171,38 +171,42 @@ under the License.
   org.apache.maven
   maven-core
   ${mavenVersion}
+  provided
 
 
   org.apache.maven
   maven-model
   ${mavenVersion}
+  provided
 
 
   org.apache.maven
   maven-settings
   ${mavenVersion}
+  provided
 
 
   org.apache.maven
   maven-plugin-api
   ${mavenVersion}
+  provided
 
 
   org.apache.maven
   maven-artifact
   ${mavenVersion}
+  provided
 
 
   org.apache.maven.plugin-tools
   maven-plugin-annotations
   provided
 
 
-  org.codehaus.plexus
-  plexus-component-annotations
-  provided
+  javax.inject
+  javax.inject
+  1

Review Comment:
   @cstamas Shouldn't this have scope "provided" as well (although not that 
critical, as unlikely to ever get another version)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] kwin commented on a diff in pull request #164: MJAVADOC-731 update parent, get rid of legacy

2022-09-19 Thread GitBox


kwin commented on code in PR #164:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/164#discussion_r974505341


##
pom.xml:
##
@@ -171,38 +171,42 @@ under the License.
   org.apache.maven
   maven-core
   ${mavenVersion}
+  provided
 
 
   org.apache.maven
   maven-model
   ${mavenVersion}
+  provided
 
 
   org.apache.maven
   maven-settings
   ${mavenVersion}
+  provided
 
 
   org.apache.maven
   maven-plugin-api
   ${mavenVersion}
+  provided
 
 
   org.apache.maven
   maven-artifact
   ${mavenVersion}
+  provided
 
 
   org.apache.maven.plugin-tools
   maven-plugin-annotations
   provided
 
 
-  org.codehaus.plexus
-  plexus-component-annotations
-  provided
+  javax.inject
+  javax.inject
+  1

Review Comment:
   @cstamas Shouldn't this be marked provided as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] michael-o commented on pull request #164: MJAVADOC-731 update parent, get rid of legacy

2022-09-19 Thread GitBox


michael-o commented on PR #164:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/164#issuecomment-1251325218

   > @michael-o Any idea why the version is managed to 3.3.1 in
   > 
   > 
https://github.com/apache/maven-javadoc-plugin/blob/3032299ec99ed5c968fc3c04cd6f1b0eaeefea20/pom.xml#L415
   > ? Couldn't we always use the current version for the report as well?
   
   Yes, it should actually work. At least other reporting plugins reuse 
themselves in the reactor for reporting. One of the problem is that if you 
haven't installed the plugin at least once locally, site phase won't include 
the plugin classes in the reactor. Try and should see it fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MPLUGINTESTING-75) Support JSR 330 components

2022-09-19 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/MPLUGINTESTING-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed MPLUGINTESTING-75.
-
Resolution: Invalid

This is actually not true, even JSR 330 component injections do work, as at 
least version 3.3.0 already relies on sisu.plexus.

> Support JSR 330 components
> --
>
> Key: MPLUGINTESTING-75
> URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-75
> Project: Maven Plugin Testing
>  Issue Type: Improvement
>  Components: plugin-testing-harness
>Affects Versions: 3.3.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently AbstractMojoTestCase can only inject legacy Plexus components but 
> no JSR 330 components 
> (https://github.com/eclipse/sisu.plexus/wiki/Plexus-to-JSR330).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7391) Add MojoExecution strategy and runner required by Maven Build Cache Extension

2022-09-19 Thread Maximilian Novikov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606677#comment-17606677
 ] 

Maximilian Novikov commented on MNG-7391:
-

good to hear you've got a huge improvement in speed Reg 3.9 release it's 
better to ask at [d...@maven.apache.org|mailto:d...@maven.apache.org]

> Add MojoExecution strategy and runner required by Maven Build Cache Extension
> -
>
> Key: MNG-7391
> URL: https://issues.apache.org/jira/browse/MNG-7391
> Project: Maven
>  Issue Type: New Feature
>  Components: Core
>Reporter: Herve Boutemy
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
> Attachments: image-2022-09-14-14-14-58-145.png, 
> image-2022-09-14-19-16-00-915.png, image-2022-09-14-19-18-12-181.png
>
>
> Maven Build Cache Extension has been provided as a maven-core update, but 
> extracted to a separate module then a separate Git repository to provide an 
> extension: see MNG-7129 == MBUILDCACHE-1
> the extension just requires a small API in Maven core to be able to inject 
> Build Cache: MojoExecution strategy and runner
> By default, MojoExecution strategy is to run Mojos
> Build Cache Extension can has a more advanced strategy that can introduce 
> cache = inject MojoExecution result taken from cache to avoid running the Mojo



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-mvnd] cstamas commented on a diff in pull request #686: Fixes module id coloring on Maven transfer.

2022-09-19 Thread GitBox


cstamas commented on code in PR #686:
URL: https://github.com/apache/maven-mvnd/pull/686#discussion_r974299537


##
common/src/main/java/org/mvndaemon/mvnd/common/logging/TerminalOutput.java:
##
@@ -767,12 +768,15 @@ private void addProjectLine(final List 
lines, Project prj) {
 if (transfer != null) {
 asb
 .append(':')
+.style(CYAN_FOREGROUND)
 .append(String.format(artifactIdFormat, prj.id))
+.style(WHITE_FOREGROUND)
 .append(transfer);
 } else if (execution == null) {
 asb
 .append(':')
-.append(prj.id);
+.style(CYAN_FOREGROUND)
+.append(String.format(artifactIdFormat, prj.id));

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-mvnd] gnodet commented on a diff in pull request #686: Fixes module id coloring on Maven transfer.

2022-09-19 Thread GitBox


gnodet commented on code in PR #686:
URL: https://github.com/apache/maven-mvnd/pull/686#discussion_r974284694


##
common/src/main/java/org/mvndaemon/mvnd/common/logging/TerminalOutput.java:
##
@@ -767,12 +768,15 @@ private void addProjectLine(final List 
lines, Project prj) {
 if (transfer != null) {
 asb
 .append(':')
+.style(CYAN_FOREGROUND)
 .append(String.format(artifactIdFormat, prj.id))
+.style(WHITE_FOREGROUND)
 .append(transfer);
 } else if (execution == null) {
 asb
 .append(':')
-.append(prj.id);
+.style(CYAN_FOREGROUND)
+.append(String.format(artifactIdFormat, prj.id));

Review Comment:
   I wonder if the project id really needs formatting here.  The main purpose 
was to trim it to a certain length to keep a nice display.  In this case, 
there's nothing more on the line though...



##
common/src/main/java/org/mvndaemon/mvnd/common/logging/TerminalOutput.java:
##
@@ -767,12 +768,15 @@ private void addProjectLine(final List 
lines, Project prj) {
 if (transfer != null) {
 asb
 .append(':')
+.style(CYAN_FOREGROUND)
 .append(String.format(artifactIdFormat, prj.id))
+.style(WHITE_FOREGROUND)

Review Comment:
   I don't think this is right.  It should be:
   ```
   .style(AttributedStyle.DEFAULT)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-integration-testing] gnodet commented on pull request #184: Modernize IT plugins to use annotations

2022-09-19 Thread GitBox


gnodet commented on PR #184:
URL: 
https://github.com/apache/maven-integration-testing/pull/184#issuecomment-1251006199

   > @gnodet Kindly rebase.
   
   I plan to rebase on master once #176 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] gnodet opened a new pull request, #564: [SUREFIRE-2032] Fix test count when using @Disabled at class level

2022-09-19 Thread GitBox


gnodet opened a new pull request, #564:
URL: https://github.com/apache/maven-surefire/pull/564

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7539) Validate/Download SNAPSHOT dependencies once

2022-09-19 Thread Adrian Tarau (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606580#comment-17606580
 ] 

Adrian Tarau commented on MNG-7539:
---

*Always* is configured on purpose to make sure it has the latest version.

Indeed, the slow resolution of artifacts does point to a problem in Nexus. 
Unfortunately, there is no apparent issue with OS (CPU, I/O), and the Java 
profiler did not highlight anything that stands out. My problem is not with 
Nexus, even when it's at its best, it still loses time doing all those 
roundtrips.

I know the recommendation is to use {*}interval:XX{*}, but downloading 
SNAPSHOTs once would be the most logical thing to do (and as a side effect, it 
will speed build everywhere the project is set to Always policy). It makes 
sense to see the same SNAPSHOT at time 00:05s in the build and at 01m:20s ... 
why would project A have modules built with different versions of a library (we 
presume a build happened in the middle)? It should present the same artifact 
version between all modules.

And a final yes, ideally, each project will be released independently. However, 
all these projects are independent, built on each other, and released as one 
(under another project) every 3-4 weeks. There are fixes/improvements across 
multiple projects, and we do not _stop_ and _release_ them individually. Thye 
is building on commit, running tests, etc., and when the time comes, we move to 
GA all at once and move to the next release cycle.

If Maven developers find the request wrong, I'll build an extension and share 
it with those who might have this particular need (and problem :)). Sometimes 
you might build things in a way that is _not by the book_ , but they are 
working for you :) 

 

 

> Validate/Download SNAPSHOT dependencies once
> 
>
> Key: MNG-7539
> URL: https://issues.apache.org/jira/browse/MNG-7539
> Project: Maven
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Adrian Tarau
>Priority: Critical
>
> Building an unreleased multi-module project (30-40 modules) that depends on 
> various other unreleased modules puts significant pressure on the Maven 
> Repository (a local Nexus instance), and artifact resolution could slow down 
> the build 2x-3x.
> I do acknowledge that it is the job of the repository to cache and serve 
> those responses fast, and for some reason, sometimes it slows down without an 
> apparent reason.
> However, the whole build process will be faster if Maven validates a SNAPSHOT 
> once for multi-module (when the dependency is reached the first time) and 
> then use that version. Even if Maven Repository is relative fast, there is 
> still network traffic done. Outside the fact that it should not be done, it 
> might also introduce flaky behaviors:
>  * one module downloads a version of artifact A, works with it, and 
> everything is fine
>  * 10 minutes later, another module needs artifact A and gets a newer 
> version, which has some issues, and various (test) failures will be raised
> For consistency, on a multi-module build, all modules should _see_ the same 
> version of a SNAPSHOT artifact. It will be faster, and it will be consistent 
> (which is very important).
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request, #77: Bump groovy from 3.0.9 to 3.0.13

2022-09-19 Thread GitBox


dependabot[bot] opened a new pull request, #77:
URL: https://github.com/apache/maven-artifact-transfer/pull/77

   Bumps [groovy](https://github.com/apache/groovy) from 3.0.9 to 3.0.13.
   
   Commits
   
   See full diff in https://github.com/apache/groovy/commits;>compare view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.groovy:groovy=maven=3.0.9=3.0.13)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-artifact-transfer] dependabot[bot] closed pull request #68: Bump groovy from 3.0.9 to 3.0.12

2022-09-19 Thread GitBox


dependabot[bot] closed pull request #68: Bump groovy from 3.0.9 to 3.0.12
URL: https://github.com/apache/maven-artifact-transfer/pull/68


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #68: Bump groovy from 3.0.9 to 3.0.12

2022-09-19 Thread GitBox


dependabot[bot] commented on PR #68:
URL: 
https://github.com/apache/maven-artifact-transfer/pull/68#issuecomment-1250939061

   Superseded by #77.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] gnodet closed pull request #698: Cache all interpolated models

2022-09-19 Thread GitBox


gnodet closed pull request #698: Cache all interpolated models
URL: https://github.com/apache/maven/pull/698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] gnodet commented on pull request #698: Cache all interpolated models

2022-09-19 Thread GitBox


gnodet commented on PR #698:
URL: https://github.com/apache/maven/pull/698#issuecomment-1250770454

   Superseded by #803 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2022-09-19 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606510#comment-17606510
 ] 

Michael Osipov commented on MNG-7055:
-

This applies to packaging maven-plugin only.

> Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into 
> maven-metadata.xml
> -
>
> Key: MNG-7055
> URL: https://issues.apache.org/jira/browse/MNG-7055
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Plugins and Lifecycle
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Blocker
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Copying [~michael-o]'s comment from mailing list on HEAD with Maven core ITs:
> [https://markmail.org/message/ggcioupa6yaet4xe#query:+page:1+mid:noyp5d3iyclrfgyp+state:results]
> {noformat}
> [ERROR] Tests run: 834, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 287.261 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testitMNG3372(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
> Time elapsed: 1.5 s  <<< ERROR!
> org.apache.maven.it.VerificationException:
> Exit code was non-zero: 1; command line and log =
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn
> --global-settings
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/settings.xml
> -s
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-3372/direct-using-prefix/settings.xml
> -e --batch-mode
> -Dmaven.repo.local=/net/home/osipovmi/var/Projekte/maven-integration-testing/repo
> mng3372:test
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model 
> for
> org.apache.maven.its.mng3372:project:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins [maven-clean-plugin,
> maven-resources-plugin, maven-jar-plugin, maven-compiler-plugin,
> maven-surefire-plugin, maven-install-plugin, maven-deploy-plugin,
> maven-site-plugin], you should define versions in pluginManagement section of
> your pom.xml or parent @ line 6, column 14
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
> [INFO] Downloading from central: 
> file:target/null/org/apache/maven/its/mng3372/maven-metadata.xml
> [INFO] Downloading from central: 
> file:target/null/org/apache/maven/plugins/maven-metadata.xml
> [INFO] Downloading from central: 
> file:target/null/org/codehaus/mojo/maven-metadata.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  0.056 s
> [INFO] Finished at: 2020-06-04T22:03:01+02:00
> [INFO] 
> 
> [ERROR] No plugin found for prefix 'mng3372' in the current project and in the
> plugin groups [org.apache.maven.its.mng3372, org.apache.maven.plugins,
> org.codehaus.mojo] available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)] -> [Help 1]
> org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin 
> found
> for prefix 'mng3372' in the current project and in the plugin groups
> [org.apache.maven.its.mng3372, org.apache.maven.plugins, org.codehaus.mojo]
> available from the repositories [local 
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central 
> (file:target/null)]
> at 
> org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver.resolve(DefaultPluginPrefixResolver.java:98)
> at 
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.findPluginForPrefix(MojoDescriptorCreator.java:269)
> at 
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.getMojoDescript{noformat}
> explanation: [maven-metadata.xml 
> descriptor|https://maven.apache.org/ref/3.8.6/maven-repository-metadata/repository-metadata.html]
>  from plugin's groupId is not updated ({{{}plugin/name+prefix+artifactId{}}}) 
> on first plugin release deployment, then plugin's prefix is not published
> see for example 
> [https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-metadata.xml|https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-metadata.xml]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-mvnd] gnodet commented on issue #691: Why didn't I release the binary archives of version 0.8.1?

2022-09-19 Thread GitBox


gnodet commented on issue #691:
URL: https://github.com/apache/maven-mvnd/issues/691#issuecomment-1250739368

   > I noticed that there has been a 0.8.1 version of the tag there for a long 
time, but the corresponding binary archives has never been released.
   
   The binaries are still under vote at Apache.  This should not be very long 
now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2022-09-19 Thread Jira


[ 
https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606481#comment-17606481
 ] 

Václav Haisman edited comment on MNG-7055 at 9/19/22 8:23 AM:
--

Can you please confirm that for Maven 3.6.3, I should use maven-deploy-plugin 
2.8.2 to avoid this issue?


was (Author: wilx):
Can you please confirm that for Maven 3.6.3, I should use maven-deploy-plugin 
2.5.3 to avoid this issue?

> Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into 
> maven-metadata.xml
> -
>
> Key: MNG-7055
> URL: https://issues.apache.org/jira/browse/MNG-7055
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Plugins and Lifecycle
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Blocker
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Copying [~michael-o]'s comment from mailing list on HEAD with Maven core ITs:
> [https://markmail.org/message/ggcioupa6yaet4xe#query:+page:1+mid:noyp5d3iyclrfgyp+state:results]
> {noformat}
> [ERROR] Tests run: 834, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 287.261 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testitMNG3372(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
> Time elapsed: 1.5 s  <<< ERROR!
> org.apache.maven.it.VerificationException:
> Exit code was non-zero: 1; command line and log =
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn
> --global-settings
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/settings.xml
> -s
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-3372/direct-using-prefix/settings.xml
> -e --batch-mode
> -Dmaven.repo.local=/net/home/osipovmi/var/Projekte/maven-integration-testing/repo
> mng3372:test
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model 
> for
> org.apache.maven.its.mng3372:project:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins [maven-clean-plugin,
> maven-resources-plugin, maven-jar-plugin, maven-compiler-plugin,
> maven-surefire-plugin, maven-install-plugin, maven-deploy-plugin,
> maven-site-plugin], you should define versions in pluginManagement section of
> your pom.xml or parent @ line 6, column 14
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
> [INFO] Downloading from central: 
> file:target/null/org/apache/maven/its/mng3372/maven-metadata.xml
> [INFO] Downloading from central: 
> file:target/null/org/apache/maven/plugins/maven-metadata.xml
> [INFO] Downloading from central: 
> file:target/null/org/codehaus/mojo/maven-metadata.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  0.056 s
> [INFO] Finished at: 2020-06-04T22:03:01+02:00
> [INFO] 
> 
> [ERROR] No plugin found for prefix 'mng3372' in the current project and in the
> plugin groups [org.apache.maven.its.mng3372, org.apache.maven.plugins,
> org.codehaus.mojo] available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)] -> [Help 1]
> org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin 
> found
> for prefix 'mng3372' in the current project and in the plugin groups
> [org.apache.maven.its.mng3372, org.apache.maven.plugins, org.codehaus.mojo]
> available from the repositories [local 
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central 
> (file:target/null)]
> at 
> org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver.resolve(DefaultPluginPrefixResolver.java:98)
> at 
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.findPluginForPrefix(MojoDescriptorCreator.java:269)
> at 
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.getMojoDescript{noformat}
> explanation: [maven-metadata.xml 
> descriptor|https://maven.apache.org/ref/3.8.6/maven-repository-metadata/repository-metadata.html]
>  from plugin's groupId is not updated ({{{}plugin/name+prefix+artifactId{}}}) 
> on first plugin release deployment, then plugin's prefix is not published
> see for example 
> 

[jira] [Comment Edited] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2022-09-19 Thread Jira


[ 
https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606481#comment-17606481
 ] 

Václav Haisman edited comment on MNG-7055 at 9/19/22 8:12 AM:
--

Can you please confirm that for Maven 3.6.3, I should use maven-deploy-plugin 
2.5.3 to avoid this issue?


was (Author: wilx):
Can you please confirm that for Maven 3.6.3, I should use maven-assembly-plugin 
2.5.3 to avoid this issue?

> Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into 
> maven-metadata.xml
> -
>
> Key: MNG-7055
> URL: https://issues.apache.org/jira/browse/MNG-7055
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Plugins and Lifecycle
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Blocker
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Copying [~michael-o]'s comment from mailing list on HEAD with Maven core ITs:
> [https://markmail.org/message/ggcioupa6yaet4xe#query:+page:1+mid:noyp5d3iyclrfgyp+state:results]
> {noformat}
> [ERROR] Tests run: 834, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 287.261 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testitMNG3372(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
> Time elapsed: 1.5 s  <<< ERROR!
> org.apache.maven.it.VerificationException:
> Exit code was non-zero: 1; command line and log =
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn
> --global-settings
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/settings.xml
> -s
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-3372/direct-using-prefix/settings.xml
> -e --batch-mode
> -Dmaven.repo.local=/net/home/osipovmi/var/Projekte/maven-integration-testing/repo
> mng3372:test
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model 
> for
> org.apache.maven.its.mng3372:project:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins [maven-clean-plugin,
> maven-resources-plugin, maven-jar-plugin, maven-compiler-plugin,
> maven-surefire-plugin, maven-install-plugin, maven-deploy-plugin,
> maven-site-plugin], you should define versions in pluginManagement section of
> your pom.xml or parent @ line 6, column 14
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
> [INFO] Downloading from central: 
> file:target/null/org/apache/maven/its/mng3372/maven-metadata.xml
> [INFO] Downloading from central: 
> file:target/null/org/apache/maven/plugins/maven-metadata.xml
> [INFO] Downloading from central: 
> file:target/null/org/codehaus/mojo/maven-metadata.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  0.056 s
> [INFO] Finished at: 2020-06-04T22:03:01+02:00
> [INFO] 
> 
> [ERROR] No plugin found for prefix 'mng3372' in the current project and in the
> plugin groups [org.apache.maven.its.mng3372, org.apache.maven.plugins,
> org.codehaus.mojo] available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)] -> [Help 1]
> org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin 
> found
> for prefix 'mng3372' in the current project and in the plugin groups
> [org.apache.maven.its.mng3372, org.apache.maven.plugins, org.codehaus.mojo]
> available from the repositories [local 
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central 
> (file:target/null)]
> at 
> org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver.resolve(DefaultPluginPrefixResolver.java:98)
> at 
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.findPluginForPrefix(MojoDescriptorCreator.java:269)
> at 
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.getMojoDescript{noformat}
> explanation: [maven-metadata.xml 
> descriptor|https://maven.apache.org/ref/3.8.6/maven-repository-metadata/repository-metadata.html]
>  from plugin's groupId is not updated ({{{}plugin/name+prefix+artifactId{}}}) 
> on first plugin release deployment, then plugin's prefix is not published
> see for example 
> 

[jira] [Commented] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2022-09-19 Thread Jira


[ 
https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606481#comment-17606481
 ] 

Václav Haisman commented on MNG-7055:
-

Can you please confirm that for Maven 3.6.3, I should use maven-assembly-plugin 
2.5.3 to avoid this issue?

> Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into 
> maven-metadata.xml
> -
>
> Key: MNG-7055
> URL: https://issues.apache.org/jira/browse/MNG-7055
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Plugins and Lifecycle
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Blocker
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Copying [~michael-o]'s comment from mailing list on HEAD with Maven core ITs:
> [https://markmail.org/message/ggcioupa6yaet4xe#query:+page:1+mid:noyp5d3iyclrfgyp+state:results]
> {noformat}
> [ERROR] Tests run: 834, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 287.261 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testitMNG3372(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
> Time elapsed: 1.5 s  <<< ERROR!
> org.apache.maven.it.VerificationException:
> Exit code was non-zero: 1; command line and log =
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn
> --global-settings
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/settings.xml
> -s
> /var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-3372/direct-using-prefix/settings.xml
> -e --batch-mode
> -Dmaven.repo.local=/net/home/osipovmi/var/Projekte/maven-integration-testing/repo
> mng3372:test
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model 
> for
> org.apache.maven.its.mng3372:project:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins [maven-clean-plugin,
> maven-resources-plugin, maven-jar-plugin, maven-compiler-plugin,
> maven-surefire-plugin, maven-install-plugin, maven-deploy-plugin,
> maven-site-plugin], you should define versions in pluginManagement section of
> your pom.xml or parent @ line 6, column 14
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
> [INFO] Downloading from central: 
> file:target/null/org/apache/maven/its/mng3372/maven-metadata.xml
> [INFO] Downloading from central: 
> file:target/null/org/apache/maven/plugins/maven-metadata.xml
> [INFO] Downloading from central: 
> file:target/null/org/codehaus/mojo/maven-metadata.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  0.056 s
> [INFO] Finished at: 2020-06-04T22:03:01+02:00
> [INFO] 
> 
> [ERROR] No plugin found for prefix 'mng3372' in the current project and in the
> plugin groups [org.apache.maven.its.mng3372, org.apache.maven.plugins,
> org.codehaus.mojo] available from the repositories [local
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
> (file:target/null)] -> [Help 1]
> org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin 
> found
> for prefix 'mng3372' in the current project and in the plugin groups
> [org.apache.maven.its.mng3372, org.apache.maven.plugins, org.codehaus.mojo]
> available from the repositories [local 
> (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central 
> (file:target/null)]
> at 
> org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver.resolve(DefaultPluginPrefixResolver.java:98)
> at 
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.findPluginForPrefix(MojoDescriptorCreator.java:269)
> at 
> org.apache.maven.lifecycle.internal.MojoDescriptorCreator.getMojoDescript{noformat}
> explanation: [maven-metadata.xml 
> descriptor|https://maven.apache.org/ref/3.8.6/maven-repository-metadata/repository-metadata.html]
>  from plugin's groupId is not updated ({{{}plugin/name+prefix+artifactId{}}}) 
> on first plugin release deployment, then plugin's prefix is not published
> see for example 
> [https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-metadata.xml|https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-metadata.xml]



--
This message was sent by Atlassian 

[jira] [Updated] (MJAVADOC-731) Migrate components to JSR 330, get rid of maven-artifact-transfer, update to parent 37

2022-09-19 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated MJAVADOC-731:
-
Description: 
Get rid of legacy:
* Annotations should be migrated to JSR 330 
(https://github.com/eclipse/sisu.plexus/wiki/Plexus-to-JSR330)
* m-artifact-transfer no longer necessary as plugin requires Maven 3.2.5, use 
Aether API directly
* Update to latest parent org.apache.maven.plugins:maven-plugins:37

Compare with 
https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup

  was:
Get rid of legacy:
* Annotations should be migrated to JSR 330 
(https://github.com/eclipse/sisu.plexus/wiki/Plexus-to-JSR330)
* m-artifact-transfer no longer necessary as plugin requires Maven 3.2.5, use 
Aether API directly
* Update to latest parent org.apache.maven.plugins:maven-plugins:37


> Migrate components to JSR 330, get rid of maven-artifact-transfer, update to 
> parent 37
> --
>
> Key: MJAVADOC-731
> URL: https://issues.apache.org/jira/browse/MJAVADOC-731
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Get rid of legacy:
> * Annotations should be migrated to JSR 330 
> (https://github.com/eclipse/sisu.plexus/wiki/Plexus-to-JSR330)
> * m-artifact-transfer no longer necessary as plugin requires Maven 3.2.5, use 
> Aether API directly
> * Update to latest parent org.apache.maven.plugins:maven-plugins:37
> Compare with 
> https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MJAVADOC-731) Migrate components to JSR 330, get rid of maven-artifact-transfer, update to parent 37

2022-09-19 Thread Konrad Windszus (Jira)
Konrad Windszus created MJAVADOC-731:


 Summary: Migrate components to JSR 330, get rid of 
maven-artifact-transfer, update to parent 37
 Key: MJAVADOC-731
 URL: https://issues.apache.org/jira/browse/MJAVADOC-731
 Project: Maven Javadoc Plugin
  Issue Type: Improvement
Reporter: Konrad Windszus
Assignee: Konrad Windszus


Get rid of legacy:
* Annotations should be migrated to JSR 330 
(https://github.com/eclipse/sisu.plexus/wiki/Plexus-to-JSR330)
* m-artifact-transfer no longer necessary as plugin requires Maven 3.2.5, use 
Aether API directly
* Update to latest parent org.apache.maven.plugins:maven-plugins:37



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7541) Native support for powershell to start maven

2022-09-19 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606466#comment-17606466
 ] 

Michael Osipov commented on MNG-7541:
-

I have tought about this and the only benefit I see is that variables aren't 
automatically exported. What else?

> Native support for powershell to start maven
> 
>
> Key: MNG-7541
> URL: https://issues.apache.org/jira/browse/MNG-7541
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.8.3
> Environment: windows 10 / 11
>Reporter: Jurrian Fahner
>Priority: Trivial
>  Labels: Script, Windows10, Windows11
>
> Maven has two files in the bin dir:
> ||command||its use||
> |mvn|POSIX shell|
> |mvn.cmd|cmd.exe|
> On windows there are two ways to write scripts, by using cmd.exe or using 
> powershell.
> If you enter mvn in powershell it will look for `mvn.ps1` on the PATH first. 
> If it doesn't find anything it will execute `mvn.cmd` as fall-back.
> When running maven for starting a server for development purposes and you do 
> ctrl-c to exit the server it will ask the question: Terminate batch job (Y/N)?
> As far as I know it is default behaviour of cmd.exe.
> Well if I don't want to terminate, I wouldn't press ctrl-c. ;)
> It is not the case (as far as I know that Microsoft is going to deprecate 
> cmd.exe in favor of powershell: 
> [https://devblogs.microsoft.com/commandline/rumors-of-cmds-death-have-been-greatly-exaggerated/]
> Allthough I think it would be a good move for maven to have also a powershell 
> script as well... It is possible to integrate elegant support for native help 
> in powershell, `get-help mvn`.
> But it also increases the maintenance effort as well. I don't know whether 
> this cost outweigh the benefits, though...
> By the way I would happy to contribute if it is appreciated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7541) Native support for powershell to start maven

2022-09-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7541:

Description: 
Maven has two files in the bin dir:
||command||its use||
|mvn|POSIX shell|
|mvn.cmd|cmd.exe|

On windows there are two ways to write scripts, by using cmd.exe or using 
powershell.

If you enter mvn in powershell it will look for `mvn.ps1` on the PATH first. If 
it doesn't find anything it will execute `mvn.cmd` as fall-back.

When running maven for starting a server for development purposes and you do 
ctrl-c to exit the server it will ask the question: Terminate batch job (Y/N)?

As far as I know it is default behaviour of cmd.exe.

Well if I don't want to terminate, I wouldn't press ctrl-c. ;)

It is not the case (as far as I know that Microsoft is going to deprecate 
cmd.exe in favor of powershell: 
[https://devblogs.microsoft.com/commandline/rumors-of-cmds-death-have-been-greatly-exaggerated/]

Allthough I think it would be a good move for maven to have also a powershell 
script as well... It is possible to integrate elegant support for native help 
in powershell, `get-help mvn`.

But it also increases the maintenance effort as well. I don't know whether this 
cost outweigh the benefits, though...

By the way I would happy to contribute if it is appreciated.

  was:
Maven has two files in the bin dir:
||command||it's use||
|mvn|bash|
|mvn.cmd|cmd.exe|

On windows there are two ways to write scripts, by using cmd.exe or using 
powershell.

If you enter mvn in powershell it will look for `mvn.ps1` on the PATH first. If 
it doesn't find anything it will execute `mvn.cmd` as fall-back.

When running maven for starting a server for development purposes and you do 
ctrl-c to exit the server it will ask the question: Terminate batch job (Y/N)?

As far as I know it is default behaviour of cmd.exe.

Well if I don't want to terminate, I wouldn't press ctrl-c. ;)

It is not the case (as far as I know that Microsoft is going to deprecate 
cmd.exe in favor of powershell: 
[https://devblogs.microsoft.com/commandline/rumors-of-cmds-death-have-been-greatly-exaggerated/]

Allthough I think it would be a good move for maven to have also a powershell 
script as well... It is possible to integrate elegant support for native help 
in powershell, `get-help mvn`.

But it also increases the maintenance effort as well. I don't know whether this 
cost outweigh the benefits, though...

By the way I would happy to contribute if it is appreciated.


> Native support for powershell to start maven
> 
>
> Key: MNG-7541
> URL: https://issues.apache.org/jira/browse/MNG-7541
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.8.3
> Environment: windows 10 / 11
>Reporter: Jurrian Fahner
>Priority: Trivial
>  Labels: Script, Windows10, Windows11
>
> Maven has two files in the bin dir:
> ||command||its use||
> |mvn|POSIX shell|
> |mvn.cmd|cmd.exe|
> On windows there are two ways to write scripts, by using cmd.exe or using 
> powershell.
> If you enter mvn in powershell it will look for `mvn.ps1` on the PATH first. 
> If it doesn't find anything it will execute `mvn.cmd` as fall-back.
> When running maven for starting a server for development purposes and you do 
> ctrl-c to exit the server it will ask the question: Terminate batch job (Y/N)?
> As far as I know it is default behaviour of cmd.exe.
> Well if I don't want to terminate, I wouldn't press ctrl-c. ;)
> It is not the case (as far as I know that Microsoft is going to deprecate 
> cmd.exe in favor of powershell: 
> [https://devblogs.microsoft.com/commandline/rumors-of-cmds-death-have-been-greatly-exaggerated/]
> Allthough I think it would be a good move for maven to have also a powershell 
> script as well... It is possible to integrate elegant support for native help 
> in powershell, `get-help mvn`.
> But it also increases the maintenance effort as well. I don't know whether 
> this cost outweigh the benefits, though...
> By the way I would happy to contribute if it is appreciated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINVOKER-311) Override reports directory in IT test

2022-09-19 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MINVOKER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606457#comment-17606457
 ] 

Hudson commented on MINVOKER-311:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-invoker-plugin » master 
#48

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-invoker-plugin/job/master/48/

> Override reports directory in IT test
> -
>
> Key: MINVOKER-311
> URL: https://issues.apache.org/jira/browse/MINVOKER-311
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> ASF Jenkins looks for reports in path like:
> {code}
> **/target/invoker-reports/TEST*.xml
> {code}
> So report generated by integration tests are assumed like project reports ... 
> and build fail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-311) Override reports directory in IT test

2022-09-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-311.

Fix Version/s: next-release
   Resolution: Fixed

> Override reports directory in IT test
> -
>
> Key: MINVOKER-311
> URL: https://issues.apache.org/jira/browse/MINVOKER-311
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> ASF Jenkins looks for reports in path like:
> {code}
> **/target/invoker-reports/TEST*.xml
> {code}
> So report generated by integration tests are assumed like project reports ... 
> and build fail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-invoker-plugin] slawekjaranowski merged pull request #142: [MINVOKER-311] Override reports directory in IT test

2022-09-19 Thread GitBox


slawekjaranowski merged PR #142:
URL: https://github.com/apache/maven-invoker-plugin/pull/142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPLUGINTESTING-75) Support JSR 330 components

2022-09-19 Thread Konrad Windszus (Jira)
Konrad Windszus created MPLUGINTESTING-75:
-

 Summary: Support JSR 330 components
 Key: MPLUGINTESTING-75
 URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-75
 Project: Maven Plugin Testing
  Issue Type: Improvement
  Components: plugin-testing-harness
Affects Versions: 3.3.0
Reporter: Konrad Windszus


Currently AbstractMojoTestCase can only inject legacy Plexus components but no 
JSR 330 components 
(https://github.com/eclipse/sisu.plexus/wiki/Plexus-to-JSR330).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)