[GitHub] [maven-invoker] iofit commented on a diff in pull request #56: [MSHARED-1152] - Migrate tests to JUnit5

2022-10-20 Thread GitBox


iofit commented on code in PR #56:
URL: https://github.com/apache/maven-invoker/pull/56#discussion_r1001364433


##
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##
@@ -857,46 +846,46 @@ public void testShouldInsertActivatedProfiles()
 public void testMvnExecutableFromInvoker()
 throws Exception
 {
-assumeThat( "Test only works when maven.home is set",
-System.getProperty( "maven.home" ), is(notNullValue()));
+assumingThat( Objects.nonNull(System.getProperty( "maven.home" )),
+() -> System.out.println("Test only works when maven.home is 
set"));

Review Comment:
   I think you're right, I missed that specific part, thank you for catching 
it, I've replaced assumingThat with assumeTrue which should abort/skip the test 
if the condition is not met.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-mvnd] seanf opened a new issue, #725: mvnd incompatible with Gradle's build-scan extension

2022-10-20 Thread GitBox


seanf opened a new issue, #725:
URL: https://github.com/apache/maven-mvnd/issues/725

   The `gradle-enterprise-maven-extension` (version 1.15.4) works with Maven 
3.8.6, but reports "MavenPluginManager was not overridden" when run via `mvnd`.
   
   ```
   ❯ mvnd initialize
   [WARN] Failed to initialize spy 
com.gradle.maven.internal.GradleEnterpriseLifecycleManager: build operation 
notification valve already started
   [INFO] Processing build on daemon c31a048e
   [ERROR] Internal error: java.lang.IllegalStateException: MavenPluginManager 
was not overridden -> [Help 1]
   org.apache.maven.InternalErrorException: Internal error: 
java.lang.IllegalStateException: MavenPluginManager was not overridden
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:120)
at org.apache.maven.cli.DaemonMavenCli.execute(DaemonMavenCli.java:687)
at org.apache.maven.cli.DaemonMavenCli.doMain(DaemonMavenCli.java:239)
at org.apache.maven.cli.DaemonMavenCli.main(DaemonMavenCli.java:215)
at org.mvndaemon.mvnd.daemon.Server.handle(Server.java:572)
at org.mvndaemon.mvnd.daemon.Server.client(Server.java:256)
at org.mvndaemon.mvnd.daemon.Server.accept(Server.java:224)
at java.base/java.lang.Thread.run(Thread.java:1589)
   Caused by: java.lang.IllegalStateException: MavenPluginManager was not 
overridden
at com.gradle.enterprise.b.a.a(SourceFile:146)
at com.gradle.enterprise.b.a.a(SourceFile:39)
at 
com.gradle.maven.internal.GradleEnterpriseLifecycleManager.afterSessionStart(SourceFile:138)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:208)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
... 7 common frames omitted
   [ERROR]
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR]
   [ERROR] For more information about the errors and possible solutions, please 
read the following articles:
   [ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/InternalErrorException
   ```
   
   See example project here: 
https://github.com/seanf/gradle-enterprise-maven-extension-mvnd-bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] nielsbasjes commented on a diff in pull request #838: Fix project versions not updated during release

2022-10-20 Thread GitBox


nielsbasjes commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001170291


##
maven-model/src/test/resources/xml/pom.xml:
##
@@ -25,7 +25,7 @@ under the License.
   
 org.apache.maven
 maven
-4.0.0-alpha-1-SNAPSHOT
+4.0.0-alpha-3-SNAPSHOT

Review Comment:
   Resource filtering works.
   Even though the version is `dummy-version` the places where it says 
`${project.version}` now actually becomes the actual version of the project for 
testing purposes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] nielsbasjes commented on a diff in pull request #838: Fix project versions not updated during release

2022-10-20 Thread GitBox


nielsbasjes commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001169223


##
maven-model/pom.xml:
##
@@ -64,7 +64,7 @@ under the License.
 
   org.apache.maven
   maven-api-model
-  4.0.0-alpha-1-SNAPSHOT
+  4.0.0-alpha-3-SNAPSHOT

Review Comment:
   I've set it to ${project.version} in all files I touched.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] nielsbasjes commented on a diff in pull request #838: Fix project versions not updated during release

2022-10-20 Thread GitBox


nielsbasjes commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001161125


##
maven-model/src/test/resources/xml/pom.xml:
##
@@ -25,7 +25,7 @@ under the License.
   
 org.apache.maven
 maven
-4.0.0-alpha-1-SNAPSHOT
+4.0.0-alpha-3-SNAPSHOT

Review Comment:
   Yes.
   The tricky part here is that in this file all versions were missed.
   I'll have to check if something as resource filtering can handle this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] nielsbasjes commented on a diff in pull request #838: Fix project versions not updated during release

2022-10-20 Thread GitBox


nielsbasjes commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001158468


##
maven-model/pom.xml:
##
@@ -64,7 +64,7 @@ under the License.
 
   org.apache.maven
   maven-api-model
-  4.0.0-alpha-1-SNAPSHOT
+  4.0.0-alpha-3-SNAPSHOT

Review Comment:
   How about I change it everywhere where possible to `${project.version}`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] gnodet commented on a diff in pull request #838: Fix project versions not updated during release

2022-10-20 Thread GitBox


gnodet commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001138925


##
maven-model/pom.xml:
##
@@ -64,7 +64,7 @@ under the License.
 
   org.apache.maven
   maven-api-model
-  4.0.0-alpha-1-SNAPSHOT
+  4.0.0-alpha-3-SNAPSHOT

Review Comment:
   Given the version is not changed during the release, this will break again.  
Would you mind changing to `${project.version}` instead ?



##
maven-model/src/test/resources/xml/pom.xml:
##
@@ -25,7 +25,7 @@ under the License.
   
 org.apache.maven
 maven
-4.0.0-alpha-1-SNAPSHOT
+4.0.0-alpha-3-SNAPSHOT

Review Comment:
   This file is a test pom which is simply loaded, the version number is not 
important.  For clarity, if we really want to change it, maybe use something 
like `dummy-version` instead of something that can be misinterpreted as a real 
version.



##
maven-settings/pom.xml:
##
@@ -68,7 +68,7 @@ under the License.
 
   org.apache.maven
   maven-api-settings
-  4.0.0-alpha-1-SNAPSHOT
+  4.0.0-alpha-3-SNAPSHOT

Review Comment:
   Use `${project.version}`.



##
maven-toolchain-model/pom.xml:
##
@@ -67,7 +67,7 @@ under the License.
 
 org.apache.maven
 
maven-api-toolchain
-4.0.0-alpha-1-SNAPSHOT
+4.0.0-alpha-3-SNAPSHOT

Review Comment:
   Use `${project.version}`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHADE-417) Fix null bytes appended to small files by maven-shade-plugin

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621373#comment-17621373
 ] 

Hudson commented on MSHADE-417:
---

Build succeeded in Jenkins: Maven » Maven TLP » maven-shade-plugin » master #44

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-shade-plugin/job/master/44/

> Fix null bytes appended to small files by maven-shade-plugin
> 
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Max Zerzouri
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.4.1
>
> Attachments: original-shadetest-0.0.0.jar, pom.xml, 
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if 
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> : 61   a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> : 6100 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in 
> the previous version, 3.2.4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHADE-366) The warning "Access denied" during 'minimizeJar' is always printed

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621372#comment-17621372
 ] 

Hudson commented on MSHADE-366:
---

Build succeeded in Jenkins: Maven » Maven TLP » maven-shade-plugin » master #44

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-shade-plugin/job/master/44/

> The warning "Access denied" during 'minimizeJar' is always printed
> --
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.4.1
>
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] gnodet commented on pull request #838: Fix project versions not updated during release

2022-10-20 Thread GitBox


gnodet commented on PR #838:
URL: https://github.com/apache/maven/pull/838#issuecomment-1286160985

   It's not only that, the `versions:set` goal did not update it during the 
release either:
 
https://github.com/apache/maven/blob/maven-4.0.0-alpha-2/maven-model/pom.xml#L64-L71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] gnodet merged pull request #836: Restore compatibility with 3.x

2022-10-20 Thread GitBox


gnodet merged PR #836:
URL: https://github.com/apache/maven/pull/836


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MSHADE-413) Maven share plugin enters endless loop

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MSHADE-413:
---
Fix Version/s: 3.4.1

> Maven share plugin enters endless loop 
> ---
>
> Key: MSHADE-413
> URL: https://issues.apache.org/jira/browse/MSHADE-413
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.4
>Reporter: Robert Stupp
>Priority: Critical
> Fix For: 3.4.1
>
>
> Two issues at play here:
> * {{ShadeMojo.createDependencyReducedPom()}} pulls in {{origDeps = 
> project.getDependencies()}} and later modifies these {{Dependency}} objects.
> * {{ShadeMojo.updateExcludesInDeps()}} enters it's own endless loop, 
> endlessly adding the exact same exclusions.
> This leads to a 
> [reproducible|https://github.com/projectnessie/nessie/issues/3678] endless 
> loop (see below).
> If the Shade plugin's not using the {{Dependency}} objects "owned by Maven 
> itself" (by setting {{promoteTransitiveDependencies}} to {{true}}), the build 
> passes fine.
> I think, _modifying_ the {{Dependency}} objects "owned by Maven itself" is 
> bad for two reasons (which IMO justify the increased priority of this 
> ticket): 
> # the reproducible endless loop
> # it breaks the correctness of the project build - at least plugins running 
> after the {{shade}} goal that use those dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-shade-plugin] gnodet closed pull request #83: [MSHADE-366] - "Access denied" during 'minimizeJar'

2022-10-20 Thread GitBox


gnodet closed pull request #83: [MSHADE-366] - "Access denied" during 
'minimizeJar'
URL: https://github.com/apache/maven-shade-plugin/pull/83


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet closed pull request #104: [MSHADE-366] - "Access denied" during 'minimizeJar' (supersedes #83)

2022-10-20 Thread GitBox


gnodet closed pull request #104: [MSHADE-366] - "Access denied" during 
'minimizeJar' (supersedes #83)
URL: https://github.com/apache/maven-shade-plugin/pull/104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MSHADE-366) The warning "Access denied" during 'minimizeJar' is always printed

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MSHADE-366.
--
Resolution: Fixed

> The warning "Access denied" during 'minimizeJar' is always printed
> --
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.4.1
>
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHADE-417) Fix null bytes appended to small files by maven-shade-plugin

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MSHADE-417.
--
Resolution: Fixed

> Fix null bytes appended to small files by maven-shade-plugin
> 
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Max Zerzouri
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.4.1
>
> Attachments: original-shadetest-0.0.0.jar, pom.xml, 
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if 
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> : 61   a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> : 6100 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in 
> the previous version, 3.2.4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-shade-plugin] gnodet merged pull request #160: [MSHADE-417] Fix null bytes appended to small files

2022-10-20 Thread GitBox


gnodet merged PR #160:
URL: https://github.com/apache/maven-shade-plugin/pull/160


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet merged pull request #161: [MSHADE-366] "Access denied" during 'minimizeJar'

2022-10-20 Thread GitBox


gnodet merged PR #161:
URL: https://github.com/apache/maven-shade-plugin/pull/161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (DOXIA-667) Add and to recognized tag list

2022-10-20 Thread John Dimeo (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621307#comment-17621307
 ] 

John Dimeo edited comment on DOXIA-667 at 10/20/22 6:25 PM:


Thank you for looking into this! Like I said, I don't think anything is broken, 
it's just that this happens with 45k Markdown files :) (and I haven't been able 
to suppress it successfully even with the MAVEN_OPTS variable and 
{{{}-Dorg.slf4j.simpleLogger.org.apache.maven.doxia.module.xhtml5=error{}}})
!image-2022-10-20-14-24-40-888.png!


was (Author: jdimeo):
Thank you for looking into this! Like I said, I don't think anything is broken, 
it's just that this happens with 45k Markdown files :)
!image-2022-10-20-14-24-40-888.png!

> Add  and  to recognized tag list
> --
>
> Key: DOXIA-667
> URL: https://issues.apache.org/jira/browse/DOXIA-667
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Module - Xhtml
>Reporter: John Dimeo
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: hw_age.md, image-2022-10-20-14-24-40-888.png
>
>
> I see both {{}} and {{}} here:
> [maven-doxia/HtmlMarkup.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java]
> is there a reason it's not part of {{ALL_TAGS}} here?
> [https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java#L42]
> I'm getting this error:
> [maven-doxia/Xhtml5BaseSink.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L2206]
> when I try to use details/disclosure in a Markdown file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (DOXIA-667) Add and to recognized tag list

2022-10-20 Thread John Dimeo (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Dimeo updated DOXIA-667:
-
Attachment: image-2022-10-20-14-24-40-888.png

> Add  and  to recognized tag list
> --
>
> Key: DOXIA-667
> URL: https://issues.apache.org/jira/browse/DOXIA-667
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Module - Xhtml
>Reporter: John Dimeo
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: hw_age.md, image-2022-10-20-14-24-40-888.png
>
>
> I see both {{}} and {{}} here:
> [maven-doxia/HtmlMarkup.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java]
> is there a reason it's not part of {{ALL_TAGS}} here?
> [https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java#L42]
> I'm getting this error:
> [maven-doxia/Xhtml5BaseSink.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L2206]
> when I try to use details/disclosure in a Markdown file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIA-667) Add and to recognized tag list

2022-10-20 Thread John Dimeo (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621307#comment-17621307
 ] 

John Dimeo commented on DOXIA-667:
--

Thank you for looking into this! Like I said, I don't think anything is broken, 
it's just that this happens with 45k Markdown files :)
!image-2022-10-20-14-24-40-888.png!

> Add  and  to recognized tag list
> --
>
> Key: DOXIA-667
> URL: https://issues.apache.org/jira/browse/DOXIA-667
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Module - Xhtml
>Reporter: John Dimeo
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: hw_age.md, image-2022-10-20-14-24-40-888.png
>
>
> I see both {{}} and {{}} here:
> [maven-doxia/HtmlMarkup.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java]
> is there a reason it's not part of {{ALL_TAGS}} here?
> [https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java#L42]
> I'm getting this error:
> [maven-doxia/Xhtml5BaseSink.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L2206]
> when I try to use details/disclosure in a Markdown file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-mvnd] adamretter commented on issue #714: mvnd for Github Actions

2022-10-20 Thread GitBox


adamretter commented on issue #714:
URL: https://github.com/apache/maven-mvnd/issues/714#issuecomment-1285892997

   @gnodet That's neat :-)
   Am I reading correctly that it looks like it only supports Linux?
   I was wondering if there was a desire from the apache/maven-mvnd project to 
publish a GitHub action to the GitHub marketplace for everyone to use - if so, 
perhaps your code could form the basis of that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] nielsbasjes opened a new pull request, #839: [MNG-5659] Project level settings.xml

2022-10-20 Thread GitBox


nielsbasjes opened a new pull request, #839:
URL: https://github.com/apache/maven/pull/839

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you 
replace `MNG-XXX`
  and `SUMMARY` with the appropriate JIRA issue. Best practice is to 
use the JIRA issue
  title in the pull request title and in the first line of the commit 
message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   I'm one of the committers for Apache Avro and Apache Flink.
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   
   ---
   This is a first attempt to make it possible to automatically read a settings 
file which is part of a project. The situation where this is useful to me is in 
multi module projects within a company where a mandatory mirror must be used.
   
   The initial version of this pull request is incomplete as it is only the 
code to make it work, no tests and no documentation at this point.
   I will write all of those once you have approved the basic implementation 
direction and the core choices I have made so far.
   
   Right now:
   - The default assumed location is `${project.basedir}/.mvn/settings.xml`
   - If this file is present it is read with 
 - a prio higher than the global settings 
 - a lower prio than the user settings; I'm unsure if this is correct.
   - It is the same file spec as the normal settings.xml, yet in the project 
level context some of those settings may not make any sense.
   
   Looking forward to your feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-5659) Project specific settings.xml

2022-10-20 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621234#comment-17621234
 ] 

ASF GitHub Bot commented on MNG-5659:
-

nielsbasjes opened a new pull request, #839:
URL: https://github.com/apache/maven/pull/839

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you 
replace `MNG-XXX`
  and `SUMMARY` with the appropriate JIRA issue. Best practice is to 
use the JIRA issue
  title in the pull request title and in the first line of the commit 
message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   I'm one of the committers for Apache Avro and Apache Flink.
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   
   ---
   This is a first attempt to make it possible to automatically read a settings 
file which is part of a project. The situation where this is useful to me is in 
multi module projects within a company where a mandatory mirror must be used.
   
   The initial version of this pull request is incomplete as it is only the 
code to make it work, no tests and no documentation at this point.
   I will write all of those once you have approved the basic implementation 
direction and the core choices I have made so far.
   
   Right now:
   - The default assumed location is `${project.basedir}/.mvn/settings.xml`
   - If this file is present it is read with 
 - a prio higher than the global settings 
 - a lower prio than the user settings; I'm unsure if this is correct.
   - It is the same file spec as the normal settings.xml, yet in the project 
level context some of those settings may not make any sense.
   
   Looking forward to your feedback.




> Project specific settings.xml
> -
>
> Key: MNG-5659
> URL: https://issues.apache.org/jira/browse/MNG-5659
> Project: Maven
>  Issue Type: New Feature
>  Components: FDPFC
>Reporter: Joachim Van der Auwera
>Priority: Major
> Fix For: Issues to be reviewed for 4.x
>
> Attachments: mvn.patch
>
>
> It would be useful to have a settings.xml file next to the project pom that 
> could contain project specific settings.  For example, when switching between 
> projects it is sometimes necessary to also change the location of the local 
> repository, or use a different set of repositories and/or mirror settings for 
> each project.
> If a settings.xml file could be included with a project checkout, then the 
> repositories needed for the build could be included (instead of putting them 
> in the pom) along with any other project specific settings.
> The tricky part is intelligently handling multi-module projects.  For a 
> multi-module project I don't want to include a separate settings.xml file for 
> each directory.  So Maven could recursively check each parent directory until 
> it either (1) finds a settings.xml, (2) finds a directory with no pom.xml, or 
> (3) finds the root directory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHADE-432) Duplicate services entries can be generated

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621196#comment-17621196
 ] 

Hudson commented on MSHADE-432:
---

Build succeeded in Jenkins: Maven » Maven TLP » maven-shade-plugin » master #43

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-shade-plugin/job/master/43/

> Duplicate services entries can be generated
> ---
>
> Key: MSHADE-432
> URL: https://issues.apache.org/jira/browse/MSHADE-432
> Project: Maven Shade Plugin
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.4.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHADE-366) The warning "Access denied" during 'minimizeJar' is always printed

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MSHADE-366:
---
Fix Version/s: 3.4.1

> The warning "Access denied" during 'minimizeJar' is always printed
> --
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 3.4.1
>
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MSHADE-417) Fix null bytes appended to small files by maven-shade-plugin

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet reassigned MSHADE-417:
--

Assignee: Guillaume Nodet
 Summary: Fix null bytes appended to small files by maven-shade-plugin  
(was: Nul bytes appended to small files by maven-shade-plugin)

> Fix null bytes appended to small files by maven-shade-plugin
> 
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Max Zerzouri
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.4.1
>
> Attachments: original-shadetest-0.0.0.jar, pom.xml, 
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if 
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> : 61   a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> : 6100 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in 
> the previous version, 3.2.4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIA-667) Add and to recognized tag list

2022-10-20 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621189#comment-17621189
 ] 

Michael Osipov commented on DOXIA-667:
--

Thanks, will check on the weekend.

> Add  and  to recognized tag list
> --
>
> Key: DOXIA-667
> URL: https://issues.apache.org/jira/browse/DOXIA-667
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Module - Xhtml
>Reporter: John Dimeo
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: hw_age.md
>
>
> I see both {{}} and {{}} here:
> [maven-doxia/HtmlMarkup.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java]
> is there a reason it's not part of {{ALL_TAGS}} here?
> [https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java#L42]
> I'm getting this error:
> [maven-doxia/Xhtml5BaseSink.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L2206]
> when I try to use details/disclosure in a Markdown file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHADE-432) Duplicate services entries can be generated

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MSHADE-432.
--
Resolution: Fixed

> Duplicate services entries can be generated
> ---
>
> Key: MSHADE-432
> URL: https://issues.apache.org/jira/browse/MSHADE-432
> Project: Maven Shade Plugin
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.4.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-shade-plugin] gnodet merged pull request #159: [MSHADE-432] Avoid duplicate META-INF/services entries

2022-10-20 Thread GitBox


gnodet merged PR #159:
URL: https://github.com/apache/maven-shade-plugin/pull/159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet merged pull request #156: Bump asmVersion from 9.3 to 9.4

2022-10-20 Thread GitBox


gnodet merged PR #156:
URL: https://github.com/apache/maven-shade-plugin/pull/156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet merged pull request #148: Bump maven-dependency-tree from 3.0.1 to 3.2.0

2022-10-20 Thread GitBox


gnodet merged PR #148:
URL: https://github.com/apache/maven-shade-plugin/pull/148


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (DOXIA-667) Add and to recognized tag list

2022-10-20 Thread John Dimeo (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621186#comment-17621186
 ] 

John Dimeo commented on DOXIA-667:
--

[^hw_age.md]

> Add  and  to recognized tag list
> --
>
> Key: DOXIA-667
> URL: https://issues.apache.org/jira/browse/DOXIA-667
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Module - Xhtml
>Reporter: John Dimeo
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: hw_age.md
>
>
> I see both {{}} and {{}} here:
> [maven-doxia/HtmlMarkup.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java]
> is there a reason it's not part of {{ALL_TAGS}} here?
> [https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java#L42]
> I'm getting this error:
> [maven-doxia/Xhtml5BaseSink.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L2206]
> when I try to use details/disclosure in a Markdown file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (DOXIA-667) Add and to recognized tag list

2022-10-20 Thread John Dimeo (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Dimeo updated DOXIA-667:
-
Attachment: hw_age.md

> Add  and  to recognized tag list
> --
>
> Key: DOXIA-667
> URL: https://issues.apache.org/jira/browse/DOXIA-667
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Module - Xhtml
>Reporter: John Dimeo
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: hw_age.md
>
>
> I see both {{}} and {{}} here:
> [maven-doxia/HtmlMarkup.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java]
> is there a reason it's not part of {{ALL_TAGS}} here?
> [https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java#L42]
> I'm getting this error:
> [maven-doxia/Xhtml5BaseSink.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L2206]
> when I try to use details/disclosure in a Markdown file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIA-667) Add and to recognized tag list

2022-10-20 Thread John Dimeo (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621184#comment-17621184
 ] 

John Dimeo commented on DOXIA-667:
--

OK this Markdown file produces these specific warnings. It seems to not be 
breaking anything, as far as I can tell, but this high volume of warnings is 
overflowing my CI/CD logs.

[^hw_age.md]

```
[WARNING] Unrecognized xhtml5 tag  at [2:8]
[WARNING] Unrecognized xhtml5 tag  at [2:79]
[WARNING] Unrecognized xhtml5 tag  at [5:64]
[WARNING] Unrecognized xhtml5 tag  at [8:8]
[WARNING] Unrecognized xhtml5 tag  at [8:74]
[WARNING] Unrecognized xhtml5 tag  at [30:302]
```

> Add  and  to recognized tag list
> --
>
> Key: DOXIA-667
> URL: https://issues.apache.org/jira/browse/DOXIA-667
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Module - Xhtml
>Reporter: John Dimeo
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> I see both {{}} and {{}} here:
> [maven-doxia/HtmlMarkup.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java]
> is there a reason it's not part of {{ALL_TAGS}} here?
> [https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java#L42]
> I'm getting this error:
> [maven-doxia/Xhtml5BaseSink.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L2206]
> when I try to use details/disclosure in a Markdown file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHADE-366) "Access denied" during 'minimizeJar'

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MSHADE-366:
---
Priority: Minor  (was: Major)

> "Access denied" during 'minimizeJar'
> 
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Priority: Minor
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHADE-366) The warning "Access denied" during 'minimizeJar' is always printed

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MSHADE-366:
---
Summary: The warning "Access denied" during 'minimizeJar' is always printed 
 (was: "Access denied" during 'minimizeJar')

> The warning "Access denied" during 'minimizeJar' is always printed
> --
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Priority: Minor
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MSHADE-366) The warning "Access denied" during 'minimizeJar' is always printed

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet reassigned MSHADE-366:
--

Assignee: Guillaume Nodet

> The warning "Access denied" during 'minimizeJar' is always printed
> --
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Assignee: Guillaume Nodet
>Priority: Minor
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHADE-366) "Access denied" during 'minimizeJar'

2022-10-20 Thread Guillaume Nodet (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621178#comment-17621178
 ] 

Guillaume Nodet commented on MSHADE-366:


I've reproduced the problem and propose a small fix on top of the existing PR 
at https://github.com/apache/maven-shade-plugin/pull/161.

> "Access denied" during 'minimizeJar'
> 
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-shade-plugin] gnodet opened a new pull request, #161: [MSHADE-366] "Access denied" during 'minimizeJar'

2022-10-20 Thread GitBox


gnodet opened a new pull request, #161:
URL: https://github.com/apache/maven-shade-plugin/pull/161

   Follow-up on #104 and #83.
   
   The fact that the build output directory has to be handled is legit because 
the minified calls `project.getRuntimeClassPathElements()` which returns a list 
of the project output dir and all dependencies jars.  It has to be handled 
specifically.  Any other directory will print a warning as currently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] nielsbasjes opened a new pull request, #838: Fix project versions not updated during release

2022-10-20 Thread GitBox


nielsbasjes opened a new pull request, #838:
URL: https://github.com/apache/maven/pull/838

   For an unknown reason the versions in the various modules were not updated 
correctly during the previous new snapshot version. 
   
   This only fixes the current versions. It does not address the root cause at 
this point.
   
   
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHADE-366) "Access denied" during 'minimizeJar'

2022-10-20 Thread Guillaume Nodet (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621127#comment-17621127
 ] 

Guillaume Nodet commented on MSHADE-366:


[~kriegaex] I've read all the discussions.  The question is whether this is the 
root cause of the problem.  I suspect no one had a project to reproduce the 
problem at hand (I'll try to setup one with your plugin config) so investigate 
what the real root cause is.  As indicated in comments, the {{target/classes}} 
directory is not supposed to be on the classpath, hence reviewers don't have a 
simple way to look for the real reason.
I'll try with the provided config and get back.
Is that a windows specific bug ?

> "Access denied" during 'minimizeJar'
> 
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MSHADE-366) "Access denied" during 'minimizeJar'

2022-10-20 Thread Alexander Kriegisch (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621104#comment-17621104
 ] 

Alexander Kriegisch edited comment on MSHADE-366 at 10/20/22 1:21 PM:
--

I beg your pardon, but this issue is easily reproducible by just doing what I 
described when opening it. A PR has been proposed and not merged. I also opened 
MSHADE-400 and provided yet [another 
PR|https://github.com/apache/maven-shade-plugin/pull/110], which also fixes 
this issue and has not been merged yet. The only reason this is still open is 
that nobody cares to fix it, not even with PRs that could be merged by one 
mouse click. The ball certainly is not in my court here.


was (Author: kriegaex):
I beg pardon, but this issue is easily reproducible by just doing what I 
described when opening it. A PR has been proposed and not merged. I also opened 
MSHADE-400 and provided yet [another 
PR|https://github.com/apache/maven-shade-plugin/pull/110], which also fixes 
this issue and has not been merged yet. The only reason this is still open is 
that nobody cares to fix it, not even with PRs that could be merged by one 
mouse click. The ball certainly is not in my court here.

> "Access denied" during 'minimizeJar'
> 
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHADE-366) "Access denied" during 'minimizeJar'

2022-10-20 Thread Alexander Kriegisch (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621104#comment-17621104
 ] 

Alexander Kriegisch commented on MSHADE-366:


I beg pardon, but this issue is easily reproducible by just doing what I 
described when opening it. A PR has been proposed and not merged. I also opened 
MSHADE-400 and provided yet [another 
PR|https://github.com/apache/maven-shade-plugin/pull/110], which also fixes 
this issue and has not been merged yet. The only reason this is still open is 
that nobody cares to fix it, not even with PRs that could be merged by one 
mouse click. The ball certainly is not in my court here.

> "Access denied" during 'minimizeJar'
> 
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-shade-plugin] je-ik commented on pull request #159: [MSHADE-432] Avoid duplicate META-INF/services entries

2022-10-20 Thread GitBox


je-ik commented on PR #159:
URL: 
https://github.com/apache/maven-shade-plugin/pull/159#issuecomment-1285502480

   Cool. :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHADE-431) Use a caching output stream

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621090#comment-17621090
 ] 

Hudson commented on MSHADE-431:
---

Build succeeded in Jenkins: Maven » Maven TLP » maven-shade-plugin » master #40

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-shade-plugin/job/master/40/

> Use a caching output stream
> ---
>
> Key: MSHADE-431
> URL: https://issues.apache.org/jira/browse/MSHADE-431
> Project: Maven Shade Plugin
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.4.1
>
>
> Use a caching output stream so that the files is not overwritten if the 
> content has not changed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHADE-431) Use a caching output stream

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MSHADE-431.
--
Resolution: Fixed

> Use a caching output stream
> ---
>
> Key: MSHADE-431
> URL: https://issues.apache.org/jira/browse/MSHADE-431
> Project: Maven Shade Plugin
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.4.1
>
>
> Use a caching output stream so that the files is not overwritten if the 
> content has not changed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-shade-plugin] gnodet merged pull request #158: [MSHADE-431] Use a caching output stream

2022-10-20 Thread GitBox


gnodet merged PR #158:
URL: https://github.com/apache/maven-shade-plugin/pull/158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-pmd-plugin] adangel merged pull request #99: Bump release-drafter/release-drafter from 5.21.0 to 5.21.1

2022-10-20 Thread GitBox


adangel merged PR #99:
URL: https://github.com/apache/maven-pmd-plugin/pull/99


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHADE-366) "Access denied" during 'minimizeJar'

2022-10-20 Thread Guillaume Nodet (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621085#comment-17621085
 ] 

Guillaume Nodet commented on MSHADE-366:


I know this one is a bit old, but if anyone has a reproducer, that would be 
fine to investigate the root cause.
Else, this issue will certainly be closed in the near future. [~kriegaex] 
[~jamodd]

> "Access denied" during 'minimizeJar'
> 
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in 
> IntelliJ IDEA Ultimate 2020.1)
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see 
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING] 
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
>  (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
>   
> org.apache.maven.plugins
> maven-shade-plugin
> 3.2.3
> 
>   
> package
> 
>   shade
> 
> 
>   true
>   false
>   false
> 
>   
> 
>   
> {code}
> I removed my filters because even without them the same warning occurs. As 
> soon as I deactivate {{minimizeJar}}, the warning is gone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-dependency-plugin] khmarbaise opened a new pull request, #255: [MDEP-832] - Remove commons-collections-4

2022-10-20 Thread GitBox


khmarbaise opened a new pull request, #255:
URL: https://github.com/apache/maven-dependency-plugin/pull/255

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MDEP) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MDEP-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MDEP-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet closed pull request #140: [MSHADE-417] Fix nul bytes appended to small files

2022-10-20 Thread GitBox


gnodet closed pull request #140: [MSHADE-417] Fix nul bytes appended to small 
files
URL: https://github.com/apache/maven-shade-plugin/pull/140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet opened a new pull request, #160: [MSHADE-417] Fix null bytes appended to small files

2022-10-20 Thread GitBox


gnodet opened a new pull request, #160:
URL: https://github.com/apache/maven-shade-plugin/pull/160

   Supersedes #140 
   Added a unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet closed pull request #32: [WIP] Ignore duplicate key errors for same content in META-INF/services

2022-10-20 Thread GitBox


gnodet closed pull request #32: [WIP] Ignore duplicate key errors for same 
content in META-INF/services
URL: https://github.com/apache/maven-shade-plugin/pull/32


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet opened a new pull request, #159: [MSHADE-432] Duplicate services entries can be generated

2022-10-20 Thread GitBox


gnodet opened a new pull request, #159:
URL: https://github.com/apache/maven-shade-plugin/pull/159

   JIRA issue: https://issues.apache.org/jira/browse/MSHADE-432


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (MDEP-832) Remove commons-collections-4

2022-10-20 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MDEP-832:


Assignee: Karl Heinz Marbaise

> Remove commons-collections-4
> 
>
> Key: MDEP-832
> URL: https://issues.apache.org/jira/browse/MDEP-832
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.4.0
>
>
> Remove the dependency:
> {code:xml}
> 
>  org.apache.commons
>  commons-collections4
>  4.2
>  
> {code}
> which is used only for a single method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHADE-432) Duplicate services entries can be generated

2022-10-20 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MSHADE-432:
--

 Summary: Duplicate services entries can be generated
 Key: MSHADE-432
 URL: https://issues.apache.org/jira/browse/MSHADE-432
 Project: Maven Shade Plugin
  Issue Type: Task
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: 3.4.1






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MDEP-832) Remove commons-collections-4

2022-10-20 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MDEP-832:


 Summary: Remove commons-collections-4
 Key: MDEP-832
 URL: https://issues.apache.org/jira/browse/MDEP-832
 Project: Maven Dependency Plugin
  Issue Type: Improvement
Affects Versions: 3.3.0
Reporter: Karl Heinz Marbaise
 Fix For: 3.4.0


Remove the dependency:
{code:xml}

 org.apache.commons
 commons-collections4
 4.2
 
{code}
which is used only for a single method.




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHADE-431) Use a caching output stream

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MSHADE-431:
---
Fix Version/s: 3.4.1

> Use a caching output stream
> ---
>
> Key: MSHADE-431
> URL: https://issues.apache.org/jira/browse/MSHADE-431
> Project: Maven Shade Plugin
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.4.1
>
>
> Use a caching output stream so that the files is not overwritten if the 
> content has not changed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHADE-417) Nul bytes appended to small files by maven-shade-plugin

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MSHADE-417:
---
Fix Version/s: 3.4.1

> Nul bytes appended to small files by maven-shade-plugin
> ---
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Max Zerzouri
>Priority: Major
> Fix For: 3.4.1
>
> Attachments: original-shadetest-0.0.0.jar, pom.xml, 
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if 
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> : 61   a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> : 6100 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in 
> the previous version, 3.2.4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MINSTALL-178) Maven Doesn't Pick Locally Installed Package / Artifact

2022-10-20 Thread Surendra (Jira)


[ 
https://issues.apache.org/jira/browse/MINSTALL-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621026#comment-17621026
 ] 

Surendra edited comment on MINSTALL-178 at 10/20/22 11:24 AM:
--

[~michael-o] please help understand this maven error, when does it happen? Why 
does maven look for a maven-metadata.xml file?


was (Author: JIRAUSER297246):
[~michael-o] please help understand this maven error, when does it happen? Why 
does maven look for a maven-metadat.xml file?

> Maven Doesn't Pick Locally Installed Package / Artifact
> ---
>
> Key: MINSTALL-178
> URL: https://issues.apache.org/jira/browse/MINSTALL-178
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 3.0.1
> Environment: Linux
>Reporter: Surendra
>Priority: Major
>  Labels: easyfix, performance
> Fix For: waiting-for-feedback
>
>
> Java Version - 11
> `mvn clean install` is not picking up a locally installed snapshot artifact 
> that is present in the .m2 folder.
> It complains with the following warning and then start looking for this 
> artifact in maven central -
>  
> {code:java}
> [DEBUG]  Could not find metadata
> ::0.0.1-SNAPSHOT/maven-metadata.xml in local {code}
>  
> I checked .m2 directory and it has maven-metadata-local.xml, why does maven 
> look for maven-metadata.xml file? It's a locally installed artifact and maven 
> should be able to pick this up directly. Looks like I'm missing something.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINSTALL-178) Maven Doesn't Pick Locally Installed Package / Artifact

2022-10-20 Thread Surendra (Jira)


[ 
https://issues.apache.org/jira/browse/MINSTALL-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621026#comment-17621026
 ] 

Surendra commented on MINSTALL-178:
---

[~michael-o] please help understand this maven error, when does it happen? Why 
does maven look for a maven-metadat.xml file?

> Maven Doesn't Pick Locally Installed Package / Artifact
> ---
>
> Key: MINSTALL-178
> URL: https://issues.apache.org/jira/browse/MINSTALL-178
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 3.0.1
> Environment: Linux
>Reporter: Surendra
>Priority: Major
>  Labels: easyfix, performance
> Fix For: waiting-for-feedback
>
>
> Java Version - 11
> `mvn clean install` is not picking up a locally installed snapshot artifact 
> that is present in the .m2 folder.
> It complains with the following warning and then start looking for this 
> artifact in maven central -
>  
> {code:java}
> [DEBUG]  Could not find metadata
> ::0.0.1-SNAPSHOT/maven-metadata.xml in local {code}
>  
> I checked .m2 directory and it has maven-metadata-local.xml, why does maven 
> look for maven-metadata.xml file? It's a locally installed artifact and maven 
> should be able to pick this up directly. Looks like I'm missing something.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MINSTALL-178) Maven Doesn't Pick Locally Installed Package / Artifact

2022-10-20 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MINSTALL-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MINSTALL-178:

Fix Version/s: waiting-for-feedback

> Maven Doesn't Pick Locally Installed Package / Artifact
> ---
>
> Key: MINSTALL-178
> URL: https://issues.apache.org/jira/browse/MINSTALL-178
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 3.0.1
> Environment: Linux
>Reporter: Surendra
>Priority: Major
>  Labels: easyfix, performance
> Fix For: waiting-for-feedback
>
>
> Java Version - 11
> `mvn clean install` is not picking up a locally installed snapshot artifact 
> that is present in the .m2 folder.
> It complains with the following warning and then start looking for this 
> artifact in maven central -
>  
> {code:java}
> [DEBUG]  Could not find metadata
> ::0.0.1-SNAPSHOT/maven-metadata.xml in local {code}
>  
> I checked .m2 directory and it has maven-metadata-local.xml, why does maven 
> look for maven-metadata.xml file? It's a locally installed artifact and maven 
> should be able to pick this up directly. Looks like I'm missing something.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINSTALL-178) Maven Doesn't Pick Locally Installed Package / Artifact

2022-10-20 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MINSTALL-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621016#comment-17621016
 ] 

Michael Osipov commented on MINSTALL-178:
-

Even if the statement is clear, but the environment not.

> Maven Doesn't Pick Locally Installed Package / Artifact
> ---
>
> Key: MINSTALL-178
> URL: https://issues.apache.org/jira/browse/MINSTALL-178
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 3.0.1
> Environment: Linux
>Reporter: Surendra
>Priority: Major
>  Labels: easyfix, performance
>
> Java Version - 11
> `mvn clean install` is not picking up a locally installed snapshot artifact 
> that is present in the .m2 folder.
> It complains with the following warning and then start looking for this 
> artifact in maven central -
>  
> {code:java}
> [DEBUG]  Could not find metadata
> ::0.0.1-SNAPSHOT/maven-metadata.xml in local {code}
>  
> I checked .m2 directory and it has maven-metadata-local.xml, why does maven 
> look for maven-metadata.xml file? It's a locally installed artifact and maven 
> should be able to pick this up directly. Looks like I'm missing something.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-invoker] slawekjaranowski commented on a diff in pull request #56: [MSHARED-1152] - Migrate tests to JUnit5

2022-10-20 Thread GitBox


slawekjaranowski commented on code in PR #56:
URL: https://github.com/apache/maven-invoker/pull/56#discussion_r1000439724


##
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##
@@ -857,46 +846,46 @@ public void testShouldInsertActivatedProfiles()
 public void testMvnExecutableFromInvoker()
 throws Exception
 {
-assumeThat( "Test only works when maven.home is set",
-System.getProperty( "maven.home" ), is(notNullValue()));
+assumingThat( Objects.nonNull(System.getProperty( "maven.home" )),
+() -> System.out.println("Test only works when maven.home is 
set"));

Review Comment:
   Ok, I think that whole test should be ignored.
   - old `assumeThat` skip test if condition is not meet
   - but `assumingThat` only skips execution of provided lambda not whole test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet opened a new pull request, #158: [MSHADE-431] Use a caching output stream

2022-10-20 Thread GitBox


gnodet opened a new pull request, #158:
URL: https://github.com/apache/maven-shade-plugin/pull/158

   Use a caching output stream to avoid overwriting the file if not needed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHADE-430) Remove usage of deprecated ModelBase#getReports()

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620964#comment-17620964
 ] 

Hudson commented on MSHADE-430:
---

Build succeeded in Jenkins: Maven » Maven TLP » maven-shade-plugin » master #38

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-shade-plugin/job/master/38/

> Remove usage of deprecated ModelBase#getReports()
> -
>
> Key: MSHADE-430
> URL: https://issues.apache.org/jira/browse/MSHADE-430
> Project: Maven Shade Plugin
>  Issue Type: Task
>Affects Versions: 3.4.0
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.4.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHADE-431) Use a caching output stream

2022-10-20 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MSHADE-431:
--

 Summary: Use a caching output stream
 Key: MSHADE-431
 URL: https://issues.apache.org/jira/browse/MSHADE-431
 Project: Maven Shade Plugin
  Issue Type: Task
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet


Use a caching output stream so that the files is not overwritten if the content 
has not changed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-shade-plugin] gnodet merged pull request #139: Bump plexus-utils from 3.3.0 to 3.4.2

2022-10-20 Thread GitBox


gnodet merged PR #139:
URL: https://github.com/apache/maven-shade-plugin/pull/139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shade-plugin] gnodet merged pull request #157: [MSHADE-430] Remove usage of deprecated ModelBase#getReports()

2022-10-20 Thread GitBox


gnodet merged PR #157:
URL: https://github.com/apache/maven-shade-plugin/pull/157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7543) Upgrade JUnit Jupiter Version 5.9.1

2022-10-20 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620949#comment-17620949
 ] 

ASF GitHub Bot commented on MNG-7543:
-

khmarbaise opened a new pull request, #837:
URL: https://github.com/apache/maven/pull/837

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you 
replace `MNG-XXX`
  and `SUMMARY` with the appropriate JIRA issue. Best practice is to 
use the JIRA issue
  title in the pull request title and in the first line of the commit 
message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Upgrade JUnit Jupiter Version 5.9.1
> ---
>
> Key: MNG-7543
> URL: https://issues.apache.org/jira/browse/MNG-7543
> Project: Maven
>  Issue Type: Dependency upgrade
>Affects Versions: 4.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.0-alpha-3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] khmarbaise opened a new pull request, #837: [MNG-7543] - Upgrade JUnit Jupiter Version 5.9.1

2022-10-20 Thread GitBox


khmarbaise opened a new pull request, #837:
URL: https://github.com/apache/maven/pull/837

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you 
replace `MNG-XXX`
  and `SUMMARY` with the appropriate JIRA issue. Best practice is to 
use the JIRA issue
  title in the pull request title and in the first line of the commit 
message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7566) Allow a Maven plugin to require a Java version through its plugin descriptor

2022-10-20 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620948#comment-17620948
 ] 

ASF GitHub Bot commented on MNG-7566:
-

kwin commented on PR #330:
URL: https://github.com/apache/maven-site/pull/330#issuecomment-1285234412

   I meanwhile figured out why the XSD is wrong and created 
https://github.com/codehaus-plexus/modello/issues/264 for that.




> Allow a Maven plugin to require a Java version through its plugin descriptor
> 
>
> Key: MNG-7566
> URL: https://issues.apache.org/jira/browse/MNG-7566
> Project: Maven
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Labels: plugin-descriptor-1.1
> Fix For: 4.0.0
>
>
> Currently a Maven plugin can only require a minimum Maven version via pom's 
> prerequisites (https://maven.apache.org/pom.html#Prerequisites). There is 
> currently no means to require a minimum Java version.
> I would suggest to slightly expand the plugin descriptor to include a 
> minimumJavaVersion element there as well and evaluate that before executing a 
> plugin goal and emit a good error message. The default Java version could be 
> determined by the target class file version.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-site] kwin commented on pull request #330: [MNG-7566] Plugin descriptor 1.1.0 adding element "requiredJavaVersion"

2022-10-20 Thread GitBox


kwin commented on PR #330:
URL: https://github.com/apache/maven-site/pull/330#issuecomment-1285234412

   I meanwhile figured out why the XSD is wrong and created 
https://github.com/codehaus-plexus/modello/issues/264 for that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7566) Allow a Maven plugin to require a Java version through its plugin descriptor

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620927#comment-17620927
 ] 

Hudson commented on MNG-7566:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7543 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7543/3/

> Allow a Maven plugin to require a Java version through its plugin descriptor
> 
>
> Key: MNG-7566
> URL: https://issues.apache.org/jira/browse/MNG-7566
> Project: Maven
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Labels: plugin-descriptor-1.1
> Fix For: 4.0.0
>
>
> Currently a Maven plugin can only require a minimum Maven version via pom's 
> prerequisites (https://maven.apache.org/pom.html#Prerequisites). There is 
> currently no means to require a minimum Java version.
> I would suggest to slightly expand the plugin descriptor to include a 
> minimumJavaVersion element there as well and evaluate that before executing a 
> plugin goal and emit a good error message. The default Java version could be 
> determined by the target class file version.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7549) Upgrade Core ITs to Maven Verifier 2.0.0-M1

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620930#comment-17620930
 ] 

Hudson commented on MNG-7549:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7543 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7543/3/

> Upgrade Core ITs to Maven Verifier 2.0.0-M1
> ---
>
> Key: MNG-7549
> URL: https://issues.apache.org/jira/browse/MNG-7549
> Project: Maven
>  Issue Type: Dependency upgrade
>  Components: Integration Tests
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7098) Project counter should be cumulative when using resume

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620926#comment-17620926
 ] 

Hudson commented on MNG-7098:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7543 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7543/3/

> Project counter should be cumulative when using resume
> --
>
> Key: MNG-7098
> URL: https://issues.apache.org/jira/browse/MNG-7098
> Project: Maven
>  Issue Type: Improvement
>  Components: Reactor and Workspace
>Reporter: Robert Scholte
>Priority: Minor
> Fix For: 4.0.0-alpha-2
>
>
> When doing a resume on a build, the counter now starts again at 1.
> E.g. Suppose a project has 10 modules and the 7th module fails. With a resume 
> now you'll see {{[1/4]}}.
> To me it makes more sense to say {{[7/10]}}. You're still as close to the end 
> as usual, but this indicates the size of the complete project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7570) Allow a Maven plugin to require a Maven version through its plugin descriptor

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620928#comment-17620928
 ] 

Hudson commented on MNG-7570:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7543 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7543/3/

> Allow a Maven plugin to require a Maven version through its plugin descriptor
> -
>
> Key: MNG-7570
> URL: https://issues.apache.org/jira/browse/MNG-7570
> Project: Maven
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Labels: plugin-descriptor-1.1
> Fix For: 4.0.0
>
>
> Although the minimum Maven version can be specified via pom's prerequisites 
> (https://maven.apache.org/pom.html#Prerequisites), there is currently no 
> element for this on the plugin descriptor. 
> I would suggest to slightly expand the plugin descriptor to include an 
> element there as well. If such an element is found it should take precedence 
> over pom prerequisites.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7106) VersionRange.toString() produces a string that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620925#comment-17620925
 ] 

Hudson commented on MNG-7106:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7543 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7543/3/

> VersionRange.toString() produces a string that cannot be parsed with 
> VersionRange.createFromVersionSpec() for same lower and upper bounds
> -
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> When a hard version requirement (Ex - [1.0]) is passed to 
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
>  it is parsed to [1.0, 1.0]. But, this version range is invalid [according to 
> this 
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
>  If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot 
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); // 
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0, 
> 1.0]"
> VersionRange exceptionVersionRange = 
> VersionRange.createFromVersionSpec(stringVersionRange); // <- 
> InvalidVersionSpecificationException( "Range cannot have identical 
> boundaries: [1.0, 1.0]" )
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7543) Upgrade JUnit Jupiter Version 5.9.1

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620929#comment-17620929
 ] 

Hudson commented on MNG-7543:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7543 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7543/3/

> Upgrade JUnit Jupiter Version 5.9.1
> ---
>
> Key: MNG-7543
> URL: https://issues.apache.org/jira/browse/MNG-7543
> Project: Maven
>  Issue Type: Dependency upgrade
>Affects Versions: 4.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.0-alpha-3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7547) Simplify G level metadata handling

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620924#comment-17620924
 ] 

Hudson commented on MNG-7547:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7543 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7543/3/

> Simplify G level metadata handling
> --
>
> Key: MNG-7547
> URL: https://issues.apache.org/jira/browse/MNG-7547
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories, Plugins and Lifecycle
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> The original fix from MNG-7055 can be tremendously simplified: the plugins 
> about to be deployed are JARs with embedded plugin descriptor, that contains 
> all the required information (GA, prefix, name) to make G level metadata 
> generator does everything on it's own, no need for hoops and loops at all. 
> Actually, with this, all 3 generators becomes self-sufficient, and no need 
> for caller to even fiddle with deploying metadata (as it happens 
> automatically, courtesy of resolver and resolver-provider in maven).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-6801) MavenXpp3Writer doesn't retain order of properties

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620923#comment-17620923
 ] 

Hudson commented on MNG-6801:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7543 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7543/3/

> MavenXpp3Writer doesn't retain order of properties
> --
>
> Key: MNG-6801
> URL: https://issues.apache.org/jira/browse/MNG-6801
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Reporter: Liana Lupsa
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.x-candidate, 4.0.0-alpha-2, 4.0.0
>
>
> Context: 
>  We are using pipeline-utility-steps-plugin which is a jenkins plugin which 
> uses the following classes:
>  
> [https://github.com/jenkinsci/pipeline-utility-steps-plugin/blob/master/src/main/java/org/jenkinsci/plugins/pipeline/utility/steps/maven/ReadMavenPomStep.java].
>  
> [https://github.com/jenkinsci/pipeline-utility-steps-plugin/blob/master/src/main/java/org/jenkinsci/plugins/pipeline/utility/steps/maven/WriteMavenPomStep.java#L32]
>  In our Jenkins file we have a stage that overwrites the version in the pom 
> with the computed version and for this we need pipeline-utility-steps-plugin.
> The problem is that the tags in the pom.xml are never retained in the same 
> order. The elements in the pom file are completelly rearranged.
>  For consistency reasons and idempotency we need to retain the structure and 
> simply update one line.
> Status:
>  After evaluating the plugin code we noticed that it uses: 
>  
> [https://github.com/jenkinsci/pipeline-utility-steps-plugin/blob/master/src/main/java/org/jenkinsci/plugins/pipeline/utility/steps/maven/WriteMavenPomStep.java#L32]
>  and imports:
>  import org.apache.maven.model.io.xpp3.MavenXpp3Writer;
>  with 
> [https://maven.apache.org/ref/3.3.9/maven-model/apidocs/src-html/org/apache/maven/model/io/xpp3/MavenXpp3Writer.html]
>  which uses 
>  XmlSerializer serializer = new MXSerializer();
>  
> [https://github.com/sonatype/plexus-utils/blob/master/src/main/java/org/codehaus/plexus/util/xml/pull/MXSerializer.java]
>  We think that maven XmlSerializer causes this problem.
> Example of the pom.xml changes:
> first build trigger:
> run 1:
> 
>  3.1.0
>  1.10.19
>  2.1
>  6.5.1
>  1.18.6
>  4.12
>  
> run 2:
> 
>  1.10.19
>  3.1.0
>  2.1
>  6.5.1
>  1.18.6
>  4.12
>  
> ​and run 3: 
> 
>  3.1.0
>  1.10.19
>  2.1
>  6.5.1
>  1.18.6
>  4.12
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7553) New clean API with immutable model

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620922#comment-17620922
 ] 

Hudson commented on MNG-7553:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7543 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7543/3/

> New clean API with immutable model
> --
>
> Key: MNG-7553
> URL: https://issues.apache.org/jira/browse/MNG-7553
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0
>
>
> https://github.com/apache/maven/tree/master/api



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MDEP-831) Remove not used dependencies / Replace parts

2022-10-20 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MDEP-831:


Assignee: Karl Heinz Marbaise

> Remove not used dependencies / Replace parts
> 
>
> Key: MDEP-831
> URL: https://issues.apache.org/jira/browse/MDEP-831
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.4.0
>
>
> Currently the dependency is not used at all:
> {code:xml}
> 
>  commons-beanutils
>  commons-beanutils
>  1.9.4
>  
> {code}
> The dependency is only used for a single method:
> {code:xml}
> 
>  org.apache.commons
>  commons-collections4
>  4.2
>  
> {code}
> The dependency is only used for two methods of StringUtils.
> {code:xml}
> 
> org.apache.commons
> commons-lang3
> 3.12.0
>  
> {code}
> The dependency is only used in tests for deleting a directory. 
> {code:xml}
> 
>   commons-io
>   commons-io
>   2.11.0
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MDEP-831) Remove not used dependencies / Replace parts

2022-10-20 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MDEP-831:


 Summary: Remove not used dependencies / Replace parts
 Key: MDEP-831
 URL: https://issues.apache.org/jira/browse/MDEP-831
 Project: Maven Dependency Plugin
  Issue Type: Improvement
Affects Versions: 3.3.0
Reporter: Karl Heinz Marbaise
 Fix For: 3.4.0


Currently the dependency is not used at all:
{code:xml}

 commons-beanutils
 commons-beanutils
 1.9.4
 
{code}
The dependency is only used for a single method:
{code:xml}

 org.apache.commons
 commons-collections4
 4.2
 
{code}
The dependency is only used for two methods of StringUtils.
{code:xml}

org.apache.commons
commons-lang3
3.12.0
 
{code}
The dependency is only used in tests for deleting a directory. 
{code:xml}

  commons-io
  commons-io
  2.11.0

{code}




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-mvnd] gzm55 commented on pull request #722: Use muti-release jar to fallback mvnd-client to original maven

2022-10-20 Thread GitBox


gzm55 commented on PR #722:
URL: https://github.com/apache/maven-mvnd/pull/722#issuecomment-1285171179

   > I see. Would the opt-in explicit fallback to embedded Maven be a viable 
option for you?
   
   I'm OK to the switch, and it is reasonable for a package manager to always 
to call the native image. In this pr, we can focus on providing the fallback 
function, keeping the most entry behavior. I think the opt switch could be 
implemented in #717 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRESOLVER-280) Upgrade invoker, install, deploy, require maven 3.8.4+

2022-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620903#comment-17620903
 ] 

Hudson commented on MRESOLVER-280:
--

Build succeeded in Jenkins: Maven » Maven TLP » maven-resolver » master #64

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/64/

> Upgrade invoker, install, deploy, require maven 3.8.4+
> --
>
> Key: MRESOLVER-280
> URL: https://issues.apache.org/jira/browse/MRESOLVER-280
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.0
>
>
> Upgrade following plugins:
>  * m-invoker-p
>  * m-install-p
>  * m-deploy-p
> Require Maven 3.8.4+ for building.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-280) Upgrade invoker, install, deploy, require maven 3.8.4+

2022-10-20 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620902#comment-17620902
 ] 

ASF GitHub Bot commented on MRESOLVER-280:
--

cstamas merged PR #204:
URL: https://github.com/apache/maven-resolver/pull/204




> Upgrade invoker, install, deploy, require maven 3.8.4+
> --
>
> Key: MRESOLVER-280
> URL: https://issues.apache.org/jira/browse/MRESOLVER-280
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.0
>
>
> Upgrade following plugins:
>  * m-invoker-p
>  * m-install-p
>  * m-deploy-p
> Require Maven 3.8.4+ for building.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRESOLVER-280) Upgrade invoker, install, deploy, require maven 3.8.4+

2022-10-20 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MRESOLVER-280.
-
Resolution: Fixed

> Upgrade invoker, install, deploy, require maven 3.8.4+
> --
>
> Key: MRESOLVER-280
> URL: https://issues.apache.org/jira/browse/MRESOLVER-280
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.0
>
>
> Upgrade following plugins:
>  * m-invoker-p
>  * m-install-p
>  * m-deploy-p
> Require Maven 3.8.4+ for building.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-resolver] cstamas merged pull request #204: [MRESOLVER-280] Upgrade invoker, install, deploy, require Mvn 3.8.4+

2022-10-20 Thread GitBox


cstamas merged PR #204:
URL: https://github.com/apache/maven-resolver/pull/204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MNG-6437) Generic .uri suffix to get the URI representation of any file property

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-6437:
-
Fix Version/s: 4.0.0-alpha-3
   (was: 4.0.0-alpha-2)

> Generic .uri suffix to get the URI representation of any file property
> --
>
> Key: MNG-6437
> URL: https://issues.apache.org/jira/browse/MNG-6437
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.5.4
>Reporter: Claude Brisson
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> It's impossible to properly generate, for instance, a java policy file which 
> needs files URIs, using either Cargo properties and filtered config files, or 
> just filtered resources.
> In both cases, the problem is the impossibility to generate proper URIs when 
> expanding Maven properties (see also MNG-3760).
> The candidate feature is to add a way to explicitly request the URI when 
> expanding a property by means of a {{.uri}} suffix. The underlying 
> {{getUri()}} method should rely on the correct {{Path#toUri()}} and neither 
> {{File#toUri()}} nor {{File#toString()}}, see the SO reference in MNG-6386.
> For instance:
>  * {{${project.basedir.uri}}} instead of the broken {{${project.baseUri}}} 
> (and of course fix MNG-6436 otherwise it's useless)
>  * {{${project.build.directory.uri}}}
>  * {{${settings.localRepository.uri}}}
>  * etc
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7228) MavenProject.getOriginalSource returns interpolated parts

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7228:
-
Fix Version/s: 4.0.0-alpha-3
   (was: 4.0.0-alpha-2)

> MavenProject.getOriginalSource returns interpolated parts
> -
>
> Key: MNG-7228
> URL: https://issues.apache.org/jira/browse/MNG-7228
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> I have tested the maven-enforcer-plugin 3.0.0 running in a project where I 
> use the following configuration:
> {code:xml}
>
>   The rules for repo1.maven.org are that pom.xml 
> files should not include repository definitions. If
> repository definitions are included, they must be limited 
> to SNAPSHOT only repositories.
>   true
>   true
>   true
> 
> 
> {code}
> The project works correct with Maven 3.X but fails with Maven 4.X (current 
> state of master 92d2c2e3b43ca214989f0f517aa90f1525f0ff2e).
> After some investigation it looks like that the 
> {{mavenProject.getOriginalModel()}} returns already interpolated model and 
> **NOT** the original model.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MNG-7106) VersionRange.toString() produces a string that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MNG-7106.


> VersionRange.toString() produces a string that cannot be parsed with 
> VersionRange.createFromVersionSpec() for same lower and upper bounds
> -
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> When a hard version requirement (Ex - [1.0]) is passed to 
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
>  it is parsed to [1.0, 1.0]. But, this version range is invalid [according to 
> this 
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
>  If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot 
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); // 
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0, 
> 1.0]"
> VersionRange exceptionVersionRange = 
> VersionRange.createFromVersionSpec(stringVersionRange); // <- 
> InvalidVersionSpecificationException( "Range cannot have identical 
> boundaries: [1.0, 1.0]" )
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7260) Remove old deprecated code

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7260:
-
Fix Version/s: 4.x / Backlog
   (was: 4.0.0)
   (was: 4.0.0-alpha-2)

> Remove old deprecated code
> --
>
> Key: MNG-7260
> URL: https://issues.apache.org/jira/browse/MNG-7260
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.x / Backlog
>
>
> Things like {{maven-compat}} for example, but we should review everything 
> that has been deprecated since quite some time and possibly remove those.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7456) Provide FileTransformer replacement within Maven

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7456:
-
Fix Version/s: 4.0.0-alpha-3
   (was: 4.0.0-alpha-2)

> Provide FileTransformer replacement within Maven
> 
>
> Key: MNG-7456
> URL: https://issues.apache.org/jira/browse/MNG-7456
> Project: Maven
>  Issue Type: Task
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> As transforming "just in time" POM for consumer POM is not really Resolver 
> concern, that must get rid of current OOM-prone API. Maven should take care 
> of it by itself.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7422) Remove dependency to guava

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7422:
-
Fix Version/s: 4.0.0-alpha-3
   (was: 4.0.0-alpha-2)

> Remove dependency to guava
> --
>
> Key: MNG-7422
> URL: https://issues.apache.org/jira/browse/MNG-7422
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 4.0.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.0-alpha-3
>
>
> Currently we have dependency to google guava which is only needed for a 
> single test at the moment.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7543) Upgrade JUnit Jupiter Version 5.9.1

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7543:
-
Fix Version/s: 4.0.0-alpha-3
   (was: 4.0.0-alpha-2)

> Upgrade JUnit Jupiter Version 5.9.1
> ---
>
> Key: MNG-7543
> URL: https://issues.apache.org/jira/browse/MNG-7543
> Project: Maven
>  Issue Type: Dependency upgrade
>Affects Versions: 4.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.0-alpha-3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7556) Clean up notion between user properties and system properties

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7556:
-
Fix Version/s: 4.0.0-alpha-3
   (was: 4.0.0-alpha-2)

> Clean up notion between user properties and system properties
> -
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
>  Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0, 4.0.0-alpha-3
>
>
> For a very long time we have documented that the user can set system 
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties 
> which are promoted to system properties and it some cases system properties 
> cannot be modified *after* the JVM has been started. To properly set system 
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a 
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7079) Upgrade to jansi 2.2.0 and maven-shared-utils 3.3.4

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7079:
-
Fix Version/s: (was: 4.0.0-alpha-1)

> Upgrade to jansi 2.2.0 and maven-shared-utils 3.3.4
> ---
>
> Key: MNG-7079
> URL: https://issues.apache.org/jira/browse/MNG-7079
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: Guillaume Nodet
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0-alpha-2, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7347) SessionScoped beans should be singletons for a given session

2022-10-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7347:
-
Fix Version/s: (was: 4.0.0-alpha-1)

> SessionScoped beans should be singletons for a given session
> 
>
> Key: MNG-7347
> URL: https://issues.apache.org/jira/browse/MNG-7347
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.8.4
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-2, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


  1   2   3   4   5   6   7   8   >