[jira] [Updated] (MBUILDCACHE-32) Do not print exception when probing builds in remote repo
[
https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Ashitkin updated MBUILDCACHE-32:
--
Description:
When cache engine tries to discover existing cache by checksum, it sends get
request.
This request is normally getting 404s, because cache is not guaranteed to exist.
It's a normal situation and exception should not be printed in such case as it
meaninglessly pollutes logs:
{code:java}
org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
https://my-cache/.../buildinfo.xml, status: 404 Not Found
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1191)
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1140)
at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
(StreamWagon.java:226)
at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
(WagonTransporter.java:533)
at org.eclipse.aether.transport.wagon.WagonTransporter.execute
(WagonTransporter.java:425)
at org.eclipse.aether.transport.wagon.WagonTransporter.get
(WagonTransporter.java:400)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
(RemoteCacheRepositoryImpl.java:165)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
(RemoteCacheRepositoryImpl.java:114)
at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
(LocalCacheRepositoryImpl.java:183)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:212)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:179)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:179)
{code}
{{Need to create method similar to
RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet
and use it when probing buildinfo.xml. the method should not log exceptions}}
was:
When cache engine tries to discover existing cache by checksum, it sends get
request.
This request is not expected to always return 200, because cache is not
guaranteed to exist.
It's a normal situation and exception should not be printed in such case:
{code:java}
org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
https://my-cache/.../buildinfo.xml, status: 404 Not Found
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1191)
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1140)
at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
(StreamWagon.java:226)
at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
(WagonTransporter.java:533)
at org.eclipse.aether.transport.wagon.WagonTransporter.execute
(WagonTransporter.java:425)
at org.eclipse.aether.transport.wagon.WagonTransporter.get
(WagonTransporter.java:400)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
(RemoteCacheRepositoryImpl.java:165)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
(RemoteCacheRepositoryImpl.java:114)
at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
(LocalCacheRepositoryImpl.java:183)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:212)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:179)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:179)
{code}
{{Need to create method similar to
RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet
and use it when probing buildinfo.xml. the method should not log exceptions}}
> Do not print exception when probing builds in remote repo
> -
>
> Key: MBUILDCACHE-32
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Major
> Labels: pull-request-available
> Original Estimate: 24h
> Remaining Estimate: 24h
[jira] [Updated] (MBUILDCACHE-32) Do not print exception when probing builds in remote repo
[
https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Ashitkin updated MBUILDCACHE-32:
--
Summary: Do not print exception when probing builds in remote repo (was:
Do not print exception when probing buildInfo.xml in remote repo)
> Do not print exception when probing builds in remote repo
> -
>
> Key: MBUILDCACHE-32
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Major
> Labels: pull-request-available
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When cache engine tries to discover existing cache by checksum, it sends get
> request.
> This request is not expected to always return 200, because cache is not
> guaranteed to exist.
> It's a normal situation and exception should not be printed in such case:
> {code:java}
> org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
> https://my-cache/.../buildinfo.xml, status: 404 Not Found
> at
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
> (AbstractHttpClientWagon.java:1191)
> at
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
> (AbstractHttpClientWagon.java:1140)
> at org.apache.maven.wagon.StreamWagon.getInputStream
> (StreamWagon.java:126)
> at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
> (StreamWagon.java:226)
> at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
> at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
> (WagonTransporter.java:533)
> at org.eclipse.aether.transport.wagon.WagonTransporter.execute
> (WagonTransporter.java:425)
> at org.eclipse.aether.transport.wagon.WagonTransporter.get
> (WagonTransporter.java:400)
> at
> org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
> (RemoteCacheRepositoryImpl.java:165)
> at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
> (RemoteCacheRepositoryImpl.java:114)
> at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
> (LocalCacheRepositoryImpl.java:183)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:212)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:179)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:114)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:179)
> {code}
> {{Need to create method similar to
> RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet
> and use it when probing buildinfo.xml. the method should not log exceptions}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-32) Do not print exception when probing buildInfo.xml in remote repo
[
https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626160#comment-17626160
]
ASF GitHub Bot commented on MBUILDCACHE-32:
---
AlexanderAshitkin opened a new pull request, #33:
URL: https://github.com/apache/maven-build-cache-extension/pull/33
… remote repo
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Do not print exception when probing buildInfo.xml in remote repo
>
>
> Key: MBUILDCACHE-32
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When cache engine tries to discover existing cache by checksum, it sends get
> request.
> This request is not expected to always return 200, because cache is not
> guaranteed to exist.
> It's a normal situation and exception should not be printed in such case:
> {code:java}
> org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
> https://my-cache/.../buildinfo.xml, status: 404 Not Found
> at
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
> (AbstractHttpClientWagon.java:1191)
> at
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
> (AbstractHttpClientWagon.java:1140)
> at org.apache.maven.wagon.StreamWagon.getInputStream
> (StreamWagon.java:126)
> at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
> (StreamWagon.java:226)
> at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
> at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
> (WagonTransporter.java:533)
> at org.eclipse.aether.transport.wagon.WagonTransporter.execute
> (WagonTransporter.java:425)
> at org.eclipse.aether.transport.wagon.WagonTransporter.get
> (WagonTransporter.java:400)
> at
> org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
> (RemoteCacheRepositoryImpl.java:165)
> at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
> (RemoteCacheRepositoryImpl.java:114)
> at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
> (LocalCacheRepositoryImpl.java:183)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:212)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:179)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:114)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:179)
> {code}
> {{Need to create method similar to
> RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet
> and use it when probing
[jira] [Updated] (MBUILDCACHE-32) Do not print exception when probing buildInfo.xml in remote repo
[
https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated MBUILDCACHE-32:
--
Labels: pull-request-available (was: )
> Do not print exception when probing buildInfo.xml in remote repo
>
>
> Key: MBUILDCACHE-32
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Major
> Labels: pull-request-available
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When cache engine tries to discover existing cache by checksum, it sends get
> request.
> This request is not expected to always return 200, because cache is not
> guaranteed to exist.
> It's a normal situation and exception should not be printed in such case:
> {code:java}
> org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
> https://my-cache/.../buildinfo.xml, status: 404 Not Found
> at
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
> (AbstractHttpClientWagon.java:1191)
> at
> org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
> (AbstractHttpClientWagon.java:1140)
> at org.apache.maven.wagon.StreamWagon.getInputStream
> (StreamWagon.java:126)
> at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
> (StreamWagon.java:226)
> at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
> at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
> (WagonTransporter.java:533)
> at org.eclipse.aether.transport.wagon.WagonTransporter.execute
> (WagonTransporter.java:425)
> at org.eclipse.aether.transport.wagon.WagonTransporter.get
> (WagonTransporter.java:400)
> at
> org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
> (RemoteCacheRepositoryImpl.java:165)
> at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
> (RemoteCacheRepositoryImpl.java:114)
> at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
> (LocalCacheRepositoryImpl.java:183)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:212)
> at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
> (CacheControllerImpl.java:179)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:114)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:179)
> {code}
> {{Need to create method similar to
> RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet
> and use it when probing buildinfo.xml. the method should not log exceptions}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-build-cache-extension] AlexanderAshitkin opened a new pull request, #33: [MBUILDCACHE-32] Do not print exception when probing builds
AlexanderAshitkin opened a new pull request, #33: URL: https://github.com/apache/maven-build-cache-extension/pull/33 … remote repo Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MBUILDCACHE-32) Do not print exception when probing buildInfo.xml in remote repo
[
https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Ashitkin updated MBUILDCACHE-32:
--
Description:
When cache engine tries to discover existing cache by checksum, it sends get
request.
This request is not expected to always return 200, because cache is not
guaranteed to exist.
It's a normal situation and exception should not be printed in such case:
{code:java}
org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
https://my-cache/.../buildinfo.xml, status: 404 Not Found
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1191)
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1140)
at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
(StreamWagon.java:226)
at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
(WagonTransporter.java:533)
at org.eclipse.aether.transport.wagon.WagonTransporter.execute
(WagonTransporter.java:425)
at org.eclipse.aether.transport.wagon.WagonTransporter.get
(WagonTransporter.java:400)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
(RemoteCacheRepositoryImpl.java:165)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
(RemoteCacheRepositoryImpl.java:114)
at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
(LocalCacheRepositoryImpl.java:183)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:212)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:179)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:179)
{code}
{{Need to create method similar to
RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet
and use it when probing buildinfo.xml. the method should not log exceptions}}
was:
When cache engine tries to discover existing cache by checksum, it sends get
request.
This request is not expected to always return 200, because cache is not
guaranteed to exist.
It's a normal situation and exception should not be printed in such case:
{code:java}
org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
https://my-cache/.../buildinfo.xml, status: 404 Not Found
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1191)
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1140)
at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
(StreamWagon.java:226)
at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
(WagonTransporter.java:533)
at org.eclipse.aether.transport.wagon.WagonTransporter.execute
(WagonTransporter.java:425)
at org.eclipse.aether.transport.wagon.WagonTransporter.get
(WagonTransporter.java:400)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
(RemoteCacheRepositoryImpl.java:165)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
(RemoteCacheRepositoryImpl.java:114)
at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
(LocalCacheRepositoryImpl.java:183)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:212)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:179)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:179)
{code}
{{Need to create method similar to
RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet
and use it when probing buildings. the method should not log exceptions}}
> Do not print exception when probing buildInfo.xml in remote repo
>
>
> Key: MBUILDCACHE-32
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When cache engine tries to discover existing cache by
[jira] [Updated] (MBUILDCACHE-32) Do not print exception when probing buildInfo.xml in remote repo
[
https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Ashitkin updated MBUILDCACHE-32:
--
Description:
When cache engine tries to discover existing cache by checksum, it sends get
request.
This request is not expected to always return 200, because cache is not
guaranteed to exist.
It's a normal situation and exception should not be printed in such case:
{code:java}
org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
https://my-cache/.../buildinfo.xml, status: 404 Not Found
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1191)
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1140)
at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
(StreamWagon.java:226)
at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
(WagonTransporter.java:533)
at org.eclipse.aether.transport.wagon.WagonTransporter.execute
(WagonTransporter.java:425)
at org.eclipse.aether.transport.wagon.WagonTransporter.get
(WagonTransporter.java:400)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
(RemoteCacheRepositoryImpl.java:165)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
(RemoteCacheRepositoryImpl.java:114)
at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
(LocalCacheRepositoryImpl.java:183)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:212)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:179)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:179)
{code}
{{Need to create method similar to
RemoteCacheRepositoryImpl#getResourceContent, but }}{{{}getResourceContentQuiet
and use it when probing buildings. the method should not log
exceptions{}}}{{{}{}}}
was:
When cache engine tries to discover existing cache by checksum, it sends get
request.
This request is not expected to always return 200, because cache is not
guaranteed to exist.
It's a normal situation and exception should not be printed in such case:
{code:java}
org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
https://my-cache/.../buildinfo.xml, status: 404 Not Found
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1191)
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1140)
at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
(StreamWagon.java:226)
at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
(WagonTransporter.java:533)
at org.eclipse.aether.transport.wagon.WagonTransporter.execute
(WagonTransporter.java:425)
at org.eclipse.aether.transport.wagon.WagonTransporter.get
(WagonTransporter.java:400)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
(RemoteCacheRepositoryImpl.java:165)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
(RemoteCacheRepositoryImpl.java:114)
at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
(LocalCacheRepositoryImpl.java:183)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:212)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:179)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:179)
{code}
Need to add flag print / not print error in http repo
> Do not print exception when probing buildInfo.xml in remote repo
>
>
> Key: MBUILDCACHE-32
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When cache engine tries to discover existing cache by checksum, it sends get
> request.
> This request is not expected to always return 200, because cache is not
> guaranteed to
[jira] [Updated] (MBUILDCACHE-32) Do not print exception when probing buildInfo.xml in remote repo
[
https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Ashitkin updated MBUILDCACHE-32:
--
Description:
When cache engine tries to discover existing cache by checksum, it sends get
request.
This request is not expected to always return 200, because cache is not
guaranteed to exist.
It's a normal situation and exception should not be printed in such case:
{code:java}
org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
https://my-cache/.../buildinfo.xml, status: 404 Not Found
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1191)
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1140)
at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
(StreamWagon.java:226)
at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
(WagonTransporter.java:533)
at org.eclipse.aether.transport.wagon.WagonTransporter.execute
(WagonTransporter.java:425)
at org.eclipse.aether.transport.wagon.WagonTransporter.get
(WagonTransporter.java:400)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
(RemoteCacheRepositoryImpl.java:165)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
(RemoteCacheRepositoryImpl.java:114)
at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
(LocalCacheRepositoryImpl.java:183)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:212)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:179)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:179)
{code}
{{Need to create method similar to
RemoteCacheRepositoryImpl#getResourceContent, but }}{{getResourceContentQuiet
and use it when probing buildings. the method should not log exceptions}}
was:
When cache engine tries to discover existing cache by checksum, it sends get
request.
This request is not expected to always return 200, because cache is not
guaranteed to exist.
It's a normal situation and exception should not be printed in such case:
{code:java}
org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
https://my-cache/.../buildinfo.xml, status: 404 Not Found
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1191)
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1140)
at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
(StreamWagon.java:226)
at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
(WagonTransporter.java:533)
at org.eclipse.aether.transport.wagon.WagonTransporter.execute
(WagonTransporter.java:425)
at org.eclipse.aether.transport.wagon.WagonTransporter.get
(WagonTransporter.java:400)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
(RemoteCacheRepositoryImpl.java:165)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
(RemoteCacheRepositoryImpl.java:114)
at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
(LocalCacheRepositoryImpl.java:183)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:212)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:179)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:179)
{code}
{{Need to create method similar to
RemoteCacheRepositoryImpl#getResourceContent, but }}{{{}getResourceContentQuiet
and use it when probing buildings. the method should not log
exceptions{}}}{{{}{}}}
> Do not print exception when probing buildInfo.xml in remote repo
>
>
> Key: MBUILDCACHE-32
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Major
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When cache engine tries to discover existing
[jira] [Created] (MBUILDCACHE-32) Do not print exception when probing buildInfo.xml in remote repo
Alexander Ashitkin created MBUILDCACHE-32:
-
Summary: Do not print exception when probing buildInfo.xml in
remote repo
Key: MBUILDCACHE-32
URL: https://issues.apache.org/jira/browse/MBUILDCACHE-32
Project: Maven Build Cache Extension
Issue Type: Bug
Reporter: Alexander Ashitkin
When cache engine tries to discover existing cache by checksum, it sends get
request.
This request is not expected to always return 200, because cache is not
guaranteed to exist.
It's a normal situation and exception should not be printed in such case:
{code:java}
org.apache.maven.wagon.ResourceDoesNotExistException: resource missing at
https://my-cache/.../buildinfo.xml, status: 404 Not Found
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1191)
at org.apache.maven.wagon.shared.http.AbstractHttpClientWagon.fillInputData
(AbstractHttpClientWagon.java:1140)
at org.apache.maven.wagon.StreamWagon.getInputStream (StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewerToStream
(StreamWagon.java:226)
at org.apache.maven.wagon.StreamWagon.getToStream (StreamWagon.java:262)
at org.eclipse.aether.transport.wagon.WagonTransporter$GetTaskRunner.run
(WagonTransporter.java:533)
at org.eclipse.aether.transport.wagon.WagonTransporter.execute
(WagonTransporter.java:425)
at org.eclipse.aether.transport.wagon.WagonTransporter.get
(WagonTransporter.java:400)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.getResourceContent
(RemoteCacheRepositoryImpl.java:165)
at org.apache.maven.buildcache.RemoteCacheRepositoryImpl.findBuild
(RemoteCacheRepositoryImpl.java:114)
at org.apache.maven.buildcache.LocalCacheRepositoryImpl.findBuild
(LocalCacheRepositoryImpl.java:183)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:212)
at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild
(CacheControllerImpl.java:179)
at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
(BuildCacheMojosExecutionStrategy.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:179)
{code}
Need to add flag print / not print error in http repo
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-indexer] cstamas closed pull request #230: Bump maven-parent from 36 to 37
cstamas closed pull request #230: Bump maven-parent from 36 to 37 URL: https://github.com/apache/maven-indexer/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] cstamas closed pull request #247: Bump checkstyle from 10.3.3 to 10.3.4
cstamas closed pull request #247: Bump checkstyle from 10.3.3 to 10.3.4 URL: https://github.com/apache/maven-indexer/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #247: Bump checkstyle from 10.3.3 to 10.3.4
dependabot[bot] commented on PR #247: URL: https://github.com/apache/maven-indexer/pull/247#issuecomment-1295949044 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #234: Bump resolver.version from 1.8.1 to 1.8.2
dependabot[bot] commented on PR #234: URL: https://github.com/apache/maven-indexer/pull/234#issuecomment-1295948985 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] cstamas closed pull request #234: Bump resolver.version from 1.8.1 to 1.8.2
cstamas closed pull request #234: Bump resolver.version from 1.8.1 to 1.8.2 URL: https://github.com/apache/maven-indexer/pull/234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #230: Bump maven-parent from 36 to 37
dependabot[bot] commented on PR #230: URL: https://github.com/apache/maven-indexer/pull/230#issuecomment-1295948909 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #244: Bump version.spring from 5.3.22 to 5.3.23
dependabot[bot] commented on PR #244: URL: https://github.com/apache/maven-indexer/pull/244#issuecomment-1295948842 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] cstamas closed pull request #244: Bump version.spring from 5.3.22 to 5.3.23
cstamas closed pull request #244: Bump version.spring from 5.3.22 to 5.3.23 URL: https://github.com/apache/maven-indexer/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #256: Bump plexus-utils from 3.4.2 to 3.5.0
dependabot[bot] commented on PR #256: URL: https://github.com/apache/maven-indexer/pull/256#issuecomment-1295948685 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] cstamas closed pull request #256: Bump plexus-utils from 3.4.2 to 3.5.0
cstamas closed pull request #256: Bump plexus-utils from 3.4.2 to 3.5.0 URL: https://github.com/apache/maven-indexer/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #257: Bump lucene.version from 9.4.0 to 9.4.1
dependabot[bot] commented on PR #257: URL: https://github.com/apache/maven-indexer/pull/257#issuecomment-1295948625 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] cstamas closed pull request #257: Bump lucene.version from 9.4.0 to 9.4.1
cstamas closed pull request #257: Bump lucene.version from 9.4.0 to 9.4.1 URL: https://github.com/apache/maven-indexer/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #258: Bump gson from 2.9.1 to 2.10
dependabot[bot] commented on PR #258: URL: https://github.com/apache/maven-indexer/pull/258#issuecomment-1295948533 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] cstamas closed pull request #258: Bump gson from 2.9.1 to 2.10
cstamas closed pull request #258: Bump gson from 2.9.1 to 2.10 URL: https://github.com/apache/maven-indexer/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] dependabot[bot] commented on pull request #259: Bump maven-shade-plugin from 3.4.0 to 3.4.1
dependabot[bot] commented on PR #259: URL: https://github.com/apache/maven-indexer/pull/259#issuecomment-1295948411 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] cstamas closed pull request #259: Bump maven-shade-plugin from 3.4.0 to 3.4.1
cstamas closed pull request #259: Bump maven-shade-plugin from 3.4.0 to 3.4.1 URL: https://github.com/apache/maven-indexer/pull/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINDEXER-172) Update Lucene, gson, plexus-utils
[ https://issues.apache.org/jira/browse/MINDEXER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626126#comment-17626126 ] Hudson commented on MINDEXER-172: - Build succeeded in Jenkins: Maven » Maven TLP » maven-indexer » master #71 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-indexer/job/master/71/ > Update Lucene, gson, plexus-utils > - > > Key: MINDEXER-172 > URL: https://issues.apache.org/jira/browse/MINDEXER-172 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.0.0 > > > Update dependencies: > * plexus-utils to 3.5.0 > * Lucene to 9.4.1 > * gson to 2.10 > Update plugins: > * m-shade-p to 3.4.1 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINDEXER-172) Update Lucene, gson, plexus-utils
[ https://issues.apache.org/jira/browse/MINDEXER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-172: Assignee: Tamas Cservenak > Update Lucene, gson, plexus-utils > - > > Key: MINDEXER-172 > URL: https://issues.apache.org/jira/browse/MINDEXER-172 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.0.0 > > > Update dependencies: > * plexus-utils to 3.5.0 > * Lucene to 9.4.1 > * gson to 2.10 > Update plugins: > * m-shade-p to 3.4.1 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINDEXER-172) Update Lucene, gson, plexus-utils
[ https://issues.apache.org/jira/browse/MINDEXER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626124#comment-17626124 ] Tamas Cservenak commented on MINDEXER-172: -- Fixed with https://github.com/apache/maven-indexer/commit/b5d8d9f4d0d37def9f5cc7708f4ca6d8ae1bc15c > Update Lucene, gson, plexus-utils > - > > Key: MINDEXER-172 > URL: https://issues.apache.org/jira/browse/MINDEXER-172 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Priority: Major > Fix For: 7.0.0 > > > Update dependencies: > * plexus-utils to 3.5.0 > * Lucene to 9.4.1 > * gson to 2.10 > Update plugins: > * m-shade-p to 3.4.1 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-172) Update Lucene, gson, plexus-utils
[ https://issues.apache.org/jira/browse/MINDEXER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-172. Resolution: Fixed > Update Lucene, gson, plexus-utils > - > > Key: MINDEXER-172 > URL: https://issues.apache.org/jira/browse/MINDEXER-172 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Priority: Major > Fix For: 7.0.0 > > > Update dependencies: > * plexus-utils to 3.5.0 > * Lucene to 9.4.1 > * gson to 2.10 > Update plugins: > * m-shade-p to 3.4.1 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINDEXER-172) Update Lucene, gson, plexus-utils
[ https://issues.apache.org/jira/browse/MINDEXER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MINDEXER-172: - Description: Update dependencies: * plexus-utils to 3.5.0 * Lucene to 9.4.1 * gson to 2.10 Update plugins: * m-shade-p to 3.4.1 > Update Lucene, gson, plexus-utils > - > > Key: MINDEXER-172 > URL: https://issues.apache.org/jira/browse/MINDEXER-172 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Priority: Major > Fix For: 7.0.0 > > > Update dependencies: > * plexus-utils to 3.5.0 > * Lucene to 9.4.1 > * gson to 2.10 > Update plugins: > * m-shade-p to 3.4.1 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1101) Completely revise argument(s) handling
[
https://issues.apache.org/jira/browse/MRELEASE-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626121#comment-17626121
]
Michael Osipov commented on MRELEASE-1101:
--
[~gnodet], I think this is the last *major* block for GA. We must stop parsing
args, but go as array.
> Completely revise argument(s) handling
> --
>
> Key: MRELEASE-1101
> URL: https://issues.apache.org/jira/browse/MRELEASE-1101
> Project: Maven Release Plugin
> Issue Type: Task
>Affects Versions: 3.0.0-M6
>Reporter: Michael Osipov
>Priority: Major
>
> Currently, we have multiple parameters which accept goals, args, options,
> etc. They suffer from several problems:
> * They accept everything and don't reject. E.g., goals should accepts goals
> only which is not the case.
> * It accepts one arg line and internally parses it.
> Both is wrong:
> * We need exactly *one* config element {{}} which take
> everything what forked Maven shall receive
> * We do double, brittle parsing. It must be one arg at a time, therefore a
> single string must be rather a array/list of args.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MINDEXER-172) Update Lucene, gson, plexus-utils
Tamas Cservenak created MINDEXER-172: Summary: Update Lucene, gson, plexus-utils Key: MINDEXER-172 URL: https://issues.apache.org/jira/browse/MINDEXER-172 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7556) Clean up notion between user properties and system properties
[
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626119#comment-17626119
]
Hudson commented on MNG-7556:
-
Build failed in Jenkins: Maven » Maven TLP » maven » master #122
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/122/
> Clean up notion between user properties and system properties
> -
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> For a very long time we have documented that the user can set system
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties
> which are promoted to system properties and it some cases system properties
> cannot be modified *after* the JVM has been started. To properly set system
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7556) Clean up notion between user properties and system properties
[
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626118#comment-17626118
]
Hudson commented on MNG-7556:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-810 #9
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-810/9/
> Clean up notion between user properties and system properties
> -
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> For a very long time we have documented that the user can set system
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties
> which are promoted to system properties and it some cases system properties
> cannot be modified *after* the JVM has been started. To properly set system
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-release] dependabot[bot] commented on pull request #153: Bump slf4jVersion from 1.7.36 to 2.0.3
dependabot[bot] commented on PR #153: URL: https://github.com/apache/maven-release/pull/153#issuecomment-1295943330 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] slachiewicz closed pull request #153: Bump slf4jVersion from 1.7.36 to 2.0.3
slachiewicz closed pull request #153: Bump slf4jVersion from 1.7.36 to 2.0.3 URL: https://github.com/apache/maven-release/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7378) neither the Core IT link in PR template nor contributor's guide tells new contributors how to run Core IT
[ https://issues.apache.org/jira/browse/MNG-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626116#comment-17626116 ] Hudson commented on MNG-7378: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #77 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/77/ > neither the Core IT link in PR template nor contributor's guide tells new > contributors how to run Core IT > - > > Key: MNG-7378 > URL: https://issues.apache.org/jira/browse/MNG-7378 > Project: Maven > Issue Type: Bug >Reporter: Jeff Hodges >Assignee: Maarten Mulders >Priority: Major > > There's a checkbox in the new pull request template for the maven repo that > says the contributor should run the Core ITs. > However, the page it links to doesn't say where to find them and the obvious > thing to do (running `mvn clean test -Prun-its` in the maven repo proper) > doesn't work because there's no `run-its` profile. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7566) Allow a Maven plugin to require a Java version through its plugin descriptor
[ https://issues.apache.org/jira/browse/MNG-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626114#comment-17626114 ] Hudson commented on MNG-7566: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #77 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/77/ > Allow a Maven plugin to require a Java version through its plugin descriptor > > > Key: MNG-7566 > URL: https://issues.apache.org/jira/browse/MNG-7566 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Labels: plugin-descriptor-1.1 > Fix For: 4.0.0 > > > Currently a Maven plugin can only require a minimum Maven version via pom's > prerequisites (https://maven.apache.org/pom.html#Prerequisites). There is > currently no means to require a minimum Java version. > I would suggest to slightly expand the plugin descriptor to include a > minimumJavaVersion element there as well and evaluate that before executing a > plugin goal and emit a good error message. The default Java version could be > determined by the target class file version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626115#comment-17626115 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #77 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/77/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0-candidate, 4.0.0 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7556) Clean up notion between user properties and system properties
[
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626113#comment-17626113
]
Hudson commented on MNG-7556:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #77
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/77/
> Clean up notion between user properties and system properties
> -
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> For a very long time we have documented that the user can set system
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties
> which are promoted to system properties and it some cases system properties
> cannot be modified *after* the JVM has been started. To properly set system
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on a diff in pull request #831: [3.9.x] Maven changes for upcoming resolver 1.9
michael-o commented on code in PR #831:
URL: https://github.com/apache/maven/pull/831#discussion_r1008746028
##
maven-core/src/main/java/org/apache/maven/internal/aether/ResolverLifecycle.java:
##
@@ -0,0 +1,54 @@
+package org.apache.maven.internal.aether;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.annotation.PreDestroy;
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Provider;
+
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.sisu.EagerSingleton;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Maven internal component that bridges container "shut down" to {@link
RepositorySystem#shutdown()}.
+ *
+ * @since 3.9.0
+ */
+@Named
+@EagerSingleton
+public final class ResolverLifecycle
+{
+private final Provider repositorySystemProvider;
+
+@Inject
+public ResolverLifecycle( Provider
repositorySystemProvider )
+{
+this.repositorySystemProvider = requireNonNull(
repositorySystemProvider );
+}
+
+@PreDestroy
Review Comment:
Ah, ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #831: [3.9.x] Maven changes for upcoming resolver 1.9
cstamas commented on code in PR #831:
URL: https://github.com/apache/maven/pull/831#discussion_r1008745807
##
maven-core/src/main/java/org/apache/maven/internal/aether/ResolverLifecycle.java:
##
@@ -0,0 +1,54 @@
+package org.apache.maven.internal.aether;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.annotation.PreDestroy;
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Provider;
+
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.sisu.EagerSingleton;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Maven internal component that bridges container "shut down" to {@link
RepositorySystem#shutdown()}.
+ *
+ * @since 3.9.0
+ */
+@Named
+@EagerSingleton
+public final class ResolverLifecycle
+{
+private final Provider repositorySystemProvider;
+
+@Inject
+public ResolverLifecycle( Provider
repositorySystemProvider )
+{
+this.repositorySystemProvider = requireNonNull(
repositorySystemProvider );
+}
+
+@PreDestroy
Review Comment:
Yes, we never removed it from Maven, but we did from Resolver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #831: [3.9.x] Maven changes for upcoming resolver 1.9
michael-o commented on code in PR #831:
URL: https://github.com/apache/maven/pull/831#discussion_r1008743550
##
maven-core/src/main/java/org/apache/maven/internal/aether/ResolverLifecycle.java:
##
@@ -0,0 +1,54 @@
+package org.apache.maven.internal.aether;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.annotation.PreDestroy;
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Provider;
+
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.sisu.EagerSingleton;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Maven internal component that bridges container "shut down" to {@link
RepositorySystem#shutdown()}.
+ *
+ * @since 3.9.0
+ */
+@Named
+@EagerSingleton
+public final class ResolverLifecycle
+{
+private final Provider repositorySystemProvider;
+
+@Inject
+public ResolverLifecycle( Provider
repositorySystemProvider )
+{
+this.repositorySystemProvider = requireNonNull(
repositorySystemProvider );
+}
+
+@PreDestroy
Review Comment:
Now this is back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MNG-7556) Clean up notion between user properties and system properties
[
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-7556.
---
Fix Version/s: 3.9.0
(was: 3.9.0-candidate)
Resolution: Fixed
Fixed with
[9c6013891504d5eb1d8bad18772a7fe114131d61|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=9c6013891504d5eb1d8bad18772a7fe114131d61]
and with
[0f4387543debd77ab649f97014b72feb4046b3c6|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=0f4387543debd77ab649f97014b72feb4046b3c6]
for {{maven-3.9.x}} branch.
> Clean up notion between user properties and system properties
> -
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> For a very long time we have documented that the user can set system
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties
> which are promoted to system properties and it some cases system properties
> cannot be modified *after* the JVM has been started. To properly set system
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7556) Clean up notion between user properties and system properties
[
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626107#comment-17626107
]
ASF GitHub Bot commented on MNG-7556:
-
asfgit closed pull request #810: [MNG-7556] Clean up notion between user
properties and system properties
URL: https://github.com/apache/maven/pull/810
> Clean up notion between user properties and system properties
> -
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0, 4.0.0-alpha-3
>
>
> For a very long time we have documented that the user can set system
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties
> which are promoted to system properties and it some cases system properties
> cannot be modified *after* the JVM has been started. To properly set system
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] asfgit closed pull request #810: [MNG-7556] Clean up notion between user properties and system properties
asfgit closed pull request #810: [MNG-7556] Clean up notion between user properties and system properties URL: https://github.com/apache/maven/pull/810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7564) Potential NPE in MavenMetadataSource
[
https://issues.apache.org/jira/browse/MNG-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626106#comment-17626106
]
Michael Osipov commented on MNG-7564:
-
Where is the fix version? This likely also applies to 3.9.0.
> Potential NPE in MavenMetadataSource
>
>
> Key: MNG-7564
> URL: https://issues.apache.org/jira/browse/MNG-7564
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Maarten Mulders
>Priority: Major
> Labels: up-for-grabs
>
> In here:
> https://github.com/apache/maven/blob/cb54aa429d9e63bf78c4c808898fbef1cc01ff33/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java#L198-L203
> {{LegacySupport#getSession()}} can be {{null}}, but never tested. If {{null}}
> an empty list should be returned.
> This was indirectly found by [~gnodet].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7556) Clean up notion between user properties and system properties
[
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626104#comment-17626104
]
Hudson commented on MNG-7556:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-810 #8
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-810/8/
> Clean up notion between user properties and system properties
> -
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0, 4.0.0-alpha-3
>
>
> For a very long time we have documented that the user can set system
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties
> which are promoted to system properties and it some cases system properties
> cannot be modified *after* the JVM has been started. To properly set system
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7564) Potential NPE in MavenMetadataSource
[
https://issues.apache.org/jira/browse/MNG-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626103#comment-17626103
]
Hudson commented on MNG-7564:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-810 #8
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-810/8/
> Potential NPE in MavenMetadataSource
>
>
> Key: MNG-7564
> URL: https://issues.apache.org/jira/browse/MNG-7564
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Maarten Mulders
>Priority: Major
> Labels: up-for-grabs
>
> In here:
> https://github.com/apache/maven/blob/cb54aa429d9e63bf78c4c808898fbef1cc01ff33/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java#L198-L203
> {{LegacySupport#getSession()}} can be {{null}}, but never tested. If {{null}}
> an empty list should be returned.
> This was indirectly found by [~gnodet].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRELEASE-1105) when running with mvnDebug the spawned process in in debug mode as well
[ https://issues.apache.org/jira/browse/MRELEASE-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1105: - Fix Version/s: (was: 3.0.0-M7) > when running with mvnDebug the spawned process in in debug mode as well > > > Key: MRELEASE-1105 > URL: https://issues.apache.org/jira/browse/MRELEASE-1105 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M6 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > > because env vars are propagated... > `MAVEN_DEBUG_OPTS` should be forced to "" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1108) Upgrade Maven SCM to 2.0.0-M3
[ https://issues.apache.org/jira/browse/MRELEASE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626087#comment-17626087 ] Hudson commented on MRELEASE-1108: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #65 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/65/ > Upgrade Maven SCM to 2.0.0-M3 > - > > Key: MRELEASE-1108 > URL: https://issues.apache.org/jira/browse/MRELEASE-1108 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M7 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1072) Reuse original tag for next development version in case translator does not support resolution
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626088#comment-17626088
]
Hudson commented on MRELEASE-1072:
--
Build succeeded in Jenkins: Maven » Maven TLP » maven-release » master #65
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-release/job/master/65/
> Reuse original tag for next development version in case translator does not
> support resolution
> --
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Improvement
> Components: prepare
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-release] michael-o closed pull request #145: Simplify PerformReleaseMojo
michael-o closed pull request #145: Simplify PerformReleaseMojo URL: https://github.com/apache/maven-release/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #145: Simplify PerformReleaseMojo
michael-o commented on PR #145: URL: https://github.com/apache/maven-release/pull/145#issuecomment-1295903571 > I agree with @nielsbasjes that a lot more parameters are now exposed for goal `perform` which are not useful. Maybe the AbstractScmReleaseMojo would need a split up between `AbstractScmReadReleaseMojo` and `AbstractScmWriteReleaseMojo` (inheriting from the former). This totally makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRELEASE-1108) Upgrade Maven SCM to 2.0.0-M3
[ https://issues.apache.org/jira/browse/MRELEASE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1108. Resolution: Fixed Fixed with [951aba3843d0334fc8d6d06cda6c5540b8861b94|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=951aba3843d0334fc8d6d06cda6c5540b8861b94]. > Upgrade Maven SCM to 2.0.0-M3 > - > > Key: MRELEASE-1108 > URL: https://issues.apache.org/jira/browse/MRELEASE-1108 > Project: Maven Release Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.0.0-M7 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRELEASE-1072) Reuse original tag for next development version in case translator does not support resolution
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MRELEASE-1072.
Resolution: Fixed
Fixed with
[0615a4c3b2138116a255fc2b57fcf83d76d49e68|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=0615a4c3b2138116a255fc2b57fcf83d76d49e68].
> Reuse original tag for next development version in case translator does not
> support resolution
> --
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Improvement
> Components: prepare
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-release] asfgit merged pull request #157: [MRELEASE-1108] Upgrade Maven SCM to 2.0.0-M3
asfgit merged PR #157: URL: https://github.com/apache/maven-release/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] asfgit merged pull request #86: MRELEASE-1072 reuse original tag for next development version in case
asfgit merged PR #86: URL: https://github.com/apache/maven-release/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRELEASE-1072) Reuse original tag for next development version in case translator does not support resolution
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-1072:
-
Issue Type: Improvement (was: New Feature)
> Reuse original tag for next development version in case translator does not
> support resolution
> --
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: Improvement
> Components: prepare
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRELEASE-1072) Reuse original tag for next development version in case translator does not support resolution
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-1072:
-
Summary: Reuse original tag for next development version in case translator
does not support resolution (was: Reuse original tag for next development
version in case translator does not support resolving)
> Reuse original tag for next development version in case translator does not
> support resolution
> --
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: New Feature
> Components: prepare
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRELEASE-1072) Reuse original tag for next development version in case translator does not support resolving
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-1072:
-
Summary: Reuse original tag for next development version in case translator
does not support resolving (was: scm.tag removed for next snapshot during
prepare when using svn)
> Reuse original tag for next development version in case translator does not
> support resolving
> -
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: New Feature
> Components: prepare
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-1072:
-
Fix Version/s: 3.0.0-M7
(was: waiting-for-feedback)
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: New Feature
> Components: prepare
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.0.0-M7
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MRELEASE-1072:
Assignee: Michael Osipov
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: New Feature
> Components: prepare
>Reporter: Konrad Windszus
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRELEASE-1072) scm.tag removed for next snapshot during prepare when using svn
[
https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-1072:
-
Issue Type: New Feature (was: Bug)
> scm.tag removed for next snapshot during prepare when using svn
> ---
>
> Key: MRELEASE-1072
> URL: https://issues.apache.org/jira/browse/MRELEASE-1072
> Project: Maven Release Plugin
> Issue Type: New Feature
> Components: prepare
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> In case that the original {{project.scm}} section contains a tag element
> (e.g. with value "trunk") this is removed during prepare for the next
> snapshot version. The tagged/release version contains the properly adjusted
> tag element.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-release] michael-o opened a new pull request, #157: [MRELEASE-1108] Upgrade Maven SCM to 2.0.0-M3
michael-o opened a new pull request, #157: URL: https://github.com/apache/maven-release/pull/157 This closes #157 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1077) Support for prepare specific profiles
[ https://issues.apache.org/jira/browse/MRELEASE-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626070#comment-17626070 ] Michael Osipov commented on MRELEASE-1077: -- [~nielsbasjes], what about [~khmarbaise]'s proposal? > Support for prepare specific profiles > - > > Key: MRELEASE-1077 > URL: https://issues.apache.org/jira/browse/MRELEASE-1077 > Project: Maven Release Plugin > Issue Type: New Feature > Components: prepare >Affects Versions: 3.0.0-M5 >Reporter: Niels Basjes >Priority: Minor > > In my projects I like to have the latest released version of the software > shown on the website (which is also in the source tree). I do this using the > exec plugin which runs a script to write the project version in a few places. > For this purpose I propose having the option to allow specifying one or more > profiles that are activated during the prepare phase. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRELEASE-1108) Upgrade Maven SCM to 2.0.0-M3
Michael Osipov created MRELEASE-1108: Summary: Upgrade Maven SCM to 2.0.0-M3 Key: MRELEASE-1108 URL: https://issues.apache.org/jira/browse/MRELEASE-1108 Project: Maven Release Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.0.0-M7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626068#comment-17626068 ] Michael Osipov commented on MRELEASE-1103: -- Please bisect down to the change. > decryption of server password in settings.xml failed (works with 2.5.3) > --- > > Key: MRELEASE-1103 > URL: https://issues.apache.org/jira/browse/MRELEASE-1103 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M6 >Reporter: Robert Seidel >Priority: Blocker > > A server section was defined in the settings.xml at > with id, username and password to connect to a > Bitbucket server. > In the pom.xml the id was referenced in the properties via project.scm.id. > With 2.5.3 the build is running fine, but with 3.0.06-M6 the following > happens: > *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be > activated because it does not exist. > *11:35:40* [INFO] 11/17 prepare:scm-commit-release > *11:35:40* [INFO] Checking in modified POMs... > *11:35:40* [WARNING] Failed to decrypt password/passphrase for server > bitbucket-prod, using auth token as is: decrypt failed > and in the aftermath: > *11:35:41* [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) > on project ExamplePom: Unable to commit files > *11:35:41* [ERROR] Provider message: > *11:35:41* [ERROR] The git-push command failed. > *11:35:41* [ERROR] Command output: > *11:35:41* [ERROR] fatal: Authentication failed for > '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]' > > JDK used was Adoptium 17 (but with 11 the same problem occured). > Maven used was 3.8.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7378) neither the Core IT link in PR template nor contributor's guide tells new contributors how to run Core IT
[ https://issues.apache.org/jira/browse/MNG-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626054#comment-17626054 ] Hudson commented on MNG-7378: - Build failed in Jenkins: Maven » Maven TLP » maven » PR-849 #6 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-849/6/ > neither the Core IT link in PR template nor contributor's guide tells new > contributors how to run Core IT > - > > Key: MNG-7378 > URL: https://issues.apache.org/jira/browse/MNG-7378 > Project: Maven > Issue Type: Bug >Reporter: Jeff Hodges >Assignee: Maarten Mulders >Priority: Major > > There's a checkbox in the new pull request template for the maven repo that > says the contributor should run the Core ITs. > However, the page it links to doesn't say where to find them and the obvious > thing to do (running `mvn clean test -Prun-its` in the maven repo proper) > doesn't work because there's no `run-its` profile. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-help-plugin] mthmulders closed pull request #77: Fix dead link to Github PR documentation
mthmulders closed pull request #77: Fix dead link to Github PR documentation URL: https://github.com/apache/maven-help-plugin/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-438) Parameter description should be taken from annotated item
[ https://issues.apache.org/jira/browse/MPLUGIN-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626052#comment-17626052 ] Hudson commented on MPLUGIN-438: Build succeeded in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #78 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/78/ > Parameter description should be taken from annotated item > - > > Key: MPLUGIN-438 > URL: https://issues.apache.org/jira/browse/MPLUGIN-438 > Project: Maven Plugin Tools > Issue Type: Bug >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > When we have declared both - field and setter method for field - parameter > description should be taken from item with @Parameter annotation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPLUGIN-437) Plugin generator generation fails when the parent class comes from a different project
[ https://issues.apache.org/jira/browse/MPLUGIN-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPLUGIN-437. --- Resolution: Fixed PR merged - so I assume that can be closed. > Plugin generator generation fails when the parent class comes from a > different project > -- > > Key: MPLUGIN-437 > URL: https://issues.apache.org/jira/browse/MPLUGIN-437 > Project: Maven Plugin Tools > Issue Type: Task >Affects Versions: 3.7.0 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-438) Parameter description should be taken from annotated item
[ https://issues.apache.org/jira/browse/MPLUGIN-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626050#comment-17626050 ] ASF GitHub Bot commented on MPLUGIN-438: slawekjaranowski merged PR #168: URL: https://github.com/apache/maven-plugin-tools/pull/168 > Parameter description should be taken from annotated item > - > > Key: MPLUGIN-438 > URL: https://issues.apache.org/jira/browse/MPLUGIN-438 > Project: Maven Plugin Tools > Issue Type: Bug >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > When we have declared both - field and setter method for field - parameter > description should be taken from item with @Parameter annotation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPLUGIN-438) Parameter description should be taken from annotated item
[ https://issues.apache.org/jira/browse/MPLUGIN-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPLUGIN-438. --- Resolution: Fixed > Parameter description should be taken from annotated item > - > > Key: MPLUGIN-438 > URL: https://issues.apache.org/jira/browse/MPLUGIN-438 > Project: Maven Plugin Tools > Issue Type: Bug >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > When we have declared both - field and setter method for field - parameter > description should be taken from item with @Parameter annotation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] slawekjaranowski merged pull request #168: [MPLUGIN-438] Parameter description should be taken from annotated item
slawekjaranowski merged PR #168: URL: https://github.com/apache/maven-plugin-tools/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7587) Update sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MNG-7587:
-
Description:
Version 0.3.5 (inherited from
https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
to support up to Java 14).
Given that Java 19 is the most recent one today Maven needs a newer version of
{{sisu.inject}} to fully support newer Java bytecode than for Java 14.
was:
The version used in version 0.3.5 (inherited from
https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
in both Maven 4 and 3.9 of sisu.inject ships with ASM 5.0.2 relaxed in
https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
to support up to Java 14.
Given that Java 19 is the most recent one today Maven needs a newer version of
sisu.inject to fully support newer Java bytecode than for Java 14.
> Update sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.9.0-candidate
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-surefire] MrFix93 opened a new pull request, #574: [SUREFIRE-1887] Trim stacktraces to include relevant lines
MrFix93 opened a new pull request, #574: URL: https://github.com/apache/maven-surefire/pull/574 Following issue [SUREFIRE-1887](https://issues.apache.org/jira/browse/SUREFIRE-1887), this PR features an improved version of [`trimStackTrace`](https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace). With this implementation a trimmed stacktrace not only consist of the element(s) in the test class, but extends the stacktrace to include methods calls leading up to the test method. Before (with `trimStackTrace` = true):  After (with `trimStackTrace` = true):  After releasing and collecting feedback, we propose to make `trimStackTrace` to be enabled by default. This would greatly reduce the stacktraces and thereby the footprint of build output. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-help-plugin] mthmulders commented on a diff in pull request #76: [MPH-168] effective-pom should support multi-module project
mthmulders commented on code in PR #76:
URL: https://github.com/apache/maven-help-plugin/pull/76#discussion_r1008690718
##
src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java:
##
@@ -140,24 +161,73 @@ public void execute()
}
String effectivePom = prettyFormat( w.toString(), encoding, false );
+effectivePom = prettyFormatVerbose( effectivePom );
+reportEffectivePom( effectivePom, output );
+}
+
+private void generateIndividualEffectivePom() throws MojoExecutionException
+{
+String encoding = project.getModel().getModelEncoding();
+if ( shouldWriteAllEffectivePOMsInReactor() )
+{
+// outer root element
+for ( MavenProject subProject : projects )
+{
+StringWriter w = new StringWriter();
+XMLWriter writer =
+getPrettyPrintXMLWriterForEffectivePom( w, encoding );
+writeHeader( writer );
+writeEffectivePom( subProject, writer );
+String effectivePom = prettyFormat( w.toString(), encoding,
false );
+effectivePom = prettyFormatVerbose( effectivePom );
+File effectiveOutput = new File(
subProject.getBuild().getDirectory() + "/effective.pom.xml" );
+reportEffectivePom( effectivePom, effectiveOutput );
+}
+}
+else
+{
+StringWriter w = new StringWriter();
+XMLWriter writer =
+getPrettyPrintXMLWriterForEffectivePom( w, encoding );
+writeHeader( writer );
+writeEffectivePom( project, writer );
+String effectivePom = prettyFormat( w.toString(), encoding, false
);
+effectivePom = prettyFormatVerbose( effectivePom );
+File effectiveOutput = new File( project.getBuild().getDirectory()
+ "/effective.pom.xml" );
+reportEffectivePom( effectivePom, effectiveOutput );
+}
+}
+
+private String prettyFormatVerbose( String effectivePom )
+{
if ( verbose )
{
// tweak location tracking comment, that are put on a separate
line by pretty print
effectivePom = effectivePom.replaceAll(
[jira] [Commented] (MNG-7564) Potential NPE in MavenMetadataSource
[
https://issues.apache.org/jira/browse/MNG-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626044#comment-17626044
]
Hudson commented on MNG-7564:
-
Build failed in Jenkins: Maven » Maven TLP » maven » master #120
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/120/
> Potential NPE in MavenMetadataSource
>
>
> Key: MNG-7564
> URL: https://issues.apache.org/jira/browse/MNG-7564
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Maarten Mulders
>Priority: Major
> Labels: up-for-grabs
>
> In here:
> https://github.com/apache/maven/blob/cb54aa429d9e63bf78c4c808898fbef1cc01ff33/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java#L198-L203
> {{LegacySupport#getSession()}} can be {{null}}, but never tested. If {{null}}
> an empty list should be returned.
> This was indirectly found by [~gnodet].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MNG-7564) Potential NPE in MavenMetadataSource
[
https://issues.apache.org/jira/browse/MNG-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Mulders resolved MNG-7564.
--
Resolution: Fixed
Fixed in
[{{bc8c6be}}|https://github.com/apache/maven/commit/bc8c6be269a97126dc13005c494d883f6713d6a6].
> Potential NPE in MavenMetadataSource
>
>
> Key: MNG-7564
> URL: https://issues.apache.org/jira/browse/MNG-7564
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Maarten Mulders
>Priority: Major
> Labels: up-for-grabs
>
> In here:
> https://github.com/apache/maven/blob/cb54aa429d9e63bf78c4c808898fbef1cc01ff33/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java#L198-L203
> {{LegacySupport#getSession()}} can be {{null}}, but never tested. If {{null}}
> an empty list should be returned.
> This was indirectly found by [~gnodet].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7564) Potential NPE in MavenMetadataSource
[
https://issues.apache.org/jira/browse/MNG-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626041#comment-17626041
]
ASF GitHub Bot commented on MNG-7564:
-
mthmulders commented on PR #857:
URL: https://github.com/apache/maven/pull/857#issuecomment-1295811373
Thanks a lot for your contribution, @AbdelHajou!
> Potential NPE in MavenMetadataSource
>
>
> Key: MNG-7564
> URL: https://issues.apache.org/jira/browse/MNG-7564
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Maarten Mulders
>Priority: Major
> Labels: up-for-grabs
>
> In here:
> https://github.com/apache/maven/blob/cb54aa429d9e63bf78c4c808898fbef1cc01ff33/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java#L198-L203
> {{LegacySupport#getSession()}} can be {{null}}, but never tested. If {{null}}
> an empty list should be returned.
> This was indirectly found by [~gnodet].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7564) Potential NPE in MavenMetadataSource
[
https://issues.apache.org/jira/browse/MNG-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626040#comment-17626040
]
ASF GitHub Bot commented on MNG-7564:
-
mthmulders closed pull request #857: [MNG-7564] Check whether session is null
when generating metadata
URL: https://github.com/apache/maven/pull/857
> Potential NPE in MavenMetadataSource
>
>
> Key: MNG-7564
> URL: https://issues.apache.org/jira/browse/MNG-7564
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Maarten Mulders
>Priority: Major
> Labels: up-for-grabs
>
> In here:
> https://github.com/apache/maven/blob/cb54aa429d9e63bf78c4c808898fbef1cc01ff33/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java#L198-L203
> {{LegacySupport#getSession()}} can be {{null}}, but never tested. If {{null}}
> an empty list should be returned.
> This was indirectly found by [~gnodet].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] mthmulders commented on pull request #857: [MNG-7564] Check whether session is null when generating metadata
mthmulders commented on PR #857: URL: https://github.com/apache/maven/pull/857#issuecomment-1295811373 Thanks a lot for your contribution, @AbdelHajou! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders closed pull request #857: [MNG-7564] Check whether session is null when generating metadata
mthmulders closed pull request #857: [MNG-7564] Check whether session is null when generating metadata URL: https://github.com/apache/maven/pull/857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7587) Update sisu to a version supporting at least Java 17
Konrad Windszus created MNG-7587: Summary: Update sisu to a version supporting at least Java 17 Key: MNG-7587 URL: https://issues.apache.org/jira/browse/MNG-7587 Project: Maven Issue Type: Improvement Components: Core Reporter: Konrad Windszus Fix For: 3.9.0-candidate The version used in version 0.3.5 (inherited from https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934) in both Maven 4 and 3.9 of sisu.inject ships with ASM 5.0.2 relaxed in https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa to support up to Java 14. Given that Java 19 is the most recent one today Maven needs a newer version of sisu.inject to fully support newer Java bytecode than for Java 14. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-357) Upgrade to PMD 6.51.0
[ https://issues.apache.org/jira/browse/MPMD-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626039#comment-17626039 ] Hudson commented on MPMD-357: - Build succeeded in Jenkins: Maven » Maven TLP » maven-pmd-plugin » master #66 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-pmd-plugin/job/master/66/ > Upgrade to PMD 6.51.0 > - > > Key: MPMD-357 > URL: https://issues.apache.org/jira/browse/MPMD-357 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.20.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPMD-357) Upgrade to PMD 6.51.0
[ https://issues.apache.org/jira/browse/MPMD-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel closed MPMD-357. --- > Upgrade to PMD 6.51.0 > - > > Key: MPMD-357 > URL: https://issues.apache.org/jira/browse/MPMD-357 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.20.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MPMD-357) Upgrade to PMD 6.51.0
[ https://issues.apache.org/jira/browse/MPMD-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel resolved MPMD-357. - Resolution: Fixed > Upgrade to PMD 6.51.0 > - > > Key: MPMD-357 > URL: https://issues.apache.org/jira/browse/MPMD-357 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.20.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-pmd-plugin] adangel merged pull request #100: [MPMD-357] - Upgrade to PMD 6.51.0
adangel merged PR #100: URL: https://github.com/apache/maven-pmd-plugin/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SUREFIRE-1887) Test Failures should not dump stack.
[ https://issues.apache.org/jira/browse/SUREFIRE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626034#comment-17626034 ] Peter Wessels edited comment on SUREFIRE-1887 at 10/29/22 11:02 AM: After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. The implementation of this feature however, trims too much lines. To be valuable for users, the lines from the cause of the failure to the testcase are relevant. Example: trimStackTrace=true !image-2022-10-29-12-56-00-008.png|width=595,height=67! trimStackTrace=false !image-2022-10-29-12-56-10-482.png|width=1084,height=779! We propose to change the implementation of this feature to include more relevant lines and make this option enabled by default. Our premature implementation generates the following stacktrace: !image-2022-10-29-13-01-36-151.png|width=586,height=97! We included our minimal test project. was (Author: JIRAUSER297668): After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. The implementation of this feature however, trims too much lines. To be valuable for users, the lines from the cause of the failure to the testcase are relevant. Example: trimStackTrace=true !image-2022-10-29-12-56-00-008.png|width=595,height=67! trimStackTrace=false !image-2022-10-29-12-56-10-482.png|width=1084,height=779! We propose to change the implementation of this feature to include more relevant lines and make enable this option by default. Our premature implementation generates the following stacktrace: !image-2022-10-29-13-01-36-151.png|width=586,height=97! We included our minimal test project. > Test Failures should not dump stack. > - > > Key: SUREFIRE-1887 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1887 > Project: Maven Surefire > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Maarten Mulders >Priority: Major > Attachments: image-2022-10-29-12-56-00-008.png, > image-2022-10-29-12-56-10-482.png, image-2022-10-29-12-57-02-825.png, > image-2022-10-29-13-01-36-151.png, maven-surefire-test-project.zip > > > Typical failing test output from the Maven surefire plugin dumps a lot of > internal state. This is incorrect. > > The purpose of the surefire plugin is to run the user's tests. These tests > are expected to fail much of the time. This a normal state. The test failure > should be reported, but this is in no way a failure of surefire itself. There > is no reason surefire should print its own stack. Indeed, this simply > obscures the real failure in the user's own code. > > ``` > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test > (default-test) on project dependencies: There are test failures. > Please refer to > /home/runner/work/cloud-opensource-java/cloud-opensource-java/dependencies/target/surefire-reports > for the individual test results. > Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump > and [date].dumpstream. > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:215) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced >
[jira] [Comment Edited] (SUREFIRE-1887) Test Failures should not dump stack.
[ https://issues.apache.org/jira/browse/SUREFIRE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626034#comment-17626034 ] Peter Wessels edited comment on SUREFIRE-1887 at 10/29/22 11:01 AM: After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. The implementation of this feature however, trims too much lines. To be valuable for users, the lines from the cause of the failure to the testcase are relevant. Example: trimStackTrace=true !image-2022-10-29-12-56-00-008.png|width=595,height=67! trimStackTrace=false !image-2022-10-29-12-56-10-482.png|width=1084,height=779! We propose to change the implementation of this feature to include more relevant lines and make enable this option by default. Our premature implementation generates the following stacktrace: !image-2022-10-29-13-01-36-151.png|width=586,height=97! We included our minimal test project. was (Author: JIRAUSER297668): After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. The implementation of this feature however, trims too much lines. To be valuable for users, the lines from the cause of the failure to the testcase are relevant. Example: trimStackTrace=true !image-2022-10-29-12-56-00-008.png! trimStackTrace=false !image-2022-10-29-12-56-10-482.png! We propose to change the implementation of this feature to include more relevant lines and make enable this option by default. Our premature implementation generates the following stacktrace: !image-2022-10-29-12-57-02-825.png! We included our minimal test project. > Test Failures should not dump stack. > - > > Key: SUREFIRE-1887 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1887 > Project: Maven Surefire > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Maarten Mulders >Priority: Major > Attachments: image-2022-10-29-12-56-00-008.png, > image-2022-10-29-12-56-10-482.png, image-2022-10-29-12-57-02-825.png, > image-2022-10-29-13-01-36-151.png, maven-surefire-test-project.zip > > > Typical failing test output from the Maven surefire plugin dumps a lot of > internal state. This is incorrect. > > The purpose of the surefire plugin is to run the user's tests. These tests > are expected to fail much of the time. This a normal state. The test failure > should be reported, but this is in no way a failure of surefire itself. There > is no reason surefire should print its own stack. Indeed, this simply > obscures the real failure in the user's own code. > > ``` > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test > (default-test) on project dependencies: There are test failures. > Please refer to > /home/runner/work/cloud-opensource-java/cloud-opensource-java/dependencies/target/surefire-reports > for the individual test results. > Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump > and [date].dumpstream. > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:215) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:289) > at
[jira] [Comment Edited] (SUREFIRE-1887) Test Failures should not dump stack.
[ https://issues.apache.org/jira/browse/SUREFIRE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626034#comment-17626034 ] Peter Wessels edited comment on SUREFIRE-1887 at 10/29/22 11:00 AM: After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. The implementation of this feature however, trims too much lines. To be valuable for users, the lines from the cause of the failure to the testcase are relevant. Example: trimStackTrace=true !image-2022-10-29-12-56-00-008.png! trimStackTrace=false !image-2022-10-29-12-56-10-482.png! We propose to change the implementation of this feature to include more relevant lines and make enable this option by default. Our premature implementation generates the following stacktrace: !image-2022-10-29-12-57-02-825.png! We included our minimal test project. was (Author: JIRAUSER297668): After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. The implementation of this feature however, trims too much lines. To be valuable for users, more lines are necessary. We propose to change the implementation of this feature to include more relevant lines and make enable this option by default. > Test Failures should not dump stack. > - > > Key: SUREFIRE-1887 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1887 > Project: Maven Surefire > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Maarten Mulders >Priority: Major > Attachments: image-2022-10-29-12-56-00-008.png, > image-2022-10-29-12-56-10-482.png, image-2022-10-29-12-57-02-825.png, > maven-surefire-test-project.zip > > > Typical failing test output from the Maven surefire plugin dumps a lot of > internal state. This is incorrect. > > The purpose of the surefire plugin is to run the user's tests. These tests > are expected to fail much of the time. This a normal state. The test failure > should be reported, but this is in no way a failure of surefire itself. There > is no reason surefire should print its own stack. Indeed, this simply > obscures the real failure in the user's own code. > > ``` > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test > (default-test) on project dependencies: There are test failures. > Please refer to > /home/runner/work/cloud-opensource-java/cloud-opensource-java/dependencies/target/surefire-reports > for the individual test results. > Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump > and [date].dumpstream. > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:215) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at
[jira] [Comment Edited] (SUREFIRE-1887) Test Failures should not dump stack.
[ https://issues.apache.org/jira/browse/SUREFIRE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626034#comment-17626034 ] Peter Wessels edited comment on SUREFIRE-1887 at 10/29/22 10:55 AM: After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. The implementation of this feature however, trims too much lines. To be valuable for users, more lines are necessary. We propose to change the implementation of this feature to include more relevant lines and make enable this option by default. was (Author: JIRAUSER297668): After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. However, this option is disabled by default. Which makes sense because often users needs more information than the lines within the test. We propose to change the implementation of this feature to include more relevant lines and make enable this option by default. > Test Failures should not dump stack. > - > > Key: SUREFIRE-1887 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1887 > Project: Maven Surefire > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Maarten Mulders >Priority: Major > > Typical failing test output from the Maven surefire plugin dumps a lot of > internal state. This is incorrect. > > The purpose of the surefire plugin is to run the user's tests. These tests > are expected to fail much of the time. This a normal state. The test failure > should be reported, but this is in no way a failure of surefire itself. There > is no reason surefire should print its own stack. Indeed, this simply > obscures the real failure in the user's own code. > > ``` > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test > (default-test) on project dependencies: There are test failures. > Please refer to > /home/runner/work/cloud-opensource-java/cloud-opensource-java/dependencies/target/surefire-reports > for the individual test results. > Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump > and [date].dumpstream. > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:215) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.apache.maven.wrapper.BootstrapMainStarter.start > (BootstrapMainStarter.java:39) > at org.apache.maven.wrapper.WrapperExecutor.execute > (WrapperExecutor.java:122) > at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:61) > Caused by: org.apache.maven.plugin.MojoFailureException: There are test > failures. >
[jira] [Updated] (SUREFIRE-1887) Test Failures should not dump stack.
[ https://issues.apache.org/jira/browse/SUREFIRE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Wessels updated SUREFIRE-1887: Attachment: (was: Screenshot 2022-10-29 at 12.50.30.png) > Test Failures should not dump stack. > - > > Key: SUREFIRE-1887 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1887 > Project: Maven Surefire > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Maarten Mulders >Priority: Major > > Typical failing test output from the Maven surefire plugin dumps a lot of > internal state. This is incorrect. > > The purpose of the surefire plugin is to run the user's tests. These tests > are expected to fail much of the time. This a normal state. The test failure > should be reported, but this is in no way a failure of surefire itself. There > is no reason surefire should print its own stack. Indeed, this simply > obscures the real failure in the user's own code. > > ``` > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test > (default-test) on project dependencies: There are test failures. > Please refer to > /home/runner/work/cloud-opensource-java/cloud-opensource-java/dependencies/target/surefire-reports > for the individual test results. > Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump > and [date].dumpstream. > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:215) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.apache.maven.wrapper.BootstrapMainStarter.start > (BootstrapMainStarter.java:39) > at org.apache.maven.wrapper.WrapperExecutor.execute > (WrapperExecutor.java:122) > at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:61) > Caused by: org.apache.maven.plugin.MojoFailureException: There are test > failures. > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-help-plugin] Giovds opened a new pull request, #77: Fix dead link to Github PR documentation
Giovds opened a new pull request, #77: URL: https://github.com/apache/maven-help-plugin/pull/77 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPH) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MPH-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MPH-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SUREFIRE-1887) Test Failures should not dump stack.
[ https://issues.apache.org/jira/browse/SUREFIRE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626034#comment-17626034 ] Peter Wessels edited comment on SUREFIRE-1887 at 10/29/22 10:43 AM: After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. However, this option is disabled by default. Which makes sense because often users needs more information than the lines within the test. We propose to change the implementation of this feature to include more relevant lines and make enable this option by default. was (Author: JIRAUSER297668): After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. However, this option is disabled by default. Which makes sense because often users needs more information than the lines within the test. We propose to improve to change the implementation of this feature to include more relevant lines and make enable this option by default. > Test Failures should not dump stack. > - > > Key: SUREFIRE-1887 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1887 > Project: Maven Surefire > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Maarten Mulders >Priority: Major > > Typical failing test output from the Maven surefire plugin dumps a lot of > internal state. This is incorrect. > > The purpose of the surefire plugin is to run the user's tests. These tests > are expected to fail much of the time. This a normal state. The test failure > should be reported, but this is in no way a failure of surefire itself. There > is no reason surefire should print its own stack. Indeed, this simply > obscures the real failure in the user's own code. > > ``` > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test > (default-test) on project dependencies: There are test failures. > Please refer to > /home/runner/work/cloud-opensource-java/cloud-opensource-java/dependencies/target/surefire-reports > for the individual test results. > Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump > and [date].dumpstream. > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:215) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.apache.maven.wrapper.BootstrapMainStarter.start > (BootstrapMainStarter.java:39) > at org.apache.maven.wrapper.WrapperExecutor.execute > (WrapperExecutor.java:122) > at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:61) > Caused by: org.apache.maven.plugin.MojoFailureException:
[jira] [Commented] (MNG-7473) Backport Maven BOM to Maven 3.9.x
[ https://issues.apache.org/jira/browse/MNG-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626035#comment-17626035 ] ASF GitHub Bot commented on MNG-7473: - kwin commented on PR #859: URL: https://github.com/apache/maven/pull/859#issuecomment-1295799982 Maybe we can add another artifact then and call it maven-core-classloader-dep-mgmt. I don’t care about naming here, I primarily care about better support for plugin developers. > Backport Maven BOM to Maven 3.9.x > - > > Key: MNG-7473 > URL: https://issues.apache.org/jira/browse/MNG-7473 > Project: Maven > Issue Type: Task > Components: POM >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.0-candidate > > > It will ease lives of plugin developers a lot. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] kwin commented on pull request #859: [3.9.x] [MNG-7473] Backport Maven BOM to 3.9.0
kwin commented on PR #859: URL: https://github.com/apache/maven/pull/859#issuecomment-1295799982 Maybe we can add another artifact then and call it maven-core-classloader-dep-mgmt. I don’t care about naming here, I primarily care about better support for plugin developers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1887) Test Failures should not dump stack.
[ https://issues.apache.org/jira/browse/SUREFIRE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626034#comment-17626034 ] Peter Wessels commented on SUREFIRE-1887: - After some investigation, we found that [trimStackTrace|https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] can be used to shorten the stacktrace. However, this option is disabled by default. Which makes sense because often users needs more information than the lines within the test. We propose to improve to change the implementation of this feature to include more relevant lines and make enable this option by default. > Test Failures should not dump stack. > - > > Key: SUREFIRE-1887 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1887 > Project: Maven Surefire > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Maarten Mulders >Priority: Major > > Typical failing test output from the Maven surefire plugin dumps a lot of > internal state. This is incorrect. > > The purpose of the surefire plugin is to run the user's tests. These tests > are expected to fail much of the time. This a normal state. The test failure > should be reported, but this is in no way a failure of surefire itself. There > is no reason surefire should print its own stack. Indeed, this simply > obscures the real failure in the user's own code. > > ``` > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test > (default-test) on project dependencies: There are test failures. > Please refer to > /home/runner/work/cloud-opensource-java/cloud-opensource-java/dependencies/target/surefire-reports > for the individual test results. > Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump > and [date].dumpstream. > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:215) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.apache.maven.wrapper.BootstrapMainStarter.start > (BootstrapMainStarter.java:39) > at org.apache.maven.wrapper.WrapperExecutor.execute > (WrapperExecutor.java:122) > at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:61) > Caused by: org.apache.maven.plugin.MojoFailureException: There are test > failures. > ``` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7473) Backport Maven BOM to Maven 3.9.x
[ https://issues.apache.org/jira/browse/MNG-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626033#comment-17626033 ] ASF GitHub Bot commented on MNG-7473: - cstamas commented on PR #859: URL: https://github.com/apache/maven/pull/859#issuecomment-1295798971 @gnodet I also think leaving out maven-compat makes no sense (at least for 3.x line) @kwin I completely agree, but was down voted for doing that by arguments "it is not BOM"... In essence, I wanted to backport what master/4.x has, would merely add maven-compat and later we can see for the rest... > Backport Maven BOM to Maven 3.9.x > - > > Key: MNG-7473 > URL: https://issues.apache.org/jira/browse/MNG-7473 > Project: Maven > Issue Type: Task > Components: POM >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.0-candidate > > > It will ease lives of plugin developers a lot. -- This message was sent by Atlassian Jira (v8.20.10#820010)
